subject:"\[Koha\-bugs\] \[Bug 10937\] Option to hide and group itemtypes from advanced search"

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-10-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||15092


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092
[Bug 15092] item type descriptions not showing if no logo
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-10-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||15093


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093
[Bug 15093] item type groups not saving
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #65 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Ahmed and Philippe!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #64 from Genevieve  ---
Created attachment 42323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42323=edit
Bug 10937 - Fix Seach Type in Advanced Search

In order to see the checkboxes of the Collection and Shelving location of the
advanced search, the if changed so that only the Itemtypes will go through the
previous if

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-07-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #61 from Blou philippe.blo...@inlibro.com ---
All those comments are perfectly valid.  I'll correct them all (the use Dumper
are most probably something forgotten by the dev, no excuse).  

Regarding the name, which one would you prefer
ITYPECAT or ITEMTYPECAT? Or a bit different: ITYPEGROUP

If no response, I'll go with ITYPEGROUP

(of course, I'll do a patch's patch. I'm not messing with a passed qa)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-07-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #62 from Blou philippe.blo...@inlibro.com ---
Created attachment 40884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40884action=edit
Bug 10937 - cleanup and rename DOCTYPECAT to ITEMTYPECAT

- Item and not Document is the word used throughout Koha.
- Moved the updates to an atomic update
- changed searchcategory from varchar(20) to (80)
- cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-07-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #63 from Blou philippe.blo...@inlibro.com ---
Since the word category was used throughout the patch, I kept it instead of
using group.

updatedatabase.pl doesn't apply anymore with the first patch, but since it's
PassedQA, I'm not touching it.  The second patch puts it all in atomicupdate,
to help in case it all falls apart and someone recreate a new squashed patch
from 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-07-08 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #60 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 36856
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36856
[PASSED QA] Bug 10937 - Option to hide and group itemtypes from advanced search

Review of attachment 36856:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=36856)
-

I talked to Tomas about this a while ago and finally got around to put my
concerns in writing. Leaving to Tomas for final decision as this is PQA right
now.

::: C4/Koha.pm
@@ +33,2 @@
  use DBI qw(:sql_types);
 + use Data::Dumper;

This here doesn't look quite right, first you have: 
use autouse 'Data::cselectall_arrayref' = qw(Dumper);
then an additional
use Data::Dumper;
Can you explain?

@@ +279,5 @@
 +$categories = GetItemTypesCategorized();
 +
 +Returns a hashref containing search categories.
 +A search category will be put in the hash if at least one of its itemtypes 
 is visible in OPAC.
 +The categories must be part of Authorized Values (DOCTYPECAT)

I am not happy with the name: DOCTYPECAT. If this is to help group itemtypes,
why not name it accordingly? ITYPECAT or ITEMTYPECAT? Or a bit different:
ITYPEGROUP?

::: installer/data/mysql/kohastructure.sql
@@ +1276,5 @@
checkinmsg VARCHAR(255), -- message that is displayed when an item with 
 the given item type is checked in
checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) 
 for the checkinmsg, can be alert or message
sip_media_type VARCHAR(3) DEFAULT NULL, -- SIP2 protocol media type for 
 this itemtype
 +  hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the 
 search options in OPAC
 +  searchcategory varchar(20) default NULL, -- Group this item type with 
 others with the same value on OPAC search options

I think this is used to store the authorised value code picked from the
authorized value DOCTYPECAT category. If I am not wrong, they should match in
length to avoid problems:
authorised_values.authorised_value is varchar(80)

::: installer/data/mysql/updatedatabase.pl
@@ +9838,5 @@
 +$dbh-do(q{
 +ALTER TABLE itemtypes
 +ADD hideinopac TINYINT(1) NOT NULL DEFAULT 0
 +  AFTER sip_media_type,
 +ADD searchcategory VARCHAR(20) DEFAULT NULL

See above!

::: t/db_dependent/Koha.t
@@ +7,4 @@
  use warnings;
  use C4::Context;
  use Koha::DateUtils qw(dt_from_string);
 +use Data::Dumper;

I am not sure if this is needed here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36240|0   |1
is obsolete||

--- Comment #59 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36856
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36856action=edit
[PASSED QA] Bug 10937 - Option to hide and group itemtypes from advanced search

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
  -- all tests should pass.
  4) run ./installer/data/mysql/updatedatabase.pl to add the
  two columns to itemtypes
  -- Does a meaningful message get printed?
  Are the columns added?
  DESCRIBE itemtypes; should list hideinopac and searchcategory.
  5) You need to add a category to group your item types:
  a) In Intranet/Koha Admin/Authorized values,
  select DOCTYPECAT in the 'Show category:' dropdown
  i) If you do not have a DOCTYPECAT category, create one.
  b) Click button New authorized value for DOCTYPECAT
  c) Enter
  Authorized value: HARDWARE
  Description : Hardware
  Description (OPAC): Hardware
  6) Group your items under that new category
  a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
  7) Select at least one item to be hidden in the OPAC search
  a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.
  8) Go test your modifications
  a) Go to OPAC/Adv search.
  b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
  c) Validate that new item type Hardware does appear instead.
  d) Select item Hardware, start Search.
  ) Validate returned items are the of the two types that were grouped into the
Hardware category in step 4.

  Sponsored-by: Vanier college

Signed-off-by: Nick n...@quecheelibrary.org

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #58 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #56)
 Looks good to me too.
 Kyle could you run perl -wc Koha.pm and tell us what is the error/warning?
 It's certainly related to the perl version (5.20 here).

Agreed, I'm running perl v5.10.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Blocks||13787

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #57 from Magnus Enger mag...@enger.priv.no ---
It might be a good idea to QA bug 13787 at the same time as this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks|13787   |
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13787

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com ---
Looks good to me too.
Kyle could you run perl -wc Koha.pm and tell us what is the error/warning?
It's certainly related to the perl version (5.20 here).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-04 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #55 from simith.dolive...@inlibro.com ---
I got that when I ran QA :

 OKC4/Koha.pm
   OK  pod
   OK  valid
   OK  critic
   OK  forbidden patterns

 OKadmin/authorised_values.pl
   OK  pod
   OK  valid
   OK  critic
   OK  forbidden patterns

 OKadmin/itemtypes.pl
   OK  pod
   OK  forbidden patterns
   OK  valid
   OK  critic

 OKinstaller/data/mysql/updatedatabase.pl
   OK  forbidden patterns
   OK  valid
   OK  critic
   OK  pod

 OKopac/opac-search.pl
   OK  critic
   OK  valid
   OK  forbidden patterns
   OK  pod

 OKt/db_dependent/Koha.t
   OK  valid
   OK  critic
   OK  forbidden patterns
   OK  pod

 OKkoha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
   OK  valid_template
   OK  forbidden patterns
   OK  tt_valid

 OKkoha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
   OK  tt_valid
   OK  forbidden patterns
   OK  valid_template


Can anyone else run QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-03-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #54 from Kyle M Hall k...@bywatersolutions.com ---
 FAILC4/Koha.pm
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid


 FAILadmin/authorised_values.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid


 FAILadmin/itemtypes.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid


 OKinstaller/data/mysql/updatedatabase.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   OK  valid

 FAILopac/opac-search.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid


 FAILt/db_dependent/Koha.t
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #36191|0   |1
is obsolete||

--- Comment #52 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 36240
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36240action=edit
Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master.

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
  -- all tests should pass.
  4) run ./installer/data/mysql/updatedatabase.pl to add the
  two columns to itemtypes
  -- Does a meaningful message get printed?
  Are the columns added?
  DESCRIBE itemtypes; should list hideinopac and searchcategory.
  5) You need to add a category to group your item types:
  a) In Intranet/Koha Admin/Authorized values,
  select DOCTYPECAT in the 'Show category:' dropdown
  i) If you do not have a DOCTYPECAT category, create one.
  b) Click button New authorized value for DOCTYPECAT
  c) Enter
  Authorized value: HARDWARE
  Description : Hardware
  Description (OPAC): Hardware
  6) Group your items under that new category
  a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
  7) Select at least one item to be hidden in the OPAC search
  a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.
  8) Go test your modifications
  a) Go to OPAC/Adv search.
  b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
  c) Validate that new item type Hardware does appear instead.
  d) Select item Hardware, start Search.
  ) Validate returned items are the of the two types that were grouped into the
Hardware category in step 4.

  Sponsored-by: Vanier college

Signed-off-by: Nick Clemensn...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

--- Comment #53 from Nick Clemens n...@quecheelibrary.org ---
I like this idea, but have a a small readability issue with the Hide In OPAC
description on the Modify Item type page.  

It says: 
(if checked, items of this type will be hidden as filters in OPAC's advanced
search)

I think more on the lines of:
If checked, the option to filter by items of this type will be hidden in OPAC
advanced search (item of this type will not explicitly be hidden by this
preference)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34667|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35452|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 36191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36191action=edit
Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master.

Easy conflict on updatedatabase.pl fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-02-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Brooksml je...@brookslibraryvt.org changed:

   What|Removed |Added

 CC||je...@brookslibraryvt.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Ahmed Sfayhi ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||ahmed.sfa...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #50 from Ahmed Sfayhi ahmed.sfa...@inlibro.com ---
Created attachment 35452
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35452action=edit
Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master.

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
  -- all tests should pass.
  4) run ./installer/data/mysql/updatedatabase.pl to add the
  two columns to itemtypes
  -- Does a meaningful message get printed?
  Are the columns added?
  DESCRIBE itemtypes; should list hideinopac and searchcategory.
  5) You need to add a category to group your item types:
  a) In Intranet/Koha Admin/Authorized values,
  select DOCTYPECAT in the 'Show category:' dropdown
  i) If you do not have a DOCTYPECAT category, create one.
  b) Click button New authorized value for DOCTYPECAT
  c) Enter
  Authorized value: HARDWARE
  Description : Hardware
  Description (OPAC): Hardware
  6) Group your items under that new category
  a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
  7) Select at least one item to be hidden in the OPAC search
  a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.
  8) Go test your modifications
  a) Go to OPAC/Adv search.
  b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
  c) Validate that new item type Hardware does appear instead.
  d) Select item Hardware, start Search.
  ) Validate returned items are the of the two types that were grouped into the
Hardware category in step 4.

  Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am not sure if the change to the schema files is mandatory yet, but if you do
it, please put it in a separate patch to avoid conflicts.
http://wiki.koha-community.org/wiki/Database_updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch needs a little bit more work to be readable by QAers.
There is not decent commit message, please read
http://wiki.koha-community.org/wiki/Commit_messages

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 34667
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34667
[Signed-off] Bug 10947 - Grouped ItemTypes - Patch should apply properly on
latest master.

Review of attachment 34667:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=34667)
-

Quick code review.

::: C4/Koha.pm
@@ +283,5 @@
 +The categories must be part of Authorized Values (DOCTYPECAT)
 +
 +=cut
 +
 +sub GetItemTypesCategorized {

Why don't you use C4::ItemType?

@@ +287,5 @@
 +sub GetItemTypesCategorized {
 +my $dbh   = C4::Context-dbh;
 +# Order is important, so that partially hidden (some items are not 
 visible in OPAC) search
 +# categories will be visible. hideinopac=0 must be last.
 +my $query = qq|

There are no string interpolation here, limit to q||

@@ +312,5 @@
 +
 +my %itemtypes;
 +while ( my $IT = $sth-fetchrow_hashref ) {
 +$itemtypes{ $IT-{'itemtype'} } = $IT;
 +}

useless while, have a look at selectall_hashref.

@@ +324,5 @@
 +Returns the itemtype code of all itemtypes included in a searchcategory.
 +
 +=cut
 +
 +sub GetItemTypesByCategory {

Why don't you use C4::ItemType?

@@ +334,5 @@
 +$sth-execute($category);
 +
 +while ( my $data = $sth-fetchrow ) {
 +push ( @results, $data );
 +}

useless while, have a look at selectall_arrayref

::: installer/data/mysql/kohastructure.sql
@@ +1276,4 @@
checkinmsg VARCHAR(255), -- message that is displayed when an item with 
 the given item type is checked in
checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) 
 for the checkinmsg, can be alert or message
sip_media_type VARCHAR(3) DEFAULT NULL, -- SIP2 protocol media type for 
 this itemtype
 +  hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the 
 search options in OPAC

There are occurrences of hideatopac in the code, maybe it's better than
hideinopac. Need to be confirmed by English native speaker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #49 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #48)
 There are occurrences of hideatopac in the code, maybe it's better than
 hideinopac. Need to be confirmed by English native speaker.

I can see how both might be used. The idea being that something is hidden at
display time by OPAC vs. OPAC is being used an something is hidden in the
output. Personally, hide in OPAC is clearer to Canadian, Anglophone me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-24 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #44 from Marc Véron ve...@veron.ch ---
Created attachment 34667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34667action=edit
[Signed-off] Bug 10947 - Grouped ItemTypes - Patch should apply properly on
latest master.

Other patches are now obsolete, this is a squashed patch.
Merge conflicts were resolved.

Sponsored-by: Vanier college

http://bugs.koha-community.org/show_bug.cgi?id=10937

Followed test plan (comment #34), works as expected.

Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-24 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #34635|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-24 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-24 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from M. Tompsett mtomp...@hotmail.com ---
Sorry, but modifying the table structure requires a patch to Schema files.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567#c58
That was my first experience with them. Hope this helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #34419|0   |1
is obsolete||

--- Comment #43 from simith.dolive...@inlibro.com ---
Created attachment 34635
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34635action=edit
Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master.

Other patches are now obsolete, this is a squashed patch.
Merge conflicts were resolved.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-20 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #42 from Marc Véron ve...@veron.ch ---
Sorry, merge conflicts (again) with current master (3.19.00.002):

Applying: Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest
master.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
CONFLICT (content): Merge conflict in opac/opac-search.pl
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

Oh, the patch title reads:
Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. 

...but we are on Bug 10937?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #31896|0   |1
is obsolete||

--- Comment #41 from simith.dolive...@inlibro.com ---
Created attachment 34419
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34419action=edit
Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master.

Other patches are now obsolete, this is a squashed patch.
Merge conflicts were resolved.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-12-09 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #40 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
There's a problem when applying this patch on a sandbox :
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 10937:
h1Something went wrong !/h1Applying: Bug 10947 - Grouped ItemTypes - Patch
should apply properly on latest master.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Koha.pm
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
CONFLICT (delete/modify): koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
deleted in HEAD and modified in Bug 10947 - Grouped ItemTypes - Patch should
apply properly on latest master.. Version Bug 10947 - Grouped ItemTypes - Patch
should apply properly on latest master. of
koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt left in tree.
Auto-merging opac/opac-search.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 10947 - Grouped ItemTypes - Patch should apply
properly on latest master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-10-10 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-09-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

PTFS Europe Sandboxes sandbo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #30308|0   |1
is obsolete||

--- Comment #37 from PTFS Europe Sandboxes sandbo...@ptfs-europe.com ---
Created attachment 31896
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31896action=edit
Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master.

Other patches are now obsolete, this is a squashed patch.
Merge conflicts were resolved.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-09-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #38 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
The above rebase was I, just the db update conflict to allow the sandbox to
work ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-09-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #39 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 31896
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31896
Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master.

Review of attachment 31896:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=31896)
-

::: t/db_dependent/Koha.t
@@ +7,4 @@
  use warnings;
  use C4::Context;
  use Koha::DateUtils qw(dt_from_string);
 +use Data::Dumper;

Oops! Forgot to remove it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-08-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-08-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||maxime.beaul...@inlibro.com
   Assignee|philippe.blo...@inlibro.com |maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-08-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-07-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

  Attachment #28626|0   |1
is obsolete||
  Attachment #29383|0   |1
is obsolete||

--- Comment #36 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 30308
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30308action=edit
Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master.

Other patches are now obsolete, this is a squashed patch.
Merge conflicts were resolved.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-07-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #35 from M. Tompsett mtomp...@hotmail.com ---
Sorry, doesn't apply cleanly. Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-06-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #34 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 29383
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29383action=edit
Bug 10947 - Follow-up to: 'Review of attachment 28626'

C4/Koha.pm: Perldoc has been updated to better describe subroutine behaviour
and usage.
itemtypes.tt: The 'IF/ELSE' was used to distiguish between the 'ADD' and
'MODIFY' screens. It has been removed and the same 'select' is now used for
both cases.
opac-advsearch.tt (both files): I've reformatted the code to improve
readability.

CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
   -- all tests should pass.
4) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and
   searchcategory.
5) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   i) If you do not have a DOCTYPECAT category, create one.
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware
6) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category
list box, select Hardware
  - click Save changes at the bottom
7) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a
  different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of
 icons.
8) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped)
   do not appear in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were
   grouped into the Hardware category in step 4.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-06-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #31 from Blou philippe.blo...@inlibro.com ---
Created attachment 28624
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28624action=edit
Bug 10937 - Add unit tests.

Modified t/db_dependant/Koha.t to test the two new functions from C4/Koha.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-06-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #28579|0   |1
is obsolete||
  Attachment #28624|0   |1
is obsolete||

--- Comment #32 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28626
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28626action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

It's possible to hide the records and the items, but the
advanced search form is a bit trickier. It would be nice if
we could specify which itemtypes are offered as search options
in the OPAC advanced search form.

To solve this, two new columns will be added in the item type.

1) Display in OPAC
Default : Yes
Set to NO to hide and itemtype in the opac's advanced search.

2) Search category
The search category allows library to group some similar
itemtypes in a single checkbox in the opac.  The categories are
defined in an Authorized value.

For Example, itemtypes DVD, VHS could use the Video category.
Searching for Video in the OPAC would returns the DVD and VHS
items.

As C4/Koha was modified, a set of subtests were added to confirm
the changes in t/db_dependent/Koha.t. The two new routines add
a grouping functionality into the OPAC Advanced Search
Item type display area.

Initial coding by philippe.blo...@inlibro.com with
mtomp...@hotmail.com providing extra testing, patching,
squashing, and rebasing.

CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
   -- all tests should pass.
4) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and
   searchcategory.
5) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   i) If you do not have a DOCTYPECAT category, create one.
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware
6) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category
list box, select Hardware
  - click Save changes at the bottom
7) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a
  different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of
 icons.
8) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped)
   do not appear in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were
   grouped into the Hardware category in step 4.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-06-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-06-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #33 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 28626
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28626
Bug 10937 - Option to hide and group itemtypes from advanced search

Review of attachment 28626:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=28626)
-

::: C4/Koha.pm
@@ +278,5 @@
  
 +=head2 GetItemTypesCategorized
 +
 +Returns item types but grouped by category if available.
 +The categories must be part of Authorized Values (DOCTYPECAT)

The perldoc on these new functions is lacking.

@@ +320,5 @@
 +=head2 GetItemTypesByCategory
 +
 +$category = category filter
 +
 +Returns the itemtypes that are grouped into the category.

The perldoc is valid, but horrible.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ +127,5 @@
 +[% END %]
 +  /select
 +  (Options are defined as the authorized values for the DOCTYPECAT 
 category)
 +  /li
 +  [% ELSE %]

Can you explain why there is an IF/ELSE case?

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
@@ +141,5 @@
  legendLimit to any of the 
 following:/legend
  div class=row-fluid
  [% FOREACH itemtypeloo IN 
 advsearchloo.code_loop %]
 +[% IF 
 ((!itemtypeloo.searchcategory) AND (itemtypeloo.cat == 0)) OR 
 (itemtypeloo.cat == 1) %]
 +div class=span3input 
 type=checkbox id=[% itemtypeloo.ccl FILTER remove(',') %]-[% 
 itemtypeloo.number %] name=[% IF ( itemtypeloo.cat == 1 ) %]searchcat[% 
 ELSE %]limit[% END %] value=[% IF ( itemtypeloo.cat == 1 ) %][% 
 itemtypeloo.code %][% ELSE %]mc-[% itemtypeloo.ccl %]:[% itemtypeloo.code 
 %][% END %]/label for=[% itemtypeloo.ccl FILTER remove(',') %]-[% 
 itemtypeloo.number %][% UNLESS ( noItemTypeImages ) %][% IF ( 
 itemtypeloo.imageurl ) %]img border=0 src=[% itemtypeloo.imageurl %] 
 alt=[% itemtypeloo.description %] /[% END %]nbsp;[% END %]

This be some ugly code. Improve readability, please.

::: koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
@@ +187,5 @@
  table
  tr
  [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
 +[% IF ((!itemtypeloo.searchcategory) AND (itemtypeloo.cat == 0)) 
 OR (itemtypeloo.cat == 1) %]
 +tdinput type=checkbox id=[% itemtypeloo.ccl FILTER 
 remove(',') %]-[% itemtypeloo.number %] name=[% IF ( itemtypeloo.cat == 1 ) 
 %]searchcat[% ELSE %]limit[% END %] value=[% IF ( itemtypeloo.cat == 1 ) 
 %][% itemtypeloo.code %][% ELSE %]mc-[% itemtypeloo.ccl %]:[% 
 itemtypeloo.code %][% END %]/label for=[% itemtypeloo.ccl FILTER 
 remove(',') %]-[% itemtypeloo.number %][% UNLESS ( noItemTypeImages ) %][% 
 IF ( itemtypeloo.imageurl ) %]img border=0 src=[% itemtypeloo.imageurl 
 %] alt=[% itemtypeloo.description %] /[% END %]nbsp;[% END %]

You should looking into Tool Template variables. This code is ugly to read.
http://www.template-toolkit.org/docs/manual/Variables.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #24782|0   |1
is obsolete||

--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28573
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28573action=edit
(Re?)added update message and set version to 3.15.XXX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #24779|0   |1
is obsolete||

--- Comment #23 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28572
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28572action=edit
Fix tab issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #22 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28571
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28571action=edit
Fix and rebase following mtompset's comments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #24778|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #28571|0   |1
is obsolete||
  Attachment #28572|0   |1
is obsolete||
  Attachment #28573|0   |1
is obsolete||

--- Comment #25 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28575
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28575action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

Rebased, squashed, and fixed whitespace.

CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Run Koha QA tool.
2) Apply the patch

SETUP
3) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and searchcategory.
4) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

More revisions to follow once I actually start testing this fully. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #28575|0   |1
is obsolete||

--- Comment #26 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28576
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28576action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

Rebased, squashed, and fixed whitespace.
Added AFTER to updatedatabase.pl, so order will match
 kohastructure.sql
Fixed GetItemTypesCategorized, so that partially hidden search
 categories still appear in the item type list.
HOWEVER, THIS CREATES A PROBLEM. SEARCHING ON A CATEGORY MAY
 RETURN THINGS WHICH ARE NOT SUPPOSED TO BE SHOWN.
SEE FURTHER COMMENTS.

CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Run Koha QA tool.
2) Apply the patch

SETUP
3) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and searchcategory.
4) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.


Current status: In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #27 from M. Tompsett mtomp...@hotmail.com ---
I think there is some inclusion/exclusion logic going awry here. If we don't
show an item in the item types available in the advanced search, we likely do
not want the user to actually get results with those in them. However, the
results will still return them. If I hide everything except one item type, then
if I don't select that item type, then everything is returned. If I do select
just that item type, then the results will only be limited in that item type.
Is this really what is desired?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #28 from M. Tompsett mtomp...@hotmail.com ---
Also, rather than just dump this to failed qa, because there is a lack of
C4/Koha test for the new routines, I'd like to figure out this discussion
first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #29 from M. Tompsett mtomp...@hotmail.com ---
Okay, if OpacHiddenItems is set in a corresponding manner to the item types
being marked as hidden in OPAC, then I think this should suffice. That is
assuming that you only want the individual items not listed if they are grouped
together. However, this is lacking testing for the C4/Koha routines that were
added. Marking as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #28576|0   |1
is obsolete||

--- Comment #30 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28579
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28579action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

It's possible to hide the records and the items, but the
advanced search form is a bit trickier. It would be nice if
we could specify which itemtypes are offered as search options
in the OPAC advanced search form.

To solve this, two new columns will be added in the item type.

1) Display in OPAC
Default : Yes
Set to NO to hide and itemtype in the opac's advanced search.

2) Search category
The search category allows library to group some similar
itemtypes in a single checkbox in the opac.  The categories are
defined in an Authorized value.

For Example, itemtypes DVD, VHS could use the Video category.
Searching for Video in the OPAC would returns the DVD and VHS
items.

Initial coding by philippe.blo...@inlibro.com with
mtomp...@hotmail.com providing extra testing, patching,
squashing, and rebasing.

CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Run Koha QA tool.
2) Apply the patch

SETUP
3) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and
   searchcategory.
4) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   i) If you do not have a DOCTYPECAT category, create one.
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category
list box, select Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a
  different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of
 icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped)
   do not appear in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were
   grouped into the Hardware category in step 4.

Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-05-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12330

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-02-05 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Francois Charbonnier franch...@gmail.com changed:

   What|Removed |Added

 CC||franch...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-31 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #21 from Blou philippe.blo...@inlibro.com ---
Results hard to reproduce, I'll wait on your further testing results.

If you get unwanted results, like the no category you listed below, could
you examine the search string in the header, something like 

Results of search  with limit(s): 'mc-itype,phr:CDR or mc-itype,phr:VG or
mc-itype,phr:VT' 

That is what is generated when HARDWARE is exploded in my latest test with URL:
cgi-bin/koha/opac-search.pl?idx=kwq=idx=kwq=idx=kwq=do=Searchsearchcat=HARDWARElimit-yr=limit=limit=sort_by=relevance

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #24597|0   |1
is obsolete||

--- Comment #14 from Blou philippe.blo...@inlibro.com ---
Created attachment 24778
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24778action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

Fix and rebase following mtompset's comments

Bug 10937 - Option to hide and group itemtypes from advanced search

   Fixed and rebased following mtompset's comments.
   - Kept inline expr, same as model 5 lines earlier.
   - No indentation change.  END matching (now cleaner) introductory IF
   - changed to varchar(20) to match authorised_value's type.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Applies fine.

mtompset@ubuntu:~/kohaclone$ koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to bab96c3 'Bug 11571: fix breakage of -f option
')

 FAIL   C4/Koha.pm
   OK pod
   FAIL   forbidden patterns
forbidden pattern: tab char (line 288)
forbidden pattern: tab char (line 45)
   OK valid
   OK critic

...

 FAIL   opac/opac-search.pl
   OK pod
   FAIL   forbidden patterns
forbidden pattern: tab char (line 411)
forbidden pattern: tab char (line 228)
   OK valid
   OK critic

Please correct your tab issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #16 from Blou philippe.blo...@inlibro.com ---
Created attachment 24779
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24779action=edit
Fix tab issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #17 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 24778
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24778
Bug 10937 - Option to hide and group itemtypes from advanced search

Review of attachment 24778:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=24778)
-

::: installer/data/mysql/updatedatabase.pl
@@ +7950,5 @@
 +$dbh-do(q{
 +ALTER TABLE itemtypes
 +ADD hideinopac TINYINT(1) NOT NULL DEFAULT 0,
 +ADD searchcategory VARCHAR(20) DEFAULT NULL;
 +});

You forgot to print out a meaningful message and call SetVersion, like the
other ones. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #18 from M. Tompsett mtomp...@hotmail.com ---
CURRENT TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Run Koha QA tool.
2) Apply the patch

SETUP
3) run ./installer/data/mysql/updatedatabase.pl to add the
two columns to itemtypes
   -- Does a meaningful message get printed?
  Are the columns added?
   DESCRIBE itemtypes; should list hideinopac and searchcategory.
4) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values,
   select DOCTYPECAT in the 'Show category:' dropdown
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

More revisions to follow once I actually start testing this fully. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #19 from Blou philippe.blo...@inlibro.com ---
Created attachment 24782
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24782action=edit
(Re?)added update message and set version to 3.15.XXX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Okay... that fresh install works. the update works.
the editing the itemtype stuff all seems to work.
But I can't get it to search properly.

ARTCL Article
AUD Audio CD
BK Books
CF Computer Files
CR Continuing Resources
EBK Ebooks, Online Resources
IM In house Material
MP Maps
MF Microfiche
MX Mixed Materials
MU Music
REF Reference
RPR Reprint, VFile
TH Thesis, Dissertation
VCD Video CD
VM Visual Materials

These are my item types. I took the first 8 and did a pretty 0-7 binary
combination with HARDWARE, Hide in OPAC, and Not for Loan.

I then went to the OPAC interface, clicked on Advanced Search and tried to make
sense of the Item type box. 10 things plus hardware were displayed. 16-4
(hidden in OPAC) = 12, 12-2 (not hidden in OPAC, but HARDWARE) = 10. plus
hardware. Display looks good.

I checked hardware, and then clicked the Search button at the bottom of the
page.

I got a bunch of results, but this is where it doesn't make sense. My first
result was a journal (Continuing Resources), which I had marked as no category,
not for loan, hide in OPAC. The fact that the search returned a no category,
and not the hardware category makes it seem broken.

Here is the URL (the name doesn't exist):
https://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=kwq=idx=kwq=idx=kwq=limit-yr=searchcat=HARDWARElimit=limit=multibranchlimit=sort_by=relevancedo=Search

Hmmm... I changed the sort by drop down to title A-Z and the first one was BK,
so that was expected. The result count is strangely high too, but perhaps I am
mistaken in that account. I'll check manually later. Until then, I'm leaving
this as Failed QA, because the search by relevance gave me a bad result, and I
don't know if it is this patch, or just the by relevance search in general.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 24597
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24597
Bug 10937 - Option to hide and group itemtypes from advanced search

Review of attachment 24597:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10937attachment=24597)
-

::: C4/Koha.pm
@@ +41,4 @@
   slashifyDate
   subfield_is_koha_internal_p
   GetPrinters GetPrinter
 + GetItemTypes GetItemTypesCategorized GetItemTypesByCategory 
 getitemtypeinfo

No problem, but I would have put the new functions on a different line, so as
to reduce the chance of messing up the old ones.

@@ +270,4 @@
  }
  }
  
 +=head2 GetItemTypes

GetItemTypesCategorized. Oops!

::: admin/itemtypes.pl
@@ +168,4 @@
  $input-param('summary'),
  $input-param('checkinmsg'),
  $input-param('checkinmsgtype'),
 +( $input-param('hideinopac') ? 1 : 0 ),

This one is in parenthesis?

@@ +193,4 @@
  $input-param('summary'),
  $input-param('checkinmsg'),
  $input-param('checkinmsgtype'),
 +$input-param('hideinopac') ? 1 : 0,

This one is not? It might be best to avoid the inline expr?true:false in this
list.

::: installer/data/mysql/kohastructure.sql
@@ +1241,5 @@
summary text, -- information from the summary field, may include HTML
checkinmsg VARCHAR(255), -- message that is displayed when an item with 
 the given item type is checked in
checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) 
 for the checkinmsg, can be alert or message
 +  hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the 
 search options in OPAC
 +  searchcategory varchar(15) default NULL, -- Group this item type with 
 others with the same value on OPAC search options

How did you decide on varchar(15)?

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
@@ +146,3 @@
  [% itemtypeloo.description 
 %]/label/div
  [% IF ( loop.last ) %]/div[% 
 ELSE %][% UNLESS ( loop.count % 4 ) %]/divdiv class=row-fluid[% END 
 %][% END %]
 +[% END %]

This END isn't even the area you were adding your IF around. Why change the
indentation? Indentation issues should perhaps be a separate patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Does not apply to master. Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #11 from Blou philippe.blo...@inlibro.com ---
Created attachment 24597
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24597action=edit
Bug 10937 - Option to hide and group itemtypes from advanced search

Sponsor: Vanier college

Added bootstrap theme

same instructions.

SETUP
0) run updatedatabase.pl to add the two columns to itemtypes
1) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #22276|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #10 from Blou philippe.blo...@inlibro.com ---
Created attachment 24596
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24596action=edit
Conflicts: installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2014-01-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #24596|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-12-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Patches apply for me, for the second patch I think the subject should be a
sponsor line :)
(http://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-12-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #22007|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-12-29 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Blou, could you take a look and provide a follow-up for the bootstrap theme?
It's the default theme now and we shouldn't add a new feature that doesn't work
with it.

Also, both patches seem almost identical - I am obsoleting the older patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-12-25 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

--- Comment #7 from mathieu saby mathsaby...@gmail.com ---
Hello
Could you write a followup for the new default bootstrap theme?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-11-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-25 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Applying: Sponsor: Vanier college
/home/koha/kohaclone/.git/rebase-apply/patch:24: tab in indent.
LEFT JOIN authorised_values ON searchcategory = authorised_value
WHERE searchcategory  ''
/home/koha/kohaclone/.git/rebase-apply/patch:62: tab in indent.
quantity SMALLINT(6) default NULL, -- suggested quantity to be
purchased
/home/koha/kohaclone/.git/rebase-apply/patch:63: tab in indent.
currency VARCHAR(3) default NULL, -- suggested currency for the
suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:64: tab in indent.
price DECIMAL(28,6) default NULL, -- suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:65: tab in indent.
total DECIMAL(28,6) default NULL, -- suggested total cost
(price*quantity updated for currency)
fatal: sha1 information is lacking or useless (C4/Koha.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Sponsor: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #4 from Blou philippe.blo...@inlibro.com ---
Created attachment 22276
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22276action=edit
Sponsor: Vanier college

Following David Cook's comments, I made the following modifications:

- C4/Koha.pm : include the non-NULL but empty category in the selection
- admin/authorised_values.pl : Added the DOCTYPECAT as default.  Seemed the
cleanest solution.
- installer/data/mysql/kohastructure.sql : cleaned the unwelcomed whitespaces.
- koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt : fixed typo and
added instruction message
- koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt : minimized the diff by
redoing the code.

New testing instructions.

SETUP
0) run updatedatabase.pl to add the two columns to itemtypes
1) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
   b) Click button New authorized value for DOCTYPECAT
   c) Enter
 Authorized value: HARDWARE
 Description : Hardware
 Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Blou philippe.blo...@inlibro.com ---
The patch is additive.  The first one is required.
I rebased before doing it, so all should be good.

Feedbacks are welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-21 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook dc...@prosentient.com.au ---
I'm glad that someone has worked on this issue as I was just talking about it a
few hours ago!

However:

1) There is an issue with your code in regards to Search Category. If an item
type has a search category of none, it won't appear on the Advanced Search
page.

That is...if searchcategory is null in the database and hideinopac is 0,
the item type will appear.

However, if searchcategory is blank and hideinopac is 0, the item type will
be hidden. 

searchcategory will be blank any time an item type is saved and None is
selected as the Search Category. Definitely not a good thing!

There are a few other things that you will also want to consider in revising
your patch:

2) Whitespace changes should be made in a separate patch so it's easier to
separate code differences and format differences (like in kohastructure.sql).

3) You have a typo on the Add/Edit item type page
(http://devonestaff/cgi-bin/koha/admin/itemtypes.pl?op=add_form).

It says Advanded Search rather than Advanced Search.

--

You might want to also consider the following:

4) Your test plan assumes that there is an authorized value category of
DOCTYPECAT. You should mention that most users will probably have to create
this authorized value category.

Also, your test plan says to choose Hardware in the staff client, but the
authorized value will actually be Anything according to your plan. Of course,
it should be the only search category available (other than none), but the test
plan is a rather dense block of text, so I found it difficult to tell exactly
what I was supposed to see.

It might be useful to add some whitespace between the test plan steps to make
it easier to read. 

--

I'll be happy to look again once you have an updated patch! Thanks, Philippe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #2 from Blou philippe.blo...@inlibro.com ---
Created attachment 22007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22007action=edit
Bug 10937 - Options to group or hide items in adv. search

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

Modified:
C4/Koha.pmGetItemTypesCategorized
admin/itemtypes.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
opac/opac-search.pl
installer/data/mysql/kohastructure.sql  Added two columns, hideinopac and
searchcategory
installer/data/mysql/updatedatabase.pl

Testing:
0) run updatedatabase.pl to add the two columns to itemtypes
1) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
2) Click button New authorized value for DOCTYPECAT
3) Enter HARDWARE as Atuhorize value, ANything as Description and Hardware
as OPAC description then click SAVE.
4) In Intranet/Koha Amind/Item types, select (at least) two different items
and proceed with the following steps
  a) Click action/Edit on the right column
  b) Third row is the search category list box, select Hardware
  c) click Save changes at the bottom
5) In Intranet/Koha Admin/Item types (again), select a different item type
and click the checkbox Hide in OPAC
6) Go to OPAC/Adv search.
7) Validate that all items modified above do not appear in Item type list
8) Validate that new item type Hardware does appear instead.
9) Select item Hardware, start Search.
10) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com
   Assignee|eric.be...@inlibro.com  |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Eric Bégin eric.be...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||eric.be...@inlibro.com
   Assignee|oleon...@myacpl.org |eric.be...@inlibro.com
Summary|Option to hide some |Option to hide and group
   |itemtypes from advanced |itemtypes from advanced
   |search  |search

--- Comment #1 from Eric Bégin eric.be...@inlibro.com ---
Two new columns will be added in the item type.

1) Display in OPAC
Default : Yes
Set to NO to hide and itemtype in the opac's advanced search.

2) Search category
The search category allows library to group some « similar » itemtypes in a
single checkbox in the opac.
The categories are defined in an Authorized value.

For Example, itemtypes DVD, VHS could use the Video category.
Searching for Video in the OPAC would returns the DVD and VHS items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

96 matches

Mail list logo