[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Nick Clemens changed: What|Removed |Added Blocks||36532 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/687 Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Needs documenting --- Comment #77 from Martin Renvoize --- Nice enhancement, marking as Needs documenting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #76 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #75 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #74) > *** Bug 33442 has been marked as a duplicate of this bug. *** Nice to see this one :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #74 from Marcel de Rooy --- *** Bug 33442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #73 from Christopher Brannon --- (In reply to Jonathan Druart from comment #67) > Not blocker, but noting: > 2. We don't have access to already read notes. Could be added later if > needed. Staff do, patrons do not. Yes, something to consider adding later if needed. Would have to be adjusted on the staff side, as right now, staff have all control as to how long a message sticks around. We would need to probably have some way of hiding the message when read, like we do on the patron side, and then have a way to access read messages on both sides, and then decide how to manage read messages. Again, something for another bug perhaps. This is a good start. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #72 from Jonathan Druart --- Created attachment 148611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148611=edit Bug 12029: Remove 'params' from filter_by_unread It's not used and not needed, you can chain methods. Also remove unused C4::Koha module and useless statement in tests. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #71 from Jonathan Druart --- Created attachment 148610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148610=edit Bug 12029: Ability for patrons to dismiss OPAC messages This enhancement adds the ability for patrons to dismiss an OPAC message, marking it as read to remove it from their summary page. To test: 1) Update database and restart services 2) Log into the staff interface and go to your patron account 3) Click the Add message button 4) Add a message for the OPAC and Save 5) Log into the OPAC. Note there is a message on the homepage saying you have a message. Go to your user summary and confirm the message displays. 6) Click the button to dismiss the message. A confirmation box should pop up - hitting Cancel should stop the action. 7) Dismiss the message again and this time Confirm. Make sure the message is gone from the OPAC user summary and from the homepage. 8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t 9) Create a few more messages for the OPAC 10) Log into the OPAC and dismiss one of the messages 11) Confirm the count of unread messages on the OPAC home page is correct Sponsored-by: Koha-US Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #70 from Jonathan Druart --- Created attachment 148609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148609=edit Bug 12029: Tests Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #69 from Jonathan Druart --- Created attachment 148608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148608=edit Bug 12029: Schema updates Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Jonathan Druart changed: What|Removed |Added Attachment #147522|0 |1 is obsolete|| Attachment #147523|0 |1 is obsolete|| Attachment #147524|0 |1 is obsolete|| Attachment #147525|0 |1 is obsolete|| --- Comment #68 from Jonathan Druart --- Created attachment 148607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148607=edit Bug 12029: Adding messages.patron_read_date column Signed-off-by: Christopher Brannon JD Amended patch: Fix QA failure "File must have the exec flag" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #67 from Jonathan Druart --- Not blocker, but noting: 1. A REST API endpoint would have been better for this job 2. We don't have access to already read notes. Could be added later if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Christopher Brannon changed: What|Removed |Added Blocks||33097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097 [Bug 33097] Is message for staff or OPAC on circulation.pl? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #66 from Christopher Brannon --- Works as describe, and totally awesome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Biblibre Sandboxes changed: What|Removed |Added Attachment #147521|0 |1 is obsolete|| --- Comment #65 from Biblibre Sandboxes --- Created attachment 147525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147525=edit Bug 12029: Ability for patrons to dismiss OPAC messages This enhancement adds the ability for patrons to dismiss an OPAC message, marking it as read to remove it from their summary page. To test: 1) Update database and restart services 2) Log into the staff interface and go to your patron account 3) Click the Add message button 4) Add a message for the OPAC and Save 5) Log into the OPAC. Note there is a message on the homepage saying you have a message. Go to your user summary and confirm the message displays. 6) Click the button to dismiss the message. A confirmation box should pop up - hitting Cancel should stop the action. 7) Dismiss the message again and this time Confirm. Make sure the message is gone from the OPAC user summary and from the homepage. 8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t 9) Create a few more messages for the OPAC 10) Log into the OPAC and dismiss one of the messages 11) Confirm the count of unread messages on the OPAC home page is correct Sponsored-by: Koha-US Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Biblibre Sandboxes changed: What|Removed |Added Attachment #146708|0 |1 is obsolete|| --- Comment #64 from Biblibre Sandboxes --- Created attachment 147524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147524=edit Bug 12029: Tests Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Biblibre Sandboxes changed: What|Removed |Added Attachment #146707|0 |1 is obsolete|| --- Comment #63 from Biblibre Sandboxes --- Created attachment 147523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147523=edit Bug 12029: Schema updates Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Biblibre Sandboxes changed: What|Removed |Added Attachment #146706|0 |1 is obsolete|| --- Comment #62 from Biblibre Sandboxes --- Created attachment 147522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147522=edit Bug 12029: Adding messages.patron_read_date column Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added Attachment #146709|0 |1 is obsolete|| --- Comment #61 from Aleisha Amohia --- Created attachment 147521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147521=edit Bug 12029: Ability for patrons to dismiss OPAC messages This enhancement adds the ability for patrons to dismiss an OPAC message, marking it as read to remove it from their summary page. To test: 1) Update database and restart services 2) Log into the staff interface and go to your patron account 3) Click the Add message button 4) Add a message for the OPAC and Save 5) Log into the OPAC. Note there is a message on the homepage saying you have a message. Go to your user summary and confirm the message displays. 6) Click the button to dismiss the message. A confirmation box should pop up - hitting Cancel should stop the action. 7) Dismiss the message again and this time Confirm. Make sure the message is gone from the OPAC user summary and from the homepage. 8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t 9) Create a few more messages for the OPAC 10) Log into the OPAC and dismiss one of the messages 11) Confirm the count of unread messages on the OPAC home page is correct Sponsored-by: Koha-US -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #60 from Christopher Brannon --- Everything works, however, when I have 3 messages, with two marked read, the counter on the home page of the OPAC still shows 3, even though there is only 1 left to read. This was addressed in one of the original patches, and is now not working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #59 from Katrin Fischer --- It's definitely the issue with the sandboxes we ran into today multiple times. Better to have this Needs SO then stuck in FQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #58 from Christopher Brannon --- Feel free to sign off on it then. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #57 from Owen Leonard --- The patch applied fine for me in koha-testing-docker so I think this is an issue with the sandboxes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #56 from Christopher Brannon ---
I'm getting this error when I try to load the patch in a sandbox:
TASK [Apply bug 12029 via git-bz in docker container]
**
fatal: [localhost -> koha-test12029]: FAILED! => {"changed": true, "cmd": "cd
/kohadevbox/koha && yes | git bz apply 12029", "delta": "0:00:00.089425",
"end": "2023-02-16 18:29:15.316516", "msg": "non-zero return code", "rc": 1,
"start": "2023-02-16 18:29:15.227091", "stderr": "Traceback (most recent call
last):\n File \"/usr/bin/git-bz\", line 2716, in \napplied =
do_apply(bug_ref)\n File \"/usr/bin/git-bz\", line 1738, in do_apply\n
attachmentdata=True)\n File \"/usr/bin/git-bz\", line 1473, in load\n
bug._load(bug_reference.id, attachmentdata)\n File \"/usr/bin/git-bz\", line
1229, in _load\nresponse = self.server.send_request(\"GET\", url)\n File
\"/usr/bin/git-bz\", line 999, in send_request\ncookies =
self.get_cookie_string()\n File \"/usr/bin/git-bz\", line 992, in
get_cookie_string\nself.cookies = get_bugzilla_cookies(host)\nNameError:
global name 'host' is not defined", "stderr_lines": ["Traceback (most recent
call last):", " File \"/usr/bin/git-bz\", line 2716, in ", "
applied = do_apply(bug_ref)", " File \"/usr/bin/git-bz\", line 1738, in
do_apply", "attachmentdata=True)", " File \"/usr/bin/git-bz\", line 1473,
in load", "bug._load(bug_reference.id, attachmentdata)", " File
\"/usr/bin/git-bz\", line 1229, in _load", "response =
self.server.send_request(\"GET\", url)", " File \"/usr/bin/git-bz\", line 999,
in send_request", "cookies = self.get_cookie_string()", " File
\"/usr/bin/git-bz\", line 992, in get_cookie_string", "self.cookies =
get_bugzilla_cookies(host)", "NameError: global name 'host' is not defined"],
"stdout": "", "stdout_lines": []}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added Text to go in the|Sponsored by koha-US|This enhancement adds the release notes||ability for patrons to ||dismiss an OPAC message, ||marking it as read to ||remove it from their ||summary page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #55 from Aleisha Amohia --- Created attachment 146709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146709=edit Bug 12029: Ability for patrons to dismiss OPAC messages This enhancement adds the ability for patrons to dismiss an OPAC message, marking it as read to remove it from their summary page. To test: 1) Update database and restart services 2) Log into the staff interface and go to your patron account 3) Click the Add message button 4) Add a message for the OPAC and Save 5) Log into the OPAC. Note there is a message on the homepage saying you have a message. Go to your user summary and confirm the message displays. 6) Click the button to dismiss the message. A confirmation box should pop up - hitting Cancel should stop the action. 7) Dismiss the message again and this time Confirm. Make sure the message is gone from the OPAC user summary and from the homepage. 8) Confirm tests pass t/db_dependent/Koha/Patron/Messages.t Sponsored-by: Koha-US -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #54 from Aleisha Amohia --- Created attachment 146708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146708=edit Bug 12029: Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #53 from Aleisha Amohia --- Created attachment 146707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146707=edit Bug 12029: Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added Attachment #137646|0 |1 is obsolete|| Attachment #137647|0 |1 is obsolete|| Attachment #137648|0 |1 is obsolete|| --- Comment #52 from Aleisha Amohia --- Created attachment 146706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146706=edit Bug 12029: Adding messages.patron_read_date column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #51 from Martin Renvoize --- Must admit, I didn't do a code review here.. just confirmed the feature worked as described. As you've adopted this one Owen, feel free to ask for help to update it to more usual practices.. I'm happy to help. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #50 from Jonathan Druart ---
+my $borrowernumber = $cgi->param('borrowernumber') || undef;
$borrowernumber MUST be retrieved from get_template_and_user (or another
C4::Auth method), not from the query parameters.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #49 from Jonathan Druart --- There is NO authentication check, everybody (no need to be loggedin) can delete a message. This is a hard fail. Really, it would have been better (and easier for everybody) to follow the usual pattern we have in our scripts, than decide on something that is not Koha-styled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #48 from Jonathan Druart --- DB naming (suffix _date), see bug 31150. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #47 from Christopher Brannon --- Looks good to me as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 ByWater Sandboxes changed: What|Removed |Added Attachment #137523|0 |1 is obsolete|| --- Comment #46 from ByWater Sandboxes --- Created attachment 137648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137648=edit Bug 12029: DBIC Schema Signed-off-by: Martin Renvoize Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
ByWater Sandboxes changed:
What|Removed |Added
Attachment #137522|0 |1
is obsolete||
--- Comment #45 from ByWater Sandboxes ---
Created attachment 137647
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137647=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
Signed-off-by: Martin Renvoize
Signed-off-by: Christopher Brannon
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 ByWater Sandboxes changed: What|Removed |Added Attachment #137521|0 |1 is obsolete|| --- Comment #44 from ByWater Sandboxes --- Created attachment 137646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137646=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Martin Renvoize Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #43 from Martin Renvoize --- (In reply to Christopher Brannon from comment #42) > I had no idea that I needed to do that. How can I tell? It's not entirely trivial to tell.. it's either a good habit to get into to just run the schema rebuild after applying patches (this is something I've considered doing by default on the sandboxes, but never had a moment to implement).. or if you look at the logs you posted the `The method Some::Koha::Object->some_method_name is not covered by tests!` line is an indication that it's probably schema build related. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #42 from Christopher Brannon --- (In reply to Martin Renvoize from comment #37) > I've added the Schema patch here to make this easier to test on sandboxes... > > > However.. please note when you see an error like this you can actually build > the schema's yourself from the sandbox action menu 'Refresh schema' I had no idea that I needed to do that. How can I tell? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #41 from Martin Renvoize --- All appears to work as designed.. signing off, ready for QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Attachment #137520|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 137523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137523=edit Bug 12029: DBIC Schema Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137519|0 |1
is obsolete||
--- Comment #39 from Martin Renvoize ---
Created attachment 137522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137522=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Attachment #137518|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 137521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137521=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #37 from Martin Renvoize --- I've added the Schema patch here to make this easier to test on sandboxes... However.. please note when you see an error like this you can actually build the schema's yourself from the sandbox action menu 'Refresh schema' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #36 from Martin Renvoize --- Created attachment 137520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137520=edit Bug 12029: DBIC Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Martin Renvoize changed:
What|Removed |Added
Attachment #137435|0 |1
is obsolete||
--- Comment #35 from Martin Renvoize ---
Created attachment 137519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137519=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added Attachment #137434|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 137518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137518=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #33 from Christopher Brannon ---
Tested on sandbox - Failed when creating a message:
Error trace
Template process failed: undef error - The method
Koha::Patron::Message->patron_read_date is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Patron::Message=HASH(0x55c6e0dc8e60)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 223
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 223
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 243
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 18
Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x55c6e0c5ada0)',
'Template::Context=HASH(0x55c6ddb6d958)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)',
'patron_messages.inc', undef, 'localize me!') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 409
Template::Context::include('Template::Context=HASH(0x55c6ddb6d958)',
'patron_messages.inc') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 810
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 18
Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x55c6e1361ad0)',
'Template::Context=HASH(0x55c6ddb6d958)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)',
'Template::Document=HASH(0x55c6e1361ad0)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 91
Template::Service::process('Template::Service=HASH(0x55c6e0c4a660)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt',
'HASH(0x55c6e0d30130)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template.pm line 66
Template::process('Template=HASH(0x55c6dd8a77f8)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt',
'HASH(0x55c6e0d30130)', 'SCALAR(0x55c6da300c50)') called at
/kohadevbox/koha/C4/Templates.pm line 127
C4::Templates::output('C4::Templates=HASH(0x55c6e0d89578)') called at
/kohadevbox/koha/circ/circulation.pl line 636
eval {...} at /kohadevbox/koha/circ/circulation.pl line 2
CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::__ANON__('CGI::Compile=HASH(0x55c6ddb71328)',
'', '/kohadevbox/koha/circ/circulation.pl', '/kohadevbox/koha/circ',
'ARRAY(0x55c6e0e46b48)') called at /usr/share/perl5/CGI/Compile.pm line 151
CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::circulation_2epl at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 30
CGI::Emulate::PSGI::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/App/WrapCGI.pm line 95
Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55c6e0db51f0)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/App/CGIBin.pm line 50
Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55c6d6269cf8)',
'HASH(0x55c6dd8d05a8)', '/kohadevbox/koha/circ/circulation.pl') called at
/usr/share/perl5/Plack/App/File.pm line 34
Plack::App::File::call('Plack::App::CGIBin=HASH(0x55c6d6269cf8)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/LogWarn.pm line 22
Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55c6dd8f9030)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/Log4perl.pm line 30
Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55c6dd8f92d0)',
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Assignee|ivan.marquez@autoparallel.c |oleon...@myacpl.org |om | --- Comment #32 from Owen Leonard --- FYI I've changed the assignment to myself because Autoparallel had no interest in participating in the Bugzilla process. I've attached the last version of their patch and what I think is a mangled version of Hayley's followup. Everything seems to work correctly but I'm going to be cautious by asking for new signoffs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #31 from Owen Leonard ---
Created attachment 137435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137435=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Attachment #130516|0 |1 is obsolete|| Attachment #132949|0 |1 is obsolete|| --- Comment #30 from Owen Leonard --- Created attachment 137434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137434=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #29 from Katrin Fischer --- Thx for the update, Christopher. If we could get the unit tests within the next few days, we still might make the release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #28 from Christopher Brannon --- Auto-Parallel, who wrote the patch, is supposed to be uploading the unit tests. We are waiting for them to do this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #27 from Katrin Fischer ---
Hi Hayley and all,
trying to give this another push forward.
1) Unit tests (blocker)
We are still missing the unit tests. Is there any update on that?
2) Database update
The database update is still a bit too verbose, as noted earlier, using some
uncommon output pattern (ALTERATION, NOTICE and INFO are not needed). We said
RM could deal with it, so just explaining a bit more what people meant earlier
on:
+use Modern::Perl;
+
+return {
+bug_number => "12029",
+description => "Enable patrons to delete messages",
+up => sub {
+my ($args) = @_;
+my ($dbh, $out) = @$args{qw(dbh out)};
+
+# Do you stuffs here
+my $alteration = q{
+ALTER TABLE messages
+ADD COLUMN `patron_read_date` timestamp NULL DEFAULT NULL
+COMMENT 'date and time patron dismissed message'
+AFTER `manager_id`
+};
+if( column_exists('messages', 'patron_read_date') ) {
+say $out "NOTICE: Column 'messages.patron_read_date' already
exists";
+}
+else {
+say $out "ALTERATION: $alteration";
+$dbh->do($alteration);
+}
+
+# Print useful stuff here
+say $out "INFO: Bug 12029 migration applied";
+},
+};
3) Translatability
There is some code in opac/dismiss_message.pl that I wondered about. It
contains messages that are not translatable, but I am not sure yet if this
would show to patrons, in my tests it didn't seem like it.
comment => "Patron read date already set",
comment => "Set patron_read_date to ($patron_read_date)",
Hm, they might not be used after all?
>11. What are you doing with $result? $inputs and comment are returned from the
>dismiss_patron_message sub but never >reused. This script could be 10 lines
>long IMO.
Failing for 1). Testing in the GUI worked well!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #26 from Owen Leonard --- Thank you for the follow-up Hayley! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Owen Leonard changed:
What|Removed |Added
Attachment #132918|0 |1
is obsolete||
--- Comment #25 from Owen Leonard ---
Created attachment 132949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132949=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Marie changed: What|Removed |Added CC||marie.hed...@musikverket.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Hayley Pelham changed: What|Removed |Added CC||hayleypel...@catalyst.net.n ||z --- Comment #24 from Hayley Pelham --- (In reply to Martin Renvoize from comment #22) > Comment on attachment 130516 [details] [review] > Bug 12029: Patrons should be able to delete their patron messages > > Review of attachment 130516 [details] [review]: > - > > ::: installer/data/mysql/kohastructure.sql > @@ +3739,4 @@ > >`message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the > > text of the message', > >`message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT > > 'the date and time the message was written', > >`manager_id` int(11) DEFAULT NULL COMMENT 'creator of message', > > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time > > the patron dismissed the message', > > Final additional note from my own review: > > Shouldn't this be a DATETIME rather than a TIMESTAMP field? As the similar field message_date is also a timestamp I see no need to change this aspect of the patch at this stage. Please let me know if you have other reasoning! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
--- Comment #23 from Hayley Pelham ---
Created attachment 132918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132918=edit
Bug 12029: (follow-up) Adhering to coding guidelines
This is a follow-up patch which (based on comment #19) does
the following:
1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)
Sponsored-by: Horowhenua Library Trust
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #22 from Martin Renvoize --- Comment on attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516 Bug 12029: Patrons should be able to delete their patron messages Review of attachment 130516: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12029=130516) - ::: installer/data/mysql/kohastructure.sql @@ +3739,4 @@ >`message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the text > of the message', >`message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'the > date and time the message was written', >`manager_id` int(11) DEFAULT NULL COMMENT 'creator of message', > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time the > patron dismissed the message', Final additional note from my own review: Shouldn't this be a DATETIME rather than a TIMESTAMP field? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #21 from Martin Renvoize --- Welcome Bill, This looks like a great new feature and I'm really glad the discussion continued past comment 4 to get the refinements I also felt were necessary. Regarding the actual submission, did you read the coding guidelines available https://wiki.koha-community.org/wiki/Coding_Guidelines ? These are what the QA people will base their most basic feedback upon and are 'hard fails' in most cases when not adhered to. They are voted upon by a council of community members and have good reasoning behind each (though they do not cover all cases and being updated fairly regularly as we come across various patterns.. for exapme the 'filter_by_' requirement is not yet a formal guideline, but will become one very soon) Beyond hard fails, the QA persons role is to help spot regressions and ensure coding of a minimum standard is maintained for submissions so we can maintain the features going forward. Such advice can be argued against, but should generally be considered constructive. So, taking Jonathans list. 1. Style, this may fail guidelines given our perlcritic requirements. It's a 1s fix anyway. 2. Will be in the guidelines imminently, a few minutes to fix. 3. Style, improved coding style, readability improvement. Not a hard fail, but constructive. 4. Hard fail, all module changes have required corresponding unit tests since 2017. If you are stuck here, just ask for some guidance. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required_.28updated_Apr_26.2C_2017.29 5. This is an unwritten rule.. I've made a note to add it to the guidelines. It just makes submissions considerably simpler for maintainers to add to all the supported branches. 6. Style, no guidelines broken, but it's a fair comment to help improve the developer. Another 10s fix. 7. Style, this will be fixed at push. 8. Hard fail: https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence 9. Superfluous comments confuse future maintenance and cost everybody time. 10. Style, developers do things in their own way. Whilst I agree an ajax method would have been preferable (I'd probably have gone for a new REST route myself, rather than svc), this isn't a hard fail but more of a guide for future developments. 11. This is highlighting some red flags for future maintenance again. This is the most 'human' comment here. To me, this code looks rather 'copy/paste', which is fine but there should be evidence that you've stripped out all unnecessary boilerplate and given the development some thought as to what it's actually doing and requires. Hope that helps clarify things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #20 from Katrin Fischer --- Hi Bill, thx for providing a patch! Jonathan provided you some good feedback on things that need to be fixed, please let us know if something is not clear! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.druart+koha@gmail.
||com
--- Comment #19 from Jonathan Druart ---
1. Empty new line at the top of Koha/Patron/Messages.pm
2. Koha::Patron::Messages->unread should be ->filter_by_unread
3. You don't need unread_count, just use ->filter_by_unread->count
4. Missing tests for this new method
5. DBIC schema change should not be included in the patch
6. atomicupdate file has a qq{} but you don't need string interpolation (ie.
replace with q{}
7. atomicupdate is too verbose, but RM can deal with that
8. Wrong copyright statement in opac/dismiss_message.pl (the one from 2009)
9. Unexpected comment in opac/dismiss_message.pl
# no warnings qw/once/;
# my $ig = 'Examine variable $exception';
# push @DB::typeahead, 'x $exception';
# $DB::single++;
# uncomment assignment below if you want to view environment
# $result->{env} = \%ENV;
10. It would have been better to write a ajax script, like
opac/svc/checkout_notes
11. What are you doing with $result? $inputs and comment are returned from the
dismiss_patron_message sub but never reused. This script could be 10 lines long
IMO.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall changed: What|Removed |Added Attachment #130515|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #17 from Lisette Scheer --- Worked great. I also ran a report: SELECT * FROM messages WHERE borrowernumber="51" and the patron_read_date was included: 2022-02-11 17:16:58. I know we have plenty of patrons who will be excited about this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall changed: What|Removed |Added Attachment #130514|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 130515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130515=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #15 from Owen Leonard --- Created attachment 130514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130514=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #14 from George Williams (NEKLS) --- (In reply to Christopher Brannon from comment #13) > Updated per Auto-Parallel's request: > > * A new field (ie patron_read) will be added to the messages table to record > that the patron has read the message. > > * If a message is set to display on the OPAC for the patron, the patron will > have a 'Dismiss' or 'Mark as read' button next to the message. > > * When the patron marks the message as read, the new field (ie patron_read) > will have the current date added to it, indicating the date that they read > the message. > > * If this new field "patron_read" has a value (a date), the dismissed > message will no longer show on the patron user interface (OPAC) only. In the > staff user interface, the dismissed message will still be visible and will > also display a label, such as 'Read xx-xx-', where x is the date in the > field. (Date will need to be formatted to admin date settings.) > > This functionality will not delete the message. It will allow staff to see > that the patron has read the message, and staff will still have the ability > to delete the message at their discretion. This is an excellent enhancement to the development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #13 from Christopher Brannon --- Updated per Auto-Parallel's request: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the new field (ie patron_read) will have the current date added to it, indicating the date that they read the message. * If this new field "patron_read" has a value (a date), the dismissed message will no longer show on the patron user interface (OPAC) only. In the staff user interface, the dismissed message will still be visible and will also display a label, such as 'Read xx-xx-', where x is the date in the field. (Date will need to be formatted to admin date settings.) This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #12 from Christopher Brannon --- Okay, based on this discussion, we can simplify the scope of this project: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the new field (ie patron_read) will have the current date added to it, indicating the date that they read the message. * If this new field has a value (a date), it will no longer show on the OPAC. It will also display a label, such as 'Read xx-xx-', where x is the date in the field. (Date will need to be formatted to admin date settings.) This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #11 from Katrin Fischer --- > Oh, wait. I think I understand. So, if we flag the it as read by putting a > date in the new field, we just turn off visibility on the opac side. We > don't have to touch the message_type field at all. That makes sense. :) > Am I understanding correctly? Everything else should still work the same, > because we will still be able to see it on the staff side, and it will still > be flagged as read? Yep, exactly what I meant. This way we don't change the current logic, but just enhance it a bit further. Changing the display logic in the OPAC to filter by the new 'read flag' should not be too hard and it will be a little less disruptive for the current workflows. Also, if we needed to revert from read to unread or wanted to optionally show read messages again, that would be relatively easy, because we can still tell what messages are 'patron' messages. I like the idea of making the 'read flag' a date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #10 from Christopher Brannon --- (In reply to Owen Leonard from comment #9) > (In reply to Christopher Brannon from comment #7) > > > When a message is marked as B (patron), it is seen on BOTH sides, by patron > > and staff. Changing it to L (staff) would accomplish dismissing it on the > > patron side, and maintaining current workflows on the staff side. > > It's not necessary if we're using logic in the OPAC to hide any message > which is marked as seen. Oh, wait. I think I understand. So, if we flag the it as read by putting a date in the new field, we just turn off visibility on the opac side. We don't have to touch the message_type field at all. That makes sense. :) Am I understanding correctly? Everything else should still work the same, because we will still be able to see it on the staff side, and it will still be flagged as read? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #9 from Owen Leonard --- (In reply to Christopher Brannon from comment #7) > When a message is marked as B (patron), it is seen on BOTH sides, by patron > and staff. Changing it to L (staff) would accomplish dismissing it on the > patron side, and maintaining current workflows on the staff side. It's not necessary if we're using logic in the OPAC to hide any message which is marked as seen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #8 from Christopher Brannon --- One small adjustment I would suggest, and should be easy enough, is to add the date of when the message was read to the label on the staff side. Perhaps the date could be the flag in the new field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #7 from Christopher Brannon --- (In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > Why the change from B to L? > > I agree that this doesn't seem to be a necessary step. This step was added because the message system does not archive these messages. If the message were just deleted, there would be no easy way for staff to see that the patron acknowledged receiving the message. If it were marked and hidden, we would be retaining messages that would build up over time, and the table would have to be maintained. When a message is marked as B (patron), it is seen on BOTH sides, by patron and staff. Changing it to L (staff) would accomplish dismissing it on the patron side, and maintaining current workflows on the staff side. After this enhancement, staff would be able to KNOW that the patron has seen the message, and the staff could decide whether to keep or delete the message from that point. Right now, staff have NO idea if the message is seen, and therefore have no idea when it would be appropriate to delete, if desired. This workflow enhancement has the least impact on current practices while adding needed functionality, and adding information for staff to enhance their workflow with these messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from Owen Leonard --- (In reply to Katrin Fischer from comment #5) > Why the change from B to L? I agree that this doesn't seem to be a necessary step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #5 from Katrin Fischer --- Probably should stay away... but since this question could also come up later in the process...: Why the change from B to L? For me that indicates for whose eyes the message was initially intended for and I think changing it, might make us lose some valuable information. Reporting could for example be affected. Visibility to the patron in the OPAC and also the new note "patron acknowledged" could also use just rely on the new db column. So the change B/L would not be strictly necessary to achieve the described behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #4 from Autoparallel --- Since this is what came out from the committee we will consider it as the official scope for this project and what will be built. Please be aware that any changes to this scope will have to be re-discussed in the committee and if approved would have to be treated as a new development, which would require a new work agreement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #3 from Christopher Brannon --- The koha-US development committee met and has determined the following criteria for this new feature: * A new field (ie patron_read) will be added to the messages table to record that the patron has read the message. * If a message is set to display on the OPAC for the patron, the patron will have a 'Dismiss' or 'Mark as read' button next to the message. * When the patron marks the message as read, the message_type field will change from B (patron) to L (librarian), and the new field (ie patron_read) will have a value, indicating that they read the message. * If this new field is true (showing the patron has read the message), it will now have the message_type set to L (librarian), and the message will show on the patron account. Because the new field has a value, it will also display some form of label next to the message indicating that the patron has read the message. The label could say something like 'Patron acknowledged', or something similar. This functionality will not delete the message. It will allow staff to see that the patron has read the message, and staff will still have the ability to delete the message at their discretion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #2 from Christopher Brannon --- (In reply to George Williams (NEKLS) from comment #1) > We have AllowAllMessageDeletion set to "Don't allow" so I'd like to see a > system preference that can turn this feature on or off if added. After reviewing the intended functionality of this feature and the purpose of AllowAllMessageDeletion, we have determined that this feature will not change anything with this permission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Autoparallel changed: What|Removed |Added CC||ivan.marquez@autoparallel.c ||om Assignee|oleon...@myacpl.org |ivan.marquez@autoparallel.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- We have AllowAllMessageDeletion set to "Don't allow" so I'd like to see a system preference that can turn this feature on or off if added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 koha-US bug tracker changed: What|Removed |Added Text to go in the||Sponsored by koha-US release notes|| Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
