[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157672|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157671|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157670|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157669|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157668|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157667|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157666|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157665|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157664|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157662|0 |1 is obsolete|| Attachment #157663|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157662|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157660|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157661|0 |1 is obsolete|| --- Comment #389 from Maryse Simard --- Created attachment 167808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167808=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157659|0 |1 is obsolete|| --- Comment #390 from Maryse Simard --- Created attachment 167809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167809=edit Bug 17015: Tests for DiscreteCalendar TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157658|0 |1 is obsolete|| --- Comment #388 from Maryse Simard --- Created attachment 167807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167807=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts Replace the current Calendar. Use Discrete Calendar in Tools->Calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (prove -l t/db_dependent/DiscreteCalendar.t) 6- Run all koha test in t/ (prove t). All tests should pass USING THE DISCRETE CALENDAR: 1- New UI a) Calendar on the left b) Holidays list on the right 2- New color system for holiday types: a) Working day : white b) Unique holiday: red c) Holiday repeating weekly: yellow d) Holiday repeating yearly: orange e) Floating holiday: green f) Need validation: blue 3- When clicking on a date in the calendar, opening, closing hours and holiday type are displayed. 4- All the fields are editable 5- New radio button to Edit selected dates or Copy to different dates 6- Option to copy the calendar to another branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157657|0 |1 is obsolete|| --- Comment #387 from Maryse Simard --- Created attachment 167806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167806=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #157656|0 |1 is obsolete|| --- Comment #386 from Maryse Simard --- Created attachment 167805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167805=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #385 from Blou --- No. Maryse will surely rebase it within the next two months to be in line with the master at the time of release, at which point she might put it as Need Signoff depending on the changes made. The status quo remains: we are confident this is a huge upgrade and would be a great stepping block for future fonctionnalities, and will keep rebasing it forever, AND the community doesn't see the value so we're not going through any refactoring for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #384 from Magnus Enger --- Looks like new patches were added after the status changed to Failed QA. Should the status be "Needs Signoff"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #383 from Maryse Simard --- Created attachment 157672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157672=edit Bug 17015: Adjust weekday name in weekly repeatable holidays table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156355|0 |1 is obsolete|| --- Comment #382 from Maryse Simard --- Created attachment 157671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157671=edit Bug 17015 : Correction when creating a new library This patch is a rebase of all the other ones. I have also resolved an issue that occurred when creating a new library. When creating a library, days are copied from the first library in the "branches" table and added to the new library in the "discrete_calendar" table. The problem arises because the table stores libraries in alphabetical order based on their branch code. So, if the new library has a branch code that comes first in alphabetical order, no days can be added, which would prevent the calendar from functioning for that library. I resolved this issue by copying the days from the first library that appears in the "discrete_calendar" table. This way, we ensure that days will be found and copied. TEST PLAN 1) Apply the patch 2) Run installer/data/mysql/updatedatabase.pl 3) Run misc/cronjobs/add_days_discrete_calendar.pl 4) Check that the max date is today + 1 day 5) Run t/db_dependent/DiscreteCalendar.t 6) If all the test pass, then the rebase work 7) Now, go to “Koha administration > Libraries > New library” 8) In “Library code” enter “A” 9) Enter the name that you want 10) Click the “Submit” button 11) Go to “Tools > Calendar” 12) Select the calendar for the library you just created 13) If there are no errors displayed on the page, the issue is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156354|0 |1 is obsolete|| --- Comment #381 from Maryse Simard --- Created attachment 157670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157670=edit Bug 17015: Corrections for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156353|0 |1 is obsolete|| --- Comment #380 from Maryse Simard --- Created attachment 157669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157669=edit Bug 17015: Miscellaneous corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156352|0 |1 is obsolete|| --- Comment #379 from Maryse Simard --- Created attachment 157668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157668=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156351|0 |1 is obsolete|| --- Comment #378 from Maryse Simard --- Created attachment 157667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157667=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156350|0 |1 is obsolete|| --- Comment #377 from Maryse Simard --- Created attachment 157666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157666=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156349|0 |1 is obsolete|| --- Comment #376 from Maryse Simard --- Created attachment 157665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157665=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156348|0 |1 is obsolete|| --- Comment #375 from Maryse Simard --- Created attachment 157664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157664=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156347|0 |1 is obsolete|| --- Comment #374 from Maryse Simard --- Created attachment 157663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157663=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156346|0 |1 is obsolete|| --- Comment #373 from Maryse Simard --- Created attachment 157662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157662=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156345|0 |1 is obsolete|| --- Comment #372 from Maryse Simard --- Created attachment 157661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157661=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156344|0 |1 is obsolete|| --- Comment #371 from Maryse Simard --- Created attachment 157660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157660=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156343|0 |1 is obsolete|| --- Comment #370 from Maryse Simard --- Created attachment 157659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157659=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Maryse Simard changed:
What|Removed |Added
Attachment #156342|0 |1
is obsolete||
--- Comment #369 from Maryse Simard ---
Created attachment 157658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157658=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
Signed-off-by: Michal Denar
Bug 17015: When using book drop mode, set check in time as closing hours
Signed-off-by: Michal Denar
Bug 17015: Automatically update calendar when creating or deleting a branch
Signed-off-by: Michal Denar
Bug 17015: Rebase and tests for discrete calendar
This patch is a rebase of all the previous patches in order to show the
discrete calendar.
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
Signed-off-by: Michal Denar
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
Bug 17015: Fixing QA tools failures
This patch fixes tests that fails with the QA tool.
To test, run the QA tool
All tests should say OK except 2 that fails.
Bug 17015: Check out with the useDaysMode preference
When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.
To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156341|0 |1 is obsolete|| --- Comment #368 from Maryse Simard --- Created attachment 157657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157657=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #156340|0 |1 is obsolete|| --- Comment #367 from Maryse Simard --- Created attachment 157656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157656=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #366 from Émily-Rose Francoeur --- Created attachment 156355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156355=edit Bug 17015 : Correction when creating a new library This patch is a rebase of all the other ones. I have also resolved an issue that occurred when creating a new library. When creating a library, days are copied from the first library in the "branches" table and added to the new library in the "discrete_calendar" table. The problem arises because the table stores libraries in alphabetical order based on their branch code. So, if the new library has a branch code that comes first in alphabetical order, no days can be added, which would prevent the calendar from functioning for that library. I resolved this issue by copying the days from the first library that appears in the "discrete_calendar" table. This way, we ensure that days will be found and copied. TEST PLAN 1) Apply the patch 2) Run installer/data/mysql/updatedatabase.pl 3) Run misc/cronjobs/add_days_discrete_calendar.pl 4) Check that the max date is today + 1 day 5) Run t/db_dependent/DiscreteCalendar.t 6) If all the test pass, then the rebase work 7) Now, go to “Koha administration > Libraries > New library” 8) In “Library code” enter “A” 9) Enter the name that you want 10) Click the “Submit” button 11) Go to “Tools > Calendar” 12) Select the calendar for the library you just created 13) If there are no errors displayed on the page, the issue is resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151450|0 |1 is obsolete|| --- Comment #365 from Émily-Rose Francoeur --- Created attachment 156354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156354=edit Bug 17015: Corrections for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151449|0 |1 is obsolete|| --- Comment #364 from Émily-Rose Francoeur --- Created attachment 156353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156353=edit Bug 17015: Miscellaneous corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151448|0 |1 is obsolete|| --- Comment #363 from Émily-Rose Francoeur --- Created attachment 156352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156352=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151447|0 |1 is obsolete|| --- Comment #362 from Émily-Rose Francoeur --- Created attachment 156351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156351=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151446|0 |1 is obsolete|| --- Comment #361 from Émily-Rose Francoeur --- Created attachment 156350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156350=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151445|0 |1 is obsolete|| --- Comment #360 from Émily-Rose Francoeur --- Created attachment 156349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156349=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151444|0 |1 is obsolete|| --- Comment #359 from Émily-Rose Francoeur --- Created attachment 156348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156348=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151443|0 |1 is obsolete|| --- Comment #358 from Émily-Rose Francoeur --- Created attachment 156347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156347=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151442|0 |1 is obsolete|| --- Comment #357 from Émily-Rose Francoeur --- Created attachment 156346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156346=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151441|0 |1 is obsolete|| --- Comment #356 from Émily-Rose Francoeur --- Created attachment 156345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156345=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151440|0 |1 is obsolete|| --- Comment #355 from Émily-Rose Francoeur --- Created attachment 156344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156344=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #151439|0 |1 is obsolete|| --- Comment #354 from Émily-Rose Francoeur --- Created attachment 156343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156343=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Émily-Rose Francoeur changed:
What|Removed |Added
Attachment #151438|0 |1
is obsolete||
--- Comment #353 from Émily-Rose Francoeur
---
Created attachment 156342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156342=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
Signed-off-by: Michal Denar
Bug 17015: When using book drop mode, set check in time as closing hours
Signed-off-by: Michal Denar
Bug 17015: Automatically update calendar when creating or deleting a branch
Signed-off-by: Michal Denar
Bug 17015: Rebase and tests for discrete calendar
This patch is a rebase of all the previous patches in order to show the
discrete calendar.
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
Signed-off-by: Michal Denar
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
Bug 17015: Fixing QA tools failures
This patch fixes tests that fails with the QA tool.
To test, run the QA tool
All tests should say OK except 2 that fails.
Bug 17015: Check out with the useDaysMode preference
When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.
To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #144258|0 |1 is obsolete|| --- Comment #352 from Émily-Rose Francoeur --- Created attachment 156341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156341=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added Attachment #144257|0 |1 is obsolete|| --- Comment #351 from Émily-Rose Francoeur --- Created attachment 156340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156340=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Émily-Rose Francoeur changed: What|Removed |Added CC||emily-rose.francoeur@inLibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #350 from Victor Grousset/tuxayo --- @Catrina in your (and your customer libraries) situation, your best bet is two get one or two of your several colleagues that are on the QA team to assess how fixable or fundamentally problematic the problems found in the earlier reviews are. comment 322 (the 2nd half is the 1st thing to look) should point to everything relevant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Dani Elder changed: What|Removed |Added CC||danielle.elder@law.utexas.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m --- Comment #349 from Catrina Berka --- Academic libraries would find this useful to limit their open hours, specifically for summer holidays. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #348 from Maryse Simard --- Created attachment 151450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151450=edit Bug 17015: Corrections for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #347 from Maryse Simard --- Created attachment 151449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151449=edit Bug 17015: Miscellaneous corrections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144273|0 |1 is obsolete|| --- Comment #346 from Maryse Simard --- Created attachment 151448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151448=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144272|0 |1 is obsolete|| --- Comment #345 from Maryse Simard --- Created attachment 151447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151447=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144271|0 |1 is obsolete|| --- Comment #344 from Maryse Simard --- Created attachment 151446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151446=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144270|0 |1 is obsolete|| --- Comment #343 from Maryse Simard --- Created attachment 151445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151445=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144269|0 |1 is obsolete|| --- Comment #342 from Maryse Simard --- Created attachment 151444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151444=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144268|0 |1 is obsolete|| --- Comment #341 from Maryse Simard --- Created attachment 151443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151443=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144264|0 |1 is obsolete|| --- Comment #340 from Maryse Simard --- Created attachment 151442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151442=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144262|0 |1 is obsolete|| --- Comment #339 from Maryse Simard --- Created attachment 151441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151441=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144261|0 |1 is obsolete|| --- Comment #338 from Maryse Simard --- Created attachment 151440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151440=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Maryse Simard changed: What|Removed |Added Attachment #144260|0 |1 is obsolete|| --- Comment #337 from Maryse Simard --- Created attachment 151439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151439=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Maryse Simard changed:
What|Removed |Added
Attachment #144259|0 |1
is obsolete||
--- Comment #336 from Maryse Simard ---
Created attachment 151438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151438=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
Signed-off-by: Michal Denar
Bug 17015: When using book drop mode, set check in time as closing hours
Signed-off-by: Michal Denar
Bug 17015: Automatically update calendar when creating or deleting a branch
Signed-off-by: Michal Denar
Bug 17015: Rebase and tests for discrete calendar
This patch is a rebase of all the previous patches in order to show the
discrete calendar.
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
Signed-off-by: Michal Denar
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
Bug 17015: Fixing QA tools failures
This patch fixes tests that fails with the QA tool.
To test, run the QA tool
All tests should say OK except 2 that fails.
Bug 17015: Check out with the useDaysMode preference
When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.
To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #335 from Shi Yao Wang --- Created attachment 144273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144273=edit Bug 17015: Always uncheck "Copy all librairies" when opening edit page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #334 from Shi Yao Wang --- Created attachment 144272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144272=edit Bug 17015: UI tweaks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #333 from Shi Yao Wang --- Created attachment 144271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144271=edit Bug 17015: Add minDate restrictions for pairs of date selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #332 from Shi Yao Wang --- Created attachment 144270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144270=edit Bug 17015: Add an option to view past holiday details in table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #331 from Shi Yao Wang --- Created attachment 144269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144269=edit Bug 17015: Allow holiday edits to be applied to all branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #330 from Shi Yao Wang --- Created attachment 144268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144268=edit Bug 17015: Add description field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #141176|0 |1 is obsolete|| --- Comment #329 from Shi Yao Wang --- Created attachment 144264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144264=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #140150|0 |1 is obsolete|| --- Comment #328 from Shi Yao Wang --- Created attachment 144262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144262=edit Bug 17015: Install scripts for DiscreteCalendar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #139851|0 |1 is obsolete|| --- Comment #327 from Shi Yao Wang --- Created attachment 144261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144261=edit Bug 17015: DatePicker/TimePicker to Flatpickr Changed all datepicker/timepicker to flatpickr + some small fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #139603|0 |1 is obsolete|| --- Comment #326 from Shi Yao Wang --- Created attachment 144260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144260=edit Bug 17015: Tests for DiscreteCalendar Signed-off-by: Michal Denar Bug 17015: Rebase and tests for discrete calendar This patch is a rebase of all the previous patches in order to show the discrete calendar. TEST PLAN: 1- Apply the patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run misc/cronjobs/add_days_discrete_calendar.pl 4- Check that the max date is today + 1 day 5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Shi Yao Wang changed:
What|Removed |Added
Attachment #139602|0 |1
is obsolete||
--- Comment #325 from Shi Yao Wang ---
Created attachment 144259
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144259=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts
Signed-off-by: Michal Denar
Bug 17015: When using book drop mode, set check in time as closing hours
Signed-off-by: Michal Denar
Bug 17015: Automatically update calendar when creating or deleting a branch
Signed-off-by: Michal Denar
Bug 17015: Rebase and tests for discrete calendar
This patch is a rebase of all the previous patches in order to show the
discrete calendar.
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)
Signed-off-by: Michal Denar
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
Bug 17015: Fixing QA tools failures
This patch fixes tests that fails with the QA tool.
To test, run the QA tool
All tests should say OK except 2 that fails.
Bug 17015: Check out with the useDaysMode preference
When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.
To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #139601|0 |1 is obsolete|| --- Comment #324 from Shi Yao Wang --- Created attachment 144258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144258=edit Bug 17015: Schema file for new discrete_calendar table Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Shi Yao Wang changed: What|Removed |Added Attachment #139599|0 |1 is obsolete|| --- Comment #323 from Shi Yao Wang --- Created attachment 144257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144257=edit Bug 17015: Performance comparison (images) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #322 from Victor Grousset/tuxayo --- Blou: > As I stated in comment 312 last month, we do not care much about performance > anymore. Jonathan: > See also comment #121 > [note, comment 121 is about performances] Is there actually a worry about performances? At the time of the benchmarks with the test data, checkins & checkouts & fines.pl was either a bit faster or much faster depending on which of the 3 operations. So there doesn't seem to be much of a risk of regression. Or was the worry something else? Still need to have someone else replicate on the current codebase *but only if there isn't other concerns.* Jonathan: > and #154. > [link: comment 154] Ok so next would be to hope for one or two people from QA to check if the fundamental idea of the patch is good enough. And how much of Comment 119 still stands. I can try to advertise it. Meanwhile (or worse case in the long run), having it here is great so other libraries can pick it and report bugs as we have seen :D I know it's frustrating. Though the situation looks like lack of QAing resources in the community rather than fad. And the large patches are suffering the most from the large QA queue. Just looking how much the recalls patches had to be brought up in meetings and emails discussion before they could be reviewed enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Eric Bégin changed: What|Removed |Added CC|charles.far...@inlibro.com, | |the-minh.lu...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #321 from Blou --- As I stated in comment 312 last month, we do not care much about performance anymore. This patch exists because it is just a better way to handle schedules and everything related to it (opening times, past fines, etc...) is a discrete (the mathematical meaning) manner. Your comments were noted years ago, we do not intend to waste any time trying to convince anyone about it. We came back to it because there seemed to be an genuine interest by some Koha users. But thank you for your reminder, I'll make sure we do not burn too much energy in the process, while still service those. We have enough patches in architecture purgatory. This patch won't be recoded to follow the latest fad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #320 from Jonathan Druart --- You should make sure the concept of this patch is approved by other developers before spending more time on rewriting/splitting this patchset. See also comment #121, and #154. > * did you take a look at Date::Holidays? 4 years old question still pending for answers, etc. Last release of Date::Holidays was on Oct 10, 2022! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #319 from Blou --- Thanks Bjorn, we didn't know it was used by anyone else. Puts more pressure now on us to keep it straight. :) We're discovering new issues now that we playing with 22.05, and Maryse is fixing them. After release to our customers, we hope to find time to split the patches in multiple cute ones as demanded. It won't happen until december though, I fear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #318 from Björn Nylén --- (In reply to Victor Grousset/tuxayo from comment #317) > Thanks Björn, that's the kind of feedback that can help. > > Do you recall more about the quirks in the admin page? > > > How to > > ? Talked to my colleagues and the quirk was that all calendar changes were for your logged in library, ignoring the selected branch. However the last patch from M Simard should address that. Disregard "How to.." prob had a thought but changed my mind :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #317 from Victor Grousset/tuxayo --- Thanks Björn, that's the kind of feedback that can help. Do you recall more about the quirks in the admin page? > How to ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Björn Nylén changed: What|Removed |Added CC||bjorn.ny...@ub.lu.se --- Comment #316 from Björn Nylén --- We're also using the Discrete calendar in our library since we went live with Koha 2018. (Thx for the thankless work by the way). It would be a valuable addition to the Koha in our opinion. From our experiences it works very well and we've not experienced anything odd or any malfunctions. (Apart from some quirks in the admin page) Quite a large patch and and we're not sure we are using enough of Koha to be confident to say the *every* feature is on par with the defualt calendar. How to -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #315 from Maryse Simard --- Created attachment 141176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141176=edit Bug 17015: Use branchcode when adding or modifying a holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #314 from Blou --- I'd like to think we are at parity, but I'm not coding it. I'll trust my team. We have over 50 clients using it, so if something is missing, it crashes early and hard enough that we spot it and fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #313 from Victor Grousset/tuxayo --- (In reply to Blou from comment #312) > You can see comment 12 from Mehdi, for some summary. Thanks, that's great. > There was also emails > sent to the lists at the time, describing the plan. And replies that > basically shut it down. I dug in koha-devel and found the early proposal and later the "emails sent to the lists at the time" but did find the replies that basically shut it down. Or was that at the moment of the early proposal? See 2016-August emails bellow. https://lists.koha-community.org/pipermail/koha-devel/2016-July/042854.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042856.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042858.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042859.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042865.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042867.html https://lists.koha-community.org/pipermail/koha-devel/2016-July/042871.html https://lists.koha-community.org/pipermail/koha-devel/2016-August/042881.html https://lists.koha-community.org/pipermail/koha-devel/2016-August/042890.html https://lists.koha-community.org/pipermail/koha-devel/2017-January/043420.html https://lists.koha-community.org/pipermail/koha-devel/2017-February/043454.html Is the new calendar at feature parity with the current one? Or are there features that you didn't need and didn't reimplemented in the new backend or new UI? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #312 from Blou --- You can see comment 12 from Mehdi, for some summary. There was also emails sent to the lists at the time, describing the plan. And replies that basically shut it down. It started with the calendar doing its calculation by adding one to every date object and creating a new one. A very painful way to calculate things, if you ask me. Then we also didn't like the fact that past dates were lost to modifications into the calendar. You modify a holiday for the future, and it screw your calculation in the past. So instead of having "patterns" for opening and closing, we have a discrete entry for each date. By preserving it (as long as needed), past calculation are always correct. We also added opening and close time. And we redid the UI to allow for an easier management of all that. It's pretty easy to manipulate the calendar how we want when each date can be modified individually. And we added some logic to spot the recurring pattern and create the new dates with most likely values, including unique dates like Easter, national holiday, etc... Of course, since they are unique dates in the calendar, they can be adjusted as needed, easily, a long time ahead. We've been using it for 6 years now. It requires some maintenance to follow the master, but it's worth it. Regarding the patches: we did split as asked, then, and we also invested to go Schema instead of SQL, and tried to please everyone. At some point it was just not worth it considering the low likelyhood of moving ahead relative to the effort to follow. So that's it. I already ask our dev to not switch it back to Need Signoff after the next adjustment. We'll figure out something so that our automated tool pick up when the patch doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #311 from Victor Grousset/tuxayo --- (In reply to Joonas Kylmälä from comment #310) > maybe you mean with no interest as in no interest to review? Yes, there is the usual problem with getting people motivated to review large patches. That part of the problem is not specific to this patchset. It's a general problem of being able to chew such a large bite and the general bottleneck of QA and signoff workforce. And it's enough to block stuff during years until someone brings it up multiple times in meetings to ask for next steps to move it forward and motivate testers and reviewers. That's how it happened with recalls. > As the motivation and > benefits of the patches is not super clear (due to the missing descriptions > in patches) I'm thinking that could have played its part here. However, from > the first comment on this bug I see that performance seems to be the reason > for the work. To help the stars align, at least a pitch about what this patch brings would help promoting it. > I'm quite confident that if the patches with proper descriptions were > submitted they would move forward or be rejected as another approach to > solving the bug would be considered better. We might already be at this step. Comment 154 mentions that «The fundamental idea of the patches should be discussed» Does anyone know which are the controversial points? Or who to ask? Obviously Jonathan when they come back of their current long leave. Who else knows about this? Blou: You followed this patch before comment 154, do you remember something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #310 from Joonas Kylmälä --- (In reply to Blou from comment #309) > We have stopped maintaining the patch as a formal prospect long ago, after > being told there was no need nor interest for it. It is an endeavour, and > maintaining it "proper" is very time consumming. > > > So we maintain it for ourselves and our clients (maybe hoping that maybe one > day the stars will align?), as it is vastly superior to the current > "calendar" in Koha. > > > We tried many splits over the years, following recommendations. Right now > it's mostly for the sake of easy "git apply". I see many people here in the comments interested in these patches, maybe you mean with no interest as in no interest to review? As the motivation and benefits of the patches is not super clear (due to the missing descriptions in patches) I'm thinking that could have played its part here. However, from the first comment on this bug I see that performance seems to be the reason for the work. I'm quite confident that if the patches with proper descriptions were submitted they would move forward or be rejected as another approach to solving the bug would be considered better. Actually what's the bug here? Calendar slow? If so, the bug report title should be changed. For the Calendar slowness there might be other fixes too so those need to be explored and documented. In any case, until the patches are redone so that they could be reviewed may I ask to keep the status in Failed QA so people don't spend unnecessarily time on reviewing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
