[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #58 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #57 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #56 from Marcel de Rooy  ---
Final comment:
Still not completely happy about it (see earlier comments) but this is also
caused by the condition of the current code.
Note that point 2 of comment40 requires opening a new report for SIP.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #53 from Marcel de Rooy  ---
Created attachment 61748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61748=edit
Bug 17560: Add a message when a patron checking in using the self checkout

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #54 from Marcel de Rooy  ---
Created attachment 61749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61749=edit
Bug 17560: Improve strenght of hold existence test

This patch is a QA follow-up to fix several issues:
- 1 call to GetReserveFee was wrong in ModReserveFill
- Update DB entry was wrong and insufficient
- Add robustness to the tests in sco-main

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #55 from Marcel de Rooy  ---
Created attachment 61750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61750=edit
Bug 17560: Improve wordings

Signed-off-by: Marcel de Rooy 
Amended as per comment33 of Alex Sassmannshausen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #52 from Marcel de Rooy  ---
Created attachment 61747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61747=edit
Bug 17560: Update the wording when a patron places a hold at the OPAC

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57241|0   |1
is obsolete||
  Attachment #57242|0   |1
is obsolete||
  Attachment #57243|0   |1
is obsolete||
  Attachment #57244|0   |1
is obsolete||
  Attachment #57245|0   |1
is obsolete||
  Attachment #60993|0   |1
is obsolete||
  Attachment #61669|0   |1
is obsolete||

--- Comment #49 from Marcel de Rooy  ---
Created attachment 61744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61744=edit
Bug 17560: Add a third option to HoldFeeMode

This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
syspref.
The existing 'always' option is renamed with 'any_time_is_placed''

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #50 from Marcel de Rooy  ---
Created attachment 61745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61745=edit
Bug 17560: Update current code

This patch updates the current code to make it works with the new
option's name of the syspref.
It also refactor the tests to make them more reusable and robust.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #51 from Marcel de Rooy  ---
Created attachment 61746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61746=edit
Bug 17560: Hold fee placement at point of checkout

Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category
with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #48 from Jonathan Druart  
---
As you may have noticed the Circulation code is not robust and does not give us
useful return values or enough trust in the actions that have been done (or
maybe not).
I would like not to add anything to this enhancement to add feedback to the
users, it is not easy to provide a good patch to do such a job at the moment
(i.e. with the current code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #47 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #46)
> What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge
> to 5 (a weird combination), Koha still allows me to checkout the book,
> charges me 13 AND says Cannot check out ! This is definitely a bug but not
> from this report.

Or my interpretation. Should we read it as: Can no longer check out !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #46 from Marcel de Rooy  ---
I obsoleted the last patch. It is not really what I had in mind.
I found out what my problem was in the charges display:
HoldsInNoissuesCharge = Dont include
RentalsInNoissuesCharge = Include
If you set HoldsInNoissuesCharge to include, you will have the same display as
a rental fee. But what would be the side effects?

I am not sure if the current code really works fine if you would e.g. combine a
hold fee with a rental fee (playing with noissuescharge too). But we are
leaving the scope of this bug here.

In the issuing process CanBookBeIssued is called, it does not care about the
hold fee charged later. And in this case it should not block the issue here for
a hold fee only.

What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge to
5 (a weird combination), Koha still allows me to checkout the book, charges me
13 AND says Cannot check out ! This is definitely a bug but not from this
report.

In conclusion: Since Koha does not handle these charges correctly here, I would
not enforce point 1 from comment 40. Since we move point 2 to another report,
point 3 makes no sense yet..

Before passing QA: Do you still have any feedback to these last findings?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61691|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #45 from Marcel de Rooy  ---
> > [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31,
> > 34)
> > Note that Colin suggested to do this on another report.
> > In that case we could perhaps add a small "disclaimer" to the preference
> > that SIP does apply, but not show the fee at checkout time.
> > And as a side note, SIP currently does not show a fee when placing a hold.
> > But this is just a theoretical thing; not really used.
> 
> Same as previously, the message did not show up before. Why should we add a
> warning to the pref?
Same as before too. You changed behavior. But as stated before, this could go
to another report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #44 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #41)
> (In reply to Marcel de Rooy from comment #40)
> > [1] If we checkout in the staff client, wouldn't it be good to also show a
> > message? (Just like the sco message.) 
> > See comment23, 27 and 30. Show the fee under Attention just like rental 
> > fees.
> 
> I would consider this as a new enhancement, the info did not show up before
> this patch set.
> I will submit a patch anyway.

The info did not show up before since the hold fee was not charged at checkout
time before. So this is not a new enhancement.
I am still looking at your patch btw. You may have a point somehow, since the
rental charge is not presented as an individual charge but as a total amount.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #43 from Marcel de Rooy  ---
+$hold_existed = Koha::Holds->search({ -or => { 'biblionumber'
=> $item->biblionumber, 'itemnumber' => $item->itemnumber}})->count;

versus

+my $had_an_hold_placed_on_it = Koha::Holds->search({
borrowernumber => $borrower->{borrowernumber}, itemnumber => $item->itemnumber
})->count;

This difference may actually illustrate why a consolidation would be nice.
Will amend it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #42 from Jonathan Druart  
---
Created attachment 61691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61691=edit
Bug 17560: Add a message when a patron collecting a hold (staff interface)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #41 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #40)
> [1] If we checkout in the staff client, wouldn't it be good to also show a
> message? (Just like the sco message.) 
> See comment23, 27 and 30. Show the fee under Attention just like rental fees.

I would consider this as a new enhancement, the info did not show up before
this patch set.
I will submit a patch anyway.

> [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31,
> 34)
> Note that Colin suggested to do this on another report.
> In that case we could perhaps add a small "disclaimer" to the preference
> that SIP does apply, but not show the fee at checkout time.
> And as a side note, SIP currently does not show a fee when placing a hold.
> But this is just a theoretical thing; not really used.

Same as previously, the message did not show up before. Why should we add a
warning to the pref?

> [3] Since we need to show the same message at three locations, we could
> consolidate that code (now in sco-main.pl)

Messages are now in staff and opac, there are no way to centralise them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #40 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #36)
> Marcel, by chance could you rephrase with what you want on QAing?

Of course :)

[1] If we checkout in the staff client, wouldn't it be good to also show a
message? (Just like the sco message.) 
See comment23, 27 and 30. Show the fee under Attention just like rental fees.

[2] Provide a message to the SIP terminal at checkout time. (a.o. comment31,
34)
Note that Colin suggested to do this on another report.
In that case we could perhaps add a small "disclaimer" to the preference that
SIP does apply, but not show the fee at checkout time.
And as a side note, SIP currently does not show a fee when placing a hold. But
this is just a theoretical thing; not really used.

[3] Since we need to show the same message at three locations, we could
consolidate that code (now in sco-main.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #39 from Marcel de Rooy  ---
(In reply to Alex Sassmannshausen from comment #33)
> Fwiw, I agree with this reasoning you, Marcel (though I think the tense
> 'collecting' is not quite right):
> You will be charged a hold fee of [% RESERVE_CHARGE %] when you collect the
> item.

Amended last patch. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61301|0   |1
is obsolete||

--- Comment #38 from Marcel de Rooy  ---
Created attachment 61669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61669=edit
Bug 17560: Improve wordings

Signed-off-by: Marcel de Rooy 
Amended as per comment33 of Alex Sassmannshausen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #37 from Jonathan Druart  
---
Back to the SO queue as the only issue seems to be nitpicking wording.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #36 from Jonathan Druart  
---
Marcel, by chance could you rephrase with what you want on QAing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #35 from Marcel de Rooy  ---
(In reply to Colin Campbell from comment #34)
> (In reply to Marcel de Rooy from comment #32)
> > Just for completeness:
> > Colin: See comment 24. The currently applied hold fee at the time of placing
> > a hold is not shown in SIP. I guess that placing a hold via SIP is not that
> > common as checking out.
> 
> I suspect the hold messages are not used in practice. Hence the code only
> returns failure messages in its current skeletal state. If any are used it
> would be the cancel and possibly alter functions, I dont think self checks
> have the interface to let you search for an item to hold in order to place
> it, whereas it could possible retrieve a user's holds to allow them to
> cancel them.
> 
> I would imagine that items are not checked out to the holder via self check
> as they have to collect the item from a staffed hold shelf.
> 
> I may be wrong but I think if we are going to change the sip code I'd like
> to have a user's scenario of what the workflow is rather than concocting it
> from possibly mistaken abstractions. So I suggest any sip implications be
> dealt with in a separate call

Well, at least I learned a new word :) Concoct. My message stated more or less
the same: placing a hold in SIP is probably useless.
If we put the SIP change in another report, you may have the effect that this
patch is pushed into 17.05 and the sip followup is not..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #34 from Colin Campbell  ---
(In reply to Marcel de Rooy from comment #32)
> Just for completeness:
> Colin: See comment 24. The currently applied hold fee at the time of placing
> a hold is not shown in SIP. I guess that placing a hold via SIP is not that
> common as checking out.

I suspect the hold messages are not used in practice. Hence the code only
returns failure messages in its current skeletal state. If any are used it
would be the cancel and possibly alter functions, I dont think self checks have
the interface to let you search for an item to hold in order to place it,
whereas it could possible retrieve a user's holds to allow them to cancel them.

I would imagine that items are not checked out to the holder via self check as
they have to collect the item from a staffed hold shelf.

I may be wrong but I think if we are going to change the sip code I'd like to
have a user's scenario of what the workflow is rather than concocting it from
possibly mistaken abstractions. So I suggest any sip implications be dealt with
in a separate call

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #33 from Alex Sassmannshausen 
 ---
(In reply to Marcel de Rooy from comment #22)
> (In reply to Alex Sassmannshausen from comment #20)
> > Claire and I have deliberated for a bit at the hackfest, and we think the
> > following would be minor improvements (though it kind of works as it is).
> 
> Great. Thanks.
> 
> > > There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> > You will be charged a hold fee of [% _ %] for collecting this item
> 
> Although I am not a native speaker, maybe we can still improve here :) Note
> that opac-reserve tells this to the user. So the time is placing the hold,
> but collecting it is still in the future. We do not charge for collecting
> btw, we just charge when you collect.. Shouldn't it be better to say You
> will be charged WHEN collecting? (Very strictly, we can't say THIS item;
> could be a biblio level hold. Maybe: book, material, or just 'it'.)
> So I would opt for: You will be charged WHEN collecting THE item.
> No blocker btw.

Fwiw, I agree with this reasoning you, Marcel (though I think the tense
'collecting' is not quite right):
You will be charged a hold fee of [% RESERVE_CHARGE %] when you collect the
item.

Jonathan, would you be happy for me to add a patch for this?

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #32 from Marcel de Rooy  ---
Just for completeness:
Colin: See comment 24. The currently applied hold fee at the time of placing a
hold is not shown in SIP. I guess that placing a hold via SIP is not that
common as checking out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #31 from Marcel de Rooy  ---
(In reply to Colin Campbell from comment #29)
> Sip calls CanBookBeIssued and will need to be told in the return that the
> issue requires a fee to be paid - It will then handle it much as it does
> rental fees.

Thx Colin for your quick response.
There is a fundamental difference with this fee. The user cannot acknowledge it
anymore as with a rental fee. He already agreed with this fee when he placed
the hold. In other words, CanBookBeIssued does not look at it and AddIssue will
just charge the fee via MoveReserve/ModReserveFill.
But just as we show the fee on the self checkout, we need to show a message imo
on the sip terminal about the fee applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #30 from Marcel de Rooy  ---
(In reply to Fiona Borthwick from comment #27)
> (In reply to Marcel de Rooy from comment #23)
> > Just another question: If we checkout in the staff client, wouldn't it be
> > good to also show a message? A staff member could remind the patron that the
> > fee is applied now, but he does not see it happening.
> 
> I think this would be a 'nice to have' feature but not essential so perhaps
> it could be a phase 2 follow up. Items with rental fees show an alert at
> checkout so an alert would be consistent with this. However in large, busy
> public libraries for example with lots of customers collecting holds, an
> alert may be more of a hindrance.

Thx Fiona for your feedback.
A busy librarian may ignore alerts at his own responsibility. (In this case the
user has been informed when he placed the hold.)
But yes, I agree that it would be consistent to show the alert just as a rental
charge is shown under the attention label of staff checkout. And I would rather
see it on this report; it is a small change and within scope.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #29 from Colin Campbell  ---
(In reply to Marcel de Rooy from comment #28)
> (In reply to Martin Renvoize from comment #26)
> > Comment from Colin regarding SIP (He's on leave today, so I've replied for
> > him after a conversation about this yesterday):
> > 
> > "I think if user tries to issue the item you will see that there is a fee
> > associated and the unit should take that from the user - similar to rental
> > fees - we just need to check that is returned"
> 
> Martin, could you translate this for me? :)
> I am not sure what you or Colin mean here.
> Do you want a change, or are you comfortable with the current status?

Sip calls CanBookBeIssued and will need to be told in the return that the issue
requires a fee to be paid - It will then handle it much as it does rental fees.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #28 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #26)
> Comment from Colin regarding SIP (He's on leave today, so I've replied for
> him after a conversation about this yesterday):
> 
> "I think if user tries to issue the item you will see that there is a fee
> associated and the unit should take that from the user - similar to rental
> fees - we just need to check that is returned"

Martin, could you translate this for me? :)
I am not sure what you or Colin mean here.
Do you want a change, or are you comfortable with the current status?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #27 from Fiona Borthwick  ---
(In reply to Marcel de Rooy from comment #23)
> Just another question: If we checkout in the staff client, wouldn't it be
> good to also show a message? A staff member could remind the patron that the
> fee is applied now, but he does not see it happening.

I think this would be a 'nice to have' feature but not essential so perhaps it
could be a phase 2 follow up. Items with rental fees show an alert at checkout
so an alert would be consistent with this. However in large, busy public
libraries for example with lots of customers collecting holds, an alert may be
more of a hindrance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #26 from Martin Renvoize  ---
Comment from Colin regarding SIP (He's on leave today, so I've replied for him
after a conversation about this yesterday):

"I think if user tries to issue the item you will see that there is a fee
associated and the unit should take that from the user - similar to rental fees
- we just need to check that is returned"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Marcel de Rooy  ---
Changing status to reflect need for feedback (comment23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #24 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #23)
> Just another question: If we checkout in the staff client, wouldn't it be
> good to also show a message? A staff member could remind the patron that the
> fee is applied now, but he does not see it happening.

Not to talk about SIP.
This 'fortunately' does not look very promising currently in do_hold:
AddReserve( $branch, $borrower->{borrowernumber}, $bibno,
GetBiblioItemByBiblioNumber($bibno) );
# unfortunately no meaningful return value
$self->ok(1);
return $self;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #23 from Marcel de Rooy  ---
Just another question: If we checkout in the staff client, wouldn't it be good
to also show a message? A staff member could remind the patron that the fee is
applied now, but he does not see it happening.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #22 from Marcel de Rooy  ---
(In reply to Alex Sassmannshausen from comment #20)
> Claire and I have deliberated for a bit at the hackfest, and we think the
> following would be minor improvements (though it kind of works as it is).

Great. Thanks.

> > There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> You will be charged a hold fee of [% _ %] for collecting this item

Although I am not a native speaker, maybe we can still improve here :) Note
that opac-reserve tells this to the user. So the time is placing the hold, but
collecting it is still in the future. We do not charge for collecting btw, we
just charge when you collect.. Shouldn't it be better to say You will be
charged WHEN collecting? (Very strictly, we can't say THIS item; could be a
biblio level hold. Maybe: book, material, or just 'it'.)
So I would opt for: You will be charged WHEN collecting THE item.
No blocker btw.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #18 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #15)
> BTW Why not just call GetReserveFee here instead? You do not need to check
> holds and account_lines anymore. And additionally you can pass the exact
> amount in the message.

I tried to display the amount, but since we do not handle the display of price
yet, I do not think it is ready.
Without the currency symbol, the number alone looks weird, and with the
currency symbol the display will be wrong half of the time...

> Please rename bug_X.sql.

I do not think this is necessary, I will have to rewrite the original patches
and reupload all of them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #17 from Jonathan Druart  
---
Created attachment 60993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60993=edit
Bug 17560: Improve strenght of hold existence test

This patch is a QA follow-up to fix several issues:
- 1 call to GetReserveFee was wrong in ModReserveFill
- Update DB entry was wrong and insufficient
- Add robustness to the tests in sco-main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #16 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #15)
> QA Comment
> Code looks good to me. Note some wording issues and one blocker in the db
> revision. Did not yet test the interface.
> 
> not_always is kind of a vague name for an option ;)
> There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> There is a charge of [% RESERVE_CHARGE %] for placing this hold
> Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
> hold ?
> You have been charged for collecting this item.
> Why did they charge me? Shouldn't you mention the the term "hold fee" here
> too?


Can we get a native English speaker confirm the wordings?


> sco-main.pl
> You check if a hold exists before issuing. Shouldn't you check for the
> borrowernumber too?

Indeed.

> BTW Why not just call GetReserveFee here instead? You do not need to check
> holds and account_lines anymore. And additionally you can pass the exact
> amount in the message.

The idea was to make sure the patron has been charged. From the circulation and
reserves modules we are never really sure that what we want to happen will
happen

> If you would still check account_lines, why not search for "Reserve Charge -
> $title" too? 

To avoid to depend on a string that could change, but I can add it if you think
it's safer.

> Please rename bug_X.sql.
> Additionally, if the pref is set to 'always', you should now change the
> value to any_time_is_placed. Since you remove always !!

Indeed, will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Marcel de Rooy  ---
QA Comment
Code looks good to me. Note some wording issues and one blocker in the db
revision. Did not yet test the interface.

not_always is kind of a vague name for an option ;)
There is a charge of [% RESERVE_CHARGE %] for collecting this hold
There is a charge of [% RESERVE_CHARGE %] for placing this hold
Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
hold ?
You have been charged for collecting this item.
Why did they charge me? Shouldn't you mention the the term "hold fee" here too?

sco-main.pl
You check if a hold exists before issuing. Shouldn't you check for the
borrowernumber too?
BTW Why not just call GetReserveFee here instead? You do not need to check
holds and account_lines anymore. And additionally you can pass the exact amount
in the message.
If you would still check account_lines, why not search for "Reserve Charge -
$title" too? 

Please rename bug_X.sql.
Additionally, if the pref is set to 'always', you should now change the value
to any_time_is_placed. Since you remove always !!

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

--- Comment #14 from Marcel de Rooy  ---
QA: Looking here now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #13 from Sally Healey  
---
Hi Martin,

It's a very similar bug (it was our original spec) - but after some internal
discussion, we altered the spec, and this bug was logged and sponsored instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #12 from Martin Renvoize  ---
My bad, they are subtly different.. one is 'Charge on collection' the other is
'Charge when ready for collection'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #11 from Martin Renvoize  ---
This is a dupe of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16817 right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #7 from Josef Moravec  ---
Created attachment 57242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57242=edit
[SIGNED-OFF] Bug 17560: Update current code

This patch updates the current code to make it works with the new
option's name of the syspref.
It also refactor the tests to make them more reusable and robust.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #9 from Josef Moravec  ---
Created attachment 57244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57244=edit
[SIGNED-OFF] Bug 17560: Update the wording when a patron places a hold at the
OPAC

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #8 from Josef Moravec  ---
Created attachment 57243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57243=edit
[SIGNED-OFF] Bug 17560: Hold fee placement at point of checkout

Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category
with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #10 from Josef Moravec  ---
Created attachment 57245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57245=edit
[SIGNED-OFF] Bug 17560: Add a message when a patron checking in using the self
checkout

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57233|0   |1
is obsolete||
  Attachment #57234|0   |1
is obsolete||
  Attachment #57235|0   |1
is obsolete||
  Attachment #57236|0   |1
is obsolete||
  Attachment #57237|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 57241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57241=edit
[SIGNED-OFF] Bug 17560: Add a third option to HoldFeeMode

This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
syspref.
The existing 'always' option is renamed with 'any_time_is_placed''

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16817

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #1 from Jonathan Druart  
---
Created attachment 57233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57233=edit
Bug 17560: Add a third option to HoldFeeMode

This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
syspref.
The existing 'always' option is renamed with 'any_time_is_placed''

Sponsored-by: Cheshire Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #2 from Jonathan Druart  
---
Created attachment 57234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57234=edit
Bug 17560: Update current code

This patch updates the current code to make it works with the new
option's name of the syspref.
It also refactor the tests to make them more reusable and robust.

Sponsored-by: Cheshire Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #4 from Jonathan Druart  
---
Created attachment 57236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57236=edit
Bug 17560: Update the wording when a patron places a hold at the OPAC

Sponsored-by: Cheshire Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #3 from Jonathan Druart  
---
Created attachment 57235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57235=edit
Bug 17560: Hold fee placement at point of checkout

Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category
with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #5 from Jonathan Druart  
---
Created attachment 57237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57237=edit
Bug 17560: Add a message when a patron checking in using the self checkout

Sponsored-by: Cheshire Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/