[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #39 from Andrew Fuerste-Henry  ---
This wasn't ever intended to place item-level holds. We're placing a bunch of
bib-level holds for our club patrons in a random order, with the expectation
that the bib will contain multiple copies of the same title and everyone will
get a copy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||27330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330
[Bug 27330] Wrong return status when no enrollments in club holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #38 from Jonathan Druart  
---
How do we add a hold for club at item level?
It's all what I see on the form: https://snipboard.io/cOIK8q.jpg

ie. how do I fill club_holds.item_id with something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #37 from Martin Renvoize  ---
(In reply to Agustín Moyano from comment #36)
> (In reply to Jonathan Druart from comment #35)
> > Thanks Agustin, it's a bit more clear.
> > 
> > More questions then :)
> > Is there a plan to have a UI view of club_holds_to_patron_holds?
> 
> I don't remember exactly what we planned for this table, but I do remember
> that we created them for traceability. 
> 
> But it's not a bad idea to have a "club holds history" in a near future.
> 
> > If not, what's the point of it? Could not we replace it with entries in
> > action_logs?
> 
> I didn't know action_logs table existed.. I should study it.
> 
> > The enum on error_code is weird, and will lead to issues: everytime a new
> > status is returned by the subroutine we will need to adjust the enum. It
> > seems that it should be a simple varchar.
> 
> You're right.. It's a bad design
> 
> > By the way what is the difference between error_code and error_message?
> > (Documentation is missing in kohastructure.sql :)
> 
> error_code holds the result of C4::Reserves::CanItemBeReserved or
> C4::Reserves::CanBookBeReserved depending if you are trying to hold on a
> item or a biblio.
> 
> error_message says "Could not create hold for Patron(".$patron_id.")" if
> C4::Reserves::AddReserve fails.. 
> 
> maybe we can have only one column of error messages.

This has a translation code smell to me.. adding such a message in the database
means it's not translatable.. we should stick to codes and then use the
templates to allow translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #36 from Agustín Moyano  ---
(In reply to Jonathan Druart from comment #35)
> Thanks Agustin, it's a bit more clear.
> 
> More questions then :)
> Is there a plan to have a UI view of club_holds_to_patron_holds?

I don't remember exactly what we planned for this table, but I do remember that
we created them for traceability. 

But it's not a bad idea to have a "club holds history" in a near future.

> If not, what's the point of it? Could not we replace it with entries in
> action_logs?

I didn't know action_logs table existed.. I should study it.

> The enum on error_code is weird, and will lead to issues: everytime a new
> status is returned by the subroutine we will need to adjust the enum. It
> seems that it should be a simple varchar.

You're right.. It's a bad design

> By the way what is the difference between error_code and error_message?
> (Documentation is missing in kohastructure.sql :)

error_code holds the result of C4::Reserves::CanItemBeReserved or
C4::Reserves::CanBookBeReserved depending if you are trying to hold on a item
or a biblio.

error_message says "Could not create hold for Patron(".$patron_id.")" if
C4::Reserves::AddReserve fails.. 

maybe we can have only one column of error messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #35 from Jonathan Druart  
---
Thanks Agustin, it's a bit more clear.

More questions then :)
Is there a plan to have a UI view of club_holds_to_patron_holds?
If not, what's the point of it? Could not we replace it with entries in
action_logs?

The enum on error_code is weird, and will lead to issues: everytime a new
status is returned by the subroutine we will need to adjust the enum. It seems
that it should be a simple varchar.
By the way what is the difference between error_code and error_message?
(Documentation is missing in kohastructure.sql :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #34 from Agustín Moyano  ---
Hi Jonathan, I'll respond between lines:

(In reply to Jonathan Druart from comment #33)
> Can you explain what is the purpose of the new table?

This bug adds 2 new tables:

club_holds and club_holds_to_patron_holds

club_holds has the information of a hold request or error for a certain club.


> club_holds_to_patron_holds.error_code seems super odd, it takes the return
> of CanBookBeReserved and put it in DB??

Think of club_holds_to_patron_holds table more like a log.. it has the
information of which holds where generated from a certain club hold, and in
case of error, it has the information of the error message, error code and
patron.

So, if someone, someday wants to create a report on how many holds where made
through club holds, they have the info.

> How is this table populated? Only from an API endpoint that is not used from
> Koha?

It's populated in the API endpoint, but it's used in
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 150



-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #33 from Jonathan Druart  
---
Can you explain what is the purpose of the new table?

club_holds_to_patron_holds.error_code seems super odd, it takes the return of
CanBookBeReserved and put it in DB??

How is this table populated? Only from an API endpoint that is not used from
Koha?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Julian Maurice  changed:

   What|Removed |Added

 Blocks||24587


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587
[Bug 24587] reserve/placerequest.pl is not used anymore and should be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546
[Bug 24546] Club/Hold.t has a wrong call to build_sample_item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #32 from Jonathan Druart  
---
See bug 24410.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410
[Bug 24410] Multi holds broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #31 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #30)
> I still do not manage to find regression, and found:
> 
> 1043 if($('.datepickerfrom_hidden').length)
> 1044 data.hold_date =
> $('.datepickerfrom_hidden').val()||null;
> 1045 if($('input[name="itemtype"]').length) {
> 1046 data.item_type =
> $('input[name="itemtype"]').val()||null;
> 1047 }
> 
> Are we safe?

My only concern is not about attribute mappings, but on the multi_hold use
case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #30 from Jonathan Druart  
---
I still do not manage to find regression, and found:

1043 if($('.datepickerfrom_hidden').length)
1044 data.hold_date =
$('.datepickerfrom_hidden').val()||null;
1045 if($('input[name="itemtype"]').length) {
1046 data.item_type =
$('input[name="itemtype"]').val()||null;
1047 }

Are we safe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #29 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > At first glance I'd say there is a item_type (expected by
> > Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
> > Also reserve_date vs hold_date
> > 
> > Either I am missing something or this patchset was not ready to be pushed.
> 
> Can you file a bug for that?

We need to restore the call to placerequest.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #28 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #27)
> At first glance I'd say there is a item_type (expected by
> Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
> Also reserve_date vs hold_date
> 
> Either I am missing something or this patchset was not ready to be pushed.

Can you file a bug for that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #27 from Jonathan Druart  
---
At first glance I'd say there is a item_type (expected by
Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
Also reserve_date vs hold_date

Either I am missing something or this patchset was not ready to be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #26 from Jonathan Druart  
---
-
+


Was this change expected?

Either it was and we should remove placerequest.pl as it was the only
occurrence, or we should restore the call.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This new feature adds the   |This new feature adds the
  release notes|ability for clubs to place  |ability for clubs to place
   |a hold for bibs. When such  |a hold for bibs. When such
   |a hold is placed, in the|a hold is placed, in the
   |background a hold will be   |background a hold will be
   |automatically placed for|automatically placed for
   |each member of the group in |each member of the group in
   |random order.
  |random order.
   |
   |
   |Sponsored   |
   |by: Southeast Kansas|
   |Library System  |
   | |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Margaret  changed:

   What|Removed |Added

  Text to go in the|This new feature adds the   |This new feature adds the
  release notes|ability for clubs to place  |ability for clubs to place
   |a hold for bibs. When such  |a hold for bibs. When such
   |a hold is placed, in the|a hold is placed, in the
   |background a hold will be   |background a hold will be
   |automatically placed for|automatically placed for
   |each member of the group in |each member of the group in
   |random order.   |random order.
   ||
   ||Sponsored
   ||by: Southeast Kansas
   ||Library System
   ||
 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857
[Bug 23857] Club holds endpoint not setting Location header
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Katrin Fischer  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||katrin.fisc...@bsz-bw.de
  Component|Architecture, internals,|Hold requests
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|Sponsored by South East |This new feature adds the
  release notes|Kansas Library System.  |ability for clubs to place
   |This new feature adds the   |a hold for bibs. When such
   |ability for clubs to place  |a hold is placed, in the
   |a hold for bibs. When such  |background a hold will be
   |a hold is placed, in the|automatically placed for
   |background a hold will be   |each member of the group in
   |automatically placed for|random order.
   |each member of the group in |
   |random order.   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||23710


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
[Bug 23710] Holds broken, displays a JSON page with an error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #25 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #24 from Kyle M Hall  ---
Created attachment 93258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93258=edit
Bug 19618: (QA follow-up) POD Fix

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #20 from Kyle M Hall  ---
Created attachment 93254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93254=edit
Bug 19618: [DO NOT PUSH] (follow-up) Schema structure

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #23 from Kyle M Hall  ---
Created attachment 93257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93257=edit
Bug 19618: Add tests

This patch adds tests for new features

To test:
1) prove t/db_dependent/Koha/Club/Enrollment.t
2) prove t/db_dependent/Koha/Club/Hold.t
3) prove t/db_dependent/api/v1/clubs_holds.t
4) Sign off

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #22 from Kyle M Hall  ---
Created attachment 93256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93256=edit
Bug 19618: Add api endpoint for club holds

This patch adds an endpoint in thi api in /api/v1/clubs/{club_id}/holds whith
the verb POST that maps to Koha::REST::V1::Clubs::Holds#add controller.
Classes for club_holds and club_holds_to_patron_holds new tables where also
added.

To test:
1) Reach SUCCESS.3 test point of previous patch with club that has no
enrollments
2) Click on "Place Hold"
SUCCESS => an alert should appear that you cannot place hold on a club without
patrons
3) Reach SUCCESS.3 test point of previous patch with club that has enrollments
4) Click on "Place Hold"
SUCCESS => holds priority list should appear with holds for every patron in
club
5) Repeat steps 3 and 4.
SUCCESS => new holds should appear in different order
6) Sign off

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #21 from Kyle M Hall  ---
Created attachment 93255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93255=edit
Bug 19618: Add ability to place holds for members of a club in intranet

This patch adds the ability to place a hold for each member of a club in random
order.

To test:
1) apply this patch
2) create 2 clubs, (club names should have some part in common, and some part
different for each other)
3) in one of them add at least 6 members
4) enter patron clubs management and click on "Actions" button
SUCCESS.1 => club with members has a new action called "search to hold"
5) click on search to hold
SUCCESS.2 => in the list of bilios there appears an action called "Place hold
for "
6) click on "Place hold for "
SUCCESS.3 => a new window appears where you can select pickup location
(defaults to club's library, if any), and the list of members.
7) go back to the list of bilios in the catalog and click on "Forget "
8) click on "Holds" action of any biblio
SUCCESS.4 => a search box appears with two tabs: Patrons and Clubs
9) click on Clubs tab and search by the common part of clubs names
SUCCESS.5 => a list of clubs that matches the search appears. If you click on
any of them, the same page as SUCCESS.3 appears.
10) go back to the search box in SUCCESS.4 and search by the different part of
the name.
SUCCESS.6 => because there is only one club that matches search criteria, the
same page as SUCCESS.3 appears;
11) Sign off

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #92746|0   |1
is obsolete||
  Attachment #92747|0   |1
is obsolete||
  Attachment #92748|0   |1
is obsolete||
  Attachment #92749|0   |1
is obsolete||
  Attachment #92750|0   |1
is obsolete||
  Attachment #92751|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall  ---
Created attachment 93253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93253=edit
Bug 19618: Add club_holds and club_holds_to_patron_holds tables

This patch adds 2 new tables
1. club_holds
2. club_holds_to_patron_holds

They are ment to keep info about hold requests made in name of a club

To test:
1) apply this patch
2) perl installer/data/mysql/updatedatabase.pl
SUCCESS => 2 new tables were created

Signed-off-by: Martin Renvoize 

Sponsored-by: Southeast Kansas Library - SEKLS

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Joy Nelson  changed:

   What|Removed |Added

  Text to go in the|This new feature adds the   |Sponsored by South East
  release notes|ability for clubs to place  |Kansas Library System.
   |a hold for bibs. When such  |This new feature adds the
   |a hold is placed, in the|ability for clubs to place
   |background a hold will be   |a hold for bibs. When such
   |automatically placed for|a hold is placed, in the
   |each member of the group in |background a hold will be
   |random order.   |automatically placed for
   ||each member of the group in
   ||random order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Joy Nelson  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #18 from Agustín Moyano  ---
(In reply to Martin Renvoize from comment #15)
> This all seems to work well enough to me.. Signing off..
> 
> Some QA notes though.. What happens if the club is disbanded (deleted)..
> should the holds also be removed.. I don't see anything here doing that?

Hi Martin, thanks for taking the time.

I really wouldn't touch holds that were already placed, even if club was
deleted. 

Patrons may depend on that hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #17 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #16)
> Also.. was this sponsored by anyone?

Southeast Kansas Library - SEKLS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #16 from Martin Renvoize  ---
Also.. was this sponsored by anyone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #15 from Martin Renvoize  ---
This all seems to work well enough to me.. Signing off..

Some QA notes though.. What happens if the club is disbanded (deleted).. should
the holds also be removed.. I don't see anything here doing that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92678|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 92750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92750=edit
Bug 19618: Add tests

This patch adds tests for new features

To test:
1) prove t/db_dependent/Koha/Club/Enrollment.t
2) prove t/db_dependent/Koha/Club/Hold.t
3) prove t/db_dependent/api/v1/clubs_holds.t
4) Sign off

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #14 from Martin Renvoize  ---
Created attachment 92751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92751=edit
Bug 19618: (QA follow-up) POD Fix

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92677|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 92749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92749=edit
Bug 19618: Add api endpoint for club holds

This patch adds an endpoint in thi api in /api/v1/clubs/{club_id}/holds whith
the verb POST that maps to Koha::REST::V1::Clubs::Holds#add controller.
Classes for club_holds and club_holds_to_patron_holds new tables where also
added.

To test:
1) Reach SUCCESS.3 test point of previous patch with club that has no
enrollments
2) Click on "Place Hold"
SUCCESS => an alert should appear that you cannot place hold on a club without
patrons
3) Reach SUCCESS.3 test point of previous patch with club that has enrollments
4) Click on "Place Hold"
SUCCESS => holds priority list should appear with holds for every patron in
club
5) Repeat steps 3 and 4.
SUCCESS => new holds should appear in different order
6) Sign off

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92676|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 92748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92748=edit
Bug 19618: Add ability to place holds for members of a club in intranet

This patch adds the ability to place a hold for each member of a club in random
order.

To test:
1) apply this patch
2) create 2 clubs, (club names should have some part in common, and some part
different for each other)
3) in one of them add at least 6 members
4) enter patron clubs management and click on "Actions" button
SUCCESS.1 => club with members has a new action called "search to hold"
5) click on search to hold
SUCCESS.2 => in the list of bilios there appears an action called "Place hold
for "
6) click on "Place hold for "
SUCCESS.3 => a new window appears where you can select pickup location
(defaults to club's library, if any), and the list of members.
7) go back to the list of bilios in the catalog and click on "Forget "
8) click on "Holds" action of any biblio
SUCCESS.4 => a search box appears with two tabs: Patrons and Clubs
9) click on Clubs tab and search by the common part of clubs names
SUCCESS.5 => a list of clubs that matches the search appears. If you click on
any of them, the same page as SUCCESS.3 appears.
10) go back to the search box in SUCCESS.4 and search by the different part of
the name.
SUCCESS.6 => because there is only one club that matches search criteria, the
same page as SUCCESS.3 appears;
11) Sign off

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92674|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 92746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92746=edit
Bug 19618: Add club_holds and club_holds_to_patron_holds tables

This patch adds 2 new tables
1. club_holds
2. club_holds_to_patron_holds

They are ment to keep info about hold requests made in name of a club

To test:
1) apply this patch
2) perl installer/data/mysql/updatedatabase.pl
SUCCESS => 2 new tables were created

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92675|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 92747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92747=edit
Bug 19618: [DO NOT PUSH] (follow-up) Schema structure

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature adds the
  release notes||ability for clubs to place
   ||a hold for bibs. When such
   ||a hold is placed, in the
   ||background a hold will be
   ||automatically placed for
   ||each member of the group in
   ||random order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Add 'Club Holds' feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Martin Renvoize  changed:

   What|Removed |Added

Summary|Club holds support  |Add 'Club Holds' feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/