[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|Pushed to Stable --- Comment #7 from Nick Clemens --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Katrin Fischer changed: What|Removed |Added Attachment #72161|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 72195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72195&action=edit Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated Signed-off-by: Pasi Kallinen Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 --- Comment #4 from paxed --- (In reply to Katrin Fischer from comment #3) > Hi Paxed, patch is fine as usual, but wondering about setDescription. I > think the term was taken from the OAI spec: > > https://www.openarchives.org/OAI/openarchivesprotocol.html > a setDescription -- an optional and repeatable container that may hold > community-specific XML-encoded data about the set; the accompanying > Implementation Guidelines document provides suggestions regarding the usage > of this container. > > So maybe we want to change it in English too? "Description > (setDescription):" ? Perhaps, but there were two reasons for why I made it translatable: 1) The same "setDescription" text header in the table, and the same label above in the template are translatable - so why not this instance of it? 2) Leaving a text string in javascript like that is a bad example - perhaps someone will look at it and add similar untranslatable strings elsewhere. Better have everything translatable that sometimes some strings not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Paxed, patch is fine as usual, but wondering about setDescription. I think the term was taken from the OAI spec: https://www.openarchives.org/OAI/openarchivesprotocol.html a setDescription -- an optional and repeatable container that may hold community-specific XML-encoded data about the set; the accompanying Implementation Guidelines document provides suggestions regarding the usage of this container. So maybe we want to change it in English too? "Description (setDescription):" ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Roch D'Amour changed: What|Removed |Added CC||roch.dam...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Roch D'Amour changed: What|Removed |Added Attachment #71245|0 |1 is obsolete|| --- Comment #2 from Roch D'Amour --- Created attachment 72161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72161&action=edit Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated Signed-off-by: Pasi Kallinen Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Maksim Sen changed: What|Removed |Added CC||maksim@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20140] Allow translating more of OAI sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 paxed changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 71245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71245&action=edit Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/