[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold sip -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Katrin Fischer changed: What|Removed |Added Component|Circulation |Hold requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #128 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #127 from Nicolas Legrand --- Thanks a lot everyone! Thank you Séverine for testing, thank you, Martin, Josef and Jonathan for reviewing, questioning, advising and guiding. It's such a pleasure to share time with the Koha community! I'm so eager to meet you all in Marseille as soon as possible! See you all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #126 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #125 from Jonathan Druart --- I've squashed some patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #122 from Jonathan Druart --- Created attachment 113234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113234=edit Bug 24412: (QA follow-up) Change CASCADE DELETE to SET NULL I don't believe waiting reserves should be removed if a desk is deleted, we should instead simply unset the desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #124 from Jonathan Druart
---
Created attachment 113236
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113236=edit
Bug 24412: (follow-up) prevent js injection
Some js variables are not properly escaped and can be executed if
containing javascript.
1. have some waiting reserve attached to a desk
2. change this desk name to : alert("❤");
3. go to user's checkout page (circulation.pl) and click on the
Hold(s) tab
4. you should see some popup with a ❤ in it.
5. apply patch and refresh page
6. now you should see the desk name printed properly in the page:
alert("❤");
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #123 from Jonathan Druart --- Created attachment 113235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113235=edit Bug 24412: (follow-up) prevent request.pl from failing When no desk is defined request.pl returns an internal server error. Check a desk is defined before asking for reservation deskname. Plan test: 1. log in with a library with no desk 2. check in a reserved book so it'll be switch to “waiting reserve” 3. go to the book notice and click the Holds tab (request.pl page) 4. boum 5. apply patch, restart plack 6. refresh page 7. now loading properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #120 from Jonathan Druart --- Created attachment 113232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113232=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #117 from Jonathan Druart --- Created attachment 113229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113229=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Bug 24412: (follow-up) Fix POD Koha::Desk and not Koha::Library... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #119 from Jonathan Druart --- Created attachment 113231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113231=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #121 from Jonathan Druart --- Created attachment 113233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113233=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #118 from Jonathan Druart --- Created attachment 113230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113230=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What|Removed |Added Attachment #112264|0 |1 is obsolete|| Attachment #112265|0 |1 is obsolete|| Attachment #112266|0 |1 is obsolete|| Attachment #112267|0 |1 is obsolete|| Attachment #112268|0 |1 is obsolete|| Attachment #112269|0 |1 is obsolete|| Attachment #112270|0 |1 is obsolete|| Attachment #112271|0 |1 is obsolete|| Attachment #112272|0 |1 is obsolete|| Attachment #112292|0 |1 is obsolete|| Attachment #112293|0 |1 is obsolete|| Attachment #113108|0 |1 is obsolete|| Attachment #113109|0 |1 is obsolete|| Attachment #113116|0 |1 is obsolete|| --- Comment #116 from Jonathan Druart --- Created attachment 113228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113228=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #115 from Jonathan Druart --- Thanks Nicolas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #114 from Nicolas Legrand --- (In reply to Jonathan Druart from comment #109) [...] > > 4. I am not sure about the desk_id parameter we passed to > Koha::Hold->set_waiting. > We could also set it from ModReserveAffect, what's the benefit of this > approach? > > Failing QA for 1, 2, 3. I tried to address 1, 2, 3, a big thanks for spotting those. Especially 3... > 4 is for discussion. I'm a bit ashamed to say I don't really know. It seemed to me logical at the time. I'd say that if you think the day someone rewrite ModReserveAffect as a Koha::Hold method the desk attachment should go in this method, then I'll put it under set_waiting(). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
--- Comment #113 from Nicolas Legrand ---
Created attachment 113116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113116=edit
Bug 24412: (follow-up) prevent js injection
Some js variables are not properly escaped and can be executed if
containing javascript.
1. have some waiting reserve attached to a desk
2. change this desk name to : alert("❤");
3. go to user's checkout page (circulation.pl) and click on the
Hold(s) tab
4. you should see some popup with a ❤ in it.
5. apply patch and refresh page
6. now you should see the desk name printed properly in the page:
alert("❤");
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #111 from Nicolas Legrand --- Created attachment 113108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113108=edit Bug 24412 (follow-up): Fix POD Koha::Desk and not Koha::Library... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #112 from Nicolas Legrand --- Created attachment 113109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113109=edit Bug 24412: (follow-up) prevent request.pl from failing When no desk is defined request.pl returns an internal server error. Check a desk is defined before asking for reservation deskname. Plan test: 1. log in with a library with no desk 2. check in a reserved book so it'll be switch to “waiting reserve” 3. go to the book notice and click the Holds tab (request.pl page) 4. boum 5. apply patch, restart plack 6. refresh page 7. now loading properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #110 from Martin Renvoize --- (In reply to Jonathan Druart from comment #109) > 4. I am not sure about the desk_id parameter we passed to > Koha::Hold->set_waiting. > We could also set it from ModReserveAffect, what's the benefit of this > approach? I felt it was a good thing having it at the set_waiting level. In part because it encourages code to be written cleanly in the Koha:: space and because I feel it's the set_waiting call that links closely with when a desk would be assigned to a reserve and as such having it in this function now means if we use set_waiting down the line without calling ModReserveAffect then we would be reminded to set desk_id if appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #109 from Jonathan Druart
---
1. POD for Koha::Hold->desk is wrong
2. If not desk set, biblio hold list (reserves/request.pl) explodes with:
Can't call method "desk_name" on an undefined value at
/kohadevbox/koha/reserve/request.pl line 661
3. The desk's name is not correctly escaped in the patron's hold list
(circ/circulation.pl, "Holds" tab)
Try to use the following string as a desk name:
alert("❤");
Search for "escapeHtml" in the same js file for the solution.
4. I am not sure about the desk_id parameter we passed to
Koha::Hold->set_waiting.
We could also set it from ModReserveAffect, what's the benefit of this
approach?
Failing QA for 1, 2, 3.
4 is for discussion.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Keywords||rel_20_11_target Text to go in the||When `UseCirculationDesks` release notes||is enabled and desks are ||defined and attached to a ||library, this feature makes ||it possible to attach a ||waiting reserve to a desk: ||when an item is checked in ||and marked as a waiting ||reserve, it is also ||attached to the current ||desk. The desk is then ||displayed in the intranet ||document request page, the ||intranet borrower holds ||tab, the item list of the ||document bibliographic ||details and the borrower's ||OPAC holds tab. You can ||move waiting reserve from ||desk to desk by checking in ||again the item at a ||different desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Blocks||14654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 [Bug 14654] Add desk filter in Holds awaiting pickup list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #108 from Martin Renvoize --- (In reply to Martin Renvoize from comment #103) > I'm pretty much ready to PQA this.. once I have an answer to a couple of > minor queries. > > 1/ Are you sure you want to delete a reserve that's attached to a desk when > the desk is deleted.. rather than setting the desk_id to null? This may need > a tiny followup ;) I resolved this in my own QA follow-up > > 2/ Would there ever be a requirement for desks to be 'required'.. in which > case we should probably introduce a pref and check to enforce this. This can > be a separate bug. I decided this wouldn't be the case. We need to allow AddReserve to continue passing through no desk for the 'Automatically set holds to waiting' option of 'ReservesNeedReturns'. It might be nice to have the option of using 'Processing' for that case in the future however. > > 3/ Would there ever be a case where the librarian may want to override the > desk at the time of setting the reserve as waiting? This could also be in a > followup bug. Another one for another bug in the future. > 4/ I'm contemplating asking for a check in the set_waiting that ensures we > set a desk that corresponds to the branchcode to ensure we don't get mixed > data. This is over the top at this time I think. After all that.. I'm Passing QA! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #106 from Martin Renvoize --- Created attachment 112292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112292=edit Bug 24412: (QA follow-up) Change CASCADE DELETE to SET NULL I don't believe waiting reserves should be removed if a desk is deleted, we should instead simply unset the desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #107 from Martin Renvoize --- Created attachment 112293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112293=edit Bug 24412: (QA follow-up) DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #105 from Martin Renvoize --- (In reply to Martin Renvoize from comment #104) > Hmmm... also beware that bug 12556 is PQA so this will likely need a rebase > on top of it before it gets pushed :| Ignore that.. 12556 is already in master.. and this applies fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #104 from Martin Renvoize --- Hmmm... also beware that bug 12556 is PQA so this will likely need a rebase on top of it before it gets pushed :| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #103 from Martin Renvoize --- I'm pretty much ready to PQA this.. once I have an answer to a couple of minor queries. 1/ Are you sure you want to delete a reserve that's attached to a desk when the desk is deleted.. rather than setting the desk_id to null? This may need a tiny followup ;) 2/ Would there ever be a requirement for desks to be 'required'.. in which case we should probably introduce a pref and check to enforce this. This can be a separate bug. 3/ Would there ever be a case where the librarian may want to override the desk at the time of setting the reserve as waiting? This could also be in a followup bug. 4/ I'm contemplating asking for a check in the set_waiting that ensures we set a desk that corresponds to the branchcode to ensure we don't get mixed data. I'm generally really happy with this development though, it's looking great. Good Job! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112218|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 112271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112271=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112219|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 112272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112272=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112217|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 112270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112270=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112216|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 112269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112269=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112215|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 112268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112268=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112214|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 112267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112267=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112212|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 112265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112265=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112211|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 112264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112264=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Martin Renvoize changed: What|Removed |Added Attachment #112213|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 112266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112266=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112207|0 |1 is obsolete|| --- Comment #91 from Séverine Queune --- Created attachment 112217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112217=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112210|0 |1 is obsolete|| --- Comment #93 from Séverine Queune --- Created attachment 112219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112219=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112208|0 |1 is obsolete|| --- Comment #92 from Séverine Queune --- Created attachment 112218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112218=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112204|0 |1 is obsolete|| --- Comment #88 from Séverine Queune --- Created attachment 112214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112214=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112205|0 |1 is obsolete|| --- Comment #89 from Séverine Queune --- Created attachment 112215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112215=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112206|0 |1 is obsolete|| --- Comment #90 from Séverine Queune --- Created attachment 112216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112216=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112203|0 |1 is obsolete|| --- Comment #87 from Séverine Queune --- Created attachment 112213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112213=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112202|0 |1 is obsolete|| --- Comment #86 from Séverine Queune --- Created attachment 112212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112212=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112165|0 |1 is obsolete|| --- Comment #85 from Séverine Queune --- Created attachment 112211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112211=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=26779 Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112209|0 |1 is obsolete|| --- Comment #84 from Séverine Queune --- Created attachment 112210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112210=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112172|0 |1 is obsolete|| --- Comment #82 from Séverine Queune --- Created attachment 112208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112208=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112201|0 |1 is obsolete|| --- Comment #83 from Séverine Queune --- Created attachment 112209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112209=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112171|0 |1 is obsolete|| --- Comment #81 from Séverine Queune --- Created attachment 112207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112207=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 8 -v 2 2. should be green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112166|0 |1 is obsolete|| --- Comment #76 from Séverine Queune --- Created attachment 112202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112202=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112170|0 |1 is obsolete|| --- Comment #80 from Séverine Queune --- Created attachment 112206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112206=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112169|0 |1 is obsolete|| --- Comment #79 from Séverine Queune --- Created attachment 112205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112205=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112168|0 |1 is obsolete|| --- Comment #78 from Séverine Queune --- Created attachment 112204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112204=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Séverine Queune changed: What|Removed |Added Attachment #112167|0 |1 is obsolete|| --- Comment #77 from Séverine Queune --- Created attachment 112203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112203=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #75 from Séverine Queune --- Created attachment 112201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112201=edit Bug 24412: (follow-up) prevent error in svc/holds don't fail if a hold has no desk attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #74 from Nicolas Legrand --- Created attachment 112172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112172=edit Bug 24412: (follow-up) bad desk printing forgot to update two pages when I wrote Hold->desk to replace Desks.GetName. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112099|0 |1 is obsolete|| --- Comment #73 from Nicolas Legrand --- Created attachment 112171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112171=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 7 -v 2 2. should be green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112049|0 |1 is obsolete|| --- Comment #70 from Nicolas Legrand --- Created attachment 112168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112168=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112048|0 |1 is obsolete|| --- Comment #69 from Nicolas Legrand --- Created attachment 112167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112167=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112050|0 |1 is obsolete|| --- Comment #71 from Nicolas Legrand --- Created attachment 112169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112169=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112047|0 |1 is obsolete|| --- Comment #68 from Nicolas Legrand --- Created attachment 112166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112166=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112092|0 |1 is obsolete|| --- Comment #72 from Nicolas Legrand --- Created attachment 112170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112170=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #112046|0 |1 is obsolete|| --- Comment #67 from Nicolas Legrand --- Created attachment 112165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112165=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=26779 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #66 from Nicolas Legrand --- Séverine spotted bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #65 from Nicolas Legrand --- > > Unfortunately, while I was looking at this, I found two bugs : (1) if you > check in a book waiting at another library, it makes a server internal > error. (2) When changing libraries, the menu proposes only one desk and not > the entire set. > > I'll look at (1) here and (2) in a separate bugzilla... fix proposed for (2) in Bug 26779 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #64 from Nicolas Legrand --- > Unfortunately, while I was looking at this, I found two bugs : (1) if you > check in a book waiting at another library, it makes a server internal > error. (2) When changing libraries, the menu proposes only one desk and not > the entire set. > > I'll look at (1) here and (2) in a separate bugzilla... I forgot to mention it seems like (1) was fixed by Bug 12556! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #63 from Nicolas Legrand --- (In reply to Katrin Fischer from comment #54) > I am also missing tests? oups... Tests added! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #62 from Nicolas Legrand --- Created attachment 112099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112099=edit Bug 24412: (follow-up) qa-tools fix obvious problems: 1. qa -c 6 -v 2 2. should be green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #61 from Nicolas Legrand --- Created attachment 112092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112092=edit Bug 24412: (follow-up) tests Add some test for Koha::Hold->desk and Koha::Hold->set_waiting. Test plan: 1. prove t/db_dependent/Koha/Holds.t 2. should be green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #60 from Nicolas Legrand --- this was a big rebase I didn't test (the Koha people worked a lot while I was in my tunnel!). I'll test tomorrow so please don't test until I switch to NEED SIGNOFF :). Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110586|0 |1 is obsolete|| --- Comment #59 from Nicolas Legrand --- Created attachment 112050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112050=edit Bug 24412: (follow-up) QA: useless change Maybe it was a relic of something usefull... anyway not anymore. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110584|0 |1 is obsolete|| --- Comment #57 from Nicolas Legrand --- Created attachment 112048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112048=edit Bug 24412: (follow-up) QA Following Josef Moravec QA comments : - rewrite Koha::Hold->desk according to Object Oriented Koha Guidelines and use it to fetch desk name in various templates - remove unused Desks.GetName - Check for columns existence in db update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110585|0 |1 is obsolete|| --- Comment #58 from Nicolas Legrand --- Created attachment 112049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112049=edit Bug 24412: Schema file DO NOT PUSH! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110582|0 |1 is obsolete|| --- Comment #55 from Nicolas Legrand --- Created attachment 112046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112046=edit Bug 24412: kohastructure and atomic update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Nicolas Legrand changed: What|Removed |Added Attachment #110583|0 |1 is obsolete|| --- Comment #56 from Nicolas Legrand --- Created attachment 112047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112047=edit Bug 24412: Attach waiting reserve to desk When an item is checked in and marked 'Waiting' or already 'Waiting' and there is a desk attached to the session, the item is marked waiting at the current desk of the current library. The information is displayed on the OPAC and on the intranet. The patron can then know at which desk he can retrieve his document. Desk Management (Bug 13881) is now useful. Test plan : 1. apply Bug 24201 2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl 3. Check out some document to someone 4. make another one reserve this document 5. check in the document 6. you can see the document is attach to the current library 7. create some desks and attach one to your session (see Bug 13881 and Bug 24201) 8. cancel the preceding reserve and redo steps 3 to 5 9. you should see the document is waiting at the current library and current desk on: a. the intranet document request page b. the intranet borrower holds tab c. the item list where the document is listed on the bibliographic details d. the borrower's OPAC holds tab. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #54 from Katrin Fischer --- I am also missing tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #53 from Katrin Fischer --- > > Unfortunately, while I was looking at this, I found two bugs : (1) if you > > check in a book waiting at another library, it makes a server internal > > error. (2) When changing libraries, the menu proposes only one desk and not > > the entire set. > > > > I'll look at (1) here and (2) in a separate bugzilla... > > Good catches Awaiting the follow-up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24412] Attach waiting hold to desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Katrin Fischer changed: What|Removed |Added Summary|Attach waiting reserve to |Attach waiting hold to desk |desk| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
