[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Bug 28058 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Bug 28058 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Bug 28058 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Depends on||34913 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Attachment #119321|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Attachment #119165|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move JavaScript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Katrin Fischer changed: What|Removed |Added Summary|Move javascript out of |Move JavaScript out of |columns_settings.inc into |columns_settings.inc into |separate file |separate file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #9 from David Nind --- Patch no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #8 from Owen Leonard --- Created attachment 119321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119321=edit Bug 28058: (follow-up) Make same change in the OPAC; Use "table_settings" as file name This patch moves the JavaScript contained in a
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Status|In Discussion |Passed QA Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #6 from Owen Leonard --- I called it "columns_settings.js" because it corresponds to "columns_settings.inc" and I thought it made sense for them to be the same. I'm happy to change it. I could also change the name of columns_settings.inc at the same time. Anyone have preferences? I can do the same in the OPAC but I think that can happen on another bug without holding up this one. --- Comment #7 from Jonathan Druart --- (In reply to Owen Leonard from comment #6) > I called it "columns_settings.js" because it corresponds to > "columns_settings.inc" and I thought it made sense for them to be the same. > I'm happy to change it. I could also change the name of columns_settings.inc > at the same time. > > Anyone have preferences? Everything should now be "tables_settings". > I can do the same in the OPAC but I think that can happen on another bug > without holding up this one. For consistency I would prefer to keep both in sync. We can do it on a separate bug report but I will push them together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Shouldn't we also apply the changes to the OPAC? Shouldn't the file be named table_settings.js instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Katrin Fischer changed: What|Removed |Added Attachment #119163|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 119165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119165=edit Bug 28058: Move javascript out of columns_settings.inc into separate file This patch moves the JavaScript contained in a
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 David Nind changed: What|Removed |Added Attachment #119024|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 119163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119163=edit Bug 28058: Move javascript out of columns_settings.inc into separate file This patch moves the JavaScript contained in a
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #2 from Owen Leonard --- Created attachment 119024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119024=edit Bug 28058: Move javascript out of columns_settings.inc into separate file This patch moves the JavaScript contained in a
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28058] Move javascript out of columns_settings.inc into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #1 from Owen Leonard --- I'm also moving the contents of table_filters.js into the new JS file (tablesettings.js). table_filters.js contained only two functions and was only used on pages which already include columns_settings.inc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
