[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in|| --- Comment #44 from Lucas Gass --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|24.05.00|24.05.00,23.11.06 released in|| --- Comment #43 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Emily Lamancusa changed: What|Removed |Added CC||sbr...@bywatersolutions.com --- Comment #42 from Emily Lamancusa --- *** Bug 36817 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Emily Lamancusa changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #41 from Emily Lamancusa --- *** Bug 32778 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36817 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added Text to go in the|This ptchset adds a new |This patch set adds a new release notes|option "--unallocated" to |option "--unallocated" to |the build_holds_queue.pl|the build_holds_queue.pl |cronjob. |cronjob. | | |This option |This option |prevents deletion of the|prevents deletion of the |existing queue, and looks |existing queue, and looks |for new unassigned holds|for new unassigned holds |that may be mapped to |that may be mapped to |available items. |available items. | | |There are |There are |two intended uses for the |two intended uses for the |option, depending on|option, depending on |whether the |whether the |'RealTimeHoldsQueue' (RTHQ) |'RealTimeHoldsQueue' (RTHQ) |system preference is anbled |system preference is |or not. |enabled or not. | | |Without RTHQ|Without |libraries who want a more |RTHQ libraries who want a |static holds queue during |more static holds queue |the day can run an hourly |during the day can run an |'unallocated' cronjob. This |hourly 'unallocated' |will add new holds to the |cronjob. This will add new |queue as they come in, but |holds to the queue as they |allow libraries longer to |come in, but allow |fill the holds in their |libraries longer to fill |existing queue before they |the holds in their existing |move on. The recommendation |queue before they move on. |would then be a nightly |The recommendation would |full run to rebuild the |then be a nightly full run |queue entirely. |to rebuild the queue | |entirely. |With RTHQ, | |libraries could run a |With RTHQ, |nightly 'unallocated' cron |libraries could run a |to select holds for |nightly 'unallocated' cron |libraries that were not |to select holds for |open on the previous day, |libraries that were not |and to select holds that|open on the previous day, |have been unsuspended by|and to select holds that |another cronjob. |have been unsuspended by | |another cronjob. |Current | |setups will continue to |Current |function as before with no |setups will continue to |change, but libraries may |function as before with no |wish to review their|change, but libraries may |options after this upgrade. |wish to review their ||options after this upgrade. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #40 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added Text to go in the||This ptchset adds a new release notes||option "--unallocated" to ||the build_holds_queue.pl ||cronjob. || ||This option ||prevents deletion of the ||existing queue, and looks ||for new unassigned holds ||that may be mapped to ||available items. || ||There are ||two intended uses for the ||option, depending on ||whether the ||'RealTimeHoldsQueue' (RTHQ) ||system preference is anbled ||or not. || ||Without RTHQ ||libraries who want a more ||static holds queue during ||the day can run an hourly ||'unallocated' cronjob. This ||will add new holds to the ||queue as they come in, but ||allow libraries longer to ||fill the holds in their ||existing queue before they ||move on. The recommendation ||would then be a nightly ||full run to rebuild the ||queue entirely. || ||With RTHQ, ||libraries could run a ||nightly 'unallocated' cron ||to select holds for ||libraries that were not ||open on the previous day, ||and to select holds that ||have been unsuspended by ||another cronjob. || ||Current ||setups will continue to ||function as before with no ||change, but libraries may ||wish to review their ||options after this upgrade. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #39 from Tomás Cohen Arazi --- (In reply to Pedro Amorim from comment #24) > > Nick, please intervene if any of the above needs correcting. > My opinion is that a note along the lines of "It is recommended to use the > cron build_holds_queue.pl --unallocated-only cron if using RTHQ" would be > useful in the UI. Agreed. And we need good release notes as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 165803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165803=edit Bug 32565: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 165802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165802=edit Bug 32565: (QA follow-up) Fix tests Apply original tests patch + this follow-up. Run: prove t/db_dependent/HoldsQueue.t Notice tests fail. Apply fix patch, run the above prove command again. Notice tests pass. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 165801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165801=edit Bug 32565: Unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Tomás Cohen Arazi changed: What|Removed |Added Attachment #165166|0 |1 is obsolete|| Attachment #165167|0 |1 is obsolete|| Attachment #165168|0 |1 is obsolete|| Attachment #165169|0 |1 is obsolete|| --- Comment #35 from Tomás Cohen Arazi --- Created attachment 165800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165800=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #34 from Nick Clemens --- Created attachment 165169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165169=edit Bug 32565: (follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #33 from Nick Clemens --- Created attachment 165168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165168=edit Bug 32565: (QA follow-up) Fix tests Apply original tests patch + this follow-up. Run: prove t/db_dependent/HoldsQueue.t Notice tests fail. Apply fix patch, run the above prove command again. Notice tests pass. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #32 from Nick Clemens --- Created attachment 165167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165167=edit Bug 32565: Unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added Attachment #164272|0 |1 is obsolete|| Attachment #164273|0 |1 is obsolete|| Attachment #164274|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 165166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165166=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #30 from Nick Clemens --- *** Bug 34676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #29 from Pedro Amorim --- HoldsQueue.t needed a rebase after bug 35997 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #162269|0 |1 is obsolete|| --- Comment #28 from Pedro Amorim --- Created attachment 164274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164274=edit Bug 32565: QA Follow-up: Fix tests Apply original tests patch + this follow-up. Run: prove t/db_dependent/HoldsQueue.t Notice tests fail. Apply fix patch, run the above prove command again. Notice tests pass. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #161680|0 |1 is obsolete|| --- Comment #27 from Pedro Amorim --- Created attachment 164273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164273=edit Bug 32565: Unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #161679|0 |1 is obsolete|| --- Comment #26 from Pedro Amorim --- Created attachment 164272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164272=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #25 from Victor Grousset/tuxayo --- (In reply to Pedro Amorim from comment #20) > Created attachment 162269 [details] [review] > Bug 32565: QA Follow-up: Fix tests > > Apply original tests patch + this follow-up. Run: > prove t/db_dependent/HoldsQueue.t > Notice tests fail. > Apply fix patch, run the above prove command again. > Notice tests pass. Confirmed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #24 from Pedro Amorim --- (In reply to Nick Clemens from comment #23) > (In reply to Pedro Amorim from comment #22) > > Hey guys, I'd love some feedback on my latest patch. > > I think it makes sense considering build_holds_queue.pl --unallocated should > > be idempotent. > > I'm okay with it being dropped if you feel that's best or if I missed > > something. > > In a system without RTHQ there are times a library would like the queue to > remain static for a period of time, but have new holds be picked up. i.e. > giving a library more time to fill holds until a full rebuild, so I think > the switch is necessary even when not using the RTHQ. Having the switch > allows this code to satisfy bug 34676 and 32328 at leats partially I've made my latest patch obsolete for these reasons, I had not considered this specific use case. As it stands now, the following cron entries configurations will work like this: Without RTHQ: 0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl --unallocated-only # run this hourly 0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this daily With RTHQ: 0 * * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl --unallocated-only # run this hourly 0 1 * * * /usr/share/koha/bin/cronjobs/holds/build_holds_queue.pl # run this daily !This will not do anything because RTHQ is enabled and --force is missing Nick, please intervene if any of the above needs correcting. My opinion is that a note along the lines of "It is recommended to use the cron build_holds_queue.pl --unallocated-only cron if using RTHQ" would be useful in the UI. I think this is good to go and I don't have anything else to add, but because of my involvement in it I'll leave it to someone else to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #162297|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #23 from Nick Clemens --- (In reply to Pedro Amorim from comment #22) > Hey guys, I'd love some feedback on my latest patch. > I think it makes sense considering build_holds_queue.pl --unallocated should > be idempotent. > I'm okay with it being dropped if you feel that's best or if I missed > something. In a system without RTHQ there are times a library would like the queue to remain static for a period of time, but have new holds be picked up. i.e. giving a library more time to fill holds until a full rebuild, so I think the switch is necessary even when not using the RTHQ. Having the switch allows this code to satisfy bug 34676 and 32328 at leats partially -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32328 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #22 from Pedro Amorim --- Hey guys, I'd love some feedback on my latest patch. I think it makes sense considering build_holds_queue.pl --unallocated should be idempotent. I'm okay with it being dropped if you feel that's best or if I missed something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #21 from Pedro Amorim --- Created attachment 162297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162297=edit Bug 32565: Remove unallocated param from cron script unallocated param is redundant, it is only relevant if RealTimeHoldsQueue is enabled, the cron should just fall back to unallocated mode if the sys pref is enabled. This simplifies system administration, and does not require current Koha installations to update their cron configuration entry to make use of this fix. I think we should add a documentation note recommending using this cronjob when RealTimeHoldsQueue is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #20 from Pedro Amorim --- Created attachment 162269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162269=edit Bug 32565: QA Follow-up: Fix tests Apply original tests patch + this follow-up. Run: prove t/db_dependent/HoldsQueue.t Notice tests fail. Apply fix patch, run the above prove command again. Notice tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA CC||vic...@tuxayo.net --- Comment #19 from Victor Grousset/tuxayo --- Good questions Pedro. I do not know enough that functional area to help here. But at least here is a finding on another thing: test "Test unallocated option" actually doesn't test it. 1. Apply test patch 2. run tests 3. They pass! :o they shouldn't since there is not implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #18 from Pedro Amorim --- (In reply to Nick Clemens from comment #15) > This is similar to another bug we filed 3467 > > Pedro, if you want to pursue something different here I am happy to move my > patches to that bug. Otherwise we could combine the two Hey, thanks Nick! Yeah, I think bug 34676 should definitely be made a duplicate of this. I've signed-off and I believe this is good to go, although I have 2 observations: 1) With this new enhancement, would there ever be a situation where using RTHQ without the cron build_holds_queue.pl --force --unallocated be advisable? In other words, it seems that it would always be beneficial to run RTHQ in conjunction with the cron build_holds_queue.pl --force --unallocated, in order to catch unallocated holds "just in case". If the above is true, we're moving from: "It's recommended to use RTHQ or the build_holds_queue.pl cron, not both" to "RTHQ should be used in conjunction with build_holds_queue.pl --force --unallocated cron". This works, but it may be confusing in terms of system administration. Maybe not, ignore if that's the case. 2) Should we rename the unallocated option to unallocated-only to make it clearer? We're not adding "unallocated" on top of what the script already does, instead we're making the script consider unallocated holds only, correct? Ignore if not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #161394|0 |1 is obsolete|| --- Comment #17 from Pedro Amorim --- Created attachment 161680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161680=edit Bug 32565: Unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #161393|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 161679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161679=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34676 --- Comment #15 from Nick Clemens --- This is similar to another bug we filed 3467 Pedro, if you want to pursue something different here I am happy to move my patches to that bug. Otherwise we could combine the two -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #14 from Nick Clemens --- Created attachment 161394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161394=edit Bug 32565: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added Attachment #161231|0 |1 is obsolete|| Attachment #161232|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 161393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161393=edit Bug 32565: Add unallocated option to holds queue Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected To test: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Confirm the second hold is added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #12 from Katrin Fischer --- Pre-allocation will require new logic that we currently not have and has some issues that we could encounter. Allocation right now can be random (StaticHoldsQueueWeight), static (RandomizeHoldsQueueWeight) or driven by the transport cost matrix (UseTransportCostMatrix). Only "open" libraries will be looked at with HoldsQueueSkipClosed. So we have a complex system. When pre-allocating, we could do open libraries first, but when all are closed, should we take the duration of the closing into account? It could be just a holiday closure or it could be library that is closed for months. What if the calendar entries were changed after pre-allocating (closing period is extended)? The hold could get stuck in limbo basically forever, while it sits on the shelf in a library close by. I believe pre-allocating is not good, as we don't have a way to "review" those. What do you mean by have RTHoldsQueue check tomorrow? RTHoldsQueue means that every time a hold/item/biblio is added or updated we trigger a 'review' of the holds queue entry for the bibliographic record concerned. It's triggered by an action - so we'd still need to locate the unallocated and trigger this step for these holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #11 from Pedro Amorim --- (In reply to Katrin Fischer from comment #10) > * Have some other way of triggering re-allocation - I don't think we have an > option there apart from cron? Discussed this with Martin, an option would perhaps have it be a "scheduled job" (think background jobs, but scheduled to run at a specific given time instead of whenever possible), but I don't think we're there yet. Brainstorm idea, but if a hold is placed today and no library is open today, why not have RTHoldsQueue check tomorrow? and the day after that, and so on, until it finds a suitable one? (within a sensible limit) That's what would happen anyway through the cron, right? Maybe we'd have to add a way of flagging the hold that it can't be satisfied immediately as the library is closed but it could show the hold as "pre-allocated". This may not be a great idea, but let me know what the problems are with it as I lack the hold queues workflow knowledge required to see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added Version|22.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #10 from Katrin Fischer --- Trying to help untangle this, in hope of not making it worse :) Problem: When all libraries owning a requested item are closed, we are not able to allocate a hold. Past: In the past and without RTHoldsQueue the holdsqueue was rebuilt completely. As a result, the unallocated holds would get allocated. Present: We now have RTHoldsQueue and try to avoid running the build_holdsqueue additionally, so we need a way to deal with the unallocated holds without still rebuilding the table regularly. I think having a switch on the build_holdsqueue that does prevent it deleting the table and makes it only add the so far unallocated would be OK. What could be alternatives? * Having a separate script: not ideal really as it would be too similar really. * Have some other way of triggering re-allocation - I don't think we have an option there apart from cron? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m --- Comment #9 from Pedro Amorim --- This is my understanding of the suggested solution: In order to address the problem reported in the original post, one would have to configure the cronjob entry "build_holds_queue.pl --unallocated" on top of the sys pref configurations stated in the original post (HoldsQueueSkipClosed = "open" and RealTimeHoldsQueue = "enabled"). In other words, the patch alone does not prevent the issue, it aims to fix the issue after it has occurred, when the cron runs by allocating the unallocated holds. Please correct me if I'm wrong. Observations with the patch: - My understanding is that RealTimeHoldsQueue and the build_holds_queue.pl cronjob are/were designed to be mutually exclusive, or at least for the most part, i.e. either use one of the other (?). This patch enforces the relationship between the syspref+cronjob, i.e. one would be expected to use both RealTimeHoldsQueue and the build_holds_queue.pl cronjob (at least when HoldsQueueSkipClosed is set to "open"). I think this is confusing. I think we should have one way or the other but, honestly/ideally, just one standard way of doing this. - With all of the above said, and having tested the patch, I don't think it does what it's designed to do. To recreate, clean k-t-d: 1) Apply both patches 2) Enable RealTimeHoldsQueue and set HoldsQueueSkipClosed to "open" 3) Add a holiday to the calendar for all libraries for today, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Holiday repeated every same day of the week" -- Click "Copy to all libraries". Hit "Save. 4) Place a biblio-level hold on a biblio record and set the pickup location to a library that has available copies, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=76=51 -- Click the first "Place hold" button to place the biblio-level hold. 5) Verify that that hold got added to the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 6) Place a biblio-level hold on a biblio record where there are no other holds and copies are available at another location, but not the pickup location, visit: -- /cgi-bin/koha/reserve/request.pl?biblionumber=437=51 -- On the "pickup at" dropdown, pick something else other than "Centerville", e.g. "Fairfield". -- Click the first "Place hold" button to place the biblio-level hold. 7) Check the holds queue again, notice that this 2nd hold was not added to the queue: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 8) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 9) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 10) Remove the holiday we created previously, visit: /cgi-bin/koha/tools/holidays.pl -- Click today's day on the calendar and pick "Delete this holiday" -- Click "Copy to all libraries". Hit "Save. 11) Run the updated cronscript: perl misc/cronjobs/holds/build_holds_queue.pl --force --unallocated 12) Notice nothing changed in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 At this point I would have expected the unallocated hold to have been placed, but it isn't. 13) Lastly, run the cron script without 'unallocated': perl misc/cronjobs/holds/build_holds_queue.pl --force 14) Notice both holds are now in the holds queue, visit: /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit_report=1 My understanding is that the downside of running the cron with --force while having the syspref configured as above, is that the whole queue is rebuilt and some items previously allocated may be swapped around (?), and this is why having the cron with --force plus the sysprefs is not recommended. Correct me if I'm wrong please. I don't have a proposed fix of my own as I don't think I understand any of this well enough to provide one efficiently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #8 from Pedro Amorim --- Created attachment 161232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161232=edit Bug 32565: WIP - Minor fixes to have WIP working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Pedro Amorim changed: What|Removed |Added Attachment #147659|0 |1 is obsolete|| --- Comment #7 from Pedro Amorim --- Created attachment 161231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161231=edit Bug 32565: WIP Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected This will need unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #6 from Nick Clemens --- Not taking this one right now, just had an idea to test, so if someone else wants to pickup unit tests please do -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #5 from Nick Clemens --- Created attachment 147659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147659=edit Bug 32565: WIP Add an unallocated option to CreateQueue and pass through as needed Avoid deletion of the tmp_holdsqueue, and only check holds and items that are not currently matched A future hold with a higher priority will still fail here - because the item may already be assigned, but on next change to the biblio it would be corrected This will need unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org --- Comment #4 from Daniel Gaghan --- We saw this recently at PCCLD, so +1 to fixing this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Katrin Fischer changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #3 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #2) > Could the script be modified to only check for missing holds that haven't > been allocated yet? Otherwise it will delete the whole table, mess with all > the timestamps etc which would be a real set back now that we have RT. I second this - in addition to the reasons Katrin mentioned, we've found (at least in testing) that the real-time holds queue also distributes the holds more equitably among our libraries than the cron job, so we'd like to preserve that! Running a modified holds queue cron would also be more in keeping with the goals of Bug 31995. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 --- Comment #2 from Katrin Fischer --- Could the script be modified to only check for missing holds that haven't been allocated yet? Otherwise it will delete the whole table, mess with all the timestamps etc which would be a real set back now that we have RT. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #1 from Nick Clemens --- I think the solution to this one may be server configuration - there is a need to run the holds queue cron daily/nightly to check for holds that may not have had an open library when placed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
