[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 --- Comment #9 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in|| Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.04 released in|| --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Kyle M Hall changed: What|Removed |Added Attachment #155578|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 155597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155597=edit Bug 34764: Set fee_acknowledged to expect a string For consistency with other options I opted to have the fee acknowledged parameter to expect a string and as it's an optional parameter I've dropped the default value of 'N' too. Test plan 1) Prior to this patch 1a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will be '|BON', the default 1b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will still be '|BON', failure 1c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will still be '|BON', failure 2) Apply the patch 2a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout` The optional `|BO` element should not be present 2b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged N --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will now be '|BON', success 2c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will now be '|BOY', success Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 --- Comment #5 from David Nind --- Testing notes (using KTD): 1. After each command, I checked the item back in using the staff interface when required. I tested without and with a rental fee for the item type - not sure whether I needed to do that or not, or if that was going overboard! 2. I edited the commit message to include the '-m checkout' at the end of each command (see comment #3). 3. (1a) Result from step 1a: without a rental charge for the item type - item checked out, no charges ~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2023091221260620230912 212606AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 121NNY20230912212606AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH20230917235900| with a rental charge for the item type - item not checked out, no charges ~~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2023091223592420230912 235924AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 120NUN20230912235924AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH|BLY|BV1.00|BHUSD|BT06| 4. (1b) Result from step 1b: without a rental charge for the item type - item checked out, no charges ~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2023091221295620230912 212956AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 121NNY20230912212956AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH20230917235900| with a rental charge for the item type - item not checked out, no charges ~~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN202309132820230913 28AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 120NUN2023091328AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH|BLY|BV1.00|BHUSD|BT06| 5. (1c) Result from step 1c: without a rental charge for the item type - item checked out, no charges ~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2023091221312020230912 213120AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 121NNY20230912213120AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH20230917235900| with a rental charge for the item type - item not checked out, no charges ~~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2023091300013520230913 000135AOCPL|AA2352935676|AB307756|ACterm1|BON|BIN| READ: 120NUN20230913000135AOCPL|AA2352935676|AB307756|AJScarlet and black /|AH|BLY|BV1.00|BHUSD|BT06| 6. (2a) Result from step 2a - item not checked out: without a rental charge for the item type - item checked out, no charges ~ ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 David Nind changed: What|Removed |Added Attachment #13|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 155578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155578=edit Bug 34764: Set fee_acknowledged to expect a string For consistency with other options I opted to have the fee acknowledged parameter to expect a string and as it's an optional parameter I've dropped the default value of 'N' too. Test plan 1) Prior to this patch 1a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will be '|BON', the default 1b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will still be '|BON', failure 1c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will still be '|BON', failure 2) Apply the patch 2a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 -m checkout` The optional `|BO` element should not be present 2b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged N --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will now be '|BON', success 2c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756 -m checkout` The final field of the SIP request will now be '|BOY', success Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 --- Comment #3 from Martin Renvoize --- Darn.. I missed the '-m checkout' on the end of all those commands. Must have got lost in the copy/paste from my own testing. Without that part, SIP doesn't know which message to send..oops -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- When I issue any of the commands, either before or after the patch is applied, I get no response back. For example: ./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at ./misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 --- Comment #1 from Martin Renvoize --- Created attachment 13 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13=edit Bug 34764: Set fee_acknowledged to expect a string For consistency with other options I opted to have the fee acknowledged parameter to expect a string and as it's an optional parameter I've dropped the default value of 'N' too. Test plan 1) Prior to this patch 1a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756` The final field of the SIP request will be '|BON', the default 1b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 2352935676 --item 307756` The final field of the SIP request will still be '|BON', failure 1c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756` The final field of the SIP request will still be '|BON', failure 2) Apply the patch 2a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 2352935676 --item 307756` The optional `|BO` element should not be present 2b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged N --patron 2352935676 --item 307756` The final field of the SIP request will now be '|BON', success 2c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 2352935676 --item 307756` The final field of the SIP request will now be '|BOY', success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34764] sip_cli_emulator -fa/--fee_acknowledge does not act as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
