[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #61 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Looking at critical bugs I noticed this one - does the problem still exist and can we get the patch back into the queue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #62 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- As I said in comment #59 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030#c59), this bug was splitted in many small one. It seems that all attached bugs are pushed except Bug 11173 (that won't apparently). So I think it could be closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED --- Comment #63 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Sophie, thx for clarifying! I am closing this then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Assignee|stephane.delaune@biblibre.c |jonathan.dru...@biblibre.co |om |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Francois Charbonnier francois.charbonn...@inlibro.com changed: What|Removed |Added CC||francois.charbonnier@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030
--- Comment #60 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 13018
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13018
Bug 6030 [3.8.x] Allow html content in letters
Review of attachment 13018:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6030attachment=13018)
-
::: misc/cronjobs/overdue_notices.pl
@@ +344,4 @@
our $csv; # the Text::CSV_XS object
our $csv_fh;# the filehandle to the CSV file.
+if ( $csvfilename ) {
No, because the file name could be 0. Old code is better.
@@ +563,4 @@
email = $email,
itemcount = $itemcount,
titles = $titles,
+outputformat = $csvfilename ? 'csv' : defined
$htmlfilename ? 'html' : '',
This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.
@@ +591,4 @@
email = $email,
itemcount = $itemcount,
titles = $titles,
+outputformat = $csvfilename ? 'csv' :
defined $htmlfilename ? 'html' : '',
This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.
@@ +602,4 @@
}
if (@output_chunks) {
+if ( $csvfilename ) {
This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Joel Sasse jsa...@plumcreeklibrary.net changed: What|Removed |Added CC||jsa...@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11173 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9208 | --- Comment #59 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- As this patch seemed difficult to sign, I have made several small patches, each dealing with one problem (list in See also) I will mark this patch as resolved when all those patches will be pushed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Bob Birchall b...@calyx.net.au changed: What|Removed |Added CC||b...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #58 from Bob Birchall b...@calyx.net.au --- Where is this up to? Its marked 'Does not apply'. If it can be re-based, I'm up for testing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #57 from mathieu saby mathieu.s...@univ-rennes2.fr --- I'm a big lost. Is this bug for 3.8.x or for master ? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Eric Bégin eric.be...@inlibro.com changed: What|Removed |Added CC||eric.be...@inlibro.com --- Comment #56 from Eric Bégin eric.be...@inlibro.com --- Some email clients doesn't support UTF-8 encoding, should the charset be a system preference ? (emailCharset or emailEncoding) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10727 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10720 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl --- Several conflicts in overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I will try to test this, but a step by step test plan would be a great help in making this bug move. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #52 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Derrin, if you use -html option, you have to check html on you notice template in order your email get the right content type. And KohaAdminEmailAddress is only used if Library email address is not set. This was the previous way to send overdues and this patch does not change that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #53 from Derryn derr...@gmail.com --- (In reply to comment #52) Derrin, if you use -html option, you have to check html on you notice template in order your email get the right content type. And KohaAdminEmailAddress is only used if Library email address is not set. This was the previous way to send overdues and this patch does not change that. This is without the -html option. I'm not outputting them to a file, which the -html option is for; I'm making them to email. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #51 from Derryn derr...@gmail.com --- After I applied this patch on my 3.10.02 setup, my overdue notices go out as plain text, but still with the HTML markup applied. After opening the email and changing: Content-Type: text/plain; charset=UTF8 to Content-Type: text/html; charset=UTF8 It displays perfectly! Also, and I'm not sure if this is related, but overdue notices also seem not to respect the KohaAdminEmailAddress preference, instead using the default library email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #49 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Hi Jared, Without this patch, overdues notices are not correctly generated in html, so pdf file could not be produced. It is critical for our clients because they used to print overdue letters, and they can't do it anymore when upgrading to 3.8. There were several patches and follow-up provided. I only provide correction for the remaining problems and sqashed the already signed off patches. So concerning Katrin question about csv, modifications where in those primitive patches. Tell me if I should begin again from scratch an propose a new patch only dealing with html. Our librairies really need this funcitonality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #50 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #49) Without this patch, overdues notices are not correctly generated in html, so pdf file could not be produced. It is critical for our clients because they used to print overdue letters, and they can't do it anymore when upgrading to 3.8. So this is a feature that used to work? There were several patches and follow-up provided. I only provide correction for the remaining problems and sqashed the already signed off patches. So concerning Katrin question about csv, modifications where in those primitive patches. I guess hdl is the original author, and therefore no longer available to comment? I looked at the code, and it looks like the CSV-related changes may have been simply to quiet warnings, in which case, since it is an old patch, I have no objection to it remaining in place, provided the CSV export is tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #48 from Jared Camins-Esakov jcam...@cpbibliography.com --- I am entirely perplexed about what this patch is supposed to do and why it is marked critical. Based on the information on this report this sounds like at most a minor bug. Also, while I have this bully pulpit, could one of the original authors address Katrin's question about the CSV export changes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 stephane.dela...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9372 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13017|0 |1 is obsolete|| --- Comment #45 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14128 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14128action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 followup : add a condition to use getlanguage in bath mode Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Conflicts: misc/cronjobs/overdue_notices.pl Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14128|0 |1 is obsolete|| --- Comment #46 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14129 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14129action=edit [SIGNED-OFF] Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 followup : add a condition to use getlanguage in bath mode Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Conflicts: misc/cronjobs/overdue_notices.pl Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #47 from Kyle M Hall k...@bywatersolutions.com --- I think this needs to move forward to QA for the patch for master. There is little sense in having this held back by the lack of an SO for the 3.8.x versioned patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9216 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9208 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9210 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9180 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #44 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Katrin, Concerning table headers, we have defined a french .pref file that we copy in french directory each time we execute a translation. I agree it's not so good, but we need to have french headers for our customers. Do you have any better suggestion ? Else for the test plan, without the patch, if you use overdue_notices.pl with -html parameter, html file generated doesn't contain any HTML tags between pre and /pre, so the .pdf generated misc/cronjobs/printoverdues.sh contains only plain text without layout. If you apply the patch, then html file contains html tags and pdf file can then be generated with a nice layout. As far as csv parameter is concerned, I dedn't change anything from proposed patches that where signed off and that I squashed. But I asssume it should be better to test that nothing is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Derryn derr...@gmail.com changed: What|Removed |Added CC||derr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #41 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- I have changed the status of this ticket. This is not an enhancement, but a bugfix. The feature to create html file exist in overdue_notices.pl but it does not work withour this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Sophie, can you provide a test plan for this? I am not sure what this patch includes as it seems to do a lot of things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030
--- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Sophie, taking a look at your patch.
First thing I notice is that it also seems to touch the CSV export option. So
this needs to be retested as well?
I am worried about using the guided reports .pref files for the items table as
those are known to not be translatable with the scripts.
Also wondering if we really want to output a table. I think this should be
optional as it's a bigger change in behaviour. This seems to be the old output:
$return = pre\n;
$return .= $params-{'letter'}-{'content'}\n;
$return .= \n/pre\n;
I am also wondering about the syntaxes in the overdue letter to be used. Does
it work with both items.content and the itemfine/fine/item syntax?
Hope I didn't misread.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #12698|0 |1 is obsolete|| Attachment #12699|0 |1 is obsolete|| Attachment #12700|0 |1 is obsolete|| Attachment #12701|0 |1 is obsolete|| Attachment #12772|0 |1 is obsolete|| --- Comment #38 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 13017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13017action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 followup : add a condition to use getlanguage in bath mode Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Conflicts: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #39 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 13018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13018action=edit Bug 6030 [3.8.x] Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Bug 6030 followup : add a condition to use getlanguage in bath mode Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #40 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- I have squashed all the followup in one patch en send a specific pathc for 3.8.x Each patch was signed-off individually, but maybe the global patch should be validated again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030
--- Comment #37 from Paul Poulain paul.poul...@biblibre.com ---
I don't think this patch is just an ENH, sor RMaint, your choice, but this
patch should be OK in 3.8 imo
Examining possible side effect before pushing:
* The patch contains:
-my $titles = ;
+my $titles;
= I think it's a bad idea. If you have the html parameter, title will be
filled by
if ($htmlfilename) {
$titles = table id='itemscontent$borrowernumber';
but, if you don't have html, it will stay empty, and the line
$titles .= join(\t, @item_info) . \n;
will issue an error
I've reintroduced the = '';
* the patch add:
$letter-{'content-type'}=text/.($htmlfilename?html:plain).;
charset=UTF8;
= having a content-type is always ++
and it's the correct one I think if we don't have html
* testing the script:
- I get a bad
DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at
misc/cronjobs/overdue_notices.pl line 505.
I've attached a follow-up
2nd try = I can't get anything in the generated file.
Running the script
misc/cronjobs/overdue_notices.pl --html=test-html -v
tells me that I've one patron late:
returns 1 rows at misc/cronjobs/overdue_notices.pl line 490.
borrower firstname, TEST (7852) has items triggering level 1. at
misc/cronjobs/overdue_notices.pl line 496.
STH2 PARAMS: borrowernumber = 7852, mindays = 1, maxdays = 90 returns 1 rows at
misc/cronjobs/overdue_notices.pl line 506.
but the generated HTML is empty:
html
head
style type='text/css'
pre {page-break-after: always;}
pre {white-space: pre-wrap;}
pre {white-space: -moz-pre-wrap;}
pre {white-space: -o-pre-wrap;}
pre {word-wrap: break-work;}
/style
/head
body
/body
/html
The notice defined for this patron is ODUE, i've checked the html on
tools/letters.pl
so... any idea why I can't make it work welcomed.
I also think a squashed patch (with an updated git patch comment) would be more
than welcomed. Those 5 patches are looking poor !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #35 from Mason James m...@kohaaloha.com --- (In reply to comment #34) Created attachment 12701 [details] [SIGNED-OFF] Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Kyle M Hall k...@bywatersolutions.com 4 patches look good, passing QA on this... $ koha-qa.pl -c 4 testing 4 commit(s) (applied to commit 37340e3) * 4403c59 Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title misc/cronjobs/overdue_notices.pl * a9a93a7 Bug 6030 follow-up koha-tmpl/intranet-tmpl/prog/en/columns.def misc/cronjobs/overdue_notices.pl * 5fc93ff Bug 6030 followup : add a condition to use getlanguage in bath mode C4/Templates.pm * 437886a Bug 6030 Allow html content in letters misc/cronjobs/overdue_notices.pl * misc/cronjobs/overdue_notices.pl OK * C4/Templates.pm OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12232|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12698 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12698action=edit [SIGNED-OFF] Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12234|0 |1 is obsolete|| --- Comment #32 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12699 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12699action=edit [SIGNED-OFF] Bug 6030 followup : add a condition to use getlanguage in bath mode Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12235|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12700 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12700action=edit [SIGNED-OFF] Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12397|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12701 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12701action=edit [SIGNED-OFF] Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #30 from Magnus Enger mag...@enger.priv.no --- As far as I can tell, attachments 12232, 12235 and 12397 have signoffs, but not 12234. Having a unified signoff on all of them would probably be good. I just did git bz apply 6030 on current master and all patches applied, so I'm resetting to Needs signoff, but I wont have time to do a signoff now myself, so please feel free... :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #29 from wajasu matted-34...@mypacks.net --- The third one, is the one I believe I had problems applying. attachment 12235 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 wajasu matted-34...@mypacks.net changed: What|Removed |Added Status|Failed QA |Patch doesn't apply CC||matted-34...@mypacks.net --- Comment #27 from wajasu matted-34...@mypacks.net --- The Bug 6030 follow-up needs to be adjusted so the patch will apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #25 from Paul Poulain paul.poul...@biblibre.com --- Running the script says: DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at ./overdue_notices.pl line 505. DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at ./overdue_notices.pl line 518. Investigating a little, show that line 505 is running $sth2, that contains: my $sth2 = $dbh-prepare( 'END_SQL' ); SELECT biblio.title as biblio.title, biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue FROM issues,items,biblio, biblioitems WHERE items.itemnumber=issues.itemnumber AND biblio.biblionumber = items.biblionumber AND biblio.biblionumber = biblioitems.biblionumber AND issues.borrowernumber = ? AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? END_SQL the line: AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? is heavily wrong ! The signoff was probably right when it was made, but time passed, things were updated, and now it's invalid ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #12112|0 |1 is obsolete|| --- Comment #20 from Mason James m...@kohaaloha.com --- Created attachment 12231 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12231action=edit Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #12110|0 |1 is obsolete|| Attachment #12111|0 |1 is obsolete|| Attachment #12113|0 |1 is obsolete|| --- Comment #21 from Mason James m...@kohaaloha.com --- Created attachment 12232 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12232action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #22 from Mason James m...@kohaaloha.com --- Created attachment 12234 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12234action=edit Bug 6030 followup : add a condition to use getlanguage in bath mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #23 from Mason James m...@kohaaloha.com --- Created attachment 12235 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12235action=edit Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact|koha-b...@lists.koha-commun |m...@kohaaloha.com |ity.org | --- Comment #24 from Mason James m...@kohaaloha.com --- Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com i rebased these 4 patches to apply to master patches looks good, passing QA… nice work Sophie! $ koha-qa.pl -c 4 testing 4 commit(s) (applied to commit 0acebb8) * e34fa8f Bug 6030 followup : add a condition to use getlanguage in bath mo C4/Templates.pm * cb90e51 Bug 6030 follow-up koha-tmpl/intranet-tmpl/prog/en/columns.def misc/cronjobs/overdue_notices.pl * a346838 Bug 6030 followup : Specify biblio.title as a column name to di misc/cronjobs/overdue_notices.pl * 8ff05be Bug 6030 Allow html content in letters misc/cronjobs/overdue_notices.pl * C4/Templates.pm OK * misc/cronjobs/overdue_notices.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #15 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 12110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12110action=edit Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #16 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 12111 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12111action=edit Bug 6030 followup : add a condition to use getlanguage in bath mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #17 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 12112 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12112action=edit Bug 6030 followup : Specify biblio.title as a column name to differentiate from borrowers.title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #5241|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #6251|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #6252|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off CC||sophie.meyni...@biblibre.co ||m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #18 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 12113 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12113action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT henridamien.laur...@biblibre.com Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux sophie.meyni...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Attachment #5240|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #19 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- I have signed off the first 2 patches and added 2 small follow-up : * the first one is need because when $query is not defined, themelanguage returns an error * the seconf one because in french we need to differentiate borrowers.title and biblio.title (it's not the same translation) I don't know why the main path is the fourth file sended : in consequence, to test, you should apply 4th patch first and then 1, 2 and 3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #14 from Paul Poulain paul.poul...@biblibre.com 2012-01-18 11:23:22 UTC --- *** Bug 5878 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P3 Version|rel_3_4 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 20:06:29 UTC --- Follow up does not apply: [~/kohaclone (6030_htmloverdues)⚡] git am -iu3 /tmp/proposed-patch-follow-up-jH3H5e.patch Commit Body is: -- Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the explained row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def -- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6030 follow-up fatal: sha1 information is lacking or useless (misc/cronjobs/overdue_notices.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6030 follow-up When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 20:07:25 UTC --- Paul, can you clear up the relationship to bug 5878? - Can this bug be closed as features will be implemented incrementally by other bugs/patches? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Patch Status|Failed QA |Needs Signoff --- Comment #10 from Paul Poulain paul.poul...@biblibre.com 2012-01-09 19:46:30 UTC --- (In reply to comment #9) Ok, I am confused here - perhaps someone can clarify: why is this failed qa and what is the relation to 5878 (that I spent a lot of time testing on)? Reading the bug history, I can't explain why I've set failed QA. I feel I made the change without noticing it. Switching back to need signoff. Nicholas : could you confirm your alternative patch SQL required are both an alternative option ? In this case i'll mark them as obsolete continue with my initial patches -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #11 from Nicholas van Oudtshoorn vano...@gmail.com 2012-01-10 01:44:33 UTC --- Hi Paul, Yes - they're an alternative option. (A quick solution I threw together so that our library could send nice-looking email reminders out! - I'm more than happy for an official solution - this was just a hey - this is how we've solved it when I noticed that the problem was being worked on) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-06 15:14:34 UTC --- Ok, I am confused here - perhaps someone can clarify: why is this failed qa and what is the relation to 5878 (that I spent a lot of time testing on)? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added AssignedTo|henridam...@koha-fr.org |stephane.delaune@biblibre.c ||om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #7 from Nicholas van Oudtshoorn vano...@gmail.com 2011-11-08 08:12:45 UTC --- Created attachment 6251 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6251 Alternative patch-set to send html emails Found this bug after just having patched our installation at library.pbc.wa.edu.au to send html notices. (The same issue, addressed in slightly different ways) If it's of any use, I've attached the diff of what we use to send html emails If this is simply noise, please let me know! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Nicholas van Oudtshoorn vano...@gmail.com changed: What|Removed |Added CC||vano...@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #8 from Nicholas van Oudtshoorn vano...@gmail.com 2011-11-08 08:39:24 UTC --- Created attachment 6252 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6252 SQL required for the previous patch-set This SQL is required for the previous patch-set used at Perth Bible College. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #3596|0 |1 is obsolete|| --- Comment #5 from Paul Poulain paul.poul...@biblibre.com 2011-08-31 14:12:52 UTC --- Created attachment 5240 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5240 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
Patch Status|Signed Off |Failed QA
--- Comment #3 from Paul Poulain paul.poul...@biblibre.com 2011-08-09
15:57:02 UTC ---
doing some tests, I get:
17:47 ~/koha.dev/koha-community (BZ6030 $%)$ misc/cronjobs/overdue_notices.pl
--html=test-html
Global symbol $columns_def_hashref requires explicit package name at
misc/cronjobs/overdue_notices.pl line 486.
Execution of misc/cronjobs/overdue_notices.pl aborted due to compilation
errors.
Digging into biblibre/master, I see this script has more lines :
my $columns_def_hashref = C4::Reports::Guided::_get_column_defs();
foreach my $key ( keys %$columns_def_hashref ) {
my $initkey = $key;
$key =~ s/[^\.]*\.//;
$columns_def_hashref-{$initkey}=NormalizeString($columns_def_hashref-{$initkey});
$columns_def_hashref-{$initkey}=~s# #br/#;
$columns_def_hashref-{$key} = $columns_def_hashref-{$initkey};
}
I think adding them will result in the script working, but without this, it
can't work.
Nicole = what kind of tests did you do ?
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #4 from Nicole C. Engard neng...@gmail.com 2011-08-09 21:07:19 UTC --- All my tests are purely cosmetic. The email generated with HTML in it. I did not send the emails (cause I don't have email sending turned on) and I don't read the server logs or anything. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com Patch Status|Needs Signoff |Signed Off --- Comment #2 from Nicole C. Engard neng...@gmail.com 2011-07-06 15:59:38 UTC --- I tested a few HTML tags and it appears to work, it should probably be tested again and get a second sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|kyle.m.h...@gmail.com |henridam...@koha-fr.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
