[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Fridolin SOMERS changed: What|Removed |Added Blocks||9654 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #29 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #28 from mathieu saby --- (In reply to Martin Renvoize from comment #27) > Hi Mathieu, > > There were a few IRC converstaions and a thread on the mailing list about > tidying the whole koha codebase at some point.. I think the final decision > was to just do it as we go along instead of a massive change.. which is > exactly what you've done here so is good.. > > I'de leave the patch in, now it's marked passed QA it'll pass by Galen > attention and I'm sure he'll make a sensible decision either way. > > Martin OK I remember having read - not to mix reindenting and new code in the same commit - not to do a patch only for reindenting So, as this bug changes some behavior in a template file, I think it is legitimate to add a followup for reindenting the file. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #27 from Martin Renvoize --- Hi Mathieu, There were a few IRC converstaions and a thread on the mailing list about tidying the whole koha codebase at some point.. I think the final decision was to just do it as we go along instead of a massive change.. which is exactly what you've done here so is good.. I'de leave the patch in, now it's marked passed QA it'll pass by Galen attention and I'm sure he'll make a sensible decision either way. Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #26 from mathieu saby --- (In reply to Martin Renvoize from comment #25) > Passing QA for that final followup. It's a template tidy up which doesn't > affect operation. > > It'll affect blame as it change whitespace (which can be ignored by -w) but > also breaks lines. > > I'm not sure that discussion ever came to an end, but I don't see why the > initial two patches can't get pushed? Hello Discussion with whom? In fact, if someone really does not want this followup, of course I can suppress the patch. But I think the reindenting on this file was really needed and will make further changes easier ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- Passing QA for that final followup. It's a template tidy up which doesn't affect operation. It'll affect blame as it change whitespace (which can be ignored by -w) but also breaks lines. I'm not sure that discussion ever came to an end, but I don't see why the initial two patches can't get pushed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #24 from Martin Renvoize --- Works as expected.. the final patch really is just a indenting clean up. Patch still works, patches all still pass qa script and code looks much nicer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize changed: What|Removed |Added Attachment #22827|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 23233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23233&action=edit Bug 9807, followup: Reindent basketgroup.tt Basketgroup.tt is very hard to read. This patch simply reindents it. No visiable changes expected Regression test : - check the list of opened and closed basketgroups for a vendor is displayed properly - check an individual basketgroup (closed and opened) is displayed properly - check you can edit a basketgroup and save changes - check you can print and export a basketgroup - check you can close and reopen a basketgroup http://bugs.koha-community.org/show_bug.cgi?id=9807 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Status|Passed QA |Needs Signoff --- Comment #22 from mathieu saby --- Regression test : - check the list of opened and closed basketgroups for a vendor is displayed properly - check an individual basketgroup (closed and opened) is displayed properly - check you can edit a basketgroup and save changes - check you can print and export a basketgroup - check you can close and reopen a basketgroup The last attachment Needs signoff. The 2 firsts have passed QA M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #21 from mathieu saby --- Created attachment 22827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22827&action=edit [PATCH 3] Bug 9807 : Reindent basketgroup template Subject: [PATCH 3/3] reindent basketgroup.tt Content-Type: text/plain; charset="utf-8" Basketgroup.tt is very hard to read This patch reindents it No visiable changes expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22793|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #20 from mathieu saby --- (In reply to Kyle M Hall from comment #19) > I would like to note that the pdf print view is a "interesting" but > certainly no reason to not pass qa. I think a long term future goal should > be to enable Template Toolkit for slips and notices, and then perhaps switch > print views such as this to being html views configurable via slips and > notices. Hi Not sure to understand your message. You mean generate the pdf from a HTML file, not with Perl PDF library? If so, yes it would be a good idea ;-) But my patch did not concern this part of code... Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com --- Comment #19 from Kyle M Hall --- I would like to note that the pdf print view is a "interesting" but certainly no reason to not pass qa. I think a long term future goal should be to enable Template Toolkit for slips and notices, and then perhaps switch print views such as this to being html views configurable via slips and notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #18 from Kyle M Hall --- Created attachment 22813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22813&action=edit Bug 9807 : Followup fixing variable name Fixing closedbg name in template Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall changed: What|Removed |Added Attachment #22792|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 22812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22812&action=edit Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. Signed-off-by: cedric.v...@dracenie.com Signed-off-by: Kyle M Hall Passes koha-qa.pl, t and xt. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22782|0 |1 is obsolete|| --- Comment #16 from mathieu saby --- Created attachment 22793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22793&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22781|0 |1 is obsolete|| --- Comment #15 from mathieu saby --- Created attachment 22792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22792&action=edit [PATCH ] Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting Should be more easy to understand. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #14 from mathieu saby --- Jonathan, I will rewrite the patch without any reindenting. I think it will be more easy to understand for QA team. As reindenting is needed for code readabiliy, it will add a followup for it. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #11 from mathieu saby --- The closedbg variable passed to template is used to decide if the bg must be only displayed, or make editable. By the way, I've remarked a typo : "closedgb" for "closedbg". I'm writing a followup. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #13 from mathieu saby --- Created attachment 22782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22782&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name Fixing closedbg name in template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Attachment #22023|0 |1 is obsolete|| --- Comment #12 from mathieu saby --- Created attachment 22781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22781&action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it Main patch rebased (little conflict) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #10 from mathieu saby --- > 2/ The view "show" is not clear in the code. Personally, I don't understand > anything. Could you specify what you call the view "show" ? I don't find the "show" word in my patch. > 3/ There is some useless loop: > [% FOREACH billingplaceloo IN billingplaceloop %] > [% IF ( billingplaceloo.selected ) %] > [% billingplaceloo.branchname %] > [% END %] > [% END %] > It is not a logic way to display an input. This unless loop was here before my patch. So I kept it here. It was not my goal to remove it. But it can be fixed later. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #9 from mathieu saby --- (In reply to Jonathan Druart from comment #8) > I am a little bit disconcerted. > The aqbasketgroup.tt is really dirty and it is not easy to do something in > it. => so true. it's horrible. And very hard to understand without reindenting... > But this patch is not really clear: > 1/ I don't know if to add a lot of simple comment is useful (in the pl file). It was usefull for me, to understand how the file was structured. But I can suppress comments if they are unneeded. > 4/ There is a mix between new code and indentation fixes (use the -w option > for git show). For me reindentation were logical, because I add a new condition in the template (l. 147:[% IF (closedbg) %] ), so I felt free to reindent For the other points, I cannot answer quickly, and must watch it closely. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart --- I am a little bit disconcerted. The aqbasketgroup.tt is really dirty and it is not easy to do something in it. But this patch is not really clear: 1/ I don't know if to add a lot of simple comment is useful (in the pl file). 2/ The view "show" is not clear in the code. Personally, I don't understand anything. 3/ There is some useless loop: [% FOREACH billingplaceloo IN billingplaceloop %] [% IF ( billingplaceloo.selected ) %] [% billingplaceloo.branchname %] [% END %] [% END %] It is not a logic way to display an input. 4/ There is a mix between new code and indentation fixes (use the -w option for git show). 5/ There is no "show" view for the opened bg. And for the closed bd, the "show" view is accessible on click on a button. Why there is no a simple "show" op and a link on the bg name? I let someone else from the QA team to give his/her opinion on this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #7 from mathieu saby --- Thank you Pierre and Cedric! Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 sandbo...@biblibre.com changed: What|Removed |Added Attachment #22021|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #5 from sandbo...@biblibre.com --- Patch tested with a sandbox, by cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #6 from sandbo...@biblibre.com --- Created attachment 22023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22023&action=edit Bug 9807 : Make possible to view a basketgroup without reopening it This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. Signed-off-by: cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #4 from mathieu saby --- (In reply to mathieu saby from comment #3) > Next step for improving basketgroup management will be Bug 10919 > > M. Saby And make links from other pages (orders, baskets...) to a specific basket group when it is needed (it was not possible before this patch, because it reopened automatically the basketgroup...) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #3 from mathieu saby --- Next step for improving basketgroup management will be Bug 10919 M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #2 from mathieu saby --- Created attachment 22021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22021&action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #1 from mathieu saby --- I am working on that Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
