[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Blocks|14702 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 [Bug 14702] Refactor GetReserveFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7957 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #63 from Tomás Cohen Arazi --- Patches pushed to master. Thanks guys! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Tomás Cohen Arazi changed: What|Removed |Added Severity|normal |enhancement CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What|Removed |Added Blocks||12632 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What|Removed |Added Blocks|12632 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What|Removed |Added Blocks||12632 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Blocks||14337 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41850|0 |1 is obsolete|| --- Comment #58 from Jonathan Druart --- Created attachment 41899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41899&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41848|0 |1 is obsolete|| --- Comment #56 from Jonathan Druart --- Created attachment 41897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41897&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall AMENDED: An else branch in reserve/placerequest.pl was removed. This had the effect of making it no longer possible to place an any hold in the staff client. Signed-off-by: Marcel de Rooy Verified placing a biblio level and an item level hold. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41851|0 |1 is obsolete|| --- Comment #59 from Jonathan Druart --- Created attachment 41900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41900&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41810|0 |1 is obsolete|| --- Comment #52 from Jonathan Druart --- Created attachment 41893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41893&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41849|0 |1 is obsolete|| --- Comment #57 from Jonathan Druart --- Created attachment 41898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41898&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #62 from Jonathan Druart --- Created attachment 41903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41903&action=edit Bug 9809: Remove one more occurrence of reserveconstraints This file is not updated, but no need to keep on occurrence of an nonexistent table in it. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41812|0 |1 is obsolete|| --- Comment #54 from Jonathan Druart --- Created attachment 41895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41895&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809
--- Comment #61 from Jonathan Druart
---
Created attachment 41902
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41902&action=edit
Bug 9809: Fix pod errors
FAIL C4/Reserves.pm
FAIL pod
in file C4/Reserves.pm
*** ERROR:
Spurious =cut command
Test plan:
perl -e "use Pod::Checker;podchecker('C4/Reserves.pm');"
Should not return any errors.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41852|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 41901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41901&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41813|0 |1 is obsolete|| --- Comment #55 from Jonathan Druart --- Created attachment 41896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41896&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41811|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 41894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41894&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Attachment #41809|0 |1 is obsolete|| --- Comment #51 from Jonathan Druart --- Created attachment 41892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41892&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41845|0 |1 is obsolete|| --- Comment #50 from Marcel de Rooy --- Created attachment 41852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41852&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41817|0 |1 is obsolete|| --- Comment #49 from Marcel de Rooy --- Created attachment 41851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41851&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41815|0 |1 is obsolete|| --- Comment #47 from Marcel de Rooy --- Created attachment 41849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41849&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41814|0 |1 is obsolete|| --- Comment #46 from Marcel de Rooy --- Created attachment 41848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41848&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall AMENDED: An else branch in reserve/placerequest.pl was removed. This had the effect of making it no longer possible to place an any hold in the staff client. Signed-off-by: Marcel de Rooy Verified placing a biblio level and an item level hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41816|0 |1 is obsolete|| --- Comment #48 from Marcel de Rooy --- Created attachment 41850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41850&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #45 from Marcel de Rooy --- Created attachment 41845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41845&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41774|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41773|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41770|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41771|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41772|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41769|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41768|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #41767|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #44 from Marcel de Rooy --- Rebased (after 14464) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #42 from Marcel de Rooy --- Created attachment 41816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41816&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #40 from Marcel de Rooy --- Created attachment 41814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41814&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #38 from Marcel de Rooy --- Created attachment 41812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41812&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #39 from Marcel de Rooy --- Created attachment 41813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41813&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #43 from Marcel de Rooy --- Created attachment 41817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41817&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #41 from Marcel de Rooy --- Created attachment 41815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41815&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #37 from Marcel de Rooy --- Created attachment 41811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41811&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #36 from Marcel de Rooy --- Created attachment 41810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41810&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #35 from Marcel de Rooy --- Created attachment 41809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41809&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #33) > Bug 14464 is passed QA and will be in conflict with this patch. Please > provide a followup build on top of it. Well. maybe we should wait to see it get pushed first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7376 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13903 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14097 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14337 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14155 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #33 from Jonathan Druart --- Bug 14464 is passed QA and will be in conflict with this patch. Please provide a followup build on top of it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #32 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #22) > Looks good to me! Thanks, Kyle. > I added two small follow-ups and a see-also to a new report for > GetReserveFee. Thanks for the followups Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #27 from Kyle M Hall --- Created attachment 41770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41770&action=edit [SIGNED-OFF] Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #31 from Kyle M Hall --- Created attachment 41774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41774&action=edit [SIGNED-OFF] Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #29 from Kyle M Hall --- Created attachment 41772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41772&action=edit [SIGNED-OFF] Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #30 from Kyle M Hall --- Created attachment 41773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41773&action=edit [SIGNED-OFF] Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #28 from Kyle M Hall --- Created attachment 41771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41771&action=edit [SIGNED-OFF] Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #26 from Kyle M Hall --- Created attachment 41769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41769&action=edit [SIGNED-OFF] Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What|Removed |Added Attachment #41754|0 |1 is obsolete|| Attachment #41755|0 |1 is obsolete|| Attachment #41756|0 |1 is obsolete|| Attachment #41757|0 |1 is obsolete|| Attachment #41758|0 |1 is obsolete|| Attachment #41759|0 |1 is obsolete|| Attachment #41760|0 |1 is obsolete|| Attachment #41761|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 41767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41767&action=edit [SIGNED-OFF] Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #25 from Kyle M Hall --- Created attachment 41768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41768&action=edit [SIGNED-OFF] Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #23 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > [2] Check the warn for placing a hold on such a book in OPAC. Actually, this should read: a hold for such a patron ! Maybe we should also think of moving this fee to item types? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Blocks||14702 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 [Bug 14702] Fix GetReserveFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14702 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #22 from Marcel de Rooy --- Looks good to me! Thanks, Kyle. I added two small follow-ups and a see-also to a new report for GetReserveFee. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40736|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 41757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41757&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #20 from Marcel de Rooy --- Created attachment 41760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41760&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40738|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 41759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41759&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #21 from Marcel de Rooy --- Created attachment 41761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41761&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40737|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 41758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41758&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40735|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 41756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41756&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40734|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 41755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41755&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy changed: What|Removed |Added Attachment #40733|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 41754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41754&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #13 from Marcel de Rooy --- Testing this one now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |k...@bywatersolutions.com |ommunity.org| --- Comment #12 from Jonathan Druart --- Yes it is! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809
--- Comment #11 from Katrin Fischer ---
Comment on attachment 40738
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40738
Bug 9809 - Update AddReserve prototype to remove constraint parameter
Review of attachment 40738:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9809&attachment=40738)
-
::: C4/Reserves.pm
@@ -694,5 @@
> $sth1->execute($biblionumber);
> while ( my $data1 = $sth1->fetchrow_hashref ) {
> -if ( $const eq "a" ) {
> -push @biblioitems, $data1;
> -}
Could it be this here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--- Comment #10 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #9)
> Kyle,
> Thanks for these patches, it's a much more complete solution than the one I
> have proposed.
>
> I have a doubt with the changes in GetReserveFee:
> Before the patches:
> if ( $const eq "a" ) {
> push @biblioitems, $data1;
> }
> else {
> some code;
> }
>
> now you always execute some code.
>
> But before the patch, $const was sometime equal to "a".
> I am not sure about the consequences of this change.
Can you add a splinter review? I'm not sure exactly where the code you are
referencing is. You can also add a followup to fix it if that's easier.
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809
--- Comment #9 from Jonathan Druart ---
Kyle,
Thanks for these patches, it's a much more complete solution than the one I
have proposed.
I have a doubt with the changes in GetReserveFee:
Before the patches:
if ( $const eq "a" ) {
push @biblioitems, $data1;
}
else {
some code;
}
now you always execute some code.
But before the patch, $const was sometime equal to "a".
I am not sure about the consequences of this change.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #7 from Kyle M Hall --- Created attachment 40737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40737&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #6 from Kyle M Hall --- Created attachment 40736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40736&action=edit Bug 9809 - Update unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #8 from Kyle M Hall --- Created attachment 40738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40738&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #5 from Kyle M Hall --- Created attachment 40735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40735&action=edit Bug 9809 - Remove DBIC module for reserveconstraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What|Removed |Added Attachment #37638|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 40733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40733&action=edit Bug 9809 - DB Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #4 from Kyle M Hall --- Created attachment 40734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40734&action=edit Bug 9809 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Component|Hold requests |Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #1 from M. de Rooy --- Include the code around reqbib in reserve/placerequest.pl ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
