[Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

--- Comment #29 from Emmi Takkinen  ---
Looking this again and trying to figure out a simpler solution to original
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9762] Log circulation overrides

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Anneli Österman  changed:

   What|Removed |Added

 CC||anneli.osterman@koha-suomi.
   ||fi

--- Comment #28 from Anneli Österman  ---
I tested in Bywater's sandbox points 1, 2, 3, 10 and 16 and was about to
comment that these doesn't work because there were no logs for those borrowers
whose restriction was overridden. Then I checked the action_logs table with SQL
report and noticed that there actually were logs for overrides. But there were
no object recorded which is why I did not find anything at first with the log
viewer.

Should the borrowernumber of the borrower whose resctriction is overridden be
recorded as well to the object column in action_logs? It would help to find
those overrides more easily. I intuitively looked for them from borrowers logs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36161] ILS-DI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161

--- Comment #5 from Nick Clemens  ---
Currently the checkpw_internal gets patron by userid and check the password if
a patron is found, then it gets patron by cardnumber and checks password.

This patch reduces that to a single check, get patron by either field, then
check password - it's going to muddy the case where a username/cardnumber is
shared

bug 14323 aims to disallow, but I think we need to reconcile this one and 36575
- can you compare them Kyle?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #102 from Katrin Fischer  ---
I am sure everyone here has tested well, but I'd feel a little bit more
confident if we could maybe get Kyle or another hold expert to look at this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #103 from Katrin Fischer  ---
I don't have a status for "request additional review". Hmpf. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706

--- Comment #4 from Pedro Amorim  ---
Thanks for the clearer instructions, David, I skipped a few in my test plan.
Sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

--- Comment #10 from Katrin Fischer  ---
Pretty happy to see this addressed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Katrin Fischer  changed:

   What|Removed |Added

Summary|Display current date in |Display current date in
   |Hold starts on date on  |hold starts on when placing
   |opac-reserve|a hold in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #18 from Katrin Fischer  ---
I am sorry, but this breaks the datepickers on the OPAC reserve page totally
for me now :(

The input shows:
2024-04-26T1

JS error:
Uncaught ReferenceError: Date_from_syspref is not defined

I was a little mean and set the DateFormat to the German DD.MM..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #104 from Nick Clemens  ---
I am still unsure about one of the lines here:

In CanBookBeReserved, during the item loop:
return { status => 'recordHoldNotAllowed' } if $opacitemholds eq 'F';


If one of the items is type 'new' and doesn't allow record level holds, but
another is 'book' and does allow it - we will return 'recordHoldNotAllowed' if
we hit the 'new' item first.

You also call 'get_opacitemholds_policy' in CanBookBeReserved and also add a
call to get_effective_rules in CanItemBeReserved - these should be getting the
same rule - why do we need to check at both levels? The check in
CanItemBeReseerved should handle returning the necessary status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36295] Space out content blocks in batch record deletion

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295

Katrin Fischer  changed:

   What|Removed |Added

Summary|Space out content blocks in |Space out content blocks in
   |Batch record deletion   |batch record deletion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676

--- Comment #2 from David Nind  ---
I've tested under 23.11 and the patch works as per the test plan.

However, on main, I can't seem to run the emulator - not quite sure why as it
has worked fine in the past when testing other bugs:

perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp
term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount
0.01
Attempting socket connection to 127.0.0.1:6001...failed! : Connection refused

The bug title and description need to be changed as per the commit message
guidelines https://wiki.koha-community.org/wiki/Commit_messages

- Bug 36676: Short title

  Short description about what the bug fixes.

  Test plan:
  

In addition, should this change be made to main (previously master) as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

--- Comment #23 from Katrin Fischer  ---
I do like the documentation and the --confirm :)

I haven't tested this deeply, but it comes with a test run mode and is also
self contained. It kinda feels like we should be able to have tests for this...
but I know it's just a CLI script.

I notice it takes a while, even on my small sample database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

--- Comment #25 from Katrin Fischer  ---
Thanks for the follow-up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36135] Add tool to batch modify holds

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135

Laura O'Neil  changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #165526|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Laura Escamilla  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

--- Comment #6 from Laura Escamilla  ---
Created attachment 165651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165651&action=edit
Bug 35669 - Updated check in message for a specific authorised value in the
LOST authorised values (edit) To test:

1. Set an item to a Lost status of "Lost". When you check in that item you will
get a message that says "Item was lost, now found."
2. Set an item to a Lost status of "Missing". When you check in that item you
will get the same message that says "Item was lost, now found."
3. Apply the patch.
4. Set an item to a Lost status of “Missing”. When you check in that item you
will now get the message that says “Item was Missing, now found.”
5. Test step 4 with other custom LOST authorised values. The checkin message
should match those value descriptions.
6. Sign off and have a wonderful day :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23350] Add another variable for advanced prediction pattern

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23350

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

--- Comment #5 from Maude  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |release-notes-needed

--- Comment #115 from Katrin Fischer  ---
Hm, DBIC changes here are mixed in with other changes, so I have kept the
patch. dbic comes up empty. I have been told it would be better to regenerate
usually so timestamps etc. match

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #165651|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #116 from Katrin Fischer  ---
I am a fan of scripts that update data having a --confirm switch, this one just
has the -h. I know that you should always run the latter first, so leaving this
more as a note and suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22180] SERIAL_ALERT email does not send if the status is claimed before arrived

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22180

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

--- Comment #24 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #117 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16567] RSS feeds show issues in W3C validator and can't be read by some aggregators (Chimpfeedr, feedbucket)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16567

--- Comment #11 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893

--- Comment #37 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

--- Comment #20 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36160] Use $builder->build_object when creating patrons in Circulation.t

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160

--- Comment #8 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

--- Comment #26 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36295] Space out content blocks in batch record deletion

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36295] Space out content blocks in batch record deletion

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36295

--- Comment #11 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36535] 33568 introduced too many changes in modules without tests

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36535

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36535] 33568 introduced too many changes in modules without tests

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36535

--- Comment #7 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

--- Comment #4 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36703] Link to ERM from Vendor detail page

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36703

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36704] Add WYSIWYG support to Agreement Descriptions

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36704

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676

Jan Kissig  changed:

   What|Removed |Added

 Attachment #165436|0   |1
is obsolete||

--- Comment #3 from Jan Kissig  ---
Created attachment 165652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165652&action=edit
BUG 36676: SIP2 drops connection on unknown patron id in fee paid message

When sending a fee paid message to SIP2 with an unknown patron id it will
respond with an empty response followed by dropping the connection to a client.

to test on ktd (23.11):
a) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1
-sp term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT
--fee-amount 0.01
Output:
Trying 'fee_paid'
SEND: 3720240423124447FT00USDBV0.01|AO|AA2352900100046|ACterm1|
Use of uninitialized value $data in concatenation (.) or string at
/usr/share/koha/bin/sip_cli_emulator.pl line 355,  chunk 1.
READ:

b) apply patch
c) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1
-sp term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT
--fee-amount 0.01
Output:
Trying 'fee_paid'
SEND: 3720240423125602FT00USDBV0.01|AO|AA2352900100046|ACterm1|
READ: 38N20240423125602AO|AA2352900100046|AFInvalid patron barcode.|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676

Jan Kissig  changed:

   What|Removed |Added

 Attachment #165652|0   |1
is obsolete||

--- Comment #4 from Jan Kissig  ---
Created attachment 165653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165653&action=edit
BUG 36676: SIP2 drops connection on unknown patron id in fee paid message

When sending a fee paid message to SIP2 with an unknown patron id it will
respond with an empty response followed by dropping the connection to a client.

to test on ktd (23.11):
a) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1
-sp term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT
--fee-amount 0.01
Output:
Trying 'fee_paid'
SEND: 3720240423124447FT00USDBV0.01|AO|AA2352900100046|ACterm1|
Use of uninitialized value $data in concatenation (.) or string at
/usr/share/koha/bin/sip_cli_emulator.pl line 355,  chunk 1.
READ:

b) apply patch
c) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1
-sp term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT
--fee-amount 0.01
Output:
Trying 'fee_paid'
SEND: 3720240423125602FT00USDBV0.01|AO|AA2352900100046|ACterm1|
READ: 38N20240423125602AO|AA2352900100046|AFInvalid patron barcode.|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||RM_priority

--- Comment #19 from Katrin Fischer  ---
... as I just accidentally pushed this - could we get a quick follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23426] Empty AV field returned in Patron Info in addition to those requested

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23426

Jan Kissig  changed:

   What|Removed |Added

 Attachment #165509|0   |1
is obsolete||

--- Comment #8 from Jan Kissig  ---
Created attachment 165654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165654&action=edit
BUG 23426: Add fine items to patron information response in SIP2

This patch adds fine items (AV) to patron information response in SIP2
In addition the active currency we be part of the response (BH)
This also fixes the number of items in the response which are specified in BP
and BQ in the request

to test:
a) create a manual invoice for patron 2352935676 :
http://localhost:8081/cgi-bin/koha/members/maninvoice.pl?borrowernumber=19
b) in ktd call: perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p
6001 -su term1 -sp term1   -l CPL --patron 2352935676 -m patron_information
-s "  Y   "
c) verify that no |AV field is in response
d) apply patch
e) in ktd call: perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p
6001 -su term1 -sp term1   -l CPL --patron 2352935676 -m patron_information
-s "  Y   "
f) verify that response includes fields like '|AVManual fee '

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26297] Add a route to list patron categories

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26297] Add a route to list patron categories

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #165453|0   |1
is obsolete||

--- Comment #45 from Tomás Cohen Arazi  ---
Created attachment 165655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165655&action=edit
Bug 26297: (QA follow-up): Update tests

prove t/db_dependent/api/v1/patron_categories.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165611|0   |1
is obsolete||

--- Comment #29 from Martin Renvoize  ---
Created attachment 165656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165656&action=edit
Bug 32435: Add TICKET_RESOLUTION authorized value

Signed-off-by: David Nind 
Signed-off-by: Ray Delahunty 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165612|0   |1
is obsolete||

--- Comment #30 from Martin Renvoize  ---
Created attachment 165657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165657&action=edit
Bug 32435: Add resolution states to Catalog concerns

This patch adds resolution types to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_RESOLUTION' authorized
values from which librarians can then pick at the point of resolving a
catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still resolve a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_RESOLUTION authorized values
6) Submit a new catalog concern
7) Confirm that the 'Resolve' button in the management modal is now a
   dropdown containing the list of resolution values defined above.

Signed-off-by: David Nind 
Signed-off-by: Ray Delahunty 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165613|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 165658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165658&action=edit
Bug 32435: Unit tests for Ticket/Ticket::Update change

We add a fallback to allow TICKET_RESOLUTIONS to be returned in the
strings_map as additional TICKET_STATUS states.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36641] Add an endpoint to list effective circulation rules for an itemtype, branchcode, patron category combination

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

--- Comment #3 from Tomás Cohen Arazi  ---
A few remarks:

* The order of the path parameters is arbitrary, right? I assume you thought
about it
* The parameter names should be fixed to our current uses
* The returned structure is under specified
* I never liked /circulation-rules, can we make it /circulation_rules so it
matches all other routes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435

--- Comment #32 from Martin Renvoize  ---
Just fixed the Tidy issue.

I agree with the somewhat odd use of two AV's.. I couldn't come up with a
better solution that gave the end result people wanted.. maybe we'll eventually
migrate these out of AV's though if they end up with a stronger workflow
management piece.. which is planned.. at that point I could see a 'flag' being
added that marked some as 'resolutions' vs 'general status' steps.

I'll certainly bear that in mind for the future.

Thanks for the review.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34788] Add the ability to import KBART files to ERM

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788

--- Comment #25 from Mathieu Saby  ---
Thanks you for the explanation.
By "warning" do you mean that only the standard kbart columns are imported (if
there are other columns), or that no columns at all are imported ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34788] Add the ability to import KBART files to ERM

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788

--- Comment #26 from Matt Blenkinsop  ---
It will return the warning before the job is queued so no columns will be
imported at that stage. Once the file is edited to remove the columns it can
then be re-imported and the job will be queued

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36687] itemtypes.notforloan should be tinyint and NOT NULL

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36687

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi  ---
Hi, I think you need to first set any NULL values to 0 before the ALTER TABLE.

I got this error when manually setting some itemtypes.notforloan values to NULL
before running your DBRev.

```
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Data truncated for
column 'notforloan' at row 1 at /kohadevbox/koha/C4/Installer.pm line 741
```

Also, I think the is_boolean flag should be added to the schema file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

--- Comment #20 from Martin Renvoize  ---
I'm on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34788] Add the ability to import KBART files to ERM

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788

--- Comment #27 from Mathieu Saby  ---
Well, I am not your sponsor but as an average librarian I can say that it not
the most effective workflow : when we librarians download valid kbart files
from gokb or other sources, we usually wont want to edit the file to remove
columns that are not defined in kbart specs. If all mandatory fields are in the
file, won't it be possible to import the file with a "simple" warning telling
the user that the other (non mandatory) fields were discarded?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676

--- Comment #5 from Jan Kissig  ---
(In reply to David Nind from comment #2)
> I've tested under 23.11 and the patch works as per the test plan.
> 
> However, on main, I can't seem to run the emulator - not quite sure why as
> it has worked fine in the past when testing other bugs:
> 
> perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1
> -sp term1   -l CPL --patron 2352900100046 -m fee_paid --fee-type FT
> --fee-amount 0.01
> Attempting socket connection to 127.0.0.1:6001...failed! : Connection refused
> 
> The bug title and description need to be changed as per the commit message
> guidelines https://wiki.koha-community.org/wiki/Commit_messages
> 
> - Bug 36676: Short title
> 
>   Short description about what the bug fixes.
> 
>   Test plan:
>   
> 
> In addition, should this change be made to main (previously master) as well?

Hi David,

I was testing in 23.11. but yes, I think it should be made to main as well.

I also changed the patch title. There is still a lack of routine on writing
patches from my side ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #39 from Martin Renvoize  ---
Definitely needs Unit tests.. I clearly forgot to attach those.. I'll go dig
out the branch and get them submitted.

As for your 500 Error.. I think that's a missing DB update..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34007] REST API: Add a list (GET) endpoint for patron categories

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34007

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Tomás Cohen Arazi  ---


*** This bug has been marked as a duplicate of bug 26297 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26297] Add a route to list patron categories

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297

--- Comment #46 from Tomás Cohen Arazi  ---
*** Bug 34007 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36206] Administrative plugins

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36206

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |additional_work_needed

--- Comment #27 from Katrin Fischer  ---
Please fix!

#   Failed test 'Expected permissions generated for superlibrarian'
#   at /kohadevbox/koha/t/Koha/Auth/Permissions.t line 289.
 # Structures begin differing at:
#  $got->{CAN_user_plugins_admin} = '1'
# $expected->{CAN_user_plugins_admin} = Does not exist
 # Looks like you failed 1 test of 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17505] Add routes for messaging preferences

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||26297

--- Comment #26 from Tomás Cohen Arazi  ---
Hi, in my opinion this needs to be redone. Besides naming conventions (e.g.
borrowernumber) we have moved forward in some things a while back.

My thoughts:

We need:

GET /patron_categories/:patron_category_id/messaging_preferences
GET /patrons/:patron_id/messaging_preferences

As for CRUD operations, I don't feel comfortable with just doing

PUT /patron_categories/:patron_category_id/messaging_preferences

with all the message types and transports. We need more fine-grained control.
So probably

PUT /patrons/:patron_id/messaging_preferences/:message_type

And as I said some time ago, I think we also need some endpoint to fetch the
valid message types and also transport types.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297
[Bug 26297] Add a route to list patron categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26297] Add a route to list patron categories

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||17505


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
[Bug 17505] Add routes for messaging preferences
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36707] New: Links on itemnumbers in report should say "item", not "record"

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36707

Bug ID: 36707
   Summary: Links on itemnumbers in report should say "item", not
"record"
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

To reproduce: 

- Add a report like "SELECT itemnumber, biblionumber FROM items LIMIT 10"
- Run the report
- Check the data menu on the biblionumbers, it will say "Edit record" and "View
record"
- Check the data menu on the itemnumbers, it will also say "Edit record" and
"View record"

It would be better if the data menu for itemnumbers said "Edit item" and "View
item".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #105 from Nick Clemens  ---
see comment 20 and comment 25 - I think the problem with multiple item types on
a single bib is still the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35855] Enhance Existing notices and slips list in the manual

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35855

Emmanuel Bétemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #46 from Caroline Cyr La Rose  ---
(In reply to Katrin Fischer from comment #44)
> I am not sure about the proposed patches here as what they actually do and
> what is advertised in the bug title doesn't match up.
> 
> 1) This changes the current behavior beyond not displaying $h: 
> 
> We won't be displaying any "Online resources" info if there isn't a $u. The
> LOC documentation lists a few examüles where we don't have a $u:
> 
> https://www.loc.gov/marc/bibliographic/bd856.html
> 
> 856   1#$amaine.maine.edu$cMust be decompressed with PKUNZIP$fresource.zip
> 856   0#$akentvm.bitnet$facadlist file1$facadlist file2$facadlist file3
> 856   0#$auicvm.bitnet$fAN2
> 856   2#$amadlab.sprl.umich.edu$p3000
> 856   10$zFTP access to PostScript version includes groups of article files
> with .pdf
> extension$aftp.cdc.gov$d/pub/EIS/vol*no*/adobe$f*.pdf$qapplication/pdf 
> 
> So are we sure there are no unintended side effects of this change?
> 

I can't really answer the more technical questions, I will leave this to
Matthias, but I can answer this one. Currently, there is a link "Click here to
access online" whether there is a $u or not and the href is the contents of the
$u. That is definitely not wanted, I don't think. If anyone currently uses the
856 field without $u, they must have display problems. 

I think the 856$u alternative in MARC is to use a combination of $a, $d, and
$f. Those subfields are currently not supported in the XSLT.  

I don't really see how we could introduce a regression if the current behaviour
is broken and the alternative behaviour is not implemented.

You're right that it kind of veered off from the title of the bug. It started
with my issue with 856$h, but as Matthias looked at the code, we noticed that
only $3, $u, $y and $z were implemented in the display, with the $u as the href
and it was displayed if there is any 856 subfield. Since the link depends on
the $u, I instructed him to hide the whole thing if there is no $u. I will
change the bug's title to reflect more the current behaviour.

If we want to implement $a/$d/$f for those who use it, I think it should be
done in the context of another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35855] Enhance Existing notices and slips list in the manual

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35855

--- Comment #2 from Emmanuel Bétemps  ---
(In reply to Aude Charillon from comment #1)
> Example of formatting:
> 
> .. _notice-name-label:
> 
> NOTICE_CODE
> 
> 
> Module: module the notice is under.
> 
> Description:
> 
> -  Notice description goes here, including indication of what it contains
> (no leading spaces before the hyphen(-) -- two(2) spaces between hyphen and
> the description text)
> 
> -  Add any useful information on what needs to be set up for this notice to
> be sent.
> 
> .. Note::
> 
>Notes use the usual format


Did you imagine things like that ?


.. _ACCEPTED-label:

ACCEPTED

Module: Suggestions
Description:
-  This notice is sent to the patron when their purchase suggestion is
accepted.
.. Note::
If you don’t want to send this notice, simply delete its content.




> Is making the notice names headers really a good idea? It's going to make
> for a very long list in the menu... While also making the section easier to
> navigate.


I think making a list in the menu is interesting and if there are too many
notices / names, perhaps could we order by Module and put labels on the 10
modules rather than the 70+ notices / slips

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17505] Add routes for messaging preferences

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

Lari Taskula  changed:

   What|Removed |Added

   Assignee|lari.task...@hypernova.fi   |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Text to go in the|This fixes the display of   |This fixes the display of
  release notes|856$h (used to store|856 in the search results
   |non-functioning URLs) so|and detailed record, in the
   |that URLs in 856$h are not  |staff interface and OPAC.
   |displayed for search|Currently, Koha displays
   |results and detail pages in |"Click here to access
   |the staff interface and |online" if any 856 subfield
   |OPAC. 
 |is present, using the $u
   |
   |subfield as the link
   |Previously, if a|target, even if $u is
   |record had data in 856$h, a |empty. This patch makes the
   |link "Click here to access  |display of the online
   |online" appeared when it|resource link depend on the
   |should not be displayed.
   |presence of 856$u to
   ||prevent empty links.
   |Other URLs should continue  |
   |to be displayed where they  |
   |should, such as 856$u.  |
Summary|856$h should not appear as  |Online resource link should
   |a link in detailed record   |be based on the presence of
   ||856$u (MARC21)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36708] New: Problems editing circ rules when 'Holds allowed (total)' value is greater than or equal to 0

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36708

Bug ID: 36708
   Summary: Problems editing circ rules when 'Holds allowed
(total)' value is greater than or equal to 0
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sbr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If I edit a circulation rule with a value of 0 or higher in the 'Holds allowed
(total)' column, Koha is populating the 'No automatic renewal after (hard
limit)' with a date when it was/should remain blank for editing. Also, the
value in 'Holds allowed (total)' isn't populating in the editing line.

To replicate:
-Find or create a circulation rule with a 'Holds allowed (total)' limit of 3
(or another number) and no value in 'No automatic renewal after (hard limit)'
-Select to edit the rule, and note that 'No automatic renewal after (hard
limit)' box in the editing line is now populated with a date
-Note also that 'Holds allowed (total)' is empty in your editing line
-If you save your edits without clearing the new 'No automatic renewal after
(hard limit)' date, it will save as part of the rule. Also, 'Holds allowed
(total)' will save as Unlimited unless you re-add your numerical value. 

This happened when I tested with multiple numbers including 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #118 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #115)
> Hm, DBIC changes here are mixed in with other changes, so I have kept the
> patch. dbic comes up empty. I have been told it would be better to
> regenerate usually so timestamps etc. match

I just figured out what happens when you don't run dbic again - it causes
issues! - please only strictly separate patches in future! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36709] New: Add --confirm flag to update_localuse_from_statistics.pl script

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709

Bug ID: 36709
   Summary: Add --confirm flag to
update_localuse_from_statistics.pl script
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

From https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122#c116 

The script should have a --confirm flag

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #47 from Matthias Le Gac  ---
I'll take a look at the technical problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709

Lucas Gass  changed:

   What|Removed |Added

 Depends on||16122


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122
[Bug 16122] Item record needs to keep local use count
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Blocks||36709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709
[Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Blocks|36709   |

--- Comment #119 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #116)
> I am a fan of scripts that update data having a --confirm switch, this one
> just has the -h. I know that you should always run the latter first, so
> leaving this more as a note and suggestion.

I will add a confirm flag:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709
[Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709

Lucas Gass  changed:

   What|Removed |Added

 Depends on|16122   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122
[Bug 16122] Item record needs to keep local use count
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #120 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #118)
> (In reply to Katrin Fischer from comment #115)
> > Hm, DBIC changes here are mixed in with other changes, so I have kept the
> > patch. dbic comes up empty. I have been told it would be better to
> > regenerate usually so timestamps etc. match
> 
> I just figured out what happens when you don't run dbic again - it causes
> issues! - please only strictly separate patches in future! :)

Noted. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36161] ILS-DI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||36575

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] Online resource link should be based on the presence of 856$u (MARC21)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #48 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #46)
> (In reply to Katrin Fischer from comment #44)
> > I am not sure about the proposed patches here as what they actually do and
> > what is advertised in the bug title doesn't match up.
> > 
> > 1) This changes the current behavior beyond not displaying $h: 
> > 
> > We won't be displaying any "Online resources" info if there isn't a $u. The
> > LOC documentation lists a few examüles where we don't have a $u:
> > 
> > https://www.loc.gov/marc/bibliographic/bd856.html
> > 
> > 856 1#$amaine.maine.edu$cMust be decompressed with 
> > PKUNZIP$fresource.zip
> > 856 0#$akentvm.bitnet$facadlist file1$facadlist file2$facadlist 
> > file3
> > 856 0#$auicvm.bitnet$fAN2
> > 856 2#$amadlab.sprl.umich.edu$p3000
> > 856 10$zFTP access to PostScript version includes groups of article 
> > files
> > with .pdf
> > extension$aftp.cdc.gov$d/pub/EIS/vol*no*/adobe$f*.pdf$qapplication/pdf 
> > 
> > So are we sure there are no unintended side effects of this change?
> > 
> 
> I can't really answer the more technical questions, I will leave this to
> Matthias, but I can answer this one. Currently, there is a link "Click here
> to access online" whether there is a $u or not and the href is the contents
> of the $u. That is definitely not wanted, I don't think. If anyone currently
> uses the 856 field without $u, they must have display problems. 
> I think the 856$u alternative in MARC is to use a combination of $a, $d, and
> $f. Those subfields are currently not supported in the XSLT.  
> I don't really see how we could introduce a regression if the current
> behaviour is broken and the alternative behaviour is not implemented.
> 
> You're right that it kind of veered off from the title of the bug. It
> started with my issue with 856$h, but as Matthias looked at the code, we
> noticed that only $3, $u, $y and $z were implemented in the display, with
> the $u as the href and it was displayed if there is any 856 subfield. Since
> the link depends on the $u, I instructed him to hide the whole thing if
> there is no $u. I will change the bug's title to reflect more the current
> behaviour.
> 
> If we want to implement $a/$d/$f for those who use it, I think it should be
> done in the context of another bug.

All good points :)

I didn't have the time to dig deeper than checking if it could be a valid use
case to have an 856 without $u. So I put the question out there. 

I am ok with relying on $u for now, but:

* Could we maybe adjust bug description and release notes to reflect the
slightly different route we've taken?
* When making the comments 2)-5) I assumed we would take this route, so they
should still be valid. Would be great to get some feedback/follow-ups on those.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36369] Make APIClient be more useful

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369

--- Comment #15 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Tomás Cohen Arazi from comment #13)
> > (In reply to Jonathan Druart from comment #11)
> > > 2. So far we have decided to provide what is implemented/used. With this 
> > > we
> > > will offer in the view usage of routes that may not be implemented yet.
> > 
> > Am I right to interpret what you say like: 'if the Vue page doesn't allow
> > deleting the resource, we shouldn't implement a delete() method'?
> > 
> > It feels to me that this shouldn't be an issue... and would allow people to
> > reuse this more?
> 
> Yes it is what I meant for "used". And I agree it is not really a problem.
> However it can be a problem for "implemented": If the endpoint does not
> exist in the controller should we provide it in the api-client? It does not
> make sense to me.

I think it is fair that a dev can try, but then get a 404. I would like to hear
from others.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #34 from Katrin Fischer  ---
I am sorry, I have trouble with the second patch:

git bz apply 35746

Bug 35746 - Multiple selections for parameters used in the IN function

165333 - Bug 35746: add multiselect to report dropdowns
165345 - Bug 35746: (follow-up) Fix invalid tt in html tag

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35746: add multiselect to report dropdowns
Applying: Bug 35746: (follow-up) Fix invalid tt in html tag
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 35746: (follow-up) Fix invalid tt in html tag


Can you please rebase and re-attach both of those patches? If you need help
please let us know!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36161] ILS-DI AuthenticatePatron broken when LDAP enabled and auth falls back to internal connection

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36161

--- Comment #6 from Kyle M Hall  ---
We believe bug 36575 may take care of this. Let's revisit it after that's been
pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36579] Top search bar tabs reset after search

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36579

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36659

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36579

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36579] Top search bar tabs reset after search

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36579

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35430] Add endpoints for managing stock rotation rota's

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #22 from Katrin Fischer  ---
I have a failing test with this patch set applied, please check!

Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t
KO!

#   Failed test 'exact match for JSON Pointer ""'
#   at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line
88.
# Structures begin differing at:
#  $got->[2] = HASH(0x55687bdd94d8)
# $expected->[2] = Does not exist
 # Looks like you failed 1 test of 20.

#   Failed test 'list() tests'
#   at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 102.
 # Looks like you failed 1 test of 5.
 /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


<    1   2   3   4   5   >