[Bug 1242678]
As far as I remember the fix only worked for some versions of GS. Anyway, I'll try to find some time too look at this in detail again. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to Pacho Ramos from comment #36) > (In reply to Carlos Garcia Campos from comment #35) > > I've reverted the patch in master for now, until we find a proper solution. > > Do you know when a new tarball is planned including this and other fixes? > Thanks No plans, but I can make a new release once this problem is fixed, for example. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Still doesn't work here, it seems to rotate the first page only of a multipage document. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
(In reply to comment #22) > (In reply to comment #20) > > (In reply to comment #19) > > > Thanks Marek! Do you still plan to look at the evince side as well (since > > > the rotation seems to still be wrong when using it, as mentioned in > > > previous > > > comments) > > > > Hi Sebastien, > > > > thank you for reminding me this. I'll look at that but not now since I have > > several tasks I have to finish before I can jump on this. > > Maybe at the end of the next week. > > I've filled a bug for this here: > https://bugzilla.gnome.org/show_bug.cgi?id=731786. A patch is attached there > which solves it for me. > > > (In reply to comment #21) > > I've been trying this and I'm getting the opposite results, the attached ps > > file is rotated without the patch but nothing is rendered when rotated with > > the patch. > > I've just tried it with evince from master with patched libspectre and it > works for me as expected :(. Maybe it has to do with the gs version? $ gs --version 9.05 >From Debian testing. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
I've been trying this and I'm getting the opposite results, the attached ps file is rotated without the patch but nothing is rendered when rotated with the patch. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to libspectre in Ubuntu. https://bugs.launchpad.net/bugs/1242678 Title: evince cannot render some EPS files To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Comment on attachment 99331
Rotate documents correctly
Review of attachment 99331:
-
This looks good to me, except the confusing NONE/LANDSCAPE thing.
Adrian, does the PostScript part looks good to you?
::: libspectre/spectre-device.c
@@ +206,4 @@
> return SPECTRE_STATUS_RENDER_ERROR;
> }
>
> + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
Why NONE and LANDSCAPE? shouldn't we invert width/height when
orientation is LANDSCAPE and SEASCAPE? Ah, I know what's going on, you
are using the internal values of the parser (my fault, I think I
suggested it) but rc->orientation is actually a SpectreOrientation enum
value, so you should use SPECTRE_ORIENTATION_PORTRAIT ||
SPECTRE_ORIENTATION_REVERSE_PORTRAIT that are 0 and 2 like NONE and
LANDSCAPE in the internal parser.
@@ +269,4 @@
> args[arg++] = "-dNOPLATFONTS";
>
> if (rc->width != -1 && rc->height != -1) {
> + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
Same here.
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 1242678]
Comment on attachment 96165
Rotate documents correctly
Review of attachment 96165:
-
Thanks for the patch!
::: libspectre/spectre-device.c
@@ +206,5 @@
> return SPECTRE_STATUS_RENDER_ERROR;
> }
>
> + scaled_width = (int) ((width * rc->x_scale) + 0.5);
> + scaled_height = (int) ((height * rc->y_scale) + 0.5);
I think it would be clearer if we set these values depending on the
orientation, and then we just use scale_width, scaled_height below.
@@ +226,5 @@
> rc->text_alpha_bits);
> args[arg++] = graph_alpha = _spectre_strdup_printf
> ("-dGraphicsAlphaBits=%d",
>
> rc->graphic_alpha_bits);
> +
> + if (rc->orientation == 0 || rc->orientation == 2) {
Don't use magic numbers here, use NONE and LANDSCAPE instead.
@@ +232,5 @@
> + args[arg++] = resolution = _spectre_strdup_printf ("-r%fx%f",
> +rc->x_scale
> * rc->x_dpi,
> +rc->y_scale
> * rc->y_dpi);
> + }
> + else {
} else {
::: libspectre/spectre-gs.c
@@ +237,5 @@
>
> + switch (rotation) {
> + default:
> + tmp_xoffset = xoffset + x;
> + tmp_yoffset = yoffset + y;
I don't think we need the tmp_ variables, we can just modify the
existing xoffset/yoffset.
@@ +277,5 @@
>doc->endsetup))
> return FALSE;
>
> + if (rotation != 0) {
> + set = _spectre_strdup_printf ("%d rotate", rotation);
Where does this end up? After the setup and before the pages? Isn't it
recommended to apply the rotation after the translation? I think we
could move this to spectre_gs_process, after the translate. We pass the
rotation to spectre_gs_process and when it's != NONE we inject the
rotate command there. What do you think?
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
