Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-26 Thread Alexey Eremenko
 Generally I see no problem with it. But at least for NPT I don't see a
 reason why someone should want to disable it on a VM basis (as far as it
 works stable). Avi, what do you think?


1. This is more user-friendly and easier-to-find

2. A lot of people would like to view (and Demo) it side-by-side.

3. Useful for BETA-testing of KVM.

-- 
-Alexey Eremenko Technologov

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-26 Thread Joerg Roedel
On Sat, Jan 26, 2008 at 11:49:17AM +0200, Alexey Eremenko wrote:
  Generally I see no problem with it. But at least for NPT I don't see a
  reason why someone should want to disable it on a VM basis (as far as it
  works stable). Avi, what do you think?
 
 
 1. This is more user-friendly and easier-to-find
 
 2. A lot of people would like to view (and Demo) it side-by-side.
 
 3. Useful for BETA-testing of KVM.

Ok, agreed. I will add this feature.

Joerg

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-26 Thread Anthony Liguori
Alexey Eremenko wrote:
 Generally I see no problem with it. But at least for NPT I don't see a
 reason why someone should want to disable it on a VM basis (as far as it
 works stable). Avi, what do you think?

 

 1. This is more user-friendly and easier-to-find
   

I'm inclined to disagree.  Why add an additional thing for people to 
tune if they really shouldn't need to.  Once NPT/EPT support are stable, 
is there any reason to want to disable it?

Regards,

Anthony Liguori

 2. A lot of people would like to view (and Demo) it side-by-side.

 3. Useful for BETA-testing of KVM.

   


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-26 Thread Avi Kivity
Joerg Roedel wrote:
 Generally I see no problem with it. But at least for NPT I don't see a
 reason why someone should want to disable it on a VM basis (as far as it
 works stable). Avi, what do you think?
   

Unless there is a real-life workload that benefits from npt=0, I see no 
reason to have per-vm npt control.  The module parameter is helpful, for 
to isolate npt problems and for development, but I don't see a need for 
users to fiddle with it.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-25 Thread Joerg Roedel
On Fri, Jan 25, 2008 at 05:47:11PM -0800, Nakajima, Jun wrote:
 Joerg Roedel wrote:
  To disable the use of the Nested Paging feature even if it is
 available in
  hardware this patch adds a module parameter. Nested Paging can be
 disabled by
  passing npt=off to the kvm_amd module.
 
 I think it's better to use a (common) parameter to qemu. That way you
 can control on/off for each VM.

Generally I see no problem with it. But at least for NPT I don't see a
reason why someone should want to disable it on a VM basis (as far as it
works stable). Avi, what do you think?

Joerg

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging

2008-01-25 Thread Nakajima, Jun
Joerg Roedel wrote:
 To disable the use of the Nested Paging feature even if it is
available in
 hardware this patch adds a module parameter. Nested Paging can be
disabled by
 passing npt=off to the kvm_amd module.

I think it's better to use a (common) parameter to qemu. That way you
can control on/off for each VM.

Jun
---
Intel Open Source Technology Center

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel