Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile
> This patch adds -Werror to CFLAGS for compilation of libkvm. This > should stop complaints about Warnings. Does libkvm build without warnings using GCC-4.3 (or even GCC-4.4) on all supported platforms? If not, please fix that first :-) Segher - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile
It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would workout. Though they should. I'll need to to compile them and give them a try. On Mon, 2008-03-24 at 20:42 +0100, Segher Boessenkool wrote: > > This patch adds -Werror to CFLAGS for compilation of libkvm. This > > should stop complaints about Warnings. > > Does libkvm build without warnings using GCC-4.3 (or even GCC-4.4) > on all supported platforms? If not, please fix that first :-) > > > Segher > > > - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ > ___ > kvm-devel mailing list > kvm-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/kvm-devel - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile
Jerone Young wrote: > It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would > workout. Though they should. I'll need to to compile them and give them > a try. > While I'm a fan of -Werror, I have to agree with Anthony it can cause no end of pain to users if they have a slightly different configuration. Maybe enable it conditionally based on ./configure --developer as Anthony suggests (but I'll forget to use it myself, I'm sure). -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile
Yeah. This could "potentially" cause hell for users (non developers) down the road. I'm just going to keep this patch in my queue for myself, so no one will complain about warnings from my patches anymore. I think having a --developer flag to configure could work, but we would then need separate file for including the CFLAG, this would just clutter things more. On Tue, 2008-03-25 at 19:08 +0200, Avi Kivity wrote: > Jerone Young wrote: > > It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would > > workout. Though they should. I'll need to to compile them and give them > > a try. > > > > While I'm a fan of -Werror, I have to agree with Anthony it can cause no > end of pain to users if they have a slightly different configuration. > > Maybe enable it conditionally based on ./configure --developer as > Anthony suggests (but I'll forget to use it myself, I'm sure). > - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile
Jerone Young wrote: > Yeah. This could "potentially" cause hell for users (non developers) > down the road. I'm just going to keep this patch in my queue for myself, > so no one will complain about warnings from my patches anymore. > > I think having a --developer flag to configure could work, but we would > then need separate file for including the CFLAG, this would just clutter > things more. > One other option is to enable -Werror by default, and have a --disable-werror configure flag. It means we'll get better coverage, but the user experience when it breaks will be worse. -- error compiling committee.c: too many arguments to function - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
