Re: [kvm-devel] [patch] Make sure that we compile before installing

2007-07-23 Thread Avi Kivity
Nguyen Anh Quynh wrote:
 This patch makes install compile code, and install-rpm package rpms.

'install' and 'install-rpm' are typically run as root, and we don't want 
to compile as root.


-- 
error compiling committee.c: too many arguments to function


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [patch] Make sure that we compile before installing

2007-07-23 Thread Nguyen Anh Quynh
On 7/23/07, Avi Kivity [EMAIL PROTECTED] wrote:
 Nguyen Anh Quynh wrote:
  This patch makes install compile code, and install-rpm package rpms.

 'install' and 'install-rpm' are typically run as root, and we don't want
 to compile as root.

Is it because of security reason, or something else?

I want this patch because without it, sometimes I install without
recompiling. As a result, the old binary is installed, and I dont
notice that I dont run the code with new change. That really confuses,
and even took me a while to figure out what actually happend.

-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [patch] Make sure that we compile before installing

2007-07-23 Thread Avi Kivity
Nguyen Anh Quynh wrote:
 On 7/23/07, Avi Kivity [EMAIL PROTECTED] wrote:
 Nguyen Anh Quynh wrote:
  This patch makes install compile code, and install-rpm package 
 rpms.

 'install' and 'install-rpm' are typically run as root, and we don't want
 to compile as root.

 Is it because of security reason, or something else?


Just standard practice.  For example, my home directory is nfs mounted, 
so I can't compile as root.  Since I sometimes test before committing, 
I'd like to keep the ability to compile.

 I want this patch because without it, sometimes I install without
 recompiling. As a result, the old binary is installed, and I dont
 notice that I dont run the code with new change. That really confuses,
 and even took me a while to figure out what actually happend.

Run 'make  make install' (or a script that does that) instead.

-- 
error compiling committee.c: too many arguments to function


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now   http://get.splunk.com/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel