Re: [Lazarus] [Lazarusdev] RFC --- We are planning the next release: Lazarus 2.0.6
On Wed, Oct 16, 2019 at 7:18 PM Werner Pamler via lazarus wrote: > Hmmh - I never thought about this, I always thought this is a "new > feature" and should stay in trunk. ATM, I cannot focus on merging VTV to > fixes. It isn't a show-stopper, isn't it? Not a show-stopper. If I remember right, it may prevent installing many versions of VTV simultaneously but there are ways around it. The System.Move change was not a show-stopper either because Lazarus 2.0.6 will be released with FPC 3.0.4, but it is convenient anyway for people who want to use a different compiler. Juha -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus
Re: [Lazarus] [Lazarusdev] RFC --- We are planning the next release: Lazarus 2.0.6
16.10.2019 19:15, Werner Pamler via lazarus пишет: > Am 16.10.2019 um 16:52 schrieb Juha Manninen via lazarus: >> On Wed, Oct 16, 2019 at 4:41 PM Werner Pamler via lazarus >> wrote: >>> I don't know what you are referring to, here. In r61814 I had added the >>> "System" namespace here in VTV because fpc 3.2+ has a Move method in >>> TCollection which conflicts with the old code. >> r61814 in fixes branch seems to a merge from Michael's r60784 in trunk. >> Your big rename commit r60132 in trunk would be useful, too, but I >> guess difficult to merge. > > > Hmmh - I never thought about this, I always thought this is a "new > feature" and should stay in trunk. ATM, I cannot focus on merging VTV to > fixes. It isn't a show-stopper, isn't it? This should NOT be merged, because it introduced dotted unit names into the wild and required major changes to translation system. -- Best regards, Maxim Ganetsky mailto:gan...@narod.ru -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus
Re: [Lazarus] [Lazarusdev] RFC --- We are planning the next release: Lazarus 2.0.6
El 16/10/19 a les 12:31, Juha Manninen via lazarus ha escrit: On Sun, Oct 13, 2019 at 4:10 PM Luca Olivetti via lazarus wrote: In my copy of lazarus 2.0.4 I have the fix for bug https://bugs.freepascal.org/view.php?id=35716 I added it to the list to be merged for 2.0.6. and the patch for the still opened https://bugs.freepascal.org/view.php?id=35715 Unfortunately Jesus has not applied the patch or otherwise solved the issue. You write "I'm not sure it's the best solution", I guess it is a difficult case. "I'm not sure it's the best solution" because the grid is a complex beast and maybe Jesus has a better one. Also, I don't know if this will be in 2.0.6 (I need it since the bugs in fpc 3.0.4 affect my projects, so I have to use fixes_3_2): Your diff for VirtualTreeView replaces Move with System.Move. Why? Is there another Move in FPC 3.2 sources that would be called otherwise? 3.2 added a new method Move to TCollection, hence the need to qualify the call Is your diff already applied somewhere or is it a patch uploaded into some bug report? In lazarus trunk it's already changed https://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/components/virtualtreeview/laz.virtualtrees.pas?root=lazarus=60642=60784 however lazarus trunk also changed the name of the component and the corresponding units https://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/components/virtualtreeview/laz.virtualtrees.pas?root=lazarus=60024=60132 Bye -- Luca Olivetti Wetron Automation Technology http://www.wetron.es/ Tel. +34 93 5883004 (Ext.3010) Fax +34 93 5883007 -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus
Re: [Lazarus] [Lazarusdev] RFC --- We are planning the next release: Lazarus 2.0.6
El 13/10/19 a les 14:46, Martin Frb via lazarus ha escrit: This release will be built with FPC 3.0.4. The previous release Lazarus 2.0.4 was built with FPC 3.0.4 as well. Here is the list of fixes for Lazarus 2.0.4 (since 2.0.0): http://wiki.freepascal.org/Lazarus_2.0_fixes_branch We would invite everyone to provide their feedback to help us improve this upcoming release. Please let as know in particular: - Any bug-fixes already made to trunk, that you believe should still be merged to the fixes branch (fixes that are not listed on the above wiki page) In my copy of lazarus 2.0.4 I have the fix for bug https://bugs.freepascal.org/view.php?id=35716 and the patch for the still opened https://bugs.freepascal.org/view.php?id=35715 Also, I don't know if this will be in 2.0.6 (I need it since the bugs in fpc 3.0.4 affect my projects, so I have to use fixes_3_2): --- components/virtualtreeview/VirtualTrees.pas (revision 62005) +++ components/virtualtreeview/VirtualTrees.pas (working copy) @@ -8014,12 +8014,12 @@ if OldPosition < Position then begin // column will be moved up so move down other entries - Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal)); + System.Move(FPositionToIndex[OldPosition + 1], FPositionToIndex[OldPosition], (Position - OldPosition) * SizeOf(Cardinal)); end else begin // column will be moved down so move up other entries - Move(FPositionToIndex[Position], FPositionToIndex[Position + 1], (OldPosition - Position) * SizeOf(Cardinal)); + System.Move(FPositionToIndex[Position], FPositionToIndex[Position + 1] , (OldPosition - Position) * SizeOf(Cardinal)); end; FPositionToIndex[Position] := Column.Index; end; @@ -8264,7 +8264,7 @@ begin // Index found. Move all higher entries one step down and remove the last entry. if I < Upper then - Move(FPositionToIndex[I + 1], FPositionToIndex[I], (Upper - I) * SizeOf(TColumnIndex)); + System.Move(FPositionToIndex[I + 1], FPositionToIndex[I] , (Upper - I) * SizeOf(TColumnIndex)); end; // Decrease all indices, which are greater than the index to be deleted. if FPositionToIndex[I] > OldIndex then Bye -- Luca Olivetti Wetron Automation Technology http://www.wetron.es/ Tel. +34 93 5883004 (Ext.3010) Fax +34 93 5883007 -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus
[Lazarus] [Lazarusdev] RFC --- We are planning the next release: Lazarus 2.0.6
The Lazarus team is glad to announce: The upcoming release of Lazarus 2.0.6 which has been scheduled for the last week of October 2019 This release will be built with FPC 3.0.4. The previous release Lazarus 2.0.4 was built with FPC 3.0.4 as well. Here is the list of fixes for Lazarus 2.0.4 (since 2.0.0): http://wiki.freepascal.org/Lazarus_2.0_fixes_branch We would invite everyone to provide their feedback to help us improve this upcoming release. Please let as know in particular: - Any bug-fixes already made to trunk, that you believe should still be merged to the fixes branch (fixes that are not listed on the above wiki page) - Any regressions that happened in fixes branch since the release of 2.0 - Other urgent matters, you believe we should know before the release. Please attempt to provide your feedback by: 23rd October 2019 More info on our release process can be found at (work in progress): http://wiki.lazarus.freepascal.org/Lazarus_release_engineering Information about the previous release: http://wiki.lazarus.freepascal.org/Lazarus_2.0.0_release_notes http://wiki.lazarus.freepascal.org/User_Changes_3.0.4 The intended minimum requirements for the release will be: Windows: 2k, XP, Vista, 7, 8, 8.1 and 10, 32 or 64bit. FreeBSD/Linux: gtk 2.8 for gtk2, qt4.5 for qt, qt5.6 for qt5, 32 or 64bit. macOS: 10.5 to 10.12; Carbon (32bit), Cocoa (64bit, beta), qt and qt5 (32 or 64bit). -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus
