Re: [lazarus] Maskedit and copyrighted material
The first patch about this is marked as: Revision 3216 - (view) (download) - [select for diffs] Added Mon Aug 19 15:15:20 2002 UTC (4 years, 7 months ago) by mattias File length: 39065 byte(s) added TMaskEdit from Tony And the later modifications look very small, just small adjustments, so we can consider that in this particular file he is the only one that copyed code. I would sugest investigating all patches by Tony. Does anyone know how to get all revisions with a svn log with the string "Tony" ? I couldn´t find such option on viewcvs For future implementations, I think it´s ok to copy the class declaration on the interface section (or am I wrong?), because you are using it to provide a compatible interface, and then one should not look at Delphi´s implementation and implement it´s own version as he imagines things should work. -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] Maskedit and copyrighted material
On 4/17/07, Felipe Monteiro de Carvalho <[EMAIL PROTECTED]> wrote: For future implementations, I think it´s ok to copy the class declaration on the interface section (or am I wrong?), Of course I meant only the public parts, and not the private section. I just did a diff between menus.pp from lazarus and menus.pas from delphi, and it looks a good example of how to create a compatible interface (public parts of the classes look very similar on the interface, but private sections and all implementation code is completely different. The only part a little scary is the declaration of TMenuActionLink. There are no differences, but this class has only protected section. Also on menuactionlink.inc the code is a little bit too similar. But then it has only trivial procedures like getters. -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] Maskedit and copyrighted material
I did some random checks, and the rest of the lcl code looks ok. I checked clipbrd, stdactns, forms, etc, and looks clean from vcl code, with original implementations and white places on things not implemented yet. But there could be more copyrighted spots, so a good check would be nice. -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] Maskedit and copyrighted material
Felipe Monteiro de Carvalho schreef: I would sugest investigating all patches by Tony. Does anyone know how to get all revisions with a svn log with the string "Tony" ? I couldn´t find such option on viewcvs Get the complete log at http://svn.freepascal.org/svn/logs/lazarus-all.log and search for Tony. Vincent _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] Maskedit and copyrighted material
On 4/17/07, Vincent Snijders <[EMAIL PROTECTED]> wrote: Get the complete log at http://svn.freepascal.org/svn/logs/lazarus-all.log and search for Tony. Just did. Hi did some small patches about things that don´t exist on delphi. He also created the first implementation for printers.pas. His implementation was in fact a copy from Delphi with some things comented out. But subsequently the unit was completely rewriten, and isn´t a delphi copy since 2004. Details here: http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/lcl/printers.pas?root=lazarus&rev=9948&view=log -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] Maskedit and copyrighted material
Felipe Monteiro de Carvalho wrote: The first patch about this is marked as: [snip] For future implementations, I think it´s ok to copy the class declaration on the interface section (or am I wrong?), because you are using it to provide a compatible interface, and then one should not look at Delphi´s implementation and implement it´s own version as he imagines things should work. Copying public and protected as in writing them over is ok, copying as in copy&paste not imo. Marc _ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
