Re: [Leaf-devel] Perl help
Hi Mike in case noone noticed until now.. there was a glitch in the perl script anyway, see the following test luna > perl casetest.pl MakefilefoobarDDD All filenames must be completely lowercase except Makefiles. (/) All filenames must be completely lowercase except Makefiles. (/) but of course taking it out removed it. cheers Erich THINK Püntenstrasse 39 8143 Stallikon mailto:[EMAIL PROTECTED] PGP Fingerprint: BC9A 25BC 3954 3BC8 C024 8D8A B7D4 FF9D 05B8 0A16 --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Leaf-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On Wed, 2002-07-17 at 10:57, Brad Fritz wrote: > I also double-checked the r1.1 to r1.2 diff[1] from last night, > and I don't see anything wrong or any changes that should have > resulted in the broken pipe error. Brad, Thanks for taking another look at the file. I committed the changes again. > What was the context of the broken pipe message? It was a errant import to the top level in our repository, by a member without write privileges there. -- Mike Noyes <[EMAIL PROTECTED]> http://sourceforge.net/users/mhnoyes/ http://leaf-project.org/ --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Leaf-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On 17 Jul 2002 10:24:21 PDT Mike Noyes wrote:
> Brad,
> Thanks for the proof. The broken pipe may have been a coincidence, but I
> thought I should check before trying this again.
Almost always better to be safe than sorry, I suppose. :)
> My diff doesn't look right (diff output below). The same thing happened
> last night when going from rev 1.1 to 1.2. Strange, the diff seems to be
> offset. Am I doing something wrong? I'll try the change in Emacs and see
> if the diff changes.
>
> [Leaf-cvs-commits] CVSROOT enforce_naming,1.1,1.2
> http://www.mail-archive.com/leaf-cvs-commits%40lists.sourceforge.net/msg00039
>.html
>
>
> CVSROOT]$ diff enforce_naming ~/CVSROOT/enforce_naming
> 26c26
> < # $Id: enforce_naming,v 1.3 2002/07/17 02:44:55 mhnoyes Exp $
> ---
> > # $Id: enforce_naming,v 1.4 2002/05/04 16:12:18 moorman Exp $
> 32a33
> > # 3. Verify that all filenames, except Makefile, are lowercase
> 46a48,54
> > $exit_val = 1;
> > }
> >
> > # Verify that all files are lowercase, except Makefiles
> > if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> > print "All filenames must be completely lowercase except";
> > print "Makefiles. ($directory/$_)\n";
>
Looks okay to me. The next line after the last "print" line
inserted is another "$exit_val = 1" line. Even though your
diff looks different than mine, the resulting code is the same.
I also double-checked the r1.1 to r1.2 diff[1] from last night,
and I don't see anything wrong or any changes that should have
resulted in the broken pipe error.
What was the context of the broken pipe message?
--Brad
[1]
http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/enforce_naming.diff?r1=1.1&r2=1.2
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On Wed, 2002-07-17 at 08:34, Mike Noyes wrote: > leaf/CVSROOT/enforce_naming rev 1.3 > http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/ Everyone, Our enforce_naming is now at rev 1.4, and lowercase name enforcement should be disabled. Please let me know if you experience any problems. I thank Michael and Brad for their help. -- Mike Noyes <[EMAIL PROTECTED]> http://sourceforge.net/users/mhnoyes/ http://leaf-project.org/ --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Leaf-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On Wed, 2002-07-17 at 09:58, Michael D. Schleif wrote: > > Mike Noyes wrote: > > > > On Wed, 2002-07-17 at 08:58, Michael D. Schleif wrote: > > > Mike Noyes wrote: > > > > > > > > Anyone, > > > > Will removing the following lines from enforce_naming leave the perl > > > > script functional? > > > > > > Yes, absolutely yes; provided that either all of the lines are > > > completely _removed_ or completely commented out. > > > > Hmm, then what did I do wrong in rev 1.2? I used vi to dd out the lines > > below, and you ended up with a broken pipe from the server last night. > > > > Any enlightenment is appreciated. > > Previously, you said that _cvs import_ somehow bypasses case checking, > or this script. Since all I did last night was _cvs import_, and > because there is nothing in enforce_naming (no version in cvs) that > would result in "broken pipe" errors, I believe the culprit is > elsewhere. Michael, It seems to, but I don't think it should. Our commitinfo seems to process our cvs_acls script but not enforce_naming on imports. I need to find a reference to what commands activate commitinfo in which circumstances. > > > Also, remove the lone `next;' at end of for loop, since the for loop > > > does that automatically, by design ;> > > > > Is this true for older versions of perl too? The SF cvs server may not > > have the newest perl release on it. > > I've been Perl'ing since v4.0x days. That is the design of a for loop. > That `next;' does not do anything bad except waste a couple cpu cycles . Thanks for the info. I'll remove it also. -- Mike Noyes <[EMAIL PROTECTED]> http://sourceforge.net/users/mhnoyes/ http://leaf-project.org/ --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ Leaf-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On Wed, 2002-07-17 at 09:54, Brad Fritz wrote:
>
> On 17 Jul 2002 09:11:44 PDT Mike Noyes wrote:
>
> > Hmm, then what did I do wrong in rev 1.2? I used vi to dd out the lines
> > below, and you ended up with a broken pipe from the server last night.
>
> I am not sure about the broken pipe, but if you need more
> evidence it *should* work, see below. My apologies for the
> long lines. Any chance the broken pipe was a coincidence
> or an artifact of the check-in of enforce_naming.pl rather
> than the code changes?
Brad,
Thanks for the proof. The broken pipe may have been a coincidence, but I
thought I should check before trying this again.
My diff doesn't look right (diff output below). The same thing happened
last night when going from rev 1.1 to 1.2. Strange, the diff seems to be
offset. Am I doing something wrong? I'll try the change in Emacs and see
if the diff changes.
[Leaf-cvs-commits] CVSROOT enforce_naming,1.1,1.2
http://www.mail-archive.com/leaf-cvs-commits%40lists.sourceforge.net/msg00039.html
CVSROOT]$ diff enforce_naming ~/CVSROOT/enforce_naming
26c26
< # $Id: enforce_naming,v 1.3 2002/07/17 02:44:55 mhnoyes Exp $
---
> # $Id: enforce_naming,v 1.4 2002/05/04 16:12:18 moorman Exp $
32a33
> # 3. Verify that all filenames, except Makefile, are lowercase
46a48,54
> $exit_val = 1;
> }
>
> # Verify that all files are lowercase, except Makefiles
> if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> print "All filenames must be completely lowercase except
";
> print "Makefiles. ($directory/$_)\n";
--
Mike Noyes <[EMAIL PROTECTED]>
http://sourceforge.net/users/mhnoyes/
http://leaf-project.org/
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
Mike Noyes wrote:
>
> On Wed, 2002-07-17 at 08:58, Michael D. Schleif wrote:
> > Mike Noyes wrote:
> > >
> > > Anyone,
> > > Will removing the following lines from enforce_naming leave the perl
> > > script functional?
> >
> > Yes, absolutely yes; provided that either all of the lines are
> > completely _removed_ or completely commented out.
>
> Hmm, then what did I do wrong in rev 1.2? I used vi to dd out the lines
> below, and you ended up with a broken pipe from the server last night.
>
> Any enlightenment is appreciated.
Previously, you said that _cvs import_ somehow bypasses case checking,
or this script. Since all I did last night was _cvs import_, and
because there is nothing in enforce_naming (no version in cvs) that
would result in "broken pipe" errors, I believe the culprit is
elsewhere.
> > > # Verify that all files are lowercase, except Makefiles
> > > if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> > > print "All filenames must be completely lowercase except ";
> > > print "Makefiles. ($directory/$_)\n";
> > > $exit_val = 1;
> > > }
> > >
> > > leaf/CVSROOT/enforce_naming rev 1.3
> > > http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/
> >
> > Also, remove the lone `next;' at end of for loop, since the for loop
> > does that automatically, by design ;>
>
> Is this true for older versions of perl too? The SF cvs server may not
> have the newest perl release on it.
I've been Perl'ing since v4.0x days. That is the design of a for loop.
That `next;' does not do anything bad except waste a couple cpu cycles .
. .
--
Best Regards,
mds
mds resource
888.250.3987
Dare to fix things before they break . . .
Our capacity for understanding is inversely proportional to how much we
think we know. The more I know, the more I know I don't know . . .
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On 17 Jul 2002 09:11:44 PDT Mike Noyes wrote:
> Hmm, then what did I do wrong in rev 1.2? I used vi to dd out the lines
> below, and you ended up with a broken pipe from the server last night.
I am not sure about the broken pipe, but if you need more
evidence it *should* work, see below. My apologies for the
long lines. Any chance the broken pipe was a coincidence
or an artifact of the check-in of enforce_naming.pl rather
than the code changes?
$ ./enforce_naming.pl dummy FOO BAR makefile cvs
All Makefiles must have proper case (M should be upper-case). (dummy/makefile)
Creation of files named CVS or cvs is prohibited. (dummy/cvs)
$ ./enforce_naming.pl.orig dummy FOO BAR makefile cvs
All filenames must be completely lowercase except Makefiles. (dummy/FOO)
All filenames must be completely lowercase except Makefiles. (dummy/BAR)
All Makefiles must have proper case (M should be upper-case). (dummy/makefile)
Creation of files named CVS or cvs is prohibited. (dummy/cvs)
$ diff ./enforce_naming.pl.orig ./enforce_naming.pl
51,56d50
< # Verify that all files are lowercase, except Makefiles
< if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
< print "All filenames must be completely lowercase except ";
< print "Makefiles. ($directory/$_)\n";
< $exit_val = 1;
< }
--Brad
> Any enlightenment is appreciated.
>
> > > # Verify that all files are lowercase, except Makefiles
> > > if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> > > print "All filenames must be completely lowercase except
>";
> > > print "Makefiles. ($directory/$_)\n";
> > > $exit_val = 1;
> > > }
> > >
> > > leaf/CVSROOT/enforce_naming rev 1.3
> > > http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
On Wed, 2002-07-17 at 08:58, Michael D. Schleif wrote:
> Mike Noyes wrote:
> >
> > Anyone,
> > Will removing the following lines from enforce_naming leave the perl
> > script functional?
>
> Yes, absolutely yes; provided that either all of the lines are
> completely _removed_ or completely commented out.
Hmm, then what did I do wrong in rev 1.2? I used vi to dd out the lines
below, and you ended up with a broken pipe from the server last night.
Any enlightenment is appreciated.
> > # Verify that all files are lowercase, except Makefiles
> > if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> > print "All filenames must be completely lowercase except ";
> > print "Makefiles. ($directory/$_)\n";
> > $exit_val = 1;
> > }
> >
> > leaf/CVSROOT/enforce_naming rev 1.3
> > http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/
>
> Also, remove the lone `next;' at end of for loop, since the for loop
> does that automatically, by design ;>
Is this true for older versions of perl too? The SF cvs server may not
have the newest perl release on it.
--
Mike Noyes <[EMAIL PROTECTED]>
http://sourceforge.net/users/mhnoyes/
http://leaf-project.org/
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
Re: [Leaf-devel] Perl help
Mike Noyes wrote:
>
> Anyone,
> Will removing the following lines from enforce_naming leave the perl
> script functional?
Yes, absolutely yes; provided that either all of the lines are
completely _removed_ or completely commented out.
> # Verify that all files are lowercase, except Makefiles
> if ((substr($_, 0, 8) ne "Makefile") and (lc($_) ne $_)) {
> print "All filenames must be completely lowercase except ";
> print "Makefiles. ($directory/$_)\n";
> $exit_val = 1;
> }
>
> leaf/CVSROOT/enforce_naming rev 1.3
> http://cvs.leaf-project.org/cgi-bin/viewcvs.cgi/leaf/CVSROOT/
Also, remove the lone `next;' at end of for loop, since the for loop
does that automatically, by design ;>
--
Best Regards,
mds
mds resource
888.250.3987
Dare to fix things before they break . . .
Our capacity for understanding is inversely proportional to how much we
think we know. The more I know, the more I know I don't know . . .
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Leaf-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/leaf-devel
