Re: Please test Leo's pylint command in devel

[Viktor Ransmayr]

Hello Thomas,

Am Sa., 9. Apr. 2022 um 18:03 Uhr schrieb tbp1...@gmail.com <
tbp100...@gmail.com>:

> Thanks, @lewis, @viktor, this is very helpful.  We have identified the
> cause: The pylint command is run using subprocess.Popen and writes output
> (stdout) to a pipe.  When there is a lot of output, the output pipe fills
> up and the source has to wait until it has room again.  So the process
> never finishes.  You can read the pipe, the the read causes Leo to block
> until there is more output again.  The size of the pipe would be
> os-dependent, so one installation could have success and another remain
> stalled forever.
>
> It's a tricky thing to get this working without blocking Leo.
>
> On Saturday, April 9, 2022 at 11:09:19 AM UTC-4 viktor@gmail.com
> wrote:
>
>> Hello everyone,
>>
>> lewis schrieb am Samstag, 9. April 2022 um 06:11:29 UTC+2:
>>
>>> I tested with a large file - running pylint on leoGlobals.py gives lots
>>> of output.
>>>
>>
>> Trying to to the same on a Leo 'devel' instance in a Fedora VM does not
>> return any output at all.
>>
>
Thanks for your quick feedback & update.

I'll stop applying the latest changes on the development branch until I
hear from you or Edward again.

With kind regards,

Viktor

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAAeSrGJie9wBGWnR7odqinVR%3DqqELMV3hmucAyA96dkDss1Bhw%40mail.gmail.com.

Re: Please test Leo's pylint command in devel

[tbp1...@gmail.com]

Thanks, @lewis, @viktor, this is very helpful.  We have identified the 
cause: The pylint command is run using subprocess.Popen and writes output 
(stdout) to a pipe.  When there is a lot of output, the output pipe fills 
up and the source has to wait until it has room again.  So the process 
never finishes.  You can read the pipe, the the read causes Leo to block 
until there is more output again.  The size of the pipe would be 
os-dependent, so one installation could have success and another remain 
stalled forever.

It's a tricky thing to get this working without blocking Leo.

On Saturday, April 9, 2022 at 11:09:19 AM UTC-4 viktor@gmail.com wrote:

> Hello everyone,
>
> lewis schrieb am Samstag, 9. April 2022 um 06:11:29 UTC+2:
>
>> I tested with a large file - running pylint on leoGlobals.py gives lots 
>> of output.
>>
>
> Trying to to the same on a Leo 'devel' instance in a Fedora VM does not 
> return any output at all.
>
> With kind regards,
>
> Viktor
>  
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/016d60a4-619f-4e4d-992c-3eae3418ff2bn%40googlegroups.com.

Re: Please test Leo's pylint command in devel

[Viktor Ransmayr]

Hello everyone,

lewis schrieb am Samstag, 9. April 2022 um 06:11:29 UTC+2:

> I tested with a large file - running pylint on leoGlobals.py gives lots of 
> output.
>

Trying to to the same on a Leo 'devel' instance in a Fedora VM does not 
return any output at all.

With kind regards,

Viktor
 

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/0bd18eb0-b4b9-4271-851d-fe887e6eeba7n%40googlegroups.com.

Re: Please test Leo's pylint command in devel

[lewis]

I tested with a large file - running pylint on leoGlobals.py gives lots of 
output.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/24ed129f-ed2e-4dbb-90b6-0a6f1365d08cn%40googlegroups.com.

Re: Please test Leo's pylint command in devel

[lewis]

Thanks for the tip.
I ran pylint on an @clean node with a line  *g.es_print(" ")*  which caused 
pylint to give some output. 
That line shows as a UNL link in the log pane:




*pylint: asknames.py* Module asknamesN:\leo\asknames.py:21:0: 
E0602: Undefined variable 'g' (undefined-variable)pylint finished*


On Saturday, April 9, 2022 at 11:33:38 AM UTC+10 tbp1...@gmail.com wrote:

> You have to run it on an external file tree - @file or @clean.  The 
> message is saying that that the routine couldn't find an external file 
> looking upwards through the tree.
>
> On Friday, April 8, 2022 at 9:02:10 PM UTC-4 lewis wrote:
>
>> I have pylint 2.13.5 installed with pip.
>> Right-click over a node and selecting Run Pylint gives message:
>> *pylint: no files found*
>>
>> Alt-x pylint command gives same message.
>>
>> Is there any setup required to use pylint in Leo?
>>
>>
>>
>>
>> *Leo Log WindowLeo 6.6.1-devel, devel branch, build 4bdce3ef48Python 
>> 3.10.4, PyQt version 6.2.4Windows 10 AMD64 (build 10.0.19042) SP0*
>>
>> On Saturday, April 9, 2022 at 1:18:50 AM UTC+10 Edward K. Ream wrote:
>>
>>> Thomas and I have been investigating #2586 
>>> . Everything 
>>> works for me, but Thomas only gets output from the pylint command if he 
>>> sets wait = True in the node:
>>>
>>> "class BackgroundProcessManager" in leoBackground.py.
>>>
>>> This is all the more mysterious since (I think) we are both testing on 
>>> Windows machines.
>>>
>>> I would appreciate any feedback about whether you see pylint output, on 
>>> whatever platform you like.  Thanks!
>>>
>>> Edward
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/33799ed4-5985-4007-89d1-a9ab96b63edcn%40googlegroups.com.

Re: Please test Leo's pylint command in devel

[tbp1...@gmail.com]

You have to run it on an external file tree - @file or @clean.  The message 
is saying that that the routine couldn't find an external file looking 
upwards through the tree.

On Friday, April 8, 2022 at 9:02:10 PM UTC-4 lewis wrote:

> I have pylint 2.13.5 installed with pip.
> Right-click over a node and selecting Run Pylint gives message:
> *pylint: no files found*
>
> Alt-x pylint command gives same message.
>
> Is there any setup required to use pylint in Leo?
>
>
>
>
> *Leo Log WindowLeo 6.6.1-devel, devel branch, build 4bdce3ef48Python 
> 3.10.4, PyQt version 6.2.4Windows 10 AMD64 (build 10.0.19042) SP0*
>
> On Saturday, April 9, 2022 at 1:18:50 AM UTC+10 Edward K. Ream wrote:
>
>> Thomas and I have been investigating #2586 
>> . Everything works 
>> for me, but Thomas only gets output from the pylint command if he sets wait 
>> = True in the node:
>>
>> "class BackgroundProcessManager" in leoBackground.py.
>>
>> This is all the more mysterious since (I think) we are both testing on 
>> Windows machines.
>>
>> I would appreciate any feedback about whether you see pylint output, on 
>> whatever platform you like.  Thanks!
>>
>> Edward
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/6a21fa61-038f-4fcb-8dc8-59d113524224n%40googlegroups.com.

Re: Please test Leo's pylint command in devel

[lewis]

I have pylint 2.13.5 installed with pip.
Right-click over a node and selecting Run Pylint gives message:
*pylint: no files found*

Alt-x pylint command gives same message.

Is there any setup required to use pylint in Leo?




*Leo Log WindowLeo 6.6.1-devel, devel branch, build 4bdce3ef48Python 
3.10.4, PyQt version 6.2.4Windows 10 AMD64 (build 10.0.19042) SP0*

On Saturday, April 9, 2022 at 1:18:50 AM UTC+10 Edward K. Ream wrote:

> Thomas and I have been investigating #2586 
> . Everything works 
> for me, but Thomas only gets output from the pylint command if he sets wait 
> = True in the node:
>
> "class BackgroundProcessManager" in leoBackground.py.
>
> This is all the more mysterious since (I think) we are both testing on 
> Windows machines.
>
> I would appreciate any feedback about whether you see pylint output, on 
> whatever platform you like.  Thanks!
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/63db340f-2fa5-4ccc-b890-81c56850e72an%40googlegroups.com.

Please test Leo's pylint command in devel

[Edward K. Ream]

Thomas and I have been investigating #2586 
. Everything works 
for me, but Thomas only gets output from the pylint command if he sets wait 
= True in the node:

"class BackgroundProcessManager" in leoBackground.py.

This is all the more mysterious since (I think) we are both testing on 
Windows machines.

I would appreciate any feedback about whether you see pylint output, on 
whatever platform you like.  Thanks!

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/9de2424d-38e1-44d4-9b0a-005a84468073n%40googlegroups.com.