Re: Theme Problems

[Edward K. Ream]

On Thu, Dec 15, 2016 at 6:20 PM, Edward K. Ream  wrote:

>
>
> On Tue, Dec 13, 2016 at 8:25 PM, 'Terry Brown' via leo-editor <
> leo-editor@googlegroups.com> wrote:
>
>> You're right, themes seem to have been  completely nerfed.
>> ekr_dark_theme has a @data node, but it doesn't seem to work.
>>
>
​Please file an official bug report, so we can all track this.

Thanks.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[Edward K. Ream]

On Fri, Dec 16, 2016 at 9:57 AM, john lunzer  wrote:

> have you recently done a fresh checkout of Leo and followed the theme
> instructions? I believe that is what both Terry and I did and how we
> concluded that themes are non-operational.
>

​No, I haven't.  I won't be able to do that on my Linux box until I get
home. I'll try to use a theme on my laptop to see what happens.

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[john lunzer]

It's possible the tests need to be updated. Rather than run the tests, have 
you recently done a fresh checkout of Leo and followed the theme 
instructions? I believe that is what both Terry and I did and how we 
concluded that themes are non-operational.

On Thursday, December 15, 2016 at 6:20:19 PM UTC-5, Edward K. Ream wrote:
>
>
>
> On Tue, Dec 13, 2016 at 8:25 PM, 'Terry Brown' via leo-editor <
> leo-e...@googlegroups.com > wrote:
>
>> You're right, themes seem to have been  completely nerfed.
>> ekr_dark_theme has a @data node, but it doesn't seem to work.
>>
>
> ​Hmm.  I don't have access to a Linux box right now, but just before I 
> left for Florida I ran all unit tests in Leo.  That surely used a dark 
> theme, so afaik themes do work on Linux.
>
> EKR
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[Edward K. Ream]

On Tue, Dec 13, 2016 at 8:25 PM, 'Terry Brown' via leo-editor <
leo-editor@googlegroups.com> wrote:

> You're right, themes seem to have been  completely nerfed.
> ekr_dark_theme has a @data node, but it doesn't seem to work.
>

​Hmm.  I don't have access to a Linux box right now, but just before I left
for Florida I ran all unit tests in Leo.  That surely used a dark theme, so
afaik themes do work on Linux.

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

['Terry Brown' via leo-editor]

You're right, themes seem to have been  completely nerfed.
ekr_dark_theme has a @data node, but it doesn't seem to work.

At one point there was infrastructure to build the @data node from a
Leonine tree outline of the theme.

I'll try and have a look at it.

Cheers -Terry

On Tue, 13 Dec 2016 11:48:32 -0800 (PST)
john lunzer  wrote:

> I'm testing on the current master as of today and themes are not
> working as advertised on Linux/Python3/PyQt4.
> 
> I can copy my old "theme" node headlined "leo_dark theme 0" from my
> daily driver version of Leo to my test master and it will load fine.
> 
> The important node to this "theme" is headlined @data 
> qt-gui-plugin-style-sheet, without that the theme does nothing.
> 
> In the current master the "reload-styles" command appears to do
> nothing, it doesn't generate the @data node.
> 
> It is interesting is that a great deal of the detail in the current
> master "leo_dark theme 0" seems to be missing compared to what I
> copied years ago. There used to be an "@button reload-styles" node
> contained in these themes which *does* successfully generate the
> needed @data node.
> 
> Themes used to work and it looks like there was possibly an attempt
> to simplify them and in the process now they don't work.
> 
> I would argue that themes are critical to overall Leo adoption and as
> long as this sits broken we risk losing new users.
> 
> On Tuesday, May 17, 2016 at 2:55:17 PM UTC-4, Edward K. Ream wrote:
> >
> > On Tue, May 17, 2016 at 1:33 PM, Mike Busch  > > wrote:
> >  
> >> I was able to get bg and fg colors to change with the Appearance 
> >> settings. As far as I can tell, Theme isn't read/used.
> >>  
> >
> > ​Good.  I do think your idea for a theme plugin would be useful.
> >
> > Edward
> >  
> 

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[john lunzer]

I'm testing on the current master as of today and themes are not working as 
advertised on Linux/Python3/PyQt4.

I can copy my old "theme" node headlined "leo_dark theme 0" from my daily 
driver version of Leo to my test master and it will load fine.

The important node to this "theme" is headlined @data 
qt-gui-plugin-style-sheet, without that the theme does nothing.

In the current master the "reload-styles" command appears to do nothing, it 
doesn't generate the @data node.

It is interesting is that a great deal of the detail in the current master 
"leo_dark theme 0" seems to be missing compared to what I copied years ago. 
There used to be an "@button reload-styles" node contained in these themes 
which *does* successfully generate the needed @data node.

Themes used to work and it looks like there was possibly an attempt to 
simplify them and in the process now they don't work.

I would argue that themes are critical to overall Leo adoption and as long 
as this sits broken we risk losing new users.

On Tuesday, May 17, 2016 at 2:55:17 PM UTC-4, Edward K. Ream wrote:
>
> On Tue, May 17, 2016 at 1:33 PM, Mike Busch  > wrote:
>
>> I was able to get bg and fg colors to change with the Appearance 
>> settings. As far as I can tell, Theme isn't read/used.
>>
>
> ​Good.  I do think your idea for a theme plugin would be useful.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[Edward K. Ream]

On Tue, May 17, 2016 at 1:33 PM, Mike Busch  wrote:

> I was able to get bg and fg colors to change with the Appearance settings.
> As far as I can tell, Theme isn't read/used.
>

​Good.  I do think your idea for a theme plugin would be useful.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: Theme Problems

[Mike Busch]

I was able to get bg and fg colors to change with the Appearance settings. 
As far as I can tell, Theme isn't read/used.

On Monday, May 16, 2016 at 5:41:32 AM UTC-6, Mike Busch wrote:
>
> TL;DR Despite going over the instructions several times and also deleting 
> my .leo directory once, themes don't work for me (Mac OS 10.11).
>
> I just started grabbed the latest code from GitHub and started using Leo 
> and of course the first thing I have to do is figure out how to get a 
> Zenburn-like theme... I got a bit confused when I didn't see a top-level 
> menu item like "Change Theme" and thought perhaps I have to do it by hand. 
> I was able to get the body pane to change bg and fg colors then found this 
> group and a couple of mentions of themes... 
>
> Long story short, I found the themes and followed the instructions but 
> they no worky. I tried moving the Themes node to different spots, deleting 
> the text after the colon, I even tried deleting the entire .leo directory 
> thinking maybe I screwed up some other setting as I read in one post from a 
> few weeks ago. 
>
> Anyone have an idea how to fix it or perhaps know what I've done wrong? 
> BTW, I'm amazed no one has made a theme switcher plugin. Perhaps the 
> ability to import themes from Eclipse or Vim, too. Maybe I can look into it 
> in my spare time.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Theme Problems

[Mike Busch]

TL;DR Despite going over the instructions several times and also deleting 
my .leo directory once, themes don't work for me (Mac OS 10.11).

I just started grabbed the latest code from GitHub and started using Leo 
and of course the first thing I have to do is figure out how to get a 
Zenburn-like theme... I got a bit confused when I didn't see a top-level 
menu item like "Change Theme" and thought perhaps I have to do it by hand. 
I was able to get the body pane to change bg and fg colors then found this 
group and a couple of mentions of themes... 

Long story short, I found the themes and followed the instructions but they 
no worky. I tried moving the Themes node to different spots, deleting the 
text after the colon, I even tried deleting the entire .leo directory 
thinking maybe I screwed up some other setting as I read in one post from a 
few weeks ago. 

Anyone have an idea how to fix it or perhaps know what I've done wrong? 
BTW, I'm amazed no one has made a theme switcher plugin. Perhaps the 
ability to import themes from Eclipse or Vim, too. Maybe I can look into it 
in my spare time.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.