Re: [libav-devel] [PATCH] Drop DCTELEM typedef
On 22/01/13 10:53, Diego Biurrun wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time), even though the dependency is (in a code-sense) no longer there. Examples are in vp3.c or vp8.c, but there's likely more. Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no dependency on dsputil, before or after my patch ... In any case I'd rather do that on a second patch, this one is large enough. What I did do was push dsputil.h #includes out to the leaves of the dependency graph. An example of this is prores. I dropped the dsputil.h #include from proresdsp.h, but added it to proresdsp.c, proresdec.c and proresenc.c. All three .c files directly use symbols from dsputil.h, so they relied on dsputil.h being provided to them via proresdsp.h. Thus the real dependency count was not increased by three, but reduced from four files to three. Sounds fair. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Drop DCTELEM typedef
Hi, On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time), even though the dependency is (in a code-sense) no longer there. Examples are in vp3.c or vp8.c, but there's likely more. Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no dependency on dsputil, before or after my patch ... [..blah..] $ grep dsputil\.h ../libavcodec/vp*dsp.h ../libavcodec/vp3dsp.h:#include dsputil.h ../libavcodec/vp8dsp.h:#include dsputil.h Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Drop DCTELEM typedef
On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time), even though the dependency is (in a code-sense) no longer there. Examples are in vp3.c or vp8.c, but there's likely more. Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no dependency on dsputil, before or after my patch ... [..blah..] $ grep dsputil\.h ../libavcodec/vp*dsp.h ../libavcodec/vp3dsp.h:#include dsputil.h ../libavcodec/vp8dsp.h:#include dsputil.h So it's a game of showing shell output; here's mine: $ grep dsputil\.h libavcodec/vp*dsp.h libavcodec/vp3dsp.h:#include dsputil.h libavcodec/vp8dsp.h:#include dsputil.h $ git cherry-pick c2567e6c6771a6a5bd66762e486eae0cd608f7a4 Finished one cherry-pick. [test a10ebd3] Drop DCTELEM typedef 163 files changed, 835 insertions(+), 812 deletions(-) $ grep dsputil\.h libavcodec/vp*dsp.h $ git log -n 1 --oneline c2567e6c6771a6a5bd66762e486eae0cd608f7a4 | cat c2567e6 Drop DCTELEM typedef Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Drop DCTELEM typedef
Hi, On Tue, Jan 22, 2013 at 7:49 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time), even though the dependency is (in a code-sense) no longer there. Examples are in vp3.c or vp8.c, but there's likely more. Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no dependency on dsputil, before or after my patch ... [..blah..] $ grep dsputil\.h ../libavcodec/vp*dsp.h ../libavcodec/vp3dsp.h:#include dsputil.h ../libavcodec/vp8dsp.h:#include dsputil.h So it's a game of showing shell output; here's mine: $ grep dsputil\.h libavcodec/vp*dsp.h libavcodec/vp3dsp.h:#include dsputil.h libavcodec/vp8dsp.h:#include dsputil.h $ git cherry-pick c2567e6c6771a6a5bd66762e486eae0cd608f7a4 Finished one cherry-pick. [test a10ebd3] Drop DCTELEM typedef 163 files changed, 835 insertions(+), 812 deletions(-) $ grep dsputil\.h libavcodec/vp*dsp.h $ git log -n 1 --oneline c2567e6c6771a6a5bd66762e486eae0cd608f7a4 | cat c2567e6 Drop DCTELEM typedef Very well then. Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] Drop DCTELEM typedef
On 22/01/13 01:04, Diego Biurrun wrote: It does not help as an abstraction and adds dsputil dependencies. --- doc/optimization.txt |2 +- libavcodec/4xm.c | 10 ++-- libavcodec/alpha/dsputil_alpha.c | 12 ++-- libavcodec/alpha/dsputil_alpha.h | 20 libavcodec/alpha/dsputil_alpha_asm.S |4 +- libavcodec/alpha/motion_est_alpha.c|4 +- libavcodec/alpha/mpegvideo_alpha.c |8 ++-- libavcodec/alpha/simple_idct_alpha.c | 12 ++-- libavcodec/arm/dsputil_init_arm.c | 18 +++--- libavcodec/arm/dsputil_init_armv5te.c |6 +- libavcodec/arm/dsputil_init_armv6.c| 12 ++-- libavcodec/arm/dsputil_init_neon.c | 16 +++--- libavcodec/arm/h264dsp_init_arm.c | 16 +++--- libavcodec/arm/jrevdct_arm.S |2 +- libavcodec/arm/mpegvideo_arm.c |4 +- libavcodec/arm/mpegvideo_armv5te.c |8 ++-- libavcodec/arm/rv34dsp_init_arm.c |6 +- libavcodec/arm/rv34dsp_neon.S |6 +- libavcodec/arm/simple_idct_armv6.S |6 +- libavcodec/arm/simple_idct_neon.S |6 +- libavcodec/arm/vp3dsp_init_arm.c |6 +- libavcodec/arm/vp8.h |2 +- libavcodec/arm/vp8dsp_armv6.S | 12 ++-- libavcodec/arm/vp8dsp_init_armv6.c | 12 ++-- libavcodec/arm/vp8dsp_init_neon.c | 10 ++-- libavcodec/asv.h |2 +- libavcodec/asvdec.c|8 ++-- libavcodec/asvenc.c|8 ++-- libavcodec/bfin/config_bfin.h |2 +- libavcodec/bfin/dsputil_bfin.c |6 +- libavcodec/bfin/dsputil_bfin.h | 21 libavcodec/bfin/fdct_bfin.S|8 ++-- libavcodec/bfin/idct_bfin.S|4 +- libavcodec/bfin/mpegvideo_bfin.c |2 +- libavcodec/bfin/pixels_bfin.S |8 ++-- libavcodec/bfin/vp3_bfin.c |4 +- libavcodec/bfin/vp3_idct_bfin.S|4 +- libavcodec/bink.c |6 +- libavcodec/cavs.c |2 +- libavcodec/cavs.h |2 +- libavcodec/cavsdec.c |8 ++-- libavcodec/cavsdsp.c |4 +- libavcodec/cavsdsp.h |2 +- libavcodec/dct-test.c | 31 ++- libavcodec/dnxhddec.c | 14 +++--- libavcodec/dnxhdenc.c | 20 libavcodec/dnxhdenc.h |4 +- libavcodec/dsputil.c | 34 ++-- libavcodec/dsputil.h | 91 libavcodec/dsputil_template.c | 14 +++--- libavcodec/dv.c|4 +- libavcodec/dvdata.h|6 +- libavcodec/dvdec.c |8 ++-- libavcodec/eaidct.c|6 +- libavcodec/eaidct.h|3 +- libavcodec/eamad.c |6 +- libavcodec/eatgq.c |6 +- libavcodec/eatqi.c |6 +- libavcodec/faandct.c |6 +- libavcodec/faandct.h |6 +- libavcodec/faanidct.c |8 ++-- libavcodec/faanidct.h |7 +-- libavcodec/h261dec.c |4 +- libavcodec/h261enc.c |8 ++-- libavcodec/h263.c |2 +- libavcodec/h263.h |8 ++-- libavcodec/h264.c | 10 ++-- libavcodec/h264.h |7 +-- libavcodec/h264_cabac.c| 36 ++--- libavcodec/h264_cavlc.c|6 +- libavcodec/h264_mb_template.c |2 +- libavcodec/h264dsp.h | 24 - libavcodec/h264idct_template.c | 24 libavcodec/h264pred.h | 12 ++-- libavcodec/h264pred_template.c | 20 libavcodec/ituh263dec.c|6 +- libavcodec/ituh263enc.c|4 +- libavcodec/jfdctfst.c | 18 +++--- libavcodec/jfdctint_template.c | 28 +- libavcodec/jrevdct.c | 38 +++--- libavcodec/mdec.c |8 ++-- libavcodec/mimic.c |4 +- libavcodec/mjpegdec.c | 12 ++-- libavcodec/mjpegdec.h |4 +- libavcodec/mjpegenc.c |4 +- libavcodec/mjpegenc.h |5 +- libavcodec/mpeg12.c| 20 libavcodec/mpeg12.h|2 +- libavcodec/mpeg12enc.c |8 ++-- libavcodec/mpeg4video.h|4 +- libavcodec/mpeg4videodec.c |8 ++-- libavcodec/mpeg4videoenc.c |
Re: [libav-devel] [PATCH] Drop DCTELEM typedef
Hi, On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time), even though the dependency is (in a code-sense) no longer there. Examples are in vp3.c or vp8.c, but there's likely more. Will you remove these in a later commit? Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
