[libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. Qansi-alias is the icl equivalent of -fstrict-aliasing. --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 928e5f4..3bed617 100755 --- a/configure +++ b/configure @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then enabled debug add_ldflags -debug enable pragma_deprecated if enabled icl; then -# basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# -Qansi-alias is basically -fstrict-aliasing that does not work (correctly) on icl 13.x +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +check_cpp_condition windows.h __ICL = 1400 add_cflags -Qansi-alias # icl will pass the inline asm tests but inline asm is currently # not supported (build will fail) disable inline_asm -- 1.8.4.msysgit.0 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 4:34 AM, Alex Smith alex.sm...@warpsharp.info wrote: Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. Qansi-alias is the icl equivalent of -fstrict-aliasing. --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 928e5f4..3bed617 100755 --- a/configure +++ b/configure @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then enabled debug add_ldflags -debug enable pragma_deprecated if enabled icl; then -# basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# -Qansi-alias is basically -fstrict-aliasing that does not work (correctly) on icl 13.x +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +check_cpp_condition windows.h __ICL = 1400 add_cflags -Qansi-alias # icl will pass the inline asm tests but inline asm is currently # not supported (build will fail) disable inline_asm -- 1.8.4.msysgit.0 Forgot to mark it as v3 before I sent it. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 04:34:25AM -0400, Alex Smith wrote: Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. s/version// Qansi-alias is the icl equivalent of -fstrict-aliasing. IMO redundant. --- a/configure +++ b/configure @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then if enabled icl; then -# basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# -Qansi-alias is basically -fstrict-aliasing that does not work (correctly) on icl 13.x Break this line. +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +check_cpp_condition windows.h __ICL = 1400 add_cflags -Qansi-alias Can't you check for == 13 in just one line? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 4:44 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Sep 23, 2013 at 04:34:25AM -0400, Alex Smith wrote: Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. s/version// Qansi-alias is the icl equivalent of -fstrict-aliasing. IMO redundant. Well you asked as if it wasn't clear from the context. --- a/configure +++ b/configure @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then if enabled icl; then -# basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# -Qansi-alias is basically -fstrict-aliasing that does not work (correctly) on icl 13.x Break this line. What do you mean by that? +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +check_cpp_condition windows.h __ICL = 1400 add_cflags -Qansi-alias Can't you check for == 13 in just one line? Diego No, __ICL is the compiler version which is defined as VRP (version, revision, patch) so as updates roll out it won't stay the same. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 04:53:57AM -0400, Alex Smith wrote: On Mon, Sep 23, 2013 at 4:44 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Sep 23, 2013 at 04:34:25AM -0400, Alex Smith wrote: Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. s/version// Qansi-alias is the icl equivalent of -fstrict-aliasing. IMO redundant. Well you asked as if it wasn't clear from the context. No, before it was configure: Add additional optimization for icl 14.x It worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. with no hint what was actually working or not apart from some optimization, while configure: Add additional optimization for icl 14.x Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all fate tests for version icl version 14. is clear about which optimization is meant w/o looking at the diff. I'm very wary of it when writing or reviewing technical documentation. It's far too easy to be ambiguous what it might refer to, leaving the reader confused. IMO even better log message: configure: Enable -Qansi-alias for icl 14+ Qansi-alias worked on 12.x, then caused miscompilation on 13.x, but now works again passing all FATE tests for icl version 14. --- a/configure +++ b/configure @@ -4021,8 +4021,9 @@ elif enabled_any msvc icl; then if enabled icl; then -# basically -fstrict-aliasing that does not work (correctly) on icl 13.x -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# -Qansi-alias is basically -fstrict-aliasing that does not work (correctly) on icl 13.x Break this line. What do you mean by that? The line is too long (80 chars), break it in two. +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +check_cpp_condition windows.h __ICL = 1400 add_cflags -Qansi-alias Can't you check for == 13 in just one line? No, __ICL is the compiler version which is defined as VRP (version, revision, patch) so as updates roll out it won't stay the same. You mean that it won't stay as 1300 but could increase to 1323 or whatever? What about just checking the version alone w/o revision and patch level? Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 5:19 AM, Diego Biurrun di...@biurrun.de wrote: You mean that it won't stay as 1300 but could increase to 1323 or whatever? What about just checking the version alone w/o revision and patch level? Diego That's the only macro definition we have to work with if you have any suggestions. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] configure: Add additional optimization for icl 14.x
On Mon, Sep 23, 2013 at 05:23:34AM -0400, Alex Smith wrote: On Mon, Sep 23, 2013 at 5:19 AM, Diego Biurrun di...@biurrun.de wrote: You mean that it won't stay as 1300 but could increase to 1323 or whatever? What about just checking the version alone w/o revision and patch level? That's the only macro definition we have to work with if you have any suggestions. Try check_cpp_condition windows.h __ICL 1300 __ICL = 1400 add_cflags -Qansi-alias Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
