Re: [libav-devel] [PATCHv2 0/10] VDPAU H.264 High 4:4:4 support

2014-12-19 Thread Rémi Denis-Courmont

Le 2014-12-19 08:51, Anton Khirnov a écrit :
Why would you have to call avcodec_default_get_format()? You could 
just

look at the last offered pixel format (the only non-hwaccel one).


Sure but that is effectively the same thing. The problem remain that 
each and every application would have to code the mapping from 
AV_PIX_FMT_* to VDP_CHROMA_TYPE_* and to VDPAU-specific dimension 
constraints.


Speaking of which, why is avcodec_default_get_format even public 
right

now?


I don't know but at least VLC uses it.

--
Rémi Denis-Courmont
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCHv2 0/10] VDPAU H.264 High 4:4:4 support

2014-12-18 Thread Anton Khirnov
Quoting Rémi Denis-Courmont (2014-12-13 17:41:46)
 The following changes since commit e737a4aaafcb1d761b7f96043c2f83ce742c64ae:
 
   dashenc: Change the duration fields to 64 bit (2014-12-10 22:51:51 +0200)
 
 are waiting for review up to.
 
   vdpau: add support for the H.264 High 4:4:4 Predictive profile (2014-12-13 
 18:39:01 +0200)
 
 Updates since last changes:
 - resync with libvdpau git tree,
 - address comments from Luca and Vittorio,
 - misc minor fixes.
 
 
 Rémi Denis-Courmont (10):
   vdpau: revector macro to reduce line span
   vdpau: add mapping for H.264 Extended profile
   vdpau: add mapping for H.264 Constrained Baseline profile and fallback
   vdpau: add helper for surface chroma type and size
   avconv_vdpau: allocate video surface of VDPAU-specified size
   libavcodec: add AV_HWACCEL_ALLOW_HIGH_DEPTH flag
   vdpau: add common support for other surface chroma types
   h264: factor hwaccel pixel formats list
   vdpau: add support for 4:2:2 and 4:4:4 chroma sampling in H.264
   vdpau: add support for the H.264 High 4:4:4 Predictive profile
 
  avconv_vdpau.c  |   9 +++-
  doc/APIchanges  |   6 +++
  libavcodec/avcodec.h|   6 +++
  libavcodec/h264_slice.c |  89 +++-
  libavcodec/vdpau.c  | 107 
 +++-
  libavcodec/vdpau.h  |  20 +
  libavcodec/vdpau_h264.c |  57 ++-
  libavcodec/vdpau_internal.h |  17 ---
  libavcodec/vdpau_mpeg12.c   |   6 ++-
  libavcodec/vdpau_mpeg4.c|   6 ++-
  libavcodec/vdpau_vc1.c  |   3 +-
  libavcodec/version.h|   2 +-
  12 files changed, 236 insertions(+), 92 deletions(-)
 

Overall I'm not entirely happy with the API creep, but as I cannot
suggest any better way, I'm mostly fine with this set.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCHv2 0/10] VDPAU H.264 High 4:4:4 support

2014-12-18 Thread Rémi Denis-Courmont
Le jeudi 18 décembre 2014, 22:55:06 Anton Khirnov a écrit :
 Overall I'm not entirely happy with the API creep, but as I cannot
 suggest any better way, I'm mostly fine with this set.

There are three other ways I can suggest.

The first one is to use different pixel formats, and I only mention it for the 
sake of completeness because nobody likes that idea except me.

Another option is for the application to call avcodec_default_get_format(), 
match the unaccelerated pixel format to a hardware surface chroma type and to 
the size requirements. That is a little bit uglier in my opinion, and means 
more per-application copycat code.

The last option is to store the needed bits directly in the context. That 
would be awful though.


I think adding the new function from patch 4 is yet the cleanest and least 
invasive solution.

-- 
Rémi Denis-Courmont
http://www.remlab.net/

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCHv2 0/10] VDPAU H.264 High 4:4:4 support

2014-12-18 Thread Anton Khirnov
Quoting Rémi Denis-Courmont (2014-12-18 23:33:45)
 Le jeudi 18 décembre 2014, 22:55:06 Anton Khirnov a écrit :
  Overall I'm not entirely happy with the API creep, but as I cannot
  suggest any better way, I'm mostly fine with this set.
 
 There are three other ways I can suggest.
 
 The first one is to use different pixel formats, and I only mention it for 
 the 
 sake of completeness because nobody likes that idea except me.
 
 Another option is for the application to call avcodec_default_get_format(), 
 match the unaccelerated pixel format to a hardware surface chroma type and to 
 the size requirements. That is a little bit uglier in my opinion, and means 
 more per-application copycat code.
 

Why would you have to call avcodec_default_get_format()? You could just
look at the last offered pixel format (the only non-hwaccel one).

Speaking of which, why is avcodec_default_get_format even public right
now?

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCHv2 0/10] VDPAU H.264 High 4:4:4 support

2014-12-13 Thread Rémi Denis-Courmont
The following changes since commit e737a4aaafcb1d761b7f96043c2f83ce742c64ae:

  dashenc: Change the duration fields to 64 bit (2014-12-10 22:51:51 +0200)

are waiting for review up to.

  vdpau: add support for the H.264 High 4:4:4 Predictive profile (2014-12-13 
18:39:01 +0200)

Updates since last changes:
- resync with libvdpau git tree,
- address comments from Luca and Vittorio,
- misc minor fixes.


Rémi Denis-Courmont (10):
  vdpau: revector macro to reduce line span
  vdpau: add mapping for H.264 Extended profile
  vdpau: add mapping for H.264 Constrained Baseline profile and fallback
  vdpau: add helper for surface chroma type and size
  avconv_vdpau: allocate video surface of VDPAU-specified size
  libavcodec: add AV_HWACCEL_ALLOW_HIGH_DEPTH flag
  vdpau: add common support for other surface chroma types
  h264: factor hwaccel pixel formats list
  vdpau: add support for 4:2:2 and 4:4:4 chroma sampling in H.264
  vdpau: add support for the H.264 High 4:4:4 Predictive profile

 avconv_vdpau.c  |   9 +++-
 doc/APIchanges  |   6 +++
 libavcodec/avcodec.h|   6 +++
 libavcodec/h264_slice.c |  89 +++-
 libavcodec/vdpau.c  | 107 +++-
 libavcodec/vdpau.h  |  20 +
 libavcodec/vdpau_h264.c |  57 ++-
 libavcodec/vdpau_internal.h |  17 ---
 libavcodec/vdpau_mpeg12.c   |   6 ++-
 libavcodec/vdpau_mpeg4.c|   6 ++-
 libavcodec/vdpau_vc1.c  |   3 +-
 libavcodec/version.h|   2 +-
 12 files changed, 236 insertions(+), 92 deletions(-)

-- 
Rémi Denis-Courmont
http://www.remlab.net/

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel