Re: [Libreoffice] Make available this file [Done]
Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
On 10/27/10, Mattias Johnsson wrote: > On 28 October 2010 08:42, LeMoyne wrote: >> >> >> All these tests are with the aScanner.GetLen() > 1 check in place. With >> that Len >=2 check, the new counting routine has no problem with single >> letter words like A, a, 1, -, or just , >> It is puzzling that Mattias removed the check to handle single char words >> on >> his machine but a build out of master/LibOdev works (at least for me) with >> that same check in … > > Hmm, I originally left that check in because it was in Norbert's > sketch code, and I figured he knew what was going on. Not at all. I had no clue. I just found the place where the magic was happening so I mentioned it in the bug report. The 'if' was already in the original code. I just had to move things a bit to not have the if for counting char while still have it the way it was before for words... and I may very well have botched that. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] OpenBSD patch #1
Hi Robert, On 2010-10-28 at 00:17 +0200, Robert Nagy wrote: > I've started to work on a LibreOffice port for OpenBSD and i'd like to > start pushing my diffs slowly, here is the first one. Thank you very much for the patch - pushed! Looking forward to the other ones :-) All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Mattias,
No problem at all. Recompiled with your original simpler if then statement
and I get the same counts for your reference Oasis Metadata Examples odt
http://nabble.documentfoundation.org/file/n1783515/07-08-22-MetaData-Examples.odt
07-08-22-MetaData-Examples.odt
>>> Just one quick test but absolute agreement with and without the length
>>> test.
So, it really does seem that the len=1 strings are just the break char
and one char words must come through as char+break.
You were correct to just slip in the minimal fix and then look at all
the other problems. I really bogged down in the greater context and in the
scanner weirdness. Didn't really get less confused until doing the simple
test of switching between your patch and Cedric's patch.
On one hand, the current method will count the same in other languages as
long as their space char has a uint val of 32. In other words, the present
counter can't tell an upside-down exclamation point from an A: it's all
not-a-space. On the other hand there is almost certainly implicit casting
involved in the whitespace tests (' ' == unicodeCharVar ) and that could
really break it on a different code page. On the gripping hand I don't
really know. It does still over-count a leading double quote (") as its own
word and I'm pretty clueless on that pre-existing condition except to
strongly suspicion the scanner ;-) - the double quote isn't in the
whitespace list at the top of the file.
I will try to look closer to see what the scanner is actually starting
with and giving back as it expands and breaks up the node text. I may not
get to that for a while so please dont let me stop you. For clarity and
completion you may want to pull the numbering/bullets stuff into line with
your fix on the main node text and just re-submit your simpler test.
The documentation folks will laugh if/when they find out we count
bullets as a word. But only because they are in a good mood: they will be
happy with your patch.
- LeMoyne
--
View this message in context:
http://nabble.documentfoundation.org/PATCH-Fix-for-bug-feature-request-30550-Character-count-without-spaces-tp1778667p1783515.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] OpenBSD patch #1
Hello,
I've started to work on a LibreOffice port for OpenBSD and i'd like to
start pushing my diffs slowly, here is the first one.
diff --git a/bin/build-ooo b/bin/build-ooo
index 1f10182..361e8f0 100755
--- a/bin/build-ooo
+++ b/bin/build-ooo
@@ -11,7 +11,7 @@ fi
export TARFILE_LOCATION
-if test "z$BUILD_WIN32" = "z" -a "z`uname -s`" != "zSunOS" -a "z`uname -s`" !=
"zDarwin"; then
+if test "z$BUILD_WIN32" = "z" -a "z`uname -s`" != "zSunOS" -a "z`uname -s`" !=
"zDarwin"; -a "z`uname -s`" != "zOpenBSD"; then
if ! test -f /proc/cpuinfo; then
echo "Looks like proc isn't mounted - this means almost certain"
echo "Java related weird build failure: please check /proc"
diff --git a/bin/piece/unpack-extras b/bin/piece/unpack-extras
index 4accc63..ed8dd43 100755
--- a/bin/piece/unpack-extras
+++ b/bin/piece/unpack-extras
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
TOOLSDIR=$1
OOBUILDDIR=$2
diff --git a/configure.in b/configure.in
index 523104b..8152913 100755
--- a/configure.in
+++ b/configure.in
@@ -673,6 +673,9 @@ $distros_list])
if test "z`uname -s`" = "zDarwin"; then
DISTRO="LibreOfficeMacOSX"
fi
+if test "z`uname -s`" = "zOpenBSD"; then
+DISTRO="LibreOfficeOpenBSD"
+fi
;;
NLD) DISTRO="SUSE"
;;
@@ -696,6 +699,7 @@ case $DISTRO in
Dropline*) VENDORNAME="DroplineGNOME" ;;
Frugalware*) VENDORNAME="Frugalware" ;;
Gentoo*) VENDORNAME="Gentoo" ;;
+LibreOfficeOpenBSD) VENDORNAME="The OpenBSD project" ;;
LibreOffice*) VENDORNAME="The Document Foundation" ;;
Mandriva*) VENDORNAME="Mandriva" ;;
Pardus*) VENDORNAME="Pardus" ;;
@@ -1685,6 +1689,7 @@ distro-configs/LibreOfficeWin32.conf
distro-configs/LibreOfficeLinux.conf
distro-configs/LibreOfficeLinuxDevel.conf
distro-configs/LibreOfficeMacOSX.conf
+distro-configs/LibreOfficeOpenBSD.conf
etc/Makefile
extensions/Makefile
extensions/tweakconfig/Makefile
diff --git a/download.in b/download.in
index ed63c30..f65d128 100755
--- a/download.in
+++ b/download.in
@@ -424,6 +424,7 @@ my %requires_ant = (
LibreOfficeLinuxDevel => 1,
LibreOfficeWin32 => 1,
LibreOfficeMacOSX => 1,
+LibreOfficeOpenBSD=> 1,
);
if ('@BUILD_WIN32@' || $requires_a...@distro@})
{
diff --git a/patches/dev300/apply b/patches/dev300/apply
index b38bc23..fc8d197 100755
--- a/patches/dev300/apply
+++ b/patches/dev300/apply
@@ -150,6 +150,7 @@ LibreOfficeWin32: LibreOfficeCommon LibreOfficePatches
LibreOfficeWin32Patches
LibreOfficeLinux: LibreOfficeCommon LibreOfficePatches LibreOfficeLinuxPatches
LibreOfficeLinuxDevel: LibreOfficeCommon LibreOfficePatches
LibreOfficeLinuxPatches
LibreOfficeMacOSX: LibreOfficeCommon LibreOfficePatches
LibreOfficeMacOSXPatches
+LibreOfficeOpenBSD: LibreOfficeCommon LibreOfficePatches
LibreOfficeOpenBSDPatches
# [ Tag [ >= etc. ], ] patch sets
diff --git a/distro-configs/LibreOfficeOpenBSD.conf.in
b/distro-configs/LibreOfficeOpenBSD.conf.in
new file mode 100644
index 000..f3e62c6
--- /dev/null
+++ b/distro-configs/LibreOfficeOpenBSD.conf.in
@@ -0,0 +1,56 @@
+--with-vendor=\"The OpenBSD project\"
+--disable-dbus
+--disable-kde4
+--enable-cairo
+--with-system-cairo
+--enable-gstreamer
+--disable-odk
+--enable-binfilter
+--enable-gnome-vfs
+--enable-hids
+--enable-lockdown
+--disable-opengl
+--with-java-target-version=1.5
+--with-jdk-home=/usr/local/jdk-1.5.0
+--with-myspell-dicts
+--enable-epm
+--disable-kde
+--disable-mozilla
+--disable-build-mozilla
+--disable-nss-module
+--without-system-mozilla
+--with-system-freetype
+--with-system-jpeg
+--with-system-libxml
+--with-system-libxslt
+--with-system-python
+--with-system-zlib
+--with-system-jars
+--with-system-stdlibs
+--disable-crypt-link
+--disable-pam-link
+--disable-xrender-link
+--disable-randr-link
+--without-openldap
+--with-system-xrender-headers
+--with-system-mesa-headers
+--without-unix-wrapper
+--with-fonts
+--enable-minimizer
+--enable-presenter-console
+--enable-pdfimport
+--with-system-poppler
+--enable-wiki-publisher
+--enable-report-builder
+--with-extension-integration
+--with-linker-hash-style=both
+--with-ant-home=/usr/local/ant/lib
+--with-dict=ALL
+--with-lang=en_US
+--with-system-openssl
+--disable-unix-qstart
+--enable-broffice
+--disable-pasf
+--with-alloc=system
+--without-junit
+--with-gnu-cp=/usr/local/bin/gcp
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
On 28 October 2010 08:42, LeMoyne wrote: > > Using the following sample from a git patch one can see one way in which the > current counting method comes up with fewer words than other methods do. > +1747,9 > 1.7.0.4 > 14 characters on two lines: either 2, 3 or 6 words depending on how you > count > > Gedit says: 2 lines 6 words 15 chars 14 chars(no spaces) > LibOdev says: 2 words 14 chars 14 chars excl spaces - (no stat line for > lines tho it has para counts) > > Gedit takes each number as a word breaking the words on punctuation > Gedit also counts the new line as whitespace > LibOdev counts all of any block of contiguous characters as a word > LibOdev in node word counter never sees the newline > > Over the diff part (from qgit) of Mattias' part 1 - sw patch file showing > gedit / LibOdev > Words: 2418 / 2414 > Chars: 24241 / 24241 > Chars – 16830 / 16830 (excl. spaces) > Now a near match in words and perfect match on chars excl spaces. > > Testing with a different entire patch file, the major difference is in words > 1338 to 1533 or ~200 out of 1400 words, but the total char and char excl. > spaces agree completely 13 459 and 10 157 > Taking into account the different word handling (top) and the way they match > then don't match I suspect a second difference in the counting method tween > gedit and LibOdev and differences in the line breaks in the files after cut > and paste. > > So far gedit and LibOdev agree completely ONLY on the non-space counts. > > I didn't check results on your reference odt because gedit wont open odt and > cut and paste just dumps the XML into the text... > Words 3997 / 18 > Chars 33429 / 125 > Chars – 28469 / 107 > Where the second smaller numbers are a page footer's counts. AFAIR - > LibOdev doesn't count the footer content and that might be the difference. > there are 20+ pages so thats 360+ words ~2500 chars in the footers > > I also saw how the LibOdev count is zero at load of the odt. Perhaps the > count is made somewhere else and saved on the doc without this code or it is > stored in the doc and loaded – either way the word count is marked clean so > it is not re-counted when the dialog box calls updateStats and the excl. > spaces count remains zero. Just clicking in the document causes a full > recount tho and that seems too busy somehow.. <-- more than enough guessing > there > > All these tests are with the aScanner.GetLen() > 1 check in place. With > that Len >=2 check, the new counting routine has no problem with single > letter words like A, a, 1, -, or just , > It is puzzling that Mattias removed the check to handle single char words on > his machine but a build out of master/LibOdev works (at least for me) with > that same check in … Hmm, I originally left that check in because it was in Norbert's sketch code, and I figured he knew what was going on. But I definitely didn't get the right word count with it in place, and I did when I removed it. I was quite puzzled as to its purpose - your explanation about the leading spaces and the SwScanner makes sense, though, and I guess that's the reason it was there. > I will test changing back to Mattias simpler submission. (building now). > I must note that the block immediately after this count area word counts the > outline numbers (and counts the bullets as words!?!) - it does not have any > such length check at all... I think all the len=1 strings that the scanner > might give back are just CH_TXTATR_BREAKWORD = 0x01. And they are probably > Scanner's zero length string. Scanner's GetEnd points one slot past the end > of the string – i.e. for SwScanner GetEnd() = GetBegin() + GetLen() (no > -1 there) And that end spot likely has a break marker. > > Again gedit and LibOdev agree completely ONLY on the non-space counts. Nice analysis! I'm at work now, but with your explanations I'll look into things again when I get home, unless you've solved all the problems by then. I did notice the problem LO has with counting things like isolated punctuation as a word (and its deliberate choice to count bullets as words), but decided not to try and change it, since I figured step 1 was to add the feature without breaking the current behaviour :-P I also couldn't see a way to make it robust for all languages, especially those with non-Latin alphabets and weird punctuation markers. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaning and organizing of configure.in
At 7:39am -0400 Wed, 27 Oct 2010, Wols Lists wrote: I just click on "reply list" :-) Thunderbird has that option if you want to use that ... So it does! Apparently since the 3.0. I've been using my keyboard friends: Ctrl+R (respond directly to author) Ctrl+Shift+R (respond to everyone) But now I can add Ctrl+Shift+L (respond to list) Thanks! Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tar / Zip wobbly
At 5:47pm -0400 Wed, 27 Oct 2010, Wols Lists wrote: On 27/10/10 18:10, Kevin Hunter wrote: The file format was created circa 1990 (Phil Katz, maybe?), and, because of lawsuits against his company, intentionally released into the public domain. I've forgotten the exact story details, The wikipedia article is pretty brief, but it seems that actually Phil Katz stole the basis of zip. That's certainly the story as I understood it. I'm not sure how similar the formats arc and zip are, but zip seems to have started life as an illegal version of arc. Oh good deal! Thanks for pointing me to Wikipedia on the subject! Wikipedia always a good refresher of way more than one needed to know or had time to read ... :-) Further reading suggests that Phil was indeed infringing on SEA's work, but that the Zip file format is *not* the Arc format. I agree with your conclusion that Zip certainly started life because of Arc and an associated interaction, but like you, I don't know the internals of the formats. I had recalled that there was a controversy at the beginning, but I thought it had long been resolved. Surely the Free software community, especially as small as it was back then, would not have let illegal IP into its ranks? We're rather off LibreOffice topic at this point (my fault!), but I'm still genuinely curious about your comment that Zip shouldn't be on a *nix system. It's not the first time I've heard that opinion, but it's the first time I've probed further. Thanks, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] smoketest segfault
On Tue, Oct 26, 2010 at 4:39 AM, Caolán McNamara wrote:
> On Mon, 2010-10-25 at 15:39 -0500, Norbert Thiebaud wrote:
>> On Mon, Oct 25, 2010 at 3:13 PM, Caolán McNamara wrote:
>> > On Sun, 2010-10-24 at 22:03 -0500, Norbert Thiebaud wrote:
>> >> I have a segfault running smoketest.
>> >
>> > Its cold comfort, but smoketest works for me ok.
>>
>> can you post the ./bin/g log of where you are at (and mybe your
>> autogen parameters),
>
> --enable-maintainer-mode --enable-maintainer-mode
> --with-distro=LibreOfficeLinux --disable-kde --disable-kde4 --with-git
> --with-num-cpus=8 --with-max-jobs=8 --enable-symbols --disable-gnome-vfs
> --with-system-cairo --no-create --no-recursion
>
> As a thought, does it make any difference to e.g.
> export SAL_USE_VCLPLUGIN=gen before running build in the
> smoketestoo_native dir and/or export SAL_USE_VCLPLUGIN=svp (for headless
> mode). From your bt I wouldn't think so, but worth perturbing things to
> see what might fall out.
>
n...@tpa10 /lo/ref/rawbuild/smoketestoo_native (master)$ export
SAL_USE_VCLPLUGIN=svp
n...@tpa10 /lo/ref/rawbuild/smoketestoo_native (master)$ build
build -- version: 275224
=
Building module smoketestoo_native
=
Entering /lo/ref/rawbuild/smoketestoo_native/com/sun/star/comp/smoketest
updating: META-INF/MANIFEST.MF (deflated 11%)
updating: com_sun_star_comp_smoketest/META-INF/ (stored 0%)
updating: com_sun_star_comp_smoketest/META-INF/MANIFEST.MF (deflated 11%)
cp -f ../../../../../unxlngx6.pro/class/TestExtension.jar
../../../../../unxlngx6.pro/misc/com_sun_star_comp_smoketest/TestExtension.jar
Making:TestExtension.oxt
updating: META-INF/ (stored 0%)
updating: META-INF/manifest.xml (deflated 51%)
updating: TestExtension.jar (deflated 37%)
updating: TestExtension.rdb (deflated 90%)
Making:com_sun_star_comp_smoketest.dpz
zipdep -- version: 1.12
Multi Platform Enabled Edition
Entering /lo/ref/rawbuild/smoketestoo_native/data
Entering /lo/ref/rawbuild/smoketestoo_native
dmake: Executing shell macro: ls
$(installationtest_instset)/LibO_*_install-arc_$(defaultlangiso).tar.gz
rm -f -r ./unxlngx6.pro/misc/smoketest/user
mkdir -p ./unxlngx6.pro/misc/smoketest/user
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/lo/ref/clone/testing/smoketestoo_native/unxlngx6.pro/lib:/lo/ref/rawbuild/solver/330/unxlngx6.pro/lib
/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/cppunittester \
-env:UNO_SERVICES=file:///lo/ref/clone/testing/smoketestoo_native/./unxlngx6.pro/misc/smoketest/services.rdb
\
-env:UNO_TYPES=file:///lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/types.rdb
\
-env:arg-soffice=path:/lo/ref/rawbuild/solver/330/unxlngx6.pro/installation/opt/program/soffice
-env:arg-user=./unxlngx6.pro/misc/smoketest/user \
-env:arg-env=LD_LIBRARY_PATH"${LD_LIBRARY_PATH+=$LD_LIBRARY_PATH}"
./unxlngx6.pro/lib/libsmoketest.so
-env:arg-doc=./unxlngx6.pro/bin/smoketestdoc.sxw
/lo/ref/rawbuild/solver/330/unxlngx6.pro/installation/opt/program/soffice:
line 154: 15620 Segmentation fault "$sd_prog/$sd_binary" "$@"
^CCaught SIGINT. Trying to quit ...
[.]
n...@tpa10 /lo/ref/rawbuild/smoketestoo_native (master)$ export
SAL_USE_VCLPLUGIN=gen
n...@tpa10 /lo/ref/rawbuild/smoketestoo_native (master)$ build
build -- version: 275224
=
Building module smoketestoo_native
=
Entering /lo/ref/rawbuild/smoketestoo_native/com/sun/star/comp/smoketest
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/lo/ref/rawbuild/solver/330/unxlngx6.pro/lib
/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/regmerge
../../../../../unxlngx6.pro/misc/com_sun_star_comp_smoketest/TestExtension.rdb
/UCR ../../../../../unxlngx6.pro/misc/TestExtension.urd
: &&
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/lo/ref/rawbuild/solver/330/unxlngx6.pro/lib
/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/javamaker
-O../../../../../unxlngx6.pro/class -BUCR -nD
-X/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/types.rdb
../../../../../unxlngx6.pro/misc/com_sun_star_comp_smoketest/TestExtension.rdb
/opt/sun-jdk-1.6.0.20/bin/javac -source 1.6 -target 1.6 -classpath
".:../../../../../unxlngx6.pro/class:/opt/sun-jdk-1.6.0.20/jre/lib/rt.jar:.:/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/ridl.jar:/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/jurt.jar:/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/unoil.jar:/lo/ref/rawbuild/solver/330/unxlngx6.pro/bin/juh.jar::/lo/ref/rawbuild/solver/330/unxlngx6.pro/lib"
-d ../../../../../unxlngx6.pro/class @/tmp/mk6hIj6f
updating: META-INF/MANIFEST.MF (deflated 11%)
updating: com_sun_star_comp_smoketest/META-INF/ (stored 0%)
updating: com_sun_star_comp_smoketest/META-INF/MANIFEST.MF (deflated 11%)
updating: com/sun/star/comp/smoketest/ (stored 0%)
updating: com/sun/star/comp/smoketest/TestExtension.class (deflated 51%)
updating: com/sun/star/comp/smoketest/TestExtension$_TestExtension.class
(deflated 47%)
cp -f ../../../../../unxlngx6.pro/class/TestExtension.j
[Libreoffice] [PATCH] Deprecate --enable-java
As far as I can see, /build doesn't actually use enable-java, but it does use with-java. /build/libreoffice... makes extensive use of with-java and no sign of enable-java. The comment implies that it was only meant to have an impact on --help, anyway, and moving it to a "with" should be the same. It now builds fine with the patch, but I get a load of strange warnings. They don't seem too important, but it would be wise for someone else to check the patch builds okay. errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_e_g.win desktop:RadioButton:TP_REGISTRATION:RB_REGISTRATION_NEVER errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_e_g.win desktop:Edit:TP_USER:ED_USER_FIRST errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_e_g.win desktop:Edit:TP_USER:ED_USER_LAST errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_e_g.win desktop:Edit:TP_USER:ED_USER_INITIALS errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_e_g.win desktop:Edit:TP_USER:ED_USER_FATHER errror: Longname not in hid.lst: /home/anthony/gitstuff/loffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngx6.pro/bin/win/etab_p_s.win desktop:CheckBox:TP_MIGRATION:CB_MIGRATION No EPM: do no packaging at this stage Multiprocessing build is finished Maximal number of processes run: 3 __ | \ \..| | \ \.| |\ \| | \ | | Congratulation ! You have successfully built | | ( ) ( )( ,)( ,) ( _) / \( _)( _)( )/ _)( _) | | )(__ )( ) ,\ ) \ ) _) ( () )) _) ) _) )(( (_ ) _) |__| ()(__)(___/(_)\_)(___) \__/(_) (_) (__)\__)(___) touch stamp/build >From b13ec97e33b9e2aa99703a94a9549a9f24643c41 Mon Sep 17 00:00:00 2001 From: Wol Date: Wed, 27 Oct 2010 16:55:01 +0100 Subject: [PATCH] Deprecate --enable-java --- configure.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index 523104b..f4fc947 100755 --- a/configure.in +++ b/configure.in @@ -125,6 +125,7 @@ AC_ARG_ENABLE(tests, --enable-tests Enables the execution of the tests.], ,) +# DEPRECATED - DELETE AFTER 3.3 IS RELEASED - NOW AN AC_ARG_WITH # This is here only to make --help work nicely: # Shouldn't this be a --enabe-java or AC_ARG_WITH instead? AC_ARG_ENABLE(java, @@ -288,6 +289,13 @@ AC_ARG_WITH(internal-gcc, binutils 2.18).], ,) +# this was wrongly ac_arg_enable +AC_ARG_WITH(java, +[ + --with-java Build LibO with a JDK & Java support.], + enable_java = "yes" # deprecated - set old flag for the moment +,) + AC_ARG_WITH(lang, [ --with-lang Define the localizations to build. The English one is -- 1.7.2.2 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tar / Zip wobbly
On 27/10/10 18:10, Kevin Hunter wrote: > The file format was created circa 1990 (Phil Katz, maybe?), and, > because of lawsuits against his company, intentionally released into > the public domain. I've forgotten the exact story details, The wikipedia article is pretty brief, but it seems that actually Phil Katz stole the basis of zip. That's certainly the story as I understood it. I'm not sure how similar the formats arc and zip are, but zip seems to have started life as an illegal version of arc. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Using the following sample from a git patch one can see one way in which the current counting method comes up with fewer words than other methods do. +1747,9 1.7.0.4 14 characters on two lines: either 2, 3 or 6 words depending on how you count Gedit says: 2 lines 6 words 15 chars 14 chars(no spaces) LibOdev says: 2 words 14 chars 14 chars excl spaces - (no stat line for lines tho it has para counts) Gedit takes each number as a word breaking the words on punctuation Gedit also counts the new line as whitespace LibOdev counts all of any block of contiguous characters as a word LibOdev in node word counter never sees the newline Over the diff part (from qgit) of Mattias' part 1 - sw patch file showing gedit / LibOdev Words: 2418 / 2414 Chars: 24241 / 24241 Chars – 16830 / 16830 (excl. spaces) Now a near match in words and perfect match on chars excl spaces. Testing with a different entire patch file, the major difference is in words 1338 to 1533 or ~200 out of 1400 words, but the total char and char excl. spaces agree completely 13 459 and 10 157 Taking into account the different word handling (top) and the way they match then don't match I suspect a second difference in the counting method tween gedit and LibOdev and differences in the line breaks in the files after cut and paste. So far gedit and LibOdev agree completely ONLY on the non-space counts. I didn't check results on your reference odt because gedit wont open odt and cut and paste just dumps the XML into the text... Words 3997 / 18 Chars 33429 / 125 Chars – 28469 / 107 Where the second smaller numbers are a page footer's counts. AFAIR - LibOdev doesn't count the footer content and that might be the difference. there are 20+ pages so thats 360+ words ~2500 chars in the footers I also saw how the LibOdev count is zero at load of the odt. Perhaps the count is made somewhere else and saved on the doc without this code or it is stored in the doc and loaded – either way the word count is marked clean so it is not re-counted when the dialog box calls updateStats and the excl. spaces count remains zero. Just clicking in the document causes a full recount tho and that seems too busy somehow.. <-- more than enough guessing there All these tests are with the aScanner.GetLen() > 1 check in place. With that Len >=2 check, the new counting routine has no problem with single letter words like A, a, 1, -, or just , It is puzzling that Mattias removed the check to handle single char words on his machine but a build out of master/LibOdev works (at least for me) with that same check in … I will test changing back to Mattias simpler submission. (building now). I must note that the block immediately after this count area word counts the outline numbers (and counts the bullets as words!?!) - it does not have any such length check at all... I think all the len=1 strings that the scanner might give back are just CH_TXTATR_BREAKWORD = 0x01. And they are probably Scanner's zero length string. Scanner's GetEnd points one slot past the end of the string – i.e. for SwScanner GetEnd() = GetBegin() + GetLen()(no -1 there) And that end spot likely has a break marker. Again gedit and LibOdev agree completely ONLY on the non-space counts. -- View this message in context: http://nabble.documentfoundation.org/PATCH-Fix-for-bug-feature-request-30550-Character-count-without-spaces-tp1778667p1782965.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Image Compression Patch
Cheers Michael. Sounds like a good plan of attack. I've added some stats to the wiki based on an analysis I did a while ago.There's some other possible hacks in the analysis here: https://spreadsheets.google.com/ccc?key=0AktmVHYOt-kzcmpnbFE0Rmx2c1lLVTVwaUtDR2t3S0E&hl=en_GB Many thanks,Andrew___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SW_DLLPUBLIC limitations ...
Hi Tor, Michael, I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. If there is any possible trouble, let me know ;) -- Cedric On Wed, 2010-10-27 at 07:21 -0600, Tor Lillqvist wrote: > > The question (for > > Tor) is - if we have a __declspec(dllexport) on two identical symbols in > > two shared libraries that link to each other: will we get some vile > > linking conflict ? [ or not ] ;-) > > As far as I could see by experimenting, yes, as long as you from a DLL don't > both import and export a symbol with the same name, it should work. > > Possibly using some clever tricks or useful options to the linker it might be > possible to make the linker create a DLL that both imports a certain symbol > from another DLL, and also exports the same symbol. > > (If just you manage to create such a DLL, using it should not be > problematic... After all, to the run-time linker, there should be nothing > confusing going on.) > > But of course, without actually trying, and considering C++ is involved, take > all the above with a large grain of salt. > > --tml > > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tar / Zip wobbly
On Wed, 2010-10-27 at 13:10 -0400, Kevin Hunter wrote: > To put a different spin on your surprise, I've wondered for awhile why > it *isn't* installed in the default installation of more desktop-based > nix distros. For me, the nicest bit of zip is the un-compressed, find-able, directory structure at the end of the file; so you don't have to un-gzip everything in order to work out what is there. ODF and OOXML appreciate that. :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Enable testtool (and possibly other stuff) to run with LibO
Hi Guiseppe, On Fri, 2010-10-15 at 21:31 +0200, Giuseppe Castagno wrote: > the following patch should allow testtool to run with LibO. Did your patch(es) get merged ? if not that sucks, sorry - just working back through my mail. They look good to me - but for me the testtool runs reasonably - though that is just vs. a manual install - I've not tried a testtool package (if we have them). > All of the above only if you have done nothing on the matter yet :-). So - seems we havn't :-) where are we at ? are these still needed ? if so, could you re-submit & we'll make sure they don't get dropped. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Dev-install failed
hi' michael, located the call to perl -d:DProf -w and removed the profiling declare if you think the profiling at every build is redundant although the build is nowhere near completion so I can't test it yet, however I've checked and ppc is now with the new sources quoted and make_install.pl is in solenv/bin that should I think take care of most of the issues ;) On Wed, Oct 27, 2010 at 6:02 PM, René Kjellerup wrote: > I will try, and look into that ppc bit too, > But I did a pull -r when I got home today. And is currently building as > fast as my Opteron 1212 let's me :) from scratch. > On Oct 27, 2010 5:19 PM, "Michael Meeks" wrote: > > Hi Rene, > > > > On Wed, 2010-10-27 at 16:41 +0200, René Kjellerup wrote: > >> sh: line 1: 14217 Segmentation fault perl -d:DProf > > > > Wow - we managed to crash perl - that's fun; you're warning about ppc. > > > >> Unquoted string "ppc" may clash with future reserved word > > > > Shows you have a somewhat older version of the script ;-) > > > >> I've been puzzled and tried to look at the install file, but with > >> limited success, other than to confirm that the make_install.pl isn't > >> there in the build directory > > > > We might want to remove the -d:DProf - which may cause the problem: no > > idea why it is there, there is no need to profile on every run. If that > > fixes it, can you submit a patch ? > > > > Thanks, > > > > Michael. > > > > -- > > michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot > > > > > René -- -- as life grows older, I gain experience. bootstrap-ooinstall-removing-code-profiling.diff Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Pushed] Filters - Clean up some comments in binfilter/bf_sw/source/core/unocore/
Hi there, Pushed :-) [ sorry for the delay ] Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Image Compression Patch
Hi Andrew, On Wed, 2010-10-27 at 12:08 +0100, Andrew C. E. Dent wrote: > > Ah ! ;-) out of interest, how many of these do we have still ? > > From a quick count, only ~150 or so... (!) Nice - only 150 duplicated icons. I've added an easy hack for this, we should fix in the code first [ it should be easy ]. http://wiki.documentfoundation.org/Development/Easy_Hacks#don.27t_ship_150_duplicate_placeholder_icons > Sounds like an excellent plan. A few years back I started the task of > stripping out HC icons, but this sometimes caused crashes as the fall > back mechanism (currently just leaves a blank), doesn't always > work... Right - if we can provide some more details to motivate people in that task into the other icon task after that; "un-screw-up accessible icon..." that might motivate people to look at that. It badly needs doing, and we can save a chunk of memory, download bandwidth etc. etc. doing that - we currently duplicate the HC icons in every theme (I think) ;-) > This is a code task that I don't currently have time for, but would > make a good Easy Hack wiki addition. Be great to get some numbers into there - eg. the difference in images.zip file size with and without the hc icons. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] First build error: segmentation fault on vcl
On Tue, 2010-10-26 at 12:22 -0700, Dave Lacy Kusters wrote: > g++ -L/usr/lib -L/usr/lib > -L/home/dlacykusters/libre/libreoffice/build/build/libreoffice-3.2.99.2/solver/330/unxlngi6.pro/lib Aha, indeed, this is why this is breaking for the KDE users. Someone needs to track where those are coming from down and append them to the linker flags rather than prepend them C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Dev-install failed
ooinstall perl script failed with this message: Reading setup from ./setup Running OOo installer Subroutine installer::epmfile::getcwd redefined at /usr/lib64/perl5/5.8.8/Exporter.pm line 65. at /usr/lib64/perl5/5.8.8/x86_64-linux/POSIX.pm line 19 Unquoted string "ppc" may clash with future reserved word at /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solenv/bin/modules/installer/ epmfile.pm line 2836. sh: line 1: 14217 Segmentation fault perl -d:DProf -w /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solenv/bin/ make_installer.pl -f openoffice.lst -l en-US -p LibreOffice -buildid 1 -simple /mnt/newdisk/loffice/install Failed to install: No such file or directory at solenv/bin/ooinstall line 96. Installing extra dictionaries... the build ended with: Making:../unxlngx6.pro/bin/hid.lst warn: two longnames have the same ID: HID_BG_BTN_IMG4 and HID_BG_BTN_IMG14 share ID 34300 warn: two longnames have the same ID: HID_DSADMIN_USESSL_LDAP and HID_DSADMIN_DBASE_PATH share ID 39007 warn: two longnames have the same ID: RID_TABPAGE_PARA_NUMBERING and FN_GOTO_NEXT_MARK share ID 20976 warn: two longnames have the same ID: RID_TOOLBOX_INSERT and 1 share ID 1 warn: two longnames have the same ID: RID_UNDO_DELETE_WARNING and FN_FORMULA_APPLY share ID 20558 warn: two longnames have the same ID: SID_DRAW_FONTWORK and RID_SVX_FONTWORK_BAR share ID 10987 warn: two longnames have the same ID: SID_DRAW_TEXT_VERTICAL and SID_ATTR_CHAR_VERTICAL share ID 10905 warn: two longnames have the same ID: SID_FONTWORK_KERN_CHARACTER_PAIRS and RID_SVX_EXTRUSION_BAR share ID 10986 warn: two longnames have the same ID: UID_RPT_PROP_FORMULA and HID_RPT_GROUPSORT_MOVE_UP share ID 64531 warn: two longnames have the same ID: chart2:TabPage:TP_WIZARD_TITLEANDOBJECTS and CHART2:FL_GRIDS:TP_WIZARD_TITLEANDOBJECTS share ID 551813120 warn: two longnames have the same ID: dbaccess:TabPage:PAGE_MYSQL_JDBC and DBACCESS:FT_JDBCDRIVERCLASS:PAGE_MYSQL_JDBC share ID 851771392 warn: two longnames have the same ID: dbaccess:TabPage:PAGE_MYSQL_NATIVE and DBACCESS:FL_SEPARATOR2:PAGE_MYSQL_NATIVE share ID 851836928 warn: two longnames have the same ID: dbaccess:TabPage:PAGE_ORACLE_JDBC and DBACCESS:FT_JDBCDRIVERCLASS:PAGE_ORACLE_JDBC share ID 851886080 warn: two longnames have the same ID: extensions:ModalDialog:RID_SANE_DIALOG and EXTENSIONS:MODALDIALOG:RID_DLG_SELECTLABELCONTROL share ID 1090125824 warn: two longnames have the same ID: filter:ModalDialog:DLG_OPTIONS and EXTENSIONS:MODALDIALOG:RID_DLG_OEMWIZARD share ID 1090519040 warn: two longnames have the same ID: padmin:ModalDialog:RID_PADIALOG and EXTENSIONS:MODALDIALOG:RID_SANE_DIALOG share ID 1090125824 warn: two longnames have the same ID: padmin:ModalDialog:RID_PPDIMPORT_DLG and EXTENSIONS:MODALDIALOG:RID_DLG_NEW_DATA_TYPE share ID 1090191360 warn: two longnames have the same ID: padmin:ModalDialog:RID_STRINGQUERYDLG and EXTENSIONS:MODALDIALOG:RID_DLG_SELECTION share ID 1090174976 warn: two longnames have the same ID: padmin:PushButton:RID_PADIALOG:RID_PA_BTN_DEL and EXTENSIONS:PUSHBUTTON:RID_SANE_DIALOG:RID_DEVICEINFO_BTN share ID 1090130435 warn: two longnames have the same ID: sd:ModalDialog:RID_SD_DLG_MASTER_LAYOUT and EXTENSIONS:MODALDIALOG:RID_DLG_TABORDER share ID 1090142208 warn: two longnames have the same ID: svx:ModalDialog:DLG_CHINESEDICTIONARY and SVX:CB_REVERSE:DLG_CHINESEDICTIONARY share ID 1078673408 warn: two longnames have the same ID: svx:ModalDialog:DLG_CHINESETRANSLATION and SVX:CB_USE_VARIANTS:DLG_CHINESETRANSLATION share ID 1078657024 warn: two longnames have the same ID: svx:ModalDialog:RID_DEFAULTABOUT and SVX:ABOUT_BTN_OK:RID_DEFAULTABOUT share ID 1078001664 warn: two longnames have the same ID: xmlsecurity:PushButton:RID_XMLSECDLG_DIGSIG:BTN_ADDCERT and PADMIN:PUSHBUTTON:RID_PADIALOG:RID_PA_BTN_STD share ID 1090130434 warn: two longnames have the same ID: xmlsecurity:PushButton:RID_XMLSECDLG_DIGSIG:BTN_REMOVECERT and PADMIN:PUSHBUTTON:RID_PADIALOG:RID_PA_BTN_DEL share ID 1090130435 errror: Longname not in hid.lst: /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/ unxlngx6.pro/bin/win/dial_d_h.winsw:NumericField:DLG_PAGEPREVIEW_PRINTOPTIONS:NF_ROWS errror: Longname not in hid.lst: /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/ unxlngx6.pro/bin/win/dial_d_h.winsw:NumericField:DLG_PAGEPREVIEW_PRINTOPTIONS:NF_COLS errror: Longname not in hid.lst: /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/ unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_LMARGIN errror: Longname not in hid.lst: /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/ unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_RMARGIN errror: Longname not in hid.lst: /mnt/newdisk/loffice/build/build/libreoffice-3.2.99.2/solver/330/ unxlngx6.pro/bin/win/dial_d_h.winsw:MetricField:DLG_PAGEPREVIEW_PRINTOPTIONS:MF_TMARGIN errror: Longname not in hid.lst: /mnt/newdisk/loff
Re: [Libreoffice] [Patch] Fix for installer::languages::shorten_language_string()
Attached are the three commits that make up the whole patch.
I hope this helps.
On 10/27/2010 01:44 AM, Michael Meeks wrote:
Hi Sean,
On Wed, 2010-10-27 at 02:24 -0600, Tor Lillqvist wrote:
Please note that your earlier MD5::Digest patch was reverted, though,
because it was causing problems
Right - it was breaking existing includes of Digest::MD5 at least on my
system. Quite possibly this is because I first committed the digest
code, and then the changes to adapt to it (if so my fault) :-)
Any chance of a complete git diff origin/master..master ?
Thanks,
Michael.
From 324b46372c2ebc972064fe7c19d4344bc45982aa Mon Sep 17 00:00:00 2001
Date: Wed, 20 Oct 2010 11:16:35 -0700
Subject: [PATCH] Added perl module required for commit
f8114ef6051e0fb5cb02d97ea468a2da7d2047fa
---
solenv/bin/modules/Digest.pm | 315 +++
solenv/bin/modules/Digest/MD5.pm | 376 ++
2 files changed, 691 insertions(+), 0 deletions(-)
create mode 100644 solenv/bin/modules/Digest.pm
create mode 100644 solenv/bin/modules/Digest/MD5.pm
diff --git a/solenv/bin/modules/Digest.pm b/solenv/bin/modules/Digest.pm
new file mode 100644
index 000..fb5b0d7
--- /dev/null
+++ b/solenv/bin/modules/Digest.pm
@@ -0,0 +1,315 @@
+package Digest;
+
+use strict;
+use vars qw($VERSION %MMAP $AUTOLOAD);
+
+$VERSION = "1.15";
+
+%MMAP = (
+ "SHA-1" => ["Digest::SHA1", ["Digest::SHA", 1], ["Digest::SHA2", 1]],
+ "SHA-224"=> [["Digest::SHA", 224]],
+ "SHA-256"=> [["Digest::SHA", 256], ["Digest::SHA2", 256]],
+ "SHA-384"=> [["Digest::SHA", 384], ["Digest::SHA2", 384]],
+ "SHA-512"=> [["Digest::SHA", 512], ["Digest::SHA2", 512]],
+ "HMAC-MD5" => "Digest::HMAC_MD5",
+ "HMAC-SHA-1" => "Digest::HMAC_SHA1",
+ "CRC-16" => [["Digest::CRC", type => "crc16"]],
+ "CRC-32" => [["Digest::CRC", type => "crc32"]],
+ "CRC-CCITT" => [["Digest::CRC", type => "crcccitt"]],
+);
+
+sub new
+{
+shift; # class ignored
+my $algorithm = shift;
+my $impl = $MMAP{$algorithm} || do {
+$algorithm =~ s/\W+//;
+"Digest::$algorithm";
+};
+$impl = [$impl] unless ref($impl);
+my $err;
+for (@$impl) {
+my $class = $_;
+my @args;
+($class, @args) = @$class if ref($class);
+no strict 'refs';
+unless (exists ${"$class\::"}{"VERSION"}) {
+eval "require $class";
+if ($@) {
+$err ||= $@;
+next;
+}
+}
+return $class->new(@args, @_);
+}
+die $err;
+}
+
+sub AUTOLOAD
+{
+my $class = shift;
+my $algorithm = substr($AUTOLOAD, rindex($AUTOLOAD, '::')+2);
+$class->new($algorithm, @_);
+}
+
+1;
+
+__END__
+
+=head1 NAME
+
+Digest - Modules that calculate message digests
+
+=head1 SYNOPSIS
+
+ $md5 = Digest->new("MD5");
+ $sha1 = Digest->new("SHA-1");
+ $sha256 = Digest->new("SHA-256");
+ $sha384 = Digest->new("SHA-384");
+ $sha512 = Digest->new("SHA-512");
+
+ $hmac = Digest->HMAC_MD5($key);
+
+=head1 DESCRIPTION
+
+The C modules calculate digests, also called "fingerprints"
+or "hashes", of some data, called a message. The digest is (usually)
+some small/fixed size string. The actual size of the digest depend of
+the algorithm used. The message is simply a sequence of arbitrary
+bytes or bits.
+
+An important property of the digest algorithms is that the digest is
+I to change if the message change in some way. Another
+property is that digest functions are one-way functions, that is it
+should be I to find a message that correspond to some given
+digest. Algorithms differ in how "likely" and how "hard", as well as
+how efficient they are to compute.
+
+Note that the properties of the algorithms change over time, as the
+algorithms are analyzed and machines grow faster. If your application
+for instance depends on it being "impossible" to generate the same
+digest for a different message it is wise to make it easy to plug in
+stronger algorithms as the one used grow weaker. Using the interface
+documented here should make it easy to change algorithms later.
+
+All C modules provide the same programming interface. A
+functional interface for simple use, as well as an object oriented
+interface that can handle messages of arbitrary length and which can
+read files directly.
+
+The digest can be delivered in three formats:
+
+=over 8
+
+=item I
+
+This is the most compact form, but it is not well suited for printing
+or embedding in places that can't handle arbitrary data.
+
+=item I
+
+A twice as long string of lowercase hexadecimal digits.
+
+=item I
+
+A string of portable printable characters. This is the base64 encoded
+representation of the digest with any trailing padding removed. The
+string will be about 30% longer than the binary version.
+L tells you more about this encoding.
+
+=back
+
+
+The functional interface is simpl
Re: [Libreoffice] inserting movie in presentation
On 27/10/10 15:15, Noel Power wrote: Just a quick question as whether anyone tried this with beta2 ( on linux ) on opensuse11.2 opensuse11.3 ( I meant ) I tried and failed to insert a movie ( ogg format ) in a presentation. It failed reporting errors ala "format of selected file is unsupported" etc. Since I have a somewhat dirty installation ( in terms of video related bits ;-) ) would be great to know if someone else with a standard system succeeded or not. othoh ogg plays beautifully in banshee/totem suggesting that I haven't totally trashed my gstreamer config or libs. So I wonder is there a bug in libreoffice or a problem on my system also rpm -v --verify --query --all "*gstreamer*" etc. doesn't flag any problems either thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] inserting movie in presentation
Just a quick question as whether anyone tried this with beta2 ( on linux ) on opensuse11.2 I tried and failed to insert a movie ( ogg format ) in a presentation. It failed reporting errors ala "format of selected file is unsupported" etc. Since I have a somewhat dirty installation ( in terms of video related bits ;-) ) would be great to know if someone else with a standard system succeeded or not. othoh ogg plays beautifully in banshee/totem suggesting that I haven't totally trashed my gstreamer config or libs. So I wonder is there a bug in libreoffice or a problem on my system also rpm -v --verify --query --all "*gstreamer*" etc. doesn't flag any problems either thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SW_DLLPUBLIC limitations ...
> The question (for > Tor) is - if we have a __declspec(dllexport) on two identical symbols in > two shared libraries that link to each other: will we get some vile > linking conflict ? [ or not ] ;-) As far as I could see by experimenting, yes, as long as you from a DLL don't both import and export a symbol with the same name, it should work. Possibly using some clever tricks or useful options to the linker it might be possible to make the linker create a DLL that both imports a certain symbol from another DLL, and also exports the same symbol. (If just you manage to create such a DLL, using it should not be problematic... After all, to the run-time linker, there should be nothing confusing going on.) But of course, without actually trying, and considering C++ is involved, take all the above with a large grain of salt. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] Easy Task - systray build progress tracker
On Tue, 2010-10-26 at 19:00 +0100, Luke Dixon wrote: > Thanks, that makes sense. I saw the other commits by people that fixed > what I had broken, I'm very sorry for any trouble I've caused. Hah - all my fault for not testing more widely, but Jesus helped out & we got there in the end. > I forgot about DISPLAY. Thanks. I'll have to look into it. And I did that too for safety. > > Anyhow - thanks ! is there anything else you'd like to work on ? > > I'm not really sure. I've not really looked at any of this code before > so I'm just trying to learn about it at the moment, though I haven't > looked at anything past the build system yet. Cool :-) so - some of the formula tasks might be interesting - with Jonas (just added to the Easy Hacks list). > Thank you for being so welcoming. You're welcome ! :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SW_DLLPUBLIC limitations ...
Hi guys, Soo ... Cedric just had an interesting bug: On Tue, 2010-10-26 at 18:22 +0200, Cédric Bosdonnat wrote: > Attached is a diff adding the SW_DLLPUBLIC to the ICheckboxFieldmark > (and friends). To test the problem, open the p11.doc file. > > sw/source/core/doc/docbm.cxx, line 448 we still have a > ICheckboxFieldmark. > sw/source/filter/ww8/wrtww8.cxx, line 3520, the dynamic_cast fails. The ICheckboxFieldmark class is an abstract class with no constructor, as such its type information is likely to be compiled into any translation unit that uses it. Unfortunately - we need to use that typeinfo in a dynamic cast inside the libmsword split library. The consequence of that is that we need to annotate all versions of that typeinfo to be public (ie. not hidden) such that the run-time linker (if not compile time) linker will be able to detect and elide these so they resolve to the same value and the dynamic_cast works. Unfortunately SW_DLLPUBLIC cannot do this: since libmsword is a separate shared library, and it results in a .hidden symbol outside of the library. Hence the suggestion to use SAL_DLLPUBLIC_EXPORT as an annotation for these classes, which may (un-tested) work on Linux[1]. The question (for Tor) is - if we have a __declspec(dllexport) on two identical symbols in two shared libraries that link to each other: will we get some vile linking conflict ? [ or not ] ;-) Thanks, Michael. [1] - though interestingly we also have a map file for libmsword - which is perhaps also unhelpful here: should we ? -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Drat, I meant to send: I removed the aScanner.GetLen() > 1 check because if you leave that in, it doesn't count words consisting of a single character as words. So it wasn't counting words like "a" or "i" On 27 October 2010 23:38, Cedric Bosdonnat wrote: > Hi Mattias, > > On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote: >> Here are my patches for the easy hack / programming task "Count >> characters without whitespace in the Writer statistics." Since it's >> something translators have apparently been asking for OO.org to have >> for eight years (see >> http://www.openoffice.org/issues/show_bug.cgi?id=10356 and >> https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for >> it to appear in LibreOffice :-) > > Thanks for your patches, I reviewed them and cleaned up a bit the > SwTxtNode::WordCount() method as you added some commented code. I also > kept the condition for the aScanner.GetLen() > 1... is there any reason > to remove that? > > I removed the task from the EasyTasks list. Keep providing nice patches > like those ;) > > Regards, > > -- > Cédric Bosdonnat > LibreOffice hacker > http://documentfoundation.org > OOo Eclipse Integration developer > http://cedric.bosdonnat.free.fr > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
On 27 October 2010 23:38, Cedric Bosdonnat wrote: > Hi Mattias, > > On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote: >> Here are my patches for the easy hack / programming task "Count >> characters without whitespace in the Writer statistics." Since it's >> something translators have apparently been asking for OO.org to have >> for eight years (see >> http://www.openoffice.org/issues/show_bug.cgi?id=10356 and >> https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for >> it to appear in LibreOffice :-) > > Thanks for your patches, I reviewed them and cleaned up a bit the > SwTxtNode::WordCount() method as you added some commented code. I also > kept the condition for the aScanner.GetLen() > 1... is there any reason > to remove that? > > I removed the task from the EasyTasks list. Keep providing nice patches > like those ;) > > Regards, > > -- > Cédric Bosdonnat > LibreOffice hacker > http://documentfoundation.org > OOo Eclipse Integration developer > http://cedric.bosdonnat.free.fr > > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Hi Mattias, On Wed, 2010-10-27 at 18:26 +1100, Mattias Johnsson wrote: > Here are my patches for the easy hack / programming task "Count > characters without whitespace in the Writer statistics." Since it's > something translators have apparently been asking for OO.org to have > for eight years (see > http://www.openoffice.org/issues/show_bug.cgi?id=10356 and > https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for > it to appear in LibreOffice :-) Thanks for your patches, I reviewed them and cleaned up a bit the SwTxtNode::WordCount() method as you added some commented code. I also kept the condition for the aScanner.GetLen() > 1... is there any reason to remove that? I removed the task from the EasyTasks list. Keep providing nice patches like those ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaning and organizing of configure.in
On 27/10/10 00:41, Niko Rönkkö wrote: > And then there is that: > http://cgit.freedesktop.org/libreoffice/build/tree/configure.in#n128 > Which is definedly wrong and which nobody knows how it should be... I'm looking at this :-) It looks to me (looking at the autoconf doc) that this is a clear case of "should be WITH". The docu says "with", but in practice you need "enable" to make it work ... So. Are you happy with the following ... a) Mark the current section as "wrong and deprecated". b) create the "--with-java" section that clearly looks as though it should be there. c) try and fix anything that's going to break. (probably initially at least, by making the "with java" section set any "enable java" variables :-( d) delete it after 3.3 is released. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Pushed] Build problem on windows 7
> Patch attached! Thanks, pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaning and organizing of configure.in
On 26/10/10 23:53, Kevin Hunter wrote: > At 6:18pm -0400 Tue, 26 Oct 2010, Christian Lohmaier wrote: >> I must get used to that this list doesn't set reply to list... > > Oh brother, I hear you. I personally prefer that a list gets all > traffic, end of discussion. However, it was pointed out to me about 6 > months ago that I'm the losing side of that argument. The article(s) > it took to convince me: > > http://woozle.org/~neale/papers/reply-to-still-harmful.html > > In this light, the LO list is actually doing "the right thing." > I just click on "reply list" :-) Thunderbird has that option if you want to use that ... Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Image Compression Patch
Hi Michael> Ah ! ;-) out of interest, how many of these do we have still ?From a quick count, only ~150 or so... (!)> IMHO it is a nonsense to distribute them. I would prefer to have a> single "missing icon" icon, and a fallback path in the image loader> (vcl/source/gdi/impimage*) that would load those icons when the target> is missing (and preferably log to the console ;-).Sounds like an excellent plan. A few years back I started the task of stripping out HC icons, but thissometimes caused crashes as the fall back mechanism (currently just leaves a blank), doesn't always work... This is a code task that I don't currently have time for, but would make a good Easy Hack wiki addition.Cheers,Andrew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running
Michael Meeks wrote: > On Wed, 2010-10-27 at 01:15 +0200, Thorsten Behrens wrote: > > I've for the while reverted the commit, will look into this tomorrow. > > Ah ! - better to add a prefix to the prj/build.lst dep. or something to > the makefile.mk so it still build on (only) Linux (?) ;-) Looking > forward to having it fixed on mac though ... > I breaks on *Linux* here. ;) This is all rather nasty - currently fighting with some resmgr issues... Cheers, -- Thorsten pgpCnRuFWpysv.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Questions about SDK.
Hi all, after building a LibO dev installation package, I installed the lot and the corresponding SDK, just to have a look at it. It appears there are some issue, or so it seems to me, to be addressed. Generally speaking, when I try to install it, it tries to use OOo 3 installation whereas I can force the LibO one, but then it overwrites an existing OOo 3 sdk local installation. Possibly playing havoc with the concurrent OOo 3 sdk installation instead of building a new one. The IDL documentation generated during LibO build time points to OOo DevGuide on the OOo wiki. The OOo DevGuide will then points back to IDL api on OOo web sites then, so confusing matters a litte... So my questions: 1) about the documentation: this is a complicated matter, since the LibO API, hence the IDL doc, may have different material, so some decision should be made on what to do. Or a decision was already made and I missed it. 2) the installation step: I'm not sure if it work; at a first try forcing manually the auto-detected installation directory seems ok, but the user environment for LibO ends up in the same directory as OOo so may be some small adjusting is needed. Besides it would be interesting to see if the user IDL declaration are compiled and registered in the API database. A somehow lengthly process. Is there someone checking this? If not, then I'm willing to give a hand, may be I'll learn something new, though I'll limit the checking to Java; since on C++ I never did anything on the OOo SDK side. beppec56 -- Kind Regards, Giuseppe Castagno Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu beppec56 at openoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] the basic macro editor
On Wed, Oct 27, 2010 at 11:29 AM, Michael Meeks wrote: > > On Tue, 2010-10-26 at 21:39 +0200, René Kjellerup wrote: > > Very understandable then, I've had build issues since the 17th... > >Nasty - can we help out with them ? perhaps the solver is out of > sync > somehow - Norbert's recommendation to remove build/libreoffice/solver in > its entirety may help there. > well maybe... I do, whenever I can, update my build tree (once a day usually) and just before I retry: $ git pull -r if that failse (cause of locally modified files) $ git fetch ; git merge origin then $ bin/g fetch ; bin/g merge origin $ make clean $ ./autogen.sh $ make if you'd have some git pointer if I need to update my build tree otherwise > > and no real time to look into it. I apologize for having brought it up > > so late. > >No problem ! :-) > > > Nice to see it has been solved. Thanks > >Thanks for your persistence in debugging ! lets try to get you a > working build ... > yeah, I thought I had one yesterday evening however a perl script failed for make dev-install (ooinstall) I'll post a new tread about it and let this one die as it should ^_^ >All the best, > >Michael. > > -- > michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot > > > I try to at least read up on the issues posted at the mailing list. thanks for everything, René -- -- as life grows older, I gain experience. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaning and organizing of configure.in
On 27/10/10 10:38, Michael Meeks wrote: > In configure.in - but can we separate the (more controversial) > re-ordering of all arguments with the fixing / documenting of the > options. > > I guess we should also try to fix this in the 'inner' configure in > bootstrap/ since we hope to abandon the 'outer' configure for 3.3.next Does that mean we want to fix /build/libreoffice.../configure.in rather than /build/configure.in ? Okay. I'll make sure I duplicate my work in configure.in across both of those. Niko: I'm trying to work on configure.in as well, we should try and sort out a page on the wiki that documents how/what needs changing so we don't tread on each others toes ... :-) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tar / Zip wobbly
> but I still stand by > my comment "what is zip doing on a nix system?" Given that .odf files are .zip files, I would be surprised if you did not have a zipper/unzipper on your box. :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] First build error: segmentation fault on vcl
Hi Dave, On Tue, 2010-10-26 at 12:22 -0700, Dave Lacy Kusters wrote: > > I don't know why exactly this is happening. It appears to be picking up > > a stlport_gcc in /usr/lib before the one in /path/to/solver. So what's > > the output of > > echo $LD_LIBRARY_PATH btw Soo ... IIWY I would remove your solver: rm -Rf build/libreoffice*/solver And re-configure with --without-stlport Hopefully that will fix your build; failing that, disabling both kde3 and 4 will get you past the problem (for now). > Note, there is /usr/lib, then solver/330/unxlngi6.pro/lib, then /usr/lib > again. > The linker doesn't have a chance to find the one in the solver hierarchy. > > Where specifically is this command line generated? So - see the Linux*.Set.sh file in the inner build directory, and also solenv/inc/*.mk - which together populate all the dmake rules [ yes we will be switching to a more standard gnumake structure for the next release ] Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running
On Wed, 2010-10-27 at 01:15 +0200, Thorsten Behrens wrote: > I've for the while reverted the commit, will look into this tomorrow. Ah ! - better to add a prefix to the prj/build.lst dep. or something to the makefile.mk so it still build on (only) Linux (?) ;-) Looking forward to having it fixed on mac though ... Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] credits page is 403 access forbidden
On Tue, 26 Oct 2010 17:17:59 +0200 (CEST), "David Schröder" wrote: > I'm a newcomer and at this point of state I can't real help. Welcome :) > Your list isn't correct. It shows only the contributors since > the - harding to say - fork. Well, if you look at the title of the page: "Git contributors since LibreOffice inception" then it shows exactly that. All contributors to the fork, right. So it's not wrong. WOuld it be useful to include all contributors somewhere? Yes, I haven't gotten to it yet, and I have not come up with a good way to differentiate between the "old OOo" contributors and the "new LO" ones. I'll try to add that as time allows. > https://www.ohloh.net/p/libreoffice/contributors Thanks for the link. Perhaps we should include that link for a full history credit page? Recreating the credits page for the full history every day is probably going to be very expensive, and I don't have any caching implemented yet. Sebastian pgp1WwvLsHMm2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaning and organizing of configure.in
Hi Niko, On Wed, 2010-10-27 at 02:41 +0300, Niko Rönkkö wrote: > I think that it would be best to name all options consistently like: I like the idea of consistent naming; though we need to make sure that all the distro packagers at least get notified so they can change their .spec files, and we get the distro-config/ parameter files sorted out cleanly [ hopefully the bulk of their parameters are standardised there ]. > I just don't know hot to make those changes elsewhere than in configure. Sure - that is the place. > There is also a lots of non documented options like --enable-epm. Which need documenting :-) > And then there is that: >http://cgit.freedesktop.org/libreoffice/build/tree/configure.in#n128 > Which is definedly wrong and which nobody knows how it should be... :-) > I'd like to make a patch to those if only I would know where those > changes shall made in. In configure.in - but can we separate the (more controversial) re-ordering of all arguments with the fixing / documenting of the options. I guess we should also try to fix this in the 'inner' configure in bootstrap/ since we hope to abandon the 'outer' configure for 3.3.next > PS. There is also some OOo'isms like --with-ooo-builddir. Should be > --with-builddir or something like that - I think. :-) quite probably some renaming, and/or simple removal of obsolete & unusued options is necessary too. Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Moved wrappers for all debuginfo calls into the function itself
>> This patch is public domain. > Does it mean LGPLv3+ / MPL as it's the prefered licence for LibreOffice? It depends on the country of the author, there is no way to make one's work immediately enter the "public domain" (and not just after its copyright has expired) in many countries. But sure, this clearly indicates that the author's intent is that you can do what you like with it, for instance redistribute it as LGPLv3+/MPL, yes. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tar / Zip wobbly
> Bear in mind tar is a perfectly good extraction utility (that, in its > gnu form is probably quite capable of coping with zips), No it is not. > what the h*** > are people doing assuming that zip is available on a *nix system!? > but I still stand by > my comment "what is zip doing on a nix system?" If you are going to work with some kind of programming related to ODF (Open Document Formats), having zip and unzip is definitely highly recommended in order to be able to manipulate such files. It might come as a surprise to you, but the zip format is widely used also on "*nix". ODF documents are actually (SHOCK, HORROR), zip files. (So are .jar files, for instance.) And if the LibreOffice build does take for granted that zip is available, that is a relatively reasonable thing to do IMHO. At least in a Windows build the LibreOffice build mechanism packs some stuff into zip files and then later unpacks it (yeah, weird, but then lots of things are...). So please, do submit a patch to add an explicit check to the LibreOffice configury for zip and unzip, if you think such a check is needed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] the basic macro editor
On Tue, 2010-10-26 at 21:39 +0200, René Kjellerup wrote: > Very understandable then, I've had build issues since the 17th... Nasty - can we help out with them ? perhaps the solver is out of sync somehow - Norbert's recommendation to remove build/libreoffice/solver in its entirety may help there. > and no real time to look into it. I apologize for having brought it up > so late. No problem ! :-) > Nice to see it has been solved. Thanks Thanks for your persistence in debugging ! lets try to get you a working build ... All the best, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Image Compression Patch
Hi Andrew, On Tue, 2010-10-26 at 22:49 +0100, Andrew C. E. Dent wrote: > Thanks again for checking so deeply. > Sorry, I should have been clearer on these images... > These are the green (/red) crosses that have long existed as icon > placeholders. Ah ! ;-) out of interest, how many of these do we have still ? IMHO it is a nonsense to distribute them. I would prefer to have a single "missing icon" icon, and a fallback path in the image loader (vcl/source/gdi/impimage*) that would load those icons when the target is missing (and preferably log to the console ;-). If there are still a significant number of non-icon icons ;-) then it would be great to add that as an easy-hack in the wiki (if you could?). > They probably are redundant, but I haven't looked at the code to test > this- so it may be best to go with this hack for a quick fix... I think the idea was to have something visually easily identifyable to see the missing icons. But of course, the idea of zipping dozens of the same non-image indefinitely is really silly ;-) Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Fix for installer::languages::shorten_language_string()
Hi Sean, On Wed, 2010-10-27 at 02:24 -0600, Tor Lillqvist wrote: > Please note that your earlier MD5::Digest patch was reverted, though, > because it was causing problems Right - it was breaking existing includes of Digest::MD5 at least on my system. Quite possibly this is because I first committed the digest code, and then the changes to adapt to it (if so my fault) :-) Any chance of a complete git diff origin/master..master ? Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Moved wrappers for all debuginfo calls into the function itself
On Tue, 2010-10-26 at 14:32 -0700, Sean McMurray wrote: > This patch is public domain. Does it mean LGPLv3+ / MPL as it's the prefered licence for LibreOffice? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Patch] Fix for installer::languages::shorten_language_string()
Please note that your earlier MD5::Digest patch was reverted, though, because it was causing problems, so this follow-up patch which presumably depends on that earlier one can not be applied. I didn't notice the problems myself as I hadn't got that far in the build before the patch was applied and then reverted... but those who experienced the problems hopefully can describe in more detail. Cheers, --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for bug / feature request 30550 - Character count without spaces
Hi all,
Here are my patches for the easy hack / programming task "Count
characters without whitespace in the Writer statistics." Since it's
something translators have apparently been asking for OO.org to have
for eight years (see
http://www.openoffice.org/issues/show_bug.cgi?id=10356 and
https://bugs.freedesktop.org/show_bug.cgi?id=30550) it'd be nice for
it to appear in LibreOffice :-)
I've added an extra couple of lines to the word count dialog box which
give the number of characters excluding whitespace in both selected
text and the entire document. As far as the UI decision goes, I
checked in MS Word, and that's what it does, so I figure if it's good
enough for MS it's good enough for us.
Note: I'm still getting started with the LibreOffice code base, and
I'm not entirely certain what I'm doing. For example, I have no idea
about what is supposed to happen with regard to internationalisation,
or whether this also works under Windows, given that it affects the
UI.
Still, it builds and works under Ubuntu 10.10 x86_64. I've tested it
with a number of documents and it seems to give the right answers
(with a caveat, see below), and the answers with respect to the
standard word/character count are the same as before, so I at least
haven't broken anything. If my patches aren't up to scratch, hopefully
other people can at least use them as a starting point.
Now the caveat. There seems to be a bug, in that at least one document
(www.oasis-open.org/committees/download.php/25054/07-08-22-MetaData-Examples.odt
) gives the wrong word/character count if you open it and check the
document statistics. However if you edit it at all, such as adding a
character, and then check the statistics, they're then correct. It's
as though the load doesn't mark the word count as dirty or something.
Documents I create, save and open seem to work fine.
The reason I'm submitting these patches despite this bug is that that
bug was present before I made my changes. I just pulled the latest
git, built and checked to make sure. So my feature change works, and
moves things forward, but doesn't fix this orginal bug which I found
during testing my changes. Note that OpenOffice.org 3.2 (Ubuntu 10.10
x86_64 repository version) doesn't seem to have the bug.
It's not immediately obvious to me how to fix it, but hopefully it'll
be blindingly obvious to someone else.
Please examine, test, and tell me if I've done stuff that's horribly wrong :-P
Patches contributed under MPL 1.1 / GPLv3+ / LGPLv3+ licenses.
Cheers,
Mattias
From 5ac50b845feab1ab1901cd52593237c3676e097b Mon Sep 17 00:00:00 2001
From: Mattias Johnsson
Date: Wed, 27 Oct 2010 18:01:43 +1100
Subject: [PATCH] Add character count exclusive of whitespace to document statistics part 1
---
sw/inc/docstat.hxx |1 +
sw/inc/ndtxt.hxx|2 +
sw/source/core/doc/docstat.cxx |2 +
sw/source/core/txtnode/txtedt.cxx | 115 +-
sw/source/ui/dialog/wordcountdialog.cxx |6 ++
sw/source/ui/dialog/wordcountdialog.hrc | 30 +
sw/source/ui/dialog/wordcountdialog.src | 42 +---
sw/source/ui/inc/wordcountdialog.hxx|4 +
8 files changed, 130 insertions(+), 72 deletions(-)
diff --git a/sw/inc/docstat.hxx b/sw/inc/docstat.hxx
index a818e2f..8b156bf 100644
--- a/sw/inc/docstat.hxx
+++ b/sw/inc/docstat.hxx
@@ -44,6 +44,7 @@ struct SW_DLLPUBLIC SwDocStat
ULONG nAllPara;
ULONG nWord;
ULONG nChar;
+ULONG nCharExcludingSpaces;
BOOL bModified;
SwDocStat();
diff --git a/sw/inc/ndtxt.hxx b/sw/inc/ndtxt.hxx
index 08410b0..713a30b 100644
--- a/sw/inc/ndtxt.hxx
+++ b/sw/inc/ndtxt.hxx
@@ -189,6 +189,8 @@ class SW_DLLPUBLIC SwTxtNode: public SwCntntNode, public ::sfx2::Metadatable
SW_DLLPRIVATE ULONG GetParaNumberOfWords() const;
SW_DLLPRIVATE void SetParaNumberOfChars( ULONG nTmpChars ) const;
SW_DLLPRIVATE ULONG GetParaNumberOfChars() const;
+SW_DLLPRIVATE void SetParaNumberOfCharsExcludingSpaces( ULONG nTmpChars ) const;
+SW_DLLPRIVATE ULONG GetParaNumberOfCharsExcludingSpaces() const;
SW_DLLPRIVATE void InitSwParaStatistics( bool bNew );
/** create number for this text node, if not already existing
diff --git a/sw/source/core/doc/docstat.cxx b/sw/source/core/doc/docstat.cxx
index b75a057..e2bef7f 100644
--- a/sw/source/core/doc/docstat.cxx
+++ b/sw/source/core/doc/docstat.cxx
@@ -46,6 +46,7 @@ SwDocStat::SwDocStat() :
nAllPara(1),
nWord(0),
nChar(0),
+nCharExcludingSpaces(0),
bModified(TRUE)
{}
@@ -63,6 +64,7 @@ void SwDocStat::Reset()
nAllPara= 1;
nWord = 0;
nChar = 0;
+nCharExcludingSpaces = 0;
bModified = TRUE;
}
diff --git a/sw/source/core/txtnode/txtedt.cxx b/sw/source/core/txtnode/txtedt.cxx
index aa8faaa..ad2eb8b 100644
--- a/sw/source/core/txtnode/txtedt.cxx
+++ b/sw/source/core/txtnode/txtedt.cxx
@@ -2,7 +2,7 @@
/***
