Re: [Libreoffice] [PATCHES] Eight "small" patches to remove trailing whitespaces from help
Hi Miklos, On 2010-11-15 at 21:29 +0100, Miklos Vajna wrote: > > I am sorry, but as discussed previously [1], we would prefer not to fix > > the trailing whitespace yet, until git with better merge strategies (to > > handle whitespace changes flawlessly during merges) is released. > > Have you tried the ignore-all-space option of git merge-recursive, which > was added recently in version 1.7.2? (It was released this summer.) That's exactly the one I wanted to try/use, and still do not have it in my 1.7.3.1 (from http://download.opensuse.org/repositories/devel:/tools:/scm/SLE_11/) :-( Even the man page does not mention it here. Do you know if there there si a build-time option to enable it, or something? Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] More links inherited from OOo
Hi folks,
after some more grepping, also adapted the readmes to only reference
documentfoundation/libreoffice links. File is attached, would be
cool if you could review it for correctness, language - and whether
the links as such make sense.
Thanks,
-- Thorsten
http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml";>
${PRODUCTNAME} Readme
File
#Copyright_Trademark * {font-size: .7em;}
.note {border: 1px solid #99; padding: 3px;}
p { margin-top: .1em; margin-bottom: .1em;}
.code {font-family: monospace;}
${PRODUCTNAME}
${PRODUCTVERSION} ReadMe
For latest
updates to this readme file, see http://www.libreoffice.org/welcome/readme.html";>http://www.libreoffice.org/welcome/readme.html
This file contains
important information about this program. Please read this information very
carefully before starting work.
The LibreOffice Community,
responsible for the development of this product, would like to invite you to
participate as a community member. As a new user, you can check out the
${PRODUCTNAME} site with helpful user information at http://www.libreoffice.org/about_us/introduction.html";>http://www.libreoffice.org/about_us/introduction.html
Also read the sections
below about getting involved in the LibreOffice project.
Is ${PRODUCTNAME} really
free for any user?
${PRODUCTNAME} is free for
use by everybody. You may take this copy of ${PRODUCTNAME} and install it on as
many computers as you like, and use it for any purpose you like (including
commercial, government, public administration and educational use). For further
details see the license text delivered together with ${PRODUCTNAME} or http://www.libreoffice.org/license.html";>http://www.libreoffice.org/license.html
Why is ${PRODUCTNAME}
free for any user?
You can use this copy of
${PRODUCTNAME} today free of charge because individual contributors and
corporate sponsors have designed, developed, tested, translated, documented,
supported, marketed, and helped in many other ways to make ${PRODUCTNAME} what
it is today - the world's leading open-source office software.
If you appreciate their
efforts, and would like to ensure LibreOffice continues into the future, please
consider contributing to the project - see http://www.documentfoundation.org/contribution/";>http://www.documentfoundation.org/contribution/
for details. Everyone has a contribution to make.
Notes on
Installation
System
Requirements
MacOSX 10.4 (Tiger) or higher
Intel processor
512 MB RAM
Up to 1.5 GB available hard disk space
1024 x 768 graphic device with 256 colors (higher resolution
recommended)
Microsoft Windows 2000 (Service Pack 4 or higher), XP, Vista,
or Windows 7
Pentium compatible PC (Pentium III or Athlon recommended)
256 MB RAM (512 MB RAM recommended)
Up to 1.5 GB available hard disk space
1024x768 resolution (higher resolution recommended), at least
256 colors
Please be aware
[Libreoffice] Preventivo
TIPOGRAFIA e STAMPA DIGITALE www.milanoprinting.com Tel: 02 89 92 67 50 Gentile Cliente, Crediamo sia cosa gradita farvi pervenire questa nostra offerta relativa ai nostri stampati. E' una occasione da non perdere anche perche' potrete sfruttare questa offerta per tutto il 2010 a sola condizione che rispondiate allegando questa email, o chiamiate subito questo numero: 02 89.92.67.50 Alcuni esempi: 100 Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro15,00 500 Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro29,00 1000Biglietti da visita a colori f.to 85x55 mm solo fronte 4+0 Euro35,00 1000Biglietti da visita a colori f.to 85x55 mm fronte e retro 4+4 Euro60,00 250 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro60,00 500 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro88,00 5000 Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro150,00 1Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro250,00 15000Volantini stampati su carta patinata 15x21 cm (A5) stampa a colori Euro320,00 2Volantini stampati su carta patinata 15x21 cm (A5) atampa a colori Euro400,00 250 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro100,00 1000 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro189,00 2500 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro265,00 5000 Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro312,00 1Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro490,00 15000Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro670,00 2Pieghevoli a 2 o 3 ante f.to A4 stampa a colori su patinata Euro890,00 50 Opuscoli 8 pagine A5 chiuso stampa a colori cucitura punto metallico Euro120,00 100 Opuscoli 8 pagine A5 chiuso stampa a colori cucitura punto metallico Euro170,00 50 Opuscoli 8 pagine A4 chiuso stampa a colori cucitura punto metallico Euro140,00 100 Opuscoli 8 pagine A4 chiuso stampa a colori cucitura punto metallico Euro200,00 50 Opuscoli 16 pagine A4 chiuso stampa a colori cucitura punto metallico Euro200,00 100 Opuscoli 16 pagine A4 chiuso stampa a colori cucitura punto metallico Euro300,00 1000 Buste americane con o senza finestra stampate ad 1 colore (Nero) Euro49,00 1000 Buste a sacchetto con strip adesivo f.to 19x26 stampa 1 colore (Nero) Euro90,00 1000 Buste a sacchetto con strip adesivo f.to 23x33 stampa 1 colore (Nero) Euro126,00 1000 Buste a sacchetto con strip adesivo f.to 25x35 stampa 1 colore (Nero) Euro168,00 1 Spesa di corriere espresso in 24 ore su tutto il territorio nazionale Euro12,00 Tutti i prezzi in questa mail sono riferiti alla sola stampa da vostri file di stampa in alta risoluzione nei formati .pdf o eps , inoltre i prezzi si intendono al netto di IVA. Visitate il nostro sito dove troverete tutti i prezzi e le offerte del periodo. clicca qui: www.milanoprinting.com --- This e-mail was sent to libreoffice@lists.freedesktop.org because you are subscribed to at least one of our mailing lists. If at any time you would like to remove yourself from our mailing list, please feel free to do so by visiting: http://www.stampadai.com/list/public/unsubscribe.php?g=104&addr=libreoff...@lists.freedesktop.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Easy Hacks: Translation of Comments from German to English
On Mon, 15 Nov 2010 23:54:33 +0100, Daniel Di Marco wrote: PUSHED. Nice translations. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Clean code at writer [source/core/layout]
On Mon, Nov 15, 2010 at 01:05:43PM -0800, Kayo Hamid wrote: > Hello, please can someone review this? I do not known exactly what I need to > remove or not, so I'll known a bit more after someone reviewing it. > So I'll be able to clean better and at once. > I pushed it. Nice big chunk of dead code removed. Keep them coming :) D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion to expand user base: enable screenplay formatting with LibreOffice
Thanks, Michael. I was hoping it might be this simple. The template is less than 18K: http://extensions.services.openoffice.org/project/scr2 Bite-sized. ;-) And I really appreciate your support! -Alan >>Nov 15, 2010 9:21 AM, Michael Meeks michael.meeks at novell.com wrote: Pragmatically, if you can find a hacker who can knock up a patch that merges the template into the code-base; then - we tend to accept patches on the dev list [ assuming it doesn't add megabytes (compressed) ] to the suite [ which I assume it would not ]. I see no reason why it shouldn't go in - though, clearly not all special interests can do this - nevertheless the mroe templates we have, the more people we have interested in fixing our template browse / selection UI issues I hope ;-) HTH, Michael. >>On Sun, 2010-11-14 at 12:02 -0800, Alan C. Baird wrote: > > But it requires a template download and installation. If LibreOffice > wants to capitalize on this unique opportunity, the template could be > integrated in the upcoming LibreOffice release. --- original posting --- Re: [tdf-discuss] Suggestion to expand user base: enable screenplay formatting with LibreOffice Proposal for significantly enlarging LibreOffice's user base with Screenwright(R) 14 November 2010 by Alan C. Baird, prizewinning writer and creator of the Screenwright(R) screenplay formatter [winner of the Sun/OOo CIP award] http://w.9TimeZones.com/avails.htm http://extensions.services.openoffice.org/project/scr2 http://development.openoffice.org/awardees-2008.html Executive Summary: enable screenplay formatting in LibreOffice to distinguish it from OpenOffice. Pitch: Every aspiring screenwriter has a movie in his/her head that needs to get down on paper. However, some film production companies won't accept a script submission if the formatting is even ONE POSITION off! So ensuring that screenplays are formatted correctly is an obsession of screenwriters everywhere. But formatting a script can be an expensive proposition; 78 commercial formatters are listed at The Writers Store. A screenwriter could easily spend $200 or more on software, just to get a screenplay into acceptable shape. UNLESS s/he uses LibreOffice in conjunction with the Screenwright(R) screenplay formatting template. We all want our scripts to be eligible for the next multimillion-dollar spec auction, so some of us even carry our latest screenplays in our glove compartments, on the off-chance that we might meet someone who can help. In the movie "Monster In A Box," Spalding Gray talks about one of his trips to Los Angeles: «I had no idea how difficult it would be to find people not involved in the film industry until I got out there and saw a special on television - in which they were interviewing people in the parking lot of a Shop Rite supermarket. As people came out with their groceries, the interviewer would go up to them and say, "Hi there, good morning! Tell us, how's your film script going?" And everyone said, "What?! How did you know?" Right up to the cashier.» If the Screenwright(R) screenplay formatting template can be included as an integral part of the upcoming LibreOffice release, it will send a clear signal--to filmmakers in particular and to the Entertainment sector in general--that LibreOffice is ready to address the industry's unique text-processing and -formatting needs. News travels fast among members of the Entertainment industry, and they tend to be the gatekeepers and style leaders for the culture at large. Historical context: OOo Writer is the first (and for now, the only) full-featured word processor that will easily format a screenplay at no cost whatsoever. But it requires a template download and installation. If LibreOffice wants to capitalize on this unique opportunity, the template could be integrated in the upcoming LibreOffice release. Alan C. Baird Mesa, Arizona USA acba...@yahoo.com Extra: using your iPod to write screenplays. [You can also use your iPhone, thumb/flash drive, mp3 player, or favorite USB storage device.] It's a snap: A) At the bottom of your iPod's "Summary" tab in iTunes, check the "Enable disk use" box, and click the "Apply" button. B) Download and install the latest free OpenOffice.org (LibreOffice?) Portable suite on your iPod. http://portableapps.com/apps/office/openoffice_portable C) Download and install this free scr2.ott template on your iPod. When we stay in Tucson with my wife's friend--who has a Windows computer, but no Internet connection--I keep myself entertained by working on my latest screenplay or just kicking back and listening to some music (perhaps Mark Knopfler's Screenplaying). I can also use the iPod to revise my script on the public computers in: (1) my local library, (2) London's Heathrow airport, (3) Beijing's cyber-cafés, etc. PS: My iPod is one of the smallest models, an old 2GB Nano. I had already loaded nearly 18 hours of music (201 songs) and 33 photos onto it.
Re: [Libreoffice] Tab rename in Calc
On Mon Nov 15 2010 10:17:08 GMT-0800 (PST) Andy Brown wrote: On Mon Nov 15 2010 07:55:27 GMT-0800 (PST) Michael Meeks wrote: Personally I'm fine with that idea - of course, it is neater to have a "New sheet name" entry inside the Move/Copy sheet dialog I think; that is an easy enough hack. It would be great if you could add it to the 'Easy Hacks' section in the "Easy Programming Tasks" section - with a clear spec of what needs doing; it would be even better if you took the task on :-) working with VCL's resources there is quite a pain - and it'll increase the interest in Ricardo's new layout work I think. Kohei - if you object strongly - would be good to remove the Easy Hack / discuss :-) HTH, Michael. Michael, I will get it a shot at adding this to the Easy Hack wiki. Andy Michael, Got the item added to the wiki, http://wiki.documentfoundation.org/Development/Easy_Hacks#Change_Sheet_copy_process , not sure what else to add so please have a look and add what is needed. Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] RID_FRENCH_50_NAMES and RID_FRENCH_60_NAMES
Hi, I'm finishing a patch to add portuguese labels for symbols in starmath. In the file "symbol.src" exists two lists of labels for each language: RID_FRENCH_50_NAMES RID_FRENCH_60_NAMES RID_ITALIAN_50_NAMES RID_ITALIAN_60_NAMES and so on... What is the difference? Thanks, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Fw: [discuss] adding my company's label templates to OO
Ill like to know how to add label templates to libreoffice . we are a labels supplier located in singapore. thanks and regards eric - Original Message - From: "Dave Barton" Cc: "Eric Teng" ; ; Sent: Tuesday, November 16, 2010 4:43 AM Subject: Re: [discuss] adding my company's label templates to OO Original Message From: Eric Teng To: disc...@openoffice.org Date: Mon, 15 Nov 2010 18:44:03 +0800 hi OO, Ill like to know how to add label templates to OO just like avery and sigel. we are a labels supplier located in singapore. thanks and regards eric Hi Eric, You might also wish to contact the The Document Foundation to have templates for your labels included in the LibreOffice software. http://www.documentfoundation.org/ i...@documentfoundation.org Hope this helps. Dave ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
On Mon, 2010-11-15 at 16:06 -0500, Kohei Yoshida wrote: > On Mon, 2010-11-15 at 09:47 -0500, Kohei Yoshida wrote: > > If so, I'd say let's make this change on the > > master branch. > > Ok, done on master. Testing appreciated. One implementation note. I've implemented this by making changes to the ScCbWarningBox class which is a child class of WarningBox (from vcl) and is used only in the calc code. If this change makes sense to other similar warning dialogs used in other places (even in Writer, Draw, Impress etc), then it would make sense to move the logic up into the WarningBox class in vcl. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SvxHyperlinkDlg still used?
Hi Christoph, On Sat, 2010-11-13 at 01:15 +0100, Christoph Noack wrote: > A first look ... did that help anyhow? Yes, that helped a lot! :-) Thanks a lot for the very detailed analysis on this. If I read your analysis correctly, we can probably safely remove this without upsetting too many users. And based on the input from others on this thread removing this toolbar will not be missed, and the code is so old that it's probably not worth trying to salvage it for recycling. I just resurrected this item on the Easy Hacks page, and edited it to provide more hints. http://wiki.documentfoundation.org/Development/Easy_Hacks#Remove_obsolete_Hyperlink_Bar I look forward to having someone brave enough to step up for this task. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
On Mon, 2010-11-15 at 09:47 -0500, Kohei Yoshida wrote: > If so, I'd say let's make this change on the > master branch. Ok, done on master. Testing appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Clean code at writer [source/core/layout]
Hello, please can someone review this? I do not known exactly what I need to remove or not, so I'll known a bit more after someone reviewing it. So I'll be able to clean better and at once. cleancode-writer.source.core.layout.diff Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] AUTO: AUTO: Away from office (returning 11/19/2010)
I am out of the office until 11/19/2010. I am at the SC10 conference, with intermittent access to email. Note: This is an automated response to your message "LibreOffice Digest, Vol 3, Issue 157" sent on 11/15/10 9:33:33. This is the only notification you will receive while this person is away. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCHES] Eight "small" patches to remove trailing whitespaces from help
On Mon, Nov 15, 2010 at 02:08:52PM +0100, Jan Holesovsky wrote: > I am sorry, but as discussed previously [1], we would prefer not to fix > the trailing whitespace yet, until git with better merge strategies (to > handle whitespace changes flawlessly during merges) is released. Have you tried the ignore-all-space option of git merge-recursive, which was added recently in version 1.7.2? (It was released this summer.) pgpliNWu4ARih.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
Hello Santiago, On Mon, 2010-11-15 at 16:04 -0300, Santiago Bosio wrote: > El 15/11/10 11:47, Kohei Yoshida escribió: > > So, just to summarize this thread, we have three possible options for > > this: > > > > 1) no changes, > > 2) change the polarity of the current dialog so that the user *unchecks* > > the check box to dismiss future popups of the dialog, or > > 3) remove this entirely. > > > > And based on how I read all the inputs on this thread, 2) is the > > preferred solution by the vast majority of people. > > > > Is this a fair assessment? If so, I'd say let's make this change on the > > master branch. > > I just want to remind something that come to my mind while reading this. > This annoying dialog was introduced in OOo because it lacked the ability > to paste only to the visible cells. Thus, when you have hidden rows > and/or columns, and select a range to paste, hidden cells get its > contents replaced. Ah! It's certainly nice to know the rationale behind this popup. It brings more context to this subject. :-) > This dialog was sort of a temp solution until the "paste only to visible > cells" feature get implemented. I don't know if it was ever implemented > or not, I think it isn't, but would be a great feature to add, thus > giving the possibility to get rid of that dialog once and for all. I can tell you that you can now paste only to visible cells if those invisible cells were *filtered out* by autofilter, etc. But if you manually hide cells, data still gets pasted into those hidden cells. And I believe this behavior is intentional. My personal take on this is to let remove the dialog, and if necessary warn the user of overwritten cells in a less intrusive way and inform the user of the undo option if needed. I'm thinking of Christoph's blog entry http://luxate.blogspot.com/2010/11/non-modal-messages.html where he talks about non-modal messages. This may fit nicely into this scenario. Having said that, since we don't have this widget yet in LibreOffice, I'd say let's change the check box behavior for now, and re-visit this item if/when we have non-modal message widget available. Cheers, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] a few mixed patches to calc
On Mon, 2010-11-15 at 17:33 +0100, René Kjellerup wrote: > the highlights > translations of a few comments > removal of some dead code Nicely done. Pushed them all. :-) The only parts I didn't apply were the trailing space changes in the headers. I believe we are planning to fix that in all files in one go if I understand this correctly. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED]Re: Blinking cursor progress
Hi Luke, I'm very sorry, I should have had this done earlier. Most of it was > done Tuesday, but I had trouble building until today That's okay, take your time... Getting it to build after messing with something can be rather unpleasant... I think the patch looks great, I've pushed it... But when we need to draw a thin solid line under the visual line that the caret is in, we will probably need to pass a boolean value to SmCursor::Draw in SmGraphicWindow::Paint and from SmCursor::Draw to SmCaretDrawingVisitor... So that only the vertical line blinks, but the solid underline of the visual line doesn't blink... This is as opposed to not calling SmCursor::Draw in SmGraphicWindow::Paint which is what currently happens... By the way, I think that it's really cool that you found the setting for the caret blink timer... Nice work! - I still have ugly constants for handling key input... I allowed the initialization of the timer to take place whilst no checking > IsInlineEditEnabled(). I'm not sure if that is okay, or perhaps I could > think about working out whether it could be initialized if needed if not. I think that is great... initializing the timer can't hurt anybody... And if it's not initialized and the users activates visual editing during runtime, who knows what happens... - Well, probably nothing, but nothing isn't good either... These methods that I've made, would you prefer that I write a doxygen comment > for them? No, no, don't bother... Leaving them uncommented is fine for stuff of that size... And which such obvious names... I'm sending this patch to you, would you prefer I sent it instead to > the mailing list? As I've pushed the patch I don't think there's any reason to... (I've also CC'ed the list) Unless, somebody on the list suggests that we don't CC them, I suggest that we do... (still send to me, just, CC the list, or the other way around if you prefer that). Anyway, thanks for the patch, it's great and it works! :) If you would move the section about this hack from the Easy_Hacks page to the Easy_Hacks/Completed in the wiki, that would also be great... Let me know if you run out of interesting tasks, or get stuck, etc... -- Regards Jonas Finnemann Jensen. On Sun, Nov 14, 2010 at 23:08, Luke Dixon <6b8b4...@gmail.com> wrote: > Hello Jonas, > > I'm very sorry, I should have had this done earlier. Most of it was done > Tuesday, but I had trouble building until today (all of it was me > missing something obvious, please don't ask). > > I allowed the initialization of the timer to take place whilst not > checking IsInlineEditEnabled(). I'm not sure if that is okay, or perhaps > I could think about working out whether it could be initialized if > needed if not. > > These methods that I've made, would you prefer that I write a doxygen > comment for them? They are very small and simple, so I wasn't sure it > was worth it. > > I'm sending this patch to you, would you prefer I sent it instead to the > mailing list? > > > - Luke > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tab rename in Calc
On Mon Nov 15 2010 08:07:28 GMT-0800 (PST) Kohei Yoshida wrote: On Mon, 2010-11-15 at 15:55 +, Michael Meeks wrote: Hi Andy, On Mon, 2010-11-15 at 07:17 -0800, Andy Brown wrote: You are quite correct. I made the mistake by saying copy instead of move/copy. Currently if you right click and select move/copy sheet then click the copy box the sheet is renamed with a .# (.1,.2,.3 and so on). You then have to right click Rename or double click to change the name. Having the rename dialog open, even with the suggested .# name would save a couple of clicks. I have several spreadsheets that are updated at least monthly. I use the move/copy use the tab name as the date is was updated and having the rename dialog open would be great. Personally I'm fine with that idea - of course, it is neater to have a "New sheet name" entry inside the Move/Copy sheet dialog I think; that is an easy enough hack. Yes, that was my initial thought too. I prefer this to launching another modal dialog when dismissing the first modal dialog. Works for me. Save time in the process. It would be great if you could add it to the 'Easy Hacks' section in the "Easy Programming Tasks" section - with a clear spec of what needs doing; it would be even better if you took the task on :-) working with VCL's resources there is quite a pain - and it'll increase the interest in Ricardo's new layout work I think. Kohei - if you object strongly - would be good to remove the Easy Hack / discuss :-) Well, the only complication would be that calc also allows copying of multiple sheets when multiple sheets are selected, in which case we would need more than one sheet name input box. We need to decide how we need to handle this before going further. IMO this scenario somewhat complicates the matter, and I don't have a good solution to offer here, unfortunately. Kohei I had not though of this but your correct some planning needs to go into this. Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tab rename in Calc
On Mon Nov 15 2010 07:55:27 GMT-0800 (PST) Michael Meeks wrote: Hi Andy, On Mon, 2010-11-15 at 07:17 -0800, Andy Brown wrote: You are quite correct. I made the mistake by saying copy instead of move/copy. Currently if you right click and select move/copy sheet then click the copy box the sheet is renamed with a .# (.1,.2,.3 and so on). You then have to right click Rename or double click to change the name. Having the rename dialog open, even with the suggested .# name would save a couple of clicks. I have several spreadsheets that are updated at least monthly. I use the move/copy use the tab name as the date is was updated and having the rename dialog open would be great. Personally I'm fine with that idea - of course, it is neater to have a "New sheet name" entry inside the Move/Copy sheet dialog I think; that is an easy enough hack. It would be great if you could add it to the 'Easy Hacks' section in the "Easy Programming Tasks" section - with a clear spec of what needs doing; it would be even better if you took the task on :-) working with VCL's resources there is quite a pain - and it'll increase the interest in Ricardo's new layout work I think. Kohei - if you object strongly - would be good to remove the Easy Hack / discuss :-) HTH, Michael. Michael, I will get it a shot at adding this to the Easy Hack wiki. Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED Fix typo in Impress (i105883 and i102212)
Mattias Johnsson wrote: > Rename the custom animation "Put on the Breaks" to "Put on the Brakes". > > So here's a question - what do I do when I fix an OO.o issue that's in > the OO.o issue tracker, but not in the LO bugzilla? I suppose I can't > really comment there and say it's fixed, since they're not going to be > pulling the fix from LO, right? > Many thanks for the patch - applied only the part that changes the UI string, unfortunately the preset ids end up in the ODF file format, changing those would make OOo / LibO mutually not understand which ui preset has been used (could generally be worked-around, but I think in this case is not worth the effort). I've added a reference to i102212 in the commit log, Cedric has a patch and a greasemonkey script to overlay a "fixed in LibO" for the OOo issuezilla (http://cedric.bosdonnat.free.fr/wordpress/?p=727) Cheers, -- Thorsten pgpK0oj4Zl9AH.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tab rename in Calc
basically implement similar functionality like in excel where you can double click on the tab to rename it with a name that a user can understand. instead of sheet 1 etc On Mon, Nov 15, 2010 at 8:30 AM, Michael Meeks wrote: > Hi Andy / Jonathan, > > On Sat, 2010-11-13 at 09:52 +0100, Jonathan Aquilina wrote: > > On Sat, Nov 13, 2010 at 2:28 AM, Andy Brown wrote: > > I would like to make a request for Calc. When a 'sheet' is copied, > > why not have the rename box open like the double click? > > Can you explain the interaction you want in more detail. For me > right > clicking on a sheet tab and selecting 'copy' did something rather > count-intuitive (to me). > >Are you talking about the 'Move / Copy Sheet' dialog - having a > 'new name' entry so that can be changed ? > >Thanks, > >Michael. > > -- > michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot > > > -- Jonathan Aquilina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] More patches for Base
Hey Wols, >> On Wed, 10 Nov 2010 22:51:04 +, Wols Lists >> wrote: > By the way, is there an easy git command to squash two patches together? > > Cheers, > Wol Got to know about the git-squashing from Spaetz. Works really nice for me. Hope this helps :) [1] http://book.git-scm.com/4_interactive_rebasing.html -- regards Suren Learning < Doing Learn By doing. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] BmpColorMode removal from libs-gui
Hi Joseph, On Sat, 2010-11-13 at 07:32 -0800, Joseph Powers wrote: > Last night I submitted some patches to remove most of the code related to > BmpColorMode from libs-gui. Great :-) > The only remaining references are in: > > vcl/source/gdi/bitmap.cxx > vcl/inc/vcl/bitmap.hxx > vcl/source/gdi/bitmapex.cxx > vcl/inc/vcl/bitmapex.hxx > vcl/source/gdi/image.cxx > vcl/inc/vcl/image.h > vcl/source/gdi/impimage.cxx > > These items not only use the normal BMP_COLOR_NORAMAL & > BMP_COLOR_HIGHCONTRAST, > but also BMP_COLOR_MONOCHROME_BLACK & BMP_COLOR_MONOCHROME_WHITE. They also > have some bitmap transformation code. Riight; so - this is odd. In the abstract - there should be no monochrome display support in LibreOffice. To paraphrase my Product Manager: "It is an outrage that my phone is only 16bit color" So, clearly removing monochrome support is fine. > As far as I can determine, the MONOCHROME settings are never used outside > of bitmap.cxx & bitmapex.cxx. It leaks out in only one place here: vcl/source/gdi/impimage.cxx: ( ( nStyle & IMAGE_DRAW_MONOCHROME_BLACK ) ? BMP_COLOR_MONOCHROME_BLACK : BMP_COLOR_MONOCHROME_WHITE ); > The big quest is: is anyone attached to this code or can I just remove it? Please remove it. > I could also try to remove the BMP_COLOR_HIGHCONTRAST code from these > files and leave the other sections intact. We should (I think) also remove any other unused IMAGE_DRAW_ flags - AFAICS the nStyle parameter is almost never used there: bin/g grep IMAGE_DRAW_HIGHLIGHT # likewise, and 3DLOOK etc. IMHO we could perhaps clean all that up with a nice (proper) enum DISABLED / NORMAL and an nDrawDisabled param to the outdev DrawImage. As you see - the more you poke, the more cruft we find that can be chopped out happily :-) Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] a few mixed patches to calc
the highlights translations of a few comments removal of some dead code thanks René Kjellerup -- -- as life grows older, I gain experience. 0001-Comment-translation-and-removing-FASTBOOL-reference.patch Description: Binary data 0001-Macro-update-and-Comment-translation.patch Description: Binary data 0002-Removing-dead-code-in-ScDrawView.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] More patches for Base
Wols Lists wrote: > By the way, is there an easy git command to squash two patches together? > If you realize that your last commit was incomplete - use git commit --amend. That lumps your uncommitted changes into the last commit. Cheers, -- Thorsten pgpIIfl39x6mf.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
On Mon, 2010-11-15 at 09:47 -0500, Kohei Yoshida wrote: > 2) change the polarity of the current dialog so that the user > *unchecks* > the check box to dismiss future popups of the dialog, or Hi folks, Have been reading along quietly. +1 for that solution. Best wishes, Drew ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
At 9:47am -0500 Mon, 15 Nov 2010, Kohei Yoshida wrote: On Thu, 2010-11-11 at 17:21 -0800, Patrick Bakker wrote: COPY& PASTE TO A CELL WITH AN EXISTING VALUE The first time I copy and pasted a cell formula into another cell which already had something in it a dialog came up asking something like "This cell already has a value. Are you sure you want to do copy a new value in?" EXTREMELY annoying. So, just to summarize this thread, we have three possible options for this: 1) no changes, 2) change the polarity of the current dialog so that the user *unchecks* the check box to dismiss future popups of the dialog, or 3) remove this entirely. And based on how I read all the inputs on this thread, 2) is the preferred solution by the vast majority of people. Is this a fair assessment? If so, I'd say let's make this change on the master branch. Heh, I think the only dissenter was me, and I already pointed out that I don't know what I was smoking last week. :-) So yes, I believe you've made an accurate assessment. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Calc usability improvements
On Thu, 2010-11-11 at 17:21 -0800, Patrick Bakker wrote: > COPY & PASTE TO A CELL WITH AN EXISTING VALUE > > The first time I copy and pasted a cell formula into another cell > which already had something in it a dialog came up asking something > like "This cell already has a value. Are you sure you want to do copy > a new value in?" EXTREMELY annoying. So, just to summarize this thread, we have three possible options for this: 1) no changes, 2) change the polarity of the current dialog so that the user *unchecks* the check box to dismiss future popups of the dialog, or 3) remove this entirely. And based on how I read all the inputs on this thread, 2) is the preferred solution by the vast majority of people. Is this a fair assessment? If so, I'd say let's make this change on the master branch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCHES] Eight "small" patches to remove trailing whitespaces from help
Hi Niko, On 2010-11-13 at 10:24 +0200, Niko Rönkkö wrote: > All trailing whitespaces (spaces and tabs) removed from help repository. > In that place those really multiplies and quickly... > > Patches found in: > http://ronkko.wippiespace.com/LibO/ I am sorry, but as discussed previously [1], we would prefer not to fix the trailing whitespace yet, until git with better merge strategies (to handle whitespace changes flawlessly during merges) is released. Based on this, I cannot apply your patches, I am sorry :-( Do you think you would be interested in another Easy Hack? Eg. lots of people are involved in the RTL_CONSTASCII_USTRINGPARAM usage [2] these days... [1] http://lists.freedesktop.org/archives/libreoffice/2010-November/002309.html and the following messages in that thread [2] http://wiki.documentfoundation.org/Development/Easy_Hacks#Use_RTL_CONSTASCII_USTRINGPARAM_macro Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compile-time trickery to detect misuse of SAL_N_ELEMENTS, RTL_CONSTASCII_USTRINGPARAM, etc.
Michael Meeks wrote: > Does that mean we should use some of the boost system abstractions > instead of our own home-brewed ones where appropriate - perhaps ;-) - is > that what underlies the question ? clearly if they perform better it'd > be lovely - is there some low-hanging fruit here ? I was wondering if we > could inline & perhaps optimise out lots of atomic referencing > operations around the place :-) > Nah, this was prompted by the array-detection magic from Caolan, of which I was reminded of a nice boost::type_traits helper using a similar technique. No particular plans to replace anything - just a bunch of useful helpers we could now use at places ... -- Thorsten pgpD3X0nkqC9p.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] URE incompatibility?
On Mon, Nov 15, 2010 at 12:02:08PM +, Caolán McNamara wrote: > On Mon, 2010-11-15 at 12:50 +0100, Rene Engelhard wrote: > > but is that also the case for > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538? > > Dunno, doubt it. Do you have the build logs for that version ? You mean for OOo 3.2.1-8 (but that one "of course" is built against the 3.2.1 ure)? http://zyklop.dyndns.org/~rene/openoffice.org_3.2.1-8_amd64.build have none for LibO beta2-2 unfortunately, but beta3-1: http://zyklop.dyndns.org/~rene/libreoffice_3.3.0~beta3-1_amd64.build Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compile-time trickery to detect misuse of SAL_N_ELEMENTS, RTL_CONSTASCII_USTRINGPARAM, etc.
On Sun, 2010-11-14 at 20:21 +, Caolán McNamara wrote: > Unless I'm failing to see the obvious I wouldn't have a problem with > using boost in sal and friends, assuming we stick to the vast majority > of boost that don't require linking against specific boost libs. Sounds reasonable to me. I -believe- the intention (back in the day) was to have a plain C implementation to avoid compiler / dependency issues there: on the other hand, I no longer believe in a stand-alone future for UNO separate from LibreOffice, so we should do whatever works best for ourselves I think - ie. use boost where it makes sense (and in a tasteful way (cough) ;-) Does that mean we should use some of the boost system abstractions instead of our own home-brewed ones where appropriate - perhaps ;-) - is that what underlies the question ? clearly if they perform better it'd be lovely - is there some low-hanging fruit here ? I was wondering if we could inline & perhaps optimise out lots of atomic referencing operations around the place :-) Regards, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tab rename in Calc
Hi Andy / Jonathan, On Sat, 2010-11-13 at 09:52 +0100, Jonathan Aquilina wrote: > On Sat, Nov 13, 2010 at 2:28 AM, Andy Brown wrote: > I would like to make a request for Calc. When a 'sheet' is copied, > why not have the rename box open like the double click? Can you explain the interaction you want in more detail. For me right clicking on a sheet tab and selecting 'copy' did something rather count-intuitive (to me). Are you talking about the 'Move / Copy Sheet' dialog - having a 'new name' entry so that can be changed ? Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Icon/Image cleanup
Hi Ace, On Sat, 2010-11-13 at 23:56 +, Andrew C. E. Dent wrote: > Firstly - thanks for tackling this 'feature'. Great stuff! Really > excited about seeing this in a future release. > I have a few points to make, but will try to be brief: And thanks for your input too :-) I tend to agree that the mask color is an unfortunate anachornism, and a glogal removal would be a worthwhile project - can we spec. up an Easy Hack to build a list of all places it is used, and start going through them removing them :-) I liked all your suggestions except: > ooo_custom_images/hicontrast). If this is the case, it might be wise > to package the hicontrast theme (internally) as a tar archive Well - as you know, git compresses things rather well; unfortunately it can't compress things in archives ;-) so - if we simply move these into place, git will detect the movements and only store the artwork once - better, if the icons change, as we merge it will update the files in the new locations ;-) If by contrast we tar them up, we end up with a big, un-workable binary blob, that is then further attempted to be compressed: so we just bloat our git repo un-necessarily. I suggest we stick with an un-compressed icon set fo hicontrast. ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Suggestion needed for External Edit functionality.
surensp...@gmail.com wrote: > 1) Making it work in all OS/platforms: > [...] > Hi Suren, wow, great progress! For the editing, one easy way out would be to use the SystemShellExecute service, which will pick an app registered for the file type at hand. You can e.g. find a usage example in sfx2/source/dialog/about.cxx:298 A smallish nit regarding the move of lcl_GetPreferedExtension to a header - better rename it GetPreferedExtension, remove the static, have the declaration in the header - but keep the code inside a cxx. > 2) Undo/Redo Option: > Need to dig a bit more into how to add this functionality. > Have a look at e.g. sw/source/ui/shells/grfsh.cxx:238 > 3) Window repaint issue: > [...] > A rather blunt method is to call SwWrtShell::InvalidateWindows(), that basically forces a repaint of the given rectangular area. Would have to dig a bit for the Writer method du jour for this case, maybe the code from grfsh.cxx above has the right call already, e.g. UpdateFlyFrm() or somesuch. Keep going, this starts to look *really* nice! :) Cheers, -- Thorsten pgpNaMWzTRA8t.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] URE incompatibility?
On Mon, 2010-11-15 at 12:50 +0100, Rene Engelhard wrote: > but is that also the case for > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538? Dunno, doubt it. Do you have the build logs for that version ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] URE incompatibility?
Hi, On Mon, Nov 15, 2010 at 12:50:40PM +0100, Rene Engelhard wrote: > On Mon, Nov 15, 2010 at 11:40:37AM +, Caolán McNamara wrote: > > On Mon, 2010-11-15 at 11:40 +0100, Rene Engelhard wrote: > > > Hi, > > > > > > did we (intentionally? not intentionally?) break URE compatibility in > > > LibO 3.3 beta 2 (or earlier)? > > > > > > See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538 and > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603549 > > > > Maybe sb did that quite a while ago, see > > c37c9bf77d3ae02fb14b1d053e8c249a584f5e00 of jvmaccess/util/gcc3.map ? Is > > that it ? > > Maybe, but that commit message doesn't explain why those versions are gone > (and from reading the commit message and the issue I don't see it it > intended?) I probably should have cut'n'pasted it to that sb knows what that commit is: commit c37c9bf77d3ae02fb14b1d053e8c249a584f5e00 Author: sb Date: Fri Jan 29 17:01:54 2010 +0100 sb118: #i108776# changed addsym.awk to also export STLport num_put symbols, and simplified it by requiring that first section is labeled UDK_3_0_0; adapted map files accordingly, replacing many individual ones with solenv/src templates Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: Code cleanup in SW includes
On Sun, 2010-11-14 at 08:44 +0200, Robert Roth wrote: > Some more comments and commented code removed, some german comments > translated. code co- licensed under > LGPLv3+, GPLv3+ and MPL. > Feedback is welcome. Looks good, there was some other changes since you made that patch, so it didn't completely apply, but fixed up some conflicts and pushed the results. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] URE incompatibility?
On Mon, Nov 15, 2010 at 11:40:37AM +, Caolán McNamara wrote: > On Mon, 2010-11-15 at 11:40 +0100, Rene Engelhard wrote: > > Hi, > > > > did we (intentionally? not intentionally?) break URE compatibility in > > LibO 3.3 beta 2 (or earlier)? > > > > See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538 and > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603549 > > Maybe sb did that quite a while ago, see > c37c9bf77d3ae02fb14b1d053e8c249a584f5e00 of jvmaccess/util/gcc3.map ? Is > that it ? Maybe, but that commit message doesn't explain why those versions are gone (and from reading the commit message and the issue I don't see it it intended?) Anyway, that is for http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603549, but is that also the case for http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538? Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] URE incompatibility?
On Mon, 2010-11-15 at 11:40 +0100, Rene Engelhard wrote: > Hi, > > did we (intentionally? not intentionally?) break URE compatibility in > LibO 3.3 beta 2 (or earlier)? > > See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538 and > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603549 Maybe sb did that quite a while ago, see c37c9bf77d3ae02fb14b1d053e8c249a584f5e00 of jvmaccess/util/gcc3.map ? Is that it ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] URE incompatibility?
Hi, did we (intentionally? not intentionally?) break URE compatibility in LibO 3.3 beta 2 (or earlier)? See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603538 and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603549 Grüße/Regards, René ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Preferred indentation for LibreOffice
Ok, thank you all, i will use it. ;-) Júlio. 2010/11/15 Takeshi Abe > Hi, > > On Mon, 15 Nov 2010 01:15:24 -0700, "Tor Lillqvist" > wrote: > > Details concerning the preferred use of white space around parentheses in > function calls etc, placement of braces, etc, can be learned by looking at > existing source files. For Emacs users, there is also elisp code available > in the OOo wiki, I think it was, to set up an Emacs hook for proper handling > of OOo/LO source files. > Do you mean this ooo-c-style?: > http://wiki.services.openoffice.org/wiki/Editor_Emacs > Can we consider that it is adequate for LO too? > > Cheers, > -- Takeshi Abe > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix the last commit in build repository.
Hi Sebastian, Sebastian Spaeth wrote: On Sat, 13 Nov 2010 16:09:26 +0100, Giuseppe Castagno wrote: --- a/bin/install-artwork +. bin/setup While that patch might fix things, I believe a script in ./bin should not assume anything about what the current working directory is. We should either use a relative directory, relative to the script location. Or we should source some configuration file created by ./configure to read in the relevant directories. I think you are right, I attached a revised version of the patch. I believe this one is a little better, unless I'm completely wrong and the entire ef57e0668c2171036759f244a8bb6b6cc753f594 commit should be reverted for some other reason... beppec56. -- Kind Regards, Giuseppe Castagno Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu beppec56 at openoffice.org >From 932e360a71a2175a2dccdf0fde1e7a2c169b9e54 Mon Sep 17 00:00:00 2001 From: Giuseppe Castagno Date: Sat, 13 Nov 2010 16:02:56 +0100 Subject: [PATCH] Fix for commit ef57e0668c2171036759f244a8bb6b6cc753f594. File sourced outside install-artwork. --- Makefile.am |2 +- bin/install-artwork |2 -- 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index b9da4ee..63a92cf 100644 --- a/Makefile.am +++ b/Makefile.am @@ -53,7 +53,7 @@ $(STAMP_DIR)/artwork.install : $(OOBUILDDIR)/unpack \ $(STAMP_DIR)/prebuild \ $(wildcard $(top_srcdir)/src/*.png) \ $(wildcard $(top_srcdir)/src/*.bmp) - $(TOOLSDIR)/bin/install-artwork $(top_srcdir)/src $(OOBUILDDIR) + . $(TOOLSDIR)/bin/setup $(TOOLSDIR)/bin/install-artwork $(top_srcdir)/src $(OOBUILDDIR) touch $@ patch.apply: $(OOBUILDDIR)/unpack $(STAMP_DIR)/refresh $(STAMP_DIR)/patch.apply diff --git a/bin/install-artwork b/bin/install-artwork index cbb314d..be73b4d 100755 --- a/bin/install-artwork +++ b/bin/install-artwork @@ -1,7 +1,5 @@ #!/bin/sh -. ./setup - # installs artwork, opportunistically from src to dest src=$1 -- 1.6.3.3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Preferred indentation for LibreOffice
Hi, On Mon, 15 Nov 2010 01:15:24 -0700, "Tor Lillqvist" wrote: > Details concerning the preferred use of white space around parentheses in > function calls etc, placement of braces, etc, can be learned by looking at > existing source files. For Emacs users, there is also elisp code available > in the OOo wiki, I think it was, to set up an Emacs hook for proper handling > of OOo/LO source files. Do you mean this ooo-c-style?: http://wiki.services.openoffice.org/wiki/Editor_Emacs Can we consider that it is adequate for LO too? Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Preferred indentation for LibreOffice
> /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ > This will be the preferred style for LibreOffice project? Those settings are not by themselves enough to describe the traditional OOo, and thus also LibreOffice, coding style, but they do express (I believe; I am not a vim user) the ground rules: four column indentation "steps" or "offset", and no TABs in source files. Using an appropriate number of spaces instead of actual TAB characters in the source files is very much preferred, and using spaces for indentation is actually enforced by our git hooks. And, if/when TAB characters still appear in source files, they should be interpreted as tabulating to the next multiple of four columns. (Note: saying "TABs expand to four spaces" is over-simplifying and incorrect (although presumably people who say that don't actually mean it literally); the number of spaces (or other characters, for that matter) needed to reach the next multiple of four columns obviously depends on the column you are at. And obviously, all talk about "columns" assume a typewriter-style fixed-width typeface is used.) Details concerning the preferred use of white space around parentheses in function calls etc, placement of braces, etc, can be learned by looking at existing source files. For Emacs users, there is also elisp code available in the OOo wiki, I think it was, to set up an Emacs hook for proper handling of OOo/LO source files. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
