Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.

[Norbert Thiebaud]

On Fri, Jan 28, 2011 at 6:06 PM, David Dumaresq dfdumar...@gmail.com wrote:

 On 2011-01-28, at 12:03 PM, Caolán McNamara wrote:

 On Fri, 2011-01-28 at 09:59 -0800, David Dumaresq wrote:
 On 2011-01-28, at 4:02 AM, Caolán McNamara wrote:


 This is the problem, you should have a smen-US.res in there, and you
 don't. This is the same problem Norbert reports, rsc should call rsc2
 which should have put one in there, but this is apparently failing
 silently, but only on MacOSX.

 I've tried $ find . -name smen-US.res -ls and the file smen-US.res does not 
 exist in my git/libo directory.

smen-US.res should be generated during the build in starmath/unx*.pro/bin/.

on mac that seems to fail recently.



 Personally I suspect some tmpdir foo.

 Sorry, I'm a newbie and not sure what you mean, unless it's that you suspect 
 a temp dir is contaminating my build.

he means related to how rsc2 (the program that generate the res file)
do some scary and fragile acrobatics with temp files... and that may
be the culprit...

Norbert



 C.


 Any suggestions?

 Thanks,
 Dave

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] easyhacks: remove bogus comments

[Suguru Hirahara]

Hello,

some comments related with revision control were removed. Please
review the patch attached.

released under LGPLv3+ / MPL.
-- 
suguru hirahara luixx...@gmail.com


0001-easyhacks-remove-bogus-comments.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Installation instructions for source code release

[Francois Tigeot]

Hi,

Thanks everyone for your answers.

On Fri, Jan 28, 2011 at 10:03:42AM +, Michael Meeks wrote:
 
 On Fri, 2011-01-28 at 10:27 +0100, Francois Tigeot wrote:
  Well, I may become a package maintainer in the future but for that I need
  to be able to build LO from the released sources first.
 
   Sure ;-) so what I suggest you do is take a look at eg. Rene's debian
 packages, or Caolan's RedHat ones - that do a straight-through build,
 and get inspired by them ;-) try here:
 
   http://pkgs.fedoraproject.org/gitweb/?p=libreoffice.git;a=tree

Eric Hameleers from Slackware has also some interesting scripts:
http://connie.slackware.com/~alien/slackbuilds/libreoffice/build/libreoffice.SlackBuild

  Git is fine for real development but I'm afraid it may be too steep for
  me now; I'd like to play it safe, try to build a somewhat stable version
  without too much bugs. Maybe write a patch or two if something doesn't work.
 
   Sure, sure - but I think you will find (with the pace of change), that
 working on master is better: it is already easier to build master than
 'stable' (though it does break occasionally), and it is far easier to
 create a patch to submit from git: g diff will extract all your
 changes, vs. having to do some diff -r's :-)

In the end, I could not build LO from the released tarballs. I have bitten
the bullet and now use git ;)
I'll send my first patch in a separate mail.

   Sure - and we are trying to fill out this niche; primarily by moving
 (slowly) towards a split build [ in fact openSUSE does this already ],
 whereby you can re-build and develop only one piece at a time - which is
 quicker: ie. just re-compile 'writer'.

That sure would be great ! I remember painfully 15-hours compilation times
in the days of OpenOffice 2.x ...

   Which is (at root) the background as to why there are so many things to
 download ;-) - just a result of that work being in progress still.

Is there any explanation on this process ? I've only found small notes
in the wiki.

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Add support for DragonFly in configure.in

[Francois Tigeot]

This patch adds support for DragonFly to bootstrap/configure.in

DragonFly is a BSD-derived operating system:
http://www.dragonflybsd.org/

-- 
Francois Tigeot
diff --git a/configure.in b/configure.in
index be8aa6c..e5b94fe 100755
--- a/configure.in
+++ b/configure.in
@@ -1530,6 +1530,15 @@ case $host_os in
 PTHREAD_LIBS=-pthread
 _os=OpenBSD
 ;;
+dragonfly*)
+test_gtk=yes
+build_gstreamer=yes
+test_kde=yes
+test_kde4=yes
+test_freetype=yes
+PTHREAD_LIBS=-pthread
+_os=DragonFly
+;;
*)
AC_MSG_ERROR([$_os operating system is not suitable to build LibreOffice!])
;;
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] (no subject)

[Jean-Francois Willem]

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Utility to scan for some faults in Thesaurus files

[Steve Butler]

Hi,

The l10n guys said they needed this utility in git as their list does
not allow attachments.  I will leave it up to your wisdom as to where
to put it.

A brief description of what it does:
I have made some assumptions about the file format to look for the
common errors I found:
1. A line that starts with 1 or more characters followed by a |, then
only digits to EOL is a word definition.
2. A line that starts with either ( or - is a synonym definition.
This may not be a valid assumption as I've seen lines that start with
interj that were definitely synonym definitions.  I am not sure what
interj means in th_ro_RO_v2.dat so I have special cased interj and
prep to also be a synonym line, but still complain about them.

I'm not sure if the inconsistency in naming is related to l10n issues or
just an inconsistency so I've left it on nag for now.

With these assumptions the script compares the expected number of
synonyms with the actual number of synonyms and complains if they
don't match (with word and line numbers displayed for the definition).

It will also complain if it finds the same word more than once and
will print out both lines on which the suspect word was found.

I hope this helps - the script finds no issues in a number of
dictionaries, but output this many informational lines for the
following dictionaries in my libreoffice build tree:
   138 th_ca_ES_v3.dat
  1092 th_de_AT_v2.dat
  1101 th_de_CH_v2.dat
  1092 th_de_DE_v2.dat
 2 th_hu_HU_v2.dat
 6 th_ne_NP_v2.dat
  2582 th_ro_RO_v2.dat
 8 th_ru_RU_v2.dat
15 th_sk_SK_v2.dat

I hope this helps.  The perl script is MPL 1.1 / GPLv3+ / LGPLv3+ as
per the header.

Regards,
Steven Butler


th_check.pl
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Installation instructions for source code release

[Enrico Weigelt]

* Michael Meeks michael.me...@novell.com schrieb:

   Sure - and we are trying to fill out this niche; primarily by moving
 (slowly) towards a split build [ in fact openSUSE does this already ],
 whereby you can re-build and develop only one piece at a time - which is
 quicker: ie. just re-compile 'writer'.

The clean answer is to actually split the whole monster into
smaller packages, which can be built an deployed completely separately.

Just had a look at the 'bootstrap' tree: it contains a full copy
of dmake (even worse: with utogenerated files ;-o) - that would be
my firt candidate for being kicked out. Generic buildtools should
never be bundled into individual application's source trees.


cu
-- 
--
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 phone:  +49 36207 519931  email: weig...@metux.de
 mobile: +49 151 27565287  icq:   210169427 skype: nekrad666
--
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
--
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)

[Steve Butler]

Hi Michael,


        Then 'mythes' seems to be used in lingucomponent/ somewhere - I suppose
 that is where to be digging for the user code. I suspect if we can read
 and index this file in two seconds - and it is used in response to user
 input - there may not really be a lot of value in indexing it ahead of
 time, but ... ;-) worth playing with that.

I haven't had a look at this yet as I thought getting a script to
analyze the existing thesaurus files would be helpful to get those
errors looked at.

I thought I would discuss your idea about not using the index at all
to see what reception it gets, but I think you may also have been
suggesting a similar thing:
are the index files even useful on modern gear?

I can populate the en_US index in memory from the .dat file with the
C++ code in 0.287 s after dropping all cache, and 0.188s when the
cache is hot.

I do admit that my desktop is pretty quick though, with 4 cores, SATA
II drives etc.

If the thesaurus is only loaded when the user pops it up, then
couldn't mythes be taught to generate its own in-memory index
from the dictionary and not bother with an index file at all?

BTW, if I did that I'd probably do some major surgery on mythes and
just use STL because it basically is doing C style memory management
and processing and I think I would screw it up if I started messing
with it.  The only problem with simplifying it with STL constructs is
that I would want to change the interface (string vs char *), maybe
use STL vectors for the list of synonyms, etc.

By this stage it's not looking much like mythes anymore ...

Regards
Steven Butler
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] remove unused declaration - an unlikely fix for armel segfault in regcomp

[Caolán McNamara]

On Thu, 2011-01-27 at 20:13 +0200, Jani Monoses wrote:
 What about using GCC atomic builtins like in the attached patch?

Excellent, the pthread fallback always niggled me.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Kicking off 3rdparty packages

[Enrico Weigelt]

Hi folks,


one of the things which always unnverved me most in OO is the fact
that it ships own copies of dozens of standard 3rd-party packages,
often very outdated and patched-to-death. Obviously this is a 
nightmare for package engineering.

I'm currently in process of identifying those and investigating
how we can get rid of them. So far I've found eg. ico, expat,
dmake, openssl, and many more (probably everything in libs-extern
and libs-extern-sys).

We'll still have to go a long way to get that mess cleaned up,
but we should start now.


cu
-- 
--
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 phone:  +49 36207 519931  email: weig...@metux.de
 mobile: +49 151 27565287  icq:   210169427 skype: nekrad666
--
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
--
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Easy hacks: remove double line spacing

[Guillaume]

Le samedi 29 janvier 2011 à 01:31 +0100, Jonathan Aquilina a écrit :
 On 1/29/11 12:28 AM, Guillaume wrote: 
  Hi, I removed some empty lines in few files for my first patch.
  I'll continue if it's ok.
  
  Regards
  Guillaume
  
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
 Hey guillaume the file you have done could you cross it off the easy
 hack list for this easy hack. there is a link on the bottom of this
 easy hack.
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

I would, but the patch is not pushed.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 32894] [Task] LibreOffice 3.3.1 release blockers / stoppers

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32894

Bug 32894 depends on bug 33249, which changed state.

Bug 33249 Summary: LibreOffice redirect contributors to OpenOffice.org.
https://bugs.freedesktop.org/show_bug.cgi?id=33249

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] In need of windows packaging team...

[Markus Stenzel]

Hi all,

 

can anyone please send me contact information of the Windows packaging team? 
And just in case they’re reading this list:

 

I’m badly in need of a smaller setup supporting German language (only) for 
inclusion on a free tool CD aimed at students, the CD ‘OpenSource im 
Studium’[1]. I have tried fiddling around with the setup using a Microsoft tool 
but this of course only results in a defective setup with a broken signature. J

 

The CD is already filled with important tools and there is only 153 MB left for 
LO.

 

And no, DVD and links to the download page is not an option. Also removing 
other tools is not an option as well. J

 

[1]  http://www.hostingundservice.de/opensource-im-studium/ 
http://www.hostingundservice.de/opensource-im-studium/

 

 

  Markus Stenzel

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Easy hacks: remove double line spacing

[Jonathan Aquilina]

On 1/29/11 3:42 PM, Guillaume wrote:

Le samedi 29 janvier 2011 à 15:27 +0100, Jonathan Aquilina a écrit :

On 1/29/11 2:45 PM, Guillaume wrote:

Le samedi 29 janvier 2011 à 01:31 +0100, Jonathan Aquilina a écrit :

On 1/29/11 12:28 AM, Guillaume wrote:

Hi, I removed some empty lines in few files for my first patch.
I'll continue if it's ok.

Regards
Guillaume

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hey guillaume the file you have done could you cross it off the easy
hack list for this easy hack. there is a link on the bottom of this
easy hack.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

I would, but the patch is not pushed.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Pushed or not please cross it off the list so we know that it has been done.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Done !

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Ty it helps keep track of whats been done and avoids any duplication of 
patches :)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] How to use gprof on LibO?

[Soeren Moeller]

Hi

In our effort of replacing deprecated data types from tools/ by std::
types we would like to use gprof for profiling (to choose the right
data types). But unfortunately, we don't know to set the -pg flag, and
where the gmon.out file would go. Has anyone of you experiences with
profiling LibO, and would like to tell us, how to do?

Best regards
Sören
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Easy hacks: remove double line spacing

[Guillaume]

Le samedi 29 janvier 2011 à 15:42 +0100, Jonathan Aquilina a écrit :
 On 1/29/11 3:42 PM, Guillaume wrote:
  Le samedi 29 janvier 2011 à 15:27 +0100, Jonathan Aquilina a écrit :
  On 1/29/11 2:45 PM, Guillaume wrote:
  Le samedi 29 janvier 2011 à 01:31 +0100, Jonathan Aquilina a écrit :
  On 1/29/11 12:28 AM, Guillaume wrote:
  Hi, I removed some empty lines in few files for my first patch.
  I'll continue if it's ok.
 
  Regards
  Guillaume
 
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
  Hey guillaume the file you have done could you cross it off the easy
  hack list for this easy hack. there is a link on the bottom of this
  easy hack.
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
  I would, but the patch is not pushed.
 
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
  Pushed or not please cross it off the list so we know that it has been 
  done.
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
  Done !
 
  ___
  LibreOffice mailing list
  LibreOffice@lists.freedesktop.org
  http://lists.freedesktop.org/mailman/listinfo/libreoffice
 Ty it helps keep track of whats been done and avoids any duplication of 
 patches :)
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

Right ! An up to date easy tasks list is a good thing.
But it will not be correct if my patch is not pushed.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Commented out some unused functions in calc

[Alfonso Eusebio]

Hi,

I've been going through the list of identified unused functions in calc and 
commenting out those that don't seem to be used anywhere.
Attached is the patch (LGPLv3+/MPL) that comments out some 10 functions and a 
text file with those investigated so far, and the results.

I chose to comment out, rather than delete, to allow for some extra testing 
once 
it's committed. Commented functions can be easily identified later on and 
removed.
Please let me know if direct removal would be preferred.

After committing my changes locally I've built module sc and done a make 
dev-install. Everything seems to be working fine, but the test wasn't 
exhaustive.
The changes have been rebased with current master.

There are a few functions that belong to some addin mechanism now obsolete. 
I'm not sure if it can be removed completely, but it looks like a good 
candidate 
(details in attached text file).

Thanks  regards,
Alfonso


  From ad7008e740baf43ebad80a3be2f50b5fe73e584a Mon Sep 17 00:00:00 2001
From: Alfonso Eusebio alfonso_euse...@yahoo.co.uk
Date: Sat, 29 Jan 2011 13:42:07 +
Subject: [PATCH] Commented out some unused functions in calc

Commented out some unused functions in calc before proceeding to final removal.
---
 sc/inc/compressedarray.hxx |6 --
 sc/source/core/data/attarray.cxx   |1 -
 sc/source/core/data/compressedarray.cxx|8 
 sc/source/filter/excel/xipivot.cxx |9 ++---
 sc/source/filter/excel/xistream.cxx|9 ++---
 sc/source/filter/excel/xltracer.cxx|3 ++-
 sc/source/filter/inc/XclImpChangeTrack.hxx |5 +++--
 sc/source/filter/inc/xipivot.hxx   |4 ++--
 sc/source/filter/inc/xistream.hxx  |6 +++---
 sc/source/filter/inc/xltracer.hxx  |3 ++-
 10 files changed, 32 insertions(+), 22 deletions(-)

diff --git a/sc/inc/compressedarray.hxx b/sc/inc/compressedarray.hxx
index efc5cd7..941ae1a 100644
--- a/sc/inc/compressedarray.hxx
+++ b/sc/inc/compressedarray.hxx
@@ -477,18 +477,20 @@ public:
 
 /** Sum values of a ScSummableCompressedArray for each row where in *this*
 array the condition is met: ((aValue  rBitMask) == rMaskedCompare). */
+/* [AE] seems unused - commenting out for now
 template typename S 
 SC_DLLPUBLIC unsigned long   SumCoupledArrayForCondition( A nStart, A nEnd,
 const D rBitMask, const D rMaskedCompare,
-const ScSummableCompressedArrayA,S rArray ) const;
+const ScSummableCompressedArrayA,S rArray ) const;*/
 
 /** Sum scaled values of a ScSummableCompressedArray for each row where in
 *this* array the condition is met: ((aValue  rBitMask) == rMaskedCompare). */
+/* [AE] seems unused - commenting out for now
 template typename S 
 SC_DLLPUBLIC unsigned long   SumScaledCoupledArrayForCondition( A nStart, A nEnd,
 const D rBitMask, const D rMaskedCompare,
 const ScSummableCompressedArrayA,S rArray,
-double fScale ) const;
+double fScale ) const; */
 };
 
 
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index bd52f4b..bb411ab 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -1183,7 +1183,6 @@ long lcl_LineSize( const SvxBorderLine rLine )
 return nTotal;
 }
 
-
 BOOL ScAttrArray::HasLines( SCROW nRow1, SCROW nRow2, Rectangle rSizes,
 BOOL bLeft, BOOL bRight ) const
 {
diff --git a/sc/source/core/data/compressedarray.cxx b/sc/source/core/data/compressedarray.cxx
index 1c4d8bd..b935f40 100644
--- a/sc/source/core/data/compressedarray.cxx
+++ b/sc/source/core/data/compressedarray.cxx
@@ -515,7 +515,7 @@ A ScBitMaskCompressedArrayA,D::GetLastAnyBitAccess( A nStart,
 return nEnd;
 }
 
-
+/* [AE] seems unused - commenting out for now
 template typename A, typename D 
 template typename S 
 unsigned long ScBitMaskCompressedArrayA,D::SumCoupledArrayForCondition(
@@ -549,7 +549,6 @@ unsigned long ScBitMaskCompressedArrayA,D::SumCoupledArrayForCondition(
 return nSum;
 }
 
-
 template typename A, typename D 
 template typename S 
 unsigned long ScBitMaskCompressedArrayA,D::SumScaledCoupledArrayForCondition(
@@ -582,7 +581,7 @@ unsigned long ScBitMaskCompressedArrayA,D::SumScaledCoupledArrayForCondition(
 (rArray.GetDataEntry(rArray.GetEntryCount()-1).aValue * fScale) *
 (nEnd - this-nMaxAccess);
 return nSum;
-}
+} */
 
 
 // === ScCompressedArrayIterator =
@@ -694,13 +693,14 @@ template class ScCompressedArray SCROW, USHORT;   // heights, base cla
 template class ScSummableCompressedArray SCROW, USHORT;   // heights
 template class ScCompressedArray 

Re: [Libreoffice] Kicking off 3rdparty packages

[Tor Lillqvist]

 it ships own copies of dozens of standard 3rd-party packages,

standard from the viewpoint of up-to-date Linux distros, that is. Don't 
forget that LibreOffice is supposed to run also on not-so-up-to-date Linux 
installations. (As far as I know, the generic Linux build of LibreOffice is, or 
am I confusing with go-oo times?)

And of course, various other Unixes too (although I don't know if we have any 
active builders/packagers except for BSDs), on which one can be even les sure 
that there are up-to-date standard 3rd-party packages available.

And then there is Windows.

In general, isn't a LibreOffice purpose-built for some modern Linux distro 
*already* using the system copies of these libraries, not its own copies?

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

[Jonas Finnemann Jensen]

Hi Luke,


 Really sorry for not giving this any attention for so long.

No worry... I've been busy with exams for the most of January...
Though, I hope I had a break through with the newline-? bug, yesterday...

Removing the brackets from the SmOperNodes was a pretty bad, so they can
 just go back in.

Nice :)

Removing them from UnHor and BinHor also broke some stuff, however, I
 didn't want to add them back in here, so decided that I would add them
 with the other nodes types that they were breaking with which seemed to
 be BinVer nodes (also the BinDiagonal which is similar).

Okay, sounds like a great solution... That way we don't get too many
brackets...

Some of the tests are the same kind as the one from last time. It can be
 a bit difficult to get the right node tree for the test from the parser,
 which also seems to put in more expression nodes than doing it with the
 cursor, which confused me for a bit.

Really neat... Now we'll also get failures if we mess up in cursor...

--
Regards Jonas Finnemann Jensen.


On Sat, Jan 29, 2011 at 14:01, Luke Dixon 6b8b4...@gmail.com wrote:

 Hi Jonas,

 Really sorry for not giving this any attention for so long.

   I've noticed other stuff I've messed up though, so I'm going to
 continue
   on this some more :)
  Again I'm not sure you messed it up... It might as well have been
  messed up the first time I wrote it...
  But don't let that stop you from fixing it...

 I'm pretty sure I messed some of it up quite badly, I've attached a
 patch that adds some of the brackets back in.

 Removing the brackets from the SmOperNodes was a pretty bad, so they can
 just go back in.

 Removing them from UnHor and BinHor also broke some stuff, however, I
 didn't want to add them back in here, so decided that I would add them
 with the other nodes types that they were breaking with which seemed to
 be BinVer nodes (also the BinDiagonal which is similar).

 Some of the tests are the same kind as the one from last time. It can be
 a bit difficult to get the right node tree for the test from the parser,
 which also seems to put in more expression nodes than doing it with the
 cursor, which confused me for a bit.

 Regards,
 Luke



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Installation instructions for source code release

[Caolán McNamara]

On Sat, 2011-01-29 at 12:33 +0100, Enrico Weigelt wrote:
 Just had a look at the 'bootstrap' tree: it contains a full copy
 of dmake (even worse: with utogenerated files ;-o) - that would be
 my firt candidate for being kicked out. Generic buildtools should
 never be bundled into individual application's source trees.

This particular dmake isn't really a generic dmake. Its a rather odd
make-style utility which has been hacked quite a bit from its original
root.

The preferred solution here is to move everything over to gnumake. I
think the work on doing this if fairly advanced and in one of Norberts
git branches and the moment.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kicking off 3rdparty packages

[Rene Engelhard]

Hi,

On Sat, Jan 29, 2011 at 04:59:27PM +0100, Rene Engelhard wrote:
 On Sat, Jan 29, 2011 at 08:36:35AM -0700, Tor Lillqvist wrote:
   it ships own copies of dozens of standard 3rd-party packages,
  
  standard from the viewpoint of up-to-date Linux distros, that is. Don't 
  forget that LibreOffice is supposed to run also on not-so-up-to-date Linux 
  installations. (As far as I know, the generic Linux build of LibreOffice 
  is, or am I confusing with go-oo times?)
 
 Nah, there's also various internal libs so old that they were even outdated
 years ago (zlib for example)

sent to early. I also wanted to mention what consequences this can have:

*ANY* upload to Debian containing a internal zlib will be automatically 
rejected. And
TTBOMK there's no way to get anything with internal zlib into Debian as the 
error
is not overridable.

And that#s pure because zlib gets security issues often - and you wouldn't want 
to touch
all packages using zlib. The same argument applies to all of the other 
libraries, too.
3.3.0 picked up libxml2 and xpdf (using xpdf is a bug anyway, poppler should be 
used) fixes
for internal libraries...

Grüße/Regards,
 
René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  r...@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kicking off 3rdparty packages

[Rene Engelhard]

Hi,

On Sat, Jan 29, 2011 at 08:36:35AM -0700, Tor Lillqvist wrote:
 And of course, various other Unixes too (although I don't know if we have any 
 active builders/packagers except for BSDs), on which one can be even les sure 
 that there are up-to-date standard 3rd-party packages available.

Well, they have ports with (more or less) uptodate libs. That's the *exact*
same situation as on Linux distros. Just packages vs. ports.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  r...@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kicking off 3rdparty packages

[Francois Tigeot]

On Sat, Jan 29, 2011 at 08:36:35AM -0700, Tor Lillqvist wrote:
  it ships own copies of dozens of standard 3rd-party packages,
 
 standard from the viewpoint of up-to-date Linux distros, that is. Don't 
 forget that LibreOffice is supposed to run also on not-so-up-to-date Linux 
 installations.
 
 And of course, various other Unixes too (although I don't know if we have any 
 active builders/packagers except for BSDs), on which one can be even les sure 
 that there are up-to-date standard 3rd-party packages available.

Up-to-date software can also be used on old Unixes / Linux systems without too
much pain.
In some of my previous jobs, I had to manage software installations for systems
running such things as OSF/1, AIX, Solaris/Sparc, Irix, etc...

There are all sorts of solutions:

- using the vendor framework (if they still care/are alive)
- installation by hand (configure / make / make install)
- lightweight management with tools such as stow:
  http://unmaintainable.wordpress.com/2007/01/14/package-management-using-stow/
- using a third-party framework. Two of them come to mind:
  - OpenPKG http://www.openpkg.org/
  - pkgsrc  http://www.netbsd.org/docs/software/packages.html#platforms

IMHO, there's no reason to include old versions of third-party packages in
LibreOffice proper.

In addition to all the included junk, I remember OpenOffice needing a
special-purpose version of gcc to be compiled.

Should we go the same path again ?

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kicking off 3rdparty packages

[Enrico Weigelt]

* Francois Tigeot ftig...@wolfpond.org schrieb:

 There are all sorts of solutions:
 
 - using the vendor framework (if they still care/are alive)
 - installation by hand (configure / make / make install)
 - lightweight management with tools such as stow:
   
 http://unmaintainable.wordpress.com/2007/01/14/package-management-using-stow/
 - using a third-party framework. Two of them come to mind:
   - OpenPKG http://www.openpkg.org/
   - pkgsrc  http://www.netbsd.org/docs/software/packages.html#platforms
 
 IMHO, there's no reason to include old versions of third-party packages in
 LibreOffice proper.

ACK, couldn't aggree more.

A few years ago (when I still did a lot of operating), I used my
own buildsystem (called Briegel, ICAC) to build micro-distros ontop
of existing systems (specially adapted to the individual target).

Lack of proper package management on certain old cruft systems
is not an legitimate reason to carry around old cruft 3rdparty
packages in application's sourcetrees ;-p

 In addition to all the included junk, I remember OpenOffice needing a
 special-purpose version of gcc to be compiled.

Yep, that was the biggest insanity I've ever seen in opensource world.
(yes, in certain commercial/inhouse environments that's not so unusual,
just having that in a current project ;-o)

 Should we go the same path again ?

Never ever, IMHO.


cu
-- 
--
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 phone:  +49 36207 519931  email: weig...@metux.de
 mobile: +49 151 27565287  icq:   210169427 skype: nekrad666
--
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
--
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener

[Soeren Moeller]

Hi

Now we have replaced tools/list with std::list in ScAddInListener,
here we used a list, as there is adding, removing, and searching on
this list, and no clear way to sort the elements. The patch comes in
three files:
0001 Replacing deprecated data types from solar.h
0002 Cleaning up the spacings
0003 Replacing tools/list with std::list
and a non-related 4th file:
0004 Removing unnecessary include of tools/string in funcdesc.hxx

The patches compile fine, but we couldn't really test them in the
running scalc, as it was impossible for us, to get scalc to use the
ScAddInListener (although it seems to be used in the unit tests
without failing).

Best Regards
Sören Möller
From f1fe93b0b5a2edd1e6da8b1629c5d16651e6bb02 Mon Sep 17 00:00:00 2001
From: Thies Pierdola thiespierd...@gmail.com
Date: Sat, 29 Jan 2011 17:39:34 +0100
Subject: [PATCH] Replaced deprecated types with sal types

---
 sc/source/core/inc/addinlis.hxx  |2 +-
 sc/source/core/tool/addinlis.cxx |   12 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/sc/source/core/inc/addinlis.hxx b/sc/source/core/inc/addinlis.hxx
index d3cb130..9c8b471 100644
--- a/sc/source/core/inc/addinlis.hxx
+++ b/sc/source/core/inc/addinlis.hxx
@@ -72,7 +72,7 @@ public:
 com::sun::star::sheet::XVolatileResult xVR );
 static voidRemoveDocument( ScDocument* pDocument );
 
-BOOL	HasDocument( ScDocument* pDoc ) const	{ return pDocs-Seek_Entry( pDoc ); }
+bool	HasDocument( ScDocument* pDoc ) const	{ return pDocs-Seek_Entry( pDoc ); }
 void	AddDocument( ScDocument* pDoc )			{ pDocs-Insert( pDoc ); }
 const com::sun::star::uno::Any GetResult() const{ return aResult; }
 
diff --git a/sc/source/core/tool/addinlis.cxx b/sc/source/core/tool/addinlis.cxx
index 71b3d72..81fdd80 100644
--- a/sc/source/core/tool/addinlis.cxx
+++ b/sc/source/core/tool/addinlis.cxx
@@ -84,8 +84,8 @@ ScAddInListener* ScAddInListener::Get( uno::Referencesheet::XVolatileResult xV
 {
 sheet::XVolatileResult* pComp = xVR.get();
 
-ULONG nCount = aAllListeners.Count();
-for (ULONG nPos=0; nPosnCount; nPos++)
+sal_uInt32 nCount = aAllListeners.Count();
+for (sal_uInt32 nPos=0; nPosnCount; nPos++)
 {
 ScAddInListener* pLst = (ScAddInListener*)aAllListeners.GetObject(nPos);
 if ( pComp == (sheet::XVolatileResult*)pLst-xVolRes.get() )
@@ -97,14 +97,14 @@ ScAddInListener* ScAddInListener::Get( uno::Referencesheet::XVolatileResult xV
 //!	move to some container object?
 void ScAddInListener::RemoveDocument( ScDocument* pDocumentP )
 {
-ULONG nPos = aAllListeners.Count();
+sal_uInt32 nPos = aAllListeners.Count();
 while (nPos)
 {
 //	loop backwards because elements are removed
 --nPos;
 ScAddInListener* pLst = (ScAddInListener*)aAllListeners.GetObject(nPos);
 ScAddInDocs* p = pLst-pDocs;
-USHORT nFoundPos;
+sal_uInt16 nFoundPos;
 if ( p-Seek_Entry( pDocumentP, nFoundPos ) )
 {
 p-Remove( nFoundPos );
@@ -140,8 +140,8 @@ void SAL_CALL ScAddInListener::modified( const ::com::sun::star::sheet::ResultEv
 Broadcast( ScHint( SC_HINT_DATACHANGED, ScAddress(), NULL ) );
 
 const ScDocument** ppDoc = (const ScDocument**) pDocs-GetData();
-USHORT nCount = pDocs-Count();
-for ( USHORT j=0; jnCount; j++, ppDoc++ )
+sal_uInt16 nCount = pDocs-Count();
+for ( sal_uInt16 j=0; jnCount; j++, ppDoc++ )
 {
 ScDocument* pDoc = (ScDocument*)*ppDoc;
 pDoc-TrackFormulas();
-- 
1.7.0.4

From 8876c079f754211c2ba5ab8fa959c1d3056eceff Mon Sep 17 00:00:00 2001
From: Thies Pierdola thiespierd...@gmail.com
Date: Sat, 29 Jan 2011 16:17:15 +0100
Subject: [PATCH 2/3] Cleaned up spacings

---
 sc/source/core/inc/addinlis.hxx  |   70 +++---
 sc/source/core/tool/addinlis.cxx |   42 +++
 2 files changed, 48 insertions(+), 64 deletions(-)

diff --git a/sc/source/core/inc/addinlis.hxx b/sc/source/core/inc/addinlis.hxx
index 9c8b471..ace8d49 100644
--- a/sc/source/core/inc/addinlis.hxx
+++ b/sc/source/core/inc/addinlis.hxx
@@ -29,18 +29,15 @@
 #ifndef SC_ADDINLIS_HXX
 #define SC_ADDINLIS_HXX
 
-#include adiasync.hxx			// for ScAddInDocs PtrArr
+#include adiasync.hxx // for ScAddInDocs PtrArr
 #include tools/list.hxx
 #include com/sun/star/sheet/XResultListener.hpp
 #include com/sun/star/sheet/XVolatileResult.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
 #include cppuhelper/implbase2.hxx
 
-
-
 class ScDocument;
 
-
 class ScAddInListener : public cppu::WeakImplHelper2
 com::sun::star::sheet::XResultListener,
 com::sun::star::lang::XServiceInfo ,
@@ -48,53 +45,56 @@ class ScAddInListener : public cppu::WeakImplHelper2
 {
 private:
 com::sun::star::uno::Referencecom::sun::star::sheet::XVolatileResult xVolRes;
-com::sun::star::uno::Any	aResult;
-ScAddInDocs*		

Re: [Libreoffice] In need of windows packaging team...

[Andrés Domínguez]

2011/1/29 Markus Stenzel m.sten...@hostingundservice.de:
 Hi all,

 can anyone please send me contact information of the Windows packaging team?
I'm not a windows packaging team  member, but i'll try to help.

 I’m badly in need of a smaller setup supporting German language (only) for
 inclusion on a free tool CD aimed at students, the CD ‘OpenSource im
 Studium’[1]. I have tried fiddling around with the setup using a Microsoft
 tool but this of course only results in a defective setup with a broken
 signature. J

OpenOffice 3.3 final is 160 MB (German with jre), probably about 140MB
without jre (no official package without jre yet). You could get similar size
with a custom LibreOffice installer, but you need jre to use all features.

As software increase in size every version, sooner than later you will
need to remove software or change to DVD.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Kicking off 3rdparty packages

[Tor Lillqvist]

 IMHO, there's no reason to include old versions of third-party packages in
 LibreOffice proper.

Please, are you talking about third-party source code included in the 
LibreOffice source code (git repositories), source code downloaded as part of 
the build process (unless one tells it to use a system library), or binaries 
from either of those included in a binary package? Or all of these?

 Up-to-date software can also be used on old Unixes / Linux systems without too
 much pain.

Sure, as long as you know what you are doing and packages from various 
3rd-party repositories (or self-built) are in sync with what LibreOffice 
expects. But I do think that somebody running some random old Unix box would 
prefer to get an all-inclusing LibreOffice package. Instead of complex advice 
like additionally you should install foolib from this site, but be careful not 
to let it overwrite the binary incompatible build of foolib from this other 
site that you might have already

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] cppcheck clean ups

[Andy Holder]

More simple cpp check clean ups.

AndyFrom ddd64b735bc5dfecb8a7a2838072003e2b36bb26 Mon Sep 17 00:00:00 2001
From: Andy Holder andy.m.hol...@gmail.com
Date: Sat, 29 Jan 2011 16:55:22 +
Subject: [PATCH] cppcheck: Prefer prefix ++/-- operators

---
 vcl/win/source/gdi/salgdi3.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vcl/win/source/gdi/salgdi3.cxx b/vcl/win/source/gdi/salgdi3.cxx
index 5f005ad..93fa079 100644
--- a/vcl/win/source/gdi/salgdi3.cxx
+++ b/vcl/win/source/gdi/salgdi3.cxx
@@ -213,7 +213,7 @@ ImplFontAttrCache::~ImplFontAttrCache()
 
 aCacheFile.WriteByteStringLine( rDFA.maStyleName, RTL_TEXTENCODING_UTF8 );
 
-aIter++;
+++aIter;
 }
 // EOF Marker
 String aEmptyStr;
-- 
1.7.3.5

From 750415f3ae3d59204bb120bf72ac3bf34d2a8af0 Mon Sep 17 00:00:00 2001
From: Andy Holder andy.m.hol...@gmail.com
Date: Sat, 29 Jan 2011 17:37:53 +
Subject: [PATCH] cppcheck: remove unused variable

---
 sw/source/ui/dbui/mmaddressblockpage.cxx |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx b/sw/source/ui/dbui/mmaddressblockpage.cxx
index 528a349..617cc14 100644
--- a/sw/source/ui/dbui/mmaddressblockpage.cxx
+++ b/sw/source/ui/dbui/mmaddressblockpage.cxx
@@ -1067,8 +1067,6 @@ SwAssignFieldsControl::SwAssignFieldsControl(
 m_aPreviews.push_back(pNewPreview);
 }
 ListBox* pBottomBox = m_aMatches[rHeaders.Count() -1];
-long nYBottom = pBottomBox-GetPosPixel().Y();
-nYBottom += pBottomBox-GetDropDownPosSizePixel().GetHeight();
 m_aVScroll.SetRange(Range(0, rHeaders.Count()));
 m_aVScroll.SetPageSize((aOutputSize.Height() - nHBHeight - m_nLBStartTopPos)/ m_nYOffset);
 m_aVScroll.EnableDrag();
-- 
1.7.3.5

From 98714b55983e8b8258855bc0fd79aea446864d51 Mon Sep 17 00:00:00 2001
From: Andy Holder andy.m.hol...@gmail.com
Date: Sat, 29 Jan 2011 17:23:44 +
Subject: [PATCH] cppcheck: variable never used

---
 .../source/win32/customactions/reg64/reg64.cxx |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/setup_native/source/win32/customactions/reg64/reg64.cxx b/setup_native/source/win32/customactions/reg64/reg64.cxx
index ea05475..2eb3f7f 100644
--- a/setup_native/source/win32/customactions/reg64/reg64.cxx
+++ b/setup_native/source/win32/customactions/reg64/reg64.cxx
@@ -207,7 +207,6 @@ bool IsInstallForAllUsers( MSIHANDLE hMSI )
 wchar_t* GetBasisInstallLocation( MSIHANDLE hMSI )
 {
 OutputDebugStringFormat(LGetBasisInstallLocation - START\n );
-bool bResult = FALSE;
 wchar_t* pVal = NULL;
 GetMsiProp( hMSI, LINSTALLLOCATION, pVal);
 
-- 
1.7.3.5

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH 3/3] translated German comments in connectivity/inc/connectivity/sqlparse.hxx

[Tobias Rosenberger]

---
 connectivity/inc/connectivity/sqlparse.hxx |   15 +++
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/connectivity/inc/connectivity/sqlparse.hxx 
b/connectivity/inc/connectivity/sqlparse.hxx
index d55c555..531f1ac 100644
--- a/connectivity/inc/connectivity/sqlparse.hxx
+++ b/connectivity/inc/connectivity/sqlparse.hxx
@@ -208,24 +208,23 @@ namespace connectivity
 /// access to the SQLError instance owned by this parser
 const SQLError getErrorHelper() const;
 
-// TokenIDToStr: Token-Name zu einer Token-Nr.
+// TokenIDToStr: token name belonging to a token number.
 static ::rtl::OString TokenIDToStr(sal_uInt32 nTokenID, const 
IParseContext* pContext = NULL);
 
-// StrToTokenID: Token-Nr. zu einem Token-Namen.
+// StrToTokenID: token number belonging to a token name.
 // static sal_uInt32 StrToTokenID(const ::rtl::OString  rName);
 
-// RuleIDToStr gibt den zu einer RuleID gehoerenden ::rtl::OUString 
zurueck
-// (Leerstring, falls nicht gefunden)
+// (empty string if not found)
 static ::rtl::OUString RuleIDToStr(sal_uInt32 nRuleID);
 
-// StrToRuleID berechnet zu einem ::rtl::OUString die RuleID (d.h. 
::com::sun::star::sdbcx::Index in yytname)
-// (0, falls nicht gefunden). Die Suche nach der ID aufgrund eines 
Strings ist
-// extrem ineffizient (sequentielle Suche nach ::rtl::OUString)!
+// StrToRuleID calculates the RuleID for a ::rtl::OUString (that is, 
::com::sun::star::sdbcx::Index in yytname)
+// (0 if not found). The search for an ID based on a String is
+// extremely inefficient (sequential search for ::rtl::OUString)!
 static sal_uInt32 StrToRuleID(const ::rtl::OString  rValue);
 
 static OSQLParseNode::Rule RuleIDToRule( sal_uInt32 _nRule );
 
-// RuleId mit enum, wesentlich effizienter
+// RuleId with enum, far more efficient
 static sal_uInt32 RuleID(OSQLParseNode::Rule eRule);
 // compares the _sFunctionName with all known function names and 
return the DataType of the return value
 static sal_Int32 getFunctionReturnType(const ::rtl::OUString 
_sFunctionName, const IParseContext* pContext = NULL);
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH 2/3] translated German comments in connectivity/inc/connectivity/sqlnode.hxx

[Tobias Rosenberger]

---
 connectivity/inc/connectivity/sqlnode.hxx |   39 -
 1 files changed, 16 insertions(+), 23 deletions(-)

diff --git a/connectivity/inc/connectivity/sqlnode.hxx 
b/connectivity/inc/connectivity/sqlnode.hxx
index 18069e2..1f370c1 100644
--- a/connectivity/inc/connectivity/sqlnode.hxx
+++ b/connectivity/inc/connectivity/sqlnode.hxx
@@ -124,13 +124,13 @@ namespace connectivity
 friend class OSQLParser;
 
 OSQLParseNodes m_aChildren;
-OSQLParseNode* m_pParent;  
// pParent fuer Reuckverkettung im Baum
-::rtl::OUStringm_aNodeValue;   // 
Token-Name oder leer bei Regeln oder ::rtl::OUString bei
-// ::rtl::OUString, 
INT, usw. -Werten
+OSQLParseNode* m_pParent;  
// pParent for reverse linkage in the tree
+::rtl::OUStringm_aNodeValue;   // 
token name, or empty in case of rules, or ::rtl::OUString in case of
+// ::rtl::OUString, 
INT, etc.
 SQLNodeTypem_eNodeType;// s. o.
-sal_uInt32 m_nNodeID;  
// ::com::sun::star::chaos::Rule ID (bei IsRule()) oder Token ID (bei 
!IsRule())
-// ::com::sun::star::chaos::Rule 
IDs und Token IDs koennen nicht anhand des Wertes
-// unterschieden werden, dafuer 
ist IsRule() abzufragen!
+sal_uInt32 m_nNodeID;  
// ::com::sun::star::chaos::Rule ID (if IsRule()) or Token ID (if 
!IsRule())
+// ::com::sun::star::chaos::Rule 
IDs and Token IDs can't be distinguished by their values,
+// IsRule has to be used for that!
 public:
 enum Rule
 {
@@ -233,7 +233,7 @@ namespace connectivity
 other_like_predicate_part_2,
 between_predicate_part_2,
 cast_spec,
-rule_count, // letzter_wert
+rule_count, // last value
 UNKNOWN_RULE// ID indicating that a node is no rule 
with a matching Rule-enum value (see getKnownRuleID)
 };
 
@@ -254,22 +254,19 @@ namespace connectivity
   SQLNodeType _eNodeType,
   sal_uInt32 _nNodeID = 0);
 
-// Kopiert den entsprechenden ParseNode
+// copies the respective ParseNode
 OSQLParseNode(const OSQLParseNode rParseNode);
 OSQLParseNode operator=(const OSQLParseNode rParseNode);
 
 sal_Bool operator==(OSQLParseNode rParseNode) const;
 
-// Destruktor raeumt rekursiv den Baum ab
+// destructor destruct the tree recursively
 virtual ~OSQLParseNode();
 
-// Parent gibt den Zeiger auf den Parent zurueck
 OSQLParseNode* getParent() const {return m_pParent;};
 
-// SetParent setzt den Parent-Zeiger eines ParseNodes
 void setParent(OSQLParseNode* pParseNode) {m_pParent = pParseNode;};
 
-// ChildCount liefert die Anzahl der Kinder eines Knotens
 sal_uInt32 count() const {return m_aChildren.size();};
 inline OSQLParseNode* getChild(sal_uInt32 nPos) const;
 
@@ -350,15 +347,14 @@ namespace connectivity
 OSQLParseNode* getByRule(OSQLParseNode::Rule eRule) const;
 
 #if OSL_DEBUG_LEVEL  0
-// zeigt den ParseTree mit tabs und linefeeds
+// shows the ParseTree with tabs and linefeeds
 void showParseTree( ::rtl::OUString rString ) const;
 void showParseTree( ::rtl::OUStringBuffer _inout_rBuf, sal_uInt32 
nLevel ) const;
 #endif
 
-// GetNodeType gibt den Knotentyp zurueck
 SQLNodeType getNodeType() const {return m_eNodeType;};
 
-// RuleId liefert die RuleId der Regel des Knotens (nur bei 
IsRule())
+// RuleId returns the RuleID of the node's rule (only if IsRule())
 sal_uInt32 getRuleID() const {return m_nNodeID;}
 
 /** returns the ID of the rule represented by the node
@@ -367,25 +363,22 @@ namespace connectivity
 */
 Rule getKnownRuleID() const;
 
-// RuleId liefert die TokenId des Tokens des Knotens (nur bei ! 
IsRule())
+// returns the TokenId of the node's tokenRuleId (only if 
!isRule())
 sal_uInt32 getTokenID() const {return m_nNodeID;}
 
-// IsRule testet ob ein Node eine Regel (NonTerminal) ist
-// Achtung : Regeln koenne auch Blaetter sein, z.B. leere Listen
+// IsRule tests whether a node is a rule (NonTerminal)
+// ATTENTION: rules can be leaves, for 

[Libreoffice] [PATCH 1/3] translated german comments in connectivity/inc/connectivity/sqliterator.hxx

[Tobias Rosenberger]

---
 connectivity/inc/connectivity/sqliterator.hxx |   30 +++-
 1 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/connectivity/inc/connectivity/sqliterator.hxx 
b/connectivity/inc/connectivity/sqliterator.hxx
index 6512752..0593aa1 100644
--- a/connectivity/inc/connectivity/sqliterator.hxx
+++ b/connectivity/inc/connectivity/sqliterator.hxx
@@ -67,10 +67,10 @@ namespace connectivity
 {
 private:
 ::com::sun::star::sdbc::SQLExceptionm_aErrors; 
// conatins the error while iterating through the statement
-const OSQLParseNode*   
m_pParseTree;   // aktueller ParseTree
+const OSQLParseNode*   
m_pParseTree;   // current ParseTree
 const OSQLParser  
m_rParser;  // if set used for general error messages from the 
context
-OSQLStatementType  
m_eStatementType;   // Art des Statements
-::rtl::ReferenceOSQLColumns  
m_aSelectColumns;   // alle Spalten aus dem Select-Clause
+OSQLStatementType  
m_eStatementType;
+::rtl::ReferenceOSQLColumns  
m_aSelectColumns;   // all columns from the Select clause
 ::rtl::ReferenceOSQLColumns  
m_aParameters;  // all parameters
 ::rtl::ReferenceOSQLColumns  
m_aGroupColumns;// the group by columns
 ::rtl::ReferenceOSQLColumns  
m_aOrderColumns;// the order by columns
@@ -79,7 +79,7 @@ namespace connectivity
 ::std::auto_ptr OSQLParseTreeIteratorImpl m_pImpl;
 
 void   traverseParameter(const OSQLParseNode* 
_pParseNode,const OSQLParseNode* _pColumnRef,const ::rtl::OUString 
_aColumnName,const ::rtl::OUString _aTableRange, const ::rtl::OUString 
_rColumnAlias);
-// Fugt eine Tabelle in die Map ein
+// inserts a table into the map
 void   traverseOneTableName( OSQLTables 
_rTables,const OSQLParseNode * pTableName, const ::rtl::OUString  rTableRange 
);
 void   traverseORCriteria(OSQLParseNode * 
pSearchCondition);
 void   traverseANDCriteria(OSQLParseNode * 
pSearchCondition);
@@ -124,11 +124,10 @@ namespace connectivity
   protected:
 void setSelectColumnName(::rtl::ReferenceOSQLColumns 
_rColumns,const ::rtl::OUString  rColumnName,const ::rtl::OUString  
rColumnAlias, const ::rtl::OUString  rTableRange,sal_Bool 
bFkt=sal_False,sal_Int32 _nType = 
com::sun::star::sdbc::DataType::VARCHAR,sal_Bool bAggFkt=sal_False);
 void appendColumns(::rtl::ReferenceOSQLColumns _rColumns,const 
::rtl::OUString _rTableAlias,const OSQLTable _rTable);
-// Weitere Member-Variable, die in den set-Funktionen zur
-// Verfuegung stehen sollen, koennen in der abgeleiteten Klasse
-// definiert werden und z. B. in deren Konstruktor initialisiert
-// bzw. nach Benutzung der traverse-Routinen mit Hilfe weiterer
-// Funktionen abgefragt werden.
+// Other member variables that should be available in the set 
functions
+// can be defined in the derived class. They can be initialized
+// in its constructor and, after the traverse routines have been 
used,
+// they can be queried using other functions.
 
 
   private:
@@ -154,13 +153,13 @@ namespace connectivity
 
 void dispose();
 bool isCaseSensitive() const;
-// Der zu analysierende/zu traversierende Parse Tree:
-// bei Ubergabe von NULL wird der aktuelle Parsetree geloscht und 
der Fehlerstatus gecleared
+// The parse tree to be analysed/traversed:
+// If NULL is passed, the current parse tree will be deleted and the 
error status cleared.
 void setParseTree(const OSQLParseNode * pNewParseTree);
 // void setParser(const OSQLParser* _pParser) { m_pParser = 
_pParser; }
 const OSQLParseNode * getParseTree() const { return m_pParseTree; };
 
-// Teilbaueme bei einem select statement
+// subtrees in case of a select statement
 const OSQLParseNode* getWhereTree() const;
 const OSQLParseNode* getOrderTree() const;
 const OSQLParseNode* getGroupByTree() const;
@@ -178,7 +177,7 @@ namespace connectivity
 inline const ::com::sun::star::sdbc::SQLException   getErrors() const 
{ return m_aErrors; }
 inline bool hasErrors() const { return m_aErrors.Message.getLength()  
0; }
 
-// Statement-Typ (wird bereits in setParseTree gesetzt):
+// statement type (already set in setParseTree):
 OSQLStatementType 

[Libreoffice] translated German comments in libs-core repo

[Tobias Rosenberger]

I translated the German comments in the libs-core repo in connectivity/inc/.
Changes are available under LGPLv3+/MPL.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] In need of windows packaging team...

[Tor Lillqvist]

I am not on the Windows packaging team (but some of my colleagues are), and I 
can't reply for them. I think some hairy political issues are involved, my 
personal opinions below...

I think a problem here is that if the packaging team would agree to provide you 
with such a German-only build, people using all other languages would have the 
same right to ask for one too. And such requests would drop in, one after one, 
for more or less similar reasons as you cite.

Having a multi-lingual installer frees us from building and distributing a 
complete set of single-language installers, which would take significantly more 
mirror disk space, longer time to upload and propagate to mirrors, etc.

So probably you will need to find some volunteer (or paid consultant) to do 
such a build for you...

It might even be relatively simple to manipulate our multi-lingual installer: 
remove unneeded files from the CAB file and modify the MSI database file 
accordingly, and this way construct a single-language installer? Somebody with 
the necessary skills could do just that and not have to actually build 
LibreOffice. The binaries would be identical to what we ship, which would be a 
plus.

Or should we have some policy that we do provide such single-language 
installers, but not to random individuals who ask for them, and not on the web 
(mirrors), but only on request to bona fide mass re-distributors? Where should 
we then draw the limit, how many copies does one have to be re-distributing to 
count as a such? 

--tml


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] A file to show 8192 discontinuities crashes Calc

[Andrea Pescetti]

r_ouellette wrote:
 I checked with LO 3.3 final version (RC4) and the problem remains...
 It is a regression from previous OpenOffice.org (before LO) where the
 file was correctly calculated.

Indeed this is one of a very small set (2-3) of bugs that were fixed in
OpenOffice.org 3.3 (to be precise: 3.3-RC10, then released as OOo 3.3)
but weren't fixed in LibreOffice 3.3, since as Kohei explained
LibreOffice 3.3 is essentially based on OpenOffice.org 3.3-RC8 (actually
RC9, but with most of the changes between RC8 and RC9 reverted).

When I answered you in
http://lists.freedesktop.org/archives/libreoffice/2011-January/005523.html
I was assuming (sorry) that LibreOffice would import all bugfixes until
OpenOffice.org 3.3 final, while it stopped just before it.

Regards,
  Andrea.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] [PUSHED] Easy hacks: remove double line spacing

[Christina Roßmanith]

Hi Jonathan,

I expected that there are people working on this topic because there are 
so many files already striked out on the list in the wiki (and there 
were many pushed messages on #libreoffice the last days). So I took 
one not immediately adjacent to the last striked out, hoping not to get 
into conflict with someone else.


First I thought that the person pushing the patch would strike out the 
file on the list. He didn't, so I did it. Do you mind if I work a little 
on this topic?


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] Easy hacks: remove double line spacing

[Jonathan Aquilina]

On 1/29/11 9:30 PM, Christina Roßmanith wrote:

Hi Jonathan,

I expected that there are people working on this topic because there 
are so many files already striked out on the list in the wiki (and 
there were many pushed messages on #libreoffice the last days). So I 
took one not immediately adjacent to the last striked out, hoping not 
to get into conflict with someone else.


First I thought that the person pushing the patch would strike out the 
file on the list. He didn't, so I did it. Do you mind if I work a 
little on this topic?


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Go for it :) i wish i had more time to work on it but im havin 
compilation issues with LO on my mac which im fighting wiht at the moment.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Utility to scan for some faults in Thesaurus files

[Andrea Pescetti]

Steve Butler wrote:
 The l10n guys said they needed this utility in git as their list does
 not allow attachments.  I will leave it up to your wisdom as to where
 to put it.

Thanks, I just used the version you attached to test the Italian
thesaurus th_it_IT_v2.dat, that I maintain, and (expectedly, since you
hadn't listed it as problematic) it found no issues.

Regards,
  Andrea.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Easy hacks: removed double line spacing (and some dead code)

[Jonathan Aquilina]

On 1/29/11 10:30 PM, Christina Roßmanith wrote:

Hi,

I'll strike out the files I've fixed on the list.

Christina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
much appreciated :) its to avoid someone duplicating a patch someone 
else could have done.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibreOffice and (La)Tex

[Wols Lists]

On 28/01/11 09:21, Michael Meeks wrote:
 Hi Alexander,
 
 On Fri, 2011-01-28 at 02:52 +0300, Alexander wrote:
 I want to suggest to add in LO support LaTeX as formulas generator.
 Instead or jointly of Math.
 ..
 Currently, LO inherited old non-wide used StarOffice syntax for formulas.
 
   So - it is clear that the LaTeX syntax is well know; however it is also
 clear that we cannot import all of TeX into LibreOffice. Could we make
 this a problem of data input, and perhaps do some coercion under the
 hood into our MathML-like representation ?
 
   Anyhow - the math engine lives in starmath/ do have a poke in there,
 and see what can be done - even a proof of concept to convert the most
 simple LaTeX formulae to starmath form (and back) would be fun to see.
 
Dunno quite how it works, but take a look at the lilypond integration
with OOo.

Lilypond always USED to use TeX as its back-end, and there's some way
you can put lilypond code into OOo that then calls lilypond (and TeX) to
generate a graphic that gets pulled back into OOo. It's used for
producing complicated scores.

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] cpp cleanliness: fixed some memleaks binfilter

[Kenneth Venken]

2011/1/28 Michael Meeks michael.me...@novell.com

 Hi there,

 On Thu, 2011-01-27 at 20:55 +0100, Kenneth Venken wrote:
  these patches remove some comments
  from ./filters/binfilter/bf_svx/source/editeng/svx_editobj.cxx and

 I've pushed these two.

   fixes two memleaks.

But this third one looks more problematic to me (at least on the
 surface) :-)

We allocate pC and then store its pointer in aContents (cf.
 CreateAndInsertContent) - right ? surely they are freed by
 DeleteContents called from the destructor ?

your right. I guess this is a cppcheck false positive.


Thanks though,

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] added translation to description.xml

[Clio]

added Russian translation to dictionaries/ru_RU/description.xml
From 602f1a9a22b18dc936230b7733f3d9650806e08d Mon Sep 17 00:00:00 2001
From: Clio mene...@bk.ru
Date: Sat, 29 Jan 2011 19:42:14 -0400
Subject: [PATCH] Added Russian translation to description.xml

---
 dictionaries/ru_RU/description.xml |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/dictionaries/ru_RU/description.xml b/dictionaries/ru_RU/description.xml
index e9110f2..b2425ab 100644
--- a/dictionaries/ru_RU/description.xml
+++ b/dictionaries/ru_RU/description.xml
@@ -4,6 +4,7 @@
 identifier value=org.openoffice.ru.hunspell.dictionaries /
 display-name
 name lang=enRussian spelling dictionary, hyphenation dictionary and thesaurus/name
+name lang=ruРусский словарь проверки орфографии, словарь переносов и синонимов/name
 /display-name
 platform value=all /
 dependencies
-- 
1.7.0.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Cpp Cleanliness: unread variable

[Kenneth Venken]

hi,

this removes unread variable pTargetPage from
./impress/sd/source/core/drawdoc2.cxxhttp://libreoffice.boldandbusted.com/368.html

-- Kenneth
From 790ae5ce71d14ce6100fc97d81b24f960e8323d5 Mon Sep 17 00:00:00 2001
From: Kenneth Venken kenneth.ven...@gmail.com
Date: Sun, 30 Jan 2011 01:05:55 +0100
Subject: [PATCH] unread variable

---
 sd/source/core/drawdoc2.cxx |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sd/source/core/drawdoc2.cxx b/sd/source/core/drawdoc2.cxx
index 8df46ac..bbb2ecb 100644
--- a/sd/source/core/drawdoc2.cxx
+++ b/sd/source/core/drawdoc2.cxx
@@ -775,7 +775,6 @@ BOOL SdDrawDocument::CreateMissingNotesAndHandoutPages()
 
 BOOL SdDrawDocument::MovePages(USHORT nTargetPage)
 {
-SdPage* pTargetPage 	   = NULL;
 SdPage* pPage			   = NULL;
 USHORT	nPage;
 USHORT	nNoOfPages		   = GetSdPageCount(PK_STANDARD);
@@ -840,7 +839,6 @@ BOOL SdDrawDocument::MovePages(USHORT nTargetPage)
 // hinter nPage einfuegen
 else
 {
-pTargetPage = GetSdPage(nPage, PK_STANDARD);
 nTargetPage = nPage;
 nTargetPage = 2 * nTargetPage + 1;	  // PK_STANDARD -- absolut
 while (aPageList.Count()  0)
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH: 2] Cpp Cleanliness: unread variable

[Kenneth Venken]

Hi,

this removes the unreadVariable lame_frame_size in
./filters/filter/source/flash/swfwriter.cxxhttp://libreoffice.boldandbusted.com/269.html

-- Kenneth
From 10e64f12f50fb2186676b053d9d130fdbccaf91b Mon Sep 17 00:00:00 2001
From: Kenneth Venken kenneth.ven...@gmail.com
Date: Sun, 30 Jan 2011 01:32:09 +0100
Subject: [PATCH] unread variable

---
 filter/source/flash/swfwriter.cxx |3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/filter/source/flash/swfwriter.cxx b/filter/source/flash/swfwriter.cxx
index bd8daa0..5be1290 100644
--- a/filter/source/flash/swfwriter.cxx
+++ b/filter/source/flash/swfwriter.cxx
@@ -515,7 +515,6 @@ sal_Bool Writer::streamSound( const char * filename )
 if (ret_code  0)
 throw 0;
 
-int lame_frame_size = lame_get_framesize(m_lame_flags);
 int samples_per_frame = 22050 / 12; // AS: (samples/sec) / (frames/sec) = samples/frame
 int mp3buffer_size = static_castint(samples_per_frame*1.25 + 7200 + 7200);
 
@@ -583,7 +582,7 @@ sal_Bool Writer::streamSound( const char * filename )
 
 SvMemoryStream strm(mp3buffer, ret + ret2, STREAM_READWRITE);
 
-mpTag-addUI16(samples_to_write); //lame_frame_size);
+mpTag-addUI16(samples_to_write);
 mpTag-addUI16(0);
 mpTag-addStream(strm);
 
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice