Re: [Libreoffice] Error in en_us readme file ?
Le 2011-01-30 13:53, drew a écrit : Hi, Received a message from a user today regarding the install instructions within the en_US readme file covering Mandriva: 'Doing commands like su urpmi *.rpm won't work; it either has to be sudo urpmi *.rpm or su -c urpmi *.rpm' I have never used Mandriva so don't know and thought I'd ask before just opening a bug report for him. Thanks Drew Here's another routine I am suggesting for the Konsole challenged users (Mandriva): 1. Download the distro and help files and language pack (if needed). 2. Right click on the .tar.gz and choose extract here 3. You can put/move ALL the .rpms that you need in one file folder then do a Ctrl-A (this means choose all); right-click and choose the regular MDV software installer. This will install all of the files. NOTE: if you have previously installed LibreOffice, you should uninstall ALL LibreOffice related files BEFORE install the FINAL version. ALSO NOTE that the RC4 version is the same as the FINAL version. To do this go to the Mandriva Control Centre (MCC), Add/Remove Software (packages); put LibreOffice in the search window and remove all of the files it returns. ALSO NOTE: if you would like to install the clip art from the OpenClipart.org project, you can install: libreoffice-openclipart-3-1pclos2010.noarch.rpm and it will install all of the cliparts into the right LibreOffice folders. You can find the file here: http://rpm.pbone.net/index.php3/stat/4/idpl/14906526/dir/pclinuxos/com/libreoffice-openclipart-3-1pclos2010.noarch.rpm.html Cheers Marc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error in en_us readme file ?
Le 2011-01-31 03:08, Marc Paré a écrit : Here's another routine I am suggesting for the Konsole challenged users (Mandriva): 1. Download the distro and help files and language pack (if needed). 2. Right click on the .tar.gz and choose extract here 3. You can put/move ALL the .rpms that you need in one file folder then do a Ctrl-A (this means choose all); right-click and choose the regular MDV software installer. This will install all of the files. NOTE: if you have previously installed LibreOffice, you should uninstall ALL LibreOffice related files BEFORE install the FINAL version. ALSO NOTE that the RC4 version is the same as the FINAL version. To do this go to the Mandriva Control Centre (MCC), Add/Remove Software (packages); put LibreOffice in the search window and remove all of the files it returns. ALSO NOTE: if you would like to install the clip art from the OpenClipart.org project, you can install: libreoffice-openclipart-3-1pclos2010.noarch.rpm and it will install all of the cliparts into the right LibreOffice folders. You can find the file here: http://rpm.pbone.net/index.php3/stat/4/idpl/14906526/dir/pclinuxos/com/libreoffice-openclipart-3-1pclos2010.noarch.rpm.html Cheers Marc You can also check your notes against my initial post for use with Konsole here which still work: http://listarchives.libreoffice.org/www/users/msg00071.html Cheers Marc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Upgrade packages for windows
* Arno Teigseth arnot...@gmail.com schrieb: - no one wants to make such a system just for libreoffice - it's more work figuring out the problems that probably will arise from an upgrade package than actually just installing the newer version of openoffice. These would probably be good reasons to give if anyone asks? #1 answer also puts the responsibility for building a package management system to where it belongs: the system owners, Microsoft. Or to some other project, dedicated to generic Windows packaging. (cygwin folks already have done a lot in this area, so that'd be a good starting point). I'd like to help coordinating such a project, but I don't have any resources to do actual works @Windows right now. cu -- -- Enrico Weigelt, metux IT service -- http://www.metux.de/ phone: +49 36207 519931 email: weig...@metux.de mobile: +49 151 27565287 icq: 210169427 skype: nekrad666 -- Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice on FreeBSD
2011/1/31 ski libreoff...@mail.ru: Hi! Is there any possibility to build the LibreOffice under the FreeBSD? Now I get this error: I am currently writing a ports for libreoffice, it should hit the ports tree this week (my be next week depending on the testing) it builds and run fine, I just have to polish some stuff : desktop files and mime types. I you want to test my : http://git.etoilebsd.net/ports/ regards, Bapt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to use gprof on LibO?
On Sat, Jan 29, 2011 at 03:50:37PM +0100, Soeren Moeller wrote: Hi In our effort of replacing deprecated data types from tools/ by std:: types we would like to use gprof for profiling (to choose the right data types). But unfortunately, we don't know to set the -pg flag, export ENVCFLAGSCXX=-pg before build should do. and where the gmon.out file would go. To the same dir where the binary is? I.e., to install/program for dev-install. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
Hi, does anyone need this macros? I removed them completely. -Thomas From dfe6fbe864926c8ef29c34681b0425f7aacdca75 Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Mon, 31 Jan 2011 09:52:51 +0100 Subject: [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx --- basic/source/classes/disas.cxx | 13 -- basic/source/classes/sbxmod.cxx | 22 --- basic/source/comp/sbcomp.cxx | 376 -- basic/source/inc/sbtrace.hxx | 45 - basic/source/runtime/runtime.cxx | 18 -- 5 files changed, 0 insertions(+), 474 deletions(-) delete mode 100644 basic/source/inc/sbtrace.hxx diff --git a/basic/source/classes/disas.cxx b/basic/source/classes/disas.cxx index 3000391..e299717 100644 --- a/basic/source/classes/disas.cxx +++ b/basic/source/classes/disas.cxx @@ -36,7 +36,6 @@ #include sb.hxx #include iosys.hxx #include disas.hxx -#include sbtrace.hxx static const char* pOp1[] = { @@ -364,10 +363,6 @@ BOOL SbiDisas::DisasLine( String rText ) if( !Fetch() ) return FALSE; -#ifdef DBG_TRACE_BASIC -String aTraceStr_STMNT; -#endif - // New line? if( eOp == _STMNT nOp1 != nLine ) { @@ -400,10 +395,6 @@ BOOL SbiDisas::DisasLine( String rText ) rText.AppendAscii( ; ); rText += s; rText.AppendAscii( _crlf() ); - -#ifdef DBG_TRACE_BASIC -aTraceStr_STMNT = s; -#endif } } @@ -463,10 +454,6 @@ BOOL SbiDisas::DisasLine( String rText ) rText += aPCodeStr; -#ifdef DBG_TRACE_BASIC -dbg_RegisterTraceTextForPC( pMod, nPC, aTraceStr_STMNT, aPCodeStr ); -#endif - return TRUE; } diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx index c5849d7..654fa2e 100644 --- a/basic/source/classes/sbxmod.cxx +++ b/basic/source/classes/sbxmod.cxx @@ -45,7 +45,6 @@ #include runtime.hxx #include token.hxx #include sbunoobj.hxx -#include sbtrace.hxx #include svtools/syntaxhighlight.hxx @@ -1121,9 +1120,6 @@ USHORT SbModule::Run( SbMethod* pMeth ) StarBASICRef xBasic; if( bDelInst ) { -#ifdef DBG_TRACE_BASIC -dbg_InitTrace(); -#endif // #32779: Hold Basic during the execution xBasic = (StarBASIC*) GetParent(); @@ -1180,10 +1176,6 @@ USHORT SbModule::Run( SbMethod* pMeth ) pMOD = this; SbiRuntime* pRt = new SbiRuntime( this, pMeth, pMeth-nStart ); -#ifdef DBG_TRACE_BASIC -dbg_traceNotifyCall( this, pMeth, pINST-nCallLvl ); -#endif - pRt-pNext = pINST-pRun; if( pRt-pNext ) pRt-pNext-block(); @@ -1196,11 +1188,6 @@ USHORT SbModule::Run( SbMethod* pMeth ) if( pRt-pNext ) pRt-pNext-unblock(); -#ifdef DBG_TRACE_BASIC -bool bLeave = true; -dbg_traceNotifyCall( this, pMeth, pINST-nCallLvl, bLeave ); -#endif - // #63710 It can happen by an another thread handling at events, // that the show call returns to an dialog (by closing the // dialog per UI), before a by an event triggered further call returned, @@ -1304,19 +1291,10 @@ void SbModule::RunInit() // The init code starts always here SbiRuntime* pRt = new SbiRuntime( this, NULL, 0 ); -#ifdef DBG_TRACE_BASIC -dbg_traceNotifyCall( this, NULL, 0 ); -#endif - pRt-pNext = pINST-pRun; pINST-pRun = pRt; while( pRt-Step() ) {} -#ifdef DBG_TRACE_BASIC -bool bLeave = true; -dbg_traceNotifyCall( this, NULL, 0, bLeave ); -#endif - pINST-pRun = pRt-pNext; delete pRt; pMOD = pOldMod; diff --git a/basic/source/comp/sbcomp.cxx b/basic/source/comp/sbcomp.cxx index a9fbdeb..6b98736 100644 --- a/basic/source/comp/sbcomp.cxx +++ b/basic/source/comp/sbcomp.cxx @@ -32,374 +32,6 @@ #include basic/sbx.hxx #include sbcomp.hxx #include image.hxx -#include sbtrace.hxx - - -//== -// Tracing, for debugging only - -// To activate tracing enable in sbtrace.hxx -#ifdef DBG_TRACE_BASIC - -#include hash_map - -// Trace Settings -static const char* GpTraceFileName = d:\\zBasic.Asm\\BasicTrace.txt; -static const bool GbIncludePCodes = false; -static const int GnIndentPerCallLevel = 4; -static const int GnIndentForPCode = 2; - -struct TraceTextData -{ -rtl::OString m_aTraceStr_STMNT; -rtl::OString m_aTraceStr_PCode; -}; -typedef std::hash_map sal_Int32, TraceTextData PCToTextDataMap; -typedef std::hash_map ::rtl::OUString, PCToTextDataMap*, ::rtl::OUStringHash, ::std::equal_to ::rtl::OUString ModuleTraceMap; - -ModuleTraceMap GaModuleTraceMap; -ModuleTraceMaprModuleTraceMap = GaModuleTraceMap; - -static void lcl_PrepareTraceForModule( SbModule* pModule ) -{ -String aModuleName = pModule-GetName(); -ModuleTraceMap::iterator it =
Re: [Libreoffice] SCID_NEWDOCUMENT
On Fri, 2011-01-28 at 21:22 +, Nigel Hawkins wrote: On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? As I discovered earlier today, opengrok doesn't index binfilter. So it might get used in there (though if it does, it may well duplicate the definition there). Kohei suggested using git grep (or g grep) to look for it instead. He binfilter is skipped for the simple reason that it generates quite a lot of noise in general when you look for code bits as almost everything there is a copy. I don't know if any other modules are skipped by opengrok. No, no other module is skipped. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] cleanup on writer
Hi David, Thanks for your review! On Mon, 31 Jan 2011 08:16:13 +0100, David Tardon dtar...@redhat.com wrote: -// OD 09.01.2003 #i6467# - adjust view shell option to the same as for print +// adjust view shell option to the same as for print We generally want to leave the #iX#-style comments around, as they point to the publicly accessible OpenOffice.org issue tracker. OTOH, the #X# or b#X or Bug X ones point to private Sun bug tracker and there is absolutely no value in having them. Sorry for my fault. OK, I learned my lesson :) Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Commented out some unused functions in calc
Hi Alfonso, On Sat, 2011-01-29 at 15:10 +, Alfonso Eusebio wrote: Hi, I've been going through the list of identified unused functions in calc and commenting out those that don't seem to be used anywhere. Why don't you simply remove them and check if it still builds? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] added translation to description.xml
On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: added Russian translation to dictionaries/ru_RU/description.xml Many thanks for your patch, I just pushed it. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] over-long extensions manager list ...
Hi Jean, On Sun, 2011-01-30 at 13:55 +0100, Jean-Baptiste Faure wrote: No the problem is not there. It is in the long list of useless extensions / dictionaries in the Extensions Manager. Many users are afraid when they see this list. Ah ! :-) so - this is something else. We can certainly fix this; primarily by not packing those dictionaries as extensions I suspect. End-user want to have the choice. But, he does not want to look a little beyond the default installation. Sure sure - but ultimately, removing one confusing choice (tons of dictionaries in the extensions manager), by adding another confusing choice - an extra page response that no-one understands in the installer IMHO makes the matter only worse. So - Norbert is right (of course); but so are you. So - the good news is; that Steven was poking at the dictionary indexing code - which is in a similar area, and was going to look at packaging dictionaries just as bundled files, rather than as extensions - which *should* solve the problem for you. That involves a little digging in dictionaries/ (removing a -ton- of cut/paste makefile.mk-age), and some more prodding inside scp2/ to distribute the dictionaries in a different way. Hopefully that'll solve the problem for 3.4 - and/or if you're concerned - can you contact Steven and help out ? Anyhow - IMHO, there could have been a shorter thread here, if we had pinpointed the root problem that people complain about, and not one solution to it :-) but anyway: Thanks for the report ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Re: translated German comments in libs-core repo
On Sat, 2011-01-29 at 17:12 +0100, Tobias Rosenberger wrote: I translated the German comments in the libs-core repo in connectivity/inc/. Changes are available under LGPLv3+/MPL. Thanks for these, all pushed now. Attachments are easier to work with than inline patches FWIW. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] GTK: remove menu when we press the alt key
On Fri, 2011-01-28 at 20:08 +, Caolán McNamara wrote: On Fri, 2011-01-28 at 16:50 +0100, xapantu wrote: Here is a patch to remove the menu when the alt key is pressed, it is not the case with GTK apps, and is disturbing. This will also work around the rather horrific hack that totem (and probably other things have), where when it doesn't have access to dbus to tell the session to disable the screensaver while running, it sends regular fake alt keystrokes to the display, which if it happens to have OOo as the receiver of the alts will cause its menus to popup over your video every now and then :-) Do you want this on the libreoffice-3-3 branch ? I'd be happy to have it there, if you're ok to review it ;-) cf. db1f9d326bdd678c177eea337997b3c0aefa0c19 and a63e78439ca947499a4678cea4dd8e9e07054ab9 ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/core/access
On Sun, 2011-01-30 at 04:22 +0900, Suguru Hirahara wrote: under LGPLv3+ / MPL. Pushed, but please pay attention to: * Avoid breaking the build with ill-formed comments * Provide several patches changing twice the same things in the same files but not 100% exactly in the same way. I had to massage your patches to make all three of them apply. For your information, you should simply run git commit on your local copy and when you want to provide the patches, run git format-patch -nb-commits. Many thanks for your patches, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove comments (writer); sw/source/filter
On Sun, 2011-01-30 at 01:54 +0900, Suguru Hirahara wrote: Hello, here's another patch. This one is also related with bogus comments. Pushed as well -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] (no subject)
Hello Antoine, Thanks for your patch. I just pushed it. Feel free to provide other patches like this one. BTW, you didn't mention anything, I supposed you were agreeing to provide the patch under LGPLv3+ / MPL... is that OK? Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove unused files
Hello Kurosawa-san, On Mon, 2011-01-31 at 16:53 +0900, KUROSAWA, Takeshi wrote: Hi, I found some unused files in libs-gui/sv-tools/ and filters/binfilter/. Actually they are not compiled. Attached patches remove them. Many thanks for your patches. I just pushed them. I compiled them and it went nicely. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Replaced tools/list with std::list in ScAddInListener
Hello Soeren and Thies, On Sat, 2011-01-29 at 18:04 +0100, Soeren Moeller wrote: Now we have replaced tools/list with std::list in ScAddInListener, here we used a list, as there is adding, removing, and searching on this list, and no clear way to sort the elements. The patch comes in three files: 0001 Replacing deprecated data types from solar.h 0002 Cleaning up the spacings 0003 Replacing tools/list with std::list and a non-related 4th file: 0004 Removing unnecessary include of tools/string in funcdesc.hxx Many thanks for the patches. I've just pushed them. Keep providing nice patches like these with alternating names ;) Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Impressive mockups
Hi all, This is beautiful! http://www.techdrivein.com/2011/01/impressive-libreoffice-ui-mockups-you.html LibreOffice will be the best office suite ever seen! :-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Impressive mockups
Absolutely fantastic! Brilliant use of all this wasted space in a wide screen while writing in a portrait page! This just makes me think how the MS innovative big fat ribbon on top was wasting valuable screen space. Congratulations to whoever had this brilliant idea. I hope it is implemented ASAP! -- View this message in context: http://nabble.documentfoundation.org/Impressive-mockups-tp2389105p2389133.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ Libreoffice ] Impressive mockups
Hi all, Hi all, This is beautiful! http://www.techdrivein.com/2011/01/impressive-libreoffice-ui-mockups-you.html LibreOffice will be the best office suite ever seen! :-) just FYI: Paulo is already part of our Design Team :-) He created the detailed 256px versions (and an updated 128px version) of our new icon set: http://wiki.documentfoundation.org/User:Paulojose#Adding_details_to_Christoph.27s_Mimetype_Icons_.402011.2C_jan_24-28 Best regards Bernhard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Impressive mockups
Dear Julio, this is the development mailing list. Please discuss and post this on other lists, such as discuss@ or marketing@ thanks, Charles. Le Mon, 31 Jan 2011 08:57:44 -0300, Júlio Hoffimann julio.hoffim...@gmail.com a écrit : Hi all, This is beautiful! http://www.techdrivein.com/2011/01/impressive-libreoffice-ui-mockups-you.html LibreOffice will be the best office suite ever seen! :-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] fontconfig / l10n issue with font names ...
Hi Caolan, Any chance you could review Petr Gajdos's attached patch; AFAIR you are a bit of a fontconfig wizard ;-) It is to fix this: https://bugzilla.novell.com/show_bug.cgi?id=379991 Thanks ! :-) Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot From 6ab0ac7226441c282faae15e9932181520b86655 Mon Sep 17 00:00:00 2001 From: pgajdos pgaj...@novell.com Date: Mon, 31 Jan 2011 11:15:11 +0100 Subject: [PATCH] Fixing font style languages. --- vcl/unx/source/fontmanager/fontconfig.cxx | 67 +++-- 1 files changed, 35 insertions(+), 32 deletions(-) diff --git a/vcl/unx/source/fontmanager/fontconfig.cxx b/vcl/unx/source/fontmanager/fontconfig.cxx index bb4c114..8e45e43 100644 --- a/vcl/unx/source/fontmanager/fontconfig.cxx +++ b/vcl/unx/source/fontmanager/fontconfig.cxx @@ -255,7 +255,8 @@ public: { return m_pFcFreeTypeCharIndex ? m_pFcFreeTypeCharIndex( face, ucs4 ) : 0; } public: // TODO: cleanup -FcResult FamilyFromPattern(FcPattern* pPattern, FcChar8 **family); +FcResult LocalizedElementFromPattern(FcPattern* pPattern, FcChar8 **family, + const char *elementtype, const char *elementlangtype); std::hash_map rtl::OString, rtl::OString, rtl::OStringHash m_aFontNameToLocalized; std::hash_map rtl::OString, rtl::OString, rtl::OStringHash m_aLocalizedToCanonical; }; @@ -500,27 +501,27 @@ void FontCfgWrapper::release() #ifdef ENABLE_FONTCONFIG namespace { -typedef std::pairFcChar8*, FcChar8* lang_and_family; +typedef std::pairFcChar8*, FcChar8* lang_and_element; class localizedsorter { rtl::OLocale maLoc; public: localizedsorter(rtl_Locale* pLoc) : maLoc(pLoc) {} -FcChar8* bestname(const std::vectorlang_and_family families); +FcChar8* bestname(const std::vectorlang_and_element elements); }; -FcChar8* localizedsorter::bestname(const std::vectorlang_and_family families) +FcChar8* localizedsorter::bestname(const std::vectorlang_and_element elements) { -FcChar8* candidate = families.begin()-second; +FcChar8* candidate = elements.begin()-second; rtl::OString sLangMatch(rtl::OUStringToOString(maLoc.getLanguage().toAsciiLowerCase(), RTL_TEXTENCODING_UTF8)); -rtl::OString sFullMatch = sLangMatch; +rtl::OString sFullMatch = sLangMatch; sFullMatch += OString('-'); sFullMatch += rtl::OUStringToOString(maLoc.getCountry().toAsciiLowerCase(), RTL_TEXTENCODING_UTF8); -std::vectorlang_and_family::const_iterator aEnd = families.end(); +std::vectorlang_and_element::const_iterator aEnd = elements.end(); bool alreadyclosematch = false; -for( std::vectorlang_and_family::const_iterator aIter = families.begin(); aIter != aEnd; ++aIter ) +for( std::vectorlang_and_element::const_iterator aIter = elements.begin(); aIter != aEnd; ++aIter ) { const char *pLang = (const char*)aIter-first; if( rtl_str_compare( pLang, sFullMatch.getStr() ) == 0) @@ -542,7 +543,7 @@ namespace } else if( rtl_str_compare( pLang, en) == 0) { -// fallback to the english family name +// fallback to the english element name candidate = aIter-second; } } @@ -550,27 +551,29 @@ namespace } } -FcResult FontCfgWrapper::FamilyFromPattern(FcPattern* pPattern, FcChar8 **family) -{ -FcChar8 *origfamily; -FcResult eFamilyRes = FcPatternGetString( pPattern, FC_FAMILY, 0, origfamily ); -*family = origfamily; + +FcResult FontCfgWrapper::LocalizedElementFromPattern(FcPattern* pPattern, FcChar8 **element, + const char *elementtype, const char *elementlangtype) +{/* e. g.: ^ FC_FAMILY ^ FC_FAMILYLANG */ +FcChar8 *origelement; +FcResult eElementRes = FcPatternGetString( pPattern, elementtype, 0, origelement ); +*element = origelement; -if( eFamilyRes == FcResultMatch) +if( eElementRes == FcResultMatch) { -FcChar8* familylang = NULL; -if (FcPatternGetString( pPattern, FC_FAMILYLANG, 0, familylang ) == FcResultMatch) +FcChar8* elementlang = NULL; +if (FcPatternGetString( pPattern, elementlangtype, 0, elementlang ) == FcResultMatch) { -std::vector lang_and_family lang_and_families; -lang_and_families.push_back(lang_and_family(familylang, *family)); +std::vector lang_and_element lang_and_elements; +lang_and_elements.push_back(lang_and_element(elementlang, *element)); int k = 1; while (1) { -if (FcPatternGetString( pPattern, FC_FAMILYLANG, k, familylang ) != FcResultMatch)
Re: [Libreoffice] Kicking off 3rdparty packages
On Sun, 2011-01-30 at 22:11 +0100, Enrico Weigelt wrote: No, simply state the depencies and let the distros handle the rest. For old legacy systems, simply create an own micro-distro. Luckily we have a micro-distro now; complete with our own build system, and method of packaging; it is called the onebigblob microdistro - and it works as badly as can be expected when trying to target all distros. So - I appreicate the desire to rip stuff out of LibreOffice - but we should focus on the low hanging fruit that Caolan identified first. Francois: I expect you to google Tor Lillqvist, and think a bit more before typing. I fully anticipate that the vast majority of users on Linux will get their LibreOffice from their distribution with system libraries used everywhere: which produces a better product; -however- this does not mean it is worthless having generic builds - particularly since we have a QA team that is dispersed across many Linux's. ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kicking off 3rdparty packages
On Sat, 2011-01-29 at 14:44 +0100, Francois Tigeot wrote: I'm still trying to figure out the autogen.sh stuff and make it use the correct paths for libraries; one of the errors I got is really freaking me out: :-) Why would LO need to build it own version of Mozilla/Seamonkey !? And why such an old version; it must be full of security holes by now... The first line of */prj/build.lst lists dependencies for a module: $ grep MOZ:moz */prj/build.lst connectivity/prj/build.lst:cn connectivity:shell l10n comphelper MOZ:moz svl UNIXODBC:unixODBC unoil javaunohelper HSQLDB:hsqldb qadevOOo officecfg NSS:nss NULL libxmlsec/prj/build.lst:ls libxmlsec : stlport soltools LIBXML2:libxml2 MOZ:moz NULL xmlsecurity/prj/build.lst:xsxmlsecurity :l10n xmloff unotools offapi unoil svx MOZ:moz LIBXMLSEC:libxmlsec NSS:nss NULL Which in laymans terms means - we use it for connectivity (moz adressbook I guess), and xml security foo - AFAIR the cert management stuff in moz really needs pushing down to NSS, or splitting out. Clearly, we could take a big knife to Mozilla to pare out the vast majority of it that we do not need, and keep those two - it would be even more wonderful to get that split out up-stream. Could you help hack on that ? ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
Hi Christina, On Fri, 2011-01-28 at 22:25 +0100, Christina Roßmanith wrote: and how could I find out if a constant like SCID_NEWDOCUMENT is still referenced? Or does that require some more experience with the code base? In general running 'g grep' in the top-level is reliable; although I suppose some pre-processor pasting might be used for some symbols that may hide things, but - be bold - we can always revert things that break the build later :-) Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy hacks: removed double line spacing
Yes. LGPLv3+ and MPL as usual. Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Impressive mockups
Sorry Charles, this will not happen again. ;-) Regards, Júlio. 2011/1/31 Charles-H. Schulz charles.sch...@documentfoundation.org Dear Julio, this is the development mailing list. Please discuss and post this on other lists, such as discuss@ or marketing@ thanks, Charles. Le Mon, 31 Jan 2011 08:57:44 -0300, Júlio Hoffimann julio.hoffim...@gmail.com a écrit : Hi all, This is beautiful! http://www.techdrivein.com/2011/01/impressive-libreoffice-ui-mockups-you.html LibreOffice will be the best office suite ever seen! :-) Regards, Júlio. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
Thanks. On 01/31/2011 12:32 PM, Cedric Bosdonnat wrote: Hi Thomas, On Mon, 2011-01-31 at 09:58 +0100, Thomas Arnhold wrote: does anyone need this macros? I removed them completely. I just pushed your patch here: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=b214264fbb55b1f33e8a50b42113137178da0125 If anyone complains about the removal, feel free to revert the commit. Regards, ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Easy hacks: remove double line spacing
Hi there, On Sat, 2011-01-29 at 00:28 +0100, Guillaume wrote: Hi, I removed some empty lines in few files for my first patch. I'll continue if it's ok. It seems someone pushed this before I could :-) anyhow - thanks again; and can you confirm you're ok with the LGPLv3+/MPL dual license for your work ? All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kicking off 3rdparty packages
On Mon, 2011-01-31 at 13:30 +, Michael Meeks wrote: and xml security foo - AFAIR the cert management stuff in moz really needs pushing down to NSS, or splitting out. IIRC the real stuff that xmlsecurity needs is all in NSS, while the only bit that xmlsecurity needs from MOZ is simply to *find* the mozilla profile in order to locate the certificate database and I may already have some ifdefs in there to do-the-right-thing and find it without having to link to any moz libraries in order to do that. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
Hi Tobias, On 2011-01-30 at 20:56 +0100, Tobias Rosenberger wrote: is there a reason why you don't use git submodule for managing the other repos in the build repo? The reason is that so far nobody researched that enough, to be able to judge if it would help us, or not :-) From what I know about the submodules, it fits more some kind of release tree (our 'build' repository), than the bleeding edge - but I may be completely wrong :-) Can you please do a bit of research in that regard, and summarize how we would gain from using git submobule? Thank you a lot, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] added translation to description.xml
31.01.2011 06:17, Cedric Bosdonnat пишет: On Sat, 2011-01-29 at 20:05 -0400, Clio wrote: added Russian translation to dictionaries/ru_RU/description.xml Well I forgot to ask you... do you agree to push the patch under LGPLv3+ and MPL? Yes, of course. Thank you. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] git submodule
On Mon, Jan 31, 2011 at 8:39 AM, Jan Holesovsky ke...@suse.cz wrote: Hi Tobias, On 2011-01-30 at 20:56 +0100, Tobias Rosenberger wrote: is there a reason why you don't use git submodule for managing the other repos in the build repo? The reason is that so far nobody researched that enough, to be able to judge if it would help us, or not :-) From what I know about the submodules, it fits more some kind of release tree (our 'build' repository), than the bleeding edge - but I may be completely wrong :-) I concur. my limited understanding of how submodule works lead me to believe that it would not be a nice fit with what we do 1/ it is more appropriate when the 'modules' have fairly independent life-cycle, which is not really our case. sure calc/writer/impress/base are fairly isolated from one another, but the coupling with libs-core/libs-gui/ure/... is pretty tight 2/ this would make the barrier of entry, and the possibility of srew-up so much higher. I do agree that it could make a sens for a limited use in the 'build' repo of git submodules... but then again, I'm not sure it will improve the workflow of the people using it... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kicking off 3rdparty packages
On Mon, 2011-01-31 at 14:38 +, Caolán McNamara wrote: On Mon, 2011-01-31 at 13:30 +, Michael Meeks wrote: and xml security foo - AFAIR the cert management stuff in moz really needs pushing down to NSS, or splitting out. IIRC the real stuff that xmlsecurity needs is all in NSS, while the only bit that xmlsecurity needs from MOZ is simply to *find* the mozilla profile in order to locate the certificate database and I may already have some ifdefs in there to do-the-right-thing and find it without having to link to any moz libraries in order to do that. Oooh - it would be nice to drop the MOZ dependency for everything except the connectivity piece :-) sounds much nicer. Regards, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] LibreOffice on FreeBSD
2011/1/31 Michael Meeks michael.me...@novell.com: Heh; could you submit the patches to the list (with suitable LGPLv3+ / MPL license (if you're ok with that). If you could glup the clean ones together into one patch: soffice.sh, ooinstall, build-ooo can go in as-is; the others need some more polish to not break other platforms I think :-) it would be wonderful to get them included. Of course I will, I was planning to send that today, but ENOTIME :) I will in the next days. regards, Bapt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Add support for DragonFly in configure.in
On Mon, 2011-01-31 at 12:46 +0100, Francois Tigeot wrote: It was a low-hanging fruit; I'll collect patches locally for a while until I can get a more complete build. .. Sure. Great :-) thanks. http://www.libreoffice.org/get-involved/developers/ says LO is licensed under both LGPLv3 and GPL. Shouldn't it be LGPLv3 and MPL ? Great catch; fixed. Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Error with some dokuments under Windows
Hi Michael, On Sun, 2011-01-30 at 18:24 +, Michael Florian Schönitzer wrote: Hey, I have found a strange bug. I don't know where there is the right place, so I put it here. Thanks ! - Opening it in LibreOffice 3.3 under Windows, the window beeing maximized = Empty Document, LibreOffice behaves strange - Opening it in LibreOffice 3.3 under Windows, not maximised = Document is showed right, when maximizing the window LibreOffice crashes Sounds like a lot of fun :-) Opening it in MS Office 2007 and exporting it to ODF or .doc, also didn't change anything. Interesting; so it would really help to have the document. I've testet it with two different windows-computers. (plus 1 linux PC) The one PC has Windows XP, the other Windows 7. Both have LibreOffice 3.3 german. ... I think this bug is quite strange and annoying. Hope it can be fixed. I don't want to upload or mail around the file but I'd give it to a developer. So - what we would normally hope for - is a minimal test document that displays the problem. Thankfully the process of getting that is basically what QA would do to try to isolate the problem - so you can really help out with development. I would load the doc in MS Office; chop the 1st half of it out; save - and re-load in LibreOffice 3.3 - if it crashes, the problem is in the bottom half, if not, it was in the top half (so chop the other half and repeat). After repeating the cycle five times or so - you should end up with almost nothing left of your document [ which hopefully you are happier to share ], and can file a bug / post it here ? Is that possible ? Thanks, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
Sure; so if we look at: setup_native/source/win32/customactions/shellextensions/registerextension.cxx It -looks- to me, as if we should duplicate / implement a new extension Er, no need to implement a new shell extension. What could be done is to implement a new installer custom action for the installer, that creates the indexes. (The above registerextension.cxx is such a custom action, that registers the LibreOffice shell extension. But it itself is not called an extension.) An installer custom action is a DLL that can do basically whatever is necessary. The MSI database contains a setting that directs at which stage it is invoked (and what named function in it is invoked.) It can query the MSI installer that is calling it and ask what components are being installed, or set some components to not being installed, etc. (using something close to SQL if I recall correctly. That's what I do in the sellang custom action which deselects UI languages that it guesses the user is not interested in.) In this case, it should be run after stuff has been installed, and it should presumably query which dictionaries were installed, and then create index esfor them. It should presumably also be run at uninstall and remove the indexes. Although that is maybe not so important... If the custom action requires some LibreOffice DLLs, it might get interesting to make sure those are found, hmm. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] Fix wrong collation for Catalan language
Hi Jesus, On Sun, 2011-01-30 at 15:09 +0100, Jesús Corrius wrote: Could someone please review and cherry-pick for libreoffice-3-3 branch this commit: http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=affa15b894b66b3d12d00ab1ad3c567ade88800e Quick sanity check, and pushed it; though I'd be happier with Andras' ok really ;-) It basically fixes the collation for Catalan language, so it's important :) of course :-) ATB, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEWED] bugfixes for 3.3.1
Hi Andras, On Sat, 2011-01-29 at 15:13 +0100, Andras Timar wrote: Please review them and cherry-pick to libreoffice-3-3. Thanks ! I read all the integration points, and everything look great to me :-) [ though I can't say I read all of the dictionaries fully ;-]. Any chance you can do the cherry picking yourself ? I end up with conflicts in dictionaries/prj/build.lst that might take a little unwinding ;-) All of these new dictionaries, reminds me we really need to dung out the old/bogus icon themes we have to make space for them; will knock up that patch now. Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Upgrade packages for windows
On Mon, 2011-01-31 at 09:18 +0100, Enrico Weigelt wrote: Or to some other project, dedicated to generic Windows packaging. (cygwin folks already have done a lot in this area, so that'd be a good starting point). Aha I didn't know that existed. As long as the user experience isn't deteriorated [much]. However, the request was originally from a sysadmin guy, wanting to roll out upgrades across large organizations with many ooo/LO installs. In these cases it's probably more important for him to know what computers actually were upgraded. For the independent end user it's probably easier just telling him to install the new package, than installing a packet management system to his computer. (Just thinking of what happens when he's used to upgrading with a packet management system and then gets a new computer - without it...) best Arno signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] remove old icon themes ...
Hi there, The appended should save us ~10Mb of install size on Windows (and perhaps elsewhere too) - I'd love to get it onto the libreoffice-3-3 branch. Thanks, Michael. diff --git a/distro-configs/LibreOfficeLinux.conf.in b/distro-configs/LibreOfficeLinux.conf.in index aa13f07..1fe044d 100644 --- a/distro-configs/LibreOfficeLinux.conf.in +++ b/distro-configs/LibreOfficeLinux.conf.in @@ -56,3 +56,4 @@ --disable-kde4 --disable-dbus --disable-crypt-link +--with-theme=default hicontrast tango diff --git a/distro-configs/LibreOfficeMacOSX.conf.in b/distro-configs/LibreOfficeMacOSX.conf.in index add6794..4fe98c8 100644 --- a/distro-configs/LibreOfficeMacOSX.conf.in +++ b/distro-configs/LibreOfficeMacOSX.conf.in @@ -10,3 +10,4 @@ --enable-report-builder --with-extension-integration --enable-broffice +--with-theme=default hicontrast tango diff --git a/distro-configs/LibreOfficeWin32.conf.in b/distro-configs/LibreOfficeWin32.conf.in index 1a23bee..d9a5ac8 100644 --- a/distro-configs/LibreOfficeWin32.conf.in +++ b/distro-configs/LibreOfficeWin32.conf.in @@ -18,3 +18,4 @@ --disable-xrender-link --disable-build-mozilla --disable-activex-component +--with-theme=default hicontrast tango -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
On Mon, Jan 31, 2011 at 11:05 AM, Dave Dumaresq dfdumar...@gmail.com wrote: Has there been any resolution to this? I bisected the problem to libs-gui:ef70418ebf8b32f2d10abce61c0aa2c1011ced14 I'll let Joe decide how best revert/fix (since there may be more than one commit involved to revert properly) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] freebsd support
Hi all, Here are the first patch for freebsd support : I splitted them corresponding to the different git and prefix them with the git repository name. Of course those patches are in any license you want that best fits your needs :) The other patch are not included as they need more work, and I don't know how to integrate them cleanly. For example using bsdtar (libarchive) instead of GNU tar perfectly works to may be there should be a test in configure.in to allow bsdtar as well as gnu tar Another patch is that build/libreoffice/oox/util/makefile.mk needs to link to -lcrypto on freebsd. Don't know how to integrate that cleanly building with java bring a problem apache-commons/java/*/makefile.mk because the ANT_OPT line fails with our openjdk6 or our version of ant, don't know. It leads to a class def not found exception, searching -Dencoding... in classpath commenting out the ANT_OPT line fix the problem. regards, Bapt diff --git a/solenv/bin/ooinstall b/solenv/bin/ooinstall index e718b8a..ba226fa 100755 --- a/solenv/bin/ooinstall +++ b/solenv/bin/ooinstall @@ -14,7 +14,7 @@ use Cwd; $path = ''; $do_link = 0; -( $^O =~ /netbsd/i ) || ( $^O =~ /openbsd/i ) || ( $^O =~ /darwin/i ) || ( -f /proc/meminfo ) || die The installer cannot work without javaldx running, which requires /proc to be mounted; +( $^O =~ /freebsd/i ) || ( $^O =~ /netbsd/i ) || ( $^O =~ /openbsd/i ) || ( $^O =~ /darwin/i ) || ( -f /proc/meminfo ) || die The installer cannot work without javaldx running, which requires /proc to be mounted; # Workaround for system Mozilla if ( $ENV{'SYSTEM_MOZILLA'} eq 'YES' ) { diff --git a/bin/build-ooo b/bin/build-ooo index e4ab354..c3b2248 100755 --- a/bin/build-ooo +++ b/bin/build-ooo @@ -11,7 +11,7 @@ fi export TARFILE_LOCATION -if test z$BUILD_WIN32 = z -a z`uname -s` != zSunOS -a z`uname -s` != zDarwin -a z`uname -s` != zOpenBSD; then +if test z$BUILD_WIN32 = z -a z`uname -s` != zSunOS -a z`uname -s` != zDarwin -a z`uname -s` != zOpenBSD -a z`uname -s` != zFreeBSD; then if ! test -f /proc/cpuinfo; then echo Looks like proc isn't mounted - this means almost certain echo Java related weird build failure: please check /proc diff --git a/bin/ooinstall b/bin/ooinstall index 170ee29..2f54005 100755 --- a/bin/ooinstall +++ b/bin/ooinstall @@ -31,7 +31,7 @@ sub suck_setup($) return 0; } -( $^O =~ /openbsd/i ) || ( $^O =~ /darwin/i ) || ( -f /proc/meminfo ) || die The installer cannot work without javaldx running, which requires /proc to be mounted; +( $^O =~ /freebsd/i) || ( $^O =~ /openbsd/i ) || ( $^O =~ /darwin/i ) || ( -f /proc/meminfo ) || die The installer cannot work without javaldx running, which requires /proc to be mounted; suck_setup (./setup) || suck_setup (bin/setup) || die can't find bin/setup; diff --git a/desktop/scripts/soffice.sh b/desktop/scripts/soffice.sh index 2989edd..e485b11 100644 --- a/desktop/scripts/soffice.sh +++ b/desktop/scripts/soffice.sh @@ -70,7 +70,7 @@ fi sd_binary=`basename $0 | sed 's/libreoffice/soffice/g'`.bin case `uname -s` in -NetBSD|OpenBSD) # this is a temporary hack until we can live with the default search paths +NetBSD|OpenBSD|FreeBSD) # this is a temporary hack until we can live with the default search paths sd_prog1=$sd_prog/../basis-link/program sd_prog2=$sd_prog/../basis-link/ure-link/lib LD_LIBRARY_PATH=$sd_prog1:$sd_prog2${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
Hi Dave, On Mon, 2011-01-31 at 09:05 -0800, Dave Dumaresq wrote: Has there been any resolution to this? Yes ! Norbert just finished an amazing binary chop that brought it back to commit: libs-gui:ef70418ebf8b32f2d10abce61c0aa2c1011ced14 (a remove DECLARE_LIST in rsc) Which seems to break the code flow there :-) - leaving pSysEntry in an odd state ;-) I imagine it will be fixed soon ... HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Hi, I'm not really sure about this. There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? -Thomas From b93f098328afb2cf3ad420bfef45dacbdd7d5181 Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Mon, 31 Jan 2011 19:16:09 +0100 Subject: [PATCH] Remove 'Mizi Research' copyright note --- hwpfilter/source/hiodev.h |5 - hwpfilter/source/hwpfile.h |5 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hwpfilter/source/hiodev.h b/hwpfilter/source/hiodev.h index e859a13..0811fab 100644 --- a/hwpfilter/source/hiodev.h +++ b/hwpfilter/source/hiodev.h @@ -26,11 +26,6 @@ * / -/** - * hwpio.h - * (C) 1999 Mizi Research, All rights are reserved - */ - #ifndef _HIODEV_H_ #define _HIODEV_H_ diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h index 787c65e..a691f7b 100644 --- a/hwpfilter/source/hwpfile.h +++ b/hwpfilter/source/hwpfile.h @@ -26,11 +26,6 @@ * / -// -// hwpfile.h -// (C) 1998 Mizi Research, All rights are reserved -// - #ifndef _HWPFILE_H_ #define _HWPFILE_H_ -- 1.7.3.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
Thanks for the update! Dave On 31-Jan-11, at 9:55 AM, Michael Meeks wrote: Hi Dave, On Mon, 2011-01-31 at 09:05 -0800, Dave Dumaresq wrote: Has there been any resolution to this? Yes ! Norbert just finished an amazing binary chop that brought it back to commit: libs-gui:ef70418ebf8b32f2d10abce61c0aa2c1011ced14 (a remove DECLARE_LIST in rsc) Which seems to break the code flow there :-) - leaving pSysEntry in an odd state ;-) I imagine it will be fixed soon ... HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] development summary: year 2011, week 4
Hi, this time a brief summary of what happened during the 4th week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release[*] There are two logs for each branch: + bugfixes-branch-year-week.txt lists all commits that reference a proper bug id from a variety of trackers, i.e. #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla + commit-log-branch-year-week.txt lists all relevant commits on the actual source repositories [*] the logs for the libreoffice-3-3-0 branch are not attached because they are empty; I am sure that there will be more life this week as the LO-3.3.1 release is getting close Many thanks to all contributors - you make all the difference! Best Regards, Petr + bootstrap + wrong line break with ( (fdo#31271) [Caolán McNamara] + writer + crash in changing header/footer object position (rhbz#673819) [Caolán McNamara] + fdo#33477: Implemented VertOrient on Writer table cell ranges (i#116420) [os] + rTF: escape special characters in style names (partially closes ) (fdo#33478) [Miklos Vajna] + these methods don't change anything and we don't use their results (83806) [Caolán McNamara] + libs-core + related: cancel gtk file-dialog on desktop::terminate (rhbz#672872) [Caolán McNamara] + related: more woes on rpm upgrade vs rpm erase (rhbz#610103) [Caolán McNamara] + help + oOo - LibO on Getting Support Page (fdo#33249) [Andras Timar] + ure + manipulate also the C runtime's environment (fdo#33355) [Tor Lillqvist] + libs-extern + don't segfault when test is built with debug. STL (rhbz#641350) [David Tardon] + libs-extern-sys + added Occitan spelling dictionary (fdo#33574) [Andras Timar] + added Russian spelling dictionary#i113873# (fdo#33571) [Andras Timar] + added Ukrainian dictionaries#i113874# (fdo#33595) [Andras Timar] + wrong line break with ( (fdo#31271) [Caolán McNamara] + libs-gui + archaic 'Berling Antiqua' claims to also be 'Times New Roman' (fdo#33349) [Caolán McNamara] + fix for # crash when moving through database types (fdo#32561) [Caolán McNamara] + fix scrollbars in themes that have no up/down buttons (fdo#33523) [Caolán McNamara] + fix various gtk+ theme integration annoyances, (fdo#32186) [Lucas Baudin] + related: create a unit test for the line break iterator (fdo#31271) [Caolán McNamara] + related: document one-liner to disable it for testing (fdo#31016) [Caolán McNamara] + try some bandaids to improve Arabic rendering (fdo#31016) [Khaled Hosny] + wrong line break with ( (fdo#31271) [Caolán McNamara] + year of era in long format for zh_TW by default (fdo#33459) [Cédric Bosdonnat] + testing + Default Formatting - Clear Direct Formatting [Octavio Alvarez] + add .gitattributes for proper handling of .doc and .sdw files. [Thomas Arnhold] + add new files [Caolán McNamara] + bypass this directory unless SOLAR_JAVA [Tor Lillqvist] + get smoketest working after save as old bin format removed [Caolán McNamara] + include the wntmscx build directories [Tor Lillqvist] + artwork + include the wntmscx build directories [Tor Lillqvist] + removed obsolete starwars images [Andras Timar] + components + added Occitan dictionary [Andras Timar] + added Ukrainian dictionaries [Andras Timar] + bypass if no SOLAR_JAVA [Tor Lillqvist] + cpp cleanliness: check for assignment to self [An Leenders] + cpp cleanliness: redundant assignment to self [Kenneth Venken] + cppcheck: variable never used [Andy Holder] + crash on changing position of drawing object in header [Caolán McNamara] + fix fallout of WIN_ULONG change in pre/postsys.h [Tor Lillqvist] + fix minor ULONG glitch [Tor Lillqvist] + include the wntmscx build directories [Tor Lillqvist] + reg4allmsdoc updated to use the new registry file extension IDs [Jesús Corrius] + remove FS_PRIV_DEBUG directive. [Thomas Arnhold] + remove FUTURE. [Thomas Arnhold] + remove dangerously broken = operator [Caolán McNamara] + remove double line spacing and make long virtuals readable. [Thomas Arnhold] + remove some dead code. [Thomas Arnhold] + remove superfluous empty lines at end [Tor Lillqvist] + replace empty equalsAscii() with getLength(). [Thomas Arnhold] + use SetWindowLongPtr [Tor Lillqvist] + waE: gcc 4.6.0 various warnings [Caolán McNamara] + waE: various new gcc 4.6.0 warnings [Caolán McNamara] + filters + add .gitattributes for proper handling of .doc and .sdw files. [Thomas Arnhold] + ccpcheck: unused variable [Andy Holder] + class Sw3Writer in binfilter deleted [Pierre-André Jacquod] + cleanup the code a little [Joseph Powers] + code cleanup [Joseph Powers] + comment removed, fixed
Re: [Libreoffice] building index at Win32 install time ...
ie. which piece of existing code do we base this on, and where is it ? Well, the sellang custom action is pretty minimal, and is written in very C-like fashion (as it was I that wrote it, many years ago;). A single entry point: SelectLanguage which is called from msiexec when running the installer. (However, sellang is called early in the installation sequence to de-select the presumably-unwanted components, while the indexing custom action should be called pretty late.) Does the existing indexing code use LibreOffice libraries? In that case it is best to keep it as a separate program which is always installed, and just have the custom action run it as a separate process (after putting the required directories into PATH so that the libraries the indexing program needs will be found). --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kicking off 3rdparty packages
On Mon, Jan 31, 2011 at 01:27:07PM +, Michael Meeks wrote: Francois: I expect you to google Tor Lillqvist, and think a bit more before typing. I'm sure Tor is a nice fellow; I'm sorry if some of my mails seemed rude, that was not my intent. this does not mean it is worthless having generic builds - particularly since we have a QA team that is dispersed across many Linux's. I never said it was; I merely objected to the inclusion of out-of-date and unmaintained software in LO. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
On Mon, Jan 31, 2011 at 8:53 PM, Steven Butler sebut...@gmail.com wrote: Does the existing indexing code use LibreOffice libraries? In that case it is best to keep it as a separate program which is always installed, and just have the custom action run it as a separate process (after putting the required directories into PATH so that the libraries the indexing program needs will be found). I can answer this quickly. The index code is now in git in dictionaries/source/idxdict.cpp. It is very simple and uses only STL and libstdc++ (in my recollection). It currently expects the dictionary to come in on stdin, but this is easy to change to use two arguments and open its own input file if need be. Would it be simpler to ship the idxdict utility in the installer and run it from a cmd window (visually unappealing but I've seen similar on windows) :) We can always hide the cmd window, it's easy ;) -- Jesús Corrius je...@softcatala.org Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] freebsd support
Hi Baptiste, On Mon, 2011-01-31 at 18:49 +0100, Baptiste Daroussin wrote: Here are the first patch for freebsd support : Great; thanks pushed them all. Of course those patches are in any license you want that best fits your needs :) I'll take that as LGPLv3+/MPL ;-) The other patch are not included as they need more work, and I don't know how to integrate them cleanly. Thanks. For example using bsdtar (libarchive) instead of GNU tar perfectly works to may be there should be a test in configure.in to allow bsdtar as well as gnu tar Riight - so, perhaps we should have two binaries we can use, and detect bsdtar and use that only if we don't have gnu tar. Another patch is that build/libreoffice/oox/util/makefile.mk needs to link to -lcrypto on freebsd. Don't know how to integrate that cleanly That is odd indeed. I would expect that should live in solenv/inc/libs.mk - which also mentions -lcrypto. building with java bring a problem apache-commons/java/*/makefile.mk because the ANT_OPT line fails with our openjdk6 or our version of ant, don't know. It leads to a class def not found exception, searching -Dencoding... in classpath Nasty :-) commenting out the ANT_OPT line fix the problem. Again - I suspect we'll need to do some more top to bottom work to detect and adapt to these things. Its a great start though; thanks ! All the best, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
We can always hide the cmd window, it's easy ;) You mean *console* window. No cmd.exe involved when running a console exe from a gui exe (unless it is specifically cmd.exe that you run), even if a console window shows up. And indeed, it is trivial to build the program to be run as a gui exe instead, a single linker switch. At least you didn't say DOS window;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
I can answer this quickly. The index code is now in git in dictionaries/source/idxdict.cpp. It is very simple and uses only STL and libstdc++ (in my recollection). OK, so on Windows it then uses the stlport library shipped with LO (if at all; I guess it also is possible that all STL code it uses comes from headers?) Would it be simpler to ship the idxdict utility in the installer and run it I think so, yes. Especially if we install it in the same folder where the stlport dll gets installed so that no PATH manipulation is necessary. We certainly don't want to start loading the stlport dll dynamically in the custom action and look up the STL entry points needed, as they presumably are overridden operators and whatnot that have horrible mangled names, and it would be extremely, eh, interesting, to call such through pointers and totally defeat the purpose of using STL in the first place;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
On Mon, Jan 31, 2011 at 9:14 PM, Tor Lillqvist tlillqv...@novell.com wrote: We can always hide the cmd window, it's easy ;) You mean *console* window. No cmd.exe involved when running a console exe from a gui exe (unless it is specifically cmd.exe that you run), even if a console window shows up. And indeed, it is trivial to build the program to be run as a gui exe instead, a single linker switch. At least you didn't say DOS window;) Wouldn't be the first time that I have to capture the handle of a DOS window and then send a SW_HIDE message to it ;) But yes, you are absolutely right. -- Jesús Corrius je...@softcatala.org Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] building index at Win32 install time ...
On 1 February 2011 06:19, Tor Lillqvist tlillqv...@novell.com wrote: OK, so on Windows it then uses the stlport library shipped with LO (if at all; I guess it also is possible that all STL code it uses comes from headers?) On Windows why can it not use the native STL available there? Is it because you need to be able to build with non-MS compilers which don't come with appropriate redistributable libraries? Anyway, here's what it links to on Linux (Ubuntu 10.10): $ ldd idxdict linux-vdso.so.1 = (0x7fff539a3000) libpthread.so.0 = /lib/libpthread.so.0 (0x7f919f183000) libstdc++.so.6 = /usr/lib/libstdc++.so.6 (0x7f919ee7d000) libm.so.6 = /lib/libm.so.6 (0x7f919ebf9000) libgcc_s.so.1 = /lib/libgcc_s.so.1 (0x7f919e9e3000) libc.so.6 = /lib/libc.so.6 (0x7f919e66) /lib64/ld-linux-x86-64.so.2 (0x7f919f3c9000) Regards Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On Mon, 2011-01-31 at 15:17 +, Michael Meeks wrote: Hi Steve, On Sat, 2011-01-29 at 21:45 +1000, Steve Butler wrote: If the thesaurus is only loaded when the user pops it up, then couldn't mythes be taught to generate its own in-memory index from the dictionary and not bother with an index file at all? Right. I think we could easily serialize a small skip-list to disk too - if we simply store ~8 or ~32 or so indexes into the data - we can parse only a fraction of it, and pop that in our home directory. We could also drop the MyThes code too as a depedency to manage. The code using it is in: lingucomponent/source/thesaurus/libnth/nthesimp.cxx BTW, if I did that I'd probably do some major surgery on mythes and just use STL because it basically is doing C style memory management and processing and I think I would screw it up if I started messing with it. The only problem with simplifying it with STL constructs is that I would want to change the interface (string vs char *), maybe use STL vectors for the list of synonyms, etc. Heh; sure. By this stage it's not looking much like mythes anymore ... FWIW, I'm sure Nemeth would be interested if you e.g. wanted to create a reimpl of mythes that was faster than the original and perhaps simply designate the optimized version the new mythes version with an API/ABI change :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
Hi Michael On 1 February 2011 01:17, Michael Meeks michael.me...@novell.com wrote: Hi Steve, Sure - so; in response to user input I suspect we can take a second to parse the thesaurus; we have around 20Mb of text to load for en_US; perhaps 32Mb is a reasonable upper-bound; it does seem a lot to parse so quickly. Where it will hurt is if it is not in cache and the user has some background task running that hits the disk. An example might be on Windows with virus scanning (or viruses :) ). Right. I think we could easily serialize a small skip-list to disk too - if we simply store ~8 or ~32 or so indexes into the data - we can parse only a fraction of it, and pop that in our home directory. We could also drop the MyThes code too as a depedency to manage. I'm not sure what you mean by a skip list unless you simply mean a similar file to the existing .idx, or just a list of offsets for where the words are to skip loading the whole file. The trouble with that approach is the readahead will likely pull in the whole file anyway as the words aren't generally _that_ far apart in it, so you'll still do all the IO and just skip a bit of the CPU time. The code using it is in: lingucomponent/source/thesaurus/libnth/nthesimp.cxx BTW, if I did that I'd probably do some major surgery on mythes and just use STL because it basically is doing C style memory management and processing and I think I would screw it up if I started messing with it. The only problem with simplifying it with STL constructs is that I would want to change the interface (string vs char *), maybe use STL vectors for the list of synonyms, etc. Heh; sure. I've cooled off on this a bit as performance is slower when using lots of strings etc. I was able to change the approach to loading the idx to treat it as a big buffer and sped it up considerably too. This did mean resorting to lots of pointer tomfoolery but it is easy to cleanup as there are only 3 allocations instead of 100k+ worth. I guess we could re-write it inside lingucomponent then (?) but we should prolly get a better understanding of how frequently this code is called first - is it hooked into from the spell checking code ? or is it really just the Tools-Language-Thesaurus ? It's actually hooked into the right click menu (probably amongst other things). The first time you right click on a word, the dictionary for the current locale is loaded before the right click menu shows up. After that, it uses the cached thesaurus dictionary for subsequent lookups. If you look in your right-click menu, you'll notice a thesaurus list of synonyms shows up (assuming the word is found) :). Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
Hi Dave, On Mon, 2011-01-31 at 10:21 -0800, Dave Dumaresq wrote: Thanks for the update! Just pushed a fix; the unfortunate random re-use of poorly scoped local variables made this hard to see in the patch. IMHO we need to be locally scoping all variables as tightly as possible when we touch code. Anyhow; the problem luckily showed in valgrind: ==17596== Conditional jump or move depends on uninitialised value(s) ==17596==at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*, unsigned long, unsigned long, unsigned char) (rscdb.cxx:388) ==17596==at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*, unsigned long, unsigned long, unsigned char) (rscdb.cxx:388) ==17596==by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST const, RscWriteRc, RscTypCont*, unsigned long, unsigned char, unsigned char) (rscclass.cxx:1095) ==17596==by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST const, RscWriteRc, RscTypCont*, unsigned long, unsigned char, unsigned char) (rscclass.cxx:1095) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
On Mon, 2011-01-31 at 19:20 +0100, Thomas Arnhold wrote: There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? Heh, probably not. In this case what you could do I guess is to file a bug against the inheritors of the StarDivision/StarOffice/etc. copyrights and mention the file name that has the archaic copyright note on it. Those should all have probably been changed to Sun Microsystems, and then Oracle at each takeover/purchase point. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On 1 February 2011 06:30, Caolán McNamara caol...@redhat.com wrote: FWIW, I'm sure Nemeth would be interested if you e.g. wanted to create a reimpl of mythes that was faster than the original and perhaps simply designate the optimized version the new mythes version with an API/ABI change :-) I don't think there is any need for an API or ABI change as I'm shying away from an STL reimplementation. If optimisation is desired (probably not needed), reducing the string allocations by reading in the whole index file certainly helps (I cut down from 0.046 seconds with hot-cache to 0.019 seconds with hot cache to load the US dictionary. The speedup is similar on cold cache but I can't recall the numbers exactly - something like 0.1 seconds down to 0.05 seconds. I thought it would be possible to use the STL algorithms to do the binary search and/or use the map, but using all those strings and a map take considerably longer than all the strdups in the original (I recall about 0.08 seconds to load the index using STL map. I didn't measure lookup time but it would be very similar. Using STL vectors made it comparable, but then it turns out binary_search only tells you if an item exists, not its index which is kind of annoying. :) So at this point I think an STL rewrite would not result in a performance improvement, so would be an academic exercise. Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] translated some german comments
I do not have much time right now. So the comments in the file are not all translated yet. But every litte bit helps, right? :) Pascal From 6333f7553cac1fc558a5db66ca588a45af85eea4 Mon Sep 17 00:00:00 2001 From: Pascal Ullrich tentl...@web.de Date: Mon, 31 Jan 2011 21:38:55 +0100 Subject: [PATCH] Translated some german comments. --- sw/source/core/edit/autofmt.cxx | 64 +++--- 1 files changed, 32 insertions(+), 32 deletions(-) diff --git a/sw/source/core/edit/autofmt.cxx b/sw/source/core/edit/autofmt.cxx index 0e5cc8a..43872bf 100644 --- a/sw/source/core/edit/autofmt.cxx +++ b/sw/source/core/edit/autofmt.cxx @@ -59,7 +59,7 @@ #include pam.hxx #include edimp.hxx #include fesh.hxx -#include swundo.hxx // fuer die UndoIds +#include swundo.hxx // for the UndoId's #include poolfmt.hxx #include ndtxt.hxx #include txtfrm.hxx @@ -83,9 +83,9 @@ using namespace ::com::sun::star; //--- //JP 16.12.99: definition: -// from pos cPosEnDash to cPosEmDash all chars changed to endashes, -// from pos cPosEmDash to cPosEndall chars changed to emdashes -// all other chars are changed to the user configuration +// from pos cPosEnDash to cPosEmDash all chars changed to endashes, +// from pos cPosEmDash to cPosEndall chars changed to emdashes +// all other chars are changed to the user configuration const sal_Unicode pBulletChar[6] = { '+', '*', '-', 0x2013, 0x2014, 0 }; const int cnPosEnDash = 2, cnPosEmDash = 4, cnPosEnd = 5; @@ -96,23 +96,23 @@ const sal_Unicode cStarSymbolEmDash = 0x2014; SvxSwAutoFmtFlags* SwEditShell::pAutoFmtFlags = 0; -// Anzahl von Num-/Bullet-Absatzvorlagen. MAXLEVEL wird demnaechst auf -// x erhoeht, die Anzahl Vorlagen aber nicht (Ueberbleibsel aus = 4.0) +// Number of num-/bullet-paragraph templates. MAXLEVEL will soon be raised +// to x, but not the number of templates. (Artifact from = 4.0) const USHORT cnNumBullColls = 4; class SwAutoFormat { SvxSwAutoFmtFlags aFlags; -SwPaM aDelPam;// ein Pam der benutzt werden kann -SwNodeIndex aNdIdx; // der Index auf den akt. TextNode -SwNodeIndex aEndNdIdx; // Index auf das Ende vom Bereich +SwPaM aDelPam;// a Pam that can be used +SwNodeIndex aNdIdx; // the index on the current TextNode +SwNodeIndex aEndNdIdx; // index on the end of the area SwEditShell* pEditShell; SwDoc* pDoc; -SwTxtNode* pAktTxtNd; // der akt. TextNode -SwTxtFrm* pAktTxtFrm; // Frame vom akt. TextNode +SwTxtNode* pAktTxtNd; // the current TextNode +SwTxtFrm* pAktTxtFrm; // frame of the current TextNode CharClass* pCharClass; // Character classification -ULONG nEndNdIdx; // fuer die Prozent-Anzeige +ULONG nEndNdIdx; // for the percentage-display LanguageType eCharClassLang; USHORT nLastHeadLvl, nLastCalcHeadLvl; @@ -175,7 +175,7 @@ class SwAutoFormat String GoNextPara(); BOOL HasObjects( const SwNode rNd ); -// TxtNode Methoden +// TxtNode methods const SwTxtNode* GetNextNode() const; BOOL IsEmptyLine( const SwTxtNode rNd ) const { return 0 == rNd.GetTxt().Len() || @@ -198,7 +198,7 @@ class SwAutoFormat USHORT GetDigitLevel( const SwTxtNode rTxtNd, xub_StrLen rPos, String* pPreFix = 0, String* pPostFix = 0, String* pNumTypes = 0 ) const; -// hole den FORMATIERTEN TextFrame +// get the FORMATED TextFrame SwTxtFrm* GetFrm( const SwTxtNode rTxtNd ) const; void BuildIndent(); @@ -212,15 +212,15 @@ class SwAutoFormat BOOL HasBreakAttr( const SwTxtNode ) const; void DeleteSel( SwPaM rPam ); BOOL DeleteAktNxtPara( const String rNxtPara ); -// loesche im Node Anfang oder/und Ende +// delete in the node start and/or end void DeleteAktPara( BOOL bStart = TRUE, BOOL nEnd = TRUE ); void DelEmptyLine( BOOL bTstNextPara = TRUE ); -// loesche bei mehrzeiligen Absaetzen die linken und/oder -// rechten Raender +// when using multiline paragraphs delete the left and/or +// right margins void DelMoreLinesBlanks( BOOL bWithLineBreaks = FALSE ); -// loesche den vorherigen Absatz +// delete the previous paragraph void DelPrevPara(); -// dann lasse doch mal das AutoCorrect auf den akt. TextNode los +// execute AutoCorrect on current TextNode void AutoCorrect( xub_StrLen nSttPos = 0 ); BOOL CanJoin( const SwTxtNode* pTxtNd ) const @@ -234,7 +234,7 @@ class SwAutoFormat !HasBreakAttr( *pTxtNd ); } -// ist ein Punkt am Ende ?? +// is a dot at the end ?? BOOL IsSentenceAtEnd( const SwTxtNode rTxtNd ) const; BOOL DoUnderline(); @@ -266,7 +266,7 @@ const sal_Unicode* StrChr( const sal_Unicode* pSrc, sal_Unicode c ) SwTxtFrm* SwAutoFormat::GetFrm( const SwTxtNode
Re: [Libreoffice] Should the Thesaurus/mythes use a precomputed index (installer file size)
On 31 January 2011 23:14, Tor Lillqvist tlillqv...@novell.com wrote: (Hmm, was this message intentionally not to the list?) An accident, list ccd. So after looking at the wiki I wasn't able to find any instructions on how one would go about building the Windows installer. Are the instructions the same as for other platforms? Yes and no; if you mean some make install or make dev-install, those don't make sense. (I don't even know what they might do in a Windows LibreOffice build environment.) Just doing a normal build successfully on Windows, you end up with an (MSI-based) installer. And if you happen to have NSIS on the machine (optional), also a NSIS wrapper of that, a single executable. What toolchain needs to be installed? Is it cygwin, mingw, or MSVC? Cygwin and MSVC2008 or MSVC2010. The Express editions are supposed to work, I think. I could use MSVC2008 express which I already have installed. Would the build work over an SMB share? I don't really want to redownload the whole lot (bandwidth is limited on Australian broadband plans) - so failing doing it over SMB, would copying my existing git repos over to the Windows machine allow an attempt at a build without too much breakage? There's obviously a lot of linux product already in that build tree. And a bunch of other dependencies, but I think their download should now be nicely automated, at least in master. Not 100% automated in the 3-3 branch. (Note that in the 3-3 branch I think one should not attempt a Windows build in the new way (directly in the directory from the bootstrap repo), but just do it the old way, in the directory from the build repo.) Once the toolchain is there, is there a special target for the windows installer? It gets built in the instsetoo_native module. The actual dmake target name used in its util/makefile.mk is something like openoffice_en-US I think (yes, we should change those openoffice strings there to libreoffice). The MSI installer (.msi and .cab files, setup.exe, and various small other bits) ends up in wntmsci12.pro/LibreOffice/msi/install/native/en-US or somesuch place. So do I simply type make at the command line under windows? Hmmm. seems I already have gnu make in my path on windows from the mingw Ruby build dev build framework as well. I wonder if that would work okay or if I'd need to remove that tool chain from my path to stop things getting confusing? Time for work... will hopefully look into this tonight ... --tml -- Regards, Steven Butler ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Design Team Kick-Off Step 2: Current Status of Work and Collaboration
Hi all, this mail announces the second step of our official Design Team Kick-Off. It is about what we've done so far, and how we did it - thus, it aims to get everybody on track who is interested to join, or to collaborate. Current Status of Work and Collaboration: http://wiki.documentfoundation.org/Design/Kick-Off/CurrentWorkStatus I've CCed the other teams, since they might be interested in those topics as well ... Background: A few days ago, we've agreed on how to set up our Design Team, and we've invited other parties to join - people having interest in user experience, visual identity design, accessibility, and user support and training. Together, we'll aim for Make it just work, and look great, too! Design Team Kick-Off Page: http://wiki.documentfoundation.org/Design/Kick-Off Cheers, Christoph PS: Thanks to all who helped to fill / improve the content of the page. And to everyone else, who continued to work on other topics :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Ok, I wondered because this copyright notice is only inside two files of hwpfilter. But you're right, they have to the rights on it. -Thomas On 01/31/2011 07:30 PM, Norbert Thiebaud wrote: On 1/31/11, Thomas Arnhold tho...@arnhold.org wrote: Hi, I'm not really sure about this. There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? Unless you are the copyright holder for these particular file, I'd say no, you can't remove copyright notice. Norbert -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Thanks. Filed a bug #33782. -Thomas On 01/31/2011 09:44 PM, Caolán McNamara wrote: On Mon, 2011-01-31 at 19:20 +0100, Thomas Arnhold wrote: There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? Heh, probably not. In this case what you could do I guess is to file a bug against the inheritors of the StarDivision/StarOffice/etc. copyrights and mention the file name that has the archaic copyright note on it. Those should all have probably been changed to Sun Microsystems, and then Oracle at each takeover/purchase point. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
On Mon, Jan 31, 2011 at 2:43 PM, Michael Meeks michael.me...@novell.com wrote: Hi Dave, On Mon, 2011-01-31 at 10:21 -0800, Dave Dumaresq wrote: Thanks for the update! Just pushed a fix; the unfortunate random re-use of poorly scoped local variables made this hard to see in the patch. IMHO we need to be locally scoping all variables as tightly as possible when we touch code. the 'daily' build passed on mac. uploading now... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kicking off 3rdparty packages
On 31/01/11 00:32, Enrico Weigelt wrote: Little bit trickier when putting on a ISV hat and trying to target all Linux distros One binpkg for all distros ?! The whole idea of this is stupid. Some of my customers didn't listen to me and tried that at any cost, they failed miserably. I haven't the slightest bit if pity ;-o Dare I suggest you take a look at lilypond? Free Software. And that is precisely what they ship - a single package that will install on any distro! The system is called GUB (for Grand Universal Binary). And it's pretty successful. I'm not sure to what extent it's lilypond-specific - I know it's not *meant* to be, but as they are the only project I know of that use it, there's a good chance there are a fair few lilypond-isms in it. And lilypond is a big mix of things, it's mostly written in Scheme, but has a lot of low-level code written in C++, used to invoke latex, uses ghostscript, has a chunk of python or perl or some other scripting language in there. Etc etc. So one binary for all distros isn't that unachievable ... :-) Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Cleaned up in dpsave.hxx/.cxx
Hi Soeren, On Mon, 2011-01-31 at 22:33 +0100, Soeren Moeller wrote: Hi Here five patches cleaning up in dpsave.hxx/.cxx in sc 0001: replacing tools/solar.h data types by sal data types 0002: cleaning up spacings 0003-0005: replacing String with OUString in the three classes, and changing necessary call sites the patches compile fine and calc seems to work as expected. Good. I applied all of them, but I have some feedback. Patch 0002 basically does change the coding styles. Most of the changes looked ok and I applied the whole patch, but some parts were a bit too aggressive. For instance, in some class declaration the class data member names were aligned as well as their data types (like this) SomeData maData; OtherData maOther; MyFoo maFoo; .. and you've basically flattened them to SomeData maData; OtherData maOther; MyFoo maFoo; While this didn't bother me (and applied it), I'm sort of neutral on this, and other people may have different preferences. Also, I had to make some follow-up changes to some of your patches. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=750e245c50ac0bac25305ed579bd3cc80963e916 The gist of it is that, when the original string is of OUString type, and the code creates a String instance from OUString instance, instead of creating yet another OUString instance from the 2nd String instance, let's eliminate the 2nd String instance and use the original OUString one directly. For example, instead of doing void someFunc(const OUString rName) { String aCopy = rName; if (pDim-GetName() == OUString(aCopy)) { it's better to void someFunc(const OUString rName) { if (pDim-GetName() == rName) { and cleaner this way. Also this follow-up commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=000bc293630164213aa5051d71c04febc0bf038c uses rtl::OUStringBuffer instead of rtl::OUString when you need to append to an existing string value many times. With plain OUString, each time you append a new string segment, it creates a new string instance instead of appending to the original string. OUStringBuffer doesn't do that, as it appends to the original string array. So, whenever you need to append to the original string instance, OUStringBuffer should be the preferred choice. dpsave.hxx/.cxx still depend on tools/string as it is used in DBG_... macros (supposedly from tools/debug), are those still used/meaningful? I don't use them, and I don't mind them gone. Feel free to remove them. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] USE_GMAKE=1 make - chmod errors
Hullo List (Norbert), I've finally found some time to get back to LO dev (yay!). But only for about 10 minutes (boo!). I've checked out the gnumake2.1 branch and made things the usual way: a successful build. When I execute make with USE_GMAKE=1, however, I'm getting lots of 'chmod: cannot access' errors. Is that currently expected? $ make clean [ ... ] $ make [... Successful build ...] $ USE_GMAKE=1 make clean [... clean ALL ...] $ USE_GMAKE=1 make ... chmod: cannot access `;': No such file or directory ... So far, it seems to be building fine, but the output is rather large. I've attached a small snippet of my build log, which includes over 2,300 chmod ';' errors against a single module -- boost, I think. Advice? Transient, currently not-a-big-fish error? Kevin GMAKE_make_output.txt.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] [EPS Export] Fix Save as Picture
Hi, Currently Save as Picture feature in Writer, Impress, or Draw produces a broken EPS file when I save an image as EPS format. # Export feature produces a correct file. Here is a patch to fix this issue. The patch is under the LGPLv3+ / MPL. Cheers, -- KUROSAWA Takeshi taken@gmail.com From d9b1a6593bc34cd074ae469f648c6926d30e52e4 Mon Sep 17 00:00:00 2001 From: Takeshi Kurosawa taken@gmail.com Date: Tue, 1 Feb 2011 13:30:33 +0900 Subject: [PATCH] [EPS Export] Fix Save as Picture Currently Save as Picture produces a broken eps file. --- filter/source/graphicfilter/eps/eps.cxx | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx index dd127e0..88c2b86 100644 --- a/filter/source/graphicfilter/eps/eps.cxx +++ b/filter/source/graphicfilter/eps/eps.cxx @@ -374,7 +374,16 @@ BOOL PSWriter::WritePS( const Graphic rGraphic, SvStream rTargetStream, Filter if ( rGraphic.GetType() == GRAPHIC_GDIMETAFILE ) pMTF = rGraphic.GetGDIMetaFile(); else -pMTF = pAMTF = new GDIMetaFile( rGraphic.GetGDIMetaFile() ); +{ +Bitmap aBmp( rGraphic.GetBitmap() ); +pAMTF = new GDIMetaFile(); +VirtualDevice aTmpVDev; +pAMTF-Record( aTmpVDev ); +aTmpVDev.DrawBitmap( Point(), aBmp ); +pAMTF-Stop(); +pAMTF-SetPrefSize( aBmp.GetSizePixel() ); +pMTF = pAMTF; +} aVDev.SetMapMode( pMTF-GetPrefMapMode() ); nBoundingX1 = nBoundingY1 = 0; nBoundingX2 = pMTF-GetPrefSize().Width(); -- 1.7.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Missing vcl resource. This indicates that files vital to localization are missing. You might have a corrupt installation.
the safest way is: make clean ./g pull -r (optional. if you want to get the very latest) ./autogen.sh (it automatically re-use the last parameters you used - see autogen.lastrun) make Norbert On Mon, Jan 31, 2011 at 10:39 PM, David Dumaresq dfdumar...@gmail.com wrote: Hi Michael, what is the correct way to re-build with the fixes in? I ran git pull, followed by ./autogen.sh --with-num-cpus=2 --with-max-jobs=2 --disable-mozilla --disable-systray 'CC=ccache gcc-4.0' 'CXX=ccache g++-4.0' ./configure '--with-num-cpus=2' '--with-max-jobs=2' '--disable-mozilla' '--disable-systray' 'CC=ccache gcc-4.0' 'CXX=ccache g++-4.0' I then ran make check, but have the same error coming up in starmath. Thanks, Dave On 2011-01-31, at 12:43 PM, Michael Meeks wrote: Hi Dave, On Mon, 2011-01-31 at 10:21 -0800, Dave Dumaresq wrote: Thanks for the update! Just pushed a fix; the unfortunate random re-use of poorly scoped local variables made this hard to see in the patch. IMHO we need to be locally scoping all variables as tightly as possible when we touch code. Anyhow; the problem luckily showed in valgrind: ==17596== Conditional jump or move depends on uninitialised value(s) ==17596== at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*, unsigned long, unsigned long, unsigned char) (rscdb.cxx:388) ==17596== at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*, unsigned long, unsigned long, unsigned char) (rscdb.cxx:388) ==17596== by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST const, RscWriteRc, RscTypCont*, unsigned long, unsigned char, unsigned char) (rscclass.cxx:1095) ==17596== by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST const, RscWriteRc, RscTypCont*, unsigned long, unsigned char, unsigned char) (rscclass.cxx:1095) HTH, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] USE_GMAKE=1 make - chmod errors
On Mon, Jan 31, 2011 at 10:46 PM, Kevin Hunter hunt...@earlham.edu wrote: Hullo List (Norbert), I've finally found some time to get back to LO dev (yay!). But only for about 10 minutes (boo!). I've checked out the gnumake2.1 branch and made things the usual way: a successful build. When I execute make with USE_GMAKE=1, however, I'm getting lots of 'chmod: cannot access' errors. Is that currently expected? This is a bug, unrelated to gnumake, that has been fixed in master (but not picked-up in the gnumake2.1 branch) you can ignore these for now. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] refactoring gendict
On Mon, Jan 31, 2011 at 6:04 AM, Kenneth Venken kenneth.ven...@gmail.com wrote: I think i've implemented all the suggestions. There's one hard coded limit (i 0x1FFF) i don't get. Why isn't it 0x2000 since existMark has a size of 0x1. I changed it to i 0x2000. This will not have an influence on xdictionary since the 0x1FFF limit is hardcoded there too. I'll look into xdictionary next to see if i can fix the fixme in gendict. Maybe then this will make sence to me too. I've also added support to print to standard output, but i don't know how to fix the build so it will pipe the output to the file. I have not made the time yet to process these... but I will, bear with me :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] over-long extensions manager list ...
Le 31/01/2011 11:15, Michael Meeks a écrit : Hi Jean, On Sun, 2011-01-30 at 13:55 +0100, Jean-Baptiste Faure wrote: No the problem is not there. It is in the long list of useless extensions / dictionaries in the Extensions Manager. Many users are afraid when they see this list. Ah ! :-) so - this is something else. We can certainly fix this; primarily by not packing those dictionaries as extensions I suspect. I am not sure : users population is very diversified ;-) and other users may be not happy if dictionaries would not be installed as extensions. I suggest to add a button in the extension manager Show all extensions and that the Extensions Manager shows by default only private extensions (installed by the current user). End-user want to have the choice. But, he does not want to look a little beyond the default installation. Sure sure - but ultimately, removing one confusing choice (tons of dictionaries in the extensions manager), by adding another confusing choice - an extra page response that no-one understands in the installer IMHO makes the matter only worse. Yes but instead of having the choice between default installation and custom installation, I suggest that the installer gives the alternative : 1/ choose yourself the components and dictionaries you want to be installed in this case select by default only the language of the locale. 2/ full installation : all components and all dictionaries will be installed Another possibilty is: 1/ only your locale (default) 2/ full installation 3/ choose yourself What is the software used to make the MS-Windows Installer ? NSIS ? So - Norbert is right (of course); but so are you. So - the good news is; that Steven was poking at the dictionary indexing code - which is in a similar area, and was going to look at packaging dictionaries just as bundled files, rather than as extensions - which *should* solve the problem for you. That involves a little digging in dictionaries/ (removing a -ton- of cut/paste makefile.mk-age), and some more prodding inside scp2/ to distribute the dictionaries in a different way. Hopefully that'll solve the problem for 3.4 - and/or if you're concerned - can you contact Steven and help out ? Anyhow - IMHO, there could have been a shorter thread here, if we had pinpointed the root problem that people complain about, and not one solution to it :-) but anyway: The length of the dictionaries list is one aspect of the problem. The other is: the user is frustrated when he suspects that the choice has been done without asking him. Thanks to all developers for their patience. :-) Best regards JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] USE_GMAKE=1 make - chmod errors
At 12:32am -0500 Tue, 01 Feb 2011, Norbert Thiebaud wrote: This is a bug, unrelated to gnumake, that has been fixed in master (but not picked-up in the gnumake2.1 branch) you can ignore these for now. Gracias. Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice