[Libreoffice] [PATCH] [FDO#31252] Overwrite dialog improvement

[Sébastien Le Ray]

Hello list,

Here is a patch for fdo#31252[1] which improves the overwrite dialog as
described in the bug.

I don't know if the second part of the bug about backuping overwritten
file is relevant, awaiting your advices on this.

Sebastien


[1] https://bugs.freedesktop.org/show_bug.cgi?id=31252
From 7587a74f285a12180a3e99d870003958f9b14c2b Mon Sep 17 00:00:00 2001
From: Sébastien Le Ray sebastien-libreoff...@orniz.org
Date: Thu, 10 Feb 2011 18:54:59 +0100
Subject: [PATCH] Fixes bug fdo#31252 - Overwrite dialog improvment.

---
 fpicker/source/office/iodlg.cxx |7 ++-
 fpicker/source/office/iodlg.src |2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index 7db9889..699081a 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -1247,7 +1247,12 @@ IMPL_STATIC_LINK( SvtFileDialog, OpenHdl_Impl, void*, pVoid )
 {
 if ( ::utl::UCBContentHelper::Exists( aFileObj.GetMainURL( INetURLObject::NO_DECODE ) ) )
 {
-QueryBox aBox( pThis, WB_YES_NO, SvtResId( STR_SVT_ALREADYEXISTOVERWRITE ) );
+String aMsg = SvtResId( STR_SVT_ALREADYEXISTOVERWRITE );
+aMsg.SearchAndReplace(
+String( RTL_CONSTASCII_USTRINGPARAM( $filename$ ) ),
+aFileObj.getName(INetURLObject::LAST_SEGMENT, true, INetURLObject::DECODE_WITH_CHARSET)
+);
+QueryBox aBox( pThis, WB_YES_NO, aMsg );
 if ( aBox.Execute() != RET_YES )
 return 0;
 }
diff --git a/fpicker/source/office/iodlg.src b/fpicker/source/office/iodlg.src
index af24bd0..08ad36f 100644
--- a/fpicker/source/office/iodlg.src
+++ b/fpicker/source/office/iodlg.src
@@ -280,7 +280,7 @@ String STR_FILTERNAME_ALL
 
 String STR_SVT_ALREADYEXISTOVERWRITE
 {
-Text [ en-US ] = The file already exists. Overwrite? ;
+Text [ en-US ] = A file named \$filename$\ already exists.\n\nDo you want to replace it? ;
 };
 
 String STR_SVT_NEW_FOLDER
-- 
1.7.2.3



signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Easy Task - remove non-compiled / dead code

[Jean Charles Papin]

Hi everyone,

I'm currently removing all non-compiled pieces of code. I don't know how to
edit the wiki page (for registered user only?), so I prefer inform you of my
intentions.
For that work, I've made a little C program (with reg-ex). I hope this will
work fine ;)

I'll send you my diff file soon !

-- 
Jean-Charles Papin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error with cppunit - Making install in DllPlugInTester

[Michael Meeks]

Hi Kishan,

On Fri, 2011-02-11 at 09:15 +0530, Kishan Bhat wrote:
 I'm trying to build LO.

On what platform (out of interest ?) is this some self-build linux by
any chance ? did you somehow disable dynamic linking while configuring
it ? ;-)

 and I get this error: http://pastebin.com/KcMu29Ja

make[2]: Entering directory
`/home/bhat/git/libo/clone/libs-extern/cppunit/unxlngi6.pro/misc/build/cppunit-1.12.1/src/DllPlugInTester'
/bin/bash ../../libtool --tag=CXX   --mode=link g++   -ldl  -o
DllPlugInTester DllPlugInTester.o
CommandLineParser.o ../../src/cppunit/libcppunit.la -lm
g++ -o .libs/DllPlugInTester DllPlugInTester.o CommandLineParser.o
 -ldl ../../src/cppunit/.libs/libcppunit.so -lm  -Wl,--rpath
-Wl,/home/bhat/git/libo/clone/libs-extern/cppunit/unxlngi6.pro/misc/build/cppunit-1.12.1/ooo-install/lib
./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlsym'
./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlopen'
./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlclose'

Looks like your libdl is causing grief - it would be interesting to
know what:

objdump -T /lib/libdl.so.2

says - surely it must define 'dlsym' ? :-) how could it not ? and your
link line contains that.

ATB,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] minor changes to font dialog

[Caolán McNamara]

Font Dialog now title font-family and font-style the same as the
underlying platform's default font dialogs do, i.e.

Windows: Font, Style, Size
http://msdn.microsoft.com/en-us/library/ms646958%28v=vs.85%29.aspx

MacOSX: Family, Typeface, Size
http://sketchup.google.com/crimages/layout-set-ShowFonts-mac-en.jpg

GNOME/Generic: Family, Style, Size
http://live.gnome.org/Design/GTKFontDialog/UsabilityEvaluations

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-3' - starmath/source

[Jan Holesovsky]

Hi Kevin,

On 2011-02-10 at 13:12 -0500, Kevin Hunter wrote:

   Fix for bugs 32759 and 32755 on freedesktop bugzilla
 
 Do we have guidelines for commit messages?  I ask because I think it 
 would be helpful to include just a smidgen more information in them than 
 a reference to various bugzillas.  (To be clear, it's not just you/r 
 messages, but you're the person I feel comfortable asking.)

My favorite form of the first line is:

area: Fixed this in that and the other thing, fdo#12345.

'Area' gives the overview what is it about, most notably when the
commits are part of some bigger picture; in my case I use that for the
wikihelp, like:

wikihelp: Improve check for existence of the localized help, fdo#33258.

Would be great if it become more widely used, but OTOH I think we are
still not in a situation to force that by a hook, or something.

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

[Michael Meeks]

On Fri, 2011-02-11 at 00:14 +, Luke Dixon wrote:
 I hope I'm not waffling but I'm very thankful to you guys for looking
 at this. And thanks for taking care of closing the bugs.

The pleasure really is entirely mine :-) thanks for your great work on
starmath !

Quick question, while I'm here: what are the blockers for enabling this
by default on master ? was it undo/redo ? or do we have any malingering
known crashers / mis-features left.

ATB,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Easy Task - Get rid of calls that put SfxPoolItems at Which-Ids different from their own into Itemsets

[Bjoern Michaelsen]

Hi all,

I added an easy task:

 
http://wiki.documentfoundation.org/Development/Easy_Hacks#Get_rid_of_calls_that_put_SfxPoolItems_at_Which-Ids_different_from_their_own_into_Itemsets

Comments welcome!

Best Regards,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] New feature: print current page

[Tobias Ollmann]

Hi all!

I'm rather new here, so I don't know if something similar has already
been posted. But I'm missing a very important feature in the printing
dialog, namly an option to print the current page only.

Are there plans to implement something like that?

Regards,
Tobias



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Patch] SVG export filter improvements

[KUROSAWA, Takeshi]

Hi, Throsten,

I express thanks for your review.
I was bit busy with school work. But here are updated patches.
0001 and 0003 are almost same as previous.

2011/2/2 Thorsten Behrens t...@documentfoundation.org:
 Nope, this is still in use, especially in legacy binary documents
 (soon to be axed I guess), and more importantly, for all those svm
 metafiles. Could you keep both code paths - i.e. falling back to the
 old code, should there be a step count (with 0 meaning smooth
 gradient, and maybe you can even cut off at something like 100 or so
 steps)?

I found the way to reproduce the stepping gradients with native gradients.
# Simply adding gradient stops as needed.
So 0002 patch uses native gradients for both smooth and non-smooth gradients.


 A bit orthogonal to this great improvement, let me point you to
 https://github.com/knobo/OOo-svg-Export.git - this is an early stage
 of a slightly different attempt, using the new drawing layer
 primitives (that contain more high-level geometry information, like
 stroking etc.). I attach two changes I had lying around locally -
 maybe you're also interested in looking into that.

It's very interesting and has a potential to resolve many long standing issues.
While it's really attractive, I would like to continue to improve the
current filter.
LibreOffice and its predecessors have never produced an SVG
preserving, at least, visual appearances.
Improving the current filter is the shortest path to make LibreOffice
export visual identical SVG files in a short term.
# I know the structure of an SVG produced by the current filter is mess.

Cheers,

--
Kurosawa Takeshi taken@gmail.com
From ba06cca17ff6fd112d8fd4ee9a16176c34de5205 Mon Sep 17 00:00:00 2001
From: Kurosawa Takeshi taken@gmail.com
Date: Fri, 11 Feb 2011 18:55:42 +0900
Subject: [PATCH 1/3] Export hatches and gradients as SVG patterns

This patch tends not to improve a visual look, but improve semantic
structure of an exported file.
---
 filter/source/svg/svgwriter.cxx |   85 +++
 filter/source/svg/svgwriter.hxx |3 +
 2 files changed, 62 insertions(+), 26 deletions(-)

diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index b33e84a..b0e2a0f 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -39,6 +39,7 @@
 static const char	aXMLElemG[] = g;
 static const char	aXMLElemDefs[] = defs;
 static const char	aXMLElemClipPath[] = clipPath;
+static const char	aXMLElemPattern[] = pattern;
 static const char	aXMLElemLine[] = line;
 static const char	aXMLElemRect[] = rect;
 static const char	aXMLElemEllipse[] = ellipse;
@@ -66,6 +67,7 @@ static const char	aXMLAttrRY[] = ry;
 static const char	aXMLAttrWidth[] = width;
 static const char	aXMLAttrHeight[] = height;
 static const char	aXMLAttrPoints[] = points;
+static const char	aXMLAttrPatternUnits[] = patternUnits;
 static const char	aXMLAttrXLinkHRef[] = xlink:href;
 
 // --
@@ -379,7 +381,8 @@ SVGActionWriter::SVGActionWriter( SvXMLExport rExport, SVGFontExport rFontExpo
 mrFontExport( rFontExport ),
 mpContext( NULL ),
 mbClipAttrChanged( sal_False ),
-mnCurClipId( 1 )
+mnCurClipId( 1 ),
+mnCurPatternId( 1 )
 {
 mpVDev = new VirtualDevice;
 mpVDev-EnableOutput( sal_False );
@@ -659,48 +662,81 @@ void SVGActionWriter::ImplWritePolyPolygon( const PolyPolygon rPolyPoly, sal_Bo
 
 // -
 
-void SVGActionWriter::ImplWriteGradientEx( const PolyPolygon rPolyPoly, const Gradient rGradient,
-   const NMSP_RTL::OUString* pStyle, sal_uInt32 nWriteFlags )
+void SVGActionWriter::ImplWritePattern( const PolyPolygon rPolyPoly,
+const Hatch* pHatch,
+const Gradient* pGradient,
+const NMSP_RTL::OUString* pStyle,
+sal_uInt32 nWriteFlags )
 {
 if( rPolyPoly.Count() )
 {
-SvXMLElementExport	aElemG( mrExport, XML_NAMESPACE_NONE, aXMLElemG, TRUE, TRUE );
-FastString			aClipId;
-FastString			aClipStyle;
+SvXMLElementExport aElemG( mrExport, XML_NAMESPACE_NONE, aXMLElemG, TRUE, TRUE );
 
-aClipId += B2UCONST( clip );
-aClipId += NMSP_RTL::OUString::valueOf( ImplGetNextClipId() );
+FastString aPatternId;
+aPatternId += B2UCONST( pattern );
+aPatternId += GetValueString( ImplGetNextPatternId() );
 
 {
 SvXMLElementExport aElemDefs( mrExport, XML_NAMESPACE_NONE, aXMLElemDefs, TRUE, TRUE );
 
-mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrId, aClipId.GetString() );
+mrExport.AddAttribute( XML_NAMESPACE_NONE, aXMLAttrId, aPatternId.GetString() );
+
+Rectangle aRect( ImplMap( rPolyPoly.GetBoundRect() ) );
+

Re: [Libreoffice] Issues for pivot tables ... where to post

[Cor Nouws]

Hi Kohei,

Kohei Yoshida wrote (08-02-11 16:10)

On Tue, 2011-02-08 at 13:23 +0100, Cor Nouws wrote:

Someone writes about an issue in OOo/Lo 330, that was not present in OOo
321.

Is it better to post that in Bugzilla or in the OOo IssueTracker?
(Currently I see one Pivot-issue - 33990 - in Bugzilla)


Let's put it in our bugzilla, and please assign that directly to me.


OK, done (thanks to Joop Bukker too)
https://bugs.freedesktop.org/show_bug.cgi?id=34107


I'm working on the data pilot code right now to fix several issues I
discovered have been broken since 3.3.  So, it's nice to know any
regressions to data pilot while I'm at it.


1st item is a difference between OOo and LibO
2nd a common issue, not a regression.

[ wrt the differences OOo / LibO: is there an overview of those, or if 
not, a pointer how to gain that information?
Currently I am just collecting them while working, and it seems to be 
more then I expected. So I hope there will be smarter way to get that 
info ;-)  ]



Thanks,
Cor

--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Easy Task - Get rid of calls that put SfxPoolItems at Which-Ids different from their own into Itemsets

[Caolán McNamara]

On Fri, 2011-02-11 at 11:24 +0100, Bjoern Michaelsen wrote:
 Hi all,
 
 I added an easy task:

I'd suggest giving a link to a git commit of a convert to use as an
example. e.g. if you fixed lcl_ExtendEditFontAttribs the way it should
be and linked to that diff.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New feature: print current page

[Cor Nouws]

Hi Tobias,

Tobias Ollmann wrote (11-02-11 12:28)


I'm rather new here, so I don't know if something similar has already
been posted. But I'm missing a very important feature in the printing
dialog, namly an option to print the current page only.


The old behaviour in OOo was
 - select option Pages, that default to the current page.
WHich is what you want.

With the new Printer Dialog, you can select Pages, but nor does it show 
the current page, nor does it get the focus,

IMO two usability bugs.


Are there plans to implement something like that?


Not that I am aware of.
But improving the behaviour in the current dialog would do too, IMO.

regards,
Cor


--
 - giving openoffice.org its foundation :: The Document Foundation -

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Patch

[Bálint Dózsa]

Hy!

I have removed this unused method:
writerfilter::dmapper::ConversionHelper::convertDateTime(rtl::OUString
const)

Regards,
Balint Dozsa
From 8cbdc7fed60f929c496dccce797290abc9fc1a00 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?B=C3=A1lint=20D=C3=B3zsa?= dozsabal...@gmail.com
Date: Fri, 11 Feb 2011 12:13:47 +0100
Subject: [PATCH] Remove unused method

---
 writerfilter/source/dmapper/ConversionHelper.cxx |   45 --
 1 files changed, 0 insertions(+), 45 deletions(-)

diff --git a/writerfilter/source/dmapper/ConversionHelper.cxx b/writerfilter/source/dmapper/ConversionHelper.cxx
index 824a3f6..3e4240e 100644
--- a/writerfilter/source/dmapper/ConversionHelper.cxx
+++ b/writerfilter/source/dmapper/ConversionHelper.cxx
@@ -375,7 +375,6 @@ bool lcl_IsNotAM(::rtl::OUString rFmt, sal_Int32 nPos)
 bool bForceNatNum(false);
 sal_Int32 nLen = sFormat.getLength();
 sal_Int32 nI = 0;
-//const sal_Unicode* pFormat = sFormat.getStr();
 ::rtl::OUStringBuffer aNewFormat( sFormat.getStr() );
 while (nI  nLen)
 {
@@ -515,51 +514,7 @@ sal_Int16 convertTableJustification( sal_Int32 nIntValue )
 }
 return nOrient;
 }
-/*-- 06.08.2007 15:27:30---
- conversion form xsd::DateTime
-[-]CCYY-MM-DDThh:mm:ss[Z|(+|-)hh:mm]
-  ---*/
-com::sun::star::util::DateTime convertDateTime( const ::rtl::OUString rDateTimeString )
-{
-util::DateTime aRet( 0, 0, 0, 0, 1, 1, 1901 );
-//
-sal_Int32 nIndex = 0;
-::rtl::OUString sDate( rDateTimeString.getToken( 0, 'T', nIndex ));
-sal_Int32 nDateIndex = 0;
-aRet.Year = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-if( nDateIndex  0)
-aRet.Month = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-if( nDateIndex  0)
-aRet.Day = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-::rtl::OUString sTime;
-if(nIndex  0) 
-{
-sTime = ( rDateTimeString.getToken( 0, 'Z', nIndex ));
-sal_Int32 nTimeIndex = 0;
-aRet.Hours = (sal_uInt16)sTime.getToken( 0, ':', nTimeIndex ).toInt32();
-if( nTimeIndex  0)
-aRet.Minutes = (sal_uInt16)sTime.getToken( 0, ':', nTimeIndex ).toInt32();
-if( nTimeIndex  0)
-{
-::rtl::OUString sSeconds = sTime.getToken( 0, ':', nTimeIndex );
-nTimeIndex = 0;
-aRet.Seconds = (sal_uInt16)sSeconds.getToken( 0, '.', nTimeIndex ).toInt32();
-aRet.HundredthSeconds = (sal_uInt16)sSeconds.getToken( 0, '.', nTimeIndex ).toInt32();
-}
-
-// todo: ignore time offset for a while - there's no time zone available 
-//nIndex = 0;
-//::rtl::OUString sOffset( rDateTimeString.getToken( 1, 'Z', nIndex ));
-//if( sOffset.getLength() )
-//{
-//  add hour and minute offset and increase/decrease date if necessary
-//}
-}
-return aRet;
-}
-/*-- 05.03.2008 09:10:13---
 
-  ---*/
 sal_Int16 ConvertNumberingType(sal_Int32 nNFC)
 {
 sal_Int16 nRet;
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] REVIEW: EMF+ disable on Win32 ...

[Michael Meeks]

Hi guys,

Talking to Radek (wrt. the EMF+ previews missing in action - ie. we
just get white images (apparently)) - from bug:

https://bugs.freedesktop.org/show_bug.cgi?id=33785

It seems that the quick workaround is appended;

diff --git a/svtools/source/filter.vcl/wmf/enhwmf.cxx 
b/svtools/source/filter.vcl/wmf/enhwmf.cxx
index cc50b1b..1dd5c64 100644
--- a/svtools/source/filter.vcl/wmf/enhwmf.cxx
+++ b/svtools/source/filter.vcl/wmf/enhwmf.cxx
@@ -348,7 +348,7 @@ BOOL EnhWMFReader::ReadEnhWMF()
 static sal_Bool bEnableEMFPlus = ( getenv( EMF_PLUS_DISABLE ) == NULL );
 #else
 // TODO: make it possible to disable emf+ on windows
-static sal_Bool bEnableEMFPlus = sal_True;
+static sal_Bool bEnableEMFPlus = sal_False;
 #endif
 
 while( bStatus  nRecordCount-- )

And hopefully, then we will fall back (where it is present) to the EMF
(not EMF+) or WMF preview instead.

Jesus - it'd be wonderful if you could do a test of that (?) otherwise,
other reviews appreciated.

Tor - rumour has it that you looked at getting this working on Windows,
the interaction is with vcl/source/gdi/gdimtf.cxx incidentally and some
UNO-ised canvas pieces I guess.

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...

[Tor Lillqvist]

   Tor - rumour has it that you looked at getting this working on Windows,

Maybe, but that was a long time ago, and I certainly didn't get anywhere as far 
as I can recall...

--tml

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] GentooOnly cleanup and 64bit jdk server path (sun/oracle jdk)

[Hanno Meyer-Thurow]

Hi all,
attached is one patch to libreoffice/build tree branch libreoffice-3-3
that just cleans up the Gentoo patchset. You may merge it to the
libreoffice-3-3-1 branch as well, please.

The second patch, to accept the 64bit jdk server path of sun/oracle jdk
to libjvm.so, may be valid to any branch of libreoffice/ure


http://cgit.freedesktop.org/libreoffice/build/tree/patches/64bit/64bit-jdk-server-paths.diff

That would be great to be merged.


Regards,
HannoFrom cc3cff24234ca1f853f6d1e9149e30a12552dd90 Mon Sep 17 00:00:00 2001
From: Hanno Meyer-Thurow h@web.de
Date: Fri, 11 Feb 2011 13:09:06 +0100
Subject: [PATCH] (GentooOnly) Clean up patchset.

Long overdue removal of old patches.

* patches/dev300/apply: clean up
* patches/dev300/gentoo-pax-fix.diff: bin
* patches/dev300/ibm-j9vm.diff: bin
* patches/dev300/system-db-check.diff: bin

 delete mode 100644 patches/dev300/gentoo-pax-fix.diff
 delete mode 100644 patches/dev300/ibm-j9vm.diff
 delete mode 100644 patches/dev300/system-db-check.diff

diff --git a/patches/dev300/apply b/patches/dev300/apply
index c47179f..f7552f7 100755
--- a/patches/dev300/apply
+++ b/patches/dev300/apply
@@ -876,16 +876,8 @@ win32-gw-send-mail.diff, i#34264, n#418407, tml
 [ GentooOnly ]
 SectionOwner = aprosky
 
-# Allow build to proceed with PaX enabled
-gentoo-pax-fix.diff, aprosky
 # support server-only versions of 64bit JDKs
 64bit-jdk-server-paths.diff, i#65974, hmth
-# use IBM j9vm over IBM classic JVM
-ibm-j9vm.diff, hmth
-# system db check
-system-db-check.diff, i#65979, hmth
-# User ~/.ooo3 as user dir
-scp2-user-config-ooo3.diff, pmladek
 # default inc/lib
 config_office-XINC-XLIB-defaults.diff, i#65976
 # Sandbox problem with wrong path
diff --git a/patches/dev300/gentoo-pax-fix.diff b/patches/dev300/gentoo-pax-fix.diff
deleted file mode 100644
index e0b4700..000
--- a/patches/dev300/gentoo-pax-fix.diff
+++ /dev/null
@@ -1,26 +0,0 @@
 solenv/inc/unxlngi4.mk.orig	2005-10-29 17:09:48.0 +0200
-+++ solenv/inc/unxlngi4.mk	2005-10-29 17:18:46.0 +0200
-@@ -138,8 +138,8 @@
- LINKFLAGS=-z combreloc $(LINKFLAGSDEFS) $(LINKFLAGSRUNPATH)
- 
- # linker flags for linking applications
--LINKFLAGSAPPGUI= -Wl,-export-dynamic -Wl,--noinhibit-exec
--LINKFLAGSAPPCUI= -Wl,-export-dynamic -Wl,--noinhibit-exec
-+LINKFLAGSAPPGUI= -Wl,-export-dynamic -Wl,--noinhibit-exec -Wl,-z,execheap
-+LINKFLAGSAPPCUI= -Wl,-export-dynamic -Wl,--noinhibit-exec -Wl,-z,execheap
- 
- # linker flags for linking shared libraries
- LINKFLAGSSHLGUI= -shared
 solenv/inc/unxlngi6.mk.orig	2005-10-29 17:16:27.0 +0200
-+++ solenv/inc/unxlngi6.mk	2005-10-29 17:19:08.0 +0200
-@@ -147,8 +147,8 @@
- LINKFLAGS=-Wl,-z,combreloc $(LINKFLAGSDEFS) $(LINKFLAGSRUNPATH)
- 
- # linker flags for linking applications
--LINKFLAGSAPPGUI= -Wl,-export-dynamic -Wl,--noinhibit-exec
--LINKFLAGSAPPCUI= -Wl,-export-dynamic -Wl,--noinhibit-exec
-+LINKFLAGSAPPGUI= -Wl,-export-dynamic -Wl,--noinhibit-exec -Wl,-z,execheap
-+LINKFLAGSAPPCUI= -Wl,-export-dynamic -Wl,--noinhibit-exec -Wl,-z,execheap
- 
- # linker flags for linking shared libraries
- LINKFLAGSSHLGUI= -shared
diff --git a/patches/dev300/ibm-j9vm.diff b/patches/dev300/ibm-j9vm.diff
deleted file mode 100644
index 1e865fd..000
--- a/patches/dev300/ibm-j9vm.diff
+++ /dev/null
@@ -1,20 +0,0 @@
 jvmfwk/plugins/sunmajor/pluginlib/otherjre.cxx.orig	2006-08-16 12:13:05.0 +0200
-+++ jvmfwk/plugins/sunmajor/pluginlib/otherjre.cxx	2006-08-16 12:14:30.0 +0200
-@@ -76,6 +76,8 @@
- #ifdef MACOSX
- /../../../JavaVM
- #else
-+/bin/j9vm/libjvm.so, // for IBM Java
-+/jre/bin/j9vm/libjvm.so, // for IBM Java
- /lib/ JFW_PLUGIN_ARCH /client/libjvm.so, // for Blackdown PPC
- /lib/ JFW_PLUGIN_ARCH /server/libjvm.so, // for Blackdown AMD64
- /lib/ JFW_PLUGIN_ARCH /classic/libjvm.so, // for Blackdown PPC
-@@ -101,6 +103,8 @@
- #else
- /bin,
- /jre/bin,
-+/bin/j9vm,
-+/jre/bin/j9vm,
- /bin/classic,
- /jre/bin/classic,
- /lib/ JFW_PLUGIN_ARCH /client,
diff --git a/patches/dev300/system-db-check.diff b/patches/dev300/system-db-check.diff
deleted file mode 100644
index 4ab65e8..000
--- a/patches/dev300/system-db-check.diff
+++ /dev/null
@@ -1,69 +0,0 @@
 configure.in.orig	2007-07-15 16:45:32.0 +0200
-+++ configure.in	2007-07-15 16:48:19.0 +0200
-@@ -3277,14 +3277,12 @@
- 	test $with_system_db != no; then
- SYSTEM_DB=YES
- AC_MSG_RESULT([external])
--AC_CHECK_HEADER(db.h, [ DB_INCLUDES=/usr/include ],
--[
-- CFLAGS=-I/usr/include/db4
-- AC_CHECK_HEADER(db4/db.h,
-- [ DB_INCLUDES=/usr/include/db4 ],
-- [ AC_MSG_ERROR(no. install the db4 libraries) ], []+ )
--], []
--)
-+for dbver in -5.1 5.1 -5.0 5.0 -5 5 -4.8 4.8 -4.7 4.7 -4 4 ''; do
-+   AC_CHECK_HEADER(db$dbver/db.h, [ DB_INCLUDES=/usr/include/db$dbver; 

Re: [Libreoffice] JRE1.5 compatibility

[Petr Mladek]

Caolán McNamara píše v Čt 10. 02. 2011 v 21:03 +:
 On Thu, 2011-01-27 at 12:19 +0100, Antoine POURCHEZ wrote:
  Hi,
  Some jar LibreOffice3.3 (Juhl, Jurt, ...) have been compiled with a
  JRE1.6, contrary to the same jar in OpenOffice3.3 remaining compatible
  with JRE1.5.
  Is it a choice or a compilation error?
 
 What OS was this btw.
 
 Petr: Do we use the --with-java-target-version for the Universal
 builds ?

Yup, I see --with-java-target-version=1.5 in all
libreoffice-3-3/build/distro-configs/LibreOffice{Linux,MacOSX,Win32}.conf.in.

It might be a Windows-specific problem. Fridrich, could you please have
a look what options are used during the compilation?

I am using openJDK-1.6 and --with-java-target-version=1.5. All classes
in the jars have the bytecode version 0.49 or lower. I see the same in
the official LO-3.3.0 Linux build. Note that SDK-1.6 produces the
bytecode version 0.50 by default.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] hash and char * hashes the pointer not the string

[Caolán McNamara]

boost::hash (and I think std::hash in c++0x at least) with
hashconst char*(str) will hash the *pointer* str, not the
contents of str.

Which is why fontwork disappeared recently for me. So I've now greped
for and fixed any hash with a char* and fixed them to use
rtl_str_hashCode which does a hash on the contents.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] easyhack: cppcheck pre/post change

[Caolán McNamara]

On Thu, 2011-02-10 at 16:35 -0500, Kevin Hunter wrote:
 Hullo List,
 
 Same as earlier, EasyHack cppcheck-found post to pre increment iterator.

Looks good, thanks for this, pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Patch

[Miklos Vajna]

On Fri, Feb 11, 2011 at 12:16:20PM +0100, Bálint Dózsa dozsabal...@gmail.com 
wrote:
 I have removed this unused method:
 writerfilter::dmapper::ConversionHelper::convertDateTime(rtl::OUString
 const)

Didn't you forget to remove its declaration from
source/dmapper/ConversionHelper.hxx?


pgpB8n1txgjRr.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] In download.in file, use 3.3.1 as LibreOffice regexp value to correctly get tarballs.

[Gökçen Eraslan]

This patch makes ./download command in LibreOffice 3.3.1.0 work with 
--without-git option.

---
 download.in |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/download.in b/download.in
index e6c93fb..661bc2c 100755
--- a/download.in
+++ b/download.in
@@ -112,7 +112,7 @@ sub download_tests_dependencies() {
 'binutils-.*'= '@MIRROR@/support',
 'gcc-.*' = '@MIRROR@/support',
 'libreoffice-.*-3\.2\.9.*'   = 
'http://download.documentfoundation.org/libreoffice/src/',
-'libreoffice-.*-3\.3\.0.*'   = 
'http://download.documentfoundation.org/libreoffice/src/',
+'libreoffice-.*-3\.3\.1.*'   = 
'http://download.documentfoundation.org/libreoffice/src/',
 'beb300-m.*' = '@MIRROR@/BEB300',
 'dev300-m.*' = '@MIRROR@/DEV300',
 'ooo300-m.*' = '@MIRROR@/OOO300',
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] hash and char * hashes the pointer not the string

[Michael Meeks]

On Fri, 2011-02-11 at 12:58 +, Caolán McNamara wrote:
 boost::hash (and I think std::hash in c++0x at least) with
 hashconst char*(str) will hash the *pointer* str, not the
 contents of str.

That sounds like a work of genius as a default ;-)

I wonder if we can add some sort of lint check for that ?

 Which is why fontwork disappeared recently for me.

Nice catch,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...

[Jesús Corrius]

Hi Michael, all,

        And hopefully, then we will fall back (where it is present) to the EMF
 (not EMF+) or WMF preview instead.


Then it should be possible to remove the mtfrenderer.uno.dll library
from the Windows installer too :)

-- 
Jesús Corrius je...@softcatala.org
Document Foundation founding member
Mobile: +34 661 11 38 26
Skype: jcorrius | Twitter: @jcorrius
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...

[Michael Meeks]

On Fri, 2011-02-11 at 15:10 +0100, Jesús Corrius wrote:
 Then it should be possible to remove the mtfrenderer.uno.dll library
 from the Windows installer too :)

On master it would be better to make it work for Windows, Tor is
testing some patches from Radek for that now.

HTH,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Easy Task - remove non-compiled / dead code

[Jean Charles Papin]

Hi everyone,

I've removed non-compiled pieces of code for boostrap.

I hope it's ok ;)

Regards,

-- 
Jean-Charles Papin


Diff_Bootstrap
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Issues for pivot tables ... where to post

[Kohei Yoshida]

On Fri, 2011-02-11 at 11:47 +0100, Cor Nouws wrote:
 Hi Kohei,
 
 Kohei Yoshida wrote (08-02-11 16:10)
  On Tue, 2011-02-08 at 13:23 +0100, Cor Nouws wrote:
  Someone writes about an issue in OOo/Lo 330, that was not present in OOo
  321.
 
  Is it better to post that in Bugzilla or in the OOo IssueTracker?
  (Currently I see one Pivot-issue - 33990 - in Bugzilla)
 
  Let's put it in our bugzilla, and please assign that directly to me.
 
 OK, done (thanks to Joop Bukker too)
 https://bugs.freedesktop.org/show_bug.cgi?id=34107
 
  I'm working on the data pilot code right now to fix several issues I
  discovered have been broken since 3.3.  So, it's nice to know any
  regressions to data pilot while I'm at it.
 
 1st item is a difference between OOo and LibO

Yes, and that's an enhancement not a bug.  A lot of folks didn't like
the idea that OOo created table right below the data grid.

 2nd a common issue, not a regression.

Regarding this, the data pilot table expects a full absolute reference,
including the sheet name ($Sheet.$A$1), which means you can't type a
relative address such as F1.  Other dialogs expecting an address
probably has the same limitation (e.g. Goal Seek dialog).

Having said that, we may be able to enhance that to take a relative
address from the UI.  Let me look into that and see how easy or
difficult that will be.

 [ wrt the differences OOo / LibO: is there an overview of those, or if 
 not, a pointer how to gain that information?

I'm afraid there is no overview unless someone spends time to create
one, either from memory, by asking, or manually checking the git commit
records.  And as we grow further apart from OOo that will only become
more difficult.

So, I think the best way for now is to ask us weather the difference is
intended, or unintended, on a case-by-case basis (just like you did).

Another option is to go into the source code, find the relevant code,
and check the git history.  But this may or may not be easier than the
above options depending on how comfortable you are with going through
the source tree. ;-)

HTH,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] deliver.pl defaulting to strip

[Jan Holesovsky]

Hi,

deliver.pl now defaults to stripping binaries / libraries when it
delivers to solver, unless you export DISABLE_STRIP.

I think it is a bad idea - breaks debugging of the unit tests (unless
you know that you have to rebuild with debug, and deliver without
stripping), and the distros need need the symbols too, to be able to
produce the debuginfo packages.

So - I'd like to change the logic there, and use ENABLE_STRIP envvar to
control this, defaulting to not stripping; how does that sound to you?

[BTW, Windows build using MSVC would be not affected.]

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] REVIEW: EMF+ disable on Win32 ...

[Radek Doulik]

Hi,

the patch looks OK to me.

Cheers
Radek

On Fri, 2011-02-11 at 12:17 +, Michael Meeks wrote:
 Hi guys,
 
   Talking to Radek (wrt. the EMF+ previews missing in action - ie. we
 just get white images (apparently)) - from bug:
 
   https://bugs.freedesktop.org/show_bug.cgi?id=33785
 
   It seems that the quick workaround is appended;
 
 diff --git a/svtools/source/filter.vcl/wmf/enhwmf.cxx 
 b/svtools/source/filter.vcl/wmf/enhwmf.cxx
 index cc50b1b..1dd5c64 100644
 --- a/svtools/source/filter.vcl/wmf/enhwmf.cxx
 +++ b/svtools/source/filter.vcl/wmf/enhwmf.cxx
 @@ -348,7 +348,7 @@ BOOL EnhWMFReader::ReadEnhWMF()
  static sal_Bool bEnableEMFPlus = ( getenv( EMF_PLUS_DISABLE ) == NULL 
 );
  #else
  // TODO: make it possible to disable emf+ on windows
 -static sal_Bool bEnableEMFPlus = sal_True;
 +static sal_Bool bEnableEMFPlus = sal_False;
  #endif
  
  while( bStatus  nRecordCount-- )
 
   And hopefully, then we will fall back (where it is present) to the EMF
 (not EMF+) or WMF preview instead.
 
   Jesus - it'd be wonderful if you could do a test of that (?) otherwise,
 other reviews appreciated.
 
   Tor - rumour has it that you looked at getting this working on Windows,
 the interaction is with vcl/source/gdi/gdimtf.cxx incidentally and some
 UNO-ised canvas pieces I guess.
 
   Thanks,
 
   Michael.
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Easy Task - remove non-compiled / dead code

[Thomas Arnhold]

Hi,

looks nice. But that doesn't replace manual overlooking what was
deleted. For example in dmake/dmake.c was the following left:

/* Uncomment the following line to pass commands to the DBUG engine
 * before the command line switches (-#..) are evaluated. */

This comment was related to DB_PUSH(d,path);. You have to delete
this too, otherwise people will get confused.

But at all it looks great. Have you run it on a greater repo like calc
or some similar? How many lines got deleted/changed?!

Thomas

On 02/11/2011 04:34 PM, Jean Charles Papin wrote:
 Hi everyone,
 
 I've removed non-compiled pieces of code for boostrap.
 
 I hope it's ok ;)
 
 Regards,
 
 -- 
 Jean-Charles Papin
 
 
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] deliver.pl defaulting to strip

[Bjoern Michaelsen]

Hi kendy,

On Fri, 11 Feb 2011 17:07:17 +0100
Jan Holesovsky ke...@novell.com wrote:

 deliver.pl now defaults to stripping binaries / libraries when it
 delivers to solver, unless you export DISABLE_STRIP.
 
 I think it is a bad idea - breaks debugging of the unit tests (unless
 you know that you have to rebuild with debug, and deliver without
 stripping), and the distros need need the symbols too, to be able to
 produce the debuginfo packages.
 
 So - I'd like to change the logic there, and use ENABLE_STRIP envvar
 to control this, defaulting to not stripping; how does that sound to
 you?

I think stripping on deliver was always broken by design, although I
understand why the shortcut was taken. Stripping should be either be
done directly in the workdir, or upon packing the instset IMHO. I tend
to favor the second option, as it keeps information in the binaries as
long as possible. Also IIRC even in the current build there is some
stripping stuff implemented upon packing which would just strip the
already stripped binaries. But I might be wrong there.

Best Regards,

Bjoern Michaelsen


-- 
https://launchpad.net/~bjoern-michaelsen


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

[Miklos Vajna]

Hi,

This commit in master:

http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f2201e28dca3e08948ddec

Fixes:

https://bugs.freedesktop.org/show_bug.cgi?id=33653

Could someone familiar with that code (Cedric, Caolan?) sign it off and
cherry-pick, please?

Thanks,

Miklos


pgphVp4vl8XgI.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

[Caolán McNamara]

On Fri, 2011-02-11 at 17:35 +0100, Miklos Vajna wrote:
 Hi,
 
 This commit in master:
 
 http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f2201e28dca3e08948ddec
 
 Fixes:
 
 https://bugs.freedesktop.org/show_bug.cgi?id=33653
 
 Could someone familiar with that code (Cedric, Caolan?) sign it off and
 cherry-pick, please?

Done for 3-3, not for 3-3-1 though, that needs more acks.

Background for other readers is that in the binary filters we can write
the font table *after* we have traversed all the text. For a Word 6/Word
95 document we can then convert out-of-ascii range unicode to whatever
8bit ms encoding they fit into and add a font to the font table and
mark it as using that encoding in order to munge out-of-range unicode
into these 8bit only formats.

For rtf however if we wanted to do that, in order to use 8bit encodings
for text we'd need to either parse the document twice, or write to
document body some temp file and stick the font header on afterwards. Or
forget about it and just use the rtf unicode encoding mechanisms.

In master the method now also has a sane name of
DestFileFormatSupportsUnicode or something like that.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

[Miklos Vajna]

On Fri, Feb 11, 2011 at 04:57:57PM +, Caolán McNamara caol...@redhat.com 
wrote:
 On Fri, 2011-02-11 at 17:35 +0100, Miklos Vajna wrote:
  Hi,
  
  This commit in master:
  
  http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f2201e28dca3e08948ddec
  
  Fixes:
  
  https://bugs.freedesktop.org/show_bug.cgi?id=33653
  
  Could someone familiar with that code (Cedric, Caolan?) sign it off and
  cherry-pick, please?
 
 Done for 3-3, not for 3-3-1 though, that needs more acks.

Thanks.

 In master the method now also has a sane name of
 DestFileFormatSupportsUnicode or something like that.

Just SupportsUnicode(). :)


pgpSEByrF8fZr.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

[Michael Meeks]

On Fri, 2011-02-11 at 16:57 +, Caolán McNamara wrote:
  Could someone familiar with that code (Cedric, Caolan?) sign it off and
  cherry-pick, please?
 
 Done for 3-3, not for 3-3-1 though, that needs more acks.

Patch looks ok to me :-) - just that one-liner, affecting RTF export
only right ? one more  we're good for merge to 3.3.1 I guess.

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error with cppunit - Making install in DllPlugInTester

[Kishan Bhat]

Hi Michael,

Ubuntu-natty dev build from Jan 26 2011.

Now, I switched back to unbunto 10.10. I'l retry git, make and let know.

On Fri, Feb 11, 2011 at 3:08 PM, Michael Meeks michael.me...@novell.comwrote:

 Hi Kishan,

 On Fri, 2011-02-11 at 09:15 +0530, Kishan Bhat wrote:
  I'm trying to build LO.

 On what platform (out of interest ?) is this some self-build linux
 by
 any chance ? did you somehow disable dynamic linking while configuring
 it ? ;-)

  and I get this error: http://pastebin.com/KcMu29Ja

 make[2]: Entering directory
 `/home/bhat/git/libo/clone/libs-extern/cppunit/
 unxlngi6.pro/misc/build/cppunit-1.12.1/src/DllPlugInTester'
 /bin/bash ../../libtool --tag=CXX   --mode=link g++   -ldl  -o
 DllPlugInTester DllPlugInTester.o
 CommandLineParser.o ../../src/cppunit/libcppunit.la -lm
 g++ -o .libs/DllPlugInTester DllPlugInTester.o CommandLineParser.o
  -ldl ../../src/cppunit/.libs/libcppunit.so -lm  -Wl,--rpath
 -Wl,/home/bhat/git/libo/clone/libs-extern/cppunit/
 unxlngi6.pro/misc/build/cppunit-1.12.1/ooo-install/lib
 ./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlsym'
 ./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlopen'
 ./../src/cppunit/.libs/libcppunit.so: undefined reference to `dlclose'

Looks like your libdl is causing grief - it would be interesting to
 know what:

objdump -T /lib/libdl.so.2

says - surely it must define 'dlsym' ? :-) how could it not ? and
 your
 link line contains that.

ATB,

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Issues building LO on Linux prior to attempting on Android

[Andrew Wafaa]

Chaps  Chapesses,

I'm trying to build LO on openSUSE 11.3, but get a failure with make.
The steps I've taken are:

1.  git clone git://anongit.freedesktop.org/libreoffice/bootstrap
2. sudo zypper si -d libreoffice libreoffice-bootstrap (I am using the
LibreOffice:Stable repo)
3. ./autogen.sh --without-junit --disable-kde --disable-kde4
--disable-Xaw --with-git
4. make

After running autogen I get no errors, and it gives me the make
options. I choose the plain old make and I end up with the following
error:

=
Building module instsetoo_native
=
Entering 
/home/awafaa/workspace/LibreOffice/jni/instsetoo_native/inc_openoffice/unix

Entering 
/home/awafaa/workspace/LibreOffice/jni/instsetoo_native/inc_openoffice/windows/msi_languages

mkout -- version: 1.8
mkout -- version: 1.8
touch 
/home/awafaa/workspace/LibreOffice/jni/solver/330/unxlngi6.pro/inc/minormkchanged.flg
touch 
/home/awafaa/workspace/LibreOffice/jni/solver/330/unxlngi6.pro/inc/minormkchanged.flg
Entering /home/awafaa/workspace/LibreOffice/jni/instsetoo_native/util

dmake:  makefile.mk:  line 34:  Error: -- Include file
/home/awafaa/workspace/LibreOffice/jni/solver/330/unxlngi6.pro/inc/rtlbootstrap.mk,
not found
Forcing regeneration of dependency info

dmake:  makefile.mk:  line 34:  Error: -- Include file
/home/awafaa/workspace/LibreOffice/jni/solver/330/unxlngi6.pro/inc/rtlbootstrap.mk,
not found
Retrying /home/awafaa/workspace/LibreOffice/jni/instsetoo_native/util

dmake:  makefile.mk:  line 34:  Error: -- Include file
/home/awafaa/workspace/LibreOffice/jni/solver/330/unxlngi6.pro/inc/rtlbootstrap.mk,
not found

---
Oh dear - something failed during the build - sorry !
  For more help with debugging build errors, please see the section in:
http://wiki.documentfoundation.org/Development

  internal build errors:

ERROR: error 65280 occurred while making
/home/awafaa/workspace/LibreOffice/jni/instsetoo_native/util

 it seems that the error is inside 'instsetoo_native', please re-run build
 inside this module to isolate the error and/or test your fix:
---

rm -Rf /home/awafaa/workspace/LibreOffice/jni/instsetoo_native/unxlngi6.pro
# optional module 'clean'
/bin/sh
cd /home/awafaa/workspace/LibreOffice/jni
source ./LinuxX86Env.Set.sh
cd instsetoo_native
build

when the problem is isolated and fixed exit and re-run 'make' from the top-level
make: *** [all] Error 1

I'm a real noob when it comes to LO and would appreciate any help.
Reason I'm building from git is I'm looking at porting LO to Android.
I need to get to a stage where I can create the required NDK make
file. To do that I need the required c++ source files, which is why im
manually building from git :)

In case anyone is curious the NDK make file - Android.mk - looks a bit like:
   LOCAL_PATH := $(call my-dir)

   include $(CLEAR_VARS)

   LOCAL_MODULE:= hello-jni
   LOCAL_SRC_FILES := hello-jni.c

   include $(BUILD_SHARED_LIBRARY)

Thanks, and sorry for any rambling.

Andy
-- 
Andrew Wafaa
IRC: FunkyPenguin
GPG: 0x3A36312F
openSUSE: Get It, Discover It, Create It at http://www.opensuse.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Patch

[Bálint Dózsa]

Hy,

Here is the correction. I have removed the declaration

Balint

2011. február 11. 18:41 Bálint Dózsa írta, dozsabal...@gmail.com:

 Hy,

 Here is the correction. I have removed the declaration

 Balint

 2011/2/11 Miklos Vajna vmik...@frugalware.org

 On Fri, Feb 11, 2011 at 12:16:20PM +0100, Bálint Dózsa 
 dozsabal...@gmail.com wrote:
  I have removed this unused method:
  writerfilter::dmapper::ConversionHelper::convertDateTime(rtl::OUString
  const)

 Didn't you forget to remove its declaration from
 source/dmapper/ConversionHelper.hxx?

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice



From 0b74a7905ab5be9c252bb7ad4932c908f91cf942 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?B=C3=A1lint=20D=C3=B3zsa?= dozsabal...@gmail.com
Date: Fri, 11 Feb 2011 18:34:07 +0100
Subject: [PATCH] Remove unused method

---
 writerfilter/source/dmapper/ConversionHelper.cxx |   43 --
 writerfilter/source/dmapper/ConversionHelper.hxx |1 -
 2 files changed, 0 insertions(+), 44 deletions(-)

diff --git a/writerfilter/source/dmapper/ConversionHelper.cxx b/writerfilter/source/dmapper/ConversionHelper.cxx
index 824a3f6..8a2b3af 100644
--- a/writerfilter/source/dmapper/ConversionHelper.cxx
+++ b/writerfilter/source/dmapper/ConversionHelper.cxx
@@ -375,7 +375,6 @@ bool lcl_IsNotAM(::rtl::OUString rFmt, sal_Int32 nPos)
 bool bForceNatNum(false);
 sal_Int32 nLen = sFormat.getLength();
 sal_Int32 nI = 0;
-//const sal_Unicode* pFormat = sFormat.getStr();
 ::rtl::OUStringBuffer aNewFormat( sFormat.getStr() );
 while (nI  nLen)
 {
@@ -515,48 +514,6 @@ sal_Int16 convertTableJustification( sal_Int32 nIntValue )
 }
 return nOrient;
 }
-/*-- 06.08.2007 15:27:30---
- conversion form xsd::DateTime
-[-]CCYY-MM-DDThh:mm:ss[Z|(+|-)hh:mm]
-  ---*/
-com::sun::star::util::DateTime convertDateTime( const ::rtl::OUString rDateTimeString )
-{
-util::DateTime aRet( 0, 0, 0, 0, 1, 1, 1901 );
-//
-sal_Int32 nIndex = 0;
-::rtl::OUString sDate( rDateTimeString.getToken( 0, 'T', nIndex ));
-sal_Int32 nDateIndex = 0;
-aRet.Year = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-if( nDateIndex  0)
-aRet.Month = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-if( nDateIndex  0)
-aRet.Day = (sal_uInt16)sDate.getToken( 0, '-', nDateIndex ).toInt32();
-::rtl::OUString sTime;
-if(nIndex  0) 
-{
-sTime = ( rDateTimeString.getToken( 0, 'Z', nIndex ));
-sal_Int32 nTimeIndex = 0;
-aRet.Hours = (sal_uInt16)sTime.getToken( 0, ':', nTimeIndex ).toInt32();
-if( nTimeIndex  0)
-aRet.Minutes = (sal_uInt16)sTime.getToken( 0, ':', nTimeIndex ).toInt32();
-if( nTimeIndex  0)
-{
-::rtl::OUString sSeconds = sTime.getToken( 0, ':', nTimeIndex );
-nTimeIndex = 0;
-aRet.Seconds = (sal_uInt16)sSeconds.getToken( 0, '.', nTimeIndex ).toInt32();
-aRet.HundredthSeconds = (sal_uInt16)sSeconds.getToken( 0, '.', nTimeIndex ).toInt32();
-}
-
-// todo: ignore time offset for a while - there's no time zone available 
-//nIndex = 0;
-//::rtl::OUString sOffset( rDateTimeString.getToken( 1, 'Z', nIndex ));
-//if( sOffset.getLength() )
-//{
-//  add hour and minute offset and increase/decrease date if necessary
-//}
-}
-return aRet;
-}
 /*-- 05.03.2008 09:10:13---
 
   ---*/
diff --git a/writerfilter/source/dmapper/ConversionHelper.hxx b/writerfilter/source/dmapper/ConversionHelper.hxx
index a60a5f4..64b7d9e 100644
--- a/writerfilter/source/dmapper/ConversionHelper.hxx
+++ b/writerfilter/source/dmapper/ConversionHelper.hxx
@@ -57,7 +57,6 @@ namespace ConversionHelper{
 sal_Int32 convertEMUToMM100(sal_Int32 _t);
 sal_Int32 ConvertColor(sal_Int32 nWordColor );
 sal_Int16 convertTableJustification( sal_Int32 nIntValue );
-::com::sun::star::util::DateTime convertDateTime( const ::rtl::OUString rDateTimeString );
 sal_Int16 ConvertNumberingType(sal_Int32 nNFC);
 
 } // namespace ConversionHelper
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Patch][EasyHack] Fix fdo#32376 Set default color to the current one in toolbar popups

[KUROSAWA, Takeshi]

Hi,

Here is a patch to fix bug 32376:

Bug 32376 - [EasyHack] Set default color to the current one in toolbar popups
https://bugs.freedesktop.org/show_bug.cgi?id=32376

With this patch, color selection popups remember previously selected color.

Limitation:
This patch doesn't change anything about selection rendering.
It marks the previously selected color as a selection which has little
visual appeal.
So it is a bit difficult to find the selected color.
See attached a png image.

The patch is under LGPLv3/MPL.

Cheers,
--
Kurosawa Takeshi taken@gmail.com
From c765a03b543015c1ffa9e2ea6b7e6d1fba322b71 Mon Sep 17 00:00:00 2001
From: Kurosawa Takeshi taken@gmail.com
Date: Sat, 12 Feb 2011 01:27:59 +0900
Subject: [PATCH] fdo#32376 Set default color to the current one in toolbar popups

---
 svx/inc/svx/extrusioncolorcontrol.hxx |3 +-
 svx/inc/svx/tbcontrl.hxx  |6 +++
 svx/source/tbxctrls/colorwindow.hxx   |   10 +++--
 svx/source/tbxctrls/extrusioncontrols.cxx |9 +++-
 svx/source/tbxctrls/tbcontrl.cxx  |   62 ++--
 5 files changed, 61 insertions(+), 29 deletions(-)

diff --git a/svx/inc/svx/extrusioncolorcontrol.hxx b/svx/inc/svx/extrusioncolorcontrol.hxx
index 8bd4a93..4b79b88 100644
--- a/svx/inc/svx/extrusioncolorcontrol.hxx
+++ b/svx/inc/svx/extrusioncolorcontrol.hxx
@@ -38,7 +38,8 @@ namespace svx {
 class SVX_DLLPUBLIC ExtrusionColorControl : public SfxToolBoxControl
 {
 private:
-ToolboxButtonColorUpdater*	mpBtnUpdater;
+ToolboxButtonColorUpdater* mpBtnUpdater;
+Color  mLastColor;
 
 public:
 SFX_DECL_TOOLBOX_CONTROL();
diff --git a/svx/inc/svx/tbcontrl.hxx b/svx/inc/svx/tbcontrl.hxx
index 66b4861..fd1fb8a 100644
--- a/svx/inc/svx/tbcontrl.hxx
+++ b/svx/inc/svx/tbcontrl.hxx
@@ -287,6 +287,7 @@ public:
 class SVX_DLLPUBLIC SvxFontColorToolBoxControl : public SfxToolBoxControl
 {
 ::svx::ToolboxButtonColorUpdater*   pBtnUpdater;
+Color   mLastColor;
 
 public:
 SFX_DECL_TOOLBOX_CONTROL();
@@ -314,6 +315,7 @@ class SVX_DLLPUBLIC SvxFontColorExtToolBoxControl : public SfxToolBoxControl
 
 //	SfxStatusForwarder 			aForward;
 ::svx::ToolboxButtonColorUpdater*   pBtnUpdater;
+Color   mLastColor;
 
 public:
 SFX_DECL_TOOLBOX_CONTROL();
@@ -338,6 +340,8 @@ public:
 class SVX_DLLPUBLIC SvxColorToolBoxControl : public SfxToolBoxControl
 {
 ::svx::ToolboxButtonColorUpdater*   pBtnUpdater;
+Color   mLastColor;
+
 public:
 SFX_DECL_TOOLBOX_CONTROL();
 SvxColorToolBoxControl( USHORT nSlotId, USHORT nId, ToolBox rTbx );
@@ -398,6 +402,8 @@ public:
 class SVX_DLLPUBLIC SvxFrameLineColorToolBoxControl : public SfxToolBoxControl
 {
 ::svx::ToolboxButtonColorUpdater*   pBtnUpdater;
+Color   mLastColor;
+
 public:
 SFX_DECL_TOOLBOX_CONTROL();
 SvxFrameLineColorToolBoxControl( USHORT nSlotId,
diff --git a/svx/source/tbxctrls/colorwindow.hxx b/svx/source/tbxctrls/colorwindow.hxx
index 763f2bf..fc49d05 100644
--- a/svx/source/tbxctrls/colorwindow.hxx
+++ b/svx/source/tbxctrls/colorwindow.hxx
@@ -19,9 +19,10 @@ class SvxColorWindow_Impl : public SfxPopupWindow
 using FloatingWindow::StateChanged;
 
 private:
-const USHORT	theSlotId;
-ValueSet		aColorSet;
-rtl::OUString   maCommand;
+const USHORT   theSlotId;
+ValueSet   aColorSet;
+rtl::OUString  maCommand;
+const ColormLastColor;
 
 #if _SOLAR__PRIVATE
 DECL_LINK( SelectHdl, void * );
@@ -36,7 +37,8 @@ public:
  USHORT nSlotId,
  const ::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame  rFrame,
  const String rWndTitle,
- Window* pParentWindow );
+ Window* pParentWindow,
+ const Color rLastColor = COL_AUTO);
 ~SvxColorWindow_Impl();
 voidStartSelection();
 
diff --git a/svx/source/tbxctrls/extrusioncontrols.cxx b/svx/source/tbxctrls/extrusioncontrols.cxx
index ac1b68a..cca72a1 100644
--- a/svx/source/tbxctrls/extrusioncontrols.cxx
+++ b/svx/source/tbxctrls/extrusioncontrols.cxx
@@ -989,7 +989,8 @@ SFX_IMPL_TOOLBOX_CONTROL( ExtrusionColorControl, SvxColorItem );
 
 ExtrusionColorControl::ExtrusionColorControl(
 USHORT nSlotId, USHORT nId, ToolBox rTbx )
-: SfxToolBoxControl	( nSlotId, nId, rTbx )
+: SfxToolBoxControl ( nSlotId, nId, rTbx ),
+  mLastColor( COL_AUTO )
 {
 rTbx.SetItemBits( nId, TIB_DROPDOWNONLY | rTbx.GetItemBits( nId ) );
 mpBtnUpdater = new ToolboxButtonColorUpdater( nSlotId, nId, GetToolBox(), TBX_UPDATER_MODE_CHAR_COLOR_NEW );
@@ -1018,7 +1019,8 @@ SfxPopupWindow*	

Re: [Libreoffice] issue with Borderline structure

[Dietmar]

Am Dienstag, den 08.02.2011, 10:17 +0100 schrieb David Tardon:
 On Mon, Feb 07, 2011 at 09:22:50PM +0100, Dietmar wrote:
  I am having an issue with my extension Borderliner written in Java. It
  works fine with Oracle OOo, but does not with Go-OO and LO.
 
 Yes, we know already: https://bugs.freedesktop.org/show_bug.cgi?id=33397 .
 
 D.

Checked the Extension in LO 3.1.1 RC1, seems to work. Thanks for the
fix.
There still is an issue with my mouse-click-handling but that is a) a
different topic, b) could be an issue with my tricks of using
accessibility features and c) I did never like that feature anyway.

Dietmar

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] Takao font support for 3.3.1.

[Kohei Yoshida]

Hi there,

I'd like to have the following change 

http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?h=libreoffice-3-3id=3b8c4baec540c851ebf97d933e11150192defa87

reviewed for inclusion into the 3.3.1 branch.  This change fixes 

https://bugs.freedesktop.org/show_bug.cgi?id=32810

If I understand correctly Takao font is used by several Linux distros as
the default Japanese UI font, so getting that font recognized properly
is pretty important.  The change is pretty simple and IMO non-intrusive.

Thanks,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
kyosh...@novell.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] Remove obsolete Hyperlink Bar - final patches

[Jan Holesovsky]

Hi Alfonso,

On 2011-02-10 at 08:38 +, Alfonso Eusebio wrote:

 Please find attached a set of patches that remove the Hyperlink Bar from the 
 core modules. 

Thank you!  Pushed :-)  Unfortunately I was unable to test the
installation, as the unit tests are failing for me (not your fault, even
without your patches), but the patches look right, so no reason to hold
them back :-)

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Fw: [PATCH] Remove obsolete Hyperlink Bar - final patches

[Jan Holesovsky]

Hi Alfonso,

On 2011-02-11 at 07:43 +, Alfonso Eusebio wrote:

 I realise this change contains quite a few patches. Please let me know if 
 there 
 is a more efficient way of doing this.
 I created one patch per git repository as I think you can't have one patch 
 across repositories (or at least I don't know how to do it).

No worry, this is OK - it was just 7 patches, that is easy ;-)

Regards,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [FDO#31252] Overwrite dialog improvement

[Jan Holesovsky]

Hi Sebastien,

On 2011-02-11 at 09:31 +0100, Sébastien Le Ray wrote:

 Here is a patch for fdo#31252[1] which improves the overwrite dialog as
 described in the bug.

Beautiful, thank you! :-)  Pushed.

 I don't know if the second part of the bug about backuping overwritten
 file is relevant, awaiting your advices on this.

Well - I am not a friend of backup to a randomly named file, you'll end
up with disk full of backups that you never know what is which version
of what ;-)  Maybe you could add a button to launch the 'Save As...'
dialog? - CCing the design team...

Regards,
Kendy



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-3' - starmath/source

[Kevin Hunter]

At 5:15am -0500 Fri, 11 Feb 2011, Jan Holesovsky wrote:

On 2011-02-10 at 13:12 -0500, Kevin Hunter wrote:

Do we have guidelines for commit messages? I ask because I think
it would be helpful to include just a smidgen more information in
them than a reference to various bugzillas.



My favorite form of the first line is:

area: Fixed this in that and the other thing, fdo#12345.

'Area' gives the overview what is it about, most notably when the
commits are part of some bigger picture; in my case I use that for
the wikihelp, like:

wikihelp: Improve check for existence of the localized help,
fdo#33258.


That's exactly what I was thinking when I asked that question.  From my 
perspective, as I'm only able to read emails and code in *small* 
snippets of time, this style of commit message would help me stay 
abreast and reduce a fair amount my settling time to get the proper 
context for a patch.



Would be great if it become more widely used, but OTOH I think we
are still not in a situation to force that by a hook, or something.


I'm not about forcing.  Guidelines are guidelines, and are only usable 
as a metric or request.  We are a bazaar, and that means we accept the 
efforts of those of us who actually, you know, do work.  (I'll point out 
that I hardly count in that measure.)


The perhaps more direct question is, beyond you and me, would others 
*committing developers* appreciate having a commit message guideline? 
Something along the lines of what you have just proposed?  I'm not 
talking about forcing anyone to do anything, but encouraging developers 
to put slightly more effort into their commit messages.


Cheers,

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [FDO#31252] Overwrite dialog improvement

[Sébastien Le Ray]

Le Fri, 11 Feb 2011 19:58:42 +0100,
Jan Holesovsky ke...@suse.cz a écrit :

 Hi Sebastien,
 
 On 2011-02-11 at 09:31 +0100, Sébastien Le Ray wrote:
 
  Here is a patch for fdo#31252[1] which improves the overwrite
  dialog as described in the bug.
 
 Beautiful, thank you! :-)  Pushed.
 
  I don't know if the second part of the bug about backuping
  overwritten file is relevant, awaiting your advices on this.
 
 Well - I am not a friend of backup to a randomly named file, you'll
 end up with disk full of backups that you never know what is which
 version of what ;-)  Maybe you could add a button to launch the 'Save
 As...' dialog? - CCing the design team...
 

Hi,

Well, in fact, the message box is show as part of the save as workflow
so just clicking No brings back to the save As dialog :)

Sebastien


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] cppcheck easyhack

[Kevin Hunter]

Hullo List,

Another simple, easy hack, cppcheck based patch.

Kevin


0001-cppcheck-post-to-pre-crement-change.patch.gz
Description: GNU Zip compressed data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] Takao font support for 3.3.1.

[Caolán McNamara]

On Fri, 2011-02-11 at 13:17 -0500, Kohei Yoshida wrote:
 Hi there,
 
 I'd like to have the following change 
 
 http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?h=libreoffice-3-3id=3b8c4baec540c851ebf97d933e11150192defa87
 
 reviewed for inclusion into the 3.3.1 branch.  This change fixes 
 
 https://bugs.freedesktop.org/show_bug.cgi?id=32810
 
 If I understand correctly Takao font is used by several Linux distros as
 the default Japanese UI font, so getting that font recognized properly
 is pretty important.  The change is pretty simple and IMO non-intrusive.

That whole bunch of methods is deeply disturbing, Nevertheless for this
specific issue, sure, agreed that adding a few more in there looks
incredibly safe, looks good to me.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] cppcheck easyhack

[Kevin Hunter]

Hullo List,

Another simpleton cppcheck patch.

Kevin


0001-cppcheck-post-to-pre-crement-change.patch.gz
Description: GNU Zip compressed data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] deliver.pl defaulting to strip

[Caolán McNamara]

On Fri, 2011-02-11 at 17:07 +0100, Jan Holesovsky wrote:
 Hi,
 
 deliver.pl now defaults to stripping binaries / libraries when it
 delivers to solver, unless you export DISABLE_STRIP.

It doesn't strip if you have --enable-symbols on FWIW, right ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Noob needs help in first ever build: more_fonts does not build

[Caolán McNamara]

On Thu, 2011-02-10 at 16:29 -0800, jotomicron wrote:
 Hello, everyone!
 I've recently been attracted to LibreOffice development, particularly in
 Writer. I've followed general guidelines on the Web, but try as I might, I
 always end up having the same error in 'more_fonts'.

Is this with a specific branch, or just normal master ?

I'd expect make to just work and download what you need. You might get
a little more info if you do 

export VERBOSE=true
make

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1

[Caolán McNamara]

On Fri, 2011-02-11 at 20:31 +0900, KUROSAWA, Takeshi wrote:
 Hi,
 
 Here is a patch to make LibeOffice use a more commonly-used mouse cursor in 
 GTK.
 
 Currently LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2
 for POINTER_HAND.
 As a result, LibreOffice uses GDK_HAND1 for hyperlinks, while many
 GTK2 applications use GDK_HAND2.
 # See attached png images.

I wonder why I don't see this behaviour locally. If I type a url in
writer or impress and then put my mouse over it I get the same hand as I
see in gimp, etc.

The only time I see the other hand is if I type anything into draw,
whether its a url or not, i.e. I'm in a mode where clicking and moving
the mouse moves the textbox under it. Is the previous screenshot from
draw ?, and if it is, does clicking spawn off the brower when the cursor
is like that ?

If you type the url in writer and press ctrl with the mouse over it, do
you get the same hand as in gimp ?

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] cppcheck easyhack

[Caolán McNamara]

On Fri, 2011-02-11 at 15:24 -0500, Kevin Hunter wrote:
 Hullo List,
 
 Another simpleton cppcheck patch.

Looks good, pushed, thanks for this.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] cppcheck easyhack

[Caolán McNamara]

On Fri, 2011-02-11 at 15:09 -0500, Kevin Hunter wrote:
 Hullo List,
 
 Another simple, easy hack, cppcheck based patch.

Looks good, thanks for this one too, pushed.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Çok amaçli Notebook (Laptop) sehpası (6 renk cesidi)

[Notebook Sehpa]

ÇOK AMAÇLI NOTEBOOK (LAPTOP) SEHPASI 




ÜRETİCİDEN HALKA 





http://www.ahsaplaptopsehpasi.net/  








Notebook sehpaları, sağlığınız 
için 
özel doğal ürünlerden elde 
edilmiş çok amaçlı bir 
portatif laptop sehpasıdır. 
Ürünümüzün 6 çeşit renk 
çeşitleri mevcuttur.Bu ürünümüz 
tamamen yerli birinci 
sınıf çam ağacından 
üretilmiştir. Kesinlikle kanserojen 
madde içermez. Bu ürünü 
koltuğunuzda oturarak, 
yatağınızda uzanarak ve yerde 
oturarak rahatlıkla 
kullanabilirsiniz



 DETAYLI BİLGİLER İÇİN LÜTFEN  
SİTEMİZE BAKIN 

TELEFON  : 0506 340 
37 37 



sahibinden.com sitesinden ürünü incelemek 
ve sipariş vermek için tıklayınız

KREDİ KARTI İLE TAKSİT 
İMKANI VARDIR 





 




 

 

 




 

 

 



Ürünümüz Çobanoğlu Tasarım 
olarak patentlidir. 




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH][PUSHED 4/54] translated comments

[Christina Roßmanith]

Hi,

I've pushed changes to 4 out of 54 files:

 connectivity/source/commontools/CommonTools.cxx|   10 +-
 connectivity/source/commontools/DateConversion.cxx |   11 +-
 .../source/commontools/TSkipDeletedSet.cxx |2 +-
 connectivity/source/commontools/dbtools.cxx|   64 

Some of your translations changed the meaning of comments. In that case 
I edited of your changes. That takes some time...


Thank you for your contribution.

Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED, partial] Re: Easy Task - remove non-compiled / dead cod=

[Caolán McNamara]

On Fri, 2011-02-11 at 18:18 +0100, Jean Charles Papin wrote:
 Thank you for your encouragements.
 
 But unfortunately, most of the deleted comments were done by hand,
 because I was unable to really make an distinction between comments
 and the commented code.

So, I pushed some of this patch, but not all. The dmake dir is really
third party code we use as a make equivalent and we're hoping to get rid
of it soon, so best to just skip that module.

And of course the point isn't to remove all comments, just the ones that
comment out large chunks of code or the ones that don't add any value, 
e.g. -- CMC 2010-12-04 #i1# is best changed to #i1# seeing
as knowing who and when something a line was added is distracting. I'm
not sure an automatic approach will completely work.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] New feature: print current page

[Christoph Noack]

Hi Cor, hi Tobias!

Am Freitag, den 11.02.2011, 11:59 +0100 schrieb Cor Nouws:
 Hi Tobias,
 
 Tobias Ollmann wrote (11-02-11 12:28)
 
  I'm rather new here, so I don't know if something similar has already
  been posted. But I'm missing a very important feature in the printing
  dialog, namly an option to print the current page only.
 
 The old behaviour in OOo was
   - select option Pages, that default to the current page.
 WHich is what you want.

True. Funnily, that is what I've originally wrote:
Group Range and copies: Slightly improved layout which is
based on the original printing dialog, since we have to respect
our existing user base. [1]

Seems that the original behavior hasn't been preserved :-\


 With the new Printer Dialog, you can select Pages, but nor does it show 
 the current page, nor does it get the focus,
 IMO two usability bugs.

Correct. Concerning the latter, I somehow remember that this was in
discussion and I have been overruled.

  Are there plans to implement something like that?
 
 Not that I am aware of.
 But improving the behaviour in the current dialog would do too, IMO.

Indeed, that would be great. I noticed another issue that seems to be
different with regard to the original specification. And, there is a
serious usability/utility issue since the dialog doesn't save printer /
printing options in certain cases. So if there is a helpful (developer)
hand, then I'd like to resolve this ... Anybody? :-)

Cheers,
Christoph

[1] http://wiki.services.openoffice.org/wiki/Printerpullpages

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Pushing of patches translating comments

[Christina Roßmanith]

Hi,

are there enough German-speaking developers who are allowed and willing 
to review and push translation patches? I think only this group of 
developers is able to detect if a translations changes the meaning of a 
comment.




Some of the comments are already meaningless in German:
--- translated --
// btw: 10 following 09 is not a counting error but an intentional gap,
// because it was not clear, how long the RelRefs development would take. :)

(found in rechead.hxx somewhere inside calc)

Up to now I didn't know that there is a gap between 9 and 10 (assuming 
we are considering only integers of course) and even my daughters learn 
at primary school that it is ...8-9-10-... so where is the counting 
error?


If there isn't a veto this comment is marked for removal  :-)

Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] use BrOffice name if the Brazilian UI translation is used (bnc#33744)

[Petr Mladek]

Hi,

the BrOffice name was not in sync with the used UI localization. The
attached patch helped to solve it. See
https://bugs.freedesktop.org/show_bug.cgi?id=33744#c12 for more details.

I need review from 2 more people to include it into the
libreoffice-3-3-1 branch. Any volunteers, please?


Best Regards,
Petr
From 29b510e2a77f65445831767fe2061a92b6b57279 Mon Sep 17 00:00:00 2001
From: Petr Mladek pmla...@suse.cz
Date: Fri, 11 Feb 2011 22:36:09 +0100
Subject: [PATCH] use BrOffice name if the Brazilian UI translation is used (bnc#33744)

it is not enough to check the system UI setting

Signed off by Michael Meeks
---
 unotools/source/config/configmgr.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/unotools/source/config/configmgr.cxx b/unotools/source/config/configmgr.cxx
index 7b57234..fa94533 100644
--- a/unotools/source/config/configmgr.cxx
+++ b/unotools/source/config/configmgr.cxx
@@ -403,7 +403,7 @@ Any ConfigManager::GetDirectConfigProperty(ConfigProperty eProp)
 
 ::rtl::OUString sBrandName;
 #ifdef ENABLE_BROFFICE
-LanguageType nType = MsLangId::getSystemUILanguage();
+LanguageType nType = MsLangId::getRealLanguage( LANGUAGE_NONE );
 if ( nType == LANGUAGE_PORTUGUESE_BRAZILIAN )
 sBrandName = OUString::createFromAscii(BrOffice);
 else
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Tools - Media Player

[Thomas Arnhold]

Hi,

what the heck do we do with Tools - Media Player? Do we need this
within an office suite? Is anyone using this?!

Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Pushing of patches translating comments

[Christoph Herzog]

Not enough really, if you ask me. In writer/sw alone the german_comments 
tool by vmiklos counted well over 20,000 lines of German comments (and 
it does not catch all). Translating and sorting out all will take years. 
And, as you mentioned, some of these comments are real mysteries.


It would perhaps be an option to ask developers what files/comments they 
need translated in the first place and to do these first.


Best

Christoph


On 02/11/2011 10:40 PM, Christina Roßmanith wrote:

Hi,

are there enough German-speaking developers who are allowed and willing
to review and push translation patches? I think only this group of
developers is able to detect if a translations changes the meaning of a
comment.



Some of the comments are already meaningless in German:
--- translated --
// btw: 10 following 09 is not a counting error but an intentional gap,
// because it was not clear, how long the RelRefs development would
take. :)

(found in rechead.hxx somewhere inside calc)

Up to now I didn't know that there is a gap between 9 and 10 (assuming
we are considering only integers of course) and even my daughters learn
at primary school that it is ...8-9-10-... so where is the counting
error?

If there isn't a veto this comment is marked for removal :-)

Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] LO 3.3.1 RC1 Calc, Search dialog bug

[Dietmar]

Could someone countercheck this please.

In Calc use the Search and Replace dialog.
Check search in all tables
Search for a term that is NOT in the current table, but in anotherone.
It is not found, but should be.

Looks like the search in all tables just searches the current one.

Dietmar
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1

[KUROSAWA, Takeshi]

Hi Caolán,

On Sat, Feb 12, 2011 at 5:46 AM, Caolán McNamara caol...@redhat.com wrote:
 I wonder why I don't see this behaviour locally. If I type a url in
 writer or impress and then put my mouse over it I get the same hand as I
 see in gimp, etc.


Several cursor themes use same cursor for both GDK_HAND1 and GDK_HAND2.
In this case there is no difference.
But there are some cursor themes which use different cursors (e.g. DMZ
(White) ) and
provide GDK_HAND2 only (e.g. Arch Cursor Theme (Simple)).

DMZ (White)
HAND1: 
http://gitorious.org/opensuse/art/blobs/master/cursors/dmz/pngs/48x48/hand1.png
HAND2: 
http://gitorious.org/opensuse/art/blobs/master/cursors/dmz/pngs/48x48/hand2.png

Arch Cursor Theme (Simple)
http://gnome-look.org/content/show.php/Arch+Cursor+Theme+%28simple%29?content=135902

Using such themes, you'll see different hands.


 The only time I see the other hand is if I type anything into draw,
 whether its a url or not, i.e. I'm in a mode where clicking and moving
 the mouse moves the textbox under it. Is the previous screenshot from
 draw ?, and if it is, does clicking spawn off the brower when the cursor
 is like that ?

 If you type the url in writer and press ctrl with the mouse over it, do
 you get the same hand as in gimp ?


The previous screenshot is from Impress with DMZ (White) cursor theme.
It is happened in Writer with ctrl key pressing and Help Viewer as well.

Cheers,
--
Takeshi Kurosawa taken@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice