Re: [Libreoffice] assertion in SwIndexReg::~SwIndexReg

[Stephan Bergmann]

On 12/15/2011 12:59 AM, Terrence Enger wrote:

I see something that I thought was impossible ...

Running on ubuntu-natty, with commit ids 61fce03 (pulled
2011-12-02) and 4097499 (pulled 2011-12-08) running under
gdb in gnome-terminal, I highlighted three lines with the
mouse and did right-click>  copy.  soffice.bin raises the
assertion in SwIndexReg::~SwIndexReg().

How on earh can soffice.bin know that I did anything in
gnome-terminal?


Due to the clipboard being a resource shared across all applications.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Tell me Easy Hack 42782 "remove a dog ! " is a joke !

[julien2412]

Hello,

This morning I'm still angry about this tracker. I read it yesterday and
spoke my mind on IRC dev channel. I was glad I wasn't alone to think this
easyhack is nonsense.
I put a quick comment on this tracker but guys, I'd like to know your
opinion about this even it's not a "dev" subject.

Julien
PS : I try to respond as soon as I'm available again

--
View this message in context: 
http://nabble.documentfoundation.org/Tell-me-Easy-Hack-42782-remove-a-dog-is-a-joke-tp3587827p3587827.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] assertion in SwIndexReg::~SwIndexReg

[Terrence Enger]

I see something that I thought was impossible ...

Running on ubuntu-natty, with commit ids 61fce03 (pulled
2011-12-02) and 4097499 (pulled 2011-12-08) running under
gdb in gnome-terminal, I highlighted three lines with the
mouse and did right-click > copy.  soffice.bin raises the
assertion in SwIndexReg::~SwIndexReg().

How on earh can soffice.bin know that I did anything in
gnome-terminal?

FWIW, I got into this situation by trying to investigate bug
43234 "assertion raised, index.cxx:238"
.  That
is the same assertion, but the current test has proceeded
well beyond the point of failure reported in the bug.

What can I do to follow up on this strange happening?
Suggestions welcome.

Thanks,
Terry.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5

[Pedro Lino]

>> If you feel good about the beta1 build,
>
>
> My feeling about it is positive. What do others think?

I think that especially for the Windows platform it was an incredible
evolution since a couple of months ago (when it wasn't even possible
to successfully compile) to arrive at this almost stable Beta1 :)

Kudos to all developers!

BTW I do hope that bug 43422
(https://bugs.freedesktop.org/show_bug.cgi?id=43422) can be fixed
before Beta2 :)
It is really a show stopper!

I hope blocker doesn't refer to the final build only? :)

--
Pedro
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5

[Cor Nouws]

Hi Yifan,

Yifan Jiang wrote (14-12-11 07:46)


1. Thanks for Rimas and Petr's actively participating, what we did in the past
two month to improve the structure of Litmus and now the new stuff is online
and a 3.5.0 beta regression test run is created, in which we are encouraging
people to run the tests.

https://tcm.documentfoundation.org/

There are a few important changes need to notify people, especially for l10n
testers that:
[...]


OK, good news!


4. Is it possible to emphasize the regression strategy in the bug hunting
session you are planning? :)


I think it's good to clearly advertise the strategy and explain whatever 
is needed for the improved structure, indeed.



Not sure if some of the points answered your original question :)


Looks as if you perfectly managed to provide the needed additional 
information ;-)



Please let me know if anyone needs more regression test and litmus
related information!


People my feel invited directly here and now - if any needs comes to my 
ears/eyes, I'll make sure it will be further communicated.


Thanks for you help & work,

kind regards,
Cor

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5

[Cor Nouws]

Hi Petr,

Petr Mladek wrote (14-12-11 22:12)

first, I am sorry for the late replay. It was another hectic day.


No problem - it's not uncommon that these are hectic times ;-) and it's 
great to see the results (what you write about too, and what I see with 
the beta1 :-) )



We have beta1 build at http://dev-builds.libreoffice.org/pre-releases/.
Is it being pushed to mirrors. I should get announced tomorrow. Then
people will get it from the official site


:-)


If you feel good about the beta1 build,


My feeling about it is positive. What do others think?


you could start advertizing the bug-hunting session.


It makes no sense to have it on December 16/17. Too short notice.


Otherwise, we are back on track. There should be beta2 by the end of the
following week as planed at
http://wiki.documentfoundation.org/ReleasePlan/3.5#3.5.0_release


OK, so we take that into account when advertising the party.


Does this answer your question?


It perfectly does. Thanks!

Kind regards,
Cor

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.99.1 tag created (3.5.0-beta1)

[Andreas Radke]

Am Wed, 14 Dec 2011 11:59:57 +0100
schrieb Petr Mladek :

> Well, Rene pointed out that there is outdated configure stuff. It
> seems that the script "lo-pack-lources" did not run "autoreconf". You
> might try to run it to refresh the files.

> Tomas saw something similar on Gentoo as well. It might be a
> dependency problem. Does it help you to run the installation without
> any parallelism?

no luck.

> 
> Also I would try to remove /tmp/ooopackaging and /tmp/LibreOffice_SDK
> and similar directories to make sure that there is not mess from the
> past.

build is done in a clean chroot each time. shouldn't be a problem. the
beta0 built fine here.
> 
> Just to be sure. Do you have enough free space in /tmp?

sure. just rechecked it.

> Otherwise, I havn't seen it, so it is had for me to debug it :-(
> 
> 
> Best Regards,
> Petr

any suggestions welcome.

the only difference to beta0 is the changed internal libvisio src bump.
tried autoconf/autoreconf and make -j1 install without luck :(

-Andy
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] SDK example cherry pick ?

[Andras Timar]

2011/12/11 Lionel Elie Mamane :
> On Sun, Dec 11, 2011 at 09:33:15AM +0100, Laurent Godard wrote:
>
>> do you think it would be possible to cherry-pick these SDK example
>> commits to 3.5. I see no potential negative impact
>
> As a general idea, it looks good, but personally I miss the background
> to evaluate the CSS bits, so I'll leave the cherry-pick to someone
> else.

The CSS bits were all right but I had to push a few followup patches
in order to fix the header/footer of example.html pages and more
importantly to add a makefile that actually copies the python example
to the SDK. I cherry-picked all to libreoffice-3-5 and I also updated
http://api.libreoffice.org

Many thanks for your work, Laurent.

Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] What do we want from extensions module?

[Michael Stahl]

On 14/12/11 12:34, Matúš Kukan wrote:
> Hi,
> 
> I'm going to have a look at converting extensions to gbuild.

i have dug out my incomplete patches this afternoon and made them
actually build, which took longer than expected :)

result of that is in feature/gbuild_extensions branch; ~6 libraries
already converted.

(i think doing this on a branch is a good idea because there is a lot of
platform specific stuff in there and i remember how the desktop
conversion went...)

> But I'd like to avoid converting unused things and extensions look old.
> 
> I think at least source/config/ldap and source/xmlextract are not used.
> I was searching for service strings from ldapbe2.component and
> xmx.component. Is this enough ? Can I delete the directories?
> 
> Probably the rest is used and we want to build it?

hmm, no idea what all that stuff is doing anyway :)

> Best,
> 
> Matus


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] What do we want from extensions module?

[Stephan Bergmann]

On 12/14/2011 04:47 PM, Michael Meeks wrote:

On Wed, 2011-12-14 at 12:34 +0100, Matúš Kukan wrote:

I'm going to have a look at converting extensions to gbuild.
But I'd like to avoid converting unused things and extensions look old.
I think at least source/config/ldap and source/xmlextract are not used.


I believe you're right; IIRC the ldap thing was related to a
proprietary Sun tool to allow remote administration of networks of
OO.o's, I think we can fairly safely kill it - but Stephan is the expert
there.


Ah no, source/config/ldap should still be useful, see the comments in 
officecfg/registry/schema/oo-[ad-]ldap.xcd.sample (ending up in the 
installation set in share/registry/).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANNOUNCE] Branch libreoffice-3-4-5 created

[Petr Mladek]

Hi all,

there have been created the libreoffice-3-4-5 branch. It will be used for fine
tuning of the 3.4.5 bugfix release. It is based on the tag
libreoffice-3.4.5.1 for 3.4.5-rc1 release.

The following rules apply:

+ preferably just translation or blocker fixes
+ only cherry-picking from libreoffice-3-4 branch
+ 2 additional reviews needed; 2nd reviewer pushes
+ no regular merges back to anything

The 'libreoffice-3-4' branch is still active. There are currently not
exact dates for 3.4.6 bugfix release. It will happen if there is a
demand from users and some fixes are available in the 3-4 branch.

Please stay tuned and read more at

   http://wiki.documentfoundation.org/ReleasePlan
   http://wiki.documentfoundation.org/Development/Branches


Now, if you want to switch your clone to the branch, please do:

./g pull -r
./g checkout -b libreoffice-3-4-5 origin/libreoffice-3-4-5

Hopefully it will work for you :-)  Most probably, you will also want to
do (if you haven't done it yet):

git config --global push.default tracking

When you do git push with this, git will push only the branch you are
on; e.g. libreoffice-3-4-5 when you have switched to it.  This will
save you some git shouting at you.


Happy hacking,
Petr



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] QA ideas for 3.5 WAS Re: Improving the QA and Release for 3.5

[Petr Mladek]

Hi Cor,

first, I am sorry for the late replay. It was another hectic day.

On Tue, 2011-12-13 at 23:35 +0100, Cor Nouws wrote:
> Hi Petr,
> 
> Cor Nouws wrote (09-12-11 13:44)
> 
> > On the wiki, I added a section with the draft for the later to create
> > separate wiki page:
> > http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5#DRAFT_for_page_with_info_for_bug-hunting_session
> 
> Is it possible for you - without wanting to stress you - to tell smthg 
> more about the expected planning?

We have beta1 build at http://dev-builds.libreoffice.org/pre-releases/.
Is it being pushed to mirrors. I should get announced tomorrow. Then
people will get it from the official site
http://www.libreoffice.org/download/pre-releases/ .


If you feel good about the beta1 build, you could start advertizing the
bug-hunting session.

Just please, do not advertize
http://dev-builds.libreoffice.org/pre-releases/ to wide public. It is
not mirrored and big trafic would kill the server. Please, use the
official site instead :-)


Otherwise, we are back on track. There should be beta2 by the end of the
following week as planed at
http://wiki.documentfoundation.org/ReleasePlan/3.5#3.5.0_release


Does this answer your question?

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build failed in lingucomponent on Mac

[Tor Lillqvist]

> .mm files are objective-C specific header files. I would convert them to c++

Er, no.  .mm is the conventional extension for Objective-C++ source
files. (Plain Objective-C files have the conventional extension .m,
and Objective-C headers the extension .h.) This is documented in "man
gcc" even, at least on MacOSX.

And as these source files contain Objective-C(++) syntax in addition
to C++, and include Objective-C headers, how would you "convert" them
to C++?

(Objective-C++ is just C++ code that also happens to contain
Objective-C, too. It is not as weird as the name first sounds.)

> since mac now supports c++ based apps.

Don't know what you mean by this... Most of the GUI and other
Mac-specific APIs are declared as Objective-C classes and interfaces
in the various framework headers as far as I know. No C++ bindings
there. Or do you have some concrete counter-example?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Make gbuild output [build CXX] filename also with the .cxx extension

[Bjoern Michaelsen]

Hi Lubos,

On Wed, Dec 14, 2011 at 04:45:29PM +0100, Lubos Lunak wrote:
>  I find it mildly annoying that gbuild outputs "[ build CXX ] 
> starmath/source/types", without the .cxx extension, i.e. a non-existent file. 
> Especially since other target types like LNK do output "[ build LNK ] 
> Library/libsmlo.so". Any objections to the attached patch?

Just some pedantic academics: If anything, the target you are building (and
announcing) is foo.o, not foo.cxx. But I wont waste more keypresses on this, if
you insist to make that on .cxx.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

[Lubos Lunak]

On Wednesday 14 of December 2011, Noel Grandin wrote:
> Thanks Markus, I'll try that in the morning.
>
> Do you know of any trick for catching stack-overflow problems? The
> trick I'm using is pretty painful.

 Reduce the maximum allowed stack size using 'ulimit -s', the app then will 
crash as soon as it reaches the limit.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

[Markus Mohrhard]

Hello Noel,


> Do you know of any trick for catching stack-overflow problems? The
> trick I'm using is pretty painful.
>

Did you try to run the tests with memcheck?

If you do some serious rework in calc it would be nice if you could as
soon as the normal unit tests pass run them one time with
sc_subsequent_filters_test moved from the subsequentcheck target to
the normal in-build test target. Therefore just copy the line in
Module_sc.mk from one target to the other one.

Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

[Noel Grandin]

Thanks Markus, I'll try that in the morning.

Do you know of any trick for catching stack-overflow problems? The
trick I'm using is pretty painful.

On Wed, Dec 14, 2011 at 17:52, Markus Mohrhard
 wrote:
> Hello Noel,
> his is under Ubuntu Linux.
>>
>> I'm trying to track down a stack overflow in my code, and I'm having some
>> trouble running the unit tests under GDB and getting debugging symbols.
>>
>> I'm doing
>>   EXPORT GDBCPPUNITTRACE="gdb --args"
>> then running the module build under /sc
>>   build
>> and then breaking the runaway process using
>>   kill -5
>> and then doing 'bt' in GDB
>>
>
> I think you should enable symbols in sc by running make clean && make
> -sr debug=true in sc.
>
> Then normally
>
> EXPORT GDBCPPUNITTRACE="gdb --args" should open a gdb shell where you
> just type run and can debug the unit test like a normal program. It
> might be a bit tricky depending on which unit test you want to debug
> because this works only for the first one. So you might need to remove
> the second one from Module_sc.mk if you want to debug the other one.
>
> Markus
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build failed in lingucomponent on Mac

[Jonathan Aquilina]

On 14/12/2011 16:32, Matúš Kukan wrote:

On 14 December 2011 15:47, Norbert Thiebaud  wrote:

On Wed, Dec 14, 2011 at 6:23 AM, Matúš Kukan  wrote:

On 13 December 2011 21:38, Michael Stahl  wrote:

wouldn't it be better to simply use gb_Library_add_objcxxobjects instead?

Well, gb_ObjCxxObject_get_source are .mm files and not .cxx so that's
not possible.

so maybe the file should really be a .mm and not a .cxx ?

Can be, I have never seen .mm files except in LibreOffice. I think you
can change that.

.mm files are objective-C specific header files. I would convert them to 
c++ since mac now supports c++ based apps.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANNOUNCE] libreoffice-3.4.5.1 tag created (3.4.5-rc1)

[Petr Mladek]

Hi,

there have been created the libreoffice-3.4.5.1 tag for 3.4.5-rc1
release. The corresponding official builds will be available in the
beginning of the following week.

See the attached list of changes against 3.4.4-final.

I am going to create the libreoffice-3-4-5 branch for the final stabilization.

See also the schedule at 
http://wiki.documentfoundation.org/ReleasePlan#3.4_release
and release criteria at http://wiki.documentfoundation.org/Release_Criteria


Now, if you want to switch your clone to the tag, please do:

./g fetch --tags
./g checkout -b tag-libreoffice-3.4.5.1 libreoffice-3.4.5.1

Alternatively, the packaged sources can be found at
http://dev-builds.libreoffice.org/pre-releases-3-4/src/

Note that the usual pre-release/src directory is still occupied by the
delayed 3.5.0-beta. We might want to move the 3.4 sources there once
the beta1 is on mirrors.


Best Regards,
Petr

+ base
+ fix dnd crash from default assignment operators (fdo#39950) [Caolán McNamara]
+ reenable ADO URL helper UI (fdo#32347) [Lionel Elie Mamane]
+ bootstrap
+ add .ppsx (fdo#39963) [Tor Lillqvist]
+ calc
+ avoid using ulimit_cast between signed and unsigned. (fdo#39589) [Kohei Yoshida]
+ boolean values are valid for matrix evaluation (fdo#49967) [Markus Mohrhard]
+ correctly map external ranges into matrix instances. (fdo#40110) [Kohei Yoshida]
+ display caption strings without format detection. (fdo#42169) [Kohei Yoshida]
+ fixed Libreoffice calc crashes when re-opening a xlxs file (rhbz#754051) [Eike Rathke]
+ prevent access to non existing mdds elements (fdo#41807) [Markus Mohrhard]
+ set the logic straight for "center across selection" setting. (fdo#43308) [Kohei Yoshida]
+ components
+ change logic of IsOfficeRunning custom action (fdo#36677) [Andras Timar]
+ fix (bnc#653688) [Thorsten Behrens]
+ fix handling of SAFEARRAY(s) returned as variant in olebridge (fdo#38441) [Noel Power]
+ filters
+ fix : Auto fit text VIEWING too small in PPT (fdo#41245) [Arnaud Versini]
+ fix crash while opening certain pptx files. (bnc#706792) [Muthu Subramanian]
+ libs-core
+ - turn DocBasicItems into an rtl::Static to improve shutdown on mac (fdo#39520) [Michael Meeks]
+ fix the drawing of dotted and dashed borders in Calc. (fdo#37129) [Tomofumi Yagi]
+ pImplementationName is not a compile-time constant (fdo#36555) [Lionel Elie Mamane]
+ libs-gui
+ fix crash at exit ( access of deleted GtkSalDisplay instance ) (bnc#728603) [Noel Power]
+ fix horizontal scrollbars with KDE oxygen style (bnc#722918) [Luboš Luňák]
+ fix the drawing of dotted and dashed borders in Calc. (fdo#37129) [Tomofumi Yagi]
+ resolves tmp name reuse in mass pdf export (fdo#41295) [Caolán McNamara]
+ postprocess
+ make the 3D transitions work again (bnc#728559) [Radek Doulik]
+ translations
+ workaround, remove access key to prevent crash (fdo#30977) [Andras Timar]
+ writer
+ backport of 3524727db0f3cfecf3a47046795c527808c10c3e (i#58612) [Luboš Luňák]
+ fix fallout - recognize .svg in odt container (fdo#41995) [Thorsten Behrens]
+ nO_STYLE default for borderlines mso import, fixes image size issue (bnc#718971) [Noel Power]
+ swDoc::ReplaceRangeImpl: (i#102333) [Michael Stahl]
+ swView::ExecSearch: (fdo#40831) [Michael Stahl]
+ common
+ version 3.4.5.1, tag libreoffice-3.4.5.1 (3.4.5-rc1) [Petr Mladek]
+ base
+ fix dnd crash from default assignment operators (fdo#39950) [Caolán McNamara]
+ reenable ADO URL helper UI (fdo#32347) [Lionel Elie Mamane]
+ bootstrap
+ add .ppsx (fdo#39963) [Tor Lillqvist]
+ bump product version to 3.4.5-rc1, release number to 501 [Petr Mladek]
+ create this dir so uninstall can remove it [Andras Timar]
+ remove a stray leading '+' [Fridrich Štrba]
+ use latest versions of DejaVu and Liberation fonts [Andras Timar]
+ use short paths, because '(x86)' in the path causes problem [Andras Timar]
+ calc
+ avoid using ulimit_cast between signed and unsigned. (fdo#39589) [Kohei Yoshida]
+ boolean values are valid for matrix evaluation (fdo#49967) [Markus Mohrhard]
+ correctly map external ranges into matrix instances. (fdo#40110) [Kohei Yoshida]
+ display caption strings without format detection. (fdo#42169) [Kohei Yoshida]
+ fixed Libreoffice calc crashes when re-opening a xlxs file (rhbz#754051) [Eike Rathke]
+ fixed the wrong keyboard selection behavior in reference mode. [Kohei Yoshida]
+ prevent access to non existing mdds elements (fdo#41807) [Markus Mohrhard]
+ set the logic straight for "center across selection" setting. (fdo#43308) [Kohei Yoshida]
+ we need to use ValidColRowOrRepeated, silly mistake by me. [Markus Mohrhard]
+ components
+ backport reading AES-encrypted ODF 1.2 documents (as genereated by LibO 3.5). [Stephan Bergmann]
+ change logic of IsOfficeRunning custom action (fdo#36677) [Andras Timar]
+ fix (bnc#653688) [Thorst

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

[Ivan Timofeev]

14.12.2011 17:01, Michael Meeks пишет:

On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote:

If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was
introduced to control whether a simple check mark [x] or an image should
be painted with a checkable menu item; if it is so, it don't work anyway.
But may be I missed some piece of logic again :)


So - you're right; sorry for the noise ! :-) How does it look with your
fix in place ? :-)


see the attaches :)

I've tweaked menu.cxx a bit and have added "Checkable = TRUE ; \" to 
some (not all) indigent menu items in sw/source/ui/app/mn.src, don't 
know whether this is a right solution. If so, we should very carefully 
visit all such src files.


And somehow we should enable MENU_FLAG_SHOWCHECKIMAGES for win I think. 
I have not enough time to do that now, crazy pre-session weeks have 
started! :)


Regards,
Ivan
<>diff --git a/sw/source/ui/app/mn.src b/sw/source/ui/app/mn.src
index edcaa8e..71d72ee 100644
--- a/sw/source/ui/app/mn.src
+++ b/sw/source/ui/app/mn.src
@@ -76,41 +76,50 @@
 {\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_WEIGHT\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_POSTURE\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_OVERLINE\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_UNDERLINE\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_STRIKEOUT\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_SHADOWED\
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 ITEM_FORMAT_ATTR_CHAR_CONTOUR\
 };\
 SEPARATOR ; \
 MenuItem\
 {\
+Checkable = TRUE ; \
 Identifier = FN_SET_SUPER_SCRIPT ; \
 HelpId = CMD_FN_SET_SUPER_SCRIPT ; \
 Text [ en-US ] = "Superscript" ; \
 };\
 MenuItem\
 {\
+Checkable = TRUE ; \
 Identifier = FN_SET_SUB_SCRIPT ; \
 HelpId = CMD_FN_SET_SUB_SCRIPT ; \
 Text [ en-US ] = "Subscript" ; \
@@ -1141,18 +1150,22 @@ Menu MN_ANNOTATION_POPUPMENU
 {
 MenuItem\
 {\
+Checkable = TRUE ;\
 ITEM_FORMAT_ATTR_CHAR_WEIGHT\
 };\
 MenuItem\
 {\
+Checkable = TRUE ;\
 ITEM_FORMAT_ATTR_CHAR_POSTURE\
 };\
 MenuItem\
 {\
+Checkable = TRUE ;\
 ITEM_FORMAT_ATTR_CHAR_UNDERLINE\
 };\
 MenuItem\
 {\
+Checkable = TRUE ;\
 ITEM_FORMAT_ATTR_CHAR_STRIKEOUT\
 };\
 SEPARATOR ;
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index e143dfe..9f6ac6e 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -2434,7 +2434,8 @@ Size Menu::ImplCalcSize( Window* pWin )
 }
 
 // Image:
-if ( !bIsMenuBar && ( ( pData->eType == MENUITEM_IMAGE ) || ( pData->eType == MENUITEM_STRINGIMAGE ) ) )
+if ( !bIsMenuBar && ( ( pData->eType == MENUITEM_IMAGE ) || ( pData->eType == MENUITEM_STRINGIMAGE ) ) &&
+ ( (nMenuFlags & MENU_FLAG_SHOWCHECKIMAGES) || !pData->HasCheck() ) )
 {
 Size aImgSz = pData->aImage.GetSizePixel();
 aImgSz.Height() += 4; // add a border for native marks
@@ -2748,7 +2749,8 @@ void Menu::ImplPaint( Window* pWin, sal_uInt16 nBorder, long nStartY, MenuItemDa
 // however do not do this if native checks will be painted since
 // the selection color too often does not fit the theme's check and/or radio
 
-if( ! ( ( pData->eType == MENUITEM_IMAGE ) || ( pData->eType == MENUITEM_STRINGIMAGE ) ) )
+if( ! ( ( pData->eType == MENUITEM_IMAGE ) || ( pData->eType == MENUITEM_STRINGIMAGE ) ) ||
+(nMenuFlags & MENU_FLAG_SHOWCHECKIMAGES) == 0 )
 {
 if ( pWin->IsNativeControlSupported( CTRL_MENU_POPUP,
   

Re: [Libreoffice] What do we want from extensions module?

[Bjoern Michaelsen]

On Wed, Dec 14, 2011 at 03:47:23PM +, Michael Meeks wrote:
> Stephan do we still need this stuff:
> 
>   + ConsoleHandler - apparently unused outside this code
>   + CsvFormatter - ditto
>   + LoggerPool - only by the Java report wizard [!]
>   + is that really necessary ? - can we rip/replace ?
>   + FileHandler - used by smoketest/lo_smoketest.py ?
>   + also by the config's DefaultHandler key
>   + PlainTextFormatter - mentioned in config 'DefaultLogger' key
>   => need to unwind where / when / if those keys are used.
>   => unclear why we want to got this roundabout route for logging.
> 
>   Do we really need this UNO logger ? and/or what is it used for ?

It was (re-)used by the usage tracking, which has already been removed along
with automation. However, this being UNO might have also been used by
extensions, although IMHO it does not have to be kept around for that for 3.6
IMHO.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] getting debug symbols when running build unit tests under gdb?

[Markus Mohrhard]

Hello Noel,
his is under Ubuntu Linux.
>
> I'm trying to track down a stack overflow in my code, and I'm having some
> trouble running the unit tests under GDB and getting debugging symbols.
>
> I'm doing
>   EXPORT GDBCPPUNITTRACE="gdb --args"
> then running the module build under /sc
>   build
> and then breaking the runaway process using
>   kill -5
> and then doing 'bt' in GDB
>

I think you should enable symbols in sc by running make clean && make
-sr debug=true in sc.

Then normally

EXPORT GDBCPPUNITTRACE="gdb --args" should open a gdb shell where you
just type run and can debug the unit test like a normal program. It
might be a bit tricky depending on which unit test you want to debug
because this works only for the first one. So you might need to remove
the second one from Module_sc.mk if you want to debug the other one.

Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||43831

--- Comment #47 from Rainer Bielefeld  
2011-12-14 07:52:04 PST ---
Nominate "Bug 43831 - Advanced FILTER incompatible with 3.4.4 documents" -  we
should not break compatibility

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] libicudata ICU data info

[Mike Whiteley]

The current libicudata is about 15MB, but it doesn't need
to be that large.  We can probably get it down to 5MB
or less. I took a bit of time on this.

1) The configuration files needed to modify what is actually
in icudata are NOT included in the package in libreoffice's repository.
A real "source" package can be downloaded, which is what we'll
need to do if we want to customize this library.

2) The bulk of the data in (our non-source package) icudata
comes from an input file ./source/data/in/icudt44l.dat.  This
file can be removed which causes the resulting icudata library to
go from 15MB to 4.4MB.  Reading the ICU data web page leads
me to believe this 4.4MB file has enough to handle most stuff,
but I'm not sure.
HELP:  We should try this solution first.  Will someone please
who knows more about icudata see if a library build this way
is enough for what libreoffice needs?

3) There are two icudata packages in my repository.  Probably
one of them can be deleted (also, these are not pure source
packages anyways).

4) I downloaded a real source package from ICU, and can build
a custom library where we can do whatever we want. I can build
a custom version of libicudata using version 4.8 which results
in about a 7MB library, which I believe has all of the basic
conversion tables, but again I'm not sure and someone who knows
more than I do regarding the needs of libreoffice needs to test
this.

5) Keep in mind my knowledge of icudata is still very limited,
and this information is only from me reading their web pages for
20 min, and me messing with code for another 20 minutes.

Anyways, I just thought this would be helpful.

Mike

Michael Whiteley
Engineer/Law Student
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] What do we want from extensions module?

[Michael Meeks]

Hi Matus & Stephan,

On Wed, 2011-12-14 at 12:34 +0100, Matúš Kukan wrote:
> I'm going to have a look at converting extensions to gbuild.

Lovely :-)

> But I'd like to avoid converting unused things and extensions look old.

Sure.

> I think at least source/config/ldap and source/xmlextract are not used.

I believe you're right; IIRC the ldap thing was related to a
proprietary Sun tool to allow remote administration of networks of
OO.o's, I think we can fairly safely kill it - but Stephan is the expert
there.

> Probably the rest is used and we want to build it?

I think so; I did my own audit (results below). I think we can kill the
'stardiv' directory too - it looks unused.

The extensions/source/logging/ thing looks horribly over-engineered -
Stephan do we still need this stuff:

+ ConsoleHandler - apparently unused outside this code
+ CsvFormatter - ditto
+ LoggerPool - only by the Java report wizard [!]
+ is that really necessary ? - can we rip/replace ?
+ FileHandler - used by smoketest/lo_smoketest.py ?
+ also by the config's DefaultHandler key
+ PlainTextFormatter - mentioned in config 'DefaultLogger' key
=> need to unwind where / when / if those keys are used.
=> unclear why we want to got this roundabout route for logging.

Do we really need this UNO logger ? and/or what is it used for ?

unoactivex also appears unused.

xmlextract seems also to be unused (as you say).
com.sun.star.comp.io.XMLExtractor

Beyond that the code looks used & useful.

Does that help ? :-)

Thanks,

Michael.


-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Make gbuild output [build CXX] filename also with the .cxx extension

[Lubos Lunak]

 Hello,

 I find it mildly annoying that gbuild outputs "[ build CXX ] 
starmath/source/types", without the .cxx extension, i.e. a non-existent file. 
Especially since other target types like LNK do output "[ build LNK ] 
Library/libsmlo.so". Any objections to the attached patch?

-- 
 Lubos Lunak
 l.lu...@suse.cz
From 464ede47d4d22326780413ef30a0f39fec6b07aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= 
Date: Wed, 14 Dec 2011 16:41:01 +0100
Subject: [PATCH] make gbuild output [Build CXX] filename also with the .cxx extension

---
 solenv/gbuild/platform/WNT_INTEL_MSC.mk |2 +-
 solenv/gbuild/platform/com_GCC_class.mk |2 +-
 solenv/gbuild/platform/solaris.mk   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
index 5f8fb1c..a81215d 100644
--- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk
+++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk
@@ -300,7 +300,7 @@ endef
 # CxxObject class
 
 define gb_CxxObject__command
-$(call gb_Output_announce,$(2),$(true),CXX,3)
+$(call gb_Output_announce,$(2).cxx,$(true),CXX,3)
 $(call gb_Helper_abbreviate_dirs_native,\
 	mkdir -p $(dir $(1)) $(dir $(4)) && \
 	$(gb_CXX) \
diff --git a/solenv/gbuild/platform/com_GCC_class.mk b/solenv/gbuild/platform/com_GCC_class.mk
index 61afbc1..5bf7740 100644
--- a/solenv/gbuild/platform/com_GCC_class.mk
+++ b/solenv/gbuild/platform/com_GCC_class.mk
@@ -44,7 +44,7 @@ endef
 
 # $(call gb_CxxObject__command,object,relative-source,source,dep-file)
 define gb_CxxObject__command
-$(call gb_Output_announce,$(2),$(true),CXX,3)
+$(call gb_Output_announce,$(2).cxx,$(true),CXX,3)
 $(call gb_Helper_abbreviate_dirs,\
 	mkdir -p $(dir $(1)) $(dir $(4)) && \
 	$(gb_CXX) \
diff --git a/solenv/gbuild/platform/solaris.mk b/solenv/gbuild/platform/solaris.mk
index a51edbf..6287cfe 100644
--- a/solenv/gbuild/platform/solaris.mk
+++ b/solenv/gbuild/platform/solaris.mk
@@ -173,7 +173,7 @@ endef
 # CxxObject class
 
 define gb_CxxObject__command
-$(call gb_Output_announce,$(2),$(true),CXX,3)
+$(call gb_Output_announce,$(2).cxx,$(true),CXX,3)
 $(call gb_Helper_abbreviate_dirs,\
 	mkdir -p $(dir $(1)) $(dir $(4)) && \
 	$(gb_CXX) \
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] getting debug symbols when running build unit tests under gdb?

[Noel Grandin]

Hi

This is under Ubuntu Linux.

I'm trying to track down a stack overflow in my code, and I'm having some 
trouble running the unit tests under GDB and
getting debugging symbols.

I'm doing
  EXPORT GDBCPPUNITTRACE="gdb --args"
then running the module build under /sc
  build
and then breaking the runaway process using
  kill -5
and then doing 'bt' in GDB

But all I get is
#110137 0x40b0ddc1 in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110138 0x40a96883 in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110139 0x40a6b9db in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110140 0x40b0ddc1 in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110141 0x40a96883 in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110142 0x40a6b9db in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so
#110143 0x40b0ddc1 in ?? () from 
/home/noel/libo/solver/unxlngi6.pro/lib/libsclo.so

Any ideas?

Thanks, Noel Grandin


Disclaimer: http://www.peralex.com/disclaimer.html


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build failed in lingucomponent on Mac

[Matúš Kukan]

On 14 December 2011 15:47, Norbert Thiebaud  wrote:
> On Wed, Dec 14, 2011 at 6:23 AM, Matúš Kukan  wrote:
>> On 13 December 2011 21:38, Michael Stahl  wrote:
>>> wouldn't it be better to simply use gb_Library_add_objcxxobjects instead?
>>
>> Well, gb_ObjCxxObject_get_source are .mm files and not .cxx so that's
>> not possible.
>
> so maybe the file should really be a .mm and not a .cxx ?

Can be, I have never seen .mm files except in LibreOffice. I think you
can change that.

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build failed in lingucomponent on Mac

[Norbert Thiebaud]

On Wed, Dec 14, 2011 at 6:23 AM, Matúš Kukan  wrote:
> On 13 December 2011 21:38, Michael Stahl  wrote:
>> wouldn't it be better to simply use gb_Library_add_objcxxobjects instead?
>
> Well, gb_ObjCxxObject_get_source are .mm files and not .cxx so that's
> not possible.

so maybe the file should really be a .mm and not a .cxx ?

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED][PUSHED:3-4] Fix overly zealous check in Zip package consistency

[Petr Mladek]

Michael Meeks píše v St 14. 12. 2011 v 14:10 +:
> On Wed, 2011-12-14 at 14:42 +0100, Thorsten Behrens wrote:
> > Michael Meeks wrote:
> > >   I'd be happier to see the nMethod being compared if we had removed the
> > > comment, and/or at least understood whether it is still relevant: are we
> > > using/changing nMethod elsewhere ?
> >
> > Yep, good point. Tweaked for master. That comment looks false, did
> > not find any place where that would be used - also, FWICT, it would
> > not comply with the zip appnote...
> 
>   Great; I did the same git grep and it seems it's only fiddle with on
> writing so we should get it in :-)

Thanks for review. I have pushed it into libreoffice-3-4 branch. It will
be in 3.4.5-rc1.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [michael.me...@suse.com: [Fwd: Re: build failure in tail_build]]

[Bjoern Michaelsen]

Hi there,

as this is a WaE breaker, I would suggest to build without --enable-werror
until we figured out if boost or gcc is wrong here. In general it is a good
idea to stay away from fancy configure-flags in the beginning(*).

Best,

Bjoern

see also: https://lkml.org/lkml/2006/11/29/249 Linus about the "perfect kernel" 
;)

- Forwarded message from Michael Meeks  -

Date: Wed, 14 Dec 2011 14:20:17 +
From: Michael Meeks 
To: Bjoern Michaelsen 
Subject: [Fwd: Re: [Libreoffice] build failure in tail_build]
X-Mailer: Evolution 3.2.1

The logs - I guess the list bounced them :-)

 Forwarded Message 
From: Daisuke Nishino 
To: michael.me...@suse.com
Cc: libreoffice@lists.freedesktop.org
Subject: Re: [Libreoffice] build failure in tail_build
Date: Wed, 14 Dec 2011 21:31:11 +0900

Michael,

Thank you for reply.
I attached the log produced by make -r in tail_build (make.log.zip).

Additionally, make2.log is the one produced by running 'make -r'
immediately after the first 'make -r', both in tail_build.
This one includes more informative error messages.

I hope this helps fix the problem.

My system is Ubuntu 11.10 Oneiric Ocelot.
$ uname -a
Linux amane 3.0.0-12-generic #20-Ubuntu SMP Fri Oct 7 14:50:42 UTC 2011
i686 i686 i386 GNU/Linux

 
Thanks


On 14 December 2011 03:32, Michael Meeks  wrote:
Hi Daisuke,

On Wed, 2011-12-14 at 00:47 +0900, Daisuke Nishino wrote:
> Actually make in tail_build subdirectory was not suceeded.


   Bother.

> Its exit code was 2. (I was confused because I was using tee
command
> to pipe the output, accordingly subsequent $? evaluated to 0)
> No error message was produced anyway.


   Ok - that is annoying indeed. To get a failure without
any error
message is quite unusual and unhelpful of course.

   Can you provide full logs of a failing 'make' in
tail_build, and more
information on your system ?

   Sorry for the delay,

   ATB,

   Michael.

--
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot




-- 
Daisuke Nishino

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot




- End forwarded message -
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Hi ! We are new on libo!

[Michael Meeks]

Hi Martin,

On Wed, 2011-12-14 at 14:34 +0100, Martin Richard wrote:
> I am Martin Richard, a French student in CS.

Welcome ! (and great English too) :-)

> I'll probably be active on IRC under the nickname martius during the
> next weeks.

Looking forward to working with you,

All the best,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] Fix overly zealous check in Zip package consistency

[Michael Meeks]

On Wed, 2011-12-14 at 14:42 +0100, Thorsten Behrens wrote:
> Michael Meeks wrote:
> > I'd be happier to see the nMethod being compared if we had removed the
> > comment, and/or at least understood whether it is still relevant: are we
> > using/changing nMethod elsewhere ?
>
> Yep, good point. Tweaked for master. That comment looks false, did
> not find any place where that would be used - also, FWICT, it would
> not comply with the zip appnote...

Great; I did the same git grep and it seems it's only fiddle with on
writing so we should get it in :-)

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

[Thorsten Behrens]

Michael Meeks wrote:
>   I'd be happier to see the nMethod being compared if we had removed the
> comment, and/or at least understood whether it is still relevant: are we
> using/changing nMethod elsewhere ?
> 
Yep, good point. Tweaked for master. That comment looks false, did
not find any place where that would be used - also, FWICT, it would
not comply with the zip appnote...

Thanks,

-- Thorsten


pgpe5PRknLEaU.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Fix for fdo43460 Part VIII getLength() to isEmpty()

[Olivier Hallot]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Please find attached a partial fix for Easy Hack FDO43460

Part VIII
Module
configmgr
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO6KcTAAoJEJp3R7nH3vLxVxkH/2n4rrAvYDvLtj8mUOyOVeM/
POuqGPlus97l4Y6IIUAadvUolWqu1KIgDODuB9piwaiCZZ7X53xn/zAptDMO2P0S
/NbJBQYE9bjnqLjKhXwAw+AFDXuQMbyS4314hvzK73QGZnlAQ16022bt+KDmge5N
YbyVgwbpcOFMxn6wYJooS5qTkAG8QrnPBPTh4i1ozZIFzr5SMHb/5ayIlcxecyy9
nOJarAgRhaHlHyOZ864aqrJfW/ZnAN2aYAwoxp5SzkZPzL4hdJSB9pH7ZBykvf/u
oQaNvsU82a1I9+n8pi5yvsmV4kOwBXUqU7kyU1fuFetCA5gsv6/YEeS+08MxNwU=
=2f7M
-END PGP SIGNATURE-
>From ab04984845511e01a4ba5b2511ce7b55ef802c5b Mon Sep 17 00:00:00 2001
From: Olivier Hallot 
Date: Wed, 14 Dec 2011 10:59:15 -0200
Subject: [PATCH] Fix for fdo43460 Part VIII getLength() to isEmpty()

Part VIII
Module
comfigmgr
---
 configmgr/source/access.cxx|   16 
 configmgr/source/childaccess.cxx   |6 +++---
 configmgr/source/components.cxx|2 +-
 configmgr/source/configurationprovider.cxx |   22 +++---
 configmgr/source/data.cxx  |   12 ++--
 configmgr/source/propertynode.cxx  |2 +-
 configmgr/source/valueparser.cxx   |6 +++---
 configmgr/source/writemodfile.cxx  |6 +++---
 configmgr/source/xcdparser.cxx |4 ++--
 configmgr/source/xcuparser.cxx |6 +++---
 10 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index dab5e21..51fb2db 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -650,7 +650,7 @@ void Access::initBroadcasterAndChanges(
 case Node::KIND_GROUP:
 case Node::KIND_SET:
 if (i->second.children.empty()) {
-if (child->getNode()->getTemplateName().getLength() != 0) {
+if (!child->getNode()->getTemplateName().isEmpty()) {
 for (ContainerListeners::iterator j(
  containerListeners_.begin());
  j != containerListeners_.end(); ++j)
@@ -1243,7 +1243,7 @@ rtl::OUString Access::getHierarchicalName() throw (css::uno::RuntimeException) {
 path.append(root->getAbsolutePathRepresentation());
 }
 rtl::OUString rel(getRelativePathRepresentation());
-if (path.getLength() != 0 && rel.getLength() != 0) {
+if (path.getLength() != 0 && !rel.isEmpty()) {
 path.append(sal_Unicode('/'));
 }
 path.append(rel);
@@ -1259,7 +1259,7 @@ rtl::OUString Access::composeHierarchicalName(
 assert(thisIs(IS_ANY));
 osl::MutexGuard g(*lock_);
 checkLocalizedPropertyAccess();
-if (aRelativeName.getLength() == 0 || aRelativeName[0] == '/') {
+if (aRelativeName.isEmpty() || aRelativeName[0] == '/') {
 throw css::lang::IllegalArgumentException(
 rtl::OUString(
 RTL_CONSTASCII_USTRINGPARAM(
@@ -1299,7 +1299,7 @@ void Access::setName(rtl::OUString const & aName)
 rtl::Reference< Access > parent(getParentAccess());
 if (parent.is()) {
 rtl::Reference< Node > node(getNode());
-if (node->getTemplateName().getLength() != 0) {
+if (! node->getTemplateName().isEmpty()) {
 rtl::Reference< ChildAccess > other(
 parent->getChild(aName));
 if (other.get() == this) {
@@ -1995,7 +1995,7 @@ rtl::Reference< ChildAccess > Access::getUnmodifiedChild(
 rtl::Reference< ChildAccess > Access::getSubChild(rtl::OUString const & path) {
 sal_Int32 i = 0;
 // For backwards compatibility, allow absolute paths where meaningful:
-if (path.getLength() != 0 && path[0] == '/') {
+if (!path.isEmpty() && path[0] == '/') {
 ++i;
 if (!getRootAccess().is()) {
 return rtl::Reference< ChildAccess >();
@@ -2042,13 +2042,13 @@ rtl::Reference< ChildAccess > Access::getSubChild(rtl::OUString const & path) {
 switch (p->kind()) {
 case Node::KIND_LOCALIZED_PROPERTY:
 if (!Components::allLocales(getRootAccess()->getLocale()) ||
-templateName.getLength() != 0)
+!templateName.isEmpty())
 {
 return rtl::Reference< ChildAccess >();
 }
 break;
 case Node::KIND_SET:
-if (templateName.getLength() != 0 &&
+if (!templateName.isEmpty() &&
 !dynamic_cast< SetNode * >(p.get())->isValidTemplate(
 templateNam

[Libreoffice] Hi ! We are new on libo!

[Martin Richard]

Hi all,

I am Martin Richard, a French student in CS.

As a school project, a friend and I have the luck to be able to work on
Libre Office Writer, mentored by Cédric Bosdonnat.

We will work on the libre-office file picker in order to add some new
interesting features, such as a list of highlighted places, allowing direct
access to recently used files, favorites directories and FTP servers. At
last, we would like to contribute to Cedric's library libcmis and continue
his work of integration of repositories implementing CMIS (sharepoint,
alfresco, etc).

I'll probably be active on IRC under the nickname martius during the next
weeks.

My friend Julien will probably come forward soon.

Cheers,
Martin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

[Michael Meeks]

On Wed, 2011-12-14 at 13:38 +0100, Thorsten Behrens wrote:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=309f56174aca6adca879f70958892492361dac6e
> fixes an import problem for files generated with an apparently
> different code base for zip archives - the deviation is benign, and
> should be accepted on import.

I'd be happier to see the nMethod being compared if we had removed the
comment, and/or at least understood whether it is still relevant: are we
using/changing nMethod elsewhere ?

// the method can be reset for internal use so it is not checked
bBroken = rEntry.nVersion != nVersion
-   || rEntry.nFlag != nFlag
+   | rEntry.nMethod != nHow
|| rEntry.nTime != nTime

And - I guess we nearly hit tripple review time ;-)

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Change cell border on many sheets?

[Michael Meeks]

On Wed, 2011-12-14 at 07:47 -0500, . wrote:
> If this list is for developers then I need your expert help;

I'm sorry; this is not a suitable question for this list - which is to
discuss development of the code, patches, etc.

Please ask the users' list cf. us...@global.libreoffice.org - I'm
afraid you have to subscribe before you'll get a reply there though.

Thanks,

michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

[Michael Meeks]

Hi Ivan,

On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote:
> I see no feature here... When icons in menus are disabled - there is no 
> problem, but when they are enabled - nothing is painted at the left of a 
> checkable menu item, neither a check mark [x] nor an image (see the 
> attached image).

Ah - that is indeed buggy :-) you screenshot shows that; thanks ! at
least in the gtk+ mode, I'd expect to see the check-able box in place of
the icons; I'd also expect to see an empty surround [ ] for un-checked
items - eg. Italic: presumbly we are missing some annotation on those
underlying SfxItems (?) denoting that they are check-able as well [ so
we only see that when they are checked ].

> If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was 
> introduced to control whether a simple check mark [x] or an image should 
> be painted with a checkable menu item; if it is so, it don't work anyway.
> But may be I missed some piece of logic again :)

So - you're right; sorry for the noise ! :-) How does it look with your
fix in place ? :-)

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Change cell border on many sheets?

[.]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

If this list is for developers then I need your expert help;

I upgraded from Oo 3.2 (I think that was the version) to the following
version of LibreOffice;

LibreOffice 3.4.3
OOO340m1 (Build:302)

A spreadsheet I work on had the cell borders set at 1 pt. in Oo. Now
with LibreOffice all of the cell borders on the sheet are .25 pt.  A
change was made to the cell border sizes and I didn't do it.

How do I quickly change ALL of the cell borders in the many sheets I'm
working on?  I have literally 1,000's of cells in around 90 sheets to
fix IF I have to
change each cell one at a time.

I need a way to change the cell border sizes that are set by LibreOffice
Calc by defualt and have them applied to all of the sheets I need changed.




 Man, do I need some help!

Thanks.


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO6JrSAAoJEPBpZNn4grcjwmsH/3IE1QD7IWtpCzIJIVCpNL2K
QqnWK4bAd11YjRYoi5kymR6DV2L7bzolaD97+vOts8X6LS+Lz/KtzF1WM60HgZXu
1aL+JxLwxgnhHAtPCPUP8sEsPMUjaHKxkIldCxudjHJYamujAYIHf29V2zbM6wrj
93X3KcKefq0kA8jMtr+dI2s7pmoXWd+DEGg2g8nSq/M/61vQTb8OaKpJlv1ybp1b
tXAzJ5+c5WrDjEZ0JBtOhUANfrc67m7vxi9Ton8yuXnxT1LpvJE7DrqbPzUfZirl
wHdNgFTnjYMHJzELQbu6A7R4T8TGWkgjdaQsEqsJ8nU2U8zm3Lf3TLv+FaUHXLs=
=cnqv
-END PGP SIGNATURE-

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency

[Thorsten Behrens]

Hi there,

http://cgit.freedesktop.org/libreoffice/core/commit/?id=309f56174aca6adca879f70958892492361dac6e
fixes an import problem for files generated with an apparently
different code base for zip archives - the deviation is benign, and
should be accepted on import.

Original bugreport:
 https://bugzilla.novell.com/show_bug.cgi?id=653688

Review & cherry-pick for -3-4 appreciated.

Thanks a lot,

-- Thorsten


pgpeGBeRY2HL3.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Dangling symlinks (was: make dev-install hangs)

[Markus Mohrhard]

Hey,


> These are dangling symlinks such as
> test/user-template/user/config/images_tango.zip -> 
> /devel/libo/libo1/packimages/unxlngx6.pro/bin/images_tango.zip
>
> Any reason they were added to the repository? Or can they be safely
> removed?
>

Will be fixed in some minutes.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Dangling symlinks (was: make dev-install hangs)

[Eike Rathke]

Hi,

On Wednesday, 2011-12-14 11:53:44 +0100, Miklos Vajna wrote:

> ctags: Warning: cannot open source file 
> "test/user-template/user/config/images_tango.zip" : No such file or directory
> ctags: Warning: cannot open source file 
> "test/user-template/user/config/images_oxygen.zip" : No such file or directory
> ctags: Warning: cannot open source file 
> "test/user-template/user/config/images_hicontrast.zip" : No such file or 
> directory
> ctags: Warning: cannot open source file 
> "test/user-template/user/config/images_crystal.zip" : No such file or 
> directory
> ctags: Warning: cannot open source file 
> "test/user-template/user/config/images.zip" : No such file or directory

These are dangling symlinks such as
test/user-template/user/config/images_tango.zip -> 
/devel/libo/libo1/packimages/unxlngx6.pro/bin/images_tango.zip

Any reason they were added to the repository? Or can they be safely
removed?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpgWsdsih6VC.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build failed in lingucomponent on Mac

[Matúš Kukan]

On 13 December 2011 21:38, Michael Stahl  wrote:
> wouldn't it be better to simply use gb_Library_add_objcxxobjects instead?

Well, gb_ObjCxxObject_get_source are .mm files and not .cxx so that's
not possible.

> can you try if that works?

I tried to push the change and had to revert, sorry for that.

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5

[Stephan Bergmann]

On 12/14/2011 11:54 AM, Stephan Bergmann wrote:

On 12/14/2011 11:41 AM, Pedro Lino wrote:

LO stores information about a selected JRE in the user profile at
config/javasettings_*.xml. Can you verify that just deleting that
file from
the bad old user profile would already be enough to solve the crash?


Yes, I can confirm that. I made some extensive testing.

This problem occurs if the user uninstalls or downgrades the Java
version (i.e. from 7 to 6)

This happens because under Windows the absolute path to Java is stored
in file javasettings_Windows_x86.xml located in
%AppData%\LOdev\3\user\config

E.g.file:///C:/Program%20Files/Java/jre6


Somehow sounds like a well-known problem from OOo times to me (but one
having already been addressed, I thought). Will have a look.


Hm, cannot reproduce this on Linux at least.  When I consistently change 
all the file URLs in user/config/javasettings_Linux_X86_64.xml 
(including the ones encoded in the !) from the 
file:///usr/lib/jvm/... used on my machine to a non-existing 
file:///usrXX/lib/jvm/..., then restart soffice.bin directly (instead of 
soffice wrapper, to avoid interference with a confused javaldx), and 
start the Letter wizard, LO complains about a broken Java installation 
and does not crash.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] What do we want from extensions module?

[Matúš Kukan]

Hi,

I'm going to have a look at converting extensions to gbuild.
But I'd like to avoid converting unused things and extensions look old.

I think at least source/config/ldap and source/xmlextract are not used.
I was searching for service strings from ldapbe2.component and
xmx.component. Is this enough ? Can I delete the directories?

Probably the rest is used and we want to build it?

Best,

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] make dev-install hangs

[Bjoern Michaelsen]

On Wed, Dec 14, 2011 at 11:53:44AM +0100, Miklos Vajna wrote:
> Something similar: it seems some targets are now executed twice (see
> below).
Indeed. Should be fixed with:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c197011a564c185db425d38425f3a89c1700c9d

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.99.1 tag created (3.5.0-beta1)

[Petr Mladek]

Andreas Radke píše v Út 13. 12. 2011 v 18:12 +0100:
> Am Tue, 13 Dec 2011 14:30:01 +0100
> schrieb Petr Mladek :
> 
> > Andreas Radke píše v Út 13. 12. 2011 v 05:14 +0100:
> > > I'm running into this new build issue:
> > 
> > Sigh, I have created the source tarballs from master instead of the
> > libreoffice-3.4.99.1 tag.
> > 
> > Could you please dowload the updated tarballs from
> > http://dev-builds.libreoffice.org/pre-releases/src/ and try the build
> > once again?
> 
> Are you sure the new tarballs are fixed? I've tried the new .xz ones and
> I'm still getting the same error.

They should be fine.

Well, Rene pointed out that there is outdated configure stuff. It seems
that the script "lo-pack-lources" did not run "autoreconf". You might
try to run it to refresh the files.

> Any idea?
> 
> Subroutine installer::epmfile::getcwd redefined at 
> /build/src/libreoffice-core-3.4.99.1/solenv/bin/modules/installer/epmfile.pm 
> line 43
> ... checking environment variables ...
> rmdir: failed to remove `/tmp/LibreOffice//logging/': Directory not empty
> 
> ***
> Successful packaging process!
> ***
> Running SDK installer
> Subroutine installer::epmfile::getcwd redefined at 
> /build/src/libreoffice-core-3.4.99.1/solenv/bin/modules/installer/epmfile.pm 
> line 43
> ... checking environment variables ...
> rmdir: failed to remove `/tmp/LibreOffice_SDK//logging/': Directory not empty
> Can't copy file: 
> /tmp/ooopackaging/i_243901323795664/unxlngx6.pro/LibreOffice_SDK//zip/en-US/00/odkcommon_zip/idl/com/sun/star/io/TextInputStream.idl
>  -> 
> /build/src/fakeinstall/usr/lib/libreoffice/sdk/idl/com/sun/star/io/TextInputStream.idl
>  No such file or directory at 
> /build/src/libreoffice-core-3.4.99.1/solenv/bin/modules/installer/worker.pm 
> line 737.
> Failed to install:  at 
> /build/src/libreoffice-core-3.4.99.1/solenv/bin/ooinstall line 129.
> make[1]: *** [install] Error 2
> make[1]: Leaving directory `/build/src/libreoffice-core-3.4.99.1'
> make: *** [source-env-and-recurse] Error 2

Tomas saw something similar on Gentoo as well. It might be a dependency
problem. Does it help you to run the installation without any
parallelism?

Also I would try to remove /tmp/ooopackaging and /tmp/LibreOffice_SDK
and similar directories to make sure that there is not mess from the
past.

Just to be sure. Do you have enough free space in /tmp?

Otherwise, I havn't seen it, so it is had for me to debug it :-(


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5

[Stephan Bergmann]

On 12/14/2011 11:41 AM, Pedro Lino wrote:

LO stores information about a selected JRE in the user profile at
config/javasettings_*.xml.  Can you verify that just deleting that file from
the bad old user profile would already be enough to solve the crash?


Yes, I can confirm that. I made some extensive testing.

This problem occurs if the user uninstalls or downgrades the Java
version (i.e. from 7 to 6)

This happens because under Windows the absolute path to Java is stored
in file javasettings_Windows_x86.xml located in
%AppData%\LOdev\3\user\config

E.g.file:///C:/Program%20Files/Java/jre6


Somehow sounds like a well-known problem from OOo times to me (but one 
having already been addressed, I thought).  Will have a look.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] make dev-install hangs

[Miklos Vajna]

On Tue, Dec 13, 2011 at 09:57:34AM -0500, Kohei Yoshida 
 wrote:
> Indeed.  It took 6 minutes on my machine for make dev-install to finish,
> but it did finish eventually.

Something similar: it seems some targets are now executed twice (see
below). Maybe related to 8a310e3521db1f9a15a7ec32b3171c4969c461be?

$ time make tags
make[1]: Entering directory `/home/vmiklos/git/libreoffice/master'
make[1]: `/home/vmiklos/git/libreoffice/master/Env.Host.sh' is up to date.
make[1]: Leaving directory `/home/vmiklos/git/libreoffice/master'
make[1]: Entering directory `/home/vmiklos/git/libreoffice/master'
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_tango.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_oxygen.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_hicontrast.zip" : No such file or 
directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_crystal.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images.zip" : No such file or directory
24318 files, 7714976 lines (277015 kB) scanned in 16.8 seconds (16508 kB/s)
1342729 tags added to tag file
1342729 tags sorted in 0.04 seconds
make[1]: Leaving directory `/home/vmiklos/git/libreoffice/master'
make[1]: Entering directory `/home/vmiklos/git/libreoffice/master'
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_tango.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_oxygen.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_hicontrast.zip" : No such file or 
directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images_crystal.zip" : No such file or directory
ctags: Warning: cannot open source file 
"test/user-template/user/config/images.zip" : No such file or directory
24318 files, 7714976 lines (277015 kB) scanned in 16.6 seconds (16657 kB/s)
1342729 tags added to tag file
1342729 tags sorted in 0.04 seconds
make[1]: Leaving directory `/home/vmiklos/git/libreoffice/master'

real0m46.334s
user0m34.258s
sys 0m4.429s


pgpPR8a4p6iLN.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 Beta1 test builds available

[Petr Mladek]

Pedro Lino píše v St 14. 12. 2011 v 10:24 +:
> Hi
> 
> > 7362ca8-b5a8e65-af86909-d471f98-61464c4 *is* Beta1, this is the way we
> > can identify it, now it is documented in mail archives, so... :)
> 
> :) Fair enough :)
> 
> I'm glad Petr is on it. I hope he doesn't give up that easily ;)

Yup, I tried it and the easy way failed. I already have another
implementation in mind. Unfortunately, I am snowed under other problems.
Anyway, I hope that I will solve it for beta2.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.4.99.1 tag created (3.5.0-beta1)

[Miklos Vajna]

On Tue, Dec 13, 2011 at 06:12:33PM +0100, Andreas Radke  
wrote:
> Are you sure the new tarballs are fixed? I've tried the new .xz ones and
> I'm still getting the same error.

I tried to build these:

$ sha1sum *.bz2
b116c7dade3d0fb9bf73362e728dbb1b04068acb  libreoffice-binfilter-3.4.99.1.tar.bz2
6534c81c0fd86813735896cd92b738a60d27323f  libreoffice-core-3.4.99.1.tar.bz2
b5efc018319d630b776be8427b601473d15c7559  libreoffice-help-3.4.99.1.tar.bz2
e38d3d47f0a33b540f1b962ce8f1dc9ec8d84f14  
libreoffice-translations-3.4.99.1.tar.bz2

It succeeded without any problems.

Build script at
http://ftp.frugalware.org/pub/other/people/vmiklos/lotesting/source/xapps/libreoffice/FrugalBuild,
in case that would help you.


pgpFn5se2VYWQ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5

[Pedro Lino]

> LO stores information about a selected JRE in the user profile at
> config/javasettings_*.xml.  Can you verify that just deleting that file from
> the bad old user profile would already be enough to solve the crash?

Yes, I can confirm that. I made some extensive testing.

This problem occurs if the user uninstalls or downgrades the Java
version (i.e. from 7 to 6)

This happens because under Windows the absolute path to Java is stored
in file javasettings_Windows_x86.xml located in
%AppData%\LOdev\3\user\config

E.g. file:///C:/Program%20Files/Java/jre6

If LO would delete the xml file when it fails to find JRE at the
specified location and started a new search (as it does currently on
every run if Java is enabled) then the problem would be solved: if no
Java is installed, LO would ask to install; if another version is
installed LO would find it ;)

HTH,
Pedro
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Git pull problems

[Alex Thurgood]

Le 14/12/2011 11:18, Bjoern Michaelsen a écrit :

Hi Bjoern,


The tree object c29667cde3f151a73d7302757a6eca316b886aa3 exists here, but not
the commit 28b86ca7b704d2789cad69f7516203434202c082. If that commit isnt too old
(git show 28b86ca7b704d2789cad69f7516203434202c082 should tell you):

  git reset --hard 28b86ca7b704d2789cad69f7516203434202c082^
  git pull

should help you as it get rid of this (nonexistant) commit.



Unfortunately not :
git reset --hard 28b86ca7b704d2789cad69f7516203434202c082
fatal: unable to read tree 28b86ca7b704d2789cad69f7516203434202c082

:-/

Think I'll just reclone.

Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 Beta1 test builds available

[Pedro Lino]

Hi

> 7362ca8-b5a8e65-af86909-d471f98-61464c4 *is* Beta1, this is the way we
> can identify it, now it is documented in mail archives, so... :)

:) Fair enough :)

I'm glad Petr is on it. I hope he doesn't give up that easily ;)

--
Pedro
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Git pull problems

[Bjoern Michaelsen]

On Wed, Dec 14, 2011 at 10:19:58AM +0100, Alex Thurgood wrote:
> git pull && ./g pull
> error: Unable to find c29667cde3f151a73d7302757a6eca316b886aa3 under
> http://anongit.freedesktop.org/git/libreoffice/core.git
> Cannot obtain needed tree c29667cde3f151a73d7302757a6eca316b886aa3
> while processing commit 28b86ca7b704d2789cad69f7516203434202c082.
> error: Fetch failed.

The tree object c29667cde3f151a73d7302757a6eca316b886aa3 exists here, but not
the commit 28b86ca7b704d2789cad69f7516203434202c082. If that commit isnt too old
(git show 28b86ca7b704d2789cad69f7516203434202c082 should tell you):

 git reset --hard 28b86ca7b704d2789cad69f7516203434202c082^
 git pull

should help you as it get rid of this (nonexistant) commit.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 Beta1 test builds available

[Andras Timar]

Hi,

2011/12/14 Pedro :
> I would like to request again that the Devs would consider adding the text
> Beta1 in the About box.
>
> E.g. LOdev 3.5.0 Beta1
>
> There is no way to correlate Build ID:
> 7362ca8-b5a8e65-af86909-d471f98-61464c4 with Beta1
>
> Can we try to cooperate as a Community?
>

Petr tried to solve this problem, see:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=fec8058db415db791c51d4a81435cf1f93b304e7
But it caused problems with the MAC build, so he had to revert it:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=9b5e6c1b2f7742f34f26881a104b07d092541142

7362ca8-b5a8e65-af86909-d471f98-61464c4 *is* Beta1, this is the way we
can identify it, now it is documented in mail archives, so... :)

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Git pull problems

[Alex Thurgood]

Le 14/12/2011 10:47, Michael Meeks a écrit :




git tag -f here # backup tag in case we loose something
git reset --hard HEAD~50
git pull -r

That winds back 50 commits and then re-pulls; of course if you have any
commits of your own, you'll now need to do 'gitk here' and cherry pick
them across.



Tried HEAD~50, 70 and even 100, with a subsequent .g pull -r each time, 
but am still getting same error - oh dear.


Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Git pull problems

[Alex Thurgood]

Le 14/12/2011 10:47, Michael Meeks a écrit :

Hi Michael,



So - this could happen in quite a few ways; most probably if you
committed something locally, then used git format-patch -1  to send it
off - and then someone else tweaked your patch before applying.

I tend to use ./g pull -r # for rebase - that would perhaps try to
re-base your work on top of master&  might unwind the conflict for you.

Failing that; winding back your master can help:

git tag -f here # backup tag in case we loose something
git reset --hard HEAD~50
git pull -r

That winds back 50 commits and then re-pulls; of course if you have any
commits of your own, you'll now need to do 'gitk here' and cherry pick
them across.




Thanks, will try it out. I'm not too worried about any local commits I 
might have made, they were minor edits to Base help files, and I can 
always do them again.



Alex



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Git pull problems

[Michael Meeks]

Hi Alex,

On Wed, 2011-12-14 at 10:19 +0100, Alex Thurgood wrote:
> Not being very conversant with git, I'm seeing the following problem on 
> my Linux box and don't know how to sort it out :

Ah  - fun :-)

> git pull && ./g pull
> error: Unable to find c29667cde3f151a73d7302757a6eca316b886aa3 under 
> http://anongit.freedesktop.org/git/libreoffice/core.git
> Cannot obtain needed tree c29667cde3f151a73d7302757a6eca316b886aa3
> while processing commit 28b86ca7b704d2789cad69f7516203434202c082.
> error: Fetch failed.

So - this could happen in quite a few ways; most probably if you
committed something locally, then used git format-patch -1  to send it
off - and then someone else tweaked your patch before applying.

I tend to use ./g pull -r # for rebase - that would perhaps try to
re-base your work on top of master & might unwind the conflict for you.

Failing that; winding back your master can help:

git tag -f here # backup tag in case we loose something
git reset --hard HEAD~50
git pull -r

That winds back 50 commits and then re-pulls; of course if you have any
commits of your own, you'll now need to do 'gitk here' and cherry pick
them across.

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Compile Error LibreOffice 3.5

[Michael Meeks]

Hi Joel,

On Tue, 2011-12-13 at 15:43 -0800, Joel Madero wrote:
> Trying to compile newest release of libreoffice and coming up with
> errors, here's a pastebin:
> 
> http://pastebin.com/xbk1xGLP

You do come up with the most amazing problems :-)

unix/runargv.c: In function ‘dmwaitnext’:
unix/runargv.c:275: error: ‘ECHILD’ undeclared (first use in this
function)
unix/runargv.c:275: error: (Each undeclared identifier is reported only
once
unix/runargv.c:275: error: for each function it appears in.)
unix/runargv.c: In function ‘dmwaitpid’:
unix/runargv.c:376: error: ‘ECHILD’ undeclared (first use in this
function)

Having the full details of your system; what version of what system is
it that you're running ? would really help here.

Does adding  an #include  to the top of that file help ?
how about an #include  ?

Do you have a file:

/usr/include/asm-generic/errno-base.h

That includes an ECHILD definition ?

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Git pull problems

[Alex Thurgood]

Hi all,

Not being very conversant with git, I'm seeing the following problem on 
my Linux box and don't know how to sort it out :


git pull && ./g pull
error: Unable to find c29667cde3f151a73d7302757a6eca316b886aa3 under 
http://anongit.freedesktop.org/git/libreoffice/core.git

Cannot obtain needed tree c29667cde3f151a73d7302757a6eca316b886aa3
while processing commit 28b86ca7b704d2789cad69f7516203434202c082.
error: Fetch failed.


I've tried a hard reset, but that doesn't seem to make any difference.

Pointers ??

TIA,

Alex

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] weird code, please advise...

[Stephan Bergmann]

On 12/13/2011 07:09 PM, Michael Meeks wrote:

On Tue, 2011-12-13 at 16:02 -0200, Olivier Hallot wrote:

I am stumbling on the following piece of code

 if (nodepath.getLength() != 0 || !(value>>= nodepath) || 
nodepath.getLength() == 0)

...

in configmgr/source/configurationprovider.cxx:204,
and nodepath is an rtl::OUString

is this TRUE always, or did I missed something?


What you're missing is this mid-mashing operator overloading; whereby
>>= actually assigns a string to nodepath ;-) so what it says to me is:
if the length>  0 and we successfully assign it to something else from
'value' and the result is non zero - then don't fail ;-)


Yeah, what it checks is that neither is nodepath already non-empty 
(i.e., multiple "nodepath" arguments passed in), nor does extracting the 
nodepath string from the value Any fail, nor is the passed in "nodepath" 
argument string empty (which is necessary to test here in order to be 
able to (mis-)use an empty nodepath string as a flag whether a 
"nodepath" argument has already been processed).


Pretty dense code, I admit.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] Java 7 support in LO 3.4.5

[Stephan Bergmann]

On 12/13/2011 04:59 PM, Pedro wrote:

3) Following the same logic, deleted the LOdev profile and now 3.5.0 also
shows the same nice "JRE needed" message when executing the Letter Wizard
instead of crashing. Similarly, when I re-enabled the extensions mentioned
on 1) LO shows the nice "JRE needed" message, instead of crashing. There is
definitely some problem with whatever is on the profile...


LO stores information about a selected JRE in the user profile at 
config/javasettings_*.xml.  Can you verify that just deleting that file 
from the bad old user profile would already be enough to solve the crash?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice