date:20120105

Hi Michael,

Michael Stahl  writes:
> thanks for these patches, i've pushed
> 0001-fix-broken-ifndef-define-guard-in-idl.patch,
> 0002-fix-package-in-idl.patch, 0005-chmod-x-on-java-files.patch.

great!

> 0003-idl-fix-package-names.patch seems to be wrong, as discussed in the
> other mail (and i've fixed the duplicate include guard instead), and

Thank you, I didn't notice the include guard bug.

> 0006-follow-idl-definition.patch/0007-JavaLoader-actually-implements-XImplementationLoader.patch
> were NACKed by Stephan due to backward compatibility.

OK.

> btw, next time please add [PATCH] to the subject so these are more
> visible to devs :)

I will.

Best Regards,

Tomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes

Hi Michael,

Michael Meeks  writes:
>   Thanks ! - I pushed it to master; it also seems to be in the 3.5
> branch, so hopefully it should be there too for you in the release :-)

Thank you!

Tomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes

Hi Stephan,

Stephan Bergmann  writes:
> On 01/05/2012 09:38 AM, Tomas Hlavaty wrote:
>> Stephan Bergmann  writes:
>>> On 01/04/2012 11:09 PM, Tomas Hlavaty wrote:
>>>
 diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl
>
> What exactly is broken?

as Michael Stahl noticed and fixed, the include guard copy&paste.

>> Any idea why XInterface is not used in all cases?  Has it something
>> to do with the fact that reference counting happens behind the scene
>> in Java?
>
> No, just some (somewhat bad) design decision early on in the life of UNO.

OK, thank you for your feedback!

Regards,

Tomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-05 Thread Stephan Bergmann


On 01/04/2012 03:30 PM, Stephan Bergmann wrote:

If there are no objections, I will commit this to master later this week.


Done, 
 
"Switch from autodoc to doxygen for SDK C++ documentation." 
Additionally filed easy hack 
 "Improve 
Doxygen-generated SDK C++ documentation."


I simply sticked to the --with-doxygen scheme for now.  Tinderbox 
maintainers, please remember to install doxygen if not yet present 
(preferred) or add --without-doxygen to autogen.lastrun (which will 
cause the C++ documentation to be missing from the SDK).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [libreoffice-l10n] Re: [Libreoffice-qa] Online update service up & running

2012-01-05 Thread Olivier Hallot

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Kendy

I think the scheme you listed will be OK. But I don't have a server to
test in an internal network

Regards
Olivier


Em 04-01-2012 17:52, Jan Holesovsky escreveu:
> Hi Olivier,
> 
> On 2012-01-03 at 14:01 -0200, Olivier Hallot wrote:
> 
>> Actually, in a controlled environment, you may want to download the new
>> version from a internal server, sparing your expensive external
>> bandwidth. That is why I would like to have the download URL
>> configureable in a XML file (e.g. main.xcd)
> 
> Ah, I see.  OK, so after getting rid of inst:buildid, I introduced an
> inst:gitid in the update .xml so that one can control the updates via a
> static .xml file.  The inst:buildid was unreliable, because of the way
> we reset buildid with every version bump (3.3 -> 3.4 etc.)
> 
> So, what you want to do is to put the new version to your server (let's
> say http://yourserver/newersion.msi) together with the following xml
> (located at http://yourserver/update.xml):
> 
> 
> http://update.libreoffice.org/description";>
>   LibreOffice 3.something
>   3.something
>   123456-abcdef-1a2b3c-4d5e6f
>   Windows
>   x86
> 
>src="http://yourserver/newersion.msi"; />
> 
> 
> where inst:gitid is the value of 'buildid' in program/versionrc of
> newersion.msi when installed.
> 
> The last step is to point your installations to this update xml, and
> that is by modifying UpdateURL to value http://yourserver/update.xml in
> program/versionrc of your installations.
> 
> Does this work for you?
> 
> inst:gitid will be available with Beta3, so the first update that will
> be possible to handle this way will be Beta3 -> Beta4.  Please test &
> report back in case of trouble.
> 
> Regards,
> Kendy
> 

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPBe4+AAoJEJp3R7nH3vLxeqcH/Rbd8cX9riyH18Uk/tNZIcYj
jf2iZnVV/piPviqcGAr6iaVYRzszltrd9n+HpSGuAJ9bf2fequD2XBTyEMZSfp6Q
JS+YlEvxUjU/EnKA9REtaIrzBp9VZENPu30iKaEeZWw5hpRfCQvJIk2EKO6/uv1w
ILb55O7tSSp0iJuE0/YOCVeR5QsC+BEypucdcBIHKjE+gzrrC5syTEiw3PbukW/g
Lfnv84hr76cR1QYqWABp8zb5RtGCeSO+sgE21lQC28RxEklzdstnYVcA2L36nlLV
MIHrjMHykawWt4ykqT2fNQJ5nMSb52IC0ibDXIGZaBN4XAND03301rTAOqGm8ZI=
=R+02
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] minutes of ESC call ...

* Present:
+ Norbert, Michael, Andras, Stephan, Tor, David,
  Rainer, Caolan, Michael S, Petr, Kendy, Thorsten,
  Kohei, Eike, Christian, Bjoern

* Completed Action Items
+ upgrade the internal cairo to latest stable to fix theme crasher 
(Fridrich)
+ side-effect: 
https://bugs.freedesktop.org/show_bug.cgi?id=44219
+ in-progress (Caolan, Michael)
+ setup linux build system to build gtk3 support by default (Michael)
+ blocks on upgrading internal glib
+ come up with a list of QA heros (Rainer)
+ punted - until we get bugzilla stats update.
+ get Rainer setup with git commit access (Michael)
+ not required
+ forward access details to Thorsten (Rainer)
+ have Silverstripe access

* Pending Action Items
+ add postgresql to 3.5 feature page (Lionel)
+ add tinderbox name to build-id (Norbert)
+ make it clear the SAL_INFO etc. macros are internal only for 3.5 
(Stephan)
+ [slow progress] extract 64bit build hardware from firewall (Kendy / 
Admins)
+ cleanup old test build server directories (Thorsten)
+ rename VCL API to make it GetBeamerFoo & fix (Michael)
+ get a permanant re-direction link for bug assistent (Thorsten)
+ hack up the Help->File bug menu item (Thorsten)
+ checking pg baseline on windows (Fridrich)

* Action Items review

* Release Engineering update (Petr)
+ 3.4.5 status
+ rc2 up-loaded, for a week of testing before announce
+ schedule is updated: http://wiki.documentfoundation.org/ReleasePlan
+ switch from exact dates to use week numbers, to allow some
  flexibility and better describe reality.
+ 3.4.6 added for March
+ 3.5.0 status
+ Hard English string & UI freeze is on Monday, January 9, 2012,
  see 
http://wiki.documentfoundation.org/ReleasePlan/3.5#3.5.0_release
+ Markus' external ref / feature
+ approved for merging consensus for -3-5 branch
+ includes the last(?) string changes.
+ plenty more bugs to fix - eg. from bug hunt.

* FOSDEM dev-room planning & arm twisting etc. (Michael)
+ Talks:
+ Internal structure of calc - Eike ...
+  - Stephan
+  - Michael
+ Bjoern (Skiiing) & Caolan figuring out travel planning

* Doxygen update ... (Bergmann)
+ we now depend on doxygen for SDK released builds
+ much rejoicing (Thorsten)
+ looking at switching to doxygen for IDL too
+ default to with doxygen, fail if don't find one & disable it.

* License discussion / planning / MPLv2 etc. (Michael)
+ https://mpl.mozilla.org/
+ punt movement here until 3.5.0 is out.

* QA update (Rainer)
+ Windows 8 - public beta for Feburary
+ Win 8 doesn't install in VMWare
- until it does debugging is hard.
+ crash-on-load bug #43648 - fun.
+ Jesus reports it working well though ...
+ Excel (originally Lotus) leap-year bug #44453
+ we simply don't do the broken version
+ known issue, affecting only 50 dates.
AA: + wontfix the bug in pleasant way (Thorsten)
+ bugzilla
+ getting slower, gateway timeouts, error 504
+ highly annoying
AA: + talk to freedesktop sysadmin team (Michael)
+ switch of old bugs to NEEDINFO
+ generated tons of mostly useless mail
+ another few hundred obsolete bugs getting activity
+ included invite to bug hunting session (Bjoern)
+ qa list was not on Nabble - now fixed (Bjoern)
AA: + qa list incomplete, or updating slowly on gmane (Thorsten to 
poke Florian)
+ bug hunting session update
+ lots more activity than normal days
+ did we manage to attract and retain new people ?
+ feeling is good
+ using 3.4.5rc and 3.5beta2 - normal work is possible
+ 3.5 still has some real blockers, but Rainer not
  seeing them in daily work.
+ very few crashes observed in the wild

* 3.5 most annoying bugs ...
+ 
https://bugs.freedesktop.org/showdependencytree.cgi?id=37361&hide_resolved=1
+ grab bugs they like the look of there.

* Mitch / MSI building update
+ not present.

* Robust subsequenttests to a third category: tail_build tests (Michael/Stephan)
+ idea - to include the reliable unit tests that
  we can run within the build
+ can run them in the tail_build
AA: + include them into tail_build Mak

Re: [Libreoffice] bug 36874 (label printing) further improvement?

Hi Winfried,

On Thu, 2012-01-05 at 11:23 +0100, Winfried Donkers wrote:
> -use this list
> for all comments/discussion etc.?
> I think it would be good to have the comments together (traceable).

I think, at this point - you touched the tar-baby and own the labels
topic :-) I'm impressed by your research.

So I'd just go on a wild fixing spree & make it all beautiful, and send
patches as you go - there is no real need for bugs, even if we want to
get the fixes into 3.5.x it is no problem not to have bugs, if the git
commit comment is verbose enough for a reviewer to be happy :-)

The less admin overhead you have to suffer as you cleanup the better
IMHO.

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] New technology generates power from nothing

2012-01-05 Thread Jolene


FREE ENERGY TIMES

Free Energy is real, but "powerful people" spend a lot of money covering this up
and suppressing new technologies, it is not a theory, it is a reality.
I have been looking for free energy technologies for a while now, there are 
many scams out there, but a few concepts stood out from the 
rest. I have verified and spoken to several witnesses to some of these 
technologies.
i have decided to help the world know the truth by spreading the word
about these very amazing devices. In the site below i have information on the 
working devices.

 "energy-is-free.com"  

I hope you take advantage of these and stop paying the OIL goons
 for energy you could receive for FREE.
,
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Cor Nouws


Stefan Knorr (Astron) wrote (05-01-12 17:19)

On 5 January 2012 16:11, Andras Timar  wrote:

2012/1/5 Tor Lillqvist:

Quickstart feature is installed by default but it is not run by default.


My opinion is that we should just kill the feature (code) completely;)


+1


Another +1. Especially since most modern OS's do the same thing (but
better and earlier). And LibO shouldn't occupy tray space, either.



- 0

People use it as quick-access too.
Should we maybe ask the users?

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem building the 3.5 branch on Windows, postgresql related.

2012-01-05 Thread Kohei Yoshida

Hi Kendy,

On Thu, Jan 5, 2012 at 5:14 AM, Jan Holesovsky  wrote:

> On 2012-01-05 at 02:28 -0500, Kohei Yoshida wrote:
>
>> I'm having trouble building the latest 3.5 branch on Windows.  First,
>> the postgresql module failed to build due to it not finding ldap.h
>> from mozilla.  I had mozilla entirely disabled (I always had).  So I
>> decided to enable it to see if it would solve this.  But because I
>> didn't want to build it from the sources, I simply stashed the
>> pre-built mozilla zips into moz/zipped.
>
> Did you explicitly enable the postgresql build?

Nope.

Or, are you using the
> LibreOfficeWin32 distro?

Yes.

I'm building just the default build, without
> any --with-distro switch, and that is pretty reliable.

Well, I thought using --with-distro=LibreOfficeWin32 was the
recommended way to build on Windows?  Perhaps things are different
now... :-/

Anyway, explicitly disabling postgresql via
--disable-ext-postgresql-sdbc helped in the end.  Now I can build even
with mozilla entirely disabled (as before).

Thanks for your help.

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012/1/5 Pedro :
>
> Andras Timar wrote
>>
>>> I can't guarantee that it is installed by default (I NEVER use the
>>> default install option on any software) but it is selected by default
>>> when I switch to Custom (and I always un-select it). Under Windows
>>> options already selected in Custom should be the same installed by
>>> using the Default option.
>>
>> Quickstart feature is installed by default but it is not run by default.
>>
>
> I just did a fresh Default install and I can confirm that under Windows XP
> x86. Since which version has this been the default behavior?

I think LibreOffice always did this (inherited from Go-OO).

>
> So, what is the point of having a Quick Starter installed? Under what
> scenario do users deliberately activate it?
>

See for example https://bugs.freedesktop.org/show_bug.cgi?id=35568#c5

> Which brings back to the OP. If quick starter wasn't loaded (I assume that
> someone who got a software installed by mistake didn't go to Options,
> Memory, etc and activated it deliberately) what prevented LO from being
> uninstalled?
>

Because there was a bug in LibreOffice installer, see
https://bugs.freedesktop.org/show_bug.cgi?id=36677

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] UNO Object Life Cycle question

2012-01-05 Thread Execute SARL


Le 05/01/2012 18:52, Tomas Hlavaty a écrit :

Hi all,

I'm implementing

and can't make much sense of it.  It seems to me that the spec is
contradictory:

   ...  unless it considers as bridged in any tuple, where t' is
   a subtype of t (including t itself).  If the same tuple appears
   multiple times in the data of a message, the corresponding reference
   count is incremented multiple times.

   ...

   The optimization rule (to not increment the reference count for
   when  itself or some subtype tuple  is considered as
   bridged in) is broken...

The last quoted paragraph:

   to not increment the reference count for  when  itself or
   some subtype tuple  is considered as bridged in

doesn't sound like reference counting.  If the client fetches XInterface
first, then the reference count can only ever be maximum 1.  It somehow
seems very dependent on what types the client fetches in what order.
Also this rule contradicts the sentense:

   If the same tuple appears multiple times in the data of a message, the
   corresponding reference count is incremented multiple times.

By the exceptional rule, the tuple's refcount should not be incremented.
Is the exceptional rule really meant to say "including t itself"?  Or
does the part "in the data of a message" make the exceptional rule
somehow invalid in the context of one message?

Is this spec still valid?

I implemented the algorithm according to my understanding of the above
spec reducing memory leaks by 1/2 but I still get many leaks.  If I'm
strict and ignore the broken optimization rule, I get LO crashing after
some time, likely because of double release.  I'm still missing
something to get refcounting exactly the way LO does it.

Why is the reference counting algorithm dependent on the casted type in
the first place?  Shouldn't the reference count be interesting only in
connection with oid and not?

UNO is a distributed protocol.  The links should be considered
unreliable.  Is there a mechanism that when a link between the server
and client bridge breaks, the server releases the resources properly, or
do we get/expect memory leaks?

My own experience with this protocol is with a Delphi client
http://www.execute-info.com/RemoteOfficeDemo.zip

with my tests, there's a release for each tuple like for this 
XInputStream after a LoadComponentFromURL('private:stream'...) :


releasing 
com.sun.star.io.XStream:26367c8;uno[0];e0c;a57318a2d6e42fbaa3badc46a60b671
releasing 
com.sun.star.io.XSeekable:26367c8;uno[0];e0c;a57318a2d6e42fbaa3badc46a60b671
releasing 
com.sun.star.io.XInputStream:26367c8;uno[0];e0c;a57318a2d6e42fbaa3badc46a60b671
releasing 
com.sun.star.uno.XInterface:26367c8;uno[0];e0c;a57318a2d6e42fbaa3badc46a60b671



I've notice that an unreleased objet persist after disconnection, if you 
start a new session with the same threadID the server raise an exception 
when you try to send a previously used OID. So I don't know when they 
are released.


And on an other hand, I don't know how you can reconnect to the same 
thread after a client crash ! AFAIK all the objects should be just 
droped down on disconnection, but they're not.


Paul TOTH

Also, it is not exactly clear at which point in time the release message
should be sent.  One such point in time could be when the client is
finished with the session.  At that point, the client needs to send at
least as many release messages as the number of all the incremented
refcounts it noticed according to this algorithm.  That is potentially
many messages, slowing down the session considerably.  Is there a way to
simply end the session and declare all references not used anymore in
one go/message without causing leaks in the server?

Thank you,

Tomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Stefan Knorr (Astron)

Hi,

On 5 January 2012 16:11, Andras Timar  wrote:
> 2012/1/5 Tor Lillqvist :
>>> Quickstart feature is installed by default but it is not run by default.
>>
>> My opinion is that we should just kill the feature (code) completely;)
>>
> +1

Another +1. Especially since most modern OS's do the same thing (but
better and earlier). And LibO shouldn't occupy tray space, either.

Astron
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Pedro


Andras Timar wrote
> 
>> I can't guarantee that it is installed by default (I NEVER use the
>> default install option on any software) but it is selected by default
>> when I switch to Custom (and I always un-select it). Under Windows
>> options already selected in Custom should be the same installed by
>> using the Default option.
> 
> Quickstart feature is installed by default but it is not run by default.
> 

I just did a fresh Default install and I can confirm that under Windows XP
x86. Since which version has this been the default behavior?

So, what is the point of having a Quick Starter installed? Under what
scenario do users deliberately activate it?

Which brings back to the OP. If quick starter wasn't loaded (I assume that
someone who got a software installed by mistake didn't go to Options,
Memory, etc and activated it deliberately) what prevented LO from being
uninstalled?

--
View this message in context: 
http://nabble.documentfoundation.org/Removing-LibO-on-Windows-tp3634487p3635370.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-ux-advise] [REVIEW 3-5: Late feature] Improvements in the header / footer behavior

2012-01-05 Thread Cedric Bosdonnat

Hi Kendy all,

On Thu, 2011-12-29 at 14:15 +0100, Jan Holesovsky wrote:
> I have been playing recently with the great new header / footer
> indicators, and there were 2 things that I considered suboptimal from
> the UX point of view:
> 
> - Appearing / disappearing of the controls after 1 second
> 
>   I noticed that most of the time when I am using that, I am terribly
>   impatient even if it is just 1 second, and end up clicking the
>   header / footer area hoping that it will appear earlier; similarly for
>   disappearing.  I played with that, and with the faster appearing /
>   disappearing implemented by Thomas Collerton, there is no need for the
>   1 second timeout it seems; so I got rid of that:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=64e08fd3c5980b74bb958dc566c229d92db18726
> 
> - Showing both the header and footer controls, while the user is able to
>   use just one of them at a time
> 
>   While it makes some sense from the implementation point of view to
>   keep the headers and footers close in the code, from the user point of
>   view I don't see why we should show both at the same time; the user is
>   able to edit either header, or footer, but never both at the same
>   time - she has only one caret ;-)  So I decoupled that:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cce76e658af88813e17dea4f04388a29d7e582df
> 
> Both this is in master.  I recall the headers / footers were implemented
> together with our UX guys, so I don't push it to libreoffice-3-5 as a
> normal fix, but rather use the 'late feature' track - with more review,
> hoping in consensus about this :-)  I believe the above mentioned
> changes make the use of the new feature even more slick and sexy.
> 
> So - can we agree to cherry-pick this to libreoffice-3-5 too? :-)

I'm all for it, but the following commits are fixing some side-effects
or UI weird things on this thread:


Show the page break tab under the mouse instead of the end of the line.
That fixes the UI problems mentioned in this thread.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5807b07161d84ef105cc1a2292c8c1f09888e39f
http://cgit.freedesktop.org/libreoffice/core/commit/?id=965e72d64c3e38780a69cace3f1bcc5fb35d6c1e
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a0fa723ed5761609d2c31061fdd0282a2f1df6e7
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a326395a48db313b907b4a35392216d7b2e2a11

Fixes for your commits:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fef489ad0f1f14bd9f018552c47a93a80e8b353d
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7d6bff10a85986e5e6ebfa961f29fa8b3815b40

Thanks for your reviews,

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH 1/2][PUSHED] Added missing includes.

2012-01-05 Thread Lubos Lunak

On Tuesday 03 of January 2012, Marcel Metz wrote:
> ---
>  binfilter/inc/bf_starmath/smmod.hxx |2 ++
>  binfilter/inc/bf_sw/shellres.hxx|2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)

 Pushed all patches.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH 1/5][PUSHED] Removed unnecessary tools includes.

2012-01-05 Thread Lubos Lunak

On Tuesday 03 of January 2012, Marcel Metz wrote:
> Hello lo-devs,
>
> this patch series removes a lot of unnecessary includes for the various
> tools header. The patches without suffix should be applied to the core
> repository, the .binfilter.patch suffix should be applied to the
> binfilter repository. I've tested the build with the configuration
> --enable-binfilter --enable-dbgutil --enable-debug, is this sufficient
> or did I miss another important configuration, that enables some
> conditional compiled code? I've only build this on linux-x86_64, but the
> patch also touches some of the mac specific code like
> fpicker/source/aqua/SalAquaFilePicker.mm so it would be maybe a good
> idea to test this patch.

 Compiled for me too, so let's say the only way to check for problems is by 
running into them :). Pushed all patches.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Michael Stahl

On 05/01/12 10:45, Caolán McNamara wrote:
> So https://bugs.freedesktop.org/show_bug.cgi?id=43867 is a most annoying
> bug with a crash on mailmerging documents that contain ole objects in
> headers. I'd like to get the following into 3-5.
> 
> Immediate crash is fixed by
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7dc25878c1310a1de6d3c87c88404b151bad21fc
> where we previously acquired/released the document around the insertion
> of content into it, but not around inserting styles, but page styles can
> contain headers/footers with arbitrary content, so if we need to acquire
> before inserting content, we need to acquire before inserting page
> styles.

sounds plausible

> object preview is still missing from headers though,
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef17be8b006737c078a59635ae334a03301727ea
> fixes a series of apparent errors
> 
> 1. FN_UNO_REPLACEMENT_GRAPHIC_URL and FN_UNO_GRAPHIC have the same id in
> writer, so "replacement graphic urls" fall into the same case statement
> as "replacement graphics", which they aren't.

d'oh

> These random ids are *so*
> fragile, we need something better here in general.

indeed mis-merges seem to be pretty common with these.

since for UNO stuff usually a string is mapped to one of these integers,
i wonder if we could get rid of the mapping and rely on something like
OUString;:intern or OUString::hashCode for dispatch...

> 2. The replacement graphic is set with...
> svt::EmbeddedObjectRef xObj = pOleNode->GetOLEObj().GetObject();
> xObj.SetGraphic( aGraphic, aMediaType );
> but the x of xObj and the name "EmbeddedObjectRef" are misleading, its
> not a reference class, so we're setting the replacement graphic onto a
> temporary copy of the object. EmbeddedObjectRef is a poor class name, we
> should change that.

ouch.

> 3. SvXMLGraphicHelper::ImplGetStreamNames doesn't know how to
> split ./ObjectReplacements/foo in order to find the preview but
> SvXMLEmbeddedObjectHelper::ImplGetStorageNames does, so factored out
> better splitter and shared it 
> 
> C.
> 

have pushed these to libreoffice-3-5

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012/1/5 Tor Lillqvist :
>> Quickstart feature is installed by default but it is not run by default.
>
> My opinion is that we should just kill the feature (code) completely;)
>
+1

Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Tor Lillqvist

> Quickstart feature is installed by default but it is not run by default.

My opinion is that we should just kill the feature (code) completely;)

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012/1/5 Pedro Lino :
> Hi Tor, all
>
>> and it's Pedro even!
>
> I'm almost sure this wasn't a compliment... Still I'm glad that I'm
> not the only one who has this opinion :)
>
> I can't guarantee that it is installed by default (I NEVER use the
> default install option on any software) but it is selected by default
> when I switch to Custom (and I always un-select it). Under Windows
> options already selected in Custom should be the same installed by
> using the Default option.

Quickstart feature is installed by default but it is not run by default.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] UNO Object Life Cycle question

Hi all,

I'm implementing

and can't make much sense of it.  It seems to me that the spec is
contradictory:

  ...  unless it considers as bridged in any tuple , where t' is
  a subtype of t (including t itself).  If the same tuple appears
  multiple times in the data of a message, the corresponding reference
  count is incremented multiple times.

  ...

  The optimization rule (to not increment the reference count for 
  when  itself or some subtype tuple  is considered as
  bridged in) is broken...

The last quoted paragraph:

  to not increment the reference count for  when  itself or
  some subtype tuple  is considered as bridged in

doesn't sound like reference counting.  If the client fetches XInterface
first, then the reference count can only ever be maximum 1.  It somehow
seems very dependent on what types the client fetches in what order.
Also this rule contradicts the sentense:

  If the same tuple appears multiple times in the data of a message, the
  corresponding reference count is incremented multiple times.

By the exceptional rule, the tuple's refcount should not be incremented.
Is the exceptional rule really meant to say "including t itself"?  Or
does the part "in the data of a message" make the exceptional rule
somehow invalid in the context of one message?

Is this spec still valid?

I implemented the algorithm according to my understanding of the above
spec reducing memory leaks by 1/2 but I still get many leaks.  If I'm
strict and ignore the broken optimization rule, I get LO crashing after
some time, likely because of double release.  I'm still missing
something to get refcounting exactly the way LO does it.

Why is the reference counting algorithm dependent on the casted type in
the first place?  Shouldn't the reference count be interesting only in
connection with oid and not ?

UNO is a distributed protocol.  The links should be considered
unreliable.  Is there a mechanism that when a link between the server
and client bridge breaks, the server releases the resources properly, or
do we get/expect memory leaks?

Also, it is not exactly clear at which point in time the release message
should be sent.  One such point in time could be when the client is
finished with the session.  At that point, the client needs to send at
least as many release messages as the number of all the incremented
refcounts it noticed according to this algorithm.  That is potentially
many messages, slowing down the session considerably.  Is there a way to
simply end the session and declare all references not used anymore in
one go/message without causing leaks in the server?

Thank you,

Tomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Pedro Lino

Hi Tor, all

> and it's Pedro even!

I'm almost sure this wasn't a compliment... Still I'm glad that I'm
not the only one who has this opinion :)

I can't guarantee that it is installed by default (I NEVER use the
default install option on any software) but it is selected by default
when I switch to Custom (and I always un-select it). Under Windows
options already selected in Custom should be the same installed by
using the Default option.

--
Pedro
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Caolán McNamara

On Thu, 2012-01-05 at 16:25 +0200, Tor Lillqvist wrote:
> > IMO this doesn't make any sense: if your PC is low spec you don't _want_
> > this; if your PC is high spec you don't _need_ this
> 
> I can't believe it. Finally somebody who agrees with me on this (and I
> am not being ironic), and it's Pedro even!
> 
> This is a good start of the year.

I thought we *had* disabled it by default for new installs. In which
case the issue is dealing with older versions (or upgrades from) which
defaulted it on.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Tor Lillqvist

> IMO this doesn't make any sense: if your PC is low spec you don't _want_
> this; if your PC is high spec you don't _need_ this

I can't believe it. Finally somebody who agrees with me on this (and I
am not being ironic), and it's Pedro even!

This is a good start of the year.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH][PUSHED] Fix for fdo43460 Part XXII getLength() to isEmpty()

2012-01-05 Thread Lubos Lunak

On Wednesday 04 of January 2012, Gustavo Pacheco wrote:
>   Hi!
>
>   Partial fix for Easy Hack FDO43460 (part XXII) for review.
>
>   Part XXII
>   modules
>   jvmfwk, l10ntools, lingucomponent

 Pushed, thanks.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Pedro


Michael Meeks-2 wrote
> 
>   I was wondering if (just before the string freeze) we could try to
> improve this string / message to make it much more verbose and helpful.
> Preferably to include some text about the 'system tray' or the
> "Tools->Options->Memory->Enable systray quick-starter" item.
> 

Maybe this project should consider if it makes any sense to have a
"quick-starter" loaded any way...

This is a Default option which needlessly (and without asking the user)
loads a heavy module at startup.

IMO this doesn't make any sense: if your PC is low spec you don't _want_
this; if your PC is high spec you don't _need_ this

This was a marketing stunt to show how fast MS Office loaded on "first use"
Obviously your PC would take longer to start (but they never mentioned that
;) )

Even Microsoft has stopped loading the Office Startup
Application...

Unless there is some other logical reason for using this, IMO LO should get
rid of it.

--
View this message in context: 
http://nabble.documentfoundation.org/Removing-LibO-on-Windows-tp3634487p3634899.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] bug 36874 (label printing) further improvement?

2012-01-05 Thread Petr Mladek

Winfried Donkers píše v Čt 05. 01. 2012 v 11:23 +0100:
> Of the 1789 label definitions (including cards), 1418 are symmetrical
>  and of standard paper size (A4, A5 or Letter). The remaining 371 have
>  either unusual/incorrect dimensions or are not symmetrical. This
>  encourages me to continue with the enhancement of including pper size
>  in the labels.xcu file.

Makes sense.

> A question therefore:
> What is best:
> -to create a new bug (with reference to 36874)

This is the best solution if you want to store the most important
comments on single page. The bug 36874 already is too long, so I suggest
to leave it closed. It did his job and fixed 80% of labels...

Alternatively, you might create wiki page for this "feature" and
describe the status and solution there.

> -use this list

This is the best place if you get into troubles with implementation and
need hints from other developers.

If you want to discuss the UI design, you might want to add
libreoffice-ux-adv...@lists.freedesktop.org into CC.

> for all comments/discussion etc.?
> I think it would be good to have the comments together (traceable).

IMHO, it is nice to have but it is not worth to spend too much time with
it. If the solution is good, it will stay as is. If there are problems,
they will get solved as they come. Your proposal is definitely an
improvement and most people will like it.


> And another question: many labeldefinitions in labels.xcu have German
>  descriptions (e.g. from manufacturer Herma). Should these be
>  translated to English? :(

Yup, it makes sense. You might ask on l...@global.libreoffice.org
mailing list for help with translations.

Thanks a lot for working on it.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Noel Grandin

In my experience, good uninstallers check if the application is currently 
running, and refuse to complete the
uninstallation process until the user has exited the program.
Something like:
"A LibreOffice application is still running. Please save and exit before 
continuing".
And then grey out the "Next" button.

For bonus points, the uninstaller should automatically continue without needing 
to be prompted when the user has exited
the running LibreOffice application.

Stefan Knorr (Astron) wrote:
> Hi all,
>
>
>>> Well, should be pretty easy to create a pre_uninstall event that kills
>>> the process before it is removed. Is there any historical reason for
>>> not doing it this way?
>> That would be rude. Users may have unsaved data, etc.
> Can't we ask users if they really want to kill the application before
> we go and kill it?
>
> (something like
> Title: "LibreOffice is currently active."
> Message: "As long as LibreOffice is active, it can not be removed. Do
> you want to close LibreOffice now?
> Warning: you will lose any document you are currently working with in
> LibreOffice.")
>
> And, really we should detect if only the quick starter is active (no
> open files) and if that's the case why not just kill it?
>
> Astron.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>

Disclaimer: http://www.peralex.com/disclaimer.html

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Stefan Knorr (Astron)

Hi all,


>> Well, should be pretty easy to create a pre_uninstall event that kills
>> the process before it is removed. Is there any historical reason for
>> not doing it this way?
>
> That would be rude. Users may have unsaved data, etc.

Can't we ask users if they really want to kill the application before
we go and kill it?

(something like
Title: "LibreOffice is currently active."
Message: "As long as LibreOffice is active, it can not be removed. Do
you want to close LibreOffice now?
Warning: you will lose any document you are currently working with in
LibreOffice.")

And, really we should detect if only the quick starter is active (no
open files) and if that's the case why not just kill it?

Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] merging libraries: problem with multiple definitions

2012-01-05 Thread Matúš Kukan

On 4 January 2012 15:26, Michael Meeks  wrote:
>        So - I think here we just add a 'static' keyword in front of those
> (clearly module local) variables.

done with 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f2355014375adb66dd8e986068abc8429e0ad0d

>        Does that make some sort of sense ? Really excited to have you working
> on this - there should be a lot of scope for improvement from graunching
> all of that together and LTO'ing it :-)

Well, it makes some sense but I'm not really working on this, just
making easy, small changes.
It would be great if somebody could do it, otherwise I will do it at
some unspecified point later.

For now I just won't try to merge sfx and sb, fwe, fwi and fwk because
of sfx, so there is no more problem.
I will push as soon as extensions are in tail_build.

Best,

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes

2012-01-05 Thread Michael Stahl

On 04/01/12 23:09, Tomas Hlavaty wrote:
> Also, I attach a few more patches.

thanks for these patches, i've pushed
0001-fix-broken-ifndef-define-guard-in-idl.patch,
0002-fix-package-in-idl.patch, 0005-chmod-x-on-java-files.patch.

0003-idl-fix-package-names.patch seems to be wrong, as discussed in the
other mail (and i've fixed the duplicate include guard instead), and
0006-follow-idl-definition.patch/0007-JavaLoader-actually-implements-XImplementationLoader.patch
were NACKed by Stephan due to backward compatibility.

btw, next time please add [PATCH] to the subject so these are more
visible to devs :)

regards,
 michael

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Michael Stahl

On 05/01/12 09:38, Tomas Hlavaty wrote:
> Hi Stephan,
> 
> Stephan Bergmann  writes:
> 
>> On 01/04/2012 11:09 PM, Tomas Hlavaty wrote:
>>
>>> diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl
>>> b/offapi/com/sun/star/chart/XAxisSupplier.idl
>>> ...
>>
>> Are you sure that this is right, using chart2 entities from within
>> chart?  I always intuitively thought that chart2 was a second attempt,
>> to replace chart.
> 
> I am not sure as I don't know what chart and chart2 are about but
> currently this is broken.  The patch fixes the compilation issue.  Maybe
> I should move the file to chart2 package instead?

argh... that would not work, because there is already a chart2::XAxis.
in addition to chart::XAxis.  actually the chart::XAxis is newer than
chart2::XAxis: it was added for OOo 3.4, in commit
0c1fb57fe1588ba0d2ed07145fd07e834c96623f

the implementation of this is in
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx, and it uses
chart::XAxis.

by now i'm now pretty confused, but i think the proposed patch is wrong.

ah, your trouble could be caused by chart/XAxis.idl and chart2/XAxis.idl
having the same include guard, i'll try to fix that...

grmbl, what a mess...

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] bug 36874 (label printing) further improvement?

2012-01-05 Thread Bjoern Michaelsen

Hi,

On Thu, Jan 05, 2012 at 11:23:44AM +0100, Winfried Donkers wrote:
> What is best:
> -to use bug 36874 (state resolved fixed) for this thread
> -to create a new bug (with reference to 36874)
> -use this list
> for all comments/discussion etc.?
> I think it would be good to have the comments together (traceable).

thats a matter of taste mostly. Here is what I would do:
- change the title of 36874 to include only what was fixed
- make a new bug for the stuff that still needs to be improved
- make the new bug depend on 36874

That way:
- you dont get one huge bug in which one gets lost in the comments
- you can still see both bugs to be closely related and the comments
  from the other one are easy to find

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes

Hi Tomas,

On Wed, 2012-01-04 at 23:09 +0100, Tomas Hlavaty wrote:
> sorry for inconvenience, I have sent the License statement email to the
> mailing list so please feel free to reapply the patch.

Thanks ! - I pushed it to master; it also seems to be in the 3.5
branch, so hopefully it should be there too for you in the release :-)

All the best,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #76 from sasha.libreoff...@gmail.com 2012-01-05 03:47:38 PST ---
Please, verify Bug 44492 - in Arabian text blank squares instead of letters
it my be regression if confirmed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] ooo_custom_images to icon-themes, was: Re: Do we support classic and industrial theme?

2012-01-05 Thread Stefan Knorr (Astron)

Hi,

On 4 January 2012 17:39, Michael Meeks  wrote:
>        Great; so - moving default_images into there and making it 'galaxy'
> would be a nice cleanup I guess; then again it may need quite some
> tweaking of scripts that hard-code it's path I suppose; particularly
> (IIRC) 'rsc' checks to make sure that the icons actually exist in there
> and would need a path.

Hm, yeah, I would like to move this to icon-themes/galaxy, but
replacing all occurrences of the string "default_images" that came up
with git grep didn't lead to something buildable, which stopped me
from implementing the idea for now, but I hope to get back to it
later. It also fails during tail_build with something rather
non-descriptive if I remember correctly.

Interestingly, there seem to be no occurrences in rsc/, instead the
ones I found are

chart2/source/controller/dialogs/dlg_DataEditor.hrc://the numbers correspond to
desktop/Zip_brand_dev.mk:$(eval $(call gb_Zip_Zip,brand_dev/intro,$(SRCDIR)/defa
desktop/Zip_shell.mk:$(eval $(call gb_Zip_Zip,shell,$(SRCDIR)/default_images/bra
desktop/branding/Makefile:ABOUT_BITMAP := $(SRCDIR)/default_images/brand/about.p
desktop/branding/Makefile:INTRO_BITMAP := $(SRCDIR)/default_images/brand/intro.p
icon-themes/industrial/TODO:for file in `cat ../../missing`; do foo=`md5sum
reportbuilder/registry/data/org/openoffice/Office/UI/ReportCommands.xcu:
sc/source/ui/src/toolbox.src:// folder in default_images. This list is now only
set_soenv.in:$DEFIMGS  = $ds."default_images";
solenv/doc/gbuild/solenv/gbuild/alllangres.mk:/// Sets the location
solenv/doc/gbuild/solenv/gbuild/alllangres.mk:/// below default_imag
solenv/gbuild/AllLangResTarget.mk:gb_ResTarget_DEFIMAGESLOCATION := $(realpath $
solenv/gbuild/templates/AllLangResTarget.mk:# declaration of images folder (e.g.
solenv/inc/settings.mk:RSCDEFIMG*=default_images
sw/source/ui/app/app.src: // folder in default_images. This list is now only use

So, the real meat seems to be in solenv. I assume that either
a. default_images and custom_images need to lie in different base
folders and thus something tries to pack the Galaxy icon theme twice
(once as the default, once as a custom set) which goes wrong
b. there's a ../ too few or too many somewhere

Regards,

Astron.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Pushed] [Patch] [Review 3.5 - Late Feature] Importing smartArt from

2012-01-05 Thread Muthu Subramanian K

Marking this pushed:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=b9977b7a23ba4d9fc739133b6aa199f5d6cdec35

Thank you all.

On 01/05/2012 12:37 PM, Muthu Subramanian K wrote:
> Thank you so much!
> So, I assume we have 3 reviews for this.
> I will push this to 3.5 today, if there are no objections by then.
> 
> Thanks again for the reviews!
> Muthu Subramanian
> 
> On 01/05/2012 02:29 AM, Miklos Vajna wrote:
>> On Wed, Jan 04, 2012 at 04:24:22PM +0100, Jan Holesovsky  
>> wrote:
One more review needed, I'd love to get Thorsten's input of course.
>>>
>>> For the late feature - the ideal would be cross-affiliation, if
>>> possible :-)  So if anybody non-SUSE can have a look, it would be great
>>> - Caolan?  Miklos?  Ivan?  Anybody else?
>>>
>>> As explained earlier, this makes many non-working pptx presentations
>>> suddenly working; and we will see even more over the lifetime of 3.5.
>>> The patch itself is really short & self-contained, so I think no real
>>> Impress or PPTX knowledge is necessary for the approval.  And we will
>>> still have enough time to revert it in case of trouble if it gets into
>>> Beta3.
>>
>> Hi Kendy,
>>
>> Sure, from a user's perspective, I agree to have it in 3.5, it can't
>> make the situation worse. ;-)
>>
>> Miklos
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012/1/5 Jesús Corrius :
>>        I was wondering if (just before the string freeze) we could try to
>> improve this string / message to make it much more verbose and helpful.
>> Preferably to include some text about the 'system tray' or the
>> "Tools->Options->Memory->Enable systray quick-starter" item.
>>
>>        It would presumably save people a fair bit of time.
>>
>>        Or - was this message shown in error Andras ? perhaps the issue is 
>> gone
>> with your re-work here ...
>
> Well, should be pretty easy to create a pre_uninstall event that kills
> the process before it is removed. Is there any historical reason for
> not doing it this way?

That would be rude. Users may have unsaved data, etc. FYI this is the
commit that Michael mentioned. I *think* that it solves this type of
uninstall problems.

http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4&id=2408d229104c3e198ce79e72bb89ce360575aa36

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012/1/5 Michael Meeks :
>
>        Or - was this message shown in error Andras ? perhaps the issue is gone
> with your re-work here ...

I bet it's gone. The bug occured with Windows 7 and LibreOffice 3.4.4
or earlier.

Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Removing LibO on Windows ...

2012-01-05 Thread Jesús Corrius

>        I was wondering if (just before the string freeze) we could try to
> improve this string / message to make it much more verbose and helpful.
> Preferably to include some text about the 'system tray' or the
> "Tools->Options->Memory->Enable systray quick-starter" item.
>
>        It would presumably save people a fair bit of time.
>
>        Or - was this message shown in error Andras ? perhaps the issue is gone
> with your re-work here ...

Well, should be pretty easy to create a pre_uninstall event that kills
the process before it is removed. Is there any historical reason for
not doing it this way?

-- 
Jesús Corrius 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Replace ByteString with rtl::OString

2012-01-05 Thread Caolán McNamara

On Wed, 2012-01-04 at 23:06 +0100, Chr. Rossmanith wrote:
> I've finished genprnpsp.cxx and had to touch some related files as well 
> (but didn't finish them yet). After a review and removing some 
> unnecessary rtl:: prefices I'd like to push this modified patch.

Watch out for String::Copy, i.e. String::Copy(8) is copy from pos 8 to
end of string, that can be converted directed to OUString::copy(8)

Fixed that up and pushed, thanks for these.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Removing LibO on Windows ...

Hi guys,

Judging from the amount of private mail our fall-back list:

To: i...@documentfoundation.org
Subject: Delete Your Program

gets on this same topic ;-) [ prolly it is the #1 FAQ we have ],
perhaps one every week or so, typically from our more basic user:

[snip]
Dear Sirs:
I don't quite know how your program got on to my computer, and I have no
need for your sevices.  However when attempting to remove it from my
system, it states that it is running and must first be closed.

There seems to be no way to close it.  Would you please help in this
endeavor.
Thank you ...
[/snip]

I was wondering if (just before the string freeze) we could try to
improve this string / message to make it much more verbose and helpful.
Preferably to include some text about the 'system tray' or the
"Tools->Options->Memory->Enable systray quick-starter" item.

It would presumably save people a fair bit of time.

Or - was this message shown in error Andras ? perhaps the issue is gone
with your re-work here ...

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Updating Italian dictionaries

2012-01-05 Thread Andrea Pescetti


On 05/01/2012 Andras Timar wrote:

Why would you like to pack and distribute files from the legacy
folder? Those look useless to end users.


Because they allow to see who contributed what and when. They are indeed 
of little interest for end users (and the contributors' names, just the 
names, are of course already listed in the README files), but it was a 
specific request I received from previous contributors and it would be 
fair to them to respect their wishes.


Also, this allows to build a complete genealogy of the project, which is 
better now that we have to maintain it in multiple repositories.


Regards,
  Andrea.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

https://bugs.freedesktop.org/show_bug.cgi?id=41883

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||44489

--- Comment #11 from Rainer Bielefeld  
2012-01-05 03:07:23 PST ---
Nominate "Bug 44489 - MinGW: Will not launch". That's annoying because MinGW is
the only possibility to get current WIN master Builds

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Updating Italian dictionaries

Hi Andrea,

2012/1/3 Andrea Pescetti :

> Of course for the next update (not before LibreOffice 3.5) we will have a
> dedicated public repository for the Italian dictionary and possibly standard
> non-binary patches. I apologize for the slightly larger work committers will
> need this time.
>
Why would you like to pack and distribute files from the legacy
folder? Those look useless to end users.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Petr Mladek  changed:

   What|Removed |Added

 Depends on||44147

--- Comment #75 from Petr Mladek  2012-01-05 02:43:18 PST ---
Nominate 44147: unable to edit embeded Calc table in Writer

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] bug 36874 (label printing) further improvement?

2012-01-05 Thread Winfried Donkers

>>some labels paper that I bought last year were not symmetric
>I found that too when I started to extend the label defintions (1700+ ...) in 
>labels.xcu with paper height and paper width. 
>And also that by rounding off the calculated paper size can differ +/- 2mm 
>from the actual size, especially when the labels >are small.

Of the 1789 label definitions (including cards), 1418 are symmetrical and of 
standard paper size (A4, A5 or Letter). The remaining 371 have either 
unusual/incorrect dimensions or are not symmetrical. This encourages me to 
continue with the enhancement of including pper size in the labels.xcu file.

A question therefore:
What is best:
-to use bug 36874 (state resolved fixed) for this thread
-to create a new bug (with reference to 36874)
-use this list
for all comments/discussion etc.?
I think it would be good to have the comments together (traceable).

Wise men, please advise :)

And another question: many labeldefinitions in labels.xcu have German 
descriptions (e.g. from manufacturer Herma). Should these be translated to 
English? :(

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Problem building the 3.5 branch on Windows, postgresql related.

2012-01-05 Thread Jan Holesovsky

Hi Kohei,

On 2012-01-05 at 02:28 -0500, Kohei Yoshida wrote:

> I'm having trouble building the latest 3.5 branch on Windows.  First,
> the postgresql module failed to build due to it not finding ldap.h
> from mozilla.  I had mozilla entirely disabled (I always had).  So I
> decided to enable it to see if it would solve this.  But because I
> didn't want to build it from the sources, I simply stashed the
> pre-built mozilla zips into moz/zipped.

Did you explicitly enable the postgresql build?  Or, are you using the
LibreOfficeWin32 distro?  I'm building just the default build, without
any --with-distro switch, and that is pretty reliable.

> Any idea how I could get this issue resolved?  Do I now need to build
> mozilla from sources on Windows, or ...?

I am not building mozilla from sources; it needs 2005 compiler anyway,
IIRC.

>   How do others build 3.5 on
> Windows these days?

This is the autogen.lastrun of the @6-fast tinderbox, hopefully that can
help?

--with-max-jobs=5
--with-num-cpus=2
--disable-binfilter
--disable-build-mozilla
--without-junit
--with-ant-home=/home/kendy/apache-ant-1.8.2
--with-java-target-version=1.5
--with-jdk-home=/cygdrive/c/Program Files (x86)/Java/jdk1.5.0_22
--with-mozilla-build=/home/kendy/mozilla-build

All the best,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Fridrich Strba

+1 from me too.

BTW, I discovered some problems with ole objects in draw documents when
importing ole objects included in Visio files. I would not mind to have
a quick brainstorming when I am back from holiday. The next libvisio
will output those objects and projects linking with system libvisio
might see those bugs.

Cheers

Fridrich

On 05/01/12 10:45, Caolán McNamara wrote:

So https://bugs.freedesktop.org/show_bug.cgi?id=43867 is a most annoying
bug with a crash on mailmerging documents that contain ole objects in
headers. I'd like to get the following into 3-5.

Immediate crash is fixed by
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7dc25878c1310a1de6d3c87c88404b151bad21fc
where we previously acquired/released the document around the insertion
of content into it, but not around inserting styles, but page styles can
contain headers/footers with arbitrary content, so if we need to acquire
before inserting content, we need to acquire before inserting page
styles.

object preview is still missing from headers though,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef17be8b006737c078a59635ae334a03301727ea
fixes a series of apparent errors

1. FN_UNO_REPLACEMENT_GRAPHIC_URL and FN_UNO_GRAPHIC have the same id in
writer, so "replacement graphic urls" fall into the same case statement
as "replacement graphics", which they aren't. These random ids are *so*
fragile, we need something better here in general.
2. The replacement graphic is set with...
svt::EmbeddedObjectRef xObj = pOleNode->GetOLEObj().GetObject();
xObj.SetGraphic( aGraphic, aMediaType );
but the x of xObj and the name "EmbeddedObjectRef" are misleading, its
not a reference class, so we're setting the replacement graphic onto a
temporary copy of the object. EmbeddedObjectRef is a poor class name, we
should change that.
3. SvXMLGraphicHelper::ImplGetStreamNames doesn't know how to
split ./ObjectReplacements/foo in order to find the preview but
SvXMLEmbeddedObjectHelper::ImplGetStorageNames does, so factored out
better splitter and shared it

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

--
Please avoid sending me Word, Excel or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Tor Lillqvist

+1

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW][3-5] sequence of unfortunate writer ole object in headers problems

2012-01-05 Thread Caolán McNamara

So https://bugs.freedesktop.org/show_bug.cgi?id=43867 is a most annoying
bug with a crash on mailmerging documents that contain ole objects in
headers. I'd like to get the following into 3-5.

object preview is still missing from headers though,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef17be8b006737c078a59635ae334a03301727ea
fixes a series of apparent errors

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Old Oracle Mysql Connector no longer works with 3.5 on Windows - looking for a regular build solution ?


On Wed, 2012-01-04 at 18:33 +0100, Alexander Thurgood wrote:
> There was a bug report here :
> https://bugs.freedesktop.org/show_bug.cgi?id=44075

Great thanks - lets continue this thread in the bug; I've added Jesus'
helpful pointer there too.

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANN] LibreOffice 3.4.5 RC2 test builds available

2012-01-05 Thread Thorsten Behrens

Hi *,

for 3.4.5 RC2, we're now uploading builds to a public (but
non-mirrored - so don't spread news too widely!) place, as soon as
they're available. Grab them here:

http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try & report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs vs. 3.4.5 RC1 is available here

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-4-5-release-3.4.5.2.log

, it would be nice to verify they're really fixed in the build.

Thanks a lot for your help,

-- Thorsten


pgpELiklPVSHO.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||44467

Bug 37361 depends on bug 43867, which changed state.

Bug 43867 Summary: MAILMERGE: Mail Merge with ole object in header of document, 
causes crash. SfxObjectShell::GetEmbeddedObjectContainer
https://bugs.freedesktop.org/show_bug.cgi?id=43867

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #74 from Rainer Bielefeld  
2012-01-04 23:25:30 UTC ---
Nominate Bug 44467 - Deleting sheets can shift images or graphics between next
sheets

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 43867, which changed state.

Bug 43867 Summary: MAILMERGE: Mail Merge with ole object in header of document, 
causes crash. SfxObjectShell::GetEmbeddedObjectContainer
https://bugs.freedesktop.org/show_bug.cgi?id=43867

   What|Old Value   |New Value

 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Old Oracle Mysql Connector no longer works with 3.5 on Windows - looking for a regular build solution ?

2012-01-05 Thread Alexander Thurgood

Hi Stephan,

2012/1/5 Stephan Bergmann 

> On 01/04/2012 11:02 PM, Alex Thurgood wrote:
>
>> Unfortunately, I'm not on Windows. I can only build on Linux and Mac. Am
>> looking to test with gdb on Linux to see what is being called (or not)
>> as the case may be.
>>
>
> But the bug as described only happens on Windows, right?  (Just tested on
> a recent unxlngx6 master build, and 
> mysql-connector-ooo-1.0.1-**linux-x86_64.oxt
> as available from  org/en/project/mysql_connector
> **> indeed installs without problem.)
>
> In that case, I doubt that inspecting Linux behaviour gives a clue to what
> fails on Windows.  I suspect it rather has something to do with the Windows
> MSVC runtime libraries or somesuch.
>
>
>

I had also noticed the problem in a previous master build on Linux, and had
reports back from other users with the Linux connector I've made available
on the LibreOffice extensions site. That is why I changed the LO
compatibility version number to 3.5 for the connectors I have put up there.

However, in my test yesterday with my own build from master from 2 days
ago, and the Oracle mysql connector, I had no problems installing or
running the connector, so in effect, I can no longer reproduce the problem
on 32bit Linux.

In view of Lionel's comments, it seems clear that as I compiled against 3.5
master source, the connectors I have built and made available will only
work with versions >= 3.5, and at present these are only available for
Linux and Mac (my build platforms).

So it still remains to be determined whether, as you stated, the old Oracle
connector is only problematic on Windows. I shall also be testing on Mac
later today with the Oracle connector to see if that also raises an error
with the latest build I have on Mac.

Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes

2012-01-05 Thread Stephan Bergmann


On 01/05/2012 09:38 AM, Tomas Hlavaty wrote:

Stephan Bergmann  writes:

On 01/04/2012 11:09 PM, Tomas Hlavaty wrote:


diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl
b/offapi/com/sun/star/chart/XAxisSupplier.idl
...


Are you sure that this is right, using chart2 entities from within
chart?  I always intuitively thought that chart2 was a second attempt,
to replace chart.


I am not sure as I don't know what chart and chart2 are about but
currently this is broken.  The patch fixes the compilation issue.  Maybe
I should move the file to chart2 package instead?


What exactly is broken?

[...]

That's a good point.  Any idea why XInterface is not used in all cases?
Has it something to do with the fact that reference counting happens
behind the scene in Java?


No, just some (somewhat bad) design decision early on in the life of UNO.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] minor idl fixes