[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Korrawit Pruegsanusak detective.conan.1...@gmail.com changed: What|Removed |Added Depends on||51179 --- Comment #29 from Korrawit Pruegsanusak detective.conan.1...@gmail.com 2012-06-26 23:14:31 PDT --- Adding bug 51179 - cannot save as ppt. Because it's a regression, and I think we can't live with this bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Including a patch from AOO...
Hi there, a nice patch from AOO: http://svn.apache.org/viewvc?view=revisionrevision=1350585 it fixes at least the following bug https://issues.apache.org/ooo/show_bug.cgi?id=119400 which is AFAICS a regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca19291e Is it possible to merge this patch in our repo? And if yes, who would be --author then?.. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Removing avmedia dependency in drawinglayer
Hi Rafael, On Tue, Jun 26, 2012 at 05:27:13PM -0430, Rafael Dominguez venccsra...@gmail.com wrote: This patch remove avmedia dependency in drawinglayer to avoid a circular dependency, this is the most clean solution i came up with but i wanted to share it before applying it The other option was create a new lib drawinglayer_media with just that code because moving the class to svx didnt feel right. The only use of this class came from http://opengrok.libreoffice.org/xref/core/svx/source/sdr/contact/viewcontactofsdrmediaobj.cxx#152 Forgot to attach the patch? ;-) Thanks, Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Removing avmedia dependency in drawinglayer
Hi Rafael, It seems that you forgot to attach the patch ;) -- Cedric On Tue, 2012-06-26 at 17:27 -0430, Rafael Dominguez wrote: This patch remove avmedia dependency in drawinglayer to avoid a circular dependency, this is the most clean solution i came up with but i wanted to share it before applying it The other option was create a new lib drawinglayer_media with just that code because moving the class to svx didnt feel right. The only use of this class came from http://opengrok.libreoffice.org/xref/core/svx/source/sdr/contact/viewcontactofsdrmediaobj.cxx#152 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/filter/ww8/rtfattributeoutput.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 32f7d2d6cce1785607816b57744b938f887f81c0 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 09:35:29 2012 +0200 RtfAttributeOutput::SectionType: don't try to dump break code as char Change-Id: I35e66abd5595a0a23db79aef4a84c25b4f45c725 diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 6810950..c390ef7 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -1270,7 +1270,7 @@ void RtfAttributeOutput::SectionPageNumbering( sal_uInt16 nNumType, sal_uInt16 n void RtfAttributeOutput::SectionType( sal_uInt8 nBreakCode ) { -SAL_INFO(sw.rtf, OSL_THIS_FUNC , nBreakCode = nBreakCode); +SAL_INFO(sw.rtf, OSL_THIS_FUNC , nBreakCode = int(nBreakCode)); /* * break code: 0 No break, 1 New column ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Build Available Feed
Hi all, is there any possibility to get a reliable info that a new build is available from a particular WIN Tinderbox? I always have some test-to-dos in the line, not every test can be done with every build, and especially when (like now) new complete builds come very seldom those unsuccessful checks of the download server are really annoying. Is there a solution for my problem? Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2012][svg export filter] Weekly Report #5
Marco Cecchetti wrote: As for your question: well it works correctly but on Opera as it doesn't like the fill attribute on animation element, and in some cases it removes the attribute value, so I really don't know how to fix it at present. Hi Marco, I see - well that be as it may, but for the other browsers it's an improvement - I would merge it. ;) Cheers, -- Thorsten pgp1DaNm3jvw2.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: ucb/source
ucb/source/ucp/cmis/cmis_content.cxx |7 --- ucb/source/ucp/cmis/cmis_provider.cxx |6 -- 2 files changed, 4 insertions(+), 9 deletions(-) New commits: commit b3c48febcd7d9f4574beba99b66e0974bf3a3c0e Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Tue Jun 26 16:28:21 2012 +0200 CMIS UCP: Use the URL host as ID for cached sessions Using the binding URL as ID for the cached sessions is bad as there may be several repositories on the same binding URL... which means different libcmis::Session objects. Change-Id: Id3605ee4fdfbfc32b72615fb573220e94c8748af diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx index bb6e1a0..59febd9 100644 --- a/ucb/source/ucp/cmis/cmis_content.cxx +++ b/ucb/source/ucp/cmis/cmis_content.cxx @@ -162,13 +162,14 @@ namespace cmis m_sURL = m_xIdentifier-getContentIdentifier( ); cmis::URL url( m_sURL ); -// Look for a cached session -m_pSession = pProvider-getSession( url.getBindingUrl( ) ); +// Look for a cached session, key is binding url + repo id +INetURLObject aUrlObj( m_sURL ); +m_pSession = pProvider-getSession( aUrlObj.GetHost( ) ); if ( NULL == m_pSession ) { // Initiate a CMIS session and register it as we found nothing m_pSession = libcmis::SessionFactory::createSession( url.getSessionParams( ) ); -pProvider-registerSession( url.getBindingUrl( ), m_pSession ); +pProvider-registerSession( aUrlObj.GetHost( ), m_pSession ); } m_sObjectPath = url.getObjectPath( ); diff --git a/ucb/source/ucp/cmis/cmis_provider.cxx b/ucb/source/ucp/cmis/cmis_provider.cxx index a13e9f7..f65a1ca 100644 --- a/ucb/source/ucp/cmis/cmis_provider.cxx +++ b/ucb/source/ucp/cmis/cmis_provider.cxx @@ -88,16 +88,10 @@ ContentProvider::ContentProvider( const uno::Reference lang::XMultiServiceFactory rSMgr ) : ::ucbhelper::ContentProviderImplHelper( rSMgr ) { -#if OSL_DEBUG_LEVEL 1 -fprintf(stderr, ContentProvider::ContentProvider( )\n ); -#endif } ContentProvider::~ContentProvider() { -#if OSL_DEBUG_LEVEL 1 -fprintf(stderr, ContentProvider::~ContentProvider( )\n ); -#endif } XINTERFACE_IMPL_3( ContentProvider, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 5 commits - libcmis/boost-win.patch libcmis/makefile.mk ooo.lst.in ucb/source
libcmis/boost-win.patch | 20 - libcmis/makefile.mk |7 ooo.lst.in|2 ucb/source/ucp/cmis/cmis_content.cxx | 462 +++--- ucb/source/ucp/cmis/cmis_content.hxx |2 ucb/source/ucp/cmis/cmis_provider.cxx |6 6 files changed, 277 insertions(+), 222 deletions(-) New commits: commit fb6578d4cddf031f9c331536f353707c92b9666b Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Tue Jun 26 16:28:21 2012 +0200 CMIS UCP: Use the URL host as ID for cached sessions Using the binding URL as ID for the cached sessions is bad as there may be several repositories on the same binding URL... which means different libcmis::Session objects. Change-Id: Id3605ee4fdfbfc32b72615fb573220e94c8748af diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx index bb6e1a0..59febd9 100644 --- a/ucb/source/ucp/cmis/cmis_content.cxx +++ b/ucb/source/ucp/cmis/cmis_content.cxx @@ -162,13 +162,14 @@ namespace cmis m_sURL = m_xIdentifier-getContentIdentifier( ); cmis::URL url( m_sURL ); -// Look for a cached session -m_pSession = pProvider-getSession( url.getBindingUrl( ) ); +// Look for a cached session, key is binding url + repo id +INetURLObject aUrlObj( m_sURL ); +m_pSession = pProvider-getSession( aUrlObj.GetHost( ) ); if ( NULL == m_pSession ) { // Initiate a CMIS session and register it as we found nothing m_pSession = libcmis::SessionFactory::createSession( url.getSessionParams( ) ); -pProvider-registerSession( url.getBindingUrl( ), m_pSession ); +pProvider-registerSession( aUrlObj.GetHost( ), m_pSession ); } m_sObjectPath = url.getObjectPath( ); diff --git a/ucb/source/ucp/cmis/cmis_provider.cxx b/ucb/source/ucp/cmis/cmis_provider.cxx index a13e9f7..f65a1ca 100644 --- a/ucb/source/ucp/cmis/cmis_provider.cxx +++ b/ucb/source/ucp/cmis/cmis_provider.cxx @@ -88,16 +88,10 @@ ContentProvider::ContentProvider( const uno::Reference lang::XMultiServiceFactory rSMgr ) : ::ucbhelper::ContentProviderImplHelper( rSMgr ) { -#if OSL_DEBUG_LEVEL 1 -fprintf(stderr, ContentProvider::ContentProvider( )\n ); -#endif } ContentProvider::~ContentProvider() { -#if OSL_DEBUG_LEVEL 1 -fprintf(stderr, ContentProvider::~ContentProvider( )\n ); -#endif } XINTERFACE_IMPL_3( ContentProvider, commit 5d41f72f8edf880c496831078fadf1f72ece9251 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Tue Jun 26 13:29:53 2012 +0200 libcmis: forgot to update windows patch for 0.2.3 Change-Id: I7ea63acbe2f75f1e53611d75a6adc14c2bcac887 diff --git a/libcmis/boost-win.patch b/libcmis/boost-win.patch index fde29df..b794787 100644 --- a/libcmis/boost-win.patch +++ b/libcmis/boost-win.patch @@ -1,5 +1,5 @@ misc/libcmis-0.2.2/src/libcmis/atom-object.cxx 2012-06-01 07:44:26.0 -0600 -+++ misc/build/libcmis-0.2.2/src/libcmis/atom-object.cxx 2012-06-04 07:52:24.131190200 -0600 +--- misc/libcmis-0.2.3/src/libcmis/atom-object.cxx 2012-06-01 07:44:26.0 -0600 misc/build/libcmis-0.2.3/src/libcmis/atom-object.cxx 2012-06-04 07:52:24.131190200 -0600 @@ -29,6 +29,9 @@ #include algorithm #include sstream @@ -10,8 +10,8 @@ #include boost/date_time/posix_time/posix_time.hpp #include atom-object.hxx misc/libcmis-0.2.2/src/libcmis/object.hxx 2012-06-01 07:38:36.0 -0600 -+++ misc/build/libcmis-0.2.2/src/libcmis/object.hxx2012-06-04 07:52:21.900386200 -0600 +--- misc/libcmis-0.2.3/src/libcmis/object.hxx 2012-06-01 07:38:36.0 -0600 misc/build/libcmis-0.2.3/src/libcmis/object.hxx2012-06-04 07:52:21.900386200 -0600 @@ -32,6 +32,9 @@ #include map #include string @@ -22,8 +22,8 @@ #include boost/date_time.hpp #include boost/shared_ptr.hpp misc/libcmis-0.2.2/src/libcmis/property-type.hxx 2012-02-17 08:00:50.0 -0700 -+++ misc/build/libcmis-0.2.2/src/libcmis/property-type.hxx 2012-06-04 07:52:17.157977900 -0600 +--- misc/libcmis-0.2.3/src/libcmis/property-type.hxx 2012-02-17 08:00:50.0 -0700 misc/build/libcmis-0.2.3/src/libcmis/property-type.hxx 2012-06-04 07:52:17.157977900 -0600 @@ -28,6 +28,9 @@ #ifndef _PROPERTY_TYPE_HXX_ #define _PROPERTY_TYPE_HXX_ @@ -34,8 +34,8 @@ #include boost/date_time.hpp #include libxml/tree.h misc/libcmis-0.2.2/src/libcmis/property.hxx2012-02-17 06:38:33.0 -0700 -+++ misc/build/libcmis-0.2.2/src/libcmis/property.hxx 2012-06-04 07:52:19.388781800 -0600 +--- misc/libcmis-0.2.3/src/libcmis/property.hxx2012-02-17 06:38:33.0 -0700 misc/build/libcmis-0.2.3/src/libcmis/property.hxx 2012-06-04 07:52:19.388781800 -0600 @@ -31,6 +31,9 @@ #include libxml/tree.h #include libxml/xmlwriter.h @@ -46,8
[Libreoffice-commits] .: external/prj
external/prj/d.lst |1 + 1 file changed, 1 insertion(+) New commits: commit c4c50261e423c53caf562dbfa0bfd32f80353c93 Author: Jan Holesovsky ke...@suse.cz Date: Wed Jun 27 10:40:36 2012 +0200 Deliver also *.exe (to get python.exe delivered). Change-Id: I6e4645dc9de9e6650f3b5d9276e96b20266ada48 diff --git a/external/prj/d.lst b/external/prj/d.lst index fb1bd77..7fa38d3 100644 --- a/external/prj/d.lst +++ b/external/prj/d.lst @@ -46,6 +46,7 @@ mkdir: %_DEST%\inc\external\wine ..\unowinreg\unowinreg.dll %_DEST%\bin\unowinreg.dll ..\%__SRC%\bin\*.dll %_DEST%\bin\*.dll +..\%__SRC%\bin\*.exe %_DEST%\bin\*.exe ..\%__SRC%\lib\libmsvcrt*.* %_DEST%\lib\lib*.* ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Including a patch from AOO...
Hi Ivan, On Wed, 2012-06-27 at 10:41 +0400, Ivan Timofeev wrote: a nice patch from AOO: :-) Is it possible to merge this patch in our repo? And if yes, who would be --author then?.. That requires the module underneath to be re-based on top of the Apache code; which can be more or less difficult to do depending on your luck, how patch sets intersect and so on. That fundamental work is ongoing on master; we can do this in certain specific cases on the 3.6 branch as well, 3.5 is out of the question I'm afraid. So - if we can independently fix the bug in a different way, that is the easiest outcome for now. Going forward, once all possible files have been re-based on the ALv2 code; then we need to work through all the bug reports and mass import any fixes that are not problematic / don't already conflict. There is a mapping in contrib/gitdm-config/aliases that unwinds authorship to real E-mails at least nominally - sadly little attempt is made to make it easy to preserve true authorship information by svn itself so ... there will be more imprecision and/or foot-work needed there. The punch-line: for now, it'd be nice to re-implement small fixes. If you have a list of larger ones we want, then build a list and send it to me I'll see what we can do for 3.6. When we hit 3.7 there should be ~zero licensing barrier to forward-porting any fix we like, and we'll start doing that in a systematic way. Does that make sense ? :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-ux-advise] [PATCH] fdo#35365 default font color for documents
Hi all, I am not a user of high-contrast themes, and might not be able to help very much here. I am adding Christophe from a11y here who might be able to share some more ideas. So, High-Contrast... there are two types of high-contrast themes in most OS's, namely dark on light and light on dark. I think the users of the different types have different needs, too. Ooo, and thus, LibO generally cater to light on dark themes (as is evident in our hicontrast theme). Which incidentally, is the type of theme making trouble here. Thus, even though I generally like Benjamin's patch, I am not sure either that it's doing the right thing. Christophe, can you help? Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
fdo#51324 impress close crash -- help needed
Hi, I would appreciate some help with fdo#51324: https://bugs.freedesktop.org/show_bug.cgi?id=51324 if someone has some nice diagram or ASCII art showing which objects owns what in the sd::toolpane area, that would be rather helpful. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Including a patch from AOO...
On 27/06/12 10:47, Michael Meeks wrote: On Wed, 2012-06-27 at 10:41 +0400, Ivan Timofeev wrote: a nice patch from AOO: Is it possible to merge this patch in our repo? And if yes, who would be --author then?.. it seems they even add the mail address to the comment nowadays, which isn't as nice as a git Author, but it's an improvement. in principle it would of course be possible to ask the patch author if he's ok with our favourite dual-license, but that approach runs into the problem that of course IBM employees cannot agree to that, and apparently IBM employees routinely use non-IBM (gmail.com etc.) mail addresses in their interaction with AOO (because they're all volunteers, you know), and in practice IBM employees will do 95% of the work on ApacheOO, so why bother... So - if we can independently fix the bug in a different way, that is the easiest outcome for now. Going forward, once all possible files have been re-based on the ALv2 code; then we need to work through all the bug reports and mass import any fixes that are not problematic / don't already conflict. that makes sense in general, but (to my non-legally-trained eyes) it looks like this patch is so simple that it very likely doesn't meet the threshold of creativity that is required to be eligible for copyright protection in the first place; is it possible to come up with some simple rules that would allow cherry picking such simple patches even to non-rebased branches (any such hypothetical process must require review of course)? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: installation sets, parallel compression, pigz etc.
Michael Stahl píše v Út 26. 06. 2012 v 17:02 +0200: i've noticed that building archive installation sets on my machine is entirely CPU bound (since everything fits into RAM) and a single gzip takes up most of the time, so i've toyed around a little with a parallel implementation pigz (available in Fedora) and a single line change makes quite a difference real2m55.031s user3m7.863s sys 0m10.980s real0m39.902s user4m40.154s sys 0m12.257s That sounds great. Unfortunately, the patch can't be applied as is. Would you mind to add a configure check for gzip/pigz and call it via an variable? i wonder, is this something that would enable us to do release builds faster; of course since i don't do those i don't know to what extent it could help, especially as we don't release archive but rpm (and deb?) installation sets, and probably those will have their compression done by something invoked by rpm... but at least for gzip/pigz the tools look compatible, so perhaps putting it in PATH with the right name could be done. We could also somehow tweak the internal epm. Well, AFAIK, the tasks for creating normal installation, help packs, lang packs, debs and rpms are done in parallel, so we already have some kind of parallelism. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Error when trying to compile LibreOffice 3.5.2
Hi everybody: Rigth now I'm trying to compile the LibreOffice 3.5.2 version source code in a PC with Windows 7, but I have two errors and I can't fix it. I followed every step like documentation : http://wiki.documentfoundation.org/Development/How_to_build http://wiki.documentfoundation.org/Development/Native_Build/es After install all pre-requisites http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies I run the autogen command without problems, I extracted the contents of LibreOffice-core-3.5.2.2.tar.xz a path c:\Libo and execute the command make fetch. The compilation began inmediatilly, but after a few hours compiling, marked the following error in the package 102 of 156 = (102/156) Building module unotest = --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /cygdrive/c/libo/python ERROR: error 65280 occurred while making /cygdrive/c/libo/icu it seems you are using a threaded build, which means that the actual compile error is probably hidden far above, and could be inside any of these other modules: python please re-run build inside each one to isolate the problem. --- As the manual says, I tried to build each module separately, in both cases I get this error: = (1/1) Building module python = Entering /cygdrive/c/libo/python dmake: Warning: -- Found file corresponding to virtual target [./wntmsci12.pro/misc/build/Python-2.6.1/PC/pyconfig.h]. Generador de proyectos de Microsoft (R) Generador de proyectos de Visual C++ - Versi▒n de l▒nea de comandos 9.00.30729 Copyright (C) Microsoft Corporation. All rights reserved. vcbuild.exe : error VCBLD0001: VCProjectEngine.dll no se puede cargar. Aseg▒rese de que el archivo VCProjectEngine.dll se encuentra en el mismo directorio que el archivo vcbuild.exe. dmake: Error code 127, while making './wntmsci12.pro/misc/build/so_built_so_python' Retrying /cygdrive/c/libo/python dmake: Warning: -- Found file corresponding to virtual target [./wntmsci12.pro/misc/build/Python-2.6.1/PC/pyconfig.h]. Generador de proyectos de Microsoft (R) Generador de proyectos de Visual C++ - Versi▒n de l▒nea de comandos 9.00.30729 Copyright (C) Microsoft Corporation. All rights reserved. vcbuild.exe : error VCBLD0001: VCProjectEngine.dll no se puede cargar. Aseg▒rese de que el archivo VCProjectEngine.dll se encuentra en el mismo directorio que el archivo vcbuild.exe. dmake: Error code 127, while making './wntmsci12.pro/misc/build/so_built_so_python' --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /cygdrive/c/libo/python it seems that the error is inside 'python', please re-run build inside this module to isolate the error and/or test your fix: --- /usr/bin/sh cd C:/libo source ./Env.Host.sh cd python rm -Rf C:/libo/python/wntmsci12.pro # optional module 'clean' build when the problem is isolated and fixed exit and re-run 'make' from the top-level === I searched the DLL mentioned in the error (VCProjectEngine.dll), and this is in the same folder where the file VCBuild.exe, in the following path: C:\software\Microsoft Visual Studio 9.0\VC\vcpackages Can someone tell me what I have to do to fix this error? Best Regards Leonardo Josué___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Removing avmedia dependency in drawinglayer
Oops my bad, heres the patch attached 0001-Remove-dependency-of-avmedia-in-drawinglayer.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Including a patch from AOO...
On Wed, 2012-06-27 at 11:22 +0200, Michael Stahl wrote: that makes sense in general, but (to my non-legally-trained eyes) it looks like this patch is so simple that it very likely doesn't meet the threshold of creativity that is required to be eligible for copyright protection in the first place I don't want to go there really. Please just re-implement the fix in a different way - and/or if this is a really key-fix we can re-base that one file in 3.6. I'm glad author E-mails are going into svn these days - we can use them in future post the re-base to ensure crediting / affiliations etc. are correctly given. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - android/experimental
android/experimental/DocumentLoader/src/com/polites/android/FlingListener.java | 45 -- android/experimental/DocumentLoader/src/com/polites/android/GestureImageView.java | 14 ++- android/experimental/DocumentLoader/src/com/polites/android/GestureImageViewTouchListener.java | 25 + android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java | 22 ++-- 4 files changed, 48 insertions(+), 58 deletions(-) New commits: commit 0179c9628258f30c41121a1ff3a50fcebe44d776 Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Jun 27 12:54:41 2012 +0300 Adapt page switch animation duration to fling velocity Change-Id: I30e177b45b0e25d92fd7dea02ffe4e9c0731dce5 diff --git a/android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java b/android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java index 2587857..677c6d4 100644 --- a/android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java +++ b/android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java @@ -149,12 +149,13 @@ public class DocumentLoader Animation inFromRight = new TranslateAnimation(Animation.RELATIVE_TO_SELF, 1, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0); -inFromRight.setDuration(500); +int duration = Math.abs((int)((float)flipper.getWidth()/velocityX*1000f)); +inFromRight.setDuration(duration); flipper.setInAnimation(inFromRight); Animation outToLeft = new TranslateAnimation(Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, -1, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0); -outToLeft.setDuration(500); +outToLeft.setDuration(duration); flipper.setOutAnimation(outToLeft); flipper.showNext(); @@ -167,12 +168,13 @@ public class DocumentLoader Animation inFromLeft = new TranslateAnimation(Animation.RELATIVE_TO_SELF, -1, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0); -inFromLeft.setDuration(500); +int duration = Math.abs((int)((float)flipper.getWidth()/velocityX*1000f)); +inFromLeft.setDuration(duration); flipper.setInAnimation(inFromLeft); Animation outToRight = new TranslateAnimation(Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 1, Animation.RELATIVE_TO_SELF, 0, Animation.RELATIVE_TO_SELF, 0); -outToRight.setDuration(500); +outToRight.setDuration(duration); flipper.setOutAnimation(outToRight); flipper.showPrevious(); commit 5bfb819581bdc9e1f1c59e36a0d7fb21593b382b Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Jun 27 12:30:32 2012 +0300 Use GestureImageView again but still do handle page changes Make the GestureImageView constructors take a OnGestureListener, and store that, Move the FlingListener class into GestureImageViewTouchListener so that FlingListener has access to the fields of GestureImageViewTouchListener. If the image is fully zoomed out and can't be dragged, pass flings on up, to DocumentLoader's gestureListener. Change-Id: I574280de23bdab2772a361833f561dff3e182bcd diff --git a/android/experimental/DocumentLoader/src/com/polites/android/FlingListener.java b/android/experimental/DocumentLoader/src/com/polites/android/FlingListener.java deleted file mode 100644 index ab3007a..000 --- a/android/experimental/DocumentLoader/src/com/polites/android/FlingListener.java +++ /dev/null @@ -1,45 +0,0 @@ -/* - * Copyright (c) 2012 Jason Polites - * - * Licensed under the Apache License, Version 2.0 (the License); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an AS IS BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package com.polites.android; - -import android.view.GestureDetector.SimpleOnGestureListener; -import android.view.MotionEvent; - - -/** - * @author Jason Polites - * - */ -public class FlingListener extends SimpleOnGestureListener
Re: vcl checkbox behaviour
On 25/06/12 11:46, Noel Power wrote: I wonder is the behaviour that I see here normal or expected ( to me is isn't but I am not very ui-enabled ). Look at the attached jpeg, the first three checkboxes have the Align property set as Left, Center and Right, with no label the checkbox 'box' is aligned within the bounding rectangle of the control according to the 'Align' property. However, if there is a label then the checkbox 'box' is always left aligned and it is the text label that is aligned according to the 'Align' property. Now to my puny brain the latter behaviour ( as if there is a label present ) is what I would expect always. I would like to change the behaviour to be like that, but... the code is obviously and intentionally written to behave in the way described, does this make sense? would it be ok to change this? is it only me that things this is bizarre? For context this behaviour is causing me some grief when importing controls from mso formats, I could of course add some flag to the vcl Checkbox[*] class to make it behave like I wish conditionally, note: that also could require the toolbox awt ( and formcontrol ) uno checkbox control to support an extra flag also that could be persisted or their behaviour could independently be changed unconditionally ( and no need to support extra properties ). I am somewhat stumbling over what would be best to do, change the underlying vcl class unconditionally ? ( that would imply the uno controls behaviour also changes unconditionally ) or ... if we change the underlying vcl class conditionally what about the uno controls?, should we change them also conditionally? or unconditionally? It would seem to me if there is some consensus that the 'normal' vcl behaviour is not that normal but is 'abnormal' then I would be inclined to change the vcl class unconditionally ( and similarly the behaviour of the dependant uno controls ) Any thoughts ? Noel [*] same issue exists for (at least) for radio buttons no thoughts anyone ? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Removing avmedia dependency in drawinglayer
On 27/06/12 11:54, Rafael Dominguez wrote: Oops my bad, heres the patch attached patch looks good, except for this, which should be a boost::scoped_ptr so you don't need to delete it manually: +const Graphic *mpSnapshot; also, if the goal is to solve some cyclic dependency then you'll probably need to remove avmedia from first line of drawinglayer/prj/build.lst as well. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Removing avmedia dependency in drawinglayer
Rafael Dominguez wrote: Oops my bad, heres the patch attached Hi Rafael, nice improvement - two nits though: @@ -65,6 +67,8 @@ namespace drawinglayer /// discrete border (in 'pixels') sal_uInt32 mnDiscreteBorder; +const Graphic *mpSnapshot; + Parent classes of MediaPrimitive2D derive from boost::noncopyable - that means you don't have to worry about having to modify mpSnapshot, which in turn means it could be const Graphic instead. But it's even easier, since Graphic has copy-on-write behaviour - you can simply hold a Graphic by value in your primitive, it only contains a cheap ptr to an impl class, that gets, if necessary, copied duplicated if you modify one of the many shared copies. (many bulky objects in LibO have that behaviour, including bitmaps, polygons, and metafiles (sorta)) Cheers, -- Thorsten pgptBziKp2SAz.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sw/CppunitTest_sw_subsequent_rtfexport.mk sw/qa sw/source
sw/CppunitTest_sw_subsequent_rtfexport.mk |2 + sw/qa/extras/rtfexport/data/fdo48335.odt|binary sw/qa/extras/rtfexport/rtfexport.cxx| 30 sw/source/filter/ww8/rtfattributeoutput.cxx |5 +++- sw/source/filter/ww8/rtfattributeoutput.hxx |3 ++ sw/source/filter/ww8/rtfexport.cxx |4 ++- 6 files changed, 42 insertions(+), 2 deletions(-) New commits: commit 87d29c4506093680eaf5300fa0ed95a6897120d1 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 12:11:05 2012 +0200 fdo#48335 testcase Change-Id: I032ff9b65ec9c4d70a2247c7311c2c7292a411c7 diff --git a/sw/CppunitTest_sw_subsequent_rtfexport.mk b/sw/CppunitTest_sw_subsequent_rtfexport.mk index e55af88..bdc47cd 100644 --- a/sw/CppunitTest_sw_subsequent_rtfexport.mk +++ b/sw/CppunitTest_sw_subsequent_rtfexport.mk @@ -69,7 +69,9 @@ $(eval $(call gb_CppunitTest_use_components,sw_subsequent_rtfexport,\ filter/source/config/cache/filterconfig1 \ framework/util/fwk \ i18npool/util/i18npool \ +package/source/xstor/xstor \ package/util/package2 \ +sax/source/expatwrap/expwrap \ sfx2/util/sfx \ svl/source/fsstor/fsstorage \ svtools/util/svt \ diff --git a/sw/qa/extras/rtfexport/data/fdo48335.odt b/sw/qa/extras/rtfexport/data/fdo48335.odt new file mode 100644 index 000..4259f98 Binary files /dev/null and b/sw/qa/extras/rtfexport/data/fdo48335.odt differ diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx b/sw/qa/extras/rtfexport/rtfexport.cxx index 428b7e1..599b5b6 100644 --- a/sw/qa/extras/rtfexport/rtfexport.cxx +++ b/sw/qa/extras/rtfexport/rtfexport.cxx @@ -49,6 +49,7 @@ public: void testFdo44174(); void testFdo50087(); void testFdo50831(); +void testFdo48335(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -58,6 +59,7 @@ public: CPPUNIT_TEST(testFdo44174); CPPUNIT_TEST(testFdo50087); CPPUNIT_TEST(testFdo50831); +CPPUNIT_TEST(testFdo48335); #endif CPPUNIT_TEST_SUITE_END(); @@ -144,6 +146,34 @@ void Test::testFdo50831() CPPUNIT_ASSERT_EQUAL(10.f, fValue); } +void Test::testFdo48335() +{ +/* + * The problem was that we exported a fake pagebreak, make sure it's just a soft one now. + * + * oParas = ThisComponent.Text.createEnumeration + * oPara = oParas.nextElement + * oPara = oParas.nextElement + * oPara = oParas.nextElement + * oRuns = oPara.createEnumeration + * oRun = oRuns.nextElement + * xray oRun.TextPortionType 'was Text, should be SoftPageBreak + */ +roundtrip(fdo48335.odt); + +uno::Referencetext::XTextDocument xTextDocument(mxComponent, uno::UNO_QUERY); +uno::Referencecontainer::XEnumerationAccess xParaEnumAccess(xTextDocument-getText(), uno::UNO_QUERY); +uno::Referencecontainer::XEnumeration xParaEnum = xParaEnumAccess-createEnumeration(); +for (int i = 0; i 2; i++) +xParaEnum-nextElement(); +uno::Referencecontainer::XEnumerationAccess xRunEnumAccess(xParaEnum-nextElement(), uno::UNO_QUERY); +uno::Referencecontainer::XEnumeration xRunEnum = xRunEnumAccess-createEnumeration(); +uno::Referencebeans::XPropertySet xPropertySet(xRunEnum-nextElement(), uno::UNO_QUERY); +OUString aValue; +xPropertySet-getPropertyValue(TextPortionType) = aValue; +CPPUNIT_ASSERT_EQUAL(OUString(SoftPageBreak), aValue); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); CPPUNIT_PLUGIN_IMPLEMENT(); commit a03895986308206cc13a6f5ae25138d4b4ad5d43 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 11:16:55 2012 +0200 fdo#48335 RTF export: avoid fake page breaks on page style changes The problem was that a page break has been always exported when the page style changed -- but in case the page style changes just because of first page-like styles, we don't need that. Change-Id: I15527c8d3a2d1c441b4817cf94d61ea68dc5f92c diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index c390ef7..113c6d2 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -350,6 +350,8 @@ void RtfAttributeOutput::StartParagraphProperties( const SwTxtNode rNode ) { const SwTxtNode* pTxtNode = static_cast SwTxtNode* ( aNextIndex.GetNode() ); m_rExport.OutputSectionBreaks( pTxtNode-GetpSwAttrSet(), *pTxtNode ); +// Save the current page description for now, so later we will be able to access the previous one. +m_pPrevPageDesc = pTxtNode-FindPageDesc(sal_False); } else if ( aNextIndex.GetNode().IsTableNode() ) { @@ -3031,7 +3033,8 @@ RtfAttributeOutput::RtfAttributeOutput( RtfExport rExport ) m_bTableRowEnded( false ), m_aCells(), m_bSingleEmptyRun(false), -m_bInRun(false) +m_bInRun(false), +m_pPrevPageDesc(0) { SAL_INFO(sw.rtf, OSL_THIS_FUNC); } diff --git
[Libreoffice-commits] .: xmloff/source
xmloff/source/chart/SchXMLChartContext.hxx|5 - xmloff/source/chart/SchXMLParagraphContext.hxx|2 -- xmloff/source/chart/SchXMLTableContext.hxx|4 xmloff/source/draw/layerimp.hxx |2 -- xmloff/source/draw/sdxmlexp_impl.hxx |9 - xmloff/source/draw/sdxmlimp_impl.hxx |4 xmloff/source/draw/ximpcustomshape.hxx|1 - xmloff/source/forms/callbacks.hxx |4 xmloff/source/forms/elementimport.hxx |1 - xmloff/source/forms/formattributes.hxx|1 - xmloff/source/forms/layerimport.hxx |4 +--- xmloff/source/style/impastpl.hxx |1 - xmloff/source/text/XMLRedlineExport.hxx |1 - xmloff/source/text/XMLSectionImportContext.hxx|1 - xmloff/source/text/XMLTextFrameHyperlinkContext.hxx |3 --- xmloff/source/text/XMLTrackedChangesImportContext.hxx |4 xmloff/source/transform/CreateElemTContext.hxx|2 -- xmloff/source/transform/ProcAddAttrTContext.hxx |2 -- xmloff/source/transform/ProcAttrTContext.hxx |2 -- 19 files changed, 1 insertion(+), 52 deletions(-) New commits: commit 6013882bdff6265548a1511799611243a9d0e083 Author: Takeshi Abe t...@fixedpoint.jp Date: Wed Jun 27 20:03:57 2012 +0900 removed unnecessary forward declarations of class except moving SvXMLStyleContext into xmloff/source/forms/layerimport.hxx Change-Id: I5e16b54f98ccdd54bc0bb373d3fe92ed1bef3c5e diff --git a/xmloff/source/chart/SchXMLChartContext.hxx b/xmloff/source/chart/SchXMLChartContext.hxx index 249cbdb..4e39113 100644 --- a/xmloff/source/chart/SchXMLChartContext.hxx +++ b/xmloff/source/chart/SchXMLChartContext.hxx @@ -40,18 +40,13 @@ #include list #include map -class SchXMLImport; class SchXMLImportHelper; namespace com { namespace sun { namespace star { namespace chart { class XChartDocument; -class XDiagram; struct ChartSeriesAddress; } -namespace util { -class XStringMapping; -} namespace xml { namespace sax { class XAttributeList; }} diff --git a/xmloff/source/chart/SchXMLParagraphContext.hxx b/xmloff/source/chart/SchXMLParagraphContext.hxx index 31b8337..ba246ee 100644 --- a/xmloff/source/chart/SchXMLParagraphContext.hxx +++ b/xmloff/source/chart/SchXMLParagraphContext.hxx @@ -23,8 +23,6 @@ #include rtl/ustring.hxx #include rtl/ustrbuf.hxx -class SchXMLImport; - namespace com { namespace sun { namespace star { namespace xml { namespace sax { class XAttributeList; } diff --git a/xmloff/source/chart/SchXMLTableContext.hxx b/xmloff/source/chart/SchXMLTableContext.hxx index 005fda9..3285849 100644 --- a/xmloff/source/chart/SchXMLTableContext.hxx +++ b/xmloff/source/chart/SchXMLTableContext.hxx @@ -28,15 +28,11 @@ #include transporttypes.hxx namespace com { namespace sun { namespace star { -namespace frame { -class XModel; -} namespace xml { namespace sax { class XAttributeList; }} namespace chart { class XChartDocument; -struct ChartSeriesAddress; // diff --git a/xmloff/source/draw/layerimp.hxx b/xmloff/source/draw/layerimp.hxx index 47eb16a..09464a9 100644 --- a/xmloff/source/draw/layerimp.hxx +++ b/xmloff/source/draw/layerimp.hxx @@ -23,8 +23,6 @@ #include xmloff/xmlictxt.hxx #include com/sun/star/container/XNameAccess.hpp -class AnimImpImpl; - // // presentations:animations diff --git a/xmloff/source/draw/sdxmlexp_impl.hxx b/xmloff/source/draw/sdxmlexp_impl.hxx index 0558fae..bb95104 100644 --- a/xmloff/source/draw/sdxmlexp_impl.hxx +++ b/xmloff/source/draw/sdxmlexp_impl.hxx @@ -41,20 +41,11 @@ // -class SvXMLUnitConverter; -class SvXMLExportItemMapper; -class SfxPoolItem; -class SfxItemSet; -class OUStrings_Impl; class Rectangle; -class ImpPresPageDrawStylePropMapper; class ImpXMLEXPPageMasterInfo; -class ImpXMLDrawPageInfoList; class ImpXMLAutoLayoutInfo; -class SvXMLAutoStylePoolP; class XMLSdPropHdlFactory; -class ImpXMLShapeStyleInfo; class XMLShapeExportPropertyMapper; class XMLPageExportPropertyMapper; diff --git a/xmloff/source/draw/sdxmlimp_impl.hxx b/xmloff/source/draw/sdxmlimp_impl.hxx index d6bd917..f13524a 100644 --- a/xmloff/source/draw/sdxmlimp_impl.hxx +++ b/xmloff/source/draw/sdxmlimp_impl.hxx @@ -169,10 +169,6 @@ typedef std::map sal_Int32, com::sun::star::uno::Reference com::sun::star::dra class SvXMLUnitConverter; class SvXMLTokenMap; -class XMLSdPropHdlFactory; -class XMLPropertySetMapper; -class XMLPropStyleContext; -class SdXMLStylesContext; class
[Libreoffice-commits] .: sc/source
sc/source/ui/view/output2.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit ce255c2e841d6a3e0a6664834a2931f2353ff249 Author: Noel Power noel.po...@novell.com Date: Wed Jun 27 12:17:43 2012 +0100 tweak ScDrawStringsVars::RepeatToFill, us String::Expand instead of loop Change-Id: I74cfa5813f7df526794cea3cdeaf26fc5f1820ba diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx index 4e0edff..4f002fd 100644 --- a/sc/source/ui/view/output2.cxx +++ b/sc/source/ui/view/output2.cxx @@ -566,9 +566,9 @@ void ScDrawStringsVars::RepeatToFill( long colWidth ) return; long nCharsToInsert = aSpaceToFill / charWidth; -for ( int i = 0; i nCharsToInsert; ++i ) -aString.Insert( nChar, nPos ); - +String aFill; +aFill.Expand( nCharsToInsert, nChar); +aString.Insert( aFill, nPos); TextChanged(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Help in fixing gradient bug
Hi Thorsten, On Wed, Jun 20, 2012 at 6:40 PM, Thorsten Behrens t...@documentfoundation.org wrote: Aakriti Gupta wrote: Which files do I look into for exporting of embedded documents in pdfs, e.g. charts inserted in a presentation to be exported to pdf? This bug seems to be higher on our priority list. Hi there, it's the same backend code that I referenced in my earlier email - it all gets broken down to rather few graphic operations. The content itself, for embedded documents, is rendered by the applications - for charts, a Draw document is synthesized, then rendered. It would help to know more details of the problem, to give you a more specific direction. I tested some ppt files which had Embedded objects. I realize most linked objects except for MS Visio object, export fine. Are Visio docs also synthesized by Draw? When I open the ppt (which has an embedded Visio document) in Impress, the object is rendered incomplete, i.e. the text shows but not the rectangles and arrows. Where do you think I should into the code for this. Cheers, -- Thorsten -- Thanks! -Aakriti http://aakritigupta.wordpress.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: toolkit/src2xml
toolkit/src2xml/src.lst |1 - 1 file changed, 1 deletion(-) New commits: commit 6a07013f155ff2e24e13a2188951070b5af4befa Author: Thomas Arnhold tho...@arnhold.org Date: Wed Jun 27 13:38:24 2012 +0200 Remove non-existing schedule.src Change-Id: I86769ba6dd3953f65bbfc2db01e0bef7e8cdba12 diff --git a/toolkit/src2xml/src.lst b/toolkit/src2xml/src.lst index df0a1f4..fdfe91f 100644 --- a/toolkit/src2xml/src.lst +++ b/toolkit/src2xml/src.lst @@ -661,6 +661,5 @@ ../../wizards/source/euro/euro.src ../../wizards/source/imagelists/imagelists.src ../../wizards/source/template/template.src -../../wizards/source/schedule/schedule.src ../../wizards/source/importwizard/importwi.src ../../wizards/source/formwizard/dbwizres.src ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-commits] .: 3 commits - svtools/inc svtools/source
Tomaž Vajngerl wrote: commit 447844036930f6503e6791e2207bc6408a4cbb84 Author: Toma?? Vajngerl qui...@gmail.com Date: Mon Jun 25 21:19:21 2012 +0200 Remove ImplCreateScaled and ImplCreateRotatedScaled ImplCreateScaled and ImplCreateRotatedScaled are now not used anymore, so they can be removed. Hi Tomaž, great fixes there - I especially like the sinc interpolation changes. Just a remark to ImplCreateRotatedScaled, that *did* have some performance benefits, by having only *one* pass over the image. commit 764525b39c78bfad1f6fc44a8517a565547f67cf Author: Toma?? Vajngerl qui...@gmail.com Date: Mon Jun 25 21:07:06 2012 +0200 use only Bitmap scaling and fixes to scaling grfmgr uses its own scaling functions instead of the scaling functions available on Bitmap object. The step to use the Bitmap::Scale for most scenarios was already made, now the grfmgr functions are not used anymore. See above - there are nice, separable algorithms for bitmap manipulations, that can do affine transformations in 2-3 runs, e.g. Wolberg, Digital Image Warping is a classic - if you like hacking on pixel processing, there's some nifty stuff to do still (I'd also love to have basebmp used for those things some more, avoiding virtual function / callback calls for every pixel). Want to poke me on irc for some pointers? Cheers, -- Thorsten pgpB0u2bnjjgd.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Help in fixing gradient bug
Aakriti Gupta wrote: When I open the ppt (which has an embedded Visio document) in Impress, the object is rendered incomplete, i.e. the text shows but not the rectangles and arrows. Hi Fridrich, Aakriti Gupta, I forgot - is that document available somewhere already? Otherwise Fridrich is the expert for all things visio. ;) Cheers, -- Thorsten pgpImXlNPDwM3.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#50871 BUGZILLAASSISTANT: Help Linguistic PDF Export not available
Rainer Bielefeld píše v Út 26. 06. 2012 v 18:19 +0200: Petr Mladek schrieb: I am a bit confused. Could I push the patch now or should I wait for some other action? Hi Petr, if there are no 3rd parties concerns Patches generally should be pushed after review with a note in the bug so that I know that it will be available for the next Assistant-Update (What I am currently planning to do for LibO 3.5.5.2.). I am still confused. I am talking about Rob's 0001-Localisation-changed-to-Localization.patch. I guess that we want to rename the component but I am not sure about the push timing. Do you need to do some changes in bugzilla first? Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 3 commits - sw/source
sw/source/filter/ww8/rtfattributeoutput.cxx | 10 -- sw/source/filter/ww8/rtfattributeoutput.hxx |5 + sw/source/filter/ww8/rtfexport.cxx |6 -- 3 files changed, 17 insertions(+), 4 deletions(-) New commits: commit 1f0da495692279762ecdadf918f5fbbaa576fd92 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 11:16:55 2012 +0200 fdo#48335 RTF export: avoid fake page breaks on page style changes The problem was that a page break has been always exported when the page style changed -- but in case the page style changes just because of first page-like styles, we don't need that. Change-Id: I15527c8d3a2d1c441b4817cf94d61ea68dc5f92c diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index b7bbf22..6e9c8b2 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -350,6 +350,8 @@ void RtfAttributeOutput::StartParagraphProperties( const SwTxtNode rNode ) { const SwTxtNode* pTxtNode = static_cast SwTxtNode* ( aNextIndex.GetNode() ); m_rExport.OutputSectionBreaks( pTxtNode-GetpSwAttrSet(), *pTxtNode ); +// Save the current page description for now, so later we will be able to access the previous one. +m_pPrevPageDesc = pTxtNode-FindPageDesc(sal_False); } else if ( aNextIndex.GetNode().IsTableNode() ) { @@ -3032,7 +3034,8 @@ RtfAttributeOutput::RtfAttributeOutput( RtfExport rExport ) m_bTableRowEnded( false ), m_aCells(), m_bSingleEmptyRun(false), -m_bInRun(false) +m_bInRun(false), +m_pPrevPageDesc(0) { SAL_INFO(sw.rtf, OSL_THIS_FUNC); } diff --git a/sw/source/filter/ww8/rtfattributeoutput.hxx b/sw/source/filter/ww8/rtfattributeoutput.hxx index a17bcca..2b67cc8 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.hxx +++ b/sw/source/filter/ww8/rtfattributeoutput.hxx @@ -556,6 +556,9 @@ public: rtl::OStringBuffer m_aTabStop; +/// Access to the page style of the previous paragraph. +const SwPageDesc* m_pPrevPageDesc; + // These are used by wwFont::WriteRtf() /// Start the font. void StartFont( const String rFamilyName ) const; diff --git a/sw/source/filter/ww8/rtfexport.cxx b/sw/source/filter/ww8/rtfexport.cxx index eca168e..5636e8d 100644 --- a/sw/source/filter/ww8/rtfexport.cxx +++ b/sw/source/filter/ww8/rtfexport.cxx @@ -708,7 +708,9 @@ void RtfExport::PrepareNewPageDesc( const SfxItemSet* pSet, else if ( pNewPgDesc ) m_pSections-AppendSection( pNewPgDesc, rNd, pFmt, nLnNm ); -AttrOutput().SectionBreak( msword::PageBreak, m_pSections-CurrentSectionInfo() ); +// Don't insert a page break, when we're changing page style just because the next page has to be a different one. +if (!m_pAttrOutput-m_pPrevPageDesc || m_pAttrOutput-m_pPrevPageDesc-GetFollow() != pNewPgDesc) +AttrOutput().SectionBreak( msword::PageBreak, m_pSections-CurrentSectionInfo() ); } bool RtfExport::DisallowInheritingOutlineNumbering( const SwFmt rFmt ) commit 6556179c639cf9db5b33bb405e969fb6bbc458a2 Author: Miklos Vajna vmik...@suse.cz Date: Tue Jun 26 16:52:04 2012 +0200 fdo#48335 don't export zoom factor when zoom type is not percent Change-Id: I1fb7e3d9d65f2f3388bb4851f5ad517ed1681f04 diff --git a/sw/source/filter/ww8/rtfexport.cxx b/sw/source/filter/ww8/rtfexport.cxx index efcea5b..eca168e 100644 --- a/sw/source/filter/ww8/rtfexport.cxx +++ b/sw/source/filter/ww8/rtfexport.cxx @@ -508,7 +508,7 @@ void RtfExport::ExportDocument_Impl() Strm() m_pAttrOutput-m_aTabStop.makeStringAndClear().getStr() sNewLine; // Zoom ViewShell *pViewShell(pDoc-GetCurrentViewShell()); -if (pViewShell) +if (pViewShell pViewShell-GetViewOptions()-GetZoomType() == SVX_ZOOM_PERCENT) { Strm() OOO_STRING_SVTOOLS_RTF_VIEWSCALE; OutULong(pViewShell-GetViewOptions()-GetZoom()); commit 9537551a49d5f221e87a0e2b42ef973c58e542c8 Author: Miklos Vajna vmik...@suse.cz Date: Tue Jun 26 16:39:17 2012 +0200 fdo#48335 RTF export: don't try to end not started runs Change-Id: I022556acd0891cf24963d667d34f366496453630 diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 9380cca..b7bbf22 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -383,6 +383,7 @@ void RtfAttributeOutput::StartRun( const SwRedlineData* pRedlineData, bool bSing { SAL_INFO(sw.rtf, OSL_THIS_FUNC); +m_bInRun = true; m_bSingleEmptyRun = bSingleEmptyRun; if (!m_bSingleEmptyRun) m_aRun-append('{'); @@ -398,8 +399,9 @@ void RtfAttributeOutput::EndRun() SAL_INFO(sw.rtf, OSL_THIS_FUNC); m_aRun-append(m_rExport.sNewLine); m_aRun.appendAndClear(m_aRunText); -if (!m_bSingleEmptyRun) +if (!m_bSingleEmptyRun m_bInRun)
[Libreoffice-commits] Changes to 'refs/tags/ooo/OOO340_m0'
Tag 'ooo/OOO340_m0' created by Jan Holesovsky ke...@suse.cz at 2012-06-27 14:28 -0700 merged tag ooo/OOO340_m0 from old repositories -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAk/rCoMACgkQ3NffDXVGNbFbcgCeK70gY0iguBJR9WmFdLoOn+BO ZtkAn0Pltj4xyzebthUPIkAr0WIHO9mr =jT57 -END PGP SIGNATURE- Changes since ooo/DEV300_m106: Ivo Hinkelmann (2): masterfix DEV300: #i1# SRC_ROOT - SOLARSRC masterfix DEV300: #i1# add cairo to build type Jan Holesovsky (1): merged tag ooo/OOO340_m0 Kurt Zenker (12): masterfix: #i1# rename sdev300.ini into sooo340.ini for new release branch OOO340 masterfix: #i1# set WITH_LANG to all languages #i1# enable crash reporter for MWS build OOO340 masterfix: #i1# adaptions for beta release masterfix: #i1# add dependency to sltport masterfix: #i1# ns has been renamed to nso (see i117489) masterfix: #i1# added -L%SYSBASE%/lib for linux to SOLAREXTRALIB masterfix OOO340: #i117696# do not write fo:margin masterfix OOO340: #i1# add .pdb and .ilk files to deliver masterfix OOO340: #i117701# prevent warning in xmlitem.cxx masterfix OOO340: #i1# add dependency to *.src files in AllLangResTarget.mk --- cairo/cairo-1.8.0.patch|4 cairo/prj/build.lst|2 instsetoo_native/util/pack.lst |4 solenv/config/sdev300.ini | 3483 solenv/config/sooo340.ini | 3485 + solenv/gbuild/AllLangResTarget.mk |1 solenv/gbuild/platform/windows.mk |2 solenv/inc/minor.mk| 10 sw/source/filter/xml/xmlitemm.cxx |2 xmloff/source/style/PageMasterExportPropMapper.cxx | 22 10 files changed, 3500 insertions(+), 3515 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/ooo/OOO340_m1'
Tag 'ooo/OOO340_m1' created by Jan Holesovsky ke...@suse.cz at 2012-06-27 14:40 -0700 merged tag ooo/OOO340_m1 from old repositories -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAk/rDWMACgkQ3NffDXVGNbH1VwCdHAUZZQzPAJxW2K6AG9B/Y6QX TAsAoJy7XBERMavLg4EeMX1OMnXwtHE+ =hlo2 -END PGP SIGNATURE- Changes since ooo/OOO340_m0: Andre Fischer (12): impress211: #i115688# Forwarding result of ::Window::Notify(). impress211: #i114732# Revoke comphelper notification client only when it was previously registered. impress211: #i116339# Added call to Reschedule to compensate for missing yield. impress211: #i0# Fixed dragging of slides from navigator to slide sorter. impress211: #i110990# Fixed slide show spanning multiple displays on Windows. impress211: #i116911# Accept -1 as special value for multi monitor support. impress211: #i110990# Fixed remaining problems with display ids and indices. impress211: #i110990# Fixed remaining problems with display ids and indices. impress211: #i110990# Fixed slide show spanning multiple displays on Windows. impress211: #i110990# Fixed slide show spanning multiple displays on Windows. impress211: #i110990# Fixed 64bit compiler problem. impress211: #i110990# Increased version number (micro) of presenter screen extension to 1.1.1. Armin Le Grand (5): aw084: #i112978# use GetAllMarkedBoundRect instead of GetAllMarkedRect to get fat line support aw084: #i116802# Removing DBG_UNHANDLED_EXCEPTION since there is a valuable alternative alailable and not a general error happening aw084: #i108052# Added code to mimic old behaviour and call user layout link when empty paragraph is rendered aw084: resync to DEV300_m104 aw084: resync to DEV300_m104 Christian Lippka ORACLE (32): impressdefaults1: #i115996# change default bullet symbol order from 'Oo-' in 'O-O-O' inside text objects impress210: #i116846# adding uncommited changes from cws impressdefautls1 impress210: #i116846# adding uncommited changes from cws impressdefautls1 impress210: #i116846# adding uncommited changes from cws impressdefautls1 impress210: #i116846# added missing commits from cws impressdefaults1 impress210: merge impress210: merge impress210: #i50899# clean up fill attributes if fill style changes impress210: #i50899# clean up fill attributes if fill style changes impress210: #i116847# added CTRL-ALT-C as shortcut for inserting comments in calc impress210: #i41995# fixed distinct shape and page id impress210: #i41995# fixed import of path animation from sxi files impress210: #i41995# fixed import of path animation from sxi files impress210: #i41995# fixed import of path animation from sxi files impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents impress210: #i117133# put new drawing layer fill and stroke styles in pool only for newly created documents impress210: #i117319# disconnect and reconnect to table style on change model in SdrTableObjImpl impress210: merge impress210: merge impress210: merge impress210: merge impress210: merge impress210: merge impress210: merge impress210: merge impress210: #i41995# using view contact to get bound rect for old path animation import impress210: #i41995# using view contact to get bound rect for old path animation import impress210: #i41995# using view contact to get bound rect for old path animation import impress210: fixed solaris compile warning Daniel Rentz [dr] (20): dr80: #i164410# optimized cell allocation in XCellRangeData::setDataArray() to improve performance of import filters dr80: #i117388# do not try to access nonexisting document dr80: rebase to DEV300_m102 dr80: rebase to DEV300_m102 dr80: rebase to DEV300_m102 dr80: rebase to DEV300_m102 dr80: #i117418# compiler warning: OptValueT::maValue needs to be value-initializedinc dr80: #i117392# initialize VBAGlobals object if single Basic module is in VBA mode, do not expect existing parent sheet in implementation of Excel.Application.ActiveCell dr80: #i117392# initialize VBAGlobals object if single Basic module is in VBA mode, do not expect existing parent sheet in implementation of Excel.Application.ActiveCell dr80: branch merge dr80: branch merge dr80: #i117506# byvalue-byref dr80: #i117511# remove some
[ANN] LibreOffice 3.5.5 RC2 test builds available
Hi *, for the upcoming new version 3.5.5, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 3.5.5, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 3.5.5 RC1 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-5-release-3.5.5.2.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] LibreOffice 3.5.5 RC2 test builds available
Hi, On Wed, Jun 27, 2012 at 04:15:18PM +0200, Fridrich Strba wrote: Hi *, for the upcoming new version 3.5.5, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 3.5.5, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: Ubuntu users wanting to test 3.5.5~rc2 can download a build right now at: https://launchpad.net/~bjoern-michaelsen/+archive/libreoffice-precisetest-20120327 the same source package has been pushed to: https://launchpad.net/~libreoffice/+archive/ppa?field.series_filter=precise and will finish building there in some ~5 hours, making it available to all people who have enabled the LibreOffice PPA. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: android/experimental
android/experimental/DocumentLoader/AndroidManifest.xml |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit c793a57f54d3649198928f928180515e0dd1bfad Author: Tor Lillqvist tlillqv...@suse.com Date: Wed Jun 27 17:07:53 2012 +0300 Use largeHeap and hardwareAccelerated (quite visible improvement) Change-Id: I853ab39599fdc8d1b1eae5d2b2748f39535ebf64 diff --git a/android/experimental/DocumentLoader/AndroidManifest.xml b/android/experimental/DocumentLoader/AndroidManifest.xml index e3001d6..b231011 100644 --- a/android/experimental/DocumentLoader/AndroidManifest.xml +++ b/android/experimental/DocumentLoader/AndroidManifest.xml @@ -1,11 +1,13 @@ -?xml version=1.0 encoding=utf-8? +?xml version=1.0 encoding=utf-8? !-- -*- indent-tabs-mode: nil -*- -- manifest xmlns:android=http://schemas.android.com/apk/res/android; package=org.libreoffice.android.examples android:versionCode=1 android:versionName=1.0 uses-sdk android:minSdkVersion=9 / application android:label=LO Experimental DocumentLoader - android:debuggable=true + android:debuggable=true + android:largeHeap=true + android:hardwareAccelerated=true activity android:name=.DocumentLoader android:label=LO DocumentLoader android:configChanges=orientation|keyboardHidden @@ -16,3 +18,4 @@ /activity /application /manifest +!-- vim:set expandtab: -- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/source
sc/source/core/tool/interpr1.cxx | 17 +++-- sc/source/core/tool/interpr4.cxx |7 +++ 2 files changed, 14 insertions(+), 10 deletions(-) New commits: commit b709845e27db0f439c430c9ebe3c2884dbc48789 Author: Eike Rathke er...@redhat.com Date: Wed Jun 27 16:29:02 2012 +0200 resolved fdo#51478 handle array context in T() Note that Excel for T() does not use position dependent range intersection (SingleRef of DoubleRef) when a range reference is passed and does not handle evaluation in array context (instead top left value is always used), which both is inconsistent with other functions taking a scalar value parameter. ODFF does not specify this function different. range intersection was already implemented, this change adds array evaluation. Gnumeric does the same. Change-Id: I4acae943fde247c6d60b55d0f8514fb17d401f40 diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index a7f6572..2508b25 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -3082,20 +3082,17 @@ void ScInterpreter::ScT() } } break; +case svMatrix: case svExternalSingleRef: case svExternalDoubleRef: { -ScMatrixRef pMat = GetMatrix(); -if (!pMat || !pMat-GetElementCount()) -{ -SetError( errIllegalParameter); -break; -} - -if (pMat-IsString(0, 0)) -PushString(pMat-GetString(0, 0)); +double fVal; +String aStr; +ScMatValType nMatValType = GetDoubleOrStringFromMatrix( fVal, aStr); +if (ScMatrix::IsValueType( nMatValType)) +PushString( EMPTY_STRING); else -PushString(EMPTY_STRING); +PushString( aStr); } break; case svDouble : commit 72b4cb18a402338dd65d24d9da8da7fe0fa33db0 Author: Eike Rathke er...@redhat.com Date: Wed Jun 27 16:15:05 2012 +0200 propagate error in ScInterpreter::GetDoubleOrStringFromMatrix() Change-Id: Iadba0f3a28b0a3bda9b99833510e68679d915514 diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index 08d9acc..bca2977 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -2451,6 +2451,13 @@ ScMatValType ScInterpreter::GetDoubleOrStringFromMatrix( double rDouble, else rString = nMatVal.GetString(); +if (ScMatrix::IsValueType( nMatValType)) +{ +sal_uInt16 nError = nMatVal.GetError(); +if (nError) +SetError( nError); +} + return nMatValType; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Including a patch from AOO...
Hi Michael, thanks for the explanations. On 27.06.2012 13:56, Michael Meeks wrote: Please just re-implement the fix in a different way - and/or if this is a really key-fix we can re-base that one file in 3.6. I am scratching my head - how could one re-implement + if (A !B) - if (A B) or any other trivial fix? I believe the following logic-manipulating approach is pure dotage: + if (A !B) - if (A !(!B)) + if (A !B) - if (!(!A || !B)) isn't it? :) Or one need to rewrite UndoManager... I don't know if the patch can be considered a key-fix, the bug title is: Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc) (you know, it depends on the definition of the key-fix... :) From my point of view it can, but I am an inveterate bug-hater. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/tubes2' - 6 commits - officecfg/registry sc/inc sc/sdi sc/source sc/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |5 sc/inc/sc.hrc |1 sc/sdi/cellsh.sdi |1 sc/sdi/scalc.sdi | 25 sc/source/ui/collab/contacts.cxx | 76 + sc/source/ui/collab/contacts.hrc |2 sc/source/ui/collab/contacts.src | 14 sc/source/ui/collab/sendfunc.cxx | 627 +++--- sc/source/ui/collab/sendfunc.hxx | 267 sc/source/ui/view/cellsh3.cxx | 13 sc/uiconfig/scalc/menubar/menubar.xml |2 11 files changed, 605 insertions(+), 428 deletions(-) New commits: commit b711bcff8a93ff751d555e49f73b424a4e7ab1b4 Author: Matúš Kukan matus.ku...@gmail.com Date: Sat Jun 16 22:52:18 2012 +0200 tubes: add listen button to start TeleManager No more need to run soffice with LIBO_TUBES set. diff --git a/sc/source/ui/collab/contacts.cxx b/sc/source/ui/collab/contacts.cxx index 44821a5..085237b 100644 --- a/sc/source/ui/collab/contacts.cxx +++ b/sc/source/ui/collab/contacts.cxx @@ -30,6 +30,8 @@ #include vector #include contacts.hrc +#include sendfunc.hxx +#include docsh.hxx #include scresid.hxx #include svtools/filter.hxx #include tubes/manager.hxx @@ -45,10 +47,12 @@ class TubeContacts : public ModelessDialog { FixedLine maLabel; PushButton maBtnConnect; +PushButton maBtnListen; SvxSimpleTableContainer maListContainer; SvxSimpleTable maList; DECL_LINK( BtnConnectHdl, void * ); +DECL_LINK( BtnListenHdl, void * ); struct AccountContact { @@ -59,6 +63,22 @@ class TubeContacts : public ModelessDialog }; boost::ptr_vectorAccountContact maACs; +void Listen() +{ +ScDocShell *pScDocShell = reinterpret_castScDocShell* (SfxObjectShell::Current()); +ScDocFunc *pDocFunc = pScDocShell ? pScDocShell-GetDocFunc() : NULL; +ScDocFuncSend *pSender = reinterpret_castScDocFuncSend* (pDocFunc); +if (!pSender) +{ +delete pDocFunc; +boost::shared_ptrScDocFuncDirect pDirect( new ScDocFuncDirect( *pScDocShell ) ); +boost::shared_ptrScDocFuncRecv pReceiver( new ScDocFuncRecv( pDirect ) ); +pSender = new ScDocFuncSend( *pScDocShell, pReceiver ); +pDocFunc = pSender; +} +pSender-InitTeleManager( false ); +} + void StartBuddySession() { AccountContact *pAC = NULL; @@ -83,10 +103,12 @@ public: ModelessDialog( NULL, ScResId( RID_SCDLG_CONTACTS ) ), maLabel( this, ScResId( FL_LABEL ) ), maBtnConnect( this, ScResId( BTN_CONNECT ) ), +maBtnListen( this, ScResId( BTN_LISTEN ) ), maListContainer( this, ScResId( CTL_LIST ) ), maList( maListContainer ) { maBtnConnect.SetClickHdl( LINK( this, TubeContacts, BtnConnectHdl ) ); +maBtnListen.SetClickHdl( LINK( this, TubeContacts, BtnListenHdl ) ); static long aStaticTabs[]= { @@ -160,6 +182,13 @@ IMPL_LINK_NOARG( TubeContacts, BtnConnectHdl ) return 0; } +IMPL_LINK_NOARG( TubeContacts, BtnListenHdl ) +{ +Listen(); +Close(); +return 0; +} + } // anonymous namespace #endif diff --git a/sc/source/ui/collab/contacts.hrc b/sc/source/ui/collab/contacts.hrc index dd3fcc4..cb69916 100644 --- a/sc/source/ui/collab/contacts.hrc +++ b/sc/source/ui/collab/contacts.hrc @@ -3,6 +3,7 @@ #define FL_LABEL 1 #define CTL_LIST 2 #define BTN_CONNECT 3 +#define BTN_LISTEN 4 #define STR_HEADER_ALIAS 20 #define STR_HEADER_NAME 21 diff --git a/sc/source/ui/collab/contacts.src b/sc/source/ui/collab/contacts.src index 1689823..0de2849 100644 --- a/sc/source/ui/collab/contacts.src +++ b/sc/source/ui/collab/contacts.src @@ -21,10 +21,16 @@ ModelessDialog RID_SCDLG_CONTACTS }; PushButton BTN_CONNECT { -Pos = MAP_APPFONT( 8 , 200 ); +Pos = MAP_APPFONT( 70 , 200 ); Size = MAP_APPFONT( 50 , 10 ); Text [ en-US ] = Collaborate; }; +PushButton BTN_LISTEN +{ +Pos = MAP_APPFONT( 8 , 200 ); +Size = MAP_APPFONT( 50 , 10 ); +Text [ en-US ] = Listen; +}; Control CTL_LIST { Pos = MAP_APPFONT ( 8 , 10 ) ; commit 6d74d44900a8dfb80a78fb81af4dccdf11cc47fd Author: Matúš Kukan matus.ku...@gmail.com Date: Mon Jun 18 23:15:04 2012 +0200 tubes: create InitTeleManager method diff --git a/sc/source/ui/collab/sendfunc.cxx b/sc/source/ui/collab/sendfunc.cxx index ee623e4..262273d 100644 --- a/sc/source/ui/collab/sendfunc.cxx +++
[Libreoffice-commits] .: writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 16:59:24 2012 +0200 n#693238 dmapper: fix margin values vs SBkc = 0 at the end of the doc The problem was that a continous section break at the end of the document caused the section margins to be ignored. Just ignoring the continous section break (only in case it's at the end of the document) makes the problem go away. The original fix was commit cd1c434c4bd4756fa1355e906cb2e8de4aae0618, but it got reverted in commit 2dee7d6205832a1212790ac1ab168a6b6fce686d, as it caused fdo#44292. This second attempt fixes the original bug again, without introducing the 4 columns bug. Change-Id: I75d612430a5cd631dec0d224127cba580070900d diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 5ecceba..ac52d07 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -2369,7 +2369,12 @@ void DomainMapper::sprmWithProps( Sprm rSprm, PropertyMapPtr rContext, SprmType */ OSL_ENSURE(pSectionContext, SectionContext unavailable!); if(pSectionContext) -pSectionContext-SetBreakType( nIntValue ); +{ +// Ignore continous section break at the end of the document +// It makes the importer loose margin settings with no benefit +if (m_pImpl-GetParaSectpr() || nIntValue != 0) +pSectionContext-SetBreakType( nIntValue ); +} break; case 143: case NS_sprm::LN_SFTitlePage: // sprmSFTitlePage ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - fpicker/source ucb/source
fpicker/source/office/PlacesListBox.cxx | 29 - fpicker/source/office/PlacesListBox.hxx |8 +++- ucb/source/ucp/cmis/cmis_content.cxx|6 +++--- ucb/source/ucp/cmis/cmis_url.cxx|9 +++-- ucb/source/ucp/cmis/cmis_url.hxx|5 +++-- 5 files changed, 44 insertions(+), 13 deletions(-) New commits: commit 704d7023f06342c2577a79957ae357e7f9eb22af Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jun 27 17:04:34 2012 +0200 fpicker: when selecting a place, update the URL outside the selection handler If the file view URL open happens during the selection, that protentially lengthy and blocking process (auth dialog) will block the arrival of the MouseButtonUp even... and thus allowing to select items in the places list box simply by placing the mouse over them. To fix that, the URL is updated in the file view after the MouseButtonUp even. Change-Id: I0fddeb303ec9c91aef2b46592198540d6ac5c4c3 diff --git a/fpicker/source/office/PlacesListBox.cxx b/fpicker/source/office/PlacesListBox.cxx index c763b1d..f8e438d 100644 --- a/fpicker/source/office/PlacesListBox.cxx +++ b/fpicker/source/office/PlacesListBox.cxx @@ -38,9 +38,10 @@ using rtl::OUString; -PlacesListBox_Impl::PlacesListBox_Impl( Window* pParent, const rtl::OUString rTitle ) : +PlacesListBox_Impl::PlacesListBox_Impl( PlacesListBox* pParent, const rtl::OUString rTitle ) : SvHeaderTabListBox( pParent, WB_TABSTOP | WB_NOINITIALSELECTION ), -mpHeaderBar( NULL ) +mpHeaderBar( NULL ), +mpParent( pParent ) { Size aBoxSize = pParent-GetSizePixel( ); mpHeaderBar = new HeaderBar( pParent, WB_BUTTONSTYLE | WB_BOTTOMBORDER ); @@ -63,6 +64,13 @@ PlacesListBox_Impl::PlacesListBox_Impl( Window* pParent, const rtl::OUString rT PlacesListBox_Impl::~PlacesListBox_Impl( ) { delete mpHeaderBar; +mpParent = NULL; +} + +void PlacesListBox_Impl::MouseButtonUp( const MouseEvent rMEvt ) +{ +SvHeaderTabListBox::MouseButtonUp( rMEvt ); +mpParent-updateView( ); } PlacesListBox::PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTitle, const ResId rResId ) : @@ -71,7 +79,8 @@ PlacesListBox::PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTit mpDlg( pFileDlg ), mpImpl( NULL ), mnNbEditables( 0 ), -mbUpdated( false ) +mbUpdated( false ), +mbSelectionChanged( false ) { mpImpl = new PlacesListBox_Impl( this, rTitle ); @@ -149,8 +158,7 @@ IMPL_LINK( PlacesListBox, Selection, void* , EMPTYARG ) sal_uInt32 nSelected = mpImpl-GetCurrRow(); PlacePtr pPlace = maPlaces[nSelected]; -mpDlg-OpenURL_Impl( pPlace-GetUrl() ); - +mbSelectionChanged = true; if(pPlace-IsEditable()) mpDlg-RemovablePlaceSelected(); else @@ -186,4 +194,15 @@ IMPL_LINK ( PlacesListBox, DoubleClick, void*, EMPTYARG ) return 0; } +void PlacesListBox::updateView( ) +{ +if ( mbSelectionChanged ) +{ +mbSelectionChanged = false; +sal_uInt32 nSelected = mpImpl-GetCurrRow(); +PlacePtr pPlace = maPlaces[nSelected]; +mpDlg-OpenURL_Impl( pPlace-GetUrl( ) ); +} +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/fpicker/source/office/PlacesListBox.hxx b/fpicker/source/office/PlacesListBox.hxx index 74ae8e7..49dc83e 100644 --- a/fpicker/source/office/PlacesListBox.hxx +++ b/fpicker/source/office/PlacesListBox.hxx @@ -69,14 +69,18 @@ class Place typedef boost::shared_ptr Place PlacePtr; +class PlacesListBox; class PlacesListBox_Impl : public SvHeaderTabListBox { private: HeaderBar* mpHeaderBar; +PlacesListBox* mpParent; public: -PlacesListBox_Impl( Window* pParent, const rtl::OUString rTitle ); +PlacesListBox_Impl( PlacesListBox* pParent, const rtl::OUString rTitle ); ~PlacesListBox_Impl( ); + +virtual void MouseButtonUp( const MouseEvent rMEvt ); }; /** ListBox to handle Places. @@ -89,6 +93,7 @@ class PlacesListBox : public Control PlacesListBox_Impl* mpImpl; sal_Int32mnNbEditables; bool mbUpdated; +bool mbSelectionChanged; public: PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTitle, const ResId rResId ); @@ -102,6 +107,7 @@ class PlacesListBox : public Control const std::vectorPlacePtr GetPlaces(); void SetSizePixel( const Size rNewSize ); +void updateView( ); private: commit 6c71f41174fe45e78720ba049e60477735107b9d Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jun 27 13:44:47 2012 +0200 CMIS UCP: session cache, better use the binding URL + repo Id as id There may be cases where we have the host part of the URL encoded differently... and thus trigerring the creation of another session when it's not
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - fpicker/source ucb/source
fpicker/source/office/PlacesListBox.cxx | 29 - fpicker/source/office/PlacesListBox.hxx |8 +++- ucb/source/ucp/cmis/cmis_content.cxx|6 +++--- ucb/source/ucp/cmis/cmis_url.cxx|9 +++-- ucb/source/ucp/cmis/cmis_url.hxx|5 +++-- 5 files changed, 44 insertions(+), 13 deletions(-) New commits: commit 35ab4087992581104cae28f45b6be97fb1212213 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jun 27 17:04:34 2012 +0200 fpicker: when selecting a place, update the URL outside the selection handler If the file view URL open happens during the selection, that protentially lengthy and blocking process (auth dialog) will block the arrival of the MouseButtonUp even... and thus allowing to select items in the places list box simply by placing the mouse over them. To fix that, the URL is updated in the file view after the MouseButtonUp even. Change-Id: I0fddeb303ec9c91aef2b46592198540d6ac5c4c3 diff --git a/fpicker/source/office/PlacesListBox.cxx b/fpicker/source/office/PlacesListBox.cxx index c763b1d..f8e438d 100644 --- a/fpicker/source/office/PlacesListBox.cxx +++ b/fpicker/source/office/PlacesListBox.cxx @@ -38,9 +38,10 @@ using rtl::OUString; -PlacesListBox_Impl::PlacesListBox_Impl( Window* pParent, const rtl::OUString rTitle ) : +PlacesListBox_Impl::PlacesListBox_Impl( PlacesListBox* pParent, const rtl::OUString rTitle ) : SvHeaderTabListBox( pParent, WB_TABSTOP | WB_NOINITIALSELECTION ), -mpHeaderBar( NULL ) +mpHeaderBar( NULL ), +mpParent( pParent ) { Size aBoxSize = pParent-GetSizePixel( ); mpHeaderBar = new HeaderBar( pParent, WB_BUTTONSTYLE | WB_BOTTOMBORDER ); @@ -63,6 +64,13 @@ PlacesListBox_Impl::PlacesListBox_Impl( Window* pParent, const rtl::OUString rT PlacesListBox_Impl::~PlacesListBox_Impl( ) { delete mpHeaderBar; +mpParent = NULL; +} + +void PlacesListBox_Impl::MouseButtonUp( const MouseEvent rMEvt ) +{ +SvHeaderTabListBox::MouseButtonUp( rMEvt ); +mpParent-updateView( ); } PlacesListBox::PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTitle, const ResId rResId ) : @@ -71,7 +79,8 @@ PlacesListBox::PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTit mpDlg( pFileDlg ), mpImpl( NULL ), mnNbEditables( 0 ), -mbUpdated( false ) +mbUpdated( false ), +mbSelectionChanged( false ) { mpImpl = new PlacesListBox_Impl( this, rTitle ); @@ -149,8 +158,7 @@ IMPL_LINK( PlacesListBox, Selection, void* , EMPTYARG ) sal_uInt32 nSelected = mpImpl-GetCurrRow(); PlacePtr pPlace = maPlaces[nSelected]; -mpDlg-OpenURL_Impl( pPlace-GetUrl() ); - +mbSelectionChanged = true; if(pPlace-IsEditable()) mpDlg-RemovablePlaceSelected(); else @@ -186,4 +194,15 @@ IMPL_LINK ( PlacesListBox, DoubleClick, void*, EMPTYARG ) return 0; } +void PlacesListBox::updateView( ) +{ +if ( mbSelectionChanged ) +{ +mbSelectionChanged = false; +sal_uInt32 nSelected = mpImpl-GetCurrRow(); +PlacePtr pPlace = maPlaces[nSelected]; +mpDlg-OpenURL_Impl( pPlace-GetUrl( ) ); +} +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/fpicker/source/office/PlacesListBox.hxx b/fpicker/source/office/PlacesListBox.hxx index 74ae8e7..49dc83e 100644 --- a/fpicker/source/office/PlacesListBox.hxx +++ b/fpicker/source/office/PlacesListBox.hxx @@ -69,14 +69,18 @@ class Place typedef boost::shared_ptr Place PlacePtr; +class PlacesListBox; class PlacesListBox_Impl : public SvHeaderTabListBox { private: HeaderBar* mpHeaderBar; +PlacesListBox* mpParent; public: -PlacesListBox_Impl( Window* pParent, const rtl::OUString rTitle ); +PlacesListBox_Impl( PlacesListBox* pParent, const rtl::OUString rTitle ); ~PlacesListBox_Impl( ); + +virtual void MouseButtonUp( const MouseEvent rMEvt ); }; /** ListBox to handle Places. @@ -89,6 +93,7 @@ class PlacesListBox : public Control PlacesListBox_Impl* mpImpl; sal_Int32mnNbEditables; bool mbUpdated; +bool mbSelectionChanged; public: PlacesListBox( SvtFileDialog* pFileDlg, const rtl::OUString rTitle, const ResId rResId ); @@ -102,6 +107,7 @@ class PlacesListBox : public Control const std::vectorPlacePtr GetPlaces(); void SetSizePixel( const Size rNewSize ); +void updateView( ); private: commit ee6008603a59693a596d6fc1bb6a3320ba7d2940 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jun 27 13:44:47 2012 +0200 CMIS UCP: session cache, better use the binding URL + repo Id as id There may be cases where we have the host part of the URL encoded differently... and thus trigerring the creation of another session when it's not
Re: [GSoC 2012][Collaboration] status + screenshot
Hi Eike, On 19 June 2012 14:59, Eike Rathke er...@redhat.com wrote: .. the AccountContact struct seems ok to me. However, I'm missing the destruction of the created instances, this looks like a memory leak. I changed it to use boost::ptr_vector [1]. Are the instances going to be destroyed then ? I don't have experience with boost. Best, Matus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/tubes2id=809e1014f554175083d0b965c6744854a240f5b3 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
RE: Including a patch from AOO...
I'm rather fond of if (A ? !B : A) myself [;). I agree. if (A !B) is functional and a trifle. This is not a legal opinion. But if anyone on AOOi is angry about it, it will just make us look ridiculous. There is no lack of opportunities for us to do that without getting this fussy about something that is good for all of us to handle properly. Providing attribution to the AOOi bugzilla and/or fix might be nice. - Dennis -Original Message- From: libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm@lists.freedesktop.org] On Behalf Of Ivan Timofeev Sent: Wednesday, June 27, 2012 08:20 To: michael.me...@suse.com Cc: Michael Stahl; libreoffice@lists.freedesktop.org Subject: Re: Including a patch from AOO... Hi Michael, thanks for the explanations. On 27.06.2012 13:56, Michael Meeks wrote: Please just re-implement the fix in a different way - and/or if this is a really key-fix we can re-base that one file in 3.6. I am scratching my head - how could one re-implement + if (A !B) - if (A B) or any other trivial fix? I believe the following logic-manipulating approach is pure dotage: + if (A !B) - if (A !(!B)) + if (A !B) - if (!(!A || !B)) isn't it? :) Or one need to rewrite UndoManager... I don't know if the patch can be considered a key-fix, the bug title is: Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc) (you know, it depends on the definition of the key-fix... :) From my point of view it can, but I am an inveterate bug-hater. Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/qa
sw/qa/extras/ooxmltok/data/n693238.docx |binary sw/qa/extras/ooxmltok/ooxmltok.cxx | 17 + 2 files changed, 17 insertions(+) New commits: commit 85524805bd730e31c1bfc2fd9e449e10e4e6bae1 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 17:40:07 2012 +0200 n#693238 testcase Change-Id: I7093d7d27d2448601bd29c2f3dd0c42077115b80 diff --git a/sw/qa/extras/ooxmltok/data/n693238.docx b/sw/qa/extras/ooxmltok/data/n693238.docx new file mode 100644 index 000..5bcda0f Binary files /dev/null and b/sw/qa/extras/ooxmltok/data/n693238.docx differ diff --git a/sw/qa/extras/ooxmltok/ooxmltok.cxx b/sw/qa/extras/ooxmltok/ooxmltok.cxx index ce4a911..790194d 100644 --- a/sw/qa/extras/ooxmltok/ooxmltok.cxx +++ b/sw/qa/extras/ooxmltok/ooxmltok.cxx @@ -75,6 +75,7 @@ public: void testN758883(); void testN766481(); void testN766487(); +void testN693238(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -98,6 +99,7 @@ public: CPPUNIT_TEST(testN758883); CPPUNIT_TEST(testN766481); CPPUNIT_TEST(testN766487); +CPPUNIT_TEST(testN693238); #endif CPPUNIT_TEST_SUITE_END(); @@ -661,6 +663,21 @@ void Test::testN766487() CPPUNIT_ASSERT_EQUAL(sal_Int32(TWIP_TO_MM100(-360)), nValue); } +void Test::testN693238() +{ +/* + * + * The problem was that a continous section break at the end of the doc caused the margins to be ignored. + * + * xray ThisComponent.StyleFamilies.PageStyles.Default.LeftMargin ' was 2000, should be 635 + */ +load(n693238.docx); +uno::Referencebeans::XPropertySet xPropertySet(getStyles(PageStyles)-getByName(Default), uno::UNO_QUERY); +sal_Int32 nValue = 0; +xPropertySet-getPropertyValue(LeftMargin) = nValue; +CPPUNIT_ASSERT_EQUAL(sal_Int32(635), nValue); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); CPPUNIT_PLUGIN_IMPLEMENT(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit 2992b53f39ea3d61d4acbe7f7c494f90228ce377 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jun 27 16:59:24 2012 +0200 n#693238 dmapper: fix margin values vs SBkc = 0 at the end of the doc The problem was that a continous section break at the end of the document caused the section margins to be ignored. Just ignoring the continous section break (only in case it's at the end of the document) makes the problem go away. The original fix was commit cd1c434c4bd4756fa1355e906cb2e8de4aae0618, but it got reverted in commit 2dee7d6205832a1212790ac1ab168a6b6fce686d, as it caused fdo#44292. This second attempt fixes the original bug again, without introducing the 4 columns bug. Change-Id: I75d612430a5cd631dec0d224127cba580070900d diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index 5ecceba..ac52d07 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -2369,7 +2369,12 @@ void DomainMapper::sprmWithProps( Sprm rSprm, PropertyMapPtr rContext, SprmType */ OSL_ENSURE(pSectionContext, SectionContext unavailable!); if(pSectionContext) -pSectionContext-SetBreakType( nIntValue ); +{ +// Ignore continous section break at the end of the document +// It makes the importer loose margin settings with no benefit +if (m_pImpl-GetParaSectpr() || nIntValue != 0) +pSectionContext-SetBreakType( nIntValue ); +} break; case 143: case NS_sprm::LN_SFTitlePage: // sprmSFTitlePage ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 6 commits - connectivity/inc connectivity/source l10ntools/inc l10ntools/source svl/inc unusedcode.easy xml2cmp/source
connectivity/inc/connectivity/dbexception.hxx |1 connectivity/inc/connectivity/sqlnode.hxx |4 connectivity/source/commontools/dbexception.cxx |7 connectivity/source/inc/internalnode.hxx|3 connectivity/source/parse/internalnode.cxx | 10 connectivity/source/parse/sqlnode.cxx | 13 - l10ntools/inc/xmlparse.hxx |4 l10ntools/source/xmlparse.cxx | 16 - svl/inc/svl/svarray.hxx | 20 - unusedcode.easy | 294 xml2cmp/source/xcd/dependy.cxx |2 11 files changed, 10 insertions(+), 364 deletions(-) New commits: commit 887fc099c118da335e8a507db9521437f5bd2e82 Author: Caolán McNamara caol...@redhat.com Date: Wed Jun 27 16:05:33 2012 +0100 update unused code list Change-Id: I8845df6193233b268b5cce958fea9f25625c7025 diff --git a/connectivity/inc/connectivity/sqlnode.hxx b/connectivity/inc/connectivity/sqlnode.hxx index bad8ad3..e21e06e 100644 --- a/connectivity/inc/connectivity/sqlnode.hxx +++ b/connectivity/inc/connectivity/sqlnode.hxx @@ -242,10 +242,6 @@ namespace connectivity SQLNodeType eNewNodeType, sal_uInt32 nNewNodeID=0); -OSQLParseNode(const sal_Unicode* _pValue, - SQLNodeType _eNodeType, - sal_uInt32 _nNodeID = 0); - OSQLParseNode(const ::rtl::OUString _rValue, SQLNodeType _eNodeType, sal_uInt32 _nNodeID = 0); diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx index 03d096b..a2c273d 100644 --- a/connectivity/source/parse/sqlnode.cxx +++ b/connectivity/source/parse/sqlnode.cxx @@ -1559,19 +1559,6 @@ OSQLParseNode::OSQLParseNode(const ::rtl::OString _rNewValue, OSL_ENSURE(m_eNodeType = SQL_NODE_RULE m_eNodeType = SQL_NODE_CONCAT,OSQLParseNode: created with invalid NodeType); } //- -OSQLParseNode::OSQLParseNode(const sal_Unicode * pNewValue, - SQLNodeType eNewNodeType, - sal_uInt32 nNewNodeID) -:m_pParent(NULL) -,m_aNodeValue(pNewValue) -,m_eNodeType(eNewNodeType) -,m_nNodeID(nNewNodeID) -{ -RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, parse, ocke.jans...@sun.com, OSQLParseNode::OSQLParseNode ); - -OSL_ENSURE(m_eNodeType = SQL_NODE_RULE m_eNodeType = SQL_NODE_CONCAT,OSQLParseNode: created with invalid NodeType); -} -//- OSQLParseNode::OSQLParseNode(const ::rtl::OUString _rNewValue, SQLNodeType eNewNodeType, sal_uInt32 nNewNodeID) diff --git a/svl/inc/svl/svarray.hxx b/svl/inc/svl/svarray.hxx index 90428b8..0457252 100644 --- a/svl/inc/svl/svarray.hxx +++ b/svl/inc/svl/svarray.hxx @@ -412,8 +412,9 @@ void nm::DeleteAndDestroy( sal_uInt16 nP, sal_uInt16 nL )\ SV_IMPL_PTRARR_GEN(nm, AE, SvPtrarr ) typedef void* VoidPtr; -_SV_DECL_VARARR_GEN( SvPtrarr, VoidPtr, 0, 1, VoidPtr , ) -USHORT GetPos( const VoidPtr aE ) const; + +_SV_DECL_VARARR_GEN( SvPtrarr, VoidPtr, 0, VoidPtr , SVL_DLLPUBLIC ) +sal_uInt16 GetPos( const VoidPtr aE ) const; }; // SORTARR - Begin diff --git a/unusedcode.easy b/unusedcode.easy index c1b1341..dbd7661 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -255,38 +255,8 @@ _SwPamRanges_SAR::_ForEach(unsigned short, unsigned short, unsigned char (*)(SwP _SwRedlineTbl::Insert(SwRedline* const*, unsigned short) _SwRedlineTbl::Insert(_SwRedlineTbl const*, unsigned short, unsigned short) _SwRedlineTbl::Remove(SwRedline* const, unsigned short) -binfilter::B3dEdgeEntryBucketMemArr::Insert(binfilter::B3dEdgeEntryBucketMemArr const*, unsigned short, unsigned short, unsigned short) -binfilter::B3dEdgeEntryBucketMemArr::Replace(char const*, unsigned short) -binfilter::B3dEdgeEntryBucketMemArr::Replace(char const**, unsigned short, unsigned short) -binfilter::B3dEdgeEntryBucketMemArr::_ForEach(unsigned short, unsigned short, unsigned char (*)(char const*, void*), void*) -binfilter::B3dEdgeListBucketMemArr::Insert(binfilter::B3dEdgeListBucketMemArr const*, unsigned short, unsigned short, unsigned short) -binfilter::B3dEdgeListBucketMemArr::Replace(char const*, unsigned short) -binfilter::B3dEdgeListBucketMemArr::Replace(char const**, unsigned short, unsigned short) -binfilter::B3dEdgeListBucketMemArr::_ForEach(unsigned short, unsigned short, unsigned char (*)(char const*, void*), void*) -binfilter::B3dEntityBucketMemArr::Insert(binfilter::B3dEntityBucketMemArr const*, unsigned short, unsigned short, unsigned short) -binfilter::B3dEntityBucketMemArr::Replace(char const*, unsigned short) -binfilter::B3dEntityBucketMemArr::Replace(char
[Libreoffice-commits] .: 6 commits - binfilter/bf_sc binfilter/bf_sfx2 binfilter/bf_svtools binfilter/bf_sw binfilter/inc
binfilter/bf_sc/source/core/tool/sc_chgtrack.cxx | 53 - binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx| 50 - binfilter/bf_svtools/source/filerec/svt_filerec.cxx |4 binfilter/bf_svtools/source/memtools/svt_svarray.cxx | 42 - binfilter/bf_svtools/util/svt.flt|1 binfilter/bf_sw/source/core/doc/sw_docbm.cxx |2 binfilter/bf_sw/source/core/frmedt/sw_tblsel.cxx |3 binfilter/bf_sw/source/core/ole/sw_ndole.cxx | 13 binfilter/bf_sw/source/core/sw3io/sw3imp.hxx |1 binfilter/bf_sw/source/core/sw3io/sw_sw3imp.cxx | 29 - binfilter/bf_sw/source/core/sw3io/sw_sw3style.cxx| 121 binfilter/bf_sw/source/core/text/sw_porlay.cxx |2 binfilter/inc/bf_sc/chgtrack.hxx |1 binfilter/inc/bf_sfx2/minarray.hxx |8 binfilter/inc/bf_starmath/utility.hxx|1 binfilter/inc/bf_svtools/cntnrsrt.hxx| 66 +- binfilter/inc/bf_svtools/filerec.hxx |2 binfilter/inc/bf_svtools/svarray.hxx | 508 +++ binfilter/inc/bf_svtools/svstdarr.hxx|5 19 files changed, 234 insertions(+), 678 deletions(-) New commits: commit 10c2eb2375b4e2dd889b945764162666363d2145 Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 26 22:11:08 2012 +0100 inline various macros and ditch unused code Change-Id: Idef459ca324de720ea19d36ff91c89e2196ec77b diff --git a/binfilter/bf_sc/source/core/tool/sc_chgtrack.cxx b/binfilter/bf_sc/source/core/tool/sc_chgtrack.cxx index e6e12c8..71d8d18 100644 --- a/binfilter/bf_sc/source/core/tool/sc_chgtrack.cxx +++ b/binfilter/bf_sc/source/core/tool/sc_chgtrack.cxx @@ -2918,59 +2918,6 @@ const USHORT ScChangeTrack::nContentSlots = /*N*/ } /*N*/ } - -/*N*/ void ScChangeTrack::Remove( ScChangeAction* pRemove ) -/*N*/ { -/*N*/ // aus Track ausklinken -/*N*/ ULONG nAct = pRemove-GetActionNumber(); -/*N*/ aTable.Remove( nAct ); -/*N*/ if ( nAct == nActionMax ) -/*N*/ --nActionMax; -/*N*/ if ( pRemove == pLast ) -/*N*/ pLast = pRemove-pPrev; -/*N*/ if ( pRemove == pFirst ) -/*N*/ pFirst = pRemove-pNext; -/*N*/ if ( nAct == nMarkLastSaved ) -/*N*/ nMarkLastSaved = -/*N*/ ( pRemove-pPrev ? pRemove-pPrev-GetActionNumber() : 0 ); -/*N*/ -/*N*/ // aus der globalen Kette ausklinken -/*N*/ if ( pRemove-pNext ) -/*N*/ pRemove-pNext-pPrev = pRemove-pPrev; -/*N*/ if ( pRemove-pPrev ) -/*N*/ pRemove-pPrev-pNext = pRemove-pNext; -/*N*/ -/*N*/ // Dependencies nicht loeschen, passiert on delete automatisch durch -/*N*/ // LinkEntry, ohne Listen abzuklappern -/*N*/ -/*N*/ if ( aModifiedLink.IsSet() ) -/*N*/ { -/*N*/ NotifyModified( SC_CTM_REMOVE, nAct, nAct ); -/*N*/ if ( pRemove-GetType() == SC_CAT_CONTENT ) -/*N*/ { -/*N*/ ScChangeActionContent* pContent = (ScChangeActionContent*) pRemove; -/*N*/ if (( pContent = pContent-GetPrevContent() )) -/*N*/ { -/*N*/ ULONG nMod = pContent-GetActionNumber(); -/*N*/ NotifyModified( SC_CTM_CHANGE, nMod, nMod ); -/*N*/ } -/*N*/ } -/*N*/ else if ( pLast ) -/*N*/ NotifyModified( SC_CTM_CHANGE, pFirst-GetActionNumber(), -/*N*/ pLast-GetActionNumber() ); -/*N*/ } -/*N*/ -/*N*/ if ( IsInPasteCut() pRemove-GetType() == SC_CAT_CONTENT ) -/*N*/ { //! Content wird wiederverwertet -/*N*/ ScChangeActionContent* pContent = (ScChangeActionContent*) pRemove; -/*N*/ pContent-RemoveAllLinks(); -/*N*/ pContent-ClearTrack(); -/*N*/ pContent-pNext = pContent-pPrev = NULL; -/*N*/ pContent-pNextContent = pContent-pPrevContent = NULL; -/*N*/ } -/*N*/ } - - /*N*/ void ScChangeTrack::UpdateReference( ScChangeAction* pAct, BOOL bUndo ) /*N*/ { /*N*/ ScChangeActionType eActType = pAct-GetType(); diff --git a/binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx b/binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx index 2bce536..e2ef131 100644 --- a/binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx +++ b/binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx @@ -116,56 +116,6 @@ namespace binfilter { /*N*/ return nLen; /*N*/ } -// --- - -/*N*/ BOOL SfxPtrArr::Remove( void* aElem ) -/*N*/ { -/*N*/ // einfache Aufgaben ... -/*N*/ if ( nUsed == 0 ) -/*N*/ return FALSE; -/*N*/ -/*N*/ // rueckwaerts, da meist der letzte zuerst wieder entfernt wird -/*N*/ void* *pIter = pData + nUsed - 1; -/*N*/ for ( USHORT n = 0; n nUsed; ++n, --pIter ) -/*N*/ if ( *pIter == aElem ) -/*N*/ { -/*N*/ Remove(nUsed-n-1, 1); -/*N*/ return TRUE; -/*N*/ } -/*N*/ return FALSE; -/*N*/ } - -// --- - -/*N*/ void SfxPtrArr::Insert( USHORT
[Libreoffice-commits] .: Branch 'update' - check.php
check.php | 12 1 file changed, 12 insertions(+) New commits: commit 017991626e672dc497ec33931e0b2bb4a3bb40b4 Author: Jan Holesovsky ke...@suse.cz Date: Wed Jun 27 18:01:47 2012 +0200 Enable online update for the 3.6 line. diff --git a/check.php b/check.php index 7d87bca..401879b 100644 --- a/check.php +++ b/check.php @@ -94,6 +94,7 @@ $localize_map = array( # Every released version has to be added here (all betas, RC's and final # versions) as soon as they are out $update_versions = array( +## # 3.5.0 versions '7362ca8-b5a8e65-af86909-d471f98-61464c4' = 'LO-3.5', # 3.5.0 Beta1 '8589e48-760cc4d-f39cf3d-1b2857e-60db978' = 'LO-3.5', # 3.5.0 Beta2 @@ -119,6 +120,11 @@ $update_versions = array( '7306755-f4f605c-738527d-1cf4bc1-9930dc8' = 'LO-3.5', # 3.5.4 RC1 # To be uncommented when 3.5.5 Final is out #'165a79a-7059095-e13bb37-fef39a4-9503d18' = 'LO-3.5', # 3.5.4 RC2 / Final + +## +# 3.6.0 versions +'1f1cdd8-e28082e-41df8bf-b153627-a97a84' = 'LO-3.6-pre', # 3.6.0 Beta1 +#'f010139-41cc8cc-da4127d-d2bb4b0-f433b8' = 'LO-3.6-pre', # 3.6.0 Beta2 ); # Descriptions of the target versions @@ -138,6 +144,12 @@ $update_map = array( # 'version' = '3.5.5 RC2', # 'update_type' = 'text/html', # 'update_src' = 'http://www.libreoffice.org/download/pre-releases/'), + +'LO-3.6-pre' = array('gitid' = 'f010139-41cc8cc-da4127d-d2bb4b0-f433b8', + 'id' = 'LibreOffice 3.6.0 Beta2', + 'version' = '3.6.0 Beta2', + 'update_type' = 'text/html', + 'update_src' = 'http://www.libreoffice.org/download/pre-releases/'), ); # Print the update xml ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Filter Selection Dialog
Hi All, I am trying to track down how LO is handling the Filter Selection dialog found here: https://bugs.freedesktop.org/attachment.cgi?id=55136 I have tracked down the framework here: http://opengrok.libreoffice.org/xref/core/uui/source/fltdlg.src#45 but am yet to see how the actual list is being generated inside of the dialog. Any guidance greatly appreciated. As a side note...I fried my hard drive last nightso I'm offline until replacement arrives in a few days (got to love Dell Extended Warranty) :) Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Including a patch from AOO...
On Wed, Jun 27, 2012 at 8:41 AM, Ivan Timofeev timofeev@gmail.com wrote: Hi there, a nice patch from AOO: http://svn.apache.org/viewvc?view=revisionrevision=1350585 given that the entirety of the patch is: --- incubator/ooo/trunk/main/svl/source/undo/undo.cxx 2012/06/15 11:40:331350584 +++ incubator/ooo/trunk/main/svl/source/undo/undo.cxx 2012/06/15 11:42:451350585 @@ -627,7 +627,7 @@ // merge, if required SfxUndoAction* pMergeWithAction = m_pData-pActUndoArray-nCurUndoAction ? m_pData-pActUndoArray-aUndoActions[m_pData-pActUndoArray-nCurUndoAction-1].pAction : NULL; - if ( bTryMerge ( !pMergeWithAction || !pMergeWithAction-Merge( pAction ) ) ) + if ( bTryMerge ( pMergeWithAction pMergeWithAction-Merge( pAction ) ) ) { i_guard.markForDeletion( pAction ); return false; Just reproduce it and mention i119400 in the commit message. Note: in this specific case removing the unnecessary '()' [ indeed A (B C) = A B C ] would be enough to make a distinct enough implementation, should someone insist on the un-realistic concept that such patch rise to the creativity threshold. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] update cppunit to version 1-13
Hey, the attached patch updates our cppunit version to a state that will become 1.13.0 if we don't find any problems with it in the next 2 days. Can someone quickly check my patch that I did not miss something? A quick list of features/bug fixes of this release: - possibility to build cppunit directly with visual studio 2005-2012RC - upstreamed all our patches - fixed some bugs from old cppunit bugzilla and from builds with different warning settings - some build fixes for newer visual studio versions - no auto_ptr more in a header file (thanks to Michael) You can read more about the changes in the NEWS file or at http://cgit.freedesktop.org/libreoffice/cppunit/log/ Regards, Markus 0001-update-cppunit-to-1.13.0.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] update cppunit to version 1-13
On Wed, 2012-06-27 at 18:57 +0200, Markus Mohrhard wrote: the attached patch updates our cppunit version to a state that will become 1.13.0 if we don't find any problems with it in the next 2 days. All looks good to me; I'd love to get it in since I've a number of queued up commits that are blocking on it :-) If it builds for you, I'd push it to master; much of the patch (that isn't removing crufty patches) is a version search replace it seems to me :-) Thanks ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: android/qa cppunit/aix.patch cppunit/android.patch cppunit/avoid-synthetised-destructor.patch cppunit/cppunit-1.12.1-unused-parameters.patch cppunit/cppunit-1.12.1-warnings.pa
android/qa/sc/Makefile |2 - android/qa/simple/Makefile |2 - cppunit/aix.patch | 21 -- cppunit/android.patch | 12 +++--- cppunit/avoid-synthetised-destructor.patch | 29 --- cppunit/cppunit-1.12.1-unused-parameters.patch | 11 - cppunit/cppunit-1.12.1-warnings.patch | 32 cppunit/ios.patch | 43 -- cppunit/ldflags.patch | 11 - cppunit/makefile.mk| 48 + cppunit/prj/d.lst | 22 +-- cppunit/solarisfinite.patch| 14 --- cppunit/warnings.patch | 33 - cppunit/windows.patch | 48 - ooo.lst.in |2 - scp2/source/smoketest/smoketest.scp|2 - 16 files changed, 32 insertions(+), 300 deletions(-) New commits: commit fa0fd16526f05e37e10af7a367c9950a974d7c90 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Jun 27 18:41:54 2012 +0200 update cppunit to 1.13.0 Change-Id: If3896361c31a84b77e4c446dac75aeb9268605a0 diff --git a/android/qa/sc/Makefile b/android/qa/sc/Makefile index 815758d..3b92d3b 100644 --- a/android/qa/sc/Makefile +++ b/android/qa/sc/Makefile @@ -46,7 +46,7 @@ copy-stuff: # # The cppunit library # - $(call COPY,$(OUTDIR)/lib/libcppunit-1.12.so) + $(call COPY,$(OUTDIR)/lib/libcppunit-1.13.so) # # The tests we run here # diff --git a/android/qa/simple/Makefile b/android/qa/simple/Makefile index 8007084..fad7730 100644 --- a/android/qa/simple/Makefile +++ b/android/qa/simple/Makefile @@ -44,7 +44,7 @@ copy-stuff: $(call COPY,$(OUTDIR)/bin/cppunit/cppunittester,libcppunittester.so) # # The cppunit library - $(call COPY,$(OUTDIR)/lib/libcppunit-1.12.so) + $(call COPY,$(OUTDIR)/lib/libcppunit-1.13.so) # # cppunit plug-ins, first ones from sal # diff --git a/cppunit/aix.patch b/cppunit/aix.patch deleted file mode 100644 index 2bc78f3..000 --- a/cppunit/aix.patch +++ /dev/null @@ -1,21 +0,0 @@ misc/cppunit-1.12.1.orig/config/config.guess 2010-09-15 10:25:54.0 -0500 -+++ misc/build/cppunit-1.12.1/config/config.guess 2010-09-15 10:26:50.0 -0500 -@@ -532,7 +532,7 @@ - echo rs6000-ibm-aix3.2 - fi - exit ;; --*:AIX:*:[456]) -+*:AIX:*:[4567]) - IBM_CPU_ID=`/usr/sbin/lsdev -C -c processor -S available | sed 1q | awk '{ print $1 }'` - if /usr/sbin/lsattr -El ${IBM_CPU_ID} | grep ' POWER' /dev/null 21; then - IBM_ARCH=rs6000 -@@ -544,6 +544,9 @@ - else - IBM_REV=${UNAME_VERSION}.${UNAME_RELEASE} - fi -+ if [ $IBM_REV == V7BETA ]; then -+ IBM_REV=${UNAME_VERSION}.${UNAME_RELEASE} -+ fi - echo ${IBM_ARCH}-ibm-aix${IBM_REV} - exit ;; - *:AIX:*:*) diff --git a/cppunit/android.patch b/cppunit/android.patch index 7628f5f..e5671a0 100644 --- a/cppunit/android.patch +++ b/cppunit/android.patch @@ -1,5 +1,5 @@ misc/cppunit-1.12.1/config/config.sub -+++ misc/build/cppunit-1.12.1/config/config.sub +--- misc/cppunit-1.13.0/config/config.sub misc/build/cppunit-1.13.0/config/config.sub @@ -120,7 +120,7 @@ # Here we must recognize all the valid KERNEL-OS combinations. maybe_os=`echo $1 | sed 's/^\(.*\)-\([^-]*-[^-]*\)$/\2/'` @@ -18,8 +18,8 @@ | -uxpv* | -beos* | -mpeix* | -udk* \ | -interix* | -uwin* | -mks* | -rhapsody* | -darwin* | -opened* \ | -openstep* | -oskit* | -conix* | -pw32* | -nonstopux* \ misc/cppunit-1.12.1/config/ltmain.sh -+++ misc/build/cppunit-1.12.1/config/ltmain.sh +--- misc/cppunit-1.13.0/config/ltmain.sh misc/build/cppunit-1.13.0/config/ltmain.sh @@ -3228,6 +3228,12 @@ fi else @@ -33,8 +33,8 @@ # Parse the version information argument. save_ifs=$IFS; IFS=':' set dummy $vinfo 0 0 0 misc/cppunit-1.12.1/src/cppunit/UnixDynamicLibraryManager.cpp -+++ misc/build/cppunit-1.12.1/src/cppunit/UnixDynamicLibraryManager.cpp +--- misc/cppunit-1.13.0/src/cppunit/UnixDynamicLibraryManager.cpp misc/build/cppunit-1.13.0/src/cppunit/UnixDynamicLibraryManager.cpp @@ -13,7 +13,15 @@ DynamicLibraryManager::LibraryHandle DynamicLibraryManager::doLoadLibrary( const std::string libraryName ) diff --git a/cppunit/avoid-synthetised-destructor.patch b/cppunit/avoid-synthetised-destructor.patch deleted file mode 100644 index 82b7929..000 --- a/cppunit/avoid-synthetised-destructor.patch +++ /dev/null @@ -1,29 +0,0 @@ -rhbz#641350 impl. destructor of CppUnit::Message causes segfault when test -is built with debug. STL - -diff -up
[Libreoffice-commits] .: Branch 'feature/gsoc_test_improvements' - 3 commits - drawinglayer/inc drawinglayer/Library_drawinglayer.mk drawinglayer/Package_inc.mk drawinglayer/source
drawinglayer/Library_drawinglayer.mk |1 drawinglayer/Package_inc.mk |1 drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx | 52 ++ drawinglayer/inc/drawinglayer/XShapeDumper.hxx|7 +- drawinglayer/source/dumper/EnhancedShapeDumper.cxx| 48 drawinglayer/source/dumper/XShapeDumper.cxx | 26 - 6 files changed, 132 insertions(+), 3 deletions(-) New commits: commit f5ec01eca694fc240cd0e7a102e57bd0c7c807ba Author: Artur Dorda artur.dorda+l...@gmail.com Date: Tue Jun 26 19:13:22 2012 +0200 Added service EnhancedCustomShapeExtrusion, properties Extrusion Brightness Change-Id: Ie787fb90f2c8192632e0ad8a86c7affbb3315791 diff --git a/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx b/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx index 71b0fde..777a00b 100644 --- a/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx +++ b/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx @@ -42,6 +42,9 @@ public: } +// EnhancedCustomShapeExtrusion.idl +void dumpExtrusionAsAttribute(sal_Bool bExtrusion); +void dumpBrightnessAsAttribute(double aBrightness); private: xmlTextWriterPtr xmlWriter; diff --git a/drawinglayer/source/dumper/EnhancedShapeDumper.cxx b/drawinglayer/source/dumper/EnhancedShapeDumper.cxx index f68d320..19c60d4 100644 --- a/drawinglayer/source/dumper/EnhancedShapeDumper.cxx +++ b/drawinglayer/source/dumper/EnhancedShapeDumper.cxx @@ -29,5 +29,20 @@ #include drawinglayer/EnhancedShapeDumper.hxx #include rtl/strbuf.hxx +// -- +// -- EnhancedCustomShapeExtrusion.idl -- +// -- +void EnhancedShapeDumper::dumpExtrusionAsAttribute(sal_Bool bExtrusion) +{ +if(bExtrusion) +xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST(extrusion), %s, true); +else +xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST(extrusion), %s, false); +} + +void EnhancedShapeDumper::dumpBrightnessAsAttribute(double aBrightness) +{ +xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST(brightness), %f, aBrightness); +} diff --git a/drawinglayer/source/dumper/XShapeDumper.cxx b/drawinglayer/source/dumper/XShapeDumper.cxx index 990e033..f17c426 100644 --- a/drawinglayer/source/dumper/XShapeDumper.cxx +++ b/drawinglayer/source/dumper/XShapeDumper.cxx @@ -1620,7 +1620,18 @@ namespace { void XShapeDumper::dumpEnhancedCustomShapeExtrusionService(uno::Reference beans::XPropertySet xPropSet, EnhancedShapeDumper enhancedDumper) { - +{ +uno::Any anotherAny = xPropSet-getPropertyValue(Extrusion); +sal_Bool bExtrusion; +if(anotherAny = bExtrusion) +enhancedDumper.dumpExtrusionAsAttribute(bExtrusion); +} +{ +uno::Any anotherAny = xPropSet-getPropertyValue(Brightness); +double aBrightness; +if(anotherAny = aBrightness) +enhancedDumper.dumpBrightnessAsAttribute(aBrightness); +} } void XShapeDumper::dumpXShape(uno::Reference drawing::XShape xShape, xmlTextWriterPtr xmlWriter) commit 0462d0fb38191b234d095b44602918a7d3c8f16f Author: Artur Dorda artur.dorda+l...@gmail.com Date: Tue Jun 26 19:07:12 2012 +0200 Added new class EnhancedShapeDumper handled in XShapeDumper Change-Id: Ie719eba2579998917cea030fad51f07b0bcacec4 diff --git a/drawinglayer/Library_drawinglayer.mk b/drawinglayer/Library_drawinglayer.mk index f0d243d..07aaa3b 100644 --- a/drawinglayer/Library_drawinglayer.mk +++ b/drawinglayer/Library_drawinglayer.mk @@ -180,6 +180,7 @@ $(eval $(call gb_Library_add_exception_objects,drawinglayer,\ drawinglayer/source/texture/texture3d \ drawinglayer/source/texture/texture \ drawinglayer/source/dumper/XShapeDumper \ +drawinglayer/source/dumper/EnhancedShapeDumper \ )) # vim: set noet sw=4 ts=4: diff --git a/drawinglayer/Package_inc.mk b/drawinglayer/Package_inc.mk index ff9314a..9508f6e 100644 --- a/drawinglayer/Package_inc.mk +++ b/drawinglayer/Package_inc.mk @@ -137,5 +137,6 @@ $(eval $(call gb_Package_add_file,drawinglayer_inc,inc/drawinglayer/processor3d/ $(eval $(call gb_Package_add_file,drawinglayer_inc,inc/drawinglayer/texture/texture3d.hxx,drawinglayer/texture/texture3d.hxx)) $(eval $(call gb_Package_add_file,drawinglayer_inc,inc/drawinglayer/texture/texture.hxx,drawinglayer/texture/texture.hxx)) $(eval $(call gb_Package_add_file,drawinglayer_inc,inc/drawinglayer/XShapeDumper.hxx,drawinglayer/XShapeDumper.hxx)) +$(eval $(call gb_Package_add_file,drawinglayer_inc,inc/drawinglayer/XShapeDumper.hxx,drawinglayer/EnhancedShapeDumper.hxx)) # vim: set noet sw=4 ts=4: diff --git a/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx b/drawinglayer/inc/drawinglayer/EnhancedShapeDumper.hxx
Re: [PATCH] fdo#50871 BUGZILLAASSISTANT: Help Linguistic PDF Export not available
Petr Mladek schrieb: I am still confused. I am talking about Rob's 0001-Localisation-changed-to-Localization.patch. I guess that we want to rename the component but I am not sure about the push timing. Do you need to do some changes in bugzilla first? Hi Petr, no need to be confused. All fixes can (and should) be pushed immediately when review has showed that the patch is sane. The push is without any influence to the Assistant until the update of the Assistant due to https://wiki.documentfoundation.org/Bug_Submission_Assistant#Installation_and_maintenance will have been done. I consider that these updates only can be done when Bugzilla, Wiki and may be patches all are prepared. Currently these Updates generally are done By Thorsten Behrens (I did not understand the SSH proceeding), and I initiate the the update only So please push Rob's latest patch. Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [GSoC 2012][svg export filter] Weekly Report #5
On Wed, 27 Jun 2012 09:49:32 +0200, Thorsten Behrens t...@documentfoundation.org wrote: Marco Cecchetti wrote: As for your question: well it works correctly but on Opera as it doesn't like the fill attribute on animation element, and in some cases it removes the attribute value, so I really don't know how to fix it at present. Hi Marco, I see - well that be as it may, but for the other browsers it's an improvement - I would merge it. ;) Ok, I'll merge as soon as possible :) -- Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC 2012][Collaboration] status + screenshot
Hi Matúš, On Wednesday, 2012-06-27 17:35:53 +0200, Matúš Kukan wrote: .. the AccountContact struct seems ok to me. However, I'm missing the destruction of the created instances, this looks like a memory leak. I changed it to use boost::ptr_vector [1]. Are the instances going to be destroyed then ? I don't have experience with boost. Yes, boost::ptr_vector takes ownership of pointers and deletes objects on destruction. The TpAccount* and TpConnect* in AccountContact may need some un/ref'ing as well, so g_object_ref( mpAccount) when storing and and g_object_unref( mpAccount) when releasing. Actually please try to avoid to pull-in telepathy and glib dependencies into application code, I'd prefer if we could encapsulate these things within the tubes module. IMHO we should not spread linkage to telepathy/glib further than absolutely necessary. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpGBKk5IeU8r.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Including a patch from AOO...
Hi. There are bug reports on bugs.freedesktop.org imported from AOO which are in RESOLVED FIXED state there. Patches are commited to AOO codebase for some of them. LO devs should reinvent the wheel to fix a fixed issues (just like this thread is all about)? This can impact improving LO quality. Any comments on that? Best regards. -- View this message in context: http://nabble.documentfoundation.org/Including-a-patch-from-AOO-tp3992463p3992579.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#50871 BUGZILLAASSISTANT: Help Linguistic PDF Export not available
Hi, I have checked it and it should work. So I see no problem that this patch is pushed. -- Greetings, Rob Snelders Op wo 27 jun 2012 20:00:49 CEST, Rainer Bielefeld schreef: Petr Mladek schrieb: I am still confused. I am talking about Rob's 0001-Localisation-changed-to-Localization.patch. I guess that we want to rename the component but I am not sure about the push timing. Do you need to do some changes in bugzilla first? Hi Petr, no need to be confused. All fixes can (and should) be pushed immediately when review has showed that the patch is sane. The push is without any influence to the Assistant until the update of the Assistant due to https://wiki.documentfoundation.org/Bug_Submission_Assistant#Installation_and_maintenance will have been done. I consider that these updates only can be done when Bugzilla, Wiki and may be patches all are prepared. Currently these Updates generally are done By Thorsten Behrens (I did not understand the SSH proceeding), and I initiate the the update only So please push Rob's latest patch. Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Link-time optimization status
Hi Michael, On 19 June 2012 10:55, Michael Meeks michael.me...@suse.com wrote: I also got an internal compiler error somewhere. Yep, so we should file those bugs I suppoe. For me, to file a bug is almost like to fix a bug for non-developer. And it works with newer gcc anyway. Here are few differences in size (not stripped): LTO / not-LTO total size of workdir/*/LinkTarget/Library: 290M / 304M Goodness - an un-stripped library is of a random size; highly affected by debuginfo / symbol tables etc. IMHO it is only worth comparing stripped library sizes; can you easily generate those ? :-) Sure. It's 189M vs. 204M in total. libmergedlo.so 36M / 41M ... libcuilo.so 3.9M / 3.8M is slightly bigger ... nothing more really interesting. I guess -Os would behave similar. so sometimes is creates bigger libraries. That is interesting; so - Jan - how well does LTO cope with -Os vs. -O2 etc. and/or Matus - what compile flags are we using ? It's quite random. For me it's -O2 on 64bit system. But we are using -Os on 32bit linux platform. Maybe it's not all about the size ? :-) well; we want to be smaller of course. Potentially getting more code inside the libmerged perimiter helps - and potentially better visibility markup so that the LTO can know that a given function is not used outside of that libmerged is useful. So far we have only a markup that says used outside of un-merged library, really we need to split that into two types of markup that distinguish whether it is used outside of libmerged or not (I think). Hmm, this does not seem to be doable quickly. But maybe it's easy and possible to file an easy hack ? Thanks ! this was a great GSOC project :-) Yep, thanks. Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#41601 - BUGZILLAASSISTANT: Mouseover SUBMIT button does not change mouse pointer view
Hi All, Here the patch that solves this bug. The SUBMIT-button now has the pointer again. -- Greetings, Rob Snelders From 9f014d4a35ccf973b3c1a05732caae56f870175b Mon Sep 17 00:00:00 2001 From: Rob Snelders programm...@ertai.nl Date: Wed, 27 Jun 2012 23:29:01 +0200 Subject: [PATCH] fdo#41601 - BUGZILLAASSISTANT: Mouseover SUBMIT button does not change mouse pointer view --- bug/bug/bug.css |4 1 file changed, 4 deletions(-) diff --git a/bug/bug/bug.css b/bug/bug/bug.css index 34e4377..6fde858 100644 --- a/bug/bug/bug.css +++ b/bug/bug/bug.css @@ -430,11 +430,7 @@ body { color: #fff; text-align: center; line-height: 49px; -} - -.state_submit div:hover.go { cursor: pointer; -background: url('images/submit-hover.png') no-repeat; } /* related bugs */ -- 1.7.9.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
ScInterpreter::Interpret() backtraces during ODS import
Hi, Markus, Attached are the backtraces you requested for ScInterpreter::Interpret() while importing sc/qa/unit/data/ods/functions.ods. While the document is being loaded, bt1.log is called once and then bt2.log is called multiple times. After the document is loaded, if I click on a different tab to view for the first time since the document has been loaded, bt3.log is called multiple times. When ScInterpreter::Interpret() is called multiple times, I assume that each call is for each formula cell, although I have not thoroughly verified this. Does this mean we are indeed unnecessarily recalculating formula results even though we have imported formula results at our disposal? Respectfully, Daniel Bankston #0 ScInterpreter::Interpret (this=0x19aca60) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/core/tool/interpr4.cxx:3712 #1 0x7fffde699d0f in ScFormulaCell::InterpretTail (this=0x1a308b0, eTailParam=ScFormulaCell::SCITP_NORMAL) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/core/data/cell.cxx:1495 #2 0x7fffde69ad82 in ScFormulaCell::Interpret (this=0x1a308b0) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/core/data/cell.cxx:1222 #3 0x7fffdece199c in ScTabView::InterpretVisible (this=0x1a9e030) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/ui/view/tabview4.cxx:541 #4 0x7fffdecdf935 in ScTabView::ZoomChanged (this=0x1a9e030) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/ui/view/tabview3.cxx:2599 #5 0x7fffdecec961 in ScTabViewShell::ScTabViewShell (this=0x1a9df70, pViewFrame=optimized out, pOldSh=0x0) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/ui/view/tabvwsh4.cxx:1734 #6 0x7fffdece3424 in ScTabViewShell::CreateInstance (pFrame=0x1a527e0, pOldView=0x0) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/ui/view/tabvwsh.cxx:90 #7 0x756845c9 in SfxBaseModel::createViewController (this=0x19af4f0, i_rViewName=..., i_rArguments=empty uno::Sequence, i_rFrame=...) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sfx2/source/doc/sfxbasemodel.cxx:4093 #8 0x756cd058 in SfxFrameLoader_Impl::impl_createDocumentView (this=optimized out, i_rModel=uno::Reference to {com::sun::star::frame::XModel = {com::sun::star::lang::XComponent = {com::sun::star::uno::XInterface = {_vptr.XInterface = 0x7fffdf135d90}, No data fields}, No data fields}, No data fields}, i_rFrame=uno::Reference to {com::sun::star::lang::XComponent = {com::sun::star::uno::XInterface = {_vptr.XInterface = 0x7fffe1dc7f90}, No data fields}, No data fields}, i_rViewFactoryArgs=..., i_rViewName=Default) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sfx2/source/view/frmload.cxx:508 #9 0x756cffdd in SfxFrameLoader_Impl::load (this=0x19b0e00, rArgs=..., _rTargetFrame=uno::Reference to {com::sun::star::lang::XComponent = {com::sun::star::uno::XInterface = {_vptr.XInterface = 0x7fffe1dc7f90}, No data fields}, No data fields}) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sfx2/source/view/frmload.cxx:633 #10 0x7fffe19dd9a2 in framework::LoadEnv::impl_loadContent (this=0x19b96e8) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/framework/source/loadenv/loadenv.cxx:1162 #11 0x7fffe19dfc18 in framework::LoadEnv::startLoading (this=0x19b96e8) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/framework/source/loadenv/loadenv.cxx:420 #12 0x7fffe194d00b in framework::LoadDispatcher::impl_dispatch (this=0x19b9650, rURL=..., lArguments=uno::Sequence of length 3 = {...}, xListener=empty uno::Reference) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/framework/source/dispatch/loaddispatcher.cxx:130 #13 0x7fffe194e725 in framework::LoadDispatcher::dispatch (this=optimized out, aURL=..., lArguments=...) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/framework/source/dispatch/loaddispatcher.cxx:69 #14 0x7fffe1ae6a3f in framework::RecentFilesMenuController::ExecuteHdl_Impl (pLoadRecentFile=0x19b2e00) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/framework/source/uielement/recentfilesmenucontroller.cxx:490 #15 0x736f24e8 in Call (pCaller=optimized out, this=optimized out) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/solver/unxlngx6.pro/inc/tools/link.hxx:143 #16 ImplHandleUserEvent (pSVEvent=0x19b0c80) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/vcl/source/window/winproc.cxx:2003 #17 ImplWindowFrameProc (pWindow=optimized out, nEvent=optimized out, pEvent=0x19b0c80) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/vcl/source/window/winproc.cxx:2575 #18 0x736fb0ae in CallCallback (pEvent=0x19b0c80, nEvent=22, this=0x11be450) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/vcl/inc/salframe.hxx:281 #19 SalGenericDisplay::DispatchInternalEvent (this=0x10fe9b0) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/vcl/generic/app/gendisp.cxx:102 #20 0x7fffea5497f2 in GtkData::userEventFn
[Libreoffice-commits] .: sc/sdi sc/source svx/Library_svxcore.mk svx/Package_inc.mk svx/inc svx/sdi svx/source sw/Library_sw.mk sw/inc sw/sdi sw/source
sc/sdi/graphsh.sdi| 18 ++-- sc/source/ui/drawfunc/graphsh.cxx | 66 ++ sc/source/ui/drawfunc/objdraw.src |4 sc/source/ui/inc/graphsh.hxx |3 svx/Library_svxcore.mk|1 svx/Package_inc.mk|3 svx/inc/globlmn_tmpl.hrc |5 + svx/inc/svx/extedit.hxx | 54 svx/inc/svx/svxids.hrc|4 svx/sdi/svx.sdi | 25 + svx/source/core/extedit.cxx | 170 ++ sw/Library_sw.mk |1 sw/inc/cmdid.h|3 sw/inc/swcommands.h |1 sw/sdi/_grfsh.sdi |4 sw/sdi/swriter.sdi| 27 -- sw/source/ui/app/mn.src |5 - sw/source/ui/docvw/extedit.cxx| 149 - sw/source/ui/inc/extedit.hxx | 50 --- sw/source/ui/shells/grfsh.cxx | 30 +- 20 files changed, 367 insertions(+), 256 deletions(-) New commits: commit 7a3ae89a12b2c11e90d3f0c76293ddb63203bd2a Author: Tomaž Vajngerl qui...@gmail.com Date: Thu Jun 28 00:19:28 2012 +0200 Enable menu option Edit witn External Tool.. for Calc. Currently it was only possible to use Exit with External Tool.. menu option in Writer. Now it is also possible to use this in Calc and in future Draw and Impress. Code has been refactored and extacted out of sw into svx, so other components can use it. Currently there is no cleanup of temporary images after processing was done, and also pinging for changes are still active even when editing in external tool is done. This behavior will be changed in the future. Change-Id: I09969d44dfddbf9183b30ff3fffa2d201c7ae40f diff --git a/sc/sdi/graphsh.sdi b/sc/sdi/graphsh.sdi index cbf2583..6eb051b 100644 --- a/sc/sdi/graphsh.sdi +++ b/sc/sdi/graphsh.sdi @@ -128,11 +128,18 @@ interface GraphSelection ExecMethod = Execute; StateMethod = GetAttrState; ] -SID_COLOR_SETTINGS -[ -ExecMethod = Execute; -StateMethod = GetAttrState; -] + +SID_COLOR_SETTINGS +[ +ExecMethod = Execute; +StateMethod = GetAttrState; +] + +SID_EXTERNAL_EDIT +[ +ExecMethod = ExecuteExternalEdit; +StateMethod = GetExternalEditState; +] } // === @@ -140,4 +147,3 @@ shell ScGraphicShell : ScDrawShell { import GraphSelection; } - diff --git a/sc/source/ui/drawfunc/graphsh.cxx b/sc/source/ui/drawfunc/graphsh.cxx index 751fc41..ff4d43d 100644 --- a/sc/source/ui/drawfunc/graphsh.cxx +++ b/sc/source/ui/drawfunc/graphsh.cxx @@ -39,12 +39,40 @@ #include viewdata.hxx #include drawview.hxx #include scresid.hxx +#include svx/extedit.hxx #define ScGraphicShell #include scslots.hxx #define ITEMVALUE(ItemSet,Id,Cast) ((const Cast)(ItemSet).Get(Id)).GetValue() +class ScExternalToolEdit : public ExternalToolEdit +{ +ScDrawView* m_pView; +SdrObject* m_pObj; + +public: +ScExternalToolEdit ( ScDrawView* pView, SdrObject* pObj ) : +m_pView (pView), +m_pObj (pObj) +{} + +virtual void Update( Graphic aGraphic ) +{ +SdrPageView* pPageView = m_pView-GetSdrPageView(); +if( pPageView ) +{ +SdrGrafObj* pNewObj = (SdrGrafObj*) m_pObj-Clone(); +String aStr( m_pView-GetDescriptionOfMarkedObjects() ); +aStr.Append( sal_Unicode(' ') ); +aStr.Append( String( External Edit ) ); +m_pView-BegUndo( aStr ); +pNewObj-SetGraphicObject( aGraphic ); +m_pView-ReplaceObjectAtView( m_pObj, *pPageView, pNewObj ); +m_pView-EndUndo(); +} +} +}; SFX_IMPL_INTERFACE(ScGraphicShell, ScDrawShell, ScResId(SCSTR_GRAPHICSHELL) ) { @@ -140,4 +168,42 @@ void ScGraphicShell::ExecuteFilter( SfxRequest rReq ) Invalidate(); } +void ScGraphicShell::GetExternalEditState( SfxItemSet rSet ) +{ +ScDrawView* pView = GetViewData()-GetScDrawView(); +const SdrMarkList rMarkList = pView-GetMarkedObjectList(); +bool bEnable = false; +printf(ZO!\n); +if( rMarkList.GetMarkCount() == 1 ) +{ +SdrObject* pObj = rMarkList.GetMark( 0 )-GetMarkedSdrObj(); + +if( pObj pObj-ISA( SdrGrafObj ) ( ( (SdrGrafObj*) pObj )-GetGraphicType() == GRAPHIC_BITMAP ) ) +bEnable = true; +} + +if( !bEnable ) +rSet.DisableItem( SID_EXTERNAL_EDIT ); +} + +void ScGraphicShell::ExecuteExternalEdit( SfxRequest rReq ) +{ +ScDrawView* pView = GetViewData()-GetScDrawView(); +const SdrMarkList rMarkList = pView-GetMarkedObjectList(); +printf(YO!\n); + +if( rMarkList.GetMarkCount() == 1 ) +{ +SdrObject* pObj = rMarkList.GetMark( 0 )-GetMarkedSdrObj(); + +if( pObj
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Depends on||51239 --- Comment #30 from Lionel Elie Mamane lio...@mamane.lu 2012-06-27 22:31:45 PDT --- Bug 51239: very slow base / jdbc / embedded HSQLDB -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] LibO 3.6.0 Bugs without keyword REGRESSION
Hi all, https://bugs.freedesktop.org/buglist.cgi?keywords=regression%2C%20query_format=advancedkeywords_type=nowordslist_id=88175field0-0-0=versiontype0-0-0=anywordssubstrvalue0-0-0=3.6.0%203.7.0.0.alphaproduct=LibreOffice shows a lot of 3.6.0 and 3.7.0 Bugs without key word regression, although bugs for these Versions are regressions by definition. Please be watchful and add the key word where appropriate and check for bug in more early versions. Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Build Available Feed
Hi all, is there any possibility to get a reliable info that a new build is available from a particular WIN Tinderbox? I always have some test-to-dos in the line, not every test can be done with every build, and especially when (like now) new complete builds come very seldom those unsuccessful checks of the download server are really annoying. Is there a solution for my problem? Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] LibO 3.6.0 Bugs without keyword REGRESSION
On Wed, Jun 27, 2012 at 07:38:34AM +0200, Rainer Bielefeld wrote: shows a lot of 3.6.0 and 3.7.0 Bugs without key word regression, although bugs for these Versions are regressions by definition. ... unless they are about new features ;) Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] LibO 3.6.0 Bugs without keyword REGRESSION
Bjoern Michaelsen schrieb: ... unless they are about new features ;) Hi, I KNEW I had forgotten something ... Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Cobra - WinLDTP Automation
hi bfo, On 25/06/12 23:40, bfo wrote: I stumbled upon Cobra – WinLDTP, Windows version of Linux Desktop Testing Project open sourced by VMWare recently. Using this tool, the GUI functionality of an application can be tested in Windows XP SP3, Windows 7 SP1, Windows 8 development release. Libre/OpenOffice is mentioned. Did anybody used LDTP in the past to perform functional, regression testing? More info at http://ldtp.freedesktop.org/wiki. this sounds very interesting, especially this: It uses the Accessibility libraries to discover through the application's user interface. that sounds like the ideal approach to UI testing for me, as it would automatically test the accessibility interface as well, which is something that i'm pretty sure nobody tests by hand, so if there are regressions there they won't be noticed. Linux version is LDTP, Windows version is Cobra and Mac version is PyATOM (Work in progress). can all of these execute the same tests? surely writing tests 3 times is not the way to go. btw, i'm not sure if you know this, but there used to be a VCL testtool in the OOo code base, which was developed by the Sun Hamburg QA department to do automated UI testing; this tool had serious problems, such as timing issues requiring to manually litter the tests with sleeps, so as machines got faster the tests would leave the CPU mostly idle and take days to run; also i have it on good account that the QA department actually used a testtool binary built in 2007 and never upgraded that to the current OOo code later, which does not exactly instil confidence; testtool was removed from LibreOffice because it was decided that this is clearly not maintainable. i wonder what AOO uses for UI testing; perhaps IBM has some internal thing for that. Best regards. P.S. There are traces of automation at wiki.documentfoundation.org: - smoketest has to be done before any beta or rc build is announced the smoketest (as well as many other automated tests) can be run during the build simply by calling make check, and i would hope that our release builds are built that way. - full regression test has to be done before every major release - basic regression test should be done also before every bug fix release What is the status of those? Are they executed before each release? Any dashboards available? i wonder what regression test means here? manual tests, or does it refer to testtool? ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] BugHunt Session ...Re: [libreoffice-projects] Re: minutes of the libreoffice qa call 2012-06-14
Hi all, Rainer Bielefeld wrote (26-06-12 20:13) Michael Meeks schrieb: If it gets us more testing of 3.6 - it sounds like an excellent idea to I also believe it would be great do do some final spurt for 3.6. [..] But may be I will join for a short visit. So here we go: https://wiki.documentfoundation.org/QA/BugHunting_Session_3.6.0 We'll have to make sure that preparations are in place, just for in case that non of us is able to join :-) Italo, could you draft a simple PR, or can you give me permission to recycle some of your previous work ;-) Cheers -- - Cor - http://nl.libreoffice.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] [ANN] LibreOffice 3.5.5 RC2 test builds available
Hi *, for the upcoming new version 3.5.5, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 3.5.5, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 3.5.5 RC1 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-5-release-3.5.5.2.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.5 RC2 test builds available
Hi, On Wed, Jun 27, 2012 at 04:15:18PM +0200, Fridrich Strba wrote: Hi *, for the upcoming new version 3.5.5, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 3.5.5, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: Ubuntu users wanting to test 3.5.5~rc2 can download a build right now at: https://launchpad.net/~bjoern-michaelsen/+archive/libreoffice-precisetest-20120327 the same source package has been pushed to: https://launchpad.net/~libreoffice/+archive/ppa?field.series_filter=precise and will finish building there in some ~5 hours, making it available to all people who have enabled the LibreOffice PPA. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Cobra - WinLDTP Automation
Michael Stahl-2 wrote Linux version is LDTP, Windows version is Cobra and Mac version is PyATOM (Work in progress). can all of these execute the same tests? surely writing tests 3 times is not the way to go. With LDTP and WinLDTP, the script API part will be the same. The only places where the script writer has to update things would be like - when the widget types between both the platforms are different or the UI object label is different More informations: news article - http://news.efytimes.com/e1/82073/VMWare-Open-Sources--Windows-Version-Of-Linux-Desktop-Testing-Project developer's blog - http://nagappanal.blogspot.com/ i wonder what AOO uses for UI testing; perhaps IBM has some internal thing for that. I have found the following resources: https://cwiki.apache.org/OOOUSERS/release-qa-plan.html http://wiki.services.openoffice.org/wiki/Quality_Assurance http://www.mail-archive.com/ooo-dev@incubator.apache.org/msg20994.html the smoketest (as well as many other automated tests) can be run during the build simply by calling make check, and i would hope that our release builds are built that way. Are results of such tests available anywhere? - full regression test has to be done before every major release - basic regression test should be done also before every bug fix release What is the status of those? Are they executed before each release? Any dashboards available? i wonder what regression test means here? manual tests, or does it refer to testtool? I got it from this article: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests -- View this message in context: http://nabble.documentfoundation.org/Cobra-WinLDTP-Automation-tp3992246p3992538.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Cobra - WinLDTP Automation
i wonder what AOO uses for UI testing; perhaps IBM has some internal thing for that. I have found the following resources: https://cwiki.apache.org/OOOUSERS/release-qa-plan.html http://wiki.services.openoffice.org/wiki/Quality_Assurance http://www.mail-archive.com/ooo-dev@incubator.apache.org/msg20994.html The last thing I heard about it is that they are now using it already. I did not yet have time to look into it and sadly it is another java based test framework. I plan to have at least a look at it after the 3-6 release. Regards, Markus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Online update in 3.6
Hi Klaus-Juergen, all, I have enabled the online update service for the 3.6 line now too - can you please test? To test, please install the 3.6 Beta1, and choose 'Help' - 'Check for Updates...' - it should offer you the Beta2 :-) Please report back any issues. Thank you in advance! All the best, Kendy ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] bug 46250
The bug 46250 is begin in 3.5.0 and still in 3.6.0 beta 2! -- regards Frank ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Online update in 3.6
Hi Kendy, Am 27.06.2012 18:12, schrieb Jan Holesovsky: Hi Klaus-Juergen, all, I have enabled the online update service for the 3.6 line now too - can you please test? To test, please install the 3.6 Beta1, and choose 'Help' - 'Check for Updates...' - it should offer you the Beta2 :-) Version 3.6.0beta1 (Build ID: 1f1cdd8) VISTA 32bit LOdev 3.6 ist auf dem neuesten Stand. Please report back any issues. Thank you in advance! So I don't get Beta2. Grüße k-j ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 49924] FILESAVE: Comments disappear
https://bugs.freedesktop.org/show_bug.cgi?id=49924 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Summary|Comments disappering when |FILESAVE: Comments |file is saved |disappear -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49924] FILESAVE: Comments disappear
https://bugs.freedesktop.org/show_bug.cgi?id=49924 --- Comment #10 from SURCOUF bunty.surc...@gmail.com 2012-06-26 22:58:19 PDT --- Rainer Bielefeld Thanks to have a glance to this bug. Can't see how to illustrate this bug through a sample file. Hope that you'll be able to find out a solution without a sample file. Bunty UBUNTU 12.04 LTS 64 Bits GNOME 3.4.0 LibO 3.6.0 Beta 2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Korrawit Pruegsanusak detective.conan.1...@gmail.com changed: What|Removed |Added Depends on||51179 --- Comment #29 from Korrawit Pruegsanusak detective.conan.1...@gmail.com 2012-06-26 23:14:31 PDT --- Adding bug 51179 - cannot save as ppt. Because it's a regression, and I think we can't live with this bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51179] FILESAVE cannot save file as .ppt
https://bugs.freedesktop.org/show_bug.cgi?id=51179 Korrawit Pruegsanusak detective.conan.1...@gmail.com changed: What|Removed |Added Blocks||6 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50974] CALC UI [It]: Wrong wording Formula instead of formule
https://bugs.freedesktop.org/show_bug.cgi?id=50974 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Severity|normal |trivial Summary|CALC UI [It]: Wrong |CALC UI [It]: Wrong wording |wordings Diagrammi and|Formula instead of |Formula |formule Version|3.6.0.0.beta1 |3.3.0 release --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-26 23:25:16 PDT --- Oggetti correct with LibreOffice 3.3.3 Italian UI/Locale [OOO330m19 (Build:301) tag libreoffice-3.3.3.1] on German WIN7 Home Premium (64bit), Formula also incorrect in that version Same with 3.5.3 Same with 3.6.0beta1 So that Diagrammi problem is not reproducible for me. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42246] Cannot Embed Videos from Popular Video Websites
https://bugs.freedesktop.org/show_bug.cgi?id=42246 --- Comment #4 from sasha.libreoff...@gmail.com 2012-06-26 23:35:38 PDT --- Regression with playing video on Windows. Steps to reproduce: 0. Start Impress 1. Insert-Movie and Sound, select video file 2. Press F5 IMHO it was working in 3.4 version. I can not verify it in summer On Linux video not working for long time -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51179] FILESAVE cannot save file as .ppt
https://bugs.freedesktop.org/show_bug.cgi?id=51179 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Version|3.6.0.0.beta1 |Master old -3.6 --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-26 23:42:48 PDT --- [Reproducible] with server-installation of Master LOdev 3.6.0alpha1+ – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: bfa9061] (tinderbox: Win-x86@6-fast, pull time 2012-06-02 23:56:11) Worked fine with with Server installation of Master LOdev 3.6.0alpha0+ – WIN7 Home Premium (64bit) ITALIAN UI [Build ID: 7175cee] (tinderbox: Win-x86@6-fast, pull time 2012-05-16 22:07:37) Really very new regression -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51073] FILESAVE of particular .ppt fails with error message
https://bugs.freedesktop.org/show_bug.cgi?id=51073 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||DUPLICATE CC||LibreOffice@bielefeldundbus ||s.de Keywords||regression --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-26 23:45:16 PDT --- Bug 51179 - FILESAVE cannot save file as .ppt is a DUP, but I mark this one as DUP because Bug 51179 has more research results *** This bug has been marked as a duplicate of bug 51179 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51179] FILESAVE cannot save file as .ppt
https://bugs.freedesktop.org/show_bug.cgi?id=51179 --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-26 23:45:16 PDT --- *** Bug 51073 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51465] New: The Hyperlink window does not copy text from selection in the document
https://bugs.freedesktop.org/show_bug.cgi?id=51465 Bug #: 51465 Summary: The Hyperlink window does not copy text from selection in the document Classification: Unclassified Product: LibreOffice Version: 3.6.0.0.beta2 Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: narayana...@hotmail.com Often I need to repair an existing link in a odt file. In such case, I have to click anywhere in the link and then click on the Hyperlink button. A Hyperlink window pops up, and shows the existing text and hyperlink. This is fine. But if I select the entire text in the document and then click on the Hyperlink button, the window does not behave properly: The Target field in this window is filled with the existing target. However, the Text field is empty. Desired: Even when I select the entire text of the link (or even select the link partially), the dialog should show me the correct text. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48009] EDITING: Data points missing in line chart
https://bugs.freedesktop.org/show_bug.cgi?id=48009 --- Comment #10 from sasha.libreoff...@gmail.com 2012-06-26 23:59:50 PDT --- I installed it from libreoffice.org In Fedora's repo most new version is 3.3.4 Please, attach ods file with inserted chart. May be I doing something wrong. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48062] [SVG] filter-composite-03-f test fails
https://bugs.freedesktop.org/show_bug.cgi?id=48062 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-06-27 00:12:14 PDT --- Thanks for bugreport reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 and 3.6.beta1 only in File-Open -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51462] UI: Check whether an instance of LibO is running before uninstallation starts
https://bugs.freedesktop.org/show_bug.cgi?id=51462 Andras Timar tima...@gmail.com changed: What|Removed |Added AssignedTo|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | --- Comment #1 from Andras Timar tima...@gmail.com 2012-06-27 00:25:46 PDT --- When you upgrade, uninstallation of older version is done by the old installer. It is not possible to fix already released installers. I'm 99% sure, that this was shirahara's case. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48062] [SVG] filter-composite-03-f test fails
https://bugs.freedesktop.org/show_bug.cgi?id=48062 --- Comment #2 from sasha.libreoff...@gmail.com 2012-06-27 00:38:26 PDT --- Sorry, correction: Link to test: http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/filters-composite-03-f.html There shown that all 4 squares should be without squares inside. But Inkscape and Firefox show all 4 squares with other squares inside. If version that all 4 squares should be without squares inside is correct, then: reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 in both File-Open and Insert-Picture reproduced 3.6.beta1 in both File-Open and Insert-Picture -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48066] [SVG] stroke-linecap=round and stroke-mitterlimit=1 are ignored
https://bugs.freedesktop.org/show_bug.cgi?id=48066 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-06-27 00:56:22 PDT --- Thanks for bugreport Link to site: http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/painting-stroke-03-t.html reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 and 3.6.beta1 only in File-Open -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48067] [SVG] path d=M 50 120 L 430 120 opened as a 6 points polygon
https://bugs.freedesktop.org/show_bug.cgi?id=48067 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-06-27 01:02:13 PDT --- Thanks for bugreport Link to site: http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/painting-stroke-04-t.html reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 and 3.6.beta1 only in File-Open -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51081] EDITING: Multiple Select
https://bugs.freedesktop.org/show_bug.cgi?id=51081 --- Comment #5 from bfoman bfo.bugm...@spamgourmet.com 2012-06-27 01:03:27 PDT --- (In reply to comment #4) But if you make frame, text-frame or insert picture or some object in writer you don't select mutliple element for a copy or align the objects together. (sorry for my english). I had no problems while selecting few object types you mentioned and aligning them. Could you attach any example documents where you have this problem? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48063] [SVG] Open polyline and path elements should be filled as if they were closed
https://bugs.freedesktop.org/show_bug.cgi?id=48063 --- Comment #2 from sasha.libreoff...@gmail.com 2012-06-27 01:10:39 PDT --- Correction: Link to site: http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/painting-control-03-f.html reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 and 3.6.beta1 only in File-Open -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48064] [SVG] fill-rule=nonzero doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=48064 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-06-27 01:13:37 PDT --- Thanks for bugreport Link to site: http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObject/painting-fill-03-t.html reproduced in 3.3.4 on Fedora in both File-Open and Insert-Picture reproduced in 3.5.4 and 3.6.beta1 only in File-Open -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51085] Options Load/Save General: German translation of variants of ODF 1.2 file format wrong/confused
https://bugs.freedesktop.org/show_bug.cgi?id=51085 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED AssignedTo|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | --- Comment #3 from Andras Timar tima...@gmail.com 2012-06-27 01:14:44 PDT --- It has been resolved in beta 2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39415] Table borders in word 200x .doc are shown incorrect in writer
https://bugs.freedesktop.org/show_bug.cgi?id=39415 Michael Stahl mst...@redhat.com changed: What|Removed |Added Version|3.4.1 RC1 |3.4.0 release Component|Printing and PDF export |Writer --- Comment #13 from Michael Stahl mst...@redhat.com 2012-06-27 01:19:02 PDT --- sigh... revert fields that changed themselves... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48080] EDITING: Display problems with multiple comments on screen.
https://bugs.freedesktop.org/show_bug.cgi?id=48080 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #3 from sasha.libreoff...@gmail.com 2012-06-27 01:28:43 PDT --- Thanks for bugreport Please, verify if in last version of LibreOffice still reproducible (3.5.4 or more new) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs