[Libreoffice-commits] core.git: unoidl/Module_unoidl.mk

2013-03-02 Thread Tor Lillqvist
 unoidl/Module_unoidl.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 0b2bbad06c508382deb780814de6c6fde2c6d6fe
Author: Tor Lillqvist t...@iki.fi
Date:   Sat Mar 2 10:12:19 2013 +0200

reg2unoidl not needed for non-desktop OSes

Also, trying to build executables using our sal/main.h stuff for Android
fails (intentionally).

Change-Id: Ic3ff1a46dc95dd87fb33ec38883ce87b4937f05d

diff --git a/unoidl/Module_unoidl.mk b/unoidl/Module_unoidl.mk
index e612d9d..1f8bd73 100644
--- a/unoidl/Module_unoidl.mk
+++ b/unoidl/Module_unoidl.mk
@@ -10,7 +10,9 @@
 $(eval $(call gb_Module_Module,unoidl))
 
 $(eval $(call gb_Module_add_targets,unoidl, \
-Executable_reg2unoidl \
+$(if $(filter DESKTOP,$(BUILD_TYPE)), \
+Executable_reg2unoidl \
+) \
 Library_unoidl \
 Package_inc \
 ))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PATCH] fdo#47011 autosave feature work in progress

2013-03-02 Thread Krisztian Pinter (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2506

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/2506/1

fdo#47011 autosave feature work in progress

Change-Id: Ib2cbcc33e6188c60c183b5f47e9ae9c9d4c91b95
---
M cui/source/options/optsave.cxx
M cui/source/options/optsave.hrc
M cui/source/options/optsave.hxx
M cui/source/options/optsave.src
M framework/inc/services/autorecovery.hxx
M framework/source/services/autorecovery.cxx
M officecfg/registry/data/org/openoffice/Office/Recovery.xcu
M officecfg/registry/schema/org/openoffice/Office/Recovery.xcs
M sfx2/inc/sfx2/sfxsids.hrc
M sfx2/source/appl/appcfg.cxx
M shell/source/backends/gconfbe/gconfaccess.cxx
M shell/source/backends/gconfbe/gconfaccess.hxx
M unotools/inc/unotools/saveopt.hxx
M unotools/source/config/saveopt.cxx
14 files changed, 186 insertions(+), 20 deletions(-)



diff --git a/cui/source/options/optsave.cxx b/cui/source/options/optsave.cxx
index d977cac..2ada021 100644
--- a/cui/source/options/optsave.cxx
+++ b/cui/source/options/optsave.cxx
@@ -55,8 +55,9 @@
 
 #define CFG_PAGE_AND_GROUP  OUString(General), OUString(LoadSave)
 // !! you have to update these index, if you changed the list of the child 
windows !!
-#define WININDEX_AUTOSAVE   ((sal_uInt16)6)
-#define WININDEX_SAVEURL_RELFSYS((sal_uInt16)9)
+#define WININDEX_AUTOSAVE   ((sal_uInt16) 6)
+#define WININDEX_USERAUTOSAVE   ((sal_uInt16) 9)
+#define WININDEX_SAVEURL_RELFSYS((sal_uInt16)10)
 
 // --
 
@@ -102,6 +103,7 @@
 aMinuteFT   ( this, CUI_RES( FT_MINUTE ) ),
 aRelativeFsysCB ( this, CUI_RES( BTN_RELATIVE_FSYS ) ),
 aRelativeInetCB ( this, CUI_RES( BTN_RELATIVE_INET ) ),
+aUserAutoSaveCB ( this, CUI_RES( BTN_USERAUTOSAVE ) ),
 
 aDefaultFormatFL( this, CUI_RES( FL_FILTER ) ),
 aODFVersionFT   ( this, CUI_RES( FT_ODF_VERSION ) ),
@@ -239,11 +241,22 @@
 aAutoSaveEdit.Hide();
 aMinuteFT.Hide();
 // the other controls have to move upwards the height of checkbox + 
space
-nDelta += aRelativeFsysCB.GetPosPixel().Y() - 
aAutoSaveCB.GetPosPixel().Y();
+nDelta += aUserAutoSaveCB.GetPosPixel().Y() - 
aAutoSaveCB.GetPosPixel().Y();
 }
 else if ( nDelta  0 )
 // the AutoSave controls have to move upwards too
 nWinIndex = WININDEX_AUTOSAVE;
+
+if ( aOptionsDlgOpt.IsOptionHidden( UserAutoSave, CFG_PAGE_AND_GROUP ) )
+{
+// hide controls of UserAutoSave
+aUserAutoSaveCB.Hide();
+// the other controls have to move upwards the height of checkbox + 
space
+nDelta += aRelativeFsysCB.GetPosPixel().Y() - 
aUserAutoSaveCB.GetPosPixel().Y();
+}
+else if ( nDelta  0 )
+// the UserAutoSave controls have to move upwards too
+nWinIndex = WININDEX_USERAUTOSAVE;
 
 if ( nDelta  0 )
 {
@@ -313,6 +326,13 @@
 {
 rSet.Put( SfxUInt16Item( GetWhich( SID_ATTR_AUTOSAVEMINUTE ),
  (sal_uInt16)aAutoSaveEdit.GetValue() ) );
+bModified |= sal_True;
+}
+
+if ( aUserAutoSaveCB.IsChecked() != aUserAutoSaveCB.GetSavedValue() )
+{
+rSet.Put( SfxBoolItem( GetWhich( SID_ATTR_USERAUTOSAVE ),
+   aUserAutoSaveCB.IsChecked() ) );
 bModified |= sal_True;
 }
 // save relatively
@@ -489,6 +509,7 @@
 aBackupFI.Show(bBackupRO);
 
 aAutoSaveCB.Check(aSaveOpt.IsAutoSave());
+aUserAutoSaveCB.Check(aSaveOpt.IsUserAutoSave());
 aWarnAlienFormatCB.Check(aSaveOpt.IsWarnAlienFormat());
 
aWarnAlienFormatCB.Enable(!aSaveOpt.IsReadOnly(SvtSaveOptions::E_WARNALIENFORMAT));
 
@@ -515,6 +536,8 @@
 aAutoSaveCB.SaveValue();
 aAutoSaveEdit.SaveValue();
 
+aUserAutoSaveCB.SaveValue();
+
 aRelativeFsysCB.SaveValue();
 aRelativeInetCB.SaveValue();
 aODFVersionLB.SaveValue();
@@ -530,11 +553,13 @@
 {
 aAutoSaveEdit.Enable();
 aMinuteFT.Enable();
+aUserAutoSaveCB.Enable();
 }
 else
 {
 aAutoSaveEdit.Disable();
 aMinuteFT.Disable();
+aUserAutoSaveCB.Disable();
 }
 }
 return 0;
diff --git a/cui/source/options/optsave.hrc b/cui/source/options/optsave.hrc
index 16891bc..36a95b6 100644
--- a/cui/source/options/optsave.hrc
+++ b/cui/source/options/optsave.hrc
@@ -29,6 +29,7 @@
 #define BTN_AUTOSAVE16
 #define ED_AUTOSAVE 17
 #define FT_MINUTE   18
+#define BTN_USERAUTOSAVE19
 #define BTN_NOPRETTYPRINTING20
 #define FI_BACKUP   21
 #define BTN_WARNALIENFORMAT 22
diff --git a/cui/source/options/optsave.hxx b/cui/source/options/optsave.hxx
index 4ab3082..00cb63f 100644
--- a/cui/source/options/optsave.hxx
+++ b/cui/source/options/optsave.hxx
@@ -54,6 +54,7 @@
 

[PATCH] translate german comment

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2507

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/2507/1

translate german comment

Change-Id: I043903ea5b80c6cde7d204fbb28daab167cf40b7
---
M dbaccess/source/ui/inc/TableWindow.hxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/dbaccess/source/ui/inc/TableWindow.hxx 
b/dbaccess/source/ui/inc/TableWindow.hxx
index a72149c..7e0225c 100644
--- a/dbaccess/source/ui/inc/TableWindow.hxx
+++ b/dbaccess/source/ui/inc/TableWindow.hxx
@@ -35,7 +35,7 @@
 namespace dbaui
 {
 //
-// Flags fuer die Groessenanpassung der SbaJoinTabWins
+// Flags for the size adjustment of SbaJoinTabWins
 const sal_uInt16 SIZING_NONE= 0x;
 const sal_uInt16 SIZING_TOP = 0x0001;
 const sal_uInt16 SIZING_BOTTOM  = 0x0002;

-- 
To view, visit https://gerrit.libreoffice.org/2507
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I043903ea5b80c6cde7d204fbb28daab167cf40b7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


autosave feature help

2013-03-02 Thread Krisztian Pinter
Hi All!

I'd like to request some help with implementing a feature. I'm a bsc
student working as a trainee and I'm still very unfamiliar with the LO
codebase.
I was given the task to implement this:
https://bugs.freedesktop.org/show_bug.cgi?id=47011

I have added a checkbox in Tools - Options - Load/Save - General with
the text Save document when saving AutoRecovery information, copying how
other checkboxes work. I triple checked everything, but this checkbox still
won't save its state.

In the code where AutoRecovery does the recovery saving, I have added an
if, so if the value set by the checkbox mentioned above is true, it would
call store() on the file, and save it. I would think I'd also need to do
something else here that lets the UI know that the file has been saved (eg.
the floppy disk icon gets greyed out), but I have no idea where should I
begin with that (I haven't been able to find the code that handles regular
saving.).

Here is what I have done so far: https://gerrit.libreoffice.org/2506

Krisztian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: odk/examples sysui/desktop

2013-03-02 Thread Thomas Arnhold
 odk/examples/cpp/complextoolbarcontrols/Makefile |2 +-
 sysui/desktop/mandriva/mandriva-menus.spec   |   12 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 934cdea97a052f82c87b4d87bd371a105d64e7ed
Author: Thomas Arnhold tho...@arnhold.org
Date:   Sat Mar 2 12:42:53 2013 +0100

-writer - --writer

Change-Id: I78bd922b33d237f36c62ab27e1e383b456797e3a

diff --git a/odk/examples/cpp/complextoolbarcontrols/Makefile 
b/odk/examples/cpp/complextoolbarcontrols/Makefile
index 06af1af..76658e2 100644
--- a/odk/examples/cpp/complextoolbarcontrols/Makefile
+++ b/odk/examples/cpp/complextoolbarcontrols/Makefile
@@ -171,7 +171,7 @@ Example : $(COMP_REGISTERFLAG)
@echo 

 
 run: $(COMP1_COMP_REGISTERFLAG)
-   $(OFFICE_PROGRAM_PATH)$(PS)soffice -writer
+   $(OFFICE_PROGRAM_PATH)$(PS)soffice --writer
 
 
 .PHONY: clean
diff --git a/sysui/desktop/mandriva/mandriva-menus.spec 
b/sysui/desktop/mandriva/mandriva-menus.spec
index 60312d7..00afc1a 100755
--- a/sysui/desktop/mandriva/mandriva-menus.spec
+++ b/sysui/desktop/mandriva/mandriva-menus.spec
@@ -257,7 +257,7 @@ EOF
 # FIXME: Office/Database request in the Cooker ML, leave in Spreadsheets
 # until new group will be created
 #
-GenerateMenu %unixfilename -base \
+GenerateMenu %unixfilename --base \
More Applications/Databases \
base \
%productname %{menuversion} Base \
@@ -265,7 +265,7 @@ GenerateMenu %unixfilename -base \
core01 \

application/vnd.oasis.opendocument.database,application/vnd.sun.xml.base
 
-GenerateMenu %unixfilename -calc \
+GenerateMenu %unixfilename --calc \
Office/Spreadsheets \
calc \
%productname %{menuversion} Calc \
@@ -273,7 +273,7 @@ GenerateMenu %unixfilename -calc \
calc \

application/vnd.oasis.opendocument.spreadsheet,application/vnd.oasis.opendocument.spreadsheet-template,application/vnd.sun.xml.calc,application/vnd.sun.xml.calc.template,application/vnd.stardivision.calc,application/vnd.stardivision.chart,application/msexcel,application/vnd.ms-excel
 
-GenerateMenu %unixfilename -draw \
+GenerateMenu %unixfilename --draw \
Office/Drawing \
draw \
%productname %{menuversion} Draw \
@@ -281,7 +281,7 @@ GenerateMenu %unixfilename -draw \
draw \

application/vnd.oasis.opendocument.graphics,application/vnd.oasis.opendocument.graphics-template,application/vnd.sun.xml.draw,application/vnd.sun.xml.draw.template,application/vnd.stardivision.draw
 
-GenerateMenu %unixfilename -impress \
+GenerateMenu %unixfilename --impress \
Office/Presentations \
impress \
%productname %{menuversion} Impress \
@@ -289,7 +289,7 @@ GenerateMenu %unixfilename -impress \
impress \

application/vnd.oasis.opendocument.presentation,application/vnd.oasis.opendocument.presentation-template,application/vnd.sun.xml.impress,application/vnd.sun.xml.impress.template,application/vnd.stardivision.impress,application/mspowerpoint
 
-GenerateMenu %unixfilename -writer \
+GenerateMenu %unixfilename --writer \
Office/Wordprocessors \
writer \
%productname %{menuversion} Writer \
@@ -297,7 +297,7 @@ GenerateMenu %unixfilename -writer \
writer \

application/vnd.oasis.opendocument.text,application/vnd.oasis.opendocument.text-template,application/vnd.oasis.opendocument.text-web,application/vnd.oasis.opendocument.text-master,application/vnd.sun.xml.writer,application/vnd.sun.xml.writer.template,application/vnd.sun.xml.writer.global,application/vnd.stardivision.writer,application/msword,application/vnd.ms-word,application/x-doc,application/rtf
 
-GenerateMenu %unixfilename -math \
+GenerateMenu %unixfilename --math \
Office/Wordprocessors \
math \
%productname %{menuversion} Math \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: dbaccess/source

2013-03-02 Thread Luc Castermans
 dbaccess/source/ui/inc/TableWindow.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 182b7c697f4ce6bd3b05abdd42482c646e561ee9
Author: Luc Castermans luc.casterm...@gmail.com
Date:   Sat Mar 2 11:46:06 2013 +0100

translate german comment

Change-Id: I043903ea5b80c6cde7d204fbb28daab167cf40b7
Reviewed-on: https://gerrit.libreoffice.org/2507
Reviewed-by: Thomas Arnhold tho...@arnhold.org
Tested-by: Thomas Arnhold tho...@arnhold.org

diff --git a/dbaccess/source/ui/inc/TableWindow.hxx 
b/dbaccess/source/ui/inc/TableWindow.hxx
index a72149c..7e0225c 100644
--- a/dbaccess/source/ui/inc/TableWindow.hxx
+++ b/dbaccess/source/ui/inc/TableWindow.hxx
@@ -35,7 +35,7 @@ class SvTreeListEntry;
 namespace dbaui
 {
 //
-// Flags fuer die Groessenanpassung der SbaJoinTabWins
+// Flags for the size adjustment of SbaJoinTabWins
 const sal_uInt16 SIZING_NONE= 0x;
 const sal_uInt16 SIZING_TOP = 0x0001;
 const sal_uInt16 SIZING_BOTTOM  = 0x0002;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] translate german comment

2013-03-02 Thread Thomas Arnhold (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2507

Approvals:
  Thomas Arnhold: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2507
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I043903ea5b80c6cde7d204fbb28daab167cf40b7
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: dbaccess/source

2013-03-02 Thread David Verrier
 dbaccess/source/ui/querydesign/QueryTableView.cxx |  137 +++---
 1 file changed, 69 insertions(+), 68 deletions(-)

New commits:
commit 5f985d3759f6d424426b04571da90cc02c717db1
Author: David Verrier dverr...@gmail.com
Date:   Wed Feb 27 15:40:56 2013 +0100

fdo#39468: Translate German comments (and messages)

Change-Id: I80444aac8fdf90ea0f595151788afb14d4415cd3
Reviewed-on: https://gerrit.libreoffice.org/2444
Reviewed-by: Thomas Arnhold tho...@arnhold.org
Tested-by: Thomas Arnhold tho...@arnhold.org

diff --git a/dbaccess/source/ui/querydesign/QueryTableView.cxx 
b/dbaccess/source/ui/querydesign/QueryTableView.cxx
index d2e8dff..03892c7 100644
--- a/dbaccess/source/ui/querydesign/QueryTableView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryTableView.cxx
@@ -269,27 +269,28 @@ void OQueryTableView::ReSync()
 DBG_CHKTHIS(OQueryTableView,NULL);
 TTableWindowData* pTabWinDataList = 
m_pView-getController().getTableWindowData();
 OSL_ENSURE((getTableConnections()-size()==0)  
(GetTabWinMap()-size()==0),
-vor OQueryTableView::ReSync() bitte ClearAll aufrufen !);
+before calling OQueryTableView::ReSync() please call ClearAll !);
+
+
+// I need a collection of all window names that cannot be created so that 
I do not initialize connections for them.
 
-// ich brauche eine Sammlung aller Fensternamen, deren Anlegen schief 
geht, damit ich die entsprechenden Connections
-// gar nicht erst anlege
 ::std::vectorString arrInvalidTables;
 
 TTableWindowData::reverse_iterator aIter = pTabWinDataList-rbegin();
-// Fenster kreieren und einfuegen
+// Create the window and add it
 
 for(;aIter != pTabWinDataList-rend();++aIter)
 {
 OQueryTableWindowData* pData = 
static_castOQueryTableWindowData*(aIter-get());
 OTableWindow* pTabWin = createWindow(*aIter);
 
-// ich gehe jetzt NICHT ueber ShowTabWin, da dieses die Daten des 
Fensters in die Liste des Docs einfuegt, was
-// schlecht waere, denn genau von dort hole ich sie ja gerade
-// also Schritt fuer Schritt
+// I dont't use ShowTabWin as this adds the window data to the list of 
documents.
+// This would be bad as I am getting them from there.
+// Instead, I do it step by step
 if (!pTabWin-Init())
 {
-// das Initialisieren ging schief, dass heisst, dieses TabWin 
steht nicht zur Verfuegung, also muss ich es inklusive
-// seiner Daten am Dokument aufraeumen
+// The initialisation has gone wrong, this TabWin is not 
available, so
+// I must clean up the data and the document
 pTabWin-clearListBox();
 delete pTabWin;
 arrInvalidTables.push_back(pData-GetAliasName());
@@ -298,15 +299,15 @@ void OQueryTableView::ReSync()
 continue;
 }
 
-(*GetTabWinMap())[pData-GetAliasName()] = pTabWin; // am Anfang 
einfuegen, da ich die DataList ja rueckwaerts durchlaufe
-// wenn in den Daten keine Position oder Groesse steht - Default
+(*GetTabWinMap())[pData-GetAliasName()] = pTabWin; // add at the 
beginning as I am going backwards through the DataList
+// Use the default if there is no position or size
 if (!pData-HasPosition()  !pData-HasSize())
 SetDefaultTabWinPosSize(pTabWin);
 
 pTabWin-Show();
 }
 
-// Verbindungen einfuegen
+// Add the connections
 TTableConnectionData* pTabConnDataList = 
m_pView-getController().getTableConnectionData();
 TTableConnectionData::reverse_iterator aConIter = 
pTabConnDataList-rbegin();
 
@@ -397,11 +398,11 @@ OTableWindowData* OQueryTableView::CreateImpl(const 
::rtl::OUString _rComposedN
 void OQueryTableView::AddTabWin(const ::rtl::OUString _rTableName, const 
::rtl::OUString _rAliasName, sal_Bool bNewTable)
 {
 DBG_CHKTHIS(OQueryTableView,NULL);
-// das ist die aus der Basisklasse geerbte Methode, die fuehre ich auf die 
an meinem Parent zurueck, die mir eventuell einen
-// Alias dazu bastelt und das an mein anderes AddTabWin weiterreicht
+// This is the method inherited from the base class. I send it back to my 
parent class and my parent
+// may build an Alias and send it on to AddTabWin.
 
-// leider ist _rTableName voll qualifiziert, das OQueryDesignView erwartet 
aber einen String, der
-// nur aus Schema und Tabelle besteht und keinen Katalog enthaelt.
+// Unfortunately _rTableName is fully qualified, but OQueryDesignView 
expects a String consisting
+// of the Schema and Table only and not containing a Catalog.
 Reference XConnection xConnection = 
m_pView-getController().getConnection();
 if(!xConnection.is())
 return;
@@ -461,10 +462,10 @@ ReferenceXPropertySet getKeyReferencedTo(const 
ReferenceXIndexAccess _rxKey
 void OQueryTableView::AddTabWin(const ::rtl::OUString _rComposedName, const 
::rtl::OUString _rTableName, 

[PUSHED] fdo#39468: Translate German comments (and messages)

2013-03-02 Thread Thomas Arnhold (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2444

Approvals:
  Thomas Arnhold: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2444
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80444aac8fdf90ea0f595151788afb14d4415cd3
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Verrier dverr...@gmail.com
Gerrit-Reviewer: Philipp Riemer ruderphil...@gmail.com
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Grammar checker] Undocumented change in the API for LO 4

2013-03-02 Thread Olivier R.
I bibisected from scratch again, on Linux Mint. I got no crash at all.

Result:

20bcb05266724b495f909e6bdc5b253b15515e7d is the first bad commit
commit 20bcb05266724b495f909e6bdc5b253b15515e7d
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Mon Dec 10 23:37:31 2012 +

source-hash-f260c656da4457c5d87c161bdd43ad3023d07472

commit f260c656da4457c5d87c161bdd43ad3023d07472
Author: Michael Stahl mst...@redhat.com
AuthorDate: Wed Oct 24 21:29:00 2012 +0200
Commit: Michael Stahl mst...@redhat.com
CommitDate: Wed Oct 24 21:58:26 2012 +0200

vcl: uipreviewer: remove spurious return false

Change-Id: Ie853d55f78f27a7249b8e960587c8d2bd833d1a7

:100644 100644 dd56205ffd7af4544acf767d928e0fb7c362b83d
7f44424346f71b2444850a3667fbcb6cf1ad374a M  autogen.log
:100644 100644 67df361b388bd5414a4ec178afbdeaadeb28ab12
c243de0266086f2cf364d025ede83dcb5f53fcbe M  ccache.log
:100644 100644 0cc69bf7010e61309aee815ea14e91c076f2c2a9
3d48a17ff896d1e27f4e0cd78c606bd6167043f6 M  commitmsg
:100644 100644 be0612023ec5f0a77e6afc9b23d0e3c96c66c4f4
141809713e042ff39b59de44fe7b570744c7279f M  dev-install.log
:100644 100644 ce6dd2ba02cd975b4350a4c14937a2101222a737
8b188733db3a9cf1f5810fac128a7a17acf5bf43 M  make.log
:04 04 ae9ac7f6e1ba77f1a9b4d8dcb3c04a4304a1c666
5a6c6e9d2d90c720a0b62142f2ce89bc713b42d7 M  opt


git bisect log:

# bad: [5b4b36d87517a6ea96ff8c84c46b12f462fc9a1a]
source-hash-8450a99c744e9005f19173e4df35d65640bcf5c4
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00]
source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9]
source-hash-099198a4224778fe6e43f5dc13b5b9b1b4dc828c
git bisect good 16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9
# good: [f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a]
source-hash-a581d31b227623e09d2970a91214fda398f98eda
git bisect good f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a
# good: [114fd3b76bcba890e6d702d00cef910f1493c262]
source-hash-64ab96cd15e52da88781e720d6f031dbcd0ba902
git bisect good 114fd3b76bcba890e6d702d00cef910f1493c262
# bad: [47498a36f7af8f54e6e3dda89cd4708802a409e6]
source-hash-19f4ebd8a54da0ae03b9cc8481613e5cd20ee1e7
git bisect bad 47498a36f7af8f54e6e3dda89cd4708802a409e6
# bad: [f4e2d84db194943180f3e7ed4adce5f8e377d9bc]
source-hash-806d18ae7b8c241fe90e49d3d370306769c50a10
git bisect bad f4e2d84db194943180f3e7ed4adce5f8e377d9bc
# bad: [20bcb05266724b495f909e6bdc5b253b15515e7d]
source-hash-f260c656da4457c5d87c161bdd43ad3023d07472
git bisect bad 20bcb05266724b495f909e6bdc5b253b15515e7d
# good: [ae1c4bb3a840728755f4390429863629953961dd]
source-hash-b0da54bec69f4931af0adbc15d230d3f4eea7b08
git bisect good ae1c4bb3a840728755f4390429863629953961dd
# good: [ea3a78c17e9a3cb150206f82dd2f615f678731aa]
source-hash-bec62421a45da89d2812bdff30fbbab73291cf91
git bisect good ea3a78c17e9a3cb150206f82dd2f615f678731aa


Olivier



--
View this message in context: 
http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4041086.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Add new dialog to Query Design View

2013-03-02 Thread via Code Review
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2508

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2508/1

Add new dialog to Query Design View

In Query Properties Dialog can be set properties like
distinct values and limit.
To open choose Edit\Query Properties.

Steps of implementation:
- Add new slot to Edit menu (menubar.xml): delete the slot of distinct values,
  because it can set in this dialog too
- Separate LimitBox class from limitboxcontroller.cxx (LimitBox.hxx\cxx)
  With it only LimitBox header is included in the dialog source.
- Extend LimitBox class to work with new layout widget (make... and 
GetOptimalSize())
  and add it to the galde catalog
- Make a class for the new dialog (QueryPropertiesDialog.hxx\cxx) and
  write the .ui file. (querypropertiesdialog.ui)
- Syncronize the two LimitBox (querycontroller.cxx)

Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
---
M dbaccess/Library_dbu.mk
M dbaccess/Module_dbaccess.mk
A dbaccess/UI_dbaccess.mk
M dbaccess/inc/dbaccess_slotid.hrc
A dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
A dbaccess/source/ui/inc/LimitBox.hxx
A dbaccess/source/ui/inc/QueryPropertiesDialog.hxx
M dbaccess/source/ui/inc/querycontroller.hxx
A dbaccess/source/ui/querydesign/LimitBox.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.hxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/uiconfig/dbquery/menubar/menubar.xml
A dbaccess/uiconfig/ui/querypropertiesdialog.ui
M extras/source/glade/libreoffice-catalog.xml
M officecfg/registry/data/org/openoffice/Office/UI/DbuCommands.xcu
16 files changed, 613 insertions(+), 135 deletions(-)



diff --git a/dbaccess/Library_dbu.mk b/dbaccess/Library_dbu.mk
index ef84bfe..fbb385d 100644
--- a/dbaccess/Library_dbu.mk
+++ b/dbaccess/Library_dbu.mk
@@ -166,6 +166,7 @@
 dbaccess/source/ui/dlg/paramdialog \
 dbaccess/source/ui/dlg/queryfilter \
 dbaccess/source/ui/dlg/queryorder \
+dbaccess/source/ui/dlg/QueryPropertiesDialog \
 dbaccess/source/ui/dlg/RelationDlg \
 dbaccess/source/ui/dlg/sqlmessage \
 dbaccess/source/ui/dlg/tablespage \
@@ -214,6 +215,7 @@
 dbaccess/source/ui/querydesign/JoinDesignView \
 dbaccess/source/ui/querydesign/JoinExchange \
 dbaccess/source/ui/querydesign/JoinTableView \
+dbaccess/source/ui/querydesign/LimitBox \
 dbaccess/source/ui/querydesign/limitboxcontroller \
 dbaccess/source/ui/querydesign/QTableConnection \
 dbaccess/source/ui/querydesign/QTableConnectionData \
diff --git a/dbaccess/Module_dbaccess.mk b/dbaccess/Module_dbaccess.mk
index 3195bbf..0e5fe13 100644
--- a/dbaccess/Module_dbaccess.mk
+++ b/dbaccess/Module_dbaccess.mk
@@ -43,6 +43,7 @@
 Library_sdbt \
 Package_inc \
 Package_uiconfig \
+UI_dbaccess \
 ))
 
 $(eval $(call gb_Module_add_check_targets,dbaccess,\
diff --git a/dbaccess/UI_dbaccess.mk b/dbaccess/UI_dbaccess.mk
new file mode 100644
index 000..71c6ddc
--- /dev/null
+++ b/dbaccess/UI_dbaccess.mk
@@ -0,0 +1,16 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_UI_UI,dbaccess))
+
+$(eval $(call gb_UI_add_uifiles,dbaccess, \
+dbaccess/uiconfig/ui/querypropertiesdialog  \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/dbaccess/inc/dbaccess_slotid.hrc b/dbaccess/inc/dbaccess_slotid.hrc
index 37a333e..7d0af41 100644
--- a/dbaccess/inc/dbaccess_slotid.hrc
+++ b/dbaccess/inc/dbaccess_slotid.hrc
@@ -102,6 +102,8 @@
 #define SID_TABLEDESIGN_TABED_PRIMARYKEY ( SID_DBACCESS_START + 67 )
 #define SID_TABLEDESIGN_INSERTROWS  ( SID_DBACCESS_START +  68 )
 
+#define SID_QUERY_PROP_DLG  ( SID_DBACCESS_START +  69 )
+
 
 #endif // _DBACCESS_SLOTID_HRC_
 
diff --git a/dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx 
b/dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
new file mode 100644
index 000..fd37bcd
--- /dev/null
+++ b/dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include QueryPropertiesDialog.hxx
+
+namespace dbaui
+{
+
+QueryPropertiesDialog::QueryPropertiesDialog(
+Window* pParent, const sal_Bool bDistinct, const sal_Int64 nLimit )
+: ModalDialog(pParent, QueryPropertiesDialog, 
dbaccess/ui/querypropertiesdialog.ui)
+, m_pRB_Distinct( 0 )
+, m_pRB_NonDistinct( 0 )
+ 

[PATCH] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot, Michael Stahl,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2491

to look at the new rebased patch set (#2).

Change subject: remove minor.mk
..

remove minor.mk

Hopefully all stays the same except for vcl/unx/gtk/a11y/atkutil.cxx.

Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
---
M Makefile.in
M config_host.mk.in
M configure.ac
M crashrep/WinResTarget_crashrep.mk
M desktop/WinResTarget_sbase.mk
M desktop/WinResTarget_scalc.mk
M desktop/WinResTarget_sdraw.mk
M desktop/WinResTarget_simpress.mk
M desktop/WinResTarget_smath.mk
M desktop/WinResTarget_soffice.mk
M desktop/WinResTarget_sofficebin.mk
M desktop/WinResTarget_sweb.mk
M desktop/WinResTarget_swriter.mk
M instsetoo_native/CustomTarget_install.mk
M solenv/CustomTarget_versionlist.mk
M solenv/Module_solenv.mk
D solenv/Package_minor.mk
M solenv/bin/ooinstall
M solenv/gbuild/gbuild.mk
M solenv/gbuild/platform/WNT_INTEL_GCC.mk
M solenv/gbuild/platform/com_MSC_class.mk
D solenv/inc/.gitignore
D solenv/inc/minor.mk.in
M vcl/Library_vclplug_gtk.mk
M vcl/Library_vclplug_gtk3.mk
M vcl/unx/gtk/a11y/atkutil.cxx
26 files changed, 26 insertions(+), 104 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/2491/2
-- 
To view, visit https://gerrit.libreoffice.org/2491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Correct spelling errors in comments.

2013-03-02 Thread Chris Sherlock (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2509

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/2509/1

Correct spelling errors in comments.

Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659
---
M vcl/source/app/svapp.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 49cc5a7..1619acd 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -433,7 +433,7 @@
 if( pSVData-maAppData.mnDispatchLevel == 0 )
 vcl::LazyDelete::flush();
 
-// the system timer events will not necesseraly come in in non waiting mode
+// the system timer events will not necessarily come in in non waiting mode
 // e.g. on aqua; need to trigger timer checks manually
 if( pSVData-maAppData.mbNoYield  !pSVData-mbNoCallTimer )
 {
@@ -1765,7 +1765,7 @@
 
 // Disable Java bridge on UNIX
 #if defined UNX
-(void) bShowCancel; // unsued
+(void) bShowCancel; // unusued
 (void) rCancelled; // unused
 #else
 bRet = ImplInitAccessBridge( bShowCancel, rCancelled );

-- 
To view, visit https://gerrit.libreoffice.org/2509
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fix build with --disable-scripting option

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2510

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2510/1

fix build with --disable-scripting option

Change-Id: I98dbd3e46c81e1dd056d6e88dc1e526b5af456f5
---
M scp2/source/ooo/file_library_ooo.scp
M scp2/source/ooo/file_ooo.scp
M scp2/source/ooo/file_resource_ooo.scp
3 files changed, 25 insertions(+), 21 deletions(-)



diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 1da3175..292a05f 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -42,6 +42,8 @@
 
 #ifndef DISABLE_SCRIPTING
 
+STD_LIB_FILE( gid_File_Lib_Sf_Prothdlr, protocolhandler )
+
 File gid_File_Lib_Basprov
 LIB_FILE_BODY;
 Styles = (PACKED);
@@ -62,6 +64,21 @@
   #else
 Name = STRING(CONCAT3(vbaevents,.uno,.dll));
   #endif
+End
+
+File gid_File_Lib_Scriptframe
+LIB_FILE_BODY;
+  #ifdef UNX
+#ifdef MACOSX
+   Name = libscriptframe.dylib;
+#else
+   Name = libscriptframe.so;
+#endif
+  #else
+Name = scriptframe.dll;
+  #endif
+Dir = SCP2_OOO_BIN_DIR;
+Styles = (PACKED);
 End
 
 #endif
@@ -280,8 +297,6 @@
   #endif
 End
 
-#endif
-
 File gid_File_Lib_Stringresource
 LIB_FILE_BODY;
 Styles = (PACKED);
@@ -292,8 +307,6 @@
 Name = STRING(CONCAT3(stringresource,.uno,.dll));
   #endif
 End
-
-#ifndef DISABLE_SCRIPTING
 
 File gid_File_Lib_Vbaobj
 LIB_FILE_BODY;
@@ -1004,21 +1017,6 @@
 
 STD_LIB_FILE( gid_File_Lib_Scn, scn)
 
-File gid_File_Lib_Scriptframe
-LIB_FILE_BODY;
-  #ifdef UNX
-#ifdef MACOSX
-   Name = libscriptframe.dylib;
-#else
-   Name = libscriptframe.so;
-#endif
-  #else
-Name = scriptframe.dll;
-  #endif
-Dir = SCP2_OOO_BIN_DIR;
-Styles = (PACKED);
-End
-
 STD_LIB_FILE( gid_File_Lib_Sd , sd)
 STD_LIB_FILE( gid_File_Lib_Sdui, sdui)
 
@@ -1045,8 +1043,6 @@
 End
 
 STD_LIB_FILE( gid_File_Lib_Sdd , sdd)
-
-STD_LIB_FILE( gid_File_Lib_Sf_Prothdlr, protocolhandler )
 
 File gid_File_Lib_Sfx
 Name = LIBNAME(sfx);
diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index a5c2eb9..38e8003 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -57,12 +57,16 @@
 Name = basicsrvform.zip;
 End
 
+#ifndef DISABLE_SCRIPTING
+
 File gid_File_Basic_Scriptbindinglib
 Dir = gid_Dir_Basic_Scriptbindinglib;
 ARCHIVE_TXT_FILE_BODY;
 Name = scriptbindinglib.zip;
 End
 
+#endif
+
 File gid_File_Basic_Template
 Dir = gid_Dir_Basic_Template;
 ARCHIVE_TXT_FILE_BODY;
diff --git a/scp2/source/ooo/file_resource_ooo.scp 
b/scp2/source/ooo/file_resource_ooo.scp
index 29559dc..67a30ed 100644
--- a/scp2/source/ooo/file_resource_ooo.scp
+++ b/scp2/source/ooo/file_resource_ooo.scp
@@ -27,8 +27,12 @@
 
 #include macros.inc
 
+#ifndef DISABLE_SCRIPTING
+
 STD_RES_FILE( gid_File_Res_Basctl, basctl)
 
+#endif
+
 STD_RES_FILE( gid_File_Res_Bib, bib )
 
 STD_RES_FILE( gid_File_Res_Chartcontroller, chartcontroller )

-- 
To view, visit https://gerrit.libreoffice.org/2510
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98dbd3e46c81e1dd056d6e88dc1e526b5af456f5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] coverity#982282: Resource leak in object

2013-03-02 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2511

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/2511/1

coverity#982282: Resource leak in object

Change-Id: Ia7d936c90d7afd4ffa4e22a86289aba47956f576
---
M sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
M sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
2 files changed, 5 insertions(+), 0 deletions(-)



diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
index 15182c2..b556486 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
@@ -486,6 +486,10 @@
 m_pUtf8Map( new UnicodeMap((char*)UTF-8, gTrue, mapUTF8) )
 {
 }
+PDFOutDev::~PDFOutDev()
+{
+delete m_pUtf8Map;
+}
 
 void PDFOutDev::startPage(int /*pageNum*/, GfxState* state)
 {
diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
index e5e48fc..c479624 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
@@ -152,6 +152,7 @@
 
 public:
 explicit PDFOutDev( PDFDoc* pDoc );
+~PDFOutDev();
 
 //- get info about output device
 

-- 
To view, visit https://gerrit.libreoffice.org/2511
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7d936c90d7afd4ffa4e22a86289aba47956f576
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] coverity#982283: Resource leak in object

2013-03-02 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change.

Change subject: coverity#982283: Resource leak in object
..


Patch Set 1: Abandoned

Replaced by https://gerrit.libreoffice.org/#/c/2511
(If someone knows how to change commit message without opening a new gerrit 
tracker, tell me)

-- 
To view, visit https://gerrit.libreoffice.org/2502
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I55fb144adf9c823226dbed31b6ccc92567a7f8bc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Riccardo Magliocchetti riccardo.magliocche...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] translated German comments

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2512

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/2512/1

translated German comments

Change-Id: I6d9b646d9d70dcbf97f7faacc8b15578a597b2a1
---
M dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
1 file changed, 47 insertions(+), 48 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 003c9ac..128fa76 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -135,7 +135,7 @@
 m_pFunctionCell-SetHelpId(HID_QRYDGN_ROW_FUNCTION);
 
 //
-// TriState der ::com::sun::star::form::CheckBox abschalten
+// switch off triState of ::com::sun::star::form::CheckBox
 m_pVisibleCell-GetBox().EnableTriState( sal_False );
 
 Font aTitleFont = OutputDevice::GetDefaultFont( 
DEFAULTFONT_SANS_UNICODE,Window::GetSettings().GetLanguageTag().getLanguageType(),DEFAULTFONT_FLAGS_ONLYONE);
@@ -151,7 +151,7 @@
 for(long i=0;i  BROW_ROW_CNT;i++)
 m_bVisibleRow.push_back(sal_True);
 
-m_bVisibleRow[BROW_FUNCTION_ROW] = sal_False;   // zuerst ausblenden
+m_bVisibleRow[BROW_FUNCTION_ROW] = sal_False;   // first hide
 
 m_timerInvalidate.SetTimeout(200);
 m_timerInvalidate.SetTimeoutHdl(LINK(this, OSelectionBrowseBox, 
OnInvalidateTimer));
@@ -271,7 +271,7 @@
 if ( 0 == m_pBrowseBox-GetSelectColumnCount() )
 {
 m_pBrowseBox-DeactivateCell();
-// wenn es schon eine selektierte Spalte gibt, bin ich schon im 
richtigen Modus
+// we are in the right mode if a row hase been selected row
 if ( BROWSER_HIDESELECT == ( nMode  BROWSER_HIDESELECT ) )
 {
 nMode = ~BROWSER_HIDESELECT;
@@ -354,7 +354,7 @@
 }
 SetDataRowHeight(aHeight.Height());
 SetTitleLines(1);
-// Anzahl der sichtbaren Zeilen ermitteln
+// get number of visible rows
 for(long i=0;iBROW_ROW_CNT;i++)
 {
 if(m_bVisibleRow[i])
@@ -492,7 +492,7 @@
 
 getDesignView()-fillValidFields(aTable, m_pFieldCell);
 
-// * durch alias.* ersetzen
+// translate with alias.*
 if ((aField.GetChar(0) == '*')  aTable.Len())
 {
 aField = aTable;
@@ -532,7 +532,7 @@
 
 if(!pEntry-IsVisible()  pEntry-GetOrderDir() != ORDER_NONE  
!m_bOrderByUnRelated)
 {
-// Spalte muss sichtbar sein, um im ORDER BY aufzutauchen
+   // a column has to visible in order to show up in ORDER BY
 pEntry-SetVisible(sal_True);
 m_pVisibleCell-GetBox().Check(pEntry-IsVisible());
 m_pVisibleCell-GetBox().SaveValue();
@@ -921,7 +921,7 @@
 
 if (pEntry.is()  Controller().Is()  Controller()-IsModified())
 {
-// fuer die Undo-Action
+// for the Undo-action
 String strOldCellContents,sNewValue;
 long nRow = GetRealRow(GetCurRow());
 sal_Bool bAppendRow = sal_False;
@@ -956,7 +956,7 @@
 pNewEntry-SetColumnId( pEntry-GetColumnId() );
 
::std::replace(getFields().begin(),getFields().end(),pEntry,pNewEntry);
 sal_uInt16 nCol = GetCurColumnId();
-for (int i = 0; i  m_nVisibleCount; i++)   // Spalte 
neu zeichnen
+for (int i = 0; i  m_nVisibleCount; i++)   // redraw 
column
 RowModified(i,nCol);
 }
 else
@@ -1060,7 +1060,7 @@
 {
 strOldCellContents = pEntry-GetFunction();
 sal_uInt16 nPos = m_pFunctionCell-GetSelectEntryPos();
-// Diese Funktionen stehen nur unter CORE zur Verf�gung
+// these functions are only available in CORE
 String sFunctionName= 
m_pFunctionCell-GetEntry(nPos);
 String sGroupFunctionName   = 
m_aFunctionStrings.GetToken(comphelper::string::getTokenCount(m_aFunctionStrings,
 ';')-1);
 sal_Bool bGroupBy = sal_False;
@@ -1203,21 +1203,21 @@
 
 if(!bError)
 {
-// und noch die Undo-Action fuer das Ganze
+// and now the undo-action for the total
 appendUndoAction(strOldCellContents,sNewValue,nRow);
 
 }
 }
 
-// habe ich Daten in einer FieldDescription gespeichert, die vorher leer 
war und es nach den Aenderungen nicht mehr ist ?
+// did I store data in a FieldDescription which was empty before and which 
is not empty anymore after the changes?
 if ( pEntry.is()  bWasEmpty  !pEntry-IsEmpty()  !bError )
 {
-// Default auf sichtbar
+

[PATCH] translated last German comment in this file

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2513

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/2513/1

translated last German comment in this file

Change-Id: I6e8e65156d23682a2045019c7703c57f2448d1dc
---
M dbaccess/source/ui/inc/WCopyTable.hxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/dbaccess/source/ui/inc/WCopyTable.hxx 
b/dbaccess/source/ui/inc/WCopyTable.hxx
index 87098f6..9a95655 100644
--- a/dbaccess/source/ui/inc/WCopyTable.hxx
+++ b/dbaccess/source/ui/inc/WCopyTable.hxx
@@ -335,7 +335,7 @@
 OKButton   GetOKButton() { return m_pbFinish; }
 Wizard_Button_Style GetPressedButton() const { return m_ePressed; }
 voidEnableButton(Wizard_Button_Style eStyle,sal_Bool 
bEnable);
-voidAddWizardPage(OWizardPage* pPage); // Page wird 
von OCopyTableWizard gelöscht
+voidAddWizardPage(OWizardPage* pPage); // delete page 
from OCopyTableWizard
 voidRemoveWizardPage(OWizardPage* pPage); // Page goes 
again to user
 voidCheckButtons(); // checks which button can be 
disabled, enabled
 

-- 
To view, visit https://gerrit.libreoffice.org/2513
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e8e65156d23682a2045019c7703c57f2448d1dc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#38838 Replaced some use of (Uni)String with OUString.

2013-03-02 Thread via Code Review
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2514

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/2514/1

fdo#38838 Replaced some use of (Uni)String with OUString.

Change-Id: Iad623c9300919fbae34279268a5a720f978c6434
---
M sd/inc/stlsheet.hxx
M sd/source/core/drawdoc3.cxx
M sd/source/core/stlpool.cxx
M sd/source/core/stlsheet.cxx
M sd/source/ui/func/futempl.cxx
M svl/inc/svl/style.hxx
M svl/source/items/style.cxx
M sw/inc/docstyle.hxx
M sw/inc/swtypes.hxx
M sw/source/core/bastyp/swtypes.cxx
M sw/source/core/fields/fldbas.cxx
M sw/source/ui/app/docstyle.cxx
M tools/source/rc/resmgr.cxx
M vcl/win/source/gdi/salgdi3.cxx
14 files changed, 33 insertions(+), 36 deletions(-)



diff --git a/sd/inc/stlsheet.hxx b/sd/inc/stlsheet.hxx
index 191bcf9..8476222 100644
--- a/sd/inc/stlsheet.hxx
+++ b/sd/inc/stlsheet.hxx
@@ -61,7 +61,7 @@
 virtual boolHasParentSupport() const;
 virtual boolHasClearParentSupport() const;
 virtual boolSetName( const UniString );
-virtual voidSetHelpId( const String r, sal_uLong nId );
+virtual voidSetHelpId( const OUString r, sal_uLong nId );
 
 voidAdjustToFontHeight(SfxItemSet rSet, sal_Bool 
bOnlyMissingItems = sal_True);
 
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index ef6a28b..50e22ed 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -1451,7 +1451,7 @@
 else
 {
 // create new style
-String aHelpFile;
+OUString aHelpFile;
 pMySheet = static_castSfxStyleSheet*( 
mxStyleSheetPool-Make(aName, SD_STYLE_FAMILY_MASTERPAGE, 
pHisSheet-GetMask()) );
 pMySheet-SetHelpId( aHelpFile, 
pHisSheet-GetHelpId(aHelpFile) );
 pMySheet-GetItemSet().ClearItem(0);  // Delete all
diff --git a/sd/source/core/stlpool.cxx b/sd/source/core/stlpool.cxx
index 8fb287f..86c6915 100644
--- a/sd/source/core/stlpool.cxx
+++ b/sd/source/core/stlpool.cxx
@@ -193,7 +193,7 @@
 * outline levels
 **/
 String aName(SdResId(STR_LAYOUT_OUTLINE));
-String aHelpFile;
+OUString aHelpFile;
 
 SfxStyleSheetBase* pParent = NULL;
 SvxLRSpaceItem aSvxLRSpaceItem( EE_PARA_LRSPACE );
@@ -599,7 +599,7 @@
 
 void SdStyleSheetPool::CopySheets(SdStyleSheetPool rSourcePool, 
SfxStyleFamily eFamily, SdStyleSheetVector rCreatedSheets)
 {
-String aHelpFile;
+OUString aHelpFile;
 
 sal_uInt32 nCount = rSourcePool.aStyles.size();
 
@@ -659,7 +659,7 @@
 std::vectorString aNameList;
 CreateLayoutSheetNames(rLayoutName,aNameList);
 
-String sEmpty;
+OUString sEmpty;
 for (std::vectorString::const_iterator it = aNameList.begin(); it != 
aNameList.end(); ++it)
 {
 pSheet = Find(*it, SD_STYLE_FAMILY_MASTERPAGE);
@@ -784,7 +784,7 @@
 void SdStyleSheetPool::CreatePseudosIfNecessary()
 {
 String aName;
-String aHelpFile;
+OUString aHelpFile;
 SfxStyleSheetBase* pSheet = NULL;
 SfxStyleSheetBase* pParent = NULL;
 
@@ -869,7 +869,7 @@
 
 void SdStyleSheetPool::UpdateStdNames()
 {
-String aHelpFile;
+OUString aHelpFile;
 sal_uInt32  nCount = aStyles.size();
 std::vectorSfxStyleSheetBase* aEraseList;
 
@@ -880,7 +880,7 @@
 if( !pStyle-IsUserDefined() )
 {
 String aOldName = pStyle-GetName();
-sal_uLong nHelpId   = pStyle-GetHelpId( aHelpFile );
+sal_uLong nHelpId   = pStyle-GetHelpId( aHelpFile );
 SfxStyleFamily eFam = pStyle-GetFamily();
 
 sal_Bool bHelpKnown = sal_True;
@@ -972,7 +972,7 @@
 void SdStyleSheetPool::PutNumBulletItem( SfxStyleSheetBase* pSheet,
  Font rBulletFont )
 {
-String aHelpFile;
+OUString aHelpFile;
 sal_uLong nHelpId = pSheet-GetHelpId( aHelpFile );
 SfxItemSet rSet = pSheet-GetItemSet();
 
diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index 0854049..52a60e5 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -662,7 +662,7 @@
 
 // 
 
-void SdStyleSheet::SetHelpId( const String r, sal_uLong nId )
+void SdStyleSheet::SetHelpId( const OUString r, sal_uLong nId )
 {
 SfxStyleSheet::SetHelpId( r, nId );
 
@@ -1073,7 +1073,7 @@
 
 if( (pEntry-nWID == EE_PARA_NUMBULLET)  (GetFamily() == 
SD_STYLE_FAMILY_MASTERPAGE) )
 {
-String aStr;
+OUString aStr;
 const sal_uInt32 nTempHelpId = GetHelpId( aStr );
 
 if( (nTempHelpId = HID_PSEUDOSHEET_OUTLINE2)  (nTempHelpId = 
HID_PSEUDOSHEET_OUTLINE9) )
diff --git a/sd/source/ui/func/futempl.cxx 

FDO#39468 Translated German comments to English

2013-03-02 Thread Gábor Nyers
Hi,
  
All my contributions, past and future, to LibreOffice are licensed under
the terms of the MPL/LGPv3+ Greetings,

Gábor Nyers
From 7af24e3c3613cb0701be3b857dbf465c84cc85c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=A1bor=20Nyers?= gny...@opensuse.org
Date: Sat, 2 Mar 2013 15:36:29 +0100
Subject: [PATCH] FDO#39468 Translated German comments to English

---
 comphelper/inc/comphelper/syntaxhighlight.hxx  |   37 +---
 comphelper/source/misc/syntaxhighlight.cxx |7 ++--
 dbaccess/source/ui/inc/TableWindow.hxx |6 ++--
 dbaccess/source/ui/inc/WCopyTable.hxx  |2 +-
 .../ui/querydesign/QueryDesignFieldUndoAct.hxx |   18 ++
 5 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/comphelper/inc/comphelper/syntaxhighlight.hxx b/comphelper/inc/comphelper/syntaxhighlight.hxx
index 11a57db..5241713 100644
--- a/comphelper/inc/comphelper/syntaxhighlight.hxx
+++ b/comphelper/inc/comphelper/syntaxhighlight.hxx
@@ -63,10 +63,10 @@ struct HighlightPortion { sal_uInt16 nBegin; sal_uInt16 nEnd; TokenTypes tokenTy
 typedef std::vectorHighlightPortion HighlightPortions;
 
 /
-// Hilfsklasse zur Untersuchung von JavaScript-Modulen, zunaechst zum
-// Heraussuchen der Funktionen, spaeter auch zum Syntax-Highlighting verwenden
+// Auxiliary class to support JavaScript modules, next to find functions which
+// will later will be used for syntax highlighting
 
-//  Flags fuer Zeichen-Eigenschaften
+// Flags for character properties
 #define CHAR_START_IDENTIFIER   0x0001
 #define CHAR_IN_IDENTIFIER  0x0002
 #define CHAR_START_NUMBER   0x0004
@@ -81,8 +81,8 @@ typedef std::vectorHighlightPortion HighlightPortions;
 #define CHAR_EOF0x00
 
 
-// Sprachmodus des HighLighters (spaeter eventuell feiner
-// differenzieren mit Keyword-Liste, C-Kommentar-Flag)
+// Language mode of the Highlighter (possibly to be refined later with keyword
+// lists, C comment flags) 
 enum HighlighterLanguage
 {
 HIGHLIGHT_BASIC,
@@ -92,23 +92,23 @@ enum HighlighterLanguage
 class SimpleTokenizer_Impl
 {
 HighlighterLanguage aLanguage;
-// Zeichen-Info-Tabelle
+// Character information tables
 sal_uInt16 aCharTypeTab[256];
 
 const sal_Unicode* mpStringBegin;
 const sal_Unicode* mpActualPos;
 
-// Zeile und Spalte
+// Lines and columns
 sal_uInt32 nLine;
 sal_uInt32 nCol;
 
 sal_Unicode peekChar( void ){ return *mpActualPos; }
 sal_Unicode getChar( void ) { nCol++; return *mpActualPos++; }
 
-// Hilfsfunktion: Zeichen-Flag Testen
+// Auxiliary function: testing of the character flags
 sal_Bool testCharFlags( sal_Unicode c, sal_uInt16 nTestFlags );
 
-// Neues Token holen, Leerstring == nix mehr da
+// Get new token, EmptyString == nothing more over there
 sal_Bool getNextToken( /*out*/TokenTypes reType,
 /*out*/const sal_Unicode* rpStartPos, /*out*/const sal_Unicode* rpEndPos );
 
@@ -126,13 +126,11 @@ public:
 };
 
 
-//*** SyntaxHighlighter-Klasse ***
-// Konzept: Der Highlighter wird ueber alle Aenderungen im Source
-// informiert (notifyChange) und liefert dem Aufrufer jeweils die
-// Information zurueck, welcher Zeilen-Bereich des Source-Codes
-// aufgrund dieser Aenderung neu gehighlighted werden muss.
-// Dazu merkt sich Highlighter intern fuer jede Zeile, ob dort
-// C-Kommentare beginnen oder enden.
+//*** SyntaxHighlighter Class ***
+// Concept: the Highlighter will be notified of all changes in the source
+// (notifyChange) and returns the caller the range of lines, which based on the
+// changes, need to be highlighted again. For this the Highlighter marks all
+// lines internally whether or not C comments begin or end.
 class COMPHELPER_DLLPUBLIC SyntaxHighlighter
 {
 HighlighterLanguage eLanguage;
@@ -146,10 +144,9 @@ public:
 SyntaxHighlighter( void );
 ~SyntaxHighlighter( void );
 
-// HighLighter (neu) initialisieren, die Zeilen-Tabelle wird
-// dabei komplett geloescht, d.h. im Abschluss wird von einem
-// leeren Source ausgegangen. In notifyChange() kann dann
-// nur Zeile 0 angegeben werden.
+// (Re-)initialize Highlighter. The line-table will be completely erased,
+// meaning that on completion an empty Source is assumed.
+// notifyChange() can only be given line 0
 void initialize( HighlighterLanguage eLanguage_ );
 
 void notifyChange( sal_uInt32 nLine, sal_Int32 nLineCountDifference,
diff --git a/comphelper/source/misc/syntaxhighlight.cxx b/comphelper/source/misc/syntaxhighlight.cxx
index 2064c0c..84790eb 100644
--- a/comphelper/source/misc/syntaxhighlight.cxx
+++ b/comphelper/source/misc/syntaxhighlight.cxx
@@ -411,9 +411,8 @@ sal_Bool SimpleTokenizer_Impl::getNextToken( /*out*/TokenTypes reType,
 reType = TT_COMMENT;
 }
 
-// Echter Operator, kann hier einfach behandelt 

[PATCH] translated German comments

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2515

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2515/1

translated German comments

Change-Id: If89452824776c2bd653ca0728cc7e6adf4050e4b
---
M dbaccess/source/ui/tabledesign/TableUndo.cxx
1 file changed, 19 insertions(+), 19 deletions(-)



diff --git a/dbaccess/source/ui/tabledesign/TableUndo.cxx 
b/dbaccess/source/ui/tabledesign/TableUndo.cxx
index 75a8879..68d97e3 100644
--- a/dbaccess/source/ui/tabledesign/TableUndo.cxx
+++ b/dbaccess/source/ui/tabledesign/TableUndo.cxx
@@ -63,7 +63,7 @@
 m_pTabDgnCtrl-m_nCurUndoActId--;
 
 //
-// Wenn erstes Undo zurueckgenommen wurde, ist Doc nicht modifiziert worden
+// doc has not been modified if first undo was reverted
 if( m_pTabDgnCtrl-m_nCurUndoActId == 0 )
 {
 m_pTabDgnCtrl-GetView()-getController().setModified(sal_False);
@@ -77,7 +77,7 @@
 m_pTabDgnCtrl-m_nCurUndoActId++;
 
 //
-// Wenn Redo fuer erste Undo-Action, muss Modified-Flag wieder gesetzt 
werden
+// restore Modifed-flag after Redo of first Undo-action
 if( m_pTabDgnCtrl-m_nCurUndoActId  0 )
 {
 m_pTabDgnCtrl-GetView()-getController().setModified(sal_True);
@@ -95,7 +95,7 @@
 {
 DBG_CTOR(OTableDesignCellUndoAct,NULL);
 //
-// Text an der Position (m_nRow, m_nCol) auslesen
+// read text at position (m_nRow, m_nCol)
 m_sOldText = m_pTabDgnCtrl-GetCellData( m_nRow, m_nCol );
 }
 
@@ -109,12 +109,12 @@
 void OTableDesignCellUndoAct::Undo()
 {
 //
-// Neuen Text der alten Zelle speichern und alten wieder einsetzen
+// store text at old line and restore the old one
 m_pTabDgnCtrl-ActivateCell( m_nRow, m_nCol );
 m_sNewText = m_pTabDgnCtrl-GetCellData( m_nRow, m_nCol );
 m_pTabDgnCtrl-SetCellData( m_nRow, m_nCol, m_sOldText );
 //
-// Wenn erstes Undo zurueckgenommen wurde, ist Zelle nicht mehr modifiziert
+// line has not been modified if the first Undo was reverted
 if (m_pTabDgnCtrl-GetCurUndoActId() == 1)
 {
 CellControllerRef xController = m_pTabDgnCtrl-Controller();
@@ -131,7 +131,7 @@
 void OTableDesignCellUndoAct::Redo()
 {
 //
-// Neuen Text wieder einseten
+// restore new text
 m_pTabDgnCtrl-ActivateCell( m_nRow, m_nCol );
 m_pTabDgnCtrl-SetCellData( m_nRow, m_nCol, m_sNewText );
 
@@ -178,7 +178,7 @@
 void OTableEditorTypeSelUndoAct::Undo()
 {
 //
-// Typ zuruecksetzen
+// restore type
 OFieldDescription* pFieldDesc = pTabEdCtrl-GetFieldDescr(m_nRow);
 if(pFieldDesc)
 m_pNewType = pFieldDesc-getTypeInfo();
@@ -194,7 +194,7 @@
 void OTableEditorTypeSelUndoAct::Redo()
 {
 //
-// Neuen Typ
+// new type
 pTabEdCtrl-GoToRowColumnId( m_nRow ,m_nCol);
 pTabEdCtrl-SetCellData(m_nRow,m_nCol,m_pNewType);
 
@@ -210,7 +210,7 @@
 {
 DBG_CTOR(OTableEditorDelUndoAct,NULL);
 //
-// DeletedRowList fuellen
+// fill DeletedRowList
 ::std::vector ::boost::shared_ptrOTableRow * pOriginalRows = 
pOwner-GetRowList();
 long nIndex = pOwner-FirstSelectedRow();
  ::boost::shared_ptrOTableRow  pOriginalRow;
@@ -237,7 +237,7 @@
 void OTableEditorDelUndoAct::Undo()
 {
 //
-// Geloeschte Zeilen wieder einfuegen
+// Insert the deleted line
 sal_uLong nPos;
 ::std::vector ::boost::shared_ptrOTableRow ::iterator aIter = 
m_aDeletedRows.begin();
 ::std::vector ::boost::shared_ptrOTableRow ::iterator aEnd = 
m_aDeletedRows.end();
@@ -261,7 +261,7 @@
 void OTableEditorDelUndoAct::Redo()
 {
 //
-// Zeilen wieder loeschen
+// delete line again
 sal_uLong nPos;
 ::std::vector ::boost::shared_ptrOTableRow ::iterator aIter = 
m_aDeletedRows.begin();
 ::std::vector ::boost::shared_ptrOTableRow ::iterator aEnd = 
m_aDeletedRows.end();
@@ -304,7 +304,7 @@
 void OTableEditorInsUndoAct::Undo()
 {
 //
-// Eingefuegte Zeilen wieder loeschen
+// delete lines again
 ::std::vector ::boost::shared_ptrOTableRow * pOriginalRows = 
pTabEdCtrl-GetRowList();
 for( long i=(m_nInsPos+m_vInsertedRows.size()-1); i(m_nInsPos-1); 

Need help regarding BUG #60700

2013-03-02 Thread Alex Ivan
Hi,

I've been looking into  bug #60700
https://bugs.freedesktop.org/show_bug.cgi?id=60700   and have currently
managed to figure out when those empty directories are created.
Can anybody tell what those directories -should- contain when not empty?
Also, if someone could give me a scenario to follow in order to obtain, for
example, an .odt file in which said directories are not empty, it would
really help me.

Thanks in advance,
Alex Ivan



--
View this message in context: 
http://nabble.documentfoundation.org/Need-help-regarding-BUG-60700-tp4041113.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


LAST REMINDER: save your homes on kermit

2013-03-02 Thread Florian Effenberger

Hello,

in a few hours, the old kermit (88.198.53.251) will be put offline and 
all data will be deleted.


This is the third and last reminder: In case you have something 
important in your home directories, please do save it *NOW*.


Thanks,
Florian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


compilation failure on centos 6

2013-03-02 Thread Neeraj Rai
Hi,

I am getting a compilation failure on Centos 6. It seems -lX11 will solve
it, but I am not sure where to change. Please advise.
Neeraj
output log :

(12/18) Building module tail_build
=
Entering /data2/work/sid0/dev/builddir/libreoffice-4.0.0.3/tail_build/prj

[build LNK] Executable/oosplash
/data2/work/sid0/dev/builddir/libreoffice-4.0.0.3/workdir/
unxlngx6.pro/CObject/desktop/unx/source/splashx.o: In function
`create_pixmap':
splashx.c:(.text+0x57e): undefined reference to `XCreatePixmap'
splashx.c:(.text+0x5af): undefined reference to `XCreateGC'

-- collect2: ld returned 1 exit status
make[2]: *** [/data2/work/sid0/dev/builddir/libreoffice-4.0.0.3/workdir/
unxlngx6.pro/LinkTarget/Executable/oosplash] Error 1

-- 
=
Intuition - is the inability to figure out the facts on which we based the
decision.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Add new dialog to Query Design View

2013-03-02 Thread David Ostrovsky (via Code Review)
Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2508

to look at the new rebased patch set (#2).

Change subject: Add new dialog to Query Design View
..

Add new dialog to Query Design View

In Query Properties Dialog can be set properties like
distinct values and limit.
To open choose Edit\Query Properties.

Steps of implementation:
- Add new slot to Edit menu (menubar.xml): delete the slot of distinct values,
  because it can set in this dialog too
- Separate LimitBox class from limitboxcontroller.cxx (LimitBox.hxx\cxx)
  With it only LimitBox header is included in the dialog source.
- Extend LimitBox class to work with new layout widget (make... and 
GetOptimalSize())
  and add it to the galde catalog
- Make a class for the new dialog (QueryPropertiesDialog.hxx\cxx) and
  write the .ui file. (querypropertiesdialog.ui)
- Syncronize the two LimitBox (querycontroller.cxx)

Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
---
M dbaccess/Library_dbu.mk
M dbaccess/Module_dbaccess.mk
A dbaccess/UI_dbaccess.mk
M dbaccess/inc/dbaccess_slotid.hrc
A dbaccess/source/ui/dlg/QueryPropertiesDialog.cxx
A dbaccess/source/ui/inc/LimitBox.hxx
A dbaccess/source/ui/inc/QueryPropertiesDialog.hxx
M dbaccess/source/ui/inc/querycontroller.hxx
A dbaccess/source/ui/querydesign/LimitBox.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.cxx
M dbaccess/source/ui/querydesign/limitboxcontroller.hxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/uiconfig/dbquery/menubar/menubar.xml
A dbaccess/uiconfig/ui/querypropertiesdialog.ui
M extras/source/glade/libreoffice-catalog.xml
M officecfg/registry/data/org/openoffice/Office/UI/DbuCommands.xcu
16 files changed, 613 insertions(+), 135 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/2508/2
-- 
To view, visit https://gerrit.libreoffice.org/2508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib84bef5a2ed55030333d6151342b99ff27766538
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||60589

--- Comment #116 from Cor Nouws c...@nouenoff.nl ---
Adding Bug 60589 - [Template manager]: Can not copy styles between different
files and templates

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: config_host.mk.in configure.ac crashrep/WinResTarget_crashrep.mk desktop/WinResTarget_sbase.mk desktop/WinResTarget_scalc.mk desktop/WinResTarget_sdraw.mk desktop/WinRe

2013-03-02 Thread Matúš Kukan
 Makefile.in  |4 ---
 config_host.mk.in|1 
 configure.ac |   12 ---
 crashrep/WinResTarget_crashrep.mk|2 -
 desktop/WinResTarget_sbase.mk|2 -
 desktop/WinResTarget_scalc.mk|2 -
 desktop/WinResTarget_sdraw.mk|2 -
 desktop/WinResTarget_simpress.mk |2 -
 desktop/WinResTarget_smath.mk|2 -
 desktop/WinResTarget_soffice.mk  |2 -
 desktop/WinResTarget_sofficebin.mk   |2 -
 desktop/WinResTarget_sweb.mk |2 -
 desktop/WinResTarget_swriter.mk  |2 -
 instsetoo_native/CustomTarget_install.mk |2 -
 solenv/CustomTarget_versionlist.mk   |   18 ++--
 solenv/Module_solenv.mk  |1 
 solenv/Package_minor.mk  |   33 ---
 solenv/bin/ooinstall |   13 +---
 solenv/gbuild/gbuild.mk  |2 -
 solenv/gbuild/platform/WNT_INTEL_GCC.mk  |2 -
 solenv/gbuild/platform/com_MSC_class.mk  |2 -
 solenv/inc/.gitignore|2 -
 solenv/inc/minor.mk.in   |9 
 vcl/Library_vclplug_gtk.mk   |1 
 vcl/Library_vclplug_gtk3.mk  |1 
 vcl/unx/gtk/a11y/atkutil.cxx |7 +-
 26 files changed, 26 insertions(+), 104 deletions(-)

New commits:
commit ee0dd367156bbc7eac6047e9a772782e56496f59
Author: Matúš Kukan matus.ku...@gmail.com
Date:   Fri Mar 1 13:50:16 2013 +0100

remove minor.mk

Hopefully all stays the same except for vcl/unx/gtk/a11y/atkutil.cxx.

Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
Reviewed-on: https://gerrit.libreoffice.org/2491
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: David Ostrovsky david.ostrov...@gmx.de
Tested-by: David Ostrovsky david.ostrov...@gmx.de

diff --git a/Makefile.in b/Makefile.in
index 13a635f..208f619 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -31,7 +31,6 @@ Makefile: $(BUILDDIR)/config_host.mk force-restart
 $(BUILDDIR)/config_host.mk : \
$(SRCDIR)/config_host.mk.in \
$(SRCDIR)/Makefile.in \
-   $(SRCDIR)/solenv/inc/minor.mk.in \
$(SRCDIR)/instsetoo_native/util/openoffice.lst.in \
$(SRCDIR)/configure.ac \
$(BUILDDIR)/autogen.lastrun
@@ -129,8 +128,7 @@ distclean : clean compilerplugins-clean
 $(BUILDDIR)/config_host/*.mk \
 $(BUILDDIR)/configure \
 $(BUILDDIR)/instsetoo_native/util/openoffice.lst \
-$(BUILDDIR)/lo.xcent \
-$(BUILDDIR)/solenv/inc/minor.mk
+$(BUILDDIR)/lo.xcent
find $(SOLARENV)/gdb -name *.pyc -exec rm {} \;
 
 #
diff --git a/config_host.mk.in b/config_host.mk.in
index 828bcd6..8dd533a 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -298,6 +298,7 @@ export LIBLOADER_JAR=@LIBLOADER_JAR@
 export LIBMGR_X64_BINARY=@LIBMGR_X64_BINARY@
 export LIBMYSQL=@LIBMYSQL@
 export LIBMYSQL_PATH=@LIBMYSQL_PATH@
+export LIBO_THIS_YEAR=@LIBO_THIS_YEAR@
 export LIBO_VERSION_MAJOR=@LIBO_VERSION_MAJOR@
 export LIBO_VERSION_MICRO=@LIBO_VERSION_MICRO@
 export LIBO_VERSION_MINOR=@LIBO_VERSION_MINOR@
diff --git a/configure.ac b/configure.ac
index 5b503c9..45980d8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4053,7 +4053,6 @@ if test $cross_compiling = yes; then
 bin/get_config_variables \
 solenv/bin/getcompver.awk \
 solenv/inc/langlist.mk \
-solenv/inc/minor.mk.in \
 instsetoo_native/util/openoffice.lst.in) \
 | (cd CONF-FOR-BUILD  tar xf -)
 cp configure CONF-FOR-BUILD
@@ -11845,17 +11844,6 @@ if test -f config_host.mk; then
 fi
 
 AC_CONFIG_FILES([config_host.mk Makefile lo.xcent 
instsetoo_native/util/openoffice.lst])
-# Unlike AC_CONFIG_HEADERS, AC_CONFIG_FILES updates the target file even if 
the contents
-# would be unchanged, avoid that.
-AC_CONFIG_FILES([solenv/inc/minor.mk.tmp:solenv/inc/minor.mk.in],
-[
-AC_MSG_NOTICE([creating solenv/inc/minor.mk])
-if diff solenv/inc/minor.mk.tmp solenv/inc/minor.mk /dev/null 21 ; then
-AC_MSG_NOTICE([solenv/inc/minor.mk is unchanged])
-else
-cp -f solenv/inc/minor.mk.tmp solenv/inc/minor.mk
-fi
-])
 AC_CONFIG_HEADERS([config_host/config_clang.h])
 AC_CONFIG_HEADERS([config_host/config_global.h])
 AC_CONFIG_HEADERS([config_host/config_graphite.h])
diff --git a/crashrep/WinResTarget_crashrep.mk 
b/crashrep/WinResTarget_crashrep.mk
index 6036157..c4c44ad 100644
--- a/crashrep/WinResTarget_crashrep.mk
+++ b/crashrep/WinResTarget_crashrep.mk
@@ -16,7 +16,7 @@ $(eval $(call gb_WinResTarget_use_custom_headers,crashrep,\
 $(eval $(call gb_WinResTarget_add_defs,crashrep,\
 -DRES_APP_NAME=crashrep \
 -DRES_APP_FILEDESC=$(PRODUCTNAME) Crashreporter \
--DVERVARIANT=$(BUILD) \
+

[Libreoffice-commits] core.git: vcl/source

2013-03-02 Thread Chris
 vcl/source/app/svapp.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7cd26df20b4964152cd452682587e52a8408c066
Author: Chris chris.sherloc...@gmail.com
Date:   Sun Mar 3 00:17:19 2013 +1100

Correct spelling errors in comments.

Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659
Reviewed-on: https://gerrit.libreoffice.org/2509
Reviewed-by: David Ostrovsky david.ostrov...@gmx.de
Tested-by: David Ostrovsky david.ostrov...@gmx.de

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 9182b1c..e8402c4 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -433,7 +433,7 @@ inline void ImplYield( bool i_bWait, bool i_bAllEvents )
 if( pSVData-maAppData.mnDispatchLevel == 0 )
 vcl::LazyDelete::flush();
 
-// the system timer events will not necesseraly come in in non waiting mode
+// the system timer events will not necessarily come in in non waiting mode
 // e.g. on aqua; need to trigger timer checks manually
 if( pSVData-maAppData.mbNoYield  !pSVData-mbNoCallTimer )
 {
@@ -1782,7 +1782,7 @@ bool InitAccessBridge( bool bShowCancel, bool rCancelled 
)
 
 // Disable Java bridge on UNIX
 #if defined UNX
-(void) bShowCancel; // unsued
+(void) bShowCancel; // unusued
 (void) rCancelled; // unused
 #else
 bRet = ImplInitAccessBridge( bShowCancel, rCancelled );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] remove minor.mk

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2491

Approvals:
  LibreOffice gerrit bot: Verified
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49108007ee6d045f045de86c8654efc7ca5fd3d0
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] Correct spelling errors in comments.

2013-03-02 Thread David Ostrovsky (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2509

Approvals:
  David Ostrovsky: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2509
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I360d4672225ba86466d5ecf0abf615172a7c3659
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||60593

--- Comment #117 from Cor Nouws c...@nouenoff.nl ---
Bug 60593 - [Template manager] Creating new template directory is unnecessarily
hard 
has various duplicates/closely related issues

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||61468

--- Comment #118 from Cor Nouws c...@nouenoff.nl ---
Add Bug 61468 - [Template manager] [accessibility] UI broken for key board
navigation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||51556

--- Comment #119 from Cor Nouws c...@nouenoff.nl ---
Bug 51556 - FORMATTING [accessibility] Tab/keyboard behaviour in dialog
Conditional formatting strange

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] let rsc create dep file for all platforms

2013-03-02 Thread via Code Review
Matúš Kukan has abandoned this change.

Change subject: let rsc create dep file for all platforms
..


Patch Set 2: Abandoned

Oh really. I don't understand what I was thinking.
I was in believe we do this only on Windows.. confused com_GCC_class.mk with 
WNT_INTEL_GCC.mk or something, sorry.

-- 
To view, visit https://gerrit.libreoffice.org/2471
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic2406c548c013d381a5b22f514d4807877230251
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Michael Stahl mst...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] translated German comments

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2516

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/2516/1

translated German comments

Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
---
M dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
1 file changed, 6 insertions(+), 5 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx 
b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
index 5482bb8..7b89147 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
@@ -27,7 +27,7 @@
 namespace dbaui
 {
 // 

-// OQueryDesignFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung 
im Abfrageentwurf
+   // OQueryDesignFieldUndoAct - Basisclass for undo's in the fieldlist of a 
query design
 
 
 class OQueryDesignFieldUndoAct : public OCommentUndoAction
@@ -52,7 +52,7 @@
 };
 
 // 

-// OTabFieldCellModifiedUndoAct - Undo-Klasse fuer Aendern einer Zelle 
einer Spaltenbeschreibung
+// OTabFieldCellModifiedUndoAct - undo class to change a line of the 
column description
 
 class OTabFieldCellModifiedUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -73,7 +73,7 @@
 };
 
 // 

-// OTabFieldSizedUndoAct - Undo-Klasse fuer Aendern einer Spaltenbreite
+// OTabFieldSizedUndoAct - undo class to change the column width
 
 class OTabFieldSizedUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -90,7 +90,7 @@
 };
 
 // 

-// OTabFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung im 
Abfrageentwurf, die mit Veraendern einer kompletten Feldbeschreibung zu tun 
haben
+// OTabFieldUndoAct - base class for undos in the fieldlist of a query 
design, which are used to change complete field descriptions
 
 class OTabFieldUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -104,7 +104,7 @@
 };
 
 // 

-// OTabFieldDelUndoAct - Undo-Klasse fuer Loeschen eines Feldes
+// OTabFieldDelUndoAct - undo class to delete a field
 
 class OTabFieldDelUndoAct : public OTabFieldUndoAct
 {
@@ -118,6 +118,7 @@
 
 // 

 // OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes
+// OTabFieldDelUndoAct - undo class to create a field
 
 class OTabFieldCreateUndoAct : public OTabFieldUndoAct
 {

-- 
To view, visit https://gerrit.libreoffice.org/2516
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: vcl/source

2013-03-02 Thread Thomas Arnhold
 vcl/source/app/svapp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6b599d590cbaf8134bacced50e87f923ad908757
Author: Thomas Arnhold tho...@arnhold.org
Date:   Sat Mar 2 18:18:34 2013 +0100

typo

Change-Id: I2ec76c375beae644555226fcc2e94a2030d190c5

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index e8402c4..17d5f61 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -1782,7 +1782,7 @@ bool InitAccessBridge( bool bShowCancel, bool rCancelled 
)
 
 // Disable Java bridge on UNIX
 #if defined UNX
-(void) bShowCancel; // unusued
+(void) bShowCancel; // unused
 (void) rCancelled; // unused
 #else
 bRet = ImplInitAccessBridge( bShowCancel, rCancelled );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: dbaccess/source

2013-03-02 Thread Luc Castermans
 dbaccess/source/ui/inc/WCopyTable.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dc33a06d89aff71e0190780fdec02c63277844b6
Author: Luc Castermans luc.casterm...@gmail.com
Date:   Sat Mar 2 15:36:53 2013 +0100

translated last German comment in this file

Change-Id: I6e8e65156d23682a2045019c7703c57f2448d1dc
Reviewed-on: https://gerrit.libreoffice.org/2513
Reviewed-by: Joren De Cuyper joren.libreoff...@telenet.be
Reviewed-by: Thomas Arnhold tho...@arnhold.org
Tested-by: Thomas Arnhold tho...@arnhold.org

diff --git a/dbaccess/source/ui/inc/WCopyTable.hxx 
b/dbaccess/source/ui/inc/WCopyTable.hxx
index 87098f6..9a95655 100644
--- a/dbaccess/source/ui/inc/WCopyTable.hxx
+++ b/dbaccess/source/ui/inc/WCopyTable.hxx
@@ -335,7 +335,7 @@ namespace dbaui
 OKButton   GetOKButton() { return m_pbFinish; }
 Wizard_Button_Style GetPressedButton() const { return m_ePressed; }
 voidEnableButton(Wizard_Button_Style eStyle,sal_Bool 
bEnable);
-voidAddWizardPage(OWizardPage* pPage); // Page wird 
von OCopyTableWizard gelöscht
+voidAddWizardPage(OWizardPage* pPage); // delete page 
from OCopyTableWizard
 voidRemoveWizardPage(OWizardPage* pPage); // Page goes 
again to user
 voidCheckButtons(); // checks which button can be 
disabled, enabled
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] translated last German comment in this file

2013-03-02 Thread Thomas Arnhold (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2513

Approvals:
  Joren De Cuyper: Looks good to me, but someone else must approve
  Thomas Arnhold: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2513
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e8e65156d23682a2045019c7703c57f2448d1dc
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com
Gerrit-Reviewer: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] translated German comments (file is clean now)

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2517

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/2517/1

translated German comments (file is clean now)

Change-Id: I1f833fe4a2332c1b2fa1e98fd320e55f7e19c649
---
M dbaccess/source/ui/querydesign/QueryDesignView.cxx
1 file changed, 16 insertions(+), 15 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 912e30f..a2335f9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -567,16 +567,16 @@
 const ::connectivity::OSQLParseNode 
*pRightTable)
 {
 SqlParseError eErrorCode = eOk;
-if (pNode-count() == 3   // Ausdruck is geklammert
+if (pNode-count() == 3   // statment between brackets
 SQL_ISPUNCTUATION(pNode-getChild(0),() 
 SQL_ISPUNCTUATION(pNode-getChild(2),)))
 {
 eErrorCode = InsertJoinConnection(_pView,pNode-getChild(1), 
_eJoinType,pLeftTable,pRightTable);
 }
-else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)  
 // AND/OR-Verknuepfung:
+else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)  
 // AND/OR-joints:
  pNode-count() == 3)
 {
-// nur AND Verkn�pfung zulassen
+// only allow AND joints
 if (!SQL_ISTOKEN(pNode-getChild(1),AND))
 eErrorCode = eIllegalJoinCondition;
 else if ( eOk == (eErrorCode = 
InsertJoinConnection(_pView,pNode-getChild(0), 
_eJoinType,pLeftTable,pRightTable)) )
@@ -2909,19 +2909,20 @@
 OUString aFieldListStr(GenerateSelectList(this,rFieldList,nTabcount1));
 if( aFieldListStr.isEmpty() )
 return OUString();
-// Ausnahmebehandlung, wenn keine Felder angegeben worden sind
-// Dann darf die Tabpage nicht gewechselt werden
-// Im TabBarSelectHdl wird der SQL-OUString auf STATEMENT_NOFIELDS 
abgefragt
-// und eine Errormeldung erzeugt
-// - Tabellenliste aufbauen --
+
+// Exceptionhandling, if no fields have been passed we should not
+// change the tab page
+// TabBarSelectHdl will query the SQL-OUString for STATEMENT_NOFIELDS
+// and trigger a error message
+// - Build table list --
 
 const ::std::vectorOTableConnection** pConnList = 
m_pTableView-getTableConnections();
 Reference XConnection xConnection = rController.getConnection();
 OUString aTableListStr(GenerateFromClause(xConnection,pTabList,pConnList));
 OSL_ENSURE(!aTableListStr.isEmpty(), OQueryDesignView::getStatement() : 
unexpected : have Fields, but no Tables !);
-// wenn es Felder gibt, koennen die nur durch Einfuegen aus einer schon 
existenten Tabelle entstanden sein; wenn andererseits
-// eine Tabelle geloescht wird, verschwinden auch die zugehoerigen Felder 
- ergo KANN es das nicht geben, dass Felder
-// existieren, aber keine Tabellen (und aFieldListStr hat schon eine 
Laenge, das stelle ich oben sicher)
+// if fields exist now, these only can be created by inserting from an 
already existing table; if on the other hand
+// a table is deleted, also the belonging fields will be deleted - 
therefore it CANNOT occur that fields
+// exist but no tables exist (and aFieldListStr has its length, I secure 
this above)
 OUStringBuffer aHavingStr,aCriteriaListStr;
 // - Kriterien aufbauen --
 if (!GenerateCriterias(this,aCriteriaListStr,aHavingStr,rFieldList, 
nTabcount  1))
@@ -2941,7 +2942,7 @@
 }
 aCriteriaListStr = aTmp;
 }
-// - Statement aufbauen --
+// - construct statement  --
 OUStringBuffer aSqlCmd(OUString(RTL_CONSTASCII_USTRINGPARAM(SELECT )));
 if(rController.isDistinct())
 aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( DISTINCT )));
@@ -2954,7 +2955,7 @@
 aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( WHERE )));
 aSqlCmd.append(aCriteriaListStr.makeStringAndClear());
 }
-// - GroupBy aufbauen und Anhangen 
+// - construct GroupBy and attachen 
 ReferenceXDatabaseMetaData xMeta;
 if ( xConnection.is() )
 xMeta = xConnection-getMetaData();
@@ -2963,13 +2964,13 @@
 bUseAlias = bUseAlias || !xMeta-supportsGroupByUnrelated();
 
 aSqlCmd.append(GenerateGroupBy(this,rFieldList,bUseAlias));
-// - having Anhangen 
+// - attache having  
 if(aHavingStr.getLength())
 {
 aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( HAVING )));
 

[Libreoffice-commits] core.git: postprocess/CustomTarget_registry.mk

2013-03-02 Thread David Ostrovsky
 postprocess/CustomTarget_registry.mk |   19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 61e8d865fd2f3de9668c3176747362e4aaf0054e
Author: David Ostrovsky da...@ostrovsky.org
Date:   Sat Mar 2 18:46:26 2013 +0100

respect DBCONNECTIVITY option for shipping mork driver

Change-Id: If91a3fa6ad8bd1e359e472efacad9d3051cde17c

diff --git a/postprocess/CustomTarget_registry.mk 
b/postprocess/CustomTarget_registry.mk
index f2c798d..b88e4ef 100644
--- a/postprocess/CustomTarget_registry.mk
+++ b/postprocess/CustomTarget_registry.mk
@@ -63,6 +63,15 @@ ifeq (DBCONNECTIVITY,$(filter DBCONNECTIVITY,$(BUILD_TYPE)))
 postprocess_FILES_calc += \
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Drivers-calc.xcu
 postprocess_DRIVERS += calc
+ifeq (WNT,$(OS))
+ifeq ($(WITH_MOZAB4WIN),YES)
+postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Drivers-mozab.xcu
+postprocess_DRIVERS += mozab
+endif
+else ifeq (DESKTOP,$(filter DESKTOP,$(BUILD_TYPE)))
+postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Drivers-mork.xcu
+postprocess_DRIVERS += mork
+endif
 endif
 
 postprocess_DEPS_cjk := main
@@ -339,16 +348,6 @@ postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Dr
 postprocess_DRIVERS += kab
 endif
 
-ifeq (WNT,$(OS))
-ifeq ($(WITH_MOZAB4WIN),YES)
-postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Drivers-mozab.xcu
-postprocess_DRIVERS += mozab
-endif
-else ifeq (DESKTOP,$(filter DESKTOP,$(BUILD_TYPE)))
-postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/DataAccess/Drivers-mork.xcu
-postprocess_DRIVERS += mork
-endif
-
 ifneq (,$(SYSTEM_LIBEXTTEXTCAT_DATA))
 postprocess_FILES_main += 
$(postprocess_MOD)/org/openoffice/Office/Paths-externallibexttextcatdata.xcu
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


--disable-database-connectivity option is broken?

2013-03-02 Thread David Ostrovsky

Hi,

do we still support --disable-database-connectivity or should it be 
removed as once --disable-xmlsecurity?

I am asking because it is currently broken.

First problem is Module_postprocess.mk: Rdb_services is failing to copy 
the components (that weren't built yet).

While uncommenting that line (temporaly) even more weird problems occur:
https://ci.idaia.de/job/LO-Ubuntu-Head/32/console

Mutiple undefines because many objects in svx are excluded from the 
build with this condition

in Library_svxcore.mk:

[...]
ifneq (,$(filter DBCONNECTIVITY,$(BUILD_TYPE)))
[...]

while other objects that actually using these objects are always 
included and the symbols are missing.
My first thought was to include the missing objects unconditionally, but 
that failed because
they depends (in svx) on connectivity, that is disabled with 
--disable-database-connectivity:


svx/inc/svx/dbtoolsclient.hxx
#include connectivity/virtualdbtools.hxx

so i gave up and ask your advice how to fix it (or remove that option)?

Thanks
David

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: solenv/gbuild

2013-03-02 Thread Peter Foley
 solenv/gbuild/AllLangHelp.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5b272379dbfb27875c1fbeed98d71699c8beaec7
Author: Peter Foley pefol...@verizon.net
Date:   Sat Mar 2 12:55:46 2013 -0500

always build help for en-US

Change-Id: Ibcde46381cac50058f93e26f0eceb9b1446d1702

diff --git a/solenv/gbuild/AllLangHelp.mk b/solenv/gbuild/AllLangHelp.mk
index 2e4599e..a6c4562 100644
--- a/solenv/gbuild/AllLangHelp.mk
+++ b/solenv/gbuild/AllLangHelp.mk
@@ -17,7 +17,7 @@ gb_AllLangHelp_TRANLATIONSDIR := $(SRCDIR)/translations
 
 # Creates and delivers all language versions of a module.
 
-gb_AllLangHelp_LANGS := $(gb_WITH_LANG)
+gb_AllLangHelp_LANGS := en-US $(gb_WITH_LANG)
 
 define gb_AllLangHelp__translation_exists
 $(or \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: config_host.mk.in configure.ac liborcus/ExternalProject_liborcus.mk

2013-03-02 Thread Peter Foley
 config_host.mk.in|1 +
 configure.ac |   22 +-
 liborcus/ExternalProject_liborcus.mk |4 +++-
 3 files changed, 25 insertions(+), 2 deletions(-)

New commits:
commit d79bdca7e472c25973388daafdae34d49e393180
Author: Peter Foley pefol...@verizon.net
Date:   Sat Mar 2 12:57:39 2013 -0500

fix build on android with gcc 4.7

See https://code.google.com/p/android/issues/detail?id=41770

Change-Id: I555c1e9b8b15afd78b07b1c7b12a0b37d1112f9a

diff --git a/config_host.mk.in b/config_host.mk.in
index 8dd533a..11d95cd 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -32,6 +32,7 @@ export ATL_LIB=@ATL_LIB@
 export AWTLIB=@AWTLIB@
 export BARCODE_EXTENSION_PACK=@BARCODE_EXTENSION_PACK@
 export BOOST_CPPFLAGS=@BOOST_CPPFLAGS@
+export BOOST_CXXFLAGS=@BOOST_CXXFLAGS@
 export BOOST_DATE_TIME_LIB=@BOOST_DATE_TIME_LIB@
 export BOOST_LDFLAGS=@BOOST_LDFLAGS@
 export BOOST_SYSTEM_LIB=@BOOST_SYSTEM_LIB@
diff --git a/configure.ac b/configure.ac
index 45980d8..62d2f78 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5005,7 +5005,7 @@ if test $GXX = yes; then
 fi
 fi
 if test $_gpp_majmin -ge 401; then
-AC_MSG_ERROR([You need to use the g++-4.0 compiler (g++ 
$_gpp_version won't work with the MacOSX10.4u.sdk) - set CXX accordingly])
+AC_MSG_ERROR([You need to use the g++-4.0 compiler (g++ 
$_gpp_version will not work with the MacOSX10.4u.sdk) - set CXX accordingly])
 else
 AC_MSG_RESULT([implicitly using CXX=$CXX])
 fi
@@ -5036,7 +5036,27 @@ if test $GXX = yes; then
 }
 ]])],[AC_MSG_ERROR([your version of the GNU C++ compile has a bug 
which prevents LibreOffice from being compiled correctly - please check 
http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00968.html for 
details.])],[AC_MSG_RESULT([no])],[])
 fi
+dnl see https://code.google.com/p/android/issues/detail?id=41770
+if test $_gpp_majmin -ge 407; then
+glibcxx_threads=no
+AC_MSG_CHECKING([whether $CXX is broken with boost.thread])
+AC_LANG_PUSH([C++])
+AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
+#include bits/c++config.h]],[[
+#if !defined(_GLIBCXX_HAVE_GTHR_DEFAULT) \
+ !defined(_GLIBCXX__PTHREADS) \
+ !defined(_GLIBCXX_HAS_GTHREADS)
+choke me
+#endif
+]])],[AC_MSG_RESULT([yes])
+glibcxx_threads=yes],[AC_MSG_RESULT([no])])
+AC_LANG_POP([C++])
+if test $glibcxx_threads = yes; then
+  BOOST_CXXFLAGS=-D_GLIBCXX_HAS_GTHREADS
+fi
+ fi
 fi
+AC_SUBST(BOOST_CXXFLAGS)
 
 #
 # prefx CXX with ccache if needed
diff --git a/liborcus/ExternalProject_liborcus.mk 
b/liborcus/ExternalProject_liborcus.mk
index 7b12302..e932648 100644
--- a/liborcus/ExternalProject_liborcus.mk
+++ b/liborcus/ExternalProject_liborcus.mk
@@ -67,7 +67,9 @@ $(call gb_ExternalProject_get_state_target,liborcus,build) :
--disable-spreadsheet-model \
--disable-werror \
$(if $(filter LINUX FREEBSD OPENBSD NETBSD DRAGONFLY 
ANDROID,$(OS)),$(if $(gb_ENABLE_DBGUTIL),CPPFLAGS=-D_GLIBCXX_DEBUG)) \
-   $(if $(filter NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(call 
gb_UnpackedTarball_get_dir,boost),CXXFLAGS=$(BOOST_CPPFLAGS) 
LDFLAGS=$(BOOST_LDFLAGS)) \
+   CXXFLAGS=$(BOOST_CXXFLAGS) $(if $(filter 
NO,$(SYSTEM_BOOST)),\
+   -I$(call 
gb_UnpackedTarball_get_dir,boost),$(BOOST_CPPFLAGS)) \
+   $(if $(filter 
YES,$(SYSTEM_BOOST)),LDFLAGS=$(BOOST_LDFLAGS)) \
$(if $(filter 
YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \
 $(MAKE) \
)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: solenv/gbuild

2013-03-02 Thread Peter Foley
 solenv/gbuild/platform/com_GCC_defs.mk |2 +-
 solenv/gbuild/platform/unxgcc.mk   |   11 ++-
 2 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit 5b1d2fd1e6c39d44ad65c3aec1b496c7a446b1ea
Author: Peter Foley pefol...@verizon.net
Date:   Sat Mar 2 13:05:18 2013 -0500

more lto fixes

Change-Id: I97eb27a354dfb6b6d94886729c5b6df0b0f7687a

diff --git a/solenv/gbuild/platform/com_GCC_defs.mk 
b/solenv/gbuild/platform/com_GCC_defs.mk
index 4f64bff..02e3acd 100644
--- a/solenv/gbuild/platform/com_GCC_defs.mk
+++ b/solenv/gbuild/platform/com_GCC_defs.mk
@@ -108,7 +108,7 @@ gb_CXXFLAGS_COMMON += -DLIBO_MERGELIBS
 endif
 
 ifeq ($(ENABLE_LTO),TRUE)
-gb_Library_LTOFLAGS := -flto
+gb_Library_LTOFLAGS := -flto -fno-use-linker-plugin
 endif
 
 gb_LinkTarget_EXCEPTIONFLAGS := \
diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk
index 1b85ced..104fe7f 100644
--- a/solenv/gbuild/platform/unxgcc.mk
+++ b/solenv/gbuild/platform/unxgcc.mk
@@ -104,11 +104,12 @@ gb_CXXFLAGS += -Wno-deprecated-declarations
 endif
 endif
 
-ifeq ($(ENABLE_LTO),TRUE)
-ifneq ($(COM_GCC_IS_CLANG),TRUE)
-gb_LinkTarget_LTOFLAGS += -fuse-linker-plugin $(gb_COMPILERDEFAULTOPTFLAGS)
-endif
-endif
+# Breaks the build, needs more testing
+#ifeq ($(ENABLE_LTO),TRUE)
+#ifneq ($(COM_GCC_IS_CLANG),TRUE)
+#gb_LinkTarget_LTOFLAGS += -fuse-linker-plugin $(gb_COMPILERDEFAULTOPTFLAGS)
+#endif
+#endif
 
 ifneq ($(strip $(SYSBASE)),)
 gb_CXXFLAGS += --sysroot=$(SYSBASE)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PATCH] build userfriendly targets from toplevel

2013-03-02 Thread Peter Foley (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2518

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/2518/1

build userfriendly targets from toplevel

Change-Id: Iffbe6d4570bf4d4bdd7347260a6bb4160af24515
---
M Makefile.in
M solenv/gbuild/Module.mk
2 files changed, 38 insertions(+), 8 deletions(-)



diff --git a/Makefile.in b/Makefile.in
index 208f619..6164f8a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -74,7 +74,7 @@
cd $(SRCDIR)/$(1)  $(GNUMAKE) -j $(CHECK_PARALLELISM) 
$(GMAKE_OPTIONS) subsequentcheck
 
 $(1).all: bootstrap fetch
-   $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -f 
$(SRCDIR)/Makefile.build $(WORKDIR)/Module/$(1) $(WORKDIR)/Module/check/$(1) 
$(WORKDIR)/Module/slowcheck/$(1)
+   $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -f 
$(SRCDIR)/Makefile.build Module_$(1) Module_$(1).check Module_$(1).slowcheck
 
 endef
 
@@ -84,13 +84,42 @@
 
 $(eval $(call gbuild_modules_rules,$(filter-out Module%,$(subst /, ,$(subst 
$(SRCDIR)/,,$(wildcard $(SRCDIR)/*/Module_*.mk))
 
-# run a JunitTest - relies on naming convention (module prefix)
-$(WORKDIR)/JunitTest/%/done :
-   cd $(firstword $(subst _, ,$*))  $(GNUMAKE) $(GMAKE_OPTIONS) $@
-
-# run a CppunitTest - relies on naming convention (module prefix)
-$(WORKDIR)/CppunitTest/%.test :
-   cd $(firstword $(subst _, ,$*))  $(GNUMAKE) $(GMAKE_OPTIONS) $@
+gbuild_TARGETS := AllLangHelp \
+   AllLangResTarget \
+   AllLangZip \
+   AutoInstallLibs \
+   CliLibrary \
+   CliNativeLibrary \
+   CliUnoApiTarget \
+   Configuration \
+   CppunitTest \
+   CustomTarget \
+   Dictionary \
+   Executable \
+   Extension \
+   ExternalPackage \
+   ExternalProject \
+   InstallModule \
+   InstallScript \
+   InternalUnoApi \
+   Jar \
+   JunitTest \
+   Library \
+   Module \
+   Package \
+   Pagein \
+   Pyuno \
+   Rdb \
+   StaticLibrary \
+   UI \
+   UnoApi \
+   UnoApiMerge \
+   UnpackedTarball \
+   WinResTarget \
+   Zip
+# build a generic gbuild target
+$(foreach target,$(gbuild_TARGETS),$(target)_%):
+   $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) -f 
$(SRCDIR)/Makefile.build $@
 
 #
 # Clean
diff --git a/solenv/gbuild/Module.mk b/solenv/gbuild/Module.mk
index 9f545a4..4952651 100644
--- a/solenv/gbuild/Module.mk
+++ b/solenv/gbuild/Module.mk
@@ -164,6 +164,7 @@
 gb_Module_CLEANTARGETSTACK := $(call gb_Module_get_clean_target,$(1)) 
$(gb_Module_CLEANTARGETSTACK)
 gb_Module_CURRENTMODULE_DEBUG_ENABLED := $(call gb_Module__debug_enabled,$(1))
 gb_Module_CURRENTMODULE_NAME := $(1)
+$(call gb_Helper_make_userfriendly_targets,$(1),Module)
 
 endef
 

-- 
To view, visit https://gerrit.libreoffice.org/2518
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffbe6d4570bf4d4bdd7347260a6bb4160af24515
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley pefol...@verizon.net

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] ersetzen = replace in stead of translate

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2519

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/2519/1

ersetzen = replace in stead of translate

Change-Id: I8d355d58c3720201554c68be0c82245383eec1ed
---
M dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index 128fa76..ff4e780 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -492,7 +492,7 @@
 
 getDesignView()-fillValidFields(aTable, m_pFieldCell);
 
-// translate with alias.*
+// replace with alias.*
 if ((aField.GetChar(0) == '*')  aTable.Len())
 {
 aField = aTable;

-- 
To view, visit https://gerrit.libreoffice.org/2519
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d355d58c3720201554c68be0c82245383eec1ed
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: --disable-database-connectivity option is broken?

2013-03-02 Thread Tor Lillqvist
 I am asking because it is currently broken.

Well, it does say Work in progress, use only if you are hacking on it.

I see it likely that I (or somebody) *will* eventually (and relatively
soon, like within a year or so) continue to hack on it, so it doesn't
hurt to keep it there, does it?

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Libre

2013-03-02 Thread Adriam Delgado Rivero


Using UNO API for java and charge a template that contains a table  

I try to copy that table on the next page ( also property ) to create a new 
 and I find as 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 4 commits - android/experimental vcl/android vcl/inc vcl/source

2013-03-02 Thread Tor Lillqvist
 
android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
 |   53 +++
 vcl/android/androidinst.cxx
|   69 ++
 vcl/inc/vcl/event.hxx  
|   60 
 vcl/inc/vcl/svapp.hxx  
|4 
 vcl/inc/vcl/vclevent.hxx   
|2 
 vcl/source/app/svapp.cxx   
|   14 ++
 6 files changed, 172 insertions(+), 30 deletions(-)

New commits:
commit c859cc21cd4b577b4e7df8955375fcc5df2bd980
Author: Tor Lillqvist t...@iki.fi
Date:   Sat Mar 2 20:58:15 2013 +0200

Start hacking on zoom and scroll events at the VCL public level

On the internal (Sal) VCL level they will correspond to wheel mouse 
events,
I guess.

Change-Id: Ia422f892d73afe501f529020c2aed9ff8fca99f9

diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx
index 7fa7779..fdac1ec 100644
--- a/vcl/android/androidinst.cxx
+++ b/vcl/android/androidinst.cxx
@@ -922,10 +922,9 @@ 
Java_org_libreoffice_experimental_desktop_Desktop_key(JNIEnv * /* env */,
   jchar c,
   jshort /* timestamp */)
 {
-KeyEvent aEvent(c, c, 0);
-
 SalFrame *pFocus = AndroidSalInstance::getInstance()-getFocusFrame();
 if (pFocus) {
+KeyEvent aEvent(c, c, 0);
 Application::PostKeyEvent(VCLEVENT_WINDOW_KEYINPUT, 
pFocus-GetWindow(), aEvent);
 Application::PostKeyEvent(VCLEVENT_WINDOW_KEYUP, pFocus-GetWindow(), 
aEvent);
 }
@@ -942,30 +941,30 @@ 
Java_org_libreoffice_experimental_desktop_Desktop_touch(JNIEnv * /* env */,
 jint y,
 jshort /* timestamp */)
 {
-MouseEvent aEvent;
-
-sal_uLong nEvent;
-switch (action) {
-case AMOTION_EVENT_ACTION_DOWN:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
-nEvent = VCLEVENT_WINDOW_MOUSEBUTTONDOWN;
-break;
-case AMOTION_EVENT_ACTION_UP:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
-nEvent = VCLEVENT_WINDOW_MOUSEBUTTONUP;
-break;
-case AMOTION_EVENT_ACTION_MOVE:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLEMOVE, MOUSE_LEFT);
-nEvent = VCLEVENT_WINDOW_MOUSEMOVE;
-break;
-default:
-LOGE(Java_org_libreoffice_experimental_desktop_Desktop_touch: Invalid 
action %d, action);
-return;
-}
-
 SalFrame *pFocus = AndroidSalInstance::getInstance()-getFocusFrame();
-if (pFocus)
+if (pFocus) {
+MouseEvent aEvent;
+sal_uLong nEvent;
+
+switch (action) {
+case AMOTION_EVENT_ACTION_DOWN:
+aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
+nEvent = VCLEVENT_WINDOW_MOUSEBUTTONDOWN;
+break;
+case AMOTION_EVENT_ACTION_UP:
+aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
+nEvent = VCLEVENT_WINDOW_MOUSEBUTTONUP;
+break;
+case AMOTION_EVENT_ACTION_MOVE:
+aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLEMOVE, MOUSE_LEFT);
+nEvent = VCLEVENT_WINDOW_MOUSEMOVE;
+break;
+default:
+LOGE(Java_org_libreoffice_experimental_desktop_Desktop_touch: 
Invalid action %d, action);
+return;
+}
 Application::PostMouseEvent(nEvent, pFocus-GetWindow(), aEvent);
+}
 else
 LOGW(No focused frame to emit event on);
 }
@@ -978,12 +977,13 @@ 
Java_org_libreoffice_experimental_desktop_Desktop_zoom(JNIEnv * /* env */,
jint x,
jint y)
 {
-(void) x;
-(void) y;
-
-if (scale  1.05) {
-} else if (scale  0.95) {
+SalFrame *pFocus = AndroidSalInstance::getInstance()-getFocusFrame();
+if (pFocus) {
+ZoomEvent aEvent( Point( x, y ), scale);
+Application::PostZoomEvent(VCLEVENT_WINDOW_ZOOM, pFocus-GetWindow(), 
aEvent);
 }
+else
+LOGW(No focused frame to emit event on);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/vcl/event.hxx b/vcl/inc/vcl/event.hxx
index de7464d..e89d52a 100644
--- a/vcl/inc/vcl/event.hxx
+++ b/vcl/inc/vcl/event.hxx
@@ -177,6 +177,66 @@ inline MouseEvent::MouseEvent( const Point rPos, 
sal_uInt16 nClicks,
 mnCode  = nButtons | nModifier;
 }
 
+class VCL_DLLPUBLIC ZoomEvent
+{
+private:
+Point   maCenter;
+float   mfScale;
+
+public:
+ZoomEvent() :
+mfScale( 1 )
+{
+}
+
+ZoomEvent( const Point rCenter,
+ 

[Libreoffice-commits] core.git: scp2/source setup_native/Library_shlxtmsi.mk setup_native/source

2013-03-02 Thread Andras Timar
 scp2/source/ooo/windowscustomaction_ooo.scp   |9 
 setup_native/Library_shlxtmsi.mk  |1 
 setup_native/source/win32/customactions/shellextensions/iconcache.cxx |  104 
--
 setup_native/source/win32/customactions/shellextensions/shlxtmsi.def  |3 
 4 files changed, 1 insertion(+), 116 deletions(-)

New commits:
commit c3429a0da677fa0bf111ce5b9d00ee4440930f7b
Author: Andras Timar ati...@suse.com
Date:   Sat Mar 2 16:20:52 2013 +0100

remove RebuildShellIconCache CustomAction (it was Win 9x/NT/2K only)

Change-Id: Id856c2279520d9183c8b10967f5b56903d21963f

diff --git a/scp2/source/ooo/windowscustomaction_ooo.scp 
b/scp2/source/ooo/windowscustomaction_ooo.scp
index 4d5116c..4242fcd 100644
--- a/scp2/source/ooo/windowscustomaction_ooo.scp
+++ b/scp2/source/ooo/windowscustomaction_ooo.scp
@@ -158,15 +158,6 @@ WindowsCustomAction gid_Customaction_Shellextensionsdll5
Assignment2 = (InstallUISequence, Not REMOVE=\ALL\ And Not PATCH, 
FindRelatedProducts);
 End
 
-WindowsCustomAction gid_Customaction_Shellextensionsdll6
-   Name = Shellextensionsdll6;
-   Typ = 65;
-   Source = shlxtmsi.dll;
-   Target = RebuildShellIconCache;
-   Inbinarytable = 1;
-   Assignment1 = (InstallExecuteSequence, Not PATCH, end);
-End
-
 WindowsCustomAction gid_Customaction_Check_Install_Directory
Name = CheckInstallDirectory;
Typ = 65;
diff --git a/setup_native/Library_shlxtmsi.mk b/setup_native/Library_shlxtmsi.mk
index a603702..28fcdce 100644
--- a/setup_native/Library_shlxtmsi.mk
+++ b/setup_native/Library_shlxtmsi.mk
@@ -27,7 +27,6 @@ $(eval $(call gb_Library_add_ldflags,shlxtmsi,\
 $(eval $(call gb_Library_add_exception_objects,shlxtmsi,\
 setup_native/source/win32/customactions/shellextensions/startmenuicon \
 setup_native/source/win32/customactions/shellextensions/upgrade \
-setup_native/source/win32/customactions/shellextensions/iconcache \
 setup_native/source/win32/customactions/shellextensions/migrateinstallpath 
\
 
setup_native/source/win32/customactions/shellextensions/completeinstallpath \
 setup_native/source/win32/customactions/shellextensions/checkdirectory \
diff --git 
a/setup_native/source/win32/customactions/shellextensions/iconcache.cxx 
b/setup_native/source/win32/customactions/shellextensions/iconcache.cxx
deleted file mode 100644
index e037074..000
--- a/setup_native/source/win32/customactions/shellextensions/iconcache.cxx
+++ /dev/null
@@ -1,104 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
-#define WIN32_LEAN_AND_MEAN
-#include windows.h
-#include msiquery.h
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
-
-#include stdlib.h
-
-extern C UINT __stdcall RebuildShellIconCache(MSIHANDLE)
-{
-// Rebuild icon cache on windows OS prior XP
-
-OSVERSIONINFO   osverinfo;
-
-osverinfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
-
-if (
-GetVersionEx( osverinfo ) 
-VER_PLATFORM_WIN32_NT == osverinfo.dwPlatformId 
-(
-5  osverinfo.dwMajorVersion ||
-5 == osverinfo.dwMajorVersion  0  osverinfo.dwMinorVersion
-)
-)
-{
-return ERROR_SUCCESS;
-}
-
-HKEYhKey;
-DWORD   dwDispostion;
-LONGlError = RegCreateKeyEx( HKEY_CURRENT_USER, TEXT(Control 
Panel\\Desktop\\WindowMetrics), 0, NULL, REG_OPTION_VOLATILE, KEY_SET_VALUE | 
KEY_QUERY_VALUE, NULL, hKey, dwDispostion );
-
-if ( ERROR_SUCCESS == lError )
-{
-TCHAR   szValue[256];
-TCHAR   szTempValue[256];
-DWORD   cbValue = sizeof(szValue);
-DWORD   dwType;
-int iSize = 0;
-
-lError = RegQueryValueEx( hKey, TEXT(Shell Icon Size), 0, dwType, 
(LPBYTE)szValue, cbValue );
-
-if ( ERROR_SUCCESS == lError )
-iSize = atoi( szValue );
-
-if ( !iSize )
-{
-iSize = GetSystemMetrics( SM_CXICON );
-_itoa_s( iSize, szValue, 256, 10 );
-

[Libreoffice-commits] core.git: oox/source

2013-03-02 Thread Norbert Thiebaud
 oox/source/ppt/pptfilterhelpers.cxx |  109 
 1 file changed, 87 insertions(+), 22 deletions(-)

New commits:
commit 7eda7576e030f1f03a27f01e717aac9fee5f7bd7
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Feb 22 01:26:15 2013 -0600

coverity#705402 Improper use of negative value

while at it let's avoid creating 16 OUString objects per run from
the same 8 constants.. and let's avoid parsing the source 4 times
when 1 time suffice... and of course use OUStrinBuffer to construct
the result rather than creating and recreating OUString over and over.

Change-Id: I74fdb8b51bab91a0883db65bc8c5d0e8606e2da4
Reviewed-on: https://gerrit.libreoffice.org/2326
Reviewed-by: Norbert Thiebaud nthieb...@gmail.com
Tested-by: Norbert Thiebaud nthieb...@gmail.com

diff --git a/oox/source/ppt/pptfilterhelpers.cxx 
b/oox/source/ppt/pptfilterhelpers.cxx
index ca6ba36..97e3e62 100644
--- a/oox/source/ppt/pptfilterhelpers.cxx
+++ b/oox/source/ppt/pptfilterhelpers.cxx
@@ -17,10 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-
 #include com/sun/star/animations/TransitionType.hpp
 #include com/sun/star/animations/TransitionSubType.hpp
-
+#include rtl/ustrbuf.hxx
 #include pptfilterhelpers.hxx
 
 namespace oox { namespace ppt {
@@ -92,34 +91,100 @@ namespace oox { namespace ppt {
 {
 bool bRet = false;
 
-const sal_Char* pSource[] = { ppt_x, ppt_y, ppt_w, ppt_h, NULL 
};
-const sal_Char* pDest[] = { x, y, width, height, NULL };
+/* here we want to substitute all occurance of
+ * [#]ppt_[xyhw] with
+ * x,y,height and width respectively
+ */
 sal_Int32 nIndex = 0;
+sal_Int32 nLastIndex = 0;
 
-const sal_Char** ps = pSource;
-const sal_Char** pd = pDest;
-
-while( *ps )
+nIndex = rString.indexOf(ppt_);
+// bail out early if there is no substitution to be made
+if(nIndex = 0)
 {
-const OUString aSearch( OUString::createFromAscii( *ps ) );
-while( (nIndex = rString.indexOf( aSearch, nIndex )) != -1  )
+OUStringBuffer sRes(rString.getLength());
+
+do
 {
-sal_Int32 nLength = aSearch.getLength();
-if( nIndex  (rString.getStr()[nIndex-1] == '#' ) )
+// copy the non matching inverval verbatim
+if(nIndex  nLastIndex)
 {
-nIndex--;
-nLength++;
+sRes.append(rString.getStr() + nLastIndex, (nIndex - 
nLastIndex));
 }
-
-const OUString aNew( OUString::createFromAscii( *pd ) );
-rString = rString.replaceAt( nIndex, nLength, aNew );
-nIndex += aNew.getLength();
-bRet = true;
+// we are searching for ppt_[xywh] so we need and extra char 
behind the match
+if(nIndex + 4  rString.getLength())
+{
+switch(rString[nIndex + 4])
+{
+case (sal_Unicode)'h': // we found ppt_h
+// if it was #ppt_h we already copied the #
+// which we do not want in the target, so remove it
+if(nIndex  (rString[nIndex - 1] == (sal_Unicode)'#'))
+{
+sRes.remove(sRes.getLength() - 1, 1);
+}
+sRes.append(height);
+bRet = true;
+break;
+case (sal_Unicode)'w':
+if(nIndex  (rString[nIndex - 1] == (sal_Unicode)'#'))
+{
+sRes.remove(sRes.getLength() - 1, 1);
+}
+sRes.append(width);
+bRet = true;
+break;
+case (sal_Unicode)'x':
+if(nIndex  (rString[nIndex - 1] == (sal_Unicode)'#'))
+{
+sRes[sRes.getLength() - 1] = (sal_Unicode)'x';
+}
+else
+{
+sRes.append((sal_Unicode)'x');
+}
+bRet = true;
+break;
+case (sal_Unicode)'y':
+if(nIndex  (rString[nIndex - 1] == (sal_Unicode)'#'))
+{
+sRes[sRes.getLength() - 1] = (sal_Unicode)'y';
+}
+else
+{
+sRes.append((sal_Unicode)'y');
+}
+bRet = true;
+break;
+default:
+

[PUSHED] coverity#705402 Improper use of negative value

2013-03-02 Thread Norbert Thiebaud (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2326

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74fdb8b51bab91a0883db65bc8c5d0e8606e2da4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Bug 54157 depends on bug 61468, which changed state.

Bug 61468 Summary: [Template manager] [accessibility] UI broken for key board 
navigation
https://bugs.freedesktop.org/show_bug.cgi?id=61468

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

--- Comment #120 from V Stuart Foote vstuart.fo...@utsa.edu ---
(In reply to comment #118)
 Add Bug 61468 - [Template manager] [accessibility] UI broken for key board
 navigation

replacing 61468 with bug 61390 regards accessibility of Template Manager

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 54157] LibreOffice 4.0 most annoying bugs

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Depends on||61390

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Libre

2013-03-02 Thread Michael Meeks
Hi Adriam,

On Sat, 2013-03-02 at 13:51 -0500, Adriam Delgado Rivero wrote:
 Using UNO API for java and charge a template that contains a
 table 

Great to have you using LibreOffice :-) it looks like you're trying to
report a bug here which is not a great place to do that; it might be
better to ask on the Spanish list, or if you can expand more in English
to file in bugzilla, or go to:

http://www.libreoffice.org/get-help/

In general this list is for discussing the code, patches, fixes,
development of new features (by those doing the development) etc. :-)

Hope that helps,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: dbaccess/source

2013-03-02 Thread Luc Castermans
 dbaccess/source/ui/querydesign/QueryDesignView.cxx |   31 ++---
 1 file changed, 16 insertions(+), 15 deletions(-)

New commits:
commit d1e99f5802585513fa222f03d1a578840c403eb7
Author: Luc Castermans luc.casterm...@gmail.com
Date:   Sat Mar 2 18:35:34 2013 +0100

translated German comments (file is clean now)

Change-Id: I1f833fe4a2332c1b2fa1e98fd320e55f7e19c649
Reviewed-on: https://gerrit.libreoffice.org/2517
Reviewed-by: Joren De Cuyper joren.libreoff...@telenet.be
Reviewed-by: Michael Meeks michael.me...@suse.com
Tested-by: Michael Meeks michael.me...@suse.com

diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx 
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 912e30f..a2335f9 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -567,16 +567,16 @@ namespace
 const ::connectivity::OSQLParseNode 
*pRightTable)
 {
 SqlParseError eErrorCode = eOk;
-if (pNode-count() == 3   // Ausdruck is geklammert
+if (pNode-count() == 3   // statment between brackets
 SQL_ISPUNCTUATION(pNode-getChild(0),() 
 SQL_ISPUNCTUATION(pNode-getChild(2),)))
 {
 eErrorCode = InsertJoinConnection(_pView,pNode-getChild(1), 
_eJoinType,pLeftTable,pRightTable);
 }
-else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)  
 // AND/OR-Verknuepfung:
+else if (SQL_ISRULEOR2(pNode,search_condition,boolean_term)  
 // AND/OR-joints:
  pNode-count() == 3)
 {
-// nur AND Verkn�pfung zulassen
+// only allow AND joints
 if (!SQL_ISTOKEN(pNode-getChild(1),AND))
 eErrorCode = eIllegalJoinCondition;
 else if ( eOk == (eErrorCode = 
InsertJoinConnection(_pView,pNode-getChild(0), 
_eJoinType,pLeftTable,pRightTable)) )
@@ -2909,19 +2909,20 @@ OUString OQueryDesignView::getStatement()
 OUString aFieldListStr(GenerateSelectList(this,rFieldList,nTabcount1));
 if( aFieldListStr.isEmpty() )
 return OUString();
-// Ausnahmebehandlung, wenn keine Felder angegeben worden sind
-// Dann darf die Tabpage nicht gewechselt werden
-// Im TabBarSelectHdl wird der SQL-OUString auf STATEMENT_NOFIELDS 
abgefragt
-// und eine Errormeldung erzeugt
-// - Tabellenliste aufbauen --
+
+// Exceptionhandling, if no fields have been passed we should not
+// change the tab page
+// TabBarSelectHdl will query the SQL-OUString for STATEMENT_NOFIELDS
+// and trigger a error message
+// - Build table list --
 
 const ::std::vectorOTableConnection** pConnList = 
m_pTableView-getTableConnections();
 Reference XConnection xConnection = rController.getConnection();
 OUString aTableListStr(GenerateFromClause(xConnection,pTabList,pConnList));
 OSL_ENSURE(!aTableListStr.isEmpty(), OQueryDesignView::getStatement() : 
unexpected : have Fields, but no Tables !);
-// wenn es Felder gibt, koennen die nur durch Einfuegen aus einer schon 
existenten Tabelle entstanden sein; wenn andererseits
-// eine Tabelle geloescht wird, verschwinden auch die zugehoerigen Felder 
- ergo KANN es das nicht geben, dass Felder
-// existieren, aber keine Tabellen (und aFieldListStr hat schon eine 
Laenge, das stelle ich oben sicher)
+// if fields exist now, these only can be created by inserting from an 
already existing table; if on the other hand
+// a table is deleted, also the belonging fields will be deleted - 
therefore it CANNOT occur that fields
+// exist but no tables exist (and aFieldListStr has its length, I secure 
this above)
 OUStringBuffer aHavingStr,aCriteriaListStr;
 // - Kriterien aufbauen --
 if (!GenerateCriterias(this,aCriteriaListStr,aHavingStr,rFieldList, 
nTabcount  1))
@@ -2941,7 +2942,7 @@ OUString OQueryDesignView::getStatement()
 }
 aCriteriaListStr = aTmp;
 }
-// - Statement aufbauen --
+// - construct statement  --
 OUStringBuffer aSqlCmd(OUString(RTL_CONSTASCII_USTRINGPARAM(SELECT )));
 if(rController.isDistinct())
 aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( DISTINCT )));
@@ -2954,7 +2955,7 @@ OUString OQueryDesignView::getStatement()
 aSqlCmd.append(OUString(RTL_CONSTASCII_USTRINGPARAM( WHERE )));
 aSqlCmd.append(aCriteriaListStr.makeStringAndClear());
 }
-// - GroupBy aufbauen und Anhangen 
+// - construct GroupBy and attachen 
 ReferenceXDatabaseMetaData xMeta;
 if ( xConnection.is() )
 xMeta = xConnection-getMetaData();
@@ -2963,13 +2964,13 @@ OUString 

[Libreoffice-commits] core.git: dbaccess/source

2013-03-02 Thread Luc Castermans
 dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit dadfa4bbbe9107cd5b8aad43dace0692ca8d63bf
Author: Luc Castermans luc.casterm...@gmail.com
Date:   Sat Mar 2 18:07:16 2013 +0100

translated German comments

Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
Reviewed-on: https://gerrit.libreoffice.org/2516
Reviewed-by: Michael Meeks michael.me...@suse.com
Tested-by: Michael Meeks michael.me...@suse.com

diff --git a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx 
b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
index 5482bb8..7b89147 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
@@ -27,7 +27,7 @@
 namespace dbaui
 {
 // 

-// OQueryDesignFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung 
im Abfrageentwurf
+   // OQueryDesignFieldUndoAct - Basisclass for undo's in the fieldlist of a 
query design
 
 
 class OQueryDesignFieldUndoAct : public OCommentUndoAction
@@ -52,7 +52,7 @@ namespace dbaui
 };
 
 // 

-// OTabFieldCellModifiedUndoAct - Undo-Klasse fuer Aendern einer Zelle 
einer Spaltenbeschreibung
+// OTabFieldCellModifiedUndoAct - undo class to change a line of the 
column description
 
 class OTabFieldCellModifiedUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -73,7 +73,7 @@ namespace dbaui
 };
 
 // 

-// OTabFieldSizedUndoAct - Undo-Klasse fuer Aendern einer Spaltenbreite
+// OTabFieldSizedUndoAct - undo class to change the column width
 
 class OTabFieldSizedUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -90,7 +90,7 @@ namespace dbaui
 };
 
 // 

-// OTabFieldUndoAct - Basisklasse fuer Undos in der Feldauflistung im 
Abfrageentwurf, die mit Veraendern einer kompletten Feldbeschreibung zu tun 
haben
+// OTabFieldUndoAct - base class for undos in the fieldlist of a query 
design, which are used to change complete field descriptions
 
 class OTabFieldUndoAct : public OQueryDesignFieldUndoAct
 {
@@ -104,7 +104,7 @@ namespace dbaui
 };
 
 // 

-// OTabFieldDelUndoAct - Undo-Klasse fuer Loeschen eines Feldes
+// OTabFieldDelUndoAct - undo class to delete a field
 
 class OTabFieldDelUndoAct : public OTabFieldUndoAct
 {
@@ -118,6 +118,7 @@ namespace dbaui
 
 // 

 // OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes
+// OTabFieldDelUndoAct - undo class to create a field
 
 class OTabFieldCreateUndoAct : public OTabFieldUndoAct
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] translated German comments (file is clean now)

2013-03-02 Thread Michael Meeks (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2517

Approvals:
  Joren De Cuyper: Looks good to me, but someone else must approve
  Michael Meeks: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2517
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f833fe4a2332c1b2fa1e98fd320e55f7e19c649
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com
Gerrit-Reviewer: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] translated German comments

2013-03-02 Thread Michael Meeks (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2516

Approvals:
  Michael Meeks: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2516
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a629124270eb39dc879f74f1814618fe660be5e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luc Castermans luc.casterm...@gmail.com
Gerrit-Reviewer: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] translated German comments; all cleaned up.

2013-03-02 Thread Luc Castermans (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2520

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/2520/1

translated German comments; all cleaned up.

Change-Id: I761b190361bbcca2f9655a7a028799586c2d8656
---
M dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
M dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
M dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
M dbaccess/source/ui/querydesign/QueryTabConnUndoAction.hxx
M dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx
M dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx
M dbaccess/source/ui/querydesign/QueryTableView.cxx
M dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx
M dbaccess/source/ui/querydesign/TableConnection.cxx
M dbaccess/source/ui/querydesign/TableConnectionData.cxx
M dbaccess/source/ui/querydesign/TableWindowListBox.cxx
M dbaccess/source/ui/querydesign/TableWindowTitle.cxx
M dbaccess/source/ui/querydesign/querycontroller.cxx
M dbaccess/source/ui/querydesign/querydlg.hxx
16 files changed, 156 insertions(+), 147 deletions(-)



diff --git a/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx 
b/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
index d4528a1..e114f6e 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignUndoAction.hxx
@@ -24,13 +24,12 @@
 namespace dbaui
 {
 // 

-// OQueryDesignUndoAction - Undo-Basisklasse fuer Aktionen im graphischen 
Abfrageentwurf (ohne Feldliste)
-
+// OQueryDesignUndoAction - undo base class for actions in graphical query 
design (without field list)
 class OJoinTableView;
 class OQueryDesignUndoAction : public OCommentUndoAction
 {
 protected:
-OJoinTableView* m_pOwner;   // in diesem Container spielt sich 
alles ab
+OJoinTableView* m_pOwner;   // in this container it all happens
 
 public:
 OQueryDesignUndoAction(OJoinTableView* pOwner, sal_uInt16 nCommentID) 
: OCommentUndoAction(nCommentID), m_pOwner(pOwner) { }
diff --git a/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx 
b/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
index 0256953..e106344 100644
--- a/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
+++ b/dbaccess/source/ui/querydesign/QueryMoveTabWinUndoAct.cxx
@@ -29,9 +29,10 @@
 Point ptNext = m_pTabWin-GetPosPixel() + ptFrameScrollPos;
 
 m_pTabWin-SetPosPixel(m_ptNextPosition - ptFrameScrollPos);
-// sieht so aus, als wenn das ptFrameScrollPos sinnlos ist, da ich es 
hier abziehe und auf das ptNext aufaddiere, wo
-// ich es das naechste Mal ja wieder abziehe ... Aber ptFrameScrollPos 
kann sich natuerlich beim naechsten Mal schon wieder
-// geaendert haben ...
+
+// it looks like ptFrameScrollPos is meaningless, then I it substract here 
and add it to ptNext, and
+// next time I substract again ...
+// AbetptFrameScrollPos could have changed next time ...
 m_pOwner-EnsureVisible(m_pTabWin);
 
 m_ptNextPosition = ptNext;
diff --git a/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx 
b/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
index 853e24c..e21ebf0 100644
--- a/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QuerySizeTabWinUndoAct.hxx
@@ -26,7 +26,7 @@
 {
 
 // 

-// OQuerySizeTabWinUndoAct - Undo-Klasse fuer Groessenveraenderung eines 
TabWins
+// OQuerySizeTabWinUndoAct - undo class to change size of TabWins
 class OTableWindow;
 class OJoinSizeTabWinUndoAct : public OQueryDesignUndoAction
 {
@@ -39,9 +39,9 @@
 
 public:
 OJoinSizeTabWinUndoAct(OJoinTableView* pOwner, const Point 
ptOriginalPos, const Size szOriginalSize, OTableWindow* pTabWin);
-// Nebenbedingung : es darf nicht gescrollt worden sein, waehrend die 
neue Groesse/Position ermittelt wurde, das heisst, die Position
-// hier sind physische, nicht logische Koordinaten
-// (im Gegensatz zur QueryMoveTabWinUndoAct)
+// Boundary condition: while retrieving size/position scrolling is not 
allowed, meaning the position
+// here returns physical and not logical coordinates
+// (in contrary to QueryMoveTabWinUndoAct)
 
 virtual voidUndo() { ToggleSizePosition(); }
 virtual voidRedo() { ToggleSizePosition(); }
diff --git a/dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx 
b/dbaccess/source/ui/querydesign/QueryTabConnUndoAction.cxx
index 5991394..d09f60d 100644
--- 

[Libreoffice-commits] core.git: comphelper/inc comphelper/source dbaccess/source

2013-03-02 Thread Gábor Nyers
 comphelper/inc/comphelper/syntaxhighlight.hxx  |   37 +
 comphelper/source/misc/syntaxhighlight.cxx |7 +-
 dbaccess/source/ui/inc/TableWindow.hxx |4 -
 dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx |2 
 4 files changed, 23 insertions(+), 27 deletions(-)

New commits:
commit 9e991e1852fa764e78d88b5d3aab17e45ac9213e
Author: Gábor Nyers gny...@opensuse.org
Date:   Sat Mar 2 21:08:46 2013 +

fdo#39468 Translated German comments to English

Change-Id: If4f8e308cfae6a4ba64576c1b2844210e64085a0

diff --git a/comphelper/inc/comphelper/syntaxhighlight.hxx 
b/comphelper/inc/comphelper/syntaxhighlight.hxx
index 11a57db..ef1a948 100644
--- a/comphelper/inc/comphelper/syntaxhighlight.hxx
+++ b/comphelper/inc/comphelper/syntaxhighlight.hxx
@@ -63,10 +63,10 @@ struct HighlightPortion { sal_uInt16 nBegin; sal_uInt16 
nEnd; TokenTypes tokenTy
 typedef std::vectorHighlightPortion HighlightPortions;
 
 /
-// Hilfsklasse zur Untersuchung von JavaScript-Modulen, zunaechst zum
-// Heraussuchen der Funktionen, spaeter auch zum Syntax-Highlighting verwenden
+// Auxiliary class to support JavaScript modules, next to find functions which
+// will later will be used for syntax highlighting
 
-//  Flags fuer Zeichen-Eigenschaften
+// Flags for character properties
 #define CHAR_START_IDENTIFIER   0x0001
 #define CHAR_IN_IDENTIFIER  0x0002
 #define CHAR_START_NUMBER   0x0004
@@ -81,8 +81,8 @@ typedef std::vectorHighlightPortion HighlightPortions;
 #define CHAR_EOF0x00
 
 
-// Sprachmodus des HighLighters (spaeter eventuell feiner
-// differenzieren mit Keyword-Liste, C-Kommentar-Flag)
+// Language mode of the Highlighter (possibly to be refined later with keyword
+// lists, C comment flags)
 enum HighlighterLanguage
 {
 HIGHLIGHT_BASIC,
@@ -92,23 +92,23 @@ enum HighlighterLanguage
 class SimpleTokenizer_Impl
 {
 HighlighterLanguage aLanguage;
-// Zeichen-Info-Tabelle
+// Character information tables
 sal_uInt16 aCharTypeTab[256];
 
 const sal_Unicode* mpStringBegin;
 const sal_Unicode* mpActualPos;
 
-// Zeile und Spalte
+// Lines and columns
 sal_uInt32 nLine;
 sal_uInt32 nCol;
 
 sal_Unicode peekChar( void ){ return *mpActualPos; }
 sal_Unicode getChar( void ) { nCol++; return *mpActualPos++; }
 
-// Hilfsfunktion: Zeichen-Flag Testen
+// Auxiliary function: testing of the character flags
 sal_Bool testCharFlags( sal_Unicode c, sal_uInt16 nTestFlags );
 
-// Neues Token holen, Leerstring == nix mehr da
+// Get new token, EmptyString == nothing more over there
 sal_Bool getNextToken( /*out*/TokenTypes reType,
 /*out*/const sal_Unicode* rpStartPos, /*out*/const sal_Unicode* 
rpEndPos );
 
@@ -126,13 +126,11 @@ public:
 };
 
 
-//*** SyntaxHighlighter-Klasse ***
-// Konzept: Der Highlighter wird ueber alle Aenderungen im Source
-// informiert (notifyChange) und liefert dem Aufrufer jeweils die
-// Information zurueck, welcher Zeilen-Bereich des Source-Codes
-// aufgrund dieser Aenderung neu gehighlighted werden muss.
-// Dazu merkt sich Highlighter intern fuer jede Zeile, ob dort
-// C-Kommentare beginnen oder enden.
+//*** SyntaxHighlighter Class ***
+// Concept: the Highlighter will be notified of all changes in the source
+// (notifyChange) and returns the caller the range of lines, which based on the
+// changes, need to be highlighted again. For this the Highlighter marks all
+// lines internally whether or not C comments begin or end.
 class COMPHELPER_DLLPUBLIC SyntaxHighlighter
 {
 HighlighterLanguage eLanguage;
@@ -146,10 +144,9 @@ public:
 SyntaxHighlighter( void );
 ~SyntaxHighlighter( void );
 
-// HighLighter (neu) initialisieren, die Zeilen-Tabelle wird
-// dabei komplett geloescht, d.h. im Abschluss wird von einem
-// leeren Source ausgegangen. In notifyChange() kann dann
-// nur Zeile 0 angegeben werden.
+// (Re-)initialize Highlighter. The line-table will be completely erased,
+// meaning that on completion an empty Source is assumed.
+// notifyChange() can only be given line 0
 void initialize( HighlighterLanguage eLanguage_ );
 
 void notifyChange( sal_uInt32 nLine, sal_Int32 nLineCountDifference,
diff --git a/comphelper/source/misc/syntaxhighlight.cxx 
b/comphelper/source/misc/syntaxhighlight.cxx
index 2064c0c..84790eb 100644
--- a/comphelper/source/misc/syntaxhighlight.cxx
+++ b/comphelper/source/misc/syntaxhighlight.cxx
@@ -411,9 +411,8 @@ sal_Bool SimpleTokenizer_Impl::getNextToken( 
/*out*/TokenTypes reType,
 reType = TT_COMMENT;
 }
 
-// Echter Operator, kann hier einfach behandelt werden,
-// da nicht der wirkliche Operator, wie z.B. += interessiert,
-// sondern nur die Tatsache, dass es sich um einen handelt.
+   

[PUSHED] Re: FDO#39468 Translated German comments to English

2013-03-02 Thread Michael Meeks
Hi Gábor,

Thanks for that ! :-) great work.

Sadly some parts of it overlapped with someone else's translation in
dbaccess. To avoid that it is best not to start at the top of the
alphabet, but jump in in the middle eg.

bin/find-german-comments svx

And then jump in at a random place in that log ;-)

Anyhow - more is much appreciated; also - feel free to dung out
redundant comments that don't say anything that interesting and/or turn
function descriptions into doxygen comments eg. '///' etc.

Thanks for helping make LibreOffice better !

All the best,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] do not require cygwin gcc

2013-03-02 Thread Peter Foley (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2521

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/2521/1

do not require cygwin gcc

Change-Id: I29de91f2eeb5c9317271aecf861f64a3c8eff73f
---
M configure.ac
M solenv/CustomTarget_concat-deps.mk
M solenv/Package_concat-deps.mk
M solenv/bin/concat-deps.c
4 files changed, 48 insertions(+), 53 deletions(-)



diff --git a/configure.ac b/configure.ac
index 62d2f78..97c351f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2158,20 +2158,6 @@
 SOLARVER=${BUILDDIR}/solver
 fi
 
-dnl ===
-dnl Extra check for Windows. Cygwin builds need gcc to build concat-deps
-dnl although MSVC is used to build other build-time tools and
-dnl LibreOffice itself.
-dnl ===
-if test $build_os = cygwin; then
-AC_MSG_CHECKING([for Cygwin gcc/g++])
-if which gcc  /dev/null  which g++  /dev/null; then
-AC_MSG_RESULT([found])
-else
-AC_MSG_ERROR([Cygwin gcc and g++ are needed, please install them.])
-fi
-fi
-
 # remenber SYSBASE value
 AC_SUBST(SYSBASE)
 
@@ -2242,32 +2228,34 @@
 dnl  Checks for C compiler,
 dnl  The check for the C++ compiler is later on.
 dnl ===
-GCC_HOME_SET=true
-AC_MSG_CHECKING([gcc home])
-if test -z $with_gcc_home; then
-if test $enable_icecream = yes; then
-if test -d /usr/lib/icecc/bin; then
-GCC_HOME=/usr/lib/icecc/
-else
-GCC_HOME=/opt/icecream/
-fi
-else
-GCC_HOME=`which gcc | $SED -e s,/bin/gcc,,`
-GCC_HOME_SET=false
-fi
-else
-GCC_HOME=$with_gcc_home
-fi
-AC_MSG_RESULT($GCC_HOME)
-AC_SUBST(GCC_HOME)
+if test $_os != WINNT -a $WITH_MINGW != yes; then
+   GCC_HOME_SET=true
+   AC_MSG_CHECKING([gcc home])
+   if test -z $with_gcc_home; then
+   if test $enable_icecream = yes; then
+   if test -d /usr/lib/icecc/bin; then
+   GCC_HOME=/usr/lib/icecc/
+   else
+   GCC_HOME=/opt/icecream/
+   fi
+   else
+   GCC_HOME=`which gcc | $SED -e s,/bin/gcc,,`
+   GCC_HOME_SET=false
+   fi
+   else
+   GCC_HOME=$with_gcc_home
+   fi
+   AC_MSG_RESULT($GCC_HOME)
+   AC_SUBST(GCC_HOME)
 
-if test $GCC_HOME_SET = true; then
-if test -z $CC; then
-CC=$GCC_HOME/bin/gcc
-fi
-if test -z $CXX; then
-CXX=$GCC_HOME/bin/g++
-fi
+   if test $GCC_HOME_SET = true; then
+   if test -z $CC; then
+   CC=$GCC_HOME/bin/gcc
+   fi
+   if test -z $CXX; then
+   CXX=$GCC_HOME/bin/g++
+   fi
+   fi
 fi
 
 dnl The following checks for gcc, cc and then cl (if it weren't guarded for 
win32)
diff --git a/solenv/CustomTarget_concat-deps.mk 
b/solenv/CustomTarget_concat-deps.mk
index 1f138c5..6e8d56a 100644
--- a/solenv/CustomTarget_concat-deps.mk
+++ b/solenv/CustomTarget_concat-deps.mk
@@ -9,16 +9,15 @@
 
 $(eval $(call gb_CustomTarget_CustomTarget,solenv/concat-deps))
 
-$(call gb_CustomTarget_get_target,solenv/concat-deps) : \
-   $(call gb_CustomTarget_get_workdir,solenv/concat-deps)/concat-deps
+$(eval $(call gb_CustomTarget_register_targets,solenv/concat-deps,\
+   concat-deps$(gb_Executable_EXT_for_build) \
+))
 
-$(call gb_CustomTarget_get_workdir,solenv/concat-deps)/concat-deps : \
-   $(SRCDIR)/solenv/bin/concat-deps.c \
-   | $(call gb_CustomTarget_get_workdir,solenv/concat-deps)/.dir
-   $(call gb_Output_announce,solenv/concat-deps,$(true),GCC,1)
+$(call 
gb_CustomTarget_get_workdir,solenv/concat-deps)/concat-deps$(gb_Executable_EXT_for_build)
 : \
+   $(SRCDIR)/solenv/bin/concat-deps.c
+   $(call gb_Output_announce,solenv/concat-deps,$(true),C,1)
 ifeq ($(COM_FOR_BUILD),MSC)
-   # on cygwin force the use of gcc
-   gcc -O2 $ -o $@
+   LIB=$(ILIB) $(CC_FOR_BUILD) -nologo $(SOLARINC) -O2 $ -Fo$(dir $@) 
-Fe$(dir $@)
 else
$(CC_FOR_BUILD) -O2 $ -o $@
 endif
diff --git a/solenv/Package_concat-deps.mk b/solenv/Package_concat-deps.mk
index 9d6319d..9ede386 100644
--- a/solenv/Package_concat-deps.mk
+++ b/solenv/Package_concat-deps.mk
@@ -9,6 +9,6 @@
 
 $(eval $(call gb_Package_Package,solenv_concat-deps,$(call 
gb_CustomTarget_get_workdir,solenv/concat-deps)))
 
-$(eval $(call 
gb_Package_add_file,solenv_concat-deps,bin/concat-deps,concat-deps))
+$(eval $(call 
gb_Package_add_file,solenv_concat-deps,bin/concat-deps$(gb_Executable_EXT_for_build),concat-deps$(gb_Executable_EXT_for_build)))
 
 # vim: set noet sw=4 ts=4:
diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c
index 

[Libreoffice-commits] core.git: 4 commits - android/experimental android/sdremote vcl/inc vcl/source

2013-03-02 Thread Tor Lillqvist
 android/experimental/DocumentLoader/Makefile   
|4 -
 android/experimental/LibreOffice4Android/Makefile  
|4 -
 android/experimental/desktop/Makefile  
|4 -
 android/experimental/desktop/native-code.cxx   
|2 
 
android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
 |   26 +-
 android/sdremote/Makefile  
|4 -
 vcl/inc/salwtype.hxx   
|4 -
 vcl/source/app/svapp.cxx   
|   39 +-
 vcl/source/window/winproc.cxx  
|   31 +++
 9 files changed, 91 insertions(+), 27 deletions(-)

New commits:
commit 06b58a702f7751bbe997f33603af18767b9773f0
Author: Tor Lillqvist t...@iki.fi
Date:   Sun Mar 3 01:12:10 2013 +0200

Do real zooming also while the scale gesture is in progress

Would work nicely if only it wasn't so compute intensive. Or is it the
(temporary hack) constant redrawing that is killing performance?

Change-Id: I0b152411a413a818fba7a0f41a3462e423c6ab54

diff --git 
a/android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
 
b/android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
index 786bcad..6e5627b 100644
--- 
a/android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
+++ 
b/android/experimental/desktop/src/org/libreoffice/experimental/desktop/Desktop.java
@@ -171,16 +171,12 @@ public class Desktop
 super(Desktop.this);
 setFocusableInTouchMode(true);
 
-// While a scale gesture (two-finger pinch / spread to
-// zoom out / in) is in progress we just scale the bitmap
-// view (UI elements too, which of course is a bit silly).
-// When the scale gesture has finished, we ask LO to zoom
-// the document (and reset the view scale, it will be
-// replaced by one where the document (not UI elements) is
-// displayed at a different zoom level).
+// Is this sane? It is rather slow to ask LO to zoom
+// continuously while the scaling gesture is in progress.
 
-// Is that sane? Would it be too slow to ask LO to zoom
-// continuously while the gesture is in progress?
+// What we used to do was while a scale gesture was in
+// progress to just scale the bitmap view (UI elements
+// too, which of course was a bit silly).
 
 gestureDetector =
 new ScaleGestureDetector(Desktop.this,
@@ -188,8 +184,6 @@ public class Desktop
  @Override public boolean 
onScaleBegin(ScaleGestureDetector detector)
  {
  Log.i(TAG, onScaleBegin: 
pivot=( + detector.getFocusX() + ,  + detector.getFocusY() + ));
- 
setPivotX(detector.getFocusX());
- 
setPivotY(detector.getFocusY());
  scalingInProgress = true;
  return true;
  }
@@ -201,8 +195,7 @@ public class Desktop
  return false;
  scale *= s;
  Log.i(TAG, onScale:  + s + 
 =  + scale);
- setScaleX(scale);
- setScaleY(scale);
+ Desktop.zoom(scale, (int) 
detector.getFocusX(), (int) detector.getFocusY());
  return true;
  }
 
@@ -211,8 +204,6 @@ public class Desktop
  Log.i(TAG, onScaleEnd:  + 
scale);
  Desktop.zoom(scale, (int) 
detector.getFocusX(), (int) detector.getFocusY());
  scale = 1;
- setScaleX(scale);
- setScaleY(scale);
  scalingInProgress = false;
  }
  });
@@ -220,8 +211,6 @@ public class Desktop
 
 @Override protected void onDraw(Canvas canvas)
 {
-//canvas.drawColor(0xFF1ABCDD);
-
   

[Libreoffice-commits] core.git: ios/CustomTarget_Viewer_app.mk ios/Executable_Viewer.mk

2013-03-02 Thread Tor Lillqvist
 ios/CustomTarget_Viewer_app.mk |3 +--
 ios/Executable_Viewer.mk   |2 ++
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 19a080540f68abd8800b15b140349b1318d33073
Author: Tor Lillqvist t...@iki.fi
Date:   Sun Mar 3 01:46:06 2013 +0200

The Viewer executable, not just the app bundle,  depends on all the 
libraries

Change-Id: If85d7c8db75dbcd8316193e06b7c337c52216e0c

diff --git a/ios/CustomTarget_Viewer_app.mk b/ios/CustomTarget_Viewer_app.mk
index d2ccf34..7640a14 100644
--- a/ios/CustomTarget_Viewer_app.mk
+++ b/ios/CustomTarget_Viewer_app.mk
@@ -134,8 +134,7 @@ $(SCRIPT_OUTPUT_FILE_0) : $(call 
gb_Executable_get_target,Viewer)
 else
 # When run just from the command line, we don't have any app bundle to
 # copy or move the executable to. So do nothing.
-$(call gb_CustomTarget_get_target,ios/Viewer_app) : $(call 
gb_Executable_get_target,Viewer) \
-   $(call gb_Postprocess_get_target,AllModulesButInstsetNative)
+$(call gb_CustomTarget_get_target,ios/Viewer_app) : $(call 
gb_Executable_get_target,Viewer)
 
 $(call gb_CustomTarget_get_clean_target,ios/Viewer_app) :
$(call gb_Output_announce,$(subst $(WORKDIR)/Clean/,,$@),$(false),APP,2)
diff --git a/ios/Executable_Viewer.mk b/ios/Executable_Viewer.mk
index edde852..bd462d5 100644
--- a/ios/Executable_Viewer.mk
+++ b/ios/Executable_Viewer.mk
@@ -27,4 +27,6 @@ $(eval $(call gb_Executable_add_objcxxobjects,Viewer,\
 ios/experimental/Viewer/Viewer/main \
 ))
 
+$(call gb_Executable_get_target,Viewer) : $(call 
gb_Postprocess_get_target,AllModulesButInstsetNative)
+
 # vim: set ts=4 sw=4 et:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


PATCH PATCH Bug 60724 - spelling errors and typos in binaries found by lintian

2013-03-02 Thread Vojta Koukal
Hello,

sending a partial patch to Bug 60724 - spelling errors and typos in
binaries found by lintian.
Correcting wrongly spelled word paramater to correct parameter.

Vojta Koukal


All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.
diff --git a/connectivity/inc/connectivity/parameters.hxx b/connectivity/inc/connectivity/parameters.hxx
index e81e39f..648f8df 100644
--- a/connectivity/inc/connectivity/parameters.hxx
+++ b/connectivity/inc/connectivity/parameters.hxx
@@ -64,7 +64,7 @@ namespace dbtools
 name is a column name, so an implicit parameter had to be generated for it
 */
 eLinkedByColumnName,
-/** parameters which are filled externally (i.e. by XParamaters::setXXX, or by the parameter listeners)
+/** parameters which are filled externally (i.e. by XParameters::setXXX, or by the parameter listeners)
 */
 eFilledExternally
 };
diff --git a/connectivity/inc/connectivity/paramwrapper.hxx b/connectivity/inc/connectivity/paramwrapper.hxx
index e2fbfc3..f2f6354 100644
--- a/connectivity/inc/connectivity/paramwrapper.hxx
+++ b/connectivity/inc/connectivity/paramwrapper.hxx
@@ -187,7 +187,7 @@ namespace param
 };
 
 //
-//= ParamatersContainer
+//= ParametersContainer
 //
 typedef ::rtl::Reference ParameterWrapperContainerParametersContainerRef;
 
diff --git a/xmloff/dtd/drawing.mod b/xmloff/dtd/drawing.mod
index d80fd05..42a6013 100644
--- a/xmloff/dtd/drawing.mod
+++ b/xmloff/dtd/drawing.mod
@@ -789,7 +789,7 @@
 !ATTLIST draw:plugin %draw-position;
 !ATTLIST draw:plugin %draw-end-position; 
 
-!-- Paramaters --
+!-- Parameters --
 !ELEMENT draw:param EMPTY
 !ATTLIST draw:param draw:name CDATA #IMPLIED
 !ATTLIST draw:param draw:value CDATA #IMPLIED
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


build failure: missing minor.mk

2013-03-02 Thread Terrence Enger
I do not know whether I have found a problem or my machine is picking
on me because I am such a grumpy old man.  Reporting here just in case
there is something that needs to be changed.


I recently updated from the git repository.  My next `make fetch`
failed with message .,,

make: *** No rule to make target 
`/home/terry/lo_hacking/git/libo2/solenv/inc/minor.mk.in', needed by 
`/home/terry/lo_hacking/git/libo2/config_host.mk'.  Stop.

Suspecting commit ee0dd3 remove minor.mk, I checked out out the
previous commit.  My build is proceding apace.


This is a rebuild; I did not (yet) have to try `make clean`.


HTH,
Terry.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: build failure: missing minor.mk

2013-03-02 Thread Markus Mohrhard
Hey,

2013/3/3 Terrence Enger ten...@iseries-guru.com:
 I do not know whether I have found a problem or my machine is picking
 on me because I am such a grumpy old man.  Reporting here just in case
 there is something that needs to be changed.


 I recently updated from the git repository.  My next `make fetch`
 failed with message .,,

 make: *** No rule to make target 
 `/home/terry/lo_hacking/git/libo2/solenv/inc/minor.mk.in', needed by 
 `/home/terry/lo_hacking/git/libo2/config_host.mk'.  Stop.

 Suspecting commit ee0dd3 remove minor.mk, I checked out out the
 previous commit.  My build is proceding apace.


 This is a rebuild; I did not (yet) have to try `make clean`.


A make clean  make should fix it.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - i18npool/source

2013-03-02 Thread Alexandro Colorado
 i18npool/source/localedata/data/es_PE.xml |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b79ec07b04d1d335ca45a9a03a4c3c042f9baee1
Author: Alexandro Colorado j...@apache.org
Date:   Sat Mar 2 12:40:33 2013 +

new xml

diff --git a/i18npool/source/localedata/data/es_PE.xml 
b/i18npool/source/localedata/data/es_PE.xml
index 64987f5..abcb9ca 100644
--- a/i18npool/source/localedata/data/es_PE.xml
+++ b/i18npool/source/localedata/data/es_PE.xml
@@ -37,8 +37,8 @@
 LC_CTYPE unoid=generic
 Separators
 DateSeparator//DateSeparator
-ThousandSeparator./ThousandSeparator
-DecimalSeparator,/DecimalSeparator
+ThousandSeparator,/ThousandSeparator
+DecimalSeparator./DecimalSeparator
 TimeSeparator:/TimeSeparator
 Time100SecSeparator,/Time100SecSeparator
 ListSeparator;/ListSeparator
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2013-03-02 Thread Takeshi Abe
 sw/source/core/crsr/crstrvl.cxx |2 +-
 sw/source/core/crsr/findattr.cxx|8 
 sw/source/core/crsr/pam.cxx |2 +-
 sw/source/core/crsr/swcrsr.cxx  |2 +-
 sw/source/core/doc/docedt.cxx   |2 +-
 sw/source/core/doc/docfld.cxx   |4 ++--
 sw/source/core/doc/docfmt.cxx   |4 ++--
 sw/source/core/doc/docredln.cxx |2 +-
 sw/source/core/docnode/ndcopy.cxx   |4 ++--
 sw/source/core/docnode/ndsect.cxx   |2 +-
 sw/source/core/fields/cellfml.cxx   |6 +++---
 sw/source/core/fields/chpfld.cxx|2 +-
 sw/source/core/layout/frmtool.cxx   |2 +-
 sw/source/core/layout/trvlfrm.cxx   |4 ++--
 sw/source/core/text/frmcrsr.cxx |4 ++--
 sw/source/core/text/itrcrsr.cxx |2 +-
 sw/source/filter/basflt/shellio.cxx |2 +-
 sw/source/filter/html/htmlnum.cxx   |2 +-
 sw/source/ui/app/apphdl.cxx |4 ++--
 sw/source/ui/app/docsh2.cxx |2 +-
 sw/source/ui/app/docshini.cxx   |2 +-
 sw/source/ui/app/docstyle.cxx   |2 +-
 sw/source/ui/chrdlg/drpcps.cxx  |6 +++---
 sw/source/ui/config/uinums.cxx  |2 +-
 sw/source/ui/dbui/dbinsdlg.cxx  |2 +-
 sw/source/ui/dochdl/swdtflvr.cxx|2 +-
 sw/source/ui/lingu/hhcwrp.cxx   |2 +-
 sw/source/ui/utlui/attrdesc.cxx |2 +-
 28 files changed, 41 insertions(+), 41 deletions(-)

New commits:
commit ddf1b13a52548a62f6bebd5d97b7b822d2075529
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Sun Mar 3 00:44:38 2013 +0900

sal_Bool to bool

Change-Id: I4040baa1a0202426df80a0ea94abde55e2b6ca65

diff --git a/sw/source/core/crsr/crstrvl.cxx b/sw/source/core/crsr/crstrvl.cxx
index 8700c2f..9747423 100644
--- a/sw/source/core/crsr/crstrvl.cxx
+++ b/sw/source/core/crsr/crstrvl.cxx
@@ -1463,7 +1463,7 @@ sal_Bool SwCrsrShell::GetContentAtPos( const Point rPt,
 String sAttrs;
 SfxItemIter aIter( aSet );
 const SfxPoolItem* pItem = aIter.FirstItem();
-while( sal_True )
+while( true )
 {
 if( !IsInvalidItem( pItem ))
 {
diff --git a/sw/source/core/crsr/findattr.cxx b/sw/source/core/crsr/findattr.cxx
index a14c928..3a9a791 100644
--- a/sw/source/core/crsr/findattr.cxx
+++ b/sw/source/core/crsr/findattr.cxx
@@ -260,7 +260,7 @@ void SwAttrCheckArr::SetNewSet( const SwTxtNode rTxtNd, 
const SwPaM rPam )
 const SfxPoolItem* pFndItem;
 sal_uInt16 nWhich;
 
-while( sal_True )
+while( true )
 {
 if( IsInvalidItem( pItem ) )
 {
@@ -830,7 +830,7 @@ static int lcl_Search( const SwCntntNode rCNd, const 
SfxItemSet rCmpSet, sal_B
 const SfxPoolItem* pNdItem;
 sal_uInt16 nWhich;
 
-while( sal_True )
+while( true )
 {
 if( IsInvalidItem( pItem ))
 {
@@ -1072,7 +1072,7 @@ int SwFindParaAttr::Find( SwPaM* pCrsr, SwMoveFn fnMove, 
const SwPaM* pRegion,
 SwPaM* pTextRegion = aRegion;
 SwPaM aSrchPam( *pCrsr-GetPoint() );
 
-while( sal_True )
+while( true )
 {
 if( pSet-Count() ) // any attributes?
 {
@@ -1172,7 +1172,7 @@ int SwFindParaAttr::Find( SwPaM* pCrsr, SwMoveFn fnMove, 
const SwPaM* pRegion,
 
 SfxItemIter aIter( *pSet );
 const SfxPoolItem* pItem = aIter.GetCurItem();
-while( sal_True )
+while( true )
 {
 // reset all that are not set with pool defaults
 if( !IsInvalidItem( pItem )  SFX_ITEM_SET !=
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index c4bf33c..182521d 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -792,7 +792,7 @@ SwCntntNode* GetNode( SwPaM  rPam, sal_Bool rbFirst, 
SwMoveFn fnMove,
 SwNodes rNodes = aPos.nNode.GetNodes();
 
 // go to next/previous CntntNode
-while( sal_True )
+while( true )
 {
 pNd = bSrchForward
 ? rNodes.GoNextSection( aPos.nNode, sal_True, 
!bInReadOnly )
diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx
index 8bb731a..0ee9974 100644
--- a/sw/source/core/crsr/swcrsr.cxx
+++ b/sw/source/core/crsr/swcrsr.cxx
@@ -472,7 +472,7 @@ sal_Bool SwCursor::IsSelOvr( int eFlags )
 ? ( !pMyNd-IsEndNode() || 0 == ( pPtNd = 
pMyNd-FindTableNode() ))
 : 0 == ( pPtNd = pMyNd-GetTableNode() ))
 break;
-} while( sal_True );
+} while( true );
 }
 
 // stay on old position
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 04274fc..67252d9 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -1766,7 +1766,7 @@ bool SwDoc::DeleteRangeImplImpl(SwPaM  rPam)
 *pEnd = *pStt;
 

DialControl widget

2013-03-02 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Caolán, all

what will be the gtk widget to hold DialControl? DialControl is present
in Calc cell text alignment.

Thank you
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Fundação responsável civilmente, de acordo com o direito civil
Detalhes Legais: http://www.documentfoundation.org/imprint
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJRMql9AAoJEJp3R7nH3vLxUMAH/izTCkLpkhA2474PeD1/xPyy
pF+OmloYVuALK100N6CIcXKBxHf9ovpaR8Oy8PDE1/Rd1w6Vg6fkCRVTYqO6MG7Y
s2CTg9W/ZAGDpXtvskjLoUn8AariLWZ7W6OYPprfvT3PEzeeNEBlgJtwaMKJQqZt
rKNlVtPxQpuViIVQKnflJ9vuG06FCRh3Jac/moySoencNUiK0rzoHYmhtbJuYo20
Brz20eqJ6kqrOs3CY50FLy2bT39RpqJQtH79Ok2G4owZDomDIhqUR/kqdT82RE2X
B4sAG/euG//VKflbDoaNXKgeccGS2Ms1smzHf/RZW9bPUSoFRhipZhsp3fbeuB8=
=QC+o
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 18 commits - basctl/source connectivity/source extensions/source i18npool/source jvmfwk/plugins salhelper/qa sal/osl sfx2/source solenv/bin sot/source toolkit/source

2013-03-02 Thread Markus Mohrhard
 basctl/source/dlged/dlgedfac.cxx |2 ++
 connectivity/source/drivers/jdbc/Timestamp.cxx   |9 ++---
 extensions/source/scanner/sanedlg.cxx|1 +
 i18npool/source/localedata/localedata.cxx|4 
 jvmfwk/plugins/sunmajor/javaenvsetup/javaldx.cxx |3 +++
 sal/osl/unx/conditn.cxx  |2 ++
 sal/osl/unx/file_url.cxx |4 +++-
 sal/osl/unx/profile.c|1 +
 sal/osl/unx/util.c   |3 +++
 salhelper/qa/test_api.cxx|2 ++
 sfx2/source/menu/mnumgr.cxx  |1 +
 solenv/bin/concat-deps.c |2 +-
 sot/source/sdstor/stgdir.cxx |4 
 toolkit/source/awt/vclxmenu.cxx  |4 +---
 toolkit/source/awt/vclxtoolkit.cxx   |2 +-
 15 files changed, 35 insertions(+), 9 deletions(-)

New commits:
commit 21171e0a7fd3aaa14a45a72bfecbc2b2a4ad7679
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Mar 3 04:29:23 2013 +0100

coverity#736112: make clear that this is not part of the if

Change-Id: I442d7e363f7594d1fae5e2afdde71ff6670b1962

diff --git a/connectivity/source/drivers/jdbc/Timestamp.cxx 
b/connectivity/source/drivers/jdbc/Timestamp.cxx
index 77f123a..1d541d8 100644
--- a/connectivity/source/drivers/jdbc/Timestamp.cxx
+++ b/connectivity/source/drivers/jdbc/Timestamp.cxx
@@ -166,7 +166,8 @@ java_sql_Timestamp::java_sql_Timestamp(const 
::com::sun::star::util::DateTime _
 jobject tempObj;
 static jmethodID mID(NULL);
 if ( !mID  )
-mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);OSL_ENSURE(mID,Unknown method id!);
+mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);
+OSL_ENSURE(mID,Unknown method id!);
 tempObj = t.pEnv-CallStaticObjectMethod( getMyClass(), mID, args[0].l );
 
 saveRef( t.pEnv, tempObj );
commit bcca57ac426e84b5d359dea84fdac76a5495679b
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Mar 3 04:28:16 2013 +0100

coverity#736111: make clear that this is not part of the if

Change-Id: Iab61e80a7fa8f01d826ac90e184d09d0e2358b40

diff --git a/connectivity/source/drivers/jdbc/Timestamp.cxx 
b/connectivity/source/drivers/jdbc/Timestamp.cxx
index 72ce65d..77f123a 100644
--- a/connectivity/source/drivers/jdbc/Timestamp.cxx
+++ b/connectivity/source/drivers/jdbc/Timestamp.cxx
@@ -112,7 +112,8 @@ java_sql_Time::java_sql_Time( const 
::com::sun::star::util::Time _rOut ): java_
 jobject tempObj;
 static jmethodID mID(NULL);
 if ( !mID  )
-mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);OSL_ENSURE(mID,Unknown method id!);
+mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);
+OSL_ENSURE(mID,Unknown method id!);
 tempObj = t.pEnv-CallStaticObjectMethod( getMyClass(), mID, args[0].l );
 t.pEnv-DeleteLocalRef((jstring)args[0].l);
 saveRef( t.pEnv, tempObj );
commit 77c0cc3b750d516ad88481262d090ce0a2118e23
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Mar 3 04:27:17 2013 +0100

coverity#736110: make clear that this is not part of the if

Change-Id: I709672e9e2789213c85878d2bd0194ad5bc34060

diff --git a/connectivity/source/drivers/jdbc/Timestamp.cxx 
b/connectivity/source/drivers/jdbc/Timestamp.cxx
index 403935a..72ce65d 100644
--- a/connectivity/source/drivers/jdbc/Timestamp.cxx
+++ b/connectivity/source/drivers/jdbc/Timestamp.cxx
@@ -46,7 +46,8 @@ java_sql_Date::java_sql_Date( const 
::com::sun::star::util::Date _rOut ) : java
 jobject tempObj;
 static jmethodID mID(NULL);
 if ( !mID  )
-mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);OSL_ENSURE(mID,Unknown method id!);
+mID  = t.pEnv-GetStaticMethodID( getMyClass(), valueOf, cSignature 
);
+OSL_ENSURE(mID,Unknown method id!);
 tempObj = t.pEnv-CallStaticObjectMethod( getMyClass(), mID, args[0].l );
 saveRef( t.pEnv, tempObj );
 t.pEnv-DeleteLocalRef( tempObj );
commit 30975b96e84ac313eb220a1d4812e42013780b95
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Mar 3 04:25:11 2013 +0100

coverity#736107: nesting level mismatch

Change-Id: I24655d0e87335ac0356a1082fd993a87613e213e

diff --git a/basctl/source/dlged/dlgedfac.cxx b/basctl/source/dlged/dlgedfac.cxx
index 9c117eb..1ffbff2 100644
--- a/basctl/source/dlged/dlgedfac.cxx
+++ b/basctl/source/dlged/dlgedfac.cxx
@@ -84,8 +84,10 @@ IMPL_LINK( DlgEdFactory, MakeObject, SdrObjFactory *, 
pObjFactory )
  if ( pObjFactory-nIdentifier == OBJ_DLG_CHECKBOX )
  pObjFactory-pNewObj = new DlgEdObj( 
com.sun.star.awt.UnoControlCheckBoxModel, xDialogSFact );
  else
+ {
  pObjFactory-pNewObj = new DlgEdObj( 

Re: fdo#61135 New feature in Calc: Stepped Lines graphs - first part of code submitted

2013-03-02 Thread Markus Mohrhard
Hey Eric,



 I have added my first real code for submission to LO :-) It's in gerrit:
 https://gerrit.libreoffice.org/2476.

I'm going to review it in the next days.

 I looked on the LO website to find some pointers around in the code, but
 didn't really found it. My main helpers were OpenGrok and gdb. Did I miss a
 nice overview of where to find which functionality ?

No. There is no real documentation. As you already discovered xmloff/
contains the ODF import and export code for charts and chart2 the
whole implementation for the chart code. Additionally oox/ contains
the OOXML import and export code for charts.


 Secondly, what would you recommend as a primer on the C++ functionalities
 used in LO code + how they are used ? I didn't do that advanced C++ coding
 before that I know a lot about templates and namespaces.

It very much depends on your knowledge.


 I also want to add some debug code in what I have done, mainly to print a
 warning if new curve types are fed to LO. What's the best way to do that ?
 From
 https://wiki.documentfoundation.org/Development/How_to_debug#Macros_Controlling_Debug_Code
 I would think to add the code in #ifdef SAL_LOG_WARN or use the SAL_WARN
 macro.

You should use SAL_WARN and SAL_INFO for these tasks. Additionally we
are using more and more assert if we really want an abort for a
special condition. THere is also SAL_WARN_IF and SAL_INFO_IF for
conditional debug statements.

 Anyway, I will now create a mock for the UI and discuss this on the UI list.
 Once this is done, what would be the best way to add the new UI
 functionality ? A friendly push in the right direction would save me quite
 some time ;-)

You should design the dialogs nowadays with Glade. We are switching
from our old dialog descriptions to new glade xml files. Caolan wrote
a nice wiki page about widgetllayout
(https://wiki.documentfoundation.org/Development/WidgetLayout). While
it focuses mostly on transfering old dialogs to the new format it
should give you a basic idea how to create a new one. If you need one
of the custom widgets that we have somewhere in the code or other
customization of an existing widget we can help you implement that.

Thanks a lot for your great work on this feature.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Translate German DBG_ASSERT - AppFileName should be set to s...

2013-03-02 Thread Chris Sherlock (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2522

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/2522/1

Translate German DBG_ASSERT - AppFileName should be set to something

Change-Id: Idf0c1c90ff367285292097980f56ca9502e5ef33
---
M vcl/source/app/svapp.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index fe34011..6db1ec6 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -311,7 +311,7 @@
 const XubString Application::GetAppFileName()
 {
 ImplSVData* pSVData = ImplGetSVData();
-DBG_ASSERT( pSVData-maAppData.mpAppFileName, AppFileName vor SVMain ?! 
);
+DBG_ASSERT( pSVData-maAppData.mpAppFileName, AppFileName should be set 
to something after SVMain! );
 if ( pSVData-maAppData.mpAppFileName )
 return *pSVData-maAppData.mpAppFileName;
 

-- 
To view, visit https://gerrit.libreoffice.org/2522
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf0c1c90ff367285292097980f56ca9502e5ef33
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] [libreoffice-l10n] [ANN] LibreOffice 4.0.1 RC2 available

2013-03-02 Thread Serg Bormant
Hi,

There is no LiberationSerif-Regular.ttf in
libobasis4.0-ooofonts-4.0.1.2-2.x86_64.rpm package (only -Bold,
-Italic, and -BoldItalic).

-- 
wbr, sb

2013/3/1 Thorsten Behrens t...@documentfoundation.org:
 Dear Community,

 The Document Foundation is pleased to announce the second release
 candidate of our upcoming LibreOffice 4.0.1. This will be the first in
 a series of frequent updates to our feature-packed 4.0 branch. Please
 be aware that LibreOffice 4.0.1 RC2 is not ready for production use,
 you should continue to use LibreOffice 4.0.0 for that.

 The release is available for Windows, Linux and Mac OS X from our QA
 builds download page at

   http://www.libreoffice.org/download/pre-releases/

 Should you find bugs, please report them to the FreeDesktop Bugzilla:

   https://bugs.freedesktop.org

 A good way to assess the release candidate quality is to run some
 specific manual tests on it, our TCM wiki page has more details:

  
 http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test

   - or checkout our manual test database for starting right away -

  http://manual-test.libreoffice.org/runtests/

 With this release candidate, the Android Impress Remote should work on
 all platforms - if you would like to test, an updated Android package
 is available here:

  
 http://downloadarchive.documentfoundation.org/libreoffice/old/sdremote-1.0.4/playstore/ImpressRemote.apk
  (and note 
 https://wiki.documentfoundation.org/Development/Impress/RemoteHowTo)

 For other ways to get involved with this exciting project - you can
 e.g. contribute code:

   http://www.libreoffice.org/get-involved/developers/

 translate LibreOffice to your language:

   http://wiki.documentfoundation.org/LibreOffice_Localization_Guide

 or help with funding our operations:

   http://donate.libreoffice.org/

 A list of known issues and fixed bugs with 4.0.1 RC2 is available
 from our wiki:

   http://wiki.documentfoundation.org/Releases/4.0.1/RC2

 Let us close again with a BIG Thank You! to all of you having
 contributed to the LibreOffice project - this release would not have
 been possible without your help.

 Yours,

 The Document Foundation Board of Directors

 The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
 Rechtsfähige Stiftung des bürgerlichen Rechts
 Legal details: http://www.documentfoundation.org/imprint

 --
 Unsubscribe instructions: E-mail to l10n+h...@global.libreoffice.org
 Problems? 
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://listarchives.libreoffice.org/global/l10n/
 All messages sent to this list will be publicly archived and cannot be deleted

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-qa] Veja como é simples para de fumar.

2013-03-02 Thread Jociane
Comecei a fumar com 17 para 18
anos.

Excessivamente fumei durante 5 anos, e, hoje chegando aos 23 resolvi
dar uma nova chance para minha vida e largar o cigarro de uma vez por
todas.
Fumava 2 maos por dia j cheguei ate 3 maos,
no me orgulhava disso, pois alem do mau cheiro e os dentes amarelo,
eu sentia vergonha quando ia me relacionar com uma mulher.

Mais o vicio era maior que eu, no conseguia me controlar, se
eu tivesse vontade de fumar 2 horas da manha e no tivesse cigarro
eu procurava onde tivesse um estabelecimento aberto para comprar. Chegou
uma hora que eu tive que tomar uma atitude, estava acabando com a minha
sade e a minha famlia no era obrigada a respirar o
mesmo ar poludo que eu.

Descobri o to sonhado segredo que a maioria dos fumantes
procuram e no encontram para parar de fumar. Parei de fumar em 5
dias, foi inacreditvel os resultados que eu tive.
Estou h 2 meses sem fumar e percebo a diferena no
flego, na voz, pele e humor, sentindo o paladar dos alimentos e
claro as mulheres me cheirando. http://www.kitparedefumar.com.br/Removidos
desta lista de contatos

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Intro to me

2013-03-02 Thread Florian Reisinger
Hi,

I want to give you a warm welcome to the QA team
Please keep in mind, that QA is something like a never-ending story

So a few things right at the beginning:

1) We have a QA channel at freenode (#libreoffice-qa)
2) we have a biweekly call on friday
3) You may start with 4.0 bugs:
https://bugs.freedesktop.org/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=REOPENEDversion=4.0.0.0.alpha0%2B%20Masterversion=4.0.0.0.alpha1version=4.0.0.0.beta1version=4.1.0.0.alpha0%2B%20Masterversion=4.0.0.0.beta2version=4.0.0.1%20rcversion=4.0.0.2%20rcversion=4.0.0.3%20releaseversion=4.0.1.1%20rcversion=4.0.1.2%20rcproduct=LibreOfficelist_id=245941

If you are on Windows, you might want to have a look at this:
http://reisi007.bplaced.com/program/

Don't hesitate to ask if you need help...
If you triage a bug, please insert yourself into the QA contact field...
(I hope, that this wasn't too much for the takeoff at QA :)


Liebe Grüße, / Yours,
Florian Reisinger

Am 02.03.2013 um 17:30 schrieb Kieran Peckett crazyske...@gmail.com:

Hi.

I am Kieran, and I have been active at lo-documentation and lo-users for a
month or two now, and have now decided to join QA, as I feel that won't
take up too much more. I am posting this as an introduction to myself so
that you all know who I am and don't wonder who is this guy whenever I
post.

I have already posted a couple of bugs at FDO and have done a bit of
triaging today as well. I did do a bit of QA-ing at Mozilla a few months
ago on bugzilla, but after having stopped using their products I found it
to be a bit boring, so a few months later I took a look at the LO Get
Involved page, and as I've said, joined the Docs team and have decided to
branch out slightly more.

One note I would like to make, though - the page on the LO website only
mentions the developers mailing list, whilst the TDF wikipage also mentions
this one - a correction could be made there so that they don't have to
subscribe to a second list, or think is this the same one? and end up not
subscribing to here as well. Maybe list both at LO, and maybe just this one
at TDFwiki? If this was intentional by you, then don't worry about it, I
was just thinking that new users may get a bit confused by 2 links in 2
different places.

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings:
http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems?
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Intro to me

2013-03-02 Thread Kieran Peckett
Thanks!

I already have the Server GUI installed, as I needed it to install the
4.0.0.1 rc for the docs team.
This wasn't too much of a takeoff, and I knew most of how to do QA-ing from
my time as a Mozilla volunteer.

On Saturday, 2 March 2013, Florian Reisinger wrote:

 Hi,

 I want to give you a warm welcome to the QA team
 Please keep in mind, that QA is something like a never-ending story

 So a few things right at the beginning:

 1) We have a QA channel at freenode (#libreoffice-qa)
 2) we have a biweekly call on friday
 3) You may start with 4.0 bugs:
 https://bugs.freedesktop.org/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=REOPENEDversion=4.0.0.0.alpha0%2B%20Masterversion=4.0.0.0.alpha1version=4.0.0.0.beta1version=4.1.0.0.alpha0%2B%20Masterversion=4.0.0.0.beta2version=4.0.0.1%20rcversion=4.0.0.2%20rcversion=4.0.0.3%20releaseversion=4.0.1.1%20rcversion=4.0.1.2%20rcproduct=LibreOfficelist_id=245941

 If you are on Windows, you might want to have a look at this:
 http://reisi007.bplaced.com/program/

 Don't hesitate to ask if you need help...
 If you triage a bug, please insert yourself into the QA contact field...
 (I hope, that this wasn't too much for the takeoff at QA :)


 Liebe Grüße, / Yours,
 Florian Reisinger

 Am 02.03.2013 um 17:30 schrieb Kieran Peckett 
 crazyske...@gmail.comjavascript:_e({}, 'cvml', 'crazyske...@gmail.com');
 :

 Hi.

 I am Kieran, and I have been active at lo-documentation and lo-users for a
 month or two now, and have now decided to join QA, as I feel that won't
 take up too much more. I am posting this as an introduction to myself so
 that you all know who I am and don't wonder who is this guy whenever I
 post.

 I have already posted a couple of bugs at FDO and have done a bit of
 triaging today as well. I did do a bit of QA-ing at Mozilla a few months
 ago on bugzilla, but after having stopped using their products I found it
 to be a bit boring, so a few months later I took a look at the LO Get
 Involved page, and as I've said, joined the Docs team and have decided to
 branch out slightly more.

 One note I would like to make, though - the page on the LO website only
 mentions the developers mailing list, whilst the TDF wikipage also mentions
 this one - a correction could be made there so that they don't have to
 subscribe to a second list, or think is this the same one? and end up not
 subscribing to here as well. Maybe list both at LO, and maybe just this one
 at TDFwiki? If this was intentional by you, then don't worry about it, I
 was just thinking that new users may get a bit confused by 2 links in 2
 different places.

 ___
 List Name: Libreoffice-qa mailing list
 Mail address: Libreoffice-qa@lists.freedesktop.org javascript:_e({},
 'cvml', 'Libreoffice-qa@lists.freedesktop.org');
 Change settings:
 http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] Intro to me (Joel)

2013-03-02 Thread Joel Madero

Kieran,

Welcome to our fast growing team :-D I think Joren and Florian took care 
of a lot of the details but wanted to also say welcome. If you have time 
on Friday we'll be having our QA call at 1400 UTC - open to everyone but 
it usually has 3-5 people involved. We're gearing up for the QA triaging 
contest so we'll be discussing that quite a bit. Details:


https://wiki.documentfoundation.org/QA_Call_Current_Agenda

Again, welcome and thanks for any work that you do, it's greatly 
appreciated.



Best,
Joel Madero
LibreOffice QA Team

P.S. Just a small note - contributors have been asked to stay clear of 
using LO - LibO or fully spelling out is preferred :-D

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 61676] New: FORMATTING: Impossible to format text in a chart text box

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61676

  Priority: medium
Bug ID: 61676
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FORMATTING: Impossible to format text in a chart text
box
  Severity: normal
Classification: Unclassified
OS: Linux (All)
  Reporter: stephane.guil...@gmail.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 3.6.5.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 75767
  -- https://bugs.freedesktop.org/attachment.cgi?id=75767action=edit
Example spreadsheet to test this

Problem description: 
It is currently impossible to format text in text boxes that are part of a
chart in Calc.
However, text formatting is possible in boxes created in the rest of the
spreadsheet.

Steps to reproduce:
1. Create a chart in a .ods document
2. Add a title (axis or main)
3. Try to format a section of the text (subscript, superscript, bold,
italic...)

Current behavior:
Even though it is possible to format the whole title (bold, italic, bold and
italic, font and font size), there are no options for formatting a portion of
text.

Expected behavior:
There should be at least basic options to format a section of text, as this
would be helpful in many cases, e.g. superscript numbers for functions or
subscript numbers for chemicals.
Operating System: Ubuntu
Version: 3.6.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61622] Problem scaling symbol in Math

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61622

--- Comment #6 from Andrea si...@libero.it ---
Created attachment 75768
  -- https://bugs.freedesktop.org/attachment.cgi?id=75768action=edit
win7-win8

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61622] Problem scaling symbol in Math

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61622

--- Comment #7 from Andrea si...@libero.it ---
Hello Jacques,
I use Time in font settings, default. In win7 i have no problem.
I attach an image for comparison, with the font settings. In the red circle you
can see that the character is different. So I tried to change the font for the
functions but there have been no changes.
Regards, Andrea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61677] New: FORMATTING change of cells calculated from calculated cells needs Complete Recalculation

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61677

  Priority: medium
Bug ID: 61677
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FORMATTING change of cells calculated from calculated
cells needs Complete Recalculation
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: libreoff...@bielefeldundbuss.de
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.0.1.2 rc
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 75769
  -- https://bugs.freedesktop.org/attachment.cgi?id=75769action=edit
Sample Document

Steps how to reproduce [Reproducible] with LibO  4.0.1.2 rc   -  German UI /
German Locale  [Build ID: 84102822e3d61eb989ddd325abf1ac077904985)] 
{tinderbox: @6, pull time  2013-02-28 08:53(?)} on German WIN7 Home Premium
(64bit):

1. open attached 0_sample.ods
2. Select A17:B26
3. Click 'Currency' icon in Formatting Toolbar
   Expected: all selected range changes to currency view
   Actual: Only valuse in column A become currency.

More info:
--
Values A17:A26 are directly calculated from values A2:A11
Values B17:B26 are calculated from values B2B11m what are calculated from
values A2:A11

The relation is tricky, and the Summary only is correct for the sample
document. I found a how to create a very simple sample:
11. Open new blank spreadsheet fom LibO start Center
12. Type 1 to A1
13. =A1 to B1
14. =A1 to A2
15. Save as sample.ods
16. Select A1:B2
17. Click Currency
 all become currency
18. Quit without saving
19. reopen sample.ods
20. Select A1:B2
21. Click Currency
bug: only A1 becomes currency
22. Undo 
 back to default number formatting
23. also try for only B1 or A1, selected or only in cell cursor
Bug: never currency

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60914] Number FORMATTING not changed in all cells of selection

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60914

--- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
I can no longer reproduce the problem with sample document of original report.

But for me the problem still exists in Attachment 74880 for Bug 56045:

30. Download sample document
31. open sample document from LibO Start Center
32. Select B2:B5 using mouse
33. Click 'Currency' icon in Formatting Toolbar
Expected: all cells switch to currency
Actual: only B2 becomes currency

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60062] Language change via Cell Format is ignored by Spellchecker

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60062

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

  Attachment #73919|0   |1
is obsolete||

--- Comment #7 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
Comment on attachment 73919
  -- https://bugs.freedesktop.org/attachment.cgi?id=73919
attachment-15289-0.html

submitter error, not a sample

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61664] EDITING: Crash when Insert - Fields - other is pressed

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61664

--- Comment #3 from ger...@fuchsclan.de ger...@fuchsclan.de ---
Hi Julien,
renaming the LO Directory profile actually solves the issue,thanks.
My Java version is: Version 7 Update 15 Build 1.7.0_15-b03
my OSX version is: 10.8.2

regards
Gerald


(In reply to comment #2)
 Gerald: what's your Java version?
 Did you try to rename your LO directory profile and test again? (see
 https://wiki.documentfoundation.org/UserProfile)
 Also, what's your MacOs version?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60062] Language change via Cell Format is ignored by Spellchecker

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60062

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #8 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
@mbramhill, Urmas
Blease contribute LibO Version info

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61664] EDITING: Crash when Insert - Fields - other is pressed

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61664

--- Comment #4 from Julien Nabet serval2...@yahoo.fr ---
Thank you for your feedback Gerald.
If you still have the old LO directory profile, could you zip and attach it to
the bugtracker?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60062] Language change via Cell Format is ignored by Spellchecker

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60062

--- Comment #9 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
[Reproducible] with Server Installation of LibO  4.0.2.0+   -  English UI /
German Locale  [Build ID: 01f8d0a1dffce854a66c0f957e81e6df6d361a8)] 
{tinderbox: @6, pull time  2013-02-26 09:45:35} on German WIN7 Home Premium
(64bit) with newly created user profile ….\LODev\4\

Reporter's sample and own samples keep old cell language until document has
been saved and reopened. Complete Recalculation does not help.

I have LT Language Tool installed and do not know whether that might have
influence.

@@mbramhill, Urmas:
Please also contribute info concerning your Operating system and language
related Extensions

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61540] Insert column in a table deforms it, reduces the column size

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61540

abdulmajeed aalabdulraz...@kacst.edu.sa changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from abdulmajeed aalabdulraz...@kacst.edu.sa ---
Conform this bug on ubuntu 12.10 64bit  on master 4.1.0 alpha

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58962] Impossible to change cell format Date to Number Standard

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58962

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
Closed due to reporter's inactivity.

@reporter:
Please feel free to reopen this bug if you find out that the problem still
exists with the current stable LibreOffice version and if you can contribute
requested additional information due to
http://wiki.documentfoundation.org/BugReport (especially BugReport Details)!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61134] Font combo tooltip doesn’t say which substitute font is being used

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61134

--- Comment #2 from junk_2...@live.co.uk ---
Michael Meeks in comment 1 said:
  I believe we were going to implement this font substitution tooltip for 4.0
right ? did we do that already ? :-)


My understanding is that there is a patch that will implement a tooltip to say
that a font substitution has taken place:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=17d86df23e7be3ab0a161f69ff0f703728e0e135

This ticket is an enhancement suggestion that the tooltip should say which font
is actually being used as the substitute. Otherwise we are telling the user his
font is not available, but not which font is actually being used.

In fact the tooltip should ideally say:
* which font is not available
* which one is being used as a substitute
* if desired how to change which font is being used as the substitute

This may be too much information...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60341] EDITING, Formating: Unable change font of pasted text

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60341

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||LibreOffice@bielefeldundbus
   ||s.de
 Ever confirmed|0   |1

--- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
I wonder how reporter got the subscripts into his pasted contents, LibO 
4.0.1.2 rc   -  German UI / German Locale  [Build ID:
84102822e3d61eb989ddd325abf1ac077904985)]  {tinderbox: @6, pull time 
2013-02-28 08:53(?)} on German WIN7 Home Premium (64bit): will ignore them when
I paste

Concerning paste

@Frantisek Erben:
We need a clear and comprehensive description here what exactly you  consider
as a bug. We can't handle something like sometimes formatting changes seem
unexpected to me, and Change font size is much to imprecise. How and where?
Please do not describe what you observe, but describe (precisely, every mouse
click and every key press) what we have to do to reproduce your observations).
And if you expect something please cite some Help or similar.  

But your source document 2013-02-06 07:23 UTC, Frantisek Erben inspired me to
some experiments, I will report separate bugs and add you to CC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61679] New: SLIDESHOW: Enhancement request: control over the timing of presentation delay in kiosk mode

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61679

  Priority: medium
Bug ID: 61679
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: SLIDESHOW: Enhancement request: control over the
timing of presentation delay in kiosk mode
  Severity: normal
Classification: Unclassified
OS: Linux (All)
  Reporter: li...@bospaling.nl
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.0.3 release
 Component: Presentation
   Product: LibreOffice

I'm using Libreoffice in Kioskmode on raspberrypis to display messages on tv
screens ( bulletin boards in a school). The presentations are developed in
Powerpoint and automatically copied to the raspberry server. However
Libreoffice automatically adds a 10 second delay between the display of every
series of slides. Since powerpoint is not aware of this feature, we cannot
remove it during the creation of the slides. How can I default remove this
delay, since it is especially annoying when displaying a presentation of just 1
or 2 slides.
Operating System: Debian
Version: 4.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61636] EDITING: Deleting text causes Writer to crash

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61636

--- Comment #11 from Pär Johansson par.johanss...@comhem.se ---
Hi Julien Nabet!

Thank You for Your input.

Enclosed please find the terminal output and gdbtrace.log for soffice
--backtrace.

I use Oracle's Java version 7 update 13.
(Oh! There is apparently an update 15 available.)

Best regards,

Pär Johansson

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61636] EDITING: Deleting text causes Writer to crash

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61636

--- Comment #12 from Pär Johansson par.johanss...@comhem.se ---
Created attachment 75770
  -- https://bugs.freedesktop.org/attachment.cgi?id=75770action=edit
Terminal output from running soffice --backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61636] EDITING: Deleting text causes Writer to crash

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61636

--- Comment #13 from Pär Johansson par.johanss...@comhem.se ---
Created attachment 75771
  -- https://bugs.freedesktop.org/attachment.cgi?id=75771action=edit
The gdbtrace.log file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61544] UI: Some fields don't fit into Options dialog

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61544

--- Comment #1 from HP theca...@netscape.net ---
I have the same issue with Version 4.0.0.3 (Build ID:
7545bee9c2a0782548772a21bc84a9dcc583b89) on Ubuntu 12.04 LTS x86

Basically, even when I disable using the system font in the options dialog,
options overlap. I would really like to be able to resize that dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61680] New: Inserting pictures in spreadsheet default to cell

2013-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61680

  Priority: high
Bug ID: 61680
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Inserting pictures in spreadsheet default to cell
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: p_kongs...@op.pl
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.0.0.2 rc
 Component: Spreadsheet
   Product: LibreOffice

Today all pictures inserted to Calc is anchored to page.

The basic of spreadsheets are that data is linked to cell addresses, so it is
not naturally that pictures should be handled differently.

Also Excel is handling this differently than Calc.

So please consider to default inserting pictures anchored to cell instead of
page.

Please allow for dragging from one cell to another cell as well.

In Excel 2010 as an example inserting a picture is inserted with the option
'Move but don't size with cells'
Excel has 3 options available:
Move and size with cells
Move but don't size with cells
Don't move or size with cells

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >