LibreOffice Gerrit News for submodules on 2014-09-01
Moin! ~~ Project dictionaries ~~ Nothing moved in the project for the last 25 hours ~~ Project translations ~~ Nothing moved in the project for the last 25 hours ~~ Project help ~~ * Open changes on master for project help changed in the last 25 hours: None * Merged changes on master for project help changed in the last 25 hours: + Help page for Fill random numbers for new dialog in https://gerrit.libreoffice.org/11207 from Olivier Hallot * Abandoned changes on master for project help changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: None Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
LibreOffice Gerrit News for core on 2014-09-01
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + xmerge: replace package.html with package-info.java in https://gerrit.libreoffice.org/11221 from Robert Antoni Buj i Gelonch about module xmerge + xmerge: javadoc maintenance and minor code formatting in https://gerrit.libreoffice.org/11202 from Robert Antoni Buj i Gelonch about module xmerge End of freshness + fdo#83311 Fix infobar for documents with read-only property in https://gerrit.libreoffice.org/11220 from Samuel Mehrbrodt about module sfx2 + Remove redundancy in Statistics labels in https://gerrit.libreoffice.org/11222 from Adolfo Jayme Barrientos about module sw + fdo#63154: Rearrange some solar.h includes in https://gerrit.libreoffice.org/10892 from Marcos Paulo de Souza about module chart2, connectivity, dbaccess, editeng, extensions, filter, idl, include, linguistic, lotuswordpro, rsc, sc, sd, sfx2, svl, svtools, svx, sw, tools, unotools, xmloff + fdo#83302 don't display read-only infobar for Base form in normal mode in https://gerrit.libreoffice.org/11219 from Lionel Elie Mamane about module sfx2 + fdo#81132 Remove some formatting options from the right-click menu in Wri in https://gerrit.libreoffice.org/1 from Samuel Mehrbrodt about module sc, sd, svx, sw + fdo#82969 Add AutoSpellcheck to tools menu in https://gerrit.libreoffice.org/11201 from Samuel Mehrbrodt about module sw + fdo#57929 Toggle absolute/relative of external reference in https://gerrit.libreoffice.org/11218 from Laurent BP about module sc * Merged changes on master for project core changed in the last 25 hours: + fdo#83048: DOCX: Corrupt: LO exports wrong SDT properties of Date in https://gerrit.libreoffice.org/11160 from Pallavi Jadhav + More mushrooms... in https://gerrit.libreoffice.org/11217 from Olivier Hallot + Treeview may lose focus when left/right arrow is used in https://gerrit.libreoffice.org/10956 from Niklas Johansson + GraphicManager: fix crash when swapping out graphics in https://gerrit.libreoffice.org/11215 from Michael Stahl + GraphicManager: let's assert GraphicObjects are inserted and deleted once in https://gerrit.libreoffice.org/11214 from Michael Stahl + Left-align labels in Detailed Calculation Settings dialog in https://gerrit.libreoffice.org/11209 from Adolfo Jayme Barrientos + fdo#80538 Add (hidden) edit icons to the toolbar again in https://gerrit.libreoffice.org/11203 from Samuel Mehrbrodt + Improve layout of random number generator dialog in https://gerrit.libreoffice.org/11206 from Olivier Hallot + Help buttons mushrooming all over the place... in https://gerrit.libreoffice.org/11212 from Olivier Hallot + fdo#83289 (part) help btn for impress photo album in https://gerrit.libreoffice.org/11211 from Olivier Hallot + Add help button to dialog in https://gerrit.libreoffice.org/11210 from Olivier Hallot + FDO#83283 (part) help btn for Label Field select'n in https://gerrit.libreoffice.org/11208 from Olivier Hallot + fdo#80269 (part): Help button for Calc Form dialog in https://gerrit.libreoffice.org/11204 from Olivier Hallot * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + Resolves fdo#47832: Pictures on buttons (in forms) gone after reopening f in https://gerrit.libreoffice.org/10033 from Julien Nabet + fdo#63154: Use OSL_* macros to manage endianess... in https://gerrit.libreoffice.org/11082 from Marcos Paulo de Souza + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde + l10ntools: fixes and improvements for transex3 executable in https://gerrit.libreoffice.org/10212 from Douglas Mencken + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji + fdo#82290: Perform write(2) and read(2) concurrently to avoid pipe deadlo in https://gerrit.libreoffice.org/10825 from Jan Holesovsky + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#77716 : Paragraph spacing is not preserved after RT. in https://gerrit.libreoffice.org/9197 from Tushar Bende + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/ooxml/model.xml | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) New commits: commit 314241ed0e1e018560a5f0f0afdd18f107bc68e5 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Sep 1 07:58:06 2014 +0200 Clean up 6 times duplicated xmlns:a definition Change-Id: I935856965bcb1f710059801621124685aeb65a03 diff --git a/writerfilter/source/ooxml/model.xml b/writerfilter/source/ooxml/model.xml index 906b645..0faef0e 100644 --- a/writerfilter/source/ooxml/model.xml +++ b/writerfilter/source/ooxml/model.xml @@ -17,6 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . -- model + xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; xmlns:r=http://schemas.openxmlformats.org/officeDocument/2006/relationships; xmlns:rng=http://relaxng.org/ns/structure/1.0; xmlns:xml=http://www.w3.org/XML/1998/namespace; @@ -3755,7 +3756,7 @@ resource name=ST_DrawingElementId resource=Integer/ /namespace namespace name=dml-documentProperties file=dml-documentProperties.rng -grammar xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- ISO RELAX NG Schema -- include href=dml-shapeGeometry.rng/ define name=AG_Locking @@ -3951,7 +3952,7 @@ attribute name=noMove tokenid=ooxml:CT_GraphicalObjectFrameLocking_noMove/ attribute name=noResize tokenid=ooxml:CT_GraphicalObjectFrameLocking_noResize/ /resource -resource xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; name=CT_NonVisualDrawingProps resource=Properties +resource name=CT_NonVisualDrawingProps resource=Properties element name=a:hlinkClick tokenid=ooxml:CT_NonVisualDrawingProps_a_hlinkClick/ element name=hlinkHover tokenid=ooxml:CT_NonVisualDrawingProps_hlinkHover/ element name=extLst tokenid=ooxml:CT_NonVisualDrawingProps_extLst/ @@ -6668,7 +6669,7 @@ namespace name=dml-wordprocessingDrawing file=dml-wordprocessingDrawing.rng start name=inline/ start name=anchor/ -grammar xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/wordprocessingDrawing; +grammar xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/wordprocessingDrawing; !-- ISO RELAX NG Schema -- include href=dml-graphicalObject.rng/ include href=dml-documentProperties.rng/ @@ -7018,7 +7019,7 @@ attribute name=b tokenid=ooxml:CT_EffectExtent_b/ /resource resource name=ST_WrapDistance resource=Integer/ -resource xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; name=CT_Inline resource=Properties +resource xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; name=CT_Inline resource=Properties element name=extent tokenid=ooxml:CT_Inline_extent/ element name=effectExtent tokenid=ooxml:CT_Inline_effectExtent/ element name=docPr tokenid=ooxml:CT_Inline_docPr/ @@ -7116,7 +7117,7 @@ attribute name=relativeFrom tokenid=ooxml:CT_PosV_relativeFrom/ /resource resource name=ST_EditId resource=Hex/ -resource xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; name=CT_Anchor resource=Properties +resource xmlns:wp14=http://schemas.microsoft.com/office/word/2010/wordprocessingDrawing; name=CT_Anchor resource=Properties element name=simplePos tokenid=ooxml:CT_Anchor_simplePos_elem/ element name=positionH tokenid=ooxml:CT_Anchor_positionH/ element name=positionV tokenid=ooxml:CT_Anchor_positionV/ @@ -8399,7 +8400,7 @@ resource name=relIds resource=Shape element xmlns:dgm=http://schemas.openxmlformats.org/drawingml/2006/diagram; name=dgm:relIds tokenid=ooxml:dgm_relIds/ /resource -resource xmlns:a=http://schemas.openxmlformats.org/drawingml/2006/main; name=CT_GvmlGroupShape resource=Shape +resource name=CT_GvmlGroupShape resource=Shape element
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/viewfrm.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 8cf89c24906c6d50a3c15f1ebef4df071ad6ec79 Author: Samuel Mehrbrodt s.mehrbr...@gmail.com Date: Sun Aug 31 22:37:47 2014 +0200 fdo#83311 Fix infobar for documents with read-only property Change-Id: Ic813ab3eb74a088b60b4dc3dcd56e7b19683190c Reviewed-on: https://gerrit.libreoffice.org/11220 Reviewed-by: Lionel Elie Mamane lio...@mamane.lu Tested-by: Lionel Elie Mamane lio...@mamane.lu diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index efef8f4..40d4b67 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -403,6 +403,9 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest rReq ) pSh-SetModifyPasswordEntered(); } +// Remove infobar if document was read-only (after password check) +RemoveInfoBar(readonly); + nOpenMode = pSh-IsOriginallyReadOnlyMedium() ? SFX_STREAM_READONLY : SFX_STREAM_READWRITE; // if only the view was in the readonly mode then there is no need to do the reload @@ -416,7 +419,7 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest rReq ) return; } -RemoveInfoBar(readonly); + pSh-SetReadOnlyUI( false ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/view/viewfrm.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 542ae4e06f9f70e328a3e85f1272ead558b36766 Author: Lionel Elie Mamane lio...@mamane.lu Date: Sun Aug 31 21:48:12 2014 +0200 fdo#83302 don't display read-only infobar for Base form in normal mode Change-Id: I6faae7f5b1b2ec243c53453a8627bd0a540a46ad Reviewed-on: https://gerrit.libreoffice.org/11219 Reviewed-by: Bosdonnat Cedric cedric.bosdon...@free.fr Tested-by: Bosdonnat Cedric cedric.bosdon...@free.fr diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index 40d4b67..c01974d 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -1346,7 +1346,13 @@ void SfxViewFrame::Notify( SfxBroadcaster /*rBC*/, const SfxHint rHint ) SfxBindings rBind = GetBindings(); rBind.Invalidate( SID_RELOAD ); rBind.Invalidate( SID_EDITDOC ); -if ( !xObjSh-IsReadOnly() ) +SfxViewShell *pVSh; +FmFormShell *pFSh; +if ( !xObjSh-IsReadOnly() || + ( xObjSh-GetCreateMode() == SFX_CREATE_MODE_EMBEDDED + (pVSh = xObjSh-GetViewShell()) + (pFSh = pVSh-GetFormShell()) + !pFSh-IsDesignMode())) { // In contrast to above (TITLE_CHANGED) does the UI not // have to be updated because it was not obstructed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source sw/inc sw/qa sw/source
editeng/source/editeng/textconv.cxx |2 sw/inc/hhcwrp.hxx |2 sw/qa/extras/uiwriter/uiwriter.cxx | 122 sw/source/uibase/lingu/hhcwrp.cxx |4 - 4 files changed, 126 insertions(+), 4 deletions(-) New commits: commit c369013edb76cd47ef7e8c193a18a57ff165ddfb Author: Matthew J. Francis mjay.fran...@gmail.com Date: Fri Aug 29 18:18:40 2014 +0800 fdo#83178 fix Chinese Conversion crash Reviewed on: https://gerrit.libreoffice.org/11187 Change-Id: Ifa9c7c1a29d7076903e038d3132c635b1143e2d8 diff --git a/editeng/source/editeng/textconv.cxx b/editeng/source/editeng/textconv.cxx index 307d0e8..f843f83 100644 --- a/editeng/source/editeng/textconv.cxx +++ b/editeng/source/editeng/textconv.cxx @@ -478,7 +478,7 @@ void TextConvWrapper::ChangeText( const OUString rNewText, } // end of string also terminates non-matching char sequence -if (rOrigText[nIndex] == rNewText[nPos] || nPos == nConvTextLen) +if (nPos == nConvTextLen || rOrigText[nIndex] == rNewText[nPos]) { // substring that needs to be replaced found? if (nChgPos=0 nConvChgPos=0) diff --git a/sw/inc/hhcwrp.hxx b/sw/inc/hhcwrp.hxx index df973d0..9ff03b6 100644 --- a/sw/inc/hhcwrp.hxx +++ b/sw/inc/hhcwrp.hxx @@ -27,7 +27,7 @@ class SwWrtShell; struct SwConversionArgs; class SwPaM; -class SwHHCWrapper : public editeng::HangulHanjaConversion +class SW_DLLPUBLIC SwHHCWrapper : public editeng::HangulHanjaConversion { SwView *m_pView; Window* m_pWin; diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 0665f49..6cb67f7 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -6,6 +6,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#include com/sun/star/i18n/TextConversionOption.hpp #include swmodeltestbase.hxx #include ndtxt.hxx #include wrtsh.hxx @@ -19,6 +20,8 @@ #include fmtclds.hxx #include dcontact.hxx #include textboxhelper.hxx +#include view.hxx +#include hhcwrp.hxx #include svx/svdpage.hxx #include svx/svdview.hxx @@ -48,6 +51,10 @@ public: void testShapeTextboxVertadjust(); void testShapeTextboxAutosize(); void testFdo82191(); +void testChineseConversionBlank(); +void testChineseConversionNonChineseText(); +void testChineseConversionTraditionalToSimplified(); +void testChineseConversionSimplifiedToTraditional(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -65,6 +72,11 @@ public: CPPUNIT_TEST(testShapeTextboxVertadjust); CPPUNIT_TEST(testShapeTextboxAutosize); CPPUNIT_TEST(testFdo82191); +CPPUNIT_TEST(testChineseConversionBlank); +CPPUNIT_TEST(testChineseConversionNonChineseText); +CPPUNIT_TEST(testChineseConversionTraditionalToSimplified); +CPPUNIT_TEST(testChineseConversionSimplifiedToTraditional); + CPPUNIT_TEST_SUITE_END(); private: @@ -414,6 +426,116 @@ void SwUiWriterTest::testFdo82191() CPPUNIT_ASSERT_EQUAL(size_t(2), aTextBoxes.size()); } + +// Chinese conversion tests + +static const OUString CHINESE_TRADITIONAL_CONTENT(sal_Unicode(0x9F8D)); +static const OUString CHINESE_SIMPLIFIED_CONTENT(sal_Unicode(0x9F99)); +static const OUString NON_CHINESE_CONTENT (Hippopotamus); + +// Tests that a blank document is still blank after conversion +void SwUiWriterTest::testChineseConversionBlank() +{ + +// Given +SwDoc* pDoc = createDoc(); +SwView* pView = pDoc-GetDocShell()-GetView(); +const uno::Reference uno::XComponentContext xContext( comphelper::getProcessComponentContext() ); +SwNodeIndex aIdx(pDoc-GetNodes().GetEndOfContent(), -1); +SwPaM aPaM(aIdx); + +// When +SwHHCWrapper aWrap( pView, xContext, LANGUAGE_CHINESE_TRADITIONAL, LANGUAGE_CHINESE_SIMPLIFIED, NULL, +i18n::TextConversionOption::CHARACTER_BY_CHARACTER, false, +true, false, false ); +aWrap.Convert(); + + +// Then +SwTxtNode* pTxtNode = aPaM.GetNode().GetTxtNode(); +CPPUNIT_ASSERT_EQUAL(OUString(), pTxtNode-GetTxt()); + +} + +// Tests that non Chinese text is unchanged after conversion +void SwUiWriterTest::testChineseConversionNonChineseText() +{ + +// Given +SwDoc* pDoc = createDoc(); +SwView* pView = pDoc-GetDocShell()-GetView(); +const uno::Reference uno::XComponentContext xContext( comphelper::getProcessComponentContext() ); +SwNodeIndex aIdx(pDoc-GetNodes().GetEndOfContent(), -1); +SwPaM aPaM(aIdx); +pDoc-getIDocumentContentOperations().InsertString(aPaM, NON_CHINESE_CONTENT); + + +// When +SwHHCWrapper aWrap( pView, xContext, LANGUAGE_CHINESE_TRADITIONAL, LANGUAGE_CHINESE_SIMPLIFIED, NULL, +i18n::TextConversionOption::CHARACTER_BY_CHARACTER, false, +true,
[Libreoffice-commits] core.git: include/sfx2 sc/source sfx2/source svx/source sw/source
include/sfx2/shell.hxx |2 +- include/sfx2/viewsh.hxx|4 sc/source/ui/inc/tabvwsh.hxx |3 ++- sfx2/source/view/viewfrm.cxx | 12 ++-- svx/source/form/fmview.cxx |3 --- sw/source/uibase/app/docsh.cxx |1 + sw/source/uibase/inc/view.hxx |4 ++-- 7 files changed, 20 insertions(+), 9 deletions(-) New commits: commit 15cea073e7ed4970e60967fe036fc492e2052203 Author: Lionel Elie Mamane lio...@mamane.lu Date: Wed Aug 27 18:34:02 2014 +0200 fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode Change-Id: I9700d0d729a8f2d1255fcd03a07e05799e21f8d0 Reviewed-on: https://gerrit.libreoffice.org/11152 Reviewed-by: Bosdonnat Cedric cedric.bosdon...@free.fr Tested-by: Bosdonnat Cedric cedric.bosdon...@free.fr Reviewed-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/include/sfx2/shell.hxx b/include/sfx2/shell.hxx index b79fd2d..9359324 100644 --- a/include/sfx2/shell.hxx +++ b/include/sfx2/shell.hxx @@ -160,7 +160,7 @@ protected: */ SfxShell( SfxViewShell *pViewSh ); -SAL_DLLPRIVATE void SetViewShell_Impl( SfxViewShell* pView ); +void SetViewShell_Impl( SfxViewShell* pView ); SAL_DLLPRIVATE void Invalidate_Impl( SfxBindings rBindings, sal_uInt16 nId ); SAL_DLLPRIVATE SfxShellObject* GetShellObj_Impl() const; SAL_DLLPRIVATE void SetShellObj_Impl( SfxShellObject* pObj ); diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx index 5cde831..0ed5838 100644 --- a/include/sfx2/viewsh.hxx +++ b/include/sfx2/viewsh.hxx @@ -59,6 +59,7 @@ class SfxFrameItem; class Dialog; class Menu; class NotifyEvent; +class FmFormShell; #define SFX_PRINTER_PRINTER 1 // without JOB SETUP = Temporary #define SFX_PRINTER_JOBSETUP 2 @@ -207,6 +208,9 @@ public: voidRemoveSubShell( SfxShell *pShell=NULL ); SfxShell* GetSubShell( sal_uInt16 ); +virtual FmFormShell* GetFormShell() { return 0; }; +virtual const FmFormShell* GetFormShell() const { return 0; }; + // Focus, KeyInput, Cursor voidGotFocus() const; inline void LostFocus() const; diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index b20b829..d1be501 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -366,7 +366,8 @@ public: inline void SetScSbxObject( SbxObject* pOb ) { pScSbxObject = pOb; } -FmFormShell*GetFormShell() const{ return pFormShell; } +virtual const FmFormShell* GetFormShell() const SAL_OVERRIDE { return pFormShell; } +virtual FmFormShell* GetFormShell() SAL_OVERRIDE { return pFormShell; } voidInsertURL( const OUString rName, const OUString rURL, const OUString rTarget, sal_uInt16 nMode ); diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index c01974d..5434fa6 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -21,6 +21,7 @@ #include stdio.h +#include svx/fmshell.hxx #include sfx2/infobar.hxx #include sfx2/viewfrm.hxx #include com/sun/star/document/MacroExecMode.hpp @@ -866,8 +867,15 @@ void SfxViewFrame::StateReload_Impl( SfxItemSet rSet ) { case SID_EDITDOC: { -if ( !pSh || !pSh-HasName() || !( pSh-Get_Impl()-nLoadedFlags SFX_LOADED_MAINDOCUMENT ) - || pSh-GetCreateMode() == SFX_CREATE_MODE_EMBEDDED ) +SfxViewShell *pVSh; +FmFormShell *pFSh; +if ( !pSh || + !pSh-HasName() || + !( pSh-Get_Impl()-nLoadedFlags SFX_LOADED_MAINDOCUMENT ) || + ( pSh-GetCreateMode() == SFX_CREATE_MODE_EMBEDDED + ( !(pVSh = pSh-GetViewShell()) || + !(pFSh = pVSh-GetFormShell()) || + !pFSh-IsDesignMode( rSet.DisableItem( SID_EDITDOC ); else { diff --git a/svx/source/form/fmview.cxx b/svx/source/form/fmview.cxx index 343c624..b4e8a96 100644 --- a/svx/source/form/fmview.cxx +++ b/svx/source/form/fmview.cxx @@ -130,9 +130,6 @@ void FmFormView::Init() } } -if( pObjShell pObjShell-IsReadOnly() ) -bInitDesignMode = false; - // dieses wird in der Shell vorgenommen // bDesignMode = !bInitDesignMode; // erzwingt, dass SetDesignMode ausgefuehrt wird SetDesignMode( bInitDesignMode ); diff --git a/sw/source/uibase/app/docsh.cxx b/sw/source/uibase/app/docsh.cxx index e3491cb..3da9550 100644 --- a/sw/source/uibase/app/docsh.cxx +++ b/sw/source/uibase/app/docsh.cxx @@ -1084,6 +1084,7 @@ SfxStyleSheetBasePool* SwDocShell::GetStyleSheetPool() void SwDocShell::SetView(SwView* pVw) { +SetViewShell_Impl(pVw); if ( 0
[Libreoffice-commits] core.git: 2 commits - include/sfx2 sc/source sfx2/source svx/source sw/source
include/sfx2/shell.hxx |2 +- include/sfx2/viewsh.hxx|4 sc/source/ui/inc/tabvwsh.hxx |3 +-- sfx2/source/view/viewfrm.cxx | 20 +++- svx/source/form/fmview.cxx |3 +++ sw/source/uibase/app/docsh.cxx |1 - sw/source/uibase/inc/view.hxx |4 ++-- 7 files changed, 10 insertions(+), 27 deletions(-) New commits: commit 4e4ae20ab26937200d53caa15175e7847a790268 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Sep 1 10:41:00 2014 +0200 Revert fdo#83302 don't display read-only infobar for Base form in normal mode This reverts commit 542ae4e06f9f70e328a3e85f1272ead558b36766, which breaks the build without 15cea073e7ed4970e60967fe036fc492e2052203, which had to reverted. diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index c01974d..40d4b67 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -1346,13 +1346,7 @@ void SfxViewFrame::Notify( SfxBroadcaster /*rBC*/, const SfxHint rHint ) SfxBindings rBind = GetBindings(); rBind.Invalidate( SID_RELOAD ); rBind.Invalidate( SID_EDITDOC ); -SfxViewShell *pVSh; -FmFormShell *pFSh; -if ( !xObjSh-IsReadOnly() || - ( xObjSh-GetCreateMode() == SFX_CREATE_MODE_EMBEDDED - (pVSh = xObjSh-GetViewShell()) - (pFSh = pVSh-GetFormShell()) - !pFSh-IsDesignMode())) +if ( !xObjSh-IsReadOnly() ) { // In contrast to above (TITLE_CHANGED) does the UI not // have to be updated because it was not obstructed commit 024f334c48bc3d6cfac91ab7499f6b2863223c24 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Sep 1 10:40:56 2014 +0200 Revert fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode This reverts commit 15cea073e7ed4970e60967fe036fc492e2052203. I overlooked the fact during review that this introduces an svx - sfx2 circular dependency. diff --git a/include/sfx2/shell.hxx b/include/sfx2/shell.hxx index 9359324..b79fd2d 100644 --- a/include/sfx2/shell.hxx +++ b/include/sfx2/shell.hxx @@ -160,7 +160,7 @@ protected: */ SfxShell( SfxViewShell *pViewSh ); -void SetViewShell_Impl( SfxViewShell* pView ); +SAL_DLLPRIVATE void SetViewShell_Impl( SfxViewShell* pView ); SAL_DLLPRIVATE void Invalidate_Impl( SfxBindings rBindings, sal_uInt16 nId ); SAL_DLLPRIVATE SfxShellObject* GetShellObj_Impl() const; SAL_DLLPRIVATE void SetShellObj_Impl( SfxShellObject* pObj ); diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx index 0ed5838..5cde831 100644 --- a/include/sfx2/viewsh.hxx +++ b/include/sfx2/viewsh.hxx @@ -59,7 +59,6 @@ class SfxFrameItem; class Dialog; class Menu; class NotifyEvent; -class FmFormShell; #define SFX_PRINTER_PRINTER 1 // without JOB SETUP = Temporary #define SFX_PRINTER_JOBSETUP 2 @@ -208,9 +207,6 @@ public: voidRemoveSubShell( SfxShell *pShell=NULL ); SfxShell* GetSubShell( sal_uInt16 ); -virtual FmFormShell* GetFormShell() { return 0; }; -virtual const FmFormShell* GetFormShell() const { return 0; }; - // Focus, KeyInput, Cursor voidGotFocus() const; inline void LostFocus() const; diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index d1be501..b20b829 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -366,8 +366,7 @@ public: inline void SetScSbxObject( SbxObject* pOb ) { pScSbxObject = pOb; } -virtual const FmFormShell* GetFormShell() const SAL_OVERRIDE { return pFormShell; } -virtual FmFormShell* GetFormShell() SAL_OVERRIDE { return pFormShell; } +FmFormShell*GetFormShell() const{ return pFormShell; } voidInsertURL( const OUString rName, const OUString rURL, const OUString rTarget, sal_uInt16 nMode ); diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index 5434fa6..c01974d 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -21,7 +21,6 @@ #include stdio.h -#include svx/fmshell.hxx #include sfx2/infobar.hxx #include sfx2/viewfrm.hxx #include com/sun/star/document/MacroExecMode.hpp @@ -867,15 +866,8 @@ void SfxViewFrame::StateReload_Impl( SfxItemSet rSet ) { case SID_EDITDOC: { -SfxViewShell *pVSh; -FmFormShell *pFSh; -if ( !pSh || - !pSh-HasName() || - !( pSh-Get_Impl()-nLoadedFlags SFX_LOADED_MAINDOCUMENT ) || - ( pSh-GetCreateMode() ==
[Bug 51357] SVG: Add support for more shape transition effects to svg documents exported by Impress
https://bugs.freedesktop.org/show_bug.cgi?id=51357 --- Comment #5 from d.sikele...@gmail.com --- Hello, I have a problem with the export. In the exported svg-file there is no javascript integrated. So i can't test anything. Are there any special parameters for the autogen.sh to set? What else can be the reason for my problem? Thanks for helping me. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/statisticsinfopage.ui | 65 +-- 1 file changed, 22 insertions(+), 43 deletions(-) New commits: commit 407d23baceaf7014d24d631ad308c9defd4d44d0 Author: Adolfo Jayme Barrientos fit...@ubuntu.com Date: Sun Aug 31 18:57:42 2014 -0500 Remove redundancy in Statistics labels These labels were too long, obtrusive, and state the obvious. We can make them shorter and friendlier by removing the âNumber ofâ nuisance. The equivalent dialog in Office 2013 also lacks it. Brevity is a Good Thing⢠in UIs. Change-Id: Ia44f02cbcbba22a3161cac206511de4fe4daedcc Reviewed-on: https://gerrit.libreoffice.org/11222 Reviewed-by: Joren De Cuyper jore...@libreoffice.org Reviewed-by: Thomas Arnhold tho...@arnhold.org Tested-by: Thomas Arnhold tho...@arnhold.org diff --git a/sw/uiconfig/swriter/ui/statisticsinfopage.ui b/sw/uiconfig/swriter/ui/statisticsinfopage.ui index e628534..8f6027c 100644 --- a/sw/uiconfig/swriter/ui/statisticsinfopage.ui +++ b/sw/uiconfig/swriter/ui/statisticsinfopage.ui @@ -13,7 +13,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Pages:/property +property name=label translatable=yesPages:/property property name=use_underlineTrue/property property name=mnemonic_widgetnopages/property /object @@ -29,7 +29,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Tables:/property +property name=label translatable=yesTables:/property property name=use_underlineTrue/property property name=mnemonic_widgetnotables/property /object @@ -45,7 +45,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Images:/property +property name=label translatable=yesImages:/property property name=use_underlineTrue/property property name=mnemonic_widgetnogrfs/property /object @@ -61,7 +61,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of OLE Objects:/property +property name=label translatable=yesOLE Objects:/property property name=use_underlineTrue/property property name=mnemonic_widgetnooles/property /object @@ -77,7 +77,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Paragraphs:/property +property name=label translatable=yesParagraphs:/property property name=use_underlineTrue/property property name=mnemonic_widgetnoparas/property /object @@ -93,7 +93,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Words:/property +property name=label translatable=yesWords:/property property name=use_underlineTrue/property property name=mnemonic_widgetnowords/property /object @@ -109,7 +109,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Characters:/property +property name=label translatable=yesCharacters:/property property name=use_underlineTrue/property property name=mnemonic_widgetnochars/property /object @@ -127,7 +127,7 @@ property name=halignstart/property property name=valigncenter/property property name=xalign0/property -property name=label translatable=yesNumber of Characters excluding spaces:/property +property name=label translatable=yesCharacters excluding spaces:/property property name=use_underlineTrue/property property name=mnemonic_widgetnocharsexspaces/property /object @@ -143,7 +143,7 @@ property name=visibleTrue/property property name=can_focusFalse/property property name=xalign0/property -property name=label translatable=yesNumber of Lines:/property +property name=label translatable=yesLines:/property property name=use_underlineTrue/property property name=mnemonic_widgetnolines/property /object @@ -283,21 +283,6 @@ /packing /child child - object class=GtkButton id=update -property name=label translatable=yesUpdate/property -property
minutes of ESC call ...
* Present: + Bjoern, Andras, Jan-Marek G, Michael M, Christian, Stephan, Muthu, David, Eike, Kohei, Michael S, Markus, Miklos, Robinson, Cedric, Lionel * Completed Action Items: + contact Michael / the list when students show up (Jan Marek) [ students mostly coming to Bern for the conference ] + fix the 4.4 feature page (Norbert): + https://wiki.documentfoundation.org/ReleaseNotes/4.4#Mac_OS_X + speak at the conference on testing (Umesh) + trained in crash-test / VM maintenance for September/October (Miklos) * Pending Action Items: + ask UX advise wrt. wrench icons (revert or not ?) (Astron) + blog about the sad realities of web plugins (Bjoern) + open-source newer Synezip tests (Umesh) + get work / screenshots into the 4.4 feature list (Mentors ask students) + reach out / plan wrt. FOSDEM dev-rooms (Thorsten) * Release Engineering update (Christian) + 4.2.6-security release announced + 4.3.1 released early too + build issues with the VM, requiring re-starts. + rest of release schedule un-affected + 4.3.2 - branch off at the conference. + 4.2.7 - due in week 40 - 29th Sept freeze. + Potential for new incremental releases sooner. + Android Remote + pushed changes to the build-system to use gradle + in future, will be created using Android Studio. + now rather easier to hack on. * emergency release numbering policy (Bjoern/Eike) + if we always bump micro (major.minor.micro.nano) then we have problems with bugzilla fixed in next comments, not just attribute (Eike) + potentially update nano - as in 4.2.6.3 - no text changes + for this OOB release, recommend people patch don't ver. bump themselves if necessary. * GSOC Update (Cedric) + all set. + Remaining things to do: + Students should send a small blog / links etc. of what they did to Cedric so he can write a summary post. + Google re-blogs this often, so - prettiness is mandatory. + if help needed wrt. tar-ball creation; it's easy see here: + https://wiki.documentfoundation.org/Development/GSoc#Code_submission * Crashtest update (Markus) + run out of disk space -- new build will take 5 days + freed up 15Gb. + Miklos will take over in September/October + http://dev-builds.libreoffice.org/crashtest/66c6d1ef204f3507e7663a1b8b1be05b9ec71092/ + new results look quite good, fixing appreciated. * Munich update (Jan-Marek) + student interns arrived + managed to get them to the conference; 9x people there + patches in gerrit for review already + pleased with css::util vs. utl and uno-tools changes (Miklos) + #libreoffice-lhm has people there. + still reviewing mail-merge patches (Bjoern) + https://gerrit.libreoffice.org/#/q/owner:%22Jan-Marek+Glogowski%22+status:open,n,z * Certification Committee (Stephan/Bjoern/Kendy) + waiting until ~September after the conf. * Conference preparation (Moggi) + Agenda for face-to-face - 5pm ESC meeting. + UX work + QA / bug trends review + looming design disasters * Hackfests (Bjoern) + Seattle 'Libre-Fest' (Robinson) https://wiki.documentfoundation.org/Events/2014/Seattle_LibreFest + October 26, 2014 + Bug-triaging/Intro-to-community event + Following SeaGL conference + Munich hack-fest (Jan-Marek): http://www.it-muenchen-blog.de/2014/07/bug-squashing-party-2014/ + will have a BSP come-together; if someone says they're coming just show up etc. + November 21st-23rd, 2014 https://wiki.debian.org/BSP/2014/11/de/Munich + we should drop by with 2 or 3 developers, if possible + Toulouse Hackfest ... + Confirmed for Nov. 15-16th + more details: https://wiki.documentfoundation.org/Hackfest/Toulouse2014 + Be great to have -really- easy easy hacks for devs (Bjoern) * QA (Robinson) + UNCONFIRMED count up a bit last week, + some interesting new regressions + Multimedia on OS/X - changed + OS/X moved from quicktime to AVFoundation + a number of users with embedded multimedia not working. + would love a concise bug report (Michael) + Robinson's Mac arrived for triage + Speech Editor Siri of MAC OS 10.9.4 does not work with Libreoffice 4.3.0.3 https://bugs.freedesktop.org/show_bug.cgi?id=81759 + lower case greek alphabet missing in localized Math symbol table https://bugs.freedesktop.org/show_bug.cgi?id=80650 + S.Storti filing a number of writer / RTF issues recently. (Miklos) * UX Update (Astron / Mirek) * QA stats: + https://bugs.freedesktop.org/page.cgi?id=weekly-bug-summary.html +153-98(+55 overall) many thanks to the top bug squashers: Maxim Monastirsky9 Urmas7 Eike Rathke 7
[Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 --- Comment #29 from je...@live.de --- I think this bug is too difficult for me yet, so I'll take an easier bug first to learn more about libreoffice. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 je...@live.de changed: What|Removed |Added Assignee|je...@live.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 79441, which changed state. Bug 79441 Summary: Internal references to other sheets not sorted (procedure comment 31) https://bugs.freedesktop.org/show_bug.cgi?id=79441 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Two-minute(!)-survey on motivation and free time contribution of open source developers
Dear all, for a university research project in an Open Source class at the Technical University Berlin (Germany) I would like to gather some original input from open source software developers. I kept the length of the survey to an absolute minimum!!! The survey is supposed to capture the free time contribution and the primary motivation of open source software developers. It would be fantastic if you could spend two minutes on three simple questions! Here is the link to the survey: https://de.surveymonkey.com/s/MFKXYLP I highly appreciate the (short) time you take for filling it out! Best regards, Stefan Kullack TU Berlin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: chart2/source include/svx sd/source svx/source
chart2/source/controller/dialogs/tp_PointGeometry.cxx |2 include/svx/extrud3d.hxx |2 include/svx/lathe3d.hxx |6 +- include/svx/scene3d.hxx |4 - include/svx/sphere3d.hxx |4 - include/svx/svx3ditems.hxx| 40 +++--- sd/source/ui/func/fucon3d.cxx |2 svx/source/engine3d/extrud3d.cxx |2 svx/source/engine3d/float3d.cxx | 24 +- svx/source/engine3d/lathe3d.cxx |4 - svx/source/engine3d/svx3ditems.cxx| 24 -- svx/source/engine3d/view3d1.cxx |4 - svx/source/sdr/primitive2d/sdrattributecreator.cxx|2 svx/source/sdr/properties/e3dsceneproperties.cxx |4 - svx/source/svdraw/svdattr.cxx | 12 ++--- svx/source/unodraw/unoshap3.cxx |2 16 files changed, 54 insertions(+), 84 deletions(-) New commits: commit bebe30e917ebd3bd0ce43efca737caa478fddaee Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 13:37:27 2014 +0200 Consistency around SfxUInt32Item in svx/svx3ditems.hxx ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 Consistency around SdrMetricItem. Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3 diff --git a/chart2/source/controller/dialogs/tp_PointGeometry.cxx b/chart2/source/controller/dialogs/tp_PointGeometry.cxx index 5bd37ab..5456b69 100644 --- a/chart2/source/controller/dialogs/tp_PointGeometry.cxx +++ b/chart2/source/controller/dialogs/tp_PointGeometry.cxx @@ -60,7 +60,7 @@ bool SchLayoutTabPage::FillItemSet(SfxItemSet* rOutAttrs) nSegs=4; rOutAttrs-Put(SfxInt32Item(SCHATTR_STYLE_SHAPE,nShape)); -rOutAttrs-Put(Svx3DHorizontalSegmentsItem(nSegs)); +rOutAttrs-Put(makeSvx3DHorizontalSegmentsItem(nSegs)); } return true; } diff --git a/include/svx/extrud3d.hxx b/include/svx/extrud3d.hxx index 844d94e..053f0e9 100644 --- a/include/svx/extrud3d.hxx +++ b/include/svx/extrud3d.hxx @@ -59,7 +59,7 @@ public: // BackScale: 0..100, before 0.0..1.0 sal_uInt32 GetExtrudeDepth() const -{ return ((const Svx3DDepthItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_DEPTH)).GetValue(); } +{ return ((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_DEPTH)).GetValue(); } // #107245# GetSmoothNormals() for bExtrudeSmoothed bool GetSmoothNormals() const diff --git a/include/svx/lathe3d.hxx b/include/svx/lathe3d.hxx index 6eb3854..c1bbf1b 100644 --- a/include/svx/lathe3d.hxx +++ b/include/svx/lathe3d.hxx @@ -52,11 +52,11 @@ private: // HorizontalSegments: sal_uInt32 GetHorizontalSegments() const -{ return ((const Svx3DHorizontalSegmentsItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_HORZ_SEGS)).GetValue(); } +{ return ((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_HORZ_SEGS)).GetValue(); } // VerticalSegments: sal_uInt32 GetVerticalSegments() const -{ return ((const Svx3DVerticalSegmentsItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_VERT_SEGS)).GetValue(); } +{ return ((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_VERT_SEGS)).GetValue(); } // PercentDiagonal: 0..100, before 0.0..0.5 sal_uInt16 GetPercentDiagonal() const @@ -68,7 +68,7 @@ private: // EndAngle: 0..1 sal_uInt32 GetEndAngle() const -{ return ((const Svx3DEndAngleItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_END_ANGLE)).GetValue(); } +{ return ((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_END_ANGLE)).GetValue(); } // #107245# GetSmoothNormals() for bLatheSmoothed bool GetSmoothNormals() const diff --git a/include/svx/scene3d.hxx b/include/svx/scene3d.hxx index eb19807..e7a7419 100644 --- a/include/svx/scene3d.hxx +++ b/include/svx/scene3d.hxx @@ -108,11 +108,11 @@ public: // Distance: double GetDistance() const -{ return (double)((const Svx3DDistanceItem)GetObjectItemSet().Get(SDRATTR_3DSCENE_DISTANCE)).GetValue(); } +{ return (double)((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DSCENE_DISTANCE)).GetValue(); } // Focal length: before cm, now 1/10th mm (*100) double GetFocalLength() const -{ return ((const Svx3DFocalLengthItem)GetObjectItemSet().Get(SDRATTR_3DSCENE_FOCAL_LENGTH)).GetValue(); } +{ return ((const SfxUInt32Item)GetObjectItemSet().Get(SDRATTR_3DSCENE_FOCAL_LENGTH)).GetValue(); } // Two sided lighting: bool GetTwoSidedLighting() const diff --git a/include/svx/sphere3d.hxx b/include/svx/sphere3d.hxx index 0023d6f..348fbc5 100644 --- a/include/svx/sphere3d.hxx +++ b/include/svx/sphere3d.hxx @@ -49,11 +49,11 @@ public: //
Tobias Madl license statement
Hi, all my current and past contributions made to the LibreOffice project may be licensed under the MPLv2/LGPLv3+ dual license. Until further notice, all my future contributions to the LibreOffice project are available under the MPLv2/LGPLv3+ dual license. Best regards, Tobias Madl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - svtools/source
svtools/source/graphic/grfmgr2.cxx | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) New commits: commit ca436d4da64e6a06832c324ccf5c0236a9ec90d7 Author: Armin Le Grand a...@apache.org Date: Mon Sep 1 10:32:51 2014 + i125519 check GraphicObject existance before accessing it diff --git a/svtools/source/graphic/grfmgr2.cxx b/svtools/source/graphic/grfmgr2.cxx index 5cac068..bc09415 100644 --- a/svtools/source/graphic/grfmgr2.cxx +++ b/svtools/source/graphic/grfmgr2.cxx @@ -358,8 +358,33 @@ void GraphicManager::ImplCheckSizeOfSwappedInGraphics() // do not swap out when we have less than 16KB data objects if(nSizeBytes = (16 * 1024)) { -pObj-FireSwapOutRequest(); -nUsedSize = (nSizeBytes nUsedSize) ? nUsedSize - nSizeBytes : 0; +// #125519# need to check if GraphicObject is still alive +GraphicObject* pObj2 = 0; +bool bExists(false); + +for(pObj2 = (GraphicObject*)maObjList.First(); !bExists pObj2; pObj2 = (GraphicObject*)maObjList.Next()) +{ +if(pObj2 pObj2 == pObj) +{ +bExists = true; +} +} + +if(bExists) +{ +// #125519# okay, swap it out +pObj-FireSwapOutRequest(); +nUsedSize = (nSizeBytes nUsedSize) ? nUsedSize - nSizeBytes : 0; +} +else +{ +// #125519# error: object was deleted while still a member in aCandidates. This means that +// an earlier call to pObj-FireSwapOutRequest() on an other GraphicObject has as +// a side effect *deleted* and thus removed another GraphicObject from the local +// list (maObjList). This must of course be avoided. +// To check without need to run in debugger, optionally temporarily reactivate the beep below +// Sound::Beep(); +} } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source include/svx sd/source svx/source
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx | 32 +-- include/svx/obj3d.hxx|8 include/svx/scene3d.hxx | 18 +- include/svx/svx3ditems.hxx | 93 --- sd/source/ui/func/fucon3d.cxx|2 svx/source/customshapes/EnhancedCustomShape3d.cxx| 14 - svx/source/dialog/dlgctl3d.cxx | 16 - svx/source/engine3d/float3d.cxx | 68 svx/source/engine3d/svx3ditems.cxx | 53 -- svx/source/engine3d/view3d.cxx |2 svx/source/sdr/primitive2d/sdrattributecreator.cxx | 18 +- svx/source/sdr/primitive3d/sdrattributecreator3d.cxx |8 svx/source/svdraw/svdattr.cxx| 26 +-- 13 files changed, 146 insertions(+), 212 deletions(-) New commits: commit 9f6018bb64ae1da3a476f6bfca02e06b093f9e16 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 14:46:50 2014 +0200 Consistency around SfxBoolItem in svx/svx3ditems.hxx ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 Consistency around SdrMetricItem. Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx index 5cc56d6..76294c5 100644 --- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx +++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx @@ -350,42 +350,42 @@ IMPL_LINK_NOARG(ThreeD_SceneIllumination_TabPage, PreviewChangeHdl) LightSourceInfo* pInfo = m_pLightSourceInfoList[0]; pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_1)).GetValue().GetColor(); -pInfo-aLightSource.bIsEnabled = ((const Svx3DLightOnOff1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_1)).GetValue(); +pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_1)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_1)).GetValue()); pInfo = m_pLightSourceInfoList[1]; pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_2)).GetValue().GetColor(); -pInfo-aLightSource.bIsEnabled = ((const Svx3DLightOnOff2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_2)).GetValue(); +pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_2)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_2)).GetValue()); pInfo = m_pLightSourceInfoList[2]; pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_3)).GetValue().GetColor(); -pInfo-aLightSource.bIsEnabled = ((const Svx3DLightOnOff3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_3)).GetValue(); +pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_3)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_3)).GetValue()); pInfo = m_pLightSourceInfoList[3]; pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_4)).GetValue().GetColor(); -pInfo-aLightSource.bIsEnabled = ((const Svx3DLightOnOff4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_4)).GetValue(); +pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_4)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_4)).GetValue()); pInfo = m_pLightSourceInfoList[4]; pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_5)).GetValue().GetColor(); -pInfo-aLightSource.bIsEnabled = ((const Svx3DLightOnOff5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_5)).GetValue(); +pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_5)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_5)).GetValue()); pInfo = m_pLightSourceInfoList[5]; pInfo-aLightSource.nDiffuseColor = ((const
[Libreoffice-commits] core.git: chart2/source include/svx svx/source
chart2/source/view/main/DrawModelWrapper.cxx |2 - include/svx/extrud3d.hxx |4 +- include/svx/lathe3d.hxx |4 +- include/svx/obj3d.hxx|2 - include/svx/scene3d.hxx |2 - include/svx/svx3ditems.hxx | 28 --- svx/source/customshapes/EnhancedCustomShape3d.cxx|4 +- svx/source/engine3d/float3d.cxx | 16 +- svx/source/engine3d/svx3ditems.cxx | 17 --- svx/source/sdr/primitive2d/sdrattributecreator.cxx |2 - svx/source/sdr/primitive3d/sdrattributecreator3d.cxx |2 - svx/source/svdraw/svdattr.cxx|8 ++--- 12 files changed, 35 insertions(+), 56 deletions(-) New commits: commit edf7c73d457f01831ba1ad2fb4aca1a35d7c2549 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 15:18:17 2014 +0200 Consistency around SfxUInt16Item in svx/svx3ditems.hxx ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 Consistency around SdrMetricItem. Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735 diff --git a/chart2/source/view/main/DrawModelWrapper.cxx b/chart2/source/view/main/DrawModelWrapper.cxx index 5baedd3..fef6cab 100644 --- a/chart2/source/view/main/DrawModelWrapper.cxx +++ b/chart2/source/view/main/DrawModelWrapper.cxx @@ -105,7 +105,7 @@ DrawModelWrapper::DrawModelWrapper( const uno::Referenceuno::XComponentContext SfxItemPool* pMasterPool = GetItemPool(); pMasterPool-SetDefaultMetric(SFX_MAPUNIT_100TH_MM); pMasterPool-SetPoolDefaultItem(SfxBoolItem(EE_PARA_HYPHENATE, true) ); -pMasterPool-SetPoolDefaultItem(Svx3DPercentDiagonalItem (5)); +pMasterPool-SetPoolDefaultItem(makeSvx3DPercentDiagonalItem (5)); SfxItemPool* pPool = pMasterPool; // append chart pool to end of pool chain diff --git a/include/svx/extrud3d.hxx b/include/svx/extrud3d.hxx index 053f0e9..ae3276c 100644 --- a/include/svx/extrud3d.hxx +++ b/include/svx/extrud3d.hxx @@ -51,11 +51,11 @@ public: // PercentDiagonal: 0..100, before 0.0..0.5 sal_uInt16 GetPercentDiagonal() const -{ return ((const Svx3DPercentDiagonalItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_PERCENT_DIAGONAL)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_PERCENT_DIAGONAL)).GetValue(); } // BackScale: 0..100, before 0.0..1.0 sal_uInt16 GetPercentBackScale() const -{ return ((const Svx3DBackscaleItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_BACKSCALE)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_BACKSCALE)).GetValue(); } // BackScale: 0..100, before 0.0..1.0 sal_uInt32 GetExtrudeDepth() const diff --git a/include/svx/lathe3d.hxx b/include/svx/lathe3d.hxx index c1bbf1b..46d0167 100644 --- a/include/svx/lathe3d.hxx +++ b/include/svx/lathe3d.hxx @@ -60,11 +60,11 @@ private: // PercentDiagonal: 0..100, before 0.0..0.5 sal_uInt16 GetPercentDiagonal() const -{ return ((const Svx3DPercentDiagonalItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_PERCENT_DIAGONAL)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_PERCENT_DIAGONAL)).GetValue(); } // BackScale: 0..100, before 0.0..1.0 sal_uInt16 GetBackScale() const -{ return ((const Svx3DBackscaleItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_BACKSCALE)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_BACKSCALE)).GetValue(); } // EndAngle: 0..1 sal_uInt32 GetEndAngle() const diff --git a/include/svx/obj3d.hxx b/include/svx/obj3d.hxx index 87b926f..eac17e1 100644 --- a/include/svx/obj3d.hxx +++ b/include/svx/obj3d.hxx @@ -287,7 +287,7 @@ public : // MaterialSpecularIntensity: sal_uInt16 GetMaterialSpecularIntensity() const -{ return ((const Svx3DMaterialSpecularIntensityItem)GetObjectItemSet().Get(SDRATTR_3DOBJ_MAT_SPECULAR_INTENSITY)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DOBJ_MAT_SPECULAR_INTENSITY)).GetValue(); } // TextureFilter: sal_True/FALSE bool GetTextureFilter() const diff --git a/include/svx/scene3d.hxx b/include/svx/scene3d.hxx index 1288774..058ad27 100644 --- a/include/svx/scene3d.hxx +++ b/include/svx/scene3d.hxx @@ -178,7 +178,7 @@ public: // ShadowSlant: sal_uInt16 GetShadowSlant() const -{ return ((const Svx3DShadowSlantItem)GetObjectItemSet().Get(SDRATTR_3DSCENE_SHADOW_SLANT)).GetValue(); } +{ return ((const SfxUInt16Item)GetObjectItemSet().Get(SDRATTR_3DSCENE_SHADOW_SLANT)).GetValue(); } // ShadeMode: 0 == FLAT, 1 == PHONG, 2 == SMOOTH, 3 == ForceDraft sal_uInt16 GetShadeMode() const diff --git
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/laycache.cxx |6 +++--- sw/source/core/layout/layhelp.hxx | 10 +++--- 2 files changed, 10 insertions(+), 6 deletions(-) New commits: commit e62ec6d0499e6c517713e7d5b1855a9b2c518219 Author: Takeshi Abe t...@fixedpoint.jp Date: Thu Aug 28 11:21:59 2014 +0900 fdo#75757: remove inheritance to std::vector from SwLayCacheImpl. Change-Id: I77520495aab1d6a572b25433396202b11e478636 Reviewed-on: https://gerrit.libreoffice.org/11158 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/source/core/layout/laycache.cxx b/sw/source/core/layout/laycache.cxx index 7a5ae59..14fe203 100644 --- a/sw/source/core/layout/laycache.cxx +++ b/sw/source/core/layout/laycache.cxx @@ -73,7 +73,7 @@ void SwLayoutCache::Read( SvStream rStream ) void SwLayCacheImpl::Insert( sal_uInt16 nType, sal_uLong nIndex, sal_Int32 nOffset ) { aType.push_back( nType ); -std::vectorsal_uLong::push_back( nIndex ); +mIndices.push_back( nIndex ); aOffset.push_back( nOffset ); } @@ -486,7 +486,7 @@ SwLayHelper::SwLayHelper( SwDoc *pD, SwFrm* rpF, SwFrm* rpP, SwPageFrm* rpPg, -GetIndex(); nNodeIndex -= nStartOfContent; nIndex = 0; -while( nIndex pImpl-size() (*pImpl)[ nIndex ] nNodeIndex ) +while( nIndex pImpl-size() pImpl-GetBreakIndex( nIndex ) nNodeIndex ) { ++nIndex; } @@ -881,7 +881,7 @@ bool SwLayHelper::CheckInsert( sal_uLong nNodeIndex ) } } } while( bLongTab || ( pImpl nIndex pImpl-size() - (*pImpl)[ nIndex ] == nNodeIndex ) ); + pImpl-GetBreakIndex( nIndex ) == nNodeIndex ) ); } bFirst = false; return bRet; diff --git a/sw/source/core/layout/layhelp.hxx b/sw/source/core/layout/layhelp.hxx index 493e409..306147f 100644 --- a/sw/source/core/layout/layhelp.hxx +++ b/sw/source/core/layout/layhelp.hxx @@ -49,8 +49,9 @@ class SvStream; class SwFlyCache; typedef boost::ptr_vectorSwFlyCache SwPageFlyCache; -class SwLayCacheImpl : public std::vectorsal_uLong +class SwLayCacheImpl { +std::vectorsal_uLong mIndices; std::dequesal_Int32 aOffset; std::vectorsal_uInt16 aType; SwPageFlyCache aFlyCache; @@ -58,10 +59,13 @@ class SwLayCacheImpl : public std::vectorsal_uLong void Insert( sal_uInt16 nType, sal_uLong nIndex, sal_Int32 nOffset ); public: -SwLayCacheImpl() : bUseFlyCache(false) {} +SwLayCacheImpl() : mIndices(), aOffset(), aType(), aFlyCache(), bUseFlyCache(false) {} + +size_t size() const { return mIndices.size(); } + bool Read( SvStream rStream ); -sal_uLong GetBreakIndex( sal_uInt16 nIdx ) const { return std::vectorsal_uLong::operator[]( nIdx ); } +sal_uLong GetBreakIndex( sal_uInt16 nIdx ) const { return mIndices[ nIdx ]; } sal_Int32 GetBreakOfst( size_t nIdx ) const { return aOffset[ nIdx ]; } sal_uInt16 GetBreakType( sal_uInt16 nIdx ) const { return aType[ nIdx ]; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 75757] remove inheritance to std::map and std::vector
https://bugs.freedesktop.org/show_bug.cgi?id=75757 --- Comment #27 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e62ec6d0499e6c517713e7d5b1855a9b2c518219 fdo#75757: remove inheritance to std::vector The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/svx3ditems.hxx |6 ++ svx/source/engine3d/svx3ditems.cxx | 26 -- 2 files changed, 30 insertions(+), 2 deletions(-) New commits: commit d19609e118ee0bfb823945582e823d02bdaa7134 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 15:40:39 2014 +0200 Missing Clone overrides Change-Id: I0dda3dc849fce9ba994baa82f7e25497ea995c75 diff --git a/include/svx/svx3ditems.hxx b/include/svx/svx3ditems.hxx index eb34a5e..10e1334 100644 --- a/include/svx/svx3ditems.hxx +++ b/include/svx/svx3ditems.hxx @@ -65,6 +65,7 @@ public: Svx3DReducedLineGeometryItem(bool bVal = false); virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; class SVX_DLLPUBLIC Svx3DNormalsKindItem : public SfxUInt16Item { @@ -309,6 +310,7 @@ public: Svx3DSmoothNormalsItem(bool bVal = true); virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; // #107245# Item to replace bExtrudeSmoothFrontBack and bLatheSmoothFrontBack @@ -317,6 +319,7 @@ public: Svx3DSmoothLidsItem(bool bVal = false); virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; // #107245# Item to replace bExtrudeCharacterMode and bLatheCharacterMode @@ -325,6 +328,7 @@ public: Svx3DCharacterModeItem(bool bVal = false); virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; // #107245# Item to replace bExtrudeCloseFront and bLatheCloseFront @@ -333,6 +337,7 @@ public: Svx3DCloseFrontItem(bool bVal = true); SVX_DLLPRIVATE virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; SVX_DLLPRIVATE virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; // #107245# Item to replace bExtrudeCloseBack and bLatheCloseBack @@ -341,6 +346,7 @@ public: Svx3DCloseBackItem(bool bVal = true); SVX_DLLPRIVATE virtual SfxPoolItem* Create(SvStream rIn, sal_uInt16 nItemVersion) const SAL_OVERRIDE; SVX_DLLPRIVATE virtual sal_uInt16 GetVersion(sal_uInt16 nFileFormatVersion) const SAL_OVERRIDE; +SfxPoolItem * Clone(SfxItemPool *) const SAL_OVERRIDE; }; #endif // INCLUDED_SVX_SVX3DITEMS_HXX diff --git a/svx/source/engine3d/svx3ditems.cxx b/svx/source/engine3d/svx3ditems.cxx index 4242a0b..a50e64e 100644 --- a/svx/source/engine3d/svx3ditems.cxx +++ b/svx/source/engine3d/svx3ditems.cxx @@ -56,7 +56,10 @@ SfxPoolItem* Svx3DReducedLineGeometryItem::Create(SvStream rIn, sal_uInt16 nIte return pRetval; } - +SfxPoolItem * Svx3DReducedLineGeometryItem::Clone(SfxItemPool *) const +{ +return new Svx3DReducedLineGeometryItem(*this); +} Svx3DNormalsKindItem::Svx3DNormalsKindItem(sal_uInt16 nVal) : SfxUInt16Item(SDRATTR_3DOBJ_NORMALS_KIND, nVal) @@ -191,6 +194,10 @@ SfxPoolItem* Svx3DSmoothNormalsItem::Create(SvStream rIn, sal_uInt16 nItemVersi return pRetval; } +SfxPoolItem * Svx3DSmoothNormalsItem::Clone(SfxItemPool *) const +{ +return new Svx3DSmoothNormalsItem(*this); +} // #107245# @@ -216,6 +223,10 @@ SfxPoolItem* Svx3DSmoothLidsItem::Create(SvStream rIn, sal_uInt16 nItemVersion) return pRetval; } +SfxPoolItem * Svx3DSmoothLidsItem::Clone(SfxItemPool *) const +{ +return new Svx3DSmoothLidsItem(*this); +} // #107245# @@ -241,6 +252,10 @@ SfxPoolItem* Svx3DCharacterModeItem::Create(SvStream rIn, sal_uInt16 nItemVersi return pRetval; } +SfxPoolItem * Svx3DCharacterModeItem::Clone(SfxItemPool *) const +{ +return new Svx3DCharacterModeItem(*this); +} // #107245# @@ -266,6 +281,10 @@ SfxPoolItem* Svx3DCloseFrontItem::Create(SvStream rIn, sal_uInt16 nItemVersion) return pRetval; } +SfxPoolItem * Svx3DCloseFrontItem::Clone(SfxItemPool *) const +{ +return new Svx3DCloseFrontItem(*this); +} // #107245# @@ -291,7 +310,10 @@ SfxPoolItem* Svx3DCloseBackItem::Create(SvStream rIn, sal_uInt16 nItemVersion) return pRetval; } - +SfxPoolItem * Svx3DCloseBackItem::Clone(SfxItemPool *) const +{ +return new Svx3DCloseBackItem(*this); +} // Svx3DNormalsKindItem: use drawing::NormalsKind bool Svx3DNormalsKindItem::QueryValue( uno::Any rVal, sal_uInt8 /*nMemberId*/) const ___
[Libreoffice-commits] core.git: chart2/source include/svx svx/source
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx | 34 ++-- include/svx/obj3d.hxx|6 include/svx/scene3d.hxx | 18 +- include/svx/svx3ditems.hxx | 82 --- svx/source/customshapes/EnhancedCustomShape3d.cxx| 10 - svx/source/dialog/dlgctl3d.cxx | 16 +- svx/source/engine3d/float3d.cxx | 60 svx/source/engine3d/svx3ditems.cxx | 48 -- svx/source/sdr/primitive2d/sdrattributecreator.cxx | 18 +- svx/source/sdr/primitive3d/sdrattributecreator3d.cxx |4 svx/source/svdraw/svdattr.cxx| 24 +-- 11 files changed, 128 insertions(+), 192 deletions(-) New commits: commit e5d6ae0c2efcf8edb224faa294be6b0baa636137 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 16:16:49 2014 +0200 Consistency around SvxColorItem in svx/svx3ditems.hxx ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 Consistency around SdrMetricItem. Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930 diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx index 76294c5..d3c3986 100644 --- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx +++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx @@ -349,42 +349,42 @@ IMPL_LINK_NOARG(ThreeD_SceneIllumination_TabPage, PreviewChangeHdl) const SfxItemSet a3DLightAttributes(m_pCtl_Preview-GetSvx3DLightControl().Get3DAttributes()); LightSourceInfo* pInfo = m_pLightSourceInfoList[0]; -pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_1)).GetValue().GetColor(); +pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_1)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_1)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_1)).GetValue()); pInfo = m_pLightSourceInfoList[1]; -pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_2)).GetValue().GetColor(); +pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_2)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_2)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_2)).GetValue()); pInfo = m_pLightSourceInfoList[2]; -pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_3)).GetValue().GetColor(); +pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_3)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_3)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_3)).GetValue()); pInfo = m_pLightSourceInfoList[3]; -pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_4)).GetValue().GetColor(); +pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_4)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_4)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_4)).GetValue()); pInfo = m_pLightSourceInfoList[4]; -pInfo-aLightSource.nDiffuseColor = ((const Svx3DLightcolor5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_5)).GetValue().GetColor(); +pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_5)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_5)).GetValue(); pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_5)).GetValue()); pInfo = m_pLightSourceInfoList[5]; -pInfo-aLightSource.nDiffuseColor = ((const
[Libreoffice-commits] core.git: chart2/source include/svx svx/source
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx | 32 +++--- include/svx/scene3d.hxx | 16 +-- include/svx/svx3ditems.hxx | 56 --- svx/source/customshapes/EnhancedCustomShape3d.cxx|6 - svx/source/dialog/dlgctl3d.cxx | 32 +++--- svx/source/engine3d/svx3ditems.cxx | 32 -- svx/source/sdr/primitive2d/sdrattributecreator.cxx | 16 +-- svx/source/svdraw/svdattr.cxx| 16 +-- 8 files changed, 83 insertions(+), 123 deletions(-) New commits: commit 148aea32a34fe816c7f1870bfb4cf361a5e81bf0 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 16:46:59 2014 +0200 Consistency around SvxB3DVectorItem in svx/svx3ditems.hxx ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 Consistency around SdrMetricItem. Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55 diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx index d3c3986..27fb132 100644 --- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx +++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx @@ -351,42 +351,42 @@ IMPL_LINK_NOARG(ThreeD_SceneIllumination_TabPage, PreviewChangeHdl) pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_1)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_1)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection1Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_1)).GetValue()); +pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const SvxB3DVectorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_1)).GetValue()); pInfo = m_pLightSourceInfoList[1]; pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_2)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_2)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection2Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_2)).GetValue()); +pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const SvxB3DVectorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_2)).GetValue()); pInfo = m_pLightSourceInfoList[2]; pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_3)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_3)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection3Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_3)).GetValue()); +pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const SvxB3DVectorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_3)).GetValue()); pInfo = m_pLightSourceInfoList[3]; pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_4)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_4)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection4Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_4)).GetValue()); +pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const SvxB3DVectorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_4)).GetValue()); pInfo = m_pLightSourceInfoList[4]; pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_5)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_5)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const Svx3DLightDirection5Item)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_5)).GetValue()); +pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const SvxB3DVectorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTDIRECTION_5)).GetValue()); pInfo = m_pLightSourceInfoList[5]; pInfo-aLightSource.nDiffuseColor = ((const SvxColorItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTCOLOR_6)).GetValue().GetColor(); pInfo-aLightSource.bIsEnabled = ((const SfxBoolItem)a3DLightAttributes.Get(SDRATTR_3DSCENE_LIGHTON_6)).GetValue(); -pInfo-aLightSource.aDirection = B3DVectorToDirection3D(((const
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/reftokenhelper.cxx | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) New commits: commit 1a91abb451806bd93a08953c6a1afdb88995705e Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 1 17:09:30 2014 +0200 Avoid invalid premature downcasts Change-Id: Ifc6d84a63719b141ddc9bd89349d4a605d2b3e00 diff --git a/sc/source/core/tool/reftokenhelper.cxx b/sc/source/core/tool/reftokenhelper.cxx index 770f4dc..696f364 100644 --- a/sc/source/core/tool/reftokenhelper.cxx +++ b/sc/source/core/tool/reftokenhelper.cxx @@ -76,11 +76,11 @@ void ScRefTokenHelper::compileRangeRepresentation( break; } -const ScToken* pT = static_castconst ScToken*(p); -switch (pT-GetType()) +switch (p-GetType()) { case svSingleRef: { +const ScToken* pT = static_castconst ScToken*(p); const ScSingleRefData rRef = pT-GetSingleRef(); if (!rRef.Valid()) bFailure = true; @@ -90,6 +90,7 @@ void ScRefTokenHelper::compileRangeRepresentation( break; case svDoubleRef: { +const ScToken* pT = static_castconst ScToken*(p); const ScComplexRefData rRef = pT-GetDoubleRef(); if (!rRef.Valid()) bFailure = true; @@ -98,15 +99,21 @@ void ScRefTokenHelper::compileRangeRepresentation( } break; case svExternalSingleRef: -if (!pT-GetSingleRef().ValidExternal()) -bFailure = true; +{ +const ScToken* pT = static_castconst ScToken*(p); +if (!pT-GetSingleRef().ValidExternal()) +bFailure = true; +} break; case svExternalDoubleRef: -if (!pT-GetDoubleRef().ValidExternal()) -bFailure = true; +{ +const ScToken* pT = static_castconst ScToken*(p); +if (!pT-GetDoubleRef().ValidExternal()) +bFailure = true; +} break; case svString: -if (pT-GetString().isEmpty()) +if (p-GetString().isEmpty()) bFailure = true; break; default: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: 2 commits - scripts/update-stats.pl
scripts/update-stats.pl | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) New commits: commit acf040244d5a8fc488e1e8fb9dee1ce5ca8dc1b1 Author: Jan Holesovsky ke...@collabora.com Date: Mon Sep 1 19:27:05 2014 +0200 More versions (up to 4.2.6-secfix1 and 4.3.1). diff --git a/scripts/update-stats.pl b/scripts/update-stats.pl index 29c8118..45c8ede 100755 --- a/scripts/update-stats.pl +++ b/scripts/update-stats.pl @@ -86,6 +86,16 @@ my %versions = ( '882f8a0a489bc99a9e60c7905a60226254cb6ff0' = '4.2.3_RC3', # hotfix1 '63150712c6d317d27ce2db16eb94c2f3d7b699f8' = '4.2.4_RC2', + +'61cb170a04bb1f12e77c884eab9192be736ec5f5' = '4.2.5_RC2', +'6ff819b65674ae6c83f3cbab9e4a4c2b292a7a94' = '4.2.5_RC2', # hotfix1 + +'185f2ce4dcc34af9bd97dec29e6d42c39557298f' = '4.2.6_RC2', +'3fd416d4c6db7d3204c17ce57a1d70f6e531ee21' = '4.2.6_RC2', # secfix1 + +'62ad5818884a2fc2e5780dd45466868d41009ec0' = '4.3.0_RC4', + +'958349dc3b25111dbca392fbc281a05559ef6848' = '4.3.1_RC2', ); my %month_to_num = ( commit 7166dc5c1a0815aa761369d8ca961703f920218f Author: Jan Holesovsky ke...@collabora.com Date: Mon Sep 1 16:00:44 2014 +0200 Add new versions, kill by-hour breakdown. diff --git a/scripts/update-stats.pl b/scripts/update-stats.pl index 6124a13..29c8118 100755 --- a/scripts/update-stats.pl +++ b/scripts/update-stats.pl @@ -74,11 +74,18 @@ my %versions = ( '1c1366bba2ba2b554cd2ca4d87c06da81c05d24' = '4.1.5_RC3', +'40ff705089295be5be0aae9b15123f687c05b0a' = '4.1.6_RC2', + '05dceb5d363845f2cf968344d7adab8dcfb2ba71' = '4.2.0_RC4', 'd7dbbd7842e6a58b0f521599204e827654e1fb8b' = '4.2.1_RC1', '3be8cda0bddd8e430d8cda1ebfd581265cca5a0f' = '4.2.2_RC1', + +'6c3586f855673fa6a1576797f575b31ac6fa0ba3' = '4.2.3_RC3', +'882f8a0a489bc99a9e60c7905a60226254cb6ff0' = '4.2.3_RC3', # hotfix1 + +'63150712c6d317d27ce2db16eb94c2f3d7b699f8' = '4.2.4_RC2', ); my %month_to_num = ( @@ -101,7 +108,6 @@ my $try_geoip = 0; my %result_ips; my %result_versions; my %result_os; -my %result_hourly; my %result_daily; my %result_geoip; my %result_countries; @@ -140,11 +146,6 @@ while (LOG) { } ++$result_daily{$date}{'unique'}; - if ( !defined( $result_hourly{$time}{'unique'} ) ) { - $result_hourly{$time}{'unique'} = 0; - } - ++$result_hourly{$time}{'unique'}; - # geoip counts if ( $try_geoip ) { my $country = `geoiplookup '$ip'`; @@ -173,12 +174,6 @@ while (LOG) { $result_daily{$date}{$version} = 0; } ++$result_daily{$date}{$version}; - - # hourly reports per version - if ( !defined( $result_hourly{$time}{$version} ) ) { - $result_hourly{$time}{$version} = 0; - } - ++$result_hourly{$time}{$version}; } # just to keep the list of all osses we have @@ -219,24 +214,7 @@ foreach my $version ( sort( keys( %result_versions ) ) ) { print ,$all$percentage\n; } -print \nNew IP's asking for update per hour:\n\nTime,new unique IP's (never seen before); -foreach my $version ( sort( keys( %result_versions ) ) ) { -print ,$version; -} -print \n; my @print_versions = ( 'unique', sort( keys( %result_versions ) ) ); -foreach my $time ( sort( keys( %result_hourly ) ) ) { -print $time; -foreach my $version ( @print_versions ) { - my $count = $result_hourly{$time}{$version}; - if ( !defined( $count ) ) { - print ,; - } else { - print ,$count; - } -} -print \n; -} print \nNew IP's asking for update per day:\n\nTime,new unique IP's (never seen before); foreach my $version ( sort( keys( %result_versions ) ) ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'feature/calctiledrendering_attempt3_2'
New branch 'feature/calctiledrendering_attempt3_2' available with the following commits: commit f1da817eccc0e264ed52283b0c361ec71693e5c0 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Fri Aug 29 11:47:55 2014 +0200 TEMPORARY: more twips in ScOutputData. Some parts are working, some aren't. Change-Id: I69b63a585e971a4a56514a66ab318e48507ca5be commit e3b83296437d8ba23b53977563d4c7b7c7e82e34 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Fri Aug 29 10:36:26 2014 +0200 TEMPORARY: ViewData SetPosX/Y. Is this just unnecessary data duplication? (Would've been necessary with the old scaling I guess, but we don't have these inaccuracies any more?) Change-Id: I955345668d0d85a30e37316dd9a12f64d6bcbb03 commit ce6c10174151d52f50c45831785c2fef51b37995 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Fri Aug 29 10:31:40 2014 +0200 ViewData: further twips updates. Change-Id: I88b45057ce6feb121f14ecda65a23f2631349ef8 commit 8f4c131c215da020591f5ed2d083dcd8e0932cb3 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Fri Aug 29 10:23:40 2014 +0200 TEMPORARY: Use PaintMapMode scaling for DrawMapMode too. Otherwise we end up with invalid scalings once PPTX/Y doesn't exist. We can't use the DrawView yet as that gives us invalid scales for now (due to the PPTX/Y removal/disablement). Change-Id: I59279cb007bace1237384f58b345079d23aee92e commit e29f354a89f78b3ee9c997136276beafeb500d63 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Fri Aug 29 10:06:57 2014 +0200 Use Twips in DrawEditStandard too. This is used e.g. for cells which have been marked by the spellchecker. Change-Id: I8e0f85c1ff6f3104520b986eb89b03c6d457bf78 commit ac30c4a17803da346f3633723885243f17f79562 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:41:14 2014 +0200 Update DrawStrings to Twips. Change-Id: I8df207056e5aab198a2d81b5a4a7cc4d85aa07e6 commit 075f16d19a1324ec10b71034f9a13072c672fd6a Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:35:52 2014 +0200 Upgrade GetOutputArea to Twips too. Change-Id: Ie8f4f004fb73c1042616aaa475ab1d12c33f1181 commit 80f391814fb76c529a0de9431dbc1c54b6a2a08b Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:32:38 2014 +0200 TEMPORARY: don't predraw for calc. Since we don't have ViewData (yet), the scaling in OutputData is wrong, making this output ugly. This only seems to affect what appeasrs on screen directly after startup, and there appears to be no negative effect from this, so maybe we can jus tkill this pre-painting? Change-Id: Ie4178ed39263e07fa11a139b20811799b7253601 commit 3edb69a7ff5029785110b084fa409b684bf17415 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:23:09 2014 +0200 TEMPORARY: variable renamed, but usage not yet adapted. Change-Id: Ica80137ab67f7687db03cc0f6c0f7eb10d574a69 commit 09f61150e5ead84a0980caa17896d7666e27c704 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:22:15 2014 +0200 Logic coordinates for clip marks too. Change-Id: I214064a1c060af2078dc5cd3f1fb4990ea374f0b commit b9f4df427ef83f1b685d6d6e7fd64c700240aaa7 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 23:17:06 2014 +0200 Use Twips for OutputData as much as possible too. Change-Id: I4eaa1db83861d325beae2f5eea4b623331a56879 commit b8b0bc543f2de0ef66d9550ee75853bff1e919fa Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 22:46:03 2014 +0200 Only set outdev origin for tiled rendering. Change-Id: Iec3e438867a94ec3465474f7b830275373c72bd3 commit f4bf6baa0ba6f01e2aa28593cc61e9165a957d8c Author: Andrzej Hunt andrzej.h...@collabora.com Date: Thu Aug 28 22:42:56 2014 +0200 Use proper conversion for EditGrowX/Y too. Change-Id: I344a46d2f27f663dc446562534564c34f9ceaea1 commit d3a7e32f6787e3a12f45057623e722b527d849be Author: Andrzej Hunt andrzej.h...@collabora.com Date: Wed Aug 27 20:56:07 2014 +0200 Upgrade GetSelectionRects to logic coordinates too. Change-Id: I4fda7bb4fea5971654c0ecacbd67bc16bd3a68d9 commit e1c4eb03033a54e90579cef4baa6740e9e22569f Author: Andrzej Hunt andrzej.h...@collabora.com Date: Wed Aug 27 20:52:36 2014 +0200 Ensure we use the correct rectangle size for tiled rendering. Change-Id: I0a4b3bf9c8263365d04ed4319a0c551c363120cd commit 043a523ed9b1575885178a9b76e6ba913087b773 Author: Andrzej Hunt andrzej.h...@collabora.com Date: Wed Aug 27 20:52:09 2014 +0200 Match TiledRendering scaling to the new ViewData PaintMapMode. This is a bit hacky, still need to figure out what's going wrong that we need this weird conversion. Change-Id: Id1c62401f9f85c6d436bdd73b51ccf126100cbc4 commit 74f35e1f7aca1ffa003e78827f4a9acd665f38b8 Author:
Interest in contributing to the open source
Hello My name is Djimeli Konrad and i am primarily a c/c++ programmer interested in contributing to the open source through libreoffice. Since this is my first time i wish i could get some pointers on how to begin. Thanks konrad ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Interest in contributing to the open source
Welcome Make sure you read this page first: https://wiki.documentfoundation.org/Development On 01-09-2014 16:35, Djimeli Konrad wrote: Hello My name is Djimeli Konrad and i am primarily a c/c++ programmer interested in contributing to the open source through libreoffice. Since this is my first time i wish i could get some pointers on how to begin. Thanks konrad ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Olivier Hallot Comunidade LibreOffice http://ask.libreoffice.org/pt-br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - 2 commits - vcl/inc vcl/Library_vclopengl.mk vcl/osx
vcl/Library_vclopengl.mk |9 ++--- vcl/inc/OpenGLWrapper.hxx |2 -- vcl/osx/OpenGLWrapper.cxx |4 3 files changed, 6 insertions(+), 9 deletions(-) New commits: commit 8a103607586211dfacb2d815f2a7bf8f2e41d8a4 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Sep 1 22:14:59 2014 +0200 remove unused method Change-Id: I17d3e3fa4671d0004e2d7918ea3bcad1a7bcd2b5 diff --git a/vcl/inc/OpenGLWrapper.hxx b/vcl/inc/OpenGLWrapper.hxx index 6911c33..0b90b41 100644 --- a/vcl/inc/OpenGLWrapper.hxx +++ b/vcl/inc/OpenGLWrapper.hxx @@ -23,8 +23,6 @@ public: static void swapBuffers(NSOpenGLView* pView); static void makeCurrent(NSOpenGLView* pView); static void resetCurrent(); - -static void init(NSOpenGLView* pView); }; /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/osx/OpenGLWrapper.cxx b/vcl/osx/OpenGLWrapper.cxx index dc9ad7a..fc008f4 100644 --- a/vcl/osx/OpenGLWrapper.cxx +++ b/vcl/osx/OpenGLWrapper.cxx @@ -24,8 +24,4 @@ void OpenGLWrapper::resetCurrent() [NSOpenGLContext clearCurrentContext]; } -void OpenGLWrapper::init(NSOpenGLView* pView) -{ -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit f0226bfa04321e6fcdc4646e7e0c859a7cb22ee1 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Sep 1 22:14:07 2014 +0200 fix non Mac build Change-Id: I88df76fc1757b8372cd319ae1ecd7976b01554a1 diff --git a/vcl/Library_vclopengl.mk b/vcl/Library_vclopengl.mk index e5fbbfe..e61dd8a 100644 --- a/vcl/Library_vclopengl.mk +++ b/vcl/Library_vclopengl.mk @@ -38,6 +38,12 @@ $(eval $(call gb_Library_use_libraries,vclopengl,\ $(gb_UWINAPI) \ )) +$(eval $(call gb_Library_add_exception_objects,vclopengl,\ +vcl/source/opengl/OpenGLContext \ +vcl/source/opengl/OpenGLHelper \ +vcl/source/window/openglwin \ +)) + ifeq ($(OS),MACOSX) $(eval $(call gb_Library_add_cxxflags,vclopengl,\ @@ -53,9 +59,6 @@ $(eval $(call gb_Library_add_libs,vcl,\ $(eval $(call gb_Library_add_exception_objects,vclopengl,\ vcl/osx/OpenGLWrapper \ -vcl/source/opengl/OpenGLContext \ -vcl/source/opengl/OpenGLHelper \ -vcl/source/window/openglwin \ )) endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/oox oox/source
include/oox/export/chartexport.hxx |2 +- oox/source/export/chartexport.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit fba7b58a9ddaa829892bf3a3e8f3dd6970664f78 Author: Thomas Viehmann t...@beamnet.de Date: Mon Sep 1 22:32:26 2014 +0200 fix typo Sufface-Surface Change-Id: I90847d0edbc2c13e405562647b150012bc5df7e2 Reviewed-on: https://gerrit.libreoffice.org/11249 Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/include/oox/export/chartexport.hxx b/include/oox/export/chartexport.hxx index 2fd383b..ed8743c 100644 --- a/include/oox/export/chartexport.hxx +++ b/include/oox/export/chartexport.hxx @@ -138,7 +138,7 @@ private: void exportRadarChart( com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); void exportScatterChart( com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); void exportStockChart( com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); -void exportSuffaceChart( com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); +void exportSurfaceChart( com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); void exportHiLowLines(); void exportUpDownBars(com::sun::star::uno::Reference com::sun::star::chart2::XChartType xChartType ); diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index 27b9385..d074fe2 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -1116,7 +1116,7 @@ void ChartExport::exportPlotArea( ) } case chart::TYPEID_SURFACE: { -exportSuffaceChart( xChartType ); +exportSurfaceChart( xChartType ); break; } default: @@ -1612,7 +1612,7 @@ void ChartExport::exportUpDownBars( Reference chart2::XChartType xChartType) } } -void ChartExport::exportSuffaceChart( Reference chart2::XChartType xChartType ) +void ChartExport::exportSurfaceChart( Reference chart2::XChartType xChartType ) { FSHelperPtr pFS = GetFS(); sal_Int32 nTypeId = XML_surfaceChart; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - include/oox sd/source
include/oox/export/chartexport.hxx|2 +- include/oox/export/shapes.hxx |2 +- sd/source/ui/remotecontrol/mDNSResponder/dns_sd.h | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 4dbd58abb495f3e3dd008489f84f8380207127f3 Author: Thomas Arnhold tho...@arnhold.org Date: Mon Sep 1 23:06:54 2014 +0200 Partially revert: fixincludeguards.sh: sd Doesn't look this sane... commit 3b58ababc566adef48d8ab600489e554c4585b1d Author: Thomas Arnhold tho...@arnhold.org Date: Wed Oct 23 22:38:46 2013 +0200 fixincludeguards.sh: sd Change-Id: Ia6836deaa1982febf71cd8abd89e93ea0a844721 diff --git a/sd/source/ui/remotecontrol/mDNSResponder/dns_sd.h b/sd/source/ui/remotecontrol/mDNSResponder/dns_sd.h old mode 100644 new mode 100755 index ec1f43a..92342be --- a/sd/source/ui/remotecontrol/mDNSResponder/dns_sd.h +++ b/sd/source/ui/remotecontrol/mDNSResponder/dns_sd.h @@ -55,14 +55,14 @@ */ -/* INCLUDED_SD_SOURCE_UI_REMOTECONTROL_MDNSRESPONDER_DNS_SD_H contains the mDNSResponder version number for this header file, formatted as follows: +/* _DNS_SD_H contains the mDNSResponder version number for this header file, formatted as follows: * Major part of the build number * 1 + * minor part of the build number * 100 * For example, Mac OS X 10.4.9 has mDNSResponder-108.4, which would be represented as * version 1080400. This allows C code to do simple greater-than and less-than comparisons: * e.g. an application that requires the DNSServiceGetProperty() call (new in mDNSResponder-126) can check: * - * #if INCLUDED_SD_SOURCE_UI_REMOTECONTROL_MDNSRESPONDER_DNS_SD_H+0 = 126 + * #if _DNS_SD_H+0 = 126 * ... some C code that calls DNSServiceGetProperty() ... * #endif * @@ -76,8 +76,8 @@ * (system service on Windows) meets some required minimum functionality level. */ -#ifndef INCLUDED_SD_SOURCE_UI_REMOTECONTROL_MDNSRESPONDER_DNS_SD_H -#define INCLUDED_SD_SOURCE_UI_REMOTECONTROL_MDNSRESPONDER_DNS_SD_H 3793700 +#ifndef _DNS_SD_H +#define _DNS_SD_H 3793700 #ifdef __cplusplus extern C { @@ -2486,4 +2486,4 @@ struct CompileTimeAssertionChecks_DNS_SD } #endif -#endif // INCLUDED_SD_SOURCE_UI_REMOTECONTROL_MDNSRESPONDER_DNS_SD_H +#endif /* _DNS_SD_H */ commit 368374a67b972f6ff7d4a4441544318efb18edfd Author: Thomas Arnhold tho...@arnhold.org Date: Mon Sep 1 23:03:30 2014 +0200 correct include guard comment Change-Id: Ie94573f7c43c834cd636493bed32f07aa792da49 diff --git a/include/oox/export/chartexport.hxx b/include/oox/export/chartexport.hxx index ed8743c..8f86aa9 100644 --- a/include/oox/export/chartexport.hxx +++ b/include/oox/export/chartexport.hxx @@ -200,6 +200,6 @@ public: }} -#endif /* ndef INCLUDED_OOX_EXPORT_CHARTEXPORT_HXX */ +#endif // INCLUDED_OOX_EXPORT_CHARTEXPORT_HXX /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/include/oox/export/shapes.hxx b/include/oox/export/shapes.hxx index 925ba72..995ef35 100644 --- a/include/oox/export/shapes.hxx +++ b/include/oox/export/shapes.hxx @@ -168,6 +168,6 @@ public: }} -#endif /* ndef INCLUDED_OOX_EXPORT_SHAPES_HXX */ +#endif // INCLUDED_OOX_EXPORT_SHAPES_HXX /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - vcl/source
vcl/source/opengl/OpenGLContext.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit e2f11ea93e67f156dcd3c1284bbda0056b8c4ebf Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Sep 1 23:10:54 2014 +0200 fix non OSX build again Change-Id: I3faccc9f70b1afb7cbefd5ba9b26612eb7cda1fd diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index b908f05..d7ea0ee 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -17,9 +17,11 @@ #include vcl/bmpacc.hxx #include vcl/graph.hxx +#if defined(MACOSX) #include premac.h #include OpenGLWrapper.hxx #include postmac.h +#endif using namespace com::sun::star; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - 2 commits - include/vcl vcl/osx vcl/source
include/vcl/opengl/OpenGLContext.hxx |2 - include/vcl/sysdata.hxx |1 vcl/osx/salobj.cxx | 41 +++ vcl/source/opengl/OpenGLContext.cxx | 12 +- 4 files changed, 41 insertions(+), 15 deletions(-) New commits: commit 2a1804e9dd04a66b4686b22c9befbb64381c5f1d Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Sep 2 00:00:11 2014 +0200 fix indentation Change-Id: I4f299e510fecb57f763818743d357ae6bf2333af diff --git a/vcl/osx/salobj.cxx b/vcl/osx/salobj.cxx index 816eaf1..8cccd1b 100644 --- a/vcl/osx/salobj.cxx +++ b/vcl/osx/salobj.cxx @@ -87,7 +87,8 @@ AquaSalObject::AquaSalObject( AquaSalFrame* pFrame, SystemWindowData* pWindowDat { maSysData.mpNSView = [[NSView alloc] initWithFrame: aInitFrame]; } -if( maSysData.mpNSView ) + +if( maSysData.mpNSView ) { if( mpClipView ) [mpClipView setDocumentView: maSysData.mpNSView]; commit 49c40d4ec5b7e13370ff33b0d94f9c35fc500de3 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Sep 1 23:59:24 2014 +0200 support legacy and core context on OSX Change-Id: Ib8cadb3f182ce49c0ca8b6ccaa95960eb8e5f9ae diff --git a/include/vcl/opengl/OpenGLContext.hxx b/include/vcl/opengl/OpenGLContext.hxx index 7ce6763..79f97fc 100644 --- a/include/vcl/opengl/OpenGLContext.hxx +++ b/include/vcl/opengl/OpenGLContext.hxx @@ -181,7 +181,7 @@ public: bool supportMultiSampling() const; -static SystemWindowData generateWinData(Window* pParent); +static SystemWindowData generateWinData(Window* pParent, bool bRequestLegacyContext); private: SAL_DLLPRIVATE bool initWindow(); diff --git a/include/vcl/sysdata.hxx b/include/vcl/sysdata.hxx index 8ac816a..4cfc737 100644 --- a/include/vcl/sysdata.hxx +++ b/include/vcl/sysdata.hxx @@ -178,6 +178,7 @@ struct SystemWindowData #if defined( WNT ) // meaningless on Windows #elif defined( MACOSX ) boolbOpenGL;// create a OpenGL providing NSView +boolbLegacy;// create a 2.1 legacy context, only valid if bOpenGL == true // Nothing #elif defined( ANDROID ) // Nothing diff --git a/vcl/osx/salobj.cxx b/vcl/osx/salobj.cxx index 7c7ad5d..816eaf1 100644 --- a/vcl/osx/salobj.cxx +++ b/vcl/osx/salobj.cxx @@ -49,17 +49,39 @@ AquaSalObject::AquaSalObject( AquaSalFrame* pFrame, SystemWindowData* pWindowDat } if (pWindowData-bOpenGL) { -NSOpenGLPixelFormatAttribute aAttributes[] = +NSOpenGLPixelFormat* pixFormat = NULL; + +if (pWindowData-bLegacy) +{ +NSOpenGLPixelFormatAttribute aAttributes[] = +{ +NSOpenGLPFADoubleBuffer, +NSOpenGLPFAAlphaSize, 8, +NSOpenGLPFAColorSize, 24, +NSOpenGLPFAMultisample, +NSOpenGLPFASampleBuffers, (NSOpenGLPixelFormatAttribute)1, +NSOpenGLPFASamples, (NSOpenGLPixelFormatAttribute)4, +0 +}; +pixFormat = [[NSOpenGLPixelFormat alloc] initWithAttributes:aAttributes]; +} +else { -NSOpenGLPFADoubleBuffer, -NSOpenGLPFAAlphaSize, 8, -NSOpenGLPFAColorSize, 24, -0 -}; +NSOpenGLPixelFormatAttribute aAttributes[] = +{ +NSOpenGLPFAOpenGLProfile, NSOpenGLProfileVersion3_2Core, +NSOpenGLPFADoubleBuffer, +NSOpenGLPFAAlphaSize, 8, +NSOpenGLPFAColorSize, 24, +NSOpenGLPFAMultisample, +NSOpenGLPFASampleBuffers, (NSOpenGLPixelFormatAttribute)1, +NSOpenGLPFASamples, (NSOpenGLPixelFormatAttribute)4, +0 +}; +pixFormat = [[NSOpenGLPixelFormat alloc] initWithAttributes:aAttributes]; +} -NSOpenGLPixelFormat* pixFormat = [[NSOpenGLPixelFormat alloc] initWithAttributes:aAttributes]; maSysData.mpNSView = [[NSOpenGLView alloc] initWithFrame: aInitFrame pixelFormat:pixFormat]; - } else { diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index d7ea0ee..18e0a02 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -615,7 +615,7 @@ bool OpenGLContext::initWindow() { if( !m_pChildWindow ) { -SystemWindowData winData = generateWinData(mpWindow); +SystemWindowData winData = generateWinData(mpWindow, false); m_pChildWindow = new SystemChildWindow(mpWindow, 0, winData, false); m_pChildWindowGC.reset(m_pChildWindow); } @@ -642,7 +642,7 @@ bool OpenGLContext::initWindow() { if( !m_pChildWindow ) { -SystemWindowData winData = generateWinData(mpWindow); +SystemWindowData winData = generateWinData(mpWindow, mbRequestLegacyContext);
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - avmedia/source slideshow/source
avmedia/source/viewer/mediawindow_impl.cxx|2 +- slideshow/source/engine/shapes/viewmediashape.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit d5186c15d2faed2b446871a0866de3b85c706375 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Tue Sep 2 00:20:37 2014 +0200 fix build Change-Id: I13c67763ec3cb940292199f3e9e0f3942446959f diff --git a/avmedia/source/viewer/mediawindow_impl.cxx b/avmedia/source/viewer/mediawindow_impl.cxx index b608b85..f4c8856 100644 --- a/avmedia/source/viewer/mediawindow_impl.cxx +++ b/avmedia/source/viewer/mediawindow_impl.cxx @@ -515,7 +515,7 @@ void MediaWindowImpl::onURLChanged() #if HAVE_FEATURE_GLTF else if ( m_sMimeType == AVMEDIA_MIMETYPE_JSON ) { -SystemWindowData aWinData = OpenGLContext::generateWinData(this); +SystemWindowData aWinData = OpenGLContext::generateWinData(this, false); mpChildWindow.reset(new MediaChildWindow(this,aWinData)); mbEventTransparent = false; } diff --git a/slideshow/source/engine/shapes/viewmediashape.cxx b/slideshow/source/engine/shapes/viewmediashape.cxx index 9ebc014..fd3c507 100644 --- a/slideshow/source/engine/shapes/viewmediashape.cxx +++ b/slideshow/source/engine/shapes/viewmediashape.cxx @@ -477,7 +477,7 @@ namespace slideshow Size( aAWTRect.Width, aAWTRect.Height ) ); mpEventHandlerParent-EnablePaint(false); mpEventHandlerParent-Show(); -SystemWindowData aWinData = OpenGLContext::generateWinData(mpEventHandlerParent.get()); +SystemWindowData aWinData = OpenGLContext::generateWinData(mpEventHandlerParent.get(), false); mpMediaWindow.reset(new SystemChildWindow(mpEventHandlerParent.get(), 0, aWinData)); mpMediaWindow-SetPosSizePixel( Point( 0, 0 ), Size( aAWTRect.Width, aAWTRect.Height ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - 2 commits - vcl/osx vcl/source
vcl/osx/salobj.cxx |2 +- vcl/source/window/openglwin.cxx |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit e010352a3d3f36ba2318c86fc9e389a32749e26f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Sep 2 01:02:49 2014 +0200 prevent potential crash if no SystemWindowData is passed Change-Id: I89f9a2d0993084abe9065b1c44ea5d97b5b7a7cc diff --git a/vcl/osx/salobj.cxx b/vcl/osx/salobj.cxx index 8cccd1b..7932f8a 100644 --- a/vcl/osx/salobj.cxx +++ b/vcl/osx/salobj.cxx @@ -47,7 +47,7 @@ AquaSalObject::AquaSalObject( AquaSalFrame* pFrame, SystemWindowData* pWindowDat [mpFrame-getNSView() addSubview: mpClipView]; [mpClipView setHidden: YES]; } -if (pWindowData-bOpenGL) +if (pWindowData pWindowData-bOpenGL) { NSOpenGLPixelFormat* pixFormat = NULL; commit 01fe3faf09eed012f5db88f341c8d8195726eb22 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Sep 2 01:01:37 2014 +0200 fix crash when creating chart Change-Id: Ie6e38a0461a10cc33ff3d85cbf3b35ffab0efd59 diff --git a/vcl/source/window/openglwin.cxx b/vcl/source/window/openglwin.cxx index cfe6e6a..1151a4d 100644 --- a/vcl/source/window/openglwin.cxx +++ b/vcl/source/window/openglwin.cxx @@ -10,6 +10,7 @@ #include vcl/openglwin.hxx #include vcl/opengl/OpenGLContext.hxx #include vcl/event.hxx +#include vcl/sysdata.hxx class OpenGLWindowImpl { @@ -21,9 +22,10 @@ private: boost::scoped_ptrSystemChildWindow mpChildWindow; }; -OpenGLWindowImpl::OpenGLWindowImpl(Window* pWindow): -mpChildWindow(new SystemChildWindow(pWindow)) +OpenGLWindowImpl::OpenGLWindowImpl(Window* pWindow) { +SystemWindowData aData = OpenGLContext::generateWinData(pWindow, false); +mpChildWindow.reset(new SystemChildWindow(pWindow, 0, aData)); mpChildWindow-Show(); maContext.init(mpChildWindow.get()); pWindow-SetMouseTransparent(false); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/mac-opengl-fixes' - canvas/source chart2/source
canvas/source/factory/cf_service.cxx| 20 canvas/source/opengl/ogl_spritedevicehelper.cxx |1 - chart2/source/view/main/GL3DRenderer.cxx| 11 --- 3 files changed, 32 deletions(-) New commits: commit 7eb4239e3e5fbcdd8002a2d57275ac4916464daf Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Sep 2 01:05:33 2014 +0200 remove SAL_DEBUGs introduced earlier Change-Id: I901188b5b0a3e64e2407d039dd80f89cce8cf6de diff --git a/canvas/source/factory/cf_service.cxx b/canvas/source/factory/cf_service.cxx index 07ee8b7..014b82d 100644 --- a/canvas/source/factory/cf_service.cxx +++ b/canvas/source/factory/cf_service.cxx @@ -168,12 +168,6 @@ CanvasFactory::CanvasFactory( ReferenceXComponentContext const xContext ) : Referencecontainer::XHierarchicalNameAccess xHierarchicalNameAccess( xNameAccess, UNO_QUERY_THROW); -SequenceOUString serviceNames = xNameAccess-getElementNames(); -for (sal_Int32 i = 0; i serviceNames.getLength(); ++i) -{ -SAL_DEBUG(serviceNames[i]); -} - const OUString* pCurr = serviceNames.getConstArray(); const OUString* const pEnd = pCurr + serviceNames.getLength(); while( pCurr != pEnd ) @@ -188,25 +182,13 @@ CanvasFactory::CanvasFactory( ReferenceXComponentContext const xContext ) : if( (xEntryNameAccess-getByName(PreferredImplementations) = implementationList) ) { m_aAvailableImplementations.push_back( std::make_pair(*pCurr,implementationList) ); -for (sal_Int32 i = 0; i implementationList.getLength(); ++i) -{ -SAL_DEBUG(available : implementationList[i]); -} } if( (xEntryNameAccess-getByName(AcceleratedImplementations) = implementationList) ) { -for (sal_Int32 i = 0; i implementationList.getLength(); ++i) -{ -SAL_DEBUG(accelerated: implementationList[i]); -} m_aAcceleratedImplementations.push_back( std::make_pair(*pCurr,implementationList) ); } if( (xEntryNameAccess-getByName(AntialiasingImplementations) = implementationList) ) { -for (sal_Int32 i = 0; i implementationList.getLength(); ++i) -{ -SAL_DEBUG(aa implemented: implementationList[i]); -} m_aAAImplementations.push_back( std::make_pair(*pCurr,implementationList) ); } @@ -294,7 +276,6 @@ ReferenceXInterface CanvasFactory::use( ReferenceXComponentContext const xContext ) const { try { -SAL_DEBUG(use: serviceName); return m_xContext-getServiceManager()-createInstanceWithArgumentsAndContext( serviceName, args, xContext); } @@ -337,7 +318,6 @@ ReferenceXInterface CanvasFactory::lookupAndUse( ReferenceXComponentContext const xContext ) const { ::osl::MutexGuard guard(m_mutex); -SAL_DEBUG(serviceName); // forcing last entry from impl list, if config flag set bool bForceLastEntry(false); diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx b/canvas/source/opengl/ogl_spritedevicehelper.cxx index 2e4b592..58a59ea 100644 --- a/canvas/source/opengl/ogl_spritedevicehelper.cxx +++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx @@ -389,7 +389,6 @@ namespace oglcanvas uno::Referencerendering::XColorSpace SpriteDeviceHelper::getColorSpace() const { -SAL_DEBUG(called SpriteDeviceHelper::getColorSpace()); // always the same return uno::Referencerendering::XColorSpace( ::canvas::tools::getStdColorSpace(), diff --git a/chart2/source/view/main/GL3DRenderer.cxx b/chart2/source/view/main/GL3DRenderer.cxx index 999b9df..cde4356 100644 --- a/chart2/source/view/main/GL3DRenderer.cxx +++ b/chart2/source/view/main/GL3DRenderer.cxx @@ -218,9 +218,7 @@ void OpenGL3DRenderer::ShaderResources::LoadShaders() m_3DModelID = glGetUniformLocation(m_3DProID, M); m_3DNormalMatrixID = glGetUniformLocation(m_3DProID, normalMatrix); m_3DVertexID = glGetAttribLocation(m_3DProID, vertexPositionModelspace); -SAL_DEBUG(first m_3DVertexID); m_3DNormalID = glGetAttribLocation(m_3DProID, vertexNormalModelspace); -SAL_DEBUG(second m_3DNormalID); CHECK_GL_ERROR(); if (m_bScrollFlag) { @@ -289,30 +287,22 @@ void OpenGL3DRenderer::ShaderResources::LoadShaders() m_TextProID = OpenGLHelper::LoadShaders(textVertexShader, textFragmentShader); m_TextMatrixID = glGetUniformLocation(m_TextProID, MVP); m_TextVertexID = glGetAttribLocation(m_TextProID, vPosition); -
[Libreoffice-commits] core.git: 52 commits - avmedia/source canvas/opengl canvas/source chart2/opengl chart2/source include/vcl slideshow/Library_OGLTrans.mk slideshow/source vcl/inc vcl/Library_vclop
avmedia/source/viewer/mediawindow_impl.cxx |2 canvas/opengl/linearMultiColorGradientFragmentShader.glsl | 13 canvas/opengl/radialMultiColorGradientFragmentShader.glsl | 13 canvas/opengl/rectangularMultiColorGradientFragmentShader.glsl | 15 canvas/opengl/rectangularTwoColorGradientFragmentShader.glsl |4 canvas/source/factory/cf_service.cxx |7 canvas/source/opengl/ogl_canvashelper.cxx |5 canvas/source/opengl/ogl_spritedevicehelper.cxx| 13 canvas/source/tools/canvastools.cxx|1 chart2/opengl/README.deprecated| 23 chart2/opengl/backgroundFragmentShader.glsl|4 chart2/opengl/backgroundVertexShader.glsl |8 chart2/opengl/commonFragmentShader.glsl|7 chart2/opengl/commonVertexShader.glsl |6 chart2/opengl/debugFragmentShader.glsl |4 chart2/opengl/debugVertexShader.glsl |6 chart2/opengl/pickingFragmentShader.glsl | 10 chart2/opengl/pickingVertexShader.glsl |8 chart2/opengl/renderTextureFragmentShader.glsl |7 chart2/opengl/renderTextureVertexShader.glsl |8 chart2/opengl/screenTextFragmentShader.glsl| 10 chart2/opengl/screenTextVertexShader.glsl |8 chart2/opengl/shape3DFragmentShader.glsl |1 chart2/opengl/shape3DFragmentShaderBatch.glsl |1 chart2/opengl/shape3DFragmentShaderBatchScroll.glsl|1 chart2/opengl/shape3DFragmentShaderV300.glsl |7 chart2/opengl/shape3DVertexShader.glsl |2 chart2/opengl/shape3DVertexShaderBatch.glsl|2 chart2/opengl/shape3DVertexShaderBatchScroll.glsl |2 chart2/opengl/shape3DVertexShaderV300.glsl | 11 chart2/opengl/symbolFragmentShader.glsl|4 chart2/opengl/symbolVertexShader.glsl |6 chart2/opengl/textFragmentShader.glsl | 11 chart2/opengl/textFragmentShaderBatch.glsl |3 chart2/opengl/textVertexShader.glsl|8 chart2/opengl/textVertexShaderBatch.glsl |1 chart2/source/view/charttypes/GL3DBarChart.cxx |3 chart2/source/view/main/GL3DRenderer.cxx | 115 chart2/source/view/main/OpenGLRender.cxx | 25 include/vcl/opengl/OpenGLContext.hxx | 14 include/vcl/opengl/OpenGLHelper.hxx|4 include/vcl/sysdata.hxx|6 slideshow/Library_OGLTrans.mk | 13 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx | 593 ++-- slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.hxx | 75 slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx | 46 slideshow/source/engine/OGLTrans/mac/OGLTrans_Shaders.h| 96 slideshow/source/engine/OGLTrans/mac/OGLTrans_Shaders.m| 233 - slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.hxx | 501 --- slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionImpl.mm| 1316 -- slideshow/source/engine/OGLTrans/mac/OGLTrans_TransitionerImpl.mm | 1074 slideshow/source/engine/OGLTrans/mac/aquaOpenGLView.h | 48 slideshow/source/engine/OGLTrans/mac/aquaOpenGLView.m | 195 - slideshow/source/engine/shapes/viewmediashape.cxx |2 vcl/Library_vclopengl.mk | 23 vcl/inc/OpenGLWrapper.hxx | 28 vcl/inc/osx/salobj.h |2 vcl/osx/OpenGLWrapper.cxx | 27 vcl/osx/salinst.cxx|5 vcl/osx/salobj.cxx | 46 vcl/source/opengl/OpenGLContext.cxx| 70 vcl/source/opengl/OpenGLHelper.cxx | 22
[Libreoffice-commits] core.git: slideshow/source
slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |8 1 file changed, 8 insertions(+) New commits: commit 8e4defe4b59a72fbe82f94b26e233ba36640c739 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Sep 2 02:19:14 2014 +0200 fix Wunused-private-field Change-Id: Ia708cc3cccd86257e08aa916d24733ca6769e723 diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx index bb0e979..8faa728 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx @@ -253,11 +253,15 @@ private: GLXPixmap maLeavingPixmapGL; GLXPixmap maEnteringPixmapGL; #endif +#if defined( UNX ) !defined( MACOSX ) bool mbRestoreSync; +#endif bool mbUseLeavingPixmap; bool mbUseEnteringPixmap; +#if defined( GLX_EXT_texture_from_pixmap ) bool mbFreeLeavingPixmap; bool mbFreeEnteringPixmap; +#endif #if defined( UNX ) !defined( MACOSX ) Pixmap maLeavingPixmap; Pixmap maEnteringPixmap; @@ -1354,11 +1358,15 @@ OGLTransitionerImpl::OGLTransitionerImpl() , maLeavingPixmapGL(0) , maEnteringPixmapGL(0) #endif +#if defined( UNX ) !defined( MACOSX ) , mbRestoreSync(false) +#endif , mbUseLeavingPixmap(false) , mbUseEnteringPixmap(false) +#if defined( GLX_EXT_texture_from_pixmap ) , mbFreeLeavingPixmap(false) , mbFreeEnteringPixmap(false) +#endif #if defined( UNX ) !defined( MACOSX ) , maLeavingPixmap(0) , maEnteringPixmap(0) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - writerfilter/source
writerfilter/source/ooxml/model.xml | 47 ++-- 1 file changed, 24 insertions(+), 23 deletions(-) New commits: commit 03276df2ae74d94939b03503074be6192aa4c791 Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Sep 2 07:36:29 2014 +0200 Remove unused xmlns:fn namespace aliases Change-Id: I634fdfd2b206fbb91e8032fe2fbf4ec66c8623a2 diff --git a/writerfilter/source/ooxml/model.xml b/writerfilter/source/ooxml/model.xml index 3c21745..6bb83d0 100644 --- a/writerfilter/source/ooxml/model.xml +++ b/writerfilter/source/ooxml/model.xml @@ -54,7 +54,7 @@ start name=themeOverride/ start name=themeManager/ start name=hlinkClick/ -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- ISO RELAX NG Schema -- include href=dml-baseStylesheet.rng/ !-- start = theme | themeOverride | themeManager | hlinkClick -- @@ -231,7 +231,7 @@ /grammar /namespace namespace name=dml-shape3DLighting file=dml-shape3DLighting.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; define name=ST_LightRigDirection choice !-- Top Left -- @@ -381,7 +381,7 @@ /grammar /namespace namespace name=dml-shape3DStyles file=dml-shape3DStyles.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- ISO RELAX NG Schema -- include href=dml-shapeGeometry.rng/ define name=ST_BevelPresetType @@ -535,7 +535,7 @@ /resource /namespace namespace name=dml-shape3DCamera file=dml-shape3DCamera.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; define name=ST_PresetCameraType choice !-- Legacy Oblique Top Left -- @@ -747,7 +747,7 @@ /resource /namespace namespace name=dml-baseStylesheet file=dml-baseStylesheet.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- ISO RELAX NG Schema -- define name=ST_ColorSchemeIndex choice @@ -1003,7 +1003,7 @@ /resource /namespace namespace name=dml-textCharacter file=dml-textCharacter.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- ISO RELAX NG Schema -- include href=dml-shapeEffects.rng/ include href=dml-shapeLineProperties.rng/ @@ -1261,7 +1261,7 @@ /resource /namespace namespace name=dml-shapeEffects file=dml-shapeEffects.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; +grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns=http://relaxng.org/ns/structure/1.0; ns=http://schemas.openxmlformats.org/drawingml/2006/main; !-- start = blip -- define name=CT_AlphaBiLevelEffect attribute name=thresh @@ -2273,7 +2273,7 @@ /resource /namespace namespace name=dml-shapeLineProperties file=dml-shapeLineProperties.rng -grammar xmlns:xs=http://www.w3.org/2001/XMLSchema; xmlns:fn=http://www.w3.org/2006/xpath-functions; xmlns=http://relaxng.org/ns/structure/1.0;
[Libreoffice-qa] minutes of ESC call ...
* Present: + Bjoern, Andras, Jan-Marek G, Michael M, Christian, Stephan, Muthu, David, Eike, Kohei, Michael S, Markus, Miklos, Robinson, Cedric, Lionel * Completed Action Items: + contact Michael / the list when students show up (Jan Marek) [ students mostly coming to Bern for the conference ] + fix the 4.4 feature page (Norbert): + https://wiki.documentfoundation.org/ReleaseNotes/4.4#Mac_OS_X + speak at the conference on testing (Umesh) + trained in crash-test / VM maintenance for September/October (Miklos) * Pending Action Items: + ask UX advise wrt. wrench icons (revert or not ?) (Astron) + blog about the sad realities of web plugins (Bjoern) + open-source newer Synezip tests (Umesh) + get work / screenshots into the 4.4 feature list (Mentors ask students) + reach out / plan wrt. FOSDEM dev-rooms (Thorsten) * Release Engineering update (Christian) + 4.2.6-security release announced + 4.3.1 released early too + build issues with the VM, requiring re-starts. + rest of release schedule un-affected + 4.3.2 - branch off at the conference. + 4.2.7 - due in week 40 - 29th Sept freeze. + Potential for new incremental releases sooner. + Android Remote + pushed changes to the build-system to use gradle + in future, will be created using Android Studio. + now rather easier to hack on. * emergency release numbering policy (Bjoern/Eike) + if we always bump micro (major.minor.micro.nano) then we have problems with bugzilla fixed in next comments, not just attribute (Eike) + potentially update nano - as in 4.2.6.3 - no text changes + for this OOB release, recommend people patch don't ver. bump themselves if necessary. * GSOC Update (Cedric) + all set. + Remaining things to do: + Students should send a small blog / links etc. of what they did to Cedric so he can write a summary post. + Google re-blogs this often, so - prettiness is mandatory. + if help needed wrt. tar-ball creation; it's easy see here: + https://wiki.documentfoundation.org/Development/GSoc#Code_submission * Crashtest update (Markus) + run out of disk space -- new build will take 5 days + freed up 15Gb. + Miklos will take over in September/October + http://dev-builds.libreoffice.org/crashtest/66c6d1ef204f3507e7663a1b8b1be05b9ec71092/ + new results look quite good, fixing appreciated. * Munich update (Jan-Marek) + student interns arrived + managed to get them to the conference; 9x people there + patches in gerrit for review already + pleased with css::util vs. utl and uno-tools changes (Miklos) + #libreoffice-lhm has people there. + still reviewing mail-merge patches (Bjoern) + https://gerrit.libreoffice.org/#/q/owner:%22Jan-Marek+Glogowski%22+status:open,n,z * Certification Committee (Stephan/Bjoern/Kendy) + waiting until ~September after the conf. * Conference preparation (Moggi) + Agenda for face-to-face - 5pm ESC meeting. + UX work + QA / bug trends review + looming design disasters * Hackfests (Bjoern) + Seattle 'Libre-Fest' (Robinson) https://wiki.documentfoundation.org/Events/2014/Seattle_LibreFest + October 26, 2014 + Bug-triaging/Intro-to-community event + Following SeaGL conference + Munich hack-fest (Jan-Marek): http://www.it-muenchen-blog.de/2014/07/bug-squashing-party-2014/ + will have a BSP come-together; if someone says they're coming just show up etc. + November 21st-23rd, 2014 https://wiki.debian.org/BSP/2014/11/de/Munich + we should drop by with 2 or 3 developers, if possible + Toulouse Hackfest ... + Confirmed for Nov. 15-16th + more details: https://wiki.documentfoundation.org/Hackfest/Toulouse2014 + Be great to have -really- easy easy hacks for devs (Bjoern) * QA (Robinson) + UNCONFIRMED count up a bit last week, + some interesting new regressions + Multimedia on OS/X - changed + OS/X moved from quicktime to AVFoundation + a number of users with embedded multimedia not working. + would love a concise bug report (Michael) + Robinson's Mac arrived for triage + Speech Editor Siri of MAC OS 10.9.4 does not work with Libreoffice 4.3.0.3 https://bugs.freedesktop.org/show_bug.cgi?id=81759 + lower case greek alphabet missing in localized Math symbol table https://bugs.freedesktop.org/show_bug.cgi?id=80650 + S.Storti filing a number of writer / RTF issues recently. (Miklos) * UX Update (Astron / Mirek) * QA stats: + https://bugs.freedesktop.org/page.cgi?id=weekly-bug-summary.html +153-98(+55 overall) many thanks to the top bug squashers: Maxim Monastirsky9 Urmas7 Eike Rathke 7
Re: [Libreoffice-qa] Media Support in LibreOffice
Le 29/08/2014 18:43, Alexander Thurgood a écrit : Further testing : OSX : 10.9.4 LO : own master build 4.4.0 - no VLC build switch Special conditions : removed libavQuickTimelo.dylib from installed application bundle Loaded my test Impress file containing the inserted video files from bug 79546 : Preview : none of the files display a preview still image Preveiw play : none of the files play anything Full screen - none of the files play either video or sound. Note that not even the MP4 file, which is a recognised container and codec by Apple QuickTime 10.3, displays or plays in the LO master build with the quicktime library removed. Also note that when trying to insert a new media, all of the video container formats except for MOV appear to be greyed out, i.e. unselectable. However, although the MOV format file can be inserted : - it displays no preview on the slide, instead a blank object placeholder is displayed ; - the media controls are not displayed when the object is clicked ; - full screen slideshow displays a blank slide with no sound or video. My conclusion from this is that one can not simply remove the libavquicktimelo.dylib library from the LO application bundle and expect it to fallback to the libAVF library. Alex ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Media Support in LibreOffice
Le 29/08/2014 18:04, Robinson Tryon a écrit : Audio support testing with LO on OSX 10.9.4 LO master 4.4.0 own build including libavmediaquicktime library. Can insert : AIF MP3 WAV into a slide in Impress. Preview - nothing plays Fullscreen - nothing plays Can insert a MP4 AAC sound file and it will play in both preview and fullscreen. In comparison, I can't insert any of the four file formats in LO 4.3, I always get an error message - Unsupported format. Alex ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 83327] EDITING: Segfault in libeditenglo.so
https://bugs.freedesktop.org/show_bug.cgi?id=83327 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- How did you install 4.3.1.2? By downloading from official website (http://www.libreoffice.org/download/libreoffice-fresh/) or other? Does it crash on a brand new Calc file? Do you reproduce the crash after having renamed your LO directory profile? (see https://wiki.documentfoundation.org/UserProfile#GNU.2FLinux) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83328] turbo@turbo-VirtualBox ~/Desktop/LibreOffice_4.2.5.2_Linux_x86_deb/DEBS $ libreoffice4.2 /usr/bin/libreoffice4.2: 161: exec: /opt/libreoffice4.2/program/oosplash: not fo
https://bugs.freedesktop.org/show_bug.cgi?id=83328 --- Comment #2 from naresh nareshgoya...@gmail.com --- Yes i have installed it from debian package from the link http://www.libreoffice.org/download/libreoffice-fresh/ I have tried to install various version of 4.2 but nothing works. Same problem of oosplash not found. On Mon, Sep 1, 2014 at 11:27 AM, bugzilla-dae...@freedesktop.org wrote: Julien Nabet serval2...@yahoo.fr changed bug 83328 https://bugs.freedesktop.org/show_bug.cgi?id=83328 What Removed Added Status UNCONFIRMED NEEDINFO CC serval2...@yahoo.fr Ever confirmed 1 *Comment # 1 https://bugs.freedesktop.org/show_bug.cgi?id=83328#c1 on bug 83328 https://bugs.freedesktop.org/show_bug.cgi?id=83328 from Julien Nabet serval2...@yahoo.fr * On pc Debian testing x86-64, LO Debian package is 4.3.0.4 and works ok. Do you use Debian testing, stable, sid? How did you install LO? From Debian package repo? -- You are receiving this mail because: - You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80474] Mac OS X toolbar background isn't drawn correctly
https://bugs.freedesktop.org/show_bug.cgi?id=80474 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added CC||marcos...@gmail.com --- Comment #13 from Adolfo Jayme f...@libreoffice.org --- *** Bug 83318 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83318] Other: New native toolbar background do weird things with coloring
https://bugs.freedesktop.org/show_bug.cgi?id=83318 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- *** This bug has been marked as a duplicate of bug 80474 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83332] New: Add Kven language to LibreOffice [fkv-NO]
https://bugs.freedesktop.org/show_bug.cgi?id=83332 Priority: medium Bug ID: 83332 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Add Kven language to LibreOffice [fkv-NO] Severity: normal Classification: Unclassified OS: All Reporter: spec...@ivixor.net Hardware: Other Status: UNCONFIRMED Version: unspecified Component: Localization Product: LibreOffice We are working on a spellchecker[1] for the Kven language[2] at Giellatekno. Would it be possible to add Kven to the list of languages in the language selector ? 1. https://victorio.uit.no/langtech/trunk/langs/fkv 2. http://www.ethnologue.com/language/fkv -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83327] EDITING: Segfault in libeditenglo.so
https://bugs.freedesktop.org/show_bug.cgi?id=83327 Rpnpif rpn...@free.fr changed: What|Removed |Added CC||rpn...@free.fr --- Comment #2 from Rpnpif rpn...@free.fr --- (In reply to comment #1) I take the packages of this place : http://dev-builds.libreoffice.org/pre-releases/deb/x86_64/LibreOffice_4.3.1.2_Linux_x86-64_deb.tar.gz This crash is not reproducible but randomly. I'll try to change my user profile. Regards. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83141] Calc Find Replace extremely slow / freeze with large spreadsheet
https://bugs.freedesktop.org/show_bug.cgi?id=83141 Nicolas R nico2...@yopmail.com changed: What|Removed |Added Summary|Calc Find Replace extremely |Calc Find Replace extremely |slow / freeze with large |slow / freeze with large |spreasheet |spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83275] FILEOPEN: VDX import just throws general I/O error
https://bugs.freedesktop.org/show_bug.cgi?id=83275 David Tardon dtar...@redhat.com changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #5 from David Tardon dtar...@redhat.com --- (In reply to comment #4) Fridrich: I noticed that libvisio is different between 4.3 and 4.2 sources (libvisio-0.0.31.tar.bz2 libvisio-0.1.0.tar.bz2) Do you think it could be relevant to backport in 4.2 or should be put this one to FIXED (+ adding target 4.3.0.4)? It is not possible to backport libvisio-0.1.0 to 4.2--it would have to be a backport of the single commit that fixed the problem (I assume that would not be hard, but I might be mistaken.) Anyway, 4.2 is just before the last bugfix release and this is not a regression in 4.2, so I am inclined not to do anything. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83275] FILEOPEN: VDX import just throws general I/O error
https://bugs.freedesktop.org/show_bug.cgi?id=83275 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Whiteboard||target:4.3.0 Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83058] FILESAVE : DOCX File getting corrupted after RT due to Data label position is invalid in chart.xml
https://bugs.freedesktop.org/show_bug.cgi?id=83058 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jore...@libreoffice.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81492] FILESAVE [DOCX] Hyperlink text is getting lost after RT
https://bugs.freedesktop.org/show_bug.cgi?id=81492 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jorendc jore...@libreoffice.org --- Fix applied + Unit test - RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66373] FILEOPEN: MS .docx Fails to import properly. Watermark incorrectly rendered (6/6)
https://bugs.freedesktop.org/show_bug.cgi?id=66373 Bug 66373 depends on bug 78301, which changed state. Bug 78301 Summary: FILESAVE: Custom Watermark height and width has invalid values after Roundtrip in .docx https://bugs.freedesktop.org/show_bug.cgi?id=78301 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83248] PRINTING: Single-line text box always printed in black
https://bugs.freedesktop.org/show_bug.cgi?id=83248 --- Comment #3 from Mohamed-Ali BEN MANSOUR medalibenmans...@gmail.com --- Created attachment 105540 -- https://bugs.freedesktop.org/attachment.cgi?id=105540action=edit Problem when printing Single-line text box -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83248] PRINTING: Single-line text box always printed in black
https://bugs.freedesktop.org/show_bug.cgi?id=83248 --- Comment #4 from Mohamed-Ali BEN MANSOUR medalibenmans...@gmail.com --- @Joel: Sorry for cc'ing the bug: - Tested in 3.x and 4.x = The issue is there (does not seem to be a regression) - Test document attached. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83248] PRINTING: Single-line text box always printed in black
https://bugs.freedesktop.org/show_bug.cgi?id=83248 Mohamed-Ali BEN MANSOUR medalibenmans...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78694] After partial sorting data become incorrect
https://bugs.freedesktop.org/show_bug.cgi?id=78694 Timon kaktebyaviru...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #4 from Timon kaktebyaviru...@gmail.com --- In LibreOffice Version: 4.3.1.2 Build ID: 958349dc3b25111dbca392fbc281a05559ef6848 problem is back again! Cells are different (cell F5 had value 60,11 after such operations became 153,33; cell F8 had value 42,30 after such operations became 12,23; cell F13 had value 131,78 after such operations became 33,16 and and as a result the total amount in F39 is also incorrect). Hard recalc [Shift+Ctrl+F9] helps to solve problem, but that bug should be fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67464] Request for built-in EPS rendering ...
https://bugs.freedesktop.org/show_bug.cgi?id=67464 --- Comment #14 from Michael Meeks michael.me...@collabora.com --- handling as EMF/WMF, would Martin Gieseking's dvisvgm project code (GPLv3 at http://dvisvgm.sourceforge.net/ )from the TeX device independent file format world (but still ghostscript bound) be functional? Xpost has a number of licensing advantages; the alternative - having to have another out-of-process converter that is shipped only in some configurations is really not ideal IMHO no matter how nice the fidelity. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45789] automatic row height in reports
https://bugs.freedesktop.org/show_bug.cgi?id=45789 je...@live.de changed: What|Removed |Added Assignee|je...@live.de |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43579] Miniatures of pages are wrong
https://bugs.freedesktop.org/show_bug.cgi?id=43579 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from ign_christian ign_christ...@yahoo.com --- (In reply to comment #9) I think that this bug is fixed in LO 4.3.1.2. Can you confirm this ? Yes it's ok with LO 4.3.1.2 and 4.2.6.3 - Ubuntu 12.04 x86 Anyway you can change status to WFM by yourself if a problem not reproduced anymore in later version :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83107] FILEOPEN: LibO 4.3 permanently damages presentation files
https://bugs.freedesktop.org/show_bug.cgi?id=83107 sergio.calleg...@gmail.com changed: What|Removed |Added Summary|FILEOPEN: LibO 4.3 corrupts |FILEOPEN: LibO 4.3 |master pages wrt bullet |permanently damages |points |presentation files -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83107] FILEOPEN: LibO 4.3 permanently damages existing presentation files
https://bugs.freedesktop.org/show_bug.cgi?id=83107 sergio.calleg...@gmail.com changed: What|Removed |Added Summary|FILEOPEN: LibO 4.3 |FILEOPEN: LibO 4.3 |permanently damages |permanently damages |presentation files |existing presentation files -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83217] Reference of cell in source worksheet not updated correctly after moving dependent cell to another worksheet
https://bugs.freedesktop.org/show_bug.cgi?id=83217 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Whiteboard||bibisectRequest --- Comment #5 from ign_christian ign_christ...@yahoo.com --- Should we add a bibisectRequest? Yup..perhaps it helps dev if someone do bisect :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83308] STATUSBAR: Add thousand comma separators for word and character counts
https://bugs.freedesktop.org/show_bug.cgi?id=83308 Jay Philips philip...@hotmail.com changed: What|Removed |Added Version|unspecified |3.6.7.2 release --- Comment #2 from Jay Philips philip...@hotmail.com --- Sorry about that, i forgot to change that field from the last bug i sent. :) Word count in the statusbar appeared in 3.6.x. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41401] Distribution menu for images or other objects has not a natural result
https://bugs.freedesktop.org/show_bug.cgi?id=41401 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #9 from ign_christian ign_christ...@yahoo.com --- Should be UNCONFIRMED. No confirmation from others yet. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41401] Distribution menu for images or other objects has not a natural result
https://bugs.freedesktop.org/show_bug.cgi?id=41401 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34412] FILEOPEN: Import and export from and to MS Excel does not take care of the font of the cell in conditional format definitions
https://bugs.freedesktop.org/show_bug.cgi?id=34412 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Hardware|x86 (IA32) |All OS|Windows (All) |All Version|4.3.1.2 release |3.3.0 release --- Comment #31 from ign_christian ign_christ...@yahoo.com --- Change Version back to 3.3.0 according to: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Version -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82705] EDITING: Alt+Down doesn't start Selection list
https://bugs.freedesktop.org/show_bug.cgi?id=82705 --- Comment #6 from Kohei Yoshida libreoff...@kohei.us --- Alt-Down brings up the selection list for me though, using my August 29th build. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83344] New: OSX - video playback in Impress refuses to exit fullscreen mode
https://bugs.freedesktop.org/show_bug.cgi?id=83344 Priority: medium Bug ID: 83344 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: OSX - video playback in Impress refuses to exit fullscreen mode Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: ipla...@yahoo.co.uk Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.4.0.0.alpha0+ Master Component: Presentation Product: LibreOffice How to reproduce : 1) Start LibreOffice 2) Create a blank presentation 3) Insert a large video file, e.g. download from here the trailer for the sequel to 300 : http://www.digital-digest.com/movies/300_Rise_of_an_Empire_1080p_Theatrical_Trailer_2.html Unzip and insert the H264 video into a blank slide via File Insert Movie and Sound 4) Start the slideshow - the movie trailer plays 5) Now try clicking anywhere on screen, or pressing a key on the keyboard, the video stops playing, but LibreOffice remains in fullscreen mode. What should happen : the slidescreen mode should exit to a transition window that states Press any key to exit The user is forced to press Cmd-Option-Esc or Cmd-Tab to escape out of the application. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83344] OSX - video playback in Impress refuses to exit fullscreen mode
https://bugs.freedesktop.org/show_bug.cgi?id=83344 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Note that the video file in question is only 141Mb, quite small really. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83344] OSX - video playback in Impress refuses to exit fullscreen mode
https://bugs.freedesktop.org/show_bug.cgi?id=83344 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- More testing shows : No difference between linking or embedding the media file. Clicking the left mouse button key stops the video. Pressing spacebar key starts the video. Right mouse button brings up context menu where Play is the only usable choice Waiting til the end of the video in the hope that LO somehow regains control and pressing spacebar restarts the video from the beginning -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 79441, which changed state. Bug 79441 Summary: Internal references to other sheets not sorted (procedure comment 31) https://bugs.freedesktop.org/show_bug.cgi?id=79441 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83344] OSX - video playback in Impress refuses to exit fullscreen mode
https://bugs.freedesktop.org/show_bug.cgi?id=83344 foss f...@openmailbox.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from foss f...@openmailbox.org --- 10.9.4 LO 4.3.1.2 confirmed - NEW Video shows the famous grey questionmark instead of a thumbnail from the video, F5 does open presentation and video does play but as Alex says, clicking on the playing video halts the video and LO does not exist fullscreen mode. Also having to force quit LO to get out of this view isn't nice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83332] Add Kven language to LibreOffice [fkv-NO]
https://bugs.freedesktop.org/show_bug.cgi?id=83332 Urmas davian...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Urmas davian...@gmail.com --- There is an option to mark the text as fkv-NO. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83346] New: Mailing labels prints blank page between between real pages
https://bugs.freedesktop.org/show_bug.cgi?id=83346 Priority: medium Bug ID: 83346 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Mailing labels prints blank page between between real pages Severity: normal Classification: Unclassified OS: All Reporter: g...@extremeground.com Hardware: All Status: UNCONFIRMED Version: Inherited From OOo Component: Writer Product: LibreOffice This shows up when printing anything with multiple forms per page (it may also happen with single forms per page - can't remember, I usually print labels). Moreover it shows up withing LibreOffice's print dialogues as it actually shows the extra pages in the page count! For example, if I was printing something that should take 10 pages, the print dialogue will show it taking 19 pages. Things get worse when colour is involved, as all pages except the first have the colours messed up. The only workaround is to select records so that only one page of forms prints at a time. This has been going on for a long time and is not dependent on the printer. I have tested it on 32bit Ubuntu and 64bit Debian and it is still present in both Ubuntu 14.04 and Debian/Jessie (testing). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51332] EDITING: Creating labels: horizontal pitch ignored
https://bugs.freedesktop.org/show_bug.cgi?id=51332 --- Comment #5 from Gary Dale g...@extremeground.com --- It appears that the label positioning may be using width instead of pitch to position the label columns. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83347] New: START CENTER: Thumbnails shouldnt be saved in web layout
https://bugs.freedesktop.org/show_bug.cgi?id=83347 Priority: medium Bug ID: 83347 CC: ke...@collabora.com Assignee: libreoffice-bugs@lists.freedesktop.org Summary: START CENTER: Thumbnails shouldnt be saved in web layout Severity: normal Classification: Unclassified OS: All Reporter: philip...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: 4.2.6.2 release Component: Writer Product: LibreOffice Created attachment 105547 -- https://bugs.freedesktop.org/attachment.cgi?id=105547action=edit start center with the red highlighted thumbnail When you open a document in web layout, it normally repaginates to 1 page and when you exit the document, it saves a thumbnail of that long one page. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83350] New: LOCALIZATION: Arabic UI has status bar page numbering issue
https://bugs.freedesktop.org/show_bug.cgi?id=83350 Priority: medium Bug ID: 83350 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: LOCALIZATION: Arabic UI has status bar page numbering issue Severity: normal Classification: Unclassified OS: All Reporter: philip...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: Inherited From OOo Component: Writer Product: LibreOffice Created attachment 105550 -- https://bugs.freedesktop.org/attachment.cgi?id=105550action=edit how the page numbering looks after scrolling to page 2 When in the arabic UI, when i open up a document 'page 1 / X' is right aligned as it should be, but if i scroll down to page 2, it becomes left aligned. A work around is to press alt+tab twice, which bring it back to right aligned, but if i scroll to another page, it goes back to left aligned. Steps: 1) Change to Arabic UI 2) Open Writer 3) Press Ctrl+Enter to make a second page 4) Look at statusbar page numbering, it is left aligned Tested in 4.2.6, 4.3.2 and master in Linux and Windows. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83351] New: Macros: Using the old oood daemon which uses a pipe to communicate libreoffice hangs
https://bugs.freedesktop.org/show_bug.cgi?id=83351 Priority: medium Bug ID: 83351 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Macros: Using the old oood daemon which uses a pipe to communicate libreoffice hangs Severity: normal Classification: Unclassified OS: Linux (All) Reporter: dick.kn...@lindix.nl Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.3.1.2 release Component: BASIC Product: LibreOffice Problem description: Steps to reproduce: 1. Start libreoffice as a daemon: soffice --headless --norestore --minimized --nologo --nodefault --accept=pipe, name=ood-instance-1;urp; Current behavior: After a few seconds, the processor usage jumps to 100% Expected behavior: Low CPU usage for as long as no connection is requested and no document is to be processed. Operating System: Ubuntu Version: 4.3.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78508] FILEOPEN: DOCX Strict table size and spacing not retained
https://bugs.freedesktop.org/show_bug.cgi?id=78508 --- Comment #13 from Jay Philips philip...@hotmail.com --- No the table spacing issue doesnt happen with the original ooxml transitional file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83352] New: FORMATTING: Copying Attributes With the Format Paintbrush
https://bugs.freedesktop.org/show_bug.cgi?id=83352 Priority: medium Bug ID: 83352 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING: Copying Attributes With the Format Paintbrush Severity: normal Classification: Unclassified OS: Linux (All) Reporter: jpuc...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.6.2 release Component: Writer Product: LibreOffice Problem description: The format Paintbrush doesn't work Steps to reproduce: 1. Select the text with the desired format 2. click on the Format Paintbrush tool 2. Mark the text to format 3. Current behavior: Nothing happens Expected behavior: Marked text format changes to desired one Operating System: Fedora Version: 4.2.6.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83353] New: OSX - Impress only supports MP4 AAC audio playback - no other audio formats will work
https://bugs.freedesktop.org/show_bug.cgi?id=83353 Priority: medium Bug ID: 83353 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: OSX - Impress only supports MP4 AAC audio playback - no other audio formats will work Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: ipla...@yahoo.co.uk Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.4.0.0.alpha0+ Master Component: Presentation Product: LibreOffice 1) Open a new Impress presentation 2) Insert an audio file via Insert Movie and Sound 3) Try preview playback, then fullscreen playback Tested : AIF - no playback, either in preview of fullscreen MP3 - no playback, either in preview or fullscreen WAV - no playback, either in preview or fullscreen MP4 (AAC) - playback in fullscreen and preview All files play successfully in QuickTime 10.3 and also iTunes OSX : 10.9.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78699] crash after Undo of Sort with cell comment and then re-sort
https://bugs.freedesktop.org/show_bug.cgi?id=78699 --- Comment #11 from gtre...@ville-saintdie.fr --- Created attachment 105557 -- https://bugs.freedesktop.org/attachment.cgi?id=105557action=edit To reproduce bugs -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78699] crash after Undo of Sort with cell comment and then re-sort
https://bugs.freedesktop.org/show_bug.cgi?id=78699 --- Comment #12 from gtre...@ville-saintdie.fr --- Comment on attachment 105557 -- https://bugs.freedesktop.org/attachment.cgi?id=105557 To reproduce bugs Hi, we do some check with the latest code : 4.2.6-secfix - crash (seg fault) 4.3.1.2 - no crash Thanks for the fix in 4.3 branch. But, it remain our principal problem : one or more empty cell in the row header. When sorting or filtering, the row header is not recognize as expected. This cause strange behaviors for the sort and the auto-filter functionality. I attach a calc file to reproduce bugs. example for the sort : (steps to reproduce) 1) select a cell 2) do a sort (Ascendant or Descending) -- header row not recognized, so the row is sorted with others data example for the filter : (steps to reproduce) 1) select a cell 2) do a auto-filter -- a popup dialog appears which ask if we want to use the first row as header. -- answer Yes or No have the same effects -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83354] New: REPORTBUILDER: graph visualisation problem in a report base
https://bugs.freedesktop.org/show_bug.cgi?id=83354 Priority: medium Bug ID: 83354 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: REPORTBUILDER: graph visualisation problem in a report base Severity: normal Classification: Unclassified OS: Windows (All) Reporter: christian.carro...@wanadoo.fr Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.3.0.4 release Component: Database Product: LibreOffice From version 4.3.0 et 4.3.1, the graphs in the report (reportbuilder) are poorly positioned and truncated ??? The same graphs in the report are proprely viewed in version 4.2.5. Can you tell me if a correction is? Thank you in advance for your response. Operating System: Windows XP Version: 4.3.0.4 release Last worked in: 4.2.5.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51534] Ruler background doesn't change according to application background setting
https://bugs.freedesktop.org/show_bug.cgi?id=51534 --- Comment #11 from nodatalog nodata...@gmail.com --- Created attachment 105561 -- https://bugs.freedesktop.org/attachment.cgi?id=105561action=edit yellow background Can you tell? I just installed 4.3.1 to see the GUI change, and it does not work for me. It behaves exactly like 4.3.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75757] remove inheritance to std::map and std::vector
https://bugs.freedesktop.org/show_bug.cgi?id=75757 --- Comment #27 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e62ec6d0499e6c517713e7d5b1855a9b2c518219 fdo#75757: remove inheritance to std::vector The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67464] Request for built-in EPS rendering ...
https://bugs.freedesktop.org/show_bug.cgi?id=67464 --- Comment #15 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to comment #14) Xpost has a number of licensing advantages; the alternative - having to have another out-of-process converter that is shipped only in some configurations is really not ideal IMHO no matter how nice the fidelity. Didn't mean to suggest that we had to go with xpost, ghostscript is very much a functional resource, xpost is appealing as an alternative, especially if it could be built and bundled for all OSs. The project logo simply made a good EPS example. If filtering EPS to convert it to SVG--the dvisvgm utility does it in one step, but has several dependencies as noted. An alternative, and perhaps more appealing choice would be to use the ghostscript provided tool ps2pdf -dEPSCrop command to take each EPS to PDF, and then use a poppler and cairo wrapper to move from PDF to SVG (or other format). Dave Barton's pdf2svg is a poppler cairo based wrapper to do that conversion. I've used it a bit, and it is much cleaner than passing PDF (or EPS) through inkscape. --ref-- http://www.cityinthesky.co.uk/opensource/pdf2svg/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82467] PRINTING: Writer Crashes on copy phonenumer from adress-field or any where else and paste in phone number field Brother PC-Fax v.2.2
https://bugs.freedesktop.org/show_bug.cgi?id=82467 birqu...@web.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- Ever confirmed|0 |1 --- Comment #3 from birqu...@web.de --- Still existing Problem with LO 4.3.1.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82559] PRINTING: Writer Crashes on copy phone number from adress-field or any where else and paste in phone number field Brother PC-Fax v.2.2
https://bugs.freedesktop.org/show_bug.cgi?id=82559 --- Comment #1 from birqu...@web.de --- Still existing Problem with LO 4.3.1.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83309] .docx displayed incorrectly
https://bugs.freedesktop.org/show_bug.cgi?id=83309 Jorendc jore...@libreoffice.org changed: What|Removed |Added Attachment #105501|text/plain |application/vnd.openxmlform mime type||ats-officedocument.wordproc ||essingml.document -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82559] PRINTING: Writer Crashes on copy phone number from adress-field or any where else and paste in phone number field Brother PC-Fax v.2.2
https://bugs.freedesktop.org/show_bug.cgi?id=82559 --- Comment #2 from birqu...@web.de --- I read my post again and found that now it's not possible to copypaste text even once after restarting the computer. It doesn't matter whether copied from a field or from normal text nor if it's text or numbers. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82467] PRINTING: Writer Crashes on copy phonenumer from adress-field or any where else and paste in phone number field Brother PC-Fax v.2.2
https://bugs.freedesktop.org/show_bug.cgi?id=82467 --- Comment #4 from birqu...@web.de --- I read my post again and found that now it's not possible to copypaste text even once after restarting the computer. It doesn't matter whether copied from a field or from normal text nor if it's text or numbers. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83173] FILEOPEN: Missing Page in .DOCX
https://bugs.freedesktop.org/show_bug.cgi?id=83173 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83357] New: Buttons for Editing an entry of chapter Index not visible if preview is selected
https://bugs.freedesktop.org/show_bug.cgi?id=83357 Priority: medium Bug ID: 83357 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Buttons for Editing an entry of chapter Index not visible if preview is selected Severity: normal Classification: Unclassified OS: Linux (All) Reporter: n.ga...@codices.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.4.2 release Component: Writer Product: LibreOffice This is referred to the italian version of Writer, on Ubuntu 14.4 - I have not checked versions for other languages. The Structure and Formatting dialog which opens upon insert or edit of a chapter index (Indexes and Tables) does not show the buttons to insert elements (Chapter no., Tab stop, etc.) in the selected entry unless Preview is unchecked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83357] Buttons for Editing an entry of chapter Index not visible if preview is selected
https://bugs.freedesktop.org/show_bug.cgi?id=83357 Nando Gallo n.ga...@codices.com changed: What|Removed |Added Severity|normal |minor Priority|medium |low Keywords||notourbug -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83353] OSX - Impress only supports MP4 AAC audio playback - no other audio formats will work
https://bugs.freedesktop.org/show_bug.cgi?id=83353 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs