[Libreoffice-bugs] [Bug 62431] Wrong unit calculation for inherited formatting
https://bugs.freedesktop.org/show_bug.cgi?id=62431 --- Comment #13 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Markus Mohrhard from comment #11) This bug fixes number formats with units. We don't have units which would support stuff like km/h, ... and instead all that we have is number formats which specifies how to represent a number. That some number formats (if none is set yet) is determined by the formula interpreter is a feature to make it easier. Here is no bug. The plan to introduce an unit system has been discussed and there exist some plans but for the current number formats this is clearly not a bug. What's our documentation like of the current behavior? I don't see anything in the latest Calc manual: https://wiki.documentfoundation.org/images/4/47/CG41-CalcGuideLO.pdf -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67698] VIEWING: Implement 'Normal View' that includes the real page numbers in a 'Web Layout'-type view (comment #7)
https://bugs.freedesktop.org/show_bug.cgi?id=67698 Jay Philips philip...@hotmail.com changed: What|Removed |Added Summary|VIEWING: Enhancement: |VIEWING: Implement 'Normal |Implement 'Normal View' |View' that includes the |that includes the real |real page numbers in a 'Web |number and count of pages |Layout'-type view (comment |(comment #7)|#7) --- Comment #11 from Jay Philips philip...@hotmail.com --- Was trying out Abiword and noticed that they also have 'Normal' view. http://cn.cbsimg.net/cnwk.1d/i/tr/contentPics/techrepublic_abiword_normal_layout.jpg (In reply to Jay Philips from comment #9) Here is an example of 'Normal View' with footnotes showing (though the user did disable the top ruler which is on by default and the left toolbar is disabled in this view). Made a mistake here, it was supposed to be 'left ruler' and not 'left toolbar'. :D (In reply to bugquestcontri from comment #10) @Jay Philips - Thanks for adding the footnote comment. Very important indeed!!! Your welcome. I used to live in this view when i worked with my father who was an author. :D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 --- Comment #9 from just-me h...@chemie.uni-leipzig.de --- Hello Sorry for my slow response, but science can be an extreme time hogger. On the document: Yes, of course. I just recode the image to JPEG and embed the jpeg instead of a PNG in a fresh or the old file and things get better. On the machine(s): Yes. Of course I should have done that earlier. But it was partially up to 16 h work some days so I couldn't even look straight anymore. Current is 5350 APU, latest mesa etc. and LibO 4.3.5.2 (compiled one). I could check this on * VIA C7 (x86_32, Gentoo, openchrome on CN700) with some binary release of LibO * AMD Geode LX 800 (x86_32, Gentoo, xf86-video-geode on the Geode GPU) with some binary release of LibO * AMD E-350 (amd64, Gentoo, free stack on E-350 GPU part) with latest and greatest unstable LibO from portage (self compiled but * AMD Athlon II X4 (amd64, Gentoo, free stack on a HD 5670) with latest and greatest unstable LibO ... * AMD Athlon II X4 (same box, Windows XP 32 bit, AMD Catalyst blob) binary Windows release of LibO * some old laptop I got rented (intel P3 or P4 era?) with. XP 32 but iirc also some AMD/ATI mobile GPU and blob driver, binary LibO * an ancient ARM build of... oh, wait, that was still Openoffice :) on my semi defunct AI Touchbook * and some ancient boxes and loose mainboards without an OS currently. :) Honestly I wonder what causes the behaviour. I suspect a mix of GPU driver on the Kabini and LibO doing something different with the PNG to send it to the screen than it does with the JPEG. Still, other programs display them without visible problems (I might try to install abiword or calligra to check with that) I found that some binary applications do use emul-linux-x86-x (these are Gentoo's 32 bit precompiled libs for compatibility in 64 bit systems). However, they contain libs from Gentoo stable (maybe not as old as Debian stable, but you get the point). Thus e.g. the emul-linux-x86-opengl contains a mesa that is not even aware of the existance of Southern/Sea Islands GPUs used in the Kabini chips. Of course rendering then is a horror. But then, LibreOffice doesn't make use of them (32 bit compat. libs), does it? If there is any trace or something I should run during runtime while scrolling, just tell me what to do. MS-Windows test: Sorry, I only have DOS/W3.11 rotting somewhere, DOS/W9x and XP but the XP is not on the Kabini. I mean, if it was as easy with licensing and installation as a Linux distribution I might just have tossed it on some external HDD/flash and booted it via USB from the same machine. But even then the GPU driver would have been different (among a lot of other things, of course). I'll test tomorrow on some of the boxes with the problematic files and see what happens. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86636] Menu totally black when opening LO - also when opening database-file - summary circumstances -as far as possible- in comment 23
https://bugs.freedesktop.org/show_bug.cgi?id=86636 --- Comment #24 from rob...@familiegrosskopf.de --- Have updated my system to OpenSUSE 13.2 and openend LO 4.4.0.2 again. Seems the bug has gone there - don't know why. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88489] Highlight All in Find Bar
https://bugs.freedesktop.org/show_bug.cgi?id=88489 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Component|Spreadsheet |UI Version|4.3.4.1 release |Inherited From OOo --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- This is similar to what I suggested in bug 87998 comment 3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88502] User selection of Firefox theme is NOT possible
https://bugs.freedesktop.org/show_bug.cgi?id=88502 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Whiteboard|bibisectRequest | --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- Removing bibisectRequest as it is obvious this regressed in the GSoC Persona commits. It is an oversight in the new implementation. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88417] Dropdown for ruler settings should show radio buttons instead of check boxes
https://bugs.freedesktop.org/show_bug.cgi?id=88417 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added CC||caol...@redhat.com, ||f...@libreoffice.org See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=87923 | --- Comment #9 from Adolfo Jayme f...@libreoffice.org --- This also happens when you right-click a tab row, and it is due to this commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9995222d1141b326197a387cc7897b3971ce9e9a -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87923] RULER: Hiding only the vertical ruler
https://bugs.freedesktop.org/show_bug.cgi?id=87923 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=88417 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88400] How big is the libreoffice download on the website?
https://bugs.freedesktop.org/show_bug.cgi?id=88400 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Resolution|NOTABUG |MOVED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88287] UI: Rename Lines toolbar and removing Arrows toolbar from View Toolbars
https://bugs.freedesktop.org/show_bug.cgi?id=88287 Jay Philips philip...@hotmail.com changed: What|Removed |Added Component|ux-advise |UI Summary|[UI] Toolbar Curves has |UI: Rename Lines toolbar |title Lines and has no|and removing Arrows |entry in menu View |toolbar from View ||Toolbars --- Comment #4 from Jay Philips philip...@hotmail.com --- (In reply to Cor Nouws from comment #3) (In reply to Jay Philips from comment #2) I know. The example Arrows I gave, was the one I accidentally looked at ;) But it looks as the only exception: others are only accessible from the Drawing tool bar. So remove Arrows from the menu? There's enough to choose from :\ Yes i guess it can be removed from the View Toolbars menu. So the fixes needed are: 1) The tooltip for .uno:LineToolbox needs to be changed to 'Lines and Polygons' 2) The toolbar title of linesbar.xml needs to be changed to 'Lines and Polygons' 3) The Arrows toolbar (arrowsbar.xml) needs to be removed from View Toolbars -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88512] New: TOOLBARS: Character style drop down control
https://bugs.freedesktop.org/show_bug.cgi?id=88512 Bug ID: 88512 Summary: TOOLBARS: Character style drop down control Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: NEW Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Presently in Writer, we only show the paragraph style drop down control (.uno:StyleApply) and it would be useful to have a similar drop down control for character styles. Is there an uno command for this control already available, as i wasnt able to find one searching through the toolbar customizing dialog. MS Office 2003 and below would list both paragraph and character styles in its toolbar styles drop down control, while MS Office 2007 would also show paragraph and character styles in its styles selector control in its ribbon UI. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88058] Text formatted with only styles and manually is not visually different
https://bugs.freedesktop.org/show_bug.cgi?id=88058 Jay Philips philip...@hotmail.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise --- Comment #2 from Jay Philips philip...@hotmail.com --- Though i see very little use cases to this, maybe text which has direct formatting applied to it can appear in a different color than text which only uses styles, but this setting would not be enabled by default. I know MSO has a style inspector (attachment 102031) which shows the paragraph and character level styles and direct formatting applied to text. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] New: Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 Bug ID: 88516 Summary: Text rendering fuzzy on Mac OS X Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: joseph.h...@aya.yale.edu Created attachment 112365 -- https://bugs.freedesktop.org/attachment.cgi?id=112365action=edit Screenshot of font rendering in Writer Since upgrading to the new LibreOffice (4.3.5.2) yesterday on my Macbook Pro with Retina display, I've noticed that the text in LibreOffice looks fuzzy and low-res. I'm using the Yosemite version of Mac OS X. I will attach screenshots comparing the same text rendered on LibreOffice and MS Word. The problem applies to text in Writer or Calc as well as text rendered in dialogue boxes and other components. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 --- Comment #1 from Joseph Hill joseph.h...@aya.yale.edu --- Created attachment 112367 -- https://bugs.freedesktop.org/attachment.cgi?id=112367action=edit Comparison screenshot of similar text rendered in MS Word -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 --- Comment #2 from Joseph Hill joseph.h...@aya.yale.edu --- Created attachment 112368 -- https://bugs.freedesktop.org/attachment.cgi?id=112368action=edit Screenshot of font rendering in Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 Joseph Hill joseph.h...@aya.yale.edu changed: What|Removed |Added Attachment #112365|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88517] New: Calc no allow insert Page Break
https://bugs.freedesktop.org/show_bug.cgi?id=88517 Bug ID: 88517 Summary: Calc no allow insert Page Break Product: LibreOffice Version: 4.3.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: NEW Severity: major Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dahaole...@gmail.com Created attachment 112369 -- https://bugs.freedesktop.org/attachment.cgi?id=112369action=edit Can't enter Page Breaks to have printout readable. This version of Calc will not allow me to insert a page break, like am able to do in prior versions. No special characters are used... only text, formulas, background colors, cell borders. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88518] New: FILEOPEN RTF: PDF export speeds up document build times significantly
https://bugs.freedesktop.org/show_bug.cgi?id=88518 Bug ID: 88518 Summary: FILEOPEN RTF: PDF export speeds up document build times significantly Product: LibreOffice Version: 4.3.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bugzi...@justcloned.com Created attachment 112370 -- https://bugs.freedesktop.org/attachment.cgi?id=112370action=edit Simple but huge repro file. Some general remarks: First off, sorry for the huge attachement but to really see what this bug report is about we need a huge document that takes a while to load. All timings mentioned here were taken on Windows 7 running on an Intel Core 2 Duo E8400 clocked at 2GHz. So if your machine is faster or slower your mileage may vary. :) To be able to properly repro the issue I decided to use a document fairly similar to the real life document I am working on, but with the original text replaced by the Lorem ipsum text. What I call build display is what I assume LibreWriter does once it has finished loading the RTF file (the document's first page is now visible) and has started parsing its content, building the document structure from it and displaying what has been built already. Once this build display process ends, the document with all of its pages is fully displayed in LibreWriter. Problem description: While the attached RTF file takes a significant time to fully build display all of its content in LibreWriter, immediately (after loading has finished) starting an export to PDF will speed up this build display time for the document tremendously. Steps to reproduce: - Load the attached .rtf file. - Measure the time it takes for all ~267 pages to build and display. - Close the document. - Load the attached .rtf file again. - Start measuring the time again. - Immediately after loading has finished (and building and displaying has started) select File Export as PDF, hit Export and save to some random location. - Once exporting the PDF has finished, the document will also have finished building and displaying all ~267 pages. - Stop measuring the time. Current behavior: Building and displaying the document without doing anything takes ~75 seconds on my machine. Building and displaying the document while exporting it as PDF at the same time takes ~16 seconds on my machine. Expected behavior: Building and displaying the document without doing anything should not take longer than it takes when exporting the PDF at the same time. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88323] SPELLING: Shouldnt some of the grammar checking be enabled by default
https://bugs.freedesktop.org/show_bug.cgi?id=88323 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- A really interesting question. I don't understand why there are not more checked as standard. If there are no reasons against it, then I personally would propose that more features are checked by default in this dialogue (- Possible mistakes, Capitalisation, Word duplication and Parantheses). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78254] Substantial performance deterioration by scroll through cells via macro in LibreOffice Calc
https://bugs.freedesktop.org/show_bug.cgi?id=78254 Jay Philips philip...@hotmail.com changed: What|Removed |Added Whiteboard|bibisected |bibisected perf --- Comment #6 from Jay Philips philip...@hotmail.com --- Did a callgrind on it and here is the results. https://drive.google.com/file/d/0B6qJrVIa0SAlRUJRRHg0Qm9QS28/view?usp=sharing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88517] Calc no allow insert Page Break
https://bugs.freedesktop.org/show_bug.cgi?id=88517 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Attachment #112369|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88517] Calc no allow insert Page Break
https://bugs.freedesktop.org/show_bug.cgi?id=88517 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|NEW |NEEDINFO CC||mari...@miguelangel.mobi --- Comment #1 from m.a.riosv mari...@miguelangel.mobi --- Hi Dave, thanks for reporting. Please verify the option in: Menu/Tools/Options/LibreOffice Calc/Print/Pages - Always apply manual breaks. Please don't setup as NEW, this is supposed to be done by someone that has verified the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88518] FILEOPEN RTF: PDF export speeds up document build times significantly
https://bugs.freedesktop.org/show_bug.cgi?id=88518 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Attachment #112370|text/plain |application/rtf mime type|| CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- Comment on attachment 112370 -- https://bugs.freedesktop.org/attachment.cgi?id=112370 Simple but huge repro file. fix mimetype -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81129] Unicode Chars with 5-hex-digit Codes are Filtered Away in Pasting (Paste Special Option Doesn't Work; Works in WordPad)
https://bugs.freedesktop.org/show_bug.cgi?id=81129 --- Comment #6 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 85315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85315] Characters outside the Basic Multilingual Plane (BMP) cannot be pasted into LibreOffice on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=85315 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 81129 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88509] upper case i in non english text
https://bugs.freedesktop.org/show_bug.cgi?id=88509 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Puggan SE from comment #0) I have my system language set to english, and installed the english version of Libbreoffice, and added the swedish spellcheck. (got the feling that computer installed in swedish, don't have this bug) Hi Puggan, Looks like we have Swedish help- and lang-packs: http://comments.gmane.org/gmane.comp.documentfoundation.libreoffice.qa/6237 What happens when you install those and enable them? Do you still have the same auto-correct problem? Status - NEEDINFO (Please change status back to UNCONFIRMED after you reply. thanks!) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81189] Other: Ignore Once doesn't work for grammar problems
https://bugs.freedesktop.org/show_bug.cgi?id=81189 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 57666 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57666] EDITING: Grammar checker
https://bugs.freedesktop.org/show_bug.cgi?id=57666 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||misc2...@danielnaber.de --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 81189 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88371] Proposal for Expanding Headers in Navigator with Double-Clicks
https://bugs.freedesktop.org/show_bug.cgi?id=88371 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Attachment #112170|text/plain |application/vnd.oasis.opend mime type||ocument.text CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- Comment on attachment 112170 -- https://bugs.freedesktop.org/attachment.cgi?id=112170 Example file in order to illustrate the enhancement fix mimetype -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88371] Proposal for Expanding Headers in Navigator with Double-Clicks
https://bugs.freedesktop.org/show_bug.cgi?id=88371 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise Ever confirmed|0 |1 --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Harald Koester from comment #0) In order to improve the usability of the Navigator according expanding headings, I propose that headings are always expanded with a double-click and never collapse with a double-click. In order to illustrate the problem open the attached file and follow the instructions inside. One for the UX Guild to tackle Status - NEW Component - ux-advise -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88359] All ISO 8601 formats should always be in LibreOffice date acceptance patterns
https://bugs.freedesktop.org/show_bug.cgi?id=88359 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #3 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Nemo_bis from comment #0) I've read http://erack.org/blog/archives/8-LibreOffice-date-acceptance-patterns.html and I don't find this situation helpful. ... User story: as a user with a a list of ISO 8601 timestamp, I want them to be consistently recognised as timestamps, so that they are displayed as dates and can be worked on as dates (e.g. to calculate time intervals/differences). ... I'm using 4.2.8.2-1.fc20 with Italian locale. My specific input was https://frdata.wikimedia.org/campaign-vs-amount.csv So we have a test file. What are the repro steps to take and the RESULTS vs what you EXPECTED to see? Status - NEEDINFO Thanks. (set status back to UNCONFIRMED after you provide those repro steps) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87525] Wrong replace behaviour with Find Replace window open
https://bugs.freedesktop.org/show_bug.cgi?id=87525 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #7 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Beluga from comment #6) Changed severity to enhancement, but this needs to be debated. Some users might get annoyed, if this sniffing of selection was implemented. Sounds like one for the UX to contemplate... (In reply to raal from comment #4) You propose findreplace If the user has (and that's the behaviour most users will exhibit) selected a particular data range, than this should automatically active the 'current selection only' feature., but user untick Current selection. Is that what's being proposed here? Let's get our ducks in a row first, and then this can go over to the UX Team for clarification. Status - NEEDINFO (Michael: Once you've added a clear proposal for what to change re: Find Replace, then change status back to UNCONFIRMED, please. Thanks!) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81325] FILEOPEN: 6-pages DOCX shows only the first page in LO
https://bugs.freedesktop.org/show_bug.cgi?id=81325 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |WORKSFORME --- Comment #12 from Matthew Francis fdb...@neosheffield.co.uk --- Already fixed in 4.4 and 4.5 master. Unless it's already on the 4.3 branch and hasn't been released yet, a backport is probably unlikely this close to the end of the 4.3 lifecycle As it's not known which exact commit provided the fix, setting: - RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=79641 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Depends on||88378 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88378] CRASH (segfault) when flip selected for an image previously saved in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=88378 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Priority|medium |highest Status|UNCONFIRMED |NEW Hardware|Other |All CC||qu...@runcibility.com Blocks||79641 Ever confirmed|0 |1 Summary|Crash (segfault) when |CRASH (segfault) when |flip selected for an |flip selected for an |image previously saved in |image previously saved in |.doc|.doc Severity|major |critical --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING with Ubuntu 14.04 + LO 4.4.0.2 (In reply to Jim Avera from comment #0) STEPS TO REPRODUCE: 1. Open the attached crasher.odt 2. select the image (lower left corner) 3. Rightclick - Image... 4. On the Image tab, check Flip Horizontally Ayup RESULTS: Instant crash wait for it (LibreOffice stayed up for just a second) ...yep, there it is! CONFIRMED: LibreOffice does the old crasheroo Status - NEW Hardware - (Generalize) Blocks - MAB 4.4 Priority - highest Severity - critical Jim: Thanks for the great bug report! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55561] Formula Create a PDF with the code of LO Formular and in background some formula
https://bugs.freedesktop.org/show_bug.cgi?id=55561 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |WORKSFORME --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- A Writer document containing this formula appears to export correctly in 4.3 and 4.4. Setting RESOLVED - WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88378] CRASH (segfault) when flip selected for an image previously saved in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=88378 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Keywords||regression Version|4.4.0.0.beta2 |4.3.5.2 release Blocks|79641 |75025 Whiteboard||bibisectRequest --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING again on Ubuntu 14.04 + LO Version: 4.5.0.0.alpha0+ Build ID: 84c69550bcb8139669de9cf98b51c35f21fe853d TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-13_08:44:23 Locale: en_US (In reply to Robinson Tryon (qubit) from comment #1) STEPS TO REPRODUCE: 1. Open the attached crasher.odt 2. select the image (lower left corner) 3. Rightclick - Image... In 4.5 this step is now: (Right click) - Format Image 4. On the Image tab, check Flip Horizontally RESULTS: Instant crash TEST RESULTS: 4.5-master (see version above): Crash 4.2.5.2: Crash 4.2.0.1: Crash 3.5.7.2: NOREPRO - horizontal and vertical flip okay Keywords - regression Whiteboard - bibisectRequest (4.2 Builds: In both builds tested, an empty (?) warning dialog appeared (with an ! in a triangle), but upon closing the dialog, the program quit/crashed) Blocks: Changing mab4.4 - mab4.3 (The earliest active branch on which we can reproduce) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Depends on||88378 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=79641 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Depends on|88378 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88378] CRASH (segfault) when flip selected for an image previously saved in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=88378 --- Comment #3 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Robinson Tryon (qubit) from comment #2) Sorry that should read: 4.3.5.2: Crash 4.2.0.1: Crash (4.3/4.2 Builds: In both builds tested, an empty (?) warning dialog appeared (with an ! in a triangle), but upon closing the dialog, the program quit/crashed) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81393] Formulas get corrupted after exporting as PDF
https://bugs.freedesktop.org/show_bug.cgi?id=81393 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |NEEDINFO CC||fdb...@neosheffield.co.uk --- Comment #6 from Matthew Francis fdb...@neosheffield.co.uk --- I can't access the image linked to in comment 0. If this issue still occurs in 4.3 or later, please attach a screenshot of the issue you are seeing directly to this bug. It would also be useful to know the precise formula text used in the reproduction steps (step 2) and how exactly it is updated (step 3) Setting - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81436] inserting formula, autotext
https://bugs.freedesktop.org/show_bug.cgi?id=81436 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Attachment #102930|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81497] PRINTING: to PDF with Adobe Distiller or GS based PDF printer, EPS images not rendered to PS vector for PDF, instead print uses the preview of EPS image
https://bugs.freedesktop.org/show_bug.cgi?id=81497 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81498] FILEOPEN: .doc with table spanning 3 pages. page 2 and 3 are shown superimposed
https://bugs.freedesktop.org/show_bug.cgi?id=81498 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |NEEDINFO CC||fdb...@neosheffield.co.uk --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- The file linked in comment 0 has moved or been deleted. Unless the file can be located, no further investigation will be possible. Setting - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81522] FILESAVE: can't save .docx after deleting header or footer
https://bugs.freedesktop.org/show_bug.cgi?id=81522 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||regression CC||fdb...@neosheffield.co.uk Whiteboard|filter:docx |filter:docx bibisectRequest --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- This starts somewhere after last41onmaster in the 43all bibisect repository Setting Keywords: regression and Whiteboard: bibisectRequest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81531] wrong total pages shown for first few seconds
https://bugs.freedesktop.org/show_bug.cgi?id=81531 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |NOTABUG --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- To be honest this is simply expected behaviour. Consider it analogous to loading a long web page - the alternative to figuring out the page count asynchronously is to always wait until the whole document has been analysed, which could be a very long wait. Figuring out the right answer within a few seconds seems perfectly acceptable to me. Setting RESOLVED - NOTABUG -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88407] Freezing when saving as txt or rtf (and giant RTF filesize)
https://bugs.freedesktop.org/show_bug.cgi?id=88407 --- Comment #7 from Piotr p.144...@gmail.com --- hi I've just updated kernel to better support intel atom and gma500 http://heanet.dl.sourceforge.net/project/kernelnetbook/3.9.6/linux-headers-3.9.6-netbook_3.9.6_i386.deb after update the display quality was better. before update the highest youtube quality it could play was 240p and now it has no problem with 720p. that being said conversion of blog english.odt still took 5mins I estimate that for anyone with old kernel that has bad support for atom could take as much as 10mins depending on document size. still by comparison converting odt--doc/docx is instant both pre and after kernel update. blog english.rtf 532.4 MB -7mins to open 5mins to convert from odt 19.9M At the beginning I assumed the conversion odt-rtf was going dead during conversion by lack of hdd activity for more than 4mins but yeah it comes back after. Sorry my normal desktop PC broke and I am new to netbooks/atom. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81545] Manual column break misplaced after copy-paste
https://bugs.freedesktop.org/show_bug.cgi?id=81545 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Attachment #103114|text/plain |application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88311] LO Win32@51 4.4.1.0.0 2015-01-09 package corrupts during install, says CAB broken.
https://bugs.freedesktop.org/show_bug.cgi?id=88311 --- Comment #4 from Richard_416282 richard416...@yahoo.ca --- LO daily has the latest date of 2015-01-16. this has a URL of: http://dev-builds.libreoffice.org/daily/libreoffice-4-4/Win-x86@42/2015-01-16_09.39.33/ IS this what you refer to as 'branch'? While LO daily master has the URL of: http://dev-builds.libreoffice.org/daily/master/Win-x86@62-TDF/2015-01-17_01.06.46/ I am guessing at this point because there is no clear definition(s) of Branch, Master, etc after they are run through the compilers(Make Process?). Since My PC has a limited HW platform, I am sure I could cobble something together, but it is not very easy, to define the flow on how to create (or roll your own build box) or facilitate the transition to a stand alone build process from the Source and have it regularly updated (RSync perhaps). Sorry, I am not quite up to the source-make-build-execute level yet. The best I can do (at the moment) is download the tinderbox builds, and try if they work. See the image attached from the daily of 2015-01-16. I am assuming that the path that poins to the 'master', has the code for the 4.5 tree, but not sure which branch level to test against? There are 3-4 choices for the x86 platform, and nothing specific to AMD processors that can handle x64 stuff (yet). ~Hope this is the info you need. Will give a go with the latest tinderbox 4.5.0.0alpha0 build. So far it is 124 MB. this is a good sign. at least it is not missing the ~25MB of CAB that was missing from the 2015-01-09 Build. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88311] LO Win32@51 4.4.1.0.0 2015-01-09 package corrupts during install, says CAB broken.
https://bugs.freedesktop.org/show_bug.cgi?id=88311 Richard_416282 richard416...@yahoo.ca changed: What|Removed |Added CC||richard416...@yahoo.ca --- Comment #5 from Richard_416282 richard416...@yahoo.ca --- Created attachment 112373 -- https://bugs.freedesktop.org/attachment.cgi?id=112373action=edit Image of path to Tinderbox Build (Latest for x64 Win7 Systems??) Attached Image from previous Comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88407] Freezing when saving as txt or rtf (and giant RTF filesize)
https://bugs.freedesktop.org/show_bug.cgi?id=88407 --- Comment #8 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Piotr from comment #7) that being said conversion of blog english.odt still took 5mins I estimate that for anyone with old kernel that has bad support for atom could take as much as 10mins depending on document size. Yep -- ideally there could be some kind of progress bar or indicator to show that LO is still chugging along, but it's going to take a little while to finish the operation. At the beginning I assumed the conversion odt-rtf was going dead during conversion by lack of hdd activity for more than 4mins but yeah it comes back after. Sorry my normal desktop PC broke and I am new to netbooks/atom. No worries -- I certainly didn't expect to see that 20MB ODT turn into a 1/2 GB of RTF. I'm assuming that the images must be turning into huge bitmaps, etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88311] LO Win32@51 4.4.1.0.0 2015-01-09 package corrupts during install, says CAB broken.
https://bugs.freedesktop.org/show_bug.cgi?id=88311 --- Comment #6 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Richard_416282 from comment #4) http://dev-builds.libreoffice.org/daily/libreoffice-4-4/Win-x86@42/2015-01- 16_09.39.33/ Any builds in this directory are created daily, and are not designed for production work. They're only for QA and testing: http://dev-builds.libreoffice.org/daily/ Those builds may or may not work. If a build doesn't work today, then wait for the next build tomorrow and see if it works. Since My PC has a limited HW platform, I am sure I could cobble something together, but it is not very easy, to define the flow on how to create (or roll your own build box) or facilitate the transition to a stand alone build process from the Source and have it regularly updated (RSync perhaps). What's your goal here? Is there a particular reason to use a daily build vs. a release build? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88339] EDITING: Moving images in Draw, Impress, and Calc now uses constrain by default
https://bugs.freedesktop.org/show_bug.cgi?id=88339 tmacalp tmac...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from tmacalp tmac...@gmail.com --- I've submitted another patch that should take care of this behavior in Calc. https://gerrit.libreoffice.org/#/c/13975/ At this point, I'm pretty sure this bug is valid, so I'll change the status from NEEDINFO back to NEW until the patch is accepted. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87574] Outline numbering None is not retained when save as docx
https://bugs.freedesktop.org/show_bug.cgi?id=87574 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||regression CC||fdb...@neosheffield.co.uk Whiteboard||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76825] UI: Styles drop down menu is too narrow in Libreoffice Writer
https://bugs.freedesktop.org/show_bug.cgi?id=76825 Joel Madero jmadero@gmail.com changed: What|Removed |Added Priority|medium |highest CC||jmadero@gmail.com Whiteboard|BSA NeedsDevEval|BSA NeedsDevEval ||bibisectRequest --- Comment #15 from Joel Madero jmadero@gmail.com --- MAB should be set to highest. What is weird is that the person who added this to the MAB list said it's been a problem since 4.0 but the original poster said 4.2 Also - a bibisect might be useful. https://wiki.documentfoundation.org/QA/HowToBibisect -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 75467, which changed state. Bug 75467 Summary: OS X integration: selecting a file in Open File dialog adds resource fork, changes size and mod date (10.6/10.7) https://bugs.freedesktop.org/show_bug.cgi?id=75467 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75467] OS X integration: selecting a file in Open File dialog adds resource fork, changes size and mod date (10.6/10.7)
https://bugs.freedesktop.org/show_bug.cgi?id=75467 Peter Nowee peter.no...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Version|4.2.0.0.beta2 |4.2.0.0.alpha0+ Master Resolution|WONTFIX |--- Assignee|libreoffice-b...@lists.free |peter.no...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Peter Nowee peter.no...@gmail.com changed: What|Removed |Added Depends on||75467 --- Comment #93 from Peter Nowee peter.no...@gmail.com --- In Mac OS X 10.6/10.7, LO 4.2/4.3 messes with files on the filesystem that the user did not even choose to open, which I think is a serious violation. I am doing what I can to help fix it, but I could really use some developer support. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on|75467 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75467] OS X integration: selecting a file in Open File dialog or merely viewing a folder in Save File dialog adds resource fork, changes size and mod date (10.6/10.7)
https://bugs.freedesktop.org/show_bug.cgi?id=75467 tommy27 ba...@quipo.it changed: What|Removed |Added Blocks|65675 | Assignee|peter.no...@gmail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #51 from tommy27 ba...@quipo.it --- let's remove this from the mab4.2 list which is closed after 4.2.x end of life and let's keep it under the mab4.3 list @Peter I've seen you put yourself under Assigned to that field means that you are going to fix it yourself. according to your latest comment it seems that you are not able to do it alone but you need help from another developer, right? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75467] OS X integration: selecting a file in Open File dialog or merely viewing a folder in Save File dialog adds resource fork, changes size and mod date (10.6/10.7)
https://bugs.freedesktop.org/show_bug.cgi?id=75467 --- Comment #52 from Peter Nowee peter.no...@gmail.com --- @tommy27 : Yes, that's right. I assigned it to myself because I don't agree with this bug being marked RESOLVED/WONTFIX. I can understand that people who are running Mac OS 10.8+ have no incentive to fix this bug, but that does not resolve it for users of 10.6 and 10.7, for who it is a serious deal breaker. So I took this bug mainly because nobody else will. I am currently trying to manually source-bisect the bug, but this is going very slow (each build takes 5 to 8 hours and I often run into build errors). If I succeed to pinpoint the offensive code, I will probably ask experienced Mac OS X developers to comment on what may be wrong with it. If nobody is available within the LO community itself, I was planning on asking on a Mac OS X developer forum or something. So, yes, I am doing what I can, but I could really use some help. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 foss f...@openmailbox.org changed: What|Removed |Added Attachment #112365|0 |1 is obsolete|| --- Comment #3 from foss f...@openmailbox.org --- Comment on attachment 112365 -- https://bugs.freedesktop.org/attachment.cgi?id=112365 Screenshot of font rendering in Writer duplicate -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88516] Text rendering fuzzy on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=88516 --- Comment #4 from foss f...@openmailbox.org --- Does this persist with LO 4.4RC2: http://www.libreoffice.org/download/pre-releases/ ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source include/editeng sw/source
editeng/source/items/frmitems.cxx | 17 +
include/editeng/lrspitem.hxx|1 +
sw/source/core/docnode/nodedump.cxx |6 +++---
3 files changed, 21 insertions(+), 3 deletions(-)
New commits:
commit 0ffb225d374cfda29275db3c22a9866eb5fe5ad2
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jan 16 09:26:09 2015 +0100
Factor out SvxLRSpaceItem::dumpAsXml() from sw
Change-Id: Id28c3e1617f2e73c36f13b506488d401a22b00a8
diff --git a/editeng/source/items/frmitems.cxx
b/editeng/source/items/frmitems.cxx
index 66f0ba3..216b30e 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -808,6 +808,23 @@ bool SvxLRSpaceItem::HasMetrics() const
return true;
}
+void SvxLRSpaceItem::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST(svxLRSpaceItem));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(whichId),
BAD_CAST(OString::number(Which()).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nFirstLineOfst),
BAD_CAST(OString::number(nFirstLineOfst).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nTxtLeft),
BAD_CAST(OString::number(nTxtLeft).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nLeftMargin),
BAD_CAST(OString::number(nLeftMargin).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nRightMargin),
BAD_CAST(OString::number(nRightMargin).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nPropFirstLineOfst),
BAD_CAST(OString::number(nPropFirstLineOfst).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nPropLeftMargin),
BAD_CAST(OString::number(nPropLeftMargin).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nPropRightMargin),
BAD_CAST(OString::number(nPropRightMargin).getStr()));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST(bAutoFirst),
BAD_CAST(OString::number(bAutoFirst).getStr()));
+xmlTextWriterWriteAttribute(pWriter,
BAD_CAST(bExplicitZeroMarginValRight),
BAD_CAST(OString::number(bExplicitZeroMarginValRight).getStr()));
+xmlTextWriterWriteAttribute(pWriter,
BAD_CAST(bExplicitZeroMarginValLeft),
BAD_CAST(OString::number(bExplicitZeroMarginValLeft).getStr()));
+xmlTextWriterEndElement(pWriter);
+}
+
// class SvxULSpaceItem --
SvxULSpaceItem::SvxULSpaceItem( const sal_uInt16 nId )
diff --git a/include/editeng/lrspitem.hxx b/include/editeng/lrspitem.hxx
index c5eb6ec..ef5d737 100644
--- a/include/editeng/lrspitem.hxx
+++ b/include/editeng/lrspitem.hxx
@@ -126,6 +126,7 @@ public:
{ return nPropFirstLineOfst; }
inline void SetTxtFirstLineOfstValue( const short nValue )
{ nFirstLineOfst = nValue; }
+void dumpAsXml(struct _xmlTextWriter* pWriter) const;
};
inline SvxLRSpaceItem SvxLRSpaceItem::operator=( const SvxLRSpaceItem rCpy )
diff --git a/sw/source/core/docnode/nodedump.cxx
b/sw/source/core/docnode/nodedump.cxx
index 55490ee..d63b82a 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -490,6 +490,9 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const
SfxItemSet* pSet)
case RES_COLUMNBALANCE:
static_castconst
SwFmtNoBalancedColumns*(pItem)-dumpAsXml(writer);
break;
+case RES_LR_SPACE:
+static_castconst SvxLRSpaceItem*(pItem)-dumpAsXml(writer);
+break;
default: bDone = false; break;
}
if (bDone)
@@ -504,9 +507,6 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const
SfxItemSet* pSet)
boost::optionalOString oValue;
switch (pItem-Which())
{
-case RES_LR_SPACE:
-pWhich = left-right space;
-break;
case RES_UL_SPACE:
pWhich = upper-lower space;
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accmap.cxx|3 +--
sw/source/core/access/accpara.cxx |3 ++-
sw/source/core/access/acctable.cxx | 14 ++
sw/source/core/bastyp/bparr.cxx |3 +--
sw/source/core/bastyp/init.cxx |4 +++-
sw/source/core/crsr/crstrvl.cxx |7 +--
sw/source/core/doc/CntntIdxStore.cxx|2 +-
sw/source/core/doc/DocumentContentOperationsManager.cxx |3 +--
sw/source/core/doc/DocumentStatisticsManager.cxx|2 +-
sw/source/core/doc/doc.cxx | 14 ++
sw/source/core/doc/docbasic.cxx |4 +++-
sw/source/core/doc/docchart.cxx |4 +++-
sw/source/core/doc/docdraw.cxx |3 ++-
sw/source/core/doc/docedt.cxx |3 ++-
sw/source/core/doc/docfld.cxx |2 +-
sw/source/core/doc/doclay.cxx | 12 +++-
sw/source/core/doc/docnum.cxx |3 ++-
sw/source/core/doc/fmtcol.cxx |2 +-
sw/source/core/doc/gctable.cxx |4 +++-
sw/source/core/doc/number.cxx |7 ---
sw/source/core/doc/tblrwcl.cxx |6 +++---
sw/source/core/docnode/ndsect.cxx |4 ++--
sw/source/core/docnode/ndtbl.cxx| 10 --
sw/source/core/docnode/node.cxx |8 +---
24 files changed, 73 insertions(+), 54 deletions(-)
New commits:
commit ccaa5519cb978a640caa22ce2bcbd6c54fa44e26
Author: Michael Weghorn m.wegh...@posteo.de
Date: Thu Jan 15 17:16:31 2015 +
fdo#39440 sw: reduce scope of local variables
This addresses some cppcheck warnings.
Change-Id: I4c55c109f81407d5383932e4254e0f5f61d12cd7
Reviewed-on: https://gerrit.libreoffice.org/13939
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Björn Michaelsen bjoern.michael...@canonical.com
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 40eebd5..5b41a9c 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -1277,13 +1277,12 @@ void SwAccessibleMap::InvalidateShapeInParaSelection()
const SwFrm *pFrm = (*aIter).first;
if(pFrm-IsFlyFrm())
{
-bool bFrmChanged = false;
uno::Reference XAccessible xAcc = (*aIter).second;
if(xAcc.is())
{
SwAccessibleFrameBase *pAccFrame = (static_cast
SwAccessibleFrameBase * (xAcc.get()));
-bFrmChanged = pAccFrame-SetSelectedState( true );
+bool bFrmChanged = pAccFrame-SetSelectedState( true );
if (bFrmChanged)
{
const SwFlyFrm *pFlyFrm = static_cast const SwFlyFrm
* ( pFrm );
diff --git a/sw/source/core/access/accpara.cxx
b/sw/source/core/access/accpara.cxx
index b16f06a..e01e23d 100644
--- a/sw/source/core/access/accpara.cxx
+++ b/sw/source/core/access/accpara.cxx
@@ -3390,7 +3390,6 @@ sal_Bool SAL_CALL SwAccessibleParagraph::removeSelection(
sal_Int32 selectionInd
if(selectionIndex 0) return sal_False;
-bool bRet = false;
sal_Int32 nSelected = selectionIndex;
// get the selection, and test whether it affects our text node
@@ -3398,6 +3397,8 @@ sal_Bool SAL_CALL SwAccessibleParagraph::removeSelection(
sal_Int32 selectionInd
if( pCrsr != NULL )
{
+bool bRet = false;
+
// get SwPosition for my node
const SwTxtNode* pNode = GetTxtNode();
sal_uLong nHere = pNode-GetIndex();
diff --git a/sw/source/core/access/acctable.cxx
b/sw/source/core/access/acctable.cxx
index 629e08d..3582962 100644
--- a/sw/source/core/access/acctable.cxx
+++ b/sw/source/core/access/acctable.cxx
@@ -1791,11 +1791,10 @@ sal_Bool SAL_CALL SwAccessibleTable::selectRow(
sal_Int32 row )
if( isAccessibleColumnSelected( row ) )
return sal_True;
-long lCol, lColumnCount, lChildIndex;
-lColumnCount = getAccessibleColumnCount();
-for(lCol = 0; lCol lColumnCount; lCol ++)
+long lColumnCount = getAccessibleColumnCount();
+for(long lCol = 0; lCol lColumnCount; lCol ++)
{
-lChildIndex = getAccessibleIndex(row, lCol);
+long lChildIndex = getAccessibleIndex(row, lCol);
selectAccessibleChild(lChildIndex);
}
@@ -1809,12 +1808,11 @@ sal_Bool SAL_CALL SwAccessibleTable::selectColumn(
sal_Int32 column )
if( isAccessibleColumnSelected( column ) )
return sal_True;
-long lRow, lRowCount, lChildIndex;
-lRowCount = getAccessibleRowCount();
+long lRowCount =
[Bug 39440] cppcheck cleanliness
https://bugs.freedesktop.org/show_bug.cgi?id=39440 --- Comment #50 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ccaa5519cb978a640caa22ce2bcbd6c54fa44e26 fdo#39440 sw: reduce scope of local variables It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - cui/source
cui/source/options/treeopt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d2ad3d8af0f8217ba7d472630a297812d8a62b67 Author: Caolán McNamara caol...@redhat.com Date: Sun Jan 11 19:52:40 2015 -0600 fdo#87551 Category tree is too thin since conversion to .ui Measure in approx chars and not pixels. Change-Id: Ibf34083d99e0aceee2855ed10939ad3b60b8abae Reviewed-on: https://gerrit.libreoffice.org/13948 Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx index 46673d2..069eb79 100644 --- a/cui/source/options/treeopt.cxx +++ b/cui/source/options/treeopt.cxx @@ -512,6 +512,7 @@ void OfaTreeOptionsDialog::InitWidgets() Size aSize(pTabBox-LogicToPixel(Size(278, 259), MAP_APPFONT)); pTabBox-set_width_request(aSize.Width()); pTabBox-set_height_request(aSize.Height() - get_action_area()-get_preferred_size().Height()); +pTreeLB-set_width_request(pTreeLB-approximate_char_width() * 25); pTreeLB-set_height_request(pTabBox-get_height_request()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/unx
vcl/unx/gtk/a11y/atkwrapper.cxx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit 3bde8657f50b88268ffb2693cc298411fcead005
Author: Niklas Johansson sleeping.pil...@gmail.com
Date: Sun Jan 4 01:15:49 2015 +0100
fdo#86674 paragraphs have ATK_STATE_INVALID
A few states have been added in the IA2 integration. These need to be
handled somehow on linux as well. At the moment they all get the state
INVALID. Let's add the state DEFAULT that already have a equivalent.
The state MOVEABLE is causing the issues in paragraphs of LibreOffice
Writer. The state is not invalid so let's avoid reporting it at all.
There must be a cleaner way of doing this however.
Change-Id: I859439f92fe19f5050195383f43fa4af787b249e
Reviewed-on: https://gerrit.libreoffice.org/13727
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit df5fa4082cfb17c5d5be6678995689485df6d429)
Reviewed-on: https://gerrit.libreoffice.org/13947
diff --git a/vcl/unx/gtk/a11y/atkwrapper.cxx b/vcl/unx/gtk/a11y/atkwrapper.cxx
index c3b784b..552c8e3 100644
--- a/vcl/unx/gtk/a11y/atkwrapper.cxx
+++ b/vcl/unx/gtk/a11y/atkwrapper.cxx
@@ -161,12 +161,16 @@ AtkStateType mapAtkState( sal_Int16 nState )
MAP_DIRECT( TRANSIENT );
MAP_DIRECT( VERTICAL );
MAP_DIRECT( VISIBLE );
+MAP_DIRECT( DEFAULT );
// a spelling error ...
case accessibility::AccessibleStateType::DEFUNC:
type = ATK_STATE_DEFUNCT; break;
case accessibility::AccessibleStateType::MULTI_SELECTABLE:
type = ATK_STATE_MULTISELECTABLE; break;
default:
+//Mis-use ATK_STATE_LAST_DEFINED to check if a state is unmapped
+//NOTE! Do not report it
+type = ATK_STATE_LAST_DEFINED;
break;
}
@@ -535,7 +539,12 @@ wrapper_ref_state_set( AtkObject *atk_obj )
uno::Sequence sal_Int16 aStates = xStateSet-getStates();
for( sal_Int32 n = 0; n aStates.getLength(); n++ )
-atk_state_set_add_state( pSet, mapAtkState( aStates[n] ) );
+{
+// ATK_STATE_LAST_DEFINED is used to check if the state
+// is unmapped, do not report it to Atk
+if ( mapAtkState( aStates[n] ) != ATK_STATE_LAST_DEFINED )
+atk_state_set_add_state( pSet, mapAtkState( aStates[n]
) );
+}
// We need to emulate FOCUS state for menus, menu-items etc.
if( atk_obj == atk_get_focus_object() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - ucb/source
ucb/source/ucp/tdoc/tdoc_docmgr.cxx |9 ++---
ucb/source/ucp/tdoc/tdoc_docmgr.hxx |9 ++---
2 files changed, 12 insertions(+), 6 deletions(-)
New commits:
commit 8f00af819f024212c9362aa3c98000f5dff549d3
Author: Michael Stahl mst...@redhat.com
Date: Thu Jan 15 21:47:44 2015 +0100
rhbz#1163106: tdoc_ucp: fix life cycle of OfficeDocumentsCloseListener
The tdoc_ucp::OfficeDocumentsManager lives until the service manager
is disposed on shutdown, but if the database stuff isn't disposed in due
time then a document may call the notifyClosing() on the listener after
the OfficeDocumentsManager dies; probably something is leaking the
ODatabaseContext...
Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22
(cherry picked from commit 0ffa3abc7d6c0437ece30cfb1430d28ffcc9f5c1)
Reviewed-on: https://gerrit.libreoffice.org/13944
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
index f6da87a3..79e4e2b 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
@@ -74,6 +74,8 @@ void SAL_CALL
OfficeDocumentsManager::OfficeDocumentsCloseListener::notifyClosin
const lang::EventObject Source )
throw ( uno::RuntimeException, std::exception )
{
+if (!m_pManager) return; // disposed?
+
document::DocumentEvent aDocEvent;
aDocEvent.Source = Source.Source;
aDocEvent.EventName = OfficeDocumentsListener::notifyClosing;
@@ -124,6 +126,7 @@ OfficeDocumentsManager::~OfficeDocumentsManager()
// objects are actually released/destroyed upon shutdown is not defined.
And when we arrive *here*,
// OOo *is* shutting down currently, since we're held by the TDOC
provider, which is disposed
// upon shutdown.
+m_xDocCloseListener-Dispose();
}
@@ -235,7 +238,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
OnLoadFinished/OnCreate event: got no close broadcaster!
);
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-addCloseListener( m_xDocCloseListener );
+
xCloseBroadcaster-addCloseListener(m_xDocCloseListener.get());
// Propagate document closure.
OSL_ENSURE( m_pDocEventListener,
@@ -294,7 +297,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
OnUnload event: got no XCloseBroadcaster from XModel );
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-removeCloseListener(
m_xDocCloseListener );
+
xCloseBroadcaster-removeCloseListener(m_xDocCloseListener.get());
m_aDocs.erase( it );
}
@@ -501,7 +504,7 @@ void OfficeDocumentsManager::buildDocumentsList()
buildDocumentsList: got no close broadcaster! );
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-addCloseListener(
m_xDocCloseListener );
+
xCloseBroadcaster-addCloseListener(m_xDocCloseListener.get());
}
}
}
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
index 003e784..f71f0c7 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
@@ -22,6 +22,7 @@
#include map
+#include rtl/ref.hxx
#include osl/mutex.hxx
#include cppuhelper/implbase1.hxx
@@ -90,7 +91,7 @@ namespace tdoc_ucp {
{
public:
OfficeDocumentsCloseListener( OfficeDocumentsManager * pMgr )
-: m_pManager( pMgr ) {};
+: m_pManager( pMgr ) {}
// util::XCloseListener
virtual void SAL_CALL queryClosing(
@@ -107,6 +108,9 @@ namespace tdoc_ucp {
virtual void SAL_CALL disposing(
const com::sun::star::lang::EventObject Source )
throw ( com::sun::star::uno::RuntimeException, std::exception
) SAL_OVERRIDE;
+
+void Dispose() { m_pManager = 0; }
+
private:
OfficeDocumentsManager * m_pManager;
};
@@ -185,8 +189,7 @@ namespace tdoc_ucp {
com::sun::star::frame::XModuleManager2 m_xModuleMgr;
DocumentListm_aDocs;
OfficeDocumentsEventListener *
m_pDocEventListener;
-com::sun::star::uno::Reference
-com::sun::star::util::XCloseListener
m_xDocCloseListener;
+::rtl::ReferenceOfficeDocumentsCloseListener m_xDocCloseListener;
};
} // namespace tdoc_ucp
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - ucb/source
ucb/source/ucp/tdoc/tdoc_docmgr.cxx |9 ++---
ucb/source/ucp/tdoc/tdoc_docmgr.hxx |9 ++---
2 files changed, 12 insertions(+), 6 deletions(-)
New commits:
commit 4df44ecc61e2baf168bb425c96bf70fd7deb5b64
Author: Michael Stahl mst...@redhat.com
Date: Thu Jan 15 21:47:44 2015 +0100
rhbz#1163106: tdoc_ucp: fix life cycle of OfficeDocumentsCloseListener
The tdoc_ucp::OfficeDocumentsManager lives until the service manager
is disposed on shutdown, but if the database stuff isn't disposed in due
time then a document may call the notifyClosing() on the listener after
the OfficeDocumentsManager dies; probably something is leaking the
ODatabaseContext...
(cherry picked from commit 0ffa3abc7d6c0437ece30cfb1430d28ffcc9f5c1)
Conflicts:
ucb/source/ucp/tdoc/tdoc_docmgr.cxx
Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22
Reviewed-on: https://gerrit.libreoffice.org/13943
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
index 52f49b2..f2b3cac 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
@@ -74,6 +74,8 @@ void SAL_CALL
OfficeDocumentsManager::OfficeDocumentsCloseListener::notifyClosin
const lang::EventObject Source )
throw ( uno::RuntimeException, std::exception )
{
+if (!m_pManager) return; // disposed?
+
document::EventObject aDocEvent;
aDocEvent.Source = Source.Source;
aDocEvent.EventName = OfficeDocumentsListener::notifyClosing;
@@ -124,6 +126,7 @@ OfficeDocumentsManager::~OfficeDocumentsManager()
// objects are actually released/destroyed upon shutdown is not defined.
And when we arrive *here*,
// OOo *is* shutting down currently, since we're held by the TDOC
provider, which is disposed
// upon shutdown.
+m_xDocCloseListener-Dispose();
}
@@ -235,7 +238,7 @@ void SAL_CALL OfficeDocumentsManager::notifyEvent(
OnLoadFinished/OnCreate event: got no close broadcaster!
);
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-addCloseListener( m_xDocCloseListener );
+
xCloseBroadcaster-addCloseListener(m_xDocCloseListener.get());
// Propagate document closure.
OSL_ENSURE( m_pDocEventListener,
@@ -294,7 +297,7 @@ void SAL_CALL OfficeDocumentsManager::notifyEvent(
OnUnload event: got no XCloseBroadcaster from XModel );
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-removeCloseListener(
m_xDocCloseListener );
+
xCloseBroadcaster-removeCloseListener(m_xDocCloseListener.get());
m_aDocs.erase( it );
}
@@ -501,7 +504,7 @@ void OfficeDocumentsManager::buildDocumentsList()
buildDocumentsList: got no close broadcaster! );
if ( xCloseBroadcaster.is() )
-xCloseBroadcaster-addCloseListener(
m_xDocCloseListener );
+
xCloseBroadcaster-addCloseListener(m_xDocCloseListener.get());
}
}
}
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
index 36c5756..9a163b1 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.hxx
@@ -22,6 +22,7 @@
#include map
+#include rtl/ref.hxx
#include osl/mutex.hxx
#include cppuhelper/implbase1.hxx
@@ -90,7 +91,7 @@ namespace tdoc_ucp {
{
public:
OfficeDocumentsCloseListener( OfficeDocumentsManager * pMgr )
-: m_pManager( pMgr ) {};
+: m_pManager( pMgr ) {}
// util::XCloseListener
virtual void SAL_CALL queryClosing(
@@ -107,6 +108,9 @@ namespace tdoc_ucp {
virtual void SAL_CALL disposing(
const com::sun::star::lang::EventObject Source )
throw ( com::sun::star::uno::RuntimeException, std::exception
) SAL_OVERRIDE;
+
+void Dispose() { m_pManager = 0; }
+
private:
OfficeDocumentsManager * m_pManager;
};
@@ -185,8 +189,7 @@ namespace tdoc_ucp {
com::sun::star::frame::XModuleManager2 m_xModuleMgr;
DocumentListm_aDocs;
OfficeDocumentsEventListener *
m_pDocEventListener;
-com::sun::star::uno::Reference
-com::sun::star::util::XCloseListener
m_xDocCloseListener;
+::rtl::ReferenceOfficeDocumentsCloseListener m_xDocCloseListener;
};
} // namespace tdoc_ucp
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/core/uibase/dbui/dbmgr.cxx | 41 +++
1 file changed, 27 insertions(+), 14 deletions(-)
New commits:
commit e56105cfe780905864b895d337a4a848afe1fa26
Author: Michael Stahl mst...@redhat.com
Date: Thu Jan 15 17:00:13 2015 +0100
rhbz#1175027: sw: fix life cycle of SwConnectionDisposedListener_Impl
The SwDBManager is owned by SwDoc, so if the database thing is still
alive when SwDoc dies (which may or may not indicate a leak), the
listener will crash when the database stuff is eventually disposed
during shutdown.
(cherry picked from commit 4f747afae591f244164df25d96a83f417e6c0698)
Conflicts:
sw/source/core/uibase/dbui/dbmgr.cxx
Change-Id: I2bb5eb35f0a403374bc8f123b85ba2d7244016b0
Reviewed-on: https://gerrit.libreoffice.org/13935
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/core/uibase/dbui/dbmgr.cxx
b/sw/source/core/uibase/dbui/dbmgr.cxx
index 79d417d..e950854 100644
--- a/sw/source/core/uibase/dbui/dbmgr.cxx
+++ b/sw/source/core/uibase/dbui/dbmgr.cxx
@@ -206,26 +206,35 @@ void lcl_CopyCompatibilityOptions( SwWrtShell
rSourceShell, SwWrtShell rTarget
class SwConnectionDisposedListener_Impl : public cppu::WeakImplHelper1
lang::XEventListener
{
-SwDBManager rDBManager;
+private:
+SwDBManager * m_pDBManager;
virtual void SAL_CALL disposing( const EventObject Source ) throw
(RuntimeException, std::exception) SAL_OVERRIDE;
+
public:
SwConnectionDisposedListener_Impl(SwDBManager rMgr);
virtual ~SwConnectionDisposedListener_Impl();
+void Dispose() { m_pDBManager = 0; }
+
};
struct SwDBManager_Impl
{
SwDSParam* pMergeData;
AbstractMailMergeDlg* pMergeDialog;
-uno::Referencelang::XEventListener xDisposeListener;
+::rtl::ReferenceSwConnectionDisposedListener_Impl m_xDisposeListener;
SwDBManager_Impl(SwDBManager rDBManager)
:pMergeData(0)
,pMergeDialog(0)
- ,xDisposeListener(new SwConnectionDisposedListener_Impl(rDBManager))
+ , m_xDisposeListener(new SwConnectionDisposedListener_Impl(rDBManager))
{}
+
+~SwDBManager_Impl()
+{
+m_xDisposeListener-Dispose();
+}
};
static void lcl_InitNumberFormatter(SwDSParam rParam,
uno::ReferenceXDataSource xSource)
@@ -360,7 +369,7 @@ bool SwDBManager::MergeNew(const SwMergeDescriptor
rMergeDesc )
{
uno::ReferenceXComponent xComponent(pInsert-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+
xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2017,7 +2026,7 @@ uno::Reference XConnection
SwDBManager::RegisterConnection(OUString rDataSour
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2129,7 +2138,7 @@ SwDSParam* SwDBManager::FindDSData(const SwDBData rData,
bool bCreate)
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+
xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2166,7 +2175,7 @@ SwDSParam* SwDBManager::FindDSConnection(const OUString
rDataSource, bool bCre
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2933,27 +2942,31 @@ sal_Int32 SwDBManager::MergeDocuments(
SwMailMergeConfigItem rMMConfig,
return nRet;
}
-SwConnectionDisposedListener_Impl::SwConnectionDisposedListener_Impl(SwDBManager
rMgr) :
-rDBManager(rMgr)
+SwConnectionDisposedListener_Impl::SwConnectionDisposedListener_Impl(SwDBManager
rManager)
+: m_pDBManager(rManager)
{
-};
+}
SwConnectionDisposedListener_Impl::~SwConnectionDisposedListener_Impl()
{
-};
+}
void SwConnectionDisposedListener_Impl::disposing( const EventObject rSource )
throw (RuntimeException, std::exception)
{
::SolarMutexGuard aGuard;
+
+if (!m_pDBManager) return; // we're disposed too!
+
uno::ReferenceXConnection xSource(rSource.Source, UNO_QUERY);
-for(sal_uInt16 nPos = rDBManager.aDataSourceParams.size(); nPos; nPos--)
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4-0' - cui/source
cui/source/options/treeopt.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit e340f367cca07422fb415696fb729b43db221530 Author: Caolán McNamara caol...@redhat.com Date: Sun Jan 11 19:52:40 2015 -0600 fdo#87551 Category tree is too thin since conversion to .ui Measure in approx chars and not pixels. Change-Id: Ibf34083d99e0aceee2855ed10939ad3b60b8abae Reviewed-on: https://gerrit.libreoffice.org/13948 Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com (cherry picked from commit d2ad3d8af0f8217ba7d472630a297812d8a62b67) Reviewed-on: https://gerrit.libreoffice.org/13949 Reviewed-by: Jan Holesovsky ke...@collabora.com diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx index 46673d2..069eb79 100644 --- a/cui/source/options/treeopt.cxx +++ b/cui/source/options/treeopt.cxx @@ -512,6 +512,7 @@ void OfaTreeOptionsDialog::InitWidgets() Size aSize(pTabBox-LogicToPixel(Size(278, 259), MAP_APPFONT)); pTabBox-set_width_request(aSize.Width()); pTabBox-set_height_request(aSize.Height() - get_action_area()-get_preferred_size().Height()); +pTreeLB-set_width_request(pTreeLB-approximate_char_width() * 25); pTreeLB-set_height_request(pTabBox-get_height_request()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/uibase/dbui/dbmgr.cxx | 41 ++--
1 file changed, 27 insertions(+), 14 deletions(-)
New commits:
commit be13badc357b5639b8f76198dc9ff33fa6dabe88
Author: Michael Stahl mst...@redhat.com
Date: Thu Jan 15 17:00:13 2015 +0100
rhbz#1175027: sw: fix life cycle of SwConnectionDisposedListener_Impl
The SwDBManager is owned by SwDoc, so if the database thing is still
alive when SwDoc dies (which may or may not indicate a leak), the
listener will crash when the database stuff is eventually disposed
during shutdown.
Change-Id: I2bb5eb35f0a403374bc8f123b85ba2d7244016b0
(cherry picked from commit 4f747afae591f244164df25d96a83f417e6c0698)
Reviewed-on: https://gerrit.libreoffice.org/13934
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 5780001..584efa3 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -198,26 +198,35 @@ bool lcl_getCountFromResultSet( sal_Int32 rCount, const
uno::ReferenceXResultS
class SwConnectionDisposedListener_Impl : public cppu::WeakImplHelper1
lang::XEventListener
{
-SwDBManager rDBManager;
+private:
+SwDBManager * m_pDBManager;
virtual void SAL_CALL disposing( const EventObject Source ) throw
(RuntimeException, std::exception) SAL_OVERRIDE;
+
public:
SwConnectionDisposedListener_Impl(SwDBManager rMgr);
virtual ~SwConnectionDisposedListener_Impl();
+void Dispose() { m_pDBManager = 0; }
+
};
struct SwDBManager_Impl
{
SwDSParam* pMergeData;
AbstractMailMergeDlg* pMergeDialog;
-uno::Referencelang::XEventListener xDisposeListener;
+::rtl::ReferenceSwConnectionDisposedListener_Impl m_xDisposeListener;
SwDBManager_Impl(SwDBManager rDBManager)
:pMergeData(0)
,pMergeDialog(0)
- ,xDisposeListener(new SwConnectionDisposedListener_Impl(rDBManager))
+ , m_xDisposeListener(new SwConnectionDisposedListener_Impl(rDBManager))
{}
+
+~SwDBManager_Impl()
+{
+m_xDisposeListener-Dispose();
+}
};
static void lcl_InitNumberFormatter(SwDSParam rParam,
uno::ReferenceXDataSource xSource)
@@ -350,7 +359,7 @@ bool SwDBManager::MergeNew( const SwMergeDescriptor
rMergeDesc )
{
uno::ReferenceXComponent xComponent(pInsert-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+
xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2125,7 +2134,7 @@ uno::Reference XConnection
SwDBManager::RegisterConnection(OUString rDataSour
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2237,7 +2246,7 @@ SwDSParam* SwDBManager::FindDSData(const SwDBData rData,
bool bCreate)
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+
xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2274,7 +2283,7 @@ SwDSParam* SwDBManager::FindDSConnection(const OUString
rDataSource, bool bCre
{
uno::ReferenceXComponent xComponent(pFound-xConnection,
UNO_QUERY);
if(xComponent.is())
-xComponent-addEventListener(pImpl-xDisposeListener);
+xComponent-addEventListener(pImpl-m_xDisposeListener.get());
}
catch(const Exception)
{
@@ -2823,27 +2832,31 @@ uno::ReferenceXResultSet
SwDBManager::createCursor(const OUString _sDataSourc
return xResultSet;
}
-SwConnectionDisposedListener_Impl::SwConnectionDisposedListener_Impl(SwDBManager
rMgr) :
-rDBManager(rMgr)
+SwConnectionDisposedListener_Impl::SwConnectionDisposedListener_Impl(SwDBManager
rManager)
+: m_pDBManager(rManager)
{
-};
+}
SwConnectionDisposedListener_Impl::~SwConnectionDisposedListener_Impl()
{
-};
+}
void SwConnectionDisposedListener_Impl::disposing( const EventObject rSource )
throw (RuntimeException, std::exception)
{
::SolarMutexGuard aGuard;
+
+if (!m_pDBManager) return; // we're disposed too!
+
uno::ReferenceXConnection xSource(rSource.Source, UNO_QUERY);
-for(sal_uInt16 nPos = rDBManager.aDataSourceParams.size(); nPos; nPos--)
+for (size_t nPos = m_pDBManager-aDataSourceParams.size(); nPos; nPos--)
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/rhbz1180114.docx|binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx |5 +
writerfilter/source/dmapper/DomainMapper.cxx |6 ++
writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 ++-
writerfilter/source/ooxml/model.xml | 16
5 files changed, 29 insertions(+), 1 deletion(-)
New commits:
commit 7a728f882b5a66d2184dcc2fbcf291b9dbba88fe
Author: Michael Stahl mst...@redhat.com
Date: Wed Jan 14 23:01:41 2015 +0100
rhbz#1180114: writerfilter: don't crash on w:customXmlDelRangeStart etc.
We can't do anything sensible with these CustomXML elements but now we
have to handle them because.
(regression from 9dbf817fe5c5253fba0831aefa17575ae0ba3af1)
Change-Id: If4247890ff9961a77434587802670d28608a7922
(cherry picked from commit f22964e0e622af1168e241f933e5cf98e093ec2b)
Reviewed-on: https://gerrit.libreoffice.org/13914
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
b/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
new file mode 100644
index 000..23009eb
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 0082009..44876b9 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -728,6 +728,11 @@ DECLARE_OOXMLIMPORT_TEST(testN779834, n779834.docx)
// This document simply crashed the importer.
}
+DECLARE_OOXMLIMPORT_TEST(testRHBZ1180114, rhbz1180114.docx)
+{
+// This document simply crashed the importer.
+}
+
DECLARE_OOXMLIMPORT_TEST(testN779627, n779627.docx)
{
/*
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 8bc3320..44efb59 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2164,6 +2164,12 @@ void DomainMapper::sprmWithProps( Sprm rSprm,
PropertyMapPtr rContext )
case NS_ooxml::LN_CT_PPr_pPrChange:
case NS_ooxml::LN_trackchange:
case NS_ooxml::LN_EG_RPrContent_rPrChange:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlDelRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlDelRangeEnd:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveFromRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveFromRangeEnd:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveToRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveToRangeEnd:
{
HandleRedline( rSprm );
}
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 3779aa3..e2eaeec 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4623,9 +4623,10 @@ void DomainMapper_Impl::SetCurrentRedlineId( sal_Int32
sId )
{
// This should be an assert, but somebody had the smart idea to reuse
this function also for comments and whatnot,
// and in some cases the id is actually not handled, which may be in
fact a bug.
-SAL_WARN( writerfilter, !m_currentRedline.get());
if( m_currentRedline.get())
m_currentRedline-m_nId = sId;
+else
+SAL_INFO(writerfilter.dmapper, no current redline);
}
}
diff --git a/writerfilter/source/ooxml/model.xml
b/writerfilter/source/ooxml/model.xml
index 1e427b1..69ac296 100644
--- a/writerfilter/source/ooxml/model.xml
+++ b/writerfilter/source/ooxml/model.xml
@@ -24200,6 +24200,22 @@
resource name=CT_TrackChange resource=Properties tag=redline
attribute name=author tokenid=ooxml:CT_TrackChange_author/
attribute name=date tokenid=ooxml:CT_TrackChange_date/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeEnd
action=sendPropertiesWithId
[Bug 75757] remove inheritance to std::map and std::vector
https://bugs.freedesktop.org/show_bug.cgi?id=75757 --- Comment #53 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Ashod Nakashian committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d598c30d6e5a776430a3294dcde2e4ead2d65e08 fdo#75757: remove inheritance to std::vector It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/o3tl
include/o3tl/sorted_vector.hxx | 78 -
1 file changed, 46 insertions(+), 32 deletions(-)
New commits:
commit d598c30d6e5a776430a3294dcde2e4ead2d65e08
Author: Ashod Nakashian ashodnakash...@yahoo.com
Date: Mon Jan 12 18:55:03 2015 -0500
fdo#75757: remove inheritance to std::vector
sorted_vector no longer inherits from std::vector
and simplified some of the code.
Change-Id: Ie9ab93dae6865f21f62abc384ed8c166b74d15ec
Reviewed-on: https://gerrit.libreoffice.org/13881
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/include/o3tl/sorted_vector.hxx b/include/o3tl/sorted_vector.hxx
index 3a7abe0..328b101 100644
--- a/include/o3tl/sorted_vector.hxx
+++ b/include/o3tl/sorted_vector.hxx
@@ -30,29 +30,23 @@ struct find_unique;
templatetypename Value, typename Compare = std::lessValue,
templatetypename, typename class Find = find_unique
class sorted_vector
-: private std::vectorValue
{
private:
typedef FindValue, Compare Find_t;
-typedef typename std::vectorValue base_t;
+typedef typename std::vectorValue vector_t;
typedef typename std::vectorValue::iterator iterator;
public:
typedef typename std::vectorValue::const_iterator const_iterator;
typedef typename std::vectorValue::size_type size_type;
-using base_t::clear;
-using base_t::empty;
-using base_t::size;
-
// MODIFIERS
std::pairconst_iterator,bool insert( const Value x )
{
-std::pairconst_iterator, bool const ret(Find_t()(begin(), end(), x));
+std::pairconst_iterator, bool const ret(Find_t()(m_vector.begin(),
m_vector.end(), x));
if (!ret.second)
{
-const_iterator const it = base_t::insert(
-begin_nonconst() + (ret.first - begin()), x);
+const_iterator const it = m_vector.insert(m_vector.begin() +
(ret.first - m_vector.begin()), x);
return std::make_pair(it, true);
}
return std::make_pair(ret.first, false);
@@ -60,10 +54,10 @@ public:
size_type erase( const Value x )
{
-std::pairconst_iterator, bool const ret(Find_t()(begin(), end(), x));
+std::pairconst_iterator, bool const ret(Find_t()(m_vector.begin(),
m_vector.end(), x));
if (ret.second)
{
-base_t::erase(begin_nonconst() + (ret.first - begin()));
+m_vector.erase(m_vector.begin() + (ret.first - m_vector.begin()));
return 1;
}
return 0;
@@ -71,60 +65,75 @@ public:
void erase( size_t index )
{
-base_t::erase( begin_nonconst() + index );
+m_vector.erase(m_vector.begin() + index);
}
// like C++ 2011: erase with const_iterator (doesn't change sort order)
void erase(const_iterator const position)
{ // C++98 has vector::erase(iterator), so call that
-base_t::erase(begin_nonconst() + (position - begin()));
+m_vector.erase(m_vector.begin() + (position - m_vector.begin()));
}
void erase(const_iterator const first, const_iterator const last)
{
-base_t::erase(begin_nonconst() + (first - begin()),
- begin_nonconst() + (last - begin()));
+m_vector.erase(m_vector.begin() + (first - m_vector.begin()),
+ m_vector.begin() + (last - m_vector.begin()));
+}
+
+void clear()
+{
+m_vector.clear();
}
// ACCESSORS
+size_type size() const
+{
+return m_vector.size();
+}
+
+bool empty() const
+{
+return m_vector.empty();
+}
+
// Only return a const iterator, so that the vector cannot be directly
updated.
const_iterator begin() const
{
-return base_t::begin();
+return m_vector.begin();
}
// Only return a const iterator, so that the vector cannot be directly
updated.
const_iterator end() const
{
-return base_t::end();
+return m_vector.end();
}
const Value front() const
{
-return base_t::front();
+return m_vector.front();
}
const Value back() const
{
-return base_t::back();
+return m_vector.back();
}
const Value operator[]( size_t index ) const
{
-return base_t::operator[]( index );
+return m_vector.operator[]( index );
}
// OPERATIONS
const_iterator lower_bound( const Value x ) const
{
-return std::lower_bound( base_t::begin(), base_t::end(), x, Compare()
);
+return std::lower_bound( m_vector.begin(), m_vector.end(), x,
Compare() );
}
const_iterator upper_bound( const Value x ) const
{
-return std::upper_bound( base_t::begin(), base_t::end(), x, Compare()
);
+return std::upper_bound( m_vector.begin(),
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/rhbz1180114.docx|binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx |5 +
writerfilter/source/dmapper/DomainMapper.cxx |6 ++
writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 ++-
writerfilter/source/ooxml/model.xml | 16
5 files changed, 29 insertions(+), 1 deletion(-)
New commits:
commit 42c261a9e459408653dd5dae548dcc5ba619cef1
Author: Michael Stahl mst...@redhat.com
Date: Wed Jan 14 23:01:41 2015 +0100
rhbz#1180114: writerfilter: don't crash on w:customXmlDelRangeStart etc.
We can't do anything sensible with these CustomXML elements but now we
have to handle them because.
(regression from 9dbf817fe5c5253fba0831aefa17575ae0ba3af1)
Change-Id: If4247890ff9961a77434587802670d28608a7922
(cherry picked from commit f22964e0e622af1168e241f933e5cf98e093ec2b)
Reviewed-on: https://gerrit.libreoffice.org/13913
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
b/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
new file mode 100644
index 000..23009eb
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/rhbz1180114.docx
differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 27fe3d6..471095c 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -744,6 +744,11 @@ DECLARE_OOXMLIMPORT_TEST(testN779834, n779834.docx)
// This document simply crashed the importer.
}
+DECLARE_OOXMLIMPORT_TEST(testRHBZ1180114, rhbz1180114.docx)
+{
+// This document simply crashed the importer.
+}
+
DECLARE_OOXMLIMPORT_TEST(testN779627, n779627.docx)
{
/*
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index 8d4f548..ad477c5 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2196,6 +2196,12 @@ void DomainMapper::sprmWithProps( Sprm rSprm,
PropertyMapPtr rContext )
case NS_ooxml::LN_CT_PPr_pPrChange:
case NS_ooxml::LN_trackchange:
case NS_ooxml::LN_EG_RPrContent_rPrChange:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlDelRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlDelRangeEnd:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveFromRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveFromRangeEnd:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveToRangeStart:
+case NS_ooxml::LN_EG_RangeMarkupElements_customXmlMoveToRangeEnd:
{
HandleRedline( rSprm );
}
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 20bd4ce..3e7e4af 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4734,9 +4734,10 @@ void DomainMapper_Impl::SetCurrentRedlineId( sal_Int32
sId )
{
// This should be an assert, but somebody had the smart idea to reuse
this function also for comments and whatnot,
// and in some cases the id is actually not handled, which may be in
fact a bug.
-SAL_WARN( writerfilter, !m_currentRedline.get());
if( m_currentRedline.get())
m_currentRedline-m_nId = sId;
+else
+SAL_INFO(writerfilter.dmapper, no current redline);
}
}
diff --git a/writerfilter/source/ooxml/model.xml
b/writerfilter/source/ooxml/model.xml
index 925d7ac..ef288b1 100644
--- a/writerfilter/source/ooxml/model.xml
+++ b/writerfilter/source/ooxml/model.xml
@@ -17281,6 +17281,22 @@
resource name=CT_TrackChange resource=Properties
attribute name=author tokenid=ooxml:CT_TrackChange_author/
attribute name=date tokenid=ooxml:CT_TrackChange_date/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeStart
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlInsRangeEnd
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart
action=sendPropertiesWithId
sendtokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeStart
action=clearProps/
+ action name=end
tokenid=ooxml:EG_RangeMarkupElements_customXmlDelRangeEnd
action=sendPropertiesWithId
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4-0' - officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Writer.xcs |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 106ca5183a8b68c45c4739edc1572bd125702b33 Author: Jan Holesovsky ke...@collabora.com Date: Thu Jan 15 15:15:09 2015 +0100 fdo#87923: Don't hide the rulers completely - show the horizontal one. Turns out this is still useful to have, let's not be that aggressive :-) Change-Id: Ie9eb8b241594ce470238aa0b769a0afd2418e498 Reviewed-on: https://gerrit.libreoffice.org/13928 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 3502b604f383d630878441cc628000c9400f4ed4) Reviewed-on: https://gerrit.libreoffice.org/13932 Reviewed-by: Michael Stahl mst...@redhat.com diff --git a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs index 5d28555..4127fd7 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs @@ -1288,7 +1288,7 @@ descSpecifies whether rulers are displayed. Filters the values of HorizontalRuler and VerticalRuler./desc labelShow rulers/label /info - valuefalse/value + valuetrue/value /prop prop oor:name=HorizontalRuler oor:type=xs:boolean oor:nillable=false !-- OldPath: Writer/Layout/Window -- @@ -1363,7 +1363,7 @@ descSpecifies whether the vertical ruler is displayed./desc labelVertical Ruler/label /info - valuetrue/value + valuefalse/value /prop prop oor:name=IsVerticalRulerRight oor:type=xs:boolean oor:nillable=false !-- UIHints: Tools - Options - Text document - Layout - [Section] Window -- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/textsh1.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 4f4dcd527ee4ef7365389b5a70d0f199263628e7
Author: Niklas Johansson sleeping.pil...@gmail.com
Date: Thu Jan 15 14:43:21 2015 +0100
fdo#86844 - CONTEXT MENU: Remove hyperlink not accessible
At the moment Remove hyperlink is only shown when text is selected
together with a hyperlink but not when you right click directly on
a link. Let's reuse the logic from when edit hyperlink should be shown
and append it to the currently working case where text and link is
selected.
Change-Id: I2524f1c3037f3101d24e592eadf2e7d5d66ab4f9
Reviewed-on: https://gerrit.libreoffice.org/13926
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index 9a6bfa6..970fad9 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1674,7 +1674,9 @@ void SwTextShell::GetState( SfxItemSet rSet )
rSh.GetCurAttr(aSet);
// If a hyperlink is selected, either alone or along with
other text...
-if(aSet.GetItemState( RES_TXTATR_INETFMT, true ) !=
SfxItemState::DONTCARE || rSh.HasReadonlySel())
+if ((aSet.GetItemState(RES_TXTATR_INETFMT, true)
SfxItemState::SET
+aSet.GetItemState(RES_TXTATR_INETFMT, true) !=
SfxItemState::DONTCARE) ||
+rSh.HasReadonlySel())
{
rSet.DisableItem(nWhich);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/guide/startcenter.xhp | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) New commits: commit 3b44898f1098b7b3cc34028d60761135ae95dae2 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Jan 14 16:05:01 2015 +0100 remove newlines from help texts, they make no sense Change-Id: Id11d38addb547fc1d430bf568b13b03c06fa1781 Reviewed-on: https://gerrit.libreoffice.org/13910 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/source/text/shared/guide/startcenter.xhp b/source/text/shared/guide/startcenter.xhp index 2544df5..ea1a448 100644 --- a/source/text/shared/guide/startcenter.xhp +++ b/source/text/shared/guide/startcenter.xhp @@ -49,8 +49,7 @@ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/impress_all id=bm_id102220091057270 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/database_all id=bm_id102220091057437 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/math_all id=bm_id1022200910575575 localize=false/ -paragraph xml-lang=en-US id=par_id0820200803104810 role=paragraph l10n=NEWahelp hid=.The document icons each open a new document -of the specified type./ahelp/paragraph +paragraph xml-lang=en-US id=par_id0820200803104810 role=paragraph l10n=NEWahelp hid=.The document icons each open a new document of the specified type./ahelp/paragraph list type=ordered listitem paragraph xml-lang=en-US id=par_id0820200803104978 role=paragraph l10n=NEW @@ -83,13 +82,7 @@ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/open_all id=bm_id1022200910595546 localize=false/ paragraph xml-lang=en-US id=par_id1022200911011975 role=paragraph l10n=NEWahelp hid=. visibility=hiddenThe Open a Document icon presents a file open dialog./ahelp/paragraph paragraph xml-lang=en-US id=par_id082020080310500 role=paragraph l10n=NEWThe emphOpen a document/emph icon presents a link href=text/shared/guide/doc_open.xhpfile open/link dialog./paragraphcommentthe four icons show a short explanation already/comment -paragraph xml-lang=en-US id=par_id0820200802525413 role=paragraph l10n=NEW - The right pane contains thumbnails of the most recent documents you opened. Hover your mouse over the thumbnail to highlight the document, display a tip about the document location - and display an icon on the top right to delete the thumbnail from the pane and from the recent files list. - Click on the thumbnail to open the document underneath. - /paragraph -paragraph role=warning xml-lang=en-US id=par_id0820200802626413 l10n=NEW - Not every file type will display a thumbnail image of its content. Instead, you may see a large icon used by your computer for that filetype. - /paragraph +paragraph xml-lang=en-US id=par_id0820200802525413 role=paragraph l10n=NEWThe right pane contains thumbnails of the most recent documents you opened. Hover your mouse over the thumbnail to highlight the document, display a tip about the document location and display an icon on the top right to delete the thumbnail from the pane and from the recent files list. Click on the thumbnail to open the document underneath./paragraph +paragraph role=warning xml-lang=en-US id=par_id0820200802626413 l10n=NEWNot every file type will display a thumbnail image of its content. Instead, you may see a large icon used by your computer for that filetype./paragraph /body /helpdocument ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/05020300.xhp |4 +--- source/text/shared/01/05040300.xhp |3 +-- source/text/shared/01/05040400.xhp |5 ++--- source/text/shared/optionen/01010200.xhp |7 +-- source/text/simpress/01/0213.xhp |3 +-- 5 files changed, 6 insertions(+), 16 deletions(-) New commits: commit 59676afe325ca7cf023a6ecbfa63dc69955d353a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Jan 14 19:09:49 2015 +0100 remove more unnecessary newlines Change-Id: I9035a701b0045f30949ebef1920ca05f5244073e Reviewed-on: https://gerrit.libreoffice.org/13911 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/source/text/shared/01/05020300.xhp b/source/text/shared/01/05020300.xhp index 9363b55..066cf46 100644 --- a/source/text/shared/01/05020300.xhp +++ b/source/text/shared/01/05020300.xhp @@ -77,9 +77,7 @@ bookmark xml-lang=en-US branch=hid/cui/ui/numberingformatpage/languagelb id=bm_id3148797 localize=false/ paragraph xml-lang=en-US id=hd_id3154071 role=heading level=2 l10n=U oldref=23Language/paragraph - paragraph xml-lang=en-US id=par_id3154138 role=paragraph l10n=U oldref=24ahelp hid=cui/ui/numberingformatpage/languagelbSpecifies the language setting for the selected switchinline select=applcaseinline select=CALCcells -/caseinlinedefaultinlinefields/defaultinline/switchinline. With the language set to emphAutomatic/emph, $[officename] automatically applies the number formats associated with the system default language. Select any language to fix the settings for the selected switchinline select=applcaseinline select=CALCcells -/caseinlinedefaultinlinefields/defaultinline/switchinline./ahelp/paragraph + paragraph xml-lang=en-US id=par_id3154138 role=paragraph l10n=U oldref=24ahelp hid=cui/ui/numberingformatpage/languagelbSpecifies the language setting for the selected switchinline select=applcaseinline select=CALCcells /caseinlinedefaultinlinefields/defaultinline/switchinline. With the language set to emphAutomatic/emph, $[officename] automatically applies the number formats associated with the system default language. Select any language to fix the settings for the selected switchinline select=applcaseinline select=CALCcells /caseinlinedefaultinlinefields/defaultinline/switchinline./ahelp/paragraph paragraph xml-lang=en-US id=par_id3157320 role=paragraph l10n=U oldref=102The language setting ensures that date and currency formats are preserved even when the document is opened in an operating system that uses a different default language setting./paragraph bookmark xml-lang=en-US branch=hid/cui/ui/numberingformatpage/sourceformat id=bm_id3145747 localize=false/ diff --git a/source/text/shared/01/05040300.xhp b/source/text/shared/01/05040300.xhp index fed4893..a97de9d 100644 --- a/source/text/shared/01/05040300.xhp +++ b/source/text/shared/01/05040300.xhp @@ -63,8 +63,7 @@ bookmark xml-lang=en-US branch=hid/svx/ui/headfootformatpage/checkSameFP id=bm_id3150544 localize=false/ paragraph xml-lang=en-US id=hd_id3154937 role=heading level=3 l10n=U oldref=21Same content on first page/paragraph -paragraph xml-lang=en-US id=par_id3154939 role=paragraph l10n=CHG oldref=22ahelp hid=svx/ui/headfootformatpage/checkSameFP -First and even/odd pages share the same content./ahelp/paragraph +paragraph xml-lang=en-US id=par_id3154939 role=paragraph l10n=CHG oldref=22ahelp hid=svx/ui/headfootformatpage/checkSameFPFirst and even/odd pages share the same content./ahelp/paragraph bookmark xml-lang=en-US branch=hid/svx/ui/headfootformatpage/spinMargLeft id=bm_id3154153 localize=false/ paragraph xml-lang=en-US id=hd_id3145202 role=heading level=3 l10n=U oldref=17Left margin/paragraph diff --git a/source/text/shared/01/05040400.xhp b/source/text/shared/01/05040400.xhp index 036fcde..5866aa1 100644 --- a/source/text/shared/01/05040400.xhp +++ b/source/text/shared/01/05040400.xhp @@ -62,8 +62,7 @@ bookmark xml-lang=en-US branch=hid/svx:CheckBox:RID_SVXPAGE_FOOTER:CB_SHARED_FIRST id=bm_id3150544 localize=false/ paragraph xml-lang=en-US id=hd_id3154937 role=heading level=3 l10n=U oldref=21Same content on first page/paragraph -paragraph xml-lang=en-US id=par_id3154939 role=paragraph l10n=CHG oldref=22ahelp hid=SVX:CHECKBOX:RID_SVXPAGE_FOOTER:CB_SHARED_FIRST -First and even/odd pages share the same content./ahelp/paragraph +paragraph xml-lang=en-US id=par_id3154939 role=paragraph l10n=CHG oldref=22ahelp hid=SVX:CHECKBOX:RID_SVXPAGE_FOOTER:CB_SHARED_FIRSTFirst and even/odd pages share the same content./ahelp/paragraph bookmark xml-lang=en-US branch=hid/svx:MetricField:RID_SVXPAGE_FOOTER:ED_LMARGIN id=bm_id3149457 localize=false/ paragraph xml-lang=en-US id=hd_id3147264 role=heading level=3 l10n=U oldref=16Left margin/paragraph @@ -106,4 +105,4 @@ First and even/odd
[Libreoffice-commits] core.git: 2 commits - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b0eae373b02a694ed26944d20a77e7b4467074d7 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Jan 14 19:09:49 2015 +0100 Updated core Project: help 59676afe325ca7cf023a6ecbfa63dc69955d353a remove more unnecessary newlines Change-Id: I9035a701b0045f30949ebef1920ca05f5244073e Reviewed-on: https://gerrit.libreoffice.org/13911 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/helpcontent2 b/helpcontent2 index 3b44898..59676af 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3b44898f1098b7b3cc34028d60761135ae95dae2 +Subproject commit 59676afe325ca7cf023a6ecbfa63dc69955d353a commit 1c7b4e369b22eba6cc5e94f421f2ff21cebbb5e5 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed Jan 14 16:05:01 2015 +0100 Updated core Project: help 3b44898f1098b7b3cc34028d60761135ae95dae2 remove newlines from help texts, they make no sense Change-Id: Id11d38addb547fc1d430bf568b13b03c06fa1781 Reviewed-on: https://gerrit.libreoffice.org/13910 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/helpcontent2 b/helpcontent2 index bab9e3a..3b44898 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit bab9e3aa54942efff0b2d9b013ae700cab8611f3 +Subproject commit 3b44898f1098b7b3cc34028d60761135ae95dae2 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source cppuhelper/source include/cppuhelper
comphelper/source/property/propstate.cxx | 15 ++-
cppuhelper/source/propshlp.cxx | 10 --
include/cppuhelper/propshlp.hxx |6 +-
3 files changed, 15 insertions(+), 16 deletions(-)
New commits:
commit d3ce5b298e3f5cc58256ba80f5d3f361618c4820
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jan 16 10:19:36 2015 +0100
Fix getTypes() of OPropertySetHelper and derived
...broken with 60d60caf99a40ca0c3891bf230c5a1fdbae5f49c Renamed
XPropertySet2
to XPropertySetOption et al
Change-Id: I684736ffafc4642548b7c24171cc52c1acb32252
diff --git a/comphelper/source/property/propstate.cxx
b/comphelper/source/property/propstate.cxx
index d8f53b5..8f6b907 100644
--- a/comphelper/source/property/propstate.cxx
+++ b/comphelper/source/property/propstate.cxx
@@ -55,15 +55,12 @@ namespace comphelper
css::uno::Sequencecss::uno::Type OPropertyStateHelper::getTypes()
{
-::com::sun::star::uno::Sequence ::com::sun::star::uno::Type
aTypes(4);
-::com::sun::star::uno::Type* pTypes = aTypes.getArray();
-// base class types
-pTypes[0] = cppu::UnoTypecom::sun::star::beans::XPropertySet::get();
-pTypes[1] =
cppu::UnoTypecom::sun::star::beans::XMultiPropertySet::get();
-pTypes[2] =
cppu::UnoTypecom::sun::star::beans::XFastPropertySet::get();
-// my own type
-pTypes[3] =
cppu::UnoTypecom::sun::star::beans::XPropertyState::get();
-return aTypes;
+return css::uno::Sequencecss::uno::Type({
+cppu::UnoTypecss::beans::XPropertySet::get(),
+cppu::UnoTypecss::beans::XMultiPropertySet::get(),
+cppu::UnoTypecss::beans::XFastPropertySet::get(),
+cppu::UnoTypecss::beans::XPropertySetOption::get(),
+cppu::UnoTypecss::beans::XPropertyState::get()});
}
OPropertyStateHelper::OPropertyStateHelper(
diff --git a/cppuhelper/source/propshlp.cxx b/cppuhelper/source/propshlp.cxx
index d19e656..509019c 100644
--- a/cppuhelper/source/propshlp.cxx
+++ b/cppuhelper/source/propshlp.cxx
@@ -231,12 +231,10 @@ Any OPropertySetHelper2::queryInterface( const
::com::sun::star::uno::Type rTy
::com::sun::star::uno::Sequence ::com::sun::star::uno::Type
OPropertySetHelper::getTypes()
throw (RuntimeException)
{
-Sequence ::com::sun::star::uno::Type aTypes( 4 );
-aTypes[ 0 ] = XPropertySet::static_type();
-aTypes[ 1 ] = XPropertySetOption::static_type();
-aTypes[ 2 ] = XMultiPropertySet::static_type();
-aTypes[ 3 ] = XFastPropertySet::static_type();
-return aTypes;
+return css::uno::Sequencecss::uno::Type({
+UnoTypecss::beans::XPropertySet::get(),
+UnoTypecss::beans::XMultiPropertySet::get(),
+UnoTypecss::beans::XFastPropertySet::get()});
}
// ComponentHelper
diff --git a/include/cppuhelper/propshlp.hxx b/include/cppuhelper/propshlp.hxx
index ec769e3..8cf0159 100644
--- a/include/cppuhelper/propshlp.hxx
+++ b/include/cppuhelper/propshlp.hxx
@@ -686,7 +686,11 @@ protected:
/**
OPropertySetHelper plus XPropertySetOption
- */
+
+ @attention
+ The getTypes() inherited from OPropertysetHelper does not cover
+ XPropertySetOption.
+*/
class CPPUHELPER_DLLPUBLIC OPropertySetHelper2 : public OPropertySetHelper,
public ::com::sun::star::beans::XPropertySetOption
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/fudraw.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c6a1a8e6f8d97d24b4063909ef22824875326e28
Author: Trent MacAlpine tmac...@gmail.com
Date: Tue Jan 13 21:48:47 2015 -0500
fdo#88339 Fixed Draw/Impress constrained image movement
Change-Id: Ib45cb3167acfd4f409b05a0e1b8d37af36fd6725
Reviewed-on: https://gerrit.libreoffice.org/13900
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sd/source/ui/func/fudraw.cxx b/sd/source/ui/func/fudraw.cxx
index e375341..a68fb1a 100644
--- a/sd/source/ui/func/fudraw.cxx
+++ b/sd/source/ui/func/fudraw.cxx
@@ -255,8 +255,8 @@ bool FuDraw::MouseMove(const MouseEvent rMEvt)
if (mpView-IsAction())
{
-// #i33136#
-if(bIsImageSelected || (bRestricted doConstructOrthogonal()))
+// #i33136# and fdo#88339
+if(bRestricted (bIsImageSelected || doConstructOrthogonal()))
{
// Scale proportionally by default:
// rectangle-quadrat, ellipse-circle, Images etc.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4-0' - connectivity/source
connectivity/source/drivers/postgresql/pq_statement.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 27757ce998406d9cc4848720c2dc3e4f72aa0e54 Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Jan 15 12:18:03 2015 +0100 PostgreSQL statement: deliver promised XMultipleResults interface Change-Id: I0bb6df332aa0ae96bba38626b2626f880490 Reviewed-on: https://gerrit.libreoffice.org/13924 Reviewed-by: Michael Stahl mst...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/connectivity/source/drivers/postgresql/pq_statement.cxx b/connectivity/source/drivers/postgresql/pq_statement.cxx index 5c20b9a..9b5fbe5 100644 --- a/connectivity/source/drivers/postgresql/pq_statement.cxx +++ b/connectivity/source/drivers/postgresql/pq_statement.cxx @@ -199,6 +199,7 @@ Any Statement::queryInterface( const Type reqType ) throw (RuntimeException, s static_cast com::sun::star::sdbc::XResultSetMetaDataSupplier * ( this ), static_cast XCloseable * ( this ), static_cast XPropertySet * ( this ), +static_cast XMultipleResults * ( this ), static_cast XMultiPropertySet * ( this ), static_cast XGeneratedResultSet * ( this ), static_cast XFastPropertySet * ( this ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3-6' - connectivity/source
connectivity/source/drivers/postgresql/pq_statement.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 345c82aa2d7b7f551faa666475d1c9e351ed6f0e Author: Lionel Elie Mamane lio...@mamane.lu Date: Thu Jan 15 12:18:03 2015 +0100 PostgreSQL statement: deliver promised XMultipleResults interface Change-Id: I0bb6df332aa0ae96bba38626b2626f880490 Reviewed-on: https://gerrit.libreoffice.org/13922 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com diff --git a/connectivity/source/drivers/postgresql/pq_statement.cxx b/connectivity/source/drivers/postgresql/pq_statement.cxx index 23727db..03f4b17 100644 --- a/connectivity/source/drivers/postgresql/pq_statement.cxx +++ b/connectivity/source/drivers/postgresql/pq_statement.cxx @@ -199,6 +199,7 @@ Any Statement::queryInterface( const Type reqType ) throw (RuntimeException, s static_cast com::sun::star::sdbc::XResultSetMetaDataSupplier * ( this ), static_cast XCloseable * ( this ), static_cast XPropertySet * ( this ), +static_cast XMultipleResults * ( this ), static_cast XMultiPropertySet * ( this ), static_cast XGeneratedResultSet * ( this ), static_cast XFastPropertySet * ( this ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 43157] Clean up OSL_ASSERT, DBG_ASSERT, etc.
https://bugs.freedesktop.org/show_bug.cgi?id=43157 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||ashodnakash...@yahoo.com --- Comment #31 from Stephan Bergmann sberg...@redhat.com --- *** Bug 88309 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-4.3-1'
Tag 'cp-4.3-1' created by Andras Timar andras.ti...@collabora.com at 2015-01-16 09:36 -0800 cp-4.3-1 Changes since cp-4.3-branch-point-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-4.3-1'
Tag 'cp-4.3-1' created by Andras Timar andras.ti...@collabora.com at 2015-01-16 09:36 -0800 cp-4.3-1 Changes since cp-4.3-branch-point-436: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-4.3-1'
Tag 'cp-4.3-1' created by Andras Timar andras.ti...@collabora.com at 2015-01-16 09:36 -0800 cp-4.3-1 Changes since cp-4.3-branch-point-6: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-4.3-1'
Tag 'cp-4.3-1' created by Andras Timar andras.ti...@collabora.com at 2015-01-16 09:36 -0800 cp-4.3-1 Changes since libreoffice-4.3.0.0.beta1-9: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Mapping of AccessibleStateType to AtkStateType
On Sun, 2015-01-04 at 02:18 +0100, Niklas Johansson wrote: The added states are: MOVEABLE DEFAULT OFFSCREEN COLLAPSE I did a small patch to fix DEFAULT and ignore MOVABLE. MOVABLE is causing the issue reported in the bug. https://gerrit.libreoffice.org/#/c/13727 However the ignoring part is ugly. But I'm unsure of how to do it cleanly. At least ATK_STATE_INVALID does not get set if the state type is unmapped. There are some comments in offapi/com/sun/star/accessibility/AccessibleStateType.idl which suggest MOVEABLE doesn't have an atk equivalent which sounds to me that it should be simply ignored. While OFFSCREEN and COLLAPSE[D] have some suggested equivalents for atk. But presumably those equivalents are also already covered and unchanged so these could safely be ignored for atk too. As a side note the added state COLLAPSE should probably be COLLAPSED. Could this be changed or is the name set in stone? If it is possible to change I need to verify that it really should be COLLAPSED and not COLLAPSE. You should be able to change that as the a11y api is unpublished. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docdesc.cxx | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
New commits:
commit 82276525ada3112d566d0fbf1859788b7867af0e
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jan 15 20:50:50 2015 +
coverity#1264391 help coverity out wrt Logically dead code
This reverts commit 95f7a01621dd5cd62190c334fcdf02e3941fdcab.
Change-Id: I1712553e592f1313a2591f7dae92453a4a85b7f2
diff --git a/sw/source/core/doc/docdesc.cxx b/sw/source/core/doc/docdesc.cxx
index 4f3801d..d083b43 100644
--- a/sw/source/core/doc/docdesc.cxx
+++ b/sw/source/core/doc/docdesc.cxx
@@ -212,12 +212,29 @@ static void lcl_DescSetAttr( const SwFrmFmt rSource,
SwFrmFmt rDest,
rDest.SetPoolHlpFileId( rSource.GetPoolHlpFileId() );
}
+namespace
+{
+SwFrmFmt getFrmFmt(SwPageDesc rDesc, bool bLeft, bool bFirst)
+{
+if (bFirst)
+{
+if (bLeft)
+return rDesc.GetFirstLeft();
+return rDesc.GetFirstMaster();
+}
+return rDesc.GetLeft();
+}
+
+const SwFrmFmt getConstFrmFmt(const SwPageDesc rDesc, bool bLeft, bool
bFirst)
+{
+return getFrmFmt(const_castSwPageDesc(rDesc), bLeft, bFirst);
+}
+}
+
void SwDoc::CopyMasterHeader(const SwPageDesc rChged, const SwFmtHeader
rHead, SwPageDesc rDesc, bool bLeft, bool bFirst)
{
assert(bLeft || bFirst);
-SwFrmFmt rDescFrmFmt = (bFirst)
-? (bLeft) ? rDesc.GetFirstLeft() : rDesc.GetFirstMaster()
-: rDesc.GetLeft();
+SwFrmFmt rDescFrmFmt = getFrmFmt(rDesc, bLeft, bFirst);
if (bFirst bLeft)
{
// special case: always shared with something
@@ -252,9 +269,7 @@ void SwDoc::CopyMasterHeader(const SwPageDesc rChged,
const SwFmtHeader rHead,
if (!aCnt.GetCntntIdx())
{
-const SwFrmFmt rChgedFrmFmt = (bFirst)
-? (bLeft) ? rChged.GetFirstLeft() : rChged.GetFirstMaster()
-: rChged.GetLeft();
+const SwFrmFmt rChgedFrmFmt = getConstFrmFmt(rChged, bLeft,
bFirst);
rDescFrmFmt.SetFmtAttr( rChgedFrmFmt.GetHeader() );
}
else if ((*aRCnt.GetCntntIdx() == *aCnt.GetCntntIdx()) ||
@@ -292,9 +307,7 @@ void SwDoc::CopyMasterHeader(const SwPageDesc rChged,
const SwFmtHeader rHead,
void SwDoc::CopyMasterFooter(const SwPageDesc rChged, const SwFmtFooter
rFoot, SwPageDesc rDesc, bool bLeft, bool bFirst)
{
assert(bLeft || bFirst);
-SwFrmFmt rDescFrmFmt = (bFirst)
-? (bLeft) ? rDesc.GetFirstLeft() : rDesc.GetFirstMaster()
-: rDesc.GetLeft();
+SwFrmFmt rDescFrmFmt = getFrmFmt(rDesc, bLeft, bFirst);
if (bFirst bLeft)
{
// special case: always shared with something
@@ -328,9 +341,7 @@ void SwDoc::CopyMasterFooter(const SwPageDesc rChged,
const SwFmtFooter rFoot,
const SwFmtCntnt aLCnt = rFmtFoot.GetFooterFmt()-GetCntnt();
if( !aLCnt.GetCntntIdx() )
{
-const SwFrmFmt rChgedFrmFmt = (bFirst)
-? (bLeft) ? rChged.GetFirstLeft() : rChged.GetFirstMaster()
-: rChged.GetLeft();
+const SwFrmFmt rChgedFrmFmt = getConstFrmFmt(rChged, bLeft,
bFirst);
rDescFrmFmt.SetFmtAttr( rChgedFrmFmt.GetFooter() );
}
else if ((*aRCnt.GetCntntIdx() == *aLCnt.GetCntntIdx()) ||
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 5 commits - android/experimental android/mobile-config.py
android/experimental/LOAndroid3/Makefile
|2 -
android/experimental/LOAndroid3/src/java/org/libreoffice/LOEvent.java
|8 +
android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitShell.java
| 14
android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
|3 +
android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitTileProvider.java
| 16 ++
android/experimental/LOAndroid3/src/java/org/libreoffice/LibreOfficeMainActivity.java
| 15 +
android/experimental/LOAndroid3/src/java/org/libreoffice/MockTileProvider.java
|5 +++
android/experimental/LOAndroid3/src/java/org/libreoffice/TileProvider.java
|3 +
android/mobile-config.py
|1
9 files changed, 65 insertions(+), 2 deletions(-)
New commits:
commit 49255bdc4137f5c5a8bbf67444175c32503a3924
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Fri Jan 16 19:03:39 2015 +0900
android: Add key events in TileProvider pass key events to LOK
Change-Id: Id0a93f1c4199082b3c67802955082d04831ec124
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
index 32cb43c..3b7f657 100644
--- a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
+++ b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
@@ -147,6 +147,9 @@ public class LOKitThread extends Thread implements
TileProvider.TileInvalidation
case LOEvent.TOUCH:
touch(event.mTouchType, event.mMotionEvent);
break;
+case LOEvent.KEY_PRESS:
+mTileProvider.keyPress(event.mKeyEvent);
+break;
}
}
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitTileProvider.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitTileProvider.java
index b7dee3b..0970bbb 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitTileProvider.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitTileProvider.java
@@ -3,6 +3,7 @@ package org.libreoffice;
import android.graphics.Bitmap;
import android.graphics.RectF;
import android.util.Log;
+import android.view.KeyEvent;
import org.libreoffice.kit.DirectBufferAllocator;
import org.libreoffice.kit.Document;
@@ -272,6 +273,11 @@ public class LOKitTileProvider implements TileProvider,
Document.MessageCallback
this.tileInvalidationCallback = tileInvalidationCallback;
}
+@Override
+public void keyPress(KeyEvent keyEvent) {
+mOffice.postKeyEvent(Office.KEY_PRESS, keyEvent.getKeyCode());
+}
+
@Override
protected void finalize() throws Throwable {
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/MockTileProvider.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/MockTileProvider.java
index 16772d0..15332a7 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/MockTileProvider.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/MockTileProvider.java
@@ -1,6 +1,7 @@
package org.libreoffice;
import android.graphics.Bitmap;
+import android.view.KeyEvent;
import org.mozilla.gecko.gfx.BufferedCairoImage;
import org.mozilla.gecko.gfx.CairoImage;
@@ -87,6 +88,10 @@ public class MockTileProvider implements TileProvider {
}
@Override
+public void keyPress(KeyEvent keyEvent) {
+}
+
+@Override
public void changePart(int partIndex) {
}
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/TileProvider.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/TileProvider.java
index faa55a8..da0d0f4 100644
--- a/android/experimental/LOAndroid3/src/java/org/libreoffice/TileProvider.java
+++ b/android/experimental/LOAndroid3/src/java/org/libreoffice/TileProvider.java
@@ -3,6 +3,7 @@ package org.libreoffice;
import android.graphics.Bitmap;
import android.graphics.RectF;
+import android.view.KeyEvent;
import org.mozilla.gecko.gfx.CairoImage;
import org.mozilla.gecko.gfx.IntSize;
@@ -33,6 +34,8 @@ public interface TileProvider {
void registerInvalidationCallback(TileProvider.TileInvalidationCallback
tileInvalidationCallback);
+void keyPress(KeyEvent keyEvent);
+
/**
* Callback to retrieve invalidation calls
*/
commit 743bdfda78a84a2830c024a608bdf2a22ba4420c
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Fri Jan 16 19:01:04 2015 +0900
android: Add needed services for editing.
Change-Id: I29acea58b4e18efcf33b51361812c3f7532282ab
diff --git a/android/experimental/LOAndroid3/Makefile
b/android/experimental/LOAndroid3/Makefile
index
Re: enabling optimizations (-Og) with --enable-debug
On 01/15/2015 01:47 PM, Luke Deller wrote: Yesterday I floated the idea on IRC of using this with --enable-debug rather than -O0 if available, and some feedback was that it enables gcc to report extra warnings which would be a good thing. It /potentially/ enables GCC to emit more (useful) warnings, as some of GCC's warnings are known to be only emitted when certain optimizations are enabled. The benefit of having such warnings also emitted during debug builds would be that developers would be made aware of them more quickly. (As it turns out, GCC unfortunately also emits some false warnings at -Og which it would not emit at neither -O0 nor -O2. That, of course, is not considered useful.) So I guess this means we couldn't incorporate -Og until all these new warnings are fixed right? Yes, please get any warning fallout addressed beforehand (and I see you're already doing that with https://gerrit.libreoffice.org/#/c/13929/ Avoid false 'maybe-uninitialized' warnings). Any other thoughts on whether this is a good idea to pursue? One fear was that it might slow down compilation, but it doesn't actually seem to slow down make clean make much at all for me. I'll get some proper timing measurements. My -Og potentially makes the build time longer, but [...] was meant in direct response to your to make it run faster, make the build smaller (which, in turn, was a reply to why would one want to enable optimizations in a debug build?). I would not worry too much if it actually does make the build a little slower, but measuring it of course can't hurt. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: enabling optimizations (-Og) with --enable-debug
On 01/15/2015 10:47 PM, Ashod Nakashian wrote: It probably is, but with some caveats. My main concern would be unnecessary code pollution. It's true that these warnings could be really useful. They might hint at actual issues in some cases (for example an unhandled error in the unused-result case). But suppressing them can also muddle the code. I rather 'fix' the cases that might hide real issues rather than suppress/silence noise just for its own sake. Our OOo/LO history has shown us that compiler warnings are only helpful for development if they break the build. Unfortunately, that means that you occasionally need to find a way to work around a false warning unhelpfully emitted by some compiler. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - libreofficekit/source
libreofficekit/source/gtk/lokdocview.c | 45 ++---
1 file changed, 25 insertions(+), 20 deletions(-)
New commits:
commit 968759561aa56c036c0ae7b703f3acb45f12a668
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Jan 15 15:16:48 2015 +0100
lokdocview: add LOKDocViewCallbackData
So that the callback code running on the main thread can be aware of the
event type and payload (necessary in the future to do partial repaints).
Change-Id: I790b2ce0b6f9f88ba71d94a17bf0c8fc1b567c5f
diff --git a/libreofficekit/source/gtk/lokdocview.c
b/libreofficekit/source/gtk/lokdocview.c
index 5e6e790..d9be2df 100644
--- a/libreofficekit/source/gtk/lokdocview.c
+++ b/libreofficekit/source/gtk/lokdocview.c
@@ -178,20 +178,30 @@ void renderDocument( LOKDocView* pDocView )
}
}
+/// Callback data, allocated in lok_docview_callback_worker(), released in
lok_docview_callback().
+typedef struct
+{
+int m_nType;
+const char* m_pPayload;
+LOKDocView* m_pDocView;
+}
+LOKDocViewCallbackData;
+
/// Invoked on the main thread if lok_docview_callback_worker() requests so.
static gboolean lok_docview_callback(gpointer pData)
{
-LOKDocView* pDocView = pData;
-
-#if ! GTK_CHECK_VERSION(2,12,0)
-GDK_THREADS_ENTER();
-#endif
+LOKDocViewCallbackData* pCallback = pData;
-renderDocument(pDocView);
+switch (pCallback-m_nType)
+{
+case LOK_CALLBACK_INVALIDATE_TILES:
+renderDocument(pCallback-m_pDocView);
+break;
+default:
+break;
+}
-#if ! GTK_CHECK_VERSION(2,12,0)
-GDK_THREADS_LEAVE();
-#endif
+g_free(pCallback);
return G_SOURCE_REMOVE;
}
@@ -200,20 +210,15 @@ static void lok_docview_callback_worker(int nType, const
char* pPayload, void* p
{
LOKDocView* pDocView = pData;
-switch (nType)
-{
-case LOK_CALLBACK_INVALIDATE_TILES:
-// TODO for now just always render the document.
-(void)pPayload;
+LOKDocViewCallbackData* pCallback = g_new0(LOKDocViewCallbackData, 1);
+pCallback-m_nType = nType;
+pCallback-m_pPayload = pPayload;
+pCallback-m_pDocView = pDocView;
#if GTK_CHECK_VERSION(2,12,0)
-gdk_threads_add_idle(lok_docview_callback, pDocView);
+gdk_threads_add_idle(lok_docview_callback, pCallback);
#else
-g_idle_add(lok_docview_callback, pDocView);
+g_idle_add(lok_docview_callback, pDocView);
#endif
-break;
-default:
-break;
-}
}
SAL_DLLPUBLIC_EXPORT gboolean lok_docview_open_document( LOKDocView* pDocView,
char* pPath )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sal
include/sal/config.h |5 + 1 file changed, 5 insertions(+) New commits: commit 234e45bf1d27484b72e73fe327b1e92fda1933f1 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jan 16 11:29:21 2015 +0100 Revert never wonder if sun is not sun This reverts commit 06a5b619a76c96783ee67bdcfd21f203d3ddb53c, which broke Solaris/Illumos builds for no good reason, cf. mail thread starting at http://lists.freedesktop.org/archives/libreoffice/2015-January/065844.html 4.4.0.1 build error on sal/types.h on solaris/illumos. Conflicts: include/sal/config.h Change-Id: I063453ee1115ae3f97e2835828800c74e3cb5e48 diff --git a/include/sal/config.h b/include/sal/config.h index 93a4898..c459365 100644 --- a/include/sal/config.h +++ b/include/sal/config.h @@ -86,6 +86,11 @@ #define SAL_CONFIGFILE( name ) name rc #endif +#ifdef sun +#undef sun +#define sun sun +#endif + #if defined __clang__ #if __has_warning(-Wpotentially-evaluated-expression) #pragma GCC diagnostic ignored -Wpotentially-evaluated-expression ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Minutes of the Design Hangout: 2015-01-14
* Present: Heiko, Jay, Kendy, Mattias, Stuart * Pending Action Items: + Jay: Ask what is the plan with the templates on the new Extensions site [Andreas mailed design@ ML, Jay will respond.] + Jay: Send a mail to documentat...@global.libreoffice.org with the wiki page that collects changes in menus + Kendy: Collecting of the user information should be incremental, somewhere in the user's profile + Ahmed: Push the new Sifr icons he's done recently + Kendy: Talk to Milos wrt. https://bugs.freedesktop.org/show_bug.cgi?id=48622 + Alex: Gnome 2.20-style 'a' icons Gnome 3-style text line icons + Samuel: Formulas and Navigator should open in the sidebar, not as a special window https://bugs.freedesktop.org/show_bug.cgi?id=85897 * UI changes integrated the last week: + Integrated the templates from the Templates contest (Kendy) + Category tree view in Tools - Options does not cut off text now (Adolfo) + hi-dpi improvements in the rulers (dbeurle) + Cleanup of frames in .ui files (Adolfo) + Several new Sifr icons (Matthias) * Cover art for 4.4 user guides + k-j: The Documentation team needs perhaps some new cover art for 4.4 user guides documentation + http://nabble.documentfoundation.org/cover-art-for-v4-4-user-guides-td4135730.html actual looking: https://wiki.documentfoundation.org/User:K-j/Drafts/Documentation#Cover_for_V4.2 source files: https://wiki.documentfoundation.org/Documentation/Development#Source_files_for_cover_art + the current ones (shown above) look pretty good to me (Kendy) + but if there is a need for change, happy to promote that using the Design G+ and Twitter (Kendy) + if the svg is broken when open with LibreOffice - please file a bug (Kendy) + and use a png snapshot for the moment... (Kendy) * Last week's discussions that need a resolution: + Return of the horizontal ruler (Jay) https://bugs.freedesktop.org/show_bug.cgi?id=87923 + turns out that it is still useful to have the horizontal ruler (Stuart) + there are concerns = revert (Kendy) + actually it's possible to show _only_ the horizontal one (Stuart) + Tools - Options... - Writer - View AI + conclusion: let's change it to show the horizontal ruler (Kendy) + Location of Header/Footer (Jay) I believe it is maybe best under format for calc and impress as they function differently https://bugs.freedesktop.org/show_bug.cgi?id=86440 + Calc + Impress different to Writer: they already have the headers / footers (Jay / Cor) + still it seems good to have the location in the menu same as in Writer (Kendy) + conclusion: Let's keep it as it is for 4.4 (changed to Insert) + Default document view for Writer, single page rather than automatic (Jay) https://bugs.freedesktop.org/show_bug.cgi?id=88001 + the position on the left looks strange (Jay) + there is a setting automatic - launches according to the size (Stuart) + this is the default now (Stuart) + but makes the document jumping here and there when you zoom (Stuart) + Two pages tooltip is misnamed - it can have more pages than that (Stuart / Heiko) + Column mode? (Heiko) + Fit pages? (Kendy) + Automatic? (Stuart) - that's in the code + or Multipage view / Multiple page view? (Stuart, Jay, Mattias) AI + conclusion: about the default, let's change it to single page (Stuart) + Changing the context menu entry 'Default' to something more meaningful (Jay) https://bugs.freedesktop.org/show_bug.cgi?id=86877 + to have just a word Default in the menu is strange (Jay) + how to get it: F2, select text, right-click + confusing what it means (Jay) + yes (Kendy) + Default - Default Formatting ? (Heiko) + it is actually not only the text style, also the number formatting + Apply cell style? (Heiko) + Reset to cell style? (Kendy) + Reset to cell formatting (Jay) + sounds good (Kendy) + conclusion: Let's do it (4.5 only). + 'Spelling' or 'Spelling and Grammar' (Jay) https://bugs.freedesktop.org/show_bug.cgi?id=87648 + Writer has Spelling and Grammar, Calc and Impress have only Spelling + if the functionality is working, let's just change the name in Calc and Impress (Kendy) AI + conclusion: Double-check that grammar checking works in Calc and Impress, and if yes, change that to be consistent with Writer (Jay) + Calc - Context menu entry to edit Conditional Formatting
Re: 4.4.0.1 build error on sal/types.h on solaris/illumos
On 01/15/2015 03:05 PM, Gabriele Bulfon wrote: Anyone can help? http://cgit.freedesktop.org/libreoffice/core/commit/?id=234e45bf1d27484b72e73fe327b1e92fda1933f1 Revert 'never wonder if sun is not sun' should fix this (on master for now). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
