[Libreoffice-bugs] [Bug 54927] Variants of A5 format not recognized
https://bugs.documentfoundation.org/show_bug.cgi?id=54927 Heiko Tietzechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Heiko Tietze --- (In reply to Yousuf Philips (jay) from comment #4) > I tested MSO 2007, 2010 and 2013 and none of them listed A5 as an available > page size option, so i tested MSO 2003 and it did have A5 listed, so i saved > a .doc file and opened it in LO 5.2 and it opened fine as A5 (14.80cm x > 21cm). MSO2010 has A5 (maybe available dimensions depend on regional settings) and saves with 148x210, which is recognized as A5 in Writer. So WFM. I would also follow Jorendc's comment 3 that allowing a variability in sizes so that 148.5x210 is categorized as A5 leads to the risk of bad formats. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112086] PPTX with zoom animation opens with repair in PowerPoint after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=112086 --- Comment #2 from Aron Budea--- One of the issues is that the element of type p:fltVal is not exported. original snippet: exported snippet: The code doesn't like p:fltVal for Width attribute, see what's in the 'if' around here: https://opengrok.libreoffice.org/xref/core/sd/source/filter/eppt/pptexanimations.cxx#1390 Not sure what's allowed, since conversion seems to be involved in general, but maybe interpreting a double with the value 0 could be allowed there? Adding that still exports a p:strVal instead of p:fltVal, though, so further changes are needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/thread.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0083b33650c2f584ceff6eeaf9ef6993bfe0ae9b Author: Michael StahlDate: Mon Sep 18 12:44:24 2017 +0200 sal: -Werror,-Wsign-compare (32-bit) Change-Id: I204716eea112a1c99f6ac4df0d138c4c7d8b68e3 diff --git a/sal/osl/unx/thread.cxx b/sal/osl/unx/thread.cxx index 9c7bb372d592..c2705c8c08cc 100644 --- a/sal/osl/unx/thread.cxx +++ b/sal/osl/unx/thread.cxx @@ -625,7 +625,7 @@ static oslThreadIdentifier insertThreadId (pthread_t hThread) #if defined LINUX && ! defined __FreeBSD_kernel__ long lin_tid = syscall(SYS_gettid); -if (lin_tid <= 0 || lin_tid > SAL_MAX_UINT32) +if (lin_tid <= 0 || SAL_MAX_UINT32 < static_cast(lin_tid)) std::abort(); pEntry->Ident = static_cast(lin_tid); #elif defined MACOSX || defined IOS ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112464] How to get the equations of a trend lines in Calc?
https://bugs.documentfoundation.org/show_bug.cgi?id=112464 erotavlaschanged: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112464] New: How to get the equations of a trend lines in Calc?
https://bugs.documentfoundation.org/show_bug.cgi?id=112464 Bug ID: 112464 Summary: How to get the equations of a trend lines in Calc? Product: LibreOffice Version: 5.4.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: erotavlas_tu...@libero.it Description: Hi, I read this discussion https://ask.libreoffice.org/en/question/36863/how-to-get-the-equation-of-a-trend-line-in-calc/ about how to get the equations of various trend lines into a cells of Calc. I found this website http://spreadsheetpage.com/index.php/tip/chart_trendline_formulas/ that achieves what I'm looking for. It would be great an option to get the equations directly from the chart. Thank you Actual Results: This feature does not exist. Expected Results: Nothing Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108846] FILEOPEN PPTX Fuzzy images when viewed in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=108846 --- Comment #8 from Kevin Evans--- Apologies for using the NEEDINFO incorrectly. I installed V5.3.6.1 yesterday on my laptop and noticed that the bug was still there, hence the question. Regards, Kevin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/source
vcl/source/gdi/jobset.cxx | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) New commits: commit f68b66891fea7599e84395325c12cd845a308315 Author: Caolán McNamaraDate: Sun Sep 17 17:38:39 2017 +0100 detect corrupted job setup Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42384 Reviewed-by: Michael Stahl Tested-by: Michael Stahl diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx index ecea840d2393..57c02b95b557 100644 --- a/vcl/source/gdi/jobset.cxx +++ b/vcl/source/gdi/jobset.cxx @@ -236,7 +236,7 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) sal_uInt16 nSystem = 0; rIStream.ReadUInt16( nSystem ); -const size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); +size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); if (nRead > rIStream.remainingSize()) { SAL_WARN("vcl", "Parsing error: " << rIStream.remainingSize() << @@ -245,7 +245,7 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) } sal_uInt64 const nFirstPos = rIStream.Tell(); std::unique_ptr pTempBuf(new char[nRead]); -rIStream.ReadBytes(pTempBuf.get(), nRead); +nRead = rIStream.ReadBytes(pTempBuf.get(), nRead); if (nRead >= sizeof(ImplOldJobSetupData)) { ImplOldJobSetupData* pData = reinterpret_cast (pTempBuf.get()); @@ -275,11 +275,19 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) rJobData.SetPaperHeight( (long)SVBT32ToUInt32( pOldJobData->nPaperHeight ) ); if ( rJobData.GetDriverDataLen() ) { -const sal_uInt8* pDriverData = reinterpret_cast (pOldJobData) + nOldJobDataSize; -sal_uInt8* pNewDriverData = static_cast ( -rtl_allocateMemory( rJobData.GetDriverDataLen() )); -memcpy( pNewDriverData, pDriverData, rJobData.GetDriverDataLen() ); -rJobData.SetDriverData( pNewDriverData ); +const char* pDriverData = reinterpret_cast(pOldJobData) + nOldJobDataSize; +const char* pDriverDataEnd = pDriverData + rJobData.GetDriverDataLen(); +if (pDriverDataEnd > pTempBuf.get() + nRead) +{ +SAL_WARN("vcl", "corrupted job setup"); +} +else +{ +sal_uInt8* pNewDriverData = static_cast ( +rtl_allocateMemory( rJobData.GetDriverDataLen() )); +memcpy( pNewDriverData, pDriverData, rJobData.GetDriverDataLen() ); +rJobData.SetDriverData( pNewDriverData ); +} } if( nSystem == JOBSET_FILE605_SYSTEM ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - starmath/source
starmath/source/smdetect.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e577828583bbebc1fbfdb8960aa45a0b634cd5f8 Author: Caolán McNamaraDate: Sun Sep 17 14:22:45 2017 +0100 valgrind: Conditional jump or move depends on uninitialised value Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara (cherry picked from commit 64aa36e8b999ea4dcad69904da941705effad618) Reviewed-on: https://gerrit.libreoffice.org/42386 Reviewed-by: Michael Stahl Tested-by: Michael Stahl diff --git a/starmath/source/smdetect.cxx b/starmath/source/smdetect.cxx index 55283530e86a..8e2953b34227 100644 --- a/starmath/source/smdetect.cxx +++ b/starmath/source/smdetect.cxx @@ -93,12 +93,12 @@ OUString SAL_CALL SmFilterDetect::detect( Sequence< PropertyValue >& lDescriptor // stuff I hope? static const sal_uInt16 nBufferSize = 200; char aBuffer[nBufferSize+1]; -aBuffer[nBufferSize] = 0; pInStrm->Seek( STREAM_SEEK_TO_BEGIN ); pInStrm->StartReadingUnicodeText( RTL_TEXTENCODING_DONTKNOW ); // avoid BOM marker sal_uLong nBytesRead = pInStrm->ReadBytes( aBuffer, nBufferSize ); if (nBytesRead >= 6) { +aBuffer[nBytesRead] = 0; bool bIsMathType = false; if (0 == strncmp( "" ) || ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source
vcl/source/gdi/jobset.cxx | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) New commits: commit 1eb3822d74f535f75aa336b27568ee8a6084c4dd Author: Caolán McNamaraDate: Sun Sep 17 17:38:39 2017 +0100 detect corrupted job setup Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42385 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx index f80e246a5c68..31ee4f08dca5 100644 --- a/vcl/source/gdi/jobset.cxx +++ b/vcl/source/gdi/jobset.cxx @@ -239,7 +239,7 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) sal_uInt16 nSystem = 0; rIStream.ReadUInt16( nSystem ); -const size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); +size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); if (nRead > rIStream.remainingSize()) { SAL_WARN("vcl", "Parsing error: " << rIStream.remainingSize() << @@ -248,7 +248,7 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) } sal_uInt64 const nFirstPos = rIStream.Tell(); std::unique_ptr pTempBuf(new char[nRead]); -rIStream.ReadBytes(pTempBuf.get(), nRead); +nRead = rIStream.ReadBytes(pTempBuf.get(), nRead); if (nRead >= sizeof(ImplOldJobSetupData)) { ImplOldJobSetupData* pData = reinterpret_cast (pTempBuf.get()); @@ -278,11 +278,19 @@ SvStream& ReadJobSetup( SvStream& rIStream, JobSetup& rJobSetup ) rJobData.SetPaperHeight( (long)SVBT32ToUInt32( pOldJobData->nPaperHeight ) ); if ( rJobData.GetDriverDataLen() ) { -const sal_uInt8* pDriverData = reinterpret_cast (pOldJobData) + nOldJobDataSize; -sal_uInt8* pNewDriverData = static_cast ( -rtl_allocateMemory( rJobData.GetDriverDataLen() )); -memcpy( pNewDriverData, pDriverData, rJobData.GetDriverDataLen() ); -rJobData.SetDriverData( pNewDriverData ); +const char* pDriverData = reinterpret_cast(pOldJobData) + nOldJobDataSize; +const char* pDriverDataEnd = pDriverData + rJobData.GetDriverDataLen(); +if (pDriverDataEnd > pTempBuf.get() + nRead) +{ +SAL_WARN("vcl", "corrupted job setup"); +} +else +{ +sal_uInt8* pNewDriverData = static_cast ( +rtl_allocateMemory( rJobData.GetDriverDataLen() )); +memcpy( pNewDriverData, pDriverData, rJobData.GetDriverDataLen() ); +rJobData.SetDriverData( pNewDriverData ); +} } if( nSystem == JOBSET_FILE605_SYSTEM ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Red Line (Track Changes) Geometry
Hi, I'm trying to change the thickness of the 'redline' that appears in the margin to show a line that has changed. I've altered the geometries in SwMarkPreview::Paint() in optpage.cxx but this does not seem to be the right place as even placing a return at the start of this method seems to have no effect on the output. I'd appreciate a pointer to the correct area in the code. Thanks. A Background: The track changes red line in the margins is perfectly visible on my screen, but when printed or converted to pdf, it outputs very thinly, I think as a 'hairline'. I suspect my printer printer driver interprets this literally and the resulting line is barely visible on paper, and hence not much use. I thought others might have this problem, so I thought I'd try hacking the code to fix it, by allowing the line style to be adjusted (or at least hacked to 2pt). Sorry, it's my first time editing libreoffice. I'm using Ubuntu 17.04; Help About says: Version: 6.0.0.0.alpha0+ I run the compiled code using: instdir/program/soffice --writer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac
configure.ac | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) New commits: commit 050b1d0924aeaec6be5ca520617c5e511d99571a Author: Rene EngelhardDate: Mon Sep 18 11:43:51 2017 +0200 use pkg-config --modversion to check for ICU version ... since icu-config is removed at least in Debians icu 59.1 packages. icu-i18n exists since exactly 4.6 (which we require anyway) so we can remove that check, too Change-Id: I28bd1509dcc2c52e22f91fb26421fcd585323b24 diff --git a/configure.ac b/configure.ac index 5f72318268ce..b4932349a165 100644 --- a/configure.ac +++ b/configure.ac @@ -8872,23 +8872,14 @@ if test "$with_system_icu" = "yes"; then AC_LANG_POP([C++]) if test "$cross_compiling" != "yes"; then -AC_PATH_PROG(ICUCONFIG,icu-config) - -AC_MSG_CHECKING([ICU version]) -ICU_VERSION=`$ICUCONFIG --noverify --version 2>/dev/null || $ICUCONFIG --version` +PKG_CHECK_MODULES(ICU, icu-i18n >= 4.6) +ICU_VERSION=`$PKG_CONFIG --modversion icu-i18n 2>/dev/null` ICU_MAJOR=`echo $ICU_VERSION | cut -d"." -f1` ICU_MINOR=`echo $ICU_VERSION | cut -d"." -f2` - -if test "$ICU_MAJOR" -ge "49" -o \( "$ICU_MAJOR" = "4" -a "$ICU_MINOR" -ge "6" \); then -AC_MSG_RESULT([OK, $ICU_VERSION]) -else -AC_MSG_ERROR([not suitable, only >= 4.6 supported currently]) -fi fi if test "$cross_compiling" = "yes" -a \( "$with_system_icu_for_build" = "yes" -o "$with_system_icu_for_build" = "force" \); then -AC_PATH_PROG([ICUCONFIG_FOR_BUILD], [icu-config], [], [$PATH:/usr/sbin:/sbin]) -ICU_VERSION_FOR_BUILD=`$ICUCONFIG_FOR_BUILD --noverify --version 2>/dev/null || $ICUCONFIG_FOR_BUILD --version` +ICU_VERSION_FOR_BUILD=`$PKG_CONFIG --modversion icu-i18n 2>/dev/null` ICU_MAJOR_FOR_BUILD=`echo $ICU_VERSION_FOR_BUILD | cut -d"." -f1` ICU_MINOR_FOR_BUILD=`echo $ICU_VERSION_FOR_BUILD | cut -d"." -f2` AC_MSG_CHECKING([if MinGW and system versions of ICU are compatible]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: wizards/com wizards/source writerfilter/source xmloff/source
wizards/com/sun/star/wizards/db/CommandName.java |2 +- wizards/com/sun/star/wizards/db/DBMetaData.java |2 +- wizards/com/sun/star/wizards/db/FieldColumn.java |4 ++-- wizards/com/sun/star/wizards/db/RecordParser.java|2 +- wizards/com/sun/star/wizards/table/FieldDescription.java |2 +- wizards/source/formwizard/Layouter.xba |2 +- wizards/source/gimmicks/GetTexts.xba |2 +- wizards/source/tools/Misc.xba|8 wizards/source/tutorials/Functions.xba |2 +- writerfilter/source/dmapper/PropertyMap.cxx |2 +- xmloff/source/text/txtexppr.cxx |4 ++-- 11 files changed, 16 insertions(+), 16 deletions(-) New commits: commit 510b9557c37c666016c55e6ed2be7a50dbd1b67f Author: Johnny_MDate: Sun Sep 17 14:23:46 2017 +0200 Translate German comments and debug strings (leftovers in dirs w... and x...) Translates leftovers found using a custom regex in directories beginning with "w" and "x". Additionally: - A few corrections of previous translations Change-Id: Ic30cf6792748a6bea8782a9a3711fa468b80bdaf Reviewed-on: https://gerrit.libreoffice.org/42378 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/wizards/com/sun/star/wizards/db/CommandName.java b/wizards/com/sun/star/wizards/db/CommandName.java index 91e54ed3ba25..4768018ef3b5 100644 --- a/wizards/com/sun/star/wizards/db/CommandName.java +++ b/wizards/com/sun/star/wizards/db/CommandName.java @@ -87,7 +87,7 @@ public class CommandName this.DisplayName = _DisplayName; int iIndex; if (oCommandMetaData.xDBMetaData.supportsCatalogsInDataManipulation()) -{ // ...dann Catalog mit in TableName +{ // ...then Catalog also in TableName iIndex = _DisplayName.indexOf(sCatalogSep); if (iIndex >= 0) { diff --git a/wizards/com/sun/star/wizards/db/DBMetaData.java b/wizards/com/sun/star/wizards/db/DBMetaData.java index 8d90126d3e5e..1a720b0ac3a5 100644 --- a/wizards/com/sun/star/wizards/db/DBMetaData.java +++ b/wizards/com/sun/star/wizards/db/DBMetaData.java @@ -351,7 +351,7 @@ public class DBMetaData WidthList[4][0] = DataType.LONGVARCHAR; // == -1; WidthList[5][0] = DataType.CHAR; // == 1; WidthList[6][0] = DataType.NUMERIC; // == 2; -WidthList[7][0] = DataType.DECIMAL; // == 3; [mit Nachkommastellen] +WidthList[7][0] = DataType.DECIMAL; // == 3; [with fractional part] WidthList[8][0] = DataType.INTEGER; // == 4; WidthList[9][0] = DataType.SMALLINT; // == 5; WidthList[10][0] = DataType.FLOAT; // == 6; diff --git a/wizards/com/sun/star/wizards/db/FieldColumn.java b/wizards/com/sun/star/wizards/db/FieldColumn.java index 29e4b3939194..dd8b85a9207e 100644 --- a/wizards/com/sun/star/wizards/db/FieldColumn.java +++ b/wizards/com/sun/star/wizards/db/FieldColumn.java @@ -266,7 +266,7 @@ public class FieldColumn bIsNumberFormat = true; break; -case DataType.DECIMAL: // == 3; [mit Nachkommastellen] +case DataType.DECIMAL: // == 3; [with fractional part] case DataType.FLOAT: // == 6; case DataType.REAL: // == 7; case DataType.DOUBLE: // == 8; @@ -369,7 +369,7 @@ public class FieldColumn break; case DataType.NUMERIC: // == 2; -case DataType.DECIMAL: // == 3; [mit Nachkommastellen] +case DataType.DECIMAL: // == 3; [with fractional part] case DataType.FLOAT: // == 6; case DataType.REAL: // == 7; case DataType.DOUBLE: // == 8; diff --git a/wizards/com/sun/star/wizards/db/RecordParser.java b/wizards/com/sun/star/wizards/db/RecordParser.java index c06566874cef..bb35b041fe97 100644 --- a/wizards/com/sun/star/wizards/db/RecordParser.java +++ b/wizards/com/sun/star/wizards/db/RecordParser.java @@ -127,7 +127,7 @@ public class RecordParser extends QueryMetaData case DataType.NUMERIC: // == 2; case DataType.INTEGER: // == 4; case DataType.SMALLINT: // == 5; -case DataType.DECIMAL: // == 3; [mit Nachkommastellen] +case DataType.DECIMAL: // == 3; [with fractional part] case DataType.FLOAT: // == 6; case DataType.REAL: // == 7; case DataType.DOUBLE: // == 8; diff --git a/wizards/com/sun/star/wizards/table/FieldDescription.java b/wizards/com/sun/star/wizards/table/FieldDescription.java index 2128a760eabe..95a847136360 100644 --- a/wizards/com/sun/star/wizards/table/FieldDescription.java +++
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 sergio.calleg...@gmail.com changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 --- Comment #6 from sergio.calleg...@gmail.com --- My intention was precisely to provide feedback so that it can be at the maximum possible quality when it comes out of experimental status. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - starmath/source
starmath/source/smdetect.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 256a405d4b1feeafd8a09e98bce9fb0c9125ee3d Author: Caolán McNamaraDate: Sun Sep 17 14:22:45 2017 +0100 valgrind: Conditional jump or move depends on uninitialised value Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara (cherry picked from commit 64aa36e8b999ea4dcad69904da941705effad618) Reviewed-on: https://gerrit.libreoffice.org/42387 Reviewed-by: Michael Stahl diff --git a/starmath/source/smdetect.cxx b/starmath/source/smdetect.cxx index 18dfa736bd51..91c8733bf13c 100644 --- a/starmath/source/smdetect.cxx +++ b/starmath/source/smdetect.cxx @@ -93,12 +93,12 @@ OUString SAL_CALL SmFilterDetect::detect( Sequence< PropertyValue >& lDescriptor // stuff I hope? static const sal_uInt16 nBufferSize = 200; char aBuffer[nBufferSize+1]; -aBuffer[nBufferSize] = 0; pInStrm->Seek( STREAM_SEEK_TO_BEGIN ); pInStrm->StartReadingUnicodeText( RTL_TEXTENCODING_DONTKNOW ); // avoid BOM marker sal_uLong nBytesRead = pInStrm->ReadBytes( aBuffer, nBufferSize ); if (nBytesRead >= 6) { +aBuffer[nBytesRead] = 0; bool bIsMathType = false; if (0 == strncmp( "" ) || ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 sergio.calleg...@gmail.com changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 --- Comment #6 from sergio.calleg...@gmail.com --- My intention was precisely to provide feedback so that it can be at the maximum possible quality when it comes out of experimental status. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdmark.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 3af68b14791118868e410133ea5a2b555bbac6eb Author: Takeshi AbeDate: Sun Sep 17 12:18:13 2017 +0900 svx: Assert that GetMarkedSdrObj() cannot be null here as such invalid ones have been removed already in advance. This could come togeher with c0e9968b4bbda9563213589bcb0472f8797bb553. Change-Id: I914031390d13dd4ad91d2ead61db7f2d53c78004 Reviewed-on: https://gerrit.libreoffice.org/42365 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/svx/source/svdraw/svdmark.cxx b/svx/source/svdraw/svdmark.cxx index e82bc794a14c..bf31cea26892 100644 --- a/svx/source/svdraw/svdmark.cxx +++ b/svx/source/svdraw/svdmark.cxx @@ -36,6 +36,8 @@ #include #include +#include + void SdrMark::setTime() { TimeValue aNow; @@ -183,7 +185,8 @@ void SdrMarkList::ImpForceSort() { size_t i = count - 1; SdrMark* pCmp = maList[i]; -if(pAkt->GetMarkedSdrObj() == pCmp->GetMarkedSdrObj() && pAkt->GetMarkedSdrObj()) +assert(pAkt->GetMarkedSdrObj()); +if(pAkt->GetMarkedSdrObj() == pCmp->GetMarkedSdrObj()) { // Con1/Con2 Merging if(pCmp->IsCon1()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112462] Writer formula bar ignores locale
https://bugs.documentfoundation.org/show_bug.cgi?id=112462 --- Comment #2 from sergio.calleg...@gmail.com --- Please, try with US user interface and German locale. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112426] Proposal for a PDF import settings dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=112426 --- Comment #8 from Miklos Vajna--- (In reply to V Stuart Foote from comment #4) > But I would defer to Miklos' sensibilities as I know he has more in mind > with the ipdf (pdfium based filter) and that enhancement may provide better > preview/selection of page(s) for insertion. I don't have a strong opinion on this. The long-term plan would be that LO provides a skia(-compatible) drawing surface and pdfium can draw on that, so pdfium would give vector output, and at that stage we can probably drop the poppler-based pdf import. But neither pdfium nor LO is ready for that today. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 Heiko Tietzechanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- The feature is experimental and therefor not every aspect is perfect. Nevertheless I think a generic approach makes sense and I recommend to not only activate the menubar with F10 but also to show it when hidden. (Restore previous visibility when the focus goes somewhere else) This solution could be an easyhack. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 Heiko Tietzechanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- The feature is experimental and therefor not every aspect is perfect. Nevertheless I think a generic approach makes sense and I recommend to not only activate the menubar with F10 but also to show it when hidden. (Restore previous visibility when the focus goes somewhere else) This solution could be an easyhack. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 109016] FILESAVE XLSX PIVOTTABLE: Filter set on row fields not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=109016 --- Comment #10 from m.a.riosv--- Maybe this one https://bugs.documentfoundation.org/show_bug.cgi?id=89139 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112333] FILESAVE: PPTX: Fill Color Animation gets corrupted after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=112333 Szymon Kłoschanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |szymon.k...@collabora.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106990] font rendering got worse looking in 5.3.2.2 ( for Default rendering, OpenGL not affected) (devEval comment 60)
https://bugs.documentfoundation.org/show_bug.cgi?id=106990 --- Comment #98 from Andy--- I am sorry to mix things up a bit, but I would like to summarize the main problems I experiences with the modified fonts display technique in latest releases (lo5.3.2 and further). I am doing this because taken togheter they are quite problematic. Everything is based on trails conducted on 2 different windows 7 PC (there is no difference in outcome between the 2): 1)font rendering for all GUI of the suite are ugly and unpolished, and things are a bit worse also for document contens (even if the latter is less evident than in the GUI rendering - menus, dialog windows etc.) 2) the scrolling of content displayed on a document, especially calc sheets, has slowed down and become jerky. This slowing down makes LO downright unusable when the screen shows a lot of data (see the details I posted in bug 107521), causing scrolling to be around 13 THIRTEEN times slower than with lo5.3.1. At those speed keyboard buffer becomes impossible to control and is extremely difficult to navigate your spreadsheets 3) full screen impress presentations are rendered in a dramatically bad fashion when hardware display accel is enabled. This can be avoided disabling Hardware accel, but I still have to understand what this disabling implies for other functions. Or is a totally useless option? Please notice that problems 1) and 2) are not mitigated in ANY combination of display settings (hardware accel and opengl. All together , IMHO this problems make for a compelling case supporting the need to solve this. In terms of critical nature, for power users n. 2 is the worst, and there seems to be NO workaround whatsoever. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/nss
external/nss/asan.patch.1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 69e62bbebc1f4809101df0c694a930b07dbc194d Author: Stephan BergmannDate: Mon Sep 18 11:35:23 2017 +0200 Adapt external/nss/asan.patch.1 ...to a52ca01f6ae27a86cae6e82b3c5ae6601f3ea398 "nss: no rpath/origin flag for Android (unused DT entry/DT_FLAGS warnings)" Change-Id: I60e4ba1af572aa702a355e26dec58142209f8655 diff --git a/external/nss/asan.patch.1 b/external/nss/asan.patch.1 index 6acbb04d233d..7dfd6ed4e782 100644 --- a/external/nss/asan.patch.1 +++ b/external/nss/asan.patch.1 @@ -7,6 +7,6 @@ diff -ur nss.org/nss/coreconf/Linux.mk nss/nss/coreconf/Linux.mk # against the libsanitizer runtime built into the main executable. -ZDEFS_FLAG= -Wl,-z,defs +ZDEFS_FLAG= - DSO_LDOPTS += $(if $(findstring 2.11.90.0.8,$(shell ld -v)),,$(ZDEFS_FLAG)) -Wl,-z,origin '-Wl,-rpath,$$ORIGIN' + DSO_LDOPTS+= $(if $(findstring 2.11.90.0.8,$(shell ld -v)),,$(ZDEFS_FLAG)) $(if $(filter-out $(OS),ANDROID),-Wl$(COMMA)-z$(COMMA)origin '-Wl$(COMMA)-rpath$(COMMA)$$ORIGIN') LDFLAGS += $(ARCHFLAG) -z noexecstack ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/tools tools/source vcl/headless vcl/inc vcl/opengl vcl/quartz vcl/source vcl/unx vcl/win
include/tools/poly.hxx |1 + tools/source/generic/poly.cxx|5 + vcl/headless/svpgdi.cxx |2 +- vcl/inc/headless/svpgdi.hxx |2 +- vcl/inc/openglgdiimpl.hxx|2 +- vcl/inc/quartz/salgdi.h |2 +- vcl/inc/salgdi.hxx |4 ++-- vcl/inc/salgdiimpl.hxx |2 +- vcl/inc/unx/genpspgraphics.h |2 +- vcl/inc/unx/salgdi.h |2 +- vcl/inc/win/salgdi.h |2 +- vcl/opengl/gdiimpl.cxx |2 +- vcl/quartz/salgdicommon.cxx |2 +- vcl/source/gdi/salgdilayout.cxx |2 +- vcl/source/outdev/curvedshapes.cxx |8 vcl/source/outdev/line.cxx |4 ++-- vcl/source/outdev/polyline.cxx |6 +++--- vcl/source/outdev/rect.cxx |4 ++-- vcl/unx/generic/gdi/gdiimpl.cxx |2 +- vcl/unx/generic/gdi/gdiimpl.hxx |2 +- vcl/unx/generic/gdi/salgdi.cxx |2 +- vcl/unx/generic/print/genpspgraphics.cxx |4 ++-- vcl/win/gdi/gdiimpl.cxx |4 ++-- vcl/win/gdi/gdiimpl.hxx |2 +- vcl/win/gdi/salgdi.cxx |2 +- 25 files changed, 39 insertions(+), 33 deletions(-) New commits: commit 80363950fda5eeef9830f61e57899d1805c91751 Author: Stephan BergmannDate: Mon Sep 18 10:37:17 2017 +0200 Acknowledge that WinSalGraphicsImpl::drawPolyLine modifies pPtAry Change-Id: Idde44857f8ace883cc759321c71e2ca7a4359334 Reviewed-on: https://gerrit.libreoffice.org/42406 Reviewed-by: Stephan Bergmann Tested-by: Stephan Bergmann diff --git a/include/tools/poly.hxx b/include/tools/poly.hxx index 40a129414a38..044bafe3f3e2 100644 --- a/include/tools/poly.hxx +++ b/include/tools/poly.hxx @@ -171,6 +171,7 @@ public: voidRead( SvStream& rIStream ); voidWrite( SvStream& rOStream ) const; +Point * GetPointAry(); const Point*GetConstPointAry() const; const PolyFlags*GetConstFlagAry() const; diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx index 0cdc61f91b65..217565a1ae60 100644 --- a/tools/source/generic/poly.cxx +++ b/tools/source/generic/poly.cxx @@ -796,6 +796,11 @@ Polygon::~Polygon() } } +Point * Polygon::GetPointAry() +{ +return mpImplPolygon->mpPointAry; +} + const Point* Polygon::GetConstPointAry() const { return mpImplPolygon->mpPointAry; diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index dea4185abea8..08b6ad2522f9 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -577,7 +577,7 @@ void SvpSalGraphics::drawRect( long nX, long nY, long nWidth, long nHeight ) m_aLineColor = aOrigLineColor; } -void SvpSalGraphics::drawPolyLine(sal_uInt32 nPoints, const SalPoint* pPtAry) +void SvpSalGraphics::drawPolyLine(sal_uInt32 nPoints, SalPoint* pPtAry) { basegfx::B2DPolygon aPoly; aPoly.append(basegfx::B2DPoint(pPtAry->mnX, pPtAry->mnY), nPoints); diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx index 56ed365339f2..5879c1bfdf44 100644 --- a/vcl/inc/headless/svpgdi.hxx +++ b/vcl/inc/headless/svpgdi.hxx @@ -178,7 +178,7 @@ public: basegfx::B2DLineJoin, css::drawing::LineCap, double fMiterMinimumAngle) override; -virtual voiddrawPolyLine( sal_uInt32 nPoints, const SalPoint* pPtAry ) override; +virtual voiddrawPolyLine( sal_uInt32 nPoints, SalPoint* pPtAry ) override; virtual voiddrawPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry ) override; virtual voiddrawPolyPolygon( sal_uInt32 nPoly, const sal_uInt32* pPoints, diff --git a/vcl/inc/openglgdiimpl.hxx b/vcl/inc/openglgdiimpl.hxx index 7bc6644fdc48..67efca02924e 100644 --- a/vcl/inc/openglgdiimpl.hxx +++ b/vcl/inc/openglgdiimpl.hxx @@ -244,7 +244,7 @@ public: virtual void drawRect( long nX, long nY, long nWidth, long nHeight ) override; -virtual void drawPolyLine( sal_uInt32 nPoints, const SalPoint* pPtAry ) override; +virtual void drawPolyLine( sal_uInt32 nPoints, SalPoint* pPtAry ) override; virtual void drawPolygon( sal_uInt32 nPoints, const SalPoint* pPtAry ) override; diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h index 12356fb57767..9a9626719169 100644 --- a/vcl/inc/quartz/salgdi.h +++ b/vcl/inc/quartz/salgdi.h @@ -228,7 +228,7 @@ public: virtual voiddrawPixel( long nX, long nY, SalColor nSalColor ) override; virtual voiddrawLine( long nX1, long nY1, long nX2, long nY2 )
[Libreoffice-bugs] [Bug 103303] [META] Desktop integration bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103303 Thomas Lendochanged: What|Removed |Added Depends on||103177 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103177 [Bug 103177] Use preview of document as icon on macOS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103177] Use preview of document as icon on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=103177 Thomas Lendochanged: What|Removed |Added Blocks||103303 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103303 [Bug 103303] [META] Desktop integration bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Text on OLE objects?
Hi all, Currently there is muddle in the UI and in code. Insert a chart or Math object or an OLE to a foreign application, then click on it so that is gets green handles, then press F2 and enter text. That is the same behavior as for normal shapes, where you can add text to the shape that way. But when you save and reload the document, the text on the OLE is gone. (I think, there is no bug report yet.) With AOO #i118485# the feature "text on Draw OLE shape" was introduced. But that has problems in file format, because it puts the text as inside the element, which is not valid. That was changed by moving the one level up to the object. But there it neither valid. So with fdo#58571 the element was put into loext namespace, which results in a child element of the element. But in ODF1.2 strict, you now get a element without any namespace, so still not valid. In the meantime it has been introduced, that the attribute draw:notify-on-update-of-ranges of the element is used. But currently it does not go to the element, but it goes to the element. The same happens with the draw:class-id attribute of the element. That is tdf#112005. https://gerrit.libreoffice.org/#/c/42401/ has a fix for that. But it does not solve the problem, that you can enter text, which is gone after reload. I wonder, whether it is good to allow at all text (via F2) on OLE objects. And in consequence, whether it would be better to remove this feature than to get all aspects fixed? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 108703] LibO is trying to access OpenOffice\dict_word.brk & dict_word_en.brk when scrolling through a document
https://bugs.documentfoundation.org/show_bug.cgi?id=108703 --- Comment #5 from Mike Kaganski--- The code is in BreakIterator_Unicode::loadICUBreakIterator() - see i18npool/source/breakiterator/breakiterator_unicode.cxx -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/tdf109310_endnoteStyleForMSO.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |7 +++ sw/source/filter/ww8/attributeoutputbase.hxx|2 - sw/source/filter/ww8/docxattributeoutput.cxx| 18 -- sw/source/filter/ww8/docxattributeoutput.hxx|2 - sw/source/filter/ww8/wrtw8nds.cxx |8 +++- 6 files changed, 32 insertions(+), 5 deletions(-) New commits: commit ac1081170c5bc2234b14ce99b7ea8e583bac82b5 Author: Justin LuthDate: Wed Sep 6 19:29:40 2017 -0400 tdf#109310 ooxmlexport: write Xnote character style LibreOffice will just ignore the defined style on import (since that is statically defined by the footnote code). Microsoft Office, however, requires the character style be provided for the footnote number. It doesn't have any built-in formatting for footnotes. So, this patch is strictly for MSO's benefit. Change-Id: I6631dd0eb697589cfd3c13d7838fe14c31a71bbf Reviewed-on: https://gerrit.libreoffice.org/42035 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/sw/qa/extras/ooxmlexport/data/tdf109310_endnoteStyleForMSO.docx b/sw/qa/extras/ooxmlexport/data/tdf109310_endnoteStyleForMSO.docx new file mode 100644 index ..9949b98d5f68 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf109310_endnoteStyleForMSO.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx index a89799b87e39..24016d38c43c 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx @@ -420,6 +420,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf103975_notPageBreakE, "tdf103975_notPageBreakE.d CPPUNIT_ASSERT_EQUAL(style::BreakType_COLUMN_BEFORE, getProperty(getParagraph(2), "BreakType")); } +DECLARE_OOXMLEXPORT_TEST(testTdf109310_endnoteStyleForMSO, "tdf109310_endnoteStyleForMSO.docx") +{ +xmlDocPtr pXmlDoc = parseExport("word/endnotes.xml"); +if (!pXmlDoc) +return; +assertXPath(pXmlDoc, "/w:endnotes/w:endnote[@w:id='2']/w:p/w:r[1]/w:rPr/w:rStyle", "w:val"); +} DECLARE_OOXMLEXPORT_TEST(testTdf103389, "tdf103389.docx") { diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx b/sw/source/filter/ww8/attributeoutputbase.hxx index 2322b2f2..00ab40dcb88a 100644 --- a/sw/source/filter/ww8/attributeoutputbase.hxx +++ b/sw/source/filter/ww8/attributeoutputbase.hxx @@ -181,7 +181,7 @@ public: virtual void EndRunProperties( const SwRedlineData* pRedlineData ) = 0; /// docx requires footnoteRef/endnoteRef tag at the beginning of each of them -virtual void FootnoteEndnoteRefTag() {}; +virtual bool FootnoteEndnoteRefTag() { return false; }; /// for docx footnotePr/endnotePr inside sectPr virtual void SectFootnoteEndnotePr() {}; diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 1d0a3dfed712..3d7d8b53957e 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -2096,12 +2096,26 @@ void DocxAttributeOutput::WritePostponedDiagram() m_pPostponedDiagrams.reset(nullptr); } -void DocxAttributeOutput::FootnoteEndnoteRefTag() +bool DocxAttributeOutput::FootnoteEndnoteRefTag() { if( m_footnoteEndnoteRefTag == 0 ) -return; +return false; + +// output the character style for MS Word's benefit +const SwEndNoteInfo& rInfo = m_footnoteEndnoteRefTag == XML_footnoteRef ? +m_rExport.m_pDoc->GetFootnoteInfo() : m_rExport.m_pDoc->GetEndNoteInfo(); +const SwCharFormat* pCharFormat = rInfo.GetCharFormat( *m_rExport.m_pDoc ); +if ( pCharFormat ) +{ +const OString aStyleId(m_rExport.m_pStyles->GetStyleId(m_rExport.GetId(pCharFormat))); +m_pSerializer->startElementNS( XML_w, XML_rPr, FSEND ); +m_pSerializer->singleElementNS( XML_w, XML_rStyle, FSNS( XML_w, XML_val ), aStyleId.getStr(), FSEND ); +m_pSerializer->endElementNS( XML_w, XML_rPr ); +} + m_pSerializer->singleElementNS( XML_w, m_footnoteEndnoteRefTag, FSEND ); m_footnoteEndnoteRefTag = 0; +return true; } /** Output sal_Unicode* as a run text (the text). diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index d06486403a07..8024566433f6 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -174,7 +174,7 @@ public: /// Called after we end outputting the attributes. virtual void EndRunProperties( const SwRedlineData* pRedlineData ) override; -virtual void FootnoteEndnoteRefTag() override; +virtual bool FootnoteEndnoteRefTag() override; virtual void
Re: Git help needed: update local repo to specific branch or tag
Hi, On Fri, Sep 15, 2017 at 06:33:17PM +0200, Stephan Bergmannwrote: > >if [ ... ]; then > > git fetch --prune --tags origin > > # cleanup all patched stuff - probably not needed > > git reset --hard > > git checkout --detached "origin/${my_gitbranch?}" Whether the above git fetch will put origin's master branch to origin/master or master (the later case is what you call "tags and branches behave the same way") depends on the refspec of the remote named "origin", which is configured when the "origin" remote is created. Depending on 'git remote add' was invoked with the --mirror=fetch option (either directly or via 'git clone --mirror') .git/config contains something like: [remote "origin"] fetch = +refs/heads/*:refs/remotes/origin/* (normal case, master is available as origin/master) or [remote "origin"] fetch = +refs/*:refs/* (mirror case) So if the refspec is set up correctly, you should be able to transparently use tags/branches the same way. (Normally it's valuable that origin's master is written to origin/master, so your local master branch does not change when you do 'git fetch', that's why --mirror=fetch is not the default.) Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 111967] Vertical text in table formatted incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=111967 Commit Notificationchanged: What|Removed |Added Whiteboard||target:6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111967] Vertical text in table formatted incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=111967 --- Comment #19 from Commit Notification--- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=79ceef1dd0970055a8de0f0676e1cd992a484ee1 related: tdf#111967 fix assertions about silly column positions It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uiview/viewtab.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 79ceef1dd0970055a8de0f0676e1cd992a484ee1 Author: Michael StahlDate: Fri Sep 15 23:28:02 2017 +0200 related: tdf#111967 fix assertions about silly column positions ImplLogicToPixel() is called with ~LONG_MIN value, which comes from SwView::StateTabWin() where we have: (rr) p aTabCols $12 = { nLeftMin = 1134, nLeft = 0, nRight = 4618, nRightMax = 9223372036854775807, bLastRowAllowedToChange = true, aData = std::__debug::vector of length 9, capacity 16 = {{ nPos = 387, nMin = 0, nMax = 9223372036854775807, bHidden = false }, { The problem is that the "aTabCols.GetRight() - rEntry.nMax" becomes negative, which is probably wrong, so enforce a minimum of 0. (regression from 4c60f722afdc0be5c129ce5f5ed6786d09d0051e, which removed a cast of the value to sal_uInt16, which also didn't look right to me, but perhaps wouldn't cause this assert?) Change-Id: Ia1aa2cd100ac25a8c34902cc992d54954fead284 diff --git a/sw/source/uibase/uiview/viewtab.cxx b/sw/source/uibase/uiview/viewtab.cxx index ef8b0752eeb6..7d969e5430fd 100644 --- a/sw/source/uibase/uiview/viewtab.cxx +++ b/sw/source/uibase/uiview/viewtab.cxx @@ -1959,8 +1959,8 @@ void SwView::StateTabWin(SfxItemSet& rSet) { nEnd = aTabCols.GetRight() - rEntry.nPos; SvxColumnDescription aColDesc( nStart, nEnd, -aTabCols.GetRight() - rEntry.nMax, -aTabCols.GetRight() - rEntry.nMin, +std::max(0L, aTabCols.GetRight() - rEntry.nMax), +std::max(0L, aTabCols.GetRight() - rEntry.nMin), !aTabCols.IsHidden(i) ); aColItem.Append(aColDesc); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97448] Create a helper to generate an AddOns.xcu for an extension
https://bugs.documentfoundation.org/show_bug.cgi?id=97448 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|siddhartha.gairola18@gmail. |libreoffice-b...@lists.free |com |desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94695] osl_createHostAddrByAddr uses non-threadsafe gethostbyaddr
https://bugs.documentfoundation.org/show_bug.cgi?id=94695 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|rbzohar...@gmail.com|libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104650] Progress bar is not removed after DOCX open error
https://bugs.documentfoundation.org/show_bug.cgi?id=104650 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|arn...@dumas.at |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108580] Cannot run LibreOffice, api-ms-win-crt-runtime-l1-1-0.dll is missing ( for local solution see comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=108580 --- Comment #17 from Kumāra--- (In reply to Libomark from comment #16) > Anyone coming new to LO would likely just give up and look for something > else: failed installations are IMHO a critical error - nothing works. I agree. Can we have this escalated to critical? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 100370] Status bar functions - Selection Icon not working properly on left mouse click
https://bugs.documentfoundation.org/show_bug.cgi?id=100370 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|marco.filippozzi@studiostor |libreoffice-b...@lists.free |ti.com |desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 100370] Status bar functions - Selection Icon not working properly on left mouse click
https://bugs.documentfoundation.org/show_bug.cgi?id=100370 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|marco.filippozzi@studiostor |libreoffice-b...@lists.free |ti.com |desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112463] New: No Windows Start menu entries for LO components: file close doesn't leave you in application
https://bugs.documentfoundation.org/show_bug.cgi?id=112463 Bug ID: 112463 Summary: No Windows Start menu entries for LO components: file close doesn't leave you in application Product: LibreOffice Version: 5.4.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pnet...@f2s.com On installation of 5.4.1.2 (x64) Build ID: a7cb86e6eeb2bf3a5af73a8fac570321527 on Win 7 Professional 64 bit there are no separate entries in the Windows Start menu for the individual components of LO, even when they have been used, and consequently there are no associated pick lists of files from the Windows Start menu, features that were available under my previous 5.2 install. This slows down access - instead of e.g. being able to select Calc in the WS menu to load a new spreadsheet, or to directly select a file from the WS pick list to be opened, the LO start centre must first be opened, and then a new file or recently opened one. The WS menu provided separate lists by application module, which is a convenience when using one module much of the time, with many files, and you need to open a file from a less used component. Also, when closing a file that is the only one remaining open in a module, instead of displaying that module and giving the opportunity to open a different file within it, the fallback is to the LO Start Centre - a new behaviour that is confusing. I did not detect any option in the install process that might affect this new behaviour. I noted that the LO Start Centre Recent Files menu only offered "Clear Documents" as an option, despite displaying thumbnails of files in the main pane. It is failing to link to the recent files list, which does at least appear as a drop down menu within individual LO components. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62014] gdb hooks should be not be group-writeable
https://bugs.documentfoundation.org/show_bug.cgi?id=62014 Shinnokchanged: What|Removed |Added CC||ad...@shinnok.com Assignee|vukasindfel...@gmail.com|libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62014] gdb hooks should be not be group-writeable
https://bugs.documentfoundation.org/show_bug.cgi?id=62014 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97977] FILEOPEN: XSLX - MODE results in wrong calculation
https://bugs.documentfoundation.org/show_bug.cgi?id=97977 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW CC||ad...@shinnok.com Assignee|abhilash300si...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dbui/dbmgr.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6fa56459f1b3ddd7667585d18952cf409f5f8c4c Author: Miklos VajnaDate: Mon Sep 18 11:04:41 2017 +0200 sw dbmgr: fix indent of these statements Change-Id: I4eae19f5a724c44ec382053ace2f3fcd586fd6f3 diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx index 1d0d8a31c4f1..e4aaa658b707 100644 --- a/sw/source/uibase/dbui/dbmgr.cxx +++ b/sw/source/uibase/dbui/dbmgr.cxx @@ -2471,7 +2471,7 @@ SwDSParam* SwDBManager::FindDSData(const SwDBData& rData, bool bCreate) (rData.nCommandType == -1 || rData.nCommandType == pImpl->pMergeData->nCommandType || (bCreate && pImpl->pMergeData->nCommandType == -1))) { - return pImpl->pMergeData; +return pImpl->pMergeData; } SwDSParam* pFound = nullptr; @@ -2518,7 +2518,7 @@ SwDSParam* SwDBManager::FindDSConnection(const OUString& rDataSource, bool bCre if(pImpl->pMergeData && rDataSource == pImpl->pMergeData->sDataSource ) { SetAsUsed(rDataSource); - return pImpl->pMergeData; +return pImpl->pMergeData; } SwDSParam* pFound = nullptr; for (auto & pParam : m_DataSourceParams) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 64900] Write a PyUNO tutorial/walktrough
https://bugs.documentfoundation.org/show_bug.cgi?id=64900 Shinnokchanged: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64900] Write a PyUNO tutorial/walktrough
https://bugs.documentfoundation.org/show_bug.cgi?id=64900 Shinnokchanged: What|Removed |Added CC||ad...@shinnok.com Assignee|abdulghz...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Placement of addon toolbar
On 09/17/2017 09:46 AM, Jan Rheinländer wrote: my Addon defines a toolbar with the following xml. The user can place this toolbar anywhere on the screen, e.g. on the side. But after every update of the Addon ("unopkg add"), the toolbar is back at the top of the screen. Is there a way to prevent that? http://openoffice.org/2001/registry; xmlns:xs="http://www.w3.org/2001/XMLSchema; oor:name="WriterWindowState" oor:package="org.openoffice.Office.UI"> If you use oor:op="fuse" instead of "replace", an already existing set element will not be replaced completely. Only the props given explicitly here will take on their new values. Any other props ("Pos", "Size", etc.) will keep the values already set (if any). (The latter may or may not be a problem for your actual use case. There's unfortunately no way to add the set element with the given props only if the set element does not yet exist, and otherwise leave it completely alone.) false iMath iMath true true ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 112449] windows10 freezes when colomn E is copy
https://bugs.documentfoundation.org/show_bug.cgi?id=112449 Xisco Faulíchanged: What|Removed |Added Summary|Crash OS windows10 when |windows10 freezes when |colomn E is copy|colomn E is copy -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/fmtflcnt.hxx | 10 +- sw/source/core/txtnode/atrflyin.cxx | 16 2 files changed, 13 insertions(+), 13 deletions(-) New commits: commit a577f6fb33eb83f44370cf648b799ef808e97247 Author: Miklos VajnaDate: Mon Sep 18 09:58:03 2017 +0200 sw: prefix members of SwFormatFlyCnt Change-Id: I41c611d4babe227ce298ed8d6ba3d9e05da5a82b Reviewed-on: https://gerrit.libreoffice.org/42404 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sw/inc/fmtflcnt.hxx b/sw/inc/fmtflcnt.hxx index 57873510d8b0..18ba66c2fb48 100644 --- a/sw/inc/fmtflcnt.hxx +++ b/sw/inc/fmtflcnt.hxx @@ -32,8 +32,8 @@ class SwTextFlyCnt; class SwFormatFlyCnt : public SfxPoolItem { friend class SwTextFlyCnt; -SwTextFlyCnt* pTextAttr; -SwFrameFormat* pFormat; ///< My Fly/DrawFrame-format. +SwTextFlyCnt* m_pTextAttr; +SwFrameFormat* m_pFormat; ///< My Fly/DrawFrame-format. SwFormatFlyCnt& operator=(const SwFormatFlyCnt& rFlyCnt) = delete; public: @@ -42,11 +42,11 @@ public: virtual booloperator==( const SfxPoolItem& ) const override; virtual SfxPoolItem*Clone( SfxItemPool* pPool = nullptr ) const override; -SwFrameFormat *GetFrameFormat() const { return pFormat; } +SwFrameFormat *GetFrameFormat() const { return m_pFormat; } /// For Undo: delete the FlyFrameFormat "logically"; it is kept in Undo-object. -void SetFlyFormat( SwFrameFormat* pNew = nullptr ) { pFormat = pNew; } +void SetFlyFormat( SwFrameFormat* pNew = nullptr ) { m_pFormat = pNew; } -const SwTextFlyCnt *GetTextFlyCnt() const { return pTextAttr; } +const SwTextFlyCnt *GetTextFlyCnt() const { return m_pTextAttr; } }; #endif diff --git a/sw/source/core/txtnode/atrflyin.cxx b/sw/source/core/txtnode/atrflyin.cxx index b4ca1e96e704..26d34a1740d5 100644 --- a/sw/source/core/txtnode/atrflyin.cxx +++ b/sw/source/core/txtnode/atrflyin.cxx @@ -37,28 +37,28 @@ SwFormatFlyCnt::SwFormatFlyCnt( SwFrameFormat *pFrameFormat ) : SfxPoolItem( RES_TXTATR_FLYCNT ), -pTextAttr( nullptr ), -pFormat( pFrameFormat ) +m_pTextAttr( nullptr ), +m_pFormat( pFrameFormat ) { } bool SwFormatFlyCnt::operator==( const SfxPoolItem& rAttr ) const { assert(SfxPoolItem::operator==(rAttr)); -return( pTextAttr && static_cast(rAttr).pTextAttr && -pTextAttr->GetStart() == static_cast(rAttr).pTextAttr->GetStart() && -pFormat == static_cast(rAttr).GetFrameFormat() ); +return( m_pTextAttr && static_cast(rAttr).m_pTextAttr && +m_pTextAttr->GetStart() == static_cast(rAttr).m_pTextAttr->GetStart() && +m_pFormat == static_cast(rAttr).GetFrameFormat() ); } SfxPoolItem* SwFormatFlyCnt::Clone( SfxItemPool* ) const { -return new SwFormatFlyCnt( pFormat ); +return new SwFormatFlyCnt( m_pFormat ); } SwTextFlyCnt::SwTextFlyCnt( SwFormatFlyCnt& rAttr, sal_Int32 nStartPos ) : SwTextAttr( rAttr, nStartPos ) { -rAttr.pTextAttr = this; +rAttr.m_pTextAttr = this; SetHasDummyChar(true); } @@ -214,7 +214,7 @@ SwFlyInContentFrame *SwTextFlyCnt::GetFlyFrame_( const SwFrame *pCurrFrame ) return nullptr; } -SwIterator aIter( *GetFlyCnt().pFormat ); +SwIterator aIter( *GetFlyCnt().m_pFormat ); assert(pCurrFrame->IsTextFrame()); SwFrame* pFrame = aIter.First(); if ( pFrame ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112449] Crash OS windows10 when colomn E is copy
https://bugs.documentfoundation.org/show_bug.cgi?id=112449 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Is OpenGL enabled? if so, what happens if you disable it? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 Xisco Faulíchanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- (In reply to V Stuart Foote from comment #1) > The Menu "hamburger" is at the right edge of the compact groupedbar. > > Click to toggle the main menu visible, change notebook bar mode there. I agree with V Stuart. Anyway, let's add the UX team here to hear their opinion -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 Xisco Faulíchanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- (In reply to V Stuart Foote from comment #1) > The Menu "hamburger" is at the right edge of the compact groupedbar. > > Click to toggle the main menu visible, change notebook bar mode there. I agree with V Stuart. Anyway, let's add the UX team here to hear their opinion -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact mode not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 sergio.calleg...@gmail.com changed: What|Removed |Added Summary|Method to deactivate|Method to deactivate |notebookbar in groupedbar |notebookbar in groupedbar |compact not discoverable|compact mode not ||discoverable -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar in groupedbar compact not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 sergio.calleg...@gmail.com changed: What|Removed |Added Summary|Method to deactivate|Method to deactivate |notebookbar not |notebookbar in groupedbar |discoverable|compact not discoverable -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 --- Comment #3 from sergio.calleg...@gmail.com --- Would be great if the menu button could be at least given a tooltip and pushed to the right as for the standard groupedbar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112462] Writer formula bar ignores locale
https://bugs.documentfoundation.org/show_bug.cgi?id=112462 Dieter Praaschanged: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #1 from Dieter Praas --- Can't reproduce it with German as language Step 6: writer interprets the number correct Step 8: writer changes from 67.20 to 6720 I changed the language in the "Format Number" dialog to Italian and everything still was correct. Version: 5.4.2.1 (x64) Build-ID: dfa67a98bede79c671438308dc9036d50465d2cb CPU-Threads: 4; Betriebssystem:Windows 6.19; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112435] navigator does not scroll when navigating to inactive document
https://bugs.documentfoundation.org/show_bug.cgi?id=112435 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #7 from Xisco Faulí --- I can't reproduce it with comments in Version: 6.0.0.0.alpha0+ Build ID: 83288332f7ced698610739419989c464256f1c4d CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112457] Method to deactivate notebookbar not discoverable
https://bugs.documentfoundation.org/show_bug.cgi?id=112457 sergio.calleg...@gmail.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INVALID |--- Summary|Method to deactivate|Method to deactivate |notebookbar is absent or|notebookbar not |not discoverable|discoverable --- Comment #2 from sergio.calleg...@gmail.com --- Reopening as the point is that it is not discoverable enough, then. 1) Icon almost identical to the one of text align justify (at least with kde integration) 2) No tooltip. Are users expected to click all buttons of the notebookbar to find the one to get the menus? 3) Not on the "View" region of the notebookbar. Conversely, the "View" region has an icon whose tooltip says "Shows or hides the menus [...] in writer and calc" which actually does not let you show the menu (since it enters and exists fullscreen mode, basically). 4) No mention of it in the online help. 5) Not consistent with the "standard" (i.e., not compact) groupedbar, where the button to get the menus back is pushed totally to the right, to separate it from the rest of the buttons. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112426] Proposal for a PDF import settings dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=112426 --- Comment #7 from Heiko Tietze--- There are plenty of PDF tools to merge or split files [1]. LibreOffice is not a PDF editor and this request is out of scope to me. [1] https://duckduckgo.com/?q=split+pdf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53826] Value Highlighting separately activated
https://bugs.documentfoundation.org/show_bug.cgi?id=53826 --- Comment #4 from Heiko Tietze--- Never seen highlighting enabled individually. And I don't get the use case. What we could do is to offer various sets of highlight colors (like text editors allow to show content like html, c++, or pascal) and allow the user to edit the pieces. And disabling a feature would mean to just make this color black. But I would not place checkboxes on a dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py
esc-reporting/esc-analyze.py |7 --- 1 file changed, 7 deletions(-) New commits: commit 252dd394b1df99035c80a3b3da9c53dac3bdaf86 Author: Xisco FauliDate: Mon Sep 18 10:43:28 2017 +0200 This code changes things in Bugzilla on my behalf and I don't like it. Removing it. The assigned issues are already covered by qa-tools diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py index 756de84..458178e 100755 --- a/esc-reporting/esc-analyze.py +++ b/esc-reporting/esc-analyze.py @@ -615,10 +615,7 @@ def analyze_reports(): automateList['gerrit']['to_abandon_abandon'] = {} automateList['gerrit']['to_abandon_comment'] = {} automateList['gerrit']['to_review'] = {} -automateList['bugzilla']['assign_problem_status'] = {} -automateList['bugzilla']['assign_problem_user'] = {} automateList['bugzilla']['missing_cc'] = {} -automateList['bugzilla']['missing_ui_cc'] = {} automateList['bugzilla']['remove_cc'] = {} automateList['bugzilla']['to_unassign_comment'] = {} automateList['bugzilla']['to_unassign_unassign'] = {} @@ -750,10 +747,6 @@ def analyze_reports(): automateList['bugzilla']['to_unassign_unassign'][key]= 0 else: automateList['bugzilla']['to_unassign_comment'][key] = 0 - if row['status'] == 'ASSIGNED' and (row['assigned_to'] == '' or row['assigned_to'] == 'libreoffice-b...@lists.freedesktop.org'): -automateList['bugzilla']['assign_problem_status'][key] = 0 - if row['status'] != 'CLOSED' and row['status'] != 'ASSIGNED' and row['assigned_to'] != '' and row['assigned_to'] != 'libreoffice-b...@lists.freedesktop.org': - automateList['bugzilla']['assign_problem_user'][key] = 0 if len(row['comments']) >= 5: statList['reportList']['too_many_comments'].append(key) if not 'mentor...@documentfoundation.org' in row['cc']: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 77824] Display metric units on ruler in multiples of 5 when possible (i.e., for certain scale + zoom levels)
https://bugs.documentfoundation.org/show_bug.cgi?id=77824 --- Comment #6 from Heiko Tietze--- (In reply to Yousuf Philips (jay) from comment #5) > 100%: 0, 5, 10, 15, 20 > 140%: 0, 4, 8, 12, 16 > 180%: 0, 3, 6, 9, 12 > 250%: 0, 2, 4, 6, 8 440%: 0, 1, 2, 3, 4 If you have a page size that makes millimeter necessary, for example 10x10 cm, you start with a zoom level of 220%. Talking about A4 pages the better choice is centimeter with 100% zoom - and there you get the 5mm steps up to a zoom level of 130%. Work perfectly for me too. We also provide meter or foot and with this setting you will not get any label for average page sizes. Having fix steps makes no sense. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112330] Improve management of label formats
https://bugs.documentfoundation.org/show_bug.cgi?id=112330 --- Comment #3 from Winfried Donkers--- (In reply to Kalle Richter from comment #2) > A pity. I can't contribute anything codewise. Well, there's always the possibility that someone else sees possibilities to work on this enhancements. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112462] New: Writer formula bar ignores locale
https://bugs.documentfoundation.org/show_bug.cgi?id=112462 Bug ID: 112462 Summary: Writer formula bar ignores locale Product: LibreOffice Version: 5.4.1.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sergio.calleg...@gmail.com Description: On systems with LibO set to use the comma (,) as a decimal separator, the formula bar in writer insists that numbers are entered using the dot (.) as a decimal separator Steps to Reproduce: 1. Open writer, assure that the locale is set so as to use the comma as a decimal separator 2. Create a table 3. Write a number with decimal digits into a cell using the comma as the decimal separator (e.g. 67,20) 4. Use the Table->Number format function to assure that the number is correctly interpreted as such, with the correct magnitude 5. Now, go to another cell. Enter "=" or "F2" so that the formula bar opens 6. Enter the same number as above with the same formatting (e.g., 67,20) 7. Now, go to another cell. Enter "=" or "F2" so that the formula bar opens 8. Enter the same number as above, now using the dot as the decimal separator (e.g., 67.20) 3. Actual Results: Libreoffice writer at point 6 interpretes the number as if there were no decimal separator (e.g., 6720). At point 8 it interprets the number correctly Expected Results: At 6 Writer should have interpreted the number considering the decimal separator. At 8 it should not have. Incidentally, note that the formula bar in calc works as expected, differently from the one in writer. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Note that the automatically included information above is incorrect. If I go to the LibO Tools->Options->Language Settings->Languages, then I have en-US as the user interface setting, but Italian as the Locale. Builds ID: LibreOffice 5.4.2.1 User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108580] Cannot run LibreOffice, api-ms-win-crt-runtime-l1-1-0.dll is missing ( for local solution see comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=108580 Libomarkchanged: What|Removed |Added CC||pnet...@f2s.com --- Comment #16 from Libomark --- This is the second time I have failed to install a 5.4 version of LO because of this failure. I had hoped it would have been resolved by now. I did not find the link mentioned in comment 7 was entirely transparent - it offers two different packages to download, with no explanation as to which is what. I guessed correctly, but I think more guidance (or a proper resolution) might help others. Anyone coming new to LO would likely just give up and look for something else: failed installations are IMHO a critical error - nothing works. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] libvisio.git: src/conv src/lib
src/conv/raw/vsd2raw.cpp|2 +- src/conv/raw/vss2raw.cpp|2 +- src/conv/svg/vsd2xhtml.cpp |2 +- src/conv/svg/vss2xhtml.cpp |2 +- src/conv/text/vsd2text.cpp |2 +- src/conv/text/vss2text.cpp |2 +- src/lib/VDXParser.cpp |6 +++--- src/lib/VSD5Parser.cpp |2 +- src/lib/VSDContentCollector.cpp | 16 src/lib/VSDContentCollector.h |4 ++-- src/lib/VSDFieldList.cpp|2 +- src/lib/VSDGeometryList.cpp |2 +- src/lib/VSDInternalStream.cpp |4 ++-- src/lib/VSDInternalStream.h |6 +++--- src/lib/VSDLayerList.cpp|6 +++--- src/lib/VSDMetaData.cpp |2 +- src/lib/VSDParser.cpp | 14 +++--- src/lib/VSDParser.h |2 +- src/lib/VSDStencils.cpp | 32 src/lib/VSDXMLHelper.cpp| 10 +- src/lib/VSDXMLParserBase.cpp|8 src/lib/VSDXMetaData.cpp|2 +- src/lib/VSDXParser.cpp | 12 ++-- src/lib/VSDXTheme.cpp |2 +- src/lib/VisioDocument.cpp |2 +- src/lib/libvisio_xml.h |2 +- 26 files changed, 74 insertions(+), 74 deletions(-) New commits: commit 7cf4bf3b624fadb327a54c63d880ee664e8434b5 Author: Miklos VajnaDate: Mon Sep 18 10:34:05 2017 +0200 Convert 0 to nullptr where it's used as a pointer value To make the code easier to read, because this means the remaining zeros all mean numbers. Change-Id: I677df217aae81e15496d47a93daaab633d8b903f diff --git a/src/conv/raw/vsd2raw.cpp b/src/conv/raw/vsd2raw.cpp index b9ffde9..ce15260 100644 --- a/src/conv/raw/vsd2raw.cpp +++ b/src/conv/raw/vsd2raw.cpp @@ -54,7 +54,7 @@ int printVersion() int main(int argc, char *argv[]) { bool printIndentLevel = false; - char *file = 0; + char *file = nullptr; if (argc < 2) return printUsage(); diff --git a/src/conv/raw/vss2raw.cpp b/src/conv/raw/vss2raw.cpp index 4af8e3c..8f1b311 100644 --- a/src/conv/raw/vss2raw.cpp +++ b/src/conv/raw/vss2raw.cpp @@ -54,7 +54,7 @@ int printVersion() int main(int argc, char *argv[]) { bool printIndentLevel = false; - char *file = 0; + char *file = nullptr; if (argc < 2) return printUsage(); diff --git a/src/conv/svg/vsd2xhtml.cpp b/src/conv/svg/vsd2xhtml.cpp index cc91c85..7801eee 100644 --- a/src/conv/svg/vsd2xhtml.cpp +++ b/src/conv/svg/vsd2xhtml.cpp @@ -54,7 +54,7 @@ int main(int argc, char *argv[]) if (argc < 2) return printUsage(); - char *file = 0; + char *file = nullptr; for (int i = 1; i < argc; i++) { diff --git a/src/conv/svg/vss2xhtml.cpp b/src/conv/svg/vss2xhtml.cpp index f466988..edfeea5 100644 --- a/src/conv/svg/vss2xhtml.cpp +++ b/src/conv/svg/vss2xhtml.cpp @@ -54,7 +54,7 @@ int main(int argc, char *argv[]) if (argc < 2) return printUsage(); - char *file = 0; + char *file = nullptr; for (int i = 1; i < argc; i++) { diff --git a/src/conv/text/vsd2text.cpp b/src/conv/text/vsd2text.cpp index e5fe090..1d9d5fb 100644 --- a/src/conv/text/vsd2text.cpp +++ b/src/conv/text/vsd2text.cpp @@ -53,7 +53,7 @@ int main(int argc, char *argv[]) if (argc < 2) return printUsage(); - char *file = 0; + char *file = nullptr; for (int i = 1; i < argc; i++) { diff --git a/src/conv/text/vss2text.cpp b/src/conv/text/vss2text.cpp index dd8148e..f1e80f9 100644 --- a/src/conv/text/vss2text.cpp +++ b/src/conv/text/vss2text.cpp @@ -53,7 +53,7 @@ int main(int argc, char *argv[]) if (argc < 2) return printUsage(); - char *file = 0; + char *file = nullptr; for (int i = 1; i < argc; i++) { diff --git a/src/lib/VDXParser.cpp b/src/lib/VDXParser.cpp index 2a3304b..ef6f7c6 100644 --- a/src/lib/VDXParser.cpp +++ b/src/lib/VDXParser.cpp @@ -75,7 +75,7 @@ bool libvisio::VDXParser::processXmlDocument(librevenge::RVNGInputStream *input) return false; const std::shared_ptr reader( -xmlReaderForStream(input, 0, 0, XML_PARSE_NOBLANKS|XML_PARSE_NOENT|XML_PARSE_NONET|XML_PARSE_RECOVER), +xmlReaderForStream(input, nullptr, nullptr, XML_PARSE_NOBLANKS|XML_PARSE_NOENT|XML_PARSE_NONET|XML_PARSE_RECOVER), xmlFreeTextReader); if (!reader) return false; @@ -920,7 +920,7 @@ xmlChar *libvisio::VDXParser::readStringData(xmlTextReaderPtr reader) return stringValue; } } - return 0; + return nullptr; } int libvisio::VDXParser::getElementToken(xmlTextReaderPtr reader) @@ -1032,7 +1032,7 @@ void libvisio::VDXParser::readTabs(xmlTextReaderPtr reader) } while ((XML_TABS != tokenId || XML_READER_TYPE_END_ELEMENT != tokenType) && 1 == ret && (!m_watcher || !m_watcher->isError())); } - m_currentTabSet = 0; + m_currentTabSet = nullptr; } void libvisio::VDXParser::readTab(xmlTextReaderPtr reader) diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp index fd5b298..c3f80fd 100644
[Libreoffice-bugs] [Bug 112380] Built-in Help Not Installed but I did install it
https://bugs.documentfoundation.org/show_bug.cgi?id=112380 Jacques Guilleronchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #9 from Jacques Guilleron --- Thank you for the feed back. Have a nice day, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109016] FILESAVE XLSX PIVOTTABLE: Filter set on row fields not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=109016 --- Comment #9 from Gabor Kelemen--- Created attachment 136335 --> https://bugs.documentfoundation.org/attachment.cgi?id=136335=edit Screenshot of the document in Excel 2013 Indeed the filtering of your example looks fixed, thanks. However, it looks like the pivot table itself is completely gone. Is that a known regression? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54975] RFE: Value Highlighting: do not highlight constant expressions as formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=54975 --- Comment #12 from Heiko Tietze--- Created attachment 136334 --> https://bugs.documentfoundation.org/attachment.cgi?id=136334=edit Various colors Good idea to mix blue and green. Though #008080 is barely to distinguish from each other so I suggest to use violet if the difference is important or light teal 1 in case it's less relevant (my take here). Ideally, the complete set of highlighting colors can be changed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112431] CalcA11y extremely Slow when opening a second Document
https://bugs.documentfoundation.org/show_bug.cgi?id=112431 Alex ARNAUDchanged: What|Removed |Added Summary|CalcA11y extremely Slow |CalcA11y extremely Slow |when when opening a second |when opening a second |Document|Document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107467] Scalable tools for furigana (ruby) input: compatibility with other document formats (e.g. HTML5)
https://bugs.documentfoundation.org/show_bug.cgi?id=107467 --- Comment #2 from Volga--- MDN has related information for this https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ruby Also, there are several CSS properties related to HTML Ruby https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Ruby -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108846] FILEOPEN PPTX Fuzzy images when viewed in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=108846 Buovjagachanged: What|Removed |Added Keywords||regression Status|NEEDINFO|NEW Version|5.2.6.2 release |4.3.0.4 release --- Comment #7 from Buovjaga --- (In reply to Kevin Evans from comment #6) > Any word on a possible fix for this issue? That's not what the needinfo status is for: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO Yet, now I did more testing and noticed it is imported correctly in version 3.5, so this is a regression. Sadly, we don't have bibisect repositories for versions earlier than 4.3. Already bad in Version: 4.3.0.0.beta1 Build ID: b7cfa1eab1cb1e94f71d6df6612b73f231d0bf92 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: esc-reporting/qa-tools.py
esc-reporting/qa-tools.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 81e104ee6a7c1d0c08e718969fa792b3e27ebc64 Author: Xisco FauliDate: Mon Sep 18 10:14:42 2017 +0200 Fix issue with metabugs removed diff --git a/esc-reporting/qa-tools.py b/esc-reporting/qa-tools.py index 13a0970..fa301f7 100755 --- a/esc-reporting/qa-tools.py +++ b/esc-reporting/qa-tools.py @@ -391,7 +391,7 @@ def analyze_bugzilla(statList, bugzillaData, cfg, lIgnore): #TODO #util_increase_user_actions(statList, key, actionMail, bugTargets, 'metabug_added', actionDate) -if actionDate >= cfg[reportPeriod] and int(metabug) in row['blocks']: +if actionDate >= cfg[reportPeriod] and int(metabug) not in row['blocks']: if metabug not in statList['detailedReport']['metabug_removed']: statList['detailedReport']['metabug_removed'][metabug] = 0 statList['detailedReport']['lists']['metabug_removed'][metabug] = [[],[]] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: net/Socket.hpp
net/Socket.hpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f375a9d5de400b0da00b7065eac8927ab8ed891e Author: Miklos VajnaDate: Mon Sep 18 10:15:49 2017 +0200 Socket: mark setNoDelay() as non-virtual No derived classes override it, and if they would, that would be a problem, as setNoDelay() is called from init(), which is called from the Socket ctor. Calling virtual functions from the base class ctor is not a good idea, since the object is not fully constructed yet. Change-Id: I4993e26d09f5d3429c7e2afae7688b84c0061c9d diff --git a/net/Socket.hpp b/net/Socket.hpp index 3442fdb1..62a743b5 100644 --- a/net/Socket.hpp +++ b/net/Socket.hpp @@ -135,7 +135,7 @@ public: int events) = 0; /// manage latency issues around packet aggregation -virtual void setNoDelay() +void setNoDelay() { const int val = 1; ::setsockopt(_fd, IPPROTO_TCP, TCP_NODELAY, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] Weekly QA Report (W37-2017)
Hello, What have happened in QA in the last 7 days? * 142 have been created, of which, 50 are still unconfirmed ( Total Unconfirmed bugs: 410 ) Link: http://tinyurl.com/yadx4hq9 * 1054 comments have been written. == STATUS CHANGED == * 18 bugs have been changed to 'ASSIGNED'. Link: http://tinyurl.com/y793sbnu Done by: Xisco Faulí ( 4 ), Julien Nabet ( 3 ), Winfried Donkers ( 2 ), serge.krot ( 2 ), Sabin.Frandes ( 2 ), Miklos Vajna ( 1 ), Regina Henschel ( 1 ), Maxim Monastirsky ( 1 ), Dennis Francis ( 1 ), Aron Budea ( 1 ) * 2 bugs have been changed to 'CLOSED'. Link: http://tinyurl.com/ybxj6cdz Done by: Eike Rathke ( 2 ) * 27 bugs have been changed to 'NEEDINFO'. Link: http://tinyurl.com/yamec8ev Done by: Xisco Faulí ( 11 ), Alex Thurgood ( 3 ), Julien Nabet ( 2 ), Jean-Baptiste Faure ( 2 ), Jacques Guilleron ( 2 ), Dieter Praas ( 2 ), V Stuart Foote ( 1 ), Buovjaga ( 1 ), raal ( 1 ), m.a.riosv ( 1 ), Kevin Evans ( 1 ) * 102 bugs have been changed to 'NEW'. Link: http://tinyurl.com/yat9nsln Done by: Xisco Faulí ( 52 ), Buovjaga ( 8 ), raal ( 7 ), Dieter Praas ( 5 ), Aron Budea ( 5 ), Yousuf Philips (jay) ( 4 ), V Stuart Foote ( 3 ), Thomas Lendo ( 3 ), Jacques Guilleron ( 3 ), Heiko Tietze ( 2 ), Winfried Donkers ( 1 ), Andras Timar ( 1 ), Thorsten Behrens (CIB) ( 1 ), Muhammet Kara ( 1 ), m.a.riosv ( 1 ), Michael Meeks ( 1 ), Khaled Hosny ( 1 ), Bartosz ( 1 ), Eike Rathke ( 1 ), kompilainenn ( 1 ) * 4 bugs have been changed to 'REOPENED'. Link: http://tinyurl.com/y9hnecr9 Done by: Sierk Bornemann ( 1 ), Jim Raykowski ( 1 ), Hamid ( 1 ), ajimady ( 1 ) * 33 bugs have been changed to 'RESOLVED DUPLICATE'. Link: http://tinyurl.com/y8gdmaqg Done by: Xisco Faulí ( 9 ), Alex Thurgood ( 4 ), V Stuart Foote ( 3 ), Telesto ( 3 ), Buovjaga ( 2 ), Julien Nabet ( 2 ), Yousuf Philips (jay) ( 2 ), Regina Henschel ( 1 ), raal ( 1 ), Maxim Monastirsky ( 1 ), m.a.riosv ( 1 ), Timur ( 1 ), Dieter Praas ( 1 ), Cor Nouws ( 1 ), Aron Budea ( 1 ) * 31 bugs have been changed to 'RESOLVED FIXED'. Link: http://tinyurl.com/ybzjc3zu Done by: Tamás Zolnai ( 5 ), Julien Nabet ( 3 ), Muhammet Kara ( 2 ), Michael Stahl ( 2 ), Caolán McNamara ( 2 ), Armin Le Grand (CIB) ( 2 ), Xisco Faulí ( 1 ), Winfried Donkers ( 1 ), V Stuart Foote ( 1 ), Miklos Vajna ( 1 ), Heiko Tietze ( 1 ), Thorsten Behrens (CIB) ( 1 ), Szymon Kłos ( 1 ), serge.krot ( 1 ), Olivier Hallot ( 1 ), Mike Kaganski ( 1 ), Jan Holesovsky ( 1 ), Timur ( 1 ), Adolfo Jayme ( 1 ), Dennis Francis ( 1 ), Andreas Brandner ( 1 ) * 2 bugs have been changed to 'RESOLVED INSUFFICIENTDATA'. Link: http://tinyurl.com/ya3ztr4k Done by: V Stuart Foote ( 2 ) * 2 bugs have been changed to 'RESOLVED INVALID'. Link: http://tinyurl.com/y7eoafoh Done by: Telesto ( 1 ), alex.wies ( 1 ) * 4 bugs have been changed to 'RESOLVED NOTABUG'. Link: http://tinyurl.com/y6uhtcmr Done by: Xisco Faulí ( 1 ), Telesto ( 1 ), ludwig Lichtenberg ( 1 ), Adolfo Jayme ( 1 ) * 9 bugs have been changed to 'RESOLVED WONTFIX'. Link: http://tinyurl.com/y8q9ythl Done by: V Stuart Foote ( 5 ), Buovjaga ( 2 ), Olivier Hallot ( 1 ), Markus Mohrhard ( 1 ) * 21 bugs have been changed to 'RESOLVED WORKSFORME'. Link: http://tinyurl.com/ycxjgt6t Done by: Bartosz ( 3 ), Xisco Faulí ( 2 ), Heiko Tietze ( 2 ), Thomas Lendo ( 2 ), Yousuf Philips (jay) ( 2 ), V Stuart Foote ( 1 ), Buovjaga ( 1 ), Julien Nabet ( 1 ), raal ( 1 ), Markus Mohrhard ( 1 ), Michal Janoušek ( 1 ), Jesper Laugesen ( 1 ), Harald Koester ( 1 ), Timur ( 1 ), lukash256 ( 1 ) * 15 bugs have been changed to 'UNCONFIRMED'. Link: http://tinyurl.com/y7qmt7qq Done by: Xisco Faulí ( 4 ), PaulJayD ( 2 ), m.a.riosv ( 2 ), lobaluna ( 1 ), Jim Raykowski ( 1 ), Joseph Conner ( 1 ), Jean-Baptiste Faure ( 1 ), H3xag0n ( 1 ), Eric ( 1 ), Dereck Wonnacott ( 1 ) * 11 bugs have been changed to 'VERIFIED FIXED'. Link: http://tinyurl.com/ybpxzsn6 Done by: Thomas Lendo ( 3 ), Xisco Faulí ( 1 ), Julien Nabet ( 1 ), Terrence Enger ( 1 ), Alex Thurgood ( 1 ), Jacques Guilleron ( 1 ), Timur ( 1 ), Passiflora ( 1 ), Cor Nouws ( 1 ) == KEYWORDS ADDED == * 'accessibility' has been added to 1 bug. Link: http://tinyurl.com/yackhop3 Done by: Alex ARNAUD ( 1 ) * 'bibisectRequest' has been added to 7 bugs. Link: http://tinyurl.com/ya94qt3u Done by: Xisco Faulí ( 5 ), Buovjaga ( 1 ), Yousuf Philips (jay) ( 1 ) * 'bibisected' has been added to 10 bugs. Link: http://tinyurl.com/y758hnyz Done by: Xisco Faulí ( 6 ), Aron Budea ( 3 ), raal ( 1 ) * 'bisected' has been added to 10 bugs. Link: http://tinyurl.com/ya29f8u5 Done by: Xisco Faulí ( 7 ), raal ( 1 ), Terrence Enger ( 1 ), Aron Budea ( 1 ) * 'easyHack' has been added to 1 bug. Link: http://tinyurl.com/ydfm5ock Done by: Michael Meeks ( 1 ) * 'filter:docx' has been added to 7 bugs. Link: http://tinyurl.com/y8343vff
Weekly QA Report (W37-2017)
Hello, What have happened in QA in the last 7 days? * 142 have been created, of which, 50 are still unconfirmed ( Total Unconfirmed bugs: 410 ) Link: http://tinyurl.com/yadx4hq9 * 1054 comments have been written. == STATUS CHANGED == * 18 bugs have been changed to 'ASSIGNED'. Link: http://tinyurl.com/y793sbnu Done by: Xisco Faulí ( 4 ), Julien Nabet ( 3 ), Winfried Donkers ( 2 ), serge.krot ( 2 ), Sabin.Frandes ( 2 ), Miklos Vajna ( 1 ), Regina Henschel ( 1 ), Maxim Monastirsky ( 1 ), Dennis Francis ( 1 ), Aron Budea ( 1 ) * 2 bugs have been changed to 'CLOSED'. Link: http://tinyurl.com/ybxj6cdz Done by: Eike Rathke ( 2 ) * 27 bugs have been changed to 'NEEDINFO'. Link: http://tinyurl.com/yamec8ev Done by: Xisco Faulí ( 11 ), Alex Thurgood ( 3 ), Julien Nabet ( 2 ), Jean-Baptiste Faure ( 2 ), Jacques Guilleron ( 2 ), Dieter Praas ( 2 ), V Stuart Foote ( 1 ), Buovjaga ( 1 ), raal ( 1 ), m.a.riosv ( 1 ), Kevin Evans ( 1 ) * 102 bugs have been changed to 'NEW'. Link: http://tinyurl.com/yat9nsln Done by: Xisco Faulí ( 52 ), Buovjaga ( 8 ), raal ( 7 ), Dieter Praas ( 5 ), Aron Budea ( 5 ), Yousuf Philips (jay) ( 4 ), V Stuart Foote ( 3 ), Thomas Lendo ( 3 ), Jacques Guilleron ( 3 ), Heiko Tietze ( 2 ), Winfried Donkers ( 1 ), Andras Timar ( 1 ), Thorsten Behrens (CIB) ( 1 ), Muhammet Kara ( 1 ), m.a.riosv ( 1 ), Michael Meeks ( 1 ), Khaled Hosny ( 1 ), Bartosz ( 1 ), Eike Rathke ( 1 ), kompilainenn ( 1 ) * 4 bugs have been changed to 'REOPENED'. Link: http://tinyurl.com/y9hnecr9 Done by: Sierk Bornemann ( 1 ), Jim Raykowski ( 1 ), Hamid ( 1 ), ajimady ( 1 ) * 33 bugs have been changed to 'RESOLVED DUPLICATE'. Link: http://tinyurl.com/y8gdmaqg Done by: Xisco Faulí ( 9 ), Alex Thurgood ( 4 ), V Stuart Foote ( 3 ), Telesto ( 3 ), Buovjaga ( 2 ), Julien Nabet ( 2 ), Yousuf Philips (jay) ( 2 ), Regina Henschel ( 1 ), raal ( 1 ), Maxim Monastirsky ( 1 ), m.a.riosv ( 1 ), Timur ( 1 ), Dieter Praas ( 1 ), Cor Nouws ( 1 ), Aron Budea ( 1 ) * 31 bugs have been changed to 'RESOLVED FIXED'. Link: http://tinyurl.com/ybzjc3zu Done by: Tamás Zolnai ( 5 ), Julien Nabet ( 3 ), Muhammet Kara ( 2 ), Michael Stahl ( 2 ), Caolán McNamara ( 2 ), Armin Le Grand (CIB) ( 2 ), Xisco Faulí ( 1 ), Winfried Donkers ( 1 ), V Stuart Foote ( 1 ), Miklos Vajna ( 1 ), Heiko Tietze ( 1 ), Thorsten Behrens (CIB) ( 1 ), Szymon Kłos ( 1 ), serge.krot ( 1 ), Olivier Hallot ( 1 ), Mike Kaganski ( 1 ), Jan Holesovsky ( 1 ), Timur ( 1 ), Adolfo Jayme ( 1 ), Dennis Francis ( 1 ), Andreas Brandner ( 1 ) * 2 bugs have been changed to 'RESOLVED INSUFFICIENTDATA'. Link: http://tinyurl.com/ya3ztr4k Done by: V Stuart Foote ( 2 ) * 2 bugs have been changed to 'RESOLVED INVALID'. Link: http://tinyurl.com/y7eoafoh Done by: Telesto ( 1 ), alex.wies ( 1 ) * 4 bugs have been changed to 'RESOLVED NOTABUG'. Link: http://tinyurl.com/y6uhtcmr Done by: Xisco Faulí ( 1 ), Telesto ( 1 ), ludwig Lichtenberg ( 1 ), Adolfo Jayme ( 1 ) * 9 bugs have been changed to 'RESOLVED WONTFIX'. Link: http://tinyurl.com/y8q9ythl Done by: V Stuart Foote ( 5 ), Buovjaga ( 2 ), Olivier Hallot ( 1 ), Markus Mohrhard ( 1 ) * 21 bugs have been changed to 'RESOLVED WORKSFORME'. Link: http://tinyurl.com/ycxjgt6t Done by: Bartosz ( 3 ), Xisco Faulí ( 2 ), Heiko Tietze ( 2 ), Thomas Lendo ( 2 ), Yousuf Philips (jay) ( 2 ), V Stuart Foote ( 1 ), Buovjaga ( 1 ), Julien Nabet ( 1 ), raal ( 1 ), Markus Mohrhard ( 1 ), Michal Janoušek ( 1 ), Jesper Laugesen ( 1 ), Harald Koester ( 1 ), Timur ( 1 ), lukash256 ( 1 ) * 15 bugs have been changed to 'UNCONFIRMED'. Link: http://tinyurl.com/y7qmt7qq Done by: Xisco Faulí ( 4 ), PaulJayD ( 2 ), m.a.riosv ( 2 ), lobaluna ( 1 ), Jim Raykowski ( 1 ), Joseph Conner ( 1 ), Jean-Baptiste Faure ( 1 ), H3xag0n ( 1 ), Eric ( 1 ), Dereck Wonnacott ( 1 ) * 11 bugs have been changed to 'VERIFIED FIXED'. Link: http://tinyurl.com/ybpxzsn6 Done by: Thomas Lendo ( 3 ), Xisco Faulí ( 1 ), Julien Nabet ( 1 ), Terrence Enger ( 1 ), Alex Thurgood ( 1 ), Jacques Guilleron ( 1 ), Timur ( 1 ), Passiflora ( 1 ), Cor Nouws ( 1 ) == KEYWORDS ADDED == * 'accessibility' has been added to 1 bug. Link: http://tinyurl.com/yackhop3 Done by: Alex ARNAUD ( 1 ) * 'bibisectRequest' has been added to 7 bugs. Link: http://tinyurl.com/ya94qt3u Done by: Xisco Faulí ( 5 ), Buovjaga ( 1 ), Yousuf Philips (jay) ( 1 ) * 'bibisected' has been added to 10 bugs. Link: http://tinyurl.com/y758hnyz Done by: Xisco Faulí ( 6 ), Aron Budea ( 3 ), raal ( 1 ) * 'bisected' has been added to 10 bugs. Link: http://tinyurl.com/ya29f8u5 Done by: Xisco Faulí ( 7 ), raal ( 1 ), Terrence Enger ( 1 ), Aron Budea ( 1 ) * 'easyHack' has been added to 1 bug. Link: http://tinyurl.com/ydfm5ock Done by: Michael Meeks ( 1 ) * 'filter:docx' has been added to 7 bugs. Link: http://tinyurl.com/y8343vff
[Libreoffice-commits] core.git: sal/osl
sal/osl/w32/file.cxx|8 sal/osl/w32/file_dirvol.cxx |1 + sal/osl/w32/procimpl.cxx|2 ++ sal/osl/w32/signal.cxx |3 +++ 4 files changed, 14 insertions(+) New commits: commit 74cd94a17b3922bdcd44ab6460232297fbf665d0 Author: Stephan BergmannDate: Mon Sep 18 09:59:33 2017 +0200 Put back some #include (needed for e.g. --disable-pch) ...that had been removed too eagerly with 1f543b817a7e8bdef9482c4c61bc1672bf04e39f "osl/w32: don't use 8-bit string functions" Change-Id: I9d16cc5ff9b779457d8d70c7f206d5e684342c63 diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx index f654c1add897..a211464aa2cd 100644 --- a/sal/osl/w32/file.cxx +++ b/sal/osl/w32/file.cxx @@ -19,9 +19,17 @@ #include +#include +#include +#include + #include "file_url.hxx" #include "file_error.hxx" +#include +#include +#include + #ifdef max /* conflict w/ std::numeric_limits::max() */ #undef max #endif diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx index 752d6470ec67..46f185d0554e 100644 --- a/sal/osl/w32/file_dirvol.cxx +++ b/sal/osl/w32/file_dirvol.cxx @@ -27,6 +27,7 @@ #include "rtl/alloc.h" #include "rtl/ustring.hxx" +#include static const wchar_t UNC_PREFIX[] = L""; static const wchar_t BACKSLASH = '\\'; diff --git a/sal/osl/w32/procimpl.cxx b/sal/osl/w32/procimpl.cxx index af5b75e5891f..bc7617f3a834 100644 --- a/sal/osl/w32/procimpl.cxx +++ b/sal/osl/w32/procimpl.cxx @@ -34,8 +34,10 @@ #include #include #include "secimpl.hxx" +#include #include +#include namespace /* private */ { diff --git a/sal/osl/w32/signal.cxx b/sal/osl/w32/signal.cxx index 0f6bc08dc9dc..5f11b8a6bcf6 100644 --- a/sal/osl/w32/signal.cxx +++ b/sal/osl/w32/signal.cxx @@ -17,6 +17,9 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include +#include + #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112386] UI: Scaling of the sheet / fonts is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=112386 --- Comment #7 from jer...@kodsyntes.se --- Created attachment 136333 --> https://bugs.documentfoundation.org/attachment.cgi?id=136333=edit New screen shot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112386] UI: Scaling of the sheet / fonts is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=112386 --- Comment #6 from jer...@kodsyntes.se --- Sorry, don't know how to reproduce. I just started LibreOffice, and then it was like that. The problem is not entirely the same now though, but it still exists. There a smaller difference in size now, to the better, but still quite different. I removed my user profile just to be sure, and the took this screen shot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sax/source
sax/source/expatwrap/xml2utf.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 44815f1439bb36e9fb5f0181c541fc4d0c9422f1 Author: Takeshi AbeDate: Tue Jul 18 22:44:33 2017 +0900 sax: Check if it starts with 5 bytes of "https://gerrit.libreoffice.org/40139 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit b64e564492220b34c14f069e8e1f42675bd9abe6) ofz: string has to be at least 5 chars long Reviewed-on: https://gerrit.libreoffice.org/42379 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara this should presumably be 5, rather than 4 Change-Id: Iec5b748b188c7b1bf61e8137faf4b3f2d480d7f1 98c50a59c03fc886d50362b9c5dd8c84f60e0b62 20c6a6fb34485f42c2a828618e8918d8a441860a Reviewed-on: https://gerrit.libreoffice.org/42395 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sax/source/expatwrap/xml2utf.cxx b/sax/source/expatwrap/xml2utf.cxx index 361e02fc99b0..017a3b1c96e9 100644 --- a/sax/source/expatwrap/xml2utf.cxx +++ b/sax/source/expatwrap/xml2utf.cxx @@ -126,7 +126,7 @@ XMLFile2UTFConverter::~XMLFile2UTFConverter() void XMLFile2UTFConverter::removeEncoding( Sequence ) { const sal_Int8 *pSource = seq.getArray(); -if( ! strncmp( reinterpret_cast(pSource), "= 5 && !strncmp(reinterpret_cast(pSource), " ) &( seq.getArray()[nStop+1]) , seq.getLength() - nStop -1); seq.realloc( seq.getLength() - ( nStop+1 - nFound ) ); -// str = String( (char * ) seq.getArray() , seq.getLen() ); } } } @@ -178,7 +177,7 @@ bool XMLFile2UTFConverter::isEncodingRecognizable( const Sequence< sal_Int8 > return false; } -if( ! strncmp( reinterpret_cast(pSource), "(pSource), " ) } // first level : detect possible file formats -if( ! strncmp( reinterpret_cast(pSource), "= 5 && !strncmp(reinterpret_cast(pSource), "(pSource), seq.getLength() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sax/source
sax/source/expatwrap/xml2utf.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 6ac9555d133a5aa67641b3927547cf9199cd938e Author: Takeshi AbeDate: Tue Jul 18 22:44:33 2017 +0900 sax: Check if it starts with 5 bytes of "https://gerrit.libreoffice.org/40139 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit b64e564492220b34c14f069e8e1f42675bd9abe6) ofz: string has to be at least 5 chars long Reviewed-on: https://gerrit.libreoffice.org/42379 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara this should presumably be 5, rather than 4 Change-Id: Iec5b748b188c7b1bf61e8137faf4b3f2d480d7f1 98c50a59c03fc886d50362b9c5dd8c84f60e0b62 20c6a6fb34485f42c2a828618e8918d8a441860a Reviewed-on: https://gerrit.libreoffice.org/42394 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sax/source/expatwrap/xml2utf.cxx b/sax/source/expatwrap/xml2utf.cxx index 6ccecc684983..c37f7d3a0c8e 100644 --- a/sax/source/expatwrap/xml2utf.cxx +++ b/sax/source/expatwrap/xml2utf.cxx @@ -125,7 +125,7 @@ XMLFile2UTFConverter::~XMLFile2UTFConverter() void XMLFile2UTFConverter::removeEncoding( Sequence ) { const sal_Int8 *pSource = seq.getArray(); -if( ! strncmp( reinterpret_cast(pSource), "= 5 && !strncmp(reinterpret_cast(pSource), " ) &( seq.getArray()[nStop+1]) , seq.getLength() - nStop -1); seq.realloc( seq.getLength() - ( nStop+1 - nFound ) ); -// str = String( (char * ) seq.getArray() , seq.getLen() ); } } } @@ -177,7 +176,7 @@ bool XMLFile2UTFConverter::isEncodingRecognizable( const Sequence< sal_Int8 > return false; } -if( ! strncmp( reinterpret_cast(pSource), "(pSource), " ) } // first level : detect possible file formats -if( ! strncmp( reinterpret_cast(pSource), "= 5 && !strncmp(reinterpret_cast(pSource), "(pSource), seq.getLength() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 110742] add support for user icon themes via extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=110742 Xisco Faulíchanged: What|Removed |Added Status|NEW |ASSIGNED CC||xiscofa...@libreoffice.org Assignee|libreoffice-b...@lists.free |namitha.ni...@ssrlabs.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 105538] Download destination folder should be default to Download folder on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=105538 --- Comment #16 from Xisco Faulí--- Polite ping: is this bug fixed? if so, please close it as RESOLVED FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=105538 --- Comment #16 from Xisco Faulí--- Polite ping: is this bug fixed? if so, please close it as RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/test/unusedfields.cxx | 33 + compilerplugins/clang/unusedfields.cxx | 15 compilerplugins/clang/unusedfields.py| 15 compilerplugins/clang/unusedfields.readonly.results | 372 --- compilerplugins/clang/unusedfields.untouched.results | 20 - compilerplugins/clang/unusedfields.writeonly.results | 236 ++-- 6 files changed, 354 insertions(+), 337 deletions(-) New commits: commit 1ff0f0ba29cc14c265fd74c49710a079e67ee943 Author: Noel GrandinDate: Mon Sep 18 09:43:18 2017 +0200 improve unusedfields loplugin (*) IsPassedByNonConst was completely wrong, not even sure why it worked before. (*) treat a field passed to operator>>= as being written to, but not read Change-Id: Id3a5f2f35222986fe5edba3f5a58215a1815d401 diff --git a/compilerplugins/clang/test/unusedfields.cxx b/compilerplugins/clang/test/unusedfields.cxx index ff1eee5ad94c..71489b018843 100644 --- a/compilerplugins/clang/test/unusedfields.cxx +++ b/compilerplugins/clang/test/unusedfields.cxx @@ -9,6 +9,7 @@ #include #include +#include struct Foo // expected-error@-1 {{read m_foo1 [loplugin:unusedfields]}} @@ -23,13 +24,15 @@ struct Bar // expected-error@-4 {{read m_bar6 [loplugin:unusedfields]}} // expected-error@-5 {{read m_barfunctionpointer [loplugin:unusedfields]}} // expected-error@-6 {{read m_bar8 [loplugin:unusedfields]}} -// expected-error@-7 {{write m_bar1 [loplugin:unusedfields]}} -// expected-error@-8 {{write m_bar2 [loplugin:unusedfields]}} -// expected-error@-9 {{write m_bar3 [loplugin:unusedfields]}} -// expected-error@-10 {{write m_bar3b [loplugin:unusedfields]}} -// expected-error@-11 {{write m_bar4 [loplugin:unusedfields]}} -// expected-error@-12 {{write m_bar7 [loplugin:unusedfields]}} -// expected-error@-13 {{write m_barfunctionpointer [loplugin:unusedfields]}} +// expected-error@-7 {{read m_bar10 [loplugin:unusedfields]}} +// expected-error@-8 {{write m_bar1 [loplugin:unusedfields]}} +// expected-error@-9 {{write m_bar2 [loplugin:unusedfields]}} +// expected-error@-10 {{write m_bar3 [loplugin:unusedfields]}} +// expected-error@-11 {{write m_bar3b [loplugin:unusedfields]}} +// expected-error@-12 {{write m_bar4 [loplugin:unusedfields]}} +// expected-error@-13 {{write m_bar7 [loplugin:unusedfields]}} +// expected-error@-14 {{write m_barfunctionpointer [loplugin:unusedfields]}} +// expected-error@-15 {{write m_bar9 [loplugin:unusedfields]}} { int m_bar1; int m_bar2 = 1; @@ -42,6 +45,8 @@ struct Bar int m_bar7[5]; int m_bar8; int m_barstream; +int m_bar9; +int m_bar10; // check that we see reads of fields like m_foo1 when referred to via constructor initializer Bar(Foo const & foo) : m_bar1(foo.m_foo1) {} @@ -81,6 +86,20 @@ struct Bar char tmp[5]; return tmp[m_bar8]; } + +// check that we don't see reads when calling operator>>= +void bar9() +{ +css::uno::Any any; +any >>= m_bar9; +} + +// check that we see don't see writes when calling operator<<= +void bar10() +{ +css::uno::Any any; +any <<= m_bar10; +} }; // check that we __dont__ see a read of m_barstream diff --git a/compilerplugins/clang/unusedfields.cxx b/compilerplugins/clang/unusedfields.cxx index b8af5aa7d896..69ea4be9c8b2 100644 --- a/compilerplugins/clang/unusedfields.cxx +++ b/compilerplugins/clang/unusedfields.cxx @@ -493,11 +493,16 @@ void UnusedFields::checkWriteOnly(const FieldDecl* fieldDecl, const Expr* member { // check for calls to ReadXXX() type methods and the operator>>= methods on Any. const FunctionDecl * calleeFunctionDecl = callExpr->getDirectCallee(); -if (calleeFunctionDecl && calleeFunctionDecl->getIdentifier()) +if (calleeFunctionDecl) { +// FIXME perhaps a better solution here would be some kind of SAL_PARAM_WRITEONLY attribute +// which we could scatter around. std::string name = calleeFunctionDecl->getNameAsString(); std::transform(name.begin(), name.end(), name.begin(), easytolower); -if (startswith(name, "read") || name.find(">>=") != std::string::npos) +if (startswith(name, "read")) +// this is a write-only call +; +else if (name.find(">>=") != std::string::npos && callExpr->getArg(1) == child) // this is a write-only call ; else if (name == "clear" || name == "dispose" || name == "disposeAndClear" || name == "swap") @@ -650,7 +655,9 @@ void UnusedFields::checkReadOnly(const FieldDecl* fieldDecl, const Expr* memberE bPotentiallyWrittenTo = true; } else if (IsPassedByNonConst(fieldDecl,
[Libreoffice-bugs] [Bug 56789] [Request] Enhancement: DATELASTSAVED()
https://bugs.documentfoundation.org/show_bug.cgi?id=56789 --- Comment #4 from Xavier Van Wijmeersch--- Created attachment 136332 --> https://bugs.documentfoundation.org/attachment.cgi?id=136332=edit screenshot off properties -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112440] Change of language module in Writing aids isn't remembered
https://bugs.documentfoundation.org/show_bug.cgi?id=112440 --- Comment #4 from Julien Nabet--- Thank you for your feedback. Anybody knows who may help here? At least to know if it's a bug or not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56789] [Request] Enhancement: DATELASTSAVED()
https://bugs.documentfoundation.org/show_bug.cgi?id=56789 --- Comment #3 from Xavier Van Wijmeersch--- When you look at the properties off a document, you will see date and hour of creation and date and hour off update plus revision number Best regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: clang compiler gives warnings expecting errors
Hi Stephan That worked a treat. Thanks Alex On 15/09/17 09:18, Stephan Bergmann wrote: You need to configure LO with --enable-werror. (Which developers should do anyway, independent of Clang/loplugin.) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 112386] UI: Scaling of the sheet / fonts is too big
https://bugs.documentfoundation.org/show_bug.cgi?id=112386 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Alex Thurgood --- @Jeremy : please give detailed instructions on how to reproduce what you are experiencing, as currently I can't reproduce the behaviour you describe. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109147] FILESAVE XLSX: Replacing a hyperlink makes it invalid in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=109147 --- Comment #10 from Gabor Kelemen--- Created attachment 136331 --> https://bugs.documentfoundation.org/attachment.cgi?id=136331=edit The file made in Excel 2013 and modified in current LO 6 master For reference, this is the file saved from the current build. Seems to work fine in Excel 2013. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112461] Cannot open any ODG documents; Read Error; Format Error
https://bugs.documentfoundation.org/show_bug.cgi?id=112461 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Alex Thurgood --- @Neil : no repro with Version: 5.4.1.2 Build ID: ea7cb86e6eeb2bf3a5af73a8fac570321527 CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group when attempting to open a simple ODG file made in LO536 containing some of the pre-made shapes from the draw objects menu. We need more information, and preferably a document that shows the issue or detailed steps as to what the ODG file contains. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109147] FILESAVE XLSX: Replacing a hyperlink makes it invalid in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=109147 Gabor Kelemenchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from Gabor Kelemen --- Works fine with the current master build as of yesterday. Thanks whoever did this :). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Bug 107733 depends on bug 109147, which changed state. Bug 109147 Summary: FILESAVE XLSX: Replacing a hyperlink makes it invalid in Excel https://bugs.documentfoundation.org/show_bug.cgi?id=109147 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112459] FILESAVE: Linked Cell of Checkbox lost
https://bugs.documentfoundation.org/show_bug.cgi?id=112459 --- Comment #1 from Xavier Van Wijmeersch--- confirm with Version: 6.0.0.0.alpha0+ Build ID: afeff9102c2935139de4efd40fd2286dce396706 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-09-17_23:32:41 Locale: nl-BE (en_US.UTF-8); Calc: group and Version: 5.4.2.0.0+ Build ID: 61d85c4e7c30ea0f5242d927b7456190020b4fbe CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group also it will say read only document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112440] Change of language module in Writing aids isn't remembered
https://bugs.documentfoundation.org/show_bug.cgi?id=112440 Jean-Baptiste Faurechanged: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #3 from Jean-Baptiste Faure --- I reproduce this behavior but I do not know if that is a bug or not. Perhaps the language shown as starting value in the dropdown list is defined from the locale. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112460] Formatting - ruler - Tab - right alignment if removed is ignored upon saving to docx format
https://bugs.documentfoundation.org/show_bug.cgi?id=112460 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Thurgood --- Mor elike a DUP of bug 42125 *** This bug has been marked as a duplicate of bug 42125 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs