Re: [Libreoffice-commits] core.git: sysui/CustomTarget_share.mk
Hi, On Thu, Aug 01, 2019 at 07:13:58AM +, Stephan Bergmann (via logerrit) wrote: > sysui/CustomTarget_share.mk |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > New commits: > commit 4b4c7e76e6c2ea0d47a42a5107352d3ad7341fbf > Author: Stephan Bergmann > AuthorDate: Wed Jul 31 21:56:18 2019 +0200 > Commit: Noel Grandin > CommitDate: Thu Aug 1 09:13:22 2019 +0200 > > Only build LOKDocView-0.1.gir when necessary > > Prior to 634844354ee6ed884128086a80c3ee32c889d8c9 "sysui: fix rpm errors > in > freedesktop-menus (4.14.1)" it had been build as part of > sysui/desktop/share/create_tree.sh, which is presumably only called when > building for deb or rpm PKGFORMAT. Building it now in more cases started > to Uhm, no $ git grep create_tree.sh bin/distro-install-desktop-integration:# do not overwrite $BINDIR/libreoffice symlink created by create_tree.sh bin/distro-install-desktop-integration:cp -a "${SRCDIR?}"/sysui/desktop/share/create_tree.sh "$sysui_temp" bin/distro-install-desktop-integration:bash ./create_tree.sh bin/distro-install-desktop-integration:# put the stuff installed by create_tree.sh into the right file lists sysui/CustomTarget_deb.mk:$(deb_WORKDIR)/%/DEBIAN/control: $(deb_SRCDIR)/control $(call gb_CustomTarget_get_workdir,sysui/share)/%/create_tree.sh sysui/CustomTarget_deb.mk: ./create_tree.sh sysui/CustomTarget_rpm.mk: $(call gb_CustomTarget_get_workdir,sysui/share)/$(1)/create_tree.sh \ sysui/CustomTarget_share.mk:$(product)/create_tree.sh \ sysui/CustomTarget_share.mk:$(share_WORKDIR)/%/create_tree.sh: $(share_SRCDIR)/share/create_tree.sh \ sysui/desktop/freedesktop/freedesktop-menus.spec:./create_tree.sh This means that packaging without deb/rpm PKGFORMAT and plain "make install" now doesn't build it Reverted it locally for me... Regards, Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'private/EL-SHREIF/ui_logger' - include/vcl sd/source uitest/ui_logger_dsl vcl/source
include/vcl/uitest/logger.hxx | 10 +++ sd/source/ui/slidesorter/controller/SlsSlotManager.cxx | 22 + uitest/ui_logger_dsl/Special_commands.tx | 14 +++--- uitest/ui_logger_dsl/dsl_core.py |2 + vcl/source/uitest/logger.cxx | 11 vcl/source/uitest/uiobject.cxx |8 ++ 6 files changed, 63 insertions(+), 4 deletions(-) New commits: commit 20d0760cc256ab9bcd15c60d68ddc1baccdedada Author: Ahmed ElShreif AuthorDate: Fri Aug 2 22:16:31 2019 -0500 Commit: Ahmed ElShreif CommitDate: Fri Aug 2 22:16:31 2019 -0500 Add more events to ui logger for Impress: add new Slide for Draw add new Page Modify the UILogger System to save information about the name of the app Change-Id: I87fd98b2a11783e3410f1c0eba633631addf389b diff --git a/include/vcl/uitest/logger.hxx b/include/vcl/uitest/logger.hxx index f707049040fe..6c8c5008541a 100644 --- a/include/vcl/uitest/logger.hxx +++ b/include/vcl/uitest/logger.hxx @@ -32,6 +32,8 @@ private: bool mbValid; +OUString app_name; + public: UITestLogger(); @@ -48,6 +50,14 @@ public: static UITestLogger& getInstance(); +void setAppName(OUString name){ +app_name=name; +} + +OUString getAppName(){ +return app_name; +} + }; #endif diff --git a/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx b/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx index 55b58e197f1c..9d16edf5a63f 100644 --- a/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx +++ b/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx @@ -67,6 +67,9 @@ #include #include +#include +#include + #include #include #include @@ -84,6 +87,7 @@ #include #include + #include using namespace ::com::sun::star; @@ -106,6 +110,23 @@ SlideExclusionState GetSlideExclusionState (model::PageEnumeration& rPageSet); } // end of anonymous namespace + +namespace { + +void collectUIInformation(const OUString& num,const OUString& action) +{ +EventDescription aDescription; +aDescription.aID = "impress_win_or_draw_win"; +aDescription.aParameters = {{"POS", num}}; +aDescription.aAction = action; +aDescription.aKeyWord = "ImpressWindowUIObject"; +aDescription.aParent = "MainWindow"; + +UITestLogger::getInstance().logEvent(aDescription); +} + +} + SlotManager::SlotManager (SlideSorter& rSlideSorter) : mrSlideSorter(rSlideSorter) { @@ -1065,6 +1086,7 @@ void SlotManager::InsertSlide (SfxRequest& rRequest) PageSelector::UpdateLock aUpdateLock (mrSlideSorter); mrSlideSorter.GetController().GetPageSelector().DeselectAllPages(); mrSlideSorter.GetController().GetPageSelector().SelectPage(pNewPage); + collectUIInformation(OUString::number(nInsertionIndex+2),"Insert_New_Page_or_Slide"); } void SlotManager::DuplicateSelectedSlides (SfxRequest& rRequest) diff --git a/uitest/ui_logger_dsl/Special_commands.tx b/uitest/ui_logger_dsl/Special_commands.tx index 5fbd9972a275..1d11067424a9 100644 --- a/uitest/ui_logger_dsl/Special_commands.tx +++ b/uitest/ui_logger_dsl/Special_commands.tx @@ -128,17 +128,19 @@ select_options: This part for all the impress log statments: 1) Type -2) Set zoom +2) Insert New Page then we can add whatever we need in the future */ impress_command: -impress_Type_command +impress_Type_command | impress_Insert_Slide ; impress_Type_command: 'Type on impress ' what_to_type=Type_options ; - +impress_Insert_Slide: +'Insert New Slide at Position ' position_num=INT +; //=// /* This part for all the math log statments: @@ -163,12 +165,16 @@ math_Type_command: This part for all the draw log statments: 1) Type +2) Insert New Page then we can add whatever we need in the future */ draw_command: -draw_Type_command +draw_Type_command | draw_Insert_Page ; draw_Type_command: 'Type on draw ' what_to_type=Type_options +; +draw_Insert_Page: +'Insert New Page at Position ' position_num=INT ; \ No newline at end of file diff --git a/uitest/ui_logger_dsl/dsl_core.py b/uitest/ui_logger_dsl/dsl_core.py index 8d5a8a82ac0b..9a5f375b5aa9 100644 --- a/uitest/ui_logger_dsl/dsl_core.py +++ b/uitest/ui_logger_dsl/dsl_core.py @@ -101,6 +101,8 @@ class ul_Compiler: 'calc_Copy_Cells':self.do_nothing, 'calc_Merge_Cells':self.do_nothing, 'calc_UNMerge_Cells':self.do_nothing, +'impress_Insert_Slide':self.do_nothing, +'draw_Insert_Page':self.do_nothing, }) self.log_lines=self.get_log_file(self.input_address) diff --git a/vcl/source/uitest/logger.cxx b/vcl/source/uitest/logger.cxx index
[Libreoffice-bugs] [Bug 126680] Horizontal scrolling direction reversed with touchpad
https://bugs.documentfoundation.org/show_bug.cgi?id=126680 --- Comment #1 from trainma...@gmail.com --- I am getting the same result with 6.3.x, but on MacOS. I had wondered whether in my case because I'm on MacOS beta it was something from that, but looks like not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120437] Table data replaced by '0'
https://bugs.documentfoundation.org/show_bug.cgi?id=120437 --- Comment #3 from QA Administrators --- Dear Mamoth, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118064] Indentation in first column of tables is added when originally not present in docx files
https://bugs.documentfoundation.org/show_bug.cgi?id=118064 --- Comment #4 from QA Administrators --- Dear BCH, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122441] Axe X position return to 0 after saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=122441 --- Comment #3 from QA Administrators --- Dear fwojcicki, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119369] Repeat Table Heading Suddenly Appeared
https://bugs.documentfoundation.org/show_bug.cgi?id=119369 --- Comment #2 from QA Administrators --- Dear DM, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126437] DOCX: MSForm is gone if deleted and undo
https://bugs.documentfoundation.org/show_bug.cgi?id=126437 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126482] Add host IP address to Impress Remote dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=126482 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122441] Axe X position return to 0 after saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=122441 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118937] Border around text portion has padding color artifacts
https://bugs.documentfoundation.org/show_bug.cgi?id=118937 --- Comment #4 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120867] First file save after opening slower compared to previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=120867 --- Comment #2 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118970] Writer > Format > Page... > Header/Footer > 'Same content on first page' setting not saving/working as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=118970 --- Comment #2 from QA Administrators --- Dear christophe.h...@gmail.com, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command
https://bugs.documentfoundation.org/show_bug.cgi?id=105575 --- Comment #10 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119038] Fileopen DOCX: images outside table
https://bugs.documentfoundation.org/show_bug.cgi?id=119038 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94163] FILEOPEN: DOCX - Tables in RTL document places in the horizontally opposite location
https://bugs.documentfoundation.org/show_bug.cgi?id=94163 --- Comment #8 from QA Administrators --- Dear persiantools, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118902] RTF import: wrong font for Hebrew text
https://bugs.documentfoundation.org/show_bug.cgi?id=118902 --- Comment #5 from QA Administrators --- Dear Mike Kaganski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119023] Fileopen DOC: OOM/ missing or black images when opening a file contains multiple images
https://bugs.documentfoundation.org/show_bug.cgi?id=119023 --- Comment #9 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118893] Impress: UI locks up when I drag a slide from the left "Slides" view to the Windows taskbar
https://bugs.documentfoundation.org/show_bug.cgi?id=118893 --- Comment #6 from QA Administrators --- Dear Colin Finck, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119064] The size of comment box size isn't adjust on paste (only after scrolling)
https://bugs.documentfoundation.org/show_bug.cgi?id=119064 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111920] Cells no automatically recalculated when formula is dependent of language and this is changed
https://bugs.documentfoundation.org/show_bug.cgi?id=111920 --- Comment #6 from QA Administrators --- Dear Luis, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90667] Problem with alignment in index / TOC in specific DOT (per Comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=90667 --- Comment #12 from QA Administrators --- Dear gon_aranda, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102058] No screen reader notification that there is a comment
https://bugs.documentfoundation.org/show_bug.cgi?id=102058 --- Comment #6 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119010] Page area hatch doesn't work correctly in a Writer document with mirrored pages.
https://bugs.documentfoundation.org/show_bug.cgi?id=119010 --- Comment #6 from QA Administrators --- Dear Robin Henderson, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115335] Formatted cell text is not exposed to assistive technologies
https://bugs.documentfoundation.org/show_bug.cgi?id=115335 --- Comment #3 from QA Administrators --- Dear Joanmarie Diggs, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #58 from Todd --- (In reply to V Stuart Foote from comment #57) > (In reply to Todd from comment #55) > Well, I hope you now understand how trivial it is to do just that, and to > recover when you've misapplied or corrupted a style, or I've wasted way more > time than this non-issue merits ;-) I know now that up is down and right is left and can easily work with it. It helps that I wrote it all down too. I shutter to think of an non I.T. user trying to figure it out and that does make it and issue. The best outcome of all of this would be to get Regina's proposal implemented. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #58 from Todd --- (In reply to V Stuart Foote from comment #57) > (In reply to Todd from comment #55) > Well, I hope you now understand how trivial it is to do just that, and to > recover when you've misapplied or corrupted a style, or I've wasted way more > time than this non-issue merits ;-) I know now that up is down and right is left and can easily work with it. It helps that I wrote it all down too. I shutter to think of an non I.T. user trying to figure it out and that does make it and issue. The best outcome of all of this would be to get Regina's proposal implemented. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #57 from V Stuart Foote --- (In reply to Todd from comment #55) > > > Meanwhile examine the behavior of the Status bar indicator of the Page > > style, it is context menu (i.e. r-mouse click) enabled to allow you to > > select from the defined page styles and will display the Name of the page > > style applied to the document page with text cursor focus. It does not give > > any indication when the style has been modified from its template defaults. > > Open attachment 153099 [details], its view mode should make the page styling > > apparent. > > I do understand what you are saying. But from a users standpoint, you are > tell him that up is down and down is up. Portrait is Landscape and > Landscape is Portrait. This is a nightmare for the user. Do you expect the > user to code directly in XML so he gets what he wants? The user expects the > "Style" pop up to be the style of the current page and subsequent pages NOT > THE WHOLE STINKING DOCUMENT. The Style pop up should create a new set of > rules in a new or previously used style. Styles themselves are a great way > of doing this, but your flow control of styles is what is in question, not > the styles themselves. > The Page style field of the Status bar shows the *named* Page Style as pulled from the Master-Page template (the "https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #57 from V Stuart Foote --- (In reply to Todd from comment #55) > > > Meanwhile examine the behavior of the Status bar indicator of the Page > > style, it is context menu (i.e. r-mouse click) enabled to allow you to > > select from the defined page styles and will display the Name of the page > > style applied to the document page with text cursor focus. It does not give > > any indication when the style has been modified from its template defaults. > > Open attachment 153099 [details], its view mode should make the page styling > > apparent. > > I do understand what you are saying. But from a users standpoint, you are > tell him that up is down and down is up. Portrait is Landscape and > Landscape is Portrait. This is a nightmare for the user. Do you expect the > user to code directly in XML so he gets what he wants? The user expects the > "Style" pop up to be the style of the current page and subsequent pages NOT > THE WHOLE STINKING DOCUMENT. The Style pop up should create a new set of > rules in a new or previously used style. Styles themselves are a great way > of doing this, but your flow control of styles is what is in question, not > the styles themselves. > The Page style field of the Status bar shows the *named* Page Style as pulled from the Master-Page template (the "https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #56 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. Hi Regina, I think one of the issues here is naming custom styles with names like "Landscape". The "User" expects it to be Landscape because that is what is says it is. (I currently have a test doc in Portrait that uses a style called Landscape.) He does not realize that it is an arbitrary comment and that the page orientation is buried in the XML tags. I surely did not. The new style could as well be called the Flaming Zucchini style. At least if the style was called the Flaming Zucchini, he know to look inside to see what it does. When you tell the user that Landscape is not Landscape Orientation but jsut teh name of the style, he is going to think you are an idiot and go buy M$ Office. I have had is happen too many times. At least the usually buy M$ Office from me. But geez, what a waste of money. -T -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #56 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. Hi Regina, I think one of the issues here is naming custom styles with names like "Landscape". The "User" expects it to be Landscape because that is what is says it is. (I currently have a test doc in Portrait that uses a style called Landscape.) He does not realize that it is an arbitrary comment and that the page orientation is buried in the XML tags. I surely did not. The new style could as well be called the Flaming Zucchini style. At least if the style was called the Flaming Zucchini, he know to look inside to see what it does. When you tell the user that Landscape is not Landscape Orientation but jsut teh name of the style, he is going to think you are an idiot and go buy M$ Office. I have had is happen too many times. At least the usually buy M$ Office from me. But geez, what a waste of money. -T -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 97956] Don't fragment A:A conditional formatting when rows/columns are moved
https://bugs.documentfoundation.org/show_bug.cgi?id=97956 --- Comment #11 from 7qia0t...@sneakemail.com --- Yes of course it's still a problem, it happens every day. Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #55 from Todd --- (In reply to V Stuart Foote from comment #51) > > Hmm, you've had four of the sharpest QA reviewers working on the project > tell you that you are incorrect. You've received precise examples and > explanations to enable you to perceive where your usage is not in line with > function. Yet you still claim there is a bug... at some point folks will > tell you to move on. Meanwhile the UX facet of why it causes issues is our > ongoing dichotomy of Direct Formatting vs. Style based authoring. That you for helping me make my point. All those sharp guys did not really help until Regina took a look. What they did was give me work arounds, which were appreciated but not the point of the bug report. It took Regina to hit pay dirt. So I guess five is the magic number. > Meanwhile examine the behavior of the Status bar indicator of the Page > style, it is context menu (i.e. r-mouse click) enabled to allow you to > select from the defined page styles and will display the Name of the page > style applied to the document page with text cursor focus. It does not give > any indication when the style has been modified from its template defaults. > Open attachment 153099 [details], its view mode should make the page styling > apparent. I do understand what you are saying. But from a users standpoint, you are tell him that up is down and down is up. Portrait is Landscape and Landscape is Portrait. This is a nightmare for the user. Do you expect the user to code directly in XML so he gets what he wants? The user expects the "Style" pop up to be the style of the current page and subsequent pages NOT THE WHOLE STINKING DOCUMENT. The Style pop up should create a new set of rules in a new or previously used style. Styles themselves are a great way of doing this, but your flow control of styles is what is in question, not the styles themselves. You have to look at this from the user's standpoint, not the developers. This bug report all started with me having to urgently send a customers a document with mixed Landscape (first page) and Portrait mixed together and I could not figure out how in the h*** I lost my ability to use Portrait (he accepted everything is Landscape, fortunately). And I am a YUGE fan of LO and a BS in comptuer engineering and an I.T. professional to boot AND even I could not figure it out. And googeling it was no use either. (I have since wrote up how to do it from myself.) How in the world would you expect a standard user to figure it out? This is why I can't get anyone to seriously adopt LO, even thought it is a great piece of software. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #55 from Todd --- (In reply to V Stuart Foote from comment #51) > > Hmm, you've had four of the sharpest QA reviewers working on the project > tell you that you are incorrect. You've received precise examples and > explanations to enable you to perceive where your usage is not in line with > function. Yet you still claim there is a bug... at some point folks will > tell you to move on. Meanwhile the UX facet of why it causes issues is our > ongoing dichotomy of Direct Formatting vs. Style based authoring. That you for helping me make my point. All those sharp guys did not really help until Regina took a look. What they did was give me work arounds, which were appreciated but not the point of the bug report. It took Regina to hit pay dirt. So I guess five is the magic number. > Meanwhile examine the behavior of the Status bar indicator of the Page > style, it is context menu (i.e. r-mouse click) enabled to allow you to > select from the defined page styles and will display the Name of the page > style applied to the document page with text cursor focus. It does not give > any indication when the style has been modified from its template defaults. > Open attachment 153099 [details], its view mode should make the page styling > apparent. I do understand what you are saying. But from a users standpoint, you are tell him that up is down and down is up. Portrait is Landscape and Landscape is Portrait. This is a nightmare for the user. Do you expect the user to code directly in XML so he gets what he wants? The user expects the "Style" pop up to be the style of the current page and subsequent pages NOT THE WHOLE STINKING DOCUMENT. The Style pop up should create a new set of rules in a new or previously used style. Styles themselves are a great way of doing this, but your flow control of styles is what is in question, not the styles themselves. You have to look at this from the user's standpoint, not the developers. This bug report all started with me having to urgently send a customers a document with mixed Landscape (first page) and Portrait mixed together and I could not figure out how in the h*** I lost my ability to use Portrait (he accepted everything is Landscape, fortunately). And I am a YUGE fan of LO and a BS in comptuer engineering and an I.T. professional to boot AND even I could not figure it out. And googeling it was no use either. (I have since wrote up how to do it from myself.) How in the world would you expect a standard user to figure it out? This is why I can't get anyone to seriously adopt LO, even thought it is a great piece of software. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 97993] EDITING: images and shapes that are successively Copy/Pasted or Pasted should to be shifted
https://bugs.documentfoundation.org/show_bug.cgi?id=97993 --- Comment #20 from Luke --- CTRL+C then multiple CTRL+V still behaves unexpectedly with both shapes / images. No user feedback that the command was executed like in Word. Version: 6.4.0.0.alpha0+ (x64) Build ID: 41d3be4a48ea2abe019cd4f9b51bef703a2dc454 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #54 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. So how do we get Regina's proposal into the system? Create a new bug report? Reopen this one? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #54 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. So how do we get Regina's proposal into the system? Create a new bug report? Reopen this one? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #53 from Todd --- (In reply to V Stuart Foote from comment #44) > (In reply to Todd from comment #41) > > ... > What are you talking about? They do *all* work correctly, there is no > workaround! > > RTFM! Would ya like me to give you examples of XML code? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #53 from Todd --- (In reply to V Stuart Foote from comment #44) > (In reply to Todd from comment #41) > > ... > What are you talking about? They do *all* work correctly, there is no > workaround! > > RTFM! Would ya like me to give you examples of XML code? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #52 from Todd --- (In reply to V Stuart Foote from comment #49) > (In reply to Todd from comment #48) > > > > > My understanding is that "format->page" is "suppose" to only affect the > > current page and subsequent new pages, not existing pages, even if under the > > active page. > > Only I can never figure out when it is the current page and when it is > > global. > > > > Nope, there is no "Direct Formatting" for Pages--you will always be working > with a style when formatting pages. And Page styles are one of the styles > that will *always* AutoUpdate (i.e. there is no "Auto Update" checkbox > selection on the Style editor's Organizer tab). You change it anywhere, and > it will auto update (perhaps "autocorrupt") its use anywhere else in the > document. Powerful stuff :-) > > Not understanding that seems to be what continues to trip you up... I am on Format->page->Page and I see not "AutoUpdate" button, so I am at your mercy. To me, what a style is and what is means is in the XML code. For instance: And when you start typing ping on a page, the page tags itself to what style it is using (pm1 and pm2 in the above). So first you define (usually on the fly) what styles you are using, then you tag your missive with what style you are want: Page 1 Lanscape Page 2 Portrait (I am a little unclear how pm1 and pm2 got turned into P1 and P2.) So when the tag "" is encountered, everything BEYOND that point takes on the properties of the tag. So I just don't get why the side bar and the pull down do different thing. When are you and when are you not altering the the global definition of the tag, when are you and when are you, making a new tag, and when are you saying to not modify a tab, but to override one feature with a slight change. And speaking of RTFM, OpenDocument-v1.2.pdf, pg 214, 5.3.2 Default List Style, Are you even ALLOWED to change the Default Style. I presume you what changes and you create a new style: tm1, pm2, pm3, etc.. And all over the palce in the spec, it states "...If there is no specified style available, the default style is applied", so I really do not think you are allows to change the defautls, but are allowed to create a new customer style. I could be wrong. So I actually do understand what "a" style is. What I am having an issue with is the flow control of where and how styles are applied. I seriously think Regina's idea will put an end to all this. I am actually a bit in awe over how beautifully she laid it out and her thought process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #52 from Todd --- (In reply to V Stuart Foote from comment #49) > (In reply to Todd from comment #48) > > > > > My understanding is that "format->page" is "suppose" to only affect the > > current page and subsequent new pages, not existing pages, even if under the > > active page. > > Only I can never figure out when it is the current page and when it is > > global. > > > > Nope, there is no "Direct Formatting" for Pages--you will always be working > with a style when formatting pages. And Page styles are one of the styles > that will *always* AutoUpdate (i.e. there is no "Auto Update" checkbox > selection on the Style editor's Organizer tab). You change it anywhere, and > it will auto update (perhaps "autocorrupt") its use anywhere else in the > document. Powerful stuff :-) > > Not understanding that seems to be what continues to trip you up... I am on Format->page->Page and I see not "AutoUpdate" button, so I am at your mercy. To me, what a style is and what is means is in the XML code. For instance: And when you start typing ping on a page, the page tags itself to what style it is using (pm1 and pm2 in the above). So first you define (usually on the fly) what styles you are using, then you tag your missive with what style you are want: Page 1 Lanscape Page 2 Portrait (I am a little unclear how pm1 and pm2 got turned into P1 and P2.) So when the tag "" is encountered, everything BEYOND that point takes on the properties of the tag. So I just don't get why the side bar and the pull down do different thing. When are you and when are you not altering the the global definition of the tag, when are you and when are you, making a new tag, and when are you saying to not modify a tab, but to override one feature with a slight change. And speaking of RTFM, OpenDocument-v1.2.pdf, pg 214, 5.3.2 Default List Style, Are you even ALLOWED to change the Default Style. I presume you what changes and you create a new style: tm1, pm2, pm3, etc.. And all over the palce in the spec, it states "...If there is no specified style available, the default style is applied", so I really do not think you are allows to change the defautls, but are allowed to create a new customer style. I could be wrong. So I actually do understand what "a" style is. What I am having an issue with is the flow control of where and how styles are applied. I seriously think Regina's idea will put an end to all this. I am actually a bit in awe over how beautifully she laid it out and her thought process. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #51 from V Stuart Foote --- (In reply to Todd from comment #50) > > I think the issue here is that you do not get a good hearing when you report > a bug, so you either give up or start these YUGE long dissertations. > It seem that you get a knee jerk "NOTABUG" response and that is the end of > it. > > In this bug report, I pointed out several bugs and got back use a different > tool or use the tools provided, but not "that" tool. Since one tool worked, > but another did not, it was not a bug and I just did not understand. RTFM. > > For instance, the style pop up at the bottom of the page where Landscape is > actually Portrait. Format->Page->page is different that the side bar tool > when selecting Landscape. (I can show you XML code as to what is different > if you wish.) And my constant complaining about no Portrait in the styles > selection. > Hmm, you've had four of the sharpest QA reviewers working on the project tell you that you are incorrect. You've received precise examples and explanations to enable you to perceive where your usage is not in line with function. Yet you still claim there is a bug... at some point folks will tell you to move on. Meanwhile the UX facet of why it causes issues is our ongoing dichotomy of Direct Formatting vs. Style based authoring. > > That all being said, I adore Regina's proposal. I would love to test it, if > you need a tester. Not a lot to test or change--one commit to move the menu action for the Page... style dialog to a different section of the Format menu, with a tweak to its label. It won't work any differently, but may be less confusing for folks there ;-) Meanwhile examine the behavior of the Status bar indicator of the Page style, it is context menu (i.e. r-mouse click) enabled to allow you to select from the defined page styles and will display the Name of the page style applied to the document page with text cursor focus. It does not give any indication when the style has been modified from its template defaults. Open attachment 153099, its view mode should make the page styling apparent. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #51 from V Stuart Foote --- (In reply to Todd from comment #50) > > I think the issue here is that you do not get a good hearing when you report > a bug, so you either give up or start these YUGE long dissertations. > It seem that you get a knee jerk "NOTABUG" response and that is the end of > it. > > In this bug report, I pointed out several bugs and got back use a different > tool or use the tools provided, but not "that" tool. Since one tool worked, > but another did not, it was not a bug and I just did not understand. RTFM. > > For instance, the style pop up at the bottom of the page where Landscape is > actually Portrait. Format->Page->page is different that the side bar tool > when selecting Landscape. (I can show you XML code as to what is different > if you wish.) And my constant complaining about no Portrait in the styles > selection. > Hmm, you've had four of the sharpest QA reviewers working on the project tell you that you are incorrect. You've received precise examples and explanations to enable you to perceive where your usage is not in line with function. Yet you still claim there is a bug... at some point folks will tell you to move on. Meanwhile the UX facet of why it causes issues is our ongoing dichotomy of Direct Formatting vs. Style based authoring. > > That all being said, I adore Regina's proposal. I would love to test it, if > you need a tester. Not a lot to test or change--one commit to move the menu action for the Page... style dialog to a different section of the Format menu, with a tweak to its label. It won't work any differently, but may be less confusing for folks there ;-) Meanwhile examine the behavior of the Status bar indicator of the Page style, it is context menu (i.e. r-mouse click) enabled to allow you to select from the defined page styles and will display the Name of the page style applied to the document page with text cursor focus. It does not give any indication when the style has been modified from its template defaults. Open attachment 153099, its view mode should make the page styling apparent. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #50 from Todd --- (In reply to Heiko Tietze from comment #45) > Those discussions might be better suited for > the mailing lists or our other channels (IRC, Telegram). I think the issue here is that you do not get a good hearing when you report a bug, so you either give up or start these YUGE long dissertations. It seem that you get a knee jerk "NOTABUG" response and that is the end of it. In this bug report, I pointed out several bugs and got back use a different tool or use the tools provided, but not "that" tool. Since one tool worked, but another did not, it was not a bug and I just did not understand. RTFM. For instance, the style pop up at the bottom of the page where Landscape is actually Portrait. Format->Page->page is different that the side bar tool when selecting Landscape. (I can show you XML code as to what is different if you wish.) And my constant complaining about no Portrait in the styles selection. Another example of getting blown off when reporting a bug: Calc: print does not print unsaved cell https://bugs.documentfoundation.org/show_bug.cgi?id=125895 Resolved: NOT A BUG I reopened as an RFE Print/Export should close cells first https://bugs.documentfoundation.org/show_bug.cgi?id=125932 And then got a decent hearing and the bug was accepted. Are you sensing a pattern? That all being said, I adore Regina's proposal. I would love to test it, if you need a tester. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #50 from Todd --- (In reply to Heiko Tietze from comment #45) > Those discussions might be better suited for > the mailing lists or our other channels (IRC, Telegram). I think the issue here is that you do not get a good hearing when you report a bug, so you either give up or start these YUGE long dissertations. It seem that you get a knee jerk "NOTABUG" response and that is the end of it. In this bug report, I pointed out several bugs and got back use a different tool or use the tools provided, but not "that" tool. Since one tool worked, but another did not, it was not a bug and I just did not understand. RTFM. For instance, the style pop up at the bottom of the page where Landscape is actually Portrait. Format->Page->page is different that the side bar tool when selecting Landscape. (I can show you XML code as to what is different if you wish.) And my constant complaining about no Portrait in the styles selection. Another example of getting blown off when reporting a bug: Calc: print does not print unsaved cell https://bugs.documentfoundation.org/show_bug.cgi?id=125895 Resolved: NOT A BUG I reopened as an RFE Print/Export should close cells first https://bugs.documentfoundation.org/show_bug.cgi?id=125932 And then got a decent hearing and the bug was accepted. Are you sensing a pattern? That all being said, I adore Regina's proposal. I would love to test it, if you need a tester. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #49 from V Stuart Foote --- (In reply to Todd from comment #48) > > My understanding is that "format->page" is "suppose" to only affect the > current page and subsequent new pages, not existing pages, even if under the > active page. > Only I can never figure out when it is the current page and when it is > global. > Nope, there is no "Direct Formatting" for Pages--you will always be working with a style when formatting pages. And Page styles are one of the styles that will *always* AutoUpdate (i.e. there is no "Auto Update" checkbox selection on the Style editor's Organizer tab). You change it anywhere, and it will auto update (perhaps "autocorrupt") its use anywhere else in the document. Powerful stuff :-) Not understanding that seems to be what continues to trip you up... > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > > Character-Paragraph section. Perhaps put it after 'Watermark', that has > > already 'Columns', which alters the page style too. > +1, for Regina's suggestion the movement out of the block of Direct Formatting controls -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #49 from V Stuart Foote --- (In reply to Todd from comment #48) > > My understanding is that "format->page" is "suppose" to only affect the > current page and subsequent new pages, not existing pages, even if under the > active page. > Only I can never figure out when it is the current page and when it is > global. > Nope, there is no "Direct Formatting" for Pages--you will always be working with a style when formatting pages. And Page styles are one of the styles that will *always* AutoUpdate (i.e. there is no "Auto Update" checkbox selection on the Style editor's Organizer tab). You change it anywhere, and it will auto update (perhaps "autocorrupt") its use anywhere else in the document. Powerful stuff :-) Not understanding that seems to be what continues to trip you up... > > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > > Character-Paragraph section. Perhaps put it after 'Watermark', that has > > already 'Columns', which alters the page style too. > +1, for Regina's suggestion the movement out of the block of Direct Formatting controls -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #48 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. My understanding is that "format->page" is "suppose" to only affect the current page and subsequent new pages, not existing pages, even if under the active page. Only I can never figure out when it is the current page and when it is global. > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. Hi Regina, I love your idea! -T -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #48 from Todd --- (In reply to Regina Henschel from comment #46) > I think, one problem is, that the items 'Character', 'Paragraph' and 'Bullet > and Numbering…' in that section of the Format menu perform a direct > formatting which has no effect on other parts or the document. But the item > 'Page…' there, does not perform a direct formatting at all and has often a > document-wide effect. My understanding is that "format->page" is "suppose" to only affect the current page and subsequent new pages, not existing pages, even if under the active page. Only I can never figure out when it is the current page and when it is global. > I suggest to rename 'Page…' to 'Edit Page Style' and move it out of the > Character-Paragraph section. Perhaps put it after 'Watermark', that has > already 'Columns', which alters the page style too. Hi Regina, I love your idea! -T -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #47 from Todd --- (In reply to Heiko Tietze from comment #45) > And throughout all the comments I haven't seen any proposal > to enhance, eg. to introduce a page style "Portrait" in addition to the > existing Landscape (wouldn't work well, IMHO) or to have a dedicated menu > entry Insert > Page Break (Landscape) plus applying the Default page style > (with portrait) for ordinary page breaks. I never specifically said RFE to adding Portrait but did complain about it not being there profusely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126608] Writer: Can't switch to Portrait
https://bugs.documentfoundation.org/show_bug.cgi?id=126608 --- Comment #47 from Todd --- (In reply to Heiko Tietze from comment #45) > And throughout all the comments I haven't seen any proposal > to enhance, eg. to introduce a page style "Portrait" in addition to the > existing Landscape (wouldn't work well, IMHO) or to have a dedicated menu > entry Insert > Page Break (Landscape) plus applying the Default page style > (with portrait) for ordinary page breaks. I never specifically said RFE to adding Portrait but did complain about it not being there profusely. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #14 from V Stuart Foote --- (In reply to andreas_k from comment #13) > what does CF mean? There is > > CF Oee > CF Only One > CF Many > CF Many One > CF Zero One > CF Zero Many The "CF" was used for naming "Crows Foot" a.k.a Martin [1] symbology for -- Entity–relationship modeling [2] =-ref-= [1] https://en.wikipedia.org/wiki/James_Martin_(author) [2] https://en.wikipedia.org/wiki/Entity%E2%80%93relationship_model -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #14 from V Stuart Foote --- (In reply to andreas_k from comment #13) > what does CF mean? There is > > CF Oee > CF Only One > CF Many > CF Many One > CF Zero One > CF Zero Many The "CF" was used for naming "Crows Foot" a.k.a Martin [1] symbology for -- Entity–relationship modeling [2] =-ref-= [1] https://en.wikipedia.org/wiki/James_Martin_(author) [2] https://en.wikipedia.org/wiki/Entity%E2%80%93relationship_model -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #13 from andreas_k --- what does CF mean? There is CF Oee CF Only One CF Many CF Many One CF Zero One CF Zero Many -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #13 from andreas_k --- what does CF mean? There is CF Oee CF Only One CF Many CF Many One CF Zero One CF Zero Many -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: desktop/source include/svx offapi/com qadevOOo/tests sc/source svx/inc
desktop/source/lib/lokclipboard.hxx|2 +- include/svx/svdobj.hxx |4 ++-- include/svx/svdoedge.hxx |4 ++-- include/svx/svdpagv.hxx|2 +- offapi/com/sun/star/drawing/FillProperties.idl |2 +- offapi/com/sun/star/drawing/GenericDrawPage.idl|2 +- offapi/com/sun/star/drawing/GraphicObjectShape.idl |2 +- offapi/com/sun/star/embed/XStorage2.idl|4 ++-- offapi/com/sun/star/form/NavigationBarMode.idl |2 +- offapi/com/sun/star/form/binding/BindableDatabaseDateField.idl |2 +- offapi/com/sun/star/form/binding/BindableDatabaseTimeField.idl |2 +- offapi/com/sun/star/sdb/XDatabaseRegistrationsListener.idl |2 +- offapi/com/sun/star/sdb/XSQLQueryComposer.idl |2 +- qadevOOo/tests/java/mod/_sw/SwAccessibleDocumentView.java |2 +- sc/source/ui/view/tabview2.cxx |4 ++-- svx/inc/sdr/primitive2d/sdrpathprimitive2d.hxx |2 +- 16 files changed, 20 insertions(+), 20 deletions(-) New commits: commit 3b28713ef82829fd1958d1ecf8c29b7391af78f5 Author: Andrea Gelmini AuthorDate: Fri Aug 2 18:56:25 2019 +0200 Commit: Julien Nabet CommitDate: Sat Aug 3 00:01:50 2019 +0200 Fix typos Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/desktop/source/lib/lokclipboard.hxx b/desktop/source/lib/lokclipboard.hxx index 7da5f3ef3900..fd305c9b9507 100644 --- a/desktop/source/lib/lokclipboard.hxx +++ b/desktop/source/lib/lokclipboard.hxx @@ -107,7 +107,7 @@ public: css::uno::Reference SAL_CALL createInstanceWithArguments(const css::uno::Sequence& /* rArgs */) override; -/// Fetch clipboard from the gobal pool. +/// Fetch clipboard from the global pool. static rtl::Reference getClipboardForCurView(); /// Release a clipboard before its document dies, nViewId of -1 clears all. diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx index 901d6b1caed1..36f29f9d9fcf 100644 --- a/include/svx/svdobj.hxx +++ b/include/svx/svdobj.hxx @@ -470,7 +470,7 @@ public: // set modified-flag in the model virtual void SetChanged(); -// Tooling for painting a single object to a OutputDevice. This will be needed as long +// Tooling for painting a single object to an OutputDevice. This will be needed as long // as not all painting is changed to use DrawContact objects. void SingleObjectPainter(OutputDevice& rOut) const; bool LineGeometryUsageIsNecessary() const; @@ -627,7 +627,7 @@ public: // (e.g. polygons, polylines, lines) // The points of those objects are selected (if necessary multiselection), // deleted, inserted, or as a multiselection moved or rotated... -// Only such objects can have PlusHandles (e.g. the weights of an Bezier curve). +// Only such objects can have PlusHandles (e.g. the weights of a Bezier curve). virtual bool IsPolyObj() const; virtual sal_uInt32 GetPointCount() const; virtual Point GetPoint(sal_uInt32 i) const; diff --git a/include/svx/svdoedge.hxx b/include/svx/svdoedge.hxx index c07a69adbbb2..16127d914ec8 100644 --- a/include/svx/svdoedge.hxx +++ b/include/svx/svdoedge.hxx @@ -88,7 +88,7 @@ public: longnAngle2; // exit angle at Obj2 sal_uInt16 nObj1Lines;// 1..3 sal_uInt16 nObj2Lines;// 1..3 -sal_uInt16 nMiddleLine; // 0x=none, otherwiese point number of the beginning of the line +sal_uInt16 nMiddleLine; // 0x=none, otherwise point number of the beginning of the line public: SdrEdgeInfoRec() @@ -288,7 +288,7 @@ public: // for geometry access ::basegfx::B2DPolygon getEdgeTrack() const; -// helper method for SdrDragMethod::AddConnectorOverlays. Adds a overlay polygon for +// helper method for SdrDragMethod::AddConnectorOverlays. Adds an overlay polygon for // this connector to rResult. basegfx::B2DPolygon ImplAddConnectorOverlay(SdrDragMethod& rDragMethod, bool bTail1, bool bTail2, bool bDetail) const; }; diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx index 79e5bbef684a..fe5884b33809 100644 --- a/include/svx/svdpagv.hxx +++ b/include/svx/svdpagv.hxx @@ -147,7 +147,7 @@ public: css::uno::Reference< css::awt::XControlContainer > GetControlContainer( const OutputDevice& _rDevice ) const; -/// Sets all elements in the view which support a design and a alive mode into the given mode +/// Sets all elements in the view which support a design and an alive mode into the given mode
[Libreoffice-bugs] [Bug 126674] LibreOffice 6.3.0~rc2-1 Writer: undesirable menu changes
https://bugs.documentfoundation.org/show_bug.cgi?id=126674 --- Comment #2 from John Parker --- Bug 120905 was evidently initially raised for LibreOffice Impress. I cannot comment about any improvements now made to its workflow. The bug mentions usability studies. With LibreOffice Writer, the three matters I raise are regressive features. I cannot believe that a usability study was carried out in Writer after the paragraph right-context menus were redesigned and that the usability study showed the new arrangement to be best. This is a tiny part of the overall Writer user interface. But I have to use it often. It's good to know that the developers faithfully implemented the design. For me, it's a regressive design. To be sure, LibreOffice provides a means of customising menus. But don't you think that for workflows everybody uses, efficient menus should be provided by default? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126674] LibreOffice 6.3.0~rc2-1 Writer: undesirable menu changes
https://bugs.documentfoundation.org/show_bug.cgi?id=126674 --- Comment #2 from John Parker --- Bug 120905 was evidently initially raised for LibreOffice Impress. I cannot comment about any improvements now made to its workflow. The bug mentions usability studies. With LibreOffice Writer, the three matters I raise are regressive features. I cannot believe that a usability study was carried out in Writer after the paragraph right-context menus were redesigned and that the usability study showed the new arrangement to be best. This is a tiny part of the overall Writer user interface. But I have to use it often. It's good to know that the developers faithfully implemented the design. For me, it's a regressive design. To be sure, LibreOffice provides a means of customising menus. But don't you think that for workflows everybody uses, efficient menus should be provided by default? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126682] New: Unable to print on Statement size paper(5.5"x8.5")
https://bugs.documentfoundation.org/show_bug.cgi?id=126682 Bug ID: 126682 Summary: Unable to print on Statement size paper(5.5"x8.5") Product: LibreOffice Version: 6.2.5.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dwp...@bellsouth.net Description: Setting up a statement size paper job on a Brother HL-2240 print with current drivers. Running Libre Office 6.2.5 on Intel i5 computer with Windows 10 ver. 1903 and latest updates as of 2 Aug. 2019. The page displays correctly in print preview as well as the print dialog window, however the printed page looks like the font is bigger than the 12 pt that was requested, and the page Steps to Reproduce: 1.Set printer to print Statement sized page- User defined a 5.5x8.5 2.compose page to print- displays correctly in print preview and the printer properties dialog box. 3.Print page- and the result is that the content prints too low on the page, leaving most of it off the page. The font does not appear to be the 12 pt that was in the original document Actual Results: Text printed too low on the page and two far to the left as one looked at it, with much of the text off the bottom of the page. Expected Results: The text was an invitation to be printed on 5.5x8.5 inch paper, centered and on the lower half of the page so the text would be on the inside when the page was folded over. Reproducible: Always User Profile Reset: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/unoobj/docuno.cxx | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) New commits: commit 5a9bdcbb0dfd6f149d243cd69e158aa3ad70dd91 Author: Michael Meeks AuthorDate: Sat Jul 27 21:33:05 2019 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 22:36:32 2019 +0200 calc: simplify getDocumentSize calculation. Change-Id: Iee2ebf2c6ed74651556647264f519caa9c59dad7 Reviewed-on: https://gerrit.libreoffice.org/76492 Tested-by: Jenkins Reviewed-by: Michael Meeks diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 9c7f24611cf5..640e35ec4c89 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -617,15 +617,7 @@ Size ScModelObj::getDocumentSize() }; long nDocWidthPixel = pViewData->GetLOKWidthHelper().computePosition(nEndCol, GetColWidthPx); - - -auto GetRowHeightPx = [pThisDoc, nTab](SCROW nRow) { -const sal_uInt16 nSize = pThisDoc->GetRowHeight(nRow, nTab); -return ScViewData::ToPixel(nSize, 1.0 / TWIPS_PER_PIXEL); -}; - -long nDocHeightPixel = pViewData->GetLOKHeightHelper().computePosition(nEndRow, GetRowHeightPx); - +long nDocHeightPixel = pThisDoc->GetScaledRowHeight( 0, nEndRow, nTab, 1.0 / TWIPS_PER_PIXEL ); if (nDocWidthPixel > 0 && nDocHeightPixel > 0) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit c7a86aa54bc4357a82a7fb584cbc5e6606b9e2c0 Author: Michael Meeks AuthorDate: Fri Aug 2 15:11:21 2019 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 22:36:08 2019 +0200 clipboard: add profile zones. Change-Id: I2c005e78884fbe35c3045f76c203a7a369e97646 Reviewed-on: https://gerrit.libreoffice.org/76885 Tested-by: Jenkins Reviewed-by: Michael Meeks diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index f17251c70bf5..e1640836bf3c 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -3611,6 +3611,8 @@ static char* doc_getTextSelection(LibreOfficeKitDocument* pThis, const char* pMi static int doc_getSelectionType(LibreOfficeKitDocument* pThis) { +comphelper::ProfileZone aZone("doc_getSelectionType"); + SolarMutexGuard aGuard; SetLastExceptionMsg(); @@ -3649,6 +3651,8 @@ static int doc_getClipboard(LibreOfficeKitDocument* pThis, size_t **pOutSizes, char ***pOutStreams) { +comphelper::ProfileZone aZone("doc_getClipboard"); + SolarMutexGuard aGuard; SetLastExceptionMsg(); @@ -3731,7 +3735,7 @@ static int doc_setClipboard(LibreOfficeKitDocument* pThis, const size_t *pInSizes, const char **pInStreams) { -comphelper::ProfileZone aZone("doc_paste"); +comphelper::ProfileZone aZone("doc_setClipboard"); SolarMutexGuard aGuard; SetLastExceptionMsg(); @@ -3761,6 +3765,8 @@ static int doc_setClipboard(LibreOfficeKitDocument* pThis, static bool doc_paste(LibreOfficeKitDocument* pThis, const char* pMimeType, const char* pData, size_t nSize) { +comphelper::ProfileZone aZone("doc_paste"); + SolarMutexGuard aGuard; const char *pInMimeTypes[1]; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 3 commits - desktop/qa desktop/source include/LibreOfficeKit include/vcl sc/source sd/source
desktop/qa/desktop_lib/test_desktop_lib.cxx |4 desktop/source/lib/init.cxx | 38 +++ include/LibreOfficeKit/LibreOfficeKit.h |6 + include/LibreOfficeKit/LibreOfficeKit.hxx | 15 ++ include/vcl/ITiledRenderable.hxx| 16 ++- sc/source/ui/unoobj/docuno.cxx |6 - sd/source/ui/inc/DrawViewShell.hxx |8 + sd/source/ui/inc/unomodel.hxx |6 + sd/source/ui/slidesorter/controller/SlsPageSelector.cxx | 11 +- sd/source/ui/slidesorter/inc/controller/SlsPageSelector.hxx | 13 +- sd/source/ui/unoidl/unomodel.cxx| 34 ++ sd/source/ui/view/drviews1.cxx | 62 12 files changed, 212 insertions(+), 7 deletions(-) New commits: commit 3750186a09655a9eac2d742e2aadf290c2819a8c Author: Ashod Nakashian AuthorDate: Sun Sep 16 17:25:01 2018 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 16:30:29 2019 -0400 LOK: getPartInfo now returns list of selected parts For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky diff --git a/include/vcl/ITiledRenderable.hxx b/include/vcl/ITiledRenderable.hxx index 4e9a80a5378b..2fc588b5c6ef 100644 --- a/include/vcl/ITiledRenderable.hxx +++ b/include/vcl/ITiledRenderable.hxx @@ -363,7 +363,8 @@ public: } /* - * Used for sheets in spreadsheet documents. + * Used for sheets in spreadsheet documents, + * and slides in presentation documents. */ virtual OUString getPartInfo(int /*nPart*/) { diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index 5f8d326096a5..0c91c076df28 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -551,10 +551,14 @@ OUString ScModelObj::getPartInfo( int nPart ) { OUString aPartInfo; ScViewData* pViewData = ScDocShell::GetViewData(); -bool bIsVisible = pViewData->GetDocument()->IsVisible(nPart); +const bool bIsVisible = pViewData->GetDocument()->IsVisible(nPart); +//FIXME: Implement IsSelected(). +const bool bIsSelected = false; //pViewData->GetDocument()->IsSelected(nPart); aPartInfo += "{ \"visible\": \""; aPartInfo += OUString::number(static_cast(bIsVisible)); +aPartInfo += "\", \"selected\": \""; +aPartInfo += OUString::number(static_cast(bIsSelected)); aPartInfo += "\" }"; return aPartInfo; } diff --git a/sd/source/ui/inc/DrawViewShell.hxx b/sd/source/ui/inc/DrawViewShell.hxx index 71f1ed4a397c..df118b58ef1f 100644 --- a/sd/source/ui/inc/DrawViewShell.hxx +++ b/sd/source/ui/inc/DrawViewShell.hxx @@ -247,7 +247,13 @@ public: boolSwitchPage(sal_uInt16 nPage); boolIsSwitchPageAllowed() const; +/** + * Mark the desired page as selected (1), deselected (0), toggle (2). + * nPage refers to the page in question. + */ boolSelectPage(sal_uInt16 nPage, sal_uInt16 nSelect); +boolIsSelected(sal_uInt16 nPage); +boolIsVisible(sal_uInt16 nPage); voidGotoBookmark(const OUString& rBookmark); //Realize multi-selection of objects, If object is marked, the diff --git a/sd/source/ui/slidesorter/controller/SlsPageSelector.cxx b/sd/source/ui/slidesorter/controller/SlsPageSelector.cxx index 1115d05227a9..544068f151b6 100644 --- a/sd/source/ui/slidesorter/controller/SlsPageSelector.cxx +++ b/sd/source/ui/slidesorter/controller/SlsPageSelector.cxx @@ -216,7 +216,7 @@ void PageSelector::CheckConsistency() const } } -bool PageSelector::IsPageSelected (int nPageIndex) +bool PageSelector::IsPageSelected(int nPageIndex) { SharedPageDescriptor pDescriptor (mrModel.GetPageDescriptor(nPageIndex)); if (pDescriptor.get() != nullptr) @@ -225,6 +225,15 @@ bool PageSelector::IsPageSelected (int nPageIndex) return false; } +bool PageSelector::IsPageVisible(int nPageIndex) +{ +SharedPageDescriptor pDescriptor (mrModel.GetPageDescriptor(nPageIndex)); +if (pDescriptor.get() != nullptr) +return pDescriptor->HasState(PageDescriptor::ST_Visible); +else +return false; +} + int PageSelector::GetPageCount() const { return mrModel.GetPageCount(); diff --git a/sd/source/ui/slidesorter/inc/controller/SlsPageSelector.hxx b/sd/source/ui/slidesorter/inc/controller/SlsPageSelector.hxx index cc994ced28af..c53c53519aaf 100644 ---
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 3 commits - configmgr/source desktop/qa desktop/source include/LibreOfficeKit
configmgr/source/access.cxx |9 + desktop/qa/desktop_lib/test_desktop_lib.cxx |3 ++- desktop/source/lib/init.cxx | 24 ++-- include/LibreOfficeKit/LibreOfficeKit.h |3 +++ include/LibreOfficeKit/LibreOfficeKit.hxx | 10 +++--- 5 files changed, 43 insertions(+), 6 deletions(-) New commits: commit 106c4786be04e60a25740d5b2af05c367563c669 Author: Ashod Nakashian AuthorDate: Mon Jan 28 10:03:32 2019 -0500 Commit: Michael Meeks CommitDate: Fri Aug 2 16:09:14 2019 -0400 configmgr: support changing locale language Change-Id: Ia8318ce8ca3ae9fdbd526e0d41861e2863fb9a94 Reviewed-on: https://gerrit.libreoffice.org/68262 Reviewed-by: Andras Timar Tested-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/73485 Tested-by: Jenkins Reviewed-by: Jan Holesovsky diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx index 26c8e7e5c516..c7ad2c538ae8 100644 --- a/configmgr/source/access.cxx +++ b/configmgr/source/access.cxx @@ -71,6 +71,8 @@ #include #include #include +#include +#include #include #include #include @@ -1380,6 +1382,13 @@ rtl::Reference< ChildAccess > Access::getChild(OUString const & name) { locale.isEmpty(), "configmgr", ("access best-matching localized property value via \"*\"" " with empty ; falling back to defaults")); + +// Since the locale given to us is the one used at initialization, +// here we override it with the actual current-user's language to +// support per-view localization in LOK. +if (comphelper::LibreOfficeKit::isActive()) +locale = comphelper::LibreOfficeKit::getLanguageTag().getLanguage(); + if (!locale.isEmpty()) { // Find best match using an adaption of RFC 4647 lookup matching // rules, removing "-" or "_" delimited segments from the end: commit d52461dbb1f918fe86bcf3f04630d44163e6f108 Author: Ashod Nakashian AuthorDate: Thu Jan 24 06:51:46 2019 -0500 Commit: Michael Meeks CommitDate: Fri Aug 2 16:08:45 2019 -0400 LOK: support creating view with options This adds a new API createViewWithOptions that make createView similar to documentLoad, which also has documentViewWithOptions version. This is primarily to support setting per-view language and similar settings. Change-Id: I0ae5a5b2410cf9e053aee8f7c8a6204af9038a31 Reviewed-on: https://gerrit.libreoffice.org/68261 Reviewed-by: Andras Timar Tested-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/7 Tested-by: Jenkins Reviewed-by: Michael Meeks diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx index 2b1c6ae96af6..16e9a516fa9d 100644 --- a/desktop/qa/desktop_lib/test_desktop_lib.cxx +++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx @@ -2455,9 +2455,10 @@ void DesktopLOKTest::testABI() CPPUNIT_ASSERT_EQUAL(documentClassOffset(45), offsetof(struct _LibreOfficeKitDocumentClass, getSignatureState)); CPPUNIT_ASSERT_EQUAL(documentClassOffset(46), offsetof(struct _LibreOfficeKitDocumentClass, renderShapeSelection)); CPPUNIT_ASSERT_EQUAL(documentClassOffset(47), offsetof(struct _LibreOfficeKitDocumentClass, postWindowGestureEvent)); +CPPUNIT_ASSERT_EQUAL(documentClassOffset(48), offsetof(struct _LibreOfficeKitDocumentClass, createViewWithOptions)); // Extending is fine, update this, and add new assert for the offsetof the // new method -CPPUNIT_ASSERT_EQUAL(documentClassOffset(48), sizeof(struct _LibreOfficeKitDocumentClass)); +CPPUNIT_ASSERT_EQUAL(documentClassOffset(49), sizeof(struct _LibreOfficeKitDocumentClass)); } CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest); diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 5ad5f1b7e3bc..3f2a3e0cdf32 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -684,6 +684,7 @@ static void doc_setClientZoom(LibreOfficeKitDocument* pThis, static void doc_setClientVisibleArea(LibreOfficeKitDocument* pThis, int nX, int nY, int nWidth, int nHeight); static void doc_setOutlineState(LibreOfficeKitDocument* pThis, bool bColumn, int nLevel, int nIndex, bool bHidden); static int doc_createView(LibreOfficeKitDocument* pThis); +static int doc_createViewWithOptions(LibreOfficeKitDocument* pThis, const char* pOptions); static void doc_destroyView(LibreOfficeKitDocument* pThis, int nId); static void doc_setView(LibreOfficeKitDocument* pThis, int nId); static int doc_getView(LibreOfficeKitDocument* pThis); @@ -792,6 +793,8 @@ LibLODocument_Impl::LibLODocument_Impl(const uno::Reference renderShapeSelection = doc_renderShapeSelection; m_pDocumentClass->postWindowGestureEvent = doc_postWindowGestureEvent; +m_pDocumentClass->createViewWithOptions =
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 4 commits - desktop/qa desktop/source include/LibreOfficeKit include/vcl vcl/inc vcl/source
desktop/qa/desktop_lib/test_desktop_lib.cxx |3 - desktop/source/lib/init.cxx | 45 ++ include/LibreOfficeKit/LibreOfficeKit.h |9 +++ include/LibreOfficeKit/LibreOfficeKit.hxx | 16 ++ include/vcl/GestureEvent.hxx| 42 + include/vcl/commandevent.hxx| 24 + include/vcl/svapp.hxx |3 + include/vcl/vclevent.hxx|1 vcl/inc/salwtype.hxx| 14 + vcl/inc/window.h|1 vcl/source/app/svapp.cxx| 68 +--- vcl/source/control/imp_listbox.cxx |4 + vcl/source/window/commandevent.cxx |9 +++ vcl/source/window/window.cxx|1 vcl/source/window/window2.cxx | 20 vcl/source/window/winproc.cxx | 44 ++ 16 files changed, 296 insertions(+), 8 deletions(-) New commits: commit e2817afbfff5039e3c2f40c250cf2a7a02accc5c Author: Tor Lillqvist AuthorDate: Tue Mar 26 17:51:37 2019 +0200 Commit: Michael Meeks CommitDate: Fri Aug 2 15:36:52 2019 -0400 Make contents of combobox follow the finger when scrolling with a pan gesture It is the contents that we are dragging with the gesture, not the scrollbar "thumb". The DoScroll() call takes as argument how much the "thumb" should be moved, though. Change-Id: Id95a4bf9d2bb4e950dd85c6bebb4d2b5f2726ee0 diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx index eb631d3edc8c..74e84ba381fa 100644 --- a/vcl/source/window/window2.cxx +++ b/vcl/source/window/window2.cxx @@ -765,7 +765,7 @@ bool Window::HandleScrollCommand( const CommandEvent& rCmd, else if(pData->meEventType == GestureEventType::PanningUpdate) { long nOriginalPosition = mpWindowImpl->mpFrameData->mnTouchPanPosition; -pVScrl->DoScroll(nOriginalPosition + (pData->mfOffset)); +pVScrl->DoScroll(nOriginalPosition + (pData->mfOffset / pVScrl->GetVisibleSize())); } if (pData->meEventType == GestureEventType::PanningEnd) { commit 690a6924ab6173547218151d7b9094154aaeea2a Author: Tomaž Vajngerl AuthorDate: Mon Mar 25 18:23:36 2019 +0900 Commit: Michael Meeks CommitDate: Fri Aug 2 15:36:09 2019 -0400 tdf#124146 support posting of gesture event for LOKit Change-Id: I51845f2e41dbcbe1ae6cb0a18cf9f42d5549968b Reviewed-on: https://gerrit.libreoffice.org/69657 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx index 5e71f5771835..2b1c6ae96af6 100644 --- a/desktop/qa/desktop_lib/test_desktop_lib.cxx +++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx @@ -2454,9 +2454,10 @@ void DesktopLOKTest::testABI() CPPUNIT_ASSERT_EQUAL(documentClassOffset(44), offsetof(struct _LibreOfficeKitDocumentClass, addCertificate)); CPPUNIT_ASSERT_EQUAL(documentClassOffset(45), offsetof(struct _LibreOfficeKitDocumentClass, getSignatureState)); CPPUNIT_ASSERT_EQUAL(documentClassOffset(46), offsetof(struct _LibreOfficeKitDocumentClass, renderShapeSelection)); +CPPUNIT_ASSERT_EQUAL(documentClassOffset(47), offsetof(struct _LibreOfficeKitDocumentClass, postWindowGestureEvent)); // Extending is fine, update this, and add new assert for the offsetof the // new method -CPPUNIT_ASSERT_EQUAL(documentClassOffset(47), sizeof(struct _LibreOfficeKitDocumentClass)); +CPPUNIT_ASSERT_EQUAL(documentClassOffset(48), sizeof(struct _LibreOfficeKitDocumentClass)); } CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest); diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 7dd7fe6644e1..afceb472a8e6 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -101,6 +101,7 @@ #include #include #include +#include #include #include #include @@ -648,6 +649,12 @@ static void doc_postWindowMouseEvent (LibreOfficeKitDocument* pThis, int nCount, int nButtons, int nModifier); +static void doc_postWindowGestureEvent(LibreOfficeKitDocument* pThis, + unsigned nLOKWindowId, + const char* pType, + int nX, + int nY, + int nOffset); static void doc_postUnoCommand(LibreOfficeKitDocument* pThis, const char* pCommand, const char* pArguments, @@ -783,6 +790,7 @@ LibLODocument_Impl::LibLODocument_Impl(const uno::Reference getSignatureState =
[Libreoffice-bugs] [Bug 126663] XLSX: LibreOffice is freezed when I try open Style list in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=126663 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Take about 20 seconds for me with Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL There are a thousands of styles. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126681] Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=126681 Telesto changed: What|Removed |Added Version|unspecified |6.2.5.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - 3 commits - editeng/source sc/source sw/source
editeng/source/editeng/editeng.cxx |3 +++ sc/source/ui/view/viewfun5.cxx |3 ++- sw/source/filter/html/htmlplug.cxx |6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) New commits: commit 3e27cea44ccb2a34bd96c03ed2f279324a145ea6 Author: Michael Meeks AuthorDate: Fri May 31 14:38:34 2019 +0100 Commit: Michael Meeks CommitDate: Fri Aug 2 15:33:51 2019 -0400 Avoid odd crash where OLE object can't generate an image preview. Change-Id: Ib77eca6907aa09383a96f3c9de6f7a7c4799c3bc diff --git a/sw/source/filter/html/htmlplug.cxx b/sw/source/filter/html/htmlplug.cxx index f71e81b9a8cc..1f1e50d3e489 100644 --- a/sw/source/filter/html/htmlplug.cxx +++ b/sw/source/filter/html/htmlplug.cxx @@ -1503,6 +1503,12 @@ Writer& OutHTML_FrameFormatOLENodeGrf( Writer& rWrt, const SwFrameFormat& rFrame return rWrt; } +if ( !pOLENd->GetGraphic() ) +{ +SAL_WARN("sw.html", "Unexpected missing OLE fallback graphic"); +return rWrt; +} + Graphic aGraphic( *pOLENd->GetGraphic() ); SwDocShell* pDocSh = rHTMLWrt.m_pDoc->GetDocShell(); commit d553a16bb89e1b4860b4f1dbbb9bbad4f9137460 Author: Michael Meeks AuthorDate: Wed May 29 17:53:35 2019 +0100 Commit: Michael Meeks CommitDate: Fri Aug 2 15:33:43 2019 -0400 lok: disable calc char-set dialog for HTML when pasting. Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab diff --git a/sc/source/ui/view/viewfun5.cxx b/sc/source/ui/view/viewfun5.cxx index fc5d357704cf..0eca9685ad61 100644 --- a/sc/source/ui/view/viewfun5.cxx +++ b/sc/source/ui/view/viewfun5.cxx @@ -304,7 +304,8 @@ bool ScViewFunc::PasteDataFormat( SotClipboardFormatId nFormatId, tools::SvRef xStream; if ( aDataHelper.GetSotStorageStream( nFormatId, xStream ) && xStream.is() ) { -if (nFormatId == SotClipboardFormatId::HTML) +if (nFormatId == SotClipboardFormatId::HTML && +!comphelper::LibreOfficeKit::isActive()) { // Launch the text import options dialog. For now, we do // this for html pasting only, but in the future it may commit 8a8affe9d4b4d33b10841f16f5121bcadfda9a99 Author: Michael Meeks AuthorDate: Wed May 29 15:20:32 2019 +0100 Commit: Michael Meeks CommitDate: Fri Aug 2 15:33:34 2019 -0400 lok: don't be prejudiced against a single missing mime-type. Change-Id: Ic5004c306cbd01071c397ed1a61ef094b439a48f diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index b8667061e42a..d547615299d2 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -2720,6 +2720,9 @@ bool EditEngine::HasValidData( const css::uno::Reference< css::datatransfer::XTr { bool bValidData = false; +if ( comphelper::LibreOfficeKit::isActive()) +return true; + if ( rTransferable.is() ) { // Every application that copies rtf or any other text format also copies plain text into the clipboard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126681] New: Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=126681 Bug ID: 126681 Summary: Crash in: mergedlo.dll Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: perrya...@comcast.net This bug was filed from the crash reporting server and is br-968edc7d-85b4-4d05-841d-9cb679bea204. = Started LibreOffice; Received an update notice for extensions. The update was successfully installed. LibreOffice crashed and this is the crash report -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/lokclipboard.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 6d1bf3d1bde72b2cbc2d867dd6ff566b3c4e1ca6 Author: Michael Meeks AuthorDate: Fri Aug 2 15:26:32 2019 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 15:28:08 2019 -0400 clipboard: elide string constructor. Change-Id: I1f476d981989296138ab9b9b58075919da4c09b8 diff --git a/desktop/source/lib/lokclipboard.cxx b/desktop/source/lib/lokclipboard.cxx index 8b7577f3bf63..46c63bc02951 100644 --- a/desktop/source/lib/lokclipboard.cxx +++ b/desktop/source/lib/lokclipboard.cxx @@ -79,10 +79,7 @@ Sequence LOKClipboard::getSupportedServiceNames_static() return aRet; } -OUString LOKClipboard::getImplementationName() -{ -return OUString("com.sun.star.datatransfer.LOKClipboard"); -} +OUString LOKClipboard::getImplementationName() { return "com.sun.star.datatransfer.LOKClipboard"; } Sequence LOKClipboard::getSupportedServiceNames() { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88296] Show Caps Lock status in LibreOffice UI
https://bugs.documentfoundation.org/show_bug.cgi?id=88296 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords|easyHack| --- Comment #28 from Roman Kuznetsov <79045_79...@mail.ru> --- No code point here => remove EasyHack keyword -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126679] AlgorithmIA
https://bugs.documentfoundation.org/show_bug.cgi?id=126679 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID Component|BASIC |deletionRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126680] New: Horizontal scrolling direction reversed with touchpad
https://bugs.documentfoundation.org/show_bug.cgi?id=126680 Bug ID: 126680 Summary: Horizontal scrolling direction reversed with touchpad Product: LibreOffice Version: 6.3.0.2 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jcgo...@protonmail.com Description: The horizontal scrolling direction in all Libreoffice products, when using a two-finger swipe to navigate around a document, is inverted (if I perform a right swipe, the scrollbar moves to the left, and vice versa). The vertical scrolling direction, when performing the up/down swipe, works as expected. All of the other applications which feature horizontal scrolling that I've tested so far (firefox, evince, gimp) exhibit the correct behavior, and I haven't managed to find a setting in Libreoffice which might be able to correct this. My system does not have any kind of "reverse scrolling direction" setting activated. I've also checked that activating this setting does not reverse the horizontal scrolling direction, but just the vertical one, in all applications (including Libreoffice). Note: I don't know if this is related to bug 76017, or if the bug is, as mentioned there, vendor-specific, but unfortunately I don't have another platform to test this on. I am not using Windows nor the Linux Synaptic driver, so I thought that a separate report could be useful. Steps to Reproduce: 1. open any Libreoffice product (calc, writer, etc.) on a laptop 2. use a two-finger swipe gesture from left to right on the touchpad Actual Results: The horizontal scrollbar moves from right to left, the opposite of the swipe gesture Expected Results: The horizontal scrollbar should move from left to right, in the same direction as the swipe gesture Reproducible: Always User Profile Reset: Yes Additional Info: [From the help] Version: 6.3.0.2 Build ID: 1:6.3.0~rc2-1 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk2; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB Calc: threaded [System] Distribution: Debian Unstable 4.19.37-6 (2019-07-18) x86_64 GNU/Linux Desktop environment: XFCE 4.12 Input device: elan touchpad on Thinkpad T480s Input device driver: xserver-xorg-input-libinput 0.28.2-2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126659] LibreOffice 6.2.6.1 x86_64 does not start after installing
https://bugs.documentfoundation.org/show_bug.cgi?id=126659 --- Comment #9 from Dan Lewis --- (In reply to Buovjaga from comment #7) > (In reply to Michael Stahl (CIB) from comment #1) > > SAL_USE_VCLPLUGIN=gen /opt/libreoffice6.2/program/sbase > > -> does this start? > > Dan: did you try this? Yes I did today (UTC -4). It increased the length of time the splash screen was visible for a few additional seconds. This is embarrassing: when I renamed the User folder and ran the program, it opened! I have a habit of creating a configure folder for each LO program I use (6.1, 6.2, 6.3). I am also lazy in that I copy the User folder from one of them to another. It has come back to haunt me. I think that this resolves this problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #12 from andreas_k --- Thanks for the Information l will do the best to give our users the best of odt. Thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #12 from andreas_k --- Thanks for the Information l will do the best to give our users the best of odt. Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 85430] FILEOPEN DOC OLE objects scaled down with messed up aspect ratio
https://bugs.documentfoundation.org/show_bug.cgi?id=85430 Buovjaga changed: What|Removed |Added Summary|FILEOPEN: OLE objects |FILEOPEN DOC OLE objects |scaled down with messed up |scaled down with messed up |aspect ratio in DOC file|aspect ratio --- Comment #9 from Buovjaga --- Still confirmed. Arch Linux 64-bit Version: 6.4.0.0.alpha0+ Build ID: 4bd1b38633d6cb288eb559afc0ac6b961538ae60 CPU threads: 8; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 24 July 2019 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126659] LibreOffice 6.2.6.1 x86_64 does not start after installing
https://bugs.documentfoundation.org/show_bug.cgi?id=126659 --- Comment #8 from Dan Lewis --- Created attachment 153111 --> https://bugs.documentfoundation.org/attachment.cgi?id=153111=edit This is the gdbtrace.log results. Perhaps the small size of this log file will reveal what is going on fairly quickly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126679] New: AlgorithmIA
https://bugs.documentfoundation.org/show_bug.cgi?id=126679 Bug ID: 126679 Summary: AlgorithmIA Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: broncanofede...@gmail.com https://algorithmia.agency It sometimes freezes when trying to save a Macro. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] website.git: Branch 'update' - check.php
check.php |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit df8f54e8e4d0af2ddd778eb3b6209ffa540c6eeb Author: Christian Lohmaier AuthorDate: Fri Aug 2 20:12:55 2019 +0200 Commit: Christian Lohmaier CommitDate: Fri Aug 2 20:12:55 2019 +0200 migrate 6.1 users to 6.2 diff --git a/check.php b/check.php index c24b3ca..1e44101 100644 --- a/check.php +++ b/check.php @@ -618,11 +618,11 @@ $build_hash_to_version = array( # where '' and '' will be substitued with the right value # NOTE: '&' in the URL has to be escaped as $update_map = array( -'stable' => array('gitid' => '5896ab1714085361c45cf540f76f60673dd96a72', - 'id' => 'LibreOffice 6.1.6', - 'version' => '6.1.6', +'stable' => array('gitid' => '1ec314fa52f458adc18c4f025c545a4e8b22c159', + 'id' => 'LibreOffice 6.2.5', + 'version' => '6.2.5', 'update_type' => 'text/html', - 'update_src' => 'https://www.libreoffice.org/download/download/?lang=version=6.1.6', + 'update_src' => 'https://www.libreoffice.org/download/download/?lang=version=6.2.5', 'substitute' => true ), 'latest' => array('gitid' => '1ec314fa52f458adc18c4f025c545a4e8b22c159', 'id' => 'LibreOffice 6.2.5', ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - svx/source
svx/source/sidebar/paragraph/ParaPropertyPanel.src | 532 ++--- 1 file changed, 268 insertions(+), 264 deletions(-) New commits: commit cc36ea775eb22fd95e3e746f1912264763faf57d Author: Matthias Seidel AuthorDate: Fri Aug 2 18:03:42 2019 + Commit: Matthias Seidel CommitDate: Fri Aug 2 18:03:42 2019 + Cleaned up whitespace, reordered Increase/Decrease Indent in sidebar diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.src b/svx/source/sidebar/paragraph/ParaPropertyPanel.src index ffa10f7a7928..5824653f08ac 100755 --- a/svx/source/sidebar/paragraph/ParaPropertyPanel.src +++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.src @@ -19,112 +19,114 @@ * */ + + #include "ParaPropertyPanel.hrc" #include #include "helpid.hrc" -#define MASKCOLOR MaskColor = Color { Red = 0x ; Green = 0x ; Blue = 0x ; }; +#define MASKCOLOR MaskColor = Color { Red = 0x ; Green = 0x ; Blue = 0x ; }; -#define SVX_PROPERTYPANEL_PARA_VERT_IDLIST \ -IdList = \ -{ \ -IID_VERT_TOP ; \ +#define SVX_PROPERTYPANEL_PARA_VERT_IDLIST \ +IdList =\ +{ \ +IID_VERT_TOP ; \ IID_VERT_CENTER ; \ IID_VERT_BOTTOM ; \ -}; \ +}; \ IdCount = { 3 ; }; #define SVX_PROPERTYPANEL_PARA_NUMBULLET_IDLIST \ -IdList = \ -{ \ -IID_BULLET ; \ -IID_NUMBER ; \ -}; \ +IdList =\ +{ \ +IID_BULLET ;\ +IID_NUMBER ;\ +}; \ IdCount = { 2 ; }; -//add by wj for sym2_7380 +// add by wj for sym2_7380 #define SVX_PROPERTYPANEL_PARA_NUMBULLET_IDLIST_RTL \ -IdList = \ -{ \ -IID_BULLET ; \ -IID_NUMBER ; \ -}; \ +IdList =\ +{ \ +IID_BULLET ;\ +IID_NUMBER ;\ +}; \ IdCount = { 2 ; }; Control RID_SIDEBAR_PARA_PANEL { -OutputSize = TRUE; -DialogControl = TRUE; -Border = FALSE; -Size = MAP_APPFONT( PROPERTYPAGE_WIDTH, PARA_SECTIONPAGE_HEIGHT ); +OutputSize = TRUE ; +DialogControl = TRUE ; +Border = FALSE ; +Size = MAP_APPFONT ( PROPERTYPAGE_WIDTH, PARA_SECTIONPAGE_HEIGHT ) ; HelpID = HID_PROPERTYPANEL_PARA_SECTION ; -Text = "Paragraph"; +Text = "Paragraph" ; ToolBox TBX_HORIZONTALALIGNMENT { -Pos = MAP_APPFONT ( TBX_HORI_ALIGN_X , TBX_HORI_ALIGN_Y ); -Size = MAP_APPFONT ( ALIGNMENT_TBX_WIDTH*4 ,ALIGNMENT_TBX_HEIGHT); +Pos = MAP_APPFONT ( TBX_HORI_ALIGN_X, TBX_HORI_ALIGN_Y ) ; +Size = MAP_APPFONT ( ALIGNMENT_TBX_WIDTH*4 ,ALIGNMENT_TBX_HEIGHT) ; SVLook = TRUE ; Border = FALSE ; -HelpID = HID_PPROPERTYPANEL_PARA_TBX_HALIGN; -Text = "Horizontal Alignment"; +HelpID = HID_PPROPERTYPANEL_PARA_TBX_HALIGN ; +Text = "Horizontal Alignment" ; ItemList = { ToolBoxItem { Identifier = BT_SUBSTLEFT ; -HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_LEFT; +HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_LEFT ; Text [ en-US ] = "Align Left" ; }; ToolBoxItem { Identifier = BT_SUBSTCENTER ; -HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_CENTER; +HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_CENTER ; Text [ en-US ] = "Align Center" ; }; ToolBoxItem { Identifier = BT_SUBSTRIGHT ; -HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_RIGHT; +HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_RIGHT ; Text [ en-US ] = "Align Right" ; }; ToolBoxItem { Identifier = BT_SUBSTJUSTIFY ; -HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_JUSTIFY; +HelpID = HID_PPROPERTYPANEL_PARA_TBI_HALIGN_JUSTIFY ; Text [ en-US ] = "Align Justified" ; }; }; }; ToolBox TBX_VERT_ALIGN { -HelpID = HID_PPROPERTYPANEL_PARA_TBX_VALIGN; +HelpID = HID_PPROPERTYPANEL_PARA_TBX_VALIGN ; SVLook = TRUE ; Border = FALSE ; -Pos = MAP_APPFONT ( TBX_VERT_ALIGN_X, TBX_VERT_ALIGN_Y ) ; -Size = MAP_APPFONT ( TOOLBOX_ITEM_WIDTH * 3 , TOOLBOX_ITEM_HEIGHT) ; +Pos = MAP_APPFONT ( TBX_VERT_ALIGN_X, TBX_VERT_ALIGN_Y ) ; +Size = MAP_APPFONT ( TOOLBOX_ITEM_WIDTH * 3, TOOLBOX_ITEM_HEIGHT) ;
[Libreoffice-commits] core.git: 2 commits - desktop/source offapi/com
desktop/source/lib/lokclipboard.hxx |2 +- offapi/com/sun/star/datatransfer/XTransferable2.idl |2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) New commits: commit 6a3c5b418437ae928553530b938f4b7b3e5ea9e0 Author: Michael Meeks AuthorDate: Fri Aug 2 13:58:48 2019 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 14:00:30 2019 -0400 clipboard: elide string constructor. Change-Id: I18c01e77e0ddf4b86f2f5ba610509555160f96c3 diff --git a/desktop/source/lib/lokclipboard.hxx b/desktop/source/lib/lokclipboard.hxx index 6c0509265db4..7da5f3ef3900 100644 --- a/desktop/source/lib/lokclipboard.hxx +++ b/desktop/source/lib/lokclipboard.hxx @@ -54,7 +54,7 @@ public: const css::uno::Reference& xTransferable, const css::uno::Reference& xClipboardOwner) override; -OUString SAL_CALL getName() override { return OUString("CLIPBOARD"); } +OUString SAL_CALL getName() override { return "CLIPBOARD"; } // XClipboardEx sal_Int8 SAL_CALL getRenderingCapabilities() override { return 0; } commit e5e26b83e722bc49727c434ea5c775a97f737566 Author: Michael Meeks AuthorDate: Fri Aug 2 13:13:51 2019 -0400 Commit: Michael Meeks CommitDate: Fri Aug 2 14:00:30 2019 -0400 XTransferable2 - add missing 'since' tag on isComplex. Change-Id: Ib8165edb4d87fb5bbb115fe26b8dbbe5a70bd59a diff --git a/offapi/com/sun/star/datatransfer/XTransferable2.idl b/offapi/com/sun/star/datatransfer/XTransferable2.idl index a6b53f0671e2..9fb99e600177 100644 --- a/offapi/com/sun/star/datatransfer/XTransferable2.idl +++ b/offapi/com/sun/star/datatransfer/XTransferable2.idl @@ -34,6 +34,8 @@ interface XTransferable2 : com::sun::star::datatransfer::XTransferable /** * Returns true if the selection contains embedded objects or is a large text blob. + * + * @since LibreOffice 6.4 */ boolean isComplex(); }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125529] Misplaced keyboard focus cursor within new tips dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125529 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 126495 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126495] An empty area in the Tip of the day is selected (for certain tool tips)
https://bugs.documentfoundation.org/show_bug.cgi?id=126495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 125529 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126497] LibreOffice Language Setting
https://bugs.documentfoundation.org/show_bug.cgi?id=126497 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||96000 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96000 [Bug 96000] [META] Spelling and grammar checking bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||126497 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126497 [Bug 126497] LibreOffice Language Setting -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||126530 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126530 [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112706] [META] DOC (binary) bullet and numbering list-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112706 Bug 112706 depends on bug 89164, which changed state. Bug 89164 Summary: FILEOPEN of .doc shows bulletpoints which should not exist https://bugs.documentfoundation.org/show_bug.cgi?id=89164 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120394] FILEOPEN: Numbers appear in numbered list MSO created in attached DOC without visible number format
https://bugs.documentfoundation.org/show_bug.cgi?id=120394 Justin L changed: What|Removed |Added CC||kant...@sra.uni-hannover.de --- Comment #13 from Justin L --- *** Bug 89164 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89164] FILEOPEN of .doc shows bulletpoints which should not exist
https://bugs.documentfoundation.org/show_bug.cgi?id=89164 Justin L changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Justin L --- *** This bug has been marked as a duplicate of bug 120394 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126653] Insert document Title in a cell, the title is not renewed whet the document is renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=126653 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- WFM by Comment 3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126658] Arrow Style modification workflow is unclear
https://bugs.documentfoundation.org/show_bug.cgi?id=126658 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Andreas, do you want change label of "Modify" button to "Rename"? And you can't change shape for existing arrow types, but you can add some new type: draw your shape, open Line dialog, go to Arrow styles tab, pres Add button, type new name and press OK. Your shape will be a new arrow style -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #11 from Regina Henschel --- (In reply to andreas_k from comment #10) > I had a look into source file > https://opengrok.libreoffice.org/xref/core/extras/source/palettes/standard. > soe?r=b15fef02 > > Is there an reason that each viewbox is different? The viewBox defines a coordinate system for its content. It allows to exactly determine the position and and size of its content parts in regard to other content parts. Because it is pure vector graphic, it does not have any "size". The author of a marker can use a viewBox as he likes. how the size will be > defined? from the viewbox (and there size) it's not possible to define the > arow size. The size is determined by the style of the object, which uses the arrow. The style has parts 'draw:marker-start="Circle" draw:marker-start-width="1cm"', for example. That means: Use the marker with name "Circle" and scale it so, that its width is 1cm. The rectangle given be the viewBox (third and forth value of it) is scaled with keeping ratio, so that the width of the viewBox is 1cm. This width is set in the UI in the "Line" dialog for direct formatting or in a graphic style in tab "Line". The default width, when switching on a marker, is determined by the thickness of the line. When changing the line width the marker width is adapted automatically, but you can set a different value manually. And if there is somewhere an parameter for the size in the code, > than it should be not to complicated to add an size drop down menu to the > array dialog window. The drop-down menu for the type of the marker is not a good place for it. But I can think of a section in the side bar, which provides a simplified UI. Keep in mind, that you have the option "center" in addition to the width, and that in ODF you can use an arbitrary value for the width and use arbitrary paths for the marker, only that it needs to be closed. The situation is different in OOXML. There you are restricted to a fix set of 6 marker types (incl. none) and a fix set of the three size values: large, medium, small. See 20.1.10.32 to 20.1.10.34 in the OOXML standard. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 126648] Arrow Style sorting after size
https://bugs.documentfoundation.org/show_bug.cgi?id=126648 --- Comment #11 from Regina Henschel --- (In reply to andreas_k from comment #10) > I had a look into source file > https://opengrok.libreoffice.org/xref/core/extras/source/palettes/standard. > soe?r=b15fef02 > > Is there an reason that each viewbox is different? The viewBox defines a coordinate system for its content. It allows to exactly determine the position and and size of its content parts in regard to other content parts. Because it is pure vector graphic, it does not have any "size". The author of a marker can use a viewBox as he likes. how the size will be > defined? from the viewbox (and there size) it's not possible to define the > arow size. The size is determined by the style of the object, which uses the arrow. The style has parts 'draw:marker-start="Circle" draw:marker-start-width="1cm"', for example. That means: Use the marker with name "Circle" and scale it so, that its width is 1cm. The rectangle given be the viewBox (third and forth value of it) is scaled with keeping ratio, so that the width of the viewBox is 1cm. This width is set in the UI in the "Line" dialog for direct formatting or in a graphic style in tab "Line". The default width, when switching on a marker, is determined by the thickness of the line. When changing the line width the marker width is adapted automatically, but you can set a different value manually. And if there is somewhere an parameter for the size in the code, > than it should be not to complicated to add an size drop down menu to the > array dialog window. The drop-down menu for the type of the marker is not a good place for it. But I can think of a section in the side bar, which provides a simplified UI. Keep in mind, that you have the option "center" in addition to the width, and that in ODF you can use an arbitrary value for the width and use arbitrary paths for the marker, only that it needs to be closed. The situation is different in OOXML. There you are restricted to a fix set of 6 marker types (incl. none) and a fix set of the three size values: large, medium, small. See 20.1.10.32 to 20.1.10.34 in the OOXML standard. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-commits] core.git: 27 commits ...
Hi Stephan, On 02/08/2019 17:07, Stephan Bergmann wrote: >> + /** >> + * Returns true if the selection contains embedded objects or is >> a large text blob. > > Please provide a @since tag. Will add that. > (And one wonders why these patches didn't get in through Gerrit.) Oh - that's simple, it's a chunk of work that for uninteresting, customer related reasons had to be done internally, and fiddling with and/or re-basing 27 stacked commits multiple times will either kill CI for everyone or if done one by one, take an extremely long time to get in, and/or would need squashing thus loosing the history and/or authorship; so I pushed just a terminal commit through gerrit / CI. The good news is that (with the Online side which is also coming) this gives us some excellent clipboard support for Online. Thanks for the review, Michael. -- michael.me...@collabora.com <><, GM Collabora Productivity Hangout: mejme...@gmail.com, Skype: mmeeks (M) +44 7795 666 147 - timezone usually UK / Europe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sw/qa sw/source
sw/qa/extras/tiledrendering/data/image-comment.odt |binary sw/qa/extras/tiledrendering/tiledrendering.cxx | 47 + sw/source/uibase/docvw/PostItMgr.cxx | 22 - 3 files changed, 67 insertions(+), 2 deletions(-) New commits: commit d2f4a7518946ac195505308e74f411c25a459fcc Author: Miklos Vajna AuthorDate: Fri Aug 2 12:31:00 2019 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 2 19:04:40 2019 +0200 sw comments on frames: no overlay in the LOK API, either: insert case This is similar to commit 28fcb7d86765194b4015e7023449333f43aba0c5 (sw comments on frames: no overlay in the LOK API, either, 2019-07-16), but that one handled the initial fetch of comment states, while this one does the incremental updates. With this, there is no overlay on commented images right after inserting them. (cherry picked from commit 225930119543975697d3f5f042e271f0ec6c6b15) [ cp-6.2 backport note: added explicit IsEmpty() check, otherwise we would expose negative width/height for empty rectangles via LOK, which doesn't happen on master. ] [ cp-6.2 backport note: use the comphelper::dispatchCommand() variant that takes no explicit frames, the default frame seems to working here and we can't be explicit on this branch. ] Change-Id: I060303806a6611b113b4813300ed1cafd0b654fa Reviewed-on: https://gerrit.libreoffice.org/76880 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna diff --git a/sw/qa/extras/tiledrendering/data/image-comment.odt b/sw/qa/extras/tiledrendering/data/image-comment.odt new file mode 100644 index ..0852bedabf7f Binary files /dev/null and b/sw/qa/extras/tiledrendering/data/image-comment.odt differ diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index 9b2984b7af9f..701c135a579e 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -98,6 +98,7 @@ public: void testCreateViewTextSelection(); void testRedlineColors(); void testCommentEndTextEdit(); +void testCommentInsert(); void testCursorPosition(); void testPaintCallbacks(); void testUndoRepairResult(); @@ -156,6 +157,7 @@ public: CPPUNIT_TEST(testCreateViewTextSelection); CPPUNIT_TEST(testRedlineColors); CPPUNIT_TEST(testCommentEndTextEdit); +CPPUNIT_TEST(testCommentInsert); CPPUNIT_TEST(testCursorPosition); CPPUNIT_TEST(testPaintCallbacks); CPPUNIT_TEST(testUndoRepairResult); @@ -727,6 +729,8 @@ public: boost::property_tree::ptree m_aRedlineTableChanged; /// Redline table modified payload boost::property_tree::ptree m_aRedlineTableModified; +/// Post-it / annotation payload. +boost::property_tree::ptree m_aComment; ViewCallback() : m_bOwnCursorInvalidated(false), @@ -861,6 +865,14 @@ public: m_aRedlineTableModified = m_aRedlineTableModified.get_child("redline"); } break; +case LOK_CALLBACK_COMMENT: +{ +m_aComment.clear(); +std::stringstream aStream(pPayload); +boost::property_tree::read_json(aStream, m_aComment); +m_aComment = m_aComment.get_child("comment"); +} +break; } } }; @@ -1721,6 +1733,41 @@ void SwTiledRenderingTest::testCommentEndTextEdit() CPPUNIT_ASSERT(aView1.m_bTilesInvalidated); } +void SwTiledRenderingTest::testCommentInsert() +{ +// Load a document with an as-char image in it. +comphelper::LibreOfficeKit::setActive(); +comphelper::LibreOfficeKit::setTiledAnnotations(false); +SwXTextDocument* pXTextDocument = createDoc("image-comment.odt"); +SwDoc* pDoc = pXTextDocument->GetDocShell()->GetDoc(); +SwView* pView = pDoc->GetDocShell()->GetView(); + +// Select the image. +pView->GetViewFrame()->GetDispatcher()->Execute(FN_CNTNT_TO_NEXT_FRAME, SfxCallMode::SYNCHRON); +// Make sure SwTextShell is replaced with SwDrawShell right now, not after 120 ms, as set in the +// SwView ctor. +pView->StopShellTimer(); + +// Add a comment. +uno::Sequence aPropertyValues = comphelper::InitPropertySequence( +{ +{"Text", uno::makeAny(OUString("some text"))}, +{"Author", uno::makeAny(OUString("me"))}, +}); +ViewCallback aView; + SfxViewShell::Current()->registerLibreOfficeKitViewCallback(::callback, ); +comphelper::dispatchCommand(".uno:InsertAnnotation", aPropertyValues); +Scheduler::ProcessEventsToIdle(); +OString aAnchorPos(aView.m_aComment.get_child("anchorPos").get_value().c_str()); +// Without the accompanying fix in place, this test would have failed with +// - Expected: 1418, 1418, 0, 0 +// - Actual : 1418, 1418, 1024, 1024 +// i.e. the anchor position was a non-empty rectangle. +
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 07e2d6ca179f13666a9d7adfbf1d907ddc5b878b Author: Andrea Gelmini AuthorDate: Fri Aug 2 18:37:43 2019 +0200 Commit: Julien Nabet CommitDate: Fri Aug 2 19:01:33 2019 +0200 Removed duplicated include Change-Id: Ic54fab581f34f385f5a6395bb39020299fbf2bde Reviewed-on: https://gerrit.libreoffice.org/76882 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 7193b1ec4571..f17251c70bf5 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -56,7 +56,6 @@ #include #include #include -#include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126531] Connector Behavior Broken since 6.2.x
https://bugs.documentfoundation.org/show_bug.cgi?id=126531 raal changed: What|Removed |Added CC||armin.le.gr...@me.com, ||r...@post.cz Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisected, bisected, ||regression --- Comment #1 from raal --- This seems to have begun at the below commit. Adding Cc: to Armin Le Grand; Could you possibly take a look at this one? Thanks b323a719527dcf7aaf9dbcf0bd62b59eaecdb511 is the first bad commit commit b323a719527dcf7aaf9dbcf0bd62b59eaecdb511 Author: Norbert Thiebaud Date: Mon Jun 4 13:57:17 2018 -0700 source sha:726d7e7b8b50dca9914329dbfd9491f7c8961f68 source sha:726d7e7b8b50dca9914329dbfd9491f7c8961f68 source sha:a28a839b9f9eeec1544c5ceeeabe7b1083ce1655 source sha:4b4942224b550235da228655677b5c068a053254 author Armin Le Grand 2018-05-25 12:58:10 +0200 committer Armin Le Grand 2018-05-25 12:59:48 +0200 commit 726d7e7b8b50dca9914329dbfd9491f7c8961f68 (patch) treeaba7b05720e84dc38dabe93f6a51825326c2a7be parent a28a839b9f9eeec1544c5ceeeabe7b1083ce1655 (diff) tdf#117629: Remove again after next step of SOSAW080 is done -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126543] Hebrew interface menus appear on the left, though act as though they're on the right
https://bugs.documentfoundation.org/show_bug.cgi?id=126543 eladh...@gmail.com changed: What|Removed |Added Blocks||43808 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=43808 [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 eladh...@gmail.com changed: What|Removed |Added Depends on||126543 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126543 [Bug 126543] Hebrew interface menus appear on the left, though act as though they're on the right -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs