[Libreoffice-bugs] [Bug 132443] Background of the Field headers of the Table Controls are white instead of grey
https://bugs.documentfoundation.org/show_bug.cgi?id=132443 --- Comment #3 from Rob Westein --- On Ubuntu 18.04 I installed it via the PPA. Due to some other issues I will remove this PPA installation. The version that works on Mint (6.3) was installed via DEB. 4.6 was installed via SNAP / Ubuntu Software... So you suggest to not use SNAP or PPA? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71956] Other: The ability to set a different color for diacritics is missing for Arabic
https://bugs.documentfoundation.org/show_bug.cgi?id=71956 --- Comment #7 from Heiko Tietze --- *** Bug 129330 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129330] Change Arabic diacritics' colours separate from base font colour?
https://bugs.documentfoundation.org/show_bug.cgi?id=129330 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Heiko Tietze --- Why not make it a duplicate then? Interesting observation the latin á is entered per acut ´ followed by a. Find and replace for [^uB4] selects the whole letter and changing the font applies to all parts. The same with Alef plus Alef Superscript (U+670) splits the letter into two pieces. Not really what we want ;-) *** This bug has been marked as a duplicate of bug 71956 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 129330, which changed state. Bug 129330 Summary: Change Arabic diacritics' colours separate from base font colour? https://bugs.documentfoundation.org/show_bug.cgi?id=129330 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122461] SQL error with Query Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=122461 Lionel Elie Mamane changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |lio...@mamane.lu |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132755] No Apple Crash Report after crash when autorecovery dialog kicks in
https://bugs.documentfoundation.org/show_bug.cgi?id=132755 --- Comment #8 from Tor Lillqvist --- No. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130136] Resolved
https://bugs.documentfoundation.org/show_bug.cgi?id=130136 Ming Hua changed: What|Removed |Added Status|RESOLVED|CLOSED URL|http://canoncomijsetup.us/ | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130136] Resolved
https://bugs.documentfoundation.org/show_bug.cgi?id=130136 --- Comment #3 from Smith Jonshone --- Want to make changes or cancel the flight of American Airlines, but confuse how to do it? Get all reliable information about American Airlines Manage Booking here. For more info:- https://bookaflight.us/american-airlines-manage-booking/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132671] FILEOPEN Text Import dialog changes text separator 'other' character when reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=132671 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132223] failure to update master/slave link when no changes made to that specific property but editing other sub-form details...
https://bugs.documentfoundation.org/show_bug.cgi?id=132223 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132336] Compare document on DOCX fails on footnotes/footer
https://bugs.documentfoundation.org/show_bug.cgi?id=132336 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132212] Text flow not correct after loading a large document
https://bugs.documentfoundation.org/show_bug.cgi?id=132212 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132343] PPTX import: Scaled shadow distance is not equal between LO and MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=132343 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132350] Icon of updates button on right end of menu bar is still not visible (or again not visible)
https://bugs.documentfoundation.org/show_bug.cgi?id=132350 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128043] LibreOffice shows no letters after enabling 'Use OpenGL for rendering'
https://bugs.documentfoundation.org/show_bug.cgi?id=128043 --- Comment #3 from QA Administrators --- Dear tom knaffl, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128043] LibreOffice shows no letters after enabling 'Use OpenGL for rendering'
https://bugs.documentfoundation.org/show_bug.cgi?id=128043 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49149] PRINTING: LibO always uses CUPS default settings instead of what I choose for printing
https://bugs.documentfoundation.org/show_bug.cgi?id=49149 --- Comment #32 from QA Administrators --- Dear ueczz, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132671] FILEOPEN Text Import dialog changes text separator 'other' character when reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=132671 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107675] EDITING: Partially removing the border formatting of table row isn't working (steps to reproduce in comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=107675 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107545] DOCX: Template filename and not title should be saved
https://bugs.documentfoundation.org/show_bug.cgi?id=107545 --- Comment #3 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128356] Select Paragraph Area Fills save incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=128356 --- Comment #3 from QA Administrators --- Dear imnottouchingyou, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71956] Other: The ability to set a different color for diacritics is missing for Arabic
https://bugs.documentfoundation.org/show_bug.cgi?id=71956 --- Comment #6 from Munzir Taha --- I am not sure how you selected the diacritic and changed its color. Why didn't you make the whole word as the one I referred to? If you have typed it separately and then moved it to that location, that won't count of course. There should be an easy way to select the diacritic. For the implementation to be complete, there should also be a way to find and change the Arabic diacritic color. An example of an app that already implemented this so you understand the issue better is: https://helpx.adobe.com/indesign/using/arabic-hebrew.html#id_26234 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
32-bit Linux build error: no matching function for call to 'assertEquals'
[CXX] toolkit/qa/cppunit/EventContainer.cxx /core/toolkit/qa/cppunit/EventContainer.cxx:73:5: error: no matching function for call to 'assertEquals' CPPUNIT_ASSERT_EQUAL(4, nEventCount); ^~~~ /core/workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:333:5: note: expanded from macro 'CPPUNIT_ASSERT_EQUAL' ( CPPUNIT_NS::assertEquals( (expected), \ ^~~~ /core/workdir/UnpackedTarball/cppunit/include/cppunit/Portability.h:107:21: note: expanded from macro 'CPPUNIT_NS' # define CPPUNIT_NS CppUnit ^ /core/workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:161:6: note: candidate template ignored: deduced conflicting types for parameter 'T' ('int' vs. 'long') void assertEquals( const T& expected, ^ 1 error generated. make[1]: *** [/core/solenv/gbuild/LinkTarget.mk:306: /core/workdir/CxxObject/toolkit/qa/cppunit/EventContainer.o] Error 1 make[1]: *** Waiting for unfinished jobs make: *** [Makefile:282: build] Error 2 This looks to have begun after: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4021fedf758b Samuel, Any idea what's wrong? -Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 132082] Users can't edit in the Japanese display environment
https://bugs.documentfoundation.org/show_bug.cgi?id=132082 --- Comment #4 from Babbles --- I've updated to the version below and it hasn't improved. > collaboraofficebasis6.2-calc.x86_64 6.2.10.11-11 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114272] [macOS] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 --- Comment #20 from Kamei --- Sorry for forgetting put my macOS version. macOS Catalina 10.15.4(19E287) And you do not need to put '①' necessarily. (For example, ⌘ or ⌥ instead ①, like above the post) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87057] comment box text should have style options
https://bugs.documentfoundation.org/show_bug.cgi?id=87057 --- Comment #13 from peterjohnee1 --- Your reputation, values and happiness largely depend on your ability to deal with people around you. Try something you've never wanted to look for here https://cookieclicker.io -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87057] comment box text should have style options
https://bugs.documentfoundation.org/show_bug.cgi?id=87057 peterjohnee1 changed: What|Removed |Added URL||https://cookieclicker.io --- Comment #12 from peterjohnee1 --- Your reputation, values and happiness largely depend on your ability to deal with people around you. Try something you've never wanted to look for here -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132831] Finish button has no effect when using form creation wizard at the end of creation process. UI.
https://bugs.documentfoundation.org/show_bug.cgi?id=132831 --- Comment #1 from Bill Hammond --- Created attachment 160514 --> https://bugs.documentfoundation.org/attachment.cgi?id=160514=edit Test database This is a simple, blank database that I used to reproduce the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132831] New: Finish button has no effect when using form creation wizard at the end of creation process. UI.
https://bugs.documentfoundation.org/show_bug.cgi?id=132831 Bug ID: 132831 Summary: Finish button has no effect when using form creation wizard at the end of creation process. UI. Product: LibreOffice Version: 6.4.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ka1...@gmail.com Description: I've recently upgraded to Ubuntu 20.04 and LibreOffice 6.4.3.2 and tried to add a form to an existing data base using the form creation wizard. When I get to the final page of the procedure and click on the Finish button, nothing much happens. The Cancel button gets highlighted and the dialog just sits there. The other buttons seem to work. The only way out is to click Cancel, but that doesn't save the form. I seem to have this problem in a previously created database under an earlier version of Base and a database created with this latest version. Steps to Reproduce: 1. Open the form creation wizard. 2. Create a form as usual. 3. Click the Finish button at the end of the creation process. Actual Results: I was able to progress through the steps to create a form. At the end of the procedure, I pressed the Finish button and the Cancel button was highlighted. Subsequently clicking Finish had no effect. The only way out of the dialog was to press the Cancel button and abort the creation process. Expected Results: Upon clicking Finish, the creation dialog should have gone away and the form should have been open for data entry. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.4.3.2 Build ID: 1:6.4.3-0ubuntu0.20.04.1 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71956] Other: The ability to set a different color for diacritics is missing for Arabic
https://bugs.documentfoundation.org/show_bug.cgi?id=71956 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9330 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129330] Change Arabic diacritics' colours separate from base font colour?
https://bugs.documentfoundation.org/show_bug.cgi?id=129330 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=71 ||956 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129330] Change Arabic diacritics' colours separate from base font colour?
https://bugs.documentfoundation.org/show_bug.cgi?id=129330 --- Comment #8 from Khaled Hosny --- Coloring marks independent of their bases does not work correctly in LibreOffice, see bug 71956. Fixing this will require refactoring how text color is handled in LibreOffice since right now it is tied to the font, and different color means a different font internally and OpenType text layout does not work across fonts, so positing and other layout features will be broken. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132770] Underline words from HTML document do not appear
https://bugs.documentfoundation.org/show_bug.cgi?id=132770 --- Comment #1 from Konstantin Kharlamov --- I have debugged this for a bit, to give some update: it looks like LO Writer has support for tag. So what happens here seems to be an actual bug (I mean, missing support for basic tag would be one too, but it could've been fixed much easier). At the moment I figured that the difference between when "italic" and "underline" are parsed is the content of `pCFormat` being assigned as: SwCharFormat* pCFormat = m_pCSS1Parser->GetChrFormat( nToken, aClass ); Its field pCFormat->m_aSet has 3 members in case of italic: 11 = { > = { = { = { _vptr.SfxPoolItem = 0x7ff263673c70 , m_nRefCount = 2, m_nWhich = 11, m_nKind = SfxItemKind::NONE }, }, members of SfxEnumItem: m_nValue = ITALIC_NORMAL }, }, … 25 = { > = { = { = { _vptr.SfxPoolItem = 0x7ff263673c70 , m_nRefCount = 2, m_nWhich = 25, m_nKind = SfxItemKind::NONE }, }, members of SfxEnumItem: m_nValue = ITALIC_NORMAL }, }, 26 = 0x0, … 29 = 0x0, 30 = { > = { = { = { _vptr.SfxPoolItem = 0x7ff263673c70 , m_nRefCount = 2, m_nWhich = 30, m_nKind = SfxItemKind::NONE }, }, members of SfxEnumItem: m_nValue = ITALIC_NORMAL }, }, But in case of underlined it is all zeroes. Not sure just yet what to make of it. Doesn't help though is that gdb is like trying to explode while loading the office. It quickly grew to 2.2GB and hanged for 5 minutes on printing the field, so I had to -SIGKILL it in the end. I am wondering if it can be cause by pretty-printers of LibreOffice and whatnot. Does gdb load them by default? Gotta check that out, I've never seen such behavior with gdb before. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112423] MySQL native connector "Commands out of sync..." when calling procedure second time. - Crash
https://bugs.documentfoundation.org/show_bug.cgi?id=112423 --- Comment #30 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/93686 I just used https://dev.mysql.com/doc/refman/8.0/en/c-api-multiple-queries.html but don't know if it's the right thing to do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132828] FILEOPEN CSV in Calc now requires mouse or 20 key presses (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=132828 --- Comment #2 from Ming Hua --- (In reply to Ming Hua from comment #1) > Or maybe Ubuntu is doing funny things with their package version number... According to http://changelogs.ubuntu.com/changelogs/pool/main/libr/libreoffice/libreoffice_6.4.3-0ubuntu0.20.04.1/changelog the reporter's version is indeed based on 6.4.3 final release, so this should not happen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132828] FILEOPEN CSV in Calc now requires mouse or 20 key presses (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=132828 Ming Hua changed: What|Removed |Added CC||ming.v@qq.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1076 --- Comment #1 from Ming Hua --- Hi Marco, thanks for reporting this bug. When you say "Since 6.4.3, this doesn't work any more", which version were you comparing to? A similar issue was reported as bug 131076, but that was for versions 6.4.0 to 6.4.2, and should have been fixed for 6.4.3. Or maybe Ubuntu is doing funny things with their package version number... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132755] No Apple Crash Report after crash when autorecovery dialog kicks in
https://bugs.documentfoundation.org/show_bug.cgi?id=132755 Telesto changed: What|Removed |Added CC||t...@iki.fi --- Comment #7 from Telesto --- @Tor Any clue related to MacOS crash reports? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132830] New: Insert -> Shape -> Rectangle is still active after first use
https://bugs.documentfoundation.org/show_bug.cgi?id=132830 Bug ID: 132830 Summary: Insert -> Shape -> Rectangle is still active after first use Product: LibreOffice Version: 7.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Insert -> Shape -> Rectangle is still active after first use Steps to Reproduce: 1. Open Writer 2. Insert -> Shape -> Basic shape -> Rectangle -> Draw it 3. Without deselecting the shape 4. Insert -> Shape -> Basic shape -> Rectangle -> Can't be selected/still selected Actual Results: Rectangle still active Expected Results: Not Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ (x64) Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132820] UI: Height input box smaller compared to width (document specific)
https://bugs.documentfoundation.org/show_bug.cgi?id=132820 --- Comment #2 from Telesto --- Created attachment 160513 --> https://bugs.documentfoundation.org/attachment.cgi?id=160513=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132825] The layout/number of pages changes between inserting footer and save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=132825 Telesto changed: What|Removed |Added Version|7.0.0.0.alpha0+ Master |3.5.7.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132825] The layout/number of pages changes between inserting footer and save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=132825 --- Comment #3 from Telesto --- Also in. LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b Please choose the worst case outcome.. So if only top header already increases the page count, its fine :-). Save & reload -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132829] New: Copying to protected cells
https://bugs.documentfoundation.org/show_bug.cgi?id=132829 Bug ID: 132829 Summary: Copying to protected cells Product: LibreOffice Version: 6.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nunomvar...@gmail.com Description: In a protected sheet, when copying some random (unprotected) cells from one row and pasting them together in another row (with protected cells), protected cells are overwritten and become unprotected with copied contents... (sorry for my bad grammar) Steps to Reproduce: 1.selecting random (unprotected) cells in a prtotected sheet 2.pasting them together in another row (with protected cells) 3.overwritten and become unprotected with copied contents Actual Results: all overwritten cells become unprotected with copied contents Expected Results: It should had prevented copying to protected cells giving an alert Reproducible: Always User Profile Reset: No Additional Info: Versão: 6.4.3.2 (x64) ID da versão: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8 Processos do CPU: 4; SO: Windows 10.0 Build 19041; Gestão da interface: GL; VCL: win; Configuração regional: pt-PT (pt_PT); Idioma da interface: pt-PT Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132825] The layout/number of pages changes between inserting footer and save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=132825 --- Comment #2 from Telesto --- Created attachment 160512 --> https://bugs.documentfoundation.org/attachment.cgi?id=160512=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75914] Opening document properties dialog removes line breaks from custom properties
https://bugs.documentfoundation.org/show_bug.cgi?id=75914 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #15 from Julien Nabet --- Created attachment 160511 --> https://bugs.documentfoundation.org/attachment.cgi?id=160511=edit screenshot On pc Debian x86-64 with master sources updated today but line break character is badly display in custom properties (see screenshot). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: drawinglayer/source svx/source
drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |4 +++- svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx | 13 +++-- svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx| 13 +++-- 3 files changed, 17 insertions(+), 13 deletions(-) New commits: commit 99c337d1d3831ce9d2c7dc1cbff713f4ac49d6ac Author: Mike Kaganski AuthorDate: Thu May 7 08:03:22 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 23:12:41 2020 +0200 tdf#132199: put glow before shadow, to have shadow of the glow Also take modified color into account when drawing glow. Change-Id: Iba136d2695cb783d13ff251d087066c2e8803d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93605 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx index 6c14c09c1a19..cb0e3124b19d 100644 --- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx @@ -975,7 +975,9 @@ void VclPixelProcessor2D::processGlowPrimitive2D(const primitive2d::GlowPrimitiv BitmapFilter::Filter(mask, BitmapFilterStackBlur(fBlurRadius)); // The end result is the bitmap filled with glow color and blurred 8-bit alpha mask -bitmap.Erase(rCandidate.getGlowColor()); +const basegfx::BColor aGlowColor( + maBColorModifierStack.getModifiedColor(rCandidate.getGlowColor().getBColor())); +bitmap.Erase(Color(aGlowColor)); // alpha mask will be scaled up automatically to match bitmap BitmapEx result(bitmap, AlphaMask(mask.GetBitmap())); diff --git a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx index 804a653c86b2..378d78f5c6f6 100644 --- a/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx +++ b/svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx @@ -52,6 +52,13 @@ namespace drawinglayer::primitive2d getWordWrap())); } +// tdf#132199: put glow before shadow, to have shadow of the glow, not the opposite +if (!aRetval.empty() && !getSdrSTAttribute().getGlow().isDefault()) +{ +// glow +aRetval = createEmbeddedGlowPrimitive(aRetval, getSdrSTAttribute().getGlow()); +} + // add shadow if(!aRetval.empty() && !getSdrSTAttribute().getShadow().isDefault()) { @@ -71,12 +78,6 @@ namespace drawinglayer::primitive2d } } -if(!aRetval.empty() && !getSdrSTAttribute().getGlow().isDefault()) -{ -// glow -aRetval = createEmbeddedGlowPrimitive(aRetval, getSdrSTAttribute().getGlow()); -} - rContainer.insert(rContainer.end(), aRetval.begin(), aRetval.end()); } diff --git a/svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx b/svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx index 9f15f4d9fc41..2a83e5b6aeed 100644 --- a/svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx +++ b/svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx @@ -115,6 +115,13 @@ namespace drawinglayer::primitive2d false)); } +// tdf#132199: put glow before shadow, to have shadow of the glow, not the opposite +if (!aRetval.empty() && !getSdrLFSTAttribute().getGlow().isDefault()) +{ +// glow +aRetval = createEmbeddedGlowPrimitive(aRetval, getSdrLFSTAttribute().getGlow()); +} + // add shadow if(!getSdrLFSTAttribute().getShadow().isDefault()) { @@ -125,12 +132,6 @@ namespace drawinglayer::primitive2d aTranslateGrf.getY()); } -if (!aRetval.empty() && !getSdrLFSTAttribute().getGlow().isDefault()) -{ -// glow -aRetval = createEmbeddedGlowPrimitive(aRetval, getSdrLFSTAttribute().getGlow()); -} - rContainer.insert(rContainer.end(), aRetval.begin(), aRetval.end()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source sd/qa svx/source sw/qa
oox/source/drawingml/shape.cxx |2 +- oox/source/export/drawingml.cxx |6 -- sd/qa/unit/data/odg/glow.odg |binary sd/qa/unit/export-tests-ooxml2.cxx |8 sd/qa/unit/export-tests.cxx |4 ++-- sd/qa/unit/import-tests.cxx |8 svx/source/sdr/primitive2d/sdrdecompositiontools.cxx |2 +- svx/source/sidebar/glow/GlowPropertyPanel.cxx| 13 ++--- sw/qa/extras/ooxmlexport/ooxmlexport7.cxx| 10 +++--- 9 files changed, 25 insertions(+), 28 deletions(-) New commits: commit a640676e06bdab3471f5c9f04dd9403bc66ddc22 Author: Mike Kaganski AuthorDate: Thu May 7 15:40:57 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 23:07:45 2020 +0200 tdf#101181: store glow radius in 100ths of mm instead of EMUs ... as we do for all metric values. This fixes storing values like "190.5cm" in ODF for 15 pt (should be "0.529cm"). Change-Id: I382756af56464424dcb24ed8801d0a4203658c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93640 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 959f99ecffb4..92629b2419b5 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -1470,7 +1470,7 @@ Reference< XShape > const & Shape::createAndInsert( { uno::Reference propertySet (mxShape, uno::UNO_QUERY); propertySet->setPropertyValue("GlowEffect", makeAny(true)); -propertySet->setPropertyValue("GlowEffectRad", makeAny(static_cast(aEffectProperties.maGlow.moGlowRad.get(; +propertySet->setPropertyValue("GlowEffectRad", makeAny(convertEmuToHmm(aEffectProperties.maGlow.moGlowRad.get(; propertySet->setPropertyValue("GlowEffectColor", makeAny(aEffectProperties.maGlow.moGlowColor.getColor(rGraphicHelper))); propertySet->setPropertyValue("GlowEffectTransparency", makeAny(aEffectProperties.maGlow.moGlowColor.getTransparency())); } diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 17b56e8e4f91..aebd6901c864 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -3635,7 +3635,7 @@ void DrawingML::WriteShapeEffect( const OUString& sName, const Sequence< Propert } else if( rOuterShdwProp.Name == "rad" ) { -sal_Int32 nVal = 0; +sal_Int64 nVal = 0; rOuterShdwProp.Value >>= nVal; aOuterShdwAttrList->add( XML_rad, OString::number( nVal ).getStr() ); } @@ -3846,9 +3846,11 @@ void DrawingML::WriteGlowEffect(const Reference< XPropertySet >& rXPropSet) if(!hasGlow) return; +sal_Int32 nRad = 0; +rXPropSet->getPropertyValue("GlowEffectRad") >>= nRad; Sequence< PropertyValue > aGlowAttribs(1); aGlowAttribs[0].Name = "rad"; -aGlowAttribs[0].Value = rXPropSet->getPropertyValue("GlowEffectRad"); +aGlowAttribs[0].Value <<= oox::drawingml::convertHmmToEmu(nRad); Sequence< PropertyValue > aGlowProps(3); aGlowProps[0].Name = "Attribs"; aGlowProps[0].Value <<= aGlowAttribs; diff --git a/sd/qa/unit/data/odg/glow.odg b/sd/qa/unit/data/odg/glow.odg index 11d697c491da..9020f663b92c 100644 Binary files a/sd/qa/unit/data/odg/glow.odg and b/sd/qa/unit/data/odg/glow.odg differ diff --git a/sd/qa/unit/export-tests-ooxml2.cxx b/sd/qa/unit/export-tests-ooxml2.cxx index a530631761a4..6bb672641d56 100644 --- a/sd/qa/unit/export-tests-ooxml2.cxx +++ b/sd/qa/unit/export-tests-ooxml2.cxx @@ -2855,15 +2855,15 @@ void SdOOXMLExportTest2::testShapeGlowEffect() bool bHasGlow = false; xShape->getPropertyValue("GlowEffect") >>= bHasGlow; CPPUNIT_ASSERT(bHasGlow); -sal_Int64 nRadius = -1; +sal_Int32 nRadius = -1; xShape->getPropertyValue("GlowEffectRad") >>= nRadius; -CPPUNIT_ASSERT_EQUAL(sal_Int64(139700l), nRadius); +CPPUNIT_ASSERT_EQUAL(sal_Int32(388), nRadius); // 139700 EMU = 388.0556 mm/100 Color nColor; xShape->getPropertyValue("GlowEffectColor") >>= nColor; CPPUNIT_ASSERT_EQUAL(Color(0xFFC000), nColor); -sal_uInt16 nTransparency; +sal_Int16 nTransparency; xShape->getPropertyValue("GlowEffectTransparency") >>= nTransparency; -CPPUNIT_ASSERT_EQUAL(sal_uInt16(60), nTransparency); +CPPUNIT_ASSERT_EQUAL(sal_Int16(60), nTransparency); } void SdOOXMLExportTest2::testTdf119087() diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx index 2f8dd6056a8e..516eaf6df3c9 100644 --- a/sd/qa/unit/export-tests.cxx +++ b/sd/qa/unit/export-tests.cxx @@ -1272,7 +1272,7 @@ void SdExportTest::testGlow() CPPUNIT_ASSERT(bGlowEffect); sal_Int32 nGlowEffectRad = 0;
[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=101181 --- Comment #15 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a640676e06bdab3471f5c9f04dd9403bc66ddc22 tdf#101181: store glow radius in 100ths of mm instead of EMUs It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=101181 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=48 ||722 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48722] Add Realistic [soft-edge/fuzzy/Gaussian-blur] Shadows for Objects
https://bugs.documentfoundation.org/show_bug.cgi?id=48722 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||1181 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49247] Implement "Soft Edges" effect
https://bugs.documentfoundation.org/show_bug.cgi?id=49247 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7607 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80421] Image Transparency Should be Added to "Transparency" Tab
https://bugs.documentfoundation.org/show_bug.cgi?id=80421 --- Comment #5 from Gwenaël Q. --- Hello, Confirmed in 6.3.6.2 (x64) on windows 8.1 Please fix this adding an image transparency setting in the image properties dialog. At the very least improve UI so that things are understandable : when setting Transparency in image properties dialog, one expects that this transparency is applied to the image. If this setting is for the background then display "background transparency" and add a tooltip to guide the user to the right command ! What a loss of time for new users ! Thank you for listening -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107607] FILEOPEN: PPTX: Soft Edge Oval picture effect
https://bugs.documentfoundation.org/show_bug.cgi?id=107607 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||247 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102625] Formula editor breaks surrogate pairs
https://bugs.documentfoundation.org/show_bug.cgi?id=102625 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #6 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/93684 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101107] Editing Connectors seems to mess with LightDM - Affects all other apps on the PC
https://bugs.documentfoundation.org/show_bug.cgi?id=101107 Aaron Duerksen changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #9 from Aaron Duerksen --- It took me a while to get back to this. I hadn't used that virtual machine for years, as its purpose was done, but for some reason I kept it around. I fully updated it, and I can't reproduce the problem anymore. I also tried a new virtual machine with a fresh install of Lubuntu 16.04.3 and then 20.04, and I can't reproduce it there either. So I guess we can call it fixed by accident? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99649] [META] Improve Connector handling
https://bugs.documentfoundation.org/show_bug.cgi?id=99649 Bug 99649 depends on bug 101107, which changed state. Bug 101107 Summary: Editing Connectors seems to mess with LightDM - Affects all other apps on the PC https://bugs.documentfoundation.org/show_bug.cgi?id=101107 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/ServerURL.hpp
wsd/ServerURL.hpp |6 ++ 1 file changed, 6 insertions(+) New commits: commit 73a002c783160d613a79638ff4a2295981be0a30 Author: Michael Meeks AuthorDate: Thu May 7 20:06:01 2020 +0100 Commit: Michael Meeks CommitDate: Thu May 7 22:29:25 2020 +0200 Avoid unexpected exception in the iOS app Essentially restoring 5d0c8587 and mending 18c4301a1f Change-Id: I0219b61a20ee5b36ec32d62123e5c1d98c8e2af8 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93675 Tested-by: Jenkins CollaboraOffice Reviewed-by: Michael Meeks diff --git a/wsd/ServerURL.hpp b/wsd/ServerURL.hpp index 647ca966d..bfe9992b4 100644 --- a/wsd/ServerURL.hpp +++ b/wsd/ServerURL.hpp @@ -26,7 +26,13 @@ class ServerURL public: ServerURL(const Poco::Net::HTTPRequest ) { +#if MOBILEAPP +(void)request; +// getHost fires an exception on mobile. +init("mobile", ""); +#else init(request.getHost(), request.get("ProxyPrefix", "")); +#endif } explicit ServerURL() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 132251] Pasting Graphic Jumps To End of Document
https://bugs.documentfoundation.org/show_bug.cgi?id=132251 --- Comment #3 from Telesto --- (In reply to larrybradley from comment #1) > P.S. Same thing happens when you "Anchor as Character;" cursor jumps to end > of document. There are certainly jumping cases.. However an example document would be really helpful to address the issue... Can take a while though, before it gets fixed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132676] EDITING Writer hangs when scrolling in particular table
https://bugs.documentfoundation.org/show_bug.cgi?id=132676 Telesto changed: What|Removed |Added Keywords|regression | Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Telesto --- (In reply to Dieter from comment #3) > So it's a bug, but not a regression? So I'm not sure, if I can change status > to NEW, but I can confirm it with A hanging document seems wrong to me; NEW it is. Removing the regression part. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Bug 108226 depends on bug 132463, which changed state. Bug 132463 Summary: FILEOPEN PPTX: "blurred edge" effect not reflected https://bugs.documentfoundation.org/show_bug.cgi?id=132463 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49247] Implement "Soft Edges" effect
https://bugs.documentfoundation.org/show_bug.cgi?id=49247 Mike Kaganski changed: What|Removed |Added Summary|allow "blurred margin" |Implement "Soft Edges" |effect for pixel pictures |effect |what can be found in| |particular .pptx documents. | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132463] FILEOPEN PPTX: "blurred edge" effect not reflected
https://bugs.documentfoundation.org/show_bug.cgi?id=132463 Mike Kaganski changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 49247 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49247] Implement "Soft Edges" effect
https://bugs.documentfoundation.org/show_bug.cgi?id=49247 Mike Kaganski changed: What|Removed |Added CC||ger...@pfeifer.com --- Comment #5 from Mike Kaganski --- *** Bug 132463 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/export-tests.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dcd1795c4934e66378d4b88c914f8e9bb1678ba7 Author: Caolán McNamara AuthorDate: Thu May 7 21:16:08 2020 +0100 Commit: Caolán McNamara CommitDate: Thu May 7 22:21:44 2020 +0200 fix build Change-Id: I4dfbbffc1829ca52dadbb8f2d8e42d309fd10a25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93681 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx index de092590f2cd..2f8dd6056a8e 100644 --- a/sd/qa/unit/export-tests.cxx +++ b/sd/qa/unit/export-tests.cxx @@ -1281,7 +1281,7 @@ void SdExportTest::testGlow() CPPUNIT_ASSERT_EQUAL(sal_Int16(60), nGlowEffectTransparency); // 60% // Test ODF element -xmlDocPtr pXmlDoc = parseExport(tempFile, "content.xml"); +xmlDocUniquePtr pXmlDoc = parseExport(tempFile, "content.xml"); // check that we actually test graphic style assertXPath(pXmlDoc, "/office:document-content/office:automatic-styles/style:style[2]", ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 132505] UX: Ignore all option in spell check is an unexpected full session setting
https://bugs.documentfoundation.org/show_bug.cgi?id=132505 --- Comment #6 from Telesto --- (In reply to Heiko Tietze from comment #5) Hmm, not many objections from my side. Sounds like an improvement :-) -> changing the text language is pointless as the dialog does not offer any restart Word does this; at least in ancient version. Must be reason? Not sure what the idea is/ how it supposed to work. The LibreOffice "text language" option is indeed not really helpful. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 132505] UX: Ignore all option in spell check is an unexpected full session setting
https://bugs.documentfoundation.org/show_bug.cgi?id=132505 --- Comment #6 from Telesto --- (In reply to Heiko Tietze from comment #5) Hmm, not many objections from my side. Sounds like an improvement :-) -> changing the text language is pointless as the dialog does not offer any restart Word does this; at least in ancient version. Must be reason? Not sure what the idea is/ how it supposed to work. The LibreOffice "text language" option is indeed not really helpful. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132828] New: FILEOPEN CSV in Calc now requires mouse or 20 key presses (regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=132828 Bug ID: 132828 Summary: FILEOPEN CSV in Calc now requires mouse or 20 key presses (regression) Product: LibreOffice Version: 6.4.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zw...@zwets.com Description: One of LibreOffice Calc's strong points has always been the ease of working with CSV/TSV files. Just open the file, hit the Enter key in the "Text Import" dialog that appears, done! Since 6.4.3, this doesn't work any more. Pressing Enter in the Text Import dialog now opens a dropdown list of Character sets. The cause is that the default focus in that dialog is not the OK button, but the Character Set dropdown. For those who do/ not use a mouse now requires pressing Tab 19 times till the focus is on the OK button, followed by the Enter. Steps to Reproduce: Either 1. In Calc: press Alt+F O, pick any CSV file, hit Enter. 2. The Text Import dialog appears. Hit Enter. Or: 1. From commandline: xdg-open somefile.csv 2. The Text Import dialog appears. Hit Enter. Actual Results: A long drop down list of Character Encodings opens. Expected Results: The dialog closes, and the CSV is open in Calc. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 6.4.3.2 Build ID: 1:6.4.3-0ubuntu0.20.04.1 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132199] FILEOPEN: PPTX: Glow effect is applied to shadow when it shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=132199 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #2 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/93605 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132373] EDITING Remove Blinking character property from UI/Editor
https://bugs.documentfoundation.org/show_bug.cgi?id=132373 Cor Nouws changed: What|Removed |Added Version|7.0.0.0.alpha0+ Master |Inherited From OOo CC||c...@nouenoff.nl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ridljar/pom.libreoffice.xml
ridljar/pom.libreoffice.xml | 44 1 file changed, 44 insertions(+) New commits: commit a743df4f1e2d20e75b67c33a290aa398852026c3 Author: Rene Engelhard AuthorDate: Thu May 7 07:32:47 2020 +0200 Commit: Thorsten Behrens CommitDate: Thu May 7 22:10:48 2020 +0200 add pom for libreoffice.jar was missed in 35518c92365cc183ba6cce2a4d284a130c0ca13f Change-Id: I574707f6a891109ff1a7db3c915dd652fa644972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93606 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens diff --git a/ridljar/pom.libreoffice.xml b/ridljar/pom.libreoffice.xml new file mode 100644 index ..ca6438ebe3b0 --- /dev/null +++ b/ridljar/pom.libreoffice.xml @@ -0,0 +1,44 @@ + + 4.0.0 + org.libreoffice + libreoffice + @version@ + jar + LibreOffice - Public UNO Java Classes + Public UNO Java Classes (formerly jurt,juh,ridl,unoil) + https://www.libreoffice.org + + + + Mozilla Public License, Version 2.0 + https://www.mozilla.org/en-US/MPL/2.0 + repo + + + + +https://cgit.freedesktop.org/libreoffice/core + https://gerrit.libreoffice.org/#/admin/projects/core + + + + + The Document Foundation + + + + + + LibreOffice Development Mailing List + libreoffice@lists.freedesktop.org + http://lists.freedesktop.org/mailman/listinfo/libreoffice + http://lists.freedesktop.org/mailman/listinfo/libreoffice + http://lists.freedesktop.org/archives/libreoffice + + + + +https://bugs.documentfoundation.org +LibreOffice Issue Tracker + + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - include/vcl vcl/CppunitTest_vcl_graphic_test.mk vcl/Library_vcl.mk vcl/qa vcl/source
include/vcl/VectorGraphicSearch.hxx| 39 ++ vcl/CppunitTest_vcl_graphic_test.mk|7 - vcl/Library_vcl.mk |1 vcl/qa/cppunit/VectorGraphicSearchTest.cxx | 50 vcl/qa/cppunit/data/Pangram.pdf|binary vcl/source/graphic/VectorGraphicSearch.cxx | 168 + 6 files changed, 262 insertions(+), 3 deletions(-) New commits: commit 09e15db17c05a4631ee876964a31d903cf07904f Author: Tomaž Vajngerl AuthorDate: Thu May 7 22:01:22 2020 +0200 Commit: Tomaž Vajngerl CommitDate: Thu May 7 22:01:22 2020 +0200 vcl: VectorGraphicSearch - for searching text inside PDF Change-Id: Iee940a3927330c8739774ff3c1af15998f89193b diff --git a/include/vcl/VectorGraphicSearch.hxx b/include/vcl/VectorGraphicSearch.hxx new file mode 100644 index ..3411d0a931e6 --- /dev/null +++ b/include/vcl/VectorGraphicSearch.hxx @@ -0,0 +1,39 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#pragma once + +#include +#include +#include + +#include + +#include + +class SearchContext; + +class VCL_DLLPUBLIC VectorGraphicSearch final +{ +private: +Graphic maGraphic; +FPDF_DOCUMENT mpPdfDocument; +std::unique_ptr mpSearchContext; +bool searchPDF(std::shared_ptr const& rData, OUString const& rSearchString); + +public: +VectorGraphicSearch(Graphic const& rGraphic); +~VectorGraphicSearch(); +bool search(OUString const& rSearchString); +bool next(); +int index(); +}; + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/CppunitTest_vcl_graphic_test.mk b/vcl/CppunitTest_vcl_graphic_test.mk index 7b042f84d7da..ea49eacdb781 100644 --- a/vcl/CppunitTest_vcl_graphic_test.mk +++ b/vcl/CppunitTest_vcl_graphic_test.mk @@ -14,11 +14,12 @@ $(eval $(call gb_CppunitTest_add_exception_objects,vcl_graphic_test, \ vcl/qa/cppunit/GraphicDescriptorTest \ vcl/qa/cppunit/GraphicFormatDetectorTest \ vcl/qa/cppunit/GraphicNativeMetadataTest \ +vcl/qa/cppunit/VectorGraphicSearchTest \ )) -$(eval $(call gb_CppunitTest_use_externals,vcl_graphic_test,\ - boost_headers \ - glm_headers \ +$(eval $(call gb_CppunitTest_use_externals,vcl_graphic_test, \ +boost_headers \ +$(if $(filter PDFIUM,$(BUILD_TYPE)),pdfium) \ )) $(eval $(call gb_CppunitTest_set_include,vcl_graphic_test,\ diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 3a56406b9adf..12cb40226c82 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -329,6 +329,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/graphic/UnoGraphicObject \ vcl/source/graphic/UnoGraphicProvider \ vcl/source/graphic/UnoGraphicTransformer \ +vcl/source/graphic/VectorGraphicSearch \ vcl/source/bitmap/bitmap \ vcl/source/bitmap/bitmapfilter \ vcl/source/bitmap/BitmapAlphaClampFilter \ diff --git a/vcl/qa/cppunit/VectorGraphicSearchTest.cxx b/vcl/qa/cppunit/VectorGraphicSearchTest.cxx new file mode 100644 index ..0ed21ccf9e26 --- /dev/null +++ b/vcl/qa/cppunit/VectorGraphicSearchTest.cxx @@ -0,0 +1,50 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include +#include +#include + +#include +#include +#include +#include + +class VectorGraphicSearchTest : public test::BootstrapFixtureBase +{ +OUString getFullUrl(const OUString& sFileName) +{ +return m_directories.getURLFromSrc("/vcl/qa/cppunit/data/") + sFileName; +} + +void test(); + +CPPUNIT_TEST_SUITE(VectorGraphicSearchTest); +CPPUNIT_TEST(test); +CPPUNIT_TEST_SUITE_END(); +}; + +void VectorGraphicSearchTest::test() +{ +OUString aURL = getFullUrl("Pangram.pdf"); +SvFileStream aStream(aURL, StreamMode::READ); +GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter(); +Graphic aGraphic = rGraphicFilter.ImportUnloadedGraphic(aStream); +aGraphic.makeAvailable(); + +VectorGraphicSearch aSearch(aGraphic); +CPPUNIT_ASSERT_EQUAL(true, aSearch.search("lazy")); +CPPUNIT_ASSERT_EQUAL(true, aSearch.next()); +CPPUNIT_ASSERT_EQUAL(34, aSearch.index()); +} + +CPPUNIT_TEST_SUITE_REGISTRATION(VectorGraphicSearchTest); + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/qa/cppunit/data/Pangram.pdf b/vcl/qa/cppunit/data/Pangram.pdf new file mode 100644 index
[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=101181 --- Comment #14 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/08ebcff89f56bec3b0f9b346504748e4eb1687af tdf#101181: improve glow effect It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer include/vcl svx/source vcl/qa vcl/source
drawinglayer/source/attribute/sdrglowattribute.cxx | 27 - drawinglayer/source/primitive2d/glowprimitive2d.cxx | 24 ++-- drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 80 +++- include/drawinglayer/attribute/sdrglowattribute.hxx | 15 +-- include/drawinglayer/primitive2d/glowprimitive2d.hxx| 16 +-- include/vcl/BitmapFilterStackBlur.hxx |3 svx/source/sdr/primitive2d/sdrattributecreator.cxx |7 + svx/source/sdr/primitive2d/sdrdecompositiontools.cxx|5 - vcl/qa/cppunit/BitmapFilterTest.cxx |6 - vcl/source/bitmap/BitmapFilterStackBlur.cxx | 46 - 10 files changed, 94 insertions(+), 135 deletions(-) New commits: commit 08ebcff89f56bec3b0f9b346504748e4eb1687af Author: Mike Kaganski AuthorDate: Fri May 1 01:05:24 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 21:57:37 2020 +0200 tdf#101181: improve glow effect The shadow of objects must not be scaled: this displaces any internal areas that need blur, e.g. holes. Instead, it needs to dilate the shadow using kernel with radius equal to blur radius: this allows the borders of dilated objects to be in the middle of the blur area. The following blur makes those new margin points to have 50% intensity, and full glow intensity at the point of old object margins. This also removed artifacts when moving objects with glow effect caused by mismatch between scaling and D2D range calculation. The D2D range therefore is not calculated by scaling, but using grow. Blur filter's "extend bitmap by blur radius" option got obsoleted and removed. There's no need to blur the glow color (24-bit RGB). Instead, glow bitmap must be filled by glow color, and have an alpha mask that is blurred accordingly. This makes the glow properly transparent, and also reduces the blur complexity which now only needs to process 8 bits of alpha channel. The object shadow is created using basegfx::BColorModifier_replace inserted into the 2d decomposition of the effect, as before. To make sure that any non-fully-transparent pixel will become black pixel in the shadow, black color is used, and the result is further processed in VclPixelProcessor2D::processGlowPrimitive2D with monochrome filter using threshold 255. Glow transparency attribute is taken into account: the initial value at the margins of the objects. Color replacement filter is used to replace the object shadow with the attribute value before blur pass. Correct blur radius is used, calculated from glow effect radius, instead of hardcoded value of 5 pixels. This makes the glow to fade gradually along the full width of the effect, instead of only fading in narrow outer border previously. Since blur filter is only implemented for radius up to 254 pixels, and since downsampling the shadow before blur increases performance without noticeable quality loss, the image is downsampled before filtering. It should be noted that the glow effect is almost identical to soft shadow effect, likely with the only difference of using dilation in the former, but not in the latter. The code might be reused later to implement soft shadow as well. Change-Id: I728c532f9df7ccf85f353c23c6c7d8352d7b2086 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93235 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl Reviewed-by: Mike Kaganski diff --git a/drawinglayer/source/attribute/sdrglowattribute.cxx b/drawinglayer/source/attribute/sdrglowattribute.cxx index 4295aef23ae3..90367ff67ea0 100644 --- a/drawinglayer/source/attribute/sdrglowattribute.cxx +++ b/drawinglayer/source/attribute/sdrglowattribute.cxx @@ -21,7 +21,7 @@ namespace drawinglayer { namespace attribute { -SdrGlowAttribute::SdrGlowAttribute(sal_Int32 nRadius, const basegfx::BColor& rColor) +SdrGlowAttribute::SdrGlowAttribute(sal_Int32 nRadius, const Color& rColor) : m_nRadius(nRadius) , m_color(rColor) { @@ -44,31 +44,6 @@ bool SdrGlowAttribute::operator==(const SdrGlowAttribute& rCandidate) const return m_nRadius == rCandidate.m_nRadius && m_color == rCandidate.m_color; } -const basegfx::B2DHomMatrix& SdrGlowAttribute::GetTransfMatrix(basegfx::B2DRange nRange) const -{ -if (!m_oTransfCache) -{ -double dRadius100mm = static_cast(m_nRadius) / 360.0; -// Apply a scaling with the center point of the shape as origin. -// 1) translate shape to the origin -basegfx::B2DHomMatrix matrix = basegfx::utils::createCoordinateSystemTransform( -nRange.getCenter(), basegfx::B2DVector(-1, 0), basegfx::B2DVector(0, -1)); - -basegfx::B2DHomMatrix inverse(matrix); -inverse.invert(); - -// 2) Scale up -double scale_x = (nRange.getWidth() +
[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source
include/vcl/BitmapColorReplaceFilter.hxx | 44 vcl/Library_vcl.mk |1 vcl/source/bitmap/BitmapColorReplaceFilter.cxx | 45 + 3 files changed, 90 insertions(+) New commits: commit a98bdbae459ad7341bf7f484c402e77e4062cd16 Author: Mike Kaganski AuthorDate: Wed May 6 11:23:26 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 21:57:18 2020 +0200 Add color replacement bitmap filter It replaces colors in bitmap by modifying pixels, without shortcuts like replacing entries in bitmap palette. Needed for glow effect (tdf#101181) Change-Id: I9af734ce8ebbc57f723ab75c5b8406eb6fd6e31b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93553 Tested-by: Jenkins Tested-by: Mike Kaganski Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/BitmapColorReplaceFilter.hxx b/include/vcl/BitmapColorReplaceFilter.hxx new file mode 100644 index ..caeac83d0fda --- /dev/null +++ b/include/vcl/BitmapColorReplaceFilter.hxx @@ -0,0 +1,44 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#ifndef INCLUDED_INCLUDE_VCL_BITMAPCOLORREPLACEFILTER_HXX +#define INCLUDED_INCLUDE_VCL_BITMAPCOLORREPLACEFILTER_HXX + +#include + +class VCL_DLLPUBLIC BitmapColorReplaceFilter final : public BitmapFilter +{ +public: +/** Replaces a color with another by changing pixels, without shortcuts like modifying palette +(that is how it's different from using Bitmap::Replace). + +@param cReplaceWhat +Color that will be replaced. + +@param cReplaceTo +New color that will replace cReplaceWhat. + + */ +BitmapColorReplaceFilter(const Color& cReplaceWhat, const Color& cReplaceTo) +: m_aReplaceWhat(cReplaceWhat) +, m_aReplaceTo(cReplaceTo) +{ +} + +virtual BitmapEx execute(BitmapEx const& rBitmapEx) const override; + +private: +Color m_aReplaceWhat; +Color m_aReplaceTo; +}; + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index ffe065b24fff..def727918433 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -332,6 +332,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/bitmap/bitmapfilter \ vcl/source/bitmap/BitmapAlphaClampFilter \ vcl/source/bitmap/BitmapBasicMorphologyFilter \ +vcl/source/bitmap/BitmapColorReplaceFilter \ vcl/source/bitmap/BitmapMonochromeFilter \ vcl/source/bitmap/BitmapSmoothenFilter \ vcl/source/bitmap/BitmapLightenFilter \ diff --git a/vcl/source/bitmap/BitmapColorReplaceFilter.cxx b/vcl/source/bitmap/BitmapColorReplaceFilter.cxx new file mode 100644 index ..151cfbfbb48b --- /dev/null +++ b/vcl/source/bitmap/BitmapColorReplaceFilter.cxx @@ -0,0 +1,45 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#include +#include +#include +#include + +#include + +BitmapEx BitmapColorReplaceFilter::execute(BitmapEx const& aBitmapEx) const +{ +Bitmap aBitmap = aBitmapEx.GetBitmap(); + +if (BitmapScopedWriteAccess pWriteAcc{ aBitmap }) +{ +const BitmapColor aReplaceWhat(pWriteAcc->GetBestMatchingColor(m_aReplaceWhat)); +const BitmapColor aReplaceTo(pWriteAcc->GetBestMatchingColor(m_aReplaceTo)); +const long nWidth = pWriteAcc->Width(); +const long nHeight = pWriteAcc->Height(); + +for (long nY = 0; nY < nHeight; nY++) +{ +Scanline pScanline = pWriteAcc->GetScanline(nY); +for (long nX = 0; nX < nWidth; nX++) +{ +if (pWriteAcc->GetPixelFromData(pScanline, nX) == aReplaceWhat) +{ +pWriteAcc->SetPixelOnData(pScanline, nX, aReplaceTo); +} +} +} +} + +return BitmapEx(aBitmap); +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/qa vcl/source
include/vcl/BitmapBasicMorphologyFilter.hxx| 60 ++ vcl/Library_vcl.mk |1 vcl/qa/cppunit/BitmapFilterTest.cxx| 78 ++ vcl/qa/cppunit/data/testBasicMorphology.png|binary vcl/qa/cppunit/data/testBasicMorphologyDilated1.png|binary vcl/qa/cppunit/data/testBasicMorphologyDilated1Eroded1.png |binary vcl/qa/cppunit/data/testBasicMorphologyDilated2.png|binary vcl/qa/cppunit/data/testBasicMorphologyDilated2Eroded1.png |binary vcl/source/bitmap/BitmapBasicMorphologyFilter.cxx | 358 + 9 files changed, 486 insertions(+), 11 deletions(-) New commits: commit 84808eed2405ed6ee586e87bb664a816f7b91b70 Author: Mike Kaganski AuthorDate: Wed May 6 11:08:22 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 21:56:23 2020 +0200 Add basic morphology (erode/dilate) bitmap filter Needed for glow effect (tdf#101181) Change-Id: Id41daa1dc17e3749a30ce75fa3127878b9e0cfd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93552 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/BitmapBasicMorphologyFilter.hxx b/include/vcl/BitmapBasicMorphologyFilter.hxx new file mode 100644 index ..ade82adaa957 --- /dev/null +++ b/include/vcl/BitmapBasicMorphologyFilter.hxx @@ -0,0 +1,60 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#ifndef INCLUDED_VCL_BITMAPBASICMORPHOLOGYFILTER_HXX +#define INCLUDED_VCL_BITMAPBASICMORPHOLOGYFILTER_HXX + +#include +#include +#include + +enum class BasicMorphologyOp +{ +erode, +dilate +}; + +/* Black is foreground, white is background */ +class VCL_DLLPUBLIC BitmapBasicMorphologyFilter : public BitmapFilter +{ +public: +BitmapBasicMorphologyFilter(BasicMorphologyOp op, sal_Int32 nRadius); +virtual ~BitmapBasicMorphologyFilter(); + +virtual BitmapEx execute(BitmapEx const& rBitmap) const override; + +private: +Bitmap filter(Bitmap const& rBitmap) const; + +BasicMorphologyOp m_eOp; +sal_Int32 m_nRadius; +}; + +class BitmapErodeFilter : public BitmapBasicMorphologyFilter +{ +public: +BitmapErodeFilter(sal_Int32 nRadius) +: BitmapBasicMorphologyFilter(BasicMorphologyOp::erode, nRadius) +{ +} +}; + +class BitmapDilateFilter : public BitmapBasicMorphologyFilter +{ +public: +BitmapDilateFilter(sal_Int32 nRadius) +: BitmapBasicMorphologyFilter(BasicMorphologyOp::dilate, nRadius) +{ +} +}; + +#endif // INCLUDED_VCL_BITMAPBASICMORPHOLOGYFILTER_HXX + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 9780ca3575a1..ffe065b24fff 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -331,6 +331,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/source/bitmap/bitmap \ vcl/source/bitmap/bitmapfilter \ vcl/source/bitmap/BitmapAlphaClampFilter \ +vcl/source/bitmap/BitmapBasicMorphologyFilter \ vcl/source/bitmap/BitmapMonochromeFilter \ vcl/source/bitmap/BitmapSmoothenFilter \ vcl/source/bitmap/BitmapLightenFilter \ diff --git a/vcl/qa/cppunit/BitmapFilterTest.cxx b/vcl/qa/cppunit/BitmapFilterTest.cxx index a28057a4bf57..fec21fa118f0 100644 --- a/vcl/qa/cppunit/BitmapFilterTest.cxx +++ b/vcl/qa/cppunit/BitmapFilterTest.cxx @@ -7,10 +7,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include -#include -#include -#include +#include #include #include @@ -19,6 +16,7 @@ #include #include +#include #include #include @@ -29,15 +27,48 @@ namespace constexpr bool constWriteResultBitmap(false); constexpr bool constEnablePerformanceTest(false); -class BitmapFilterTest : public CppUnit::TestFixture +class BitmapFilterTest : public test::BootstrapFixture { +public: +BitmapFilterTest() +: test::BootstrapFixture(true, false) +{ +} + void testBlurCorrectness(); +void testBasicMorphology(); void testPerformance(); CPPUNIT_TEST_SUITE(BitmapFilterTest); CPPUNIT_TEST(testBlurCorrectness); +CPPUNIT_TEST(testBasicMorphology); CPPUNIT_TEST(testPerformance); CPPUNIT_TEST_SUITE_END(); + +private: +OUString getFullUrl(const OUString& sFileName) +{ +return m_directories.getURLFromSrc("vcl/qa/cppunit/data/") + sFileName; +} + +BitmapEx loadBitmap(const OUString& sFileName) +{ +Graphic aGraphic; +const OUString aURL(getFullUrl(sFileName)); +SvFileStream aFileStream(aURL, StreamMode::READ); +GraphicFilter& rFilter = GraphicFilter::GetGraphicFilter(); +ErrCode
[Libreoffice-bugs] [Bug 132251] Pasting Graphic Jumps To End of Document
https://bugs.documentfoundation.org/show_bug.cgi?id=132251 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #2 from Dieter --- I can't confirm with Version: 7.0.0.0.alpha0+ (x64)Build ID: 8c8b3a4f83f67882b284ddc3b3fe10d3fe6dedf4CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI-Language: en-GBCalc: CL If I paste an image from another document, the imae is marked and no cursor is visible. You mention mltiple pasting of images (graphics) from one document to another. How are you able to do this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118738] [META] WriterMultiListener instead of SwDepend in SwContentNode regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=118738 --- Comment #3 from Telesto --- The meta bug can be closed, I think... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/ServerURL.hpp
wsd/ServerURL.hpp | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) New commits: commit 526dd304b7625087d54a75df034058c493321999 Author: Michael Meeks AuthorDate: Thu May 7 17:30:04 2020 +0100 Commit: Michael Meeks CommitDate: Thu May 7 21:00:04 2020 +0200 Proxy: getSubURLForEndpoint - don't return wss:// URLs in error. Separate _ssl and _websocket state and construct the URLs from them. Change-Id: Ida4eee868c7815eb68e3029682d603d13d193153 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93669 Tested-by: Jenkins CollaboraOffice Reviewed-by: Michael Meeks diff --git a/wsd/ServerURL.hpp b/wsd/ServerURL.hpp index 3e96fff98..647ca966d 100644 --- a/wsd/ServerURL.hpp +++ b/wsd/ServerURL.hpp @@ -19,7 +19,8 @@ */ class ServerURL { -std::string _schemeProtocol; +bool_ssl; +bool_websocket; std::string _schemeAuthority; std::string _pathPlus; public: @@ -38,9 +39,9 @@ public: // The user can override the ServerRoot with a new prefix. _pathPlus = LOOLWSD::ServiceRoot; -bool ssl = (LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination()); +_ssl = (LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination()); +_websocket = true; std::string serverName = LOOLWSD::ServerName.empty() ? host : LOOLWSD::ServerName; -_schemeProtocol = (ssl ? "wss://" : "ws://"); _schemeAuthority = serverName; // A well formed ProxyPrefix will override it. @@ -54,7 +55,9 @@ public: auto hostEndPos = url.find("/", pos); if (hostEndPos != std::string::npos) { -_schemeProtocol = url.substr(0, pos); +_websocket = false; +std::string schemeProtocol = url.substr(0, pos); +_ssl = (schemeProtocol != "http://;); _schemeAuthority = url.substr(pos, hostEndPos - pos); _pathPlus = url.substr(hostEndPos); return; @@ -72,12 +75,15 @@ public: std::string getWebSocketUrl() const { -return _schemeProtocol + _schemeAuthority; +std::string schemeProtocol = (_websocket ? "ws" : "http"); +if (_ssl) +schemeProtocol += "s"; +return schemeProtocol + "://" + _schemeAuthority; } std::string getSubURLForEndpoint(const std::string ) const { -return _schemeProtocol + _schemeAuthority + _pathPlus + path; +return std::string("http") + (_ssl ? "s" : "") + "://" + _schemeAuthority + _pathPlus + path; } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 132676] EDITING Writer hangs when scrolling in particular table
https://bugs.documentfoundation.org/show_bug.cgi?id=132676 Dieter changed: What|Removed |Added Blocks|103100 |10, 108075 CC||dgp-m...@gmx.de --- Comment #3 from Dieter --- (In reply to Miklos Vajna from comment #2) > In practice this never worked, though. It "worked" when it had side effects > like bug 105330, which is the reason the above commit went back to the > original state. So it's a bug, but not a regression? So I'm not sure, if I can change status to NEW, but I can confirm it with Version: 7.0.0.0.alpha0+ (x64)Build ID: 8c8b3a4f83f67882b284ddc3b3fe10d3fe6dedf4CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI-Language: en-GBCalc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs https://bugs.documentfoundation.org/show_bug.cgi?id=10 [Bug 10] [META] DOCX (OOXML) table-related issues https://bugs.documentfoundation.org/show_bug.cgi?id=108075 [Bug 108075] [META] Scrolling and Page up/down issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108075 Dieter changed: What|Removed |Added Depends on||132676 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132676 [Bug 132676] EDITING Writer hangs when scrolling in particular table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Dieter changed: What|Removed |Added Depends on|132676 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132676 [Bug 132676] EDITING Writer hangs when scrolling in particular table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Dieter changed: What|Removed |Added Depends on||132676 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=132676 [Bug 132676] EDITING Writer hangs when scrolling in particular table -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132827] New: Form-control: Setting Font Color to Automatic switches back to Black in Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=132827 Bug ID: 132827 Summary: Form-control: Setting Font Color to Automatic switches back to Black in Dialog Product: LibreOffice Version: 6.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Open a Writer document Add a form control, for example a Text Box. Go to Control-Properties > General > Font and press the button with the thre points. Set Font Effects > Font color to "Automatic". It will show "Automatic" in case of Black. Press "OK". The dialog has closed. Reopen the dialog and have a look. There is standing "Black" instead of "Automatic". Note: "Automatic" is set. You could test it in formatted fields with the format-cod example of the help and some data in a database. If such a field is created with the wizard there is standing also "Black" for the color - and the Format of the formatted field wouldn't be changed. Pressing "Automatic" one time in the control will solve the problem, but inside the control is almost shown "Black". Tested all with OpenSUSE 15.1 64bit rpm Linux and LO 6.4.3.2. It's the same behavior with all older LO-versions here. "Automatic" will never been shown when opening the dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/opencl/formulagroupcl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 547b2891d9fe97dee9df14106e91dc4df659d4d5 Author: Noel Grandin AuthorDate: Thu May 7 15:00:00 2020 +0200 Commit: Noel Grandin CommitDate: Thu May 7 20:43:07 2020 +0200 fix use after std::move regression from commit 5efd34eabcbd374f0f06cac12b7b25f955db7965 loplugin:makeshared in sc Change-Id: I1ec603f6ea01aca86cb478f2bf3a6d5d37f235af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93639 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx index d8e5ded30a7b..f505e23c97d5 100644 --- a/sc/source/core/opencl/formulagroupcl.cxx +++ b/sc/source/core/opencl/formulagroupcl.cxx @@ -2704,7 +2704,7 @@ static std::shared_ptr VectorRefFactory( const ScCalcConf DynamicKernelSoPArguments::DynamicKernelSoPArguments(const ScCalcConfig& config, const std::string& s, const FormulaTreeNodeRef& ft, std::shared_ptr pCodeGen, int nResultSize ) : -DynamicKernelArgument(config, s, ft), mpCodeGen(std::move(pCodeGen)), mpClmem2(nullptr) +DynamicKernelArgument(config, s, ft), mpCodeGen(pCodeGen), mpClmem2(nullptr) { size_t nChildren = ft->Children.size(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104442 Bug 104442 depends on bug 132346, which changed state. Bug 132346 Summary: FILEOPEN DOCX Line end type “arrow” imported incorrectly https://bugs.documentfoundation.org/show_bug.cgi?id=132346 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132346] FILEOPEN DOCX Line end type “arrow” imported incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=132346 NISZ LibreOffice Team changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||barakso.att...@gmail.com, ||szabolcs...@gmail.com --- Comment #5 from NISZ LibreOffice Team --- It seems this was fixed in master. With reverse bibisect, this was the fix: Bibisected using bibisect-win64-6.5 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=68531e459e7a922319e6bfe8b7a5282ba0320182 author: Szabolcs committer: László Németh summary: tdf#123346 DOCX VML shape export: fix arrow marker *** This bug has been marked as a duplicate of bug 123346 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport10.cxx | 89 + 1 file changed, 89 insertions(+) New commits: commit e89e66a4d7c0f26222cd12ebe23b4061784a813e Author: Xisco Fauli AuthorDate: Thu May 7 15:45:35 2020 +0200 Commit: Xisco Faulí CommitDate: Thu May 7 20:21:38 2020 +0200 CppUnittest: ooxmlexport10: Assert pages where possible Change-Id: I40cc389edf9d072f643c724bdb2c70c48edced63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93645 Tested-by: Jenkins Reviewed-by: Xisco Faulí diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx index 4ba57fabc25f..dbd1ef17f3b3 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx @@ -102,6 +102,7 @@ protected: DECLARE_OOXMLEXPORT_TEST(testSmartart, "smartart.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); uno::Reference xDrawPageSupplier(mxComponent, uno::UNO_QUERY); uno::Reference xDraws = xDrawPageSupplier->getDrawPage(); CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xDraws->getCount()); // One groupshape in the doc @@ -126,6 +127,7 @@ DECLARE_OOXMLEXPORT_TEST(testSmartart, "smartart.docx") DECLARE_OOXMLEXPORT_TEST(testFdo69548, "fdo69548.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); if (!mbExported) return; @@ -135,6 +137,7 @@ DECLARE_OOXMLEXPORT_TEST(testFdo69548, "fdo69548.docx") DECLARE_OOXMLEXPORT_TEST(testWpsOnly, "wps-only.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); // Document has wp:anchor, not wp:inline, so handle it accordingly. uno::Reference xShape = getShape(1); text::TextContentAnchorType eValue = getProperty(xShape, "AnchorType"); @@ -158,6 +161,7 @@ DECLARE_OOXMLEXPORT_TEST(testWpsOnly, "wps-only.docx") DECLARE_OOXMLEXPORT_TEST(testWpgOnly, "wpg-only.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); uno::Reference xShape = getShape(1); // Check position, it was nearly 0. This is a shape, so use getPosition(), not a property. CPPUNIT_ASSERT_EQUAL(oox::drawingml::convertEmuToHmm(548005), xShape->getPosition().X); @@ -165,6 +169,7 @@ DECLARE_OOXMLEXPORT_TEST(testWpgOnly, "wpg-only.docx") DECLARE_OOXMLEXPORT_TEST(testWpgNested, "wpg-nested.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); uno::Reference xGroup(getShape(1), uno::UNO_QUERY); uno::Reference xShapeDescriptor(xGroup->getByIndex(0), uno::UNO_QUERY); // This was a com.sun.star.drawing.CustomShape, due to lack of handling of groupshapes inside groupshapes. @@ -187,6 +192,7 @@ DECLARE_OOXMLEXPORT_TEST(testWpgNested, "wpg-nested.docx") DECLARE_OOXMLEXPORT_TEST(textboxWpgOnly, "textbox-wpg-only.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); uno::Reference xShape = getShape(1); // The relativeFrom attribute was ignored for groupshapes, i.e. these were text::RelOrientation::FRAME. CPPUNIT_ASSERT_EQUAL(text::RelOrientation::PAGE_FRAME, getProperty(xShape, "HoriOrientRelation")); @@ -206,6 +212,7 @@ DECLARE_OOXMLEXPORT_TEST(textboxWpgOnly, "textbox-wpg-only.docx") DECLARE_OOXMLEXPORT_TEST(testTdf120412_400PercentSubscript, "tdf120412_400PercentSubscript.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); uno::Reference xPara = getParagraph(1); // The word "Base" should not be subscripted. CPPUNIT_ASSERT_DOUBLES_EQUAL( 0.f, getProperty(getRun(xPara, 1, "Base"), "CharEscapement"), 0); @@ -215,6 +222,7 @@ DECLARE_OOXMLEXPORT_TEST(testTdf120412_400PercentSubscript, "tdf120412_400Percen DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFontEsc, "test_tdf120412.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); xmlDocUniquePtr pXmlDoc =parseExport("word/document.xml"); // don't lose the run with superscript formatting assertXPath(pXmlDoc, "/w:document/w:body/w:p/w:r", 2); @@ -226,6 +234,7 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testFontEsc, "test_tdf120412.docx") DECLARE_OOXMLEXPORT_TEST(testMceWpg, "mce-wpg.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); // Make sure that we read the primary branch, if wpg is requested as a feature. uno::Reference xGroup(getShape(1), uno::UNO_QUERY); uno::Reference xText = uno::Reference(xGroup->getByIndex(0), uno::UNO_QUERY_THROW)->getText(); @@ -235,6 +244,7 @@ DECLARE_OOXMLEXPORT_TEST(testMceWpg, "mce-wpg.docx") DECLARE_OOXMLEXPORT_TEST(testMceNested, "mce-nested.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); // Vertical position of the shape was incorrect due to incorrect nested mce handling. uno::Reference xShape(getShape(1), uno::UNO_QUERY); // positionV's posOffset from the bugdoc, was 0. @@ -258,6 +268,7 @@ DECLARE_OOXMLEXPORT_TEST(testMceNested, "mce-nested.docx") DECLARE_OOXMLEXPORT_TEST(testMissingPath, "missing-path.docx") { +CPPUNIT_ASSERT_EQUAL(1, getPages()); comphelper::SequenceAsHashMap aCustomShapeGeometry(getProperty(getShape(1), "CustomShapeGeometry"));
[Libreoffice-bugs] [Bug 131654] Provide a live preview of changes when creating or editing a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=131654 --- Comment #6 from Jean-François Fortin Tam --- Created attachment 160510 --> https://bugs.documentfoundation.org/attachment.cgi?id=160510=edit Mockup #2 In case this helps, a rough mockup of the potential general arrangement for the scenario mentioned at the end of my comment #5. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 131654] Provide a live preview of changes when creating or editing a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=131654 --- Comment #6 from Jean-François Fortin Tam --- Created attachment 160510 --> https://bugs.documentfoundation.org/attachment.cgi?id=160510=edit Mockup #2 In case this helps, a rough mockup of the potential general arrangement for the scenario mentioned at the end of my comment #5. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 131654] Provide a live preview of changes when creating or editing a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=131654 --- Comment #5 from Jean-François Fortin Tam --- Just a thought: if I recall correctly, Excel does the live previewing directly on the canvas (essentially WYSIWYG) instead of in the properties dialog. Have you considered this avenue? Probably more complex to implement though. Your mockup is a step in the right direction with the fact that the "Available Fields" portion is on the left instead of the right, I already like that change; maybe then it's a matter of styling + headers to make it more evident, with a vertical separator (or sidebar styling, somehow) between that area and the rest? As for the notion of "targets" and add/remove arrow buttons, this could be complex and a bit cluttered from a UI interaction perspective. Wouldn't it be simpler and cleaner to have the drag-and-drop nature of the dialog be made more evident than the current implementation, for example having the "Drag the Items into the Desired position" label be repositioned at the top, left-aligned, with clearer wording ("Drag items from the available fields into the desired column, row or data fields")? Or perhaps that label could be put right underneath the "Available Fields:" header, but then this wouldn't reflect the fact that you can drag from any area to any other area. The alternative — if you prefer to save space, eliminate the "Available Fields is not visually distinct enough from other field areas" problem, and not strictly depend on drag-and-drop — is to use inline toolbars and GtkPopover widgets (and the equivalent on other platforms). For instance, under each of Column, Row and Data field listview widgets, you could have a small toolbar (with the "inline-toolbar" styling class) containing these standard inline buttons: +, -, top, up, down, bottom ...and clicking the + would open a GtkPopover containing the list of "Available Fields" to add into the current field area. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131654] Provide a live preview of changes when creating or editing a pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=131654 --- Comment #5 from Jean-François Fortin Tam --- Just a thought: if I recall correctly, Excel does the live previewing directly on the canvas (essentially WYSIWYG) instead of in the properties dialog. Have you considered this avenue? Probably more complex to implement though. Your mockup is a step in the right direction with the fact that the "Available Fields" portion is on the left instead of the right, I already like that change; maybe then it's a matter of styling + headers to make it more evident, with a vertical separator (or sidebar styling, somehow) between that area and the rest? As for the notion of "targets" and add/remove arrow buttons, this could be complex and a bit cluttered from a UI interaction perspective. Wouldn't it be simpler and cleaner to have the drag-and-drop nature of the dialog be made more evident than the current implementation, for example having the "Drag the Items into the Desired position" label be repositioned at the top, left-aligned, with clearer wording ("Drag items from the available fields into the desired column, row or data fields")? Or perhaps that label could be put right underneath the "Available Fields:" header, but then this wouldn't reflect the fact that you can drag from any area to any other area. The alternative — if you prefer to save space, eliminate the "Available Fields is not visually distinct enough from other field areas" problem, and not strictly depend on drag-and-drop — is to use inline toolbars and GtkPopover widgets (and the equivalent on other platforms). For instance, under each of Column, Row and Data field listview widgets, you could have a small toolbar (with the "inline-toolbar" styling class) containing these standard inline buttons: +, -, top, up, down, bottom ...and clicking the + would open a GtkPopover containing the list of "Available Fields" to add into the current field area. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132826] New: Writer - Create PDF - save file - wrong focus - on OpenSuse Linux Writer 6.4.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=132826 Bug ID: 132826 Summary: Writer - Create PDF - save file - wrong focus - on OpenSuse Linux Writer 6.4.2.2 Product: LibreOffice Version: 6.4.4.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: afe...@sze.hu Description: Writer 6.4.2.2 Linux: openSuse 15.2 beta x64 Create pdf button: the focus on the directory name, not on the file name, therfore saving changing the directory name, but same filename. Steps to Reproduce: 1.Create pdf button: Export directly as PDF Actual Results: Opens Export window Focus on Directory name Expected Results: 2.The focus on the directory name, not on the file name, therfore saving changing the directory name, but same filename. Reproducible: Always User Profile Reset: No Additional Info: x -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67443] Unable to download help file
https://bugs.documentfoundation.org/show_bug.cgi?id=67443 Mike Kaganski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Mike Kaganski --- This is bug tracker, where software problems - bugs - are tracked. If you need help, you are welcome to ask your usage questions at https://ask.libreoffice.org, or at IRC channel #libreoffice, or on mailing list (all these are mentioned at [1]). See also FAQ [2]. Please do not reopen this bug, which is not something that can be changed in the code. Thank you. [1] https://www.libreoffice.org/get-help/feedback/ [2] https://wiki.documentfoundation.org/Faq/General/Offline_Help_pack_must_match_UI_language -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132552] layout changed after reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=132552 --- Comment #25 from Timur --- No, because you reported pages issue first and that's WFM. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: embeddedobj/source
embeddedobj/source/commonembedding/embedobj.cxx |6 ++-- embeddedobj/source/commonembedding/miscobj.cxx | 31 embeddedobj/source/inc/commonembobj.hxx |3 +- 3 files changed, 11 insertions(+), 29 deletions(-) New commits: commit 8544e0a20bd8f8d8c918f91f90768019fa8099d7 Author: Noel Grandin AuthorDate: Thu May 7 15:34:12 2020 +0200 Commit: Noel Grandin CommitDate: Thu May 7 19:28:23 2020 +0200 m_aVerbTable can be a std::map instead of using the heavyweight Sequence datastructures Change-Id: Ica6b30490f2a1b4367acbf0341ecc86701c21926 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93641 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/embeddedobj/source/commonembedding/embedobj.cxx b/embeddedobj/source/commonembedding/embedobj.cxx index 6250555e05ec..abc43f42736f 100644 --- a/embeddedobj/source/commonembedding/embedobj.cxx +++ b/embeddedobj/source/commonembedding/embedobj.cxx @@ -74,9 +74,9 @@ awt::Rectangle GetRectangleInterception( const awt::Rectangle& aRect1, const awt sal_Int32 OCommonEmbeddedObject::ConvertVerbToState_Impl( sal_Int32 nVerb ) { -for ( sal_Int32 nInd = 0; nInd < m_aVerbTable.getLength(); nInd++ ) -if ( m_aVerbTable[nInd][0] == nVerb ) -return m_aVerbTable[nInd][1]; +auto it = m_aVerbTable.find( nVerb ); +if (it != m_aVerbTable.end()) +return it->second; throw lang::IllegalArgumentException(); // TODO: unexpected verb provided } diff --git a/embeddedobj/source/commonembedding/miscobj.cxx b/embeddedobj/source/commonembedding/miscobj.cxx index 71f79fabd96d..3363a02bfd02 100644 --- a/embeddedobj/source/commonembedding/miscobj.cxx +++ b/embeddedobj/source/commonembedding/miscobj.cxx @@ -161,50 +161,31 @@ void OCommonEmbeddedObject::CommonInit_Impl( const uno::Sequence< beans::NamedVa m_pIntermediateStatesSeqs[4][0][0] = embed::EmbedStates::RUNNING; // verbs table -sal_Int32 nVerbTableSize = 0; for ( sal_Int32 nVerbInd = 0; nVerbInd < m_aObjectVerbs.getLength(); nVerbInd++ ) { if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_PRIMARY ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] = embed::EmbedStates::UI_ACTIVE; +m_aVerbTable.insert( { m_aObjectVerbs[nVerbInd].VerbID, embed::EmbedStates::UI_ACTIVE } ); } else if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_SHOW ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] = embed::EmbedStates::UI_ACTIVE; +m_aVerbTable.insert( { m_aObjectVerbs[nVerbInd].VerbID, embed::EmbedStates::UI_ACTIVE } ); } else if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_OPEN ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] = embed::EmbedStates::ACTIVE; +m_aVerbTable.insert( { m_aObjectVerbs[nVerbInd].VerbID, embed::EmbedStates::ACTIVE } ); } else if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_IPACTIVATE ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] = embed::EmbedStates::INPLACE_ACTIVE; +m_aVerbTable.insert( { m_aObjectVerbs[nVerbInd].VerbID, embed::EmbedStates::INPLACE_ACTIVE } ); } else if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_UIACTIVATE ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] = embed::EmbedStates::UI_ACTIVE; +m_aVerbTable.insert( { m_aObjectVerbs[nVerbInd].VerbID, embed::EmbedStates::UI_ACTIVE } ); } else if ( m_aObjectVerbs[nVerbInd].VerbID == embed::EmbedVerbs::MS_OLEVERB_HIDE ) { -m_aVerbTable.realloc( ++nVerbTableSize ); -m_aVerbTable[nVerbTableSize - 1].realloc( 2 ); -m_aVerbTable[nVerbTableSize - 1][0] = m_aObjectVerbs[nVerbInd].VerbID; -m_aVerbTable[nVerbTableSize - 1][1] =
[Libreoffice-commits] core.git: 2 commits - canvas/source leak-suppress.txt
canvas/source/tools/canvastools.cxx |2 +- leak-suppress.txt |3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) New commits: commit ca21e8618f446733ab5d046178ebb47c2d204840 Author: Noel Grandin AuthorDate: Thu May 7 15:44:10 2020 +0200 Commit: Noel Grandin CommitDate: Thu May 7 19:28:07 2020 +0200 ignore leaks in idlc which seems to be leaking deliberately and we don't really care about leaks in this tool Change-Id: I6b6630fb64f905037efc043ea81c5cdc5a3207a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93644 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/leak-suppress.txt b/leak-suppress.txt index 6f00829c78ca..e3700295304d 100644 --- a/leak-suppress.txt +++ b/leak-suppress.txt @@ -51,3 +51,6 @@ leak:_PyMem_RawMalloc # ignore leak in gpgmepp external library leak:mkdefsinc + +# idlc deliberately leaks +leak:idlc/source/idlcmain.cxx commit 4c016865f9ea78813d5cde84a4d214b34f2f1dd9 Author: Noel Grandin AuthorDate: Thu May 7 15:40:15 2020 +0200 Commit: Noel Grandin CommitDate: Thu May 7 19:27:58 2020 +0200 fix bug in extracting property introduced with commit 17cd7dd708631f7af9e66860b403627416e4545e tdf#43671 set emphasis mark of vcl::Font (windows). but has probably never been a problem because I guess this propertyset almost always has 0 or 1 element. Change-Id: I17c64e376ee81cc9f92173015d2632331c63ae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93643 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/canvas/source/tools/canvastools.cxx b/canvas/source/tools/canvastools.cxx index 54e93fcb3625..2ca1b5081724 100644 --- a/canvas/source/tools/canvastools.cxx +++ b/canvas/source/tools/canvastools.cxx @@ -1317,7 +1317,7 @@ namespace canvas::tools for(sal_Int32 nIdx = 0; nIdx < rExtraFontProperties.getLength(); ++nIdx) { if (rExtraFontProperties[nIdx].Name == "EmphasisMark") -rExtraFontProperties[0].Value >>= rEmphasisMark; +rExtraFontProperties[nIdx].Value >>= rEmphasisMark; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 101181] Support the OOXML Glow Effect for Pictures and Shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=101181 --- Comment #13 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5ac2075d56cfff57f2254e4e5bd5a1e3a3579f83 tdf#101181: unit test for glow attributes in ODF It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: schema/libreoffice sd/qa
schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng | 24 + sd/qa/unit/data/odg/glow.odg|binary sd/qa/unit/export-tests.cxx | 50 3 files changed, 74 insertions(+) New commits: commit 5ac2075d56cfff57f2254e4e5bd5a1e3a3579f83 Author: Mike Kaganski AuthorDate: Thu May 7 14:24:44 2020 +0300 Commit: Mike Kaganski CommitDate: Thu May 7 19:24:52 2020 +0200 tdf#101181: unit test for glow attributes in ODF Tests loext:glow, loext:glow-radius, loext:glow-color, loext:glow-transparency There's original decision to keep EMUs in GlowEffectRad property, which makes this to be stored as hundreds of cm in ODF. I suppose we should change this in a follow-up to use mm100s instead. Change-Id: I47bf6530799ed16a55d58d0be5a8a7c3446d2df9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93633 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng b/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng index a61f6da11f71..5e1a587fda74 100644 --- a/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng +++ b/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng @@ -920,6 +920,30 @@ xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1. + + + + + visible + hidden + + + + + + + + + + + + + + + + + + diff --git a/sd/qa/unit/data/odg/glow.odg b/sd/qa/unit/data/odg/glow.odg new file mode 100644 index ..11d697c491da Binary files /dev/null and b/sd/qa/unit/data/odg/glow.odg differ diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx index 285294bca8ea..de092590f2cd 100644 --- a/sd/qa/unit/export-tests.cxx +++ b/sd/qa/unit/export-tests.cxx @@ -74,6 +74,7 @@ public: void testTdf123557(); void testTdf113822(); void testTdf126761(); +void testGlow(); CPPUNIT_TEST_SUITE(SdExportTest); @@ -108,6 +109,7 @@ public: CPPUNIT_TEST(testTdf123557); CPPUNIT_TEST(testTdf113822); CPPUNIT_TEST(testTdf126761); +CPPUNIT_TEST(testGlow); CPPUNIT_TEST_SUITE_END(); @@ -1257,6 +1259,54 @@ void SdExportTest::testTdf126761() xDocShRef->DoClose(); } +void SdExportTest::testGlow() +{ +auto xDocShRef = loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/odg/glow.odg"), ODG); +utl::TempFile tempFile; +xDocShRef = saveAndReload(xDocShRef.get(), ODG, ); +uno::Reference xShape(getShapeFromPage(0, 0, xDocShRef)); + +// Check glow properties +bool bGlowEffect = false; +CPPUNIT_ASSERT(xShape->getPropertyValue("GlowEffect") >>= bGlowEffect); +CPPUNIT_ASSERT(bGlowEffect); +sal_Int32 nGlowEffectRad = 0; +CPPUNIT_ASSERT(xShape->getPropertyValue("GlowEffectRad") >>= nGlowEffectRad); +CPPUNIT_ASSERT_EQUAL(sal_Int32(190500), nGlowEffectRad); // 15 pt = 190500 EMU +sal_Int32 nGlowEffectColor = 0; +CPPUNIT_ASSERT(xShape->getPropertyValue("GlowEffectColor") >>= nGlowEffectColor); +CPPUNIT_ASSERT_EQUAL(sal_Int32(0x00FF4000), nGlowEffectColor); // "Brick" +sal_Int16 nGlowEffectTransparency = 0; +CPPUNIT_ASSERT(xShape->getPropertyValue("GlowEffectTransparency") >>= nGlowEffectTransparency); +CPPUNIT_ASSERT_EQUAL(sal_Int16(60), nGlowEffectTransparency); // 60% + +// Test ODF element +xmlDocPtr pXmlDoc = parseExport(tempFile, "content.xml"); + +// check that we actually test graphic style +assertXPath(pXmlDoc, "/office:document-content/office:automatic-styles/style:style[2]", +"family", "graphic"); +// check loext graphic attributes +assertXPath( +pXmlDoc, + "/office:document-content/office:automatic-styles/style:style[2]/style:graphic-properties", +"glow", "visible"); +assertXPath( +pXmlDoc, + "/office:document-content/office:automatic-styles/style:style[2]/style:graphic-properties", +"glow-radius", "190.5cm"); // ??? +assertXPath( +pXmlDoc, + "/office:document-content/office:automatic-styles/style:style[2]/style:graphic-properties", +"glow-color", "#ff4000"); +assertXPath( +pXmlDoc, + "/office:document-content/office:automatic-styles/style:style[2]/style:graphic-properties", +"glow-transparency", "60%"); + +xDocShRef->DoClose(); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SdExportTest); CPPUNIT_PLUGIN_IMPLEMENT(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 132825] The layout/number of pages changes between inserting footer and save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=132825 Telesto changed: What|Removed |Added Keywords|bibisectRequest, regression | --- Comment #1 from Telesto --- I'm wrong, also in 4.4.7.2. The timer stuff is slower.. takes a while -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/xmloff
include/xmloff/xmlnmspe.hxx | 60 1 file changed, 33 insertions(+), 27 deletions(-) New commits: commit 36110559e9cd2b4f7c3dd173cb1cd60bb8d3df6f Author: Michael Stahl AuthorDate: Mon Apr 27 18:01:43 2020 +0200 Commit: Michael Stahl CommitDate: Thu May 7 19:17:10 2020 +0200 xmloff: rearrange XML_NAMESPACE_* and add some comments Change-Id: I65165da851ce7b6ef779163b5ac5346ee46a1ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92987 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/include/xmloff/xmlnmspe.hxx b/include/xmloff/xmlnmspe.hxx index 3c5e679ee5d8..d45832f02d81 100644 --- a/include/xmloff/xmlnmspe.hxx +++ b/include/xmloff/xmlnmspe.hxx @@ -25,6 +25,7 @@ // current namespaces // These namespaces have the same index in the namespace table as prefix used. // If a namespace is added, XML_OLD_NAMESPACE_BASE has to be adjusted! +// * standard ODF elements and attributes constexpr sal_uInt16 XML_NAMESPACE_OFFICE = 0; constexpr sal_uInt16 XML_NAMESPACE_STYLE =1; constexpr sal_uInt16 XML_NAMESPACE_TEXT = 2; @@ -42,29 +43,34 @@ constexpr sal_uInt16 XML_NAMESPACE_DR3D =13; constexpr sal_uInt16 XML_NAMESPACE_MATH =14; constexpr sal_uInt16 XML_NAMESPACE_FORM =15; constexpr sal_uInt16 XML_NAMESPACE_SCRIPT = 16; -constexpr sal_uInt16 XML_NAMESPACE_BLOCKLIST = 17; -constexpr sal_uInt16 XML_NAMESPACE_FRAMEWORK = 18; -constexpr sal_uInt16 XML_NAMESPACE_CONFIG = 19; -constexpr sal_uInt16 XML_NAMESPACE_OOO = 20; -constexpr sal_uInt16 XML_NAMESPACE_OOOW =21; -constexpr sal_uInt16 XML_NAMESPACE_OOOC =22; -constexpr sal_uInt16 XML_NAMESPACE_DOM = 23; -constexpr sal_uInt16 XML_NAMESPACE_TCD = 24; // text conversion dictionary -constexpr sal_uInt16 XML_NAMESPACE_DB = 25; -constexpr sal_uInt16 XML_NAMESPACE_DLG = 26; -constexpr sal_uInt16 XML_NAMESPACE_XFORMS = 27; -constexpr sal_uInt16 XML_NAMESPACE_XSD = 28; -constexpr sal_uInt16 XML_NAMESPACE_XSI = 29; -constexpr sal_uInt16 XML_NAMESPACE_SMIL =30; -constexpr sal_uInt16 XML_NAMESPACE_ANIMATION = 31; -constexpr sal_uInt16 XML_NAMESPACE_XML = 32; -constexpr sal_uInt16 XML_NAMESPACE_REPORT = 33; -constexpr sal_uInt16 XML_NAMESPACE_OF = 34; // OpenFormula aka ODFF -constexpr sal_uInt16 XML_NAMESPACE_XHTML = 35; -constexpr sal_uInt16 XML_NAMESPACE_GRDDL = 36; +constexpr sal_uInt16 XML_NAMESPACE_CONFIG = 17; +constexpr sal_uInt16 XML_NAMESPACE_DB = 18; +constexpr sal_uInt16 XML_NAMESPACE_XFORMS = 19; +constexpr sal_uInt16 XML_NAMESPACE_SMIL =20; +constexpr sal_uInt16 XML_NAMESPACE_ANIMATION = 21; +constexpr sal_uInt16 XML_NAMESPACE_XML = 22; +constexpr sal_uInt16 XML_NAMESPACE_XHTML = 23; +constexpr sal_uInt16 XML_NAMESPACE_GRDDL = 24; +// * formula attribute values (standard ODF) +constexpr sal_uInt16 XML_NAMESPACE_OF = 25; // OpenFormula aka ODFF +// * event attribute values (standard W3C) +constexpr sal_uInt16 XML_NAMESPACE_DOM = 26; +// * XForms attribute values (standard W3C) +constexpr sal_uInt16 XML_NAMESPACE_XSD = 27; +constexpr sal_uInt16 XML_NAMESPACE_XSI = 28; +// * following 3 namespaces are used for non-standard attribute values and non-ODF XML +constexpr sal_uInt16 XML_NAMESPACE_OOO = 29; // lots of attributes, settings.xml, non-ODF XML +constexpr sal_uInt16 XML_NAMESPACE_OOOW =30; // formula attribute values +constexpr sal_uInt16 XML_NAMESPACE_OOOC =31; // formula attribute values +// non-ODF XML namespaces +constexpr sal_uInt16 XML_NAMESPACE_BLOCKLIST = 32; +constexpr sal_uInt16 XML_NAMESPACE_FRAMEWORK = 33; +constexpr sal_uInt16 XML_NAMESPACE_TCD = 34; // text conversion dictionary +constexpr sal_uInt16 XML_NAMESPACE_DLG = 35; +constexpr sal_uInt16 XML_NAMESPACE_REPORT = 36; constexpr sal_uInt16 XML_NAMESPACE_VERSIONS_LIST = 37; -// namespaces for odf extended formats +// namespaces for ODF extended formats constexpr sal_uInt16 XML_NAMESPACE_EXT_BASE = 50; constexpr sal_uInt16 XML_NAMESPACE_OFFICE_EXT = XML_NAMESPACE_EXT_BASE + 0; constexpr sal_uInt16 XML_NAMESPACE_TABLE_EXT = XML_NAMESPACE_EXT_BASE + 1; @@ -73,6 +79,12 @@ constexpr sal_uInt16 XML_NAMESPACE_DRAW_EXT = XML_NAMESPACE_EXT_BASE + 3; constexpr sal_uInt16 XML_NAMESPACE_CALC_EXT = XML_NAMESPACE_EXT_BASE + 4; constexpr sal_uInt16 XML_NAMESPACE_LO_EXT = XML_NAMESPACE_EXT_BASE + 5; +// experimental ODF extended namespaces +constexpr sal_uInt16 XML_NAMESPACE_FIELD = XML_NAMESPACE_EXT_BASE + 6; +constexpr sal_uInt16 XML_NAMESPACE_CSS3TEXT =
[Libreoffice-bugs] [Bug 132825] The layout/number of pages changes between inserting footer and save & reload
https://bugs.documentfoundation.org/show_bug.cgi?id=132825 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs