[Libreoffice-bugs] [Bug 137581] add option to disable splash screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137581 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137581] add option to disable splash screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137581 Telesto changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137468] Severe performance degradation on a macOS with a 5K display
https://bugs.documentfoundation.org/show_bug.cgi?id=137468 --- Comment #10 from Leo Wang --- (In reply to Tor Lillqvist from comment #7) > Leo, do you have any way to objectively measure the impact of these patches, > out do you just estimate by eyeball? (or is the difference so very obvious > if one just knows what kind of document to use and what to do while editing > it?) > > I submitted the first patch on your behalf as > https://gerrit.libreoffice.org/c/core/+/104476 . With iStat Menus' CPU/GPU dropdown menu: Original: 5-7 fps (almost unusable) Patched: 12-18 fps (acceptable, but not smooth) when the content is pure text. Quartz Debug also gives the FPS number, but since it updates the dock icon frequently, the number is usually much higher than the actual, especially when the FPS is very low. I am still trying to find where the pixel format conversions are introduced. AquaSalGraphics::copyArea and AquaSalGraphics::copyBits are the hottest spots, they call CGContextDrawLayerInRect and CGContextDrawLayerAtPoint and those 2 functions call argb32_image_mark then rgba32_sample_rgba32 is called. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129948] ~r is double assigned in French UI
https://bugs.documentfoundation.org/show_bug.cgi?id=129948 --- Comment #10 from Ming Hua --- Created attachment 166486 --> https://bugs.documentfoundation.org/attachment.cgi?id=166486=edit Screenshots of "Find and Replace..." dialog and "Find..." toolbar with French UI OK, so I switched to French UI and had a look myself. (In reply to TorrAB from comment #9) > (In reply to Ming Hua from comment #7) > > The "Match case" checkbox in the Edit > Find and Replace... dialog (hope > > this is what TorrAB is referring to > > yes, it is. > > > in French UI Alt+C is the keyboard shortcut (also the c in casse should be > > underlined in French UI > > The c is not underlined and Alt+C does not work, in version 7.0.1.2(x64) Apparently there is some misunderstanding here (due to language barrier?), as seen in the attached screenshots, the "Find and Replace..." dialog (Ctrl+H) has an underlined c and Alt+C accelerator works as expected. On the other hand, the "Find..." toolbar (Ctrl+F) has a "Respecter la casse" checkbox with no underlined character and no keyboard accelerator. Perhaps this is what TorrAB was talking about? The screenshots are made with 7.0.2 (information is from English UI, not French): Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137520] Colibre: Some direct formatting (like B, I, U) are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=137520 --- Comment #7 from Rizal Muttaqin --- (In reply to Rania Amina from comment #6) > Totally agree with this change, it more professional for me. > Just need a bit polish in heading icons and all will great What kind of touch do you want to see from those Styles icons? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137520] Colibre: Some direct formatting (like B, I, U) are too big
https://bugs.documentfoundation.org/show_bug.cgi?id=137520 --- Comment #6 from Rania Amina --- Totally agree with this change, it more professional for me. Just need a bit polish in heading icons and all will great -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130526] New B dialog in Draw has Scope section with "Slide" and "Selection" options. It's strange
https://bugs.documentfoundation.org/show_bug.cgi?id=130526 Buovjaga changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org --- Comment #3 from Buovjaga --- (In reply to Aron Budea from comment #2) > Seems like a dupe of bug 130069. So should we close this as dupe, but transfer the easy hack status? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Infra call on Tue, Oct 20 at 16:30 UTC
Hi there, The next infra call will take place at `date -d "Tue, 20 Oct 2020 16:30 UTC"` (18:30 Berlin time). We'll meet at https://jitsi.documentfoundation.org/infra and write the minutes to https://pad.documentfoundation.org/p/infra . Agenda TBA. See you there! Cheers, -- Guilhem. signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 137219] Ability to search for patterns involving multiple lines
https://bugs.documentfoundation.org/show_bug.cgi?id=137219 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 137219] Ability to search for patterns involving multiple lines
https://bugs.documentfoundation.org/show_bug.cgi?id=137219 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137042] SQL Error -607, when changing Field type of a table (Firebird)
https://bugs.documentfoundation.org/show_bug.cgi?id=137042 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment --> added |--> added testcase leads to |testcase leads to crash |crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134901] FILEOPEN: DOCX: PRINTDATE field not supported?
https://bugs.documentfoundation.org/show_bug.cgi?id=134901 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132304] LibreOffice Calc, EDIT, Cells linked to an external file don't automatically update when both files are open.
https://bugs.documentfoundation.org/show_bug.cgi?id=132304 --- Comment #2 from QA Administrators --- Dear Paul O, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Bug 103314 depends on bug 124084, which changed state. Bug 124084 Summary: Template change goes unnoticed https://bugs.documentfoundation.org/show_bug.cgi?id=124084 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137251] Crash in: dbaccess::ODatabaseDocument::storeToRecoveryFile
https://bugs.documentfoundation.org/show_bug.cgi?id=137251 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42400] Query designer: numeric literal in condition on (VAR)CHAR column destructively transformed into string
https://bugs.documentfoundation.org/show_bug.cgi?id=42400 --- Comment #5 from QA Administrators --- Dear Lionel Elie Mamane, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131440] Cannot add an index field
https://bugs.documentfoundation.org/show_bug.cgi?id=131440 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44812] Sort ignores links from local url buttons to cells in the sorted range
https://bugs.documentfoundation.org/show_bug.cgi?id=44812 --- Comment #9 from QA Administrators --- Dear andréb, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124084] Template change goes unnoticed
https://bugs.documentfoundation.org/show_bug.cgi?id=124084 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137247] Unable to detach embedded font from base form when editing one
https://bugs.documentfoundation.org/show_bug.cgi?id=137247 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132283] Unable to make changes on any saved documents
https://bugs.documentfoundation.org/show_bug.cgi?id=132283 --- Comment #2 from QA Administrators --- Dear Ashley, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133759] Memory usage XLSX 896 MB, same data as XLS 130 MB
https://bugs.documentfoundation.org/show_bug.cgi?id=133759 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39921] Russian dictionary needs a proper numbers handling
https://bugs.documentfoundation.org/show_bug.cgi?id=39921 --- Comment #7 from QA Administrators --- Dear Urmas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131440] Cannot add an index field
https://bugs.documentfoundation.org/show_bug.cgi?id=131440 --- Comment #3 from QA Administrators --- Dear tomraymondtom, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124084] Template change goes unnoticed
https://bugs.documentfoundation.org/show_bug.cgi?id=124084 --- Comment #23 from QA Administrators --- Dear TorrAB, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112773] UI: EDITING Pivot Table Layout closed upon closing warning message
https://bugs.documentfoundation.org/show_bug.cgi?id=112773 --- Comment #5 from QA Administrators --- Dear Emil Tanev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137581] New: add option to disable splash screen
https://bugs.documentfoundation.org/show_bug.cgi?id=137581 Bug ID: 137581 Summary: add option to disable splash screen Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a...@medovina.org It would be great to have an option to disable the splash screen that appears when any LibreOffice program starts. Currently the only way to disable the splash screen is by editing LibreOffice's startup script: https://www.howtogeek.com/287367/how-to-disable-libreoffices-startup-splash-screen-on-windows-and-linux/ But that's a bother, and it's hard for many people to figure out how to do that. An option would make this easy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133546] LibODev 7.0 Beta 1 regression in insertion of PDF image wrt image size
https://bugs.documentfoundation.org/show_bug.cgi?id=133546 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1971 CC||ba...@caesar.elte.hu, ||ke...@collabora.com Keywords||bibisected, bisected, ||regression --- Comment #14 from Aron Budea --- Bibisected to the following commit using repo bibisect-linux-64-7.0. Adding CC: to Kendy. https://cgit.freedesktop.org/libreoffice/core/commit/?id=6ac2d66c78d6c080aabfa46157113684c2f3a3b0 author Jan Holesovsky 2019-10-18 11:19:04 +0200 committer Tomaž Vajngerl2020-03-17 22:01:15 +0100 pdfium: Make Insert -> Image... use VectorGraphicData for PDF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131971] Draw -> Insert -> Image... PDF file incorrectly scaled
https://bugs.documentfoundation.org/show_bug.cgi?id=131971 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3546 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - icon-themes/colibre icon-themes/colibre_svg
icon-themes/colibre/cmd/32/alphaliststyle.png |binary icon-themes/colibre/cmd/32/alphalowliststyle.png|binary icon-themes/colibre/cmd/32/ar/alphaliststyle.png|binary icon-themes/colibre/cmd/32/ar/alphalowliststyle.png |binary icon-themes/colibre/cmd/32/ar/bulletsandnumberingdialog.png |binary icon-themes/colibre/cmd/32/ar/defaultbullet.png |binary icon-themes/colibre/cmd/32/ar/defaultnumbering.png |binary icon-themes/colibre/cmd/32/ar/insertneutralparagraph.png|binary icon-themes/colibre/cmd/32/ar/numberingstart.png|binary icon-themes/colibre/cmd/32/ar/outlinebullet.png |binary icon-themes/colibre/cmd/32/ar/removebullets.png |binary icon-themes/colibre/cmd/32/ar/romanliststyle.png|binary icon-themes/colibre/cmd/32/ar/romanlowliststyle.png |binary icon-themes/colibre/cmd/32/backcolor.png|binary icon-themes/colibre/cmd/32/bulletsandnumberingdialog.png|binary icon-themes/colibre/cmd/32/charmapcontrol.png |binary icon-themes/colibre/cmd/32/colorsettings.png|binary icon-themes/colibre/cmd/32/defaultbullet.png|binary icon-themes/colibre/cmd/32/defaultnumbering.png |binary icon-themes/colibre/cmd/32/grafblue.png |binary icon-themes/colibre/cmd/32/grafgreen.png|binary icon-themes/colibre/cmd/32/grafred.png |binary icon-themes/colibre/cmd/32/inserthyperlink.png |binary icon-themes/colibre/cmd/32/inserthyperlinkcontrol.png |binary icon-themes/colibre/cmd/32/insertneutralparagraph.png |binary icon-themes/colibre/cmd/32/numberingstart.png |binary icon-themes/colibre/cmd/32/outlinebullet.png|binary icon-themes/colibre/cmd/32/removebullets.png|binary icon-themes/colibre/cmd/32/romanliststyle.png |binary icon-themes/colibre/cmd/32/romanlowliststyle.png|binary icon-themes/colibre/cmd/32/text.png |binary icon-themes/colibre/cmd/32/verticaltext.png |binary icon-themes/colibre/cmd/32/xlinecolor.png |binary icon-themes/colibre/cmd/ar/lc_alphaliststyle.png|binary icon-themes/colibre/cmd/ar/lc_alphalowliststyle.png |binary icon-themes/colibre/cmd/ar/lc_bulletsandnumberingdialog.png |binary icon-themes/colibre/cmd/ar/lc_defaultbullet.png |binary icon-themes/colibre/cmd/ar/lc_insertneutralparagraph.png|binary icon-themes/colibre/cmd/ar/lc_numberingstart.png|binary icon-themes/colibre/cmd/ar/lc_outlinebullet.png |binary icon-themes/colibre/cmd/ar/lc_removebullets.png |binary icon-themes/colibre/cmd/ar/lc_romanliststyle.png|binary icon-themes/colibre/cmd/ar/lc_romanlowliststyle.png |binary icon-themes/colibre/cmd/ar/sc_insertneutralparagraph.png|binary icon-themes/colibre/cmd/ar/sc_numberingstart.png|binary icon-themes/colibre/cmd/ar/sc_removebullets.png |binary icon-themes/colibre/cmd/ko/sc_verticaltext.png |binary icon-themes/colibre/cmd/lc_alphaliststyle.png |binary icon-themes/colibre/cmd/lc_alphalowliststyle.png|binary icon-themes/colibre/cmd/lc_backcolor.png|binary icon-themes/colibre/cmd/lc_bulletsandnumberingdialog.png|binary icon-themes/colibre/cmd/lc_colorsettings.png|binary icon-themes/colibre/cmd/lc_configuredialog.png |binary icon-themes/colibre/cmd/lc_defaultbullet.png|binary icon-themes/colibre/cmd/lc_defaultnumbering.png |binary icon-themes/colibre/cmd/lc_grafblue.png |binary icon-themes/colibre/cmd/lc_grafgreen.png|binary icon-themes/colibre/cmd/lc_grafred.png |binary icon-themes/colibre/cmd/lc_inserthyperlink.png |binary icon-themes/colibre/cmd/lc_inserthyperlinkcontrol.png |binary icon-themes/colibre/cmd/lc_insertneutralparagraph.png |binary icon-themes/colibre/cmd/lc_numberingstart.png |binary icon-themes/colibre/cmd/lc_outlinebullet.png|binary icon-themes/colibre/cmd/lc_removebullets.png|binary icon-themes/colibre/cmd/lc_romanliststyle.png |binary icon-themes/colibre/cmd/lc_romanlowliststyle.png|binary icon-themes/colibre/cmd/lc_setoptimalcolumnwidth.png|binary icon-themes/colibre/cmd/lc_text.png |binary
[Libreoffice-bugs] [Bug 131679] Crash cutting a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=131679 --- Comment #15 from Aron Budea --- Created attachment 166485 --> https://bugs.documentfoundation.org/attachment.cgi?id=166485=edit Backtrace w symbols -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135668] [LOCALHELP] Writer: add info about submenu items for "Headings" context menu in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=135668 --- Comment #5 from Jim Raykowski --- > @Jim -- do I have this right: > > 1. "outline tracking" is the only "new" (undocumented) command/feature in > the context menu for "Headings" (and its children)? I think so, other than the mentioned Collapse/Expand All. Outline tracking settings: Default - do not collapse already expanded outline entries Focus - collapse all outline entries other than the one being tracked Off - do not track https://bugs.documentfoundation.org/show_bug.cgi?id=108766#c14 > 2. while all other items in the context menus (for both Headings and for its > children) (including newly added or rearranged "old" ones) are already > documented on the Navigator help page (except for "Send Outline to > Clipboard)? Reading the help, it looks that way. > 3. And if I have read the source code correctly (uibase/utlui/content.cxx), > then Send Outline to Clipboard is using: .uno:SendOutlineToClipboard (which > I guess you have not worked on -- so I won't file a bug report. (-: ) Yep, Send Outline to Clipboard is inherited from OOo. It boils down to: https://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/rtfexport.cxx?r=7c70a59c#1023 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137495] UI: Tools - Options - Writer - Print has "Fax" label, which needs improvement
https://bugs.documentfoundation.org/show_bug.cgi?id=137495 --- Comment #5 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/56847f654de05ca610f7117d5a19784b0fb421d5 Resolves: tdf#137495 add colon for "Fax" in Writer Print Options dialog It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/printoptionspage.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 56847f654de05ca610f7117d5a19784b0fb421d5 Author: Seth Chaiklin AuthorDate: Fri Oct 16 15:15:44 2020 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Mon Oct 19 02:57:34 2020 +0200 Resolves: tdf#137495 add colon for "Fax" in Writer Print Options dialog Change-Id: I710669d8ed205aae30a63134c73b20fb6b2a52eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104340 Tested-by: Adolfo Jayme Barrientos Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/uiconfig/swriter/ui/printoptionspage.ui b/sw/uiconfig/swriter/ui/printoptionspage.ui index 666a71d921d3..f6c7d2a15a8c 100644 --- a/sw/uiconfig/swriter/ui/printoptionspage.ui +++ b/sw/uiconfig/swriter/ui/printoptionspage.ui @@ -467,7 +467,7 @@ True False -_Fax +_Fax: True fax ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 137495] UI: Tools - Options - Writer - Print has "Fax" label, which needs improvement
https://bugs.documentfoundation.org/show_bug.cgi?id=137495 --- Comment #5 from Commit Notification --- Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/56847f654de05ca610f7117d5a19784b0fb421d5 Resolves: tdf#137495 add colon for "Fax" in Writer Print Options dialog It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 109239] [META] CSV import and export dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109239 Bug 109239 depends on bug 119813, which changed state. Bug 119813 Summary: FILEOPEN CSV import dialog doesn't get focus if libreoffice is already running [Ubuntu 18.04, 16.04] https://bugs.documentfoundation.org/show_bug.cgi?id=119813 What|Removed |Added Status|RESOLVED|NEW Resolution|NOTOURBUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119813] FILEOPEN CSV import dialog doesn't get focus if libreoffice is already running [Ubuntu 18.04, 16.04]
https://bugs.documentfoundation.org/show_bug.cgi?id=119813 Aron Budea changed: What|Removed |Added Status|RESOLVED|NEW Resolution|NOTOURBUG |--- --- Comment #10 from Aron Budea --- Since it's a workaround, not an actual fix, let's keep the bug open. There's another case I can reproduce, it's not the same, but perhaps there's similarity, and it can be checked from the terminal with any version: - in a terminal window, in a LO installation directory, run ./soffice - in another terminal window, try to open a CSV from the terminal eg. ./soffice => The splash screen will be shown, and persist, and the CSV import dialog will be opened in the original soffice instance, but it doesn't get focus. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46733] Deleting columns in a table can delete several columns if any cells in that column are merged with other cells
https://bugs.documentfoundation.org/show_bug.cgi?id=46733 --- Comment #24 from Aron Budea --- (In reply to Justin L from comment #23) > > cells. This gets really complicated. What if we didn't bother with the complicated cases, only with the simple, well-structured ones? That's what users seem to care about, anyway. If someone's designing their floor tiles with Writer tables, deleting rows/columns is likely not part of their workflow ;). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137561] LibreOffice Calc crashed when I attempt to change a formula using Find/Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=137561 m.a.riosv changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from m.a.riosv --- https://wiki.documentfoundation.org/UserProfile#Expert_information -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132667] Custom properties: Adding new custom property doesn't focus Name field anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=132667 Bartosz changed: What|Removed |Added CC||gan...@poczta.onet.pl Summary|Adding new custom property |Custom properties: Adding |doesn't focus Name field|new custom property doesn't |anymore |focus Name field anymore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48606] Custom properties: Property "Open file read-only" of New Document is not saved when changed manually in File - Properties - General (OK with existing document) (see comm
https://bugs.documentfoundation.org/show_bug.cgi?id=48606 Bartosz changed: What|Removed |Added Summary|Property "Open file |Custom properties: Property |read-only" of New Document |"Open file read-only" of |is not saved when changed |New Document is not saved |manually in File - |when changed manually in |Properties - General (OK|File - Properties - General |with existing document) |(OK with existing document) |(see comment 17)|(see comment 17) CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63535] Custom properties: FORMATTING: Custom CreateDate saved in .DOC as General instead of Date
https://bugs.documentfoundation.org/show_bug.cgi?id=63535 Bartosz changed: What|Removed |Added CC||gan...@poczta.onet.pl Summary|FORMATTING: Custom |Custom properties: |CreateDate saved in .DOC as |FORMATTING: Custom |General instead of Date |CreateDate saved in .DOC as ||General instead of Date -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75914] Custom properties: Opening document properties dialog removes line breaks from custom properties
https://bugs.documentfoundation.org/show_bug.cgi?id=75914 Bartosz changed: What|Removed |Added Summary|Opening document properties |Custom properties: Opening |dialog removes line breaks |document properties dialog |from custom properties |removes line breaks from ||custom properties CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91378] Custom properties: Empty Custom Properties are lost while saving in .pptx format
https://bugs.documentfoundation.org/show_bug.cgi?id=91378 Bartosz changed: What|Removed |Added CC||gan...@poczta.onet.pl Summary|Empty Custom Properties are |Custom properties: Empty |lost while saving in .pptx |Custom Properties are lost |format |while saving in .pptx ||format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103212] Custom properties: Add and edit more authors of the document in File-Properties
https://bugs.documentfoundation.org/show_bug.cgi?id=103212 Bartosz changed: What|Removed |Added Summary|Add and edit more authors |Custom properties: Add and |of the document in |edit more authors of the |File-Properties |document in File-Properties CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116214] Custom properties: value type is changed from Number to Text
https://bugs.documentfoundation.org/show_bug.cgi?id=116214 Bartosz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl |desktop.org | CC||gan...@poczta.onet.pl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards
https://bugs.documentfoundation.org/show_bug.cgi?id=124176 --- Comment #134 from Commit Notification --- mariamfahmy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e6a96b8e9642732082701b01495e3093439ae404 tdf#124176: Use pragma once instead of include guards It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/CellColorHandler.hxx |5 +
writerfilter/source/dmapper/CellMarginHandler.hxx|5 +
writerfilter/source/dmapper/ConversionHelper.hxx |4 +---
writerfilter/source/dmapper/DomainMapper.hxx |4 +---
writerfilter/source/dmapper/DomainMapperTableHandler.hxx |5 +
writerfilter/source/dmapper/DomainMapper_Impl.hxx|4 +---
6 files changed, 6 insertions(+), 21 deletions(-)
New commits:
commit e6a96b8e9642732082701b01495e3093439ae404
Author: mariamfahmy
AuthorDate: Sun Oct 18 20:11:26 2020 +0200
Commit: Muhammet Kara
CommitDate: Sun Oct 18 23:54:36 2020 +0200
tdf#124176: Use pragma once instead of include guards
Change-Id: Ib9fd7e3ffbe8760edf4a108342aa5ed03c453b01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104487
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/writerfilter/source/dmapper/CellColorHandler.hxx
b/writerfilter/source/dmapper/CellColorHandler.hxx
index 1d5419ec18af..a011cd9fd794 100644
--- a/writerfilter/source/dmapper/CellColorHandler.hxx
+++ b/writerfilter/source/dmapper/CellColorHandler.hxx
@@ -16,8 +16,7 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CELLCOLORHANDLER_HXX
-#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CELLCOLORHANDLER_HXX
+#pragma once
#include "LoggedResources.hxx"
#include "PropertyMap.hxx"
@@ -64,6 +63,4 @@ public:
};
}
-#endif
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/CellMarginHandler.hxx
b/writerfilter/source/dmapper/CellMarginHandler.hxx
index 956e3b259a80..8dcbf2dc5245 100644
--- a/writerfilter/source/dmapper/CellMarginHandler.hxx
+++ b/writerfilter/source/dmapper/CellMarginHandler.hxx
@@ -16,8 +16,7 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CELLMARGINHANDLER_HXX
-#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CELLMARGINHANDLER_HXX
+#pragma once
#include "LoggedResources.hxx"
#include
@@ -62,6 +61,4 @@ public:
};
}
-#endif
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/ConversionHelper.hxx
b/writerfilter/source/dmapper/ConversionHelper.hxx
index 53bae1527e77..9f970f668b80 100644
--- a/writerfilter/source/dmapper/ConversionHelper.hxx
+++ b/writerfilter/source/dmapper/ConversionHelper.hxx
@@ -16,8 +16,7 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CONVERSIONHELPER_HXX
-#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_CONVERSIONHELPER_HXX
+#pragma once
#include
#include
@@ -55,6 +54,5 @@ namespace writerfilter::dmapper::ConversionHelper{
css::util::DateTime ConvertDateStringToDateTime(const OUString& rDateTime);
} // namespace writerfilter::dmapper::ConversionHelper
-#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper.hxx
b/writerfilter/source/dmapper/DomainMapper.hxx
index 34066b95cff1..9cc196621083 100644
--- a/writerfilter/source/dmapper/DomainMapper.hxx
+++ b/writerfilter/source/dmapper/DomainMapper.hxx
@@ -16,8 +16,7 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_DOMAINMAPPER_HXX
-#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_DOMAINMAPPER_HXX
+#pragma once
#include
#include "LoggedResources.hxx"
@@ -179,6 +178,5 @@ private:
};
} // namespace writerfilter::dmapper
-#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
index f130cf6da216..900ff747f4cc 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.hxx
@@ -16,8 +16,7 @@
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_DOMAINMAPPERTABLEHANDLER_HXX
-#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_DOMAINMAPPERTABLEHANDLER_HXX
+#pragma once
#include "PropertyMap.hxx"
#include
@@ -122,6 +121,4 @@ public:
}
-#endif // INCLUDED_WRITERFILTER_SOURCE_DMAPPER_DOMAINMAPPERTABLEHANDLER_HXX
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index ba81c4c55e39..4a45bc3f1fd2 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa
sc/qa/unit/data/xlsx/tdf137091.xlsx|binary
sc/qa/unit/subsequent_filters-test.cxx | 26 ++
2 files changed, 26 insertions(+)
New commits:
commit 44b5084beb7380996b1eb9c7f946768834779b1c
Author: Xisco Fauli
AuthorDate: Tue Sep 29 11:29:39 2020 +0200
Commit: Muhammet Kara
CommitDate: Sun Oct 18 23:51:13 2020 +0200
tdf#137091: sc_subsequent_filters_test: Add unittest
Change-Id: I435ffbdd82b5a40e56dd5f6ef55c032802184767
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103604
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 7672ac2e8764d9e4fcb5a896ef6210077907dcd0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103657
(cherry picked from commit 91de839547719b7177518386f9b39bd9e4b1cf73)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104493
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Muhammet Kara
diff --git a/sc/qa/unit/data/xlsx/tdf137091.xlsx
b/sc/qa/unit/data/xlsx/tdf137091.xlsx
new file mode 100644
index ..abcdf8f27f24
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf137091.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index e005b258d979..0d2f55dcd184 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -75,6 +75,8 @@
#include
#include
+#include
+#include
#include "helper/qahelper.hxx"
#include "helper/shared_test_impl.hxx"
@@ -246,6 +248,7 @@ public:
void testHiddenRowsColumnsXLSXML();
void testColumnWidthRowHeightXLSXML();
void testCharacterSetXLSXML();
+void testTdf137091();
void testTdf62268();
void testVBAMacroFunctionODS();
void testAutoheight2Rows();
@@ -388,6 +391,7 @@ public:
CPPUNIT_TEST(testColumnWidthRowHeightXLSXML);
CPPUNIT_TEST(testCharacterSetXLSXML);
CPPUNIT_TEST(testCondFormatFormulaListenerXLSX);
+CPPUNIT_TEST(testTdf137091);
CPPUNIT_TEST(testTdf62268);
CPPUNIT_TEST(testVBAMacroFunctionODS);
CPPUNIT_TEST(testAutoheight2Rows);
@@ -4265,6 +4269,28 @@ void ScFiltersTest::testCondFormatFormulaListenerXLSX()
xDocSh->DoClose();
}
+void ScFiltersTest::testTdf137091()
+{
+// Set the system locale to Turkish
+SvtSysLocaleOptions aOptions;
+OUString sLocaleConfigString = aOptions.GetLanguageTag().getBcp47();
+aOptions.SetLocaleConfigString("tr-TR");
+aOptions.Commit();
+comphelper::ScopeGuard g([, ] {
+aOptions.SetLocaleConfigString(sLocaleConfigString);
+aOptions.Commit();
+});
+
+ScDocShellRef xDocSh = loadDoc("tdf137091.", FORMAT_XLSX);
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 28/4
+// - Actual : Err:507
+CPPUNIT_ASSERT_EQUAL(OUString("28/4"), rDoc.GetString(ScAddress(2,1,0)));
+xDocSh->DoClose();
+}
+
void ScFiltersTest::testTdf62268()
{
ScDocShellRef xDocSh = loadDoc("tdf62268.", FORMAT_ODS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137571] Adding and modifying animations painfully slow
https://bugs.documentfoundation.org/show_bug.cgi?id=137571 --- Comment #4 from Eyal Rozenberg --- (In reply to Telesto from comment #3) > Are we talking about GTK3, KDE5 or GEN backend. Suspecting a GTK3 specific > issue Oh, sorry, I forgot to paste my build info: Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3 Locale: he-IL (en_IL); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234
--- Comment #7 from kleinesuniver...@gmx.de ---
{} the integral in LaTeX does not help either, this also yields the same
result:
\[
{\int_1^2} {\frac{3}{4}} = 5
\]
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234
--- Comment #6 from kleinesuniver...@gmx.de ---
Also, i just checked with the LaTeX:
both
\[
\int_1^2 \frac{3}{4} = 5
\]
and
\[
\int_1^2 {\frac{3}{4}} = 5
\]
look identical in LaTeX (corresponds to whatItShouldLookLike.png) and when
converted to ODT via PanDoc produce the exact same result
http://www.w3.org/1998/Math/MathML;>∫1234=5
However ... as already mentioned i don't believe looking at LaTeX is necessary
here (sorry again for the confusion), just look at the ODT file and see what
LibreOffice shows.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234 --- Comment #5 from kleinesuniver...@gmx.de --- It seems the LaTeX caused confusion instead of doing any good. Sorry for that. You may be right that the LaTeX might not be optimal. But what if you look at the ODT file (this file might be generated with any tool, no need for LaTeX at all) I read: . I cannot see how the msubsup-section should be part of the mfrac. To me this clearly reads that i have the integral (msubsup) and then the fraction (mfrac), not the integral as part of the fraction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137573] The "Office" file picker gets use in a recent master build on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=137573 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7575 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137575] UI: Custom sorting state is lost when reopening the LibreOffice file picker dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=137575 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7573 --- Comment #6 from V Stuart Foote --- (In reply to Telesto from comment #5) > FWIW: not that I mentioned it anywhere, but I reported this against Linux > GEN environment (didn't touch the settings; so assuming being at stock). > Also happening on MacOS, I think. But might be cause of the non-aqua file > picker at the moment (fixed tomorrow) > Looks like bug 137573... >... > Not sure what's the case on Windows. Windows doesn't seem affected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83592] Object selection removed when deleting an animation effect
https://bugs.documentfoundation.org/show_bug.cgi?id=83592 Telesto changed: What|Removed |Added CC||caol...@redhat.com --- Comment #8 from Telesto --- @Caolán As this being a focus issue (at least I assume so) and gui related, you might be interested (and because it's simply painful user experience). And being long enough to get some love ;-) Only a suggestion of course on my 100 papercut bug list [which gets reset to 100 at every bugfix, because I likely dig up something new. Before you start question, still 100, how is that possible :-)] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137580] Closing Impress presentation relatively slow (8 seconds; expected 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=137580 --- Comment #2 from Telesto --- Suspecting work of Luboš Luňák here. thumbnails ... bibisect will tell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137580] Closing Impress presentation relatively slow (8 seconds; expected 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=137580 --- Comment #1 from Telesto --- Still OK with Version: 7.1.0.0.alpha0+ (x64) Build ID: 1cd7e2a4042b92123d8c94ef10b2e8baf7cfaafa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137580] New: Closing Impress presentation relatively slow (8 seconds; expected 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=137580 Bug ID: 137580 Summary: Closing Impress presentation relatively slow (8 seconds; expected 2) Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Closing Impress presentation relatively slow (8 seconds; expected 2) Steps to Reproduce: 1. open attachment 166482 2. Press close button (gray cross) Actual Results: Takes 8 seconds for me Expected Results: 1 maybe 2 seconds? Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 94e6e140491de31c0788c91af855a75a3bb12709 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137571] Adding and modifying animations painfully slow
https://bugs.documentfoundation.org/show_bug.cgi?id=137571 --- Comment #3 from Telesto --- No repro on Windows Version: 7.1.0.0.alpha0+ (x64) Build ID: 94e6e140491de31c0788c91af855a75a3bb12709 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Are we talking about GTK3, KDE5 or GEN backend. Suspecting a GTK3 specific issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137575] UI: Custom sorting state is lost when reopening the LibreOffice file picker dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=137575 --- Comment #5 from Telesto --- (In reply to V Stuart Foote from comment #4) > But is this really an issue? Use on all os/DE requires knowledge of Expert > Configuration dialog and the 'UseSystemFileDialog' stanza to by-pass use of > os/DE native File Picker? FWIW: not that I mentioned it anywhere, but I reported this against Linux GEN environment (didn't touch the settings; so assuming being at stock). Also happening on MacOS, I think. But might be cause of the non-aqua file picker at the moment (fixed tomorrow) The reason I bibisected it, is because I sort they Downloads by date (and they top one is the bug doc being the most recent one). And now I have to using sort every time. Not sure what's the case on Windows. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234
--- Comment #4 from Rene Engelhard ---
I am not actually sure.. The LaTeX code is suboptimal to begin with.
\[
\int_1^2 \frac{3}{4} = 5
\]
works by chance since it's one command and because it's an integral and one
doesn't see the difference if the text is not covered by _int. Add a real big
\frac or whatever and you'll see the \int will not adapt to that size because
that "big thing" is not part of the \int.
a
\[
\sqrt \frac{1}{4} = \frac{1}{2}
\]
would also "work", unless you add more stuff after the fraction. You'll see
that the root only covers the \frac.
Strictly speaking,
\[
\int_1^2 {\frac{3}{4}} = 5
\]
would have been correct in LaTeX even.
Your faulty display then shows that this abiguity is then followed wrong. I
would assume that if you did {} the integral you would get the correct result
with bracketed { 3 over 4 }?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - formula/source sc/inc sc/source
formula/source/core/api/FormulaCompiler.cxx | 19 +-
sc/inc/compiler.hxx | 10 ++-
sc/source/core/tool/compiler.cxx| 82
3 files changed, 83 insertions(+), 28 deletions(-)
New commits:
commit af75098d524311416a5f7caf6ae76055cc689ad1
Author: Eike Rathke
AuthorDate: Mon Sep 28 21:02:23 2020 +0200
Commit: Muhammet Kara
CommitDate: Sun Oct 18 22:36:40 2020 +0200
Resolves: tdf#137091 Use CharClass matching the formula language
This is a combination of 3 commits.
Resolves: tdf#137091 Use CharClass matching the formula language
... not the current locale. Specifically important for
uppercase/lowercase conversions that may yield different results
for example in Turkish i with/without dot.
I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 3c6177be2705303044e3de262689d593f3d0f282)
Signed-off-by: Xisco Fauli
Current sytem locale's CharClass for user defined names, tdf#137091
follow-up
I5f025a12ca183acb3f80d2a7527677aceb9ffbd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit d41c45a522c5e973d7043d36bc6c82e77735ab9b)
Determine CharClass difference once, tdf#137091 follow-up
As a side note:
Clang plugin simplifybool for
!(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en")
told "error: logical negation of logical op containing negation, can be
simplified"
which is nonsense (the message stayed the same while the checks evolved).
It actually complained about !(a==b && c==d) to be rewritten as
(a!=b || c!=d) whether that makes sense or not.. it may save one
boolean operation, yes, but..
Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 1acf517906b7cdc4931dd26319d467dff53ae7d2)
Conflicts:
sc/source/core/tool/compiler.cxx
Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103598
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104486
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Muhammet Kara
diff --git a/formula/source/core/api/FormulaCompiler.cxx
b/formula/source/core/api/FormulaCompiler.cxx
index 16e58f9c8e71..5de0b8d76491 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -31,6 +31,9 @@
#include
#include
#include
+#include
+#include
+#include
#include
#include
#include
@@ -143,6 +146,14 @@ void lclPushOpCodeMapEntries( ::std::vector<
sheet::FormulaOpCodeMapEntry >& rVe
lclPushOpCodeMapEntry( rVec, pTable, *pnOpCodes );
}
+CharClass* createCharClassIfNonEnglishUI()
+{
+const LanguageTag& rLanguageTag(
Application::GetSettings().GetUILanguageTag());
+if (rLanguageTag.getLanguage() == "en")
+return nullptr;
+return new CharClass( ::comphelper::getProcessComponentContext(),
rLanguageTag);
+}
+
class OpCodeList
{
public:
@@ -166,8 +177,8 @@ OpCodeList::OpCodeList(bool bLocalized, const
std::pair* pSymb
, mpSymbols(pSymbols)
, mbLocalized(bLocalized)
{
-SvtSysLocale aSysLocale;
-const CharClass* pCharClass = (xMap->isEnglish() ? nullptr :
aSysLocale.GetCharClassPtr());
+std::unique_ptr xCharClass( xMap->isEnglish() ? nullptr :
createCharClassIfNonEnglishUI());
+const CharClass* pCharClass = xCharClass.get();
if (meSepType == FormulaCompiler::SeparatorType::RESOURCE_BASE)
{
for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i)
@@ -813,8 +824,8 @@ FormulaCompiler::OpCodeMapPtr
FormulaCompiler::CreateOpCodeMap(
NonConstOpCodeMapPtr xMap( new OpCodeMap( SC_OPCODE_LAST_OPCODE_ID + 1,
false,
FormulaGrammar::mergeToGrammar( FormulaGrammar::setEnglishBit(
FormulaGrammar::GRAM_EXTERNAL, bEnglish),
FormulaGrammar::CONV_UNSPECIFIED)));
-SvtSysLocale aSysLocale;
-const CharClass* pCharClass = (xMap->isEnglish() ? nullptr :
aSysLocale.GetCharClassPtr());
+std::unique_ptr xCharClass( xMap->isEnglish() ? nullptr :
createCharClassIfNonEnglishUI());
+const CharClass* pCharClass = xCharClass.get();
for (auto const& rMapEntry : rMapping)
{
OpCode eOp = OpCode(rMapEntry.Token.OpCode);
diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx
index c19ff834ded9..5de80a6b9fb3 100644
--- a/sc/inc/compiler.hxx
+++ b/sc/inc/compiler.hxx
@@ -251,7 +251,8 @@ public:
private:
-static CharClass*pCharClassEnglish;
[Libreoffice-commits] core.git: .git-blame-ignore-revs
.git-blame-ignore-revs |4 1 file changed, 4 insertions(+) New commits: commit 8fbee94f42708c664d424883e9acfea43f3612ed Author: Muhammet Kara AuthorDate: Sun Oct 18 22:33:43 2020 +0300 Commit: Muhammet Kara CommitDate: Sun Oct 18 22:35:07 2020 +0200 put clang-format commits to .git-blame-ignore-revs Change-Id: Icaddc983c153e021fa9bdd4e4b7c974648e346dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104509 Tested-by: Jenkins Reviewed-by: Muhammet Kara diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 8e3b1412..2cfc555cf365 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -36,3 +36,7 @@ b86ca947115f2ef61dd71c7a43e7a3ec1f1cf3b0 6dc2e26e0103137863f4e2d8c1f0c6511b164b66 7da92c6fff9549ebbea5e527b72ffd89faa46f71 261cd2301d0cb581de2238913bd99e2041ad6eda +2242774bc8a35cda736d65d0f4b647cf394ca6ee +11485a500196af7a2533787f4faf32e14693f480 +e190529f40988bbeb23b7b3abaeca6900f96213f +35fa77d0137350e69b17418e2bc33f1fa0be2efb ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114039] [META] Field dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114039 Bug 114039 depends on bug 129935, which changed state. Bug 129935 Summary: Mnemonic key (keyboard accelerator) clash in "Edit Fields" dialog https://bugs.documentfoundation.org/show_bug.cgi?id=129935 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 Bug 98259 depends on bug 129935, which changed state. Bug 129935 Summary: Mnemonic key (keyboard accelerator) clash in "Edit Fields" dialog https://bugs.documentfoundation.org/show_bug.cgi?id=129935 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129935] Mnemonic key (keyboard accelerator) clash in "Edit Fields" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=129935 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk |desktop.org | --- Comment #5 from sdc.bla...@youmail.dk --- (In reply to Commit Notification from comment #4) > Affected users are encouraged to test the fix and report feedback. It seems to work for me now. T for Type, S for Select, F for Format, O for OK, etc. No conflicts, so I will close as FIXED. Reopen if new problems with accelerator keys appear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 2 commits - drawinglayer/source include/drawinglayer solenv/clang-format
drawinglayer/source/primitive2d/textlayoutdevice.cxx | 722 --
include/drawinglayer/primitive2d/textlayoutdevice.hxx | 166 +---
solenv/clang-format/excludelist |2
3 files changed, 409 insertions(+), 481 deletions(-)
New commits:
commit a44755ebaef3eed58a475881efa983c205b9241e
Author: Tomaž Vajngerl
AuthorDate: Sun Oct 18 21:59:15 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:59:15 2020 +0200
simplify namespaces and clean-up for TextLayouterDevice
Move anonymous namespace into drawinglayer::primitive2d and convert
static function into anonymous functions.
Change-Id: Id8ff161a5ec69154f053fadd1178265fa2675139
diff --git a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
index 387089b62a2b..dee610bbb958 100644
--- a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
+++ b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
@@ -36,12 +36,14 @@
#include
#include
-// VDev RevDevice provider
-
+namespace drawinglayer::primitive2d
+{
namespace
{
class ImpTimedRefDev;
+// VDev RevDevice provider
+
//the scoped_timed_RefDev owns an ImpTimeRefDev and releases it on dtor
//or disposing of the default XComponentContext which causes the underlying
//OutputDevice to get released
@@ -130,14 +132,8 @@ void ImpTimedRefDev::releaseVirtualDevice()
Start();
}
}
-} // end of anonymous namespace
-
-// access to one global ImpTimedRefDev incarnation in namespace
drawinglayer::primitive
-namespace drawinglayer::primitive2d
-{
-// static methods here
-static VirtualDevice& acquireGlobalVirtualDevice()
+VirtualDevice& acquireGlobalVirtualDevice()
{
scoped_timed_RefDev& rStdRefDevice = the_scoped_timed_RefDev::get();
@@ -147,7 +143,7 @@ static VirtualDevice& acquireGlobalVirtualDevice()
return rStdRefDevice->acquireVirtualDevice();
}
-static void releaseGlobalVirtualDevice()
+void releaseGlobalVirtualDevice()
{
scoped_timed_RefDev& rStdRefDevice = the_scoped_timed_RefDev::get();
@@ -156,6 +152,8 @@ static void releaseGlobalVirtualDevice()
rStdRefDevice->releaseVirtualDevice();
}
+} // end of anonymous namespace
+
TextLayouterDevice::TextLayouterDevice()
: maSolarGuard()
, mrDevice(acquireGlobalVirtualDevice())
commit 512669246b037f1f00fdb78fc275388acbf8bd5f
Author: Tomaž Vajngerl
AuthorDate: Sun Oct 18 21:55:51 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:55:51 2020 +0200
remove textlayoutdevice.{hxx,cxx} from clang-format excludelist
Change-Id: Ia80a0331246b4e25cdc3387c50bd97c6befc4ea4
diff --git a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
index b8ac0bf73c85..387089b62a2b 100644
--- a/drawinglayer/source/primitive2d/textlayoutdevice.cxx
+++ b/drawinglayer/source/primitive2d/textlayoutdevice.cxx
@@ -36,460 +36,408 @@
#include
#include
-
// VDev RevDevice provider
namespace
{
-class ImpTimedRefDev;
+class ImpTimedRefDev;
-//the scoped_timed_RefDev owns an ImpTimeRefDev and releases it on dtor
-//or disposing of the default XComponentContext which causes the underlying
-//OutputDevice to get released
+//the scoped_timed_RefDev owns an ImpTimeRefDev and releases it on dtor
+//or disposing of the default XComponentContext which causes the underlying
+//OutputDevice to get released
-//The ImpTimerRefDev itself, if the timeout ever gets hit, will call
-//reset on the scoped_timed_RefDev to release the ImpTimerRefDev early
-//if it's unused for a few minutes
-class scoped_timed_RefDev : public
comphelper::unique_disposing_ptr
+//The ImpTimerRefDev itself, if the timeout ever gets hit, will call
+//reset on the scoped_timed_RefDev to release the ImpTimerRefDev early
+//if it's unused for a few minutes
+class scoped_timed_RefDev : public
comphelper::unique_disposing_ptr
+{
+public:
+scoped_timed_RefDev()
+: comphelper::unique_disposing_ptr(
+ (css::uno::Reference(
+ ::comphelper::getProcessComponentContext(),
css::uno::UNO_QUERY_THROW)))
{
-public:
-scoped_timed_RefDev() :
comphelper::unique_disposing_ptr((css::uno::Reference(::comphelper::getProcessComponentContext(),
css::uno::UNO_QUERY_THROW)))
-{
-}
-};
+}
+};
-class the_scoped_timed_RefDev : public rtl::Static {};
+class the_scoped_timed_RefDev : public rtl::Static
+{
+};
-class ImpTimedRefDev : public Timer
-{
-scoped_timed_RefDev&mrOwnerOfMe;
-VclPtr mpVirDev;
-sal_uInt32 mnUseCount;
-
-public:
-explicit ImpTimedRefDev(scoped_timed_RefDev& rOwnerofMe);
-virtual ~ImpTimedRefDev() override;
-virtual void Invoke() override;
-
-VirtualDevice& acquireVirtualDevice();
-void
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/salvtables.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit bfadad64fe09dcdc370631e6b0d55a8705ee923c
Author: Caolán McNamara
AuthorDate: Sat Oct 17 20:56:11 2020 +0100
Commit: Caolán McNamara
CommitDate: Sun Oct 18 21:40:41 2020 +0200
use SetControlFont instead of SetPointFont to get the right size
Change-Id: I3c3d2c11d7a1faba792162fa1a61c247949b6cc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104508
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 19cd239d2848..190e265d0ada 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -2479,7 +2479,7 @@ void SalInstanceButton::set_label_line_wrap(bool wrap)
void SalInstanceButton::set_font(const vcl::Font& rFont)
{
-m_xButton->SetPointFont(*m_xButton, rFont);
+m_xButton->SetControlFont(rFont);
m_xButton->Invalidate();
}
@@ -5559,7 +5559,7 @@ void SalInstanceLabel::set_font_color(const Color& rColor)
void SalInstanceLabel::set_font(const vcl::Font& rFont)
{
-m_xLabel->SetPointFont(*m_xLabel, rFont);
+m_xLabel->SetControlFont(rFont);
m_xLabel->Invalidate();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - include/svx svx/qa svx/source
include/svx/svdoashp.hxx |1
include/svx/svdotext.hxx |1
svx/qa/unit/customshapes.cxx |2
svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx | 21 +---
svx/source/svdraw/svdoashp.cxx| 17 --
svx/source/svdraw/svdotextdecomposition.cxx | 35 ++
6 files changed, 41 insertions(+), 36 deletions(-)
New commits:
commit eda0fa64b5de798e6fd73a4bc598b86fb4bd1fb1
Author: Gülşah Köse
AuthorDate: Mon Oct 5 14:57:33 2020 +0300
Commit: Gülşah Köse
CommitDate: Sun Oct 18 21:36:09 2020 +0200
tdf#128212 Change the text z camera rotation order.
Old order:
1) Apply all rotation values (normal and camera z)
2) Do the adjustment (top, middle, bottom)
New Order:
1) Apply rotation values except camera z
2) Do the adjustment (top, middle, bottom)
3) Apply camera z rotation.
We rotate the text at the center of the already positioned rectangle
of the text, which depends on e.g. the length of the laid out text.
This matches the PowerPoint behavior.
Change-Id: I8741cf443834bf01cc07c04318fd6205ed6a0dd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103965
Tested-by: Jenkins
Reviewed-by: Gülşah Köse
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104448
Tested-by: Jenkins CollaboraOffice
diff --git a/include/svx/svdoashp.hxx b/include/svx/svdoashp.hxx
index ff51e20ec974..a5ab4eac2d12 100644
--- a/include/svx/svdoashp.hxx
+++ b/include/svx/svdoashp.hxx
@@ -142,7 +142,6 @@ public:
double GetObjectRotation() const { return fObjectRotation;}
double GetExtraTextRotation( const bool bPreRotation = false ) const;
-double GetCameraRotation() const;
SdrObjCustomShape(SdrModel& rSdrModel);
diff --git a/include/svx/svdotext.hxx b/include/svx/svdotext.hxx
index 020bcb6cdd22..6efae0b58feb 100644
--- a/include/svx/svdotext.hxx
+++ b/include/svx/svdotext.hxx
@@ -577,6 +577,7 @@ public:
// Set single item at the local ItemSet. *Does not use* AllowItemChange(),
// ItemChange(), PostItemChange() and ItemSetChanged() calls.
void SetObjectItemNoBroadcast(const SfxPoolItem& rItem);
+double GetCameraZRotation() const;
public:
diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index 796fa4824809..2e0ec9ce4d55 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -520,7 +520,7 @@ CPPUNIT_TEST_FIXTURE(CustomshapesTest,
testTdf126060_3D_Z_Rotation)
SdrObjCustomShape& rSdrObjCustomShape(
static_cast(*GetSdrObjectFromXShape(xShape)));
-if (rSdrObjCustomShape.GetCameraRotation() != 90)
+if (rSdrObjCustomShape.GetCameraZRotation() != 90)
sErrors += "Wrong text camera Z rotation";
basegfx::B2DHomMatrix aObjectTransform;
diff --git a/svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx
b/svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx
index 7a5c0487a13f..7132a1282540 100644
--- a/svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx
+++ b/svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx
@@ -167,18 +167,13 @@ namespace sdr
// #i101684# get the text range unrotated and absolute to
the object range
const basegfx::B2DRange
aTextRange(getCorrectedTextBoundRect());
-// Get the text range before unrotated and independent
from object range
-const tools::Rectangle
aIndTextRect(Point(aTextRange.getMinX(), aTextRange.getMinY()),
GetCustomShapeObj().GetTextSize());
-const basegfx::B2DRange aIndTextRange =
vcl::unotools::b2DRectangleFromRectangle(aIndTextRect);
-
// Rotation before scaling
-
if(!basegfx::fTools::equalZero(GetCustomShapeObj().GetExtraTextRotation(true))
||
-
!basegfx::fTools::equalZero(GetCustomShapeObj().GetCameraRotation()))
+
if(!basegfx::fTools::equalZero(GetCustomShapeObj().GetExtraTextRotation(true)))
{
basegfx::B2DVector aTranslation(0.5, 0.5);
aTextBoxMatrix.translate( -aTranslation.getX(),
-aTranslation.getY() );
aTextBoxMatrix.rotate(basegfx::deg2rad(
-360.0 -
GetCustomShapeObj().GetExtraTextRotation(true) -
GetCustomShapeObj().GetCameraRotation()));
+360.0 -
GetCustomShapeObj().GetExtraTextRotation(true)));
aTextBoxMatrix.translate( aTranslation.getX(),
aTranslation.getY() );
}
// give text object a size
@@ -186,7 +181,6 @@ namespace sdr
// check if we have a rotation/shear at all to take care of
const double
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/ipdf/pdfread.cxx | 61 -
1 file changed, 28 insertions(+), 33 deletions(-)
New commits:
commit 8604610e193c980fe5a9339b677c7a0cfb0eee76
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 15:39:16 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:23:42 2020 +0200
pdfium: simplify point unit conversion to HMM for annotations
Change-Id: Ied3721d58d49736c78a4fa5181b92beb1dff7728
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104378
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index 3ccad9b10ecc..db6c9d1bdd31 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -243,6 +243,14 @@ bool ImportPDF(SvStream& rStream, Graphic& rGraphic)
#if HAVE_FEATURE_PDFIUM
namespace
{
+basegfx::B2DPoint convertFromPDFInternalToHMM(basegfx::B2DSize const&
rInputPoint,
+ basegfx::B2DSize const&
rPageSize)
+{
+double x = convertPointToMm100(rInputPoint.getX());
+double y = convertPointToMm100(rPageSize.getY() - rInputPoint.getY());
+return basegfx::B2DPoint(x, y);
+}
+
std::vector
findAnnotations(const std::unique_ptr& pPage,
basegfx::B2DSize aPageSize)
{
@@ -303,9 +311,8 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
rPDFGraphicAnnotation.mpMarker = pMarker;
for (auto const& rVertex : rVertices)
{
-double x = convertPointToMm100(rVertex.getX());
-double y = convertPointToMm100(aPageSize.getY() -
rVertex.getY());
-pMarker->maPolygon.append({ x, y });
+auto aPoint = convertFromPDFInternalToHMM(rVertex,
aPageSize);
+pMarker->maPolygon.append(aPoint);
}
pMarker->maPolygon.setClosed(true);
pMarker->mnWidth =
convertPointToMm100(pAnnotation->getBorderWidth());
@@ -341,9 +348,8 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
basegfx::B2DPolygon aPolygon;
for (auto const& rVertex : rStrokes)
{
-double x = convertPointToMm100(rVertex.getX());
-double y =
convertPointToMm100(aPageSize.getY() - rVertex.getY());
-aPolygon.append({ x, y });
+auto aPoint =
convertFromPDFInternalToHMM(rVertex, aPageSize);
+aPolygon.append(aPoint);
}
pMarker->maStrokes.push_back(aPolygon);
}
@@ -366,29 +372,21 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
auto aAttachmentPoints =
pAnnotation->getAttachmentPoints(i);
if (!aAttachmentPoints.empty())
{
-double x, y;
basegfx::B2DPolygon aPolygon;
aPolygon.setClosed(true);
-x =
convertPointToMm100(aAttachmentPoints[0].getX());
-y = convertPointToMm100(aPageSize.getY()
--
aAttachmentPoints[0].getY());
-aPolygon.append({ x, y });
-
-x =
convertPointToMm100(aAttachmentPoints[1].getX());
-y = convertPointToMm100(aPageSize.getY()
--
aAttachmentPoints[1].getY());
-aPolygon.append({ x, y });
-
-x =
convertPointToMm100(aAttachmentPoints[3].getX());
-y = convertPointToMm100(aPageSize.getY()
--
aAttachmentPoints[3].getY());
-aPolygon.append({ x, y });
-
-x =
convertPointToMm100(aAttachmentPoints[2].getX());
-y = convertPointToMm100(aPageSize.getY()
--
aAttachmentPoints[2].getY());
-aPolygon.append({ x, y });
+auto aPoint1
+=
convertFromPDFInternalToHMM(aAttachmentPoints[0], aPageSize);
+aPolygon.append(aPoint1);
+auto aPoint2
+=
convertFromPDFInternalToHMM(aAttachmentPoints[1], aPageSize);
+
[Libreoffice-commits] core.git: include/vcl sd/source vcl/source
include/vcl/pdf/PDFAnnotationMarker.hxx |6 ++
sd/source/filter/pdf/sdpdffilter.cxx| 13 +
vcl/source/filter/ipdf/pdfread.cxx | 24 +++-
3 files changed, 42 insertions(+), 1 deletion(-)
New commits:
commit 354080769f34207e3c850c61e62e8af346964463
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 14:35:26 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:23:10 2020 +0200
sd: support line PDF annot. as custom marker
This renderes the line marker, but line start and end symbol is
for now not supported.
Change-Id: Ibf099f54b4bc047b22dae32c705982c8cb24388b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104377
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/pdf/PDFAnnotationMarker.hxx
b/include/vcl/pdf/PDFAnnotationMarker.hxx
index 2c525f85cbd5..d797115437e9 100644
--- a/include/vcl/pdf/PDFAnnotationMarker.hxx
+++ b/include/vcl/pdf/PDFAnnotationMarker.hxx
@@ -45,6 +45,12 @@ struct VCL_DLLPUBLIC PDFAnnotationMarkerPolygon : public
PDFAnnotationMarker
basegfx::B2DPolygon maPolygon;
};
+struct VCL_DLLPUBLIC PDFAnnotationMarkerLine : public PDFAnnotationMarker
+{
+basegfx::B2DPoint maLineStart;
+basegfx::B2DPoint maLineEnd;
+};
+
enum class PDFTextMarkerType
{
Highlight,
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx
b/sd/source/filter/pdf/sdpdffilter.cxx
index e903c015d4be..4b52f9e4b574 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -170,6 +170,19 @@ bool SdPdfFilter::Import()
if (rCustomAnnotationMarker.maFillColor.GetTransparency()
== 0)
rCustomAnnotationMarker.maFillColor.SetTransparency(0x90);
}
+else if (rPDFAnnotation.meSubType ==
vcl::pdf::PDFAnnotationSubType::Line)
+{
+auto* pMarker =
static_cast(
+rPDFAnnotation.mpMarker.get());
+
+basegfx::B2DPolygon aPoly;
+aPoly.append(pMarker->maLineStart);
+aPoly.append(pMarker->maLineEnd);
+rCustomAnnotationMarker.maPolygons.push_back(aPoly);
+
+rCustomAnnotationMarker.mnLineWidth = pMarker->mnWidth;
+rCustomAnnotationMarker.maFillColor = COL_TRANSPARENT;
+}
}
}
}
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index 9be28fcf0c9b..3ccad9b10ecc 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -259,7 +259,8 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Circle
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Square
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Ink
-|| eSubtype == vcl::pdf::PDFAnnotationSubType::Highlight)
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Highlight
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Line)
{
OUString sAuthor =
pAnnotation->getString(vcl::pdf::constDictionaryKeyTitle);
OUString sText =
pAnnotation->getString(vcl::pdf::constDictionaryKeyContents);
@@ -394,6 +395,27 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
}
}
}
+else if (eSubtype == vcl::pdf::PDFAnnotationSubType::Line)
+{
+auto const& rLineGeometry = pAnnotation->getLineGeometry();
+if (!rLineGeometry.empty())
+{
+double x, y;
+auto pMarker =
std::make_shared();
+rPDFGraphicAnnotation.mpMarker = pMarker;
+
+x = convertPointToMm100(rLineGeometry[0].getX());
+y = convertPointToMm100(aPageSize.getY() -
rLineGeometry[0].getY());
+pMarker->maLineStart = basegfx::B2DPoint(x, y);
+
+x = convertPointToMm100(rLineGeometry[1].getX());
+y = convertPointToMm100(aPageSize.getY() -
rLineGeometry[1].getY());
+pMarker->maLineEnd = basegfx::B2DPoint(x, y);
+
+float fWidth = pAnnotation->getBorderWidth();
+pMarker->mnWidth = convertPointToMm100(fWidth);
+}
+}
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/filter/pdf/sdpdffilter.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 2a1b5af875d8ee84fec18c781020d836c4650dc9 Author: Tomaž Vajngerl AuthorDate: Thu Oct 15 12:53:18 2020 +0200 Commit: Tomaž Vajngerl CommitDate: Sun Oct 18 21:22:27 2020 +0200 sd: protect size, position when opening with PDFium import filter This is to prevent that the PDF graphics can be moved and/or resized. Change-Id: Ica4276e93e268bb2ec4a0aae0e50620a09c538f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104370 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/sd/source/filter/pdf/sdpdffilter.cxx b/sd/source/filter/pdf/sdpdffilter.cxx index 5e190f8a0117..e903c015d4be 100644 --- a/sd/source/filter/pdf/sdpdffilter.cxx +++ b/sd/source/filter/pdf/sdpdffilter.cxx @@ -83,6 +83,9 @@ bool SdPdfFilter::Import() SdrGrafObj* pSdrGrafObj = new SdrGrafObj(pPage->getSdrModelFromSdrPage(), rGraphic, tools::Rectangle(Point(), aSizeHMM)); +pSdrGrafObj->SetResizeProtect(true); +pSdrGrafObj->SetMoveProtect(true); + pPage->InsertObject(pSdrGrafObj); for (auto const& rPDFAnnotation : rPDFGraphicResult.GetAnnotations()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/pdfium include/vcl vcl/qa vcl/source
external/pdfium/AnnotationLineStartAndEnd.patch.1 | 48 ++
external/pdfium/UnpackedTarball_pdfium.mk |1
include/vcl/filter/PDFiumLibrary.hxx |1
vcl/qa/cppunit/PDFiumLibraryTest.cxx | 12 +
vcl/source/pdf/PDFiumLibrary.cxx | 13 +
5 files changed, 75 insertions(+)
New commits:
commit aa301119c98bc5103d3738263b1df90b30013e32
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 14:11:54 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:22:46 2020 +0200
pdfium: add reading of line points to the wrapper
Change-Id: I3e596254b2e4ecc9f56ff09eeb63b66195ea6a2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104376
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/external/pdfium/AnnotationLineStartAndEnd.patch.1
b/external/pdfium/AnnotationLineStartAndEnd.patch.1
new file mode 100644
index ..00ebb6d20ed1
--- /dev/null
+++ b/external/pdfium/AnnotationLineStartAndEnd.patch.1
@@ -0,0 +1,48 @@
+diff --git a/fpdfsdk/fpdf_annot.cpp b/fpdfsdk/fpdf_annot.cpp
+index 229651d82..b43f378bc 100644
+--- a/fpdfsdk/fpdf_annot.cpp
b/fpdfsdk/fpdf_annot.cpp
+@@ -552,6 +552,25 @@ FPDFAnnot_GetInkStrokePoints(FPDF_ANNOTATION annot, int
index,
+ return true;
+ }
+
++FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV FPDFAnnot_GetLine(FPDF_ANNOTATION annot,
++ FS_POINTF* start,
++ FS_POINTF* end) {
++ CPDF_Dictionary* pAnnotDict = GetAnnotDictFromFPDFAnnotation(annot);
++ if (!pAnnotDict || !start || !end)
++return false;
++
++ CPDF_Array* pLineArray = pAnnotDict->GetArrayFor("L");
++ if (!pLineArray || pLineArray->size() < 4)
++return false;
++
++ start->x = pLineArray->GetNumberAt(0);
++ start->y = pLineArray->GetNumberAt(1);
++ end->x = pLineArray->GetNumberAt(2);
++ end->y = pLineArray->GetNumberAt(3);
++
++ return true;
++}
++
+ FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
+ FPDFAnnot_AppendObject(FPDF_ANNOTATION annot, FPDF_PAGEOBJECT obj) {
+ CPDF_AnnotContext* pAnnot = CPDFAnnotContextFromFPDFAnnotation(annot);
+diff --git a/public/fpdf_annot.h b/public/fpdf_annot.h
+index ce033cde3..c4b0f71b3 100644
+--- a/public/fpdf_annot.h
b/public/fpdf_annot.h
+@@ -232,6 +232,10 @@ FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
+ FPDFAnnot_GetInkStrokePoints(FPDF_ANNOTATION annot, int index,
+ FS_POINTF* points);
+
++FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV
++FPDFAnnot_GetLine(FPDF_ANNOTATION annot, FS_POINTF* start,
++ FS_POINTF* end);
++
+ // Experimental API.
+ // Add |obj| to |annot|. |obj| must have been created by
+ // FPDFPageObj_CreateNew{Path|Rect}() or FPDFPageObj_New{Text|Image}Obj(), and
+--
+2.26.2
+
diff --git a/external/pdfium/UnpackedTarball_pdfium.mk
b/external/pdfium/UnpackedTarball_pdfium.mk
index 5eccb92001eb..152178c2b1ca 100644
--- a/external/pdfium/UnpackedTarball_pdfium.mk
+++ b/external/pdfium/UnpackedTarball_pdfium.mk
@@ -16,6 +16,7 @@ pdfium_patches += windows7.patch.1
pdfium_patches += c++20-comparison.patch
pdfium_patches += AnnotationInkAndVertices.patch.1
pdfium_patches += AnnotationBorderProperties.patch.1
+pdfium_patches += AnnotationLineStartAndEnd.patch.1
# Work around "c++20
rewritten operator==
# recursive call mixing friend and external operators for template class" in
GCC with
diff --git a/include/vcl/filter/PDFiumLibrary.hxx
b/include/vcl/filter/PDFiumLibrary.hxx
index ee8a453a8b15..474f509df46b 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -103,6 +103,7 @@ public:
basegfx::B2DSize getBorderCornerRadius();
size_t getAttachmentPointsCount();
std::vector getAttachmentPoints(size_t nIndex);
+std::vector getLineGeometry();
};
class PDFiumPage;
diff --git a/vcl/qa/cppunit/PDFiumLibraryTest.cxx
b/vcl/qa/cppunit/PDFiumLibraryTest.cxx
index 2ef9ba942f27..6b4dbedff185 100644
--- a/vcl/qa/cppunit/PDFiumLibraryTest.cxx
+++ b/vcl/qa/cppunit/PDFiumLibraryTest.cxx
@@ -325,6 +325,8 @@ void PDFiumLibraryTest::testAnnotationsDifferentTypes()
CPPUNIT_ASSERT_EQUAL(0, pAnnotation->getObjectCount());
OUString aContentsString =
pAnnotation->getString(vcl::pdf::constDictionaryKeyContents);
CPPUNIT_ASSERT_EQUAL(OUString("Inline Note"), aContentsString);
+auto const& rLineGeometry = pAnnotation->getLineGeometry();
+CPPUNIT_ASSERT_EQUAL(true, rLineGeometry.empty());
}
{
@@ -339,6 +341,8 @@ void PDFiumLibraryTest::testAnnotationsDifferentTypes()
auto const& aPoints = aInkStrokes[0];
CPPUNIT_ASSERT_EQUAL(size_t(74), aPoints.size());
CPPUNIT_ASSERT_DOUBLES_EQUAL(2.0f, pAnnotation->getBorderWidth(),
1E-2);
+auto const& rLineGeometry = pAnnotation->getLineGeometry();
+
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/overlay/overlaypolypolygon.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 81a9e0eb98eacfb50ee1b30d1bbaea7a02594cc6
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 12:07:51 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:21:42 2020 +0200
sd: fix transparency when drawing OverlayPolyPolygon
should be sal_uInt8 not sal_Int8, which means that the we could
have a negative transpareny in some cases.
Change-Id: I53c414878f0d88e58a6a9670f3f49ea23f8990a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104368
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/svx/source/sdr/overlay/overlaypolypolygon.cxx
b/svx/source/sdr/overlay/overlaypolypolygon.cxx
index b338d171e551..8abde414faa0 100644
--- a/svx/source/sdr/overlay/overlaypolypolygon.cxx
+++ b/svx/source/sdr/overlay/overlaypolypolygon.cxx
@@ -59,8 +59,8 @@ namespace sdr::overlay
aReturnContainer.push_back(aFill);
}
-sal_Int8 nTransparency = getBaseColor().GetTransparency();
-if (nTransparency != 0)
+sal_uInt8 nTransparency = getBaseColor().GetTransparency();
+if (nTransparency > 0)
{
const drawinglayer::primitive2d::Primitive2DReference
aTransparencePrimitive(
new
drawinglayer::primitive2d::UnifiedTransparencePrimitive2D(aReturnContainer,
nTransparency / 255.0));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl sd/source vcl/source
include/vcl/pdf/PDFAnnotationMarker.hxx | 19 +
sd/source/filter/pdf/sdpdffilter.cxx| 13 +
vcl/source/filter/ipdf/pdfread.cxx | 45 +++-
3 files changed, 76 insertions(+), 1 deletion(-)
New commits:
commit 7ea49126e7a247ac60ad45ab420106fe4be574ea
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 12:23:08 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:22:03 2020 +0200
sd: support text annotation PDF annot. as custom marker
This one is special as it annotates text. Normally the annotation
would be present behind the text, but this is not possible in
this case, so the best alternative is to use a transparent
rectangle over the text.
Change-Id: Ib115efa4a5994e17dcf9d7b02591ccae26800928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104369
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/pdf/PDFAnnotationMarker.hxx
b/include/vcl/pdf/PDFAnnotationMarker.hxx
index f2841b09db6c..2c525f85cbd5 100644
--- a/include/vcl/pdf/PDFAnnotationMarker.hxx
+++ b/include/vcl/pdf/PDFAnnotationMarker.hxx
@@ -45,6 +45,25 @@ struct VCL_DLLPUBLIC PDFAnnotationMarkerPolygon : public
PDFAnnotationMarker
basegfx::B2DPolygon maPolygon;
};
+enum class PDFTextMarkerType
+{
+Highlight,
+Underline,
+Squiggly,
+StrikeOut
+};
+
+struct VCL_DLLPUBLIC PDFAnnotationMarkerHighlight : public PDFAnnotationMarker
+{
+std::vector maQuads;
+PDFTextMarkerType meTextMarkerType;
+
+PDFAnnotationMarkerHighlight(PDFTextMarkerType eTextMarkerType)
+: meTextMarkerType(eTextMarkerType)
+{
+}
+};
+
} // namespace vcl::pdf
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx
b/sd/source/filter/pdf/sdpdffilter.cxx
index b2866dd1701d..5e190f8a0117 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -154,6 +154,19 @@ bool SdPdfFilter::Import()
rCustomAnnotationMarker.mnLineWidth = pMarker->mnWidth;
rCustomAnnotationMarker.maFillColor = pMarker->maFillColor;
}
+else if (rPDFAnnotation.meSubType ==
vcl::pdf::PDFAnnotationSubType::Highlight)
+{
+if (rCustomAnnotationMarker.maLineColor.GetTransparency()
== 0)
+
rCustomAnnotationMarker.maLineColor.SetTransparency(0x90);
+auto* pMarker =
static_cast(
+rPDFAnnotation.mpMarker.get());
+for (auto const& rPolygon : pMarker->maQuads)
+rCustomAnnotationMarker.maPolygons.push_back(rPolygon);
+rCustomAnnotationMarker.mnLineWidth = 1;
+rCustomAnnotationMarker.maFillColor =
rPDFAnnotation.maColor;
+if (rCustomAnnotationMarker.maFillColor.GetTransparency()
== 0)
+
rCustomAnnotationMarker.maFillColor.SetTransparency(0x90);
+}
}
}
}
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index a0e9b51e28a8..9be28fcf0c9b 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -258,7 +258,8 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Polygon
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Circle
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Square
-|| eSubtype == vcl::pdf::PDFAnnotationSubType::Ink)
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Ink
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Highlight)
{
OUString sAuthor =
pAnnotation->getString(vcl::pdf::constDictionaryKeyTitle);
OUString sText =
pAnnotation->getString(vcl::pdf::constDictionaryKeyContents);
@@ -351,6 +352,48 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
pMarker->maFillColor =
pAnnotation->getInteriorColor();
}
}
+else if (eSubtype == vcl::pdf::PDFAnnotationSubType::Highlight)
+{
+size_t nCount = pAnnotation->getAttachmentPointsCount();
+if (nCount > 0)
+{
+auto pMarker =
std::make_shared(
+vcl::pdf::PDFTextMarkerType::Highlight);
+rPDFGraphicAnnotation.mpMarker = pMarker;
+for (size_t i = 0; i < nCount; ++i)
+{
+auto aAttachmentPoints =
pAnnotation->getAttachmentPoints(i);
+if (!aAttachmentPoints.empty())
+{
+double
[Libreoffice-commits] core.git: 2 commits - include/vcl sd/source vcl/source
include/vcl/pdf/PDFAnnotationMarker.hxx | 13 +
sd/source/filter/pdf/sdpdffilter.cxx| 34
vcl/source/filter/ipdf/pdfread.cxx | 45 +++-
3 files changed, 91 insertions(+), 1 deletion(-)
New commits:
commit 560d3b95840221fe9661d46682af7c4ce897193b
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 11:22:07 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:21:18 2020 +0200
sd: support ink PDF annot. as custom marker
Ink PDF annotation is similar to a set of polylines (or freehand
drawing), so we can again just reuse the polygon code paths. The
difference to the polygon is that the polygon is closed.
Change-Id: I99641dccc0b2f9f2d3ebf2c71d3e20f8b1d0a485
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104367
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/pdf/PDFAnnotationMarker.hxx
b/include/vcl/pdf/PDFAnnotationMarker.hxx
index 4cf088dc1b8e..f2841b09db6c 100644
--- a/include/vcl/pdf/PDFAnnotationMarker.hxx
+++ b/include/vcl/pdf/PDFAnnotationMarker.hxx
@@ -35,6 +35,11 @@ struct VCL_DLLPUBLIC PDFAnnotationMarkerSquare : public
PDFAnnotationMarker
{
};
+struct VCL_DLLPUBLIC PDFAnnotationMarkerInk : public PDFAnnotationMarker
+{
+std::vector maStrokes;
+};
+
struct VCL_DLLPUBLIC PDFAnnotationMarkerPolygon : public PDFAnnotationMarker
{
basegfx::B2DPolygon maPolygon;
diff --git a/sd/source/filter/pdf/sdpdffilter.cxx
b/sd/source/filter/pdf/sdpdffilter.cxx
index 28cf7b6902dd..b2866dd1701d 100644
--- a/sd/source/filter/pdf/sdpdffilter.cxx
+++ b/sd/source/filter/pdf/sdpdffilter.cxx
@@ -145,6 +145,15 @@ bool SdPdfFilter::Import()
rCustomAnnotationMarker.maFillColor = pMarker->maFillColor;
rCustomAnnotationMarker.maPolygons.push_back(aPoly);
}
+else if (rPDFAnnotation.meSubType ==
vcl::pdf::PDFAnnotationSubType::Ink)
+{
+auto* pMarker =
static_cast(
+rPDFAnnotation.mpMarker.get());
+for (auto const& rPolygon : pMarker->maStrokes)
+rCustomAnnotationMarker.maPolygons.push_back(rPolygon);
+rCustomAnnotationMarker.mnLineWidth = pMarker->mnWidth;
+rCustomAnnotationMarker.maFillColor = pMarker->maFillColor;
+}
}
}
}
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index 001303194259..a0e9b51e28a8 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -257,7 +257,8 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
if (eSubtype == vcl::pdf::PDFAnnotationSubType::Text
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Polygon
|| eSubtype == vcl::pdf::PDFAnnotationSubType::Circle
-|| eSubtype == vcl::pdf::PDFAnnotationSubType::Square)
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Square
+|| eSubtype == vcl::pdf::PDFAnnotationSubType::Ink)
{
OUString sAuthor =
pAnnotation->getString(vcl::pdf::constDictionaryKeyTitle);
OUString sText =
pAnnotation->getString(vcl::pdf::constDictionaryKeyContents);
@@ -326,6 +327,30 @@ findAnnotations(const
std::unique_ptr& pPage, basegfx::B2D
if
(pAnnotation->hasKey(vcl::pdf::constDictionaryKeyInteriorColor))
pMarker->maFillColor = pAnnotation->getInteriorColor();
}
+else if (eSubtype == vcl::pdf::PDFAnnotationSubType::Ink)
+{
+auto const& rStrokesList = pAnnotation->getInkStrokes();
+if (!rStrokesList.empty())
+{
+auto pMarker =
std::make_shared();
+rPDFGraphicAnnotation.mpMarker = pMarker;
+for (auto const& rStrokes : rStrokesList)
+{
+basegfx::B2DPolygon aPolygon;
+for (auto const& rVertex : rStrokes)
+{
+double x = convertPointToMm100(rVertex.getX());
+double y =
convertPointToMm100(aPageSize.getY() - rVertex.getY());
+aPolygon.append({ x, y });
+}
+pMarker->maStrokes.push_back(aPolygon);
+}
+float fWidth = pAnnotation->getBorderWidth();
+pMarker->mnWidth = convertPointToMm100(fWidth);
+if
(pAnnotation->hasKey(vcl::pdf::constDictionaryKeyInteriorColor))
+pMarker->maFillColor =
pAnnotation->getInteriorColor();
+
[Libreoffice-commits] core.git: include/svx include/vcl sd/inc sd/source svx/source vcl/source
include/svx/sdr/overlay/overlaypolypolygon.hxx | 19 +-
include/vcl/pdf/PDFAnnotationMarker.hxx| 37
include/vcl/pdfread.hxx|5 ++
sd/inc/Annotation.hxx | 31
sd/source/filter/pdf/sdpdffilter.cxx | 24 +
sd/source/ui/annotations/annotationtag.cxx | 37
svx/source/sdr/overlay/overlaypolypolygon.cxx | 46 +
vcl/source/filter/ipdf/pdfread.cxx | 41 +-
8 files changed, 224 insertions(+), 16 deletions(-)
New commits:
commit 52c2b0fefcd3743c266cccb321ae194fd00720a4
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 09:38:56 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:20:40 2020 +0200
sd: custom annotation marker and draw polygon annotation from PDF
This implements custom annotation marker, which overrides the
default marker drawing of comments in Draw/Impress. The
polygon is transported from the import of PDF to SdPdfFilter,
then the sd::Annotation is set-up, by settuing up the new class
CustomAnnotationMarker.
CustomAnnotationMarker also supports setting of the line color,
line width and fill color.
The OverlayPolyPolygon is the new class that is responsible for
the marker overlay, mainly to create the Primitive2D of the
marker, that will be shown on the screen.
This only implements Polygon PDF annotation sub-type.
Change-Id: Ic663c31c5b3db5c13179dde63c1a0b81159f4b80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104365
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/sdr/overlay/overlaypolypolygon.hxx
b/include/svx/sdr/overlay/overlaypolypolygon.hxx
index 4cb5c4610a00..d3aa2074d48f 100644
--- a/include/svx/sdr/overlay/overlaypolypolygon.hxx
+++ b/include/svx/sdr/overlay/overlaypolypolygon.hxx
@@ -25,7 +25,24 @@
namespace sdr::overlay
-{
+{
+class SVXCORE_DLLPUBLIC OverlayPolyPolygon final : public OverlayObject
+{
+private:
+basegfx::B2DPolyPolygon maLinePolyPolygon;
+double mfLineWidth;
+Color maFillColor;
+
+virtual drawinglayer::primitive2d::Primitive2DContainer
createOverlayObjectPrimitive2DSequence() override;
+
+public:
+explicit OverlayPolyPolygon(const basegfx::B2DPolyPolygon&
rLinePolyPolygon,
+Color const & rLineColor,
+double mfLineWidth,
+Color const & rFillColor);
+virtual ~OverlayPolyPolygon() override;
+};
+
class SVXCORE_DLLPUBLIC OverlayPolyPolygonStripedAndFilled final :
public OverlayObject
{
// geometry
diff --git a/include/vcl/pdf/PDFAnnotationMarker.hxx
b/include/vcl/pdf/PDFAnnotationMarker.hxx
new file mode 100644
index ..2cfbeaa3
--- /dev/null
+++ b/include/vcl/pdf/PDFAnnotationMarker.hxx
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#pragma once
+
+#include
+#include
+
+namespace vcl::pdf
+{
+struct VCL_DLLPUBLIC PDFAnnotationMarker
+{
+PDFAnnotationMarker()
+: mnWidth(0.0f)
+, maFillColor(COL_TRANSPARENT)
+{
+}
+
+float mnWidth;
+Color maFillColor;
+};
+
+struct VCL_DLLPUBLIC PDFAnnotationMarkerPolygon : public PDFAnnotationMarker
+{
+basegfx::B2DPolygon maPolygon;
+};
+
+} // namespace vcl::pdf
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/pdfread.hxx b/include/vcl/pdfread.hxx
index bffdb104da42..78bc4a305aed 100644
--- a/include/vcl/pdfread.hxx
+++ b/include/vcl/pdfread.hxx
@@ -13,11 +13,13 @@
#include
#include
#include
+#include
#include
#include
#include
#include
+#include
namespace com::sun::star::uno
{
@@ -43,7 +45,10 @@ struct PDFGraphicAnnotation
basegfx::B2DRectangle maRectangle; // In HMM
css::util::DateTime maDateTime;
+Color maColor;
+
pdf::PDFAnnotationSubType meSubType;
+std::shared_ptr mpMarker;
};
class PDFGraphicResult
diff --git a/sd/inc/Annotation.hxx b/sd/inc/Annotation.hxx
index 24eb09989aca..883512506c78 100644
--- a/sd/inc/Annotation.hxx
+++ b/sd/inc/Annotation.hxx
@@ -31,6 +31,10 @@
#include "drawdoc.hxx"
#include "sdpage.hxx"
#include "textapi.hxx"
+#include "sddllapi.h"
+
+#include
+#include
class SdrUndoAction;
@@ -62,7 +66,15 @@ void LOKCommentNotify(CommentNotificationType nType, const
SfxViewShell* pViewSh
void
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/PDFiumLibraryTest.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit cf9dd0ab74db5e1f97c20737290a55a30a8738e5
Author: Tomaž Vajngerl
AuthorDate: Thu Oct 15 09:07:31 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sun Oct 18 21:20:23 2020 +0200
pdfium: extend tests checking color and presence of interior color
Change-Id: I348aad7e93378777ce924af5813a08b846d7caf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104364
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/qa/cppunit/PDFiumLibraryTest.cxx
b/vcl/qa/cppunit/PDFiumLibraryTest.cxx
index bf4876770f2c..2ef9ba942f27 100644
--- a/vcl/qa/cppunit/PDFiumLibraryTest.cxx
+++ b/vcl/qa/cppunit/PDFiumLibraryTest.cxx
@@ -379,6 +379,8 @@ void PDFiumLibraryTest::testAnnotationsDifferentTypes()
CPPUNIT_ASSERT_EQUAL(0, pAnnotation->getObjectCount());
OUString aContentsString =
pAnnotation->getString(vcl::pdf::constDictionaryKeyContents);
CPPUNIT_ASSERT_EQUAL(OUString("Rectangle Text"), aContentsString);
+CPPUNIT_ASSERT_EQUAL(Color(0xFF, 0xE0, 0x00), pAnnotation->getColor());
+CPPUNIT_ASSERT_EQUAL(false,
pAnnotation->hasKey(vcl::pdf::constDictionaryKeyInteriorColor));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137579] New: Can't delete sheet while tracking changes
https://bugs.documentfoundation.org/show_bug.cgi?id=137579 Bug ID: 137579 Summary: Can't delete sheet while tracking changes Product: LibreOffice Version: 7.0.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yallabala...@gmail.com Description: When "Tracking Changes > Record" is turn on, all menus for removing a worksheet from a ODS file are disabled or hidden. This is particularly crazy, because the human don't know what's wrong, and the human goes to google, websites, writing questions, reading answers, writing comments, arguing with moderators, uninstalling librreoffice, reinstalling and upgradind libreoffice, restarting the computer, but SHE DOESN'T KNOW WHAT'S WRONG. Please don't make the human crazy. Don't disable menu options - just put a popup explaining the reason why this function was disabled. Gracias. Steps to Reproduce: 1. open Calc 2. add a worksheet 3. Edit > track changes > record (enable) 4. try to remove a worksheet. Actual Results: context menu option for deleting the option disappears. Top menu option is disabled. No explanation given. Expected Results: "delete sheet" menu option must be enabled no matter what. Reproducible: Always User Profile Reset: Yes Additional Info: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source solenv/clang-format
cui/source/customize/SvxToolbarConfigPage.cxx | 474 --
cui/source/inc/SvxToolbarConfigPage.hxx | 53 +-
solenv/clang-format/excludelist |2
3 files changed, 255 insertions(+), 274 deletions(-)
New commits:
commit 35fa77d0137350e69b17418e2bc33f1fa0be2efb
Author: Muhammet Kara
AuthorDate: Sun Oct 18 19:48:16 2020 +0300
Commit: Muhammet Kara
CommitDate: Sun Oct 18 20:57:51 2020 +0200
clang-format customize/SvxToolbarConfigPage
Change-Id: If9b3fcbaa8e900d73c8dd0e727b4059c3b30ac01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104485
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/cui/source/customize/SvxToolbarConfigPage.cxx
b/cui/source/customize/SvxToolbarConfigPage.cxx
index 740fa426feb0..57f78dcd6161 100644
--- a/cui/source/customize/SvxToolbarConfigPage.cxx
+++ b/cui/source/customize/SvxToolbarConfigPage.cxx
@@ -42,15 +42,19 @@
#include
-SvxToolbarConfigPage::SvxToolbarConfigPage(weld::Container* pPage,
weld::DialogController* pController, const SfxItemSet& rSet)
+SvxToolbarConfigPage::SvxToolbarConfigPage(weld::Container* pPage,
+ weld::DialogController* pController,
+ const SfxItemSet& rSet)
: SvxConfigPage(pPage, pController, rSet)
{
m_xGearBtn = m_xBuilder->weld_menu_button("toolbargearbtn");
m_xGearBtn->show();
m_xContainer->set_help_id(HID_SVX_CONFIG_TOOLBAR);
-m_xContentsListBox.reset(new
SvxToolbarEntriesListBox(m_xBuilder->weld_tree_view("toolcontents"), this));
-m_xDropTargetHelper.reset(new SvxConfigPageFunctionDropTarget(*this,
m_xContentsListBox->get_widget()));
+m_xContentsListBox.reset(
+new
SvxToolbarEntriesListBox(m_xBuilder->weld_tree_view("toolcontents"), this));
+m_xDropTargetHelper.reset(
+new SvxConfigPageFunctionDropTarget(*this,
m_xContentsListBox->get_widget()));
weld::TreeView& rTreeView = m_xContentsListBox->get_widget();
Size aSize(m_xFunctions->get_size_request());
@@ -58,44 +62,38 @@ SvxToolbarConfigPage::SvxToolbarConfigPage(weld::Container*
pPage, weld::DialogC
rTreeView.set_hexpand(true);
rTreeView.set_vexpand(true);
-rTreeView.set_help_id( HID_SVX_CONFIG_TOOLBAR_CONTENTS );
+rTreeView.set_help_id(HID_SVX_CONFIG_TOOLBAR_CONTENTS);
rTreeView.show();
-rTreeView.connect_changed(
-LINK( this, SvxToolbarConfigPage, SelectToolbarEntry ) );
-rTreeView.connect_popup_menu( LINK( this, SvxToolbarConfigPage,
ContentContextMenuHdl ) );
+rTreeView.connect_changed(LINK(this, SvxToolbarConfigPage,
SelectToolbarEntry));
+rTreeView.connect_popup_menu(LINK(this, SvxToolbarConfigPage,
ContentContextMenuHdl));
m_xFunctions->get_widget().connect_popup_menu(
-LINK( this, SvxToolbarConfigPage, FunctionContextMenuHdl ) );
+LINK(this, SvxToolbarConfigPage, FunctionContextMenuHdl));
-m_xTopLevelListBox->set_help_id ( HID_SVX_TOPLEVELLISTBOX );
-m_xSaveInListBox->set_help_id( HID_SVX_SAVE_IN );
-m_xMoveUpButton->set_help_id( HID_SVX_UP_TOOLBAR_ITEM );
-m_xMoveDownButton->set_help_id( HID_SVX_DOWN_TOOLBAR_ITEM );
-m_xDescriptionField->set_help_id ( HID_SVX_DESCFIELD );
+m_xTopLevelListBox->set_help_id(HID_SVX_TOPLEVELLISTBOX);
+m_xSaveInListBox->set_help_id(HID_SVX_SAVE_IN);
+m_xMoveUpButton->set_help_id(HID_SVX_UP_TOOLBAR_ITEM);
+m_xMoveDownButton->set_help_id(HID_SVX_DOWN_TOOLBAR_ITEM);
+m_xDescriptionField->set_help_id(HID_SVX_DESCFIELD);
-m_xCommandCategoryListBox->connect_changed(
-LINK( this, SvxToolbarConfigPage, SelectCategory ) );
+m_xCommandCategoryListBox->connect_changed(LINK(this,
SvxToolbarConfigPage, SelectCategory));
-m_xGearBtn->connect_selected(
-LINK( this, SvxToolbarConfigPage, GearHdl ) );
+m_xGearBtn->connect_selected(LINK(this, SvxToolbarConfigPage, GearHdl));
-m_xMoveUpButton->connect_clicked( LINK( this, SvxToolbarConfigPage,
MoveHdl) );
-m_xMoveDownButton->connect_clicked( LINK( this, SvxToolbarConfigPage,
MoveHdl) );
+m_xMoveUpButton->connect_clicked(LINK(this, SvxToolbarConfigPage,
MoveHdl));
+m_xMoveDownButton->connect_clicked(LINK(this, SvxToolbarConfigPage,
MoveHdl));
// Always enable Up and Down buttons
// added for issue i53677 by shizhoubo
m_xMoveDownButton->set_sensitive(true);
m_xMoveUpButton->set_sensitive(true);
-m_xAddCommandButton->connect_clicked( LINK( this, SvxToolbarConfigPage,
AddCommandHdl ) );
-m_xRemoveCommandButton->connect_clicked( LINK( this, SvxToolbarConfigPage,
RemoveCommandHdl ) );
+m_xAddCommandButton->connect_clicked(LINK(this, SvxToolbarConfigPage,
AddCommandHdl));
+m_xRemoveCommandButton->connect_clicked(LINK(this, SvxToolbarConfigPage,
RemoveCommandHdl));
-m_xInsertBtn->connect_selected(
-LINK( this, SvxToolbarConfigPage, InsertHdl ) );
-
[Libreoffice-commits] core.git: cui/source solenv/clang-format
cui/source/customize/SvxMenuConfigPage.cxx | 245 ++---
cui/source/inc/SvxMenuConfigPage.hxx | 47 ++---
solenv/clang-format/excludelist|2
3 files changed, 144 insertions(+), 150 deletions(-)
New commits:
commit e190529f40988bbeb23b7b3abaeca6900f96213f
Author: Muhammet Kara
AuthorDate: Sun Oct 18 18:55:37 2020 +0300
Commit: Muhammet Kara
CommitDate: Sun Oct 18 20:53:59 2020 +0200
clang-format customize/SvxMenuConfigPage
Change-Id: I9ad8012d31c8e727fa4c8c840f15a93ca47541cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104483
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/cui/source/customize/SvxMenuConfigPage.cxx
b/cui/source/customize/SvxMenuConfigPage.cxx
index d3fed61015a2..3181a78bbb07 100644
--- a/cui/source/customize/SvxMenuConfigPage.cxx
+++ b/cui/source/customize/SvxMenuConfigPage.cxx
@@ -36,13 +36,15 @@
#include
-SvxMenuConfigPage::SvxMenuConfigPage(weld::Container* pPage,
weld::DialogController* pController, const SfxItemSet& rSet, bool bIsMenuBar)
+SvxMenuConfigPage::SvxMenuConfigPage(weld::Container* pPage,
weld::DialogController* pController,
+ const SfxItemSet& rSet, bool bIsMenuBar)
: SvxConfigPage(pPage, pController, rSet)
, m_bIsMenuBar(bIsMenuBar)
{
m_xGearBtn = m_xBuilder->weld_menu_button("menugearbtn");
m_xGearBtn->show();
-m_xContentsListBox.reset(new
SvxMenuEntriesListBox(m_xBuilder->weld_tree_view("menucontents"), this));
+m_xContentsListBox.reset(
+new SvxMenuEntriesListBox(m_xBuilder->weld_tree_view("menucontents"),
this));
weld::TreeView& rTreeView = m_xContentsListBox->get_widget();
m_xDropTargetHelper.reset(new SvxConfigPageFunctionDropTarget(*this,
rTreeView));
rTreeView.connect_size_allocate(LINK(this, SvxMenuConfigPage,
MenuEntriesSizeAllocHdl));
@@ -53,36 +55,32 @@ SvxMenuConfigPage::SvxMenuConfigPage(weld::Container*
pPage, weld::DialogControl
rTreeView.set_vexpand(true);
rTreeView.show();
-rTreeView.connect_changed(
-LINK( this, SvxMenuConfigPage, SelectMenuEntry ) );
-rTreeView.connect_popup_menu( LINK( this, SvxMenuConfigPage,
ContentContextMenuHdl ) );
+rTreeView.connect_changed(LINK(this, SvxMenuConfigPage, SelectMenuEntry));
+rTreeView.connect_popup_menu(LINK(this, SvxMenuConfigPage,
ContentContextMenuHdl));
m_xFunctions->get_widget().connect_popup_menu(
-LINK( this, SvxMenuConfigPage, FunctionContextMenuHdl ) );
+LINK(this, SvxMenuConfigPage, FunctionContextMenuHdl));
m_xGearBtn->connect_selected(LINK(this, SvxMenuConfigPage, GearHdl));
m_xCommandCategoryListBox->connect_changed(LINK(this, SvxMenuConfigPage,
SelectCategory));
-m_xMoveUpButton->connect_clicked( LINK( this, SvxConfigPage, MoveHdl) );
-m_xMoveDownButton->connect_clicked( LINK( this, SvxConfigPage, MoveHdl) );
+m_xMoveUpButton->connect_clicked(LINK(this, SvxConfigPage, MoveHdl));
+m_xMoveDownButton->connect_clicked(LINK(this, SvxConfigPage, MoveHdl));
-m_xAddCommandButton->connect_clicked( LINK( this, SvxMenuConfigPage,
AddCommandHdl ) );
-m_xRemoveCommandButton->connect_clicked( LINK( this, SvxMenuConfigPage,
RemoveCommandHdl ) );
+m_xAddCommandButton->connect_clicked(LINK(this, SvxMenuConfigPage,
AddCommandHdl));
+m_xRemoveCommandButton->connect_clicked(LINK(this, SvxMenuConfigPage,
RemoveCommandHdl));
-m_xInsertBtn->connect_selected(
-LINK( this, SvxMenuConfigPage, InsertHdl ) );
-m_xModifyBtn->connect_selected(
-LINK( this, SvxMenuConfigPage, ModifyItemHdl ) );
-m_xResetBtn->connect_clicked(
-LINK( this, SvxMenuConfigPage, ResetMenuHdl ) );
+m_xInsertBtn->connect_selected(LINK(this, SvxMenuConfigPage, InsertHdl));
+m_xModifyBtn->connect_selected(LINK(this, SvxMenuConfigPage,
ModifyItemHdl));
+m_xResetBtn->connect_clicked(LINK(this, SvxMenuConfigPage, ResetMenuHdl));
// These operations are not possible on menus/context menus yet
m_xModifyBtn->remove_item("changeIcon");
m_xModifyBtn->remove_item("resetIcon");
m_xModifyBtn->remove_item("restoreItem");
-if ( !bIsMenuBar )
+if (!bIsMenuBar)
{
//TODO: Remove this when the gear button is implemented for context
menus
m_xGearBtn->set_sensitive(false);
@@ -102,7 +100,8 @@ void SvxMenuConfigPage::ListModified()
pEntries->clear();
for (int i = 0; i < m_xContentsListBox->n_children(); ++i)
-
pEntries->push_back(reinterpret_cast(m_xContentsListBox->get_id(i).toInt64()));
+pEntries->push_back(
+
reinterpret_cast(m_xContentsListBox->get_id(i).toInt64()));
GetSaveInData()->SetModified();
GetTopLevelSelection()->SetModified();
@@ -140,36 +139,32 @@ void SvxMenuConfigPage::Init()
m_xTopLevelListBox->set_active(0);
SelectElement();
-m_xCommandCategoryListBox->Init(
-
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234
--- Comment #3 from kleinesuniver...@gmx.de ---
When opening the attached ODT file in LibreOffice 7.1.0.2 the formula looks
like shown in attachment "Faulty Display of formula" (whatItIsLike.png) while
it should look like shown in attachment "Correct display of formula"
(whatItShouldBeLike.png)
The faulty display reads like this in LibreOffice:
{ int_1^2 3 over 4 = 5}
A correct display would read like this:
{ int_1^2 {3 over 4} = 5}
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/recentdocsviewitem.cxx |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) New commits: commit 6fc5ff12ad44334947f46c4dc52299f957e2d898 Author: Caolán McNamara AuthorDate: Sat Oct 17 20:12:25 2020 +0100 Commit: Caolán McNamara CommitDate: Sun Oct 18 20:49:40 2020 +0200 we can use Desktop::queryDispatch and avoid using getActiveFrame Change-Id: I5582b4d588e1e1b47cd8aef78e6e73b2dece9d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104471 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sfx2/source/control/recentdocsviewitem.cxx b/sfx2/source/control/recentdocsviewitem.cxx index 7fa4bfaeb508..fd6d06cf378a 100644 --- a/sfx2/source/control/recentdocsviewitem.cxx +++ b/sfx2/source/control/recentdocsviewitem.cxx @@ -180,16 +180,10 @@ void RecentDocsViewItem::OpenDocument() mrParentView.SetPointer(PointerStyle::Wait); Reference xDispatch; -Reference xDispatchProvider; css::util::URL aTargetURL; Sequence aArgsList; uno::Reference xDesktop = frame::Desktop::create(::comphelper::getProcessComponentContext()); -uno::Reference xActiveFrame = xDesktop->getActiveFrame(); - -//osl::ClearableMutexGuard aLock(m_aMutex); -xDispatchProvider.set(xActiveFrame, UNO_QUERY); -//aLock.clear(); aTargetURL.Complete = maURL; Reference xTrans(util::URLTransformer::create(::comphelper::getProcessComponentContext())); @@ -203,7 +197,7 @@ void RecentDocsViewItem::OpenDocument() aArgsList[1].Name = "AsTemplate"; aArgsList[1].Value <<= false; -xDispatch = xDispatchProvider->queryDispatch(aTargetURL, "_default", 0); +xDispatch = xDesktop->queryDispatch(aTargetURL, "_default", 0); if (!xDispatch.is()) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234 --- Comment #2 from kleinesuniver...@gmx.de --- Created attachment 166484 --> https://bugs.documentfoundation.org/attachment.cgi?id=166484=edit Correct display of formula -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137234] Faulty representation of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=137234 --- Comment #1 from kleinesuniver...@gmx.de --- Created attachment 166483 --> https://bugs.documentfoundation.org/attachment.cgi?id=166483=edit Faulty display of formula -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137571] Adding and modifying animations painfully slow
https://bugs.documentfoundation.org/show_bug.cgi?id=137571 --- Comment #2 from Eyal Rozenberg --- Created attachment 166482 --> https://bugs.documentfoundation.org/attachment.cgi?id=166482=edit A presentation for reproducing the bug 1. Open the presentation. 2. Duplicate the second-to-last slide. 3. Delete the existing animations. 4. Click the main text box. 5. Select-All (e.g. with Ctrl+A) 6. Press the animation addition green-Plus button LO will be stuck for a very long time - around a minute; at least, that's what I experience. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: lotuswordpro/Library_lwpft.mk lotuswordpro/source
lotuswordpro/Library_lwpft.mk |1 +
lotuswordpro/source/filter/lwprowlayout.cxx |7 ++-
lotuswordpro/source/filter/lwptablelayout.cxx | 19 ++-
lotuswordpro/source/filter/lwptablelayout.hxx | 10 ++
4 files changed, 19 insertions(+), 18 deletions(-)
New commits:
commit 473c1b05f7a7a5500a2e15b911263b546792b013
Author: Caolán McNamara
AuthorDate: Sat Oct 17 16:40:28 2020 +0100
Commit: Caolán McNamara
CommitDate: Sun Oct 18 20:07:48 2020 +0200
ofz#26357 Timeout in lwpfuzzer, 12s -> 1.3s
Change-Id: I1f1e2f1727b698d761adaf0d388d731fc80e280f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104467
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/lotuswordpro/Library_lwpft.mk b/lotuswordpro/Library_lwpft.mk
index f35568d3647b..e7536e9f7a64 100644
--- a/lotuswordpro/Library_lwpft.mk
+++ b/lotuswordpro/Library_lwpft.mk
@@ -37,6 +37,7 @@ $(eval $(call gb_Library_use_libraries,lwpft,\
$(eval $(call gb_Library_use_externals,lwpft,\
boost_headers \
+ mdds_headers \
icui18n \
icuuc \
icu_headers \
diff --git a/lotuswordpro/source/filter/lwprowlayout.cxx
b/lotuswordpro/source/filter/lwprowlayout.cxx
index 3321f294469e..9590e41d9670 100644
--- a/lotuswordpro/source/filter/lwprowlayout.cxx
+++ b/lotuswordpro/source/filter/lwprowlayout.cxx
@@ -238,9 +238,7 @@ void LwpRowLayout::ConvertRow(rtl::Reference const
& pXFTable,sal_uInt8
m_ConnCellList[nMarkConnCell]->GetColID());
//set all cell in this merge cell to cellsmap
-for (sal_uInt16 nRowLoop = crowid; nRowLoop < nRowMark; nRowLoop++)
-for (sal_uInt16 nColLoop = i; nColLoop < nColID+1; nColLoop++)
-pTableLayout->SetCellsMap(nRowLoop,nColLoop,
xXFCell.get());
+pTableLayout->SetCellsMap(crowid, i, nRowMark - 1, nColID,
xXFCell.get());
i += m_ConnCellList[nMarkConnCell]->GetNumcols();
nMarkConnCell =
FindNextMarkConnCell(static_cast(nMarkConnCell),nEndCol);
@@ -433,8 +431,7 @@ void LwpRowLayout::ConvertCommonRow(rtl::Reference
const & pXFTable, sa
}
xRow->AddCell(xCell);
-for (sal_uInt8 j=nCellStartCol;j<=nCellEndCol;j++)
-pTableLayout->SetCellsMap(crowid,j, xCell.get());//set to cellsmap
+pTableLayout->SetCellsMap(crowid, nCellStartCol, crowid, nCellEndCol,
xCell.get()); //set to cellsmap
}
pXFTable->AddRow(xRow);
diff --git a/lotuswordpro/source/filter/lwptablelayout.cxx
b/lotuswordpro/source/filter/lwptablelayout.cxx
index 5ea2d42db9a4..2494501ff3d9 100644
--- a/lotuswordpro/source/filter/lwptablelayout.cxx
+++ b/lotuswordpro/source/filter/lwptablelayout.cxx
@@ -1402,16 +1402,17 @@ void
LwpTableLayout::ConvertDefaultRow(rtl::Reference const & pXFTable,
pXFTable->AddRow(xRow);
}
+
/**
* @short set cell map info
* @param pXFCell - pointer to xfcell
* @param nRow - row id
* @param nCol - column id
*/
-void LwpTableLayout::SetCellsMap(sal_uInt16 nRow, sal_uInt8 nCol, XFCell*
pXFCell)
+void LwpTableLayout::SetCellsMap(sal_uInt16 nRow1, sal_uInt8 nCol1,
+ sal_uInt16 nRow2, sal_uInt8 nCol2, XFCell*
pXFCell)
{
-// combine the 16bit nRow and 8bit nCol into a single 32bit number
-m_CellsMap.insert(std::make_pair((nRow << 8) | nCol, pXFCell));
+m_CellsMap.insert({{nRow1, nCol1}, {nRow2, nCol2}}, pXFCell);
}
/**
@@ -1422,17 +1423,17 @@ void LwpTableLayout::SetCellsMap(sal_uInt16 nRow,
sal_uInt8 nCol, XFCell* pXFCel
*/
XFCell* LwpTableLayout::GetCellsMap(sal_uInt16 nRow, sal_uInt8 nCol)
{
-RowCol pos = (nRow << 8) | nCol;
-auto iter = m_CellsMap.find(pos);
-if (iter == m_CellsMap.end())
-return nullptr;
-return iter->second;
+auto results = m_CellsMap.search({{nRow, nCol}, {nRow, nCol}},
rt_type::search_type::overlap);
+if (results.begin() == results.end())
+ return nullptr;
+// return the last thing inserted for this position
+return *std::prev(results.end());
}
/**
* @descr Get row layout by row id
* @param nRow - row id
*/
- LwpRowLayout* LwpTableLayout::GetRowLayout(sal_uInt16 nRow)
+LwpRowLayout* LwpTableLayout::GetRowLayout(sal_uInt16 nRow)
{
LwpObjectID *pRowID = ();
LwpRowLayout * pRowLayout = dynamic_cast(pRowID->obj().get());
diff --git a/lotuswordpro/source/filter/lwptablelayout.hxx
b/lotuswordpro/source/filter/lwptablelayout.hxx
index 21ab84ec1c67..fe8312414587 100644
--- a/lotuswordpro/source/filter/lwptablelayout.hxx
+++ b/lotuswordpro/source/filter/lwptablelayout.hxx
@@ -64,10 +64,11 @@
#include "lwplayout.hxx"
#include
+#include
+
#include
#include
#include
-#include
class XFTableStyle;
class XFTable;
@@ -148,7 +149,7 @@ public:
void ConvertTable(rtl::Reference const & pXFTable, sal_uInt16
nStartRow,
sal_uInt16 nEndRow,sal_uInt8 nStartCol,sal_uInt8
[Libreoffice-bugs] [Bug 137561] LibreOffice Calc crashed when I attempt to change a formula using Find/Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=137561 --- Comment #2 from Carl --- I have made the test with LibreOffice in Safe Mode. The problem I was having yesterday did not reappear. That is the good news. Before I started LibreOffice in Safe Mode I navigated to the folders and files in my profile and was amazed at the number of objects there are in the AppData\Roaming\LibreOffice directory tree. I was not sure how to 'back-up' this profile, so I did not back it up. Now, it appears that my profile is corrupt and needs attention but I do not know where to begin. At Safe Mode startup there was a dialog that opened with options and one was to recover the profile from 'Last known good' but where is that? I appreciate that this application is complex and hope that the development team considered lame users, like myself, doing such foolish things and have a way for me to get LibreOffice Calc working like it did befor. Thank you very much for the instructions for using safe mode. I hope you will be able to help me fix my profile so the operations stabilize. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137472] Pasted .jpg does not show up in presentation mode (F5)
https://bugs.documentfoundation.org/show_bug.cgi?id=137472 --- Comment #9 from Axel Braun --- (In reply to Timur from comment #5) > If Gerald reproduced with 7.0 and not with 7.1,that's not New but WFM. > But, to be sure, Axel please test daily master, easiest from > https://libreoffice.soluzioniopen.com/daily-version/ Just for the record: With daily master as of 2020-10-15 it worked -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137575] UI: Custom sorting state is lost when reopening the LibreOffice file picker dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=137575 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #4 from V Stuart Foote --- Version: 7.1.0.0.alpha0+ (x64) Build ID: 6ccf4dd2224e4beb567365903249858a2ca00082 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Expert Configuration 'UseSystemFileDialog' set False by-passing VistaFilePickerImpl. Confirm sorting issues with LO internal file picker. Sort order reverts to A-Z sort on file name. And that the LO internal file picker previously retained the selected sort order. But is this really an issue? Use on all os/DE requires knowledge of Expert Configuration dialog and the 'UseSystemFileDialog' stanza to by-pass use of os/DE native File Picker? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137042] SQL Error -607, when changing Field type of a table (Firebird)
https://bugs.documentfoundation.org/show_bug.cgi?id=137042 --- Comment #4 from Richard Demattio --- (In reply to Robert Großkopf from comment #3) > First this error appears when changing Boolean field to Varchar: > Conversion from base type BOOLEAN to VARCHAR is not supported. > > When I confirm to delete the old Boolean field and add a new Varchar field > it will work here. So I could not confirm the buggy behavior. > > Tested with LO 7.0.2.2 on OpenSUSE 15.1 64bit rpm Linux I agree - it is stupid, changing VARCHAR to BOOLEAN and the other way round. Your way makes more sense. But what I did must not lead to a crash, but should be prohibited by logic. In general: rejecting forbidden conversions by logic will increase stability. Such kind of inputs can happen accidentally. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137522] Ability to save settings for importing data to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=137522 --- Comment #2 from Frants <220...@mail.ru> --- Yes, you are right, my proposal is not relevant. You mean the import path is Sheet -> Link to External Data? Still, an ordinary user needs to know about this path. Not all users know about this when they use the File → Open (* .txt) path. For example, in the question "How to remove automatic field separators in text import in Calc". In such a case, in the "Text Import" window, a link or option for using the "Sheet -> Link to External Data" mechanism would be useful. Maybe it would improve usability? https://ask.libreoffice.org/en/question/211141/how-to-remove-automatic-field-separators-in-text-import-in-calc/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137042] SQL Error -607, when changing Field type of a table (Firebird)
https://bugs.documentfoundation.org/show_bug.cgi?id=137042 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #3 from Robert Großkopf --- First this error appears when changing Boolean field to Varchar: Conversion from base type BOOLEAN to VARCHAR is not supported. When I confirm to delete the old Boolean field and add a new Varchar field it will work here. So I could not confirm the buggy behavior. Tested with LO 7.0.2.2 on OpenSUSE 15.1 64bit rpm Linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137566] FIREBIRD: some errors during - create Table and insert records via menue "tools/SQL"
https://bugs.documentfoundation.org/show_bug.cgi?id=137566 Robert Großkopf changed: What|Removed |Added Status|UNCONFIRMED |NEW Summary|LO base: some errors during |FIREBIRD: some errors |- create Table and insert |during - create Table and |records via menue |insert records via menue |"tools/SQL" |"tools/SQL" Ever confirmed|0 |1 Version|7.1.0.0.alpha0+ Master |7.0.2.2 release CC||rob...@familiegrosskopf.de --- Comment #4 from Robert Großkopf --- Could confirm this buggy behavior for the internal Firebird database on OpenSuse 15.1 64bit rpm Linux an LO 7.0.2.2. The code will work well with internal Hsqldb. So a special internal Firebird bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137421] Export as PDF misses fonts even if exported as PDF/A
https://bugs.documentfoundation.org/show_bug.cgi?id=137421 --- Comment #6 from Robert Großkopf --- Bug 50879 has been fixed for LO 7.1. I think this one is a duplicate. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 130711, which changed state. Bug 130711 Summary: [tr] Extend Autocorrect list for Turkish language https://bugs.documentfoundation.org/show_bug.cgi?id=130711 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source solenv/clang-format
cui/source/customize/SvxConfigPageHelper.cxx | 224 ---
cui/source/inc/SvxConfigPageHelper.hxx | 77 +++--
solenv/clang-format/excludelist |2
3 files changed, 132 insertions(+), 171 deletions(-)
New commits:
commit 11485a500196af7a2533787f4faf32e14693f480
Author: Muhammet Kara
AuthorDate: Sun Oct 18 17:15:45 2020 +0300
Commit: Muhammet Kara
CommitDate: Sun Oct 18 17:43:53 2020 +0200
clang-format customize/SvxConfigPageHelper
Change-Id: Ia802bfc4a6cd8d970fbb3c37a55959729ea19257
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104481
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/cui/source/customize/SvxConfigPageHelper.cxx
b/cui/source/customize/SvxConfigPageHelper.cxx
index 033219f4d9a0..d54bb7cdaf1a 100644
--- a/cui/source/customize/SvxConfigPageHelper.cxx
+++ b/cui/source/customize/SvxConfigPageHelper.cxx
@@ -27,52 +27,43 @@
#include
#include
-static sal_Int16 theImageType =
-css::ui::ImageType::COLOR_NORMAL |
-css::ui::ImageType::SIZE_DEFAULT;
+static sal_Int16 theImageType = css::ui::ImageType::COLOR_NORMAL |
css::ui::ImageType::SIZE_DEFAULT;
-void SvxConfigPageHelper::RemoveEntry( SvxEntries* pEntries, SvxConfigEntry
const * pChildEntry )
+void SvxConfigPageHelper::RemoveEntry(SvxEntries* pEntries, SvxConfigEntry
const* pChildEntry)
{
SvxEntries::iterator iter = pEntries->begin();
-while ( iter != pEntries->end() )
+while (iter != pEntries->end())
{
-if ( pChildEntry == *iter )
+if (pChildEntry == *iter)
{
-pEntries->erase( iter );
+pEntries->erase(iter);
break;
}
++iter;
}
}
-OUString SvxConfigPageHelper::replaceSaveInName( const OUString& rMessage,
const OUString& rSaveInName )
+OUString SvxConfigPageHelper::replaceSaveInName(const OUString& rMessage,
+const OUString& rSaveInName)
{
OUString name = rMessage.replaceFirst("%SAVE IN SELECTION%", rSaveInName);
return name;
}
-OUString SvxConfigPageHelper::stripHotKey( const OUString& str )
-{
-return str.replaceFirst("~", "");
-}
+OUString SvxConfigPageHelper::stripHotKey(const OUString& str) { return
str.replaceFirst("~", ""); }
-OUString SvxConfigPageHelper::replaceSixteen( const OUString& str, sal_Int32
nReplacement )
+OUString SvxConfigPageHelper::replaceSixteen(const OUString& str, sal_Int32
nReplacement)
{
-return str.replaceAll( OUString::number( 16 ), OUString::number(
nReplacement ));
+return str.replaceAll(OUString::number(16),
OUString::number(nReplacement));
}
-sal_Int16 SvxConfigPageHelper::GetImageType()
-{
-return theImageType;
-}
+sal_Int16 SvxConfigPageHelper::GetImageType() { return theImageType; }
void SvxConfigPageHelper::InitImageType()
{
-theImageType =
-css::ui::ImageType::COLOR_NORMAL |
-css::ui::ImageType::SIZE_DEFAULT;
+theImageType = css::ui::ImageType::COLOR_NORMAL |
css::ui::ImageType::SIZE_DEFAULT;
if (SvtMiscOptions().GetCurrentSymbolsSize() == SFX_SYMBOLS_SIZE_LARGE)
{
@@ -84,30 +75,29 @@ void SvxConfigPageHelper::InitImageType()
}
}
-css::uno::Reference< css::graphic::XGraphic > SvxConfigPageHelper::GetGraphic(
-const css::uno::Reference< css::ui::XImageManager >& xImageManager,
-const OUString& rCommandURL )
+css::uno::Reference
+SvxConfigPageHelper::GetGraphic(const
css::uno::Reference& xImageManager,
+const OUString& rCommandURL)
{
-css::uno::Reference< css::graphic::XGraphic > result;
+css::uno::Reference result;
-if ( xImageManager.is() )
+if (xImageManager.is())
{
// TODO handle large graphics
-css::uno::Sequence< css::uno::Reference< css::graphic::XGraphic > >
aGraphicSeq;
+css::uno::Sequence>
aGraphicSeq;
-css::uno::Sequence aImageCmdSeq { rCommandURL };
+css::uno::Sequence aImageCmdSeq{ rCommandURL };
try
{
-aGraphicSeq =
-xImageManager->getImages( GetImageType(), aImageCmdSeq );
+aGraphicSeq = xImageManager->getImages(GetImageType(),
aImageCmdSeq);
-if ( aGraphicSeq.hasElements() )
+if (aGraphicSeq.hasElements())
{
-result = aGraphicSeq[0];
+result = aGraphicSeq[0];
}
}
-catch ( css::uno::Exception& )
+catch (css::uno::Exception&)
{
// will return empty XGraphic
}
@@ -116,22 +106,19 @@ css::uno::Reference< css::graphic::XGraphic >
SvxConfigPageHelper::GetGraphic(
return result;
}
-OUString
-SvxConfigPageHelper::generateCustomName(
-const OUString& prefix,
-SvxEntries* entries,
-sal_Int32 suffix /*= 1*/ )
+OUString SvxConfigPageHelper::generateCustomName(const OUString& prefix,
SvxEntries* entries,
+
[Libreoffice-bugs] [Bug 137578] New: Entering chart data labels on a Pie Chart distorts the Pie Chart display
https://bugs.documentfoundation.org/show_bug.cgi?id=137578 Bug ID: 137578 Summary: Entering chart data labels on a Pie Chart distorts the Pie Chart display Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ken.no...@hotmail.com Description: When inserting a pie chart into a Calc Spreadsheet the chart displays OK until the data labels are added to the chart. It looks fine in edit mode but as soon as you leave edit mode the chart area compresses and the chart is distorted. This only seems to affect new chart inser tions - existing charts displayed in the same sheet are not affected, although none of them has been edited. This bug has only appeared in the latest version of LibreOffice which I downloaded recently. The Version of LibreOffice that I am running is 7.0.0.3 Steps to Reproduce: 1.Insert menu insert chart 2.Add Pie Chart, select data range, select series add title Finish 3.Right click inserted chart, edit. 4. Right click on the pie chart, select Insert Data Labels (data labels appear 5. Leave edit mode by clicking on a cell outrside chart area - chart shrinks vertically and distorts. Actual Results: Distorted charts in sheet display Expected Results: Inserted chart is correct - but display is distorted Reproducible: Always User Profile Reset: No Additional Info: Exited the edit mode and left chart as correctly displayed in edit mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
