[Libreoffice-bugs] [Bug 143592] New: Keep ratio doesn't do anything for a shape (get's unchecked after re-opening dialog)
https://bugs.documentfoundation.org/show_bug.cgi?id=143592 Bug ID: 143592 Summary: Keep ratio doesn't do anything for a shape (get's unchecked after re-opening dialog) Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Keep ratio doesn't do anything for a shape (get's unchecked after re-opening dialog) Steps to Reproduce: 1. Open Writer 2. Draw a rectangle 3. Right click the shape.. 4. Position and size -> Position and size tab 5. Check keep ratio 6. Press OK 7. Step 3/4 -> notice keep ratio being unchecked Actual Results: Unchecked keep ratio Expected Results: Checked Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/parclass.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 56cebfdbce89e7400a89678d14b847243e88f971 Author: Eike Rathke AuthorDate: Wed Jul 28 18:36:51 2021 +0200 Commit: Eike Rathke CommitDate: Wed Jul 28 20:08:46 2021 +0200 Keep ScParameterClassification sorted, tdf#76310 follow-up Change-Id: Ib1441b0668abbf50a46416b32292160eb8995ba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119636 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx index 6c560b07b42f..eca9d204855a 100644 --- a/sc/source/core/tool/parclass.cxx +++ b/sc/source/core/tool/parclass.cxx @@ -74,7 +74,6 @@ const ScParameterClassification::RawData ScParameterClassification::pRawData[] = { ocSep, {{ Bounds }, 0, Bounds }}, { ocSkip,{{ Bounds }, 0, Bounds }}, { ocSpaces, {{ Bounds }, 0, Bounds }}, -{ ocWhitespace, {{ Bounds }, 0, Bounds }}, { ocStop,{{ Bounds }, 0, Bounds }}, { ocStringXML, {{ Bounds }, 0, Bounds }}, { ocTableRef,{{ Bounds }, 0, Value }},// or Reference? @@ -263,6 +262,7 @@ const ScParameterClassification::RawData ScParameterClassification::pRawData[] = { ocVarPA, {{ ReferenceOrRefArray }, 1, Value }}, { ocVarP_MS, {{ Reference }, 1, Value }}, { ocVarS,{{ Reference }, 1, Value }}, +{ ocWhitespace, {{ Bounds }, 0, Bounds }}, { ocWorkday_MS, {{ Value, Value, Value, Reference }, 0, Value }}, { ocXor, {{ Reference }, 1, Value }}, { ocZTest, {{ Reference, Value, Value }, 0, Value }}, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137072] The SunSet background of Impress template is to prominent in edit mode (fine in presentation mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=137072 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Telesto --- Assuming WFM. Not seeing any issue Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143591] Image frame anchor changes from 'to character' to "to paragraph anchoring' on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=143591 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143591] Image frame anchor changes from 'to character' to "to paragraph anchoring' on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=143591 --- Comment #1 from Telesto --- Created attachment 173932 --> https://bugs.documentfoundation.org/attachment.cgi?id=173932=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143591] New: Image frame anchor changes from 'to character' to "to paragraph anchoring' on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=143591 Bug ID: 143591 Summary: Image frame anchor changes from 'to character' to "to paragraph anchoring' on DOCX export Product: LibreOffice Version: 4.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Image frame anchor changes from 'to character' to "to paragraph anchoring'.. which weird because Word doesn't even support 'to paragraph' anchoring.. It's fine with DOC Steps to Reproduce: 1. open the attached file 2. Select the frame 3. Right click -> Look at the anchor ('to character') 4. Save as DOCX 5. File reload 7. Right click the image frame: Look at the anchor -> To paragraph. Anchor is also be seen at the start of the page when selecting the frame Actual Results: To paragraph achoring Expected Results: To character anchoring Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL and in 4.4.7.2 and in 4.3 not in 4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112293] Fileopen: 2007 DOCX shows ADDIN ZOTERO_ITEM instead of notes (if saved again in MSO opens fine)
https://bugs.documentfoundation.org/show_bug.cgi?id=112293 --- Comment #8 from NISZ LibreOffice Team --- Created attachment 173931 --> https://bugs.documentfoundation.org/attachment.cgi?id=173931=edit The example file in Word and in the bibisected 7.2 version -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120351] Writer hangs for over 20 minutes loading a 3MB, 450-page DOCX Edit with thousands of endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=120351 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2293 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 Bug 109195 depends on bug 112293, which changed state. Bug 112293 Summary: Fileopen: 2007 DOCX shows ADDIN ZOTERO_ITEM instead of notes (if saved again in MSO opens fine) https://bugs.documentfoundation.org/show_bug.cgi?id=112293 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112293] Fileopen: 2007 DOCX shows ADDIN ZOTERO_ITEM instead of notes (if saved again in MSO opens fine)
https://bugs.documentfoundation.org/show_bug.cgi?id=112293 NISZ LibreOffice Team changed: What|Removed |Added CC||libreoff...@nisz.hu, ||nem...@numbertext.org Resolution|--- |FIXED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0351 Status|NEW |RESOLVED --- Comment #7 from NISZ LibreOffice Team --- I don't see the problem anymore in 7.2 since: https://git.libreoffice.org/core/+/7dd8f8aace536a8e60e87e61ee1d90d61fba15eb author László NémethWed Feb 17 09:47:43 2021 +0100 committer László NémethThu Feb 18 13:30:55 2021 +0100 tdf#120351 DOCX import: fix slow endnote import -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142584] Filesave PPT: Text highlighting color doesn't save and reopen well
https://bugs.documentfoundation.org/show_bug.cgi?id=142584 Екатерина changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Екатерина --- confirm in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: cb2827f5f65324f309fa0e3c30d0b19ad237410e CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142863] Complete reset of the program to initial default settings, no history
https://bugs.documentfoundation.org/show_bug.cgi?id=142863 Екатерина changed: What|Removed |Added Ever confirmed|0 |1 CC||katyalukkar...@gmail.com Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Екатерина --- Could you be more specific about the steps to reproduce the bug. The second step is not clearly described. which requires a reboot: the entire system or only Libreoffice. And one more thing: how many times do you need to turn the sleep function on and off? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/accessibility/XAccessibleValue.idl |2 ++ 1 file changed, 2 insertions(+) New commits: commit 968e758f163ef5a6c8c46e3427fccae32958b6db Author: Michael Weghorn AuthorDate: Wed Jul 28 16:20:57 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 19:14:45 2021 +0200 XAccessibleValue::getMinimumIncrement: Add "@since" annotation Add "@since LibreOffice 7.3" annotation for the method added in commit b5ada12ffd0b6b8677430fce117c4c1e38cc9159 Author: Michael Weghorn Date: Wed Jul 28 11:26:16 2021 +0200 a11y: Add XAccessibleValue::getMinimumIncrement method Thanks to Stephan for pointing it out in above commit's Gerrit change. [1] [1] https://gerrit.libreoffice.org/c/core/+/119596 Change-Id: I416653ea5ebf3a09effead2d132db340d08e6c53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119634 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/offapi/com/sun/star/accessibility/XAccessibleValue.idl b/offapi/com/sun/star/accessibility/XAccessibleValue.idl index a1f7879dcd07..45001976fd0d 100644 --- a/offapi/com/sun/star/accessibility/XAccessibleValue.idl +++ b/offapi/com/sun/star/accessibility/XAccessibleValue.idl @@ -101,6 +101,8 @@ interface XAccessibleValue : ::com::sun::star::uno::XInterface Returns the minimal increment value in an implementation dependent type. If this object has no minimum increment value, then an empty object is returned. + +@since LibreOffice 7.3 */ any getMinimumIncrement (); }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7853a8018eb2c44f4374e8286e45e4e281ca43e7 Author: Stanislav Horacek AuthorDate: Wed Jul 28 19:12:46 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Jul 28 19:12:46 2021 +0200 Update git submodules * Update dictionaries from branch 'libreoffice-7-2' to 447a883184eaa8643fd6ae9a85ca64ef1d912d35 - Czech Hunspell: add several word forms Change-Id: I227d4fe75539691c75323ffcc822545081ced9ae Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119643 Tested-by: Stanislav Horáček Reviewed-by: Stanislav Horáček diff --git a/dictionaries b/dictionaries index b6f494a9946d..447a883184ea 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit b6f494a9946de2899acf22c843ef7386d09a5cf4 +Subproject commit 447a883184eaa8643fd6ae9a85ca64ef1d912d35 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-7-2' - cs_CZ/cs_CZ.dic
cs_CZ/cs_CZ.dic |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 447a883184eaa8643fd6ae9a85ca64ef1d912d35 Author: Stanislav Horacek AuthorDate: Wed Jul 28 18:58:38 2021 +0200 Commit: Stanislav Horáček CommitDate: Wed Jul 28 19:12:46 2021 +0200 Czech Hunspell: add several word forms Change-Id: I227d4fe75539691c75323ffcc822545081ced9ae Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119643 Tested-by: Stanislav Horáček Reviewed-by: Stanislav Horáček diff --git a/cs_CZ/cs_CZ.dic b/cs_CZ/cs_CZ.dic index 00c4f22..eef8d83 100644 --- a/cs_CZ/cs_CZ.dic +++ b/cs_CZ/cs_CZ.dic @@ -1,4 +1,4 @@ -261164 +261167 a AACR áách @@ -39102,6 +39102,7 @@ džínsech džínsů džínsům džínsy +džínů džíny/ZQ džíp/H džob/H @@ -110502,6 +110503,7 @@ Mjartanová/Y mjr. MK MKS +ml ml. mlácení/SN mlácený/YKRN @@ -212161,7 +212163,6 @@ tapisérie/Z ťapkat/JN ťapkávání/SN ťapkávat/JN -taplákách ťápnout/ATN ťápnutí/SN ťápnutý/YKRN @@ -213375,6 +213376,7 @@ tepláčků tepláčkům tepláčky teplající/YN +teplákách teplákový/YKRN tepláky/H Teplan/PV @@ -223683,7 +223685,7 @@ Urzidil/PV Urzidilová/Y urzon/PI Úř. -úřad/H +úřad/HR úřada/PV úřadování/SN úřadovaný/YKRN @@ -245407,6 +245409,7 @@ zacyklovat/ATN zacyklovávání/SN zacyklovávaný/YKRN zacyklovávat/JTN +zač zač. začaděný/YKRN začadit/ACN ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143114] Libclplug: kf5 support errors
https://bugs.documentfoundation.org/show_bug.cgi?id=143114 --- Comment #11 from Armin Le Grand --- Really hard to debug/change stuff here, but I made some progress and using kf5 it's already pretty good. Thus I created https://gerrit.libreoffice.org/c/core/+/119644 as a suggestion/first step to enhance this situation. As described there, the behavior is also dependent on the UI implementation used under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all (unfortunately) behaving differently... :-( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138625] The footnote number in an imported word text is not in a superscript, like in the original.
https://bugs.documentfoundation.org/show_bug.cgi?id=138625 --- Comment #13 from NISZ LibreOffice Team --- Created attachment 173930 --> https://bugs.documentfoundation.org/attachment.cgi?id=173930=edit The example file in current master, hu-HU UI Less so in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL There might be something funny with importing the localized (or not) character style names. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138625] The footnote number in an imported word text is not in a superscript, like in the original.
https://bugs.documentfoundation.org/show_bug.cgi?id=138625 --- Comment #12 from NISZ LibreOffice Team --- Created attachment 173929 --> https://bugs.documentfoundation.org/attachment.cgi?id=173929=edit The example file in current master, en_US UI Looks good in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 72773c8e547ee42922bf32a861bb4ae13858169d Author: Stanislav Horacek AuthorDate: Wed Jul 28 19:02:59 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Jul 28 19:02:59 2021 +0200 Update git submodules * Update dictionaries from branch 'master' to b3a1c0be50d1ad0b404070124463fb4af90bbe39 - Czech Hunspell: add several word forms Change-Id: I227d4fe75539691c75323ffcc822545081ced9ae Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119637 Tested-by: Stanislav Horáček Reviewed-by: Stanislav Horáček diff --git a/dictionaries b/dictionaries index 748ec6b4e01e..b3a1c0be50d1 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 748ec6b4e01e0bc17f05b3171abb02d61401c096 +Subproject commit b3a1c0be50d1ad0b404070124463fb4af90bbe39 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: cs_CZ/cs_CZ.dic
cs_CZ/cs_CZ.dic |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit b3a1c0be50d1ad0b404070124463fb4af90bbe39 Author: Stanislav Horacek AuthorDate: Wed Jul 28 18:58:38 2021 +0200 Commit: Stanislav Horáček CommitDate: Wed Jul 28 19:02:59 2021 +0200 Czech Hunspell: add several word forms Change-Id: I227d4fe75539691c75323ffcc822545081ced9ae Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119637 Tested-by: Stanislav Horáček Reviewed-by: Stanislav Horáček diff --git a/cs_CZ/cs_CZ.dic b/cs_CZ/cs_CZ.dic index 00c4f22..eef8d83 100644 --- a/cs_CZ/cs_CZ.dic +++ b/cs_CZ/cs_CZ.dic @@ -1,4 +1,4 @@ -261164 +261167 a AACR áách @@ -39102,6 +39102,7 @@ džínsech džínsů džínsům džínsy +džínů džíny/ZQ džíp/H džob/H @@ -110502,6 +110503,7 @@ Mjartanová/Y mjr. MK MKS +ml ml. mlácení/SN mlácený/YKRN @@ -212161,7 +212163,6 @@ tapisérie/Z ťapkat/JN ťapkávání/SN ťapkávat/JN -taplákách ťápnout/ATN ťápnutí/SN ťápnutý/YKRN @@ -213375,6 +213376,7 @@ tepláčků tepláčkům tepláčky teplající/YN +teplákách teplákový/YKRN tepláky/H Teplan/PV @@ -223683,7 +223685,7 @@ Urzidil/PV Urzidilová/Y urzon/PI Úř. -úřad/H +úřad/HR úřada/PV úřadování/SN úřadovaný/YKRN @@ -245407,6 +245409,7 @@ zacyklovat/ATN zacyklovávání/SN zacyklovávaný/YKRN zacyklovávat/JTN +zač zač. začaděný/YKRN začadit/ACN ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94587] [META] ODF features missing or incorrectly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=94587 Bug 94587 depends on bug 76310, which changed state. Bug 76310 Summary: ODF incompliance: Cannot use newline in formula https://bugs.documentfoundation.org/show_bug.cgi?id=76310 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: formula/source include/formula offapi/com sc/inc sc/source
formula/source/core/api/FormulaCompiler.cxx| 29 +++- formula/source/core/api/token.cxx | 39 +- formula/source/ui/dlg/formula.cxx |8 - include/formula/compiler.hxx | 41 +++--- include/formula/opcode.hxx |2 include/formula/token.hxx | 20 +++ offapi/com/sun/star/sheet/FormulaMapGroupSpecialOffset.idl | 24 +++- sc/inc/compiler.hxx| 20 +++ sc/source/core/tool/compiler.cxx | 78 + sc/source/core/tool/parclass.cxx |1 sc/source/core/tool/token.cxx | 18 ++- sc/source/filter/excel/xeformula.cxx |8 + sc/source/filter/excel/xlformula.cxx |5 sc/source/ui/app/inputhdl.cxx |2 sc/source/ui/unoobj/tokenuno.cxx | 13 ++ sc/source/ui/view/viewfunc.cxx |2 16 files changed, 240 insertions(+), 70 deletions(-) New commits: commit 516318113f0bd2b3c658aba9b285165e63a280e2 Author: Eike Rathke AuthorDate: Wed Jul 28 17:31:56 2021 +0200 Commit: Eike Rathke CommitDate: Wed Jul 28 18:56:29 2021 +0200 Resolves: tdf#76310 Preserve whitespace TAB, CR, LF in formula expressions Allowed whitespace in ODFF and OOXML are U+0020 SPACE U+0009 CHARACTER TABULATION U+000A LINE FEED U+000D CARRIAGE RETURN Line feed and carriage return look a bit funny in the Function Wizard if part of a function's argument but work. Once a formula is edited, CR are converted to LF though, probably already in EditEngine, didn't investigate. Change-Id: I6278f6be48872e0710a3d74212db391dda249ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119635 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index be5ce09d132f..f7174807f0f4 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -475,7 +475,8 @@ uno::Sequence< sheet::FormulaOpCodeMapEntry > FormulaCompiler::OpCodeMap::create { FormulaMapGroupSpecialOffset::DB_AREA , ocDBArea } , /* TODO: { FormulaMapGroupSpecialOffset::TABLE_REF , ocTableRef } , */ { FormulaMapGroupSpecialOffset::MACRO , ocMacro } , -{ FormulaMapGroupSpecialOffset::COL_ROW_NAME , ocColRowName } +{ FormulaMapGroupSpecialOffset::COL_ROW_NAME , ocColRowName } , +{ FormulaMapGroupSpecialOffset::WHITESPACE, ocWhitespace } }; const size_t nCount = SAL_N_ELEMENTS(aMap); // Preallocate vector elements. @@ -1267,14 +1268,18 @@ bool FormulaCompiler::GetToken() nWasColRowName = 1; else nWasColRowName = 0; +OpCode eTmpOp; mpToken = maArrIterator.Next(); -while( mpToken && mpToken->GetOpCode() == ocSpaces ) +while (mpToken && ((eTmpOp = mpToken->GetOpCode()) == ocSpaces || eTmpOp == ocWhitespace)) { -// For significant whitespace remember last ocSpaces token. Usually -// there's only one even for multiple spaces. -pSpacesToken = mpToken; -if ( nWasColRowName ) -nWasColRowName++; +if (eTmpOp == ocSpaces) +{ +// For significant whitespace remember last ocSpaces token. +// Usually there's only one even for multiple spaces. +pSpacesToken = mpToken; +if ( nWasColRowName ) +nWasColRowName++; +} if ( bAutoCorrect && !pStack ) CreateStringFromToken( aCorrectedFormula, mpToken.get() ); mpToken = maArrIterator.Next(); @@ -2272,10 +2277,10 @@ const FormulaToken* FormulaCompiler::CreateStringFromToken( OUStringBuffer& rBuf if( bSpaces ) rBuffer.append( ' '); -if( eOp == ocSpaces ) +if (eOp == ocSpaces || eOp == ocWhitespace) { bool bWriteSpaces = true; -if (mxSymbols->isODFF()) +if (eOp == ocSpaces && mxSymbols->isODFF()) { const FormulaToken* p = maArrIterator.PeekPrevNoSpaces(); bool bIntersectionOp = (p && p->GetOpCode() == ocColRowName); @@ -2316,7 +2321,10 @@ const FormulaToken* FormulaCompiler::CreateStringFromToken( OUStringBuffer& rBuf sal_uInt8 n = t->GetByte(); for ( sal_uInt8 j=0; jGetChar()); +else +rBuffer.append( ' '); } } } @@ -2403,6 +2411,7 @@ const FormulaToken*
[Libreoffice-bugs] [Bug 143590] New: Aspect ratio of pasted screenshot changes although it should not do so
https://bugs.documentfoundation.org/show_bug.cgi?id=143590 Bug ID: 143590 Summary: Aspect ratio of pasted screenshot changes although it should not do so Product: LibreOffice Version: 7.2.0.0 alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de Created attachment 173928 --> https://bugs.documentfoundation.org/attachment.cgi?id=173928=edit file describes the bug and shows it practically This bug report pertains to Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: e0c4cdf9a874bb40f028a26562e6399d39cb2c0f CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-29_20:31:52 Calc: threaded When I paste a screenshot from the clipboard into a LibreOffice Writer document, it happens anchored "at the character" these days. But I would rather anchor images to the paragraph. Therefore it often happens that I double-click the image immediately and then first lock the aspect ratio, then anchor the image to the paragraph and then manually make sure both times that it says the vertical and horizontal position relative to the paragraph text should apply (I would prefer it it was preset such that this selection shown in the next image is always the right away. I have to do it by hand every time). The last step is usually to resize the width of the screenshot to a certain number of cm, e.g. 14 cm in the screenshot above. The aspect ratio of this screenshot got wrong! In the development version it often happens that the width is taken over, but the height linked with it is not adapted to the new width! So the aspect ratio gets mixed up. I have the impression that the image is often one and a half to two times as high as it should be, but I may be wrong with that. This error was not in earlier versions of LO Writer! It must be new. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/cppunittester sal/Executable_cppunittester.mk
sal/Executable_cppunittester.mk |6 sal/cppunittester/cppunittester.cxx | 284 +--- 2 files changed, 211 insertions(+), 79 deletions(-) New commits: commit 24b06b9c6bdb777dff385b0fbfc81d55d3d013a1 Author: Noel Grandin AuthorDate: Tue Jul 27 15:15:21 2021 +0200 Commit: Noel Grandin CommitDate: Wed Jul 28 18:34:08 2021 +0200 log access violation on windows tinderboxen where we currently have no good feedback when something goes wrong. Credit: Exception printing code written by msdn-whiteknight as seen at https://stackoverflow.com/questions/22467604/how-can-you-use-capturestackbacktrace-to-capture-the-exception-stack-not-the-ca Change-Id: I44c65b10c0b0151c3236521d62a824570d4cdccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119561 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sal/Executable_cppunittester.mk b/sal/Executable_cppunittester.mk index 3b9016783b80..959b3cd8be47 100644 --- a/sal/Executable_cppunittester.mk +++ b/sal/Executable_cppunittester.mk @@ -28,6 +28,12 @@ $(eval $(call gb_Executable_add_exception_objects,cppunittester,\ sal/cppunittester/cppunittester \ )) +ifneq ($(strip $(debug)$(DEBUG)),) +$(eval $(call gb_Executable_use_system_win32_libs,cppunittester,\ + dbghelp \ +)) +endif + ifeq ($(COM),MSC) $(eval $(call gb_Executable_add_ldflags,cppunittester,\ diff --git a/sal/cppunittester/cppunittester.cxx b/sal/cppunittester/cppunittester.cxx index 7ab54da02106..c899f320ad0c 100644 --- a/sal/cppunittester/cppunittester.cxx +++ b/sal/cppunittester/cppunittester.cxx @@ -23,6 +23,9 @@ #endif #include #endif +#if defined(_WIN32) && defined(_DEBUG) +#include "dbghelp.h" +#endif #ifdef UNX #include @@ -378,109 +381,232 @@ void reportResourceUsage([[maybe_unused]] const OUString& /*rPath*/) } -SAL_IMPLEMENT_MAIN() +static bool main2() { bool ok = false; OUString path; -try -{ + #ifdef _WIN32 -//Disable Dr-Watson in order to crash simply without popup dialogs under -//windows -DWORD dwMode = SetErrorMode(SEM_NOGPFAULTERRORBOX); -SetErrorMode(SEM_NOGPFAULTERRORBOX|dwMode); +//Disable Dr-Watson in order to crash simply without popup dialogs under +//windows +DWORD dwMode = SetErrorMode(SEM_NOGPFAULTERRORBOX); +SetErrorMode(SEM_NOGPFAULTERRORBOX|dwMode); #ifdef _DEBUG // These functions are present only in the debugging runtime -_CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); -_CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR); -_CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); -_CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDERR); -_CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); -_CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR); +_CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); +_CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR); +_CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); +_CrtSetReportFile(_CRT_ERROR, _CRTDBG_FILE_STDERR); +_CrtSetReportMode(_CRT_ASSERT, _CRTDBG_MODE_DEBUG|_CRTDBG_MODE_FILE); +_CrtSetReportFile(_CRT_ASSERT, _CRTDBG_FILE_STDERR); #endif #endif -std::vector protectors; -CppUnit::TestResult result; -std::string args; -std::string testlib; -sal_uInt32 index = 0; -while (index < osl_getCommandArgCount()) +std::vector protectors; +CppUnit::TestResult result; +std::string args; +std::string testlib; +sal_uInt32 index = 0; +while (index < osl_getCommandArgCount()) +{ +OUString arg = getArgument(index); +if (arg.startsWith("-env:CPPUNITTESTTARGET=", )) { -OUString arg = getArgument(index); -if (arg.startsWith("-env:CPPUNITTESTTARGET=", )) -{ -++index; -continue; -} -if (arg.startsWith("-env:")) +++index; +continue; +} +if (arg.startsWith("-env:")) +{ +++index; +continue; // ignore it here - will be read later +} +if ( arg != "--protector" ) +{ +if (testlib.empty()) { -++index; -continue; // ignore it here - will be read later +testlib = OUStringToOString(arg, osl_getThreadTextEncoding()).getStr(); +args += testlib; } -if ( arg != "--protector" ) +else { -if (testlib.empty()) -{ -testlib = OUStringToOString(arg, osl_getThreadTextEncoding()).getStr(); -args += testlib; -} -else -{ -args += ' '; -
[Libreoffice-bugs] [Bug 143489] Galician (gl_ES) dictionary has new upstream repository and new version
https://bugs.documentfoundation.org/show_bug.cgi?id=143489 --- Comment #2 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/dictionaries/commit/b6f494a9946de2899acf22c843ef7386d09a5cf4 tdf#143489: Update Galician dictionaries to version 20.08 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fcc757e386e11c99b02006d3816703f83d354f94 Author: Xisco Fauli AuthorDate: Wed Jul 28 18:28:06 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Jul 28 18:28:06 2021 +0200 Update git submodules * Update dictionaries from branch 'libreoffice-7-2' to b6f494a9946de2899acf22c843ef7386d09a5cf4 - tdf#143489: Update Galician dictionaries to version 20.08 Change-Id: I95b0064894a10a47e638568f85ddf5eb97ac345e Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119372 Reviewed-by: Adolfo Jayme Barrientos Reviewed-by: Andras Timar Tested-by: Andras Timar (cherry picked from commit c292071ca8f8dece2bf5655038cdfd4899a09fa3) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119614 Tested-by: Adolfo Jayme Barrientos diff --git a/dictionaries b/dictionaries index acc95a3635ff..b6f494a9946d 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit acc95a3635fff23f6b2cfaec260460de3f9c9d9c +Subproject commit b6f494a9946de2899acf22c843ef7386d09a5cf4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143489] Galician (gl_ES) dictionary has new upstream repository and new version
https://bugs.documentfoundation.org/show_bug.cgi?id=143489 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-7-2' - gl/Changelog.txt gl/description.xml gl/gl_ES.aff gl/gl_ES.dic gl/package-description.txt gl/README
gl/Changelog.txt |2 gl/README |3 gl/description.xml |4 gl/gl_ES.aff | 245 gl/gl_ES.dic |240448 ++--- gl/package-description.txt |3 6 files changed, 121576 insertions(+), 119129 deletions(-) New commits: commit b6f494a9946de2899acf22c843ef7386d09a5cf4 Author: Xisco Fauli AuthorDate: Thu Jul 22 13:26:49 2021 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Jul 28 18:28:06 2021 +0200 tdf#143489: Update Galician dictionaries to version 20.08 Change-Id: I95b0064894a10a47e638568f85ddf5eb97ac345e Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119372 Reviewed-by: Adolfo Jayme Barrientos Reviewed-by: Andras Timar Tested-by: Andras Timar (cherry picked from commit c292071ca8f8dece2bf5655038cdfd4899a09fa3) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119614 Tested-by: Adolfo Jayme Barrientos diff --git a/gl/Changelog.txt b/gl/Changelog.txt index 38a86d7..683507c 100644 --- a/gl/Changelog.txt +++ b/gl/Changelog.txt @@ -1 +1 @@ -Véxase/See https://github.com/meixome/hunspell-gl/blob/master/CHANGELOG +Véxase/See https://gitlab.com/proxecto-trasno/hunspell-gl/-/blob/master/CHANGELOG.rst diff --git a/gl/README b/gl/README index 7bd3779..b6556d3 100644 --- a/gl/README +++ b/gl/README @@ -4,8 +4,7 @@ and the coordination of Antón Méixome for Proxecto Trasno Corrector ortográfico hunspell-gl para galego (Volga estrito) e coordinado por Antón Méixome para Proxecto Trasno (www.trasno.net) -Version 18.07 "Francisco Mirás" -(https://gl.wikipedia.org/wiki/Francisco_Mirás) +Version 20.08 Nota. diff --git a/gl/description.xml b/gl/description.xml index 53e73a8..c8e312a 100644 --- a/gl/description.xml +++ b/gl/description.xml @@ -1,7 +1,7 @@ http://openoffice.org/extensions/description/2006; xmlns:d="http://openoffice.org/extensions/description/2006; xmlns:xlink="http://www.w3.org/1999/xlink;> - + @@ -19,7 +19,7 @@ -https://github.com/meixome/hunspell-gl/issues; lang="en">Hunspell-gl +https://gitlab.com/proxecto-trasno/hunspell-gl/-/issues; lang="en">Hunspell-gl diff --git a/gl/gl_ES.aff b/gl/gl_ES.aff index 51f0261..6af2e36 100644 --- a/gl/gl_ES.aff +++ b/gl/gl_ES.aff @@ -8629,8 +8629,6 @@ COMPOUNDRULE 3 COMPOUNDRULE (901)(901)*(903)? COMPOUNDRULE (901)(901)*(902)(901)(901)*(903)? COMPOUNDRULE (901)(901)*(904)?(905) -SFX 1011 Y 1 -SFX 1011 0 s 0 . is:plural PFX 1001 Y 8 PFX 1001 0 Y . PFX 1001 0 Z . @@ -8663,7 +8661,9 @@ PFX 1004 0 Ti . PFX 1004 0 Gi . PFX 1004 0 Mi . PFX 1004 0 ki . -REP 21452 +SFX 1011 Y 1 +SFX 1011 0 s 0 . is:plural +REP 21601 REP ^abag avag REP ^abág avág REP ^abagada$ avagada @@ -9265,6 +9265,8 @@ REP ^adubiar$ adobiar REP ^aducción$ adución REP ^aductor$ adutor REP ^aductores$ adutores +REP ^advenimento$ chegada +REP ^advenimentos$ chegadas REP ^adxetiva$ adxectiva REP ^adxetivas$ adxectivas REP ^adxetivo$ adxectivo @@ -9637,6 +9639,7 @@ REP ^algunhos$ algúns REP ^algús$ algúns REP ^alhaja$ alfaia REP ^alhajas$ alfaias +REP ^aliación aliaxe REP ^alicante$ alacante REP ^alicantina$ alacantina REP ^alicantinas$ alacantinas @@ -12724,11 +12727,16 @@ REP ^callejón$ calello REP ^callejón$ canella REP ^callejón$ canellón REP ^callejón$ quella -REP ^callejones^ calellas -REP ^callejones^ calellos -REP ^callejones^ canellas -REP ^callejones^ canellóns -REP ^callejones^ quellas +REP ^callejones$ calellas +REP ^callejones$ calellos +REP ^callejones$ canellas +REP ^callejones$ canellóns +REP ^callejones$ quellas +REP ^callejóns$ calellas +REP ^callejóns$ calellos +REP ^callejóns$ canellas +REP ^callejóns$ canellóns +REP ^callejóns$ quellas REP ^callexeira$ da_rúa REP ^callexeira$ na_rúa REP ^callexeiras$ da_rúa @@ -13535,6 +13543,7 @@ REP ^cince cice REP ^cinceis$ ciceis REP ^cincel$ cicel REP ^cincoenta$ cincuenta +REP ^cinguideiro cinguidoiro REP ^cintilada$ brillada REP ^cintilada$ escintilada REP ^cintilada$ refulxida @@ -13598,6 +13607,7 @@ REP ^ciúme celo REP ^cizaña$ discordia REP ^cizaña$ xoio REP ^cizañas$ xoios +REP ^claroscuro clarescuro REP ^clas$ clase REP ^clavada$ cravada REP ^clavadas$ cravadas @@ -16604,6 +16614,7 @@ REP ^emplear$ empregar REP ^empleo emprego REP ^empleo$ emprego REP ^empleos$ empregos +REP ^empoderamento apoderamento REP ^empola$ ampola REP ^empolada$ ampolada REP ^empoladas$ ampoladas @@ -22782,6 +22793,8 @@ REP ^pao$ pau REP ^paolo$ paiolo REP ^paolos$ paiolos REP ^paos$ paus +REP ^papeleo$ papelame +REP ^papeleos$ papelames REP ^paquistaníes$ paquistanís REP ^paradeiro$ paradoiro REP ^paradeiros$ paradoiros @@ -24080,7 +24093,13 @@ REP ^pontas$ puntas REP ^ponto punto REP ^ponto$ punto REP ^pontos$ puntos +REP ^populación poboación REP ^populación$ poboación +REP ^populaciona poboaciona +REP ^populacionais$ demográficas
[Libreoffice-bugs] [Bug 134497] PNG not exported with the same dimensions when original DPI is non-standard
https://bugs.documentfoundation.org/show_bug.cgi?id=134497 Buovjaga changed: What|Removed |Added Status|NEEDINFO|NEW Blocks||109323 Summary|Inserted PNG image |PNG not exported with the |corruption when Draw image |same dimensions when |is exported in PNG format. |original DPI is ||non-standard --- Comment #7 from Buovjaga --- (In reply to Robo Pluhar from comment #6) > Created attachment 173920 [details] > PNG image for testing, 742x300px > > There is a picture 742x300 px in the attachment. In my previous comment (nr. > 4) I made a mistake and used 724px instead of 742. I am sorry for that. > Now, when I use correct width 742px in the "PNG Options" dialogue LO > calculates 300px height (which is correct and aspect ratio is preserved). > > So expected result is just one: > * when exported picture is in its original size (in the drawing), the PNG > Options dialogue should use the same size in pixels by default. This image has a weird DPI. If I open it with GIMP and view Image - Properties, it shows DPI as 2,834×2,834 px/mm. GIMP does export it correctly, however, and even preserves the DPI. With LibreOffice, to export an image in its original size, you need to right-click the image and select Original size first. If we do it in this case, the exported resolution is 990x400 and the DPI will change to 72x72 ppi. So LibreOffice should learn to behave as smartly as GIMP. NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 67e47070a7580a17804adce812cc2f98bfe7b51f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109323 [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)
https://bugs.documentfoundation.org/show_bug.cgi?id=109323 Buovjaga changed: What|Removed |Added Depends on||134497 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=134497 [Bug 134497] PNG not exported with the same dimensions when original DPI is non-standard -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/script/provider/XScript.idl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 67faef71f937a14799fd551a2751c3b61dd7a94f Author: Mike Kaganski AuthorDate: Wed Jul 28 16:00:03 2021 +0200 Commit: Mike Kaganski CommitDate: Wed Jul 28 18:13:14 2021 +0200 A typo Change-Id: I5b9635381c43d34a16fb2443c4ca3621ff0d9a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119613 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/offapi/com/sun/star/script/provider/XScript.idl b/offapi/com/sun/star/script/provider/XScript.idl index 41c934ab32d3..d7538bc4395a 100644 --- a/offapi/com/sun/star/script/provider/XScript.idl +++ b/offapi/com/sun/star/script/provider/XScript.idl @@ -60,7 +60,7 @@ interface XScript : ::com::sun::star::uno::XInterface { the value returned from the function being invoked @throws ::com::sun::star::reflection::InvocationTargetException -if and error occurs while attempting to invoke a script the information is captured. If the error or exception is generated by the script itself it is wrapped as either ScriptErrorRaisedException or ScriptExceptionRaisedException or ScriptFrameworkErrorException are wrapped as ScriptFrameworkErrorExceptions. +if an error occurs while attempting to invoke a script the information is captured. If the error or exception is generated by the script itself it is wrapped as either ScriptErrorRaisedException or ScriptExceptionRaisedException or ScriptFrameworkErrorException are wrapped as ScriptFrameworkErrorExceptions. */ any invoke( [in] sequence aParams, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143589] New: There is a Tab too far to the left in the styles associated with the Table of content
https://bugs.documentfoundation.org/show_bug.cgi?id=143589 Bug ID: 143589 Summary: There is a Tab too far to the left in the styles associated with the Table of content Product: LibreOffice Version: 7.2.0.0 alpha1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adalbert.hans...@gmx.de Created attachment 173927 --> https://bugs.documentfoundation.org/attachment.cgi?id=173927=edit Document which shows the bug and how to circumvent it In general, the page numbers in the Table of Content are far to the right (16 cm). But there is an inconsistency in the placement of the page numbers in the TOC. Probably there is a Tab somewhere close to the beginning, such that the automatic tab with . markers does not become effective for very short headlines. See examples of the associated document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143451] Sidebar: Fontwork panel buttons for alignment don't do anything (the same in Toolbar)
https://bugs.documentfoundation.org/show_bug.cgi?id=143451 --- Comment #7 from Eleonora Govallo --- (In reply to stragu from comment #6) > Created attachment 173914 [details] > screenshot of icons to click > > Thanks for testing, Eleonora! > Very odd that you see it for only one of them. > > I installed the latest daily build, and still see the same issue: clicking > the icon (and not the arrow) still does not expand the menu for all three > items I listed. > > Can I please double-check that we are looking at the same thing: > - I am talking about clicking the icon, not the arrow > - I am talking about the sidebar (to the right of the screen), not the > toolbar > > You can see in the screenshot which part I am referring to. > > Version: 7.3.0.0.alpha0+ / LibreOffice Community > Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857 > CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 > Locale: en-AU (en_AU.UTF-8); UI: en-US > TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: > 2021-07-26_22:41:19 > Calc: threaded Thank you for clarification, i reproduced this bug completely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
GSoC Week #6 and #7 Report
Hello everyone. As mentioned in my previous report, the next step was to implement UNO interface for Data Providers . Reason for not sending report last week was I started learning about UNO and there was no specific achievement . I informed about this to Markus also. So last 2 weeks were full of learning about UNO implementation and extending it to use in Data Providers. I learnt about Services , how Interfaces can be used to provide abstraction , type of methods to be implemented in Extension ,etc. GetRangeAsString() method is used to input the range in form of string . For example - A3:C5 . GetCellData() returns pair containing value and data type for each cell . Please look at the patch https://gerrit.libreoffice.org/c/core/+/119588 (WIP) to check the implementation. Thanks to Markus for helping me getting introduced with UNO. Regards Tushar Kumar Rai ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 136489] Copy and paste seems to have a problem when copying a range and pasting only formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136489 Buovjaga changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #10 from Buovjaga --- (In reply to Elmar from comment #8) > It did NOT just paste the formulas, it pasted empty blanks into the cells. > The cells had data in them before which was not formulas. > How can you say that it did what you asked it to do. > Then remove this feature. The steps in your attachment 165174 were not clear. You had left B10:D10 empty. This is a dupe anyway. *** This bug has been marked as a duplicate of bug 64596 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 136489, which changed state. Bug 136489 Summary: Copy and paste seems to have a problem when copying a range and pasting only formula https://bugs.documentfoundation.org/show_bug.cgi?id=136489 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64596] EDITING: Paste Special Formula Overwrites Value
https://bugs.documentfoundation.org/show_bug.cgi?id=64596 Buovjaga changed: What|Removed |Added CC||rob...@iafrica.com --- Comment #9 from Buovjaga --- *** Bug 136489 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136489] Copy and paste seems to have a problem when copying a range and pasting only formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136489 --- Comment #9 from Elmar --- By not ticking the other options, it is telling me "do not touch the other cells, leave them as they are" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 136489, which changed state. Bug 136489 Summary: Copy and paste seems to have a problem when copying a range and pasting only formula https://bugs.documentfoundation.org/show_bug.cgi?id=136489 What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136489] Copy and paste seems to have a problem when copying a range and pasting only formula
https://bugs.documentfoundation.org/show_bug.cgi?id=136489 Elmar changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- --- Comment #8 from Elmar --- It did NOT just paste the formulas, it pasted empty blanks into the cells. The cells had data in them before which was not formulas. How can you say that it did what you asked it to do. Then remove this feature. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143577] Crash on image delete
https://bugs.documentfoundation.org/show_bug.cgi?id=143577 --- Comment #6 from Julien Nabet --- (In reply to Timur from comment #4) > Created attachment 173915 [details] > gdb.trace for fileopen > > I tried to get backtrace in Linux, but debug crashes already on fileopen. When you see ?? you can continue by typing "c" until you see something else than ? or ??. I don't remember well but I think these are related with Java because of an obscure reason. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143561] crash after deteting a very big part of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=143561 --- Comment #4 from Adalbert Hanßen --- Just thinking about what had happened with the particular file before the crash happened: I was installing Ubuntu from a live Stick Xubuntu 20.04.2 and I had started LibreOfficeWriter (probably version 6.4) from Xubuntu 20.04.2. I started from a very big file which had an associated style sheet. I did so in order to look up things in that document and to further use the stylesheet. After I had a lot of screenshots and notes from the Xubuntu installation steps, I stored the file on an USB stick. Later I reopened and edited it several times until I got problems when storing which I could not recover with LibreOffice from the live stick. Then I reopened the file on another computer with the mentioned development version. I could restore the file there. I continued editing it on the other computer. Finally tried to get rid of most parts of the old content with which I originally had started. Then .., see description above. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143588] When a line is across pages it would not be able to print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=143588 --- Comment #4 from Franklin Weng --- Created attachment 173926 --> https://bugs.documentfoundation.org/attachment.cgi?id=173926=edit Expected behavior - p2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143588] When a line is across pages it would not be able to print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=143588 --- Comment #3 from Franklin Weng --- Created attachment 173925 --> https://bugs.documentfoundation.org/attachment.cgi?id=173925=edit Expected behavior - p1 The sample file opened in Excel. The diagonal line is shown and printed correctly, which is expected also in Calc. (However Excel does not show the repeated head row and that is not the problem what I want to discuss here.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143588] When a line is across pages it would not be able to print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=143588 --- Comment #2 from Franklin Weng --- Created attachment 173924 --> https://bugs.documentfoundation.org/attachment.cgi?id=173924=edit Diagonal line extended to the edge of the page - p2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143588] When a line is across pages it would not be able to print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=143588 --- Comment #1 from Franklin Weng --- Created attachment 173923 --> https://bugs.documentfoundation.org/attachment.cgi?id=173923=edit Diagonal line extended to the edge of the page - p1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143114] Libclplug: kf5 support errors
https://bugs.documentfoundation.org/show_bug.cgi?id=143114 --- Comment #10 from Armin Le Grand --- The three lines from SvTreeListBox::StartDrag originate from ac7acb0ab1329913b0cec79790adcde0263960be "Merged SvTreeListBox and SvLBox" from 2012-10-11 - pretty old. Thus it originates from "void SvLBox::StartDrag" and was merged-in to SvTreeListBox::StartDrag. No idea why it was like that in SvLBox, but it was *not* originally part of SvTreeListBox. This is like that since 2021, so I will not dig deeper - those three lines may not be needed, but no direct hints from the past :-( Basic problem stays that SvTreeListBox::StartDrag (triggered from a MouseMove, NOT from MouseButton) *always* executes that MouseButtonUp. This should not happen if SvImpLBox (the EntryList) is actively handling a ButtonAction with CaptureMouse() being active. That again is alredady done actively in SvImpLBox::ButtonDownCheckCtrl, SvImpLBox::MouseMoveCheckCtrl, SvImpLBox::ButtonUpCheckCtrl. Adding a possibility to *ask/check* for it from SvTreeListBox... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143588] New: When a line is across pages it would not be able to print correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=143588 Bug ID: 143588 Summary: When a line is across pages it would not be able to print correctly Product: LibreOffice Version: 6.3.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: frank...@goodhorse.idv.tw Created attachment 173922 --> https://bugs.documentfoundation.org/attachment.cgi?id=173922=edit Sample file for this problem In Calc if we draw a line (in this case a diagonal line) which is in a merged cell, which happens to be across the page, when printing it would not be able to print correctly. You can see the result in print preview. I will attach the screenshot later too. In the print preview (also the printed result) the line was extended to the bottom (and from the beginning) of its pages. Opening this file in Microsoft Excel, the diagonal line is shown corrected (see expected-1 and expected-2 screenshot). The file is generated by LibreOffice Calc 6.3.6.2 while I open it with 7.1.3.2. Version: 7.1.3.2 / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: zh-TW (zh_TW.UTF-8); UI: zh-TW Calc: threaded In my 7.1.3.2 I see one lines extending to the edge of the page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143561] crash after deteting a very big part of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=143561 --- Comment #3 from Adalbert Hanßen --- Timur, as told before, I recovered the document and continued to use it. Finally I succeeded to reduce the document to the smaller size but it is no longer the same one as it was in the moment of the crash and of course it was not ready to be publicly shown. - sorry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143114] Libclplug: kf5 support errors
https://bugs.documentfoundation.org/show_bug.cgi?id=143114 --- Comment #9 from Armin Le Grand --- Debugging this is not really possible, so I try to understand the code - SvTreeListBox is a nightmare, with it's base classes && massive implementations. I also used debug to see that the SvTreeListBox::StartDrag gets triggered by some Qt action, while e.g. MouseButtonDown is triggered regular by the office. Also we have Win/Linux/Mac. I just checked Linux where we have five UI possibilities (currently) selected by e.g. setting env SAL_USE_VCLPLUGIN: (a) "gen" (b) "gtk3_kde5" (c) "gtk3" (d) "qt5" (e) "kf5" To get all of these to experimant you need to build using --enable-kf5 --enable-qt5 --enable-gtk3-kde5 in autogen configuration. Versions (a..e) behave not the same, so the 1st problem would be to make them behave the same. BTW: A good example how a CheckButton *should* behave is in the BugDoc right above those lists when shown, the 'All' button - which works the same in (a..e). Checking why SvTreeListBox::StartDrag trggers a MouseButtonUp-event - maybe there are hints in the git history. Interestingly this is triggered by MouseMove, *not* from MouseButtonDown/Up (!)... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143587] Latest *Dev Release appears to magnify autofilter buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=143587 --- Comment #1 from Colin --- Created attachment 173921 --> https://bugs.documentfoundation.org/attachment.cgi?id=173921=edit screen image -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143587] New: Latest *Dev Release appears to magnify autofilter buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=143587 Bug ID: 143587 Summary: Latest *Dev Release appears to magnify autofilter buttons Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: See attached image. The original file in the user environment has all the autofilter buttons scaled to fit the cell height - this occurred automatically when the filters were created. Also note that my document has column & Row freeze active on line 5 The dev version Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded works as expected until the sheet zoom factor goes beyond 100 then the button grows beyond the height of the cell. This doesn't occur with release 7.0.6.2 Steps to Reproduce: Set zoom to 100% on line 5 create an array of say ten columns with random headers set this array as autofiltered Optionally add some random data to a few lines beneath the headers Optionally add some random data to the lines above the headers Set a column and row freeze to allow the table to scroll under the headers magnify the screen either with ctrl+scroll wheel or the scale control at bottom right of the sheet observe how the auto filer buttons will grow beyon the vertical limit of the row Actual Results: Button Grows disproportionately Expected Results: Button not to grow disproportionately Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded New Testing installation and new profile -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143582] The return value of Basic function is not initialized when called by the invoke method
https://bugs.documentfoundation.org/show_bug.cgi?id=143582 --- Comment #2 from Andreas Heinisch --- Repro in: Version: 6.2.5.2 (x64) Build-ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114532] add support for WEBP image format (image import and inside .ods/.odt)
https://bugs.documentfoundation.org/show_bug.cgi?id=114532 --- Comment #13 from David D Lowe --- I downloaded an image from a web page using my web browser. I then tried to add it to a presentation using Impress. I was confused when the file browser in Impress did not display the image I had downloaded. I only realised later that the image was a WebP image, and that LibreOffice presumably did not support it. It would be good to support WebP now that all major browsers support it and more images on the web are going to be using this format. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134497] Inserted PNG image corruption when Draw image is exported in PNG format.
https://bugs.documentfoundation.org/show_bug.cgi?id=134497 --- Comment #6 from Robo Pluhar --- Created attachment 173920 --> https://bugs.documentfoundation.org/attachment.cgi?id=173920=edit PNG image for testing, 742x300px There is a picture 742x300 px in the attachment. In my previous comment (nr. 4) I made a mistake and used 724px instead of 742. I am sorry for that. Now, when I use correct width 742px in the "PNG Options" dialogue LO calculates 300px height (which is correct and aspect ratio is preserved). So expected result is just one: * when exported picture is in its original size (in the drawing), the PNG Options dialogue should use the same size in pixels by default. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143582] The return value of Basic function is not initialized when called by the invoke method
https://bugs.documentfoundation.org/show_bug.cgi?id=143582 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||andreas.heini...@yahoo.de --- Comment #1 from Mike Kaganski --- Repro. XScript::invoke [1] is documented to return "the value returned from the function being invoked". It doesn't mention "... and keep a copy to attach to the next return as a bonus" ;-D [1] https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1script_1_1provider_1_1XScript.html#a11a551f5a2520f74c5109cd8c9f8c7b7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added CC||p.heinlein@heinlein-support ||.de --- Comment #23 from V Stuart Foote --- *** Bug 140710 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140710] Google-Font Sora Bold not supported for PDF export or Print
https://bugs.documentfoundation.org/show_bug.cgi?id=140710 V Stuart Foote changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #23 from V Stuart Foote --- (In reply to Rafael Lima from comment #21) Sure, but the see also is for the enhancement of supporting variable font, assume that would include work on the PDF and printing export filters. Setting this a duplicate... *** This bug has been marked as a duplicate of bug 103596 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141726] LO Writer - Bold not working with variable EB Garamond
https://bugs.documentfoundation.org/show_bug.cgi?id=141726 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |3596| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |1726| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added CC||d1nu...@protonmail.com --- Comment #22 from V Stuart Foote --- *** Bug 141726 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141726] LO Writer - Bold not working with variable EB Garamond
https://bugs.documentfoundation.org/show_bug.cgi?id=141726 V Stuart Foote changed: What|Removed |Added Resolution|INVALID |DUPLICATE --- Comment #7 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 103596 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143577] Crash on image delete
https://bugs.documentfoundation.org/show_bug.cgi?id=143577 --- Comment #5 from gta 5 modded accounts --- I tried to get a backtrace in Linux, but debug crashes already on file open. Seems to be the same as in bug 142733, not all reproduce. https://nergeticmodding.com/;>gta 5 modded accounts -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137301] PDF export cannot embed OpenType CFF2 (Variable PostScript / .otf) fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=137301 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |3596| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140710] Google-Font Sora Bold not supported for PDF export or Print
https://bugs.documentfoundation.org/show_bug.cgi?id=140710 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |3596| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108497] Converting OpenType Font Variation instances before printing and exporting to PDF or EPUB
https://bugs.documentfoundation.org/show_bug.cgi?id=108497 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3596 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=13 |tion.org/show_bug.cgi?id=10 |7301, |8497 |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |0710| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - vcl/source
vcl/source/filter/ipdf/pdfread.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit abea84a1603e3ac376733fcfdd781048ca6441c8 Author: Samuel Mehrbrodt AuthorDate: Wed Jul 28 09:50:51 2021 +0200 Commit: Samuel Mehrbrodt CommitDate: Wed Jul 28 16:29:16 2021 +0200 Fix --disable-pdfium build Change-Id: I463ad81891ecc8eedb0746fbd056fd0cb36cfca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119585 Tested-by: Samuel Mehrbrodt Reviewed-by: Samuel Mehrbrodt diff --git a/vcl/source/filter/ipdf/pdfread.cxx b/vcl/source/filter/ipdf/pdfread.cxx index 538a6055f168..f4ededa3adde 100644 --- a/vcl/source/filter/ipdf/pdfread.cxx +++ b/vcl/source/filter/ipdf/pdfread.cxx @@ -206,7 +206,6 @@ size_t RenderPDFBitmaps(const void* pBuffer, int nSize, std::vector& rBi (void)rBitmaps; (void)nFirstPage; (void)nPages; -(void)pSizeHint; return 0; #endif // HAVE_FEATURE_PDFIUM } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143586] Ruby (rubi / furigana) html tags not created when saving as html
https://bugs.documentfoundation.org/show_bug.cgi?id=143586 --- Comment #1 from anish.mis...@arcanumbridge.com --- Created attachment 173919 --> https://bugs.documentfoundation.org/attachment.cgi?id=173919=edit Current resulting html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134199] Copy/paste of a doc results in deviating number of pages of the original (in multi page view)
https://bugs.documentfoundation.org/show_bug.cgi?id=134199 Dmitriy Siushkin changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||demonchi...@mail.ru --- Comment #4 from Dmitriy Siushkin --- repro in Version: 7.2.0.1 (x64) / LibreOffice Community Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143586] New: Ruby (rubi / furigana) html tags not created when saving as html
https://bugs.documentfoundation.org/show_bug.cgi?id=143586 Bug ID: 143586 Summary: Ruby (rubi / furigana) html tags not created when saving as html Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: anish.mis...@arcanumbridge.com Created attachment 173918 --> https://bugs.documentfoundation.org/attachment.cgi?id=173918=edit Docx with ruby text Version: 7.1.5.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 12; OS: FreeBSD 13.0; UI render: default; VCL: qt5+cairo Locale: en-US (en_US.ISO8859-1); UI: en-US Calc: threaded When saving a document (docx or odt) with ruby text, that text is NOT converted correctly in the resulting html. The html should have the text appropriately tags withtags. The resulting HTML currently just show everything on the same line since it's not tagged out correctly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added CC||joaopauloag-freedesktop@yah ||oo.com.br --- Comment #21 from V Stuart Foote --- *** Bug 137301 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137301] PDF export cannot embed OpenType CFF2 (Variable PostScript / .otf) fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=137301 V Stuart Foote changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #5 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 103596 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout
https://bugs.documentfoundation.org/show_bug.cgi?id=103596 V Stuart Foote changed: What|Removed |Added CC||rafael.palma.l...@gmail.com --- Comment #20 from V Stuart Foote --- *** Bug 140538 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140538] Some bold Google Fonts not exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=140538 --- Comment #12 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 103596 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143584] In Writer, the SHFT+F3 alters the case of the entire paragraph rather than only the selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=143584 Michael Warner changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Michael Warner --- Thanks for reporting this bug. As it turns out, this is already a known issue and I am currently working on fixing it. *** This bug has been marked as a duplicate of bug 49033 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143585] New: "Calling Calc Functions" help examples should use names following respective functions' help topics
https://bugs.documentfoundation.org/show_bug.cgi?id=143585 Bug ID: 143585 Summary: "Calling Calc Functions" help examples should use names following respective functions' help topics Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: olivier.hal...@libreoffice.org "Calling Calc Functions" help page [1] has an example for VLOOKUP, which passes the four arguments expected by the spreadsheet function using names that don't follow the names used in the VLOOKUP spreadsheet function help [2]: namely, [2] uses names "SearchCriterion", "Array", "Index", while [1] uses "item", "InRange", "FromCol" for the same. Non-English speakers will not recognize the semantical connection (which itself is poor). Of course, Array is itself a BASIC function name, so the used name should be similar but not identical; but the other names could be used as is. Specifically, the question arose on a Russian user forum [3]. Users do not necessarily draw connections between arguments to Array function, and arguments to the called spreadsheet function. (This itself could be explicitly mentioned, and maybe the reference to the service could have a link to api.libreoffice.org by the way.) [1] https://help.libreoffice.org/7.2/en-US/text/sbasic/shared/calc_functions.html?=BASIC [2] https://help.libreoffice.org/7.2/en-US/text/scalc/01/04060109.html?DbPAR=CALC#bm_id3153152 [3] https://forumooo.ru/index.php/topic,8715.60/msg,59125.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140710] Google-Font Sora Bold not supported for PDF export or Print
https://bugs.documentfoundation.org/show_bug.cgi?id=140710 --- Comment #22 from Julien Nabet --- I agree(In reply to Rafael Lima from comment #21) > (In reply to V Stuart Foote from comment #19) > > There is no LibreOffice support for OTF variable fonts -- see also bug > > 103596 > > I see your point, but shouldn't this be at least an enhancement proposal? I > believe at some point this support will have to be implemented. > ... If I understand well, tdf#103596 is the enhancement bug about this. At the time it's been created, Harfbuzz 1.4 which provides variable font support (see https://www.phoronix.com/scan.php?page=news_item=HarfBuzz-1.4-Released) hadn't been released. Then, after it's been released there's been a first support with https://cgit.freedesktop.org/libreoffice/core/commit/?id=cb54bb89494218589227246f1923d8a24ab1676a. I don't know if there have been others but I suppose it's better to keep on the discussion about it on tdf#103596. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/accessibility/XAccessibleValue.idl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit be3764070655afb438ac4d09a73175ebcbc8fea2 Author: Michael Weghorn AuthorDate: Wed Jul 28 12:13:50 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 16:18:29 2021 +0200 Minor fix in comment for XAccessibleValue::getMinimumValue This looks like a copy-paste error. The *upper* bound is relevant for 'getMaximumValue', the *lower* bound for 'getMinimumValue'. Change-Id: Ibe707fde6185c0fa757741683f046393e2003eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119600 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/offapi/com/sun/star/accessibility/XAccessibleValue.idl b/offapi/com/sun/star/accessibility/XAccessibleValue.idl index db66c039b68a..a1f7879dcd07 100644 --- a/offapi/com/sun/star/accessibility/XAccessibleValue.idl +++ b/offapi/com/sun/star/accessibility/XAccessibleValue.idl @@ -85,7 +85,7 @@ interface XAccessibleValue : ::com::sun::star::uno::XInterface @return Returns the minimal value in an implementation dependent type. -If this object has no upper bound then an empty object is +If this object has no lower bound then an empty object is returned. */ any getMinimumValue (); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140710] Google-Font Sora Bold not supported for PDF export or Print
https://bugs.documentfoundation.org/show_bug.cgi?id=140710 --- Comment #21 from Rafael Lima --- (In reply to V Stuart Foote from comment #19) > There is no LibreOffice support for OTF variable fonts -- see also bug 103596 I see your point, but shouldn't this be at least an enhancement proposal? I believe at some point this support will have to be implemented. Most users will expect native support for variable fonts. Or else we will keep receiving bug reports about this issue of not exporting PDF correctly for some fonts. In truth, most average users don't even know what a "variable font" is and will not know the reason to the problem, leading them to think it is LibreOffice's fault. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/qa
sc/qa/unit/tiledrendering/tiledrendering.cxx | 43 +++ 1 file changed, 43 insertions(+) New commits: commit 360791be914f8480c76a825f0a2b75d1b66a2f3d Author: Dennis Francis AuthorDate: Fri Jul 2 19:10:31 2021 +0530 Commit: Dennis Francis CommitDate: Wed Jul 28 15:53:52 2021 +0200 lok: sc: unit test for non existent tab view data fix Conflicts: sc/qa/unit/tiledrendering/tiledrendering.cxx Change-Id: I7c0ea95118448a49288ff70c8e7bcddc379df5ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119603 Tested-by: Jenkins CollaboraOffice Reviewed-by: Dennis Francis diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 02d261919b0a..ac186d0e5f5e 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -123,6 +123,7 @@ public: void testMoveShapeHandle(); void testEditCursorBounds(); void testTextSelectionBounds(); +void testSheetViewDataCrash(); CPPUNIT_TEST_SUITE(ScTiledRenderingTest); CPPUNIT_TEST(testRowColumnHeaders); @@ -176,6 +177,7 @@ public: CPPUNIT_TEST(testMoveShapeHandle); CPPUNIT_TEST(testEditCursorBounds); CPPUNIT_TEST(testTextSelectionBounds); +CPPUNIT_TEST(testSheetViewDataCrash); CPPUNIT_TEST_SUITE_END(); private: @@ -2833,6 +2835,47 @@ void ScTiledRenderingTest::testTextSelectionBounds() SfxViewShell::Current()->registerLibreOfficeKitViewCallback(nullptr, nullptr); } +void ScTiledRenderingTest::testSheetViewDataCrash() +{ +comphelper::LibreOfficeKit::setActive(); + +ScModelObj* pModelObj = createDoc("empty.ods"); + +// view #1 +int nView1 = SfxLokHelper::getView(); +SfxLokHelper::setView(nView1); + +// Imitate online while creating a new sheet on empty.ods. +uno::Sequence aArgs( +comphelper::InitPropertySequence({ +{ "Name", uno::Any(OUString("NewSheet")) }, +{ "Index", uno::Any(sal_Int32(2)) } +})); +comphelper::dispatchCommand(".uno:Insert", aArgs); +Scheduler::ProcessEventsToIdle(); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::PAGEDOWN | KEY_MOD1); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::PAGEDOWN | KEY_MOD1); +Scheduler::ProcessEventsToIdle(); +ScTabViewShell* pView1 = dynamic_cast(SfxViewShell::Current()); +CPPUNIT_ASSERT(pView1); + +// view #2 +SfxLokHelper::createView(); +ScTabViewShell* pView2 = dynamic_cast(SfxViewShell::Current()); +CPPUNIT_ASSERT(pView2); +Scheduler::ProcessEventsToIdle(); + +SfxLokHelper::setView(nView1); +// Delete a range. +pView1->SetCursor(1, 1); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::DOWN | KEY_SHIFT); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::DOWN | KEY_SHIFT); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::DELETE); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::DELETE); +// It will crash at this point without the fix. +Scheduler::ProcessEventsToIdle(); +} + } CPPUNIT_TEST_SUITE_REGISTRATION(ScTiledRenderingTest); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source
sc/source/ui/docshell/docfunc.cxx |3 ++- sc/source/ui/view/dbfunc3.cxx | 10 -- sc/source/ui/view/viewdata.cxx|6 -- sc/source/ui/view/viewfunc.cxx| 16 4 files changed, 26 insertions(+), 9 deletions(-) New commits: commit 57a282ad7bb0c8695142c34d6f5b7e0094933d59 Author: Dennis Francis AuthorDate: Fri Jul 2 19:01:47 2021 +0530 Commit: Dennis Francis CommitDate: Wed Jul 28 15:52:47 2021 +0200 lok: sc: avoid crash on non existent tab view data ... when accessing position helpers. Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119450 Tested-by: Dennis Francis Reviewed-by: Dennis Francis diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx index 951048e43869..8c953b79a7a6 100644 --- a/sc/source/ui/docshell/docfunc.cxx +++ b/sc/source/ui/docshell/docfunc.cxx @@ -169,7 +169,8 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, bool bPaint, bool bApi ) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pSomeViewForThisDoc->GetDocId()) { - pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow); +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)) +pPosHelper->invalidateByIndex(nStartRow); } pViewShell = SfxViewShell::GetNext(*pViewShell); } diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx index f7a79a173e0f..f70a63c4484f 100644 --- a/sc/source/ui/view/dbfunc3.cxx +++ b/sc/source/ui/view/dbfunc3.cxx @@ -2289,9 +2289,15 @@ void ScDBFunc::OnLOKShowHideColRow(bool bColumns, SCCOLROW nStart) if (pTabViewShell && pTabViewShell->GetDocId() == pThisViewShell->GetDocId()) { if (bColumns) - pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStart); +{ +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStart); +} else - pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex)->invalidateByIndex(nStart); +{ +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStart); +} if (pTabViewShell->getPart() == nCurrentTabIndex) { diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx index f0f3d25e0e2f..f2b19ad71a67 100644 --- a/sc/source/ui/view/viewdata.cxx +++ b/sc/source/ui/view/viewdata.cxx @@ -2321,7 +2321,8 @@ void ScViewData::SetTabNo( SCTAB nNewTab ) ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB nTabIndex) { -if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size( +if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size())) || +!maTabData[nTabIndex]) { return nullptr; } @@ -2330,7 +2331,8 @@ ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB nTabIndex) ScPositionHelper* ScViewData::GetLOKHeightHelper(SCTAB nTabIndex) { -if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size( +if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size())) || +!maTabData[nTabIndex]) { return nullptr; } diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index 3128dc46c0a0..1a6d45ea2289 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -1474,7 +1474,8 @@ void ScViewFunc::OnLOKInsertDeleteColumn(SCCOL nStartCol, tools::Long nOffset) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pCurrentViewShell->GetDocId()) { - pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStartCol); +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStartCol); // if we remove a column the cursor position and the current selection // in other views could need to be moved on the left by one column. @@ -1530,7 +1531,8 @@ void ScViewFunc::OnLOKInsertDeleteRow(SCROW nStartRow, tools::Long nOffset) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pCurrentViewShell->GetDocId()) { -
[Libreoffice-bugs] [Bug 143583] FILEOPEN DOCX Ending empty paragraphs gone from footnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=143583 László Németh changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5AccessibleWidget.cxx | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) New commits: commit f62cbfed55099170ae6f9c006c36bca3420424e3 Author: Michael Weghorn AuthorDate: Wed Jul 28 11:46:20 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 15:45:43 2021 +0200 qt5 a11y: Implement Qt5AccessibleWidget::minimumStepSize This makes use of the newly introduced XAccessibleValue::getMinimumIncrement method, s. Change-Id: Ie148a4e1cedbdbb5964f8565c81611d3480465cb, "Add XAccessibleValue::getMinimumIncrement method". With this in place, Accerciser now shows the correct "Minimum increment" and the exact decimal value instead of a rounded integer value for FormattedFields, s. note in commit message for Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634 "a11y: Expose FormattedField as spinbox" for more details. Change-Id: Ia9d07552197357c81ae8ea3b62e2de07e82148bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119597 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx index c7008f36d26a..65d5faafb918 100644 --- a/vcl/qt5/Qt5AccessibleWidget.cxx +++ b/vcl/qt5/Qt5AccessibleWidget.cxx @@ -1090,6 +1090,7 @@ QVariant Qt5AccessibleWidget::currentValue() const xValue->getCurrentValue() >>= aDouble; return QVariant(aDouble); } + QVariant Qt5AccessibleWidget::maximumValue() const { Reference xAc = getAccessibleContextImpl(); @@ -1103,7 +1104,21 @@ QVariant Qt5AccessibleWidget::maximumValue() const xValue->getMaximumValue() >>= aDouble; return QVariant(aDouble); } -QVariant Qt5AccessibleWidget::minimumStepSize() const { return QVariant(); } + +QVariant Qt5AccessibleWidget::minimumStepSize() const +{ +Reference xAc = getAccessibleContextImpl(); +if (!xAc.is()) +return QVariant(); + +Reference xValue(xAc, UNO_QUERY); +if (!xValue.is()) +return QVariant(); +double dMinStep = 0; +xValue->getMinimumIncrement() >>= dMinStep; +return QVariant(dMinStep); +} + QVariant Qt5AccessibleWidget::minimumValue() const { Reference xAc = getAccessibleContextImpl(); @@ -1117,6 +1132,7 @@ QVariant Qt5AccessibleWidget::minimumValue() const xValue->getMinimumValue() >>= aDouble; return QVariant(aDouble); } + void Qt5AccessibleWidget::setCurrentValue(const QVariant& value) { Reference xAc = getAccessibleContextImpl(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: accessibility/inc accessibility/source offapi/com sc/source svx/source sw/source
accessibility/inc/extended/AccessibleBrowseBoxCheckBoxCell.hxx|1 accessibility/inc/extended/accessiblelistboxentry.hxx |3 + accessibility/inc/standard/svtaccessiblenumericfield.hxx |1 accessibility/inc/standard/vclxaccessiblebox.hxx |2 + accessibility/inc/standard/vclxaccessiblebutton.hxx |1 accessibility/inc/standard/vclxaccessiblecheckbox.hxx |1 accessibility/inc/standard/vclxaccessiblemenuitem.hxx |1 accessibility/inc/standard/vclxaccessibleradiobutton.hxx |1 accessibility/inc/standard/vclxaccessiblescrollbar.hxx|1 accessibility/inc/standard/vclxaccessibletoolboxitem.hxx |1 accessibility/source/extended/AccessibleBrowseBoxCheckBoxCell.cxx |8 accessibility/source/extended/accessiblelistboxentry.cxx | 17 ++ accessibility/source/standard/svtaccessiblenumericfield.cxx | 12 +++ accessibility/source/standard/vclxaccessiblebox.cxx |5 ++ accessibility/source/standard/vclxaccessiblebutton.cxx| 10 + accessibility/source/standard/vclxaccessiblecheckbox.cxx | 10 + accessibility/source/standard/vclxaccessiblemenuitem.cxx |8 accessibility/source/standard/vclxaccessibleradiobutton.cxx | 10 + accessibility/source/standard/vclxaccessiblescrollbar.cxx |7 accessibility/source/standard/vclxaccessibletoolboxitem.cxx |5 ++ offapi/com/sun/star/accessibility/XAccessibleValue.idl| 14 sc/source/ui/Accessibility/AccessibleCellBase.cxx |6 +++ sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx|6 +++ sc/source/ui/inc/AccessibleCellBase.hxx |3 + sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx |1 svx/source/accessibility/svxrectctaccessiblecontext.cxx |7 svx/source/inc/svxrectctaccessiblecontext.hxx |3 + sw/source/core/access/acccell.cxx |5 ++ sw/source/core/access/acccell.hxx |8 +--- 29 files changed, 153 insertions(+), 5 deletions(-) New commits: commit b5ada12ffd0b6b8677430fce117c4c1e38cc9159 Author: Michael Weghorn AuthorDate: Wed Jul 28 11:26:16 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 15:45:28 2021 +0200 a11y: Add XAccessibleValue::getMinimumIncrement method Add a method 'getMinimumIncrement' to the XAccessibleValue interface. The method returns the minimal increment by which the value represented by the object can be adjusted. The main motivation is to expose this to AT-SPI, so it can be retrieved e.g. by libatspi's 'atspi_value_get_minimum_increment' function [1], s. the note in Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634 "a11y: Expose FormattedField as spinbox" for more details. The implementation relevant for the 'FormattedField' class is in 'SVTXAccessibleNumericField::getMinimumIncrement', which returns the spin size. While at it, also move the comment in sw/source/core/access/acccell.hxx mentioning what methods are overriden for the 'XAccessibleValue' interface to the right place. [1] https://developer.gnome.org/libatspi/stable/libatspi-atspi-value.html#atspi-value-get-minimum-increment Change-Id: Ie148a4e1cedbdbb5964f8565c81611d3480465cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119596 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/accessibility/inc/extended/AccessibleBrowseBoxCheckBoxCell.hxx b/accessibility/inc/extended/AccessibleBrowseBoxCheckBoxCell.hxx index a550eed5e220..76c70344096c 100644 --- a/accessibility/inc/extended/AccessibleBrowseBoxCheckBoxCell.hxx +++ b/accessibility/inc/extended/AccessibleBrowseBoxCheckBoxCell.hxx @@ -70,6 +70,7 @@ namespace accessibility virtual sal_Bool SAL_CALL setCurrentValue( const css::uno::Any& aNumber ) override; virtual css::uno::Any SAL_CALL getMaximumValue( ) override; virtual css::uno::Any SAL_CALL getMinimumValue( ) override; +virtual css::uno::Any SAL_CALL getMinimumIncrement( ) override; // internal voidSetChecked( bool _bChecked ); diff --git a/accessibility/inc/extended/accessiblelistboxentry.hxx b/accessibility/inc/extended/accessiblelistboxentry.hxx index 279978a34ccf..449803bc35b5 100644 --- a/accessibility/inc/extended/accessiblelistboxentry.hxx +++ b/accessibility/inc/extended/accessiblelistboxentry.hxx @@ -202,10 +202,13 @@ namespace accessibility sal_Int32 SAL_CALL getSelectedAccessibleChildCount( ) override; css::uno::Reference< css::accessibility::XAccessible > SAL_CALL getSelectedAccessibleChild( sal_Int32 nSelectedChildIndex ) override;
[Libreoffice-commits] core.git: accessibility/inc accessibility/Library_acc.mk accessibility/source include/toolkit toolkit/source
accessibility/Library_acc.mk|1 accessibility/inc/standard/svtaccessiblenumericfield.hxx| 50 ++ accessibility/inc/standard/vclxaccessibleedit.hxx |5 accessibility/source/helper/acc_factory.cxx |8 + accessibility/source/standard/svtaccessiblenumericfield.cxx | 93 include/toolkit/awt/vclxwindows.hxx |4 include/toolkit/helper/accessiblefactory.hxx|6 toolkit/source/awt/vclxwindows.cxx |7 toolkit/source/helper/accessibilityclient.cxx |5 toolkit/source/helper/unowrapper.cxx|2 10 files changed, 177 insertions(+), 4 deletions(-) New commits: commit 349a8801b9ee98f4f9ee1d35f7d28e17baedf7cc Author: Michael Weghorn AuthorDate: Wed Jul 28 09:39:07 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 15:44:58 2021 +0200 a11y: Expose FormattedField as spinbox This adds a new accessibility class 'SVTXAccessibleNumericField' that implements 'XAccessibleValue' and reports having an a11y role of 'AccessibleRole::SPIN_BOX'. An object of that class is returned by 'SVTXNumericField::CreateAccessibleContext'. Create an 'SVTXNumericField' XWindow peer for windows of type 'WindowType::FORMATTEDFIELD' (instead of a 'VCLXNumericField' one), so the newly introduced accessibility class gets used for 'FormattedField'. This way, FormattedFields are now exposed to a11y tools as spinboxes. Previously, since no specific accessibility class had been implemented for VCLXNumericField (then used as XWindow peer class for FormattedField), the one for VCLXEdit, i.e. VCLXAccessibleEdit, was used. While VCLXNumericField implements XNumericField and thus in general offers the relevant methods to implement an accessible class that implements XAccessibleValue as well, it uses the Formatter from the VCLXFormattedSpinField base class to get/set values. However, that doesn't work for the FormattedField case, since FormattedField has its own formatter of a different type and the 'mpFormatter' member in the VCLXFormattedSpinField base class is a nullptr, resulting in the corresponding getter methods always returning 0 and the setters doing nothing. With this commit in place, Accerciser now reports role "spin box" instead of just "text" for FormattedFields and displays the current value as well as allows to change it via the "Value" interface when using the qt5/kf5 VCL plugin. Note: For non-integer values, Accerciser doesn't show the actual decimal value, but an integer, e.g. when the value for "Height" spinbox in Writer's "Page Style" -> "Page" dialog (section "Paper format") is set to "29.70cm", Accerciser shows "30" instead of "29.70", despite 'Qt5AccessibleWidget::currentValue' returning the exact value. This is because Accerciser appears to rely on the value for the minimum increment being reported (as a corresponding decimal value) by a call to 'atspi_value_get_minimum_increment', s.[1]. However, there is currently no corresponding method in the 'XAccesibleValue' interface for that at-spi method which 'Qt5AccessibleWidget::currentValue' could call to retrieve the value. The NVDA screen reader on Windows now also says e.g. "Width: (Type = 344) spin button editable Alt+W selected 8.50″" instead of "Width: (Type = 344) edit Alt+W selected 8.50″". [1] https://developer.gnome.org/libatspi/stable/libatspi-atspi-value.html#atspi-value-get-minimum-increment Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119590 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/accessibility/Library_acc.mk b/accessibility/Library_acc.mk index caf3d612330b..fe88dafe10da 100644 --- a/accessibility/Library_acc.mk +++ b/accessibility/Library_acc.mk @@ -78,6 +78,7 @@ $(eval $(call gb_Library_add_exception_objects,acc,\ accessibility/source/standard/accessiblemenucomponent \ accessibility/source/standard/accessiblemenuitemcomponent \ accessibility/source/standard/floatingwindowaccessible \ +accessibility/source/standard/svtaccessiblenumericfield \ accessibility/source/standard/vclxaccessiblebox \ accessibility/source/standard/vclxaccessiblebutton \ accessibility/source/standard/vclxaccessiblecheckbox \ diff --git a/accessibility/inc/standard/svtaccessiblenumericfield.hxx b/accessibility/inc/standard/svtaccessiblenumericfield.hxx new file mode 100644 index ..940f72fa03f2 --- /dev/null +++ b/accessibility/inc/standard/svtaccessiblenumericfield.hxx @@ -0,0 +1,50 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is
[Libreoffice-commits] core.git: include/toolkit toolkit/inc
include/toolkit/awt/vclxwindows.hxx | 118 toolkit/inc/awt/vclxwindows.hxx | 116 --- 2 files changed, 118 insertions(+), 116 deletions(-) New commits: commit 9ceb47ce712157019ca06ee11c66515ea7cc16ec Author: Michael Weghorn AuthorDate: Wed Jul 28 09:27:23 2021 +0200 Commit: Michael Weghorn CommitDate: Wed Jul 28 15:44:38 2021 +0200 Move SVTXNumericField and parents to public toolkit header This is in preparation for the creation of a new accessibility class for 'SVTXNumericField'. Change-Id: I41e04c71b951832e4e264a271a3d66be7b6d6ce7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119589 Tested-by: Jenkins Reviewed-by: Michael Weghorn diff --git a/include/toolkit/awt/vclxwindows.hxx b/include/toolkit/awt/vclxwindows.hxx index 38c3a1a4a268..99f8fea450fa 100644 --- a/include/toolkit/awt/vclxwindows.hxx +++ b/include/toolkit/awt/vclxwindows.hxx @@ -23,6 +23,7 @@ #include #include +#include #include #include #include @@ -38,6 +39,7 @@ #include #include +#include #include #include @@ -460,6 +462,122 @@ public: }; +// class VCLXSpinField +class VCLXSpinField : public css::awt::XSpinField, public VCLXEdit +{ +private: +SpinListenerMultiplexer maSpinListeners; + +protected: +voidProcessWindowEvent( const VclWindowEvent& rVclWindowEvent ) override; + +public: +VCLXSpinField(); + +// css::uno::XInterface +css::uno::Any SAL_CALL queryInterface( const css::uno::Type & rType ) override; +voidSAL_CALL acquire() noexcept override { OWeakObject::acquire(); } +voidSAL_CALL release() noexcept override { OWeakObject::release(); } + +// css::lang::XTypeProvider +css::uno::Sequence< css::uno::Type > SAL_CALL getTypes() override; +css::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId() override; + + +// css::awt::XSpinField +void SAL_CALL addSpinListener( const css::uno::Reference< css::awt::XSpinListener >& l ) override; +void SAL_CALL removeSpinListener( const css::uno::Reference< css::awt::XSpinListener >& l ) override; +void SAL_CALL up( ) override; +void SAL_CALL down( ) override; +void SAL_CALL first( ) override; +void SAL_CALL last( ) override; +void SAL_CALL enableRepeat( sal_Bool bRepeat ) override; + +static void ImplGetPropertyIds( std::vector< sal_uInt16 > ); +virtual voidGetPropertyIds( std::vector< sal_uInt16 > ) override { return ImplGetPropertyIds( aIds ); } +}; + +class SVTXFormattedField : public VCLXSpinField +{ +protected: +rtl::Reference m_xCurrentSupplier; +boolbIsStandardSupplier; + +sal_Int32 nKeyToSetDelayed; + +public: +SVTXFormattedField(); +virtual ~SVTXFormattedField() override; + +// css::awt::XVclWindowPeer +void SAL_CALL setProperty( const OUString& PropertyName, const css::uno::Any& Value ) override; +css::uno::Any SAL_CALL getProperty( const OUString& PropertyName ) override; + +protected: +voidsetFormatsSupplier(const css::uno::Reference< css::util::XNumberFormatsSupplier > & xSupplier); +sal_Int32 getFormatKey() const; +voidsetFormatKey(sal_Int32 nKey); + +voidSetValue(const css::uno::Any& rValue); +css::uno::Any GetValue() const; + +voidSetTreatAsNumber(bool bSet); +boolGetTreatAsNumber() const; + +voidSetDefaultValue(const css::uno::Any& rValue); +css::uno::Any GetDefaultValue() const; + +voidSetMinValue(const css::uno::Any& rValue); +css::uno::Any GetMinValue() const; + +voidSetMaxValue(const css::uno::Any& rValue); +css::uno::Any GetMaxValue() const; + +voidNotifyTextListeners(); +css::uno::Any convertEffectiveValue(const css::uno::Any& rValue); + +virtual voidSetWindow( const VclPtr< vcl::Window > &_pWindow) override; + +static void ImplGetPropertyIds( std::vector< sal_uInt16 > ); +virtual voidGetPropertyIds( std::vector< sal_uInt16 > ) override { return ImplGetPropertyIds( aIds ); } +}; + +class SVTXNumericField final : public css::awt::XNumericField, public SVTXFormattedField +{ +public: +SVTXNumericField(); +virtual ~SVTXNumericField() override; + +// css::uno::XInterface +css::uno::Any SAL_CALL queryInterface( const css::uno::Type & rType ) override; +void SAL_CALL acquire() noexcept override { SVTXFormattedField::acquire(); } +void SAL_CALL release() noexcept override { SVTXFormattedField::release(); } + +// css::lang::XTypeProvider +css::uno::Sequence< css::uno::Type > SAL_CALL getTypes() override; +css::uno::Sequence< sal_Int8
[Libreoffice-commits] core.git: sc/source
sc/source/ui/docshell/docfunc.cxx |3 ++- sc/source/ui/view/dbfunc3.cxx | 10 -- sc/source/ui/view/viewdata.cxx|6 -- sc/source/ui/view/viewfunc.cxx| 16 4 files changed, 26 insertions(+), 9 deletions(-) New commits: commit c4bcdb3ec8952fd2a2838629702dd7a00e104f63 Author: Dennis Francis AuthorDate: Fri Jul 2 19:01:47 2021 +0530 Commit: Dennis Francis CommitDate: Wed Jul 28 15:41:37 2021 +0200 lok: sc: avoid crash on non existent tab view data ... when accessing position helpers. Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119604 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx index f98350f0963c..2133ee93bd6e 100644 --- a/sc/source/ui/docshell/docfunc.cxx +++ b/sc/source/ui/docshell/docfunc.cxx @@ -170,7 +170,8 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, bool bPaint, bool bApi ) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pSomeViewForThisDoc->GetDocId()) { - pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow); +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)) +pPosHelper->invalidateByIndex(nStartRow); } pViewShell = SfxViewShell::GetNext(*pViewShell); } diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx index 15141c68a064..8258b52d6846 100644 --- a/sc/source/ui/view/dbfunc3.cxx +++ b/sc/source/ui/view/dbfunc3.cxx @@ -2290,9 +2290,15 @@ void ScDBFunc::OnLOKShowHideColRow(bool bColumns, SCCOLROW nStart) if (pTabViewShell && pTabViewShell->GetDocId() == pThisViewShell->GetDocId()) { if (bColumns) - pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStart); +{ +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStart); +} else - pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex)->invalidateByIndex(nStart); +{ +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStart); +} if (pTabViewShell->getPart() == nCurrentTabIndex) { diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx index 6809df0b38e5..a0a296c73e03 100644 --- a/sc/source/ui/view/viewdata.cxx +++ b/sc/source/ui/view/viewdata.cxx @@ -2322,7 +2322,8 @@ void ScViewData::SetTabNo( SCTAB nNewTab ) ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB nTabIndex) { -if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size( +if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size())) || +!maTabData[nTabIndex]) { return nullptr; } @@ -2331,7 +2332,8 @@ ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB nTabIndex) ScPositionHelper* ScViewData::GetLOKHeightHelper(SCTAB nTabIndex) { -if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size( +if (!ValidTab(nTabIndex) || (nTabIndex >= static_cast(maTabData.size())) || +!maTabData[nTabIndex]) { return nullptr; } diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index 22f2d26cd98a..fbe8a0b3719c 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -1473,7 +1473,8 @@ void ScViewFunc::OnLOKInsertDeleteColumn(SCCOL nStartCol, tools::Long nOffset) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pCurrentViewShell->GetDocId()) { - pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStartCol); +if (ScPositionHelper* pPosHelper = pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)) +pPosHelper->invalidateByIndex(nStartCol); // if we remove a column the cursor position and the current selection // in other views could need to be moved on the left by one column. @@ -1529,7 +1530,8 @@ void ScViewFunc::OnLOKInsertDeleteRow(SCROW nStartRow, tools::Long nOffset) ScTabViewShell* pTabViewShell = dynamic_cast(pViewShell); if (pTabViewShell && pTabViewShell->GetDocId() == pCurrentViewShell->GetDocId()) { -
[Libreoffice-commits] core.git: editeng/source include/editeng sd/source
editeng/source/outliner/outliner.cxx | 20 ++-- editeng/source/outliner/outlvw.cxx | 24 include/editeng/outliner.hxx |6 ++ sd/source/core/drawdoc4.cxx|2 +- sd/source/core/sdpage.cxx |4 ++-- sd/source/ui/dlg/headerfooterdlg.cxx |2 +- sd/source/ui/view/DocumentRenderer.cxx |4 ++-- sd/source/ui/view/drtxtob.cxx |2 +- sd/source/ui/view/drviews2.cxx |4 ++-- sd/source/ui/view/drviewse.cxx |2 +- 10 files changed, 34 insertions(+), 36 deletions(-) New commits: commit cc7ff6d890ab2cacc7f0273039b15689dad5e0dd Author: Mike Kaganski AuthorDate: Wed Jul 28 15:20:51 2021 +0300 Commit: Mike Kaganski CommitDate: Wed Jul 28 15:34:29 2021 +0200 Three identical functions for a class is a bit too much Change-Id: Ia949f3fe2cbbc8aa524347854faa23807d58e252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119606 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/editeng/source/outliner/outliner.cxx b/editeng/source/outliner/outliner.cxx index 49ac38415987..7ffa2de88589 100644 --- a/editeng/source/outliner/outliner.cxx +++ b/editeng/source/outliner/outliner.cxx @@ -194,7 +194,7 @@ void Outliner::Init( OutlinerMode nMode ) SetMaxDepth( 9 ); -switch ( ImplGetOutlinerMode() ) +switch ( GetOutlinerMode() ) { case OutlinerMode::TextObject: case OutlinerMode::TitleObject: @@ -249,7 +249,7 @@ void Outliner::SetDepth( Paragraph* pPara, sal_Int16 nNewDepth ) ImplInitDepth( nPara, nNewDepth, true ); ImplCalcBulletText( nPara, false, false ); -if ( ImplGetOutlinerMode() == OutlinerMode::OutlineObject ) +if ( GetOutlinerMode() == OutlinerMode::OutlineObject ) ImplSetLevelDependentStyleSheet( nPara ); DepthChangedHdl(pPara, nPrevFlags); @@ -374,7 +374,7 @@ std::unique_ptr Outliner::CreateParaObject( sal_Int32 nStart return nullptr; std::unique_ptr xText = pEditEngine->CreateTextObject( nStartPara, nCount ); -const bool bIsEditDoc(OutlinerMode::TextObject == ImplGetOutlinerMode()); +const bool bIsEditDoc(OutlinerMode::TextObject == GetOutlinerMode()); ParagraphDataVector aParagraphDataVector(nCount); const sal_Int32 nLastPara(nStartPara + nCount - 1); @@ -384,7 +384,7 @@ std::unique_ptr Outliner::CreateParaObject( sal_Int32 nStart } std::unique_ptr pPObj(new OutlinerParaObject(std::move(xText), aParagraphDataVector, bIsEditDoc)); -pPObj->SetOutlinerMode(GetMode()); +pPObj->SetOutlinerMode(GetOutlinerMode()); return pPObj; } @@ -443,8 +443,8 @@ void Outliner::SetText( const OUString& rText, Paragraph* pPara ) // In the outliner mode, filter the tabs and set the indentation // about a LRSpaceItem. In EditEngine mode intend over old tabs -if( ( ImplGetOutlinerMode() == OutlinerMode::OutlineObject ) || -( ImplGetOutlinerMode() == OutlinerMode::OutlineView ) ) +if( ( GetOutlinerMode() == OutlinerMode::OutlineObject ) || +( GetOutlinerMode() == OutlinerMode::OutlineView ) ) { // Extract Tabs sal_Int32 nTabs = 0; @@ -686,7 +686,7 @@ void Outliner::ImplCheckNumBulletItem( sal_Int32 nPara ) void Outliner::ImplSetLevelDependentStyleSheet( sal_Int32 nPara ) { -DBG_ASSERT( ( ImplGetOutlinerMode() == OutlinerMode::OutlineObject ) || ( ImplGetOutlinerMode() == OutlinerMode::OutlineView ), "SetLevelDependentStyleSheet: Wrong Mode!" ); +DBG_ASSERT( ( GetOutlinerMode() == OutlinerMode::OutlineObject ) || ( GetOutlinerMode() == OutlinerMode::OutlineView ), "SetLevelDependentStyleSheet: Wrong Mode!" ); SfxStyleSheet* pStyle = GetStyleSheet( nPara ); @@ -1189,7 +1189,7 @@ void Outliner::ImpTextPasted( sal_Int32 nStartPara, sal_Int32 nCount ) while( nCount && pPara ) { -if( ImplGetOutlinerMode() != OutlinerMode::TextObject ) +if( GetOutlinerMode() != OutlinerMode::TextObject ) { nDepthChangedHdlPrevDepth = pPara->GetDepth(); ParaFlag nPrevFlags = pPara->nFlags; @@ -1240,7 +1240,7 @@ bool Outliner::ImpCanIndentSelectedPages( OutlinerView* pCurView ) // If the first paragraph is on level 0 it can not indented in any case, // possible there might be indentations in the following on the 0 level. -if ( ( mnFirstSelPage == 0 ) && ( ImplGetOutlinerMode() != OutlinerMode::TextObject ) ) +if ( ( mnFirstSelPage == 0 ) && ( GetOutlinerMode() != OutlinerMode::TextObject ) ) { if ( nDepthChangedHdlPrevDepth == 1 ) // is the only page return false; @@ -2123,7 +2123,7 @@ std::unique_ptr Outliner::GetEmptyParaObject() const { std::unique_ptr pEmptyText = pEditEngine->GetEmptyTextObject(); std::unique_ptr pPObj( new OutlinerParaObject(
[Libreoffice-bugs] [Bug 87121] CMIS Google Drive fails on accounts with password which includes special characters
https://bugs.documentfoundation.org/show_bug.cgi?id=87121 Buovjaga changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #14 from Buovjaga --- Cloph tells me the authentication now happens in the browser with the server directly, LibreOffice only gets the return code, so this is obsolete. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112524] [META] Filename bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112524 Bug 112524 depends on bug 88834, which changed state. Bug 88834 Summary: Google Drive file name encoding problem https://bugs.documentfoundation.org/show_bug.cgi?id=88834 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98360 Bug 98360 depends on bug 88834, which changed state. Bug 88834 Summary: Google Drive file name encoding problem https://bugs.documentfoundation.org/show_bug.cgi?id=88834 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88834] Google Drive file name encoding problem
https://bugs.documentfoundation.org/show_bug.cgi?id=88834 Christian Lohmaier changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Christian Lohmaier --- of course not only in LO's dialog it uses correct naming, but also is the same in GDrive in browser. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88834] Google Drive file name encoding problem
https://bugs.documentfoundation.org/show_bug.cgi?id=88834 --- Comment #4 from Christian Lohmaier --- Created attachment 173917 --> https://bugs.documentfoundation.org/attachment.cgi?id=173917=edit no probs with fileencoding anymore no problems with encodings with current master/the fix for bug#101630 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03/sf_string.xhp | 1909 +++-- source/text/sbasic/shared/03120202.xhp |2 2 files changed, 1012 insertions(+), 899 deletions(-) New commits: commit 4a07d8d492c50f0e2db3200790f92e9e18bb5144 Author: Rafael Lima AuthorDate: Sat Jul 24 22:12:28 2021 +0200 Commit: Jean-Pierre Ledure CommitDate: Wed Jul 28 15:23:26 2021 +0200 Adapt SF_String to new method signatures and add Python examples Change-Id: Ifd9fa48fcb34ca8469581b8f3d8aac29f51b8414 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119438 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure diff --git a/source/text/sbasic/shared/03/sf_string.xhp b/source/text/sbasic/shared/03/sf_string.xhp index 2971a2f5b..43db8d582 100644 --- a/source/text/sbasic/shared/03/sf_string.xhp +++ b/source/text/sbasic/shared/03/sf_string.xhp @@ -18,14 +18,14 @@ - - String service - + +String service + - ScriptForge.String service - The String service provides a collection of methods for string processing. These methods can be used to: + ScriptForge.String service + The String service provides a collection of methods for string processing. These methods can be used to: Validate the contents of strings @@ -42,7 +42,7 @@ -Definitions + Definitions Line breaks The String service recognizes the following line breaks: @@ -163,97 +163,110 @@ - Service invocation + Service invocation Before using the ScriptForge.String service the ScriptForge library needs to be loaded using: + + + GlobalScope.BasicLibraries.loadLibrary("ScriptForge") + + Loading the library will create the SF_String object that can be used to call the methods in the String service. + The following code snippets show the three ways to call methods from the String service (the Capitalize method is used as an example): + +Dim s as String : s = "abc def" +s = SF_String.Capitalize(s) ' Abc Def + - GlobalScope.BasicLibraries.LoadLibrary("ScriptForge") +Dim s as String : s = "abc def" +Dim svc : svc = SF_String +s = svc.Capitalize(s) ' Abc Def - The following code snippets show the three ways to call methods in the String service (the ExpandTabs method is used as an example): - -SF_String.ExpandTabs(...) - - -Dim s : s = SF_String -s.ExpandTabs(...) - - -Dim s : s = CreateScriptService("String") -s.ExpandTabs(...) - + +Dim s as String : s = "abc def" +Dim svc : svc = CreateScriptService("String") +s = svc.Capitalize(s) ' Abc Def + + + The code snippet below illustrates how to invoke methods from the String service in Python scripts. The IsIPv4 method is used as an example. + +from scriptforge import CreateScriptService +svc = CreateScriptService("String") +ip_address = '192.168.0.14' +svc.IsIPv4(ip_address) # True + -Properties - The SF_String object provides the following properties: + Properties + The SF_String object provides the following properties for Basic scripts: - Name + Name - ReadOnly + ReadOnly - Description + Description - sfCR + sfCR - Yes + Yes - Carriage return: Chr(13) + Carriage return: Chr(13) - sfCRLF + sfCRLF - Yes + Yes - Carriage return + Linefeed: Chr(13) Chr(10) + Carriage return + Linefeed: Chr(13) Chr(10) - sfLF + sfLF - Yes + Yes - Linefeed: Chr(10) + Linefeed: Chr(10) - sfNEWLINE + sfNEWLINE - Yes + Yes - Carriage return + Linefeed, which can be1) Chr(13) Chr(10) or + Carriage return + Linefeed, which can be1) Chr(13) Chr(10) or 2) Linefeed: Chr(10) depending on the operating system. - sfTAB + sfTAB - Yes + Yes - Horizontal tabulation: Chr(9) + Horizontal tabulation: Chr(9) - You can use the properties above to identify or insert the corresponding characters inside strings. For
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 96c8255875c0ce45c6621999cc1bc4d9a429cb16 Author: Rafael Lima AuthorDate: Wed Jul 28 15:23:26 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Jul 28 15:23:26 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 4a07d8d492c50f0e2db3200790f92e9e18bb5144 - Adapt SF_String to new method signatures and add Python examples Change-Id: Ifd9fa48fcb34ca8469581b8f3d8aac29f51b8414 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119438 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure diff --git a/helpcontent2 b/helpcontent2 index 4373f58e837d..4a07d8d492c5 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4373f58e837de5fe8ae2d0650da53fa881a83f1e +Subproject commit 4a07d8d492c50f0e2db3200790f92e9e18bb5144 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143584] New: In Writer, the SHFT+F3 alters the case of the entire paragraph rather than only the selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=143584 Bug ID: 143584 Summary: In Writer, the SHFT+F3 alters the case of the entire paragraph rather than only the selected text Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: raindrops.from...@gmail.com Description: In Writer, if we select some text in a paragraph, and press SHFT+F3, it affects the case of the entire paragraph; and not just the selected text. Thus if you had already changed the case of other text in that paragraph, your effort is wasted. Steps to Reproduce: 1. Create a paragraph with any text 2. Select some words of the paragraph and press SHFT+F3 repeatedly. 3. Check what happens with the parfagraph. Actual Results: The case of the entire paragraph is cycled Expected Results: The case of only the selected text should be cycled. The remaining text of the paragraph should remain unaffected. Reproducible: Always User Profile Reset: No Additional Info: Locale: en-US Module: TextDocument OS: Windows 10 Home, 64 bit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37134] Tabbed UI: Document-per-tab (similar to Firefox, Opera, gedit) MDI
https://bugs.documentfoundation.org/show_bug.cgi?id=37134 --- Comment #62 from rol...@logikalsolutions.com --- OpenSource projects will always justify not doing something by saying "we don't have the money for it" when they don't want to do it. They simply allocate the money to something else. The reality is there has never been any money for any new feature. The other reality is that an Elephant is a mouse designed by committee. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 43)
https://bugs.documentfoundation.org/show_bug.cgi?id=76260 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3583 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 NISZ LibreOffice Team changed: What|Removed |Added Depends on||143583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143583 [Bug 143583] FILEOPEN DOCX Ending empty paragraphs gone from footnotes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs