[Libreoffice-bugs] [Bug 143927] New: : Auto filter - Quick filter does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=143927 Bug ID: 143927 Summary: : Auto filter - Quick filter does not work Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wolf.seib...@t-online.de Created attachment 174361 --> https://bugs.documentfoundation.org/attachment.cgi?id=174361=edit Picture with an quick filter example When an auto filter is set for a column and you click the button to drop down a list of possible selections, there is a text field on top in which you can type in the first characters of a desired search expression. In previous versions the list below will be cleaned in real time for possible selections. In Version 6 and also now 7 the list doesn't change at all. The quick filter is not working anymore. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141501] Change Page field to Filters in Help for PIVOTTABLE layout dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=141501 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- No, I don't think so. Thank you Rafael. Let's close this one as NB -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf134569_nestedTable.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport10.cxx |6 ++ writerfilter/source/dmapper/DomainMapperTableManager.cxx |6 ++ 3 files changed, 12 insertions(+) New commits: commit 28a7fec1f6465f8bfee417d447eb2e684ffe040b Author: Justin Luth AuthorDate: Sat Aug 14 21:28:50 2021 +0200 Commit: Justin Luth CommitDate: Wed Aug 18 06:21:13 2021 +0200 tdf#134569 writerfilter: move tableParaProps on table endLevel The end-level of a table only comes at the ::finishParagraph of the FOLLOWING paragraph. So for table-in-table, it is necessary to move the paragraph properties captured during the paragraph to the correct table level's collection. This fixes 7.0 regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c and depends on prior commit related tdf#134569 writerfilter: negative means table end Change-Id: I83183f38e1cf68b7db09813ca1b4a2491e7b54e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120526 Tested-by: Jenkins Tested-by: László Németh Reviewed-by: Justin Luth Reviewed-by: László Németh diff --git a/sw/qa/extras/ooxmlexport/data/tdf134569_nestedTable.docx b/sw/qa/extras/ooxmlexport/data/tdf134569_nestedTable.docx new file mode 100755 index ..7fb07eb32a19 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf134569_nestedTable.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx index 9f26fd565035..b20d0b07 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx @@ -395,6 +395,12 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf133735, "fdo73389.docx") assertXPath(pXmlDoc, "/w:document/w:body/w:tbl/w:tr/w:tc/w:tbl/w:tr[1]/w:tc[3]/w:p/w:pPr/w:spacing", "after", "0"); } +DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf134569_nestedTable, "tdf134569_nestedTable.docx") +{ +// non-overridden w:after spacing in the table was pushing the document to the second page. +CPPUNIT_ASSERT_EQUAL(1, getPages()); +} + DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf59274, "tdf59274.docx") { // Table with "auto" table width and incomplete grid: 11 columns, but only 4 gridCol elements. diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx b/writerfilter/source/dmapper/DomainMapperTableManager.cxx index e0f0ae18a160..6689a36091ad 100644 --- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx +++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx @@ -511,7 +511,13 @@ void DomainMapperTableManager::endLevel( ) m_aTablePositions.pop_back(); m_aTableStyleNames.pop_back(); m_aMoved.pop_back( ); + +std::optional oParagraph; +if (getTableDepthDifference() < 0 && !m_aParagraphsToEndTable.top()->empty()) +oParagraph = m_aParagraphsToEndTable.top()->back(); m_aParagraphsToEndTable.pop(); +if (oParagraph && m_aParagraphsToEndTable.size()) +m_aParagraphsToEndTable.top()->push_back(*oParagraph); } void DomainMapperTableManager::endOfCellAction()
[Libreoffice-bugs] [Bug 134569] FILEOPEN DOCX Paragraph after nested table gets unexpected spacing
https://bugs.documentfoundation.org/show_bug.cgi?id=134569 --- Comment #7 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/28a7fec1f6465f8bfee417d447eb2e684ffe040b tdf#134569 writerfilter: move tableParaProps on table endLevel It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143914] EDITING Rejecting character highlight does not work for first try
https://bugs.documentfoundation.org/show_bug.cgi?id=143914 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136126] FILESAVE Bad linking of file data between instances during autosaves
https://bugs.documentfoundation.org/show_bug.cgi?id=136126 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143690] HTML tables with footer (tfoot tag) pasted in Calc are loosing footer data
https://bugs.documentfoundation.org/show_bug.cgi?id=143690 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135698] Existing user data gets ignored at install
https://bugs.documentfoundation.org/show_bug.cgi?id=135698 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142561] Editing: Enable unformated text copy of Calc cells containing line breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=142561 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142907] Error opening help page for Insert-Field
https://bugs.documentfoundation.org/show_bug.cgi?id=142907 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143700] Libreoffice All Modules Bug Reporting
https://bugs.documentfoundation.org/show_bug.cgi?id=143700 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140492] 5 bugs related to tables
https://bugs.documentfoundation.org/show_bug.cgi?id=140492 --- Comment #3 from QA Administrators --- Dear Don Meinsen, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139137] macOS Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139137] macOS Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 --- Comment #15 from QA Administrators --- Dear rtpbs20, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140487] Crash in: WinFontInstance::ImplGetGlyphBoundRect(unsigned short, tools::Rectangle &, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=140487 --- Comment #2 from QA Administrators --- Dear Deborah Smith, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140364] xml bug
https://bugs.documentfoundation.org/show_bug.cgi?id=140364 --- Comment #2 from QA Administrators --- Dear Ovidiu, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125269] Some tools disappear from contextual single Notebookbar when cursor is refocused into a Writer table
https://bugs.documentfoundation.org/show_bug.cgi?id=125269 --- Comment #2 from QA Administrators --- Dear Roman Kuznetsov, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125225] Menubar colour should be the same with Notebookbar and standard toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125225 --- Comment #3 from QA Administrators --- Dear andreas_k, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143926] New: Slow startup of Calc on Windows 11 latest beta
https://bugs.documentfoundation.org/show_bug.cgi?id=143926 Bug ID: 143926 Summary: Slow startup of Calc on Windows 11 latest beta Product: LibreOffice Version: 7.0.6.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hupkabu...@gmail.com Description: On Windows 10 my spreadsheet would appear in about 1.5 seconds. Every since I upgraded to Windows 11 Beta, it takes about 15 seconds to start. I'm using the stable version of LibreOffice, not the beta. Perhaps LibreOffice has not yet been optimized for Windows 11? I'm a Windows Insider (Beta Channel). The spreadsheet is a simple check register, no complex formulas or anything fancy. Steps to Reproduce: See description above. Actual Results: See description above. Expected Results: What steps. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.6.2 (x64) Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 12; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143867] Python Implementation Poorly Conceived with No Package Installation Process
https://bugs.documentfoundation.org/show_bug.cgi?id=143867 --- Comment #6 from flywire --- Created attachment 174360 --> https://bugs.documentfoundation.org/attachment.cgi?id=174360=edit Pip Missing DLL Error pip maintainers consider LibreOffice python install is incomplete because pip should be installed as part of the distribution - https://github.com/pypa/pip/issues/10006#issuecomment-899956947 Regardless, it will not run following pip documentation. *IF* pip is installed properly then packages install as expected. Installing in as a venv still needs consideration. Tested on LibreOffice 7.2 (Python 3.8) [LibreOffice 7.0 (Python 3.7) not tested]. Following [Ensure you can run pip from the command line](https://packaging.python.org/tutorials/installing-packages/#id13) > If that still doesn’t allow you to run python -m pip ``` Microsoft Windows [Version 10.0.19043.1165] (c) Microsoft Corporation. All rights reserved. C:\Program Files\LibreOffice\program>python -m get-pip.py C:\Program Files\LibreOffice\program\python-core-3.8.10\bin\python.exe: Error while finding module specification for 'get-pip.py' (ModuleNotFoundError: __path__ attribute not found on 'get-pip' while trying to find 'get-pip.py') C:\Program Files\LibreOffice\program>python get-pip.py Defaulting to user installation because normal site-packages is not writeable Collecting pip Using cached pip-21.2.4-py3-none-any.whl (1.6 MB) Installing collected packages: pip Attempting uninstall: pip Found existing installation: pip 21.2.4 Uninstalling pip-21.2.4: Successfully uninstalled pip-21.2.4 WARNING: The scripts pip.exe, pip3.8.exe and pip3.exe are installed in 'C:\Users\User\AppData\Roaming\Python\Python38\Scripts' which is not on PATH. Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location. Successfully installed pip-21.2.4 ``` I don't know where it found existing installation, it wasn't in the path and that folder was empty until pip was installed. Maybe `get-pip.py` needs to be downloaded to `C:\Program Files\LibreOffice\program\python-core-3.8.10\bin`. **Sadly it won't run because the dll is not in the path or current folder:** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143925] 7.1.5.2 x64 writer: tab set missing, online help is wrong; line spacing wonky
https://bugs.documentfoundation.org/show_bug.cgi?id=143925 --- Comment #1 from Michael Potts --- Created attachment 174359 --> https://bugs.documentfoundation.org/attachment.cgi?id=174359=edit example text misbehaving as described -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143925] New: 7.1.5.2 x64 writer: tab set missing, online help is wrong; line spacing wonky
https://bugs.documentfoundation.org/show_bug.cgi?id=143925 Bug ID: 143925 Summary: 7.1.5.2 x64 writer: tab set missing, online help is wrong; line spacing wonky Product: LibreOffice Version: 7.1.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mich...@casparinstitute.org Description: Trying to set tabs, but tabs are not appearing in the ruler, nor does clicking or control clicking bring them up. Online help says " Choose Format - Paragraph - Tabs tab." but there is no Tabs tab there. On a numbered list I want the elements 1.5 spaced but the multi-line elements single space, and cannot. Steps to Reproduce: 1. start a numbered list using numbers and tabs (the way a normally trained secretary would do), include one multi-line element 2.set all to 1.5 space, then try to single space the multi-line element 3. Try to change the tab distance between the numbers 1. 2. 3. etc. and the start of the text Actual Results: didn't work; had to include 3pt empty line to make the doc look acceptable; never could adjust the width of the tab. Expected Results: a professional looking document with all elements starting in the same place, not too far from the numbers. It needs to be recognized that this tool will be used by trained secretaries who may not know anything more sophisticated than typing 1.[tab]element 1[return]2.[tab]element 2 so rarified list wizards may be cool but won't be used. Reproducible: Always User Profile Reset: No Additional Info: should have been able to move the tab in the ruler; should have been able to set element spacing to single and between elements to 1.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143924] New: Rows Duplicate Text to Row Above
https://bugs.documentfoundation.org/show_bug.cgi?id=143924 Bug ID: 143924 Summary: Rows Duplicate Text to Row Above Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: farrah.humph...@genesisobgyn.net Description: When using Libre Calc, Opening an excel document into LibreOffice When entering information into one row, it appears to have duplicated the same text to the row above. When you actually select the cell that has been "duplicated", it shows in the the text that is duplicated, but on the formula bar it shows the correct text. In some cases, when the cell duplicated to the row above itself, it ruins the format on the sheet. Typically scrolling all the way down the page and back up resolved the problem, but in some cases it does not. I have tried to start the software in safe mode, uninstall it and reinstall it, updated the software, nothing has seem to kick the bug. I have other people around me use the same document with LibreOffice, but this issue only seems to happen on my computer. Steps to Reproduce: 1.Type information into a chart/sheet 2.Information in upper cell gets duplicated with the same information with information from cell below 3.Scroll all the way down the page down and back up to resolve it. Actual Results: Interrupts the accuracy of the information being entered. Format of the sheet is being messed up. Sometimes scrolling down and back up the page does not resolved the issue. Expected Results: To enter information and it stay in the desired cell, and that information would not affect any of the cell around it. Reproducible: Sometimes User Profile Reset: No Additional Info: The software should not be messing up the format/display of the sheet, it should be doing nothing to the other cells surrounding it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2-0' - sc/source
sc/source/core/data/table2.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 376d9889bcd61dbfc0531b2168e2f04736d81d49 Author: Julien Nabet AuthorDate: Mon Aug 16 18:05:12 2021 +0200 Commit: Eike Rathke CommitDate: Wed Aug 18 00:50:14 2021 +0200 tdf#143896: FILESAVE XLS(X) 1001+ rows are lost after saving new file Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2bf3e0d00e3bccb5b250642ee0d3fdbe6cae8ecc tdf#104502 sc: skip hidden columns at printing pages Page calculation counted the hidden columns, resulted printing blank pages by accident. Extend GetPrintArea() and GetTableArea() to count pages without the hidden columns, too. Change-Id: I77e7d6d893967a3ddac4c7c4e225769b38b44649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120449 Tested-by: Jenkins Reviewed-by: Christian Lohmaier (cherry picked from commit ab6c339faa15bf324f1161678717f02dbf8c19f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120450 Reviewed-by: Xisco Fauli Reviewed-by: Adolfo Jayme Barrientos Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx index af36f60f0d9e..69bfec7ed100 100644 --- a/sc/source/core/data/table2.cxx +++ b/sc/source/core/data/table2.cxx @@ -1525,6 +1525,7 @@ void ScTable::CopyUpdated( const ScTable* pPosTab, ScTable* pDestTab ) const void ScTable::InvalidateTableArea() { bTableAreaValid = false; +bTableAreaVisibleValid = false; } void ScTable::InvalidatePageBreaks()
[Libreoffice-bugs] [Bug 142907] Error opening help page for Insert-Field
https://bugs.documentfoundation.org/show_bug.cgi?id=142907 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||rafael.palma.l...@gmail.com --- Comment #1 from Rafael Lima --- I can confirm that the problem does happen mainly in Calc. However, Calc and Impress do not seem to support the same "Field" functionality as Writer, so that's why the page you mentioned is not opened when you press F1. Calc and Impress support just a limited set of Fields. Some of them have help pages, for example "Date (fixed)" in Impress has a help page. One possible fix would be to create similar pages for the missing targets. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/themesupport2' - editeng/source include/editeng include/sfx2 include/svx sfx2/Library_sfx.mk sfx2/source svx/Library_svxcore.mk svx/source sw/source
editeng/source/items/textitem.cxx | 70 -- include/editeng/colritem.hxx| 48 + include/sfx2/ColorSets.hxx | 91 ++ include/sfx2/sfxsids.hrc|2 include/svx/ColorSets.hxx | 71 -- sfx2/Library_sfx.mk |1 sfx2/source/doc/objxtor.cxx |4 sfx2/source/styles/ColorSets.cxx| 155 sfx2/source/view/viewfrm.cxx|3 svx/Library_svxcore.mk |1 svx/source/styles/ColorSets.cxx | 107 -- sw/source/uibase/sidebar/ThemePanel.cxx | 54 ++- sw/source/uibase/sidebar/ThemePanel.hxx |4 13 files changed, 377 insertions(+), 234 deletions(-) New commits: commit 58b52969f02f26e6b91bfa2527e201d3883a5cae Author: Sarper Akdemir AuthorDate: Wed Jul 28 02:03:12 2021 +0300 Commit: Sarper Akdemir CommitDate: Wed Aug 18 01:19:54 2021 +0300 make colorsets work outside of styles and with direct formatting Change-Id: Id3cb073d4567f4dbc70a52bc08403751f4c8ddd4 diff --git a/editeng/source/items/textitem.cxx b/editeng/source/items/textitem.cxx index ac87db3a2573..ede250142444 100644 --- a/editeng/source/items/textitem.cxx +++ b/editeng/source/items/textitem.cxx @@ -78,6 +78,9 @@ #include #include +#include +#include + using namespace ::com::sun::star; using namespace ::com::sun::star::text; @@ -1313,17 +1316,23 @@ bool SvxContourItem::GetPresentation SvxColorItem::SvxColorItem( const sal_uInt16 nId ) : SfxPoolItem(nId), mColor( COL_BLACK ), -maThemeIndex(-1), -maTintShade(0) +mnThemeIndex(-1), +mnTintShade(0), +// maThemeColorData(std::nullopt), +mpColorSets(nullptr) { +// maThemeColorData = { 4, 0 }; } SvxColorItem::SvxColorItem( const Color& rCol, const sal_uInt16 nId ) : SfxPoolItem( nId ), mColor( rCol ), -maThemeIndex(-1), -maTintShade(0) +mnThemeIndex(-1), +mnTintShade(0), +// maThemeColorData(std::nullopt), +mpColorSets(nullptr) { +// maThemeColorData = { 4, 0 }; } SvxColorItem::~SvxColorItem() @@ -1335,9 +1344,9 @@ bool SvxColorItem::operator==( const SfxPoolItem& rAttr ) const assert(SfxPoolItem::operator==(rAttr)); const SvxColorItem& rColorItem = static_cast(rAttr); -return mColor == rColorItem.mColor && - maThemeIndex == rColorItem.maThemeIndex && - maTintShade == rColorItem.maTintShade; +return mColor == rColorItem.mColor + && mnThemeIndex == rColorItem.mnThemeIndex + && mnTintShade == rColorItem.mnTintShade; } bool SvxColorItem::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) const @@ -1358,12 +1367,12 @@ bool SvxColorItem::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) const } case MID_COLOR_THEME_INDEX: { -rVal <<= maThemeIndex; +rVal <<= mnThemeIndex; break; } case MID_COLOR_TINT_OR_SHADE: { -rVal <<= maTintShade; +rVal <<= mnTintShade; break; } default: @@ -1401,7 +1410,7 @@ bool SvxColorItem::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId ) sal_Int16 nIndex = -1; if (!(rVal >>= nIndex)) return false; -maThemeIndex = nIndex; +mnThemeIndex = nIndex; } break; case MID_COLOR_TINT_OR_SHADE: @@ -1409,7 +1418,7 @@ bool SvxColorItem::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId ) sal_Int16 nTintShade = -1; if (!(rVal >>= nTintShade)) return false; -maTintShade = nTintShade; +mnTintShade = nTintShade; } break; default: @@ -1454,7 +1463,46 @@ void SvxColorItem::dumpAsXml(xmlTextWriterPtr pWriter) const (void)xmlTextWriterEndElement(pWriter); } +const Color& SvxColorItem::GetValue() const +{ +if (mnThemeIndex > -1) +{ +// try to get the pointer for ColorSets if it's not there... +if (!mpColorSets) +{ +if (SfxObjectShell* pObjShell = SfxObjectShell::Current()) +{ +if (const SfxColorSetListItem* pColorSetItem = pObjShell->GetItem(SID_COLOR_SETS)) +{ +mpColorSets = >GetSfxColorSetList(); +} +} +} + +if(mpColorSets) +{ +Color aColor = mpColorSets->getThemeColorSet().getColor(mnThemeIndex); +// only calculate tint or shade applied color if necessary +if(aColor != maCacheColor) +{ +maCacheColor = aColor; +aColor.ApplyTintOrShade(GetTintOrShade()); +mColor = aColor; +// TODO: add some kind of cache invalidation for +//
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f9ce63df1bbbca83164d5730da58f549e9672e5b Author: Olivier Hallot AuthorDate: Tue Aug 17 19:03:47 2021 -0300 Commit: Gerrit Code Review CommitDate: Wed Aug 18 00:03:47 2021 +0200 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-2' to c02776cc419095076090911014195fc57301e6da - Update intro video for online Help pages The patch does not require translation. The videos is not loaded in offline Help Change-Id: Ia8f966d7dc48b3fe1547461a64d4430dfddf75fe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120594 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit 8c962ef5c3feb4f0ed970ab4c90efcace00f6e06) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120582 Reviewed-by: Christian Lohmaier diff --git a/helpcontent2 b/helpcontent2 index a65cd9e1f6b7..c02776cc4190 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a65cd9e1f6b76162853428d38395a02ad6faf7cb +Subproject commit c02776cc419095076090911014195fc57301e6da
[Libreoffice-commits] help.git: Branch 'libreoffice-7-2' - source/text
source/text/shared/06/youtubevideos.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c02776cc419095076090911014195fc57301e6da Author: Olivier Hallot AuthorDate: Tue Aug 17 10:35:16 2021 -0300 Commit: Adolfo Jayme Barrientos CommitDate: Wed Aug 18 00:03:47 2021 +0200 Update intro video for online Help pages The patch does not require translation. The videos is not loaded in offline Help Change-Id: Ia8f966d7dc48b3fe1547461a64d4430dfddf75fe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120594 Tested-by: Jenkins Reviewed-by: Olivier Hallot (cherry picked from commit 8c962ef5c3feb4f0ed970ab4c90efcace00f6e06) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120582 Reviewed-by: Christian Lohmaier diff --git a/source/text/shared/06/youtubevideos.xhp b/source/text/shared/06/youtubevideos.xhp index 5fac26c70..1259eaa04 100644 --- a/source/text/shared/06/youtubevideos.xhp +++ b/source/text/shared/06/youtubevideos.xhp @@ -17,7 +17,7 @@ -https://www.youtube-nocookie.com/embed/PLutwM8XKvo; id="vid_id61521568603544" type="video/youtube" width="700" height="394"/> +https://www.youtube-nocookie.com/embed/cWmURg_rM2o; id="vid_id61521568603544" type="video/youtube" width="700" height="394"/>
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b10b26f01c241b939da9b49f22239d4fea23eb7a Author: Ming Hua AuthorDate: Wed Aug 18 00:02:54 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Aug 18 00:02:54 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to e4f55790b32ad295322c712ed49d0349f4eea66d - ScriptForge Basic: fix example MB_* are properties of the service, so the service variable needs to be properly specified. Change-Id: I033f3e54ca69707c25030723fb5dc426a3ad6691 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120586 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 8c962ef5c3fe..e4f55790b32a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 8c962ef5c3feb4f0ed970ab4c90efcace00f6e06 +Subproject commit e4f55790b32ad295322c712ed49d0349f4eea66d
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03/sf_basic.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e4f55790b32ad295322c712ed49d0349f4eea66d Author: Ming Hua AuthorDate: Tue Aug 17 22:54:40 2021 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Wed Aug 18 00:02:54 2021 +0200 ScriptForge Basic: fix example MB_* are properties of the service, so the service variable needs to be properly specified. Change-Id: I033f3e54ca69707c25030723fb5dc426a3ad6691 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120586 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/sbasic/shared/03/sf_basic.xhp b/source/text/sbasic/shared/03/sf_basic.xhp index aeaa82b06..01acfac5c 100644 --- a/source/text/sbasic/shared/03/sf_basic.xhp +++ b/source/text/sbasic/shared/03/sf_basic.xhp @@ -533,7 +533,7 @@ txt = s.InputBox('Please enter a phrase:', "Dear user") -s.MsgBox(txt, MB_ICONINFORMATION, "Confirmation of phrase") +s.MsgBox(txt, s.MB_ICONINFORMATION, "Confirmation of phrase") For in-depth information please refer to https://wiki.documentfoundation.org/Macros/General/IO_to_Screen; name="Input/Output to Screen with Python">Input/Output to Screen with Python on the Wiki.
[Libreoffice-bugs] [Bug 141501] Change Page field to Filters in Help for PIVOTTABLE layout dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=141501 --- Comment #4 from Rafael Lima --- (In reply to Roman Kuznetsov from comment #3) > So it's a problem in our Help > > Olivier, can you write a codepoint for changing of this problem? Hi Roman, The help page below already mentions the correct names (filters, column fields, etc.) https://help.libreoffice.org/7.3/en-US/text/scalc/guide/datapilot_createtable.html?DbPAR=CALC#bm_id3148491 Also, in the dialog, if you click the Help button the following page will appear: https://help.libreoffice.org/7.3/en-US/text/scalc/01/12090102.html?System=UNIX=CALC=modules/scalc/ui/pivottablelayoutdialog/help#bm_id31545141 Note that this page already has the correct naming. Do you think anything needs to be improved in any of these pages? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/source
starmath/source/mathml/import.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit af1b2ea5a6d49ddeb376e83f8ca7d053b17afa20 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:43:02 2021 +0200 Commit: Andrea Gelmini CommitDate: Tue Aug 17 23:43:27 2021 +0200 Removed duplicated include Change-Id: I4103d44e0535b39555f2f62e36ce6109e39cabfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120595 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/starmath/source/mathml/import.cxx b/starmath/source/mathml/import.cxx index 4d0da69c559d..f1987d370971 100644 --- a/starmath/source/mathml/import.cxx +++ b/starmath/source/mathml/import.cxx @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include
[Libreoffice-bugs] [Bug 98232] Missing help for control points of shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=98232 --- Comment #5 from Rafael Lima --- > 1. Corner radius is only active for textbox. Always greyed out for shapes. I have just tested that in LO 7.2 and indeed corner radius is available only for textboxes (actually SvxShapeText objects). If someone can confirm that this is the way it was supposed to be, I can update the Help page to highlight that "corner radius" is only applicable to text boxes. Currently the help page says "You can only round the corners of a rectangular object." however the option was not available for any rectangular shape besides text boxes. > 2. Slant angle can be entered for textbox, but is not saved and has no > effect. I guess this is something that can be updated in the documentation, saying that Textboxes do not support this option. However, IMO if textboxes really do not support "Slant angle" then the option should be greyed out. > 3. Cannot set control points for textboxes or shapes (of any kind). > Spinboxes can be change, but after OK and reopen dialog, values are reset to > zero, and no control points shown. (One exception, "rounded rectangle" > starts with a Control 1 - X is present, but cannot change Control 1 - Y, or > Control 2 (x and y)) Here I believe there are 2 problems: (1) the documentation should mention that some shapes have 0, 1 or 2 control points. If the shape has 1 control point, the second one will have no effect nor will it be saved. (2) IMO if a shape has one control point, the spinboxes for Control Point 2 should be automatically greyed out to avoid confusion with users. In summary, I believe the dialog needs some rework to automatically detect which options should be available to users based on the selected object. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134441] default settings for printing notes
https://bugs.documentfoundation.org/show_bug.cgi?id=134441 ffs changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #8 from ffs --- Perfect - thank you - I've previously sought this under tools:options:libreoffice:print but had not notice this! Apologies for not finding it and thank you for your patient help- I will put new toner in my printer to celebrate! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 134441] default settings for printing notes
https://bugs.documentfoundation.org/show_bug.cgi?id=134441 ffs changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #8 from ffs --- Perfect - thank you - I've previously sought this under tools:options:libreoffice:print but had not notice this! Apologies for not finding it and thank you for your patient help- I will put new toner in my printer to celebrate! -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 122043] [META] generic bugs more common under gtk3
https://bugs.documentfoundation.org/show_bug.cgi?id=122043 Bug 122043 depends on bug 139220, which changed state. Bug 139220 Summary: Regression: Selection of elements is very slow https://bugs.documentfoundation.org/show_bug.cgi?id=139220 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143905] Firebird. Buit-in driver to connect to a firebird server (multi-user mode)
https://bugs.documentfoundation.org/show_bug.cgi?id=143905 jcs...@libreoffice.org changed: What|Removed |Added Summary|Firebird. Buit-in driver to |Firebird. Buit-in driver to |connect to a firebird |connect to a firebird |server |server (multi-user mode) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command
https://bugs.documentfoundation.org/show_bug.cgi?id=105575 --- Comment #24 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/889df64fbb9534491b76140d63b4340091c763e4 reduce alloc costs for some basegfx objects (tdf#105575) It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: basic/source bridges/source canvas/source chart2/source
basic/source/basmgr/vbahelper.cxx |7 basic/source/classes/global.cxx |5 basic/source/classes/sb.cxx | 19 +- basic/source/classes/sbunoobj.cxx | 14 - basic/source/comp/token.cxx |7 basic/source/runtime/runtime.cxx| 19 +- bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx |6 canvas/source/cairo/cairo_canvashelper.cxx | 21 -- canvas/source/cairo/cairo_devicehelper.cxx | 15 - canvas/source/tools/canvastools.cxx | 24 --- canvas/source/vcl/devicehelper.cxx | 18 +- chart2/source/model/template/StockChartTypeTemplate.cxx | 80 +++--- chart2/source/tools/RegressionCurveModel.cxx| 62 ++-- chart2/source/tools/RegressionEquation.cxx | 122 ++-- 14 files changed, 152 insertions(+), 267 deletions(-) New commits: commit 4dc40659044566280c202e26cab97d682ae6ab54 Author: Noel Grandin AuthorDate: Tue Aug 17 11:38:31 2021 +0200 Commit: Noel Grandin CommitDate: Tue Aug 17 22:40:40 2021 +0200 rtl::Static -> thread-safe static local Change-Id: I9f8fe250813f4f376dc46c6f3d7e25e90fdbb50e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120566 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basic/source/basmgr/vbahelper.cxx b/basic/source/basmgr/vbahelper.cxx index 83165374a8f1..7fa101a8259e 100644 --- a/basic/source/basmgr/vbahelper.cxx +++ b/basic/source/basmgr/vbahelper.cxx @@ -27,7 +27,6 @@ #include #include #include -#include namespace basic::vba { @@ -145,8 +144,6 @@ struct CurrDirPool std::map< OUString, OUString > maCurrDirs; }; -struct StaticCurrDirPool : public ::rtl::Static< CurrDirPool, StaticCurrDirPool > {}; - } // namespace @@ -167,7 +164,9 @@ void registerCurrentDirectory( const uno::Reference< frame::XModel >& rxModel, c if( rPath.isEmpty() ) return; -CurrDirPool& rPool = StaticCurrDirPool::get(); +static CurrDirPool StaticCurrDirPool; + +CurrDirPool& rPool = StaticCurrDirPool; ::osl::MutexGuard aGuard( rPool.maMutex ); try { diff --git a/basic/source/classes/global.cxx b/basic/source/classes/global.cxx index 1e72e242d94b..d2e3622b4d6f 100644 --- a/basic/source/classes/global.cxx +++ b/basic/source/classes/global.cxx @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -35,12 +34,12 @@ namespace utl::TransliterationWrapper& getTransliteration() { return m_aTransliteration; } }; -class theTransliterationWrapper : public rtl::Static {}; } utl::TransliterationWrapper& SbGlobal::GetTransliteration() { -return theTransliterationWrapper::get().getTransliteration(); +static lclTransliterationWrapper theTransliterationWrapper; +return theTransliterationWrapper.getTransliteration(); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx index e4ee5b508451..f0ab981d62a5 100644 --- a/basic/source/classes/sb.cxx +++ b/basic/source/classes/sb.cxx @@ -177,31 +177,31 @@ namespace { typedef ::rtl::Reference< DocBasicItem > DocBasicItemRef; -class GaDocBasicItems : public rtl::Static,GaDocBasicItems> {}; +std::unordered_map< const StarBASIC *, DocBasicItemRef > gaDocBasicItems; const DocBasicItem* lclFindDocBasicItem( const StarBASIC* pDocBasic ) { -auto it = GaDocBasicItems::get().find( pDocBasic ); -auto end = GaDocBasicItems::get().end(); +auto it = gaDocBasicItems.find( pDocBasic ); +auto end = gaDocBasicItems.end(); return (it != end) ? it->second.get() : nullptr; } void lclInsertDocBasicItem( StarBASIC& rDocBasic ) { -DocBasicItemRef& rxDocBasicItem = GaDocBasicItems::get()[ ]; +DocBasicItemRef& rxDocBasicItem = gaDocBasicItems[ ]; rxDocBasicItem.set( new DocBasicItem( rDocBasic ) ); rxDocBasicItem->startListening(); } void lclRemoveDocBasicItem( StarBASIC& rDocBasic ) { -auto it = GaDocBasicItems::get().find( ); -if( it != GaDocBasicItems::get().end() ) +auto it = gaDocBasicItems.find( ); +if( it != gaDocBasicItems.end() ) { it->second->stopListening(); -GaDocBasicItems::get().erase( it ); +gaDocBasicItems.erase( it ); } -for( auto& rEntry : GaDocBasicItems::get() ) +for( auto& rEntry : gaDocBasicItems ) { rEntry.second->clearDependingVarsOnDelete( rDocBasic ); } @@ -1914,8 +1914,7 @@ Reference< frame::XModel > StarBASIC::GetModelFromBasic( SbxObject* pBasic ) void StarBASIC::DetachAllDocBasicItems() { -std::unordered_map< const StarBASIC *, DocBasicItemRef >& rItems = GaDocBasicItems::get(); -for (auto const& item : rItems) +for (auto const& item : gaDocBasicItems) {
[Libreoffice-commits] core.git: basegfx/source
basegfx/source/matrix/b2dhommatrix.cxx|4 +++- basegfx/source/polygon/b2dpolypolygon.cxx |5 - 2 files changed, 7 insertions(+), 2 deletions(-) New commits: commit 889df64fbb9534491b76140d63b4340091c763e4 Author: Noel Grandin AuthorDate: Tue Aug 17 13:39:03 2021 +0200 Commit: Noel Grandin CommitDate: Tue Aug 17 22:40:07 2021 +0200 reduce alloc costs for some basegfx objects (tdf#105575) we can use a default object for the default constructo case, and remove one malloc for each default constructed object Change-Id: I0bec37ef9161a210973abb25669a9f16a5e0ea75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120603 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/basegfx/source/matrix/b2dhommatrix.cxx b/basegfx/source/matrix/b2dhommatrix.cxx index 89088e8ebdbf..badda594c9de 100644 --- a/basegfx/source/matrix/b2dhommatrix.cxx +++ b/basegfx/source/matrix/b2dhommatrix.cxx @@ -31,7 +31,9 @@ namespace basegfx { }; -B2DHomMatrix::B2DHomMatrix() = default; +static o3tl::cow_wrapper DEFAULT; + +B2DHomMatrix::B2DHomMatrix() : mpImpl(DEFAULT) {} B2DHomMatrix::B2DHomMatrix(const B2DHomMatrix&) = default; diff --git a/basegfx/source/polygon/b2dpolypolygon.cxx b/basegfx/source/polygon/b2dpolypolygon.cxx index dcd6133abc4a..36c221eeb106 100644 --- a/basegfx/source/polygon/b2dpolypolygon.cxx +++ b/basegfx/source/polygon/b2dpolypolygon.cxx @@ -200,7 +200,10 @@ public: namespace basegfx { -B2DPolyPolygon::B2DPolyPolygon() = default; +static o3tl::cow_wrapper DEFAULT; + +B2DPolyPolygon::B2DPolyPolygon() : +mpPolyPolygon(DEFAULT) {} B2DPolyPolygon::B2DPolyPolygon(const B2DPolyPolygon&) = default;
[Libreoffice-commits] core.git: svx/source
svx/source/accessibility/ChildrenManagerImpl.cxx | 135 --- 1 file changed, 75 insertions(+), 60 deletions(-) New commits: commit 3d45088a4885671a12dfa48e6c650cb896f7078e Author: Caolán McNamara AuthorDate: Tue Aug 17 15:43:00 2021 +0100 Commit: Caolán McNamara CommitDate: Tue Aug 17 22:36:51 2021 +0200 Resolves: tdf#139220 with ~1000 selected shapes a11y UpdateSelection crawls so fetch the selected shapes once and sort them for quick lookup in the loop over maVisibleChildren. As an aside, not changed here, SvxShapeCollection::getByIndex looks suboptimal with a body of std::vector> aElements(maShapeContainer.getElements()); return uno::makeAny(Reference(aElements[Index].get())); Change-Id: Idec7c003e7c5ee02000d4642d4fdb0d940548d97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120610 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx b/svx/source/accessibility/ChildrenManagerImpl.cxx index 53d1e7596b6b..573427c4714e 100644 --- a/svx/source/accessibility/ChildrenManagerImpl.cxx +++ b/svx/source/accessibility/ChildrenManagerImpl.cxx @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -793,20 +794,6 @@ uno::Reference */ void ChildrenManagerImpl::UpdateSelection() { -Reference xController(maShapeTreeInfo.GetController()); -Reference xSelectionSupplier ( -xController, uno::UNO_QUERY); - -// Try to cast the selection both to a multi selection and to a single -// selection. -Reference xSelectedShapeAccess; -Reference xSelectedShape; -if (xSelectionSupplier.is()) -{ -xSelectedShapeAccess.set( xSelectionSupplier->getSelection(), uno::UNO_QUERY); -xSelectedShape.set( xSelectionSupplier->getSelection(), uno::UNO_QUERY); -} - // Remember the current and new focused shape. AccessibleShape* pCurrentlyFocusedShape = nullptr; AccessibleShape* pNewFocusedShape = nullptr; @@ -815,73 +802,101 @@ void ChildrenManagerImpl::UpdateSelection() VEC_SHAPE vecSelect; int nAddSelect=0; bool bHasSelectedShape=false; -for (const auto& rChild : maVisibleChildren) +if (!maVisibleChildren.empty()) { -AccessibleShape* pAccessibleShape = rChild.GetAccessibleShape(); -if (rChild.mxAccessibleShape.is() && rChild.mxShape.is() && pAccessibleShape!=nullptr) +Reference xController(maShapeTreeInfo.GetController()); +Reference xSelectionSupplier ( +xController, uno::UNO_QUERY); + +// Try to cast the selection both to a multi selection and to a single +// selection. +Reference xSelectedShapeAccess; +Reference xSelectedShape; +if (xSelectionSupplier.is()) { -short nRole = pAccessibleShape->getAccessibleRole(); -bool bDrawShape = ( -nRole == AccessibleRole::GRAPHIC || -nRole == AccessibleRole::EMBEDDED_OBJECT || -nRole == AccessibleRole::SHAPE || -nRole == AccessibleRole::IMAGE_MAP || -nRole == AccessibleRole::TABLE_CELL || -nRole == AccessibleRole::TABLE ); -bool bShapeIsSelected = false; - -// Look up the shape in the (single or multi-) selection. -if (xSelectedShape.is()) +xSelectedShapeAccess.set( xSelectionSupplier->getSelection(), uno::UNO_QUERY); +xSelectedShape.set( xSelectionSupplier->getSelection(), uno::UNO_QUERY); +} + +// tdf#139220 to quickly find if a given drawing::XShape is selected +o3tl::sorted_vector> aSortedSelectedShapes; +if (!xSelectedShape.is() && xSelectedShapeAccess.is()) +{ +sal_Int32 nCount = xSelectedShapeAccess->getCount(); +aSortedSelectedShapes.reserve(nCount); +for (sal_Int32 i = 0; i < nCount; ++i) { -if (rChild.mxShape == xSelectedShape) -{ -bShapeIsSelected = true; -pNewFocusedShape = pAccessibleShape; -} +css::uno::Reference xShape(xSelectedShapeAccess->getByIndex(i), uno::UNO_QUERY); +aSortedSelectedShapes.insert(xShape); } -else if (xSelectedShapeAccess.is()) +} + +for (const auto& rChild : maVisibleChildren) +{ +AccessibleShape* pAccessibleShape = rChild.GetAccessibleShape(); +if (rChild.mxAccessibleShape.is() && rChild.mxShape.is() && pAccessibleShape!=nullptr) { -sal_Int32 nCount=xSelectedShapeAccess->getCount(); -for (sal_Int32 i=0; igetByIndex(i) == rChild.mxShape) +short nRole = pAccessibleShape->getAccessibleRole(); +bool bDrawShape = ( +
[Libreoffice-commits] core.git: include/tools sc/qa sd/qa tools/qa
include/tools/gen.hxx | 11 -- sc/qa/unit/tiledrendering/tiledrendering.cxx |6 ++--- sd/qa/unit/tiledrendering/LOKitSearchTest.cxx | 28 +- tools/qa/cppunit/test_rectangle.cxx | 24 ++ 4 files changed, 50 insertions(+), 19 deletions(-) New commits: commit 17f524a37c81a05e6d448a7186df858a69ada635 Author: Mike Kaganski AuthorDate: Tue Aug 17 11:18:39 2021 +0300 Commit: Mike Kaganski CommitDate: Tue Aug 17 22:32:22 2021 +0200 Fix o3tl::convert for Rectangle, to operate on right/bottom values ... instead of using confusing/ambiguous size having two interpretations. This reverts some of the unit test changes made in commit fa339b3adb53300ae68913bed87e18caf9f2e262. Change-Id: Ic56417703e32c1d92bcee76ad8ff494824bd4a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120564 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx index a9cf170952e6..e68b850b78cb 100644 --- a/include/tools/gen.hxx +++ b/include/tools/gen.hxx @@ -722,8 +722,15 @@ namespace o3tl constexpr tools::Rectangle convert(const tools::Rectangle& rRectangle, o3tl::Length eFrom, o3tl::Length eTo) { -return tools::Rectangle(o3tl::convert(rRectangle.TopLeft(), eFrom, eTo), -o3tl::convert(rRectangle.GetSize(), eFrom, eTo)); +// 1. Create an empty rectangle with correct left and top +tools::Rectangle aRect(o3tl::convert(rRectangle.Left(), eFrom, eTo), + o3tl::convert(rRectangle.Top(), eFrom, eTo)); +// 2. If source has width/heigth, set respective right and bottom +if (!rRectangle.IsWidthEmpty()) +aRect.SetRight(o3tl::convert(rRectangle.Right(), eFrom, eTo)); +if (!rRectangle.IsHeightEmpty()) +aRect.SetBottom(o3tl::convert(rRectangle.Bottom(), eFrom, eTo)); +return aRect; } } // end o3tl diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 18a01a051a17..bc9259b9dc84 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -1225,7 +1225,7 @@ void ScTiledRenderingTest::testInvalidateOnInserRowCol() Scheduler::ProcessEventsToIdle(); CPPUNIT_ASSERT(aView.m_bInvalidateTiles); CPPUNIT_ASSERT_EQUAL(size_t(2), aView.m_aInvalidations.size()); -CPPUNIT_ASSERT_EQUAL(tools::Rectangle(-75, 50985, 32212230, 63989), aView.m_aInvalidations[0]); +CPPUNIT_ASSERT_EQUAL(tools::Rectangle(-75, 50985, 32212230, 63990), aView.m_aInvalidations[0]); // move on the right for (int i = 0; i < 200; ++i) @@ -1242,7 +1242,7 @@ void ScTiledRenderingTest::testInvalidateOnInserRowCol() Scheduler::ProcessEventsToIdle(); CPPUNIT_ASSERT(aView.m_bInvalidateTiles); CPPUNIT_ASSERT_EQUAL(size_t(2), aView.m_aInvalidations.size()); -CPPUNIT_ASSERT_EQUAL(tools::Rectangle(253650, -15, 32212230, 63989), aView.m_aInvalidations[0]); +CPPUNIT_ASSERT_EQUAL(tools::Rectangle(253650, -15, 32212230, 63990), aView.m_aInvalidations[0]); } void ScTiledRenderingTest::testCommentCallback() @@ -1963,7 +1963,7 @@ void ScTiledRenderingTest::testSheetChangeInvalidation() Scheduler::ProcessEventsToIdle(); CPPUNIT_ASSERT(aView1.m_bInvalidateTiles); CPPUNIT_ASSERT_EQUAL(size_t(2), aView1.m_aInvalidations.size()); -CPPUNIT_ASSERT_EQUAL(tools::Rectangle(0, 0, 1310719, 268435455), aView1.m_aInvalidations[0]); +CPPUNIT_ASSERT_EQUAL(tools::Rectangle(0, 0, 1310720, 268435456), aView1.m_aInvalidations[0]); CPPUNIT_ASSERT_EQUAL(tools::Rectangle(0, 0, 10, 10), aView1.m_aInvalidations[1]); CPPUNIT_ASSERT_EQUAL(size_t(1), aView1.m_aInvalidationsParts.size()); CPPUNIT_ASSERT_EQUAL(pModelObj->getPart(), aView1.m_aInvalidationsParts[0]); diff --git a/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx b/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx index dd661553b425..762faaac1b56 100644 --- a/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx +++ b/sd/qa/unit/tiledrendering/LOKitSearchTest.cxx @@ -347,9 +347,9 @@ void LOKitSearchTest::testSearchInPDF() CPPUNIT_ASSERT_EQUAL(1, mpCallbackRecorder->m_nSearchResultCount); CPPUNIT_ASSERT_EQUAL(size_t(1), mpCallbackRecorder->m_aSearchResultSelection.size()); -CPPUNIT_ASSERT_EQUAL(OString("3763, 1331, 1432, 482"), +CPPUNIT_ASSERT_EQUAL(OString("3763, 1331, 1432, 483"), mpCallbackRecorder->m_aSearchResultSelection[0]); -CPPUNIT_ASSERT_EQUAL(tools::Rectangle(Point(3763, 1331), Size(1433, 483)), +CPPUNIT_ASSERT_EQUAL(tools::Rectangle(Point(3763, 1331), Size(1433, 484)), mpCallbackRecorder->m_aSelection[0]); // Search again - same result @@ -359,9 +359,9 @@ void LOKitSearchTest::testSearchInPDF() CPPUNIT_ASSERT_EQUAL(2,
[Libreoffice-bugs] [Bug 143894] 7.2.0.3 release: external skia build fails with freetype 2.11
https://bugs.documentfoundation.org/show_bug.cgi?id=143894 re...@rezso.net changed: What|Removed |Added CC||re...@rezso.net --- Comment #2 from re...@rezso.net --- skia m93 with a patch is good, but m94 *requires* freetype 2.11. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - comphelper/source include/comphelper
comphelper/source/misc/traceevent.cxx |7 ++- include/comphelper/profilezone.hxx| 12 +++- 2 files changed, 13 insertions(+), 6 deletions(-) New commits: commit 5c84de37ada9f5835bf0a644b0d5b7f7c7dedd2c Author: Gopi Krishna Menon AuthorDate: Thu Jul 29 15:21:13 2021 +0530 Commit: Tor Lillqvist CommitDate: Tue Aug 17 22:26:52 2021 +0200 Fix nesting level bug in ProfileZone Move the profile zone global nesting variable into the source from header and make it thread-local. Change-Id: I97751f5c532d8e0e36adb7d9d383bd88f752953f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119657 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tor Lillqvist diff --git a/comphelper/source/misc/traceevent.cxx b/comphelper/source/misc/traceevent.cxx index c379bbb97f7e..8b1a9c09427a 100644 --- a/comphelper/source/misc/traceevent.cxx +++ b/comphelper/source/misc/traceevent.cxx @@ -29,7 +29,8 @@ std::size_t TraceEvent::s_nBufferSize = 0; void (*TraceEvent::s_pBufferFullCallback)() = nullptr; int AsyncEvent::s_nIdCounter = 0; -int ProfileZone::s_nNesting = 0; + +static thread_local int nProfileZoneNesting = 0; // Level of Nested Profile Zones namespace { @@ -134,6 +135,10 @@ void ProfileZone::addRecording() + OUString::number(osl_getThreadIdentifier(nullptr)) + "},"); } +int ProfileZone::getNestingLevel() { return nProfileZoneNesting; } + +void ProfileZone::setNestingLevel(int nNestingLevel) { nProfileZoneNesting = nNestingLevel; } + } // namespace comphelper /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/include/comphelper/profilezone.hxx b/include/comphelper/profilezone.hxx index 43c792e0fcf7..ec2a5a41d34a 100644 --- a/include/comphelper/profilezone.hxx +++ b/include/comphelper/profilezone.hxx @@ -23,13 +23,14 @@ namespace comphelper class COMPHELPER_DLLPUBLIC ProfileZone : public NamedEvent { -static int s_nNesting; // level of nested zones. - long long m_nCreateTime; int m_nNesting; void addRecording(); +static void setNestingLevel(int nNestingLevel); +static int getNestingLevel(); + ProfileZone(const char* sName, const OUString ) : NamedEvent(sName, sArgs) , m_nNesting(-1) @@ -38,7 +39,8 @@ class COMPHELPER_DLLPUBLIC ProfileZone : public NamedEvent { m_nCreateTime = getNow(); -m_nNesting = s_nNesting++; +m_nNesting = getNestingLevel(); +setNestingLevel(getNestingLevel() + 1); } else m_nCreateTime = 0; @@ -63,9 +65,9 @@ class COMPHELPER_DLLPUBLIC ProfileZone : public NamedEvent { if (m_nCreateTime > 0) { -s_nNesting--; +setNestingLevel(getNestingLevel() - 1); -if (m_nNesting != s_nNesting) +if (m_nNesting != getNestingLevel()) { SAL_WARN("comphelper.traceevent", "Incorrect ProfileZone nesting for " << m_sName); }
[Libreoffice-commits] core.git: vcl/workben
vcl/workben/pptfuzzer.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit e8180aa5e7c03fe62d958e9e147136abd99ddf82 Author: Caolán McNamara AuthorDate: Wed Aug 11 17:15:19 2021 +0100 Commit: Caolán McNamara CommitDate: Tue Aug 17 22:21:54 2021 +0200 ofz: Indirect-leak Change-Id: Ia29c771d6dbdf37b55ce0e63cc73564bcea6f5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120346 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/vcl/workben/pptfuzzer.cxx b/vcl/workben/pptfuzzer.cxx index 77fe063cb18a..f36cd08d3a9a 100644 --- a/vcl/workben/pptfuzzer.cxx +++ b/vcl/workben/pptfuzzer.cxx @@ -13,6 +13,7 @@ #include #include +#include extern "C" { void * i18npool_component_getFactory( const char* , void* , void* ); @@ -132,6 +133,7 @@ extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) __lsan_disable(); CommonInitialize(argc, argv); +SdrObject::GetGlobalDrawObjectItemPool(); comphelper::getProcessServiceFactory()->createInstance("com.sun.star.comp.Draw.PresentationDocument");
[Libreoffice-bugs] [Bug 143905] Firebird. Buit-in driver to connect to a firebird server
https://bugs.documentfoundation.org/show_bug.cgi?id=143905 --- Comment #6 from m.a.riosv --- (In reply to jcsanz from comment #4) > (In reply to m.a.riosv from comment #3) > > Ok let's see, I have not tested, I connect to a FB 2.5 database in windows > > through ODBC from LO. > > > > Maybe LibreOffice is using fbembed.dll to access FB server, fbembed.dll > > blocks other access to the same database. > > A trick could be to copy fbclient.dll from the FB server installation, > > overwritten the LO fbembed.dll I use this way to connect with other program > > FB's database. > > I´m not asking a solution of my problem, but an easy way to escalate from > embedded database to a server one for any user Then please change the title to add something like 'in multiuser mode' -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143690] HTML tables with footer (tfoot tag) pasted in Calc are loosing footer data
https://bugs.documentfoundation.org/show_bug.cgi?id=143690 Eleonora Govallo changed: What|Removed |Added Ever confirmed|0 |1 CC||elya.gova...@gmail.com Status|UNCONFIRMED |NEW --- Comment #1 from Eleonora Govallo --- Repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: adf65471e889676a600a9c6d0454c75cbd549ad3 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ru-RU (ru_RU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-13_04:44:18 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141461] Auto Correct not activating
https://bugs.documentfoundation.org/show_bug.cgi?id=141461 Lena Dodul changed: What|Removed |Added CC||officelen...@gmail.com --- Comment #6 from Lena Dodul --- no repro in Version: 7.3.0.0.alpha0+ (x86) / LibreOffice Community Build ID: ee5a1b61b4460b965413a3f7ed4f9152322f1c02 CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82380] Wrong "Reached the end of the document" text with 'Find Next' and 'Find Previous'
https://bugs.documentfoundation.org/show_bug.cgi?id=82380 --- Comment #10 from Ezinne --- The bug is still present in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 7c1bad415ae48635dc67041c413bb7b76a530c22 CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-05_06:55:03 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136126] FILESAVE Bad linking of file data between instances during autosaves
https://bugs.documentfoundation.org/show_bug.cgi?id=136126 Eleonora Govallo changed: What|Removed |Added CC||elya.gova...@gmail.com --- Comment #1 from Eleonora Govallo --- Hello! Please update your office to the latest version and try to reproduce the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95038] Chart: Add Arrow support to Line Charts
https://bugs.documentfoundation.org/show_bug.cgi?id=95038 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8563 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138563] FILEOPEN XLSX Line shapes ending arrows not imported for shapes placed in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=138563 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||038 CC||ba...@caesar.elte.hu -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142519] Language direction LTR/RTL is not working in Impress comment box
https://bugs.documentfoundation.org/show_bug.cgi?id=142519 --- Comment #3 from Eleonora Govallo --- I don't understand how exactly you change text direction in Impress. I know how it to change it in Calc (Menu "sheet"=> Right-toLeft) But how can i make it in Impress? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143869] Marking a part of Draw-page locks the linux system
https://bugs.documentfoundation.org/show_bug.cgi?id=143869 --- Comment #5 from BogdanB --- Is hapening also in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 615a340fcf05845397ea3c9917e2eadf074b4514 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded, so it is not yest solved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143869] Marking a part of Draw-page locks the linux system
https://bugs.documentfoundation.org/show_bug.cgi?id=143869 BogdanB changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from BogdanB --- I opened Draw and opened your PDF. If I want to select all the shapes next to Bosch the system is freezing. I had to restart my computer. Confirm with Version: 7.1.5.2 / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ure/source
ure/source/uretest/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3678fca9098d4e61135cc732e8e37da3e6cab626 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:50:50 2021 +0200 Commit: Julien Nabet CommitDate: Tue Aug 17 20:17:51 2021 +0200 Fix typo Change-Id: Ib67f29eec54557811eb1136673030249b296289e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120599 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/ure/source/uretest/README b/ure/source/uretest/README index 8b4f8dcb7218..2699156a5e59 100644 --- a/ure/source/uretest/README +++ b/ure/source/uretest/README @@ -68,7 +68,7 @@ Makefile and Makefile.pln can execute the following tests: Builds a C++ UNO component, cppmain.uno, and runs the component with the uno executable. The component first attempts to instantiate all the UNO services and singletons that are part of the URE installation. The component then tries -to instantiate and to call another C++ UNO component (ccptest.uno) as well as a +to instantiate and to call another C++ UNO component (cpptest.uno) as well as a Java UNO component (javatest.uno). The test completes when these components throw a special exception that is caught by cppmain.uno.
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #25 from Robert Großkopf --- (In reply to Silvain Dupertuis from comment #22) > (In reply to Robert Großkopf from comment #19) > > And a second very simple solution: > > Set the Calc file as datasource of a new *.odb-file. > > Copy the content from the Calc-database-file to your database. > > Linebreaks will be imported to the internal database. > > I tested this and it does not work. > Line-breaks are lost if I create a fresh database and connect to the example > calc file as datasource This isn't what I described: 1. You need a Calc document with fields, which may have also linebreaks. 2. You need a first database, which only connects to Calc. 3. You need a second database, to which you will copy the content with the linebreaks. The fields for the table must be datatype Memo (LONGVARCHAR in HSQLDB, BLOB in Firebird). The linebreaks will be shown in the second database. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143853] RegistryModifications setting for Asian language cannot be simply set false
https://bugs.documentfoundation.org/show_bug.cgi?id=143853 --- Comment #5 from Justin L --- (In reply to Timur from comment #3) > In Common I tried with this to set Macro Security to Medium but it didn't > work, seems some issue with long type: It works with "int" (again discovered by trial and error). >
[Libreoffice-bugs] [Bug 117881] FILEOPEN DOCX: Spacing in Linux is slightly different from Windows for bullet lists with Microsoft fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=117881 --- Comment #26 from Marco Diego Aurélio Mesquita --- Another strong evidence: after "winetricks corefonts" MSO under wine displayed to file just like its MacOS version. Unfortunately "apt install ttf-mscorefonts-installer" had no effect on libreoffice (the non flatpak version). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 --- Comment #8 from Nik Gervae --- This is not about a use case; this is about how the app should just behave by default. Once again, I state that no other spreadsheet app I've used be3haves the way LibreOffice does in this regard, and I see no advantage to it behaving this way. The fact that I can jump through some hoops, every single time I create a spreadsheet, to get it to behave rationally, doesn't mitigate the fact that this is hostile UI. And what if I have some columns that I legitimately need to hide and unhide? I'd have to go and rehide all the empty columns every time too. It's hassle all around when just *not* adding empty cells on scrolling, like every other spreadsheet out there, would avoid all this. I will also note that ctrl+end doesn't work for me, I'm on a laptop and have to use fn to get the arrow keys to act like those keys, and while that works in other apps, in LibreOffice, doing so does nothing (at least page up/down do work). I can't even option+click in the scroll bar to get it to jump to the cursoru, it just scrolls one windowful. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 136119] Spreadsheets should not have "infinite" number of cells
https://bugs.documentfoundation.org/show_bug.cgi?id=136119 --- Comment #8 from Nik Gervae --- This is not about a use case; this is about how the app should just behave by default. Once again, I state that no other spreadsheet app I've used be3haves the way LibreOffice does in this regard, and I see no advantage to it behaving this way. The fact that I can jump through some hoops, every single time I create a spreadsheet, to get it to behave rationally, doesn't mitigate the fact that this is hostile UI. And what if I have some columns that I legitimately need to hide and unhide? I'd have to go and rehide all the empty columns every time too. It's hassle all around when just *not* adding empty cells on scrolling, like every other spreadsheet out there, would avoid all this. I will also note that ctrl+end doesn't work for me, I'm on a laptop and have to use fn to get the arrow keys to act like those keys, and while that works in other apps, in LibreOffice, doing so does nothing (at least page up/down do work). I can't even option+click in the scroll bar to get it to jump to the cursoru, it just scrolls one windowful. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: include/comphelper
include/comphelper/multicontainer2.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3be26178dc29ed4f8637218e0d49d1bf77e124d2 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:50:23 2021 +0200 Commit: Julien Nabet CommitDate: Tue Aug 17 19:33:32 2021 +0200 Fix typo Change-Id: I8cf2ea25ee343b747497a8a83edb48c2421863bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120596 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/comphelper/multicontainer2.hxx b/include/comphelper/multicontainer2.hxx index 33f82dcb5c20..ad5ffca7cb95 100644 --- a/include/comphelper/multicontainer2.hxx +++ b/include/comphelper/multicontainer2.hxx @@ -42,7 +42,7 @@ class XInterface; /** */ //for docpp namespace comphelper { -/** This is a copy of cppu::OMultiTypeInterfaceContainerHelper2 in include/ccppuhelper/interfacecontainer.h, +/** This is a copy of cppu::OMultiTypeInterfaceContainerHelper2 in include/cppuhelper/interfacecontainer.h, except that it uses comphelper::OInterfaceContainerHelper2, which is more efficient. */ class COMPHELPER_DLLPUBLIC OMultiTypeInterfaceContainerHelper2
[Libreoffice-bugs] [Bug 117881] FILEOPEN DOCX: Spacing in Linux is slightly different from Windows for bullet lists with Microsoft fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=117881 --- Comment #25 from Marco Diego Aurélio Mesquita --- Actually Office16, not MSO 2016. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117881] FILEOPEN DOCX: Spacing in Linux is slightly different from Windows for bullet lists with Microsoft fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=117881 --- Comment #24 from Marco Diego Aurélio Mesquita --- I tried it again on Ubuntu 20.04 with libreoffice 7.1.5.2 installed through flatpak. Problem still happens. A very interesting find: I tried MSO 2016 (office 365) installed with wine and the output was the same as libreoffice. I then tried with MSO (same version I have on my machine) running on MacOS and it appeared correct there. This makes me think the problem is related to the metrics of the font. I still suggest a fix that changes the metrics specifically for this font spacing when using a bullet list. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143911] FILESAVE DOCX Change tracked character formatting should be saved
https://bugs.documentfoundation.org/show_bug.cgi?id=143911 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #24 from Silvain Dupertuis --- Sorry I only have the latest versions of LibreOffice What I tested : - Having a calc file with multiline cells - Creating a fresh database with the option «connect to an existing database» - Chose the calc file as this existing database. - The sheets appear as tables, but the line-breaks are lost. What I would expect is having linebreaks preserved in both directions when exchanging data between calc and base. One thing I am doing on a regular bases is updating a mysql database for a web-based application from my local Base file. I use a Calc file, connect it with my registered database, copy the desired tables and/or querys, then copy the whole calc file into the mysql database. It works fine and fast, except for line-breaks in some multiline fields... Sorry if the terminology is not exact, I speak French and use a French interface in my installation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/source
starmath/source/mathml/export.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 50f4d711337b84baf22536fac99150c116b0c700 Author: dante AuthorDate: Mon Aug 16 16:48:28 2021 +0200 Commit: Noel Grandin CommitDate: Tue Aug 17 18:29:16 2021 +0200 Improvement to ml element exporter Change-Id: I12303add11406c0ab65ca02084945989f41380d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120549 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/starmath/source/mathml/export.cxx b/starmath/source/mathml/export.cxx index e701f017d7e9..57d9626a239c 100644 --- a/starmath/source/mathml/export.cxx +++ b/starmath/source/mathml/export.cxx @@ -904,7 +904,7 @@ void SmMlExport::exportMlAttributtes(const SmMlElement* pMlElement) { case SmMlAttributeValueMaxsize::MlInfinity: { -addAttribute(XML_MAXSIZE, OUString(u"infinity")); +addAttribute(XML_MAXSIZE, XML_INFINITY); break; } case SmMlAttributeValueMaxsize::MlFinite:
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected CC||er...@redhat.com, ||xiscofa...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||3571 --- Comment #10 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=329eeefcbd65ea88f0c8c3f034d49ba73045d059 author Eike Rathke 2017-11-14 17:39:41 +0100 committer Eike Rathke 2017-11-14 17:40:15 +0100 commit 329eeefcbd65ea88f0c8c3f034d49ba73045d059 (patch) tree05032ad9b703a1089c2a04a7ce68a8bb34cfd0f2 parent ed89b432dff252d3b1a18ad7694bbf2c4abc36ff (diff) Distinguish single/multiple cell copy for plain text, tdf#113571 follow-up Bisected with: bibisect-linux64-6.0 Adding Cc: to Eike Rathke -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141420] [META] UNO Object Inspector - Development tools
https://bugs.documentfoundation.org/show_bug.cgi?id=141420 Bug 141420 depends on bug 143636, which changed state. Bug 143636 Summary: UNO Object Inspector: Crash while inspecting a shape https://bugs.documentfoundation.org/show_bug.cgi?id=143636 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143636] UNO Object Inspector: Crash while inspecting a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=143636 Xisco Faulí changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 143640 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #23 from Timur --- I duplicated this under the assumption that culprit is source Calc and not destination Base. Please confirm by testing version up to 5.4.7 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141420] [META] UNO Object Inspector - Development tools
https://bugs.documentfoundation.org/show_bug.cgi?id=141420 Bug 141420 depends on bug 143638, which changed state. Bug 143638 Summary: UNO Object Inspector: Crash choosing 'inspect' on values from shape properties https://bugs.documentfoundation.org/show_bug.cgi?id=143638 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143638] UNO Object Inspector: Crash choosing 'inspect' on values from shape properties
https://bugs.documentfoundation.org/show_bug.cgi?id=143638 Xisco Faulí changed: What|Removed |Added Resolution|--- |DUPLICATE See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3640 Status|NEW |RESOLVED --- Comment #3 from Xisco Faulí --- GDB trace points to the same place as the gdb in bug 143640, Closing as duplicated *** This bug has been marked as a duplicate of bug 143640 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143636] UNO Object Inspector: Crash while inspecting a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=143636 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3640 CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- it looks like a dupe of bug 143640 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 --- Comment #22 from Silvain Dupertuis --- (In reply to Robert Großkopf from comment #19) > And a second very simple solution: > Set the Calc file as datasource of a new *.odb-file. > Copy the content from the Calc-database-file to your database. > Linebreaks will be imported to the internal database. I tested this and it does not work. Line-breaks are lost if I create a fresh database and connect to the example calc file as datasource -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121541] CRASH moving group box form anchored to character in header
https://bugs.documentfoundation.org/show_bug.cgi?id=121541 Xisco Faulí changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #13 from Xisco Faulí --- The issue got fixed by https://bugs.documentfoundation.org/show_bug.cgi?id=129542, thus closing as DUPLICATED of bug 129542 *** This bug has been marked as a duplicate of bug 129542 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/inc
starmath/inc/mathml/import.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1e1a317be265a176fdbae171953fa8902a823eb8 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:58:17 2021 +0200 Commit: Julien Nabet CommitDate: Tue Aug 17 17:37:21 2021 +0200 Fix typo Change-Id: I93062ed58f820a0f88a236c4134ff9adce06006c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120601 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/starmath/inc/mathml/import.hxx b/starmath/inc/mathml/import.hxx index 916f929440a8..658d62360c4a 100644 --- a/starmath/inc/mathml/import.hxx +++ b/starmath/inc/mathml/import.hxx @@ -88,7 +88,7 @@ private: size_t m_nSmSyntaxVersion; public: -/** Get's parsed element tree +/** Gets parsed element tree */ SmMlElement* getElementTree() { return m_pElementTree; }
[Libreoffice-bugs] [Bug 131546] FILEOPEN DOCX: File takes longer to open in master
https://bugs.documentfoundation.org/show_bug.cgi?id=131546 László Németh changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3904 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: starmath/source
starmath/source/mathml/import.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit da9fc526f3bc84443ae37666d6775c5119b3f1e8 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:58:00 2021 +0200 Commit: Julien Nabet CommitDate: Tue Aug 17 17:36:53 2021 +0200 Fix typo Change-Id: I28ef5ac72fb06406d049e1076f48dcd2d06a42af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120600 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/starmath/source/mathml/import.cxx b/starmath/source/mathml/import.cxx index 39b81b9aaed9..4d0da69c559d 100644 --- a/starmath/source/mathml/import.cxx +++ b/starmath/source/mathml/import.cxx @@ -200,7 +200,7 @@ ErrCode SmMLImportWrapper::Import(SfxMedium& rMedium) bOASIS ? u"com.sun.star.comp.Math.MLOasisMetaImporter" : u"com.sun.star.comp.Math.MLMetaImporter"); -// Check if succefull +// Check if successful if (nWarn != ERRCODE_NONE) { if (xStatusIndicator.is()) @@ -220,7 +220,7 @@ ErrCode SmMLImportWrapper::Import(SfxMedium& rMedium) bOASIS ? u"com.sun.star.comp.Math.MLOasisSettingsImporter" : u"com.sun.star.comp.Math.MLSettingsImporter"); -// Check if succefull +// Check if successful if (nWarn != ERRCODE_NONE) { if (xStatusIndicator.is()) @@ -237,7 +237,7 @@ ErrCode SmMLImportWrapper::Import(SfxMedium& rMedium) // read a component from storage nWarn = ReadThroughComponent(rMedium.GetStorage(), xModelComp, u"content.xml", xContext, xInfoSet, u"com.sun.star.comp.Math.MLImporter"); -// Check if succefull +// Check if successful if (nWarn != ERRCODE_NONE) { if (xStatusIndicator.is())
[Libreoffice-commits] core.git: include/sfx2
include/sfx2/viewsh.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba6b24bfea06ed10e4b9a595b424813d090b3a61 Author: Andrea Gelmini AuthorDate: Tue Aug 17 15:50:34 2021 +0200 Commit: Julien Nabet CommitDate: Tue Aug 17 17:35:31 2021 +0200 Fix typo Change-Id: I05739d1b82ec872cd8c7d68d3945893c9e6c3648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120597 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx index c1d9457419e6..9649b80cc34e 100644 --- a/include/sfx2/viewsh.hxx +++ b/include/sfx2/viewsh.hxx @@ -387,7 +387,7 @@ public: virtual tools::Rectangle getLOKVisibleArea() const { return tools::Rectangle(); } -// Fremium view settings +// Freemium view settings void setFreemiumView(bool isFreemium) { mbLOKIsFreemiumView = isFreemium; } bool isFreemiumView() { return mbLOKIsFreemiumView; } };
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added CC||rac...@megabit.net --- Comment #9 from Timur --- *** Bug 128513 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128513] no linefeeds when importing Calc tables that contain multiline text
https://bugs.documentfoundation.org/show_bug.cgi?id=128513 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #21 from Timur --- This seems like a duplicate of bug 119928. Please verify with testing LO 5.4.7 which didn't have it. *** This bug has been marked as a duplicate of bug 119928 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added Priority|medium |high -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143869] Marking a part of Draw-page locks the linux system
https://bugs.documentfoundation.org/show_bug.cgi?id=143869 --- Comment #3 from Florian W. --- I appended the document as attachment - see attachments. I can't / won't use another version than the one offered in the repos :-) Please check the attachment and description to reproduce the bug. Thanks - Florian -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added CC||patch.pub...@gmail.com --- Comment #8 from Timur --- *** Bug 142561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142561] Editing: Enable unformated text copy of Calc cells containing line breaks
https://bugs.documentfoundation.org/show_bug.cgi?id=142561 Timur changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Timur --- Seems duplicate, please explain if not. And search before reporting. *** This bug has been marked as a duplicate of bug 119928 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Bug 108843 depends on bug 142277, which changed state. Bug 142277 Summary: Special characters in cells not copied to clipboard when copy multiple cells https://bugs.documentfoundation.org/show_bug.cgi?id=142277 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added CC||rgu...@bk.ru --- Comment #7 from Timur --- *** Bug 142277 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142277] Special characters in cells not copied to clipboard when copy multiple cells
https://bugs.documentfoundation.org/show_bug.cgi?id=142277 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Timur --- If by text processor you mean app like Notepad, this is a duplicate. If not please explain. Reporter and tester need to check for existing bugs. *** This bug has been marked as a duplicate of bug 119928 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/jsdialog
vcl/jsdialog/jsdialogbuilder.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit f5d3cfbc0b9bc34cc3297b8a1c179e4c158271b7 Author: Szymon Kłos AuthorDate: Wed Jul 7 11:13:06 2021 +0200 Commit: Szymon Kłos CommitDate: Tue Aug 17 17:13:55 2021 +0200 jsdialog: don't send unnecessary close message Change-Id: I4077c0871c7e6faf4917ad22a1a3aae8eb972961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118549 Tested-by: Jenkins CollaboraOffice Reviewed-by: Szymon Kłos Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120569 Tested-by: Jenkins diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx index 03087e4fd82a..a376faed407d 100644 --- a/vcl/jsdialog/jsdialogbuilder.cxx +++ b/vcl/jsdialog/jsdialogbuilder.cxx @@ -1352,6 +1352,7 @@ JSToolbar::JSToolbar(JSDialogSender* pSender, ::ToolBox* pToolbox, SalInstanceBu void JSToolbar::set_menu_item_active(const OString& rIdent, bool bActive) { +bool bWasActive = get_menu_item_active(rIdent); SalInstanceToolbar::set_menu_item_active(rIdent, bActive); ToolBoxItemId nItemId = m_xToolBox->GetItemId(OUString::fromUtf8(rIdent)); @@ -1370,7 +1371,7 @@ void JSToolbar::set_menu_item_active(const OString& rIdent, bool bActive) if (bActive) sendPopup(pPopupRoot, m_xToolBox->get_id(), OStringToOUString(rIdent, RTL_TEXTENCODING_ASCII_US)); -else +else if (bWasActive) sendClosePopup(pPopupRoot->GetLOKWindowId()); } }
[Libreoffice-commits] core.git: 2 commits - sfx2/source vcl/inc vcl/jsdialog vcl/source
sfx2/source/sidebar/SidebarController.cxx | 26 ++ vcl/inc/jsdialog/jsdialogbuilder.hxx |1 + vcl/jsdialog/jsdialogbuilder.cxx |6 ++ vcl/source/window/toolbox2.cxx| 18 +- 4 files changed, 50 insertions(+), 1 deletion(-) New commits: commit 2ca212f93cb4ae1da84fa71bf70dde24784e8df7 Author: Szymon Kłos AuthorDate: Tue Jul 6 14:15:17 2021 +0200 Commit: Szymon Kłos CommitDate: Tue Aug 17 17:13:44 2021 +0200 jsdialog: sidebar: send message on sidebar close Revert needed code removed in 64bd4dd Change-Id: If45facbd68ea8f3af433b78e127fbb0745e62c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118483 Tested-by: Jenkins CollaboraOffice Reviewed-by: Szymon Kłos Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120565 Tested-by: Szymon Kłos diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx index fff93887c3a7..803d1c10a739 100644 --- a/sfx2/source/sidebar/SidebarController.cxx +++ b/sfx2/source/sidebar/SidebarController.cxx @@ -40,6 +40,7 @@ #include #include #include +#include #include #include #include @@ -1229,6 +1230,31 @@ IMPL_LINK(SidebarController, OnSubMenuItemSelected, const OString&, rCurItemId, void SidebarController::RequestCloseDeck() { +if (comphelper::LibreOfficeKit::isActive() && mpCurrentDeck) +{ +const SfxViewShell* pViewShell = SfxViewShell::Current(); +if (pViewShell && pViewShell->isLOKMobilePhone()) +{ +// Mobile phone - TODO: unify with desktop +tools::JsonWriter aJsonWriter; +aJsonWriter.put("id", mpParentWindow->get_id()); +aJsonWriter.put("type", "dockingwindow"); +aJsonWriter.put("text", mpParentWindow->GetText()); +aJsonWriter.put("enabled", false); +const std::string message = aJsonWriter.extractAsStdString(); +pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, message.c_str()); +} +else if (pViewShell) +{ +tools::JsonWriter aJsonWriter; +aJsonWriter.put("id", mpParentWindow->get_id()); +aJsonWriter.put("action", "close"); +aJsonWriter.put("jsontype", "sidebar"); +const std::string message = aJsonWriter.extractAsStdString(); +pViewShell->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, message.c_str()); +} +} + mbIsDeckRequestedOpen = false; UpdateDeckOpenState(); commit 1692ee279c7d0a6aa8210c923a6923c6919f46d3 Author: Szymon Kłos AuthorDate: Tue Jul 6 11:50:38 2021 +0200 Commit: Szymon Kłos CommitDate: Tue Aug 17 17:13:28 2021 +0200 jsdialog: dump image for toolitems Change-Id: If47eb57cc18c6f04e5b2e3a14a6bcea657e03df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118472 Tested-by: Jenkins CollaboraOffice Reviewed-by: Szymon Kłos Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120543 Tested-by: Szymon Kłos diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx b/vcl/inc/jsdialog/jsdialogbuilder.hxx index cfc5e52e5bb9..8bfa06d0742b 100644 --- a/vcl/inc/jsdialog/jsdialogbuilder.hxx +++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx @@ -568,6 +568,7 @@ public: virtual void set_menu_item_active(const OString& rIdent, bool bActive) override; virtual void set_item_sensitive(const OString& rIdent, bool bSensitive) override; +virtual void set_item_icon_name(const OString& rIdent, const OUString& rIconName) override; }; class JSTextView final : public JSWidget diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx index 4f0e6aa6bfc5..03087e4fd82a 100644 --- a/vcl/jsdialog/jsdialogbuilder.cxx +++ b/vcl/jsdialog/jsdialogbuilder.cxx @@ -1382,6 +1382,12 @@ void JSToolbar::set_item_sensitive(const OString& rIdent, bool bSensitive) sendUpdate(); } +void JSToolbar::set_item_icon_name(const OString& rIdent, const OUString& rIconName) +{ +SalInstanceToolbar::set_item_icon_name(rIdent, rIconName); +sendUpdate(); +} + JSTextView::JSTextView(JSDialogSender* pSender, ::VclMultiLineEdit* pTextView, SalInstanceBuilder* pBuilder, bool bTakeOwnership) : JSWidget(pSender, pTextView, pBuilder, diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx index 47bc4d1ff743..c3f53303e15a 100644 --- a/vcl/source/window/toolbox2.cxx +++ b/vcl/source/window/toolbox2.cxx @@ -21,9 +21,11 @@ #include #include +#include #include #include +#include #include #include #include @@ -1749,15 +1751,29 @@ void ToolBox::DumpAsPropertyTree(tools::JsonWriter& rJsonWriter) } else { +OUString sCommand = GetItemCommand(nId); rJsonWriter.put("type", "toolitem"); rJsonWriter.put("text",
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added Keywords||regression --- Comment #6 from Timur --- No repro 5.4.7, repro 6.0 and 7.3+. Windows paste to Notepad++ looses LF from LO 6.0 (this bug). Paste to MSO Excel writes "multi" and loses "line" even before. Paste to FreeOffice PlanMaker pastes properly before and after. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143916] Crashes in GTK3 with Experimental features and DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=143916 Julien Nabet changed: What|Removed |Added Keywords||wantBacktrace CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today with gtk3 rendering + experimental features enabled, I don't reproduce this. Would it be possible you retrieve a backtrace? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119928] Newline in cell formula are ignored when copy-pasting more than one cell in Calc 6.x
https://bugs.documentfoundation.org/show_bug.cgi?id=119928 Timur changed: What|Removed |Added CC||draga...@hidroinzeniring.si --- Comment #5 from Timur --- *** Bug 143915 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143915] New line (LF) are lost when pasting range of cells from Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=143915 Timur changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Timur --- Looks duplicate, please search before reporting. *** This bug has been marked as a duplicate of bug 119928 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143903] Copying table from writer to calc and then transport it, results crash without log
https://bugs.documentfoundation.org/show_bug.cgi?id=143903 --- Comment #2 from elias estatistics --- 1) I had to attach two files, and here only one file i was allowed to attach. Therefore, i zipped them. 2) No, experimental features are not on. 3) No, I didnt rest my profile in libre and I dont want to. 4) Did you tried to make the steps that I described? did you find this bug or not? -- You are receiving this mail because: You are the assignee for the bug.