[Libreoffice-bugs] [Bug 147468] sheet is not recalculated when value is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147468

--- Comment #8 from raal  ---
(In reply to VLB from comment #7)
> That means that LO version 7.3 is no longer suitable to use and is
> unreliable!
> 
> Unfortunately

Usually it's fixed in minor version 7.3.1, 7.3.2 etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107899] [META] PPTX paragraph-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107899

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||147121


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147121
[Bug 147121] FILESAVE PPTX: font size of empty line break in multi-line list
item increases
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35092

--- Comment #157 from techxso...@gmail.com ---
Amazing piece of content to read and if you are interested for the writing
services then you can check the sample here
https://techxsoft.com/2022/02/17/alienware-area-51-threadripper/
https://techxsoft.com/2021/11/26/list-of-best-sublimation-printers/
https://techxsoft.com/2022/02/17/token-sniffer/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141858] [META] Cross-references dialog issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141858

Dieter  changed:

   What|Removed |Added

 Depends on||146905


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146905
[Bug 146905] Allow cross-references to bookmarks to show the line number
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 146905] Allow cross-references to bookmarks to show the line number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146905

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Blocks||141858

--- Comment #2 from Dieter  ---
Aaron, thank you for your enhancement request. let's as design-team.

cc: Design-Team for further input and decision


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141858
[Bug 141858] [META] Cross-references dialog issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146905] Allow cross-references to bookmarks to show the line number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146905

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Blocks||141858

--- Comment #2 from Dieter  ---
Aaron, thank you for your enhancement request. let's as design-team.

cc: Design-Team for further input and decision


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141858
[Bug 141858] [META] Cross-references dialog issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135894] Add a "Distribution" button to the Tabbed interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135894

--- Comment #7 from andreas_k  ---
No it wasn't me

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147468] sheet is not recalculated when value is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147468

--- Comment #7 from VLB  ---
That means that LO version 7.3 is no longer suitable to use and is unreliable!

Unfortunately

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147503] Crashes when trying to insert a hyperlink.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147503

--- Comment #1 from Saburo  ---
I made a mistake.

Description:
LibreOffice crashes only if the hyperlink is set to [New Document], [XML Form
Document],[Edit later].

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147468] sheet is not recalculated when value is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147468

Timur  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Timur  ---
So if bug is gone in master 7.4+, that's WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf104823.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |   61 +-
 2 files changed, 60 insertions(+), 1 deletion(-)

New commits:
commit bf99f1c09dd093ba70ed9703287b80787aa510f8
Author: Vasily Melenchuk 
AuthorDate: Wed Dec 22 14:16:09 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:29:21 2022 +0100

tdf#104823: unittest

Ensure reading and writing to datasources

Change-Id: Idbc907a21fe3b881d1b835ed0e8c795c4ea36863
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127311
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127334
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130044
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf104823.docx 
b/sw/qa/extras/ooxmlexport/data/tdf104823.docx
new file mode 100644
index ..4a354b848eea
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf104823.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index 64557f56a145..2ef6c105902b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -11,11 +11,14 @@
 #include 
 #include 
 #include 
+#include 
+
+char const DATA_DIRECTORY[] = "/sw/qa/extras/ooxmlexport/data/";
 
 class Test : public SwModelTestBase
 {
 public:
-Test() : SwModelTestBase("/sw/qa/extras/ooxmlexport/data/", "Office Open 
XML Text") {}
+Test() : SwModelTestBase(DATA_DIRECTORY, "Office Open XML Text") {}
 
 protected:
 /**
@@ -784,6 +787,62 @@ DECLARE_OOXMLEXPORT_TEST( testSdtDatePicker, 
"test_sdt_datepicker.docx" )
 CPPUNIT_ASSERT_EQUAL(OUString("008000"), sColor);
 }
 
+CPPUNIT_TEST_FIXTURE(Test, testTdf104823)
+{
+// Test how we can roundtrip sdt plain text with databindings support
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"tdf104823.docx";
+loadURL(aURL, nullptr);
+
+css::uno::Reference xTextFieldsSupplier(
+mxComponent, css::uno::UNO_QUERY_THROW);
+auto xFields(xTextFieldsSupplier->getTextFields()->createEnumeration());
+
+// FIXME: seems order of fields is different than in source document
+// so feel free to modify testcase if order is changed
+
+// First field: content from core properties
+uno::Reference xField1(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xFields->hasMoreElements());
+// Check field value (it should be value from data source) and set new
+CPPUNIT_ASSERT_EQUAL(OUString("True Core Property Value"), 
xField1->getPresentation(false));
+uno::Reference xField1Props(xField1, uno::UNO_QUERY);
+xField1Props->setPropertyValue("Content", uno::makeAny(OUString("New Core 
Property Value")));
+
+// Third field: content from custom properties
+uno::Reference xField2(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xFields->hasMoreElements());
+// Check field value (it should be value from data source) and set new
+CPPUNIT_ASSERT_EQUAL(OUString("True Custom XML Value"), 
xField2->getPresentation(false));
+uno::Reference xField2Props(xField2, uno::UNO_QUERY);
+xField2Props->setPropertyValue("Content", uno::makeAny(OUString("New 
Custom XML Value")));
+
+// Second field: content from extended properties
+uno::Reference xField3(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(!xFields->hasMoreElements());
+// Check field value (it should be value from data source) and set new
+CPPUNIT_ASSERT_EQUAL(OUString("True Extended Property Value"), 
xField3->getPresentation(false));
+uno::Reference xField3Props(xField3, uno::UNO_QUERY);
+xField3Props->setPropertyValue("Content", uno::makeAny(OUString("New 
Extended Property Value")));
+
+// Save and check saved data
+save("Office Open XML Text", maTempFile);
+mbExported = true;
+xmlDocPtr pXmlCustomPropsDoc = parseExport("customXml/item1.xml");
+CPPUNIT_ASSERT(pXmlCustomPropsDoc);
+// FIXME: strange it won't run simple /employees/employee/name xpath 
query. Does not like namespaces?
+assertXPathContent(pXmlCustomPropsDoc, "//*/*[local-name()='name']", "New 
Custom XML Value");
+
+xmlDocPtr pXmlAppPropsDoc = parseExport("docProps/app.xml");
+CPPUNIT_ASSERT(pXmlAppPropsDoc);
+// TODO: extended properties are not written yet
+assertXPathContent(pXmlAppPropsDoc, "//*/*[local-name()='Company']", "True 
Extended Property Value");
+
+xmlDocPtr pXmlCorePropsDoc = parseExport("docProps/core.xml");
+CPPUNIT_ASSERT(pXmlCorePropsDoc);
+// TODO: core properties are not written yet
+assertXPathContent(pXmlCorePropsDoc, "//*/*[local-name()='creator']", 
"True Core Property Value");
+}
+
 

[Libreoffice-bugs] [Bug 147135] Crash in: _GLOBAL__sub_I_protectiondlg.cxx.lto_priv.2643 ( Calc crashes )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147135

--- Comment #82 from Timur  ---
To Michael: you were advised to create a new report and link here via See Also.
Because some here confirmed that their problem gone.

 TO ALL: Please test with latest daily master 7.4+ or wait for 7.3.1 and write
of problem still exists, preferably in that new bug report. 

(since there are mails here, at any time anyone can tick "never mail me..)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - filter/source offapi/com oox/source sw/inc sw/qa sw/source writerfilter/inc writerfilter/source

[Vasily Melenchuk (via logerrit)]

 filter/source/xsltfilter/LibXSLTTransformer.cxx   |   26 +
 filter/source/xsltfilter/LibXSLTTransformer.hxx   |3 
 offapi/com/sun/star/document/XOOXMLDocumentPropertiesImporter.idl |   25 +
 oox/source/docprop/ooxmldocpropimport.cxx |   89 -
 oox/source/docprop/ooxmldocpropimport.hxx |6 
 sw/inc/expfld.hxx |6 
 sw/qa/extras/ooxmlexport/ooxmlexport.cxx  |4 
 sw/qa/extras/ooxmlexport/ooxmlexport15.cxx|   12 
 sw/qa/extras/ooxmlexport/ooxmlexport4.cxx |   12 
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |9 
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx |2 
 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx |5 
 sw/source/core/fields/expfld.cxx  |7 
 sw/source/core/inc/unofldmid.h|1 
 sw/source/core/unocore/unomap.cxx |1 
 sw/source/filter/ww8/docxattributeoutput.cxx  |   87 +
 sw/source/filter/ww8/docxattributeoutput.hxx  |1 
 sw/source/filter/ww8/docxexport.cxx   |  130 

 sw/source/filter/ww8/docxexport.hxx   |   16 +
 writerfilter/inc/dmapper/resourcemodel.hxx|7 
 writerfilter/source/dmapper/DomainMapper.cxx  |   42 ++
 writerfilter/source/dmapper/DomainMapper.hxx  |2 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |4 
 writerfilter/source/dmapper/LoggedResources.hxx   |2 
 writerfilter/source/dmapper/SdtHelper.cxx |  156 
+-
 writerfilter/source/dmapper/SdtHelper.hxx |   15 
 27 files changed, 597 insertions(+), 75 deletions(-)

New commits:
commit 461491ef170675663e9d5396c74b04b7c051d0ac
Author: Vasily Melenchuk 
AuthorDate: Wed Nov 24 14:50:12 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:28:43 2022 +0100

tdf#104823: support for sdt plain text fields

This is a squashed commit containing set of changes:
* Create a input field from sdt text block.
* Advanced support for reading field data from data bindings
  which can point to custom xml or properties xml. For this
  XOOXMLDocumentPropertiesImporter idl interface was extrended
  with extra getterrs to get properties as xml dom elements.
* Support for exporting of this feature back to docx. For this
  some extra parameters for sdt block are kept in newly introduced
  grabbag for input fields. If field does not contain grabbag it
  being exported as before (FILLIN or whatsoever), otherwise
  sdt block is counstructed based on data from grabbag.
* Basic support for updating custom xml values back into
  custom xmls with usage of xslt transformations. To achieve
  this extra parameters were introduced to XXSLTTransformer:
  now it is able to support in-memory transformation stylesheets.

* plus some follow-up clean-ups

Some unittests were corrected: since sdt plain text edit area is
a field located inside paragraph in outout corresponding sdt is
also located inside paragraph (instead of Word's approach with
paragraph inside sdt). Seems this is not critical.

Change-Id: I1a73ef300db3619804f7adf18579bea708764c14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127015
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127284
Tested-by: Thorsten Behrens 

Fix typos

Change-Id: Ib75af11e67cadd3522c2c4b94b0549c8a96b8464
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127150
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

crashtesting: set document reference only once

For SdtHelper we need to keep valid reference to main document
(in our case first call), not to any of substreams like header,
footer, etc.

Change-Id: Id9d99c1a9bff9a3392eea4cc6e2abe774e5868d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127672
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 

be more exact about the type of pDocument

Change-Id: Iab0d23e8ee691ac6ed3381bd7e1ee02bb59dc64f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127661
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

Recent XOOXMLDocumentPropertiesImporter changes went into 7.3

Adjust @since statement to new realities

Change-Id: I8a65b4bdd2ef2ffab95f8a934ff5e5e8ffb90f03
Reviewed-on: 

[Libreoffice-bugs] [Bug 147503] New: Crashes when trying to insert a hyperlink.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147503

Bug ID: 147503
   Summary: Crashes when trying to insert a hyperlink.
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yosi3260+li...@gmail.com

Description:
LibreOffice crashes only if the hyperlink is set to [New Document], [XML Form
Document], or [Edit later].

Steps to Reproduce:
1.[Insert]-[Hyperlink]
2.[New Document] [Edit later]
  File: Something
  File type: XML Form Document
3.[Apply]or[OK] button click

Actual Results:
Force close after a few seconds.

Expected Results:
Continue work.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.1.1 / LibreOffice Community
Build ID: 75bdb7e01371355b35ec003f0e496b8afe00a42b
CPU threads: 2; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - writerfilter/inc writerfilter/source

[Vasily Melenchuk (via logerrit)]

 writerfilter/inc/dmapper/resourcemodel.hxx|2 
 writerfilter/source/dmapper/DomainMapper.cxx  |5 ++
 writerfilter/source/dmapper/DomainMapper.hxx  |2 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |8 +++
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |9 
 writerfilter/source/dmapper/LoggedResources.hxx   |2 
 writerfilter/source/dmapper/SdtHelper.cxx |   47 +-
 writerfilter/source/dmapper/SdtHelper.hxx |   11 -
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx   |1 
 9 files changed, 84 insertions(+), 3 deletions(-)

New commits:
commit 20c7e0355ed83bfb235b1b188171d7cb4c6664c9
Author: Vasily Melenchuk 
AuthorDate: Fri Nov 19 15:09:31 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:26:28 2022 +0100

tdf#104823: basic support for reading field data from databinding

Change-Id: Ie45eb18205c1c54a631303b45887e54e456b6d5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125550
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127129
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130042
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/writerfilter/inc/dmapper/resourcemodel.hxx 
b/writerfilter/inc/dmapper/resourcemodel.hxx
index 44e659235845..f54cfb0b455f 100644
--- a/writerfilter/inc/dmapper/resourcemodel.hxx
+++ b/writerfilter/inc/dmapper/resourcemodel.hxx
@@ -205,6 +205,8 @@ public:
 /// The current section is the last one in this body text.
 virtual void markLastSectionGroup( ) { };
 
+virtual void setDocumentReference(void* pDocument) = 0;
+
 /**
Receives start mark for group with the same paragraph properties.
  */
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 2d983a496e1e..e794bdcdc2c8 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -183,6 +183,11 @@ DomainMapper::DomainMapper( const uno::Reference< 
uno::XComponentContext >& xCon
 catch( const uno::Exception& ) {}
 }
 
+void DomainMapper::setDocumentReference(void* pDocument)
+{
+m_pImpl->setDocumentReference(pDocument);
+}
+
 DomainMapper::~DomainMapper()
 {
 try
diff --git a/writerfilter/source/dmapper/DomainMapper.hxx 
b/writerfilter/source/dmapper/DomainMapper.hxx
index b2c2ba63d9a0..6fcbf14bdb93 100644
--- a/writerfilter/source/dmapper/DomainMapper.hxx
+++ b/writerfilter/source/dmapper/DomainMapper.hxx
@@ -81,6 +81,8 @@ public:
  utl::MediaDescriptor const & rMediaDesc);
 virtual ~DomainMapper() override;
 
+virtual void setDocumentReference(void* pDocument) override;
+
 // Stream
 virtual void markLastParagraphInSection() override;
 virtual void markLastSectionGroup() override;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 985041c292ea..cf41cc167e53 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -270,6 +270,7 @@ DomainMapper_Impl::DomainMapper_Impl(
 utl::MediaDescriptor const & rMediaDesc) :
 m_eDocumentType( eDocumentType ),
 m_rDMapper( rDMapper ),
+m_pOOXMLDocument(nullptr),
 m_xTextDocument( xModel, uno::UNO_QUERY ),
 m_xTextFactory( xModel, uno::UNO_QUERY ),
 m_xComponentContext( xContext ),
@@ -371,7 +372,7 @@ DomainMapper_Impl::DomainMapper_Impl(
 getTableManager( ).startLevel();
 m_bUsingEnhancedFields = !utl::ConfigManager::IsFuzzing() && 
officecfg::Office::Common::Filter::Microsoft::Import::ImportWWFieldsAsEnhancedFields::get(m_xComponentContext);
 
-m_pSdtHelper = new SdtHelper(*this);
+m_pSdtHelper = new SdtHelper(*this, m_xComponentContext);
 
 m_aRedlines.push(std::vector());
 
@@ -395,6 +396,11 @@ DomainMapper_Impl::~DomainMapper_Impl()
 }
 }
 
+writerfilter::ooxml::OOXMLDocument* DomainMapper_Impl::getDocumentReference() 
const
+{
+return static_cast(m_pOOXMLDocument);
+}
+
 uno::Reference< container::XNameContainer > const &  
DomainMapper_Impl::GetPageStyles()
 {
 if(!m_xPageStyles1.is())
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 668461bc978a..c6f4755507eb 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -75,6 +75,11 @@ namespace com{ namespace sun{ namespace star{
 }}}
 
 namespace writerfilter {
+
+namespace ooxml {
+class OOXMLDocument;
+}
+
 namespace dmapper {
 
 class SdtHelper;
@@ -436,6 +441,7 @@ public:
 private:
 SourceDocumentType const   
 m_eDocumentType;
 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/test_sdt_datepicker.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx  |   25 ++
 sw/source/filter/ww8/docxattributeoutput.cxx   |   62 ++---
 sw/source/filter/ww8/docxattributeoutput.hxx   |3 
 writerfilter/source/dmapper/DomainMapper.cxx   |9 +-
 writerfilter/source/dmapper/SdtHelper.cxx  |3 
 writerfilter/source/dmapper/SdtHelper.hxx  |   15 
 7 files changed, 88 insertions(+), 29 deletions(-)

New commits:
commit 83ce54624c7f0a17b9e0ebcf8eebdbc8bae33d46
Author: Vasily Melenchuk 
AuthorDate: Thu Nov 18 20:06:08 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:25:24 2022 +0100

sw: support for other sdt attributes roundtrip in datepicker

Word Control Field with datepicker is implemented with LO datepicker,
but during this conversion we lose some field data, like control
color, data mapping, etc. This data is already retrieved and stored
in grab bag, so we need just to keep this grabbag in field and use
it again on export.

Change-Id: I6af8204fe1a7d2f9081d83372a6786b2f86260d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125486
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127196
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130041
Tested-by: Miklos Vajna 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/test_sdt_datepicker.docx 
b/sw/qa/extras/ooxmlexport/data/test_sdt_datepicker.docx
new file mode 100644
index ..3ff04cb60b89
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/test_sdt_datepicker.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
index 094a9262ace7..4a4877cdb9b4 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlfieldexport.cxx
@@ -758,6 +758,31 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testConditionalText, 
"conditional-text.fodt"
 assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[2]/w:instrText", 
aExpected);
 }
 
+DECLARE_OOXMLEXPORT_TEST( testSdtDatePicker, "test_sdt_datepicker.docx" )
+{
+// Check that roundtrip for date picker field does not lose essential data
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+   return; // initial import, no futher checks
+
+// Placeholder is here
+OUString sDocPart = getXPath(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtPr/w:placeholder/w:docPart", "val");
+CPPUNIT_ASSERT_EQUAL(OUString("DefaultPlaceholder_-1854013437"), sDocPart);
+
+// Ensure that we have data binding stuff
+OUString sDBprefix = getXPath(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtPr/w:dataBinding", "prefixMappings");
+
CPPUNIT_ASSERT_EQUAL(OUString("xmlns:ns0='http://schemas.microsoft.com/vsto/samples'
 "), sDBprefix);
+
+OUString sDBxpath = getXPath(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtPr/w:dataBinding", "xpath");
+
CPPUNIT_ASSERT_EQUAL(OUString("/ns0:employees[1]/ns0:employee[1]/ns0:hireDate[1]"),
 sDBxpath);
+
+OUString sDBstoreid = getXPath(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtPr/w:dataBinding", "storeItemID");
+CPPUNIT_ASSERT_EQUAL(OUString("{241A8A02-7FFD-488D-8827-63FBE74E8BC9}"), 
sDBstoreid);
+
+OUString sColor = getXPath(pXmlDoc, 
"/w:document/w:body/w:p/w:sdt/w:sdtPr/w15:color", "val");
+CPPUNIT_ASSERT_EQUAL(OUString("008000"), sColor);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 84269fc05f5a..e56117df2f02 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -656,12 +656,36 @@ void 
SdtBlockHelper::WriteSdtBlock(::sax_fastparser::FSHelperPtr& pSerializer, b
 }
 }
 
+WriteExtraParams(pSerializer);
+
+pSerializer->endElementNS(XML_w, XML_sdtPr);
+
+// sdt contents start tag
+pSerializer->startElementNS(XML_w, XML_sdtContent);
+
+// prepend the tags since the sdt start mark before the paragraph
+pSerializer->mergeTopMarks(Tag_WriteSdtBlock, 
sax_fastparser::MergeMarks::PREPEND);
+
+// write the ending tags after the paragraph
+m_bStartedSdt = true;
+
+// clear sdt status
+m_nSdtPrToken = 0;
+m_pTokenChildren.clear();
+m_pDataBindingAttrs.clear();
+m_pTextAttrs.clear();
+m_aAlias.clear();
+m_bHasId = false;
+}
+
+void SdtBlockHelper::WriteExtraParams(::sax_fastparser::FSHelperPtr& 
pSerializer)
+{
 if (m_nSdtPrToken == FSNS(XML_w, XML_id) || m_bHasId)
 //Word won't open a document with an empty id tag, we fill it with a 
random number
 

[Libreoffice-bugs] [Bug 147418] Libreoffice Calc cannot start

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147418

--- Comment #3 from Timur  ---
Reporter, you need to test with 7.4+ master or wait for 7.3.1.
And then to paste here info from Help-About.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/source

[Vasily Melenchuk (via logerrit)]

 sw/source/filter/ww8/docxattributeoutput.cxx |  765 +++
 sw/source/filter/ww8/docxattributeoutput.hxx |   73 +-
 2 files changed, 356 insertions(+), 482 deletions(-)

New commits:
commit c3206d877c17e980ac0dcab8e890349c23b4d249
Author: Vasily Melenchuk 
AuthorDate: Tue Nov 16 18:12:39 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:23:46 2022 +0100

sw: refactoring for docx sdt blocks output

Previous approach with almost duplicate storage and processing
for paragraph-level and run-level sdt blocks was very bulky.
Especially this became visible once supported std elements list
start to grow.

Paragraph-level sdt block and run-level sdt block data are almost
identical, so they can be kept in one standard class
(SdtBlockHelper) and use the same methods for collecting data
from grabbags and writing to output without passing huge amount
of parameters.

Change-Id: I4e1183eddf20317e954cb8aca72e97a4fc45ac68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125372
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127158
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130040
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 79d31da2e575..84269fc05f5a 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -312,6 +312,28 @@ static bool lcl_isOnelinerSdt(const OUString& rName)
 return rName == "Title" || rName == "Subtitle" || rName == "Company";
 }
 
+static void AddToAttrList(rtl::Reference& 
pAttrList, sal_Int32 nAttrs, ...)
+{
+if (!pAttrList.is())
+pAttrList = FastSerializerHelper::createAttrList();
+
+va_list args;
+va_start(args, nAttrs);
+for (sal_Int32 i = 0; i < nAttrs; i++)
+{
+sal_Int32 nName = va_arg(args, sal_Int32);
+const char* pValue = va_arg(args, const char*);
+if (pValue)
+pAttrList->add(nName, pValue);
+}
+va_end(args);
+}
+
+static void AddToAttrList(rtl::Reference& 
pAttrList, sal_Int32 nAttrName, const char* sAttrValue)
+{
+AddToAttrList(pAttrList, 1, nAttrName, sAttrValue);
+}
+
 // write a floating table directly to docx without the surrounding frame
 void DocxAttributeOutput::WriteFloatingTable(ww8::Frame const* pParentFrame)
 {
@@ -450,7 +472,7 @@ sal_Int32 
DocxAttributeOutput::StartParagraph(ww8::WW8TableNodeInfo::Pointer_t p
 // would normally arrive, it would be too late (would be after the
 // paragraph start has been written).
 bool bEndParaSdt = false;
-if (m_bStartedParaSdt)
+if (m_aParagraphSdt.m_bStartedSdt)
 {
 SwTextNode* pTextNode = m_rExport.m_pCurPam->GetNode().GetTextNode();
 if (pTextNode && pTextNode->GetpSwAttrSet())
@@ -460,17 +482,16 @@ sal_Int32 
DocxAttributeOutput::StartParagraph(ww8::WW8TableNodeInfo::Pointer_t p
 {
 const SfxGrabBagItem& rParaGrabBag = static_cast(*pItem);
 const std::map& rMap = 
rParaGrabBag.GetGrabBag();
-bEndParaSdt = m_bStartedParaSdt && 
rMap.find("ParaSdtEndBefore") != rMap.end();
+bEndParaSdt = m_aParagraphSdt.m_bStartedSdt && 
rMap.find("ParaSdtEndBefore") != rMap.end();
 }
 }
 }
 // TODO also avoid multiline paragraphs in those SDT types for shape text
-bool bOneliner = m_bStartedParaSdt && 
!m_rExport.SdrExporter().IsDMLAndVMLDrawingOpen() && 
lcl_isOnelinerSdt(m_aStartedParagraphSdtPrAlias);
-if (bEndParaSdt || (m_bStartedParaSdt && m_bHadSectPr) || bOneliner)
+bool bOneliner = m_aParagraphSdt.m_bStartedSdt && 
!m_rExport.SdrExporter().IsDMLAndVMLDrawingOpen() && 
lcl_isOnelinerSdt(m_aStartedParagraphSdtPrAlias);
+if (bEndParaSdt || (m_aParagraphSdt.m_bStartedSdt && m_bHadSectPr) || 
bOneliner)
 {
 // This is the common case: "close sdt before the current paragraph" 
was requested by the next paragraph.
-EndSdtBlock();
-m_bStartedParaSdt = false;
+m_aParagraphSdt.EndSdtBlock(m_pSerializer);
 m_aStartedParagraphSdtPrAlias.clear();
 }
 m_bHadSectPr = false;
@@ -574,24 +595,265 @@ static OString convertToOOXMLHoriOrientRel(sal_Int16 
nOrientRel)
 }
 }
 
-static void lcl_deleteAndResetTheLists(
-rtl::Reference& pSdtPrTokenChildren,
-rtl::Reference& pSdtPrDataBindingAttrs,
-rtl::Reference& pSdtPrTextAttrs,
-OUString& rSdtPrAlias, OUString& rSdtPrPlaceholderDocPart, OUString& 
rColor)
+void SdtBlockHelper::DeleteAndResetTheLists()
 {
-if( pSdtPrTokenChildren.is() )
-pSdtPrTokenChildren.clear();
-if( pSdtPrDataBindingAttrs.is() )
-

[Libreoffice-bugs] [Bug 61245] Application can't be exited

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61245

--- Comment #6 from hobert hall  ---
I am very happy to see your article, I very much like and agree with your point
of view. Thank you for sharing. This is really a very useful information in my
life. I will share it with my friends https://shell-shockers.online

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf137466.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport15.cxx   |   15 
 sw/qa/extras/ooxmlexport/ooxmlexport4.cxx|2 
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx|4 -
 sw/qa/extras/ooxmlexport/ooxmlw14export.cxx  |2 
 sw/source/filter/ww8/docxattributeoutput.cxx |   89 ---
 sw/source/filter/ww8/docxattributeoutput.hxx |6 +
 sw/source/filter/ww8/docxexport.cxx  |3 
 writerfilter/source/dmapper/DomainMapper.cxx |   20 +-
 writerfilter/source/ooxml/model.xml  |   29 +++-
 10 files changed, 152 insertions(+), 18 deletions(-)

New commits:
commit 812e93f659168306adaa1764b658be30998b1221
Author: Vasily Melenchuk 
AuthorDate: Tue Nov 16 11:50:03 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:22:45 2022 +0100

tdf#137466: docx: support w:placeholder & w15:color in w:sdtPr

Content controls in Word can contain some other elements which
are not supported by Writer. Put them into grabbag and write
back to DOCX on save to avoid losing quite sensitive data.

Test testSimpleSdts is modified: testcase is actully containing
4 sdt elements with ids in input and output.

Change-Id: I1f9addd03ed828bf375ccac5188a004f011e8a0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125271
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127126
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130039
Tested-by: Miklos Vajna 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf137466.docx 
b/sw/qa/extras/ooxmlexport/data/tdf137466.docx
new file mode 100644
index ..3c5977251bda
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf137466.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
index e1c6bc533206..0a2fdaadba7e 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
@@ -239,6 +239,21 @@ DECLARE_OOXMLEXPORT_TEST(testTdf81507, "tdf81507.docx")
 xmlXPathFreeObject(pXmlObj);
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf137466, "tdf137466.docx")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+   return; // initial import, no futher checks
+
+// Ensure that we have 
+OUString sDocPart = getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt/w:sdtPr/w:placeholder/w:docPart", "val");
+CPPUNIT_ASSERT_EQUAL(OUString("DefaultPlaceholder_-1854013440"), sDocPart);
+
+// Ensure that we have 
+OUString sColor = getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt/w:sdtPr/w15:color", "val");
+CPPUNIT_ASSERT_EQUAL(OUString("FF"), sColor);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
index 9681dc77c186..77fda39b43ea 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
@@ -1071,7 +1071,7 @@ DECLARE_OOXMLEXPORT_TEST(testSimpleSdts, 
"simple-sdts.docx")
return;
 
 assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:text", 1);
-assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:id", 3);
+assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:id", 4);
 assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:picture", 1);
 assertXPath(pXmlDoc, "/w:document/w:body/w:sdt/w:sdtPr/w:group", 1);
 assertXPath(pXmlDoc, "/w:document/w:body/w:p/w:sdt/w:sdtPr/w:citation", 1);
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 87795d6ba6c6..7821173f9863 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -535,12 +535,12 @@ DECLARE_OOXMLEXPORT_TEST(testFDO79062, "fdo79062.docx")
 xmlDocPtr pXmlFootNotes = parseExport("word/footnotes.xml");
 if (!pXmlFootNotes)
 return;
-assertXPath(pXmlFootNotes, "/w:footnotes", "Ignorable", "w14 wp14");
+assertXPath(pXmlFootNotes, "/w:footnotes", "Ignorable", "w14 wp14 w15");
 
 xmlDocPtr pXmlEndNotes = parseExport("word/endnotes.xml");
 if (!pXmlEndNotes)
 return;
-assertXPath(pXmlEndNotes, "/w:endnotes", "Ignorable", "w14 wp14");
+assertXPath(pXmlEndNotes, "/w:endnotes", "Ignorable", "w14 wp14 w15");
 
 //tdf#93121 don't add fake tabs in front of extra footnote paragraphs
 uno::Reference xFootnoteSupp(mxComponent, 
uno::UNO_QUERY);
diff --git a/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
index f6939083c456..ef6aaaebbb09 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlw14export.cxx
@@ 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source writerfilter/source

[Vasily Melenchuk (via logerrit)]

 sw/qa/extras/ooxmlexport/data/tdf81507.docx  |binary
 sw/qa/extras/ooxmlexport/ooxmlexport15.cxx   |   22 ++
 sw/source/filter/ww8/docxattributeoutput.cxx |   59 ---
 sw/source/filter/ww8/docxattributeoutput.hxx |3 +
 writerfilter/source/dmapper/DomainMapper.cxx |3 +
 writerfilter/source/ooxml/model.xml  |5 +-
 6 files changed, 85 insertions(+), 7 deletions(-)

New commits:
commit 43bbcc0d71b2b25970f4d5730c42b0eb7187cf85
Author: Vasily Melenchuk 
AuthorDate: Thu Nov 11 10:39:32 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:20:09 2022 +0100

tdf#81507: word content control support for w:multiLine

 is now supported for import/export
to DOCX. Like other content control items it is stored in
grabbag.

Change-Id: Id6f1aa0072dc5db980d0fa43cab4b38a0aa047fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125024
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127128
Tested-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130038
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf81507.docx 
b/sw/qa/extras/ooxmlexport/data/tdf81507.docx
new file mode 100644
index ..2c00ee44cb24
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf81507.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
index 8b29a9adaf6c..e1c6bc533206 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
@@ -217,6 +217,28 @@ DECLARE_OOXMLEXPORT_TEST(testCommentDoneModel, 
"CommentDone.docx")
 CPPUNIT_ASSERT_EQUAL(false, 
xComment->getPropertyValue("Resolved").get());
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf81507, "tdf81507.docx")
+{
+xmlDocPtr pXmlDoc = parseExport("word/document.xml");
+if (!pXmlDoc)
+   return; // initial import, no futher checks
+
+// Ensure that we have 
+CPPUNIT_ASSERT_EQUAL(OUString("1"), getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt[1]/w:sdtPr/w:text", "multiLine"));
+
+// Ensure that we have 
+CPPUNIT_ASSERT_EQUAL(OUString("0"), getXPath(pXmlDoc, 
"/w:document/w:body/w:sdt[2]/w:sdtPr/w:text", "multiLine"));
+
+// Ensure that we have 
+getXPath(pXmlDoc, "/w:document/w:body/w:sdt[3]/w:sdtPr/w:text", "");
+
+// Ensure that we have no  (not quite correct case, but to ensure 
import/export are okay)
+xmlXPathObjectPtr pXmlObj = getXPathNode(pXmlDoc, 
"/w:document/w:body/w:sdt[4]/w:sdtPr/w:text");
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0),
+   
static_cast(xmlXPathNodeSetGetLength(pXmlObj->nodesetval)));
+xmlXPathFreeObject(pXmlObj);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 7310e7d5f395..eb96baa880c4 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -574,12 +574,18 @@ static OString convertToOOXMLHoriOrientRel(sal_Int16 
nOrientRel)
 }
 }
 
-static void lcl_deleteAndResetTheLists( 
rtl::Reference& pSdtPrTokenChildren, 
rtl::Reference& pSdtPrDataBindingAttrs, 
OUString& rSdtPrAlias)
+static void lcl_deleteAndResetTheLists(
+rtl::Reference& pSdtPrTokenChildren,
+rtl::Reference& pSdtPrDataBindingAttrs,
+rtl::Reference& pSdtPrTextAttrs,
+OUString& rSdtPrAlias)
 {
 if( pSdtPrTokenChildren.is() )
 pSdtPrTokenChildren.clear();
 if( pSdtPrDataBindingAttrs.is() )
 pSdtPrDataBindingAttrs.clear();
+if (pSdtPrTextAttrs.is())
+pSdtPrTextAttrs.clear();
 if (!rSdtPrAlias.isEmpty())
 rSdtPrAlias.clear();
 }
@@ -778,14 +784,14 @@ void DocxAttributeOutput::EndParagraph( 
ww8::WW8TableNodeInfoInner::Pointer_t pT
 m_pSerializer->endElementNS( XML_w, XML_p );
 // on export sdt blocks are never nested ATM
 if( !m_bAnchorLinkedToNode && !m_bStartedParaSdt )
-WriteSdtBlock( m_nParagraphSdtPrToken, m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrTokenAttributes, m_pParagraphSdtPrDataBindingAttrs, 
m_aParagraphSdtPrAlias, /*bPara=*/true );
+WriteSdtBlock( m_nParagraphSdtPrToken, m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrTokenAttributes, m_pParagraphSdtPrDataBindingAttrs, 
m_pParagraphSdtPrTextAttrs, m_aParagraphSdtPrAlias, /*bPara=*/true );
 else
 {
 //These should be written out to the actual Node and not to the anchor.
 //Clear them as they will be repopulated when the node is processed.
 m_nParagraphSdtPrToken = 0;
 m_bParagraphSdtHasId = false;
-lcl_deleteAndResetTheLists( m_pParagraphSdtPrTokenChildren, 
m_pParagraphSdtPrDataBindingAttrs, m_aParagraphSdtPrAlias );
+lcl_deleteAndResetTheLists( 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - writerfilter/source

[Vasily Melenchuk (via logerrit)]

 writerfilter/source/dmapper/DomainMapper.cxx |   92 ++-
 writerfilter/source/dmapper/SdtHelper.cxx|   13 +--
 writerfilter/source/dmapper/SdtHelper.hxx|   18 +++--
 3 files changed, 64 insertions(+), 59 deletions(-)

New commits:
commit 137a7c116f58134107d4fcc399da5854639853b8
Author: Vasily Melenchuk 
AuthorDate: Thu Nov 18 15:04:00 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:14:59 2022 +0100

writerfilter: extend SdtHelper for better support control types

There is much more different controls which must be supprorted
in future. So approach with isInsideDropDownControl() and
validateDateFormat() is not sufficient. Use enum to determine
and store control type.

Change-Id: Ibea7fde117c059053195be213a3ae821644f277c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125471
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127149
Tested-by: Thorsten Behrens 
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130037
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index c6d718790763..b3c6b5d0c7c5 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1031,10 +1031,17 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 else
 m_pImpl->setSdtEndDeferred(true);
 
-if (m_pImpl->m_pSdtHelper->isInsideDropDownControl())
-m_pImpl->m_pSdtHelper->createDropDownControl();
-else if (m_pImpl->m_pSdtHelper->validateDateFormat())
-m_pImpl->m_pSdtHelper->createDateContentControl();
+switch (m_pImpl->m_pSdtHelper->getControlType())
+{
+case SdtControlType::dropDown:
+m_pImpl->m_pSdtHelper->createDropDownControl();
+break;
+case SdtControlType::datePicker:
+m_pImpl->m_pSdtHelper->createDateContentControl();
+break;
+case SdtControlType::unknown:
+default:;
+}
 break;
 case NS_ooxml::LN_CT_SdtListItem_displayText:
 // TODO handle when this is != value
@@ -2542,7 +2549,7 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 case NS_ooxml::LN_CT_SdtPr_dropDownList:
 case NS_ooxml::LN_CT_SdtPr_comboBox:
 {
-m_pImpl->m_pSdtHelper->setInsideDropDownControl(true);
+m_pImpl->m_pSdtHelper->setControlType(SdtControlType::dropDown);
 writerfilter::Reference::Pointer_t pProperties = 
rSprm.getProps();
 if (pProperties.get() != nullptr)
 pProperties->resolve(*this);
@@ -2557,6 +2564,7 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 break;
 case NS_ooxml::LN_CT_SdtPr_date:
 {
+m_pImpl->m_pSdtHelper->setControlType(SdtControlType::datePicker);
 resolveSprmProps(*this, rSprm);
 
m_pImpl->m_pSdtHelper->setDateFieldStartRange(GetCurrentTextRange()->getEnd());
 }
@@ -3385,7 +3393,7 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, 
size_t len)
 }
 
 bool bNewLine = len == 1 && (sText[0] == 0x0d || sText[0] == 0x07);
-if (m_pImpl->m_pSdtHelper->isInsideDropDownControl())
+if (m_pImpl->m_pSdtHelper->getControlType() == SdtControlType::dropDown)
 {
 if (bNewLine)
 // Dropdown control has single-line texts, so in case of newline, 
create the control.
@@ -3396,43 +3404,48 @@ void DomainMapper::lcl_utext(const sal_uInt8 * data_, 
size_t len)
 return;
 }
 }
+else if (m_pImpl->m_pSdtHelper->getControlType() == 
SdtControlType::datePicker)
+{
+if (!m_pImpl->m_pSdtHelper->isInteropGrabBagEmpty())
+{
+m_pImpl->m_pSdtHelper->getInteropGrabBagAndClear();
+}
+else if (IsInHeaderFooter() && m_pImpl->IsDiscardHeaderFooter())
+{
+m_pImpl->m_pSdtHelper->getDateFormat().truncate();
+m_pImpl->m_pSdtHelper->getLocale().truncate();
+m_pImpl->m_pSdtHelper->setControlType(SdtControlType::unknown);
+return;
+}
+}
 else if (!m_pImpl->m_pSdtHelper->isInteropGrabBagEmpty())
 {
- // Ignore grabbag when we have a date field, it can conflict during 
export
-if(m_pImpl->m_pSdtHelper->validateDateFormat())
+// there are unsupported SDT properties in the document
+// save them in the paragraph interop grab bag
+if (m_pImpl->IsDiscardHeaderFooter())
 {
+// Unless we're supposed to ignore this header/footer.
 m_pImpl->m_pSdtHelper->getInteropGrabBagAndClear();
+

[Libreoffice-commits] core.git: sw/qa vcl/source writerfilter/source

[Miklos Vajna (via logerrit)]

 sw/qa/extras/rtfimport/rtfimport.cxx  |1 -
 vcl/source/filter/ipdf/pdfread.cxx|3 ---
 writerfilter/source/dmapper/SdtHelper.cxx |2 --
 3 files changed, 6 deletions(-)

New commits:
commit 7417ac0b63557869bc5b7b8faa485145e27151c1
Author: Miklos Vajna 
AuthorDate: Thu Feb 17 21:05:18 2022 +0100
Commit: Miklos Vajna 
CommitDate: Fri Feb 18 08:13:13 2022 +0100

Remove some unused includes

See tdf#42949 for motivation.

Change-Id: Ieddb3d76a960d4b87cd2a1e89bce3fcbe0fce7e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130113
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 0b8c5b190ea3..60301446c35a 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -10,7 +10,6 @@
 #include 
 #include 
 
-#include 
 #include 
 
 #include 
diff --git a/vcl/source/filter/ipdf/pdfread.cxx 
b/vcl/source/filter/ipdf/pdfread.cxx
index 04b6b68cf9c8..3eadbfe2fd63 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -9,9 +9,6 @@
 
 #include 
 
-#include 
-#include 
-
 #include 
 
 #include 
diff --git a/writerfilter/source/dmapper/SdtHelper.cxx 
b/writerfilter/source/dmapper/SdtHelper.cxx
index c5ec47f2be23..f4fa3ef69405 100644
--- a/writerfilter/source/dmapper/SdtHelper.cxx
+++ b/writerfilter/source/dmapper/SdtHelper.cxx
@@ -25,11 +25,9 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-#include 
 
 namespace writerfilter::dmapper
 {

[Libreoffice-commits] core.git: sfx2/source

[Heiko Tietze (via logerrit)]

 sfx2/source/doc/QuerySaveDocument.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9d9e1b0174e901ba8630232960380fc8e66dff39
Author: Heiko Tietze 
AuthorDate: Thu Feb 17 16:25:05 2022 +0100
Commit: Heiko Tietze 
CommitDate: Fri Feb 18 08:08:37 2022 +0100

Revert "Related tdf#143578 - Rename SAL_NO_QUERYSAVE to NO_QUERYSAVE"

This reverts commit 75ac604292e92dc08bb8ba5b9cc30799d643090a.

Reason for revert: Decision was made to have some prefix, either SAL_ or LO_

Change-Id: I42c7ad8a8b8a83161db568895d1ec98dcdc0838f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130026
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sfx2/source/doc/QuerySaveDocument.cxx 
b/sfx2/source/doc/QuerySaveDocument.cxx
index 49b3eecf0f77..4abc612dcf90 100644
--- a/sfx2/source/doc/QuerySaveDocument.cxx
+++ b/sfx2/source/doc/QuerySaveDocument.cxx
@@ -23,7 +23,7 @@
 
 short ExecuteQuerySaveDocument(weld::Widget* _pParent, std::u16string_view 
_rTitle)
 {
-if (Application::IsHeadlessModeEnabled() || getenv("NO_QUERYSAVE"))
+if (Application::IsHeadlessModeEnabled() || getenv("SAL_NO_QUERYSAVE"))
 {
 // don't block Desktop::terminate() if there's no user to ask
 return RET_NO;

[Libreoffice-bugs] [Bug 105036] xlsx file with huge drawing.xml will not open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105036

--- Comment #15 from Luboš Luňák  ---
37s seems reasonable (it's 32s here), 6s is way too short. Given that the
commit is a bugfix, presumably comment #9 applies.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/source

[Luboš Luňák (via logerrit)]

 sw/source/uibase/docvw/edtwin.cxx |   30 +-
 sw/source/uibase/inc/edtwin.hxx   |1 -
 sw/source/uibase/uiview/view1.cxx |3 +--
 3 files changed, 18 insertions(+), 16 deletions(-)

New commits:
commit 17b39d150fce188f653632a3467891157375a1c6
Author: Luboš Luňák 
AuthorDate: Thu Feb 17 16:50:22 2022 +0100
Commit: Luboš Luňák 
CommitDate: Fri Feb 18 07:49:45 2022 +0100

fix Writer key event delayed compression (tdf#145963)

SwEditWin::KeyInput() was stopping the flush timer on every
invocation, which means that as long as key events kept coming
the timer would be started again and again and would not time out,
and so the input buffer would not be actually processed. It seems
that AnyInput(KEYBOARD) there actually does not normally manage
to return true ... except for Win11 where it seems that now
GetQueueStatus() detects even key-up events even though it didn't
before (I've not debugged this enough to be certain).

I think it still makes sense to have the compression in case Writer
get overloaded to help it process the pending input events, so fix
this (but if there are problems, I think an easy solution is simply
to drop it, it doesn't seem to be that necessary). Also decrease
the timeout from 200 to 20ms, as 200ms is a very visible delay.

Change-Id: I760ad9c4f58726a80bd6a9fbf93f2771f10cbdb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130083
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index 6a0c5ac106b2..84c99e8049c0 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 #include 
@@ -169,7 +170,6 @@ bool g_bFrameDrag   = false;
 static bool g_bValidCursorPos   = false;
 static bool g_bModePushed = false;
 bool g_bDDTimerStarted= false;
-bool g_bFlushCharBuffer   = false;
 bool g_bDDINetAttr= false;
 static SdrHdlKind g_eSdrMoveHdl   = SdrHdlKind::User;
 
@@ -877,6 +877,9 @@ static sal_uInt16 lcl_isNonDefaultLanguage(LanguageType 
eBufferLanguage, SwView
  */
 void SwEditWin::FlushInBuffer()
 {
+if ( m_aKeyInputFlushTimer.IsActive())
+m_aKeyInputFlushTimer.Stop();
+
 if ( m_aInBuffer.isEmpty() )
 return;
 
@@ -1005,8 +1008,6 @@ void SwEditWin::FlushInBuffer()
 rSh.Insert( m_aInBuffer );
 m_eBufferLanguage = LANGUAGE_DONTKNOW;
 m_aInBuffer.clear();
-g_bFlushCharBuffer = false;
-
 }
 
 #define MOVE_LEFT_SMALL 0
@@ -1395,7 +1396,9 @@ void SwEditWin::KeyInput(const KeyEvent )
 return;
 
 m_pShadCursor.reset();
-m_aKeyInputFlushTimer.Stop();
+// Do not reset the timer here, otherwise when flooded with events it 
would never time out
+// if every key event stopped and started it again.
+comphelper::ScopeGuard keyInputFlushTimerStop([this]() { 
m_aKeyInputFlushTimer.Stop(); });
 
 bool bIsDocReadOnly = m_rView.GetDocShell()->IsReadOnly() &&
   rSh.IsCursorReadonly();
@@ -2461,10 +2464,15 @@ KEYINPUT_CHECKTABLE_INSDEL:
 comphelper::string::padToLength(aBuf,
 m_aInBuffer.getLength() + aKeyEvent.GetRepeat() + 1, 
aCh);
 m_aInBuffer = aBuf.makeStringAndClear();
-g_bFlushCharBuffer = Application::AnyInput( 
VclInputFlags::KEYBOARD );
-bFlushBuffer = !g_bFlushCharBuffer;
-if( g_bFlushCharBuffer )
-m_aKeyInputFlushTimer.Start();
+bool delayFlush = Application::AnyInput( 
VclInputFlags::KEYBOARD );
+bFlushBuffer = !delayFlush;
+if( delayFlush )
+{
+// Start the timer, make sure to not restart it.
+keyInputFlushTimerStop.dismiss();
+if( !m_aKeyInputFlushTimer.IsActive())
+m_aKeyInputFlushTimer.Start();
+}
 }
 eKeyState = SwKeyState::End;
 }
@@ -2680,11 +2688,7 @@ KEYINPUT_CHECKTABLE_INSDEL:
 // in case the buffered characters are inserted
 if( bFlushBuffer && !m_aInBuffer.isEmpty() )
 {
-// bFlushCharBuffer was not reset here
-// why not?
-bool bSave = g_bFlushCharBuffer;
 FlushInBuffer();
-g_bFlushCharBuffer = bSave;
 
 // maybe show Tip-Help
 if (bNormalChar)
@@ -5193,7 +5197,7 @@ SwEditWin::SwEditWin(vcl::Window *pParent, SwView 
):
 SetPointer( PointerStyle::Text );
 m_aTimer.SetInvokeHandler(LINK(this, SwEditWin, TimerHandler));
 
-m_aKeyInputFlushTimer.SetTimeout( 200 );
+m_aKeyInputFlushTimer.SetTimeout( 20 );
 m_aKeyInputFlushTimer.SetInvokeHandler(LINK(this, 

[Libreoffice-bugs] [Bug 147408] EDIT Integer out of range overflows without message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147408

--- Comment #6 from Longi  ---
Same behaviour 
LO 7.3.0.3 in windows

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143817

--- Comment #10 from Tomaz Vajngerl  ---
Nailed it... thanks Rafael.

Returning true or false says if the key was handled or not, so returning false
meant that the key event was sent forward to other handlers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Aron Budea  changed:

   What|Removed |Added

 Depends on||147393


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147393
[Bug 147393] Chart - Format Data series - Spacing can not be enter as value,
just with plus minus signs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147393] Chart - Format Data series - Spacing can not be enter as value, just with plus minus signs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147393

Aron Budea  changed:

   What|Removed |Added

Version|7.3.0.3 release |6.2.0.3 release
 CC||aron.bu...@gmail.com
 Blocks||103182
   Keywords||bibisected, bisected,
   ||regression

--- Comment #5 from Aron Budea  ---
(In reply to BogdanB from comment #0)
> Regression from 7.2
If you think it's a regression, please add the keywords regression and
bibisectRequest, and a known working version.

My result is that this is a regression from 6.2, and could be bibisected to the
following commit using the respective bibisect repo.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8947c9b1d8cd407131fdfb6fc3c77c8532e9d2a0

author  Caolán McNamara 2018-10-18 13:00:41
+0100
committer   Caolán McNamara 2018-10-20 13:52:34
+0200

weld SchAttribTabDlg


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147502] Adjusting chart data series label can mix up the result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147502

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Aron Budea  changed:

   What|Removed |Added

 Depends on||147502


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147502
[Bug 147502] Adjusting chart data series label can mix up the result
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147502] New: Adjusting chart data series label can mix up the result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147502

Bug ID: 147502
   Summary: Adjusting chart data series label can mix up the
result
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: aron.bu...@gmail.com
CC: michael.me...@collabora.com, varga.bala...@nisz.hu
Blocks: 90486

Created attachment 178366
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178366=edit
Sample FODP

- Open the attached FODP, which has a single chart,
- Double-click into the chart,
- Open its Data Table,
- Note the series title, "This is some test thingy", delete the first word
("This"), and close the dialog.

=> The series title (and the label) becomes: "This is some test thingy is some
test thingy", ie. it's prefixed with the original title.

Observed using LO Version: 7.4.0.0.alpha0+
(2f0c26dc83448a934af5383f9f6b7a607c334744) / Ubuntu.

This is a regression in LO 6.4, bibisected to the following commit using repo
bibisect-linux-64-6.4. Adding CC: to Balazs Varga.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=fa0a981af41a2606541eec1cb20a379a739691e0

author  Balazs Varga 2019-07-17
12:57:47 +0200
committer   László Németh2019-07-24 14:04:06
+0200

tdf#114166 DOCX chart import: fix missing complex categories


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

[Rafael Lima (via logerrit)]

 sfx2/source/commandpopup/CommandPopup.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3c94a0f7729f1638ab3b273a186c48de859cfb49
Author: Rafael Lima 
AuthorDate: Fri Feb 18 02:27:11 2022 +0100
Commit: Tomaž Vajngerl 
CommitDate: Fri Feb 18 05:47:40 2022 +0100

tdf#143817 Fix HUD deleting text contents in Writer

Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sfx2/source/commandpopup/CommandPopup.cxx 
b/sfx2/source/commandpopup/CommandPopup.cxx
index 473155f89a00..7575a5794b32 100644
--- a/sfx2/source/commandpopup/CommandPopup.cxx
+++ b/sfx2/source/commandpopup/CommandPopup.cxx
@@ -246,6 +246,7 @@ IMPL_LINK(CommandListBox, TreeViewKeyPress, const 
KeyEvent&, rKeyEvent, bool)
 else if (rKeyEvent.GetKeyCode().GetCode() == KEY_RETURN)
 {
 RowActivated(*mpCommandTreeView);
+return true;
 }
 
 return false;

[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143817

--- Comment #9 from Commit Notification 
 ---
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3c94a0f7729f1638ab3b273a186c48de859cfb49

tdf#143817 Fix HUD deleting text contents in Writer

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143817

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147501] New: Know- Can I talk to a live person at Facebook from experts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147501

Bug ID: 147501
   Summary: Know- Can I talk to a live person at Facebook from
experts
   Product: cppunit
   Version: 1.13
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kinwatts...@gmail.com
CC: markus.mohrh...@googlemail.com

Want to solve FB sign in issues? If yes then feel free to connect with techies
instantly. Can I talk to a live person on Facebook?  Make sure to fix your FB
account issues by speaking to the experts. Calling experts will rectify all the
issues.
https://www.primotechy.com/blog/how-do-i-talk-to-a-live-person-at-facebook/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sal/rtl

[Mike Kaganski (via logerrit)]

 sal/rtl/math.cxx |   20 
 1 file changed, 12 insertions(+), 8 deletions(-)

New commits:
commit cb56edb177f4db5b9cc4d140543c4b11d41ef1b0
Author: Mike Kaganski 
AuthorDate: Fri Feb 18 01:43:32 2022 +0300
Commit: Mike Kaganski 
CommitDate: Fri Feb 18 05:04:39 2022 +0100

Define policy to optimize to_decimal to our use case

We don't need it to strip trailing zeroes (we do that ourselves anyway);
also we don't need it to handle negatives.

Makes doubleToString ~5% faster in my testing.

Change-Id: Ie3c4e3fec1899364af54fda3f7141678a95359d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130120
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index edb894cb7820..b9a0a3348757 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -300,6 +300,9 @@ void doubleToString(typename T::String ** pResult,
 return;
 }
 
+// sign adjustment, instead of testing for fValue<0.0 this will also fetch 
-0.0
+bool bSign = std::signbit(fValue);
+
 if (std::isinf(fValue))
 {
 // #i112652# XMLSchema-2
@@ -311,7 +314,7 @@ void doubleToString(typename T::String ** pResult,
 nResultOffset = 0;
 }
 
-if (std::signbit(fValue))
+if (bSign)
 T::appendAscii(pResult, pResultCapacity, ,
RTL_CONSTASCII_STRINGPARAM("-"));
 
@@ -321,17 +324,18 @@ void doubleToString(typename T::String ** pResult,
 return;
 }
 
-decltype(jkj::dragonbox::to_decimal(fValue)) aParts{};
+if (bSign)
+fValue = -fValue;
+
+decltype(jkj::dragonbox::to_decimal(fValue, 
jkj::dragonbox::policy::sign::ignore,
+
jkj::dragonbox::policy::trailing_zero::ignore)) aParts{};
 if (fValue) // to_decimal is documented to only handle non-zero finite 
numbers
-aParts = jkj::dragonbox::to_decimal(fValue);
-else
-aParts.is_negative = std::signbit(fValue); // Handle -0.0
+aParts = jkj::dragonbox::to_decimal(fValue, 
jkj::dragonbox::policy::sign::ignore,
+
jkj::dragonbox::policy::trailing_zero::ignore);
 
 int nOrigDigits = decimalDigits(aParts.significand);
 int nExp = nOrigDigits + aParts.exponent - 1;
 int nRoundDigits = 15;
-if (aParts.is_negative)
-fValue = -fValue;
 
 // Unfortunately the old rounding below writes 1.79769313486232e+308 for
 // DBL_MAX and 4 subsequent nextafter(...,0).
@@ -461,7 +465,7 @@ void doubleToString(typename T::String ** pResult,
 assert(nBuf <= 1024);
 typename T::Char* pBuf = static_cast(alloca(nBuf * 
sizeof(typename T::Char)));
 typename T::Char * p = pBuf;
-if (aParts.is_negative)
+if (bSign)
 *p++ = '-';
 
 bool bHasDec = false;

[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147097

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146541] Preview in Chapter Numbering uses black font color on dark background instead of white for automatic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146541

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144911] digits misplaced when entering l-t-r text (starting with a number) in a r-t-l paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144911

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147132] Flatten Basic function implementations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147132

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147455] openeuler底座 编译的libreoffice-base创建时崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147455

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147455] openeuler底座 编译的libreoffice-base创建时崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147455

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147454] openeuler底座 编译的libreoffice-impress ppt崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147454

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147454] openeuler底座 编译的libreoffice-impress ppt崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147454

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147444] Calc - interaction between filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147444

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147444] Calc - interaction between filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147444

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147058] Problems with File-History and Network-Shares

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147058

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147444] Calc - interaction between filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147444

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147444] Calc - interaction between filters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147444

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147058] Problems with File-History and Network-Shares

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147058

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136281] Feature reqeuest: make paragraph sing at the end of a paragraph behave as a symbol that keeps all formatting infromation.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136281

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136281] Feature reqeuest: make paragraph sing at the end of a paragraph behave as a symbol that keeps all formatting infromation.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136281

--- Comment #10 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143989] on load Agenda.ods error when call user defined function with error not found method ThisComponent.getScriptProvider()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143989

--- Comment #2 from QA Administrators  ---
Dear Nerijus,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108912] [META] Sheet-level bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108912
Bug 108912 depends on bug 145745, which changed state.

Bug 145745 Summary: Create a "Duplicate sheet" option in LO Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=145745

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
Bug 86899 depends on bug 145745, which changed state.

Bug 145745 Summary: Create a "Duplicate sheet" option in LO Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=145745

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143817

--- Comment #8 from Rafael Lima  ---
@Tomaz, here's a simple fix. Could you please check it?

I tested it locally and it stopped deleting text after the command is executed
with the Enter key.

https://gerrit.libreoffice.org/c/core/+/130091

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147454] openeuler底座 编译的libreoffice-impress ppt崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147454

--- Comment #2 from zhangke <374910...@qq.com> ---
Created attachment 178365
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178365=edit
动态特效切换软件崩溃

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147455] openeuler底座 编译的libreoffice-base创建时崩溃

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147455

--- Comment #2 from zhangke <374910...@qq.com> ---
Created attachment 178364
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178364=edit
错误截图 无法连接数据库

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143817

--- Comment #7 from Rafael Lima  ---
Still present in LO 7.4 alpha.

So if I select some text, press Shift+Esc, look up a command such as "Italic"
and press Enter, the formatting will be applied but the text will be deleted
similarly to when we press Enter with text selected without opening the "Search
commands" dialog.

Pressing Ctrl+Z will restore the text with the command applied, meaning that it
does apply the command and then delete the text.

Clicking the command will execute it as expected... however this is not
productive, since this new feature is keyboard-oriented and most users will
want to press Enter after choosing a command.

System info:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9d50307b2e1fd26d415539d3ed8624c7a449e45b
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143218] FILEOPEN PPTX: Drawings using the pen feature in PowerPoint are not imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143218

Rafael Lima  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #3 from Rafael Lima  ---
Still present in LO 7.4 alpha.

IMO this feature would be really useful for those using Impress to teach at
schools, universities, as well as preparing lecture material. Also the existing
pen features in Impress are a bit limited and could be improved.

@Heiko, any chance we could add this as one of the possible GSoC projetcs? If
so, how can we do it?

We have this page with GSoC ideas, but I'm not sure how to go about suggesting
new entries to this page.
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Impress

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9d50307b2e1fd26d415539d3ed8624c7a449e45b
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135894] Add a "Distribution" button to the Tabbed interface

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135894

--- Comment #6 from Rafael Lima  ---
(In reply to andreas_k from comment #5)
> Thanks for the bug report will add

Hi Andreas, I was checking my old bug reports and noted that in LO 7.4 there is
now a "Distribution" drop down menu in the "Draw" tab of the notebookbar. It
shows a tooltip "Select at least three objects to distribute".

Was it you who implemented it? Do you have a commit related to this bug report?
I could not find it in Gerrit.

If so, let me know so I can close this as FIXED and link this report to the
patch in gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135990] Pasting Writer OLE objects into Impress with Math Formulas not rendering correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135990

--- Comment #3 from Rafael Lima  ---
Still present in 7.4 alpha.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 9d50307b2e1fd26d415539d3ed8624c7a449e45b
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114263] [LOCALHELP] More BASIC functions to document in Help pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114263

--- Comment #17 from Commit Notification 
 ---
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/401fb641aff217c7c333ce71d22abcf575d3ed09

tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141474] Documentation specifies incorrect parameter names for Basic functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141474

--- Comment #15 from Commit Notification 
 ---
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/401fb641aff217c7c333ce71d22abcf575d3ed09

tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114263] [LOCALHELP] More BASIC functions to document in Help pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114263

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Alain Romedenne (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 48fd4f813f067498c6813a57869072e2a6cdb884
Author: Alain Romedenne 
AuthorDate: Fri Feb 18 01:16:58 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Feb 18 01:16:58 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 401fb641aff217c7c333ce71d22abcf575d3ed09
  - tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page

Change-Id: I99ed22b86b04a3ae4338e0c2ab49dbd594032ac6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129607
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index d8d02f0803ea..401fb641aff2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5
+Subproject commit 401fb641aff217c7c333ce71d22abcf575d3ed09

[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary source/text

[Alain Romedenne (via logerrit)]

 AllLangHelp_sbasic.mk|1 
 source/auxiliary/sbasic.tree |1 
 source/text/sbasic/shared/CallByName.xhp |  122 +++
 3 files changed, 124 insertions(+)

New commits:
commit 401fb641aff217c7c333ce71d22abcf575d3ed09
Author: Alain Romedenne 
AuthorDate: Mon Feb 7 16:29:55 2022 +0100
Commit: Rafael Lima 
CommitDate: Fri Feb 18 01:16:57 2022 +0100

tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page

Change-Id: I99ed22b86b04a3ae4338e0c2ab49dbd594032ac6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129607
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index e3c220a6e..fa1952c19 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -395,6 +395,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/new_keyword \
 helpcontent2/source/text/sbasic/shared/calc_functions \
 helpcontent2/source/text/sbasic/shared/code-stubs \
+helpcontent2/source/text/sbasic/shared/CallByName \
 helpcontent2/source/text/sbasic/shared/classmodule \
 helpcontent2/source/text/sbasic/shared/collection \
 helpcontent2/source/text/sbasic/shared/compatible \
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index f9a59c2c8..35df2f89b 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -69,6 +69,7 @@
   BasicLibraries 
object
   Beep 
Statement
   Blue 
Function
+  CallByName 
Function
   Case 
Statement
   CBool 
Function
   CByte 
Function
diff --git a/source/text/sbasic/shared/CallByName.xhp 
b/source/text/sbasic/shared/CallByName.xhp
new file mode 100644
index 0..9a34a1883
--- /dev/null
+++ b/source/text/sbasic/shared/CallByName.xhp
@@ -0,0 +1,122 @@
+
+
+
+
+
+  
+CallByName Function
+/text/sbasic/shared/CallByName.xhp
+  
+
+
+
+
+
+CallByName Function
+Invokes a subroutine by its 
string name.
+
+
+  CallByName function
+
+
+
+
+  CallByName(object As Object, 
ProcName As String, CallType As Integer [,arg0 [,arg1 …]])
+
+
+
+
+result: An 
optional variable that contains the result of the called method or 
property.
+  
+
+object: A Basic 
module, ClassModule instance or UNO service holding 
properties or methods.
+ProcName: The 
Function, Sub or 
Property that is being called.
+CallType: The type 
of performed action such as Get, Let, Method and Set.
+arg0, arg1 …: The 
Function optional parameters given as positional 
arguments.
+Arguments are provided 
in the exact same order defined in the method signature. Keyword arguments are 
not possible.
+
+   
+   Value
+   CallType Description
+   
+   
+   1
+   Method: Calls a procedure as a function or a 
subroutine.
+   
+   
+   2
+   Get: Reads a property or variable 
content.
+   
+   
+   4
+   Let: Assigns a content to a 
Property or variable.
+   
+   
+   8
+   Set: Assigns a reference value to an 
Object or Variant 
variable.
+   
+
+
+
+
+
+A 
Calc.Maths module contains a Multiply 
function expecting a varying list of numbers.
+
+
+ScriptForge.Platform.Architecture 
information is retrieved.
+
+
+DisplayDirectory property of https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1ui_1_1dialogs_1_1FilePicker-members.html;
 name="FilePicker">com.sun.star.ui.dialogs.FilePicker UNO service is 
assigned a value, its content is read twice.
+
+
+
+  Sub 
CallByName_example   
+  
Const _Method = 1, _Get = 2, _Let = 4, _Set = 8
+  
+  
BasicLibraries.loadLibrary("Calc") ' Calc.Maths user library.module
+  
Dim cm As Object : cm = Calc.Maths
+  
MsgBox CallByName(cm, "Multiply", _Method, 3, 45, 1, 89)   ' 
12015
+  
MsgBox CallByName(cm, "Multiply", _Method, 1.85e15, 44, 10^8)  ' 
8.14E+24
+  
+  
GlobalScope.BasicLibraries.loadLibrary("ScriptForge")
+  
Dim p As Object : p = CreateScriptService("ScriptForge.Platform")
+  
MsgBox CallByName(p, "Architecture", _Get) ' 32bit/64bit
+  
+  Dim 
uno As Object : uno = 
CreateUNOService("com.sun.star.ui.dialogs.FilePicker")
+  
CallByName(uno, "DisplayDirectory", _Let, "Libreoffice")
+  
MsgBox CallByName(uno, "DisplayDirectory", _Get)   ' "LibreOffice"
+  
var = CallByName(uno, "getDisplayDirectory", _Get) ' "LibreOffice"
+  End 
Sub
+
+
+Calc.Maths module
+
+  Option 
Compatible ' Calc.Maths module
+  Option 
Explicit
+  
+  Public 
Function Multiply(ParamArray args() As Double) As Variant
+  
''' Multiply a variable list of numbers '''
+  
Dim ndx As Integer : Multiply = 1.0
+  If 
UBound(args) >= 0 Then
+ 
 For ndx = 0 To UBound(args)
+ 
 Multiply = Multiply * args(ndx)
+ 
 Next ndx
+  
End If
+  End 
Function 'Calc.Maths.Multiply()
+
+
+
+  
+  
+  
+
+
+
+
\ No 

[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147097

Rafael Lima  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147097

--- Comment #2 from Rafael Lima  ---
Created attachment 178363
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178363=edit
Sample file with a dialog

In this Calc file I added a push button. Click it and a dialog will appear with
two text boxes. Notice that the textbox border is "flat", even though it was
set to be "3D".

In "gtk3" and "win" it is flat with a border around, which makes it look
better, but it's flat anyway.

In "kf5" it is flat and has no borders, which makes it look awkward.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145700] FiLEOPEN DOC lighting direction has inverted z-direction for extruded custom shapes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145700

Regina Henschel  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107634] [META] Fontwork / WordArt bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107634
Bug 107634 depends on bug 147409, which changed state.

Bug 147409 Summary: Assertion for Fontwork > Same Letter Height
https://bugs.documentfoundation.org/show_bug.cgi?id=147409

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Alain Romedenne (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c856f9bec12d98ed49f01578ded79f16ae7be051
Author: Alain Romedenne 
AuthorDate: Fri Feb 18 00:51:15 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Feb 18 00:51:15 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5
  - tdf#146847 correction to Integer division help page

Change-Id: Icdbdaf1fed778a0d235277680a2504386ec9208f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130010
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index 0fa83de4173e..d8d02f0803ea 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0fa83de4173e9dfaaca3b3c288ec4843d15b9252
+Subproject commit d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5

[Libreoffice-commits] help.git: source/text

[Alain Romedenne (via logerrit)]

 source/text/sbasic/shared/03070700.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5
Author: Alain Romedenne 
AuthorDate: Wed Feb 16 15:48:28 2022 +0100
Commit: Rafael Lima 
CommitDate: Fri Feb 18 00:51:13 2022 +0100

tdf#146847 correction to Integer division help page

Change-Id: Icdbdaf1fed778a0d235277680a2504386ec9208f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130010
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03070700.xhp 
b/source/text/sbasic/shared/03070700.xhp
index 64e4ba2c1..fdb6768fc 100644
--- a/source/text/sbasic/shared/03070700.xhp
+++ b/source/text/sbasic/shared/03070700.xhp
@@ -24,7 +24,7 @@
 
 
   Operators;Integer division (\)
-  "\" operator (mathematical)
+  "\\" operator (mathematical)
 
 
 

[Libreoffice-bugs] [Bug 147100] FILEOPEN DOC Hidden paragraph before table is not hidden in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147100

raal  changed:

   What|Removed |Added

 CC||caol...@redhat.com
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #4 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara; Could you possibly take a look at this one?
Thanks

bdd0a608f23b1c4e54e3ec396e888cd40e2afa6f is the first bad commit
commit bdd0a608f23b1c4e54e3ec396e888cd40e2afa6f
Author: Matthew Francis 
Date:   Sun Mar 15 03:02:50 2015 +0800

source-hash-705a8c226aee3e68db492083b7cf8b704335328b

commit 705a8c226aee3e68db492083b7cf8b704335328b
Author: Caolán McNamara 
AuthorDate: Tue Sep 23 20:35:50 2014 +0100
Commit: Caolán McNamara 
CommitDate: Wed Sep 24 10:04:48 2014 +0100

WW8PLCFMan::AdjustEnds deeply flawed concept wrt change tracking

The whole idea of clipping the char attributes to before the cr that
word uses
as the end of para marker is flawed from especially the perspective of
redlining which is a char property in word.

If the redline encompasses the newline in order to state that it is
deleted,
then if the prop is clipped to before that newline then the end-of-para
doesn't
get marked as deleted

For now just remove the character attributes clipping from here to be
as
conservative as possible.

Hopefully the ordering of processing start pap before start chp and end
chp
before end pap and the other million improvements in the parser that
came about
after AdjustEnds was created avoids whatever problems were trying to be
worked
around here.

Change-Id: I5a72e462db2fff60f52b12c2125ea6ac363de695

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147100] FILEOPEN DOC Hidden paragraph before table is not hidden in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147100

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
Created attachment 178362
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178362=edit
from bibisect 44

Printscreen from bibisect_44max linux repo. Bisected where first started this,
not equal how it looks in 7.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146786] File > Close exits the program

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146786

--- Comment #4 from onlyshi...@gmail.com ---
deactivate this option: Tools - Options - LibreOffice - View - Use Skia for all
rendering
Then restart LibreOffice and try the File - Close 
Now you can't reproduce it.
Issue is related to-skia for all rendering

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129062

onlyshi...@gmail.com changed:

   What|Removed |Added

 Depends on||146786


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146786
[Bug 146786] File > Close exits the program
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146786] File > Close exits the program

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146786

onlyshi...@gmail.com changed:

   What|Removed |Added

 Blocks||129062

--- Comment #3 from onlyshi...@gmail.com ---
deactivate this option: Tools - Options - LibreOffice - View - Use Skia for all
rendering
Then restart LibreOffice and try the File - Close 
Now you can't reproduce it.
Issue is related to-skia for all rendering


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129062
[Bug 129062] [META] Skia library bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/qa svx/source

[Regina Henschel (via logerrit)]

 svx/qa/unit/customshapes.cxx|   36 
 svx/qa/unit/data/tdf147409_GeomItemHash.odg |binary
 svx/source/toolbars/extrusionbar.cxx|   13 ++
 svx/source/toolbars/fontworkbar.cxx |5 +++
 4 files changed, 48 insertions(+), 6 deletions(-)

New commits:
commit 4c0b033ece143b6f398157e812ff1c6b22e2855d
Author: Regina Henschel 
AuthorDate: Thu Feb 17 22:13:54 2022 +0100
Commit: Regina Henschel 
CommitDate: Thu Feb 17 23:56:37 2022 +0100

tdf#147409 tdf#146866 use SetPropertyValue for toggle

The toggles (Textpath,SameLetterHeights) and (Extrusion,Extrusion)
change a value by directly writing the value into the property. That
is lines (*pAny) <<= bOn;, for example. But that does not trigger
InvalidateHash() of the SdrCustomShapeGeometryItem. So the item has
still aHashState 'Valid'. On the other hand because of the change the
hash itself has changed. Therefore the == comparison between the
original item and its clone returns 'false' in customshapeitem.cxx#238.
And as a result, the assert in itempool.cxx#679 fails.

My solution replaces the direct writing with setting the value via
SetPropertyValue(), which includes the needed InvalidateHash(). The
method InvalidateHash() is private and so cannot be directly used in
fontwork.cxx and extrusionbar.cxx.

Change-Id: Ib6021defb61478de9cbefa8f26466a2fe21352a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130117
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index 081a6b7789e0..bcce0ad7b458 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -132,6 +132,42 @@ void lcl_AssertRectEqualWithTolerance(std::string_view 
sInfo, const tools::Recta
std::abs(rExpected.GetHeight() - 
rActual.GetHeight()) <= nTolerance);
 }
 
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf147409_GeomItemHash)
+{
+OUString aURL = m_directories.getURLFromSrc(sDataDirectory) + 
"tdf147409_GeomItemHash.odg";
+mxComponent = loadFromDesktop(aURL, 
"com.sun.star.comp.drawing.DrawingDocument");
+uno::Reference xShape(getShape(0));
+SdrObjCustomShape* pSdrCustomShape(
+
static_cast(SdrObject::getSdrObjectFromXShape(xShape)));
+
+// Mark Object
+SfxViewShell* pViewShell = SfxViewShell::Current();
+SdrView* pSdrView = pViewShell->GetDrawView();
+pSdrView->MarkObj(pSdrCustomShape, pSdrView->GetSdrPageView());
+
+// Apply FontworkSameLetterHeights toggle
+// Without patch a debug build fails assert in SfxItemPool::PutImpl and so 
crashes.
+dispatchCommand(mxComponent, ".uno:FontworkSameLetterHeights", {});
+}
+
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf146866_GeomItemHash)
+{
+OUString aURL = m_directories.getURLFromSrc(sDataDirectory) + 
"tdf147409_GeomItemHash.odg";
+mxComponent = loadFromDesktop(aURL, 
"com.sun.star.comp.drawing.DrawingDocument");
+uno::Reference xShape(getShape(0));
+SdrObjCustomShape* pSdrCustomShape(
+
static_cast(SdrObject::getSdrObjectFromXShape(xShape)));
+
+// Mark Object
+SfxViewShell* pViewShell = SfxViewShell::Current();
+SdrView* pSdrView = pViewShell->GetDrawView();
+pSdrView->MarkObj(pSdrCustomShape, pSdrView->GetSdrPageView());
+
+// Apply extrusion toggle
+// Without patch a debug build fails assert in SfxItemPool::PutImpl and so 
crashes.
+dispatchCommand(mxComponent, ".uno:ExtrusionToggle", {});
+}
+
 CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf145700_3D_NonUI)
 {
 // The document contains first light soft, no ambient color, no second 
light and shininess 6.
diff --git a/svx/qa/unit/data/tdf147409_GeomItemHash.odg 
b/svx/qa/unit/data/tdf147409_GeomItemHash.odg
new file mode 100644
index ..770b7a6c0b42
Binary files /dev/null and b/svx/qa/unit/data/tdf147409_GeomItemHash.odg differ
diff --git a/svx/source/toolbars/extrusionbar.cxx 
b/svx/source/toolbars/extrusionbar.cxx
index 26ac4805cde0..10b56ad4b369 100644
--- a/svx/source/toolbars/extrusionbar.cxx
+++ b/svx/source/toolbars/extrusionbar.cxx
@@ -125,23 +125,26 @@ static void impl_execute( SfxRequest const & rReq, 
SdrCustomShapeGeometryItem& r
 {
 case SID_EXTRUSION_TOGGLE:
 {
-css::uno::Any* pAny = rGeometryItem.GetPropertyValueByName( 
sExtrusion, sExtrusion );
-
 bool bOn(false);
-if( pAny )
+css::uno::Any* pAny = rGeometryItem.GetPropertyValueByName( 
sExtrusion, sExtrusion );
+if ( pAny )
 {
 (*pAny) >>= bOn;
 bOn = !bOn;
-(*pAny) <<= bOn;
+css::beans::PropertyValue aPropValue;
+aPropValue.Name = sExtrusion;
+aPropValue.Value <<= bOn;
+rGeometryItem.SetPropertyValue(sExtrusion, aPropValue);
 }
 else
 {
 css::beans::PropertyValue 

[Libreoffice-bugs] [Bug 147097] Text boxes in Basic dialogs are being rendered without borders

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147097

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||r...@post.cz
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from raal  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147475] AutoFilter: Search filter not working when choosing to show specific entries

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147475

--- Comment #4 from Rafael Lima  ---
I am glad this is NOTABUG.

However, I had no idea that the option "Search criteria = and <> must apply to
whole cells" would change the way the filter is applied in AutoFilter. I always
thought this option only applied to database functions, as stated in the help
page [1], where it says that the option "Specifies that the search criteria you
set for the Calc database functions must match the whole cell exactly."

There's no information about this option being applied to the AutoFilter. The
same goes for help pages [2] and [3] that should mention the effect that this
option may have.

The reason why I ended up having this "bug" is because some time ago I was
documenting DB functions and I disabled the aforementioned option to test its
effects, then I forgot to re-enable it.

Is it OK if I reopen this bug and send it to Documentation so we can improve
the help pages related to the AutoFilter ??

[1]
https://help.libreoffice.org/7.3/en-US/text/shared/optionen/01060500.html?System=UNIX=CALC

[2]
https://help.libreoffice.org/7.3/en-US/text/scalc/guide/autofilter.html?DbPAR=CALC#bm_id3156423

[3]
https://help.libreoffice.org/7.3/en-US/text/scalc/01/12040100.html?=CALC=UNIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Also bump Linux Clang baseline to 12.0.1 (was: Bump --enable-compiler-plugins Clang baseline?)

[Stephan Bergmann]

This is all done now, 
 
"Bump Linux Clang baseline to 8.0.1" and 
 
"Bump compiler plugins Clang baseline to 12.0.1".

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/useuniqueptr.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 3fb587e89421a862a1e65f47cad17839e2b832e4
Author: Stephan Bergmann 
AuthorDate: Thu Feb 17 09:42:05 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Feb 17 23:16:15 2022 +0100

Revert "Fix failure of loplugin:useuniqueptr with older compilers"

...0bf61855164af5751e78ca8626c10d604b1ab13b, which should be obsolete now:  
It
speculated why 05a337e297eb0cfe88c99503d760bd9eaf495b7d 
"loplugin:useuniqueptr
look for deleting in loops with iterators" had introduced Foo24 in
compilerplugins/clang/test/useuniqueptr.cxx wrapped in

  #if CLANG_VERSION >= 5

and came to the conclusion that "either the old compiler lacked Clang's 
recent
 "Fix Stmt::ignoreImplicit" (and the above
initialization expression happens to include a CXXBindTemporaryExpr, at 
least
with libstdc++), or an even older compiler was used in pre-C++17 mode".  But
both of those potential reasons should be moot now, as the Clang fix got
introduced towards Clang 8, and LO requires C++17 now (except for 3rd-party
code).

Change-Id: I307afbbecc5f031bca2319c4b22d54bd467eac81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130116
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/useuniqueptr.cxx 
b/compilerplugins/clang/useuniqueptr.cxx
index ae95cbdfe99e..c0ef34b2823a 100644
--- a/compilerplugins/clang/useuniqueptr.cxx
+++ b/compilerplugins/clang/useuniqueptr.cxx
@@ -664,10 +664,6 @@ void UseUniquePtr::CheckLoopDelete(const FunctionDecl* 
functionDecl, const CXXDe
 if (init)
 {
 init = init->IgnoreImplicit();
-if (!compiler.getLangOpts().CPlusPlus17)
-if (auto x = dyn_cast(init))
-if (x->isElidable())
-init = x->getArg(0)->IgnoreImplicit();
 if (auto x = dyn_cast(init))
 if (x->getNumArgs() == 1
 || (x->getNumArgs() >= 2 && 
isa(x->getArg(1

[Libreoffice-bugs] [Bug 134980] Compare documents doesn't recognize when image is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134980

--- Comment #9 from Dieter  ---
(In reply to Michael Stahl (allotropia) from comment #8)
> (In reply to Telesto from comment #7)
> > @Michael,
> > Some wisdom would be helpful. Is Tracking Changes - in the current
> > implementation, in theory - able to detect replaced images?
> 
> probably not.

So it's a WONTFIX?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103184] [META] UI theming bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103184

Dieter  changed:

   What|Removed |Added

 Depends on|137381  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137381
[Bug 137381] Chapter numbering preview inconsistent with dark theme
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143344

Dieter  changed:

   What|Removed |Added

 Depends on||137381


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137381
[Bug 137381] Chapter numbering preview inconsistent with dark theme
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137381] Chapter numbering preview inconsistent with dark theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137381

Dieter  changed:

   What|Removed |Added

 Blocks|103184  |143344


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103184
[Bug 103184] [META] UI theming bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=143344
[Bug 143344] [META] Linux Dark Mode bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143344] [META] Linux Dark Mode bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143344
Bug 143344 depends on bug 146541, which changed state.

Bug 146541 Summary: Preview in Chapter Numbering uses black font color on dark 
background instead of white for automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=146541

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137381] Chapter numbering preview inconsistent with dark theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137381

Dieter  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #4 from Dieter  ---
*** Bug 146541 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146541] Preview in Chapter Numbering uses black font color on dark background instead of white for automatic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146541

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Dieter  ---
Heiko, please confirm bug 137381. Your bug is a clear duplicate.

*** This bug has been marked as a duplicate of bug 137381 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147477] CALC unable to retain Sort under Data > Validity after save, close, and reopening document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147477

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #3 from m.a.riosv  ---
It is excel file format, I can't see with excel in Data Validation an option
for that.

Looks like if that option doesn't exist in excel.

https://www.excelcampus.com/tips/sort-drop-down-lists-automatically/

Works find ODF file format.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147490] Drawing makes menus and dialogs blank

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147490

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from m.a.riosv  ---
I can reproduce with Skia enable, It's strange, closing the file and reopening
again, doesn't happen.

With Skia disable, the buttons [500x500] begins to flicker a lot.

Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147486] Text highlight attribute applied to pre-existing tracked change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147486

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Bibisected with 6.2 to:

https://git.libreoffice.org/core/+/def855d05efeb711e246663c37add218aaadac2f

author  Michael Stahl Wed Sep 12 10:44:38 2018 +0200
committer   Michael Stahl Wed Sep 19 10:18:31
2018 +0200

sw_redlinehide_2: view cursor movement, SwCursorShell::LeftRight()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/externandnotdefined.cxx |7 ---
 1 file changed, 7 deletions(-)

New commits:
commit 3c535b25110cb2b9cde41dd469d9ece2b52b1444
Author: Stephan Bergmann 
AuthorDate: Thu Feb 17 09:36:32 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Feb 17 22:35:57 2022 +0100

Don't exclude vcl/source/app/salplug.cxx from loplugin:externandnotdefined

Whatever exactly the original reason to do so, it appears to no longer be
relevant.  (Maybe that salplug.cxx got reworked in the meantime?)

Change-Id: I5187635dcb095ca505b38992b19770fe232f5124
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/externandnotdefined.cxx 
b/compilerplugins/clang/externandnotdefined.cxx
index 676f666ba621..5fd59ca4b58c 100644
--- a/compilerplugins/clang/externandnotdefined.cxx
+++ b/compilerplugins/clang/externandnotdefined.cxx
@@ -11,8 +11,6 @@
 
 #include 
 
-#include "config_clang.h"
-
 #include "plugin.hxx"
 
 // Having an extern prototype for a method in a module and not actually 
declaring that method is dodgy.
@@ -61,11 +59,6 @@ bool ExternAndNotDefined::VisitFunctionDecl(const 
FunctionDecl * functionDecl) {
 {
 return true;
 }
-StringRef fileName { getFilenameOfLocation(functionDecl->getLocation()) };
-// keeps  the code structure of salplug.cxx easier to follow
-if (fileName == SRCDIR "/vcl/source/app/salplug.cxx") {
-return true;
-}
 report(
 DiagnosticsEngine::Warning,
 "extern prototype in main file without definition",

[Libreoffice-bugs] [Bug 147495] Scrolling within Calc sheet is erratic or ignored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147495

m.a.riosv  changed:

   What|Removed |Added

 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147408] EDIT Integer out of range overflows without message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147408

Robert Großkopf  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 CC||rob...@familiegrosskopf.de
Version|7.3.0.3 release |6.4.7.2 release

--- Comment #5 from Robert Großkopf  ---
Same behavior in LO 6.4.7.2. Could be it is an old bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147408] EDIT Integer out of range overflows without message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147408

Robert Großkopf  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Robert Großkopf  ---
Could confirm with internal Firebird, PostgreSQL direct connection, internal
HSQLDB …

All tested with LO 7.3.1.1 on OpenSUSE 15.3 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 4 commits - download.lst external/libxslt hwpfilter/source sw/qa sw/source

[Caolán McNamara (via logerrit)]

 download.lst  |6 
 external/libxslt/UnpackedTarball_libxslt.mk   |1 
 external/libxslt/e2584eed1c84c18f16e42188c30d2c3d8e3e8853.patch.1 |   69 
--
 external/libxslt/rpath.patch.0|2 
 hwpfilter/source/htags.cxx|   26 +--
 hwpfilter/source/hwpreader.cxx|   64 
++---
 sw/qa/core/data/ooxml/fail/LIBREOFFICE-DBDAZAEC.docx  |binary
 sw/source/core/unocore/unodraw.cxx|2 
 8 files changed, 32 insertions(+), 138 deletions(-)

New commits:
commit 22a8d7c22a023b34ec51cab4772b896dadb4d5ae
Author: Caolán McNamara 
AuthorDate: Thu Feb 17 09:57:34 2022 +
Commit: Michael Stahl 
CommitDate: Thu Feb 17 21:50:36 2022 +0100

Refetch in case SwTextNode::InsertItem causes it to be deleted

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130087
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 3dab7bc9dd8763d68fc2e6496e8069c7823685c2)

Change-Id: Ie189ae4d37ffc33e58bb405f2521d1ae02a9997b

diff --git a/sw/qa/core/data/ooxml/fail/LIBREOFFICE-DBDAZAEC.docx 
b/sw/qa/core/data/ooxml/fail/LIBREOFFICE-DBDAZAEC.docx
new file mode 100755
index ..add554ae9596
Binary files /dev/null and 
b/sw/qa/core/data/ooxml/fail/LIBREOFFICE-DBDAZAEC.docx differ
diff --git a/sw/source/core/unocore/unodraw.cxx 
b/sw/source/core/unocore/unodraw.cxx
index 876cad2231df..4f8c59dd3fb6 100644
--- a/sw/source/core/unocore/unodraw.cxx
+++ b/sw/source/core/unocore/unodraw.cxx
@@ -1177,6 +1177,8 @@ void SwXShape::setPropertyValue(const OUString& 
rPropertyName, const uno::Any& a
 SwFormatFlyCnt aFormat( pFormat );
 pNd->InsertItem(aFormat, pInternalPam->GetPoint()
 ->nContent.GetIndex(), 0 );
+//Refetch in case SwTextNode::InsertItem causes it to 
be deleted
+pFormat = GetFrameFormat();
 }
 else
 {
commit 5da6e5722fffb8f303a5c4f03c9cecb68c5a7f4c
Author: Caolán McNamara 
AuthorDate: Fri Jan 28 15:02:54 2022 +
Commit: Michael Stahl 
CommitDate: Thu Feb 17 21:50:32 2022 +0100

avoid dangling tmp files in hwp import

if there is embedded data use office-binary-data to transport it
instead of a temp file

https: //issues.oasis-open.org/browse/OFFICE-3933
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129076
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit e95d5d5666505cb05e9660f24f6c7ae039451ef8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129759
(cherry picked from commit bfff5c7dadf9628926fbb5cd0394fcfc4464eb0b)

Change-Id: Ia1cebf0770c99210df09f03dbb507451d9cf7764

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index d1e3d8d36691..ab400bac045c 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -515,62 +515,28 @@ void HwpReader::makeDrawMiscStyle( HWPDrawingObject *hdo )
 if( prop->flag >> 18  & 0x01 )
 {
 padd( "draw:name", sXML_CDATA, ascii(Int2Str(hdo->index, 
"fillimage%d", buf)));
-if( !prop->pictype )
+
+EmPicture *emp = nullptr;
+if (prop->pictype && strlen(prop->szPatternFile) > 3)
+emp = hwpfile.GetEmPictureByName(prop->szPatternFile);
+if (!emp)
 {
 padd( "xlink:href", sXML_CDATA,
 reinterpret_cast(hconv(kstr2hstr( 
reinterpret_cast(urltounix(prop->szPatternFile).c_str())).c_str(;
+padd( "xlink:type", sXML_CDATA, "simple");
+padd( "xlink:show", sXML_CDATA, "embed");
+padd( "xlink:actuate", sXML_CDATA, "onLoad");
 }
-else
-{
-EmPicture *emp = nullptr;
-if ( strlen( prop->szPatternFile ) > 3)
-emp = hwpfile.GetEmPictureByName(prop->szPatternFile);
-if( emp )
-{
-char filename[128+17+9];
-char dirname[128];
-int fd;
-#ifdef _WIN32
-GetTempPathA(sizeof(dirname), dirname);
-sprintf(filename, "%s%s",dirname, emp->name);
-if( (fd = open( filename , _O_CREAT | _O_WRONLY | 
_O_BINARY , 0666)) >= 0 )
-#else
-strcpy(dirname, "/tmp/");
-sprintf(filename, "%s%s", dirname, emp->name);
-if( (fd = open( filename , O_CREAT | O_WRONLY , 0666)) 
>= 0 )
-#endif
-