[Libreoffice-bugs] [Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *, void *, _typelib_TypeDescriptionReference *, _typelib_TypeDescription *, void (*)(void *), _uno_Mapping *)
https://bugs.documentfoundation.org/show_bug.cgi?id=115707 --- Comment #14 from Aron Budea --- Still in LO 7.4.0.0.alpha1+ (b2467d6c7af988f8ed4e090ebf9472be6c84fb06) / Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 148975] TABLE PROPERTIES: Improve table split across pages and columns
https://bugs.documentfoundation.org/show_bug.cgi?id=148975 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 113088] [META] Writer table properties dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113088 Dieter changed: What|Removed |Added Depends on||148975 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148975 [Bug 148975] TABLE PROPERTIES: Improve table split across pages and columns -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Dieter changed: What|Removed |Added Depends on|148975 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148975 [Bug 148975] TABLE PROPERTIES: Improve table split across pages and columns -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148975] TABLE PROPERTIES: Improve table split across pages and columns
https://bugs.documentfoundation.org/show_bug.cgi?id=148975 Dieter changed: What|Removed |Added Blocks|103100 |113088 Keywords||needsUXEval CC||dgp-m...@gmx.de Summary|Increase resolution of |TABLE PROPERTIES: Improve |allow-break-across-pages|table split across pages ||and columns --- Comment #1 from Dieter --- I see the use case and would support this. But I don't think we should use the linguistic term "orphan" and "widow", but just use something like Minimum of [ N ] table rows above break Minimum of [ M ] table rows below break cc: Design-Team for further input and decision Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs https://bugs.documentfoundation.org/show_bug.cgi?id=113088 [Bug 113088] [META] Writer table properties dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140215] Improve the Comment strings in .desktop files
https://bugs.documentfoundation.org/show_bug.cgi?id=140215 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Priority|medium |lowest Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144237] Enforce a sane minimum width on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=144237 Buovjaga changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|RESOLVED|NEW Ever confirmed|0 |1 Severity|normal |enhancement Summary|Trouble of getting out of a |Enforce a sane minimum |rolled up LibreOffice |width on Linux |Window | --- Comment #5 from Buovjaga --- Sorry, I was not testing this properly. While the width adjustment does snap to the window control width at first, I am able to make it into a thin line with kf5 and gen backends and mere closing button width on gtk3, if I resize to "negative width". This does not happen on Windows. The Start Center never goes narrower than its application launch panel. So let's set to NEW. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147268] Settings in English Sentence Checking and Keyboad Handling Optionsare are not remembered when installing a new version
https://bugs.documentfoundation.org/show_bug.cgi?id=147268 Dieter changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org --- Comment #3 from Dieter --- Not sure, if this is a bug or enhancement request Heiko, what do you think (please take into account bug 112440)? cc: Heiko Tietze -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147268] Settings in English Sentence Checking and Keyboad Handling Optionsare are not remembered when installing a new version
https://bugs.documentfoundation.org/show_bug.cgi?id=147268 Dieter changed: What|Removed |Added Summary|Some selected preferences |Settings in English |are not remembered when |Sentence Checking and |installing a new version|Keyboad Handling Optionsare ||are not remembered when ||installing a new version -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147268] Some selected preferences are not remembered when installing a new version
https://bugs.documentfoundation.org/show_bug.cgi?id=147268 --- Comment #2 from Dieter --- *** Bug 148697 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148697] Not all user settings transfer to new versions of LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=148697 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Thank you for reporting that issue. But I don't see a difference to your report bug 147268 so I mark it as duplicate. *** This bug has been marked as a duplicate of bug 147268 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112139] [META] Options dialog's Language settings bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112139 Bug 112139 depends on bug 112440, which changed state. Bug 112440 Summary: Change of language module in Writing aids isn't remembered https://bugs.documentfoundation.org/show_bug.cgi?id=112440 What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112440] Change of language module in Writing aids isn't remembered
https://bugs.documentfoundation.org/show_bug.cgi?id=112440 Dieter changed: What|Removed |Added Status|RESOLVED|NEW CC||dgp-m...@gmx.de Resolution|NOTABUG |--- --- Comment #13 from Dieter --- (In reply to Timur from comment #12) > Based on my shallow understanding of this and how I understand Help, I close > NAB. > Please set New if explained differently. Bug has keyword "needsDevAdvice". So we should respect this request from design-team and wait for devolper input before closing it as NAB. => NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147665] Replace Scheherazade font by Scheherazade New
https://bugs.documentfoundation.org/show_bug.cgi?id=147665 --- Comment #2 from Volga --- It's also responsible to replace a renamed font. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149207] FILESAVE background images change
https://bugs.documentfoundation.org/show_bug.cgi?id=149207 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149207] FILESAVE background images change
https://bugs.documentfoundation.org/show_bug.cgi?id=149207 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145250] Illegible dropdown menu
https://bugs.documentfoundation.org/show_bug.cgi?id=145250 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145250] Illegible dropdown menu
https://bugs.documentfoundation.org/show_bug.cgi?id=145250 --- Comment #5 from QA Administrators --- Dear fritzr, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145561] Problems with 3D
https://bugs.documentfoundation.org/show_bug.cgi?id=145561 --- Comment #2 from QA Administrators --- Dear Cesar F, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114469] SfxItemSet::InitRanges_Impl(unsigned short const*) leaks memory with multiple invocations
https://bugs.documentfoundation.org/show_bug.cgi?id=114469 --- Comment #7 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148168] LibreOffice Document Recovery dialog shows weird text input field
https://bugs.documentfoundation.org/show_bug.cgi?id=148168 skierpage changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED Version|7.3.1.3 release |7.3.3.2 release --- Comment #3 from skierpage --- (In reply to Roman Kuznetsov from comment #2) > Please write here info from your LibreOffice's Help-About dialog (use the > Copy botton there) It still happens. I just reproduced with Version: 7.3.3.2 / LibreOffice Community Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348 CPU threads: 4; OS: Linux 5.17; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Flatpak Calc: threaded I'm running a KDE Wayland desktop; I think LO is using Wayland not XWayland. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149212] Impress: Powerpoint OLE animations don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=149212 --- Comment #2 from Daniel Collins --- Note that on conversion from PPTX to ODP, OLE object animation entries are lost from the Animations sidebar. E.g., in the attached PPTX example, on slide 5, there are 5 animations listed -- 2 text and 3 OLE embedded objects. After conversion to ODP format, only 2 animations are listed -- just the 2 text objects. Nonetheless, the slide still "eats up" 3 extra clicks for the missing OLE animations. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149212] Impress: Powerpoint OLE animations don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=149212 --- Comment #1 from Daniel Collins --- Created attachment 180272 --> https://bugs.documentfoundation.org/attachment.cgi?id=180272=edit Publisher-made PPTX with OLE animations. Animated OLE objects start on slide 5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149212] New: Impress: Powerpoint OLE animations don't work
https://bugs.documentfoundation.org/show_bug.cgi?id=149212 Bug ID: 149212 Summary: Impress: Powerpoint OLE animations don't work Product: LibreOffice Version: 7.2.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dcoll...@superdan.net Description: Working as a college math professor, most undergraduate textbooks come with premade Powerpoint lecture slides from the publisher. I would like to present these with Libre Office Impress. However, in every case the animated OLE math objects fail to animate properly. This is consistently the case across a large number of textbooks, authors, producers, etc., that I've tried to use (working mostly with Pearson textbooks). Steps to Reproduce: 1. Open the PPTX file 2. Start the slide show, proceed to slide with OLE animations, click through (e.g., in attached file, slides 5, 7, 8, etc.) Actual Results: OLE objects fail to animate (in view at all times) Expected Results: OLE objects should animate (start invisible, then transition to visible on click) Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: - Note that text objects animate fine; it is only OLE objects (math images) that do not. - If the PPTX file is converted to ODP, the problem persists (OLE objects do not animate) - Although though the OLE objects don't animate, the slide still "eats up" the expected clicks; we must click as many times as OLE objects to get to the next slide - Even if we delete all the animations on a slide, these "hidden" clicks persist; we must still click as many times as objects to get to the next slide - Trying to backtrack to the previous slide often fails on slides with OLE animations that we tried to remove. - I can provide an arbitrary number of publisher-made PPTX slide decks with this problem, if desired (e.g., hundreds) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 6 commits - chart2/source oox/source
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx | 19 -
chart2/source/model/main/DataTable.cxx | 40 +--
chart2/source/view/axes/VAxisBase.cxx |3
chart2/source/view/axes/VAxisBase.hxx |4
chart2/source/view/axes/VCartesianAxis.cxx |6
chart2/source/view/axes/VCartesianAxis.hxx |3
chart2/source/view/axes/VCartesianCoordinateSystem.cxx |2
chart2/source/view/inc/DataTableView.hxx| 11
chart2/source/view/main/DataTableView.cxx | 154 ++--
oox/source/export/chartexport.cxx | 29 +-
10 files changed, 194 insertions(+), 77 deletions(-)
New commits:
commit dc10d2adbe02c32c689e9760e72a18323cbc8dec
Author: Tomaž Vajngerl
AuthorDate: Sat May 21 10:52:51 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat May 21 10:52:51 2022 +0900
chart2: set the char props. to the cells of a data table from model
This copies the char. properties from the model to the cells of
a data table, so the correct char width, font is used for text
when the table is rendered. Also add margin to the text, so it
looks better.
Change-Id: Ib74a8136459a31d64a86dec36a6ba14d2c313cf2
diff --git a/chart2/source/view/main/DataTableView.cxx
b/chart2/source/view/main/DataTableView.cxx
index 3992ea84d012..c8e2adae6fbe 100644
--- a/chart2/source/view/main/DataTableView.cxx
+++ b/chart2/source/view/main/DataTableView.cxx
@@ -5,7 +5,6 @@
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
*/
#include
@@ -59,11 +58,70 @@ void setTopCell(uno::Reference&
xPropertySet)
xPropertySet->setPropertyValue("TopBorder", uno::Any(aBorderLine));
xPropertySet->setPropertyValue("LeftBorder", uno::Any(aBorderLine));
}
+
+void copyProperty(uno::Reference& xOut,
+ uno::Reference& xIn, OUString const&
sPropertyName)
+{
+xOut->setPropertyValue(sPropertyName,
xIn->getPropertyValue(sPropertyName));
+}
}
void DataTableView::setCellDefaults(uno::Reference&
xPropertySet, bool bLeft,
bool bTop, bool bRight, bool bBottom)
{
+uno::Reference xDataTableProperties =
m_xDataTableModel.get();
+
+copyProperty(xPropertySet, xDataTableProperties, "CharColor");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontFamily");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontFamilyAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontFamilyComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontCharSet");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontCharSetAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontCharSetComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontName");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontNameAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontNameComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontPitch");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontPitchAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontPitchComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontStyleName");
+copyProperty(xPropertySet, xDataTableProperties, "CharFontStyleNameAsian");
+copyProperty(xPropertySet, xDataTableProperties,
"CharFontStyleNameComplex");
+
+copyProperty(xPropertySet, xDataTableProperties, "CharHeight");
+copyProperty(xPropertySet, xDataTableProperties, "CharHeightAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharHeightComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharKerning");
+copyProperty(xPropertySet, xDataTableProperties, "CharLocale");
+copyProperty(xPropertySet, xDataTableProperties, "CharLocaleAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharLocaleComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharPosture");
+copyProperty(xPropertySet, xDataTableProperties, "CharPostureAsian");
+copyProperty(xPropertySet, xDataTableProperties, "CharPostureComplex");
+copyProperty(xPropertySet, xDataTableProperties, "CharRelief");
+copyProperty(xPropertySet, xDataTableProperties, "CharShadowed");
+copyProperty(xPropertySet, xDataTableProperties, "CharStrikeout");
+copyProperty(xPropertySet, xDataTableProperties, "CharUnderline");
+copyProperty(xPropertySet, xDataTableProperties, "CharUnderlineColor");
+copyProperty(xPropertySet, xDataTableProperties, "CharUnderlineHasColor");
+copyProperty(xPropertySet, xDataTableProperties, "CharOverline");
+copyProperty(xPropertySet, xDataTableProperties,
[Libreoffice-bugs] [Bug 145973] Keyboard shortcut personalization not working and impossible to assign empty shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=145973 sdc.bla...@youmail.dk changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #3 from sdc.bla...@youmail.dk --- When specific fix cannot be identified, then status is WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149018] "Object" property dialog (and Navigator and UI elements) should be retitled "OLE Object"
https://bugs.documentfoundation.org/show_bug.cgi?id=149018 --- Comment #29 from sdc.bla...@youmail.dk --- (In reply to Mike Kaganski from comment #28) In light of the concerns expressed in comment 15 and comment 16, maybe something like the following should be added to the OLE description (which only elaborates on embedding at present). If an OLE object is linked to a target document, then the target document must be available in the location specified in the link. Deleting or moving the target document will make it impossible to open the linked OLE object. About "Object" > The description is highly abstract ... In the current form, I'm afraid it > helps no one. (But that would be for a follow-up?) Thanks for confirmation. Bug 149211. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149211] New: Entry for "Object" in General Glossary needs review/clarification
https://bugs.documentfoundation.org/show_bug.cgi?id=149211 Bug ID: 149211 Summary: Entry for "Object" in General Glossary needs review/clarification Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk CC: olivier.hal...@libreoffice.org Here is the entry for "Object" in the General Glossary [1]. --- Object An object is a screen element containing data. It can refer to application data, such as text or graphics. Objects are independent and do not influence each other. Any object containing data can be assigned certain commands. For example, a graphic object has commands for image editing and a spreadsheet contains calculation commands. 1. It is hard to understand what this entry means. 2. It is unclear if it is referring (at all) to images, shapes, textboxes, frames, and OLE objects -- where the Help pages are often using the term "object" as a "general" or "generic" term for referring to those different elements. 3. It seems important to improve that entry, especially given that the first two sentences of the General Glossary are: This glossary includes explanations of some of the most important terms you will come across in LibreOffice. Use the glossary to look up unfamiliar terms found in any LibreOffice application. [1] https://help.libreoffice.org/7.4/en-US/text/shared/00/0005.html#object -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Aron Budea changed: What|Removed |Added Depends on||149206 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149206 [Bug 149206] FILEOPEN: EMF/WMF: Image displayed incorrectly -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103859 Aron Budea changed: What|Removed |Added Depends on||149206 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149206 [Bug 149206] FILEOPEN: EMF/WMF: Image displayed incorrectly -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149206] FILEOPEN: EMF/WMF: Image displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=149206 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Blocks||108226, 103859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103859 [Bug 103859] [META] EMF/WMF (Enhanced/Windows Metafile) bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149061] When last paragraph in a document is a list paragraph of level 2 (or greater), then "Move Down with Subpoints" only moves items to after the Level 1 list paragraph (see
https://bugs.documentfoundation.org/show_bug.cgi?id=149061 --- Comment #7 from sdc.bla...@youmail.dk --- Forgot to repeat from comment 1: if an empty, non-list paragraph is added after the level 2 paragraph at the end of the document, then "Move Down with Subpoints" works as expected. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||149061 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149061 [Bug 149061] When last paragraph in a document is a list paragraph of level 2 (or greater), then "Move Down with Subpoints" only moves items to after the Level 1 list paragraph (see comment 5) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149061] When last paragraph in a document is a list paragraph of level 2 (or greater), then "Move Down with Subpoints" only moves items to after the Level 1 list paragraph (see
https://bugs.documentfoundation.org/show_bug.cgi?id=149061 sdc.bla...@youmail.dk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Summary|In the Bullets and |When last paragraph in a |Numbering toolbar, Move |document is a list |Down with Subpoints |paragraph of level 2 (or |misbehaves. (see comment 5) |greater), then "Move Down ||with Subpoints" only moves ||items to after the Level 1 ||list paragraph (see comment ||5) Blocks||103369 --- Comment #6 from sdc.bla...@youmail.dk --- Repro with: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: cdf8e971d5d46df4bcab35a99c4254df9459213f CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL General summary and elaboration: If a document ends with list paragraphs, where the last paragraph in the document is level 2 (or greater), then "Move Item Down with Subpoints" only moves an item (and its subpoints) to after the level 1 paragraph, but not the level 2 (or greater) paragraph. No problem to use "Move Item Down with Subpoints" if the last paragraph in the document is a Level 1 list paragraph. The problem only arises when there are list paragraphs with Level 2 or greater at the end. (Changing summary, because same command is found in Format > Lists) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103369 [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149201] [DOCX] Importing Word file results in subscripted text for the entire file
https://bugs.documentfoundation.org/show_bug.cgi?id=149201 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Regina Henschel --- Reason is the font setting "lowered by 0.5pt" in Word. Inside Word modify the Paragraph style "Normal". In that dialog open the "Format" list (bottom left of the dialog) and chose item "Font". In that dialog go to tab "Advanced". In section "Character Spacing" the field "Position" should be "Normal", but is "Lowered" b 0.5pt. That results in the markup in styles.xml in the docx document. This element is defined in 17.3.2.24 position (Vertically Raised or Lowered Text) in the standard. Apparently LibreOffice is now interpreting this setting somehow, LO 5.4 shows the text normally. But the values in LibreOffice are wrong. It would need 'lower by 4%' and 'Relative font size 100%'. What was the author thinking, making such a setting in Word? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149179] The filter dialog in LibreOffice Calc behaves strangely using Graphite GTK Theme
https://bugs.documentfoundation.org/show_bug.cgi?id=149179 --- Comment #8 from Khaldoun --- Just to let you know, I already raised this issue as well with the developer for the Graphite theme as well. https://github.com/vinceliuice/Graphite-gtk-theme/issues/68 In case can help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149207] FILESAVE background images change
https://bugs.documentfoundation.org/show_bug.cgi?id=149207 --- Comment #3 from maximilian-schind...@gmx.net --- the background image of page one got overwriten by the image of page two in this file. Version: 7.3.2.2 (x64) / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 24; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149207] FILESAVE background images change
https://bugs.documentfoundation.org/show_bug.cgi?id=149207 --- Comment #2 from maximilian-schind...@gmx.net --- Created attachment 180270 --> https://bugs.documentfoundation.org/attachment.cgi?id=180270=edit sample -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142821] Want option to see more effect info in the list of effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142821 --- Comment #2 from Eyal Rozenberg --- (In reply to Roman Kuznetsov from comment #1) > Please describe more details about your suggestion. What details about > animation effects do you want see additionally? Like I said - the details in the effect options settings. If all details are too much, then as much as the design team thinks would reasonably fit in (or even make it controllable by some pref). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 142821] Want option to see more effect info in the list of effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142821 --- Comment #2 from Eyal Rozenberg --- (In reply to Roman Kuznetsov from comment #1) > Please describe more details about your suggestion. What details about > animation effects do you want see additionally? Like I said - the details in the effect options settings. If all details are too much, then as much as the design team thinks would reasonably fit in (or even make it controllable by some pref). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144237] Trouble of getting out of a rolled up LibreOffice Window
https://bugs.documentfoundation.org/show_bug.cgi?id=144237 --- Comment #4 from Adalbert Hanßen --- (In reply to Buovjaga from comment #3) > I tested reducing the width and on KDE it stops when the top window controls > would disappear. So it really seems to be an Xfce issue, if they allow the > window to "swallow up" the controls. I guess it is possible to programmatically request a minimum window width. It should be set to something like 5 cm. Probably it is also possible to prevent rolling in completely by proper programming. The annoying roll in feature triggered a discussion at https://askubuntu.com/questions/621133/change-minimum-size-of-a-window where someone is complaining about "sublime text" and the answer is "There is no way you can change the min. window size in regards to resizing. That is up to the app to do & in the case of sublime it doesn't. Altering this is done in source & as sublime is closed source your best bet is to file a bug with them." -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149210] New: Libre Office crashes unexpectedly
https://bugs.documentfoundation.org/show_bug.cgi?id=149210 Bug ID: 149210 Summary: Libre Office crashes unexpectedly Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jan.feliksi...@yahoo.com The Libre Office crashes repeatedly when an attempt is made to reduce the size of the window manually, for example to fit two windows side by side - Libre office and some other program. Recently however this became some sort of a habit for the Libre Office which is highly annoying. It also crashed several times upon insertion of a copied fragment of text from my own pdf document, then upon modification to the content of the document currently open, so the question arises is this condition known to you or not? If known, what has been done to rectify this issue? Because it looks that a major bug exists in this program making it of very little value really. When it crashes it just freezes for a moment and then closes window, the client loses the entire work if he/she has not saved regularly. Here saying that it is annoying, would be a very gentle remark. Fix this! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=102847 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||145480 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145480 [Bug 145480] Find & Replace -> Footnotes/Endnotes -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145480] Find & Replace -> Footnotes/Endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145480 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||102847 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145480] Find & Replace -> Footnotes/Endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145480 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||102847 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102847 [Bug 102847] [META] Quick Find, Search and Replace -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 145480] Find & Replace -> Footnotes/Endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145480 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsDevEval, needsUXEval Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- I'm not sure it needs and not sure it's possibly to implement Added UX-team -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145480] Find & Replace -> Footnotes/Endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=145480 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsDevEval, needsUXEval Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- I'm not sure it needs and not sure it's possibly to implement Added UX-team -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 108904] [META] Page count field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108904 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||134283 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=134283 [Bug 134283] "Show Page Variable" broken in 7.0Beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134283] "Show Page Variable" broken in 7.0Beta2
https://bugs.documentfoundation.org/show_bug.cgi?id=134283 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108904 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108904 [Bug 108904] [META] Page count field bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145239] Customize footnote symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=145239 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Add UX-team Personally I don't have strong opinion here. Let's say "I'm not against it" but it may be some devs problem with those new symbols that we get from OpenSymbol font -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 145239] Customize footnote symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=145239 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Add UX-team Personally I don't have strong opinion here. Let's say "I'm not against it" but it may be some devs problem with those new symbols that we get from OpenSymbol font -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 145061] Font::identifyFont should also detect Type1C font
https://bugs.documentfoundation.org/show_bug.cgi?id=145061 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| CC||79045_79...@mail.ru --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Kevin, LO has dropped Type1 font support in 2016 year https://lists.freedesktop.org/archives/libreoffice/2016-October/075652.html Below is some excerpt: * Bitmap fonts on Windows (Michael) + no good physical font API on Windows + DirectWrite provides one. + doesn't work with Bitmap Fonts. + Office 2013 dropped bitmap / Type1 fonts and more long ago. + Biting us with Harfbuzz in some cases. + https://bugs.documentfoundation.org/show_bug.cgi?id=103514 + an issue for the WinXP support (Cloph) + Harfbuzz doesn't support that. (and will not support Type1 fonts) + 5.3 will be the last with current rendering + see no point in also support bitmap fonts in 5.4 + thought Khaled pushed a patch to make it work on WinXP (Caolan) + but happy to loose bitmap fonts. + we get a fallback font anyway (Michael) => abandoning bitmap / Type 1 fonts etc. if not DirectWrite supported in future. So I'm not sure about your suggestion... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/lo-all-static-libs config_host.mk.in configure.ac download.lst external/libtiff external/Module_external.mk Makefile.fetch RepositoryExternal.mk vcl/Library_vcl.mk
Makefile.fetch |1
RepositoryExternal.mk | 49
bin/lo-all-static-libs |1
config_host.mk.in |3 +
configure.ac|6 +++
download.lst|2 +
external/Module_external.mk |1
external/libtiff/ExternalProject_libtiff.mk | 44 +
external/libtiff/Makefile |7
external/libtiff/Module_libtiff.mk | 17 +
external/libtiff/UnpackedTarball_libtiff.mk | 16 +
vcl/Library_vcl.mk |1
12 files changed, 148 insertions(+)
New commits:
commit a2ffd71f20e14f797f30223fe29b3ac1e92eafdf
Author: Julien Nabet
AuthorDate: Thu May 19 20:09:51 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri May 20 22:29:00 2022 +0200
build libtiff
Change-Id: Id9b6e1355147c3f68b9922db14f1b4904a05c686
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134650
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/Makefile.fetch b/Makefile.fetch
index 10641958a9a1..ccb3860735cb 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -159,6 +159,7 @@ $(WORKDIR)/download: $(BUILDDIR)/config_$(gb_Side).mk
$(SRCDIR)/download.lst $(S
$(call fetch_Optional,LIBLANGTAG,LIBLANGTAG_TARBALL) \
$(call fetch_Optional,LIBNUMBERTEXT,LIBNUMBERTEXT_TARBALL) \
$(call fetch_Optional,LIBPNG,LIBPNG_TARBALL) \
+ $(call fetch_Optional,LIBTIFF,LIBTIFF_TARBALL) \
$(call fetch_Optional,LIBTOMMATH,LIBTOMMATH_TARBALL) \
$(call fetch_Optional,LIBWEBP,LIBWEBP_TARBALL) \
$(call fetch_Optional,LIBXML2,LIBXML_TARBALL) \
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 590a6093aea1..fa97dc350597 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2607,6 +2607,55 @@ endef
endif # !SYSTEM_LIBPNG
+ifneq ($(SYSTEM_LIBTIFF),)
+
+define gb_LinkTarget__use_libtiff
+$(call gb_LinkTarget_set_include,$(1),\
+ $$(INCLUDE) \
+ $(LIBTIFF_CFLAGS) \
+)
+
+$(call gb_LinkTarget_add_libs,$(1),\
+ $(LIBTIFF_LIBS) \
+)
+
+endef
+
+gb_ExternalProject__use_libtiff :=
+
+else # !SYSTEM_LIBTIFF
+
+define gb_LinkTarget__use_libtiff
+$(call gb_LinkTarget_set_include,$(1),\
+ $(LIBTIFF_CFLAGS) \
+ $$(INCLUDE) \
+)
+
+$(call gb_LinkTarget_set_include,$(1),\
+ -I$(call gb_UnpackedTarball_get_dir,libtiff)/src \
+ $$(INCLUDE) \
+)
+ifeq ($(OS),WNT)
+$(call gb_LinkTarget_add_libs,$(1),\
+ $(call
gb_UnpackedTarball_get_dir,libtiff)/libtiff/.libs/libtiff$(gb_StaticLibrary_PLAINEXT)
\
+)
+else
+$(call gb_LinkTarget_add_libs,$(1),\
+ -L$(call gb_UnpackedTarball_get_dir,libtiff)/libtiff/.libs -ltiff \
+)
+endif
+$(call gb_LinkTarget_use_external_project,$(1),libtiff)
+
+endef
+
+define gb_ExternalProject__use_libtiff
+$(call gb_ExternalProject_use_external_project,$(1),\
+ libtiff \
+)
+
+endef
+
+endif # !SYSTEM_LIBTIFF
ifneq ($(SYSTEM_LIBWEBP),)
diff --git a/bin/lo-all-static-libs b/bin/lo-all-static-libs
index fbe6d7010624..af4ff25f348b 100755
--- a/bin/lo-all-static-libs
+++ b/bin/lo-all-static-libs
@@ -123,6 +123,7 @@ echo $INSTDIR/$LIBO_LIB_FOLDER/lib*.a \
$WORKDIR/UnpackedTarball/liborcus/src/*/.libs/*.a \
$WORKDIR/UnpackedTarball/librevenge/src/*/.libs/*.a \
$WORKDIR/UnpackedTarball/libvisio/src/lib/.libs/*.a \
+ $WORKDIR/UnpackedTarball/libtiff/libtiff/.libs/*.a \
$WORKDIR/UnpackedTarball/libwebp/src/.libs/*.a \
$WORKDIR/UnpackedTarball/libwp?/src/lib/.libs/*.a \
$WORKDIR/UnpackedTarball/raptor/src/.libs/*.a \
diff --git a/config_host.mk.in b/config_host.mk.in
index df8205e8ad1d..4d45a94e5a2c 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -417,6 +417,8 @@ export LIBPNG_CFLAGS=$(gb_SPACE)@LIBPNG_CFLAGS@
export LIBPNG_LIBS=$(gb_SPACE)@LIBPNG_LIBS@
export LIBREPOSITORY_JAR=@LIBREPOSITORY_JAR@
export LIBSERIALIZER_JAR=@LIBSERIALIZER_JAR@
+export LIBTIFF_CFLAGS=$(gb_SPACE)@LIBTIFF_CFLAGS@
+export LIBTIFF_LIBS=$(gb_SPACE)@LIBTIFF_LIBS@
export LIBTOMMATH_CFLAGS=@LIBTOMMATH_CFLAGS@
export LIBTOMMATH_LIBS=@LIBTOMMATH_LIBS@
export LIBTOOL=@LIBTOOL@
@@ -644,6 +646,7 @@ export SYSTEM_LIBNUMBERTEXT=@SYSTEM_LIBNUMBERTEXT@
export SYSTEM_LIBNUMBERTEXT_DATA=@SYSTEM_LIBNUMBERTEXT_DATA@
export SYSTEM_LIBORCUS=@SYSTEM_LIBORCUS@
export SYSTEM_LIBPNG=@SYSTEM_LIBPNG@
+export SYSTEM_LIBTIFF=@SYSTEM_LIBTIFF@
export SYSTEM_LIBTOMMATH=@SYSTEM_LIBTOMMATH@
export SYSTEM_LIBWEBP=@SYSTEM_LIBWEBP@
export SYSTEM_LIBXML=@SYSTEM_LIBXML@
diff --git a/configure.ac b/configure.ac
index 34ba3f7844e0..186c472b7d45 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13555,6 +13555,12 @@
LIBPNG_CFLAGS_internal="-I${WORKDIR}/UnpackedTarball/libpng"
[Libreoffice-bugs] [Bug 144705] LibreOffice Writer and/or Calc show High CPU and "not responding" in Windows 10 Task Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=144705 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru Whiteboard| QA:needsComment| --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please update your LibreOffice to latest version like 7.2.7 or 7.3.2 and try repeat your problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sfx2/source
sfx2/source/appl/appserv.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 08891ae798b1e59719684d1b0343767c9d136a11
Author: Szymon Kłos
AuthorDate: Fri May 20 19:18:11 2022 +0200
Commit: Michael Meeks
CommitDate: Fri May 20 22:27:11 2022 +0200
lok: sidebar: notebookbar: don't change view mode for other views
We should change view mode (notebookbar/toolbars) only for current view.
This prevents the closed sidebar from showing when other view joins the
session.
Change-Id: Iaeec1bee0afab7552e223f17dd7afac27d288db9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134690
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 2e41b999cf70..6dec63520128 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -813,6 +813,14 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
pViewFrame = SfxViewFrame::GetFirst();
while( pViewFrame )
{
+// in LOK case we want to apply changes only to the current
view
+if (comphelper::LibreOfficeKit::isActive() &&
+pViewFrame != SfxViewShell::Current()->GetViewFrame())
+{
+pViewFrame = SfxViewFrame::GetNext( *pViewFrame );
+continue;
+}
+
Reference xFrame =
pViewFrame->GetFrame().GetFrameInterface();
// We want to change mode only for a current app module,
ignore other apps
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sfx2/source
sfx2/source/sidebar/SidebarController.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit 55f65c4d6cf7d1f68fe9c39c42431e6a15d903e6 Author: Szymon Kłos AuthorDate: Fri May 20 19:16:03 2022 +0200 Commit: Michael Meeks CommitDate: Fri May 20 22:26:15 2022 +0200 lok: sidebar: avoid async call to switch context This makes us sure we don't trigger actions for other views in LOK case. We need to call Sync() after RequestCall() so it will be executed synchronously. Change-Id: I07af8d34cbbc6bb42e1b8eeef47a921fdc4bf5f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134689 Tested-by: Jenkins CollaboraOffice Reviewed-by: Michael Meeks diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx index db4f9679e34a..ba1c968d022f 100644 --- a/sfx2/source/sidebar/SidebarController.cxx +++ b/sfx2/source/sidebar/SidebarController.cxx @@ -332,8 +332,9 @@ void SAL_CALL SidebarController::notifyContextChangeEvent (const css::ui::Contex maContextChangeUpdate.RequestCall(); // async call, not a prob // calling with held // solarmutex -// TODO: this call is redundant but mandatory for unit test to update context on document loading -if (!comphelper::LibreOfficeKit::isActive()) +if (comphelper::LibreOfficeKit::isActive()) +maContextChangeUpdate.Sync(); +else // TODO: this call is redundant but mandatory for unit test to update context on document loading UpdateConfigurations(); } } @@ -373,6 +374,8 @@ void SAL_CALL SidebarController::statusChanged (const css::frame::FeatureStateEv mnRequestedForceFlags |= SwitchFlag_ForceSwitch; maContextChangeUpdate.RequestCall(); // async call, ok to call // with held solarmutex +if (comphelper::LibreOfficeKit::isActive()) +maContextChangeUpdate.Sync(); } } @@ -1028,6 +1031,8 @@ IMPL_LINK(SidebarController, WindowEventHandler, VclWindowEvent&, rEvent, void) mpParentWindow->Invalidate(); mnRequestedForceFlags |= SwitchFlag_ForceNewDeck | SwitchFlag_ForceNewPanels; maContextChangeUpdate.RequestCall(); +if (comphelper::LibreOfficeKit::isActive()) +maContextChangeUpdate.Sync(); break; case VclEventId::ObjectDying:
[Libreoffice-bugs] [Bug 140215] Improve the Comment strings in .desktop files
https://bugs.documentfoundation.org/show_bug.cgi?id=140215 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||heiko.tietze@documentfounda ||tion.org, ||ilmari.lauhakangas@libreoff ||ice.org Whiteboard| QA:needsComment| --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Heiko, Ilmari what do you think about this one? Sounds reasonable... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Telesto changed: What|Removed |Added Depends on||147507 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147507 [Bug 147507] Crash swlo!SwRedlineExtraData_FormatColl::Reject+0x1b6 (when rejecting track changes one by one) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147507] Crash swlo!SwRedlineExtraData_FormatColl::Reject+0x1b6 (when rejecting track changes one by one)
https://bugs.documentfoundation.org/show_bug.cgi?id=147507 Telesto changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149209] Crash SwRedlineExtraData_FormatColl::Reject(this=0x00006000006d2e20, rPam=0x0000600007da0780) const at docredln.cxx:929:60
https://bugs.documentfoundation.org/show_bug.cgi?id=149209 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #3 from Telesto --- Oops, already reported *** This bug has been marked as a duplicate of bug 147507 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147507] Crash swlo!SwRedlineExtraData_FormatColl::Reject+0x1b6 (when rejecting track changes one by one)
https://bugs.documentfoundation.org/show_bug.cgi?id=147507 --- Comment #4 from Telesto --- *** Bug 149209 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147665] Replace Scheherazade font by Scheherazade New
https://bugs.documentfoundation.org/show_bug.cgi?id=147665 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Ever confirmed|0 |1 Whiteboard| QA:needsComment| Status|UNCONFIRMED |NEW Blocks||113305 CC||79045_79...@mail.ru Severity|normal |enhancement --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- We still have the bundled fonts therefore this one is a valid enhancement. Set to NEW Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113305 [Bug 113305] [META] Bundled fonts bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113305] [META] Bundled fonts bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113305 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||147665 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147665 [Bug 147665] Replace Scheherazade font by Scheherazade New -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149209] Crash SwRedlineExtraData_FormatColl::Reject(this=0x00006000006d2e20, rPam=0x0000600007da0780) const at docredln.cxx:929:60
https://bugs.documentfoundation.org/show_bug.cgi?id=149209 Telesto changed: What|Removed |Added Summary|SwRedlineExtraData_FormatCo |Crash |ll::Reject(this=0x6 |SwRedlineExtraData_FormatCo |06d2e20,|ll::Reject(this=0x6 |rPam=0x67da0780)|06d2e20, |const at|rPam=0x67da0780) |docredln.cxx:929:60 |const at ||docredln.cxx:929:60 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149209] SwRedlineExtraData_FormatColl::Reject(this=0x00006000006d2e20, rPam=0x0000600007da0780) const at docredln.cxx:929:60
https://bugs.documentfoundation.org/show_bug.cgi?id=149209 --- Comment #2 from Telesto --- Created attachment 180269 --> https://bugs.documentfoundation.org/attachment.cgi?id=180269=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149209] SwRedlineExtraData_FormatColl::Reject(this=0x00006000006d2e20, rPam=0x0000600007da0780) const at docredln.cxx:929:60
https://bugs.documentfoundation.org/show_bug.cgi?id=149209 --- Comment #1 from Telesto --- Created attachment 180268 --> https://bugs.documentfoundation.org/attachment.cgi?id=180268=edit BT with symbols -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149209] New: SwRedlineExtraData_FormatColl::Reject(this=0x00006000006d2e20, rPam=0x0000600007da0780) const at docredln.cxx:929:60
https://bugs.documentfoundation.org/show_bug.cgi?id=149209 Bug ID: 149209 Summary: SwRedlineExtraData_FormatColl::Reject(this=0x6 06d2e20, rPam=0x67da0780) const at docredln.cxx:929:60 Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: SwRedlineExtraData_FormatColl::Reject(this=0x606d2e20, rPam=0x67da0780) const at docredln.cxx:929:60 Steps to Reproduce: 1. Open attachment 171696 2. Follow steps in screencast, or at least approach it Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: 62531ec1091c7b3f6a3577889a18234790ec716d CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113117 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||147636 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147636 [Bug 147636] Please wait dialog box during uninstall displays incorrect messages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147636] Please wait dialog box during uninstall displays incorrect messages
https://bugs.documentfoundation.org/show_bug.cgi?id=147636 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| CC||79045_79...@mail.ru, ||mikekagan...@hotmail.com Blocks||113117 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- I can confirm next things: 1. A wrong text. Should be something like "Wait, while Windows uninstall your LibreOffice" 2. Cancel button disappearing in the end of the uninstalling process About some strange time while the process - I think it just MSI works so. Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL Mike, what do you think about the text changing for this uninstall window? Could we do it or it's some general window for different install/modify/uninstall process? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113117 [Bug 113117] [META] Windows installer/uninstaller bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 142821] Want option to see more effect info in the list of effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142821 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please describe more details about your suggestion. What details about animation effects do you want see additionally? Added UX-team. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 142821] Want option to see more effect info in the list of effects
https://bugs.documentfoundation.org/show_bug.cgi?id=142821 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Please describe more details about your suggestion. What details about animation effects do you want see additionally? Added UX-team. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146743] AquaSalInstance::getOSVersion() does not give Darwin kernel version
https://bugs.documentfoundation.org/show_bug.cgi?id=146743 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Are we sure we need the Darwin version instead macOS version? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148168] LibreOffice Document Recovery dialog shows weird text input field
https://bugs.documentfoundation.org/show_bug.cgi?id=148168 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Please write here info from your LibreOffice's Help-About dialog (use the Copy botton there) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147426] Media sidebars Position and time items not updating while playing media file
https://bugs.documentfoundation.org/show_bug.cgi?id=147426 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Confirm in Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149199] Interface a bit laggy on Linux (all vcl backends)
https://bugs.documentfoundation.org/show_bug.cgi?id=149199 --- Comment #7 from Guido Iodice --- To compare with another big software, inkscape has no lag in the interface. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149199] Interface a bit laggy on Linux (all vcl backends)
https://bugs.documentfoundation.org/show_bug.cgi?id=149199 --- Comment #6 from Guido Iodice --- this is a video made on windows, with the same problem. When the interface is redrawed, it takes a second to redraw it. I presume it is because vcl is slow https://youtu.be/6tSLpXf2acQ?t=137 this does not make Libreoffice unusable, but it is very tedious when you switch often from one object to another and have to wait each time for the interface to be updated. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |6 ++
vcl/unx/gtk3/gtkframe.cxx| 117 +++
2 files changed, 113 insertions(+), 10 deletions(-)
New commits:
commit 3a1db3389993fe9a52330fe36bb7bdfcea905242
Author: Caolán McNamara
AuthorDate: Thu May 19 09:34:16 2022 +0100
Commit: Caolán McNamara
CommitDate: Fri May 20 21:29:42 2022 +0200
follow org.freedesktop.appearance.color-scheme setting
Change-Id: Id26d01fd19cc3ee12c0e14b785b3a5149d22baf5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134634
Reviewed-by: Michael Stahl
Tested-by: Caolán McNamara
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index ced3613ad0ca..c90afbdee899 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -185,6 +185,8 @@ class GtkSalFrame final : public SalFrame
GtkEventControllerKey* m_pKeyController;
gulong m_nSettingChangedSignalId;
#endif
+gulong m_nPortalSettingChangedSignalId;
+GDBusProxy* m_pSettingsPortal;
#if !GTK_CHECK_VERSION(4, 0, 0)
GdkWindow* m_pForeignParent;
GdkNativeWindow m_aForeignParentWindow;
@@ -412,6 +414,8 @@ class GtkSalFrame final : public SalFrame
bool HandleMenubarMnemonic(guint eState, guint nKeyval);
+void ListenPortalSettings();
+
public:
cairo_surface_t*m_pSurface;
basegfx::B2IVector m_aFrameSize;
@@ -633,6 +637,8 @@ public:
const cairo_font_options_t* get_font_options();
+void SetColorScheme(GVariant* variant);
+
void DisallowCycleFocusOut();
bool IsCycleFocusOutDisallowed() const;
void AllowCycleFocusOut();
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index c6fb8ac14ac1..7108f9206380 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -76,6 +76,12 @@ int GtkSalFrame::m_nFloats = 0;
static GDBusConnection* pSessionBus = nullptr;
+static void EnsureSessionBus()
+{
+if (!pSessionBus)
+pSessionBus = g_bus_get_sync(G_BUS_TYPE_SESSION, nullptr, nullptr);
+}
+
sal_uInt16 GtkSalFrame::GetKeyModCode( guint state )
{
sal_uInt16 nCode = 0;
@@ -541,8 +547,7 @@ static void attach_menu_model(GtkSalFrame* pSalFrame)
#if !GTK_CHECK_VERSION(4,0,0)
// Get a DBus session connection.
-if (!pSessionBus)
-pSessionBus = g_bus_get_sync (G_BUS_TYPE_SESSION, nullptr, nullptr);
+EnsureSessionBus();
if (!pSessionBus)
return;
@@ -629,13 +634,9 @@ void GtkSalFrame::EnsureAppMenuWatch()
return;
// Get a DBus session connection.
-if ( pSessionBus == nullptr )
-{
-pSessionBus = g_bus_get_sync( G_BUS_TYPE_SESSION, nullptr, nullptr );
-
-if ( pSessionBus == nullptr )
-return;
-}
+EnsureSessionBus();
+if (!pSessionBus)
+return;
// Publish the menu only if AppMenu registrar is available.
m_nWatcherId = g_bus_watch_name_on_connection( pSessionBus,
@@ -698,8 +699,14 @@ GtkSalFrame::~GtkSalFrame()
{
SolarMutexGuard aGuard;
-if(m_nWatcherId)
+if (m_nWatcherId)
g_bus_unwatch_name(m_nWatcherId);
+
+if (m_nPortalSettingChangedSignalId)
+g_signal_handler_disconnect(m_pSettingsPortal,
m_nPortalSettingChangedSignalId);
+
+if (m_pSettingsPortal)
+g_object_unref(m_pSettingsPortal);
}
GtkWidget *pEventWidget = getMouseEventWidget();
@@ -900,6 +907,8 @@ void GtkSalFrame::InitCommon()
m_pSurface = nullptr;
m_nGrabLevel = 0;
m_bSalObjectSetPosSize = false;
+m_nPortalSettingChangedSignalId = 0;
+m_pSettingsPortal = nullptr;
m_aDamageHandler.handle = this;
m_aDamageHandler.damaged = ::damaged;
@@ -1243,6 +1252,91 @@ void GtkSalFrame::AllowCycleFocusOut()
#endif
}
+namespace
+{
+enum ColorScheme
+{
+DEFAULT,
+PREFER_DARK,
+PREFER_LIGHT
+};
+
+bool ReadColorScheme(GDBusProxy* proxy, GVariant** out)
+{
+g_autoptr (GVariant) ret =
+g_dbus_proxy_call_sync(proxy, "Read",
+ g_variant_new ("(ss)",
"org.freedesktop.appearance", "color-scheme"),
+ G_DBUS_CALL_FLAGS_NONE, G_MAXINT, nullptr,
nullptr);
+if (!ret)
+return false;
+
+g_autoptr (GVariant) child = nullptr;
+g_variant_get(ret, "(v)", );
+g_variant_get(child, "v", out);
+
+return true;
+}
+}
+
+void GtkSalFrame::SetColorScheme(GVariant* variant)
+{
+if (!m_pWindow)
+return;
+
+guint32 color_scheme = g_variant_get_uint32(variant);
+if (color_scheme > PREFER_LIGHT)
+color_scheme = DEFAULT;
+
+bool bDarkIconTheme(color_scheme == PREFER_DARK);
+GtkSettings* pSettings = gtk_widget_get_settings(m_pWindow);
+
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svx/source
svx/source/unodraw/unoshape.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit f6ced2a3c3d013e904e33cba0e71997ae2437877
Author: Michael Stahl
AuthorDate: Wed May 18 18:25:07 2022 +0200
Commit: Caolán McNamara
CommitDate: Fri May 20 21:28:41 2022 +0200
svx: fix double-free if SvxShape of SwDrawVirtObj is disposed
First SvxShape::dispose() deletes it, then ~SwDrawFrameFormat() via
~SwDrawContact() calls SwDrawContact::RemoveAllVirtObjs() and deletes it
again.
Back in 2009, CWS dba32 (60698c8a619f219129dbeac7da1f962f3fa63f6a)
added this OSL_ENSURE, let's actually try to fix this now.
Change-Id: I5c391aa425aa75fb87cecccbf9e41c9f90196f9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134609
Reviewed-by: Michael Stahl
Tested-by: Jenkins
(cherry picked from commit 5eb25f6a7ecb215f7bc81116cd930c1dec645e8d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134621
Reviewed-by: Caolán McNamara
diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 98a104c49fc8..ee3e58dd0190 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -1286,10 +1286,6 @@ void SAL_CALL SvxShape::dispose()
if ( pObject->IsInserted() && pObject->getSdrPageFromSdrObject() )
{
-OSL_ENSURE( HasSdrObjectOwnership(), "SvxShape::dispose: is the below
code correct?" );
-// normally, we are allowed to free the SdrObject only if we have
its ownership.
-// Why isn't this checked here?
-
SdrPage* pPage = pObject->getSdrPageFromSdrObject();
// delete the SdrObject from the page
const size_t nCount = pPage->GetObjCount();
@@ -1298,7 +1294,10 @@ void SAL_CALL SvxShape::dispose()
if ( pPage->GetObj( nNum ) == pObject )
{
OSL_VERIFY( pPage->RemoveObject( nNum ) == pObject );
-bFreeSdrObject = true;
+if (HasSdrObjectOwnership())
+{
+bFreeSdrObject = true;
+}
break;
}
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/inc sw/source
sw/inc/hints.hxx |4 ++-
sw/source/core/attr/hints.cxx |7 --
sw/source/core/doc/docbm.cxx | 28
sw/source/core/inc/txtfrm.hxx |3 ++
sw/source/core/text/txtfrm.cxx| 44 +-
sw/source/core/txtnode/ndtxt.cxx |7 +++---
sw/source/core/txtnode/txtedt.cxx |2 -
7 files changed, 74 insertions(+), 21 deletions(-)
New commits:
commit e940b48617b29b0bccf0491a1aa5162a10c2616b
Author: Michael Stahl
AuthorDate: Wed May 18 18:31:14 2022 +0200
Commit: Caolán McNamara
CommitDate: Fri May 20 21:28:13 2022 +0200
sw_fieldmarkhide: fix wrong handling of SwInsText for fieldmarks
For redlines, typically DocumentContentOperationsManager::InsertString()
will insert text, and it explicitly removes any redlines on the text
that has been inserted, hence it is always visible - so effectively the
sw::MergedPara is updated correctly.
However for fieldmarks the situation is different, if the insertion
happens inside of the part that is hidden in the layout, then it must
not be inserted into the sw::MergedPara.
Try to figure out which part(s) of a fieldmark the insertion position is
in and ignore the inserted text as appropriate in
SwTextFrame::SwClientNotify().
Change-Id: Ic5066b20e9609f50438ca64ac7d2cbd09baeef23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134611
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 288ad999090d3f88d87f52ff9b292f473f869601)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134616
Reviewed-by: Caolán McNamara
diff --git a/sw/inc/hints.hxx b/sw/inc/hints.hxx
index afaf1d9022d9..9c37399f68f6 100644
--- a/sw/inc/hints.hxx
+++ b/sw/inc/hints.hxx
@@ -80,8 +80,10 @@ class SwInsText final : public SwMsgPoolItem
public:
sal_Int32 nPos;
sal_Int32 nLen;
+bool isInsideFieldmarkCommand;
+bool isInsideFieldmarkResult;
-SwInsText( sal_Int32 nP, sal_Int32 nL );
+SwInsText(sal_Int32 nP, sal_Int32 nL, bool isInFMCommand, bool
isInFMResult);
};
class SwDelChr final : public SwMsgPoolItem
diff --git a/sw/source/core/attr/hints.cxx b/sw/source/core/attr/hints.cxx
index 81685b777033..8016037bfdb8 100644
--- a/sw/source/core/attr/hints.cxx
+++ b/sw/source/core/attr/hints.cxx
@@ -31,8 +31,11 @@ SwFormatChg::SwFormatChg( SwFormat* pFormat )
{
}
-SwInsText::SwInsText( sal_Int32 nP, sal_Int32 nL )
-: SwMsgPoolItem( RES_INS_TXT ), nPos( nP ), nLen( nL )
+SwInsText::SwInsText(sal_Int32 const nP, sal_Int32 const nL, bool const
isInFMCommand, bool const isInFMResult)
+: SwMsgPoolItem( RES_INS_TXT )
+, nPos( nP ), nLen( nL )
+, isInsideFieldmarkCommand(isInFMCommand)
+, isInsideFieldmarkResult(isInFMResult)
{
}
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index e3c87f5ea065..0b8f5a39d158 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1979,4 +1979,32 @@ void DelBookmarks(
}
}
+namespace sw {
+
+SwInsText MakeSwInsText(SwTextNode & rNode, sal_Int32 const nPos, sal_Int32
const nLen)
+{
+SwCursor cursor(SwPosition(rNode, nPos), nullptr);
+bool isInsideFieldmarkCommand(false);
+bool isInsideFieldmarkResult(false);
+while (auto const*const pMark =
rNode.GetDoc().getIDocumentMarkAccess()->getFieldmarkFor(*cursor.GetPoint()))
+{
+if (sw::mark::FindFieldSep(*pMark) < *cursor.GetPoint())
+{
+isInsideFieldmarkResult = true;
+}
+else
+{
+isInsideFieldmarkCommand = true;
+}
+*cursor.GetPoint() = pMark->GetMarkStart();
+if (!cursor.Left(1))
+{
+break;
+}
+}
+return SwInsText(nPos, nLen, isInsideFieldmarkCommand,
isInsideFieldmarkResult);
+}
+
+} // namespace sw
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/txtfrm.hxx b/sw/source/core/inc/txtfrm.hxx
index f1016eb9a1e0..9550a0e31ab9 100644
--- a/sw/source/core/inc/txtfrm.hxx
+++ b/sw/source/core/inc/txtfrm.hxx
@@ -30,6 +30,7 @@ namespace com::sun::star::linguistic2 { class
XHyphenatedWord; }
namespace sw::mark { class IMark; }
class SwCharRange;
+class SwInsText;
class SwTextNode;
class SwTextAttrEnd;
class SwTextFormatter;
@@ -146,6 +147,8 @@ bool IsMarkHintHidden(SwRootFrame const& rLayout,
void RecreateStartTextFrames(SwTextNode & rNode);
+auto MakeSwInsText(SwTextNode & rNode, sal_Int32 nPos, sal_Int32 nLen) ->
SwInsText;
+
/**
* Decides if rTextNode has a numbering which has layout-level values (e.g.
Arabic, but not
* none or bullets).
diff --git a/sw/source/core/text/txtfrm.cxx b/sw/source/core/text/txtfrm.cxx
index 3c3c82b4e1ac..fb177841728d 100644
--- a/sw/source/core/text/txtfrm.cxx
+++ b/sw/source/core/text/txtfrm.cxx
@@ -2144,28 +2144,44 @@ void SwTextFrame::SwClientNotify(SwModify const&
[Libreoffice-bugs] [Bug 149173] Crash BigPtrEntry::GetArray(this=0x0000600001726940) const at bparr.hxx:106:23 (STR: comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=149173 --- Comment #7 from Julien Nabet --- Created attachment 180267 --> https://bugs.documentfoundation.org/attachment.cgi?id=180267=edit console logs during opening Considering logs during opening show it needs some work here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149173] Crash BigPtrEntry::GetArray(this=0x0000600001726940) const at bparr.hxx:106:23 (STR: comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=149173 Julien Nabet changed: What|Removed |Added Keywords|wantBacktrace |haveBacktrace Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149173] Crash BigPtrEntry::GetArray(this=0x0000600001726940) const at bparr.hxx:106:23 (STR: comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=149173 --- Comment #6 from Julien Nabet --- Created attachment 180266 --> https://bugs.documentfoundation.org/attachment.cgi?id=180266=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assertion just after closing the document put in attachment. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34552] EDITING: Calc loses row height value when modifying a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=34552 --- Comment #25 from Rafael Lima --- This is a very weird bug. I still can reproduce the bug with the current master build of LO 7.4 and using the provided XLS file. However, I was not able to create another file from scratch where this bug happens. There's something special about the sample file that I could not figure out. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149206] FILEOPEN: EMF/WMF: Image displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=149206 Paris Oplopoios changed: What|Removed |Added Regression By|offtkp | --- Comment #2 from Paris Oplopoios --- Reproduced, I'll look into this -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149207] FILESAVE background images change
https://bugs.documentfoundation.org/show_bug.cgi?id=149207 Rafael Lima changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Rafael Lima --- Can you provide a sample file? Also, what version of LibreOffice are you using? What OS? Please, copy and paste the "Version Information" found under Help - About LibreOffice. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149199] Interface a bit laggy on Linux (all vcl backends)
https://bugs.documentfoundation.org/show_bug.cgi?id=149199 --- Comment #5 from Rafael Lima --- I cannot reproduce the bug. I am using LibreOffice with the kf5 VCL backend as well and I have not experienced any lag. Let's see if anyone else can reproduce this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/streaming/memorystream.cxx | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
New commits:
commit 826b536fddfebf9e19efae9dbf3dbd86861c6d74
Author: Noel Grandin
AuthorDate: Fri May 20 12:52:13 2022 +0200
Commit: Noel Grandin
CommitDate: Fri May 20 20:55:54 2022 +0200
don't waste time on memset when we're just going to overwrite it
Change-Id: Id01b056a28e23c55757b0b4e08a5901c76821b6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134677
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/comphelper/source/streaming/memorystream.cxx
b/comphelper/source/streaming/memorystream.cxx
index a7612bf67b07..2abcb6b1209f 100644
--- a/comphelper/source/streaming/memorystream.cxx
+++ b/comphelper/source/streaming/memorystream.cxx
@@ -82,7 +82,18 @@ public:
virtual void SAL_CALL truncate() override;
private:
-std::vector< sal_Int8 > maData;
+// prevents std::vector from wasting time doing memset on data we are
going to overwrite anyway
+struct NoInitInt8
+{
+sal_Int8 value;
+NoInitInt8() noexcept {
+// do nothing
+static_assert(sizeof(NoInitInt8) == sizeof(sal_Int8), "invalid
size");
+static_assert(alignof(NoInitInt8) == alignof(sal_Int8), "invalid
alignment");
+}
+};
+
+std::vector< NoInitInt8 > maData;
sal_Int32 mnCursor;
};
@@ -132,8 +143,8 @@ sal_Int32 SAL_CALL UNOMemoryStream::readBytes( Sequence<
sal_Int8 >& aData, sal_
if( nBytesToRead )
{
-sal_Int8* pData = &(*maData.begin());
-sal_Int8* pCursor = &(pData[mnCursor]);
+NoInitInt8* pData = &(*maData.begin());
+NoInitInt8* pCursor = &(pData[mnCursor]);
memcpy( static_cast(aData.getArray()),
static_cast(pCursor), nBytesToRead );
mnCursor += nBytesToRead;
@@ -205,8 +216,8 @@ void SAL_CALL UNOMemoryStream::writeBytes( const Sequence<
sal_Int8 >& aData )
if( static_cast< sal_Int32 >( nNewSize ) > static_cast< sal_Int32 >(
maData.size() ) )
maData.resize( nNewSize );
-sal_Int8* pData = &(*maData.begin());
-sal_Int8* pCursor = &(pData[mnCursor]);
+NoInitInt8* pData = &(*maData.begin());
+NoInitInt8* pCursor = &(pData[mnCursor]);
memcpy( pCursor, aData.getConstArray(), nBytesToWrite );
mnCursor += nBytesToWrite;
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Rafael Lima changed: What|Removed |Added Depends on||149208 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=149208 [Bug 149208] [XLSX] Excessive border weight in imported Excel files -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 Rafael Lima changed: What|Removed |Added Blocks||59284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=59284 [Bug 59284] [META] Cell border related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79787] Normal cell borders are showing dashed/dotted when export to xlsx/xls and reopen in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=79787 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||9208 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||787 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 79787] Normal cell borders are showing dashed/dotted when export to xlsx/xls and reopen in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=79787 --- Comment #56 from Rafael Lima --- Created attachment 180265 --> https://bugs.documentfoundation.org/attachment.cgi?id=180265=edit Screenshot as of LO 7.3 It seems this issue has been fixed since 7.3. Reproducing the steps from Kevin Suo will result in solid borders both in Excel and Calc. This is good news, however this fix raised an inconsistency in border weights, which has been reported in Bug 149208. In summary, the way LO Calc draws the borders in the screen make them look excessively thick. IMO this bug could be closed as WORKSFORME since no patch was directly associated with it and the bug no longer occurs. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109530] [META] File opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=109530 Bug 109530 depends on bug 128993, which changed state. Bug 128993 Summary: Annoying delay of 10 seconds when opening Libreoffice Writer files https://bugs.documentfoundation.org/show_bug.cgi?id=128993 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 128993] Annoying delay of 10 seconds when opening Libreoffice Writer files
https://bugs.documentfoundation.org/show_bug.cgi?id=128993 schregen...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #23 from schregen...@gmail.com --- I've been using a newer version (7.3.3.2) for 2-3 weeks and didn't encounter the bug yet. But then the version where it originally appeared (6.2.8.2) also works again. As assumed before it probably relates to some kind of server check - which may have been fixed on the server side for now (although I thought the same last year and then the bug reappeared after a month). Yet I have to say keeping this bugreport open is a bit tiring - especially because of its irregular behaviour. Thus I'm for closing it until it becomes a real problem. But as said, for the past couple of weeks there was no problem, so I marked it as resolved. P.S.: I never encountered the bug mentioned by Paolo Benvenuto (which may be something entirely different). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149205] FILESAVE: PPTX: Incorrect background color after RT ( part 2 )
https://bugs.documentfoundation.org/show_bug.cgi?id=149205 Miklos Vajna changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148422] Assertion failed: (rSData.empty() || rSData[0].m_bRedlineMoved || (rSData[0].m_nRedlineCount == rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())), function Se
https://bugs.documentfoundation.org/show_bug.cgi?id=148422 --- Comment #7 from Telesto --- Another way 1. Open attachment 179679 2. Select "either contributed by volunteers, or funded" 3. Press backspace 4. Edit -> track changes -> Manage 5. Reject, reject, reject (so each entry one by one 6. Press and hold CTRL+Z -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 --- Comment #3 from Rafael Lima --- Created attachment 180264 --> https://bugs.documentfoundation.org/attachment.cgi?id=180264=edit Screenshot of the file opened in LO Calc at 200% zoom -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 --- Comment #2 from Rafael Lima --- Created attachment 180263 --> https://bugs.documentfoundation.org/attachment.cgi?id=180263=edit Screenshot of the file opened in Excel at 200% zoom -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 --- Comment #1 from Rafael Lima --- Created attachment 180262 --> https://bugs.documentfoundation.org/attachment.cgi?id=180262=edit Sample XLSX file used in the screenshots -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149208] New: [XLSX] Excessive border weight in imported Excel files
https://bugs.documentfoundation.org/show_bug.cgi?id=149208 Bug ID: 149208 Summary: [XLSX] Excessive border weight in imported Excel files Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rafael.palma.l...@gmail.com Created attachment 180261 --> https://bugs.documentfoundation.org/attachment.cgi?id=180261=edit Border options available in Excel Excel offers 3 options for border thickness when it comes to solid borders (see first attachment showing these options). I'll call them "Thin", "Medium" and "Thick", since MS does not provide names for them in the user interface. The way LO Calc import these borders is causing a bit of inconsistency, because our import is making the borders look much thicker than they should. For example, if you apply these borders in Excel, save the XLSX document and open it in LO Calc they will appear with excessive border weight. Below I'll attach more files showing the problem, as well as a sample XLSX file. I believe the way we convert border thickness needs to be improved. Or maybe the way we draw these borders in the screen. This is because in Excel, if you zoom in/out the border thickness does not change, whereas in LO Calc zooming affects the thickness of the border drawn in the screen. System info: Version: 7.3.3.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
