date:20220825

[Libreoffice-bugs] [Bug 150616] FILESAVE PDF Table row disappears from complex table after CLI PDF export

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150616

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

  Regression By||Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147497] PostgreSQL direct connection: AutoValue wont be shown in table when created with "generated by default…"

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147497

--- Comment #3 from Robert Großkopf  ---
This buggy behavior also will appear when trying to get such an AutoValue by

stNID = oForm.getString(oForm.findColumn("ID"))

in a macro. So I have to switch macros to 

stNID = oForm.getString(oForm.findColumn("ID"))
IF stNID = 0 THEN
   oForm.reload()
   stNID = oForm.getString(oForm.findColumn("ID"))
END IF

This will work when form is sorted by 
"ID" DESC

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150616] FILESAVE PDF Table row disappears from complex table after CLI PDF export

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150616

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Created attachment 182037
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182037=edit
The example file in Writer and its CLI PDF export in Evince

Does not happen if it's exported via GUI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147358] FILESAVE PDF Table lines slipping together when exported from CLI

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147358

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0616

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150616] New: FILESAVE PDF Table row disappears from complex table after CLI PDF export

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150616

Bug ID: 150616
   Summary: FILESAVE PDF Table row disappears from complex table
after CLI PDF export
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, regression
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
CC: michael.st...@allotropia.de
Blocks: 103378

Created attachment 182036
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182036=edit
Example file

Attached document contains some complex nested tables.
When the document is exported to PDF from the command line, the table row
containing "Important information here!" disappears.

1, soffice --convert-to pdf in_056132_mod.odt
2, Open resulting in_056132_mod.pdf in PDF viewer

Happens in 
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 27892a5e12dada80226f778ab2bd14b1bdaab58a
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

and 7.4, but not in older.

Bibisected to:

https://git.libreoffice.org/core/+/e7874c936dd1ff9b3423eb7477cbee2494535176

author  Michael Stahl  Fri Feb 11 18:28:42
2022 +0100
committer   Michael Stahl  Mon Feb 14
11:35:59 2022 +0100

sw: layout: fix overlapped table rows in --convert-to pdf

which was for bug 147358.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||150616


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150616
[Bug 150616] FILESAVE PDF Table row disappears from complex table after CLI PDF
export
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148010] Large ODS open 100% slower compared to XLSX format

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148010

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #10 from Kevin Suo  ---
Should the slowness happen adapting row height? If that is the case, then it is
bug 128204.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: desktop/source sc/inc

2022-08-25 Thread Andrea Gelmini (via logerrit)

 desktop/source/lib/init.cxx |2 +-
 sc/inc/formulacell.hxx  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d9ed7e3e3301664d5f7bbe8cf6ba42bdfd78e3d0
Author: Andrea Gelmini 
AuthorDate: Fri Aug 26 01:23:50 2022 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 26 07:08:03 2022 +0200

Fix typos

Change-Id: I28943475fe35aadab44b8bd2a87f1ea84c49dff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138857
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index be7bcd9b0b0f..e907b253248f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2621,7 +2621,7 @@ static LibreOfficeKitDocument* 
lo_documentLoadWithOptions(LibreOfficeKit* pThis,
 // If the original font had an empty style and one of its 
replacement fonts has the same
 // family name, we assume the font is present. The root problem 
here is that the code
 // that collects font substitutions tends to get just empty styles 
for the font that is
-// being substituded, as vcl::Font::GetStyleName() tents to return 
an empty string.
+// being substituted, as vcl::Font::GetStyleName() tents to return 
an empty string.
 // (Italicness is instead indicated by what vcl::Font::GetItalic() 
returns and boldness
 // by what vcl::Font::GetWeight() returns.)
 if (aFontMappingUseData[i].mOriginalFont.indexOf('/') == -1)
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 789353efce9f..ddd12a04e6ac 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -262,7 +262,7 @@ public:
 void CalcAfterLoad( sc::CompileFormulaContext& rCxt, bool bStartListening 
);
 boolMarkUsedExternalReferences();
 // Returns true if the cell was interpreted as part of the formula group.
-// The parameters may limit which subset of the formula group should be 
interepreted, if possible.
+// The parameters may limit which subset of the formula group should be 
interpreted, if possible.
 bool Interpret(SCROW nStartOffset = -1, SCROW nEndOffset = -1);
 bool IsIterCell() const { return bIsIterCell; }
 sal_uInt16 GetSeenInIteration() const { return nSeenInIteration; }

[Libreoffice-bugs] [Bug 147655] LibreOffice Writer v7.3.0.3 loses some tracked changes when saving as .docx

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147655

--- Comment #5 from swleef...@hotmail.com ---
Oops, two (unimportant) typos in step 7: that should be "Show Tracked Changes",
not "View Tracked Changes". And the "(It doesn't matter" can be ignored.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147655] LibreOffice Writer v7.3.0.3 loses some tracked changes when saving as .docx

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147655

swleef...@hotmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from swleef...@hotmail.com ---
Here are steps to reproduce the issue, without requiring an existing document.
The problem only occurs for me when either "Deletions in Margin" or "Insertions
in Margin" is enabled.

Libre Office 7.4.0.3 (x64), Windows 10.

1. Open Writer.
2. Create a new document (File → New → Text Document).
3. Make sure "Record Track Changes" is disabled for now.
4. Type or paste any badly written text, e.g. "Hello, Misterrr Boo, how are".
5. Enable "Record Track Changes" and "Show Tracked Changes".
6. Correct the text by deleting something and inserting something, e.g. delete
the extra r's in "Misterrr", and insert " you?". at the end, resulting in a
correct sentence: "Hello, Mister Boo, how are you?". (Do not simply copy-paste
the correct sentence over the old sentence: we need to actually make a deletion
and an insertion.)
7. CRUCIAL STEP: In the little dropdown menu at View Track Changes, pick
"Deletions in Margin". (It doesn't matter 
8. Save the document as a .DOCX file.
9. Close the document.
10. Reopen the file.

You will now see somewhat unpredictable data loss. The deletion "rr" has
disappeared altogether. The part "Boo, how are" is marked as a deletion even
though it should be marked as unchanged text. The insertion "you?" is shown as
unchanged text even though it should be marked as an insertion.

If you then disable "Show Tracked Changes", you will see that it is not just a
display issue: the words incorrectly marked as a deletion have actually
disappeared.

The problem even occurs if you disable "Show Tracked Changes" after picking
"Detetions in Margin" and before saving the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-08-25 Thread Andrea Gelmini (via logerrit)

 vcl/source/window/menu.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit db4535c0b060974667f2607a234c79d7a2cbc632
Author: Andrea Gelmini 
AuthorDate: Fri Aug 26 01:22:29 2022 +0200
Commit: Andrea Gelmini 
CommitDate: Fri Aug 26 06:41:29 2022 +0200

Removed duplicated include

Change-Id: I6852fe11a142d13c71e111b3e4747cd1ca0850b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138856
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini 

diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 5a9bfaa237d1..bf02fab4c698 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -30,7 +30,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include

[Libreoffice-bugs] [Bug 150613] Format of chapter number changed by format of the last character on the line

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150613

--- Comment #4 from William Friedman  ---
I have attached both a video showing the bug in action and the document used to
test it. A few things to note:

1) As you can see from the video, underlining and superscripting don't affect
the formatting of the number, while bold/italics/strikethrough/font color do.

2) I didn't show this in the video, but it really is dependent on the
formatting of  the last character. If I add a space that is formatted just as
bold, then that's how the number appears. (That's my current workaround for
this issue when the last word in the heading needs to be in italics.)

Thank you for your attention!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150613] Format of chapter number changed by format of the last character on the line

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150613

--- Comment #3 from William Friedman  ---
Created attachment 182035
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182035=edit
Document used for testing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/inc vcl/unx

2022-08-25 Thread Caolán McNamara (via logerrit)

 vcl/inc/unx/cairotextrender.hxx |8 +
 vcl/unx/generic/gdi/cairotextrender.cxx |   50 +++-
 2 files changed, 51 insertions(+), 7 deletions(-)

New commits:
commit ed95bc0d2f0d8ee8f04ac84bcb4e41d780878501
Author: Caolán McNamara 
AuthorDate: Thu Aug 25 13:10:23 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Aug 26 06:26:58 2022 +0200

tdf#150507 reenable slight hinting for cairo with 
ResolutionIndependentLayout

it was disabled because of:
tdf#150145 text appears to have a row of pixels cropped out
which seems to be the same issue as
https://gitlab.freedesktop.org/cairo/cairo/-/issues/390

reenable, drop CAIRO_HINT_METRICS_OFF and emulate a proposed solution of
https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/235 by
hacking in a route to disable CAIRO_ROUND_GLYPH_POS_ON

Change-Id: I3c9f982c9737b84fe0ee6b645f507e1226807d60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138817
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/inc/unx/cairotextrender.hxx b/vcl/inc/unx/cairotextrender.hxx
index c046b00c9e49..e9a85739827b 100644
--- a/vcl/inc/unx/cairotextrender.hxx
+++ b/vcl/inc/unx/cairotextrender.hxx
@@ -25,9 +25,15 @@
 class GenericSalLayout;
 class SalGraphics;
 typedef struct _cairo cairo_t;
+typedef struct _cairo_font_options cairo_font_options_t;
 
 class VCL_DLLPUBLIC CairoTextRender : public FreeTypeTextRenderImpl
 {
+private:
+// https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/235
+// I don't want to have CAIRO_ROUND_GLYPH_POS_ON set in the cairo
+// surfaces font_options, but that's private, so tricky to achieve
+cairo_font_options_t*   mpRoundGlyphPosOffOptions;
 protected:
 virtual cairo_t*getCairoContext() = 0;
 virtual voidgetSurfaceOffset(double& nDX, double& nDY) = 0;
@@ -37,6 +43,8 @@ protected:
 
 public:
 virtual voidDrawTextLayout(const GenericSalLayout&, const 
SalGraphics&) override;
+CairoTextRender();
+virtual ~CairoTextRender();
 };
 
 #endif
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 1e2e75c01d79..24e5580e9bdb 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -29,6 +29,11 @@
 
 #include 
 #include 
+#if defined(CAIRO_HAS_SVG_SURFACE)
+#include 
+#elif defined(CAIRO_HAS_PDF_SURFACE)
+#include 
+#endif
 
 #include 
 
@@ -125,6 +130,36 @@ extern "C"
 }
 #endif
 
+CairoTextRender::CairoTextRender()
+{
+// https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/235
+// I don't want to have CAIRO_ROUND_GLYPH_POS_ON set in the cairo surfaces
+// font_options when trying subpixel rendering, but that's a private
+// feature of cairo_font_options_t, so tricky to achieve. Hack this by
+// getting the font options of a backend known to set this private feature
+// to CAIRO_ROUND_GLYPH_POS_OFF and then set to defaults the public
+// features and the result can be merged with new font options to set
+// CAIRO_ROUND_GLYPH_POS_OFF in those
+mpRoundGlyphPosOffOptions = cairo_font_options_create();
+#if defined(CAIRO_HAS_SVG_SURFACE)
+// svg, pdf and ps backends have CAIRO_ROUND_GLYPH_POS_OFF by default
+cairo_surface_t* hack = cairo_svg_surface_create(nullptr, 1, 1);
+#elif defined(CAIRO_HAS_PDF_SURFACE)
+cairo_surface_t* hack = cairo_pdf_surface_create(nullptr, 1, 1);
+#endif
+cairo_surface_get_font_options(hack, mpRoundGlyphPosOffOptions);
+cairo_surface_destroy(hack);
+cairo_font_options_set_antialias(mpRoundGlyphPosOffOptions, 
CAIRO_ANTIALIAS_DEFAULT);
+cairo_font_options_set_subpixel_order(mpRoundGlyphPosOffOptions, 
CAIRO_SUBPIXEL_ORDER_DEFAULT);
+cairo_font_options_set_hint_style(mpRoundGlyphPosOffOptions, 
CAIRO_HINT_STYLE_DEFAULT);
+cairo_font_options_set_hint_metrics(mpRoundGlyphPosOffOptions, 
CAIRO_HINT_METRICS_DEFAULT);
+}
+
+CairoTextRender::~CairoTextRender()
+{
+cairo_font_options_destroy(mpRoundGlyphPosOffOptions);
+}
+
 void CairoTextRender::DrawTextLayout(const GenericSalLayout& rLayout, const 
SalGraphics& rGraphics)
 {
 const FreetypeFontInstance& rInstance = 
static_cast(rLayout.GetFont());
@@ -199,21 +234,22 @@ void CairoTextRender::DrawTextLayout(const 
GenericSalLayout& rLayout, const SalG
 if (pFontOptions || bDisableAA || bResolutionIndependentLayoutEnabled)
 {
 cairo_hint_style_t eHintStyle = pFontOptions ? 
cairo_font_options_get_hint_style(pFontOptions) : CAIRO_HINT_STYLE_DEFAULT;
-cairo_hint_metrics_t eHintMetricsStyle = pFontOptions ? 
cairo_font_options_get_hint_metrics(pFontOptions) : CAIRO_HINT_METRICS_DEFAULT;
-bool bAllowedHintStyle = !bResolutionIndependentLayoutEnabled || 
(eHintStyle == CAIRO_HINT_STYLE_NONE);
-bool bAllowedHintMetricStyle =

[Libreoffice-bugs] [Bug 150613] Format of chapter number changed by format of the last character on the line

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150613

--- Comment #2 from William Friedman  ---
Created attachment 182034
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182034=edit
Video showing the bug

In this video, you can see the bug at work. (Please forgive the occasional
flickering.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150026] 64-bit ChromeOS Cannot Start LibreOffice 7.3.4 or 7.4.0.3

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150026

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150591] Calc Segmentation Fault Segfault Crash Coredump Upon Close After Changes

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150591

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109530] [META] File opening issues

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109530
Bug 109530 depends on bug 139491, which changed state.

Bug 139491 Summary: FILEOPEN: Systematic very slow file loading on Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=139491

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150591] Calc Segmentation Fault Segfault Crash Coredump Upon Close After Changes

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150591

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 139491, which changed state.

Bug 139491 Summary: FILEOPEN: Systematic very slow file loading on Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=139491

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139491] FILEOPEN: Systematic very slow file loading on Calc

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139491

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139491] FILEOPEN: Systematic very slow file loading on Calc

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139491

--- Comment #18 from QA Administrators  ---
Dear mage99,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147655] LibreOffice Writer v7.3.0.3 loses some tracked changes when saving as .docx

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=147655

--- Comment #3 from QA Administrators  ---
Dear sadrx,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132625] Move mediawiki template and code into external extension

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=132625

--- Comment #5 from QA Administrators  ---
Dear andreas_k,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125259] FILEOPEN:XLS: Image overlaps border

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125259

--- Comment #14 from QA Administrators  ---
Dear AnJingjing,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124496] Adding diagonal borders to cells while EDITING calc file messes the file

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=124496

--- Comment #17 from QA Administrators  ---
Dear Michael@Paris,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 30731] Cursor jumps around when moving through some ligatures

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=30731

خالد حسني  changed:

   What|Removed |Added

Summary|Cursor behaviour with   |Cursor jumps around when
   |Graphite fonts  |moving through some
   ||ligatures

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 30731] Cursor behaviour with Graphite fonts

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=30731

خالد حسني  changed:

   What|Removed |Added

   Priority|lowest  |medium

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 30731] Cursor behaviour with Graphite fonts

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=30731

خالد حسني  changed:

   What|Removed |Added

 CC||kha...@aliftype.com

--- Comment #23 from خالد حسني  ---
Created attachment 182033
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182033=edit
Screencast comparing the cursor movement of ligated with unligated text

I believe the problem is that LibreOffice (or writer) is measuring the text
width in chunks to determine the cursor position, e.g. in the string “office”
for the cursor at “o|ffice” it will measure the width of “o” to position the
cursor, and in “of|fice” it will measure the width of “of” and so on. For
ligatures where the width of the partial text is close enough to the with of
the ligature component, things appear to work, but in the problematic cases
here the difference is way off that the cursor appears to be jumping.

See the cursor movement in the attached screencast and compare the cursor
position when it jumps with the unligated text below it, the cursor jumps to
exactly where the unligated glyph is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150615] New: Window position/size not respected when opening from a file

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150615

Bug ID: 150615
   Summary: Window position/size not respected when opening from a
file
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jim.by...@rcn.com

Using version 7.4.2.0.0, obtained from the current nightly build...

If I open Writer or Calc and set the window position and size, close the
program, and reopen them, the window position and size are retained. (This was
fixed in 7.4.1.0.0.)

However, for example, if I then select a .odt file and open the program from
the document file (double-click on the .odt file, right-click on the .odt file
and select Open, right-click on the .odt file and select Open with /
LibreOffice, when the document is opened, the position and window size that I
set previously is not respected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150566] LibreOffice 7.3.5.2 hangs

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150566

--- Comment #12 from Bob Sander-Cederlof  ---
I was running from an external disk. However, after moving LibreOffice to my
internal disk, I am seeing identical behavior.
If no other apps are running, LibreOffice is happy. However my normal condition
is to have 3 or 4 other apps running, such as Mail, Chrome, and BBEdit. Just
now it froze trying to open the Start Center page.

No matter where I run it from, the hang report says that the path is 
Path:/Volumes/VOLUME/*/LibreOffice.app/Contents/MacOS/soffice

Right now the real path is
/Applications/LibreOffice.app/Contents/MacOS/soffice

The path /Volumes/VOLUME/*/LibreOffice.app/Contents/MacOS/soffice does not
exist, so I have no idea why the hang report gives that path.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150614] always Crashing

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150614

Tim  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from Tim  ---
(In reply to stragu from comment #2)
> I could not crash Writer when opening your document with:
> 
> Version: 7.3.5.2 / LibreOffice Community
> Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
> CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> or
> 
> Version: 7.4.0.0.alpha1+ / LibreOffice Community
> Build ID: 3676fb9d7b505d9f8079008b41e423b54663a86a
> CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> ...although I have only played with the document for a few minutes.
> 
> As you used the version 7.4.0.3 for first version affected, could you please
> clarify if you have actually tested it in that version?
> 
> Could you also please try resetting your user profile and see if it still
> crashes? ->
> https://wiki.documentfoundation.org/UserProfile#Help_wizard_.28LibreOffice_5.
> 3_and_newer.29
> 
> Regarding the second issue about the printer, I would recommend asking on
> ask.libreoffice.org unless it is an actual bug (in which case it would be
> great if you could open a separate bug report).

I am way over my head on this. Crashed in safe mode. after 30 min. I only used
Version: 7.3.5.2. How do I get the other version? I will be more than happy to
try. 

As to the printer i followed the link I was confused at what i was looking at.
I'm not a computer person at all, its all foreign to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

V Stuart Foote  changed:

   What|Removed |Added

 Attachment #182032|WinDbg stacktrace of buffer |WinDbg stacktrace of LO
description|overflow when launching |7.4.1 buffer overflow when
   |into Impress presentation   |launching into Impress
   |with Skia Vulkan enabled on |presentation with Skia
   |nVidia K2000 GPU|Vulkan enabled on nVidia
   ||K2000 GPU

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

--- Comment #17 from V Stuart Foote  ---
Created attachment 182032
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182032=edit
WinDbg stacktrace of buffer overflow when launching into Impress presentation
with Skia Vulkan enabled on nVidia K2000 GPU

nVidia 473.47 driver

RenderMethod: vulkan
Vendor: 0x10de
Device: 0xffe
API: 1.2.175
Driver: 473.188.0
DeviceType: discrete
DeviceName: Quadro K2000
Denylisted: no

On this system, the triangles are filled in presentation mode without dropouts.
But the edges ofeach triangle are noticibly sawtoothed.  While those on the
edit canvas are smooth.

But this GPU driver will also abort via watchdoog process 60% of launches into
presentation with Vulkan enabled.

updating to nVidia driver 473.81 results in this Vulkan skia.log:

RenderMethod: vulkan
Vendor: 0x10de
Device: 0xffe
API: 1.2.175
Driver: 473.324.0
DeviceType: discrete
DeviceName: Quadro K2000
Denylisted: no

but no improvement. The SVG objects edges remain saw-toothed.

@Luboš,* -- I was able to catch a substantive WinDbg stacktrace with symbols
(attached) --but not sure it is of any real help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139895] [META] PPTX Character formatting issues

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139895

stragu  changed:

   What|Removed |Added

 Depends on||150610


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150610
[Bug 150610] FILEOPEN PPTX: text shows grey instead of black (low contrast)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150610] FILEOPEN PPTX: text shows grey instead of black (low contrast)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150610

stragu  changed:

   What|Removed |Added

Version|7.5.0.0 alpha0+ Master  |7.1.0.0.alpha0+
 CC||stephane.guil...@member.fsf
   ||.org
 Blocks||139895
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from stragu  ---
I can confirm that it looks bad in:

Version: 7.2.7.2 / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and

Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

but looks good in:

Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

It looks the same as in the MSO screenshot and LO 6.4 when opened in
OnlyOffice.

Colour of text is #0C322C in version 6.4 but it is #3E3E3E in buggy versions.

Putting 7.1 alpha version as first affected because we don't have 7.0.7 in the
list.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139895
[Bug 139895] [META] PPTX Character formatting issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/source

2022-08-25 Thread Khaled Hosny (via logerrit)

 vcl/inc/font/OpenTypeFeatureDefinitionList.hxx |2 -
 vcl/source/font/FeatureCollector.cxx   |   45 -
 2 files changed, 23 insertions(+), 24 deletions(-)

New commits:
commit 8f058de233e5110720daa5b42e0c66e7c3b2c31f
Author: Khaled Hosny 
AuthorDate: Thu Aug 25 23:42:40 2022 +0200
Commit: خالد حسني 
CommitDate: Fri Aug 26 01:00:32 2022 +0200

FeatureCollector: Drop redundant check

HarfBuzz handles this for us, and it more future-proof this way.

Change-Id: Ia8a65f0363a05c74a718a1a9f7d6df6c84373f46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138853
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/inc/font/OpenTypeFeatureDefinitionList.hxx 
b/vcl/inc/font/OpenTypeFeatureDefinitionList.hxx
index aaa89ebe5d48..52dbcfb5b9f0 100644
--- a/vcl/inc/font/OpenTypeFeatureDefinitionList.hxx
+++ b/vcl/inc/font/OpenTypeFeatureDefinitionList.hxx
@@ -25,12 +25,12 @@ private:
 
 void init();
 
+static bool isSpecialFeatureCode(sal_uInt32 nFeatureCode);
 static FeatureDefinition handleSpecialFeatureCode(sal_uInt32 nFeatureCode);
 
 public:
 OpenTypeFeatureDefinitionListPrivate();
 FeatureDefinition getDefinition(sal_uInt32 nFeatureCode);
-static bool isSpecialFeatureCode(sal_uInt32 nFeatureCode);
 bool isRequired(sal_uInt32 nFeatureCode);
 };
 
diff --git a/vcl/source/font/FeatureCollector.cxx 
b/vcl/source/font/FeatureCollector.cxx
index 653712c27e93..4f517bf6784a 100644
--- a/vcl/source/font/FeatureCollector.cxx
+++ b/vcl/source/font/FeatureCollector.cxx
@@ -135,31 +135,30 @@ void FeatureCollector::collectForTable(hb_tag_t aTableTag)

HB_OT_LAYOUT_DEFAULT_LANGUAGE_INDEX, aFeatureTag,
))
 {
-if 
(OpenTypeFeatureDefinitionListPrivate::isSpecialFeatureCode(aFeatureTag))
+// ssXX and cvXX can have name ID defined for them, check for
+// them and use as appropriate.
+hb_ot_name_id_t aLabelID;
+hb_ot_name_id_t aFirstParameterID;
+unsigned nNamedParameters;
+if (hb_ot_layout_feature_get_name_ids(m_pHbFace, aTableTag, 
nFeatureIdx, ,
+  nullptr, nullptr, 
,
+  ))
 {
-// ssXX and cvXX can have name ID defined for them, check for
-// them and use as appropriate.
-hb_ot_name_id_t aLabelID;
-hb_ot_name_id_t aFirstParameterID;
-unsigned nNamedParameters;
-if (hb_ot_layout_feature_get_name_ids(m_pHbFace, aTableTag, 
nFeatureIdx, ,
-  nullptr, nullptr, 
,
-  ))
+OString sLanguage = m_rLanguageTag.getBcp47().toUtf8();
+OUString sLabel = getName(m_pHbFace, aLabelID, sLanguage);
+if (!sLabel.isEmpty())
+aDefinition = vcl::font::FeatureDefinition(aFeatureTag, 
sLabel);
+
+// cvXX features can have parameters name IDs, check for
+// them and populate feature parameters as appropriate.
+for (unsigned i = 0; i < nNamedParameters; i++)
 {
-OString sLanguage = m_rLanguageTag.getBcp47().toUtf8();
-OUString sLabel = getName(m_pHbFace, aLabelID, sLanguage);
-if (!sLabel.isEmpty())
-aDefinition = 
vcl::font::FeatureDefinition(aFeatureTag, sLabel);
-
-// cvXX features can have parameters name IDs, check for
-// them and populate feature parameters as appropriate.
-for (unsigned i = 0; i < nNamedParameters; i++)
-{
-hb_ot_name_id_t aNameID = aFirstParameterID + i;
-OUString sName = getName(m_pHbFace, aNameID, 
sLanguage);
-if (!sName.isEmpty())
-aParameters.emplace_back(uint32_t(i + 1), sName);
-}
+hb_ot_name_id_t aNameID = aFirstParameterID + i;
+OUString sName = getName(m_pHbFace, aNameID, sLanguage);
+if (!sName.isEmpty())
+aParameters.emplace_back(uint32_t(i + 1), sName);
+else
+aParameters.emplace_back(uint32_t(i + 1), 
OUString::number(i + 1));
 }
 }

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=133092

stragu  changed:

   What|Removed |Added

 Depends on||150611


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150611
[Bug 150611] Fatal exception Signal 6 on startup after Ubuntu jammy upgrade
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150611] Fatal exception Signal 6 on startup after Ubuntu jammy upgrade

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150611

stragu  changed:

   What|Removed |Added

 CC||stephane.guil...@member.fsf
   ||.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 Blocks||133092

--- Comment #6 from stragu  ---
in addition to what Timur and Julien have said, please share with use the
version information for the LibreOffice version(s) you have installed, and how
you installed it.

As you can't open the GUI, maybe this can help:

apt list --installed | grep libreoffice[0-9]

And to see what's available in the repos:

apt-cache policy libreoffice


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-08-25 Thread Caolán McNamara (via logerrit)

 vcl/source/gdi/pdfwriter_impl.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 6895bd63359f9d3ff7de0eea985c8171aef245f9
Author: Caolán McNamara 
AuthorDate: Thu Aug 25 20:50:42 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 26 00:37:42 2022 +0200

aStartPt is derived from a DevicePoint, so keep it as a DevicePoint

Change-Id: I85f4275593fe491bf5ba06d334312881367ceacf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138851
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 617871036117..d862da0f253a 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6442,7 +6442,7 @@ void PDFWriterImpl::drawLayout( SalLayout& rLayout, const 
OUString& rText, bool
 bool bUnderlineAbove = m_aCurrentPDFState.m_aFont.IsUnderlineAbove();
 if( m_aCurrentPDFState.m_aFont.IsWordLineMode() )
 {
-Point aStartPt;
+DevicePoint aStartPt;
 DeviceCoordinate nWidth = 0;
 nIndex = 0;
 while (rLayout.GetNextGlyph(, aPos, nIndex))
@@ -6450,13 +6450,13 @@ void PDFWriterImpl::drawLayout( SalLayout& rLayout, 
const OUString& rText, bool
 if (!pGlyph->IsSpacing())
 {
 if( !nWidth )
-aStartPt = Point(aPos.getX(), aPos.getY());
+aStartPt = aPos;
 
 nWidth += pGlyph->newWidth();
 }
 else if( nWidth > 0 )
 {
-drawTextLine( PixelToLogic( aStartPt ),
+drawTextLine( SubPixelToLogic(aStartPt, true),
   ImplDevicePixelToLogicWidth( nWidth ),
   eStrikeout, eUnderline, eOverline, 
bUnderlineAbove );
 nWidth = 0;
@@ -6465,7 +6465,7 @@ void PDFWriterImpl::drawLayout( SalLayout& rLayout, const 
OUString& rText, bool
 
 if( nWidth > 0 )
 {
-drawTextLine( PixelToLogic( aStartPt ),
+drawTextLine( SubPixelToLogic(aStartPt, true),
   ImplDevicePixelToLogicWidth( nWidth ),
   eStrikeout, eUnderline, eOverline, 
bUnderlineAbove );
 }

[Libreoffice-commits] core.git: vcl/source

2022-08-25 Thread Caolán McNamara (via logerrit)

 vcl/source/gdi/pdfwriter_impl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d147ef14ac3d3250bd9039a47a9b819e7e23315a
Author: Caolán McNamara 
AuthorDate: Thu Aug 25 20:47:10 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 26 00:37:21 2022 +0200

nWidth is set from newWidth which is DeviceCoordinate

Change-Id: I9d28fa57847b71383baa4b48d51a176017c0132f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138849
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index b1c4e0d6272b..617871036117 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6443,7 +6443,7 @@ void PDFWriterImpl::drawLayout( SalLayout& rLayout, const 
OUString& rText, bool
 if( m_aCurrentPDFState.m_aFont.IsWordLineMode() )
 {
 Point aStartPt;
-sal_Int32 nWidth = 0;
+DeviceCoordinate nWidth = 0;
 nIndex = 0;
 while (rLayout.GetNextGlyph(, aPos, nIndex))
 {

[Libreoffice-commits] core.git: drawinglayer/source include/vcl starmath/source sw/source vcl/inc vcl/qa vcl/qt5 vcl/quartz vcl/skia vcl/source vcl/unx vcl/win

2022-08-25 Thread Caolán McNamara (via logerrit)

 drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |9 
 include/vcl/outdev.hxx  |7 ---
 include/vcl/vcllayout.hxx   |5 ++
 starmath/source/ElementsDockingWindow.cxx   |1 
 sw/source/core/txtnode/fntcache.cxx |6 ---
 vcl/inc/salgdi.hxx  |   11 -
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |   20 +-
 vcl/qt5/QtGraphics_Text.cxx |3 +
 vcl/quartz/salgdi.cxx   |2 -
 vcl/skia/win/gdiimpl.cxx|2 -
 vcl/skia/x11/textrender.cxx |2 -
 vcl/source/filter/svm/SvmConverter.cxx  |1 
 vcl/source/gdi/pdfwriter_impl.cxx   |   10 ++---
 vcl/source/gdi/salgdilayout.cxx |3 -
 vcl/source/gdi/virdev.cxx   |2 -
 vcl/source/outdev/map.cxx   |   20 +++---
 vcl/source/outdev/outdev.cxx|   15 ---
 vcl/source/outdev/text.cxx  |   31 +---
 vcl/unx/generic/gdi/cairotextrender.cxx |2 -
 vcl/win/gdi/winlayout.cxx   |2 -
 20 files changed, 54 insertions(+), 100 deletions(-)

New commits:
commit 100fe8a3a1724f1a5f834da11e17d1641be20994
Author: Caolán McNamara 
AuthorDate: Mon Aug 15 17:24:28 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 26 00:36:58 2022 +0200

automatically set TextRenderModeForResolutionIndependentLayout if we scale

Always render glyphs with a mode suitable for rendering of
resolution-independent layout positions if we scale the text positions.

The idea being to typically continue to use the system defaults for font
settings for UI elements, but where we are rendering into application
canvases where there's a mapmode set then automatically use a good mode
to render that.

Change-Id: I0e5857e377da72ae1a2ede1d88d6408819fc9200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138324
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index fe2f30cbf23a..5e0612f94a93 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -75,12 +75,9 @@ namespace drawinglayer::processor2d
 struct VclPixelProcessor2D::Impl
 {
 AntialiasingFlags m_nOrigAntiAliasing;
-bool m_bOrigTextRenderModeForResolutionIndependentLayout;
 
 explicit Impl(OutputDevice const& rOutDev)
 : m_nOrigAntiAliasing(rOutDev.GetAntialiasing())
-, m_bOrigTextRenderModeForResolutionIndependentLayout(
-  rOutDev.GetTextRenderModeForResolutionIndependentLayout())
 {
 }
 };
@@ -107,9 +104,6 @@ VclPixelProcessor2D::VclPixelProcessor2D(const 
geometry::ViewInformation2D& rVie
 {
 mpOutputDevice->SetAntialiasing(m_pImpl->m_nOrigAntiAliasing & 
~AntialiasingFlags::Enable);
 }
-
-// tdf#150462 set text render mode to suit use of resolution independent 
text layout
-mpOutputDevice->SetTextRenderModeForResolutionIndependentLayout(true);
 }
 
 VclPixelProcessor2D::~VclPixelProcessor2D()
@@ -119,9 +113,6 @@ VclPixelProcessor2D::~VclPixelProcessor2D()
 
 // restore AntiAliasing
 mpOutputDevice->SetAntialiasing(m_pImpl->m_nOrigAntiAliasing);
-
-mpOutputDevice->SetTextRenderModeForResolutionIndependentLayout(
-m_pImpl->m_bOrigTextRenderModeForResolutionIndependentLayout);
 }
 
 void VclPixelProcessor2D::tryDrawPolyPolygonColorPrimitive2DDirect(
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 5a13c640a296..27e7650e8f72 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -236,7 +236,6 @@ private:
 Point   maRefPoint;
 AntialiasingFlags   mnAntialiasing;
 LanguageTypemeTextLanguage;
-bool mbTextRenderModeForResolutionIndependentLayout;
 
 mutable boolmbMap : 1;
 mutable boolmbClipRegion : 1;
@@ -484,10 +483,6 @@ public:
 voidSetAntialiasing( AntialiasingFlags nMode );
 AntialiasingFlags   GetAntialiasing() const { return 
mnAntialiasing; }
 
-// Render glyphs with a mode suitable for rendering of 
resolution-independent layout positions.
-void
SetTextRenderModeForResolutionIndependentLayout(bool bMode);
-bool
GetTextRenderModeForResolutionIndependentLayout() const { return 
mbTextRenderModeForResolutionIndependentLayout; }
-
 voidSetDrawMode( DrawModeFlags nDrawMode );

[Libreoffice-bugs] [Bug 150566] LibreOffice 7.3.5.2 hangs

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150566

--- Comment #11 from Alex Thurgood  ---
Thanks ! 

@Bob, where are you running the LibreOffice.app from? 

The /VOLUMES/Volumes/*/ seems like an unusual location for app bundle
installation. 

The crash report seems to indicate a scheduling issue with mutex locks, maybe a
race condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Touchpad gesture support (e.g. for zooming via touchpad pinch gestures)

2022-08-25 Thread Povilas Kanapickas

Hi Tomaž,

On 2022-08-25 20:23, Tomaž Vajngerl wrote:
> Hi,
> 
> On Thu, Aug 25, 2022 at 12:16 PM Povilas Kanapickas  > wrote:
> 
> Hello,
> 
> I would like to implement support for touchpad gesture handling to
> LibreOffice. This is useful e.g. for zooming views using two-finger
> pinch touchpad gesture or rotating objects using two-finger rotate
> gesture.
> 
> I have implemented this functionality in GIMP and would like to do the
> same for LibreOffice. In LibreOffice case the implementation will be
> more complex, as there are more backends than just GTK, but this will
> just require more work.
> 
> There is a proof of concept implementation that wires touchpad gestures
> on GTK to the ViewShell widget. As a result it's possible to use
> touchpad pinch gesture to zoom in-out the main slide in Impress.
> 
> https://gerrit.libreoffice.org/c/core/+/138791/1
>  (note that
> implementation is split across 5 changes in the chain).
> 
> Please let me know what do you think about this problem and the proof of
> concept solution.
> 
> 
> Looks great.
> 
> The reason why GestureEvent is called so generally is that there should
> only be one common gesture event for all types of gestures - even if
> that would also mean it would have all the member variables of all the
> gestures - for simplicity. But I guess that approach is also ok...

Thanks a lot for very fast reply.

I can do either approach as you please. The reason why I created
separate event types for each gesture type was the experience when
implementing touchpad gestures for the X server. Putting all data into a
single struct becomes hard to manage in the end, because it's not
obvious what data each logical event carries and as consequence code
becomes error prone and harder to refactor.

Please let me know if I should just put everything into the Gesture
class though. You know better which approach will be easier to maintain
in the specific case of LibreOffice project.

Thanks a lot,
Povilas

[Libreoffice-bugs] [Bug 150613] Format of chapter number changed by format of the last character on the line

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150613

stragu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guil...@member.fsf
   ||.org

--- Comment #1 from stragu  ---
Hi William

I couldn't reproduce with:

Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

To see the heading numbers, have you turned numbering on previously with "Tools
> Chapter Numbering... > Numbering tab > 1-10 > Number"?

Could you please write steps to start from a brand new document, or provide an
existing document to start from?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150614] always Crashing

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150614

stragu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from stragu  ---
I could not crash Writer when opening your document with:

Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

or

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 3676fb9d7b505d9f8079008b41e423b54663a86a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

...although I have only played with the document for a few minutes.

As you used the version 7.4.0.3 for first version affected, could you please
clarify if you have actually tested it in that version?

Could you also please try resetting your user profile and see if it still
crashes? ->
https://wiki.documentfoundation.org/UserProfile#Help_wizard_.28LibreOffice_5.3_and_newer.29

Regarding the second issue about the printer, I would recommend asking on
ask.libreoffice.org unless it is an actual bug (in which case it would be great
if you could open a separate bug report).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150592] Comments should be shown over all form controls (eg push button)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150592

Óvári  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 ) ( LibreOffice 7.4 only )

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150236

Xisco Faulí  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #52 from Xisco Faulí  ---
Closing this one

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150592] Comments should be shown over all form controls (eg push button)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150592

--- Comment #4 from Óvári  ---
Created attachment 182031
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182031=edit
Mouse pointer over Push Button

(In reply to m.a.riosv from comment #3)
> And if the comment it's showed above, can hide the button. How do you see it
> then?
Thank you for your comment.

Opening the attached spreadsheet in this issue and moving the mouse over the
push button hides the comment.

The comment only shows when you hover above cell A1. If the mouse pointer is
not above cell A1 the comment does not show. When the mouse pointer moves over
the button is it not above the A1 cell so the comment from cell A1 is not
showing and the button can be pressed.

Fixing this bug will make the UX consistent with other spreadsheet software.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150236] Does not open full screen, ooSetupFactoryWindowAttributes not being filled ( steps in comment 21 ) ( LibreOffice 7.4 only )

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150236

--- Comment #51 from Xisco Faulí  ---
(In reply to Jim Byram from comment #50)
> Using version 7.4.1.0.0, obtained from nightly builds...
> 
> If I open Writer or Calc and set the window position and size, close the
> program, and reopen them, the window position and size are retained. So the
> issue is fixed.
> 
> However, for example, if I then select a .odt file, right-click and select
> Open with / LibreOffice, when the document is opened, the position and
> window size that I set previously is not respected.
> 
> So the issue persists in a different context.

Hi Jim, all,
Thansk for testing this issue.
Could you please create a follow-up report for the second issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150568] FILESAVE DOCX: Additional page created

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150568

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #3 from raal  ---
No repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 27892a5e12dada80226f778ab2bd14b1bdaab58a
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/inc sc/source

2022-08-25 Thread Luboš Luňák (via logerrit)

 sc/inc/column.hxx  |2 -
 sc/inc/document.hxx|4 ++-
 sc/inc/formulacell.hxx |2 +
 sc/inc/rangecache.hxx  |2 -
 sc/inc/table.hxx   |2 -
 sc/source/core/data/column3.cxx|   44 +
 sc/source/core/data/documen2.cxx   |   11 ++---
 sc/source/core/data/document.cxx   |   13 +++---
 sc/source/core/data/table1.cxx |7 -
 sc/source/core/tool/rangecache.cxx |6 -
 10 files changed, 65 insertions(+), 28 deletions(-)

New commits:
commit d8eba60009afce4d9cca1488b4ce70e221642865
Author: Luboš Luňák 
AuthorDate: Tue Aug 23 19:47:50 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Aug 25 23:06:17 2022 +0200

try harder to ensure InterpretCellsIfNeeded() interprets (tdf#150499)

ScFormulaCell::Interpret() tries to interpret the whole formula group
(or the given range of it), but it's not guaranteed, and possibly
just the called cell will be interpreted. So if a specific range
really needs to be interpreted, handle that case.

Change-Id: I7fb563ae471eefd49e5bb6c92b6aff98c42a440e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138741
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 
(cherry picked from commit e1f02b8d00272be9cbf17cb8c351445a08a4c5f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138814
Reviewed-by: Xisco Fauli 

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index e4b7eb148d9a..aa5a5c689c01 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -721,7 +721,7 @@ public:
 bool IsDrawObjectsEmptyBlock(SCROW nStartRow, SCROW nEndRow) const;
 
 void InterpretDirtyCells( SCROW nRow1, SCROW nRow2 );
-void InterpretCellsIfNeeded( SCROW nRow1, SCROW nRow2 );
+bool InterpretCellsIfNeeded( SCROW nRow1, SCROW nRow2 );
 
 static void JoinNewFormulaCell( const sc::CellStoreType::position_type& 
aPos, ScFormulaCell& rCell );
 
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index 959960e15e03..b4552e792000 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1363,7 +1363,9 @@ public:
 void  SetTableOpDirty( const ScRange& );  // for Interpreter 
TableOp
 void  InterpretDirtyCells( const ScRangeList& rRanges );
 // Interprets cells that have NeedsInterpret(), i.e. the same like calling 
MaybeInterpret() on them.
-void  InterpretCellsIfNeeded( const ScRangeList& rRanges );
+// Returns false if some couldn't be interpreted (i.e. they still have 
NeedsInterpret()).
+// Useful to ensure that the given cells will not need interpreting.
+bool  InterpretCellsIfNeeded( const ScRangeList& rRanges );
 SC_DLLPUBLIC void CalcAll();
 SC_DLLPUBLIC void CalcAfterLoad( bool bStartListening = true );
 void  CompileAll();
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 013a0058ba5d..789353efce9f 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -261,6 +261,8 @@ public:
 void CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rProgress ); 
   // compile temporary string tokens
 void CalcAfterLoad( sc::CompileFormulaContext& rCxt, bool bStartListening 
);
 boolMarkUsedExternalReferences();
+// Returns true if the cell was interpreted as part of the formula group.
+// The parameters may limit which subset of the formula group should be 
interepreted, if possible.
 bool Interpret(SCROW nStartOffset = -1, SCROW nEndOffset = -1);
 bool IsIterCell() const { return bIsIterCell; }
 sal_uInt16 GetSeenInIteration() const { return nSeenInIteration; }
diff --git a/sc/inc/rangecache.hxx b/sc/inc/rangecache.hxx
index 7490a570f20a..c65e8653a458 100644
--- a/sc/inc/rangecache.hxx
+++ b/sc/inc/rangecache.hxx
@@ -46,7 +46,7 @@ class ScSortedRangeCache final : public SvtListener
 public:
 /// MUST be new'd because Notify() deletes.
 ScSortedRangeCache(ScDocument* pDoc, const ScRange& rRange, const 
ScQueryParam& param,
-   ScInterpreterContext* context);
+   ScInterpreterContext* context, bool invalid = false);
 
 /// Returns if the cache is usable.
 bool isValid() const { return mValid; }
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 0a3bc6c67956..35388b54ea1f 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -1057,7 +1057,7 @@ public:
 void FillMatrix( ScMatrix& rMat, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2, svl::SharedStringPool* pPool ) const;
 
 void InterpretDirtyCells( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW 
nRow2 );
-void InterpretCellsIfNeeded( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW 
nRow2 );
+bool InterpretCellsIfNeeded( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW 
nRow2 );
 
 void SetFormulaResults( SCCOL nCol, SCROW nRow, const double* pResults, 
size_t nLen );
 
diff --git

[Libreoffice-bugs] [Bug 150499] CRASH: deleting sheet

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150499

--- Comment #4 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/d8eba60009afce4d9cca1488b4ce70e221642865

try harder to ensure InterpretCellsIfNeeded() interprets (tdf#150499)

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150499] CRASH: deleting sheet

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150499

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0 target:7.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150597] Sheet names under Sidebar Navigator are not updated correctly after Copy/Move Sheet

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150597

raal  changed:

   What|Removed |Added

Version|7.4.0.3 release |4.2.0.4 release
 CC||r...@post.cz
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Confirm with Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 27892a5e12dada80226f778ab2bd14b1bdaab58a
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

2022-08-25 Thread Eike Rathke (via logerrit)

 sc/source/filter/dif/difimp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5b6b1f230529070259d81193a78d38b00fb8aec3
Author: Eike Rathke 
AuthorDate: Thu Aug 25 12:53:51 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Aug 25 23:03:20 2022 +0200

Resolves: tdf#150599 Move obtaining data into loop again

Regression from

commit a23a7eea5cfcdc50d09be248828cb1e6293e5ebb
CommitDate: Sun Dec 26 20:36:26 2021 +0100

Avoid OUStringBuffer::toString where possible

that erroneously also moved obtaining the data string outside the
loop, whyever..

Change-Id: I329108d42db43c1ab22ba82650d801e595dd7ece
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138805
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit b5629341edecf10c18087811c77708b01dd15a15)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138815
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/filter/dif/difimp.cxx b/sc/source/filter/dif/difimp.cxx
index f6e1fd0b0a36..fd88cdf4cfd4 100644
--- a/sc/source/filter/dif/difimp.cxx
+++ b/sc/source/filter/dif/difimp.cxx
@@ -122,7 +122,6 @@ ErrCode ScFormatFilterPluginImpl::ScImportDif(SvStream& 
rIn, ScDocument* pDoc, c
 
 ScSetStringParam aStrParam; // used to set string value without number 
detection.
 aStrParam.setTextInput();
-const OUString aData = rData.makeStringAndClear();
 
 while( eCurrent != D_EOD )
 {
@@ -130,6 +129,7 @@ ErrCode ScFormatFilterPluginImpl::ScImportDif(SvStream& 
rIn, ScDocument* pDoc, c
 
 aPrgrsBar.Progress();
 ScAddress aPos(nColCnt, nRowCnt, nBaseTab);
+const OUString aData = rData.makeStringAndClear();
 
 switch( eCurrent )
 {

[Libreoffice-commits] core.git: sw/source

2022-08-25 Thread Andreas Heinisch (via logerrit)

 sw/source/core/doc/doctxm.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 33c6dcfaab35a70f8794a67d31fbec636cb485d5
Author: Andreas Heinisch 
AuthorDate: Thu Aug 25 21:53:06 2022 +0200
Commit: Andreas Heinisch 
CommitDate: Thu Aug 25 23:01:08 2022 +0200

tdf#150594 - Prevent crash while searching for the next outline node

Change-Id: Ia83968b26f0053815c0da9910aa00f9dde577246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138850
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/sw/source/core/doc/doctxm.cxx b/sw/source/core/doc/doctxm.cxx
index bdea1e4dec1d..ee418e5f1d4e 100644
--- a/sw/source/core/doc/doctxm.cxx
+++ b/sw/source/core/doc/doctxm.cxx
@@ -804,8 +804,9 @@ static bool IsHeadingContained(const SwTextNode* pChptrNd, 
const SwNode& rNd)
 else
 {
 // Search for the next outline node which lies not within the 
current chapter node
-while (pChptrNd->GetAttrOutlineLevel()
-   < rONds[nPos]->GetTextNode()->GetAttrOutlineLevel())
+while (nPos > 0
+   && pChptrNd->GetAttrOutlineLevel()
+  < rONds[nPos]->GetTextNode()->GetAttrOutlineLevel())
 nPos--;
 bIsHeadingContained = pChptrNd == rONds[nPos]->GetTextNode();
 }

[Libreoffice-bugs] [Bug 150614] always Crashing

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150614

Tim  changed:

   What|Removed |Added

 CC||timothyrme...@gmail.com

--- Comment #1 from Tim  ---
Created attachment 182030
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182030=edit
A family Tree document

Help Please

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150586] Tables awkward to manage with new page generation

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150586

--- Comment #6 from Coburn Ingram  ---
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150614] New: always Crashing

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150614

Bug ID: 150614
   Summary: always Crashing
   Product: LibreOffice
   Version: 7.4.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer Web
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timothyrme...@gmail.com

Description:
I have a very long web document. Most likely the longest you have ever seen. It
crashes every time I turn around. It could be minutes or 1/2 hour at a time.
Also it moves things around in the document. I follow a precise guideline so
that all the documents are the same color-code at a certain space in the
document. I have recreated the document several times. If this can't be fixed,
I will need to return to using MS Word and that would be a shame.

 I also need to be able to print this off on a SC-T2475 printer as on sheet not
4 that it shows me.

Steps to Reproduce:
1.You need my document
2.
3.

Actual Results:
You will need to be able to have my document is there a way to upload it?

Expected Results:
I end up starting all over again


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150479] LibreOffice does not open files After upgrading Ubuntu to 22.04.01

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150479

--- Comment #31 from yen...@gmail.com ---
I got it to work (linux mint 21 Cinnamon, kernel 5.15.0-46). Must have been a
config file leftover...

$ sudo apt-get remove --purge libreoffice*
$ sudo apt-get clean
$ sudo apt-get autoremove
$ sudo apt install libreoffice

LO had to start in safe-mode. I selected 'factory settings' and restarted.
All seems functional now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150594] LO 7.4: crash when I update a chapter index (swlo!SwDoc::SetTOXBaseName+0x5cd:)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150594

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107200] [META] Writer table and cell selection issues

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107200
Bug 107200 depends on bug 109285, which changed state.

Bug 109285 Summary: Converting tabbed text to bullets adds extra tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=109285

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103369
Bug 103369 depends on bug 109285, which changed state.

Bug 109285 Summary: Converting tabbed text to bullets adds extra tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=109285

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: hwpfilter/source

2022-08-25 Thread Caolán McNamara (via logerrit)

 hwpfilter/source/hwpreader.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 84629220ad7d7897f57070b4aba6a3cbaef756aa
Author: Caolán McNamara 
AuthorDate: Thu Aug 25 20:27:50 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Aug 25 21:45:33 2022 +0200

ofz#47118 Timeout

Change-Id: I8bb03b567acd4419aff15267d936298378ca03d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138848
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index d2690082ce3b..58d9598c7af7 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -957,10 +957,10 @@ void HwpReader::makeMasterStyles()
 PageSetting *pPrevSet = nullptr;
 PageSetting *pPage = nullptr;
 
-if (nMax > SAL_MAX_UINT16 && utl::ConfigManager::IsFuzzing())
+if (nMax > 2048 && utl::ConfigManager::IsFuzzing())
 {
-SAL_WARN("filter.hwp", "too many pages: " << nMax << " clip to " << 
SAL_MAX_UINT16);
-nMax = SAL_MAX_UINT16;
+SAL_WARN("filter.hwp", "too many pages: " << nMax << " clip to " << 
2048);
+nMax = 2048;
 }
 
 for( i = 1; i <= nMax ; i++ )

[Libreoffice-bugs] [Bug 150613] New: Format of chapter number changed by format of the last character on the line

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150613

Bug ID: 150613
   Summary: Format of chapter number changed by format of the last
character on the line
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: will.fried...@gmail.com

Description:
After selecting the Heading style for the relevant chapter level of a document,
typing in some words, and directly formatting the last word (e.g., italics), it
changes the formatting of the number to follow the last word.

Steps to Reproduce:
1. Select Paragraph Style Heading.
2. Type some text.
3. Change the formatting of the last word (or character) you type. E.g., set it
to italics, or strikethrough, or unbold it, or change its color.
4. Hit enter. (The style of the number doesn't change until you move the cursor
to a different line, either by entering a new line or clicking to an existing
line.)

Actual Results:
The chapter number formatting changes to match the formatting of the last
character on the line.

Expected Results:
The number should retain the default formatting of the Heading paragraph style.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2022-08-25 Thread Justin Luth (via logerrit)

 sw/inc/IDocumentContentOperations.hxx   |1 +
 sw/qa/extras/uiwriter/uiwriter3.cxx |   11 ---
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   11 +++
 sw/source/core/inc/DocumentContentOperationsManager.hxx |1 +
 sw/source/uibase/wrtsh/wrtsh1.cxx   |2 +-
 5 files changed, 22 insertions(+), 4 deletions(-)

New commits:
commit 3e3328987b69a2a549d24c79ee71b353b9a3e288
Author: Justin Luth 
AuthorDate: Thu Aug 25 05:51:11 2022 -0400
Commit: Justin Luth 
CommitDate: Thu Aug 25 21:04:38 2022 +0200

tdf#109285 sw numbering: RemoveLeadingWhiteSpace from all paras

Change-Id: Ie834b9c10c9a6cfd7971c7713c5684157477acc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138807
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/inc/IDocumentContentOperations.hxx 
b/sw/inc/IDocumentContentOperations.hxx
index bac97d685927..94bb7102dee0 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -250,6 +250,7 @@ public:
 /** Removes any leading white space from the paragraph
 */
 virtual void RemoveLeadingWhiteSpace(const SwPosition & rPos ) = 0;
+virtual void RemoveLeadingWhiteSpace(SwPaM& rPaM) = 0;
 
 protected:
 virtual ~IDocumentContentOperations() {};
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 8b661082e8ba..062fb0acc195 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -4587,15 +4587,20 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf97899)
 IDocumentContentOperations& rIDCO(pDoc->getIDocumentContentOperations());
 
 // Create an Ordered List
-rIDCO.InsertString(*pCursor, "a");
+rIDCO.InsertString(*pCursor, "\ta");
 pWrtShell->SplitNode();
-rIDCO.InsertString(*pCursor, "b");
+rIDCO.InsertString(*pCursor, "   b");
 pWrtShell->SplitNode();
-rIDCO.InsertString(*pCursor, "c");
+rIDCO.InsertString(*pCursor, "  \t  c");
 
 dispatchCommand(mxComponent, ".uno:SelectAll", {});
 dispatchCommand(mxComponent, ".uno:DefaultNumbering", {});
 
+// tdf#109285: RemoveLeadingWhiteSpace from all numbered paragraphs
+getParagraph(1, "a");
+getParagraph(2, "b");
+getParagraph(3, "c");
+
 // Save it as DOCX & load it again
 reload("Office Open XML Text", "tdf97899-tmp.docx");
 uno::Reference xNumberingRules
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index d751ac3d19f9..59bfafb5d313 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -3616,6 +3616,17 @@ void 
DocumentContentOperationsManager::RemoveLeadingWhiteSpace(const SwPosition
 }
 }
 
+void DocumentContentOperationsManager::RemoveLeadingWhiteSpace(SwPaM& rPaM )
+{
+for (SwPaM& rSel :rPaM.GetRingContainer())
+{
+SwNodeOffset nStt = rSel.Start()->nNode.GetIndex();
+SwNodeOffset nEnd = rSel.End()->nNode.GetIndex();
+for (SwNodeOffset nPos = nStt; nPos<=nEnd; nPos++)
+RemoveLeadingWhiteSpace(SwPosition(rSel.GetBound().GetNodes(), 
nPos));
+}
+}
+
 // Copy method from SwDoc - "copy Flys in Flys"
 /// note: rRg/rInsPos *exclude* a partially selected start text node;
 ///   pCopiedPaM *includes* a partially selected start text node
diff --git a/sw/source/core/inc/DocumentContentOperationsManager.hxx 
b/sw/source/core/inc/DocumentContentOperationsManager.hxx
index decc16c14648..6b45e6ca01ae 100644
--- a/sw/source/core/inc/DocumentContentOperationsManager.hxx
+++ b/sw/source/core/inc/DocumentContentOperationsManager.hxx
@@ -96,6 +96,7 @@ public:
 SwRootFrame const* pLayout = nullptr) override;
 
 void RemoveLeadingWhiteSpace(const SwPosition & rPos ) override;
+void RemoveLeadingWhiteSpace(SwPaM& rPaM) override;
 
 
 //Non-Interface methods
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx 
b/sw/source/uibase/wrtsh/wrtsh1.cxx
index 6606b65ff49f..5b6649861a74 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -1549,7 +1549,7 @@ void SwWrtShell::NumOrBulletOn(bool bNum)
 const SwTwips nWidthOfTabs = pTextNode
  ? pTextNode->GetWidthOfLeadingTabs()
  : 0;
-GetDoc()->getIDocumentContentOperations().RemoveLeadingWhiteSpace( 
*GetCursor()->GetPoint() );
+
GetDoc()->getIDocumentContentOperations().RemoveLeadingWhiteSpace(*GetCursor());
 
 const bool bHtml = dynamic_cast( pDocSh ) !=  nullptr;
 const bool bRightToLeft = IsInRightToLeftText();

[Libreoffice-bugs] [Bug 150612] LibreOffice will not open except through the Windows Run command in Safe Mode

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150612

--- Comment #2 from Timur  ---
Does User Profile Reset: Yes really mean you deleted or renamed LO user profile
folder?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150612] LibreOffice will not open except through the Windows Run command in Safe Mode

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150612

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Timur  ---
When you start LO, please paste here info from Help-About. To know Windows
version. 
This may be Skia bug related to graphic card, as bug 145803, so you need to run
without Skia. 

You may start from command line or via script (replacing path-to) with:
set SAL_DISABLESKIA=1 
path-to\soffice.exe

Or make a shortcut as one-liner:

C:\Windows\System32\cmd.exe /c "set SAL_DISABLESKIA=1 && START /D ^"C:\Program
Files\LibreOffice\program^" soffice.exe  --norestore"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

--- Comment #16 from V Stuart Foote  ---
No improvement in the SVG dropouts after updating to latest Intel driver for
this GPU Driver Version 31.0.101.2111

which updates Vulkan driver to be:

RenderMethod: vulkan
Vendor: 0x8086
Device: 0x8a52
API: 1.3.215
Driver: 0.404.2111
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Plus Graphics
Denylisted: no

in Impress edit mode, continue to see some artifacts in Skia Vulkan rendering
as the canvas is panned. But the Skia Raster mode is clean. 

Looking at it in Vulkan rendering and attached to WinDbg, it does look to fail
graphics watchdog when going into full screen presentation, which suggests this
GPU should be denylisted, except this is pretty generic GPU.  Maybe not too
much available video RAM but it should handle this simple Vulkan rendering.
Makes me think we have an implementation issue in here somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150611] Fatal exception Signal 6 on startup after Ubuntu jammy upgrade

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150611

--- Comment #5 from Timur  ---
Just in case please remove LO profile folder and try again, before removing LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150479] LibreOffice does not open files After upgrading Ubuntu to 22.04.01

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150479

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0611

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150611] Fatal exception Signal 6 on startup after Ubuntu jammy upgrade

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150611

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0479
   Severity|normal  |critical

--- Comment #4 from Timur  ---
This seems like Ubuntu or Mint bug rather then LO. 
You say you reinstalled but didn't say how, maybe via Synaptic or some
Software. 
I'd add remove LO, then add LO PPA and install 7.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 150507, which changed state.

Bug 150507 Summary: VIEWING: Text in Writer 7.4.0 appears smeared
https://bugs.documentfoundation.org/show_bug.cgi?id=150507

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

2022-08-25 Thread Noel Grandin (via logerrit)

 sw/inc/ndarr.hxx |2 ++
 sw/source/core/doc/docedt.cxx|2 +-
 sw/source/core/doc/docfmt.cxx|4 ++--
 sw/source/core/docnode/nodes.cxx |6 ++
 4 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit f5eccd1ecf67daace793fb7c856b4429345a9338
Author: Noel Grandin 
AuthorDate: Thu Aug 25 18:30:40 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 25 20:22:16 2022 +0200

add version of SwNodes::ForEach that takes SwNode params

instead of SwNodeIndex. Part of the process of hiding the
internals of SwPosition.

Change-Id: I86f3eed9b614295857eb9219d76f3cd00c48a634
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138840
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/ndarr.hxx b/sw/inc/ndarr.hxx
index 0dabda23ec9f..8f8cce07a4dd 100644
--- a/sw/inc/ndarr.hxx
+++ b/sw/inc/ndarr.hxx
@@ -145,6 +145,8 @@ public:
 ForEach( SwNodeOffset(0), Count(), fnForEach, pArgs );
 }
 void ForEach( SwNodeOffset nStt, SwNodeOffset nEnd, FnForEach_SwNodes 
fnForEach, void* pArgs );
+void ForEach( SwNode& rStart, SwNode& rEnd,
+FnForEach_SwNodes fnForEach, void* pArgs );
 void ForEach( const SwNodeIndex& rStart, const SwNodeIndex& rEnd,
 FnForEach_SwNodes fnForEach, void* pArgs );
 
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index b20789b60bc8..2b097eca37cb 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -808,7 +808,7 @@ uno::Reference< XHyphenatedWord >  SwDoc::Hyphenate(
 
 SwHyphArgs aHyphArg( pPam, rCursorPos, pPageCnt, pPageSt );
 SwNodeIndex aTmpIdx( pPam->GetMark()->GetNode(), 1 );
-GetNodes().ForEach( pPam->GetPoint()->nNode, aTmpIdx,
+GetNodes().ForEach( pPam->GetPoint()->GetNode(), aTmpIdx.GetNode(),
 lcl_HyphenateNode,  );
 aHyphArg.SetPam( pPam );
 return aHyphArg.GetHyphWord();  // will be set by lcl_HyphenateNode
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index cc53bc815e82..357ca66aeb8d 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -380,7 +380,7 @@ void SwDoc::ResetAttrs( const SwPaM ,
 }
 
 if( aTmpStt < aTmpEnd )
-GetNodes().ForEach( pStt->nNode, aTmpEnd, lcl_RstAttr,  );
+GetNodes().ForEach( pStt->GetNode(), aTmpEnd.GetNode(), lcl_RstAttr, 
 );
 else if( !rRg.HasMark() )
 {
 aPara.bResetAll = false ;
@@ -392,7 +392,7 @@ void SwDoc::ResetAttrs( const SwPaM ,
 {
 if( bAdd )
 ++aTmpEnd;
-GetNodes().ForEach( pStt->nNode, aTmpEnd, 
sw::DocumentContentOperationsManager::lcl_RstTextAttr,  );
+GetNodes().ForEach( pStt->GetNode(), aTmpEnd.GetNode(), 
sw::DocumentContentOperationsManager::lcl_RstTextAttr,  );
 }
 
 getIDocumentState().SetModified();
diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index 93384c28d12a..6a8de7c94ff9 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -2390,6 +2390,12 @@ void SwNodes::ForEach( const SwNodeIndex& rStart, const 
SwNodeIndex& rEnd,
 ForEach( rStart.GetIndex(), rEnd.GetIndex(), fnForEach, pArgs );
 }
 
+void SwNodes::ForEach( SwNode& rStart, SwNode& rEnd,
+FnForEach_SwNodes fnForEach, void* pArgs )
+{
+ForEach( rStart.GetIndex(), rEnd.GetIndex(), fnForEach, pArgs );
+}
+
 void SwNodes::RemoveNode( SwNodeOffset nDelPos, SwNodeOffset nSz, bool bDel )
 {
 #ifndef NDEBUG

[Libreoffice-commits] core.git: sw/source

2022-08-25 Thread Noel Grandin (via logerrit)

 sw/source/core/doc/doccomp.cxx |   20 ++--
 sw/source/core/doc/doccorr.cxx |   12 +++-
 sw/source/core/doc/docedt.cxx  |6 +++---
 sw/source/core/doc/docfly.cxx  |   22 +++---
 sw/source/core/doc/docfmt.cxx  |2 +-
 sw/source/core/doc/docglos.cxx |8 
 sw/source/core/doc/doclay.cxx  |3 +--
 7 files changed, 37 insertions(+), 36 deletions(-)

New commits:
commit d7234feac18dbb94fef310e8c241428426b27717
Author: Noel Grandin 
AuthorDate: Thu Aug 25 18:45:33 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 25 20:21:54 2022 +0200

use more SwPosition::Assign

as part of the process of hiding the internals of SwPosition

Change-Id: I86da72d648ba006f55fcec86854e5188720a1156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138841
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx
index 7cb4a640173e..e29ea7d87f1c 100644
--- a/sw/source/core/doc/doccomp.cxx
+++ b/sw/source/core/doc/doccomp.cxx
@@ -1672,10 +1672,10 @@ void CompareData::SetRedlinesToDoc( bool bUseDocInfo )
 if (& GetEndOfContent() ==
 & pTmp->GetPoint()->GetNode())
 {
---pTmp->GetPoint()->nNode;
+pTmp->GetPoint()->Adjust(SwNodeOffset(-1));
 SwContentNode *const pContentNode( pTmp->GetPointContentNode() 
);
-pTmp->GetPoint()->nContent.Assign( pContentNode,
-pContentNode ? pContentNode->Len() : 0 );
+if( pContentNode )
+pTmp->GetPoint()->SetContent( pContentNode->Len() );
 // tdf#106218 try to avoid losing a paragraph break here:
 if (pTmp->GetMark()->GetContentIndex() == 0)
 {
@@ -1715,10 +1715,10 @@ void CompareData::SetRedlinesToDoc( bool bUseDocInfo )
 if (& GetEndOfContent() ==
 & pTmp->GetPoint()->GetNode())
 {
---pTmp->GetPoint()->nNode;
+pTmp->GetPoint()->Adjust(SwNodeOffset(-1));
 SwContentNode *const pContentNode( pTmp->GetPointContentNode() );
-pTmp->GetPoint()->nContent.Assign( pContentNode,
-pContentNode ? pContentNode->Len() : 0 );
+if( pContentNode )
+pTmp->GetPoint()->SetContent( pContentNode->Len() );
 // tdf#106218 try to avoid losing a paragraph break here:
 if (pTmp->GetMark()->GetContentIndex() == 0)
 {
@@ -1929,10 +1929,10 @@ SaveMergeRedline::SaveMergeRedline( const SwNode& 
rDstNd,
 const SwPosition* pEnd = rSrcRedl.End();
 
 pDestRedl->SetMark();
-pDestRedl->GetPoint()->nNode += pEnd->GetNodeIndex() -
-pStt->GetNodeIndex();
-pDestRedl->GetPoint()->nContent.Assign( pDestRedl->GetPointContentNode(),
-pEnd->GetContentIndex() );
+pDestRedl->GetPoint()->Adjust( pEnd->GetNodeIndex() -
+pStt->GetNodeIndex() );
+if( pDestRedl->GetPointContentNode() )
+pDestRedl->GetPoint()->SetContent( pEnd->GetContentIndex() );
 }
 
 sal_uInt16 SaveMergeRedline::InsertRedline(SwPaM* pLastDestRedline)
diff --git a/sw/source/core/doc/doccorr.cxx b/sw/source/core/doc/doccorr.cxx
index 2af89d1cdf37..b4167611f8e9 100644
--- a/sw/source/core/doc/doccorr.cxx
+++ b/sw/source/core/doc/doccorr.cxx
@@ -73,13 +73,15 @@ namespace
 const sal_Int32 nCntIdx)
 {
 for(int nb = 0; nb < 2; ++nb)
-if(&(pPam->GetBound(bool(nb)).GetNode()) == pOldNode)
+{
+SwPosition & rPos = pPam->GetBound(bool(nb));
+if(() == pOldNode)
 {
-pPam->GetBound(bool(nb)).nNode = rNewPos.nNode;
-pPam->GetBound(bool(nb)).nContent.Assign(
-rNewPos.GetNode().GetContentNode(),
-nCntIdx + pPam->GetBound(bool(nb)).GetContentIndex());
+rPos.Assign( rNewPos.GetNode() );
+if(rNewPos.GetNode().GetContentNode())
+rPos.AdjustContent(nCntIdx);
 }
+}
 }
 }
 
diff --git a/sw/source/core/doc/docedt.cxx b/sw/source/core/doc/docedt.cxx
index 9be8bcccae63..b20789b60bc8 100644
--- a/sw/source/core/doc/docedt.cxx
+++ b/sw/source/core/doc/docedt.cxx
@@ -141,7 +141,7 @@ void SaveFlyInRange( const SwPaM& rPam, const SwPosition& 
rInsPos,
 const SwFormatAnchor* pAnchor;
 
 const SwPosition* pPos = rPam.Start();
-const SwNodeIndex& rSttNdIdx = pPos->nNode;
+const SwNode& rSttNd = pPos->GetNode();
 
 SwPosition atParaEnd(*rPam.End());
 if (bMoveAllFlys)
@@ -183,9 +183,9 @@ void SaveFlyInRange( const SwPaM& rPam, const SwPosition& 
rInsPos,
 {
 pHistory->AddChangeFlyAnchor(*pFormat);
 }
-SaveFly aSave( pAPos->GetNodeIndex()

[Libreoffice-bugs] [Bug 150591] Calc Segmentation Fault Segfault Crash Coredump Upon Close After Changes

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150591

--- Comment #2 from nroycea+documentfoundat...@gmail.com ---
That is something I had already done before I posted. Even renaming my current
profile dir and starting clean that way. Safe mode exhibited the same behavior.
I even just did it again just now in safe-mode before sending this. Same
result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2022-08-25 Thread Khaled Hosny (via logerrit)

 vcl/source/font/FeatureCollector.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3a541e3ba663485f94caf2803a05f7109653dce8
Author: Khaled Hosny 
AuthorDate: Thu Aug 25 19:07:37 2022 +0200
Commit: خالد حسني 
CommitDate: Thu Aug 25 20:11:37 2022 +0200

FeatureCollector: Fix parameter code for named parameters

The code are 1-indexed (since 0 means disabled).

Change-Id: I1d4ed80ba91191645305aad2d621116c5d36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138842
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/source/font/FeatureCollector.cxx 
b/vcl/source/font/FeatureCollector.cxx
index c792d50d7e17..653712c27e93 100644
--- a/vcl/source/font/FeatureCollector.cxx
+++ b/vcl/source/font/FeatureCollector.cxx
@@ -158,7 +158,7 @@ void FeatureCollector::collectForTable(hb_tag_t aTableTag)
 hb_ot_name_id_t aNameID = aFirstParameterID + i;
 OUString sName = getName(m_pHbFace, aNameID, 
sLanguage);
 if (!sName.isEmpty())
-aParameters.emplace_back(uint32_t(i), sName);
+aParameters.emplace_back(uint32_t(i + 1), sName);
 }
 }
 }

[Libreoffice-bugs] [Bug 150594] LO 7.4: crash when I update a chapter index (swlo!SwDoc::SetTOXBaseName+0x5cd:)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150594

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0318

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

--- Comment #15 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #14)
> Created attachment 182029 [details]
> camera shot of presentation on 7.3.6.1 with Skia Vulkan rendering glitch

Version: 7.3.6.1 (x64) / LibreOffice Community
Build ID: 92b673af3a5e8f7cf4716be88dfaca424612f244
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded


same rendering issues with 7.4.1alfa and current master against 7.5.0 

=-ref-=
skia.log

RenderMethod: vulkan
Vendor: 0x8086
Device: 0x8a52
API: 1.2.195
Driver: 0.404.1069
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Plus Graphics
Denylisted: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150531] Incorrectly rendered SVG images with Skia enabled

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150531

--- Comment #14 from V Stuart Foote  ---
Created attachment 182029
  --> https://bugs.documentfoundation.org/attachment.cgi?id=182029=edit
camera shot of presentation on 7.3.6.1 with Skia Vulkan rendering glitch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150569] Date shown incorrectly in a form with default values

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150569

jcs...@libreoffice.org changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jcs...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150587] Date control. It is not possible set "Date min" property a value lower than 1/1/1600 or "Date max" greater than 1/1/9999

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150587

jcs...@libreoffice.org changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jcs...@libreoffice.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Touchpad gesture support (e.g. for zooming via touchpad pinch gestures)

2022-08-25 Thread Tomaž Vajngerl

Hi,

On Thu, Aug 25, 2022 at 12:16 PM Povilas Kanapickas 
wrote:

> Hello,
>
> I would like to implement support for touchpad gesture handling to
> LibreOffice. This is useful e.g. for zooming views using two-finger
> pinch touchpad gesture or rotating objects using two-finger rotate gesture.
>
> I have implemented this functionality in GIMP and would like to do the
> same for LibreOffice. In LibreOffice case the implementation will be
> more complex, as there are more backends than just GTK, but this will
> just require more work.
>
> There is a proof of concept implementation that wires touchpad gestures
> on GTK to the ViewShell widget. As a result it's possible to use
> touchpad pinch gesture to zoom in-out the main slide in Impress.
>
> https://gerrit.libreoffice.org/c/core/+/138791/1 (note that
> implementation is split across 5 changes in the chain).
>
> Please let me know what do you think about this problem and the proof of
> concept solution.
>

Looks great.

The reason why GestureEvent is called so generally is that there should
only be one common gesture event for all types of gestures - even if that
would also mean it would have all the member variables of all the gestures
- for simplicity. But I guess that approach is also ok...


> I would like to eventually add touchpad gesture support to all UI
> elements of LibreOffice where that makes sense.
>

I have experimented with panning support years ago - maybe some code
pointers will be useful.

https://pastebin.com/2xHfSe8B


> Cheers,
> Povilas
>

Tomaž

[Libreoffice-bugs] [Bug 150567] LibreOffice is showing unreadable file names it the name uses Arabic or Persian characters.

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150567

--- Comment #7 from خالد حسني  ---
(In reply to خالد حسني from comment #6)
> (In reply to Mike Kaganski from comment #5)
> > Do the files show OK in the system file manager?
> 
> So it is a LibreOffice issue after all. I think this and bug 145758 should
> be duplicates of bug 125995.

Though we probably need a screenshot of About LibreOffice from Morteza to see
what locale is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150567] LibreOffice is showing unreadable file names it the name uses Arabic or Persian characters.

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150567

--- Comment #6 from خالد حسني  ---
(In reply to Mike Kaganski from comment #5)
> Do the files show OK in the system file manager?

So it is a LibreOffice issue after all. I think this and bug 145758 should be
duplicates of bug 125995.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125995] C locale is currently broken for file handling

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125995

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0567

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150567] LibreOffice is showing unreadable file names it the name uses Arabic or Persian characters.

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150567

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5995,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5971

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150587] Date control. It is not possible set "Date min" property a value lower than 1/1/1600 or "Date max" greater than 1/1/9999

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150587

gmoll...@us.es changed:

   What|Removed |Added

 CC||gmoll...@us.es
Version|3.5.0 release   |3.3 all versions

--- Comment #5 from gmoll...@us.es ---
Confirmed:
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source

2022-08-25 Thread László Németh (via logerrit)

 sw/qa/extras/uiwriter/uiwriter3.cxx |   70 
 sw/source/core/frmedt/fetab.cxx |   23 +++
 2 files changed, 93 insertions(+)

New commits:
commit 6b86e529fb6681bbd8207ee7f3d9e57cb2e55502
Author: László Németh 
AuthorDate: Wed Aug 24 17:10:56 2022 +0200
Commit: László Németh 
CommitDate: Thu Aug 25 19:05:18 2022 +0200

tdf#150576 sw: fix cursor pos deleting at rows deleted already

Instead of jumping in the start of the document, set cursor
after (or deleting the last row, before) the rows deleted
already in Hide Changes mode with enabled change tracking.

Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885
"tdf#146962 sw: hide deleted row at deletion in Hide Changes".

Follow-up to commit 189aa05c6ea17a8e823b4eab18ea0d1131d9d73e
"tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes".

Conflicts:
sw/qa/extras/uiwriter/uiwriter3.cxx

Change-Id: Ifc2a7f41a57f413d27d9b464a0e464643d15f404
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138772
Tested-by: Jenkins
Reviewed-by: László Németh 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138786
Tested-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 9479e34858bd..6d93e784f394 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -3564,6 +3564,76 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf148849)
 CPPUNIT_ASSERT_EQUAL(OUString("Row 2"), rNode.GetTextNode()->GetText());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf150576)
+{
+// load a document with a table and an empty paragraph before the table
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf148849.fodt");
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+// record changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On | 
RedlineFlags::ShowDelete
+  | 
RedlineFlags::ShowInsert);
+CPPUNIT_ASSERT_MESSAGE("redlining should be on",
+   pDoc->getIDocumentRedlineAccess().IsRedlineOn());
+// hide changes
+dispatchCommand(mxComponent, ".uno:ShowTrackedChanges", {});
+CPPUNIT_ASSERT(pWrtShell->GetLayout()->IsHideRedlines());
+
+uno::Reference xTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
+
+// Check deletion of the first row, if the second row deleted already
+
+// put cursor in the second table row
+pWrtShell->Down(/*bSelect=*/false, /*nCount=*/2);
+SwNode& rNode = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("Row 2"), rNode.GetTextNode()->GetText());
+
+// delete the second table row
+pWrtShell->DeleteRow();
+
+// check cursor position (row 3)
+SwNode& rNode2 = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("Row 3"), rNode2.GetTextNode()->GetText());
+
+// put cursor in the first row
+pWrtShell->Up(/*bSelect=*/false, /*nCount=*/1);
+SwNode& rNode3 = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("12"), rNode3.GetTextNode()->GetText());
+
+// delete the first row
+pWrtShell->DeleteRow();
+
+// This was empty (cursor jumped in the start of the document instead of
+// the next not deleted row)
+SwNode& rNode4 = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("Row 3"), rNode4.GetTextNode()->GetText());
+
+// Check skipping previous lines
+
+// restore deleted rows
+dispatchCommand(mxComponent, ".uno:Undo", {});
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+SwNode& rNode5 = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("Row 2"), rNode5.GetTextNode()->GetText());
+
+// delete the second row
+pWrtShell->DeleteRow();
+SwNode& rNode7 = pWrtShell->GetCursor()->GetNode();
+CPPUNIT_ASSERT_EQUAL(OUString("Row 3"), rNode7.GetTextNode()->GetText());
+
+// delete the third, i.e. last row
+pWrtShell->DeleteRow();
+SwNode& rNode8 = pWrtShell->GetCursor()->GetNode();
+
+// This was empty (cursor jumped in the start of the document instead of
+// the previous not deleted row)
+CPPUNIT_ASSERT_EQUAL(OUString("12"), rNode8.GetTextNode()->GetText());
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf132603)
 {
 createSwDoc();
diff --git a/sw/source/core/frmedt/fetab.cxx b/sw/source/core/frmedt/fetab.cxx
index c5053080d8ff..e061bbb49b68 100644
--- a/sw/source/core/frmedt/fetab.cxx
+++ b/sw/source/core/frmedt/fetab.cxx
@@ -417,6 +417,16 @@ bool SwFEShell::DeleteRow(bool bCompleteTable)
 }
 SwTableBox*

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sw/qa sw/source

2022-08-25 Thread László Németh (via logerrit)

 sw/qa/extras/uiwriter/data/tdf148849.fodt |   53 ++
 sw/qa/extras/uiwriter/uiwriter3.cxx   |   34 +++
 sw/source/core/frmedt/fetab.cxx   |   30 +++-
 3 files changed, 108 insertions(+), 9 deletions(-)

New commits:
commit 16c705ec0d1ab4b4428577ccb0ea3fc14ee0fc88
Author: László Németh 
AuthorDate: Mon Aug 22 11:18:23 2022 +0200
Commit: László Németh 
CommitDate: Thu Aug 25 19:05:01 2022 +0200

tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes

In Hide Changes mode, the text cursor jumped to the start of the
document after tracked deletion of a table row, instead of
remaining in the table in the next table row.

Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885
"tdf#146962 sw: hide deleted row at deletion in Hide Changes".

Conflicts:
sw/source/core/frmedt/fetab.cxx
sw/qa/extras/uiwriter/uiwriter3.cxx

Change-Id: Iff959c9a9940db013827e1c827bcb92c07b4b26a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138683
Tested-by: Jenkins
Reviewed-by: László Németh 
(cherry picked from commit 189aa05c6ea17a8e823b4eab18ea0d1131d9d73e)

Change-Id: I17e11862cf144f150e64082e7c8b22c3877fbc2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138785
Tested-by: Jenkins
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/data/tdf148849.fodt 
b/sw/qa/extras/uiwriter/data/tdf148849.fodt
new file mode 100644
index ..07efa8bb6dbd
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/tdf148849.fodt
@@ -0,0 +1,53 @@
+
+
+http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:ooow="http://openoffice.org/200
 4/writer" 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:table="urn:oasis:names:tc:open
 document:xmlns:table:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+ 
+  
+   
+
+ 
+  
+   xxx4
+   2021-09-21T14:41:20
+  
+ 
+
+
+ 
+  
+   xxx4
+   2021-09-21T14:41:20
+  
+ 
+
+   
+   
+
+
+
+
+
+   
+   
+   
+
+
+ 
+  12
+ 
+
+
+ 
+  Row 2
+ 
+
+
+ 
+  Row 3
+ 
+
+   
+   
+  
+ 
+
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 1d5455341839..9479e34858bd 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -3530,6 +3530,40 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf146573)
 CPPUNIT_ASSERT_EQUAL(OUString("204"), xCellA4->getString());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf148849)
+{
+// load a document with a table and an empty paragraph before the table
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf148849.fodt");
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+
+// record changes
+pDoc->getIDocumentRedlineAccess().SetRedlineFlags(RedlineFlags::On | 
RedlineFlags::ShowDelete
+

[Libreoffice-bugs] [Bug 150612] New: LibreOffice will not open except through the Windows Run command in Safe Mode

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150612

Bug ID: 150612
   Summary: LibreOffice will not open except through the Windows
Run command in Safe Mode
   Product: LibreOffice
   Version: 7.3.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wise.lou...@gmail.com

Description:
I am unable to open a LibreOffice file or any LibreOffice application. I
attempted to look for similar reports and the suggestions had me use the
Microsoft Run command to open Libre in safe mode which works but then I am
unable to restore backup or reset. I am forced to Continue in safe mode. I must
repeat this process of opening the Run Command and continuing in safe mode
every time i want to open a LibreOffice file.

Steps to Reproduce:
1. Attempt to open any LibreOffice file
2.
3.

Actual Results:
The LibreOffice Community screen opens, loads and closes immediately

Expected Results:
The LibreOffice Community screen should open and then load the correct file


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: safemode
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150594] LO 7.4: crash when I update a chapter index (swlo!SwDoc::SetTOXBaseName+0x5cd:)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150594

--- Comment #5 from Andreas Heinisch  ---
Will take a look the next days when I find some spare time 珞

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82627

m.a.riosv  changed:

   What|Removed |Added

 CC||mjtom...@gmail.com

--- Comment #26 from m.a.riosv  ---
*** Bug 150593 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150593] text rotate does not work

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150593

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from m.a.riosv  ---


*** This bug has been marked as a duplicate of bug 82627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150592] Comments should be shown over all form controls (eg push button)

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150592

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
And if the comment it's showed above, can hide the button. How do you see it
then?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150591] Calc Segmentation Fault Segfault Crash Coredump Upon Close After Changes

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150591

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Please test with a clean profile, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150611] Fatal exception Signal 6 on startup after Ubuntu jammy upgrade

2022-08-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=150611

--- Comment #3 from Julien Nabet  ---
Indeed it's not gtk specific.
Since you tested with  --safe, it's not profile related too.
I must recognize I'm stuck but certainly other people may help here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/qt5

2022-08-25 Thread Michael Weghorn (via logerrit)

 vcl/qt5/QtAccessibleEventListener.cxx |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 8ce3d4f8b000e11d63d37546c5f574e57db46551
Author: Michael Weghorn 
AuthorDate: Thu Aug 25 16:58:06 2022 +0200
Commit: Michael Weghorn 
CommitDate: Thu Aug 25 18:37:02 2022 +0200

qt a11y: Forward text selection change event as such

Change-Id: I7e208d964c5b5badb0a3ea3a19c3ca3cc7fa4ff4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138838
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/QtAccessibleEventListener.cxx 
b/vcl/qt5/QtAccessibleEventListener.cxx
index dd2ee1b2eae6..9dbc3f3e5504 100644
--- a/vcl/qt5/QtAccessibleEventListener.cxx
+++ b/vcl/qt5/QtAccessibleEventListener.cxx
@@ -30,6 +30,7 @@
 #include 
 
 #include 
+#include 
 
 using namespace css;
 using namespace css::accessibility;
@@ -222,9 +223,21 @@ void QtAccessibleEventListener::notifyEvent(const 
css::accessibility::Accessible
 new QAccessibleEvent(pQAccessibleInterface, 
QAccessible::VisibleDataChanged));
 return;
 case AccessibleEventId::TEXT_SELECTION_CHANGED:
+{
+QAccessibleTextInterface* pTextInterface = 
pQAccessibleInterface->textInterface();
+if (!pTextInterface)
+{
+SAL_WARN("vcl.qt", "TEXT_SELECTION_CHANGED event received for 
object not "
+   "implementing text interface");
+return;
+}
+int nStartOffset = 0;
+int nEndOffset = 0;
+pTextInterface->selection(0, , );
 QAccessible::updateAccessibility(
-new QAccessibleEvent(pQAccessibleInterface, 
QAccessible::Selection));
+new QAccessibleTextSelectionEvent(pQAccessibleInterface, 
nStartOffset, nEndOffset));
 return;
+}
 case AccessibleEventId::TEXT_ATTRIBUTE_CHANGED:
 QAccessible::updateAccessibility(
 new QAccessibleEvent(pQAccessibleInterface, 
QAccessible::AttributeChanged));

1 2 3 >

1 - 100 of 284 matches

Mail list logo