[Libreoffice-bugs] [Bug 136003] PROTECT SHEET: Can't delete rows, despite of allow to deletes
https://bugs.documentfoundation.org/show_bug.cgi?id=136003 --- Comment #7 from Kira Tubo --- Still reproducible in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 695ae365dcab7c7dd59b39411299c5c200081885 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138572] Lights Impress template is off in multiple ways (page 3 shows only partly a template). Circles are white in draw mode
https://bugs.documentfoundation.org/show_bug.cgi?id=138572 Sophie Sipasseuth changed: What|Removed |Added Version|7.2.0.0.alpha0+ |7.1.0.0.alpha1+ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138572] Lights Impress template is off in multiple ways (page 3 shows only partly a template). Circles are white in draw mode
https://bugs.documentfoundation.org/show_bug.cgi?id=138572 --- Comment #5 from Sophie Sipasseuth --- Repro Version: 7.1.0.0.alpha1+ (x64) Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win Locale: fr-FR (fr_FR); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121219] UI: Split view separator lines responsive on double click only after move by mouse
https://bugs.documentfoundation.org/show_bug.cgi?id=121219 --- Comment #5 from Kira Tubo --- Issue is still reproducible Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 695ae365dcab7c7dd59b39411299c5c200081885 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157047] clicking on Properties under File cause program to hang
https://bugs.documentfoundation.org/show_bug.cgi?id=157047 Julien Nabet changed: What|Removed |Added Summary|clicking on Properties |clicking on Properties |under File cause programme |under File cause program to |to hang |hang -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/accmap.hxx|4
sw/source/core/access/accmap.cxx | 196 ++-
2 files changed, 76 insertions(+), 124 deletions(-)
New commits:
commit 14dc749f575a8faea301472ed22f9c6b24044e8d
Author: Noel Grandin
AuthorDate: Wed Aug 30 16:02:29 2023 +0200
Commit: Noel Grandin
CommitDate: Fri Sep 1 08:49:17 2023 +0200
use concrete type for SwAccessibleMap::mxCursorContext
avoid some unnecessary casting
Change-Id: I354ac67aa7a0c7f8ebe676315c66c97af31dc4e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156318
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/accmap.hxx b/sw/inc/accmap.hxx
index 33f3a2d93f94..42a73cbf4fe9 100644
--- a/sw/inc/accmap.hxx
+++ b/sw/inc/accmap.hxx
@@ -27,7 +27,7 @@
#include
#include
-
+#include
#include
#include
#include
@@ -108,7 +108,7 @@ class SwAccessibleMap final : public
::accessibility::IAccessibleViewForwarder,
/// preview-to-display coordinates
std::unique_ptr mpPreview;
-css::uno::WeakReference < css::accessibility::XAccessible >
mxCursorContext;
+unotools::WeakReference< SwAccessibleContext > mxCursorContext;
bool mbShapeSelected;
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 02038f14fc25..b8b87289286a 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -86,8 +86,8 @@ using namespace ::sw::access;
class SwAccessibleContextMap_Impl
{
public:
-typedef const SwFrame *
key_type;
-typedef uno::WeakReference < XAccessible >
mapped_type;
+typedef const SwFrame *
key_type;
+typedef unotools::WeakReference < SwAccessibleContext >
mapped_type;
typedef std::pair
value_type;
typedef std::unordered_map::iterator iterator;
typedef std::unordered_map::const_iterator
const_iterator;
@@ -647,8 +647,8 @@ struct SwAccessibleParaSelection
struct SwXAccWeakRefComp
{
-bool operator()( const uno::WeakReference& _rXAccWeakRef1,
- const uno::WeakReference& _rXAccWeakRef2
) const
+bool operator()( const unotools::WeakReference&
_rXAccWeakRef1,
+ const unotools::WeakReference&
_rXAccWeakRef2 ) const
{
return _rXAccWeakRef1.get() < _rXAccWeakRef2.get();
}
@@ -659,7 +659,7 @@ struct SwXAccWeakRefComp
class SwAccessibleSelectedParas_Impl
{
public:
-typedef uno::WeakReference < XAccessible >
key_type;
+typedef unotools::WeakReference < SwAccessibleContext >
key_type;
typedef SwAccessibleParaSelection
mapped_type;
typedef std::pair
value_type;
typedef SwXAccWeakRefComp
key_compare;
@@ -859,7 +859,7 @@ void SwAccPreviewData::AdjustLogicPgRectToVisibleArea(
_iorLogicPgSwRect.AddBottom( - nTmpDiff );
}
-static bool AreInSameTable( const uno::Reference< XAccessible >& rAcc,
+static bool AreInSameTable( const rtl::Reference< SwAccessibleContext >& rAcc,
const SwFrame *pFrame )
{
bool bRet = false;
@@ -870,11 +870,9 @@ static bool AreInSameTable( const uno::Reference<
XAccessible >& rAcc,
// by comparing the last table frame in the
// follow chain, because that's cheaper than
// searching the first one.
-SwAccessibleContext *pAccImpl =
-static_cast< SwAccessibleContext *>( rAcc.get() );
-if( pAccImpl->GetFrame()->IsCellFrame() )
+if( rAcc->GetFrame()->IsCellFrame() )
{
-const SwTabFrame *pTabFrame1 =
pAccImpl->GetFrame()->FindTabFrame();
+const SwTabFrame *pTabFrame1 = rAcc->GetFrame()->FindTabFrame();
if (pTabFrame1)
{
while (pTabFrame1->GetFollow())
@@ -904,14 +902,10 @@ void SwAccessibleMap::FireEvent( const
SwAccessibleEvent_Impl& rEvent )
mpFrameMap->find( rEvent.mpParentFrame );
if( aIter != mpFrameMap->end() )
{
-uno::Reference < XAccessible > xAcc( (*aIter).second );
-if (xAcc.is())
+rtl::Reference < SwAccessibleContext > xContext(
(*aIter).second.get() );
+if (xContext.is() && xContext->getAccessibleRole() ==
AccessibleRole::PARAGRAPH)
{
-uno::Reference < XAccessibleContext >
xContext(xAcc,uno::UNO_QUERY);
-if (xContext.is() && xContext->getAccessibleRole() ==
AccessibleRole::PARAGRAPH)
-{
-xAccImpl = static_cast< SwAccessibleContext *>( xAcc.get()
);
-}
+xAccImpl = xContext.get();
}
}
}
@@ -1324,7 +1318,7 @@ void
[Libreoffice-bugs] [Bug 157042] Calc crashes when closed
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- Just for the test, could you: - open a term/console - type: export SAL_USE_VCLPLUGIN=gen - try to reproduce the crash ? The goal is to know if it's rendering dependent or not. Also did you get LO 7.6.0.3 from openSUSE's repository or from another way? (I've just read about Tumbleweed being a rolling release version). I mean, when installing a software, there are dependencies to take into account. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91901] Clicking on an image causes Paste toolbar button to loose drop down button
https://bugs.documentfoundation.org/show_bug.cgi?id=91901 --- Comment #5 from Kira Tubo --- Still reproducible with daily master build Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 695ae365dcab7c7dd59b39411299c5c200081885 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157044] Font drop down has Linux Biolinum G selected, while the font being Verdana
https://bugs.documentfoundation.org/show_bug.cgi?id=157044 Julien Nabet changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. Nitpick: indeed at the steps 8 and 9, I see "Linux Biolinum G" selected by default in the list but at step 10 I can't say the new font (I don't have "Verdana" so used "Rubik") is back since it's always the one on the dialog (I mean above the list). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157042] Calc crashes when closed
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 Eric changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157042] Calc crashes when closed
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 Eric changed: What|Removed |Added CC||erben...@comcast.net --- Comment #3 from Eric --- As far as I can tell 7.6 is the latest version - i don't understand you comment on updating. I'll test in safe mode but the issue is intermittent so it may take awhile. I'll try speeding things up by just repeating the opening and closing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115185] Selection is displayed incorrectly after window maximize.
https://bugs.documentfoundation.org/show_bug.cgi?id=115185 --- Comment #7 from Kira Tubo --- Still reproducible in daily master build. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 695ae365dcab7c7dd59b39411299c5c200081885 CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
Re: Question of Gerrit build
Hi Taichi, On Thu, Aug 31, 2023 at 11:55:58PM +0900, taichi <20001...@ymail.ne.jp> wrote: > In Gerrit build, Windows builder configuration is only for x86, isn't there > one for x86_64 or ARM64? That's correct. Your trade-off is to have fast CI feedback vs testing every possible configuration. The current setup is to test on linux (clang+dbgutil+make check and gcc+release+a smaller subset of tests), windows, mac and 2 randomly picked android configs (out of the 4). The jenkins:all label can opt in to have all android configs. The rest is covered by tinderboxes (post-submit): https://ci.libreoffice.org/view/tb%20platform%20status/ There is more there, like wasm and mac vs mac_arm64. Regards, Miklos
[Libreoffice-bugs] [Bug 156638] Export to HTML results in a number of issues
https://bugs.documentfoundation.org/show_bug.cgi?id=156638
Buovjaga changed:
What|Removed |Added
CC||ilmari.lauhakangas@libreoff
||ice.org
--- Comment #3 from Buovjaga ---
You list eight issues while a report should should only be about a single
issue. So separate reports will have to be created. However, some of the listed
issues are already covered by existing reports.
(In reply to robert from comment #0)
> When the attached ODS file is saved in HTML format, there are at least these
> issues:
>
> 1) Excessive bloat
> The resulting HTML file has a size in excess of 10Mb, and part of this is
> caused by
>
> a) Excessive indentation of the generated HTML - there should be a setting
> to manage this, IN THE SAVE-AS DIALOGUE, and not is some obscure settings
> dialogue that your average Tammy, Danny, or Harriet will never look at
Possibly covered by bug 128638.
> b) Inclusion of utterly useless data, in casu the "sdval" and "sdnum"
> attributes. They serve abso-(strong expletive)-ingly no purpose in a html
> document, and in my case the 2057 is quite likely something Windoze
> specific, even worse...
Bug 60071 comment 4 addresses this, but for export this could possibly be
covered by bug 128638.
> c) Lack of additional CSS, even just three selectors, .l, .c, and .r for
> "text-align: left/center/right" would save considerable space, 'class="l"'
> saves three chars over 'align="left"' Setting a default alignment for *all*
> tables would result in (potentially) substantial additional savings.
It is about Writer, but bug 95861 could possibly cover this, if the end result
is a bigger rework of HTML handling.
> 2) Navigation
> a) Given that each sheet ends up in a sequentially numbered table, how hard
> would it be to add backward and forward links to each of them, and an "up"
> link to get back to the index?
Requested in bug 106656.
> b) If the top-row of a sheet is (a) frozen (heading), why not add something
> like
>
> .sticky {
> position: sticky;
> top: 0;
> width: fit-content;
> }
>
> html {
> scroll-padding-top: 3rem;
> }
>
> to it, so that the same effect is achieved in the html
Could not find existing report.
> 3) Why are the html anchor tags in UPPERCASE???
Pretty cosmetic, but could not find existing report.
> 4) How hard would it be to use the name of the ODS file in the tag,
> when the create and modified dates are already used in (what are
> essentially) useless meta tags?
Could not find existing report.
> 5) What the flippin' 'ell are the colgroup tags for? They do not stop some
> cells from flowing into the next row, or let me rephrase that, THEY ACTUALLY
> CAUSE CELLS TO WRAP!
Possibly covered by bug 128638.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106656] Add navigation links to sheets saved as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=106656 Buovjaga changed: What|Removed |Added Summary|Enhancement request for |Add navigation links to |documents saved as Html |sheets saved as HTML |files | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/flycnt.cxx | 18 ++
sw/source/core/text/xmldump.cxx | 18 --
2 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit f81554ef7855d76fbb1708b127c66e29c5d125bd
Author: Miklos Vajna
AuthorDate: Thu Aug 31 20:06:00 2023 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 1 08:09:01 2023 +0200
sw layout xml dump: move at-content fly dumper to flycnt
That's where the rest of the SwFlyAtContentFrame member functions are
defined.
Change-Id: I0215a21c6f3bf41a1e5998b2c5a91864c70f2f93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156355
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/source/core/layout/flycnt.cxx b/sw/source/core/layout/flycnt.cxx
index 113eaafbce9d..5eabc5ccaef2 100644
--- a/sw/source/core/layout/flycnt.cxx
+++ b/sw/source/core/layout/flycnt.cxx
@@ -1732,6 +1732,24 @@ void SwFlyAtContentFrame::DelEmpty()
}
}
+void SwFlyAtContentFrame::dumpAsXmlAttributes(xmlTextWriterPtr pWriter) const
+{
+SwFlyFreeFrame::dumpAsXmlAttributes(pWriter);
+
+if (m_pFollow != nullptr)
+{
+(void)xmlTextWriterWriteAttribute(
+pWriter, BAD_CAST("follow"),
+
BAD_CAST(OString::number(m_pFollow->GetFrame().GetFrameId()).getStr()));
+}
+if (m_pPrecede != nullptr)
+{
+(void)xmlTextWriterWriteAttribute(
+pWriter, BAD_CAST("precede"),
+
BAD_CAST(OString::number(m_pPrecede->GetFrame().GetFrameId()).getStr()));
+}
+}
+
void SwRootFrame::InsertEmptyFly(SwFlyFrame* pDel)
{
if (!mpFlyDestroy)
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 48c893bf403c..e3b333b602a0 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -294,22 +294,4 @@ void SwFont::dumpAsXml(xmlTextWriterPtr writer) const
(void)xmlTextWriterEndElement(writer);
}
-void SwFlyAtContentFrame::dumpAsXmlAttributes(xmlTextWriterPtr pWriter) const
-{
-SwFlyFreeFrame::dumpAsXmlAttributes(pWriter);
-
-if (m_pFollow != nullptr)
-{
-(void)xmlTextWriterWriteAttribute(
-pWriter, BAD_CAST("follow"),
-
BAD_CAST(OString::number(m_pFollow->GetFrame().GetFrameId()).getStr()));
-}
-if (m_pPrecede != nullptr)
-{
-(void)xmlTextWriterWriteAttribute(
-pWriter, BAD_CAST("precede"),
-
BAD_CAST(OString::number(m_pPrecede->GetFrame().GetFrameId()).getStr()));
-}
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: starmath/qa
starmath/qa/cppunit/test_node.cxx | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
New commits:
commit 0feb934fbe3a5deee24cf373922d824ddf5ea7c4
Author: Stephan Bergmann
AuthorDate: Thu Aug 31 16:39:14 2023 +0200
Commit: Stephan Bergmann
CommitDate: Fri Sep 1 08:08:32 2023 +0200
Replace a macro with a function
Such test code should generally be non-DRY, but using a macro rather than a
function here didn't help much in that regard: For a failing test, it just
traded reporting the line of the failing CPPUNIT_ASSERT for reporting the
line
of the failing CHECK_GREEK_SYMBOL call, neither of which by itself gives
sufficient context.
Change-Id: Icce6a68d67d36e8809bf96dcd36ceef6b7b7c9eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156351
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/starmath/qa/cppunit/test_node.cxx
b/starmath/qa/cppunit/test_node.cxx
index af9ff177f38f..acb1c27d4c79 100644
--- a/starmath/qa/cppunit/test_node.cxx
+++ b/starmath/qa/cppunit/test_node.cxx
@@ -36,6 +36,7 @@ public:
private:
void testTdf47813();
+void CHECK_GREEK_SYMBOL(OUString const & text, sal_Unicode code, bool
bItalic);
void testTdf52225();
CPPUNIT_TEST_SUITE(NodeTest);
@@ -92,26 +93,26 @@ void NodeTest::testTdf47813()
CPPUNIT_ASSERT_DOUBLES_EQUAL(1.0, nWidthR/static_cast(nWidthA),
0.03);
}
+void NodeTest::CHECK_GREEK_SYMBOL(OUString const & text, sal_Unicode code,
bool bItalic) {
+mxDocShell->SetText(text);
+const SmTableNode *pTree= mxDocShell->GetFormulaTree();
+CPPUNIT_ASSERT_EQUAL(size_t(1), pTree->GetNumSubNodes());
+const SmNode *pLine = pTree->GetSubNode(0);
+CPPUNIT_ASSERT(pLine);
+CPPUNIT_ASSERT_EQUAL(SmNodeType::Line, pLine->GetType());
+CPPUNIT_ASSERT_EQUAL(size_t(1), pLine->GetNumSubNodes());
+const SmNode *pNode = pLine->GetSubNode(0);
+CPPUNIT_ASSERT(pNode);
+CPPUNIT_ASSERT_EQUAL(SmNodeType::Special, pNode->GetType());
+const SmSpecialNode *pSn = static_cast(pNode);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), pSn->GetText().getLength());
+CPPUNIT_ASSERT_EQUAL(code, pSn->GetText()[0]);
+CPPUNIT_ASSERT_EQUAL(text, pSn->GetToken().aText);
+CPPUNIT_ASSERT_EQUAL(bItalic, IsItalic(pSn->GetFont()));
+}
+
void NodeTest::testTdf52225()
{
-#define CHECK_GREEK_SYMBOL(text, code, bItalic) do {\
-mxDocShell->SetText(text); \
-const SmTableNode *pTree= mxDocShell->GetFormulaTree(); \
-CPPUNIT_ASSERT_EQUAL(size_t(1), pTree->GetNumSubNodes()); \
-const SmNode *pLine = pTree->GetSubNode(0); \
-CPPUNIT_ASSERT(pLine); \
-CPPUNIT_ASSERT_EQUAL(SmNodeType::Line, pLine->GetType()); \
-CPPUNIT_ASSERT_EQUAL(size_t(1), pLine->GetNumSubNodes()); \
-const SmNode *pNode = pLine->GetSubNode(0); \
-CPPUNIT_ASSERT(pNode); \
-CPPUNIT_ASSERT_EQUAL(SmNodeType::Special, pNode->GetType());\
-const SmSpecialNode *pSn = static_cast(pNode); \
-CPPUNIT_ASSERT_EQUAL(sal_Int32(1), pSn->GetText().getLength()); \
-CPPUNIT_ASSERT_EQUAL(code, pSn->GetText()[0]); \
-CPPUNIT_ASSERT_EQUAL(OUString(text), pSn->GetToken().aText);\
-CPPUNIT_ASSERT_EQUAL(bItalic, IsItalic(pSn->GetFont()));\
-} while (false)
-
SmFormat aFormat = mxDocShell->GetFormat();
CPPUNIT_ASSERT_EQUAL(sal_Int16(2), aFormat.GetGreekCharStyle()); //
default format = 2
CHECK_GREEK_SYMBOL("%ALPHA", u'\x0391', false);
[Libreoffice-bugs] [Bug 157025] List presets should include an option with a dash "-"
https://bugs.documentfoundation.org/show_bug.cgi?id=157025 Kira Tubo changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Status|UNCONFIRMED |NEW Keywords||needsUXEval Ever confirmed|0 |1 --- Comment #1 from Kira Tubo --- Since this looks to be an enhancement request, I added needsUXEval to the Keyword and included libreoffice-ux-adv...@lists.freedesktop.org in the CC List. -- You are receiving this mail because: You are the assignee for the bug.
