[Bug 160945] LibreOffice crashes at startup

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160945

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||marc.rol...@outlook.com

--- Comment #16 from Stéphane Guillou (stragu) 
 ---
*** Bug 155865 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155865] EDITING: Crash in vtableCall

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=155865

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #17 from Stéphane Guillou (stragu) 
 ---
Let's consolidate with more recent report bug 160945, which has a backtrace.

*** This bug has been marked as a duplicate of bug 160945 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161194] Opening docx created by MS Word, CROPs to images are lost and images are just scaled in the frame

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161194

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Created attachment 194236
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194236=edit
not reproduced with this DOCX sample that includes a cropped PNG

I tested with this sample file created in MS 365, including a cropped PNG.
Rendered the same in:

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Can you please share a sample file? Did you possibly use an SVG? I think you
might be seeing bug 160571.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160571] FILEOPEN: Cropped SVG in .docx file (from winword) is rendered uncropped in Writer

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160571

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks|103152  |104468

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Ah, the SVG is now shown instead of the PNG fallback. So I guess your commit
made a pre-existing issue visible?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=104468
[Bug 104468] [META] DOCX (OOXML) image-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160571] FILEOPEN: Cropped SVG in .docx file (from winword) is rendered uncropped in Writer

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160571

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|24.2.2.2 release|24.2.0.0 beta1+
  Regression By||Tomaž Vajngerl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||6084
 CC||stephane.guillou@libreoffic
   ||e.org
   Keywords||bibisected, bisected,
   ||regression

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
This is a regression in 24.2.

Reproduced in:

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: d0702a3f17c1fbd1b8ffb9ca0b275943e1a1f442
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Bibisected with linux-64-24.2 repo to first bad build
[18a81415c56f2c4c6dde248db2fb2bc382b247d8] which is:

commit  1db193c6c744289139b1df2af0b8defcf974b238
author  Tomaž Vajngerl  Mon Sep 25 09:03:54 2023 +0200
committer   Tomaž Vajngerl  Wed Dec 06 08:23:34 2023 +0100
tdf#126084 import svg image from ooxml document that use svgBlip elem.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157238

Quikee, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161193] Exporting pdf with bookmarks from headings.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161193

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Have you tried using File > Export as > Export as PDF > General > Structure >
Export outlines?
That option (which should be on by default) controls if the bookmarks are
created.
If they don't show in your PDF reader, try a different one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161195] New: brochure right to left in draw

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161195

Bug ID: 161195
   Summary: brochure right to left in draw
   Product: LibreOffice
   Version: 24.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dz.wb...@gmail.com

i hope that you add the right to left brochure printing option like in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161194] New: Opening docx created by MS Word, CROPs to images are lost and images are just scaled in the frame

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161194

Bug ID: 161194
   Summary: Opening docx created by MS Word, CROPs to images are
lost and images are just scaled in the frame
   Product: LibreOffice
   Version: 24.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nickeggles...@gmail.com

Description:
When opening documents created by MS Word that have cropped (not scaled)
images, in Writer the crops are lost and the images are scaled to the frame
created by the crops. 

Steps to Reproduce:
1. Create a document in MS Word, insert images and crop (not scale) those
images
2. Save the Word document as a docx.
3. Open in Writer and observe the images have lost the crops and are instead
warped by being scaled into the frames created by the crops.

Actual Results:
Images are warped by mis-scaling due to and not properly cropped.  

Expected Results:
Images should be cropped the same as in Word


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 2; OS: Windows 10.0 Build 26100; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139429] To be presentable the Style previews on the 'Tabbed' NB need padding and some additional width, with tooltip for overwide style names

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139429

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Severity|trivial |enhancement
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
Arnab, have you tested a recent version of LO? Szymon's patch in comment 10 has
changed quite a few things.
I agree that tooltips should be added as we will always have cutoff labels.
Maybe this request can focus on that?

(In reply to andreas_k from comment #4)
> right click for edit whould be nice.
That was implemented by Jim for bug 137121, but somewhat broken by Szymon's
patch (tracked in bug 145547 and bug 146314).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146314] UI: Right click a style in the style preview of tabbed bar doesn't select the underlying style first

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146314

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org,
   ||szymon.k...@collabora.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5547
   Keywords||bibisected, bisected,
   ||regression
  Regression By||Szymon Kłos
Version|7.2.4.1 release |7.2.0.4 release

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Used to work when it was implemented by Jim in
f16ab02c98b8d3483f6b6a7f8f10a4e41b545464.

Bibisected with linux-64-7.2 to first bad build
[7802521f69c71eee6a11517ecb0d6c8d8e57a015] which is:

commit fd9b52502de6044a2249ff81407ac579a35ad3a1
author  Szymon Kłos Tue Feb 02 16:12:55 2021 +0100
committer   Szymon Kłos Thu Feb 11 18:50:48 2021 +0100
tdf#139429 Convert Style previews widget to IconView
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110408

Szymon, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145547] [GTK3] can't right-click tabbed UI styles preview

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145547

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||szymon.k...@collabora.com
   Keywords||bibisected, bisected,
   ||regression
Version|7.2.2.2 release |7.2.0.4 release
 Blocks||103182
  Regression By||Szymon Kłos

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Used to work when it was implemented by Jim in
f16ab02c98b8d3483f6b6a7f8f10a4e41b545464.

Bibisected with linux-64-7.2 to first bad build
[7802521f69c71eee6a11517ecb0d6c8d8e57a015] which is:

commit  fd9b52502de6044a2249ff81407ac579a35ad3a1
author  Szymon Kłos Tue Feb 02 16:12:55 2021 +0100
committer   Szymon Kłos Thu Feb 11 18:50:48 2021 +0100
tdf#139429 Convert Style previews widget to IconView
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110408

Szymon, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161162] visual glitch on tabbed user interface

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161162

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEEDINFO|RESOLVED

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Thanks for sharing the screenshot!
This issue is already tracked in bug 146297, so marking as duplicate.

*** This bug has been marked as a duplicate of bug 146297 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146297] NB TABBED: Styles Preview Widget does not implement scaling (visible in qt / kf5)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146297

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||rosswzy...@outlook.com

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
*** Bug 161162 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161193] New: Exporting pdf with bookmarks from headings.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161193

Bug ID: 161193
   Summary: Exporting pdf with bookmarks from headings.
   Product: LibreOffice
   Version: 24.8.0.0 alpha1+ Master
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yapil75...@neixos.com

Description:
Libreoffice Writer was a good software alternative to Word or even OnlyOffice
however, it lacked the feature to export a pdf with bookmarks from headings
which would help when navigating around the pdf I have exported. I usually have
to convert my document to .docx then export that to a pdf to export the pdf
with a bookmarks from heading. It would be great to have this feature to
prevent interoperability and conversion issues when doing this task. Thanks. 

Steps to Reproduce:
1.Create a document 
2. go to file --> export pdf 
3. The settings does not have the feature to export headings as bookmark

Actual Results:
Pdf looks fine with links from table of contents however, does not have a
bookmark. 

Expected Results:
pdf with links from table of contents as well as having a bookmarks from
headings


Reproducible: Always


User Profile Reset: Yes

Additional Info:
pdf with links from table of contents as well as having a bookmarks from
headings

-- 
You are receiving this mail because:
You are the assignee for the bug.

Infra call on Tue, Jun 18 at 16:30 UTC

2024-05-20 Thread Guilhem Moulin
Hi there,

The next infra call will take place at `date -d "Tue, 18 Jun 2024 16:30 UTC"`
(18:30 Berlin time).

We'll meet at https://jitsi.documentfoundation.org/infra and write the minutes
to https://pad.documentfoundation.org/p/infra .  Agenda TBA.

See you there!
Cheers,
-- 
Guilhem.


signature.asc
Description: PGP signature


[Bug 161192] New: EDITING - allow for default change to copy cell content without formatting

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161192

Bug ID: 161192
   Summary: EDITING - allow for default change to copy cell
content without formatting
   Product: LibreOffice
   Version: 7.3 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dle...@web.de

Description:
This is a feature request
Add CALC settings option to switch off formatting changes when copying, cutting
or pasting:

action:
cut out a cell with ctrl+c
paste cell

current result:
formatting is deleted in source cell and added to target cell

result suggested:
formatting remains untouched in both source and target cells

This can currently be achieved with some more complex actions, like context
menu or keyboard shortcuts, but it would save a lot of work and worry, if
copying, deleting and pasting of formatting could be switched off completely in
the settings, with more complex keyboard/contextmenu actions to be used when
wanting to transport the formatting as well. 

Steps to Reproduce:
1.cut out a cell with ctrl+c
2.paste content to other cell


Actual Results:
formatting is deleted in source cell and written to target cell

Expected Results:
no formatting is deleted or written at all


Reproducible: Always


User Profile Reset: No

Additional Info:
Request is for a settings option to toggle current behaviour and
formatting-remains-untouched behaviour for all cut/coopy/paste operation using
ctr+c, ctr+x or ctr+v.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161191] New: Page Numbering Wizard

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161191

Bug ID: 161191
   Summary: Page Numbering Wizard
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: drclementakat...@aol.com

Dear LibreOffice Writer

I have had a problem with Insert Pages since I downloaded your application to
my Laptop. The Insert Page Wizard is not functioning properly. If, for
instance, I click Page numbering in the Insert Menu, the pages are numbered
left and right and even centre. However, if I click Field so as to set Page
Numbers, the numbers duplicate themselves.

Page numbering at the bottom left of text page does not make any diffrence.

Ever since I downloaded LibreOffice, this has been the case. One would have
thought this situation would have been resolved with updates. Numbering Pages
has been one of the failing features on LibreOffice. I actyually went on line
to check and there are so many complaints there too,

I hope you should be able to resolve this issue as qjuickly as possible.

kind regards.



DR CLEMENT AKATENG MD

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161190] LibreOffice Calc crashes if you export a spreadsheet as PDF with "whole sheet export" option enabled.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161190

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m_a_riosv  ---
Not reproducible with
Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Compiling nearly every file now compiles sqlbison.cxx and/or sqlflex.cxx

2024-05-20 Thread Patrick Luby

> On May 20, 2024, at 1:52 PM, Noel Grandin  wrote:
> 
> 
> So I saw the same thing on my ARM macbook, and I chased it for a while, 
> resetting/clearing ccache, rebooting, etc, but it just kept coming back, so I 
> gave up and updated to a newer version of ccache for my mac, which seems to 
> have fixed it (and as a bonus, is much newer and supports nice compression, 
> saving me disk space, etc)
> 
> Patch to update LODE here:
>https://gerrit.libreoffice.org/c/lode/+/167874
> 
> you will need to re-run LODE setup after applying that patch.
> 

Thanks Noel! Your LODE patch stopped the warnings in two clean builds (but no 
ccache clearing) for me.

Earlier today, like you I had found that if you interrupt the build after some 
point and run ccache -C, the warnings stop. But the problem would reappear 
after a make distclean or the next time some unknown code is recompiled (maybe 
in connectivity?).

Patrick



[Bug 161187] Error when reviewing documents

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161187

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from raal  ---

Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161188] debug build crash with Tools > Customize > Category Macro

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161188

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Created attachment 194231
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194231=edit
Screenshot

Not for me with
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: e3bd3c7e3178dc091fd002628f052666b4db3be6
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render:
Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161190] LibreOffice Calc crashes if you export a spreadsheet as PDF with "whole sheet export" option enabled.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161190

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161189] EDITING: Comment of target cell cell does not disappear when source cell has no comment

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161189

raal  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de
   Keywords||bibisected, bisected
  Regression By||Andreas Heinisch

--- Comment #2 from raal  ---
This seems to have begun at the below commit in bibisect repository/OS
linux-64-7.6.
Adding Cc: to Andreas Heinisch ; Could you possibly take a look at this one?
Thanks

ca3d029dd18bba9118dce4bd591721002b7b4a4e is the first bad commit
commit ca3d029dd18bba9118dce4bd591721002b7b4a4e
Author: Jenkins Build User 
Date:   Sun Oct 29 06:16:11 2023 +0100

source sha:535f8fde0c33c435e4a8e9f768003516ce933666

151759: tdf#141440 - Do not delete notes when pasting contents |
https://gerrit.libreoffice.org/c/core/+/151759

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161189] EDITING: Comment of target cell cell does not disappear when source cell has no comment

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161189

raal  changed:

   What|Removed |Added

   Keywords||regression
 OS|Windows (All)   |All
 Blocks||101216
 CC||r...@post.cz
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from raal  ---
Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

Work in 7.3.3


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 135645] LO corrupts bitmaps and crashes in X11 with 16 bit color (TrueColor)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135645

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #9 from raal  ---
Would now be nice to get a bibisect of the bug -
https://wiki.documentfoundation.org/QA/HowToBibisect
Please could you do it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - ucb/source

2024-05-20 Thread Thorsten Behrens (via logerrit)
 ucb/source/ucp/webdav-curl/CurlSession.cxx |9 -
 1 file changed, 9 deletions(-)

New commits:
commit 2cb47c0acae68bb1b7f7aa5ffa9e63fd39b748be
Author: Thorsten Behrens 
AuthorDate: Thu May 16 17:52:41 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Mon May 20 23:07:52 2024 +0200

backport curl_easy_setopt changes

This reverts commit d95ac1c608caba9cabaa503f1a5589285547aed5.

Change-Id: I4bc104272d4c41efab1a7e5eae78267675c1b32b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167753
Tested-by: Jenkins
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167805
Reviewed-by: Caolán McNamara 

diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx 
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 2f104d5388d7..bfd0825d8cff 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -15,7 +15,6 @@
 #include "webdavresponseparser.hxx"
 
 #include 
-#include 
 #include 
 #include 
 
@@ -689,14 +688,6 @@ 
CurlSession::CurlSession(uno::Reference xContext,
 rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_FORBID_REUSE, 1L);
 assert(rc == CURLE_OK);
 }
-// If WOPI-like host has self-signed certificate, it's not possible to 
insert images
-// to the document, so here is a compromise. The user has already accepted 
the self
-// signed certificate in the browser, when we get here.
-if (comphelper::LibreOfficeKit::isActive())
-{
-rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_SSL_VERIFYPEER, 0L);
-assert(rc == CURLE_OK);
-}
 }
 
 CurlSession::~CurlSession() {}


core.git: helpcontent2

2024-05-20 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ae798781ef4df7a1fdef13af0bc459bf4f6e7b4c
Author: Olivier Hallot 
AuthorDate: Mon May 20 17:25:55 2024 -0300
Commit: Gerrit Code Review 
CommitDate: Mon May 20 22:25:55 2024 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 2662257ca9594a0c5fc1371c8e397f562c726f8c
  - tdf#159872 UNIQUE function help page

- Attempt to address issues raised by Regina.

Change-Id: I85892d15a5bf8bb798f733cd4fddc309e5906894
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167755
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index cbb8c2d8d957..2662257ca959 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit cbb8c2d8d957f8a4729b32ac098c8a88f72d797a
+Subproject commit 2662257ca9594a0c5fc1371c8e397f562c726f8c


help.git: source/text

2024-05-20 Thread Olivier Hallot (via logerrit)
 source/text/scalc/01/04060101.xhp|7 +++---
 source/text/scalc/01/func_unique.xhp |   37 +--
 2 files changed, 39 insertions(+), 5 deletions(-)

New commits:
commit 2662257ca9594a0c5fc1371c8e397f562c726f8c
Author: Olivier Hallot 
AuthorDate: Thu May 16 17:07:52 2024 -0300
Commit: Olivier Hallot 
CommitDate: Mon May 20 22:25:55 2024 +0200

tdf#159872 UNIQUE function help page

- Attempt to address issues raised by Regina.

Change-Id: I85892d15a5bf8bb798f733cd4fddc309e5906894
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167755
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/source/text/scalc/01/04060101.xhp 
b/source/text/scalc/01/04060101.xhp
index bd0864fb72..d68e5ec716 100644
--- a/source/text/scalc/01/04060101.xhp
+++ b/source/text/scalc/01/04060101.xhp
@@ -104,8 +104,8 @@
 
 Examples of Database Function Use
 The following table 
provides an example database table that is utilized to demonstrate how to use 
the functions in the Database category. The cell range A1:E10 contains 
fictitious information about the guests invited to Joe's birthday party. The 
following information is given for each guest - name, school grade, age in 
years, distance to school in meters, and weight in kilograms.
-
-
+
+
 
 
 
@@ -339,7 +339,8 @@
 
 
 
-
+
+
 
 The following 
six examples use the database table above, combined with different search 
criteria areas.
 
diff --git a/source/text/scalc/01/func_unique.xhp 
b/source/text/scalc/01/func_unique.xhp
index 0d7025e841..8c709cfb44 100644
--- a/source/text/scalc/01/func_unique.xhp
+++ b/source/text/scalc/01/func_unique.xhp
@@ -22,11 +22,44 @@
 
 
 UNIQUE
-(...)
+Returns the array 
of unique values from a range or array of values.
 
+
+The UNIQUE function is always case sensitive, 
independent from the setting of Case sensitive checkbox in 
%PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME Calc - 
Calculate.
+
 
-UNIQUE(...)
+UNIQUE(Array, [By col], 
[Uniqueness])
+Array: the 
range or array from which to return unique values.
+By col: 
(optional) a logical value that indicates how to compare data: TRUE - compares 
data horizontally for a match of all cells in each column, across all columns. 
FALSE or omitted (default) - compares data vertically, for a match of all cells 
of each row, across all rows.
+
+Uniqueness: (optional) A logical value 
that defines which values are considered unique. TRUE returns values that occur 
only once. The default is FALSE or omitted, which returns all distinct values 
in the range or array.
+The UNIQUE function must be entered as an 
array 
formula.
 
+Given the data table 
below, the examples returns unique occurrences of grades and age.
+
+Example 1
+{=UNIQUE(B1:C10,FALSE(),FALSE())} 
returns the array below. The grades and ages of the rows with name Andy and 
Harry are returned only once. The same for rows with name Eva and 
Irene.
+
+GradeAge
+39
+410
+310
+511
+28
+27
+17
+
+Example 2
+{=UNIQUE(B1:C10,FALSE(),TRUE())}, 
with Uniqueness as TRUE. Returns the array below with the rows of 
Andy, Harry, Eva and Irene omitted because their combined grades and ages are 
not unique.
+
+GradeAge
+410
+310
+511
+27
+17
+
+
 
 
 


core.git: comphelper/source cpputools/source docmodel/source eventattacher/source i18nlangtag/qa i18nlangtag/source i18npool/qa i18nutil/source include/docmodel include/systools o3tl/qa opencl/source

2024-05-20 Thread Noel Grandin (via logerrit)
 UnoControls/source/controls/OConnectionPointHelper.cxx   |8 
 UnoControls/source/controls/framecontrol.cxx |   10 
 UnoControls/source/controls/statusindicator.cxx  |2 
 comphelper/source/property/propertysethelper.cxx |2 
 cpputools/source/unoexe/unoexe.cxx   |   20 
 docmodel/source/theme/Theme.cxx  |   12 
 eventattacher/source/eventattacher.cxx   |4 
 i18nlangtag/qa/cppunit/test_languagetag.cxx  |  678 +++
 i18nlangtag/source/languagetag/languagetag.cxx   |   20 
 i18npool/qa/cppunit/test_breakiterator.cxx   |8 
 i18nutil/source/utility/unicode.cxx  |2 
 include/docmodel/theme/Theme.hxx |2 
 include/systools/curlinit.hxx|2 
 include/systools/opensslinit.hxx |2 
 o3tl/qa/test-sorted_vector.cxx   |   20 
 o3tl/qa/test-string_view.cxx |   16 
 opencl/source/openclconfig.cxx   |   10 
 opencl/source/openclwrapper.cxx  |2 
 postprocess/qa/services.cxx  |   10 
 registry/source/regkey.cxx   |   18 
 remotebridges/source/unourl_resolver/unourl_resolver.cxx |6 
 scaddins/source/analysis/analysis.cxx|2 
 scaddins/source/analysis/analysishelper.cxx  |2 
 scaddins/source/datefunc/datefunc.cxx|2 
 smoketest/smoketest.cxx  |8 
 store/qa/store.cxx   |8 
 testtools/source/bridgetest/bridgetest.cxx   |   22 
 testtools/source/bridgetest/constructors.cxx |8 
 testtools/source/bridgetest/cppobj.cxx   |   20 
 testtools/source/bridgetest/multi.cxx|   42 
 unodevtools/source/skeletonmaker/cppcompskeleton.cxx |   26 
 unodevtools/source/skeletonmaker/javacompskeleton.cxx|   12 
 unodevtools/source/skeletonmaker/skeletoncommon.cxx  |   24 
 unotest/source/cpp/macros_test.cxx   |6 
 unotest/source/cpp/officeconnection.cxx  |   12 
 vcl/qa/cppunit/svm/svmtest.cxx   |   98 +-
 xmlreader/source/span.cxx|2 
 37 files changed, 573 insertions(+), 575 deletions(-)

New commits:
commit d573e2ae17d2ff589ec7adc0dddf6a78db4cc93a
Author: Noel Grandin 
AuthorDate: Mon May 20 09:34:37 2024 +0200
Commit: Noel Grandin 
CommitDate: Mon May 20 22:09:56 2024 +0200

loplugin:ostr in various

Change-Id: I9f399b3752da9df930e0647536ffcd4e82beb1ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167856
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/UnoControls/source/controls/OConnectionPointHelper.cxx 
b/UnoControls/source/controls/OConnectionPointHelper.cxx
index b17edc2ba3da..26b04a6cc9af 100644
--- a/UnoControls/source/controls/OConnectionPointHelper.cxx
+++ b/UnoControls/source/controls/OConnectionPointHelper.cxx
@@ -101,7 +101,7 @@ Type SAL_CALL OConnectionPointHelper::getConnectionType()
 // Set default return value, if method failed.
 if ( !impl_LockContainer() )
 {
-throw RuntimeException("Container does not exist!");
+throw RuntimeException(u"Container does not exist!"_ustr);
 }
 
 // If container reference valid, return right type of supported interfaces 
of THIS connectionpoint.
@@ -144,7 +144,7 @@ void SAL_CALL OConnectionPointHelper::advise( const 
Reference< XInterface >& xLi
 // Operation is permitted only, if reference to container is valid!
 if ( !impl_LockContainer() )
 {
-throw RuntimeException("Container does not exist!");
+throw RuntimeException(u"Container does not exist!"_ustr);
 }
 // Forward it to OConnectionPointHelperContainer!
 m_pContainerImplementation->advise( m_aInterfaceType, xListener );
@@ -161,7 +161,7 @@ void SAL_CALL OConnectionPointHelper::unadvise( const 
Reference< XInterface >& x
 // Operation is permitted only, if reference to container is valid!
 if ( !impl_LockContainer() )
 {
-throw RuntimeException("Container does not exist!");
+throw RuntimeException(u"Container does not exist!"_ustr);
 
 }
 // Forward it to OConnectionPointHelperContainer!
@@ -179,7 +179,7 @@ Sequence< Reference< XInterface > > SAL_CALL 
OConnectionPointHelper::getConnecti
 // Operation is permitted only, if reference to container is valid!
 if ( !impl_LockContainer() )
 {
-throw RuntimeException("Container does not exist!");
+throw RuntimeException(u"Container does not exist!"_ustr);
 }
 // Set default return value, if method failed.
 Sequence< Reference< XInterface > > seqReturnConnections;
diff --git 

[Bug 161190] New: LibreOffice Calc crashes if you export a spreadsheet as PDF with "whole sheet export" option enabled.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161190

Bug ID: 161190
   Summary: LibreOffice Calc crashes if you export a spreadsheet
as PDF with  "whole sheet export" option enabled.
   Product: LibreOffice
   Version: 24.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marcouriel.r...@gmail.com

Description:
FILESAVE: When you try to export any spreadsheet in Calc as PDF with "whole
sheet export" box checked, LibreOffice crashes. It only happens with this
option enabled, if it's exported without it, it works normally. Currently
running the flatpak version.

Steps to Reproduce:
1. Create any document in LibreOffice Calc.
2. Click on 'File' tab and 'Export as PDF'.
3. Select the 'Whole sheet export' option.
4. Export the document.

Actual Results:
A dialog about LibreOffice crash appears.

Expected Results:
Export the spreadsheet as PDF in the selected location.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 24.2.3.2 (X86_64)
Build ID: 420(Build:2)
CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Flatpak version
Fedora Linux 40

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - formula/source

2024-05-20 Thread Jaume Pujantell (via logerrit)
 formula/source/core/api/FormulaCompiler.cxx |   61 +---
 1 file changed, 46 insertions(+), 15 deletions(-)

New commits:
commit 421ef056cf5e991ae3072cd1acb5ef23aa7c780a
Author: Jaume Pujantell 
AuthorDate: Mon May 20 16:50:34 2024 +0200
Commit: Jaume Pujantell 
CommitDate: Mon May 20 20:23:53 2024 +0200

lok: translate formula bar functions to each locale

On calc the native formula symbols were loaded once on start-up and
assumed to not change.

This adds a map language to symbols when LOK is active and chooses
the correct set of symbols on each call.

Change-Id: I821fb3ad4a06d764399e3fdf4a2ec628909312db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167870
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jaume Pujantell 

diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index 278628cbd648..3656c65def1e 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -965,28 +966,58 @@ FormulaCompiler::OpCodeMapPtr 
FormulaCompiler::CreateOpCodeMap(
 static bool lcl_fillNativeSymbols( FormulaCompiler::NonConstOpCodeMapPtr& 
xMap, FormulaCompiler::InitSymbols eWhat = FormulaCompiler::InitSymbols::INIT )
 {
 static OpCodeMapData aSymbolMap;
+static std::map aLocaleSymbolMap;
 std::unique_lock aGuard(aSymbolMap.maMtx);
 
-if (eWhat == FormulaCompiler::InitSymbols::ASK)
+if (comphelper::LibreOfficeKit::isActive())
 {
-return bool(aSymbolMap.mxSymbolMap);
-}
-else if (eWhat == FormulaCompiler::InitSymbols::DESTROY)
-{
-aSymbolMap.mxSymbolMap.reset();
+OUString langauge = 
comphelper::LibreOfficeKit::getLanguageTag().getLanguage();
+if (eWhat == FormulaCompiler::InitSymbols::ASK)
+{
+return aLocaleSymbolMap.contains(langauge)
+   && bool(aLocaleSymbolMap[langauge].mxSymbolMap);
+}
+else if (eWhat == FormulaCompiler::InitSymbols::DESTROY)
+{
+aLocaleSymbolMap[langauge].mxSymbolMap.reset();
+}
+else if (!aLocaleSymbolMap[langauge].mxSymbolMap)
+{
+// Core
+aLocaleSymbolMap[langauge].mxSymbolMap = 
std::make_shared(
+SC_OPCODE_LAST_OPCODE_ID + 1, true, 
FormulaGrammar::GRAM_NATIVE_UI);
+OpCodeList aOpCodeListSymbols(RID_STRLIST_FUNCTION_NAMES_SYMBOLS,
+  
aLocaleSymbolMap[langauge].mxSymbolMap);
+OpCodeList aOpCodeListNative(RID_STRLIST_FUNCTION_NAMES,
+ 
aLocaleSymbolMap[langauge].mxSymbolMap);
+// No AddInMap for native core mapping.
+}
+
+xMap = aLocaleSymbolMap[langauge].mxSymbolMap;
 }
-else if (!aSymbolMap.mxSymbolMap)
+else
 {
-// Core
-aSymbolMap.mxSymbolMap =
-std::make_shared(
+if (eWhat == FormulaCompiler::InitSymbols::ASK)
+{
+return bool(aSymbolMap.mxSymbolMap);
+}
+else if (eWhat == FormulaCompiler::InitSymbols::DESTROY)
+{
+aSymbolMap.mxSymbolMap.reset();
+}
+else if (!aSymbolMap.mxSymbolMap)
+{
+// Core
+aSymbolMap.mxSymbolMap = 
std::make_shared(
 SC_OPCODE_LAST_OPCODE_ID + 1, true, 
FormulaGrammar::GRAM_NATIVE_UI);
-OpCodeList aOpCodeListSymbols(RID_STRLIST_FUNCTION_NAMES_SYMBOLS, 
aSymbolMap.mxSymbolMap);
-OpCodeList aOpCodeListNative(RID_STRLIST_FUNCTION_NAMES, 
aSymbolMap.mxSymbolMap);
-// No AddInMap for native core mapping.
-}
+OpCodeList aOpCodeListSymbols(RID_STRLIST_FUNCTION_NAMES_SYMBOLS,
+  aSymbolMap.mxSymbolMap);
+OpCodeList aOpCodeListNative(RID_STRLIST_FUNCTION_NAMES, 
aSymbolMap.mxSymbolMap);
+// No AddInMap for native core mapping.
+}
 
-xMap = aSymbolMap.mxSymbolMap;
+xMap = aSymbolMap.mxSymbolMap;
+}
 
 return true;
 }


Re: Compiling nearly every file now compiles sqlbison.cxx and/or sqlflex.cxx

2024-05-20 Thread Noel Grandin
So I saw the same thing on my ARM macbook, and I chased it for a while,
resetting/clearing ccache, rebooting, etc, but it just kept coming back, so
I gave up and updated to a newer version of ccache for my mac, which seems
to have fixed it (and as a bonus, is much newer and supports nice
compression, saving me disk space, etc)

Patch to update LODE here:
   https://gerrit.libreoffice.org/c/lode/+/167874

you will need to re-run LODE setup after applying that patch.


[Bug 159592] Permanent items in styles dropdown have irregular formatting

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159592

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||108346


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108346
[Bug 108346] [META] Writer paragraph style combobox control bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160199] FORMATTING Making text size inside Comments in LibreOffice Calc permanently changeable (Issue opening xlsx files)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160199

BogdanB  changed:

   What|Removed |Added

 Blocks||127172
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127172
[Bug 127172] [META] XLSX (OOXML) Comments related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160420] Editing table trashes table formatting

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160420

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||113208, 103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=113208
[Bug 113208] [META] Table AutoFormat bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160649] Calc scrolling in the calc main window is disabled while the "Manage Conditional Formatting" dialog is opened

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160649

BogdanB  changed:

   What|Removed |Added

 Blocks||102019
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160900] Inconsistency in Retaining Automatic Line Break Setting in LibreOffice Calc (xlsx Format)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160900

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||87740


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87740
[Bug 87740] [META] Anchor and text wrapping bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161160] Indent increase multiple cells not formatting correctly when Aligned right in box

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161160

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||108252


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108252
[Bug 108252] [META] Cell-related bugs and enhancements (including formatting)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160896] Allow referencing Column & Row with Base 1 instead of 0 in Basic

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160896

--- Comment #4 from NOYB  ---
(In reply to Stéphane Guillou (stragu) from comment #3)
> I think adding complexity to it with more options is not desirable. This is
> a scripting/programming language, and can be expected to count zero-based.
> "Won't fix" for me too.

In fact reduces complexity for the coder/users.  Zero base is inconsistent with
spreadsheet columns & rows labeling and corresponding functions that are 1
(one) based.   Nothing changes unless the coder intentionally sets the option.

A scripting/programing language can be expected to have options to facilitate
humans.  That's purpose of scripting/programming languages.

A one base option is much better, clearer and human friendlier than having to
add 1 to zero based column & row indexes.  Especially when there is a 1 (one)
based array option.  Add the same type of option for columns & rows indexes and
eliminate the here we add 1 and here we don't.  That is complexity for the
coder/users.

If you you or anyone doesn't what to use the option.  You don't have to.  Won't
affect you one bit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

core.git: 2 commits - sw/inc sw/source

2024-05-20 Thread Noel Grandin (via logerrit)
 sw/inc/unocoll.hxx   |3 ++-
 sw/source/core/inc/frame.hxx |3 ++-
 sw/source/core/layout/wsfrm.cxx  |6 +++---
 sw/source/core/unocore/unocoll.cxx   |2 +-
 sw/source/core/unocore/unoredline.cxx|3 ++-
 sw/source/core/unocore/unotext.cxx   |   11 ---
 sw/source/filter/ww8/docxtableexport.cxx |4 ++--
 7 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit 41c04ceb3b1b14c3c99ede86524df8f3de4f5daa
Author: Noel Grandin 
AuthorDate: Mon May 20 12:55:15 2024 +0200
Commit: Noel Grandin 
CommitDate: Mon May 20 19:14:14 2024 +0200

use more concrete UNO types in sw

Change-Id: I3cf017e74e7cc9902486d6dba1d89f70c47c978a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167864
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/unocoll.hxx b/sw/inc/unocoll.hxx
index 6254801bf8a7..0ecca6fb45c2 100644
--- a/sw/inc/unocoll.hxx
+++ b/sw/inc/unocoll.hxx
@@ -40,6 +40,7 @@ class SwSectionFormat;
 struct SvEventDescription;
 class SwXFootnote;
 class SwXTextSection;
+class SwXTextTable;
 
 const SvEventDescription* sw_GetSupportedMacroItems();
 
@@ -287,7 +288,7 @@ public:
 virtual sal_Bool SAL_CALL supportsService(const OUString& ServiceName) 
override;
 virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() 
override;
 
-SW_DLLPUBLIC static css::uno::Reference 
GetObject(SwFrameFormat& rFormat);
+SW_DLLPUBLIC static rtl::Reference GetObject(SwFrameFormat& 
rFormat);
 };
 
 typedef
diff --git a/sw/source/core/unocore/unocoll.cxx 
b/sw/source/core/unocore/unocoll.cxx
index 24016c53350f..e00fa835f16a 100644
--- a/sw/source/core/unocore/unocoll.cxx
+++ b/sw/source/core/unocore/unocoll.cxx
@@ -973,7 +973,7 @@ uno::Sequence< OUString > 
SwXTextTables::getSupportedServiceNames()
 return { u"com.sun.star.text.TextTables"_ustr };
 }
 
-uno::Reference SwXTextTables::GetObject(SwFrameFormat& 
rFormat)
+rtl::Reference SwXTextTables::GetObject(SwFrameFormat& rFormat)
 {
 return SwXTextTable::CreateXTextTable(& rFormat);
 }
diff --git a/sw/source/core/unocore/unoredline.cxx 
b/sw/source/core/unocore/unoredline.cxx
index 27fd9aa7f555..b97cc20028b2 100644
--- a/sw/source/core/unocore/unoredline.cxx
+++ b/sw/source/core/unocore/unoredline.cxx
@@ -42,6 +42,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -422,7 +423,7 @@ uno::Any SwXRedline::getPropertyValue( const OUString& 
rPropertyName )
 OSL_ENSURE(pTableNode, "No table node!");
 SwTable& rTable = pTableNode->GetTable();
 SwFrameFormat* pTableFormat = rTable.GetFrameFormat();
-xRet = SwXTextTables::GetObject( *pTableFormat );
+xRet = cppu::getXWeak(SwXTextTables::GetObject( *pTableFormat 
).get());
 }
 break;
 case SwNodeType::Text :
diff --git a/sw/source/core/unocore/unotext.cxx 
b/sw/source/core/unocore/unotext.cxx
index 730e24ca6718..50d9f75db63f 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -2214,9 +2214,8 @@ SwXText::convertToTable(
 if (!pTable)
 return uno::Reference< text::XTextTable >();
 
-uno::Reference const xRet =
+rtl::Reference const xRet =
 SwXTextTable::CreateXTextTable(pTable->GetFrameFormat());
-uno::Reference const xPrSet(xRet, uno::UNO_QUERY);
 // set properties to the table
 // catch lang::WrappedTargetException and lang::IndexOutOfBoundsException
 try
@@ -2254,7 +2253,7 @@ SwXText::convertToTable(
 };
 if (std::find(vDenylist.begin(), vDenylist.end(), 
rTableProperty.Name) == vDenylist.end())
 {
-xPrSet->setPropertyValue(rTableProperty.Name, 
rTableProperty.Value);
+xRet->setPropertyValue(rTableProperty.Name, 
rTableProperty.Value);
 }
 }
 catch (const uno::Exception&)
@@ -2270,7 +2269,6 @@ SwXText::convertToTable(
 for(sal_Int32 nCnt = 0; nCnt < nLast; ++nCnt)
 lcl_ApplyRowProperties(rRowProperties[nCnt], 
xRows->getByIndex(nCnt), aRowSeparators[nCnt]);
 
-uno::Reference const xCR(xRet, 
uno::UNO_QUERY_THROW);
 //apply cell properties
 sal_Int32 nRow = 0;
 for(const auto& rCellPropertiesForRow : rCellProperties)
@@ -2280,7 +2278,7 @@ SwXText::convertToTable(
 {
 lcl_ApplyCellProperties(lcl_GetLeftPos(nCell, 
aRowSeparators[nRow]),
 rCellProps,
-xCR->getCellByPosition(nCell, nRow),
+xRet->getCellByPosition(nCell, nRow),
 aMergedCells);
 ++nCell;
 }
@@ -2299,8 +2297,7 @@ SwXText::convertToTable(
 }
 
 assert(SwTable::FindTable(pTable->GetFrameFormat()) == pTable);
-assert(pTable->GetFrameFormat() ==
-  

[Bug 147286] ‘Default Paragraph Style’ should be renamed ‘Basic’

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147286

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||107833


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107833
[Bug 107833] [META] Writer paragraph style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159705] Incorrect paragraph spacing when page gaps are collapsed

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159705

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||113545

--- Comment #3 from BogdanB  ---
I remember some similar bug was solved in the last 2–3 months, but I don't
remember exactly the bug number, and I can not find it right now.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113545
[Bug 113545] [META] Paragraph spacing above and below and related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160939] table of authorities missing in writer

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160939

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
   Keywords||needsUXEval

--- Comment #3 from Dieter  ---
(In reply to Stéphane Guillou (stragu) from comment #2)
> This is the process for marking citations and creating a table of
> authorities in MSO:
> https://support.microsoft.com/en-us/office/create-a-table-of-authorities-
> ddd126ae-52bc-4299-9558-06dd0e4fe8c0

So first step would be to provide option for table of authorities entries.
cc: Design-Team

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161189] New: EDITING: Comment of target cell cell does not disappeare when source cell has no comment

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161189

Bug ID: 161189
   Summary: EDITING: Comment of target cell cell does not
disappeare when source cell has no comment
   Product: LibreOffice
   Version: 7.6.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rg...@yahoo.de

When a source cell without comment is copied whith Ctrl-C and pasted to a
target cell with Ctrl-V, an existing comment of the target cell does not
disappear although it should. Function Edit/Insert Contents/Insert
Contents/ALL=Yes shows same fault.
This wrong behaviour was seen since version 7.6.
actual System: Windows 10 x64, LibreOffice 24.2.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159549] FORMATTING LO Writer 7.6 and 24.2 alter settings of Text Body paragraph style when renaming style as Body Text

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159549

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||107833


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107833
[Bug 107833] [META] Writer paragraph style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160238] FORMATTING - "Paragraph style" - "Text Flow" - "Breaks": incorrect "Page number"

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160238

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 OS|Windows (All)   |All
 Blocks||108746, 107831


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107831
[Bug 107831] [META] Paragraph-level bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108746
[Bug 108746] [META] Page number field bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160406] Difference between LibreOffice and OpenOffice in paragraph line-spacing in RTL docs

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160406

BogdanB  changed:

   What|Removed |Added

 Blocks||109235, 43808
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=109235
[Bug 109235] [META] Paragraph line spacing bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 150276] Paragraph mark in rotated-character paragraph placed in middle of text

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150276

BogdanB  changed:

   What|Removed |Added

 Blocks||107831
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107831
[Bug 107831] [META] Paragraph-level bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160581] A paragraph with a large as-character object may overlap with following paragraphs

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160581

BogdanB  changed:

   What|Removed |Added

 Blocks||107831, 87740
 CC||buzea.bog...@libreoffice.or
   ||g


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87740
[Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107831
[Bug 107831] [META] Paragraph-level bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sd/source

2024-05-20 Thread Hubert Figuière (via logerrit)
 sd/source/ui/view/drviews5.cxx |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 41130a39ad68310a0136605cbced1f191396c456
Author: Hubert Figuière 
AuthorDate: Mon May 20 11:15:35 2024 -0400
Commit: Caolán McNamara 
CommitDate: Mon May 20 18:36:02 2024 +0200

cool#9019: draw/impress: disable the Grid for now

So that the grid isn't shown in the thumbnail.
This will need to be reverted later for cool#7406

Change-Id: I01fbc7ebc9e33a27fb866b7ea6dbaaac68ae8f9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167872
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/view/drviews5.cxx b/sd/source/ui/view/drviews5.cxx
index 8583ecc182c7..fa744fe49bcd 100644
--- a/sd/source/ui/view/drviews5.cxx
+++ b/sd/source/ui/view/drviews5.cxx
@@ -315,7 +315,15 @@ void DrawViewShell::WriteFrameViewData()
 mpFrameView->SetGridCoarse( mpDrawView->GetGridCoarse() );
 mpFrameView->SetGridFine( mpDrawView->GetGridFine() );
 mpFrameView->SetSnapGridWidth(mpDrawView->GetSnapGridWidthX(), 
mpDrawView->GetSnapGridWidthY());
-mpFrameView->SetGridVisible( mpDrawView->IsGridVisible() );
+
+// In LOK, Grid isn't implemented, and it appears in the slide thumbnails
+// Remove this when Grid is implemented and/or thumbnails are fixed to no 
longer
+// show the grid.
+if (comphelper::LibreOfficeKit::isActive())
+mpFrameView->SetGridVisible( false );
+else
+mpFrameView->SetGridVisible( mpDrawView->IsGridVisible() );
+
 mpFrameView->SetGridFront( mpDrawView->IsGridFront() );
 mpFrameView->SetSnapAngle( mpDrawView->GetSnapAngle() );
 mpFrameView->SetGridSnap( mpDrawView->IsGridSnap() );


[Bug 151701] Enable acceptance of the suggestion when entering formulas also with Tab (Tabulator) key

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151701

--- Comment #4 from Jürgen Kirsten  ---
Unfortunately, this extension of the functionality for the transfer when
entering functions has still not been implemented.

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Today I realised that the EXCEL web version now also accepts both keys. You can
also use TAB or ENTER to transfer the function there. 

Only in CALC only the ENTER key is accepted. That is a pity.

If this is a simple hack, it could be implemented in the short term.

Kind regards 

Jürgen

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139546] Calc Sort Dialogue Options: Language Sort Options are not visible when you use your default language

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139546

--- Comment #5 from Jürgen Kirsten  ---
The bug still occurs in the latest LO version.

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160936] Draw freezes after save until forced context switch or timeout.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160936

--- Comment #2 from Alex Thurgood  ---
@Stephane: I'll have a chance to try with 24.2 this week as I've got some more
patent drawings to prepare. I have a sneaky suspicion that it is specifically a
macos problem though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161183] Forced restart of windows cumputer due to installation of LibreOffice

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161183

--- Comment #9 from Mike Kaganski  ---
(In reply to V Stuart Foote from comment #8)
> As noted it may be possible, but not a priority, to modify the LibreOffice
> installer with custom actions to halt/unload any in use LO libraries to
> avoid the "resource in use" errors that trigger the restart manager dialogs.

I'm unsure what you refer to. The Restart Manager is *intended* to do exactly
that: in case when the system sees that a file is locked by a process, it tries
to unload that process. If the system component fails that, there is no way
LibreOffice would do something bigger to halt random processes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: desktop/source

2024-05-20 Thread Mike Kaganski (via logerrit)
 desktop/source/deployment/manager/dp_manager.cxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 9851311055da1a050405f7bc0b7e12ad7cff3cbe
Author: Mike Kaganski 
AuthorDate: Mon May 20 16:00:39 2024 +0200
Commit: Mike Kaganski 
CommitDate: Mon May 20 17:31:19 2024 +0200

Drop remnants of a long-obsolete hack

In commits 6dd5a96e1e3a6bb307f8f2d43cce2b5f2cde659d
(INTEGRATION: CWS unopkg1 (1.1.2); FILE ADDED, 2004-04-14),
19a10039a59002b68291e7f200f85fd962592d75 (INTEGRATION: CWS
unopkg2 (1.2.4); FILE MERGED, 2004-06-11), and
886715b6b6f30fed36d50a4ddf84ed5984f4f993 (INTEGRATION: CWS
scriptingf7 (1.3.4); FILE MERGED, 2004-07-23), a hack was
introduced to allow empty substorages.

Later, in commits 0d6b24a721f05fedef9cd32b596a0fec71a5089f
(INTEGRATION: CWS tdoc3 (1.7.24); FILE MERGED, 2004-11-09)
and 5f4d17724f7323077191114486edff8cdce05b2f (INTEGRATION:
CWS scriptingf9 (1.6.2); FILE MERGED, 2004-12-23), that
hack was removed, but one place was kept, which is removed
now.

Change-Id: Iaaf46421ddbe942878ebe17ca1e585be9db5999d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167823
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/desktop/source/deployment/manager/dp_manager.cxx 
b/desktop/source/deployment/manager/dp_manager.cxx
index c2c8c621df1f..574470068da1 100644
--- a/desktop/source/deployment/manager/dp_manager.cxx
+++ b/desktop/source/deployment/manager/dp_manager.cxx
@@ -130,9 +130,6 @@ void PackageManagerImpl::initActivationLayer(
 {
 Reference xRow( xResultSet, UNO_QUERY_THROW );
 OUString title( xRow->getString( 1 /* Title */ ) );
-// xxx todo: remove workaround for tdoc
-if ( title == 
"this_is_a_dummy_stream_just_there_as_a_workaround_for_a_temporary_limitation_of_the_storage_api_implementation"
 )
-continue;
 if ( title == "META-INF" )
 continue;
 


[Bug 161163] Crash when opening/creating a brand new file on Base (gtk3 only)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161163

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Caolán McNamara  ---
yeah, that sounds like the
https://bugs.documentfoundation.org/show_bug.cgi?id=161073#c6 piece where that
part of the bug is in glib g_dbus_connection_export_menu_model itself

*** This bug has been marked as a duplicate of bug 161073 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161183] Forced restart of windows cumputer due to installation of LibreOffice

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161183

--- Comment #8 from V Stuart Foote  ---
(In reply to Lars.H.Nilsson from comment #6)
> Can then this be adjusted for future LibreOffice releases, so that the
> installation scripts themself take care of this procedure, without
> presenting the overly dramatic "need to reboot the computer" information to
> the user, if there indeed are no technical requirements for a real reboot?

As for bug 69066 (read from about cmnt 51), we already make use of the Windows 
installer provided "Restart Manager" that is intended to perform this task, but
it has warts.

As noted it may be possible, but not a priority, to modify the LibreOffice
installer with custom actions to halt/unload any in use LO libraries to avoid
the "resource in use" errors that trigger the restart manager dialogs.

For now the dialog *as implemented* is the best option for reliable
installations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161180] Logo Missing in Android App

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161180

BogdanB  changed:

   What|Removed |Added

URL|https://www.facebook.com/   |
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

New QtMultimedia dependency for --enable-qt6/--enable-kf6 builds (by default)

2024-05-20 Thread Michael Weghorn
In order to make video playback work for the Qt 6 based VCL plugins 
(qt6, kf6) work, the pending Gerrit change [1] ("tdf#145735 avmedia qt: 
Use QtMultimedia for Qt 6 media playback") will introduce a new default 
dependency on QtMultimedia for builds using the 
--enable-qt6/--enable-kf6 autogen options, except for WASM.


If you're building these, please make sure the corresponding development 
package (e.g. qt6-multimedia-dev on Debian) is installed or explicitly 
disable the use of QtMultimedia using the new autogen option 
"--disable-qt6-multimedia" once the change has landed on master.


[1] https://gerrit.libreoffice.org/c/core/+/167869


OpenPGP_signature.asc
Description: OpenPGP digital signature


[Bug 41610] Calc FORMATTING: Add functionality "Paste column width"

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=41610

--- Comment #5 from loic_dup...@hotmail.com ---
Afer trying this copy/paste of some formatted cells with assigned width AND
height, this issue is valid for BOTH of directions/axis. 

In other words, when you want to copy/paste "some cells with special height or
special width"... It just doesn't paste neither height nor width. 

I could be a useful addition to "paste special" menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161188] New: debug build crash with Tools > Customize > Category Macro

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161188

Bug ID: 161188
   Summary: debug build crash with Tools > Customize > Category
Macro
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Start a debug build. Tools > Customize > page 'Menus'.
Open the drop-down list of field 'Category' and select second last item
'Macros'. => Crash.

I get the error message
Exception thrown at 0x01C812D2095C in soffice.bin: 0xC005: Access
violation reading location 0x.

I do not get a call stack from VS 2022.

The debug build is from master Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice
Community
Build ID: bb5740bb4c79c6c9507d4dc127e9f4bac78afc2f
CPU threads: 32; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default;
VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - desktop/qa desktop/source include/comphelper include/LibreOfficeKit ucb/source

2024-05-20 Thread Michael Meeks (via logerrit)
 desktop/qa/desktop_lib/test_desktop_lib.cxx  |5 +--
 desktop/source/lib/init.cxx  |   18 +++
 include/LibreOfficeKit/LibreOfficeKit.h  |3 +
 include/LibreOfficeKit/LibreOfficeKit.hxx|9 +
 include/comphelper/lok.hxx   |2 +
 ucb/source/ucp/webdav-curl/CurlSession.cxx   |   43 +++
 ucb/source/ucp/webdav-curl/SerfLockStore.cxx |   35 +++--
 ucb/source/ucp/webdav-curl/SerfLockStore.hxx |   12 ++-
 ucb/source/ucp/webdav-curl/ucpdav1.component |4 ++
 9 files changed, 117 insertions(+), 14 deletions(-)

New commits:
commit 66de5312607e93b985ca5934e851718453a24693
Author: Michael Meeks 
AuthorDate: Sat May 18 22:08:22 2024 +0100
Commit: Michael Meeks 
CommitDate: Mon May 20 16:43:00 2024 +0200

lok: join Webdav Ticker thread.

Add 'startThreads' lok method for the few thread scenarios where
we need to have a background thread running that cannot be started
opportunistically.

Also add that to the ThreadJoinable interface so we can get into
UNO components' implementations to handle their worker threads
easily.

Implement joining and re-starting in WebDAV ucp too.

Change-Id: I329ef9decb32b263197e4c03a0d54952985fdd0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167858
Reviewed-by: Michael Meeks 
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins CollaboraOffice 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 298e5a5d7a9b..4a09b10931f6 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3594,11 +3594,12 @@ void DesktopLOKTest::testABI()
 CPPUNIT_ASSERT_EQUAL(classOffset(18), offsetof(struct 
_LibreOfficeKitClass, startURP));
 CPPUNIT_ASSERT_EQUAL(classOffset(19), offsetof(struct 
_LibreOfficeKitClass, stopURP));
 CPPUNIT_ASSERT_EQUAL(classOffset(20), offsetof(struct 
_LibreOfficeKitClass, joinThreads));
-CPPUNIT_ASSERT_EQUAL(classOffset(21), offsetof(struct 
_LibreOfficeKitClass, setForkedChild));
+CPPUNIT_ASSERT_EQUAL(classOffset(21), offsetof(struct 
_LibreOfficeKitClass, startThreads));
+CPPUNIT_ASSERT_EQUAL(classOffset(22), offsetof(struct 
_LibreOfficeKitClass, setForkedChild));
 
 // When extending LibreOfficeKit with a new function pointer,  add new 
assert for the offsetof the
 // new function pointer and bump this assert for the size of the class.
-CPPUNIT_ASSERT_EQUAL(classOffset(22), sizeof(struct _LibreOfficeKitClass));
+CPPUNIT_ASSERT_EQUAL(classOffset(23), sizeof(struct _LibreOfficeKitClass));
 
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(0), offsetof(struct 
_LibreOfficeKitDocumentClass, destroy));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(1), offsetof(struct 
_LibreOfficeKitDocumentClass, saveAs));
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index f00edb9ec9c9..86f0efda8857 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2602,6 +2602,8 @@ static void lo_stopURP(LibreOfficeKit* pThis, void* 
pSendURPToLOContext);
 
 static int lo_joinThreads(LibreOfficeKit* pThis);
 
+static void lo_startThreads(LibreOfficeKit* pThis);
+
 static void lo_setForkedChild(LibreOfficeKit* pThis, bool bIsChild);
 
 static void lo_runLoop(LibreOfficeKit* pThis,
@@ -2649,6 +2651,7 @@ LibLibreOffice_Impl::LibLibreOffice_Impl()
 m_pOfficeClass->startURP = lo_startURP;
 m_pOfficeClass->stopURP = lo_stopURP;
 m_pOfficeClass->joinThreads = lo_joinThreads;
+m_pOfficeClass->startThreads = lo_startThreads;
 m_pOfficeClass->setForkedChild = lo_setForkedChild;
 
 gOfficeClass = m_pOfficeClass;
@@ -3399,6 +3402,12 @@ static int lo_joinThreads(LibreOfficeKit* /* pThis */)
 if (joinable && !joinable->joinThreads())
 return 0;
 
+auto ucpWebdav = xContext->getServiceManager()->createInstanceWithContext(
+"com.sun.star.ucb.WebDAVManager", xContext);
+joinable = dynamic_cast(ucpWebdav.get());
+if (joinable && !joinable->joinThreads())
+return 0;
+
 // Ensure configmgr's write thread is down
 css::uno::Reference< css::util::XFlushable >(
 css::configuration::theDefaultProvider::get(
@@ -3408,6 +3417,15 @@ static int lo_joinThreads(LibreOfficeKit* /* pThis */)
 return 1;
 }
 
+static void lo_startThreads(LibreOfficeKit* /* pThis */)
+{
+auto ucpWebdav = xContext->getServiceManager()->createInstanceWithContext(
+"com.sun.star.ucb.WebDAVManager", xContext);
+auto joinable = dynamic_cast(ucpWebdav.get());
+if (joinable)
+joinable->startThreads();
+}
+
 static void lo_setForkedChild(LibreOfficeKit* /* pThis */, bool bIsChild)
 {
 comphelper::LibreOfficeKit::setForkedChild(bIsChild);
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h 
b/include/LibreOfficeKit/LibreOfficeKit.h
index 

[Bug 161163] Crash when opening/creating a brand new file on Base (gtk3 only)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161163

--- Comment #8 from Julien Nabet  ---
apt-file search libgio-2.0.so.0 (from bt) gives:
libglib2.0-0t64: /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
libglib2.0-0t64: /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.8000.2

and apt-cache show libglib2.0-0t64 shows:
Package: libglib2.0-0t64
Source: glib2.0
Version: 2.80.2-1

so yes it's 2.80.
So since my local build already includes tdf#161073's fix, I suppose it means
there's still a pb with 2.80.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80430] [META] Documentation gap for new features

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 160909, which changed state.

Bug 160909 Summary: [LOCALHELP] Update Help Page on Tools - Options - Calc - 
View, ref: cell edit mode background
https://bugs.documentfoundation.org/show_bug.cgi?id=160909

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160870] Continued footnote number is flipped

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160870

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||103164


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103164
[Bug 103164] [META] Footnote and Endnote bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103164] [META] Footnote and Endnote bugs and enhancements

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103164

BogdanB  changed:

   What|Removed |Added

 Depends on||160870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160870
[Bug 160870] Continued footnote number is flipped
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/uiconfig

2024-05-20 Thread Dione Maddern (via logerrit)
 sc/uiconfig/scalc/ui/tpviewpage.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e503518c14cfa2f1fda709db017d6e0de3f39141
Author: Dione Maddern 
AuthorDate: Mon May 20 08:47:16 2024 -0400
Commit: Olivier Hallot 
CommitDate: Mon May 20 16:22:15 2024 +0200

tdf#160969 Update extended tip for Comment Indicator

In sc/uiconfig/scalc/ui/tpviewpage.ui
- Updated extended tip for "Comment Indicator" to reflect the current 
appearance of the Tools > Options> Scalc > View dialog

Change-Id: Iff0d7b0c05d54099818816e6146bc678d06a1e32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167867
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/sc/uiconfig/scalc/ui/tpviewpage.ui 
b/sc/uiconfig/scalc/ui/tpviewpage.ui
index a0d552aa1162..04ace554d200 100644
--- a/sc/uiconfig/scalc/ui/tpviewpage.ui
+++ b/sc/uiconfig/scalc/ui/tpviewpage.ui
@@ -74,7 +74,7 @@
 True
 
   
-Specifies that a small 
rectangle in the top right corner of the cell indicates that a comment 
exists.
+Specifies that a small triangle 
in the top right corner of the cell indicates that a comment exists.
   
 
   


[Bug 161162] visual glitch on tabbed user interface

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161162

--- Comment #4 from ross-ross  ---
(In reply to Stéphane Guillou (stragu) from comment #1)
> Not reproduced with Ubuntu 22.04 + GNOME 42.9, 150% fractional scaling and:
> 
> Version: 24.2.3.2 (X86_64) / LibreOffice Community
> Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
> CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> Can you please share a screenshot of the issue, and more details about your
> desktop environment and windowing system / compositor?
> 
> Thank you!

see the attachment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161162] visual glitch on tabbed user interface

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161162

ross-ross  changed:

   What|Removed |Added

 CC||rosswzy...@outlook.com

--- Comment #3 from ross-ross  ---
Created attachment 194229
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194229=edit
reproduce image

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161163] Crash when opening/creating a brand new file on Base (gtk3 only)

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161163

--- Comment #7 from Caolán McNamara  ---
What version of glib do you have? There was apparently a new release of glib
2.80 which revealed some outstanding issue in
g_dbus_connection_export_menu_model

See https://bugs.documentfoundation.org/show_bug.cgi?id=161073

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161162] visual glitch on tabbed user interface

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161162

--- Comment #2 from ross-ross  ---
my env:

Version: 24.2.3.2 (X86_64)
Build ID: 420(Build:2)
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161183] Forced restart of windows cumputer due to installation of LibreOffice

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161183

--- Comment #7 from Mike Kaganski  ---
We do not use "installation scripts". We use Microsoft technology named
"Windows Installer", which takes a list of files and registry values, and does
everything that is needed to put them to the destination. When Windows
Installer thinks that a reboot is needed, it tells you so. There is no plans to
change the installation technology.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 38065] PDF Export with LibO Application Colors / Document background color

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38065

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3334

--- Comment #35 from V Stuart Foote  ---
Application color settings bleed over into document style on export to PDF
still reproducible 24.2.3.2 and recent 24.8.0.0 builds. 

Seems more of an issue now with the os/DE theme and "Light" and "Dark" AC theme
in place as for bug 152184 and bug 153334

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160382] Option to turn on Remote access not available

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160382

Dione Maddern  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |dionemadd...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 38065] PDF Export with LibO Application Colors / Document background color

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=38065

V Stuart Foote  changed:

   What|Removed |Added

 CC||dz.wb...@gmail.com

--- Comment #34 from V Stuart Foote  ---
*** Bug 161185 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161185] draw: lines and background color should be automatic when using dark mode

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161185

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3334
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||vsfo...@libreoffice.org

--- Comment #1 from V Stuart Foote  ---
Confirmed for Draw and Impress. But a long present dupe...

Not applicable to Writer, Calc with the os/DE theme support in View and
Application color as for bug 153334 and bug 152184

=-Testing-=

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47664e282da4999b8e471a6a916d7ec80414ac18
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render:
Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

*** This bug has been marked as a duplicate of bug 38065 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

help.git: source/text

2024-05-20 Thread Dione Maddern (via logerrit)
 source/text/shared/optionen/0106.xhp |2 
 source/text/shared/optionen/01060100.xhp |  205 +++
 2 files changed, 129 insertions(+), 78 deletions(-)

New commits:
commit cbb8c2d8d957f8a4729b32ac098c8a88f72d797a
Author: Dione Maddern 
AuthorDate: Tue May 14 00:14:49 2024 +0200
Commit: Olivier Hallot 
CommitDate: Mon May 20 16:00:42 2024 +0200

tdf#160909 Update help page for Scalc View Options

In text/shared/optionen/01060100.xhp
- Added index bookmarks for new features
- Removed old comment.
- Updated "How to get" section to reflect current menu options.
- Updated help page to cover new options:
  - Pointer
  - Comment authorship
  - Column/Row highlighting
  - Edit cell highlighting
  - Summary on search
- Removed the section describing the "Color" option because that option no 
longer appears in the "View" dialog.

In text/shared/optionen/0106.xhp
- Added link and variable tags to the title, so that the page can be easily 
linked from other pages.

Change-Id: Ib738453b33efcded574576052b7add3cb6bb25c0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167463
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/source/text/shared/optionen/0106.xhp 
b/source/text/shared/optionen/0106.xhp
index ea0d9613bd..9be7dde90a 100644
--- a/source/text/shared/optionen/0106.xhp
+++ b/source/text/shared/optionen/0106.xhp
@@ -32,7 +32,7 @@
 
 
 
-%PRODUCTNAME Calc Options
+%PRODUCTNAME Calc 
Options
 Defines various settings for spreadsheets, 
contents to be displayed, and the cursor direction after a cell entry. You can 
also define sorting lists, determine the number of decimal places and the 
settings for recording and highlighting changes. 
 
 
diff --git a/source/text/shared/optionen/01060100.xhp 
b/source/text/shared/optionen/01060100.xhp
index 05c53ba29b..7d93705944 100644
--- a/source/text/shared/optionen/01060100.xhp
+++ b/source/text/shared/optionen/01060100.xhp
@@ -29,51 +29,71 @@

   
 cells; showing grid 
lines (Calc)
-borders; cells on screen (Calc)
-grids; displaying lines (Calc)
-colors; grid lines and cells (Calc)
-page breaks; displaying (Calc)
-guides; showing (Calc)
-displaying; zero values (Calc)
-zero values; displaying (Calc)
-tables in spreadsheets; value highlighting
-cells; formatting without effect (Calc)
-cells; coloring (Calc)
-anchors; displaying (Calc)
-colors;restriction (Calc)
-text overflow in spreadsheet cells
-references; displaying in color (Calc)
-objects; displaying in spreadsheets
-pictures; displaying in Calc
-charts; displaying (Calc)
-draw objects; displaying (Calc)
-row headers; displaying (Calc)
-column headers; displaying (Calc)
-scrollbars; displaying (Calc)
-sheet tabs; displaying
-tabs; displaying sheet tabs
-outlines;outline symbols
-cells;formula indicator in cell
-cells;formula hint
-MW copied "displaying;comments" over to  Calc guide 
note_insert.xhp and deleted "comments;displaying"
+  borders; cells on screen (Calc)
+  grids; displaying lines (Calc)
+  colors; grid lines and cells (Calc)
+  page breaks; displaying (Calc)
+  guides; showing (Calc)
+  displaying; zero values (Calc)
+  zero values; displaying (Calc)
+  tables in spreadsheets; value highlighting
+  cells; formatting without effect (Calc)
+  cells; coloring (Calc)
+  anchors; displaying (Calc)
+  colors;restriction (Calc)
+  text overflow in spreadsheet cells
+  references; displaying in color (Calc)
+  objects; displaying in spreadsheets
+  pictures; displaying in Calc
+  charts; displaying (Calc)
+  draw objects; displaying (Calc)
+  row headers; displaying (Calc)
+  column headers; displaying (Calc)
+  scrollbars; displaying (Calc)
+  sheet tabs; displaying
+  tabs; displaying sheet tabs
+  outlines;outline symbols
+  cells;formula indicator in cell
+  cells;formula hint
+  displaying; comment authorship
+  pointer;themed
+  pointer;system  
+  find all;displaying search summary
+  cells;highlighting
+
+
 
 
-View
- Defines which elements of the 
%PRODUCTNAME Calc main window are displayed. 
You can also show or hide highlighting of values in tables.
-  
+View
+Defines which elements of the 
%PRODUCTNAME Calc main window are displayed. 
You can also show or hide highlighting of values in tables.
+
   
- 
-  
-  Visual aids
-  Specifies which lines are 
displayed.
+
+
+
+Choose 
Tools - Options - %PRODUCTNAME Calc - View.
+
+Press 
Alt+F12 then choose  %PRODUCTNAME Calc - 
View.
+
+Visual aids
+Specifies which lines are 
displayed.
+
 
-Grid lines
-  Specifies when grid 
lines will be displayed. Default is to display grid lines only on cells that do 
not have a background color. You can choose to also display grid lines on cells 
with background color, or to hide them. For printing, choose 
Format - Page Style - Sheet and mark the 

core.git: helpcontent2

2024-05-20 Thread Dione Maddern (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6a3273ddf6a754b14d47448b8bf9cd335e7de502
Author: Dione Maddern 
AuthorDate: Mon May 20 16:00:42 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Mon May 20 16:00:42 2024 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to cbb8c2d8d957f8a4729b32ac098c8a88f72d797a
  - tdf#160909 Update help page for Scalc View Options

In text/shared/optionen/01060100.xhp
- Added index bookmarks for new features
- Removed old comment.
- Updated "How to get" section to reflect current menu options.
- Updated help page to cover new options:
  - Pointer
  - Comment authorship
  - Column/Row highlighting
  - Edit cell highlighting
  - Summary on search
- Removed the section describing the "Color" option because that option 
no longer appears in the "View" dialog.

In text/shared/optionen/0106.xhp
- Added link and variable tags to the title, so that the page can be 
easily linked from other pages.

Change-Id: Ib738453b33efcded574576052b7add3cb6bb25c0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167463
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 975d11c1c7bc..cbb8c2d8d957 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c
+Subproject commit cbb8c2d8d957f8a4729b32ac098c8a88f72d797a


[Bug 134139] Long translated strings cause layout havoc in options dialog

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134139

--- Comment #27 from Łukasz  ---
will it be patched to version 24.8?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160896] Allow referencing Column & Row with Base 1 instead of 0 in Basic

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160896

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
Summary|Cell Column & Row Base  |Allow referencing Column &
   ||Row with Base 1 instead of
   ||0 in Basic
   Keywords||needsUXEval
   Severity|normal  |enhancement

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I think adding complexity to it with more options is not desirable. This is a
scripting/programming language, and can be expected to count zero-based.
"Won't fix" for me too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160896] Allow referencing Column & Row with Base 1 instead of 0 in Basic

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160896

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||stephane.guillou@libreoffic
   ||e.org
Summary|Cell Column & Row Base  |Allow referencing Column &
   ||Row with Base 1 instead of
   ||0 in Basic
   Keywords||needsUXEval
   Severity|normal  |enhancement

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
I think adding complexity to it with more options is not desirable. This is a
scripting/programming language, and can be expected to count zero-based.
"Won't fix" for me too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103369
Bug 103369 depends on bug 156105, which changed state.

Bug 156105 Summary: Percents behave wrong in list level prefix/suffix
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156105] Percents behave wrong in list level prefix/suffix

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Justin L  ---
Comment 3's fix is the one that takes care of what OP described.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160498] Crash in: ntdll.dll

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160498

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Not reproduced with a new file in:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Maybe you can attach a sample file for us to test? Or provide us with more
details to reproduce the issue from scratch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-05-20 Thread Stéphane Guillou (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 625c1507712adedb85a276921aa6aacbbd1e142d
Author: Stéphane Guillou 
AuthorDate: Mon May 20 23:44:23 2024 +1000
Commit: Gerrit Code Review 
CommitDate: Mon May 20 15:44:23 2024 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c
  - related tdf#69192 document --show=slide_number option

Change-Id: I9944a6d4dbaa7ec7f5283c677063cac74bc7e80d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167614
Reviewed-by: Justin Luth 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index d2649657002e..975d11c1c7bc 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d2649657002eeabbf686333faccd2b141d3bc9dc
+Subproject commit 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c


help.git: source/text

2024-05-20 Thread Stéphane Guillou (via logerrit)
 source/text/shared/guide/start_parameters.xhp |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c
Author: Stéphane Guillou 
AuthorDate: Tue May 14 12:12:10 2024 +1000
Commit: Justin Luth 
CommitDate: Mon May 20 15:44:22 2024 +0200

related tdf#69192 document --show=slide_number option

Change-Id: I9944a6d4dbaa7ec7f5283c677063cac74bc7e80d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167614
Reviewed-by: Justin Luth 
Tested-by: Jenkins

diff --git a/source/text/shared/guide/start_parameters.xhp 
b/source/text/shared/guide/start_parameters.xhp
index 4b8cc8e1bd..1740980581 100644
--- a/source/text/shared/guide/start_parameters.xhp
+++ b/source/text/shared/guide/start_parameters.xhp
@@ -533,10 +533,11 @@
 
 
 
---show
+--show[=slide_number]
 
 
-Opens and starts the following presentation documents of each 
immediately. Files are closed after the showing. Files other than Impress 
documents are opened in default mode , regardless of previous mode.
+
+Opens and starts the slideshow of the following presentation 
documents immediately. Files are closed after the showing. If a 
slide_number is provided, they start at that slide.
 
 
 


core.git: desktop/source

2024-05-20 Thread Justin Luth (via logerrit)
 desktop/source/app/cmdlinehelp.cxx |9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 3d4a3b30aea603b98da447ec6587b5d3eb20da66
Author: Justin Luth 
AuthorDate: Tue May 14 09:20:49 2024 -0400
Commit: Justin Luth 
CommitDate: Mon May 20 15:42:36 2024 +0200

tdf#69192 fix cmdlinehelp: --show[=slide_number], etc.

I had skimmed the help file earlier, and concluded that { }
are used elsewhere to indicate optional paramaters.
However, there is --quickstart[=no], and -env:[=]
which exactly match my optional addition.

Thanks Stéphane for pointing this out.
Also included are some other changes we made
to clarify the help wording in general,
so the documentation and the cmdline help are in sync.

We dropped
Files other than Impress documents are opened in
default mode, regardless of previous mode.
because:
-from an initial reading it doesn't convey any useful meaning.
-searching for other uses of "mode" in the file suggests it means
 that prior --print/--convert-to/--view modes
 no longer apply. This override of prior modes is true for all modes,
 but only this argument tries to spell this out.
-it seems rather inconceivable that any user would attempt
 to mix --show with any other arguments or more than one file.

Change-Id: I191e572506cf2b39ed6c9ff4ebaf66f258a176a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167633
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/desktop/source/app/cmdlinehelp.cxx 
b/desktop/source/app/cmdlinehelp.cxx
index 10b3e5c48cbb..7fb0b3d48a1e 100644
--- a/desktop/source/app/cmdlinehelp.cxx
+++ b/desktop/source/app/cmdlinehelp.cxx
@@ -145,11 +145,10 @@ namespace desktop
 "   not appear. If the file name contains spaces, 
then it   
"
 "   must be enclosed in quotation marks.   
 
"
 "   --view  Opens following files in viewer mode 
(read-only).   
"
-"   --show{=slide#} Opens and starts the following presentation 
documents   
"
-"   of each immediately. Files are closed after 
the showing.
"
-"   If a slide # is provided, they start at that 
slide. 
"
-"   Files other than Impress documents are opened 
in
"
-"   default mode , regardless of previous mode.
 
"
+"   --show[=slide_number]  Opens and starts the slideshow of the 
following  
"
+"   presentation documents immediately.
 
"
+"   Files are closed after the showing.
 
"
+"   If a slide_number is provided, they start at 
that slide.
"
 "   --convert-to OutputFileExtension[:OutputFilterName] \  

"
 " [--outdir output_dir] [--convert-images-to]  
 
"
 "   Batch convert files (implies --headless). If 
--outdir   
"


[Bug 159981] Pasting table data with no coloumn breaks (only row breaks), but with fixed number of columns.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159981

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
(also, please test a version that is currently maintained, like 24.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/editeng

2024-05-20 Thread Justin Luth (via logerrit)
 include/editeng/numitem.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 382801ee5368a4c3d59931450dec0d2d9f369285
Author: Justin Luth 
AuthorDate: Sat May 18 12:02:56 2024 -0400
Commit: Justin Luth 
CommitDate: Mon May 20 15:41:19 2024 +0200

documentation: list format placeholder has been "%1%" since LO 7.2

Vasily's commit aa5c6d127559912ad60a63fbd972b78fb8f9691b
new ODF numbered list parameter loext:num-list-format

Internal LO format for list format is changed:
instead of placeholders like %1, %2, etc
we right now use %1%, %2%... Reason: for ODT documents,
having more than 9 levels there is ambiguity in "%10":
it is "%1" followed by "0" suffix, or "%10"?

It was introduced in 6.4.5 for DOCX support with
Vasily's commit 7459b9ecb54a298f02d19089620149718f8d8d48
tdf#116883: sw: support for lists level format string

Change-Id: I5962ed04c555356c6a3fc05ab7e036975d7eee40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167833
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/include/editeng/numitem.hxx b/include/editeng/numitem.hxx
index 5005a20fa7a1..423a0e2aeda3 100644
--- a/include/editeng/numitem.hxx
+++ b/include/editeng/numitem.hxx
@@ -104,7 +104,7 @@ public:
 private:
 OUStringsPrefix;
 OUStringsSuffix;
-std::optional sListFormat;// Format string ">%1.%2<" can 
be used instead of prefix/suffix
+std::optional sListFormat;// Format string ">%1%.%2%<" 
can be used instead of prefix/suffix
 // Right now it is optional 
value to distinguish empty list format
 // and not set list format 
when we need to fallback to prefix/suffix.
 


[Bug 159981] Pasting table data with no coloumn breaks (only row breaks), but with fixed number of columns.

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=159981

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Can you provide an example website to copy the HTML from?
Have you tested right-click > paste special > unformatted text? That text
import dialog provides many options to define the structure of the table.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156105] Percents behave wrong in list level prefix/suffix

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

--- Comment #4 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a94db2e3b6e130fe90de31cbd909ce54f5450601

tdf#156105 sw: make SvxNumberFormat GetPrefix/Suffix more trustworthy

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156105] Percents behave wrong in list level prefix/suffix

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

--- Comment #3 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/65e226aff6a946ae4884b9f5afdccaa1c745bcd4

tdf#156105 sw: trust SvxNumberFormat GetPrefix/GetSuffix

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/source

2024-05-20 Thread Justin Luth (via logerrit)
 editeng/source/items/numitem.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a94db2e3b6e130fe90de31cbd909ce54f5450601
Author: Justin Luth 
AuthorDate: Sat May 18 11:36:24 2024 -0400
Commit: Justin Luth 
CommitDate: Mon May 20 15:40:58 2024 +0200

tdf#156105 sw: make SvxNumberFormat GetPrefix/Suffix more trustworthy

As soon as SetPrefix or SetSuffix are called,
any partially formed sListFormat is invalid (unless nothing changed).

ListFormat creates sPrefix/sSuffix as a convenience/compat item,
and changing it directly is NOT reflected in the sListFormat itself.
Trying to keep them in sync would be very complicated.

Any process that uses these functions OUGHT TO be doing it as
building blocks to eventually call SetListFormat(prefix, suffix, lvl),
at which point a proper sListFormat will be created.

Change-Id: I05f681c812ea5207cb8127b30dafbd543ffea219
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167832
Reviewed-by: Justin Luth 
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk 

diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 0d677dfc6696..f0fe0085e157 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -571,7 +571,7 @@ OUString SvxNumberFormat::CreateRomanString( sal_Int32 nNo, 
bool bUpper )
 void SvxNumberFormat::SetPrefix(const OUString& rSet)
 {
 // ListFormat manages the prefix. If badly changed via this function, 
sListFormat is invalidated
-if (sListFormat && rSet.getLength() != sPrefix.getLength())
+if (sListFormat)
 sListFormat.reset();
 
 sPrefix = rSet;
@@ -580,7 +580,7 @@ void SvxNumberFormat::SetPrefix(const OUString& rSet)
 void SvxNumberFormat::SetSuffix(const OUString& rSet)
 {
 // ListFormat manages the suffix. If badly changed via this function, 
sListFormat is invalidated
-if (sListFormat && rSet.getLength() != sSuffix.getLength())
+if (sListFormat)
 sListFormat.reset();
 
 sSuffix = rSet;


[Bug 156105] Percents behave wrong in list level prefix/suffix

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

--- Comment #2 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/047e3f62901ae89da30bf1367218104e57439f70

related tdf#156105 sw UI: recognize '%' in numbering prefix/suffix

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156105] Percents behave wrong in list level prefix/suffix

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156105

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/qa sw/source

2024-05-20 Thread Justin Luth (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf156105_percentSuffix.odt |binary
 sw/qa/extras/ooxmlexport/ooxmlexport21.cxx|7 ++
 sw/source/core/doc/number.cxx |   33 +++---
 3 files changed, 15 insertions(+), 25 deletions(-)

New commits:
commit 65e226aff6a946ae4884b9f5afdccaa1c745bcd4
Author: Justin Luth 
AuthorDate: Fri May 17 12:17:26 2024 -0400
Commit: Justin Luth 
CommitDate: Mon May 20 15:40:38 2024 +0200

tdf#156105 sw: trust SvxNumberFormat GetPrefix/GetSuffix

After LO 7.4 (backported to 7.2.5) created this
function that manually identifies the Prefix/Suffix,
there was some work done to ensure
GetPrefix and GetSuffix were trustworthy in
LO 7.5's commit 835cda561217bd8c53af2de927158dd5712b06c0
Author: Justin Luth on Tue Aug 2 13:30:31 2022 -0400
related tdf#150197: use SetListFormat or SetPrefix/Suffix
GetListFormat DEPENDS on having managed prefix/suffix itself...

So, lets make sure we use and fix these functions in only one place.

make CppunitTest_sw_ooxmlexport21 \
CPPUNIT_TEST_NAME=testTdf156105_percentSuffix

Change-Id: I44c021a200ba45960e39983087c6af268751fbc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167792
Reviewed-by: Justin Luth 
Reviewed-by: Vasily Melenchuk 
Tested-by: Jenkins

diff --git a/sw/qa/extras/ooxmlexport/data/tdf156105_percentSuffix.odt 
b/sw/qa/extras/ooxmlexport/data/tdf156105_percentSuffix.odt
new file mode 100644
index ..a5319f7a9522
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf156105_percentSuffix.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
index 01c42d0ea34d..6cfbe8d783fc 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
@@ -293,6 +293,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf158597, "tdf158597.docx")
 }
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf156105_percentSuffix, 
"tdf156105_percentSuffix.odt")
+{
+// given a numbered list with a non-escaping percent symbol in the prefix 
and suffix
+CPPUNIT_ASSERT_EQUAL(OUString("(%)[%]"),
+ getProperty(getParagraph(3), 
"ListLabelString"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf160049_anchorMarginVML, 
"tdf160049_anchorMarginVML.docx")
 {
 // given a VML (Word 2003) document with a LEFT "column/text" anchored 
image
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index c92d2af29a7d..f43ab140b60d 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -721,32 +721,15 @@ OUString SwNumRule::MakeNumString( const 
SwNumberTree::tNumberVector & rNumVecto
 
 if (rMyNFormat.GetNumberingType() == SVX_NUM_NUMBER_NONE)
 {
-if (!rMyNFormat.HasListFormat()) {
-OUString sRet = bInclStrings ? rMyNFormat.GetPrefix() + 
rMyNFormat.GetSuffix() : OUString();
-StripNonDelimiter(sRet);
-return sRet;
-}
-
-// If numbering is disabled for this level we should emit just 
prefix/suffix
-// Remove everything between first %1% and last %n% (including markers)
-OUString sLevelFormat = rMyNFormat.GetListFormat(bInclStrings && 
!bHideNonNumerical);
-
-if (bInclStrings && bHideNonNumerical) {
-// If hiding non numerical text, we need to strip the prefix and 
suffix properly, so let's add them manually
-OUString sPrefix = rMyNFormat.GetPrefix();
-OUString sSuffix = rMyNFormat.GetSuffix();
+// since numbering is disabled for this level,
+// only emit prefix/suffix (unless they are not wanted either)
+if (!bInclStrings)
+return OUString();
 
-StripNonDelimiter(sPrefix);
-StripNonDelimiter(sSuffix);
-
-sLevelFormat = sPrefix + sLevelFormat + sSuffix;
-}
-
-sal_Int32 nFirstPosition = sLevelFormat.indexOf("%");
-sal_Int32 nLastPosition = sLevelFormat.lastIndexOf("%");
-if (nFirstPosition >= 0 && nLastPosition >= nFirstPosition)
-sLevelFormat = sLevelFormat.replaceAt(nFirstPosition, 
nLastPosition - nFirstPosition + 1, u"");
-return sLevelFormat;
+OUString sRet = rMyNFormat.GetPrefix() + rMyNFormat.GetSuffix();
+if (bHideNonNumerical)
+StripNonDelimiter(sRet);
+return sRet;
 }
 
 css::lang::Locale aLocale( LanguageTag::convertToLocale(nLang));


core.git: editeng/source

2024-05-20 Thread Justin Luth (via logerrit)
 editeng/source/items/numitem.cxx |   28 +---
 1 file changed, 25 insertions(+), 3 deletions(-)

New commits:
commit 047e3f62901ae89da30bf1367218104e57439f70
Author: Justin Luth 
AuthorDate: Fri May 17 10:01:50 2024 -0400
Commit: Justin Luth 
CommitDate: Mon May 20 15:40:07 2024 +0200

related tdf#156105 sw UI: recognize '%' in numbering prefix/suffix

bug 156105's listWithPercents.odt is an example of a
properly defined ListFormat which contains a percent symbol
in the prefix and suffix, which looked fine in the document itself,
but was cut off short in the UI.

sw/qa/extras/ooxmlexport/data/tdf116883.docx is also an example,
which can be seen if you reduce the first entry to level 1
instead of level 2.
Level 1 is improperly defined as "1%>". This is invalid formatting,
so the entire thing should be considered a suffix.
MS Word also considers it to be a suffix.

This code segment still isn't completely comprehensive
because it won't properly parse "%1xyz%1%." and "%1xyz%10%."
but I'm losing patience.

There is still a potential problem with the
nInclUpperLevels calculation in case
a '%' is used as an in-between separator,
but that seems extremely theoretical and irrelevant to me.
IIUC, the main impact is that it shows some extra dots
in the bullets and numbering UI preview.

Change-Id: Ic1b8fbda62917ad4c7b88bf4fff136d72242f977
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167782
Reviewed-by: Justin Luth 
Reviewed-by: Vasily Melenchuk 
Tested-by: Jenkins

diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index b81172f9e5a2..0d677dfc6696 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -626,17 +626,39 @@ void 
SvxNumberFormat::SetListFormat(std::optional oSet)
 // For backward compatibility and UI we should create something looking 
like
 // a prefix, suffix and included levels also. This is not possible in 
general case
 // since level format string is much more flexible. But for most cases is 
okay
+
+// If properly formatted, sListFormat should look something like "%1%…%10%"
+// with an optional prefix or suffix (which could theoretically include a 
percent symbol)
+const sal_Int32 nLen = sListFormat->getLength();
 sal_Int32 nFirstReplacement = sListFormat->indexOf('%');
-sal_Int32 nLastReplacement = sListFormat->lastIndexOf('%') + 1;
+while (nFirstReplacement > -1 && nFirstReplacement < nLen - 1
+   && ((*sListFormat)[nFirstReplacement + 1] < '1'
+   || (*sListFormat)[nFirstReplacement + 1] > '9'))
+{
+nFirstReplacement = sListFormat->indexOf('%', nFirstReplacement + 1);
+}
+
+sal_Int32 nLastReplacement = nFirstReplacement == -1 ? -1 : 
sListFormat->lastIndexOf('%');
+while (nLastReplacement > 0
+   && ((*sListFormat)[nLastReplacement - 1] < '0'
+   || (*sListFormat)[nLastReplacement - 1] > '9'))
+{
+nLastReplacement = sListFormat->lastIndexOf('%', nLastReplacement);
+}
+if (nLastReplacement < nFirstReplacement)
+nLastReplacement = nFirstReplacement;
+else
+++nLastReplacement;
+
 if (nFirstReplacement > 0)
 // Everything before first '%' will be prefix
 sPrefix = sListFormat->copy(0, nFirstReplacement);
-if (nLastReplacement >= 0 && nLastReplacement < sListFormat->getLength())
+if (nLastReplacement >= 0 && nLastReplacement < nLen)
 // Everything beyond last '%' is a suffix
 sSuffix = sListFormat->copy(nLastReplacement);
 
 sal_uInt8 nPercents = 0;
-for (sal_Int32 i = 0; i < sListFormat->getLength(); i++)
+for (sal_Int32 i = nFirstReplacement > 0 ? nFirstReplacement : 0; i < 
nLastReplacement; i++)
 {
 if ((*sListFormat)[i] == '%')
 nPercents++;


core.git: Branch 'distro/collabora/co-24.04' - desktop/source

2024-05-20 Thread Michael Meeks (via logerrit)
 desktop/source/lib/init.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 84ede4db0482a5bdcdb3398483ec1a63f7167012
Author: Michael Meeks 
AuthorDate: Mon May 20 14:03:51 2024 +0100
Commit: Michael Meeks 
CommitDate: Mon May 20 15:39:12 2024 +0200

lok: joinThreads - take down configmgr's write-thread.

Change-Id: I1f9b6b88ef7e97da02fecf2035f953584cd28c16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167868
Reviewed-by: Caolán McNamara 
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index cb487d641ac8..f00edb9ec9c9 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -112,6 +112,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -3397,6 +3399,12 @@ static int lo_joinThreads(LibreOfficeKit* /* pThis */)
 if (joinable && !joinable->joinThreads())
 return 0;
 
+// Ensure configmgr's write thread is down
+css::uno::Reference< css::util::XFlushable >(
+css::configuration::theDefaultProvider::get(
+comphelper::getProcessComponentContext()),
+css::uno::UNO_QUERY_THROW)->flush();
+
 return 1;
 }
 


[Bug 160492] libcdr: recent CorelDraw files are not loaded

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160492

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4664
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
- cdr24.cdr: loads
- cdr25.cdr: loads
- cdr25.cdrt: does not open
- template20.cdt: does not open
- Untitled-1.cdr: input/output error
- Untitled-1.cmx: does not open

Some of the file types are already represented in bug 104664.

Are you able to provide screenshots of what the files look like in CorelDRAW?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 104664] Almost complete failure of CorelDraw 5 files

2024-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104664

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0492

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >