[Bug 160139] Header/footer contents removed and cannot be restored after some paste actions (from shape; as RTF; Zotero refresh...) (steps in comment 2)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160139

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Header and footer gets  |Header/footer contents
   |removed in Writer and   |removed and cannot be
   |cannot be restored after|restored after some paste
   |pasting some text from a|actions (from shape; as
   |shape (steps in comment 2)  |RTF; Zotero refresh...)
   ||(steps in comment 2)

--- Comment #22 from Stéphane Guillou (stragu) 
 ---
Minimal steps from duplicate bug 160045:

1. Insert any text into the header
2. Copy it
3. Paste with Ctrl + Shift + V, select RTF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 89472] Table background overriden by background image in header

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89472

--- Comment #10 from fabien.mic...@hespul.org ---
Still repro in

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 8; OS: Linux 6.9; UI render: default; VCL: gtk3
Locale: fr-FR (en_US.UTF-8); UI: en-US
24.2.4-1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158618] Picture made with draw and pasted in Writer disappear when you modify or/and register Writer file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158618

david.vantyg...@laposte.net changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158618] Picture made with draw and pasted in Writer disappear when you modify or/and register Writer file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158618

--- Comment #10 from david.vantyg...@laposte.net ---
Bug is in LibreOffice version 7.3.7.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 48741] [META] Writer's page header and footer issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48741
Bug 48741 depends on bug 160045, which changed state.

Bug 160045 Summary: Writer Header cleared when pasting RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=160045

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160139] Header and footer gets removed in Writer and cannot be restored after pasting some text from a shape (steps in comment 2)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160139

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |0045|
 CC||adomas@gmail.com

--- Comment #21 from Stéphane Guillou (stragu) 
 ---
*** Bug 160045 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160045] Writer Header cleared when pasting RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160045

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Resolution|--- |DUPLICATE
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |0139|
 Status|NEW |RESOLVED

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
(In reply to Adomas Venčkauskas from comment #0)
> Steps to Reproduce:
> 1. Insert any text into the header.
> 2. Copy it
> 3. Paste with Ctrl-Shift-V, select RTF
> 4. Header text disappears
> 
> Actual Results:
> Header is cleared
This also started at:

author  Tomaž Vajngerl  2023-11-28 13:46:21 +0900
commit 4b0fa253a4540f5461397815d290586f9ddabe61
tdf#136472 adjust ooxml import to handle first header/footer

Let's mark as duplicate.

*** This bug has been marked as a duplicate of bug 160139 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161252] bibliography shows either number or short title in the entry not both

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161252

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |7064|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161252] bibliography shows either number or short title in the entry not both

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161252

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |7064|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157064

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |1252|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157064

Heiko Tietze  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |1252|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157064

Heiko Tietze  changed:

   What|Removed |Added

 CC||testing1237...@yahoo.com

--- Comment #13 from Heiko Tietze  ---
*** Bug 161252 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 101258] [META] Bibliography bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101258
Bug 101258 depends on bug 161252, which changed state.

Bug 161252 Summary: bibliography shows either number or short title in the 
entry not both
https://bugs.documentfoundation.org/show_bug.cgi?id=161252

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157064] Allow customization of the text reference style(s) from the bibliographic entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157064

Heiko Tietze  changed:

   What|Removed |Added

 CC||testing1237...@yahoo.com

--- Comment #13 from Heiko Tietze  ---
*** Bug 161252 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 161252] bibliography shows either number or short title in the entry not both

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161252

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Heiko Tietze  ---


*** This bug has been marked as a duplicate of bug 157064 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 161252] bibliography shows either number or short title in the entry not both

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161252

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Heiko Tietze  ---


*** This bug has been marked as a duplicate of bug 157064 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161377] Create an option to set ISO 8601 as the default date format for any locale.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161377

--- Comment #21 from Heiko Tietze  ---
Your idea of a checkbox or two radio buttons ("one option") limits the request
to either locale or ISO. But ISO 8601 is just one way to format date/time
values, and not only bug 46448 asks for more freedom but I can easily think of
a use case where people have a locale of Klingon but want to get date/time
values always in a specific format. While this particular request here is
limited, the dropdown with all available formats (plus Automatic or Locale
Default) is more flexible and is not detrimental on usability.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161441

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC|heiko.tietze@documentfounda |libreoffice-ux-advise@lists
   |tion.org|.freedesktop.org

--- Comment #13 from Heiko Tietze  ---
My take: WF/NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161441] UI: Hard to tell which side of a shape being used for as reference for rotation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161441

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC|heiko.tietze@documentfounda |libreoffice-ux-advise@lists
   |tion.org|.freedesktop.org

--- Comment #13 from Heiko Tietze  ---
My take: WF/NAB

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 161500] Click twice on the border of shape with small interval does enter the shape, instead of accessing rotation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161500

Heiko Tietze  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Heiko Tietze  ---
I don't think of a border as an extra clickable element. Vaguely I remember
opposite tickets maybe regarding frames in Writer. My take: NAB

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64028] Add option (or command) to retain source cell formatting in Calc when Ctrl + X is used to cut contents of a cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64028

--- Comment #31 from Heiko Tietze  ---
(In reply to Stéphane Guillou (stragu) from comment #30)
> Heiko, would you like to put this one on the UX/Design meeting agenda so
> others in the team can have a say?
I see no need for further discussion. Your summary is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161498] autocontour function is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161498

--- Comment #3 from pieter kristensen  ---
Created attachment 194638
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194638=edit
image with 100% transparent border. Text wrap contour activated.

This is a screenshot of LO with an inserted image with 100% transparent border
and 0% transparent center.
LO sees this image as rectangular.
Years ago I also worked with this functionality and then LO behaved as expected
and wrapped the text around the ellipse.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161498] autocontour function is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161498

--- Comment #2 from pieter kristensen  ---
I tried on a Windows machine with a recent version of LibreOffice. It behaved
the same as my linux machine. 
No autocontour function.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 144981] Insert Hyperlink dialog with artifacts in icons on the left bar (using gen/kf5/kf6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144981

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||1501

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 102495] [META] KDE (kf5) VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161501


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161501
[Bug 161501] The new vertical tabs do not look good under kf5 (poor contrast,
spacing of selection frame)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161501] The new vertical tabs do not look good under kf5 (poor contrast, spacing of selection frame)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161501

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4981
 Blocks||102495
 Status|UNCONFIRMED |NEW
Summary|The new vertical tabs do|The new vertical tabs do
   |not look good under kf5 |not look good under kf5
   ||(poor contrast, spacing of
   ||selection frame)
Version|unspecified |24.8.0.0 alpha1+ Master
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Reproduced in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 5a75414d1772d1fd998f405e3b9bd80b1f10c51f
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)

e.g. in Page Style dialog, characters touch the surrounding frame.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE (kf5) VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: desktop/source

[Andras Timar (via logerrit)]

 desktop/source/lib/init.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 719958306782ef7e79c2f0e07f621ba9a050a623
Author: Andras Timar 
AuthorDate: Fri Jun 7 10:56:45 2024 +0200
Commit: Andras Timar 
CommitDate: Tue Jun 11 06:37:01 2024 +0200

LOK: do not use deprecated .uno:BackColor

.uno:BackColor was deprecated in
be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928
which changed the label to
"Character Highlighting Color (deprecated - use CharBackColor)"
We do not want this label to appear in LOK based product.
The corresponding online patch set:
https://github.com/CollaboraOnline/online/pull/9225

Change-Id: Ieb780d278cd45bf82a2b4acee0abd17af2dc71eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168519
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit db27cd2246cfc54abd94885ce5edbdca69688af0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168616
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 464c2498cf9f..c8af7f847ee5 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3635,7 +3635,6 @@ static void doc_iniUnoCommands ()
 u".uno:AlignLeft"_ustr,
 u".uno:AlignHorizontalCenter"_ustr,
 u".uno:AlignRight"_ustr,
-u".uno:BackColor"_ustr,
 u".uno:BackgroundColor"_ustr,
 u".uno:TableCellBackgroundColor"_ustr,
 u".uno:Bold"_ustr,

[Bug 160462] F10 key is marked reserved, but doesn't do anything (kf5, gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160462

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||accessibility

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
(In reply to Buovjaga from comment #5)
> F10 opens the first menu for me with gtk3.
Which GNOME version?
With 42.9, focus doesn't leave the document for me.
And then we've got someone using 46.2 reporting first menu being focused but
not able to move to the next one with arrows:
https://listarchives.libreoffice.org/global/accessibility/msg01145.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 114423] [META] File export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114423

BogdanB  changed:

   What|Removed |Added

 Depends on||161453


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161453
[Bug 161453] Wrap text not exported to XLS/XLSX
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 87740] [META] Anchor and text wrapping bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87740

BogdanB  changed:

   What|Removed |Added

 Depends on||161453


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161453
[Bug 161453] Wrap text not exported to XLS/XLSX
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161453] Wrap text not exported to XLS/XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161453

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||114423, 87740


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87740
[Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114423
[Bug 114423] [META] File export bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108438] [META] Animated image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108438

BogdanB  changed:

   What|Removed |Added

 Depends on||161480


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161480
[Bug 161480] Animated gif renders with green artifacts with Skia/Raster & Metal
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161480] Animated gif renders with green artifacts with Skia/Raster & Metal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161480

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||108438


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108438
[Bug 108438] [META] Animated image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159146] Trouble redrawing background for comment column after changing width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159146

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||implementationError

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
kf5 also affected, see duplicate bug 159851.
Samuel, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159146] Trouble redrawing background for comment column after changing width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159146

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
*** Bug 159851 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 106179] [META] Writer comment bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106179

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|159851  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=159851
[Bug 159851] Redraw issue when resizing the comment width in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 159851] Redraw issue when resizing the comment width in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=159851

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks|106179  |
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=73 |
   |953 |
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 159146 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106179
[Bug 106179] [META] Writer comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] Spellcheck: "Correct All" does not correct all occurrences of misspelling throughout the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|There is a failure during   |Spellcheck: "Correct All"
   |spell checking, telling to  |does not correct all
   |“Change All”, not performs  |occurrences of misspelling
   |the function of correcting  |throughout the document
   |the Following words |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] There is a failure during spell checking, telling to “Change All”, not performs the function of correcting the Following words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||larrywbrad...@gmail.com

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
*** Bug 161245 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|161245  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161245
[Bug 161245] Correct All in Spelling Does Not Correct All (only up to next
spelling error)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161245] Correct All in Spelling Does Not Correct All (only up to next spelling error)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161245

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Blocks|96000   |
 Status|NEW |RESOLVED

--- Comment #5 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 91151 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|143231  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143231
[Bug 143231] Spellcheck: "correct all" replaces all same errors only up to the
next misspelling
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] There is a failure during spell checking, telling to “Change All”, not performs the function of correcting the Following words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||birnb...@posteo.de

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
*** Bug 143231 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143231] Spellcheck: "correct all" replaces all same errors only up to the next misspelling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143231

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks|96000   |
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
Marking as duplicate, see bug 91151 comment 3.

*** This bug has been marked as a duplicate of bug 91151 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] There is a failure during spell checking, telling to “Change All”, not performs the function of correcting the Following words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||sad_bu...@hotmail.com

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
*** Bug 126814 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 126814] Spell-check "correct all" disabled when parser encounters a different mis-spelling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126814

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #2 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 91151 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] There is a failure during spell checking, telling to “Change All”, not performs the function of correcting the Following words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
*** Bug 92545 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 92545] Spell Check "Correct All" Ignores final Word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92545

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |1245|
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
Let's consolidate this inherited issue into bug 91151.

*** This bug has been marked as a duplicate of bug 91151 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 92545, which changed state.

Bug 92545 Summary: Spell Check "Correct All" Ignores final Word
https://bugs.documentfoundation.org/show_bug.cgi?id=92545

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161245] Correct All in Spelling Does Not Correct All (only up to next spelling error)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161245

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=92 |
   |545 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 75922] EDITING: "Correct All" (Change All) button doesnt function correctly in spelling dialog (see comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75922

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||151

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||91151


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91151
[Bug 91151] There is a failure during spell checking, telling to “Change All”,
not performs the function of correcting the Following words
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 96000] [META] Spelling checking bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
Bug 96000 depends on bug 91151, which changed state.

Bug 91151 Summary: There is a failure during spell checking, telling to “Change 
All”, not performs the function of correcting the Following words
https://bugs.documentfoundation.org/show_bug.cgi?id=91151

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 91151] There is a failure during spell checking, telling to “Change All”, not performs the function of correcting the Following words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91151

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 OS|Linux (All) |All
 CC||so...@libreoffice.org,
   ||stephane.guillou@libreoffic
   ||e.org
 Ever confirmed|0   |1
   Hardware|x86-64 (AMD64)  |All
 Resolution|DUPLICATE   |---
 Status|RESOLVED|NEW
Version|4.4.3.2 release |Inherited From OOo
 Blocks||96000
  Component|Writer  |Linguistic
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=75
   ||922,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=46
   ||852,
   ||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=114441,
   ||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=110688

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Bug 46852 was about a different issue: using "Correct All" in combination with
"Continue checking at beginning of document", the spellcheck process concluding
prematurely. That was indeed fixed in LO 6.0.

The issue described by Anaya is different: pressing "Correct all" does not
correct all the same misspellings throughout the document (or at least, from
the active word to the end of the document). And this is still the case in a
recent daily build, as well as in OOo 3.3.

Bug 75922 alludes to this, but was tracking many different issues with Correct
All, so better keep that one as "resolved - works for me".

This bug here can be reproduce with the default English dictionaries, and the
following steps:

1. In a new Writer document, with document in any English variant, paste the
following paragraphs (unformatted):

dogg
dogg
catt dogg
frogg frogg
frogg catt dogg
dogg catt
frogg, dogg, catt

2. With cursor at beginning of document, start Tools > Spelling (F7)
3. Click "Correct All" for the suggestion "dogg -> dog"

Result A: first two paragraphs are corrected, not the rest.

4. Click "Close"

Result B: third paragraph is corrected, but not the rest.

Expected result: all occurrences of "dogg" are replaced by "dog" throughout the
document as soon as "Correct All" is pressed. This is the expectation according
to the documentation[1]:

"Replaces all occurrences of the unknown word with the current suggestion."

I haven't seen any evidence that the command shouldn't apply to the whole
document, and the feature should at least behave on par with the "Ignore All"
command, which ignores all occurrences instantly and removes the red underline,
before and after the current position.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 5a75414d1772d1fd998f405e3b9bd80b1f10c51f
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Same results in OOo 3.3.

Similar issue in Impress, see e.g. bugdoc[2] from AOO tracker[3].

[1]: https://help.libreoffice.org/24.8/en-US/text/shared/01/0601.html
[2]: https://bz.apache.org/ooo/attachment.cgi?id=68817
[3]: https://bz.apache.org/ooo/show_bug.cgi?id=110688


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96000
[Bug 96000] [META] Spelling checking bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161423] Writer v24.2.3.2 will not save the border on embedded image in a .docx document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161423

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161299] Impress: nondisplayed image(s) in existing .odp or 'Image filter not found' on Insert/Image...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161299

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158688] The lock file could not be created for exclusive access by LibreOffice, due to missing permission to create a lock file on that file location or lack of free disk space

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158688

--- Comment #2 from QA Administrators  ---
Dear John,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161423] Writer v24.2.3.2 will not save the border on embedded image in a .docx document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161423

--- Comment #12 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158622] CSV which contains #N/A, cannot read as #N/A(NaN, Not a Number)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158622

--- Comment #7 from QA Administrators  ---
Dear polyester,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158677] formula insertion screen bug??

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158677

--- Comment #2 from QA Administrators  ---
Dear alexis lechanteur,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158325] Option to start row at 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158325

--- Comment #5 from QA Administrators  ---
Dear simactest,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156205] Menus and other features appear blank in Calc Version: 7.5.4.2 (X86_64)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156205

--- Comment #18 from QA Administrators  ---
Dear Angie,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151092] LO 7.4.1 unable to create lock - opens Calc files in read only mode and impossible to "save as" or export as pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151092

--- Comment #2 from QA Administrators  ---
Dear mac,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 92944] FILESAVE Export to tif should allow choosing of resolution and other properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92944

--- Comment #8 from QA Administrators  ---
Dear Gérald Maruccia,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 89472] Table background overriden by background image in header

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89472

--- Comment #9 from QA Administrators  ---
Dear fabien.michel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 135322] FILEOPEN DOC: Text pushed down after moving an image upwards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135322

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133721] VIEWING: Arrows for cell resizing in table not showing if picture or shape is in background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133721

--- Comment #4 from QA Administrators  ---
Dear Markus,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57414] File Recovery: Don't save read-only files for recovery

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57414

--- Comment #25 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d5dc59d6ead1ba814c8dd1623330291375281e9b

tdf#57414 tdf#160769 autorecovery: keep open docs in RecoveryList

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57414] File Recovery: Don't save read-only files for recovery

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57414

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0 target:24.8.0 |target:24.2.0 target:24.8.0
   ||target:24.2.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - framework/source

[Justin Luth (via logerrit)]

 framework/source/services/autorecovery.cxx |   40 +
 1 file changed, 24 insertions(+), 16 deletions(-)

New commits:
commit d5dc59d6ead1ba814c8dd1623330291375281e9b
Author: Justin Luth 
AuthorDate: Mon Jun 10 15:50:29 2024 -0400
Commit: Mike Kaganski 
CommitDate: Tue Jun 11 04:59:17 2024 +0200

tdf#57414 tdf#160769 autorecovery: keep open docs in RecoveryList

This reverts parts of the LO 24.2 patches commited for bug 57414.

There were lots more vocal people than I expected
that want the crash-recovery to restore their session state.

Since there is no working alternative to trigger a session save,
just revert the bits that made the RecoveryList clean
(as I and other users had requested)
and revert back to the original, historic behaviour.

This means that now the following files will again be recovered:
- saved documents (opened from file URL)
- read-only documents (opened from file URL)
- files that were opened, but never modified (opened from file URL)
- files from now-potentially-unavailable disks/servers/temp-dirs
   - recovery will attempt to access those file URLs

At least one benefit remains:
- new, unmodified documents will not be in the RecoveryList

Maybe I'll look into a session save option for 25.2.

Change-Id: I2477f194bf94f14620d284728027846ec5b6119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168650
Reviewed-by: Justin Luth 
Tested-by: Jenkins
(cherry picked from commit 852cd511258e97a0df3b6fbe9fc0ae670c3fc843)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168619
Reviewed-by: Mike Kaganski 

diff --git a/framework/source/services/autorecovery.cxx 
b/framework/source/services/autorecovery.cxx
index 03936b54aee8..2a875ebb5969 100644
--- a/framework/source/services/autorecovery.cxx
+++ b/framework/source/services/autorecovery.cxx
@@ -110,24 +110,32 @@ using namespace css::lang;
 using namespace framework;
 
 /** After the fact documentation - hopefully it is correct.
+ *
+ * NOTE TO DEVELOPERS: instsetoo_native/ooenv sets the environment variable 
OOO_DISABLE_RECOVERY
+ * which means that your non-gdb execution of the compiled code will not 
display the recovery dialog
+ * and if officecfg::Office::Recovery::RecoveryList has some autosave files to 
recover,
+ * then autorecovery itself will not be started, and none of the code in this 
file will be executed.
+ * THEREFORE you probably want to COMMENT OUT that environment variable when 
working in this file.
  *
  * AutoRecovery handles 3 types of recovery, as well as periodic document 
saving
- *   1) timed, ODF, temporary, recovery files created in the backup folder
- *  -can instead be used to actually save the documents periodically if 
settings request that.
+ *   1a) timed, automatic saving of the documents (aka UserAutoSave)
+ *   or more commonly:
+ *   1b) timed, ODF, temporary recovery files created in the backup folder 
(default setting)
  *  -temporary: deleted when the document itself is saved
  *  -handles the situation where LO immediately exits (power outage, 
program crash, pkill -9 soffice)
- *  -not restored immediately
+ *  -not restored immediately (user needs to restart LibreOffice)
  *  -no guarantee of availability of recovery file (since deleted on 
document save)
- *   or original document (perhaps /tmp, removeable, disconnected 
server).
- *  -therefore does not include unmodified files in RecoveryList 
(@since LO 24.2).
- *-TODO: perhaps can be enhanced for users who always want 
sessions restored?
+ *   or original document (perhaps /tmp, removeable disk, disconnected 
server).
+ *  -TODO tdf#57414: if SessionSave not desired, don't recover 
unmodified files.
  *   2) emergency save-and-restart immediately triggers creation of temporary, 
ODF, recovery files
  *  -handles the situation where LO is partially functioning (pkill -6 
soffice)
  *  -restore attempted immediately, so try to restore entire session - 
all open files
  *  -always create recovery file for every open document in emergency 
situation
  *  -works without requiring AutoRecovery to be enabled
- *   3) session save on exit desired by OS or user creates recovery files for 
every open document
- *  -triggered by some OS's shutdown/logout (no known way for user to 
initiate within LO)
+ *   3) session save on exit requested by OS or user
+ *  -triggered by OS's shutdown/logout
+ *  -appears to be purely theoretical: no known working OS at the 
moment.
+ *  -also no known way for user to initiate within LO (tdf#146769)
  *  -same as emergency save, except maybe more time critical - OS kill 
timeout
  *  -not restored until much later - the user has stopped doing 
computer work
  *  -always create recovery file for every open 

[Bug 143231] Spellcheck: "correct all" replaces all same errors only up to the next misspelling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143231

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|6.4.7.2 release |Inherited From OOo
   Keywords|bibisectRequest |
Summary|Spellcheck: "correct all"   |Spellcheck: "correct all"
   |replaces only current   |replaces all same errors
   |occurrence (MacOS)  |only up to the next
   ||misspelling

--- Comment #8 from Stéphane Guillou (stragu) 
 ---
(In reply to birnb...@posteo.de from comment #7)
> Sorry, I cannot confirm.
> 
> "Lorem Lorem Lorem" --(correct all)--> 
> "Loren Loren Loren" (correct)
> 
> "Lorem Lorem ipsum [50 words more] Lorem" --(correct all)--> 
> "Loren Loren ipsum [50 words] Lorem" (partially correct)
Thank you. This is exactly what I described in comment 6: "Correct all"
corrects everything up to the next different misspelling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160675] UI: Sidebar doesn't show width and height (nor X/Y coordinates) of object depending on timing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160675

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |0428|
 CC||sai...@loonol.com

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
*** Bug 160428 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146606] Field "Position X" under "Position and size" right-sidebar sometimes is empty.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146606

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |0428|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160428] LibreOffice Draw Properties Position and Size often do not display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160428

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=14 |
   |6606,   |
   |https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=16 |
   |0675|

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Bug 160675 comment 10 shows that the issue depends on how quickly/slowly the
actions are performed.
Marking as duplicate, as there's a bibisect result there.

*** This bug has been marked as a duplicate of bug 160675 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160675] UI: Sidebar doesn't show width and height (nor X/Y coordinates) of object depending on timing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160675

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|UI: Sidebar doesn't show|UI: Sidebar doesn't show
   |width and height (nor X/Y   |width and height (nor X/Y
   |coordinates) of object in   |coordinates) of object
   |certain context |depending on timing
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7168

--- Comment #11 from Stéphane Guillou (stragu) 
 ---
(The commit is said in bug 155241 comment 8 to have been reverted for bug
157168, but that was only the gtk3-specific part. Bug is still present in
recent daily build.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160675] UI: Sidebar doesn't show width and height (nor X/Y coordinates) of object in certain context

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160675

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||caolan.mcnamara@collabora.c
   ||om
  Regression By|Justin Luth |Caolán McNamara
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||5241
Version|7.5.0.3 release |7.5.4.2 release

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
(In reply to Telesto from comment #9)
> @stragu
> Would you mind the recheck the bibisect result, to be sure.
Indeed, I can't confirm that it started at
2c813b3745e2da2001d318a60d911107bfefc32c as you report in comment 8 (build
[89c3572e790a4a1957045d00a2f7e7bf042bbb10] in linux-64-7.5, tested with gen
VCL). 

I bibisected to the earlier build [d08fb5e37e9d4bc1867e8fb0410c3741b35a0ae1],
which is:

commit  0d0841dc8faccc7d7d3d8d463916dd73a7c061a1
author  Caolán McNamara Thu May 11 16:03:57 2023 +0100
committer   Adolfo Jayme Barrientos Sun May 14 06:56:03 2023 +0200
tdf#155241 keep current MetricSpinButton value if unparseable junk input
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151617

The flakiness of previous bibisects is probably due to variations in timing. To
reproduce it consistently, wait a couple of seconds between each step.
- at commit:
   * follow steps quickly: values visible
   * wait between each step: fields empty
- at commit~1: always visible

Caolán, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155241] Calc: Column Width Accepts Invalid Input Resulting in Sheet Corruption

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155241

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0675

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/source

[Michael Weghorn (via logerrit)]

 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7d334ba7467d03e2d890e2926244f783d403878f
Author: Michael Weghorn 
AuthorDate: Mon Jun 10 14:08:15 2024 +0200
Commit: Michael Weghorn 
CommitDate: Tue Jun 11 03:15:43 2024 +0200

tdf#158914 sc a11y: Remember new cell text again

commit 5f9a955042822d05af5c04b2c852738c7e1e21a2
Author: Michael Weghorn 
Date:   Fri Jun 7 13:03:19 2024 +0200

tdf#158914 sc a11y: Send TEXT_CHANGED event when text changes

had made sending a `AccessibleEventId::VALUE_CHANGED` event
conditional on the cell having a *numerical* value.

Assigning the new string to `m_strCurCellValue`
should always happen independent of this, though,
as this is the string value, not the numerical
value.

Thanks to Patrick Luby for noting the difference
in [1].

[1] 
https://gerrit.libreoffice.org/c/core/+/167961/comment/1af95eb6_7db33e0b/

Change-Id: I1d1da2caeb7f2199251599313ec4412d7b6e47b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168635
Tested-by: Jenkins
Reviewed-by: Patrick Luby 
Reviewed-by: Michael Weghorn 

diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx 
b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
index 39998fa7fee6..1c27bbc94d81 100644
--- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
+++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
@@ -697,8 +697,9 @@ void ScAccessibleSpreadsheet::Notify( SfxBroadcaster& rBC, 
const SfxHint& rHint
 AccessibleEventObject aEvent;
 aEvent.EventId = 
AccessibleEventId::VALUE_CHANGED;
 mpAccCell->CommitChange(aEvent);
-m_strCurCellValue=valStr;
 }
+
+m_strCurCellValue = valStr;
 }
 OUString tabName;
 pScDoc->GetName( maActiveCell.Tab(), tabName );

[Bug 112970] [META] Document recovery bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112970
Bug 112970 depends on bug 160769, which changed state.

Bug 160769 Summary: LibreOffice 24.2 Document recovery (from timed autoSave) 
doesn't restore all open files after crash
https://bugs.documentfoundation.org/show_bug.cgi?id=160769

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77999] [META] Autosave/Autorecovery/Backup copy issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77999
Bug 77999 depends on bug 160769, which changed state.

Bug 160769 Summary: LibreOffice 24.2 Document recovery (from timed autoSave) 
doesn't restore all open files after crash
https://bugs.documentfoundation.org/show_bug.cgi?id=160769

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160769] LibreOffice 24.2 Document recovery (from timed autoSave) doesn't restore all open files after crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160769

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |
   Keywords||bibisected, bisected,
   ||regression
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #14 from Justin L  ---
(In reply to BikeHelmet from comment #6)
> That suggests that there is a bug here? If emergencySave is supposed to
> recover everything, and after a crash it doesn't, then clearly it crashed in
> such a way that it did not have a chance to do so, and is depending upon the
> timed autoRecovery instead?
Sure, that could be considered a bug. However, that is a huge, expert topic, so
I can't imagine anyone looking at it unless a company wants to pay tens of
thousands for that investigation.

Hmm - I see I didn't read comment 2 closely enough, which clearly stated that
"recent documents" was not adequate for that use case.

I decided to just revert my change and reopen bug 57414. Bug 146769 and its
duplicates are probably another good indicator that a large user segment may
not appreciate a clean RecoveryList. So best to just keep the status quo
instead of insisting on a controversial change.

Backport to 24.2 is in progress...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157899] open last session's documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157899

Justin L  changed:

   What|Removed |Added

Summary|open last session's |open last session's
   |documents (almost   |documents
   |implemented already)|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 77999] [META] Autosave/Autorecovery/Backup copy issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77999
Bug 77999 depends on bug 57414, which changed state.

Bug 57414 Summary: File Recovery: Don't save read-only files for recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=57414

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 112970] [META] Document recovery bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112970
Bug 112970 depends on bug 57414, which changed state.

Bug 57414 Summary: File Recovery: Don't save read-only files for recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=57414

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57414] File Recovery: Don't save read-only files for recovery

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=57414

Justin L  changed:

   What|Removed |Added

 Resolution|FIXED   |---
Summary|File Recovery: Don't save   |File Recovery: Don't save
   |read-only and empty files   |read-only files for
   |for recovery|recovery
 Status|RESOLVED|NEW
   Assignee|jl...@mail.com  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160769] LibreOffice 24.2 Document recovery (from timed autoSave) doesn't restore all open files after crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160769

--- Comment #13 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/852cd511258e97a0df3b6fbe9fc0ae670c3fc843

tdf#57414 tdf#160769 autorecovery: keep open docs in RecoveryList

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160769] LibreOffice 24.2 Document recovery (from timed autoSave) doesn't restore all open files after crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=160769

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: framework/source

[Justin Luth (via logerrit)]

 framework/source/services/autorecovery.cxx |   40 +
 1 file changed, 24 insertions(+), 16 deletions(-)

New commits:
commit 852cd511258e97a0df3b6fbe9fc0ae670c3fc843
Author: Justin Luth 
AuthorDate: Mon Jun 10 15:50:29 2024 -0400
Commit: Justin Luth 
CommitDate: Tue Jun 11 02:17:28 2024 +0200

tdf#57414 tdf#160769 autorecovery: keep open docs in RecoveryList

This reverts parts of the LO 24.2 patches commited for bug 57414.

There were lots more vocal people than I expected
that want the crash-recovery to restore their session state.

Since there is no working alternative to trigger a session save,
just revert the bits that made the RecoveryList clean
(as I and other users had requested)
and revert back to the original, historic behaviour.

This means that now the following files will again be recovered:
- saved documents (opened from file URL)
- read-only documents (opened from file URL)
- files that were opened, but never modified (opened from file URL)
- files from now-potentially-unavailable disks/servers/temp-dirs
   - recovery will attempt to access those file URLs

At least one benefit remains:
- new, unmodified documents will not be in the RecoveryList

Maybe I'll look into a session save option for 25.2.

Change-Id: I2477f194bf94f14620d284728027846ec5b6119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168650
Reviewed-by: Justin Luth 
Tested-by: Jenkins

diff --git a/framework/source/services/autorecovery.cxx 
b/framework/source/services/autorecovery.cxx
index 246d8438bbae..3e3d92ba6a63 100644
--- a/framework/source/services/autorecovery.cxx
+++ b/framework/source/services/autorecovery.cxx
@@ -110,24 +110,32 @@ using namespace css::lang;
 using namespace framework;
 
 /** After the fact documentation - hopefully it is correct.
+ *
+ * NOTE TO DEVELOPERS: instsetoo_native/ooenv sets the environment variable 
OOO_DISABLE_RECOVERY
+ * which means that your non-gdb execution of the compiled code will not 
display the recovery dialog
+ * and if officecfg::Office::Recovery::RecoveryList has some autosave files to 
recover,
+ * then autorecovery itself will not be started, and none of the code in this 
file will be executed.
+ * THEREFORE you probably want to COMMENT OUT that environment variable when 
working in this file.
  *
  * AutoRecovery handles 3 types of recovery, as well as periodic document 
saving
- *   1) timed, ODF, temporary, recovery files created in the backup folder
- *  -can instead be used to actually save the documents periodically if 
settings request that.
+ *   1a) timed, automatic saving of the documents (aka UserAutoSave)
+ *   or more commonly:
+ *   1b) timed, ODF, temporary recovery files created in the backup folder 
(default setting)
  *  -temporary: deleted when the document itself is saved
  *  -handles the situation where LO immediately exits (power outage, 
program crash, pkill -9 soffice)
- *  -not restored immediately
+ *  -not restored immediately (user needs to restart LibreOffice)
  *  -no guarantee of availability of recovery file (since deleted on 
document save)
- *   or original document (perhaps /tmp, removeable, disconnected 
server).
- *  -therefore does not include unmodified files in RecoveryList 
(@since LO 24.2).
- *-TODO: perhaps can be enhanced for users who always want 
sessions restored?
+ *   or original document (perhaps /tmp, removeable disk, disconnected 
server).
+ *  -TODO tdf#57414: if SessionSave not desired, don't recover 
unmodified files.
  *   2) emergency save-and-restart immediately triggers creation of temporary, 
ODF, recovery files
  *  -handles the situation where LO is partially functioning (pkill -6 
soffice)
  *  -restore attempted immediately, so try to restore entire session - 
all open files
  *  -always create recovery file for every open document in emergency 
situation
  *  -works without requiring AutoRecovery to be enabled
- *   3) session save on exit desired by OS or user creates recovery files for 
every open document
- *  -triggered by some OS's shutdown/logout (no known way for user to 
initiate within LO)
+ *   3) session save on exit requested by OS or user
+ *  -triggered by OS's shutdown/logout
+ *  -appears to be purely theoretical: no known working OS at the 
moment.
+ *  -also no known way for user to initiate within LO (tdf#146769)
  *  -same as emergency save, except maybe more time critical - OS kill 
timeout
  *  -not restored until much later - the user has stopped doing 
computer work
  *  -always create recovery file for every open document: needed for 
/tmp, disconnected docs
@@ -617,8 +625,9 @@ private:
  *EmergencySave and SessionSave are interested in all open 
documents (which may not

GSOC More and Better Tests: Weekly Update

[Adam Seskunas]

Hello everyone,

This is my weekly GSOC update, for week 3. Seems like time is flying by!

Last week I finished porting over some of the tests in 
framework/qa/complex/dispatches/checkdispatchapi.java. The Gerrit submission 
can be found here
https://gerrit.libreoffice.org/c/core/+/168482 


This patch covers the checkDispatchOfXXX tests, including the three database 
tests. The database tests and supporting code had been disabled for quite some 
time, so when the patch gets merged, the tests will hopefully be re-enabled 
after a long hiatus. 

While looking over the submission, Xisco noticed that something funny was 
happening with the Frames in each test, they aren’t getting closed out by the 
testing infrastructure. So after being alerted to this, I spent some time 
working on the issue and have gotten the non-database frames to close, but I’m 
currently blocked on getting the three database related frames to behave.

Next up, I’ve started working on porting over the last three tests in 
checkdispatchapi.java, checkInterceptorLifeTime(), checkInterception() and 
checkDispatchInfoOfBasic/StartModule(). The Interceptor tests have a class of 
supporting code, located in framework/qa/complex/dispatches/Interceptor.java. 
I’ve currently got the code for the class ported, but not in a functioning 
state. If all goes well with the supporting class, the porting of the tests 
should be done in the next two days. 

Next up would be framework/qa/complex/api_internal/CheckAPI.java, and after 
that I’m going to start working on writing some tests from the Missing Unit 
tests list. 

Cheers,
Adam Seskunas

core.git: svx/source

[Andrea Gelmini (via logerrit)]

 svx/source/sdr/overlay/overlayselection.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2254c416261c8001f002067c306c13b32adab5fa
Author: Andrea Gelmini 
AuthorDate: Mon Jun 10 21:42:29 2024 +0200
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Tue Jun 11 01:40:14 2024 +0200

Fix typo

Change-Id: I65fa0676119a2e52e23acddc564143cd1e519df1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168647
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/svx/source/sdr/overlay/overlayselection.cxx 
b/svx/source/sdr/overlay/overlayselection.cxx
index 963546145b46..232d6dcc487b 100644
--- a/svx/source/sdr/overlay/overlayselection.cxx
+++ b/svx/source/sdr/overlay/overlayselection.cxx
@@ -60,7 +60,7 @@ namespace sdr::overlay
 return aRetval;
 }
 
-// Creates an ORed polygon with all the ranges shriked by 1px
+// Creates an ORed polygon with all the ranges shrinked by 1px
 // This is used to draw the internal white line in the selection
 static basegfx::B2DPolyPolygon 
impCombineRangesToInternalPolyPolygon(const std::vector< basegfx::B2DRange >& 
rRanges)
 {

[Bug 161501] The new vertical tabs do not look good under kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161501

Rafael Lima  changed:

   What|Removed |Added

 Blocks||161497


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161497
[Bug 161497] META: Vertical Tab dialogs issues and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161497] META: Vertical Tab dialogs issues and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161497

Rafael Lima  changed:

   What|Removed |Added

 Depends on||161501


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161501
[Bug 161501] The new vertical tabs do not look good under kf5
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161501] New: The new vertical tabs do not look good under kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161501

Bug ID: 161501
   Summary: The new vertical tabs do not look good under kf5
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 194637
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194637=edit
Screenshots comparing gtk3 and kf5

Recently we had a change in some dialogs, that now use "vertical tabs" instead
of "horizontal tabs".

TBH they look quite nice using gtk3, and in this case they feel like an
improvement.

However, in kf5 they do not look good or appealing. They do not feel like an
improvement. Entries seem too squeezed or compressed... and there's no good
contrast for text as in gtk3.

Is there something we can do to improve the situation to render this in kf5?

See attached ODG with some examples

System info

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: dc243f0122ba656d2630e93bebfb84a2bfe4042a
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161492] Vertical Tab dialogs--Options column in Area section is not wide enough in paragraph style dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161492

--- Comment #2 from Rafael Lima  ---
On kf5 I get some errors like these, but not identical to yours (since you're
on Windows, the result will differ a bit).

For instance, in "Text flow" - "Hyphenation" I get some labels cut out because
there's not enough space.

But in the "Area" section I don't get any issues.

Tested with (built from master today)

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: dc243f0122ba656d2630e93bebfb84a2bfe4042a
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64028] Add option (or command) to retain source cell formatting in Calc when Ctrl + X is used to cut contents of a cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64028

--- Comment #30 from Stéphane Guillou (stragu) 
 ---
Thanks Ady for the comment.

(In reply to ady from comment #28)
> IMNSHO, suggesting that "cut" in a spreadsheet tool could be defined in a
> different way, or that the resulting action could be different than it has
> always been, is not acceptable.
I definitely understand that the default shouldn't be changed, and also agree
that we shouldn't even allow to change the default with an Options dialog tick
box.

> All spreadsheet tools define the actions of
> cut/copy/move/paste/reference/link in the same way, with the difference
> being in method/UX (and in some cases, formula's syntax), but not in what
> these actions actually do.
We offer plenty of paste customisation, so I am not too surprised that users
might expect some customisation options for what cutting does. One might think
"I'm able to paste without formatting, so why should the formatting always be
taken away by a cutting action?"

> Considering that:
> * there are (more-than-one) alternative ways to achieve the goal, and
> that... 
> * when users gain more experience with spreadsheets then the need for this
> kind of layout corrections tend to be less frequent... 
> ...IMHO the issue in question does not deserve more time from LO developers.
> There are many other aspects of Calc that are much more relevant (for
> users), and that have no current alternative available in Calc.
The enhancement request is of "low" priority currently, and could be an
easyHack.

(In reply to Cor Nouws from comment #29)
> There are situations where encouraging the reporter/user having better
> understanding/explaining where to get that, is a much better way to handle*,
> than trying to find a 'solution' which is somehow weird/against the natural
> use.
> This bug, with the simple available options to do what the initial request
> appeared to be, and the extra additional/different issue in comment 18, IMO
> fits into that category, where proper understanding is the best help
> possible.
Of course, but:
- we have to be careful not be pedantic about "this is how things should be
done", especially when users repeatedly hit their head against something (which
is the case here)
- the bug was closed in comment 19 as "works for me", which should be for
"there was a bug but it has somehow vanished". I understand that was based on a
misunderstanding, focusing on only the paste step, which wasn't the focus
anymore.

If not offering an extra UNO command is what the community, and in particular
the Design team, prefers, I'm perfectly fine with that. But in that case, let's
close as "won't fix" with a recommendation to use macro and/or develop as
extension.

Heiko, would you like to put this one on the UX/Design meeting agenda so others
in the team can have a say?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - sfx2/source

[Michael Stahl (via logerrit)]

 sfx2/source/doc/objmisc.cxx |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit d6b881627cc1f6982129862e0221da65389d83bf
Author: Michael Stahl 
AuthorDate: Wed Jun 5 18:53:05 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Tue Jun 11 00:50:23 2024 +0200

tdf#157931 sfx2: fix modified status of Base forms

The problem is that when a Base form is not in design mode, it's not
expected that it will be stored.

There are checks for m_bOpenInDesign in ODocumentDefinition::save() and
ODocumentDefinition::saveAs() that were added in commit
9cfe62966ff1e0039d95a07d0c613675a53e3075 "CWS dba201b" but removing
these runs into another check in OCommonEmbeddedObject::storeOwn()
of m_bReadOnly and then it still fails, presumably because the storage
was opened readonly.

Let's restore SfxObjectShell::IsEnableSetModified() to check
IsReadOnly(), but only for Base form documents, which seems simplest.

(regression from commit bde746141f9b382156a5ce79ebf82c5e32fc455b)

Change-Id: I886389e2bd462d27ed5c46bfd2132893bb2d5a81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168481
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 3e7478ef9706e74ac551c1f94090e163e74c7fd8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168442
Reviewed-by: Thorsten Behrens 

diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 234ae799caeb..9ef1469687b3 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -256,7 +256,13 @@ bool SfxObjectShell::IsEnableSetModified() const
 // which the user didn't load or activate to modified.
 return pImpl->m_bEnableSetModified && !IsPreview()
 && eCreateMode != SfxObjectCreateMode::ORGANIZER
-&& eCreateMode != SfxObjectCreateMode::INTERNAL;
+&& eCreateMode != SfxObjectCreateMode::INTERNAL
+// tdf#157931 form documents only in design mode
+&& ((pImpl->pBaseModel
+&& !pImpl->pBaseModel->impl_isDisposed()
+&& pImpl->pBaseModel->IsInitialized()
+&& pImpl->pBaseModel->getIdentifier() != 
"com.sun.star.sdb.FormDesign")
+|| !IsReadOnly());
 }
 
 

core.git: sw/source

[Justin Luth (via logerrit)]

 sw/source/filter/ww8/docxattributeoutput.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 468b17bd06e56b406f5651d7f0e9c7bef54090e0
Author: Justin Luth 
AuthorDate: Sat Jun 8 20:51:26 2024 -0400
Commit: Justin Luth 
CommitDate: Tue Jun 11 00:50:03 2024 +0200

NFC docxattributeoutput loop: skip if empty, exit early if duplicate

No need to loop through all of the textboxes
if the rName.isEmpty() since that is never accepted as a duplicate.
As soon as a valid duplicate is found,
we can quit search the rest.

Change-Id: I785c2cf4cc619fc45fc2b95f492fe1b5ff0f1a55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168582
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 97a4c038c736..1d3c806843af 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -6329,15 +6329,19 @@ void DocxAttributeOutput::WriteFlyFrame(const 
ww8::Frame& rFrame)
 // The frame output is postponed to the end of the anchor 
paragraph
 bool bDuplicate = false;
 const OUString& rName = rFrame.GetFrameFormat().GetName();
-unsigned nSize = m_aFramesOfParagraph.size() ? 
m_aFramesOfParagraph.top().size() : 0;
-for( unsigned nIndex = 0; nIndex < nSize; ++nIndex )
+if (m_aFramesOfParagraph.size() && !rName.isEmpty())
 {
-const OUString& rNameExisting = 
m_aFramesOfParagraph.top()[nIndex].GetFrameFormat().GetName();
-
-if (!rName.isEmpty() && !rNameExisting.isEmpty())
+const unsigned nSize = m_aFramesOfParagraph.top().size();
+for (unsigned nIndex = 0; nIndex < nSize; ++nIndex)
 {
+const OUString& rNameExisting
+= 
m_aFramesOfParagraph.top()[nIndex].GetFrameFormat().GetName();
+
 if (rName == rNameExisting)
+{
 bDuplicate = true;
+break;
+}
 }
 }
 

Re: GSoC: Libreoffice Theme (application crashes when I modify ColorConfig on startup)

[Sahil Gautam]

Hi
went through the design of data flow this week. I found myself running away 
from the VCL
and it's colors, or rather from the question of "how to get 2 way exchange of colors 
working".

https://gerrit.libreoffice.org/c/core/+/168016  Here's the patch [WIP]

There is quite some information to keep in the head, I would try to briefly 
describe it.

- So we get colors out of the widget toolkits using the updateSettings() 
functions.
- We have ColorConfig() which gives access to the ExpertConfiguration colors 
(or colors in the registry).
- We cannot access ColorConfig inside updateSettings() functions in the VCL 
(because vcl can't depend on svt).

My plan was to (and still is) to load the registry colors in the StyleSettings 
object when ColorConfig is
created (in the constructor), and mark a flag in the StyleSettings that the 
Theme is Loaded.
Note that I want to keep the ThemeColors object and the bLoaded flag as static 
in the StyleSettings.
The reasons are:

a) this feels right, as the ThemeColors are object independent and depend only 
on the ExpertConfiguration.
b) this way, I evade the various SetStyleSettings() calls. Otherwise, at the 
end, there would be some
   call which overwrites the ThemeColors.

So for a user using some custom theme, it the flow goes this way:
- When the ColorConfig is created, the colors are loaded into the static 
ThemeColors object in StyleSettings,
  and a flag is marked (theme colors loaded)
- Then in each VCLPLUGIN's updateSettings(AllSettings&), we overwrite the 
colors from the toolkit, and put
  them into the AllSettings object passed as argument. So the theme colors from 
the registry went to all
  the parts which will be using the StyleSettings.Get...Color() functions.
- Then I have to add some code, which will send back those colors to the 
toolkit[PENDING].
Seems to work fine.

But the issue comes when the user is using the default theme.
Where would I fill the registry entries from? If I hardcode some values for 
Automatic scheme,
then what's the point of reading system colors. So I thought what if I mark a 
flag in the StyleSettings
(not static) when I have read the colors from the toolkit once, and then I will 
check for that flag
in the ColorConfig constructor. Along with this I added a registry flag for if 
the SystemColors
are loaded into the ExpertConfiguration or not.

The idea is to load the system colors into the registry for theme colors (for 
automatic scheme)
once, when the application is started for the first time. then I set that 
registry setting as colors
are loaded, no need to load when the application starts again. This way the 
user's preferences for the
Automatic scheme won't be overwritten. **The application is crashing on startup 
when I tried this**.

TL;DR version

Custom theme:
Defaults come from the theme, and after that StyleSettings keeps an 
updated
copy of the registry, which is used for the to-and-fro of colors.

Default System Theme:
System Colors are loaded from the StyleSettings into the registry
on the first startup, then after that an updated copy of the registry
in the StyleSettings is used for the to-and-fro...(same as above)

Problem: When the ColorConfig() constructor is called first, I try to write the 
colors into the
 registry (via ColorConfig_Impl), but some listeners fire up, and the 
application crashes.

If you know of any other approach to get a 2 way color communication between 
the registry and the
VCLs, then please share. I thought of using the UNO api to access the registry 
values (seems possible),
but then what's the point of having ColorConfig, I thought.

Regards
Sahil Gautam

[Bug 161494] becomes unresponsive

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161494

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
Please attach a sample file, reduce the size as much as possible without
private information, and paste the information in Menu/Help/About LibreOffice,
there is a copy icon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161493] Creating a simple pivot table with 2x2 data fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=161493

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #4 from m_a_riosv  ---
Please attach a sample file, reduce the size as much as possible without
private information.

-- 
You are receiving this mail because:
You are the assignee for the bug.