License statement
Hi! I hereby confirm that all my past and future contributions to LibreOffice, until I state otherwise, are licensed under LGPLv3+/MPLv1.1+. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][PATCH] Remove unused code in drawingml
On Wed, Mar 14, 2012 at 6:46 PM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2012-03-14 at 02:05 +0200, Mariana Marasoiu wrote: Hi! These patches remove unused code as listed in unusedcode.easy Looks good, pushed now. Thanks for these. If I'm not wrong, this is you first submission ? If so, can you add yourself to http://wiki.documentfoundation.org/Development/Developers and confirm that your code is submitted under the preferred LGPLv3+/MPLv1.1+ combo ? Its typical to do a sort of blanket, all patches until I state otherwise, should be links to examples on the above wiki page. Yes, this was my first submission :D. I sent a mail regarding the license, and also modified the wiki page. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove unused code in drawingml
Hi! These patches remove unused code as listed in unusedcode.easy Mariana Marasoiu From 2fa32c691f2af987bb32bff8b9b3f940c90b08aa Mon Sep 17 00:00:00 2001 From: Mariana Marasoiu mariana.maras...@gmail.com Date: Wed, 14 Mar 2012 01:07:16 +0200 Subject: [PATCH 1/4] Remove unused code in drawingml. --- oox/inc/oox/drawingml/customshapeproperties.hxx |1 - oox/source/drawingml/customshapeproperties.cxx | 10 -- unusedcode.easy |1 - 3 files changed, 0 insertions(+), 12 deletions(-) diff --git a/oox/inc/oox/drawingml/customshapeproperties.hxx b/oox/inc/oox/drawingml/customshapeproperties.hxx index 5fd6cd0..1b88ed3 100644 --- a/oox/inc/oox/drawingml/customshapeproperties.hxx +++ b/oox/inc/oox/drawingml/customshapeproperties.hxx @@ -155,7 +155,6 @@ public: voidsetMirroredY( sal_Bool bMirroredY ) { mbMirroredY = bMirroredY; }; voidsetTextRotateAngle( sal_Int32 nAngle ) { mnTextRotateAngle = nAngle; }; -double getValue( const std::vector CustomShapeGuide , sal_uInt32 nIndex ) const; static sal_Int32 SetCustomShapeGuideValue( std::vector CustomShapeGuide rGuideList, const CustomShapeGuide rGuide ); static sal_Int32 GetCustomShapeGuideValue( const std::vector CustomShapeGuide rGuideList, const rtl::OUString rFormulaName ); diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx index 29844b8..071f37a 100644 --- a/oox/source/drawingml/customshapeproperties.cxx +++ b/oox/source/drawingml/customshapeproperties.cxx @@ -359,16 +359,6 @@ void CustomShapeProperties::pushToPropSet( const ::oox::core::FilterBase /* rFi } } -double CustomShapeProperties::getValue( const std::vector CustomShapeGuide rGuideList, sal_uInt32 nIndex ) const -{ -double fRet = 0.0; -if ( nIndex rGuideList.size() ) -{ - -} -return fRet; -} - Any CustomShapeProvider::createStringSequence( size_t nStrings, const char **pStrings ) { Sequence OUString aStringSequence( nStrings ); diff --git a/unusedcode.easy b/unusedcode.easy index 77ae5b4..b2450c7 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -907,7 +907,6 @@ oox::drawingml::ChartExport::exportXAxis(oox::drawingml::AxisIdPair) oox::drawingml::ChartExport::exportYAxis(oox::drawingml::AxisIdPair) oox::drawingml::ColorPropertySet::getColor() oox::drawingml::ColorPropertySet::setColor(int) -oox::drawingml::CustomShapeProperties::getValue(std::__debug::vectoroox::drawingml::CustomShapeGuide, std::allocatoroox::drawingml::CustomShapeGuide const, unsigned int) const oox::drawingml::DiagramLayout::layout(std::__debug::vectoroox::drawingml::dgm::Point, std::allocatoroox::drawingml::dgm::Point const, com::sun::star::awt::Point const) oox::drawingml::GraphicProperties::assignUsed(oox::drawingml::GraphicProperties const) oox::drawingml::TextBodyProperties::pushToPropMap(oox::PropertyMap) const -- 1.7.0.4 From 9e68e6fdf658f4c11bb4ac93402d402544a9d0d1 Mon Sep 17 00:00:00 2001 From: Mariana Marasoiu mariana.maras...@gmail.com Date: Wed, 14 Mar 2012 01:15:11 +0200 Subject: [PATCH 2/4] Remove unused code in drawingml/diagram. --- oox/source/drawingml/diagram/diagram.cxx |3 --- oox/source/drawingml/diagram/diagram.hxx |2 -- unusedcode.easy |1 - 3 files changed, 0 insertions(+), 6 deletions(-) diff --git a/oox/source/drawingml/diagram/diagram.cxx b/oox/source/drawingml/diagram/diagram.cxx index 58c8de8..8e6586d 100644 --- a/oox/source/drawingml/diagram/diagram.cxx +++ b/oox/source/drawingml/diagram/diagram.cxx @@ -95,9 +95,6 @@ void DiagramData::dump() boost::bind( dgm::Point::dump, _1 ) ); } -void DiagramLayout::layout( const dgm::Points /*pTree*/, const awt::Point /*pt*/ ) -{ -} void Diagram::setData( const DiagramDataPtr pData) { diff --git a/oox/source/drawingml/diagram/diagram.hxx b/oox/source/drawingml/diagram/diagram.hxx index 633f452..0e5bfef 100644 --- a/oox/source/drawingml/diagram/diagram.hxx +++ b/oox/source/drawingml/diagram/diagram.hxx @@ -237,8 +237,6 @@ public: const DiagramDataPtr getStyleData() const { return mpStyleData; } -void layout( const dgm::Points pTree, const com::sun::star::awt::Point pt ); - private: ::rtl::OUString msDefStyle; ::rtl::OUString msMinVer; diff --git a/unusedcode.easy b/unusedcode.easy index b2450c7..e357027 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -907,7 +907,6 @@ oox::drawingml::ChartExport::exportXAxis(oox::drawingml::AxisIdPair) oox::drawingml::ChartExport::exportYAxis(oox::drawingml::AxisIdPair) oox::drawingml::ColorPropertySet::getColor() oox::drawingml::ColorPropertySet::setColor(int) -oox::drawingml::DiagramLayout::layout(std::__debug::vectoroox::drawingml::dgm::Point, std::allocatoroox::drawingml::dgm::Point const, com::sun::star::awt::Point const) oox::drawingml::GraphicProperties::assignUsed
Re: GSoC error during make
On Thu, Mar 8, 2012 at 11:47 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Thu, Mar 8, 2012 at 3:31 AM, Michael Meeks michael.me...@suse.com wrote: On Thu, 2012-03-08 at 01:00 +0200, Mariana Marasoiu wrote: Okay, bad news... I still couldn't build LibreOffice :(. :-) sorry for the trouble. One of the best ways to get a working build is to use IRC, and appear in the #libreoffice-dev on irc.freenode.net and get some interactive help (it may be quicker), we're quite friendly there tend not to bite (at least newbies :-) I strongly recommend http://workaround.org/getting-help-on-irc if you are not familiar with IRC... that will help you to have an even nicer experience :-) Norbert Thank you for your support and I want to let you know that I have now a working build, after my laptop pulled an all-nighter :D. Indeed, I am not familiar with IRC, but I'll give it a try. Thanks again! Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GSoC error during make
On Tue, Mar 6, 2012 at 3:17 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Mon, Mar 5, 2012 at 6:20 PM, Mariana Marasoiu mariana.maras...@gmail.com wrote: On Sun, Mar 4, 2012 at 7:08 PM, Mariana Marasoiu --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/mariana/Working/git/libo/helpcontent2/source/auxiliary it seems that the error is inside 'helpcontent2', please re-run build inside this module to isolate the error and/or test your fix: --- /bin/bash cd /home/mariana/Working/git/libo source ./Env.Host.sh cd helpcontent2 rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro # optional module 'clean' build What version are you trying to build ? this message seems to indicate something more than a month old Well, I am trying to build the master branch of the git repo. The thing is that message above, especially the part about 'source ./Env.Host.sh does not exist in master since February 5th (see solenv/bin/build.pl) Today I made a simple git pull to get the latest changes, and then ran make again, but with the same result. the problem may be that you dd a git pull and not a ./g pull -r ? I did yesterday a ./g pull -r but it didn't fix the build. Afterwards, I tried a make clean make, which ended with the same result. I followed Korrawit's instructions and realised that the branch I was trying to build wasn't the master, but libreoffice-3-5. So I switched to master, did ./g pull -r and now it's building once again. Lets hope this time works :D In any case... you mentionned http://wiki.documentfoundation.org/Development/How_to_build I supposed you read http://wiki.documentfoundation.org/Development/How_to_build#The_Build_Failed..._What_can_I_do.C2.A0.3F and particularely the part: [...] ERROR: error 65280 occurred while making /lo/libo/connectivity/source/cpool it seems that the error is inside 'connectivity', please re-run build inside this module to isolate the error and/or test your fix: --- [...] make: *** [all] Error 1 First things: do not post that on the mailing list. The only useful information in all this is that the module 'connectivity' could not be built for some yet unknown reason. [..] To my shame, I skipped the part where it said I shouldn't be posting that on the list. I'm sorry about that and next time I'l make sure I'll read more carefully the documentation before posting. Thanks for pointing it out! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GSoC error during make
On Wed, Mar 7, 2012 at 7:17 PM, Mariana Marasoiu mariana.maras...@gmail.com wrote: I did yesterday a ./g pull -r but it didn't fix the build. Afterwards, I tried a make clean make, which ended with the same result. I followed Korrawit's instructions and realised that the branch I was trying to build wasn't the master, but libreoffice-3-5. So I switched to master, did ./g pull -r and now it's building once again. Lets hope this time works :D Okay, bad news... I still couldn't build LibreOffice :(. It fails in two modules: officecfg and sal. I tried building them separately, with a make clean before that, but I still get errors... This is what I get for officecfg: cd officecfg make -j 1 -rs gb_PARTIALBUILD=T [ build XCS ] officecfg/registry/schema/org/openoffice/Setup.xcs /home/mariana/Working/git/libo/solver/unxlngi6.pro/xml/processing/schema_val.xsl:1: parser error : Document is empty ^ /home/mariana/Working/git/libo/solver/unxlngi6.pro/xml/processing/schema_val.xsl:1: parser error : Start tag expected, '' not found ^ cannot parse /home/mariana/Working/git/libo/solver/unxlngi6.pro/xml/processing/schema_val.xsl make[1]: *** [/home/mariana/Working/git/libo/workdir/unxlngi6.pro/XcsTarget/officecfg/registry/schema/org/openoffice/Setup.xcs] Error 4 make: *** [officecfg] Error 2 And for sal module, there are lots of C++ errors and warnings and also No such file or directory errors. If I should post the output, tell me and I'll put it in a pastebin. Thanks, Mariana Mărășoiu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: GSoC error during make
On Mon, Mar 5, 2012 at 3:42 AM, Norbert Thiebaud nthieb...@gmail.com wrote: On Sun, Mar 4, 2012 at 7:08 PM, Mariana Marasoiu mariana.maras...@gmail.com wrote: Hello everyone! I'm Mariana Mărășoiu from Romania and I am a second-year student at Politehnica University of Bucharest, Automatic Controls and Computers Faculty. I would like to participate in Google Summer of Code this year and I want to work on a project in LibreOffice. I wanted to start with an EasyHack, and I tried first of all to build LibreOffice. I cloned the git code [1] and installed all dependencies that were required before running make. But during make, it stops with the following error message: --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/mariana/Working/git/libo/helpcontent2/source/auxiliary it seems that the error is inside 'helpcontent2', please re-run build inside this module to isolate the error and/or test your fix: --- /bin/bash cd /home/mariana/Working/git/libo source ./Env.Host.sh cd helpcontent2 rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro # optional module 'clean' build What version are you trying to build ? this message seems to indicate something more than a month old Well, I am trying to build the master branch of the git repo. I followed the tutorial here [1] and I used this command to get the code: git clone git://anongit.freedesktop.org/libreoffice/core libo Today I made a simple git pull to get the latest changes, and then ran make again, but with the same result. [1] http://wiki.documentfoundation.org/Development/How_to_build ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
GSoC error during make
Hello everyone! I'm Mariana Mărășoiu from Romania and I am a second-year student at Politehnica University of Bucharest, Automatic Controls and Computers Faculty. I would like to participate in Google Summer of Code this year and I want to work on a project in LibreOffice. I wanted to start with an EasyHack, and I tried first of all to build LibreOffice. I cloned the git code [1] and installed all dependencies that were required before running make. But during make, it stops with the following error message: --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/mariana/Working/git/libo/helpcontent2/source/auxiliary it seems that the error is inside 'helpcontent2', please re-run build inside this module to isolate the error and/or test your fix: --- /bin/bash cd /home/mariana/Working/git/libo source ./Env.Host.sh cd helpcontent2 rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro # optional module 'clean' build when the problem is isolated and fixed exit and re-run 'make' from the top-level make[1]: *** [build] Error 1 make[1]: Leaving directory `/home/mariana/Working/git/libo' make: *** [source-env-and-recurse] Error 2 I re-ran build inside the module as specified in the message, but all I got was another error message: = (1/1) Building module helpcontent2 = Entering /home/mariana/Working/git/libo/helpcontent2/source/auxiliary Processing en-US ../../unxlngi6.pro/misc/en-US/simpress.tree is illformed xml ( on linux) update_tree.pl all languages in WITH_LANG are processed. WITH_LANG=ALL is not supported in manual calls. Updates the *.tree files. At first, the English file is updated based on the English help topic titles as read from the help files. Then, the localized tree files are written based on the English tree file and the localized help topic titles. Requires a valid LibreOffice build environment. dmake: Error code 255, while making '../../unxlngi6.pro/misc/treefiles.done' --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/mariana/Working/git/libo/helpcontent2/source/auxiliary it seems that the error is inside 'helpcontent2', please re-run build inside this module to isolate the error and/or test your fix: --- /bin/bash cd /home/mariana/Working/git/libo source ./Env.Host.sh cd helpcontent2 rm -Rf /home/mariana/Working/git/libo/helpcontent2/unxlngi6.pro # optional module 'clean' build when the problem is isolated and fixed exit and re-run 'make' from the top-level I don't know what should I do next. I tried googling the error, but came up with nothing conclusive. I was hoping you could help me fix this and finish building LibreOffice so I could start hacking :D. Thank you, Mariana Mărășoiu [1] git://anongit.freedesktop.org/libreoffice/core ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice